Build applications that make decisions (chatbots, agents, simulations, etc...). Monitor, trace, persist, and execute on your own infrastructure.
Python aiburrchatbot-frameworkdagsgenerative-aigraphshacktoberfestllmopsllmsmlopspersistent-data-structurestate-machinestate-managementvisibility
fix(testing): read test case json as utf-8 (#872)
Rolly Calmaecb6f0accd16
diff --git a/burr/cli/__main__.py b/burr/cli/__main__.pyindex 5bbc99dd..8967602d 100644--- a/burr/cli/__main__.py+++ b/burr/cli/__main__.py@@ -477,14 +477,14 @@ def create_test_case(if target_file_name:# if it already exists, load it up and append to itif os.path.exists(target_file_name):- with open(target_file_name, "r") as f:+ with open(target_file_name, "r", encoding="utf-8") as f:# assumes it's a list of test casescurrent_testcases = json.load(f)current_testcases.append(tc_json)else:current_testcases = [tc_json]print(f"\nWriting data to file {target_file_name}")- with open(target_file_name, "w") as f:+ with open(target_file_name, "w", encoding="utf-8") as f:json.dump(current_testcases, f, indent=2)else:logger.info(json.dumps(tc_json, indent=2))diff --git a/burr/testing/__init__.py b/burr/testing/__init__.pyindex f1caa19b..bd89af77 100644--- a/burr/testing/__init__.py+++ b/burr/testing/__init__.py@@ -26,7 +26,7 @@ import json# and then load it for the test.def load_test_cases(file_name: str) -> tuple:"""Load test cases from a json file."""- with open(file_name, "r") as f:+ with open(file_name, "r", encoding="utf-8") as f:json_test_cases = json.load(f)test_cases = [(tc.get("input_state"), tc.get("expected_state")) for tc in json_test_cases]test_ids = [diff --git a/tests/test_testing.py b/tests/test_testing.pynew file mode 100644index 00000000..3c8224d8--- /dev/null+++ b/tests/test_testing.py@@ -0,0 +1,43 @@+# Licensed to the Apache Software Foundation (ASF) under one+# or more contributor license agreements. See the NOTICE file+# distributed with this work for additional information+# regarding copyright ownership. The ASF licenses this file+# to you under the Apache License, Version 2.0 (the+# "License"); you may not use this file except in compliance+# with the License. You may obtain a copy of the License at+#+# http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing,+# software distributed under the License is distributed on an+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+# KIND, either express or implied. See the License for the+# specific language governing permissions and limitations+# under the License.++import json++from burr.testing import load_test_cases+++def test_load_test_cases_reads_utf8_json(tmp_path):+ test_case_file = tmp_path / "test_cases.json"+ test_case_file.write_text(+ json.dumps(+ [+ {+ "action": "summarize",+ "name": "handles_utf8",+ "input_state": {"message": "café"},+ "expected_state": {"response": "résumé"},+ }+ ],+ ensure_ascii=False,+ ),+ encoding="utf-8",+ )++ test_cases, test_ids = load_test_cases(str(test_case_file))++ assert test_cases == [({"message": "café"}, {"response": "résumé"})]+ assert test_ids == ["summarize-handles_utf8"]