Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
package tidb
import (
"context"
"fmt"
"github.com/bytebase/omni/tidb/ast"
storepb "github.com/bytebase/bytebase/backend/generated-go/store"
"github.com/bytebase/bytebase/backend/plugin/advisor"
"github.com/bytebase/bytebase/backend/plugin/advisor/code"
"github.com/bytebase/bytebase/backend/plugin/parser/base"
)
var (
_ advisor.Advisor = (*ColumnDisallowChangingAdvisor)(nil)
)
func init() {
advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE, &ColumnDisallowChangingAdvisor{})
}
// ColumnDisallowChangingAdvisor is the advisor checking for disallow CHANGE COLUMN statement.
type ColumnDisallowChangingAdvisor struct {
}
// Check checks for disallow CHANGE COLUMN statement.
func (*ColumnDisallowChangingAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {
stmts, err := getTiDBOmniNodes(checkCtx)
if err != nil {
return nil, err
}
level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)
if err != nil {
return nil, err
}
title := checkCtx.Rule.Type.String()
var adviceList []*storepb.Advice
for _, ostmt := range stmts {
alter, ok := ostmt.Node.(*ast.AlterTableStmt)
if !ok {
continue
}
// Single-advice-per-statement contract: pingcap-tidb's Visitor
// broke after the first match; preserve via firstAlterCommandMatching
// (the helper returns the first index satisfying the matcher).
// Mysql analog emits per-cmd without breaking — cardinality
// divergence preserved on the tidb side per invariant #7.
if firstAlterCommandMatching(alter, func(cmd *ast.AlterTableCmd) bool {
return cmd.Type == ast.ATChangeColumn
}) >= 0 {
adviceList = append(adviceList, &storepb.Advice{
Status: level,
Code: code.UseChangeColumnStatement.Int32(),
Title: title,
Content: fmt.Sprintf("\"%s\" contains CHANGE COLUMN statement", ostmt.TrimmedText()),
StartPosition: base.ConvertANTLRLineToPosition(ostmt.AbsoluteLine(alter.Loc.Start)),
})
}
}
return adviceList, nil
}