Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

2.4 KB
Raw Blame
package starrocks

import (
	"testing"

	metadatapb "github.com/bytebase/omni/metadata"
	"github.com/stretchr/testify/require"

	"github.com/bytebase/bytebase/backend/plugin/db"
)

// BYT-9689: StarRocks reports materialized views in information_schema.tables with
// TABLE_TYPE='VIEW' and omits them from information_schema.views (verified on a live
// 3.4.10 BE-alive smoke test), so the table type alone cannot identify one. Membership
// in the materialized-view set is the authoritative signal, whatever type the row carries.
func TestIsMaterializedView(t *testing.T) {
	mvMap := map[db.TableKey]*metadatapb.MaterializedViewMetadata{
		{Schema: "", Table: "mv_async"}: {Name: "mv_async"},
	}
	mvKey := db.TableKey{Schema: "", Table: "mv_async"}

	require.True(t, isMaterializedView(viewTableType, mvKey, mvMap))
	require.True(t, isMaterializedView(materializedViewType, mvKey, mvMap))
	require.True(t, isMaterializedView(baseTableType, mvKey, mvMap))

	// A name absent from the MV set is never a materialized view.
	require.False(t, isMaterializedView(viewTableType, db.TableKey{Table: "v_regular"}, mvMap))
	require.False(t, isMaterializedView(baseTableType, db.TableKey{Table: "sales"}, mvMap))
}

// BYT-9689: StarRocks synchronous rollups are listed in
// information_schema.materialized_views with REFRESH_TYPE='ROLLUP' but, unlike async
// MVs, have no information_schema.tables row (they are rollup indexes on the base
// table). Only confirmed rollups are excluded; async MVs (ASYNC/MANUAL/...) are kept, so
// a future refresh type isn't silently dropped. The query coalesces SQL NULL to the
// empty string via IFNULL (database/sql cannot scan NULL into a string), so a NULL
// refresh type reaches this check as the empty string, which must also be kept.
func TestIsSyncRollup(t *testing.T) {
	require.True(t, isSyncRollup("ROLLUP"))
	require.False(t, isSyncRollup("ASYNC"))
	require.False(t, isSyncRollup("MANUAL"))
	require.False(t, isSyncRollup("")) // IFNULL-coalesced NULL or a genuinely empty type.
}

// #20566 review (P2): SyncInstance's system-database exclusion must match the parser's
// system set. `sys` is StarRocks's read-only metadatabase and must be excluded so it
// isn't imported as a user database.
func TestSystemDatabaseExclusion(t *testing.T) {
	got := systemDatabaseExclusion()
	require.Contains(t, got, "'information_schema'")
	require.Contains(t, got, "'_statistics_'")
	require.Contains(t, got, "'sys'")
}