Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor: clean up redundant error message patterns (#18685)

p0ny033bc7afb243
diff --git a/backend/api/v1/auth_service.go b/backend/api/v1/auth_service.go
index 1687830cb0..c5e8cdce31 100644
--- a/backend/api/v1/auth_service.go
+++ b/backend/api/v1/auth_service.go
@@ -453,7 +453,7 @@ func (s *AuthService) getOrCreateUserWithIDP(ctx context.Context, request *v1pb.
PasswordHash: string(passwordHash),
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create user, error"))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create user"))
}
if userInfo.HasGroups {
// Sync user groups with the identity provider.
@@ -672,7 +672,7 @@ func (s *AuthService) completeMFALogin(ctx context.Context, request *v1pb.LoginR
}
user, err := s.store.GetUserByEmail(ctx, userEmail)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find user, error"))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find user"))
}
if user == nil {
return nil, invalidCredentialsError
@@ -704,7 +704,7 @@ func (s *AuthService) validateLoginPermissions(ctx context.Context, user *store.
isWorkspaceAdmin, err := isUserWorkspaceAdmin(ctx, s.store, user)
if err != nil {
- return connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check user roles, error"))
+ return connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check user roles"))
}
// Skip restrictions for workspace admins and service accounts
@@ -724,7 +724,7 @@ func (s *AuthService) validateLoginPermissions(ctx context.Context, user *store.
if err := s.licenseService.IsFeatureEnabled(v1pb.PlanFeature_FEATURE_DISALLOW_PASSWORD_SIGNIN); err == nil {
setting, err := s.store.GetWorkspaceProfileSetting(ctx)
if err != nil {
- return connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find workspace setting, error"))
+ return connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find workspace setting"))
}
if setting.DisallowPasswordSignin && !loginViaIDP {
return connect.NewError(connect.CodePermissionDenied, errors.Errorf("password signin is disallowed"))
diff --git a/backend/api/v1/database_service.go b/backend/api/v1/database_service.go
index 4fb0d88405..a09d3bcaba 100644
--- a/backend/api/v1/database_service.go
+++ b/backend/api/v1/database_service.go
@@ -63,7 +63,7 @@ func (s *DatabaseService) GetDatabase(ctx context.Context, req *connect.Request[
}
database, err := s.convertToDatabase(ctx, databaseMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert database, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert database"))
}
return connect.NewResponse(database), nil
}
@@ -116,7 +116,7 @@ func (s *DatabaseService) BatchGetDatabases(ctx context.Context, req *connect.Re
}
database, err := s.convertToDatabase(ctx, databaseMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert database, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert database"))
}
databases = append(databases, database)
}
@@ -248,7 +248,7 @@ func (s *DatabaseService) ListDatabases(ctx context.Context, req *connect.Reques
if len(databaseMessages) == limitPlusOne {
databaseMessages = databaseMessages[:offset.limit]
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to marshal next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to marshal next page token"))
}
}
@@ -258,7 +258,7 @@ func (s *DatabaseService) ListDatabases(ctx context.Context, req *connect.Reques
for _, databaseMessage := range databaseMessages {
database, err := s.convertToDatabase(ctx, databaseMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert database, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert database"))
}
response.Databases = append(response.Databases, database)
}
@@ -382,7 +382,7 @@ func (s *DatabaseService) UpdateDatabase(ctx context.Context, req *connect.Reque
database, err := s.convertToDatabase(ctx, updatedDatabase)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert database, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert database"))
}
return connect.NewResponse(database), nil
}
@@ -691,22 +691,22 @@ func (s *DatabaseService) DiffSchema(ctx context.Context, req *connect.Request[v
// Use unified SDL-based approach for all scenarios
sourceDBSchema, err := s.getSourceDBMetadata(ctx, req.Msg)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get source schema, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get source schema"))
}
targetDBSchema, err := s.getTargetDBMetadata(ctx, req.Msg)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get target schema, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get target schema"))
}
engine, err := s.getParserEngine(ctx, req.Msg)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get parser engine, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get parser engine"))
}
schemaDiff, err := schema.GetDatabaseSchemaDiff(engine, sourceDBSchema, targetDBSchema)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to compute schema diff, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to compute schema diff"))
}
// Filter out bbdataarchive schema changes for Postgres
@@ -716,7 +716,7 @@ func (s *DatabaseService) DiffSchema(ctx context.Context, req *connect.Request[v
migrationSQL, err := schema.GenerateMigration(engine, schemaDiff)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate migration SQL, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate migration SQL"))
}
return connect.NewResponse(&v1pb.DiffSchemaResponse{
diff --git a/backend/api/v1/group_service.go b/backend/api/v1/group_service.go
index 4c543e50fc..607dca117c 100644
--- a/backend/api/v1/group_service.go
+++ b/backend/api/v1/group_service.go
@@ -98,7 +98,7 @@ func (s *GroupService) ListGroups(ctx context.Context, request *connect.Request[
if len(groups) == limitPlusOne {
groups = groups[:offset.limit]
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to marshal next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to marshal next page token"))
}
}
diff --git a/backend/api/v1/issue_service.go b/backend/api/v1/issue_service.go
index de25e3d0a7..a99cf549d1 100644
--- a/backend/api/v1/issue_service.go
+++ b/backend/api/v1/issue_service.go
@@ -69,7 +69,7 @@ func (s *IssueService) GetIssue(ctx context.Context, req *connect.Request[v1pb.G
}
issueV1, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(issueV1), nil
}
@@ -216,7 +216,7 @@ func (s *IssueService) getIssueFind(
}
if _, err := parseFilter(ast.NativeRep().Expr()); err != nil {
- return nil, nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to parse filter, error: %v", err))
+ return nil, nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to parse filter"))
}
return issueFind, filterIssue, nil
}
@@ -249,20 +249,20 @@ func (s *IssueService) ListIssues(ctx context.Context, req *connect.Request[v1pb
issues, err := s.store.ListIssues(ctx, issueFind)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to search issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to search issue"))
}
var nextPageToken string
if len(issues) == limitPlusOne {
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token"))
}
issues = issues[:offset.limit]
}
converted, err := s.convertToIssues(ctx, issues, issueFilter)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(&v1pb.ListIssuesResponse{
Issues: converted,
@@ -304,27 +304,27 @@ func (s *IssueService) SearchIssues(ctx context.Context, req *connect.Request[v1
}
projectIDsFilter, err := getProjectIDsSearchFilter(ctx, user, iam.PermissionIssuesGet, s.iamManager, s.store)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get projectIDs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get projectIDs"))
}
issueFind.ProjectIDs = projectIDsFilter
}
issues, err := s.store.ListIssues(ctx, issueFind)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to search issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to search issue"))
}
var nextPageToken string
if len(issues) == limitPlusOne {
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token"))
}
issues = issues[:offset.limit]
}
converted, err := s.convertToIssues(ctx, issues, issueFilter)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(&v1pb.SearchIssuesResponse{
Issues: converted,
@@ -357,7 +357,7 @@ func (s *IssueService) CreateIssue(ctx context.Context, req *connect.Request[v1p
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))
@@ -398,7 +398,7 @@ func (s *IssueService) createIssueDatabaseChange(ctx context.Context, project *s
}
plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &project.ResourceID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, project.ResourceID))
@@ -425,7 +425,7 @@ func (s *IssueService) createIssueDatabaseChange(ctx context.Context, project *s
issue, err := s.store.CreateIssue(ctx, issueCreateMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create issue"))
}
s.stateCfg.ApprovalFinding.Store(issue.UID, issue)
@@ -439,7 +439,7 @@ func (s *IssueService) createIssueDatabaseChange(ctx context.Context, project *s
converted, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(converted), nil
@@ -468,7 +468,7 @@ func (s *IssueService) createIssueGrantRequest(ctx context.Context, project *sto
if expression := request.Issue.GrantRequest.GetCondition().GetExpression(); expression != "" {
e, err := cel.NewEnv(common.IAMPolicyConditionCELAttributes...)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create cel environment, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create cel environment"))
}
if _, issues := e.Compile(expression); issues != nil {
return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("found issues in grant request condition expression, issues: %v", issues.String()))
@@ -477,7 +477,7 @@ func (s *IssueService) createIssueGrantRequest(ctx context.Context, project *sto
convertedGrantRequest, err := convertGrantRequest(ctx, s.store, request.Issue.GrantRequest)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert GrantRequest, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert GrantRequest"))
}
issueCreateMessage := &store.IssueMessage{
ProjectID: project.ResourceID,
@@ -500,7 +500,7 @@ func (s *IssueService) createIssueGrantRequest(ctx context.Context, project *sto
issue, err := s.store.CreateIssue(ctx, issueCreateMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create issue"))
}
s.stateCfg.ApprovalFinding.Store(issue.UID, issue)
@@ -514,7 +514,7 @@ func (s *IssueService) createIssueGrantRequest(ctx context.Context, project *sto
converted, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(converted), nil
@@ -537,7 +537,7 @@ func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, projec
}
plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &project.ResourceID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, project.ResourceID))
@@ -564,7 +564,7 @@ func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, projec
issue, err := s.store.CreateIssue(ctx, issueCreateMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create issue"))
}
s.stateCfg.ApprovalFinding.Store(issue.UID, issue)
@@ -578,7 +578,7 @@ func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, projec
converted, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(converted), nil
@@ -592,7 +592,7 @@ func (s *IssueService) ApproveIssue(ctx context.Context, req *connect.Request[v1
}
project, err := s.store.GetProject(ctx, &store.FindProjectMessage{ResourceID: &issue.ProjectID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %s not found", issue.ProjectID))
@@ -638,7 +638,7 @@ func (s *IssueService) ApproveIssue(ctx context.Context, req *connect.Request[v1
approved, err := utils.CheckApprovalApproved(payload.Approval)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check if the approval is approved, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check if the approval is approved"))
}
issue, err = s.store.UpdateIssue(ctx, issue.UID, &store.UpdateIssueMessage{
@@ -647,7 +647,7 @@ func (s *IssueService) ApproveIssue(ctx context.Context, req *connect.Request[v1
},
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to update issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to update issue"))
}
// Grant the privilege if the issue is approved.
@@ -770,7 +770,7 @@ func (s *IssueService) ApproveIssue(ctx context.Context, req *connect.Request[v1
issueV1, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
// Auto-create rollout if this approval completes the approval flow
@@ -833,7 +833,7 @@ func (s *IssueService) RejectIssue(ctx context.Context, req *connect.Request[v1p
},
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to update issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to update issue"))
}
if err := func() error {
@@ -856,7 +856,7 @@ func (s *IssueService) RejectIssue(ctx context.Context, req *connect.Request[v1p
issueV1, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(issueV1), nil
}
@@ -869,7 +869,7 @@ func (s *IssueService) RequestIssue(ctx context.Context, req *connect.Request[v1
}
project, err := s.store.GetProject(ctx, &store.FindProjectMessage{ResourceID: &issue.ProjectID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %s not found", issue.ProjectID))
@@ -918,7 +918,7 @@ func (s *IssueService) RequestIssue(ctx context.Context, req *connect.Request[v1
},
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to update issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to update issue"))
}
func() {
@@ -964,7 +964,7 @@ func (s *IssueService) RequestIssue(ctx context.Context, req *connect.Request[v1
issueV1, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(issueV1), nil
}
@@ -1007,7 +1007,7 @@ func (s *IssueService) UpdateIssue(ctx context.Context, req *connect.Request[v1p
}
project, err := s.store.GetProject(ctx, &store.FindProjectMessage{ResourceID: &issue.ProjectID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %s not found", issue.ProjectID))
@@ -1131,7 +1131,7 @@ func (s *IssueService) UpdateIssue(ctx context.Context, req *connect.Request[v1p
issue, err = s.store.UpdateIssue(ctx, issue.UID, patch)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to update issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to update issue"))
}
if updateMasks["approval_finding_done"] {
@@ -1149,7 +1149,7 @@ func (s *IssueService) UpdateIssue(ctx context.Context, req *connect.Request[v1p
issueV1, err := s.convertToIssue(issue)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to issue"))
}
return connect.NewResponse(issueV1), nil
}
@@ -1295,7 +1295,7 @@ func (s *IssueService) ListIssueComments(ctx context.Context, req *connect.Reque
var nextPageToken string
if len(issueComments) == limitPlusOne {
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token"))
}
issueComments = issueComments[:offset.limit]
}
@@ -1322,7 +1322,7 @@ func (s *IssueService) CreateIssueComment(ctx context.Context, req *connect.Requ
}
project, err := s.store.GetProject(ctx, &store.FindProjectMessage{ResourceID: &issue.ProjectID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %s not found", issue.ProjectID))
@@ -1421,7 +1421,7 @@ func (s *IssueService) getIssueMessage(ctx context.Context, name string) (*store
ProjectID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get issue"))
}
if issue == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("issue %d not found in project %s", issueUID, projectID))
diff --git a/backend/api/v1/plan_service.go b/backend/api/v1/plan_service.go
index 0bf5cdfd89..11453a3fbe 100644
--- a/backend/api/v1/plan_service.go
+++ b/backend/api/v1/plan_service.go
@@ -50,14 +50,14 @@ func (s *PlanService) GetPlan(ctx context.Context, request *connect.Request[v1pb
ProjectID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, projectID))
}
convertedPlan, err := convertToPlan(ctx, s.store, plan)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to plan"))
}
return connect.NewResponse(convertedPlan), nil
}
@@ -96,21 +96,21 @@ func (s *PlanService) ListPlans(ctx context.Context, request *connect.Request[v1
plans, err := s.store.ListPlans(ctx, find)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list plans, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list plans"))
}
var nextPageToken string
// has more pages
if len(plans) == limitPlusOne {
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token"))
}
plans = plans[:offset.limit]
}
convertedPlans, err := convertToPlans(ctx, s.store, plans)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to plans, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to plans"))
}
return connect.NewResponse(&v1pb.ListPlansResponse{
@@ -160,7 +160,7 @@ func (s *PlanService) CreatePlan(ctx context.Context, request *connect.Request[v
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))
@@ -169,7 +169,7 @@ func (s *PlanService) CreatePlan(ctx context.Context, request *connect.Request[v
// Validate plan specs
databaseGroup, err := validateSpecs(ctx, s.store, projectID, req.Plan.Specs)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to validate plan specs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to validate plan specs"))
}
planMessage := &store.PlanMessage{
@@ -181,16 +181,16 @@ func (s *PlanService) CreatePlan(ctx context.Context, request *connect.Request[v
plan, err := s.store.CreatePlan(ctx, planMessage, user.Email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create plan"))
}
planCheckRun, err := getPlanCheckRunFromPlan(project, plan, databaseGroup)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan check run for plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan check run for plan"))
}
if planCheckRun != nil {
if err := s.store.CreatePlanCheckRun(ctx, planCheckRun); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create plan check run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create plan check run"))
}
}
// Tickle plan check scheduler.
@@ -198,7 +198,7 @@ func (s *PlanService) CreatePlan(ctx context.Context, request *connect.Request[v
convertedPlan, err := convertToPlan(ctx, s.store, plan)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to plan"))
}
return connect.NewResponse(convertedPlan), nil
}
@@ -259,7 +259,7 @@ func (s *PlanService) UpdatePlan(ctx context.Context, request *connect.Request[v
return s.iamManager.CheckPermission(ctx, iam.PermissionPlansUpdate, user, oldPlan.ProjectID)
}()
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check permission, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check permission"))
}
if !ok {
return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("permission denied to update plan"))
@@ -293,7 +293,7 @@ func (s *PlanService) UpdatePlan(ctx context.Context, request *connect.Request[v
// Validate the new specs.
dg, err := validateSpecs(ctx, s.store, oldPlan.ProjectID, req.Plan.Specs)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to validate plan specs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to validate plan specs"))
}
databaseGroup = dg
@@ -337,11 +337,11 @@ func (s *PlanService) UpdatePlan(ctx context.Context, request *connect.Request[v
if planCheckRunsTrigger {
planCheckRun, err := getPlanCheckRunFromPlan(project, updatedPlan, databaseGroup)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan check run for plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan check run for plan"))
}
if planCheckRun != nil {
if err := s.store.CreatePlanCheckRun(ctx, planCheckRun); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create plan check run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create plan check run"))
}
}
// Tickle plan check scheduler.
@@ -350,7 +350,7 @@ func (s *PlanService) UpdatePlan(ctx context.Context, request *connect.Request[v
convertedPlan, err := convertToPlan(ctx, s.store, updatedPlan)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to plan"))
}
return connect.NewResponse(convertedPlan), nil
}
@@ -365,7 +365,7 @@ func (s *PlanService) GetPlanCheckRun(ctx context.Context, request *connect.Requ
planCheckRun, err := s.store.GetPlanCheckRun(ctx, planUID)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan check run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan check run"))
}
if planCheckRun == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan check run not found for plan %d", planUID))
@@ -386,7 +386,7 @@ func (s *PlanService) RunPlanChecks(ctx context.Context, request *connect.Reques
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))
@@ -396,7 +396,7 @@ func (s *PlanService) RunPlanChecks(ctx context.Context, request *connect.Reques
ProjectID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan not found"))
@@ -424,11 +424,11 @@ func (s *PlanService) RunPlanChecks(ctx context.Context, request *connect.Reques
}
planCheckRun, err := getPlanCheckRunFromPlan(project, plan, databaseGroup)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan check run for plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan check run for plan"))
}
if planCheckRun != nil {
if err := s.store.CreatePlanCheckRun(ctx, planCheckRun); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create plan check run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create plan check run"))
}
}
@@ -450,7 +450,7 @@ func (s *PlanService) CancelPlanCheckRun(ctx context.Context, request *connect.R
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %v not found", projectID))
@@ -458,7 +458,7 @@ func (s *PlanService) CancelPlanCheckRun(ctx context.Context, request *connect.R
planCheckRun, err := s.store.GetPlanCheckRun(ctx, planUID)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan check run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan check run"))
}
if planCheckRun == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan check run not found for plan %d", planUID))
@@ -475,7 +475,7 @@ func (s *PlanService) CancelPlanCheckRun(ctx context.Context, request *connect.R
// Update the status to canceled.
if err := s.store.BatchCancelPlanCheckRuns(ctx, []int{planCheckRun.UID}); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to cancel plan check run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to cancel plan check run"))
}
return connect.NewResponse(&v1pb.CancelPlanCheckRunResponse{}), nil
diff --git a/backend/api/v1/revision_service.go b/backend/api/v1/revision_service.go
index e4515dcf0c..052912ca97 100644
--- a/backend/api/v1/revision_service.go
+++ b/backend/api/v1/revision_service.go
@@ -78,7 +78,7 @@ func (s *RevisionService) ListRevisions(
var nextPageToken string
if len(revisions) == limitPlusOne {
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token, error"))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token"))
}
revisions = revisions[:offset.limit]
}
diff --git a/backend/api/v1/rollout_service.go b/backend/api/v1/rollout_service.go
index 64a1dcd246..421ba324b3 100644
--- a/backend/api/v1/rollout_service.go
+++ b/backend/api/v1/rollout_service.go
@@ -59,7 +59,7 @@ func (s *RolloutService) GetRollout(ctx context.Context, req *connect.Request[v1
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %q not found", projectID))
@@ -71,7 +71,7 @@ func (s *RolloutService) GetRollout(ctx context.Context, req *connect.Request[v1
UID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", planID, projectID))
@@ -83,13 +83,13 @@ func (s *RolloutService) GetRollout(ctx context.Context, req *connect.Request[v1
tasks, err := s.store.ListTasks(ctx, &store.TaskFind{PlanID: &planID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get tasks"))
}
// Get environment order.
environments, err := s.store.GetEnvironment(ctx)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get environments, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get environments"))
}
environmentOrderMap := make(map[string]int)
for i, env := range environments.GetEnvironments() {
@@ -98,7 +98,7 @@ func (s *RolloutService) GetRollout(ctx context.Context, req *connect.Request[v1
rolloutV1, err := convertToRollout(project, plan, tasks, environmentOrderMap)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to rollout"))
}
return connect.NewResponse(rolloutV1), nil
}
@@ -114,7 +114,7 @@ func (s *RolloutService) ListRollouts(ctx context.Context, req *connect.Request[
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %q not found", projectID))
@@ -143,13 +143,13 @@ func (s *RolloutService) ListRollouts(ctx context.Context, req *connect.Request[
}
plans, err := s.store.ListPlans(ctx, findPlan)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list plans, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list plans"))
}
var nextPageToken string
if len(plans) == limitPlusOne {
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get next page token"))
}
plans = plans[:offset.limit]
}
@@ -164,7 +164,7 @@ func (s *RolloutService) ListRollouts(ctx context.Context, req *connect.Request[
var err error
allTasks, err = s.store.ListTasks(ctx, &store.TaskFind{PlanIDs: &planIDs})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list tasks"))
}
}
@@ -177,7 +177,7 @@ func (s *RolloutService) ListRollouts(ctx context.Context, req *connect.Request[
// Get environment order once for all rollouts.
environments, err := s.store.GetEnvironment(ctx)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get environments, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get environments"))
}
environmentOrderMap := make(map[string]int)
for i, env := range environments.GetEnvironments() {
@@ -190,7 +190,7 @@ func (s *RolloutService) ListRollouts(ctx context.Context, req *connect.Request[
tasks := tasksByPlanID[plan.UID]
rollout, err := convertToRollout(project, plan, tasks, environmentOrderMap)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to rollout"))
}
rollouts = append(rollouts, rollout)
}
@@ -227,7 +227,7 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))
@@ -235,7 +235,7 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &projectID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get plan"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, projectID))
@@ -243,12 +243,12 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
tasks, err := GetPipelineCreate(ctx, s.store, plan.Config.GetSpecs(), project.ResourceID)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get pipeline create, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get pipeline create"))
}
if isChangeDatabasePlan(plan.Config.GetSpecs()) {
tasks, err = filterTasksByStage(tasks, request.Target)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to filter tasks with stage id, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to filter tasks with stage id"))
}
}
@@ -258,13 +258,13 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
tasks, err = s.store.ListTasks(ctx, &store.TaskFind{PlanID: &planID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get tasks"))
}
// Get environment order.
environments, err := s.store.GetEnvironment(ctx)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get environments, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get environments"))
}
environmentOrderMap := make(map[string]int)
for i, env := range environments.GetEnvironments() {
@@ -273,7 +273,7 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
rolloutV1, err := convertToRollout(project, plan, tasks, environmentOrderMap)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to rollout"))
}
// Tickle task run scheduler.
@@ -294,7 +294,7 @@ func (s *RolloutService) ListTaskRuns(ctx context.Context, req *connect.Request[
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %v not found", projectID))
@@ -305,7 +305,7 @@ func (s *RolloutService) ListTaskRuns(ctx context.Context, req *connect.Request[
UID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get rollout"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", planID, projectID))
@@ -316,12 +316,12 @@ func (s *RolloutService) ListTaskRuns(ctx context.Context, req *connect.Request[
TaskUID: maybeTaskID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list task runs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list task runs"))
}
taskRunsV1, err := convertToTaskRuns(ctx, s.store, s.stateCfg, taskRuns)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to task runs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to task runs"))
}
return connect.NewResponse(&v1pb.ListTaskRunsResponse{
TaskRuns: taskRunsV1,
@@ -441,7 +441,7 @@ func (s *RolloutService) GetTaskRun(ctx context.Context, req *connect.Request[v1
UID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get rollout"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", planID, projectID))
@@ -452,7 +452,7 @@ func (s *RolloutService) GetTaskRun(ctx context.Context, req *connect.Request[v1
PlanUID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get task run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get task run"))
}
if taskRun == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("task run %d not found in rollout %d", taskRunUID, planID))
@@ -460,7 +460,7 @@ func (s *RolloutService) GetTaskRun(ctx context.Context, req *connect.Request[v1
taskRunV1, err := convertToTaskRun(ctx, s.store, s.stateCfg, taskRun)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert to task run, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert to task run"))
}
return connect.NewResponse(taskRunV1), nil
}
@@ -469,11 +469,11 @@ func (s *RolloutService) GetTaskRunLog(ctx context.Context, req *connect.Request
request := req.Msg
_, _, _, _, taskRunUID, err := common.GetProjectIDPlanIDStageIDTaskIDTaskRunID(request.Parent)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get task run uid, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get task run uid"))
}
logs, err := s.store.ListTaskRunLogs(ctx, taskRunUID)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to list task run logs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to list task run logs"))
}
return connect.NewResponse(convertToTaskRunLog(request.Parent, logs)), nil
}
@@ -482,7 +482,7 @@ func (s *RolloutService) GetTaskRunSession(ctx context.Context, req *connect.Req
request := req.Msg
_, _, _, taskUID, taskRunUID, err := common.GetProjectIDPlanIDStageIDTaskIDTaskRunID(request.Parent)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get task run uid, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get task run uid"))
}
connIDAny, ok := s.stateCfg.TaskRunConnectionID.Load(taskRunUID)
if !ok {
@@ -495,23 +495,23 @@ func (s *RolloutService) GetTaskRunSession(ctx context.Context, req *connect.Req
task, err := s.store.GetTaskByID(ctx, taskUID)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get task, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get task"))
}
instance, err := s.store.GetInstance(ctx, &store.FindInstanceMessage{ResourceID: &task.InstanceID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get instance, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get instance"))
}
driver, err := s.dbFactory.GetAdminDatabaseDriver(ctx, instance, nil, db.ConnectionContext{})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get driver, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get driver"))
}
defer driver.Close(ctx)
session, err := getSession(ctx, instance.Metadata.GetEngine(), driver.GetDB(), connID)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get session, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get session"))
}
session.Name = request.Parent + "/session"
@@ -627,7 +627,7 @@ func (s *RolloutService) BatchRunTasks(ctx context.Context, req *connect.Request
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %v not found", projectID))
@@ -638,7 +638,7 @@ func (s *RolloutService) BatchRunTasks(ctx context.Context, req *connect.Request
UID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find plan for rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find plan for rollout"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout (plan) %v not found", planID))
@@ -649,7 +649,7 @@ func (s *RolloutService) BatchRunTasks(ctx context.Context, req *connect.Request
PlanUID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find issue"))
}
// Parse requested task IDs and group by their environment
@@ -678,7 +678,7 @@ func (s *RolloutService) BatchRunTasks(ctx context.Context, req *connect.Request
// Get all tasks in the same environment
stageToRunTasks, err := s.store.ListTasks(ctx, &store.TaskFind{PlanID: &planID, Environment: &environmentToRun})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list tasks"))
}
if len(stageToRunTasks) == 0 {
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("No tasks to run in the stage"))
@@ -691,7 +691,7 @@ func (s *RolloutService) BatchRunTasks(ctx context.Context, req *connect.Request
ok, err = s.canUserRunEnvironmentTasks(ctx, user, project, issueN, environmentToRun, plan.Creator)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check if the user can run tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check if the user can run tasks"))
}
if !ok {
return nil, connect.NewError(connect.CodePermissionDenied, errors.New("Not allowed to run tasks"))
@@ -701,7 +701,7 @@ func (s *RolloutService) BatchRunTasks(ctx context.Context, req *connect.Request
if project.Setting.RequireIssueApproval && issueN != nil {
approved, err := utils.CheckIssueApproved(issueN)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check if the issue is approved, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check if the issue is approved"))
}
if !approved {
return nil, connect.NewError(connect.CodeFailedPrecondition, errors.New("cannot run the tasks because issue approval is required but the issue is not approved"))
@@ -762,7 +762,7 @@ func (s *RolloutService) BatchSkipTasks(ctx context.Context, req *connect.Reques
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %v not found", projectID))
@@ -773,7 +773,7 @@ func (s *RolloutService) BatchSkipTasks(ctx context.Context, req *connect.Reques
UID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find plan for rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find plan for rollout"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout (plan) %v not found", planID))
@@ -784,12 +784,12 @@ func (s *RolloutService) BatchSkipTasks(ctx context.Context, req *connect.Reques
PlanUID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find issue"))
}
tasks, err := s.store.ListTasks(ctx, &store.TaskFind{PlanID: &planID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list tasks"))
}
taskByID := make(map[int]*store.TaskMessage)
@@ -821,7 +821,7 @@ func (s *RolloutService) BatchSkipTasks(ctx context.Context, req *connect.Reques
for environment := range environmentSet {
ok, err = s.canUserRunEnvironmentTasks(ctx, user, project, issueN, environment, plan.Creator)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check if the user can skip tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check if the user can skip tasks"))
}
if !ok {
return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("not allowed to skip tasks in environment %q", environment))
@@ -829,7 +829,7 @@ func (s *RolloutService) BatchSkipTasks(ctx context.Context, req *connect.Reques
}
if err := s.store.BatchSkipTasks(ctx, taskUIDs, request.Reason); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to skip tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to skip tasks"))
}
for _, task := range tasksToSkip {
@@ -868,7 +868,7 @@ func (s *RolloutService) BatchCancelTaskRuns(ctx context.Context, req *connect.R
ResourceID: &projectID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find project, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find project"))
}
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %v not found", projectID))
@@ -879,7 +879,7 @@ func (s *RolloutService) BatchCancelTaskRuns(ctx context.Context, req *connect.R
UID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find plan for rollout, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find plan for rollout"))
}
if plan == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout (plan) %v not found", planID))
@@ -890,7 +890,7 @@ func (s *RolloutService) BatchCancelTaskRuns(ctx context.Context, req *connect.R
PlanUID: &planID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find issue, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find issue"))
}
for _, taskRun := range request.TaskRuns {
@@ -911,7 +911,7 @@ func (s *RolloutService) BatchCancelTaskRuns(ctx context.Context, req *connect.R
environment := formatEnvironmentFromStageID(stageID)
ok, err = s.canUserCancelEnvironmentTaskRun(ctx, user, project, issueN, environment, plan.Creator)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check if the user can run tasks, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check if the user can run tasks"))
}
if !ok {
return nil, connect.NewError(connect.CodePermissionDenied, errors.New("Not allowed to cancel tasks"))
@@ -930,7 +930,7 @@ func (s *RolloutService) BatchCancelTaskRuns(ctx context.Context, req *connect.R
UIDs: &taskRunIDs,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list task runs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list task runs"))
}
for _, taskRun := range taskRuns {
@@ -951,7 +951,7 @@ func (s *RolloutService) BatchCancelTaskRuns(ctx context.Context, req *connect.R
}
if err := s.store.BatchCancelTaskRuns(ctx, taskRunIDs); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to batch patch task run status to canceled, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to batch patch task run status to canceled"))
}
s.webhookManager.CreateEvent(ctx, &webhook.Event{
@@ -972,14 +972,14 @@ func (s *RolloutService) PreviewTaskRunRollback(ctx context.Context, req *connec
request := req.Msg
_, _, _, taskUID, taskRunUID, err := common.GetProjectIDPlanIDStageIDTaskIDTaskRunID(request.Name)
if err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("failed to get task run uid, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get task run uid"))
}
taskRuns, err := s.store.ListTaskRuns(ctx, &store.FindTaskRunMessage{
UID: &taskRunUID,
})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list task runs, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list task runs"))
}
if len(taskRuns) == 0 {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("task run %v not found", taskRunUID))
@@ -1005,12 +1005,12 @@ func (s *RolloutService) PreviewTaskRunRollback(ctx context.Context, req *connec
task, err := s.store.GetTaskByID(ctx, taskUID)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get task, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get task"))
}
instance, err := s.store.GetInstance(ctx, &store.FindInstanceMessage{ResourceID: &task.InstanceID})
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get instance, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get instance"))
}
if taskRun.SheetSha256 == nil {
@@ -1018,7 +1018,7 @@ func (s *RolloutService) PreviewTaskRunRollback(ctx context.Context, req *connec
}
sheet, err := s.store.GetSheetFull(ctx, *taskRun.SheetSha256)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get sheet statements, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get sheet statements"))
}
statements := sheet.Statement
@@ -1031,7 +1031,7 @@ func (s *RolloutService) PreviewTaskRunRollback(ctx context.Context, req *connec
IsCaseSensitive: store.IsObjectCaseSensitive(instance),
}, statements, item)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate restore sql, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate restore sql"))
}
results = append(results, restore)
}
diff --git a/backend/api/v1/setting_service.go b/backend/api/v1/setting_service.go
index 83fe63a5d1..c9286cc2ea 100644
--- a/backend/api/v1/setting_service.go
+++ b/backend/api/v1/setting_service.go
@@ -373,7 +373,7 @@ func (s *SettingService) UpdateSetting(ctx context.Context, request *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("cannot found slack setting"))
}
if err := slack.ValidateToken(ctx, slackSetting.GetSlack().GetToken()); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("validation failed, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "validation failed"))
}
case "value.app_im.feishu":
@@ -382,7 +382,7 @@ func (s *SettingService) UpdateSetting(ctx context.Context, request *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("cannot found feishu setting"))
}
if err := feishu.Validate(ctx, feishuSetting.GetFeishu().GetAppId(), feishuSetting.GetFeishu().GetAppSecret(), user.Email); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("validation failed, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "validation failed"))
}
case "value.app_im.wecom":
@@ -391,7 +391,7 @@ func (s *SettingService) UpdateSetting(ctx context.Context, request *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("cannot found wecom setting"))
}
if err := wecom.Validate(ctx, wecomSetting.GetWecom().GetCorpId(), wecomSetting.GetWecom().GetAgentId(), wecomSetting.GetWecom().GetSecret()); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("validation failed, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "validation failed"))
}
case "value.app_im.lark":
@@ -400,7 +400,7 @@ func (s *SettingService) UpdateSetting(ctx context.Context, request *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("cannot found lark setting"))
}
if err := lark.Validate(ctx, larkSetting.GetLark().GetAppId(), larkSetting.GetLark().GetAppSecret(), user.Email); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("validation failed, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "validation failed"))
}
case "value.app_im.dingtalk":
@@ -409,7 +409,7 @@ func (s *SettingService) UpdateSetting(ctx context.Context, request *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("cannot found dingtalk setting"))
}
if err := dingtalk.Validate(ctx, dingtalkSetting.GetDingtalk().GetClientId(), dingtalkSetting.GetDingtalk().GetClientSecret(), dingtalkSetting.GetDingtalk().GetRobotCode(), user.Phone); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("validation failed, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "validation failed"))
}
case "value.app_im_setting_value.teams":
@@ -418,7 +418,7 @@ func (s *SettingService) UpdateSetting(ctx context.Context, request *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("cannot found teams setting"))
}
if err := teams.Validate(ctx, teamsSetting.GetTeams().GetTenantId(), teamsSetting.GetTeams().GetClientId(), teamsSetting.GetTeams().GetClientSecret(), user.Email); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("validation failed, error: %v", err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "validation failed"))
}
default:
diff --git a/backend/api/v1/sql_service.go b/backend/api/v1/sql_service.go
index d796d4972f..529214602d 100644
--- a/backend/api/v1/sql_service.go
+++ b/backend/api/v1/sql_service.go
@@ -1278,7 +1278,7 @@ func (s *SQLService) SearchQueryHistories(ctx context.Context, req *connect.Requ
if len(historyList) == limitPlusOne {
historyList = historyList[:offset.limit]
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to marshal next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to marshal next page token"))
}
}
@@ -1288,7 +1288,7 @@ func (s *SQLService) SearchQueryHistories(ctx context.Context, req *connect.Requ
for _, history := range historyList {
queryHistory, err := s.convertToV1QueryHistory(ctx, history)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to convert log entity, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to convert log entity"))
}
if queryHistory == nil {
continue
@@ -1426,7 +1426,7 @@ func (s *SQLService) accessCheck(
workspacePolicy, err := s.store.GetWorkspaceIamPolicy(ctx)
if err != nil {
- return connect.NewError(connect.CodeInternal, errors.Errorf("failed to get workspace iam policy, error: %v", err))
+ return connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get workspace iam policy"))
}
projectPolicy, err := s.store.GetProjectIamPolicy(ctx, project.ResourceID)
@@ -1696,13 +1696,13 @@ func (*SQLService) DiffMetadata(_ context.Context, req *connect.Request[v1pb.Dif
// Get the metadata diff between source and target
metadataDiff, err := schema.GetDatabaseSchemaDiff(storepb.Engine(request.Engine), sourceDBSchema, targetDBSchema)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to compute diff between source and target schemas, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to compute diff between source and target schemas"))
}
// Generate migration SQL from the diff
diff, err := schema.GenerateMigration(storepb.Engine(request.Engine), metadataDiff)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate migration SQL, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate migration SQL"))
}
return connect.NewResponse(&v1pb.DiffMetadataResponse{
diff --git a/backend/api/v1/user_service.go b/backend/api/v1/user_service.go
index db2a33d324..06d111546e 100644
--- a/backend/api/v1/user_service.go
+++ b/backend/api/v1/user_service.go
@@ -57,7 +57,7 @@ func (s *UserService) GetUser(ctx context.Context, request *connect.Request[v1pb
}
user, err := s.store.GetUserByEmail(ctx, email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get user"))
}
if user == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("user %q not found", email))
@@ -128,14 +128,14 @@ func (s *UserService) ListUsers(ctx context.Context, request *connect.Request[v1
users, err := s.store.ListUsers(ctx, find)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to list user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to list user"))
}
nextPageToken := ""
if len(users) == limitPlusOne {
users = users[:offset.limit]
if nextPageToken, err = offset.getNextPageToken(); err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to marshal next page token, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to marshal next page token"))
}
}
@@ -153,7 +153,7 @@ func (s *UserService) CreateUser(ctx context.Context, request *connect.Request[v
if err := s.licenseService.IsFeatureEnabled(v1pb.PlanFeature_FEATURE_DISALLOW_SELF_SERVICE_SIGNUP); err == nil {
setting, err := s.store.GetWorkspaceProfileSetting(ctx)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find workspace setting, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find workspace setting"))
}
if setting.DisallowSignup || s.profile.SaaS {
callerUser, ok := GetUserFromContext(ctx)
@@ -205,13 +205,13 @@ func (s *UserService) CreateUser(ctx context.Context, request *connect.Request[v
count, err := s.store.CountActiveEndUsers(ctx)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to count users, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to count users"))
}
firstEndUser := count == 0
if request.Msg.User.Phone != "" {
if err := common.ValidatePhone(request.Msg.User.Phone); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("invalid phone %q, error: %v", request.Msg.User.Phone, err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "invalid phone %q", request.Msg.User.Phone))
}
}
@@ -222,7 +222,7 @@ func (s *UserService) CreateUser(ctx context.Context, request *connect.Request[v
}
existingUser, err := s.store.GetUserByEmail(ctx, request.Msg.User.Email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find user by email, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find user by email"))
}
if existingUser != nil {
return nil, connect.NewError(connect.CodeAlreadyExists, errors.Errorf("email %s exists", request.Msg.User.Email))
@@ -260,7 +260,7 @@ func (s *UserService) CreateUser(ctx context.Context, request *connect.Request[v
passwordHash, err := bcrypt.GenerateFromPassword([]byte(password), bcrypt.DefaultCost)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate password hash, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate password hash"))
}
// Build profile with workload identity config if applicable
@@ -288,7 +288,7 @@ func (s *UserService) CreateUser(ctx context.Context, request *connect.Request[v
user, err := s.store.CreateUser(ctx, userMessage)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to create user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to create user"))
}
if firstEndUser {
@@ -353,7 +353,7 @@ func (s *UserService) UpdateUser(ctx context.Context, request *connect.Request[v
}
user, err := s.store.GetUserByEmail(ctx, email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get user"))
}
if user == nil {
if request.Msg.AllowMissing {
@@ -430,12 +430,12 @@ func (s *UserService) UpdateUser(ctx context.Context, request *connect.Request[v
} else {
setting, err := s.store.GetWorkspaceProfileSetting(ctx)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find workspace setting, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find workspace setting"))
}
if setting.Require_2Fa {
isWorkspaceAdmin, err := isUserWorkspaceAdmin(ctx, s.store, callerUser)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to check user roles, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check user roles"))
}
// Allow workspace admin to disable 2FA even if it is required.
if !isWorkspaceAdmin {
@@ -447,7 +447,7 @@ func (s *UserService) UpdateUser(ctx context.Context, request *connect.Request[v
case "phone":
if request.Msg.User.Phone != "" {
if err := common.ValidatePhone(request.Msg.User.Phone); err != nil {
- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("invalid phone number %q, error: %v", request.Msg.User.Phone, err))
+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "invalid phone number %q", request.Msg.User.Phone))
}
}
patch.Phone = &request.Msg.User.Phone
@@ -462,7 +462,7 @@ func (s *UserService) UpdateUser(ctx context.Context, request *connect.Request[v
passwordHash, err := bcrypt.GenerateFromPassword([]byte((*passwordPatch)), bcrypt.DefaultCost)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate password hash, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate password hash"))
}
passwordHashStr := string(passwordHash)
patch.PasswordHash = &passwordHashStr
@@ -489,11 +489,11 @@ func (s *UserService) UpdateUser(ctx context.Context, request *connect.Request[v
if request.Msg.RegenerateTempMfaSecret {
tempSecret, err := generateRandSecret(user.Email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate MFA secret, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate MFA secret"))
}
tempRecoveryCodes, err := generateRecoveryCodes(10)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to generate recovery codes, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to generate recovery codes"))
}
patch.MFAConfig = &storepb.MFAConfig{
TempOtpSecret: tempSecret,
@@ -522,7 +522,7 @@ func (s *UserService) UpdateUser(ctx context.Context, request *connect.Request[v
user, err = s.store.UpdateUser(ctx, user, patch)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to update user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to update user"))
}
userResponse := convertToUser(ctx, s.iamManager, user)
@@ -552,7 +552,7 @@ func (s *UserService) DeleteUser(ctx context.Context, request *connect.Request[v
}
user, err := s.store.GetUserByEmail(ctx, email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get user"))
}
if user == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("user %q not found", email))
@@ -645,7 +645,7 @@ func (s *UserService) UndeleteUser(ctx context.Context, request *connect.Request
}
user, err := s.store.GetUserByEmail(ctx, email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get user"))
}
if user == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("user %q not found", email))
@@ -687,7 +687,7 @@ func (s *UserService) UpdateEmail(ctx context.Context, request *connect.Request[
}
user, err := s.store.GetUserByEmail(ctx, email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get user, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get user"))
}
if user == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("user not found"))
@@ -709,7 +709,7 @@ func (s *UserService) UpdateEmail(ctx context.Context, request *connect.Request[
// Check if email already exists
existedUser, err := s.store.GetUserByEmail(ctx, request.Msg.Email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to find user by email, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find user by email"))
}
if existedUser != nil && existedUser.ID != user.ID {
return nil, connect.NewError(connect.CodeAlreadyExists, errors.Errorf("email %s already exists", request.Msg.Email))
@@ -718,7 +718,7 @@ func (s *UserService) UpdateEmail(ctx context.Context, request *connect.Request[
// Update the email
user, err = s.store.UpdateUserEmail(ctx, user, request.Msg.Email)
if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to update user email, error: %v", err))
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to update user email"))
}
return connect.NewResponse(convertToUser(ctx, s.iamManager, user)), nil
@@ -806,7 +806,7 @@ func validateEmailWithDomains(ctx context.Context, licenseService *enterprise.Li
}
setting, err := stores.GetWorkspaceProfileSetting(ctx)
if err != nil {
- return connect.NewError(connect.CodeInternal, errors.Errorf("failed to find workspace setting, error: %v", err))
+ return connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find workspace setting"))
}
var allowedDomains []string