Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: BigQuery query span type and DML statement handling (#18077)
Vincent Huang0347c99058e2
diff --git a/backend/plugin/db/bigquery/bigquery.go b/backend/plugin/db/bigquery/bigquery.goindex 0fa5bc3dcf..2e44f4ae27 100644--- a/backend/plugin/db/bigquery/bigquery.go+++ b/backend/plugin/db/bigquery/bigquery.go@@ -117,13 +117,12 @@ func (d *Driver) QueryConn(ctx context.Context, _ *sql.Conn, statement string, qvar results []*v1pb.QueryResultfor _, statement := range statements {- if queryContext.Limit > 0 {- statement = getStatementWithResultLimit(statement, queryContext.Limit)- }-startTime := time.Now()queryResult, err := func() (*v1pb.QueryResult, error) {if util.IsSelect(statement) {+ if queryContext.Limit > 0 {+ statement = getStatementWithResultLimit(statement, queryContext.Limit)+ }q := d.client.Query(statement)if queryContext.OperatorEmail != "" {q.Labels = map[string]string{"operator_email": encodeOperatorEmail(queryContext.OperatorEmail)}diff --git a/backend/plugin/parser/bigquery/query_span_extractor.go b/backend/plugin/parser/bigquery/query_span_extractor.goindex 830fc40e02..b641b30d01 100644--- a/backend/plugin/parser/bigquery/query_span_extractor.go+++ b/backend/plugin/parser/bigquery/query_span_extractor.go@@ -86,6 +86,7 @@ func (q *querySpanExtractor) getQuerySpan(ctx context.Context, stmt string) (*ba}return &base.QuerySpan{+ Type: base.Select,Results: querySpanResult,SourceColumns: accessTables,}, nildiff --git a/backend/plugin/parser/bigquery/test-data/query-span/standard.yaml b/backend/plugin/parser/bigquery/test-data/query-span/standard.yamlindex e1ab6e9378..8260539526 100644--- a/backend/plugin/parser/bigquery/test-data/query-span/standard.yaml+++ b/backend/plugin/parser/bigquery/test-data/query-span/standard.yaml@@ -24,7 +24,7 @@]}querySpan:- type: 0+ type: 1results:- name: NAMEsourcecolumns:@@ -80,7 +80,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -174,7 +174,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -263,7 +263,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -349,7 +349,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -428,7 +428,7 @@]}querySpan:- type: 0+ type: 1results:- name: C1sourcecolumns:@@ -523,7 +523,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -600,7 +600,7 @@]}querySpan:- type: 0+ type: 1results:- name: CITYsourcecolumns:@@ -655,7 +655,7 @@]}querySpan:- type: 0+ type: 1results:- name: ""sourcecolumns: []@@ -705,7 +705,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -775,7 +775,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -830,7 +830,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -885,7 +885,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns:@@ -960,7 +960,7 @@]}querySpan:- type: 0+ type: 1results:- name: IDsourcecolumns: