Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

feat(store): add LRU cache with TTL for IAM policies (#18896)

p0ny0630f27c6e08
diff --git a/backend/component/iam/manager.go b/backend/component/iam/manager.go
index a1ebf0cdf5..f28599e77b 100644
--- a/backend/component/iam/manager.go
+++ b/backend/component/iam/manager.go
@@ -40,7 +40,7 @@ func (m *Manager) CheckPermission(ctx context.Context, p permission.Permission,
return members
}
- policyMessage, err := m.store.GetWorkspaceIamPolicy(ctx)
+ policyMessage, err := m.store.GetWorkspaceIamPolicySnapshot(ctx)
if err != nil {
return false, err
}
@@ -61,7 +61,7 @@ func (m *Manager) CheckPermission(ctx context.Context, p permission.Permission,
if project == nil {
return false, errors.Errorf("project %q not found", projectID)
}
- policyMessage, err := m.store.GetProjectIamPolicy(ctx, project.ResourceID)
+ policyMessage, err := m.store.GetProjectIamPolicySnapshot(ctx, project.ResourceID)
if err != nil {
return false, err
}
diff --git a/backend/store/policy.go b/backend/store/policy.go
index c981314671..4d4be075bc 100644
--- a/backend/store/policy.go
+++ b/backend/store/policy.go
@@ -24,6 +24,10 @@ type IamPolicyMessage struct {
Etag string
}
+func getIamPolicyCacheKey(resourceType storepb.Policy_Resource, resourceID string) string {
+ return fmt.Sprintf("iam/%s/%s", resourceType, resourceID)
+}
+
// generateEtag generates etag for the given body.
func generateEtag(t time.Time) string {
return fmt.Sprintf("%d", t.UnixMilli())
@@ -31,9 +35,14 @@ func generateEtag(t time.Time) string {
func (s *Store) GetWorkspaceIamPolicy(ctx context.Context) (*IamPolicyMessage, error) {
resourceType := storepb.Policy_WORKSPACE
- return s.getIamPolicy(ctx, &FindPolicyMessage{
+ policy, err := s.getIamPolicy(ctx, &FindPolicyMessage{
ResourceType: &resourceType,
})
+ if err != nil {
+ return nil, err
+ }
+ s.iamPolicyCache.Add(getIamPolicyCacheKey(storepb.Policy_WORKSPACE, ""), policy)
+ return policy, nil
}
type PatchIamPolicyMessage struct {
@@ -93,16 +102,42 @@ func (s *Store) PatchWorkspaceIamPolicy(ctx context.Context, patch *PatchIamPoli
return nil, err
}
+ // Invalidate IAM policy cache after mutation.
+ s.iamPolicyCache.Remove(getIamPolicyCacheKey(storepb.Policy_WORKSPACE, ""))
+
return s.GetWorkspaceIamPolicy(ctx)
}
func (s *Store) GetProjectIamPolicy(ctx context.Context, projectID string) (*IamPolicyMessage, error) {
resourceType := storepb.Policy_PROJECT
resource := common.FormatProject(projectID)
- return s.getIamPolicy(ctx, &FindPolicyMessage{
+ policy, err := s.getIamPolicy(ctx, &FindPolicyMessage{
ResourceType: &resourceType,
Resource: &resource,
})
+ if err != nil {
+ return nil, err
+ }
+ s.iamPolicyCache.Add(getIamPolicyCacheKey(storepb.Policy_PROJECT, projectID), policy)
+ return policy, nil
+}
+
+// GetWorkspaceIamPolicySnapshot returns the workspace IAM policy with snapshot reads (with cache).
+func (s *Store) GetWorkspaceIamPolicySnapshot(ctx context.Context) (*IamPolicyMessage, error) {
+ key := getIamPolicyCacheKey(storepb.Policy_WORKSPACE, "")
+ if v, ok := s.iamPolicyCache.Get(key); ok {
+ return v, nil
+ }
+ return s.GetWorkspaceIamPolicy(ctx)
+}
+
+// GetProjectIamPolicySnapshot returns the project IAM policy with snapshot reads (with cache).
+func (s *Store) GetProjectIamPolicySnapshot(ctx context.Context, projectID string) (*IamPolicyMessage, error) {
+ key := getIamPolicyCacheKey(storepb.Policy_PROJECT, projectID)
+ if v, ok := s.iamPolicyCache.Get(key); ok {
+ return v, nil
+ }
+ return s.GetProjectIamPolicy(ctx, projectID)
}
func (s *Store) getIamPolicy(ctx context.Context, find *FindPolicyMessage) (*IamPolicyMessage, error) {
diff --git a/backend/store/store.go b/backend/store/store.go
index 6b1f6ee148..b35e5723a1 100644
--- a/backend/store/store.go
+++ b/backend/store/store.go
@@ -32,6 +32,7 @@ type Store struct {
groupMembersCache *expirable.LRU[string, map[string]bool]
memberGroupsCache *expirable.LRU[string, []string]
dbSchemaCache *expirable.LRU[string, *model.DatabaseMetadata]
+ iamPolicyCache *expirable.LRU[string, *IamPolicyMessage]
// Large objects.
sheetFullCache *lru.Cache[string, *SheetMessage]
@@ -73,6 +74,7 @@ func New(ctx context.Context, pgURL string, enableCache bool) (*Store, error) {
groupMembersCache := expirable.NewLRU[string, map[string]bool](1024, nil, time.Minute)
memberGroupsCache := expirable.NewLRU[string, []string](4096, nil, time.Minute)
dbSchemaCache := expirable.NewLRU[string, *model.DatabaseMetadata](128, nil, 5*time.Minute)
+ iamPolicyCache := expirable.NewLRU[string, *IamPolicyMessage](1024, nil, time.Minute)
// Initialize database connection (handles both direct URL and file-based)
dbConnManager := NewDBConnectionManager(pgURL)
@@ -97,6 +99,7 @@ func New(ctx context.Context, pgURL string, enableCache bool) (*Store, error) {
groupMembersCache: groupMembersCache,
memberGroupsCache: memberGroupsCache,
dbSchemaCache: dbSchemaCache,
+ iamPolicyCache: iamPolicyCache,
}
return s, nil
@@ -125,6 +128,11 @@ func (s *Store) PurgeGroupCaches() {
s.memberGroupsCache.Purge()
}
+// PurgeIamPolicyCaches purges all IAM policy caches.
+func (s *Store) PurgeIamPolicyCaches() {
+ s.iamPolicyCache.Purge()
+}
+
func getInstanceCacheKey(instanceID string) string {
return instanceID
}