Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: authorize the concrete-project branch of SearchIssues
Danny067db4aa32f2
diff --git a/backend/api/mcp/gen/openapi.yaml b/backend/api/mcp/gen/openapi.yamlindex 29846b828a..49d1ab3488 100644--- a/backend/api/mcp/gen/openapi.yaml+++ b/backend/api/mcp/gen/openapi.yaml@@ -17823,7 +17823,10 @@ components:description: |-The parent, which owns this collection of issues.Format: projects/{project}- Use "projects/-" to list all issues from all projects.+ Use the wildcard "projects/-" to search across collections (AIP-159); the+ result is restricted to the projects where the caller holds+ bb.issues.get. For a concrete project, the caller must hold bb.issues.get+ on that project or the request is denied.pageSize:type: integertitle: page_sizediff --git a/backend/api/v1/issue_service.go b/backend/api/v1/issue_service.goindex 86b4779ec4..158581ccca 100644--- a/backend/api/v1/issue_service.go+++ b/backend/api/v1/issue_service.go@@ -318,15 +318,17 @@ func (s *IssueService) SearchIssues(ctx context.Context, req *connect.Request[v1}issueFind.OrderByKeys = orderByKeys+ user, ok := GetUserFromContext(ctx)+ if !ok {+ return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))+ }++ // This RPC uses CUSTOM auth, so the ACL interceptor performs no permission+ // check: both branches below must authorize the read themselves.var projectIDs []string- if projectID != "-" {- projectIDs = append(projectIDs, projectID)- } else {- // Cross-project search- user, ok := GetUserFromContext(ctx)- if !ok {- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))- }+ if projectID == "-" {+ // AIP-159 wildcard: search across every project where the caller holds+ // the permission. An empty set makes the store return zero rows.projectIDsFilter, err := getProjectIDsSearchFilter(ctx, user, permission.IssuesGet, s.iamManager, s.store)if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get projectIDs"))@@ -334,6 +336,15 @@ func (s *IssueService) SearchIssues(ctx context.Context, req *connect.Request[v1if projectIDsFilter != nil {projectIDs = *projectIDsFilter}+ } else {+ ok, err := s.iamManager.CheckPermission(ctx, permission.IssuesGet, user, common.GetWorkspaceIDFromContext(ctx), projectID)+ if err != nil {+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to check permission %q", permission.IssuesGet))+ }+ if !ok {+ return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q in %q", permission.IssuesGet, req.Msg.Parent))+ }+ projectIDs = append(projectIDs, projectID)}issueFind.ProjectIDs = projectIDsissueFind.ExcludeDraft = truediff --git a/backend/api/v1/issue_service_test.go b/backend/api/v1/issue_service_test.goindex 362c4a4281..a337eed9c4 100644--- a/backend/api/v1/issue_service_test.go+++ b/backend/api/v1/issue_service_test.go@@ -17,6 +17,7 @@ import ("github.com/bytebase/bytebase/backend/common""github.com/bytebase/bytebase/backend/common/testcontainer""github.com/bytebase/bytebase/backend/component/bus"+ "github.com/bytebase/bytebase/backend/component/iam""github.com/bytebase/bytebase/backend/component/review""github.com/bytebase/bytebase/backend/component/webhook"storepb "github.com/bytebase/bytebase/backend/generated-go/store"@@ -1413,6 +1414,15 @@ func setupIssueServiceTestStore(ctx context.Context, t *testing.T) *store.Storestores, err := store.New(ctx, pgURL, false)require.NoError(t, err)t.Cleanup(func() { require.NoError(t, stores.Close()) })++ // SearchIssues authorizes the caller itself (CUSTOM auth), so the test+ // principal needs a role carrying bb.issues.get.+ _, err = stores.PatchWorkspaceIamPolicy(ctx, &store.PatchIamPolicyMessage{+ Workspace: "default",+ Member: common.FormatUserEmail("[email protected]"),+ Roles: []string{"roles/workspaceAdmin"},+ })+ require.NoError(t, err)return stores}@@ -1431,7 +1441,9 @@ func newIssueServiceForTest(t *testing.T, stores *store.Store) *IssueService {b, err := bus.New()require.NoError(t, err)- return NewIssueService(stores, webhook.NewManager(stores, nil), b, nil, nil)+ iamManager, err := iam.NewManager(stores, nil, false)+ require.NoError(t, err)+ return NewIssueService(stores, webhook.NewManager(stores, nil), b, nil, iamManager)}func createIssueServiceApprovalIssue(ctx context.Context, t *testing.T, stores *store.Store) (*store.PlanMessage, *store.IssueMessage) {diff --git a/backend/generated-go/v1/issue_service.pb.go b/backend/generated-go/v1/issue_service.pb.goindex 80fb0a80f2..141e4f090a 100644--- a/backend/generated-go/v1/issue_service.pb.go+++ b/backend/generated-go/v1/issue_service.pb.go@@ -490,7 +490,10 @@ type SearchIssuesRequest struct {state protoimpl.MessageState `protogen:"open.v1"`// The parent, which owns this collection of issues.// Format: projects/{project}- // Use "projects/-" to list all issues from all projects.+ // Use the wildcard "projects/-" to search across collections (AIP-159); the+ // result is restricted to the projects where the caller holds+ // bb.issues.get. For a concrete project, the caller must hold bb.issues.get+ // on that project or the request is denied.Parent string `protobuf:"bytes,1,opt,name=parent,proto3" json:"parent,omitempty"`// The maximum number of issues to return. The service may return fewer than// this value.diff --git a/backend/tests/cross_project_update_test.go b/backend/tests/cross_project_update_test.goindex 2f39ba617b..5b1735f47e 100644--- a/backend/tests/cross_project_update_test.go+++ b/backend/tests/cross_project_update_test.go@@ -322,3 +322,80 @@ func TestCollisionListIssuesIsolation(t *testing.T) {"ListIssues for project A returned an issue from another project: %s", issue.Name)}}++// TestSearchIssuesConcreteProjectAuthorization is the regression lock for+// audit finding T4: SearchIssues uses CUSTOM auth, so the ACL interceptor+// performs no permission check and the handler must authorize both the+// concrete-project and the AIP-159 wildcard branch itself. Before the fix,+// any authenticated workspace member could read every non-draft issue in any+// project by naming that project as the parent.+func TestSearchIssuesConcreteProjectAuthorization(t *testing.T) {+ t.Parallel()+ a := require.New(t)+ ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)+ defer cancel()+ ctl := &controller{}+ ctx, err := ctl.StartServerWithExternalPg(ctx)+ a.NoError(err)+ defer ctl.Close(ctx)++ fixture := setupCollidingProjects(ctx, t, ctl)+ ownerToken := ctl.authInterceptor.token++ // A member of project A only. Project B is off limits for this user.+ memberToken := bot35CreateProjectUser(ctx, t, ctl, fixture.ProjectA.Name, "roles/projectDeveloper", "issue-search-member")++ ctl.authInterceptor.token = memberToken+ // Concrete parent the caller cannot read: denied, not silently served.+ _, err = ctl.issueServiceClient.SearchIssues(ctx,+ connect.NewRequest(&v1pb.SearchIssuesRequest{+ Parent: fixture.ProjectB.Name,+ PageSize: 100,+ }))+ a.Error(err, "SearchIssues on an unauthorized project must fail")+ a.Equal(connect.CodePermissionDenied, connect.CodeOf(err))++ // Concrete parent the caller can read still works.+ allowed, err := ctl.issueServiceClient.SearchIssues(ctx,+ connect.NewRequest(&v1pb.SearchIssuesRequest{+ Parent: fixture.ProjectA.Name,+ PageSize: 100,+ }))+ a.NoError(err, "SearchIssues on an authorized project must succeed")+ a.Greater(len(allowed.Msg.Issues), 0, "project A should have issues (fixture creates them)")+ for _, issue := range allowed.Msg.Issues {+ a.True(strings.HasPrefix(issue.Name, fixture.ProjectA.Name+"/"),+ "SearchIssues for project A returned an issue from another project: %s", issue.Name)+ }++ // The AIP-159 wildcard keeps searching across collections, restricted to+ // the projects the caller can read.+ wildcard, err := ctl.issueServiceClient.SearchIssues(ctx,+ connect.NewRequest(&v1pb.SearchIssuesRequest{+ Parent: "projects/-",+ PageSize: 100,+ }))+ a.NoError(err, "wildcard search must remain available")+ a.Greater(len(wildcard.Msg.Issues), 0, "the caller can read project A's issues")+ for _, issue := range wildcard.Msg.Issues {+ a.False(strings.HasPrefix(issue.Name, fixture.ProjectB.Name+"/"),+ "wildcard search leaked an issue from an unauthorized project: %s", issue.Name)+ }++ // A workspace admin still sees both projects through the wildcard, so the+ // filter narrows by permission rather than always dropping other projects.+ ctl.authInterceptor.token = ownerToken+ adminWildcard, err := ctl.issueServiceClient.SearchIssues(ctx,+ connect.NewRequest(&v1pb.SearchIssuesRequest{+ Parent: "projects/-",+ PageSize: 100,+ }))+ a.NoError(err)+ var sawB bool+ for _, issue := range adminWildcard.Msg.Issues {+ if strings.HasPrefix(issue.Name, fixture.ProjectB.Name+"/") {+ sawB = true+ }+ }+ a.True(sawB, "an admin wildcard search should include project B's issues")+}diff --git a/docs/design/v1-api-audit-2026-08.md b/docs/design/v1-api-audit-2026-08.mdindex 89375002bf..0aa1f05302 100644--- a/docs/design/v1-api-audit-2026-08.md+++ b/docs/design/v1-api-audit-2026-08.md@@ -19,30 +19,8 @@ backend actually does**, which is where everything serious lives.`name`, else `resource`, else `project`, and only if that field carries a `resource_reference`annotation (`backend/api/v1/acl.go:667-685`). Any *second* resource name in the body is invisibleto it. `DiffSchema` (fix already written, patch `04`) was one instance; these are the rest.--### T4 ✅ HIGH — `SearchIssues` performs no authorization for a concrete project--`backend/api/v1/issue_service.go:321-323`:--```go-var projectIDs []string-if projectID != "-" {- projectIDs = append(projectIDs, projectID) // no permission check-} else {- projectIDsFilter, err := getProjectIDsSearchFilter(ctx, user, permission.IssuesGet, ...)-}-```--`auth_method = CUSTOM` makes `doIAMPermissionCheck` return early (`acl.go:246`), and `parent` has-no `resource_reference` (`issue_service.proto:270`) so the resolver yields only the workspace-fallback. `CheckPermission` appears in `issue_service.go` only at `:799` and `:1217` — neither on-this path. `workspaceMember` does not hold `bb.issues.get`.--Perverse detail: the **wildcard** `projects/-` branch is correctly filtered. The concrete-project-branch — the one that looks safe — is the hole. Any authenticated member reads every non-draft-issue in any project: titles, descriptions, creators, labels, risk levels, approval state.--**Fix:** call `CheckPermission(IssuesGet, user, workspaceID, projectID)` on the concrete branch.+The related CUSTOM-auth variant — the interceptor checks nothing at all, so the handler must+authorize every branch itself — was T4 (`SearchIssues`), now fixed.### T5 ✅ HIGH — sheet content is globally readable by SHA256@@ -237,7 +215,7 @@ comment; 22 files have string fields and zero protovalidate constraints despite# What I'd do, in order1. **Runtime-confirm T9.** Eleven bad logins. If the eleventh is accepted, there is no lockout and that outranks everything else here.-2. **Close the multi-resource ACL class, not the instances** (T4–T7 + the pending `DiffSchema` patch): teach `getResourceFromRequest` to collect *every* `resource_reference`d field including oneof and repeated members, then annotate `DiffSchemaRequest.changelog`, `CheckReleaseRequest.targets`, `Revision.release/file/task_run`. `UpdateDatabase`'s project-transfer case (`acl.go:604-624`) is the in-repo precedent.+2. **Close the multi-resource ACL class, not the instances** (T6–T7 + the pending `DiffSchema` patch): teach `getResourceFromRequest` to collect *every* `resource_reference`d field including oneof and repeated members, then annotate `DiffSchemaRequest.changelog`, `CheckReleaseRequest.targets`, `Revision.release/file/task_run`. `UpdateDatabase`'s project-transfer case (`acl.go:604-624`) is the in-repo precedent.3. **Give sheets an ownership model** (T5), or at minimum scope the blob fetch by the owning project/workspace. Until then the sheet namespace is workspace-global by design, and should be documented as such.4. **Fail closed**: reject `AUTH_METHOD_UNSPECIFIED` at startup; make `permission` on a CUSTOM RPC either enforced or a build error, since 20 of them are currently decorative.5. **Wire api-linter into CI** at the 474-finding baseline. None of Tier 5 was visible to `buf lint`'s `BASIC` profile, which is why it accumulated.diff --git a/frontend/src/types/proto-es/v1/issue_service_pb.d.ts b/frontend/src/types/proto-es/v1/issue_service_pb.d.tsindex f5511736b6..51e0ad8833 100644--- a/frontend/src/types/proto-es/v1/issue_service_pb.d.ts+++ b/frontend/src/types/proto-es/v1/issue_service_pb.d.ts@@ -185,7 +185,10 @@ export declare type SearchIssuesRequest = Message<"bytebase.v1.SearchIssuesReque/*** The parent, which owns this collection of issues.* Format: projects/{project}- * Use "projects/-" to list all issues from all projects.+ * Use the wildcard "projects/-" to search across collections (AIP-159); the+ * result is restricted to the projects where the caller holds+ * bb.issues.get. For a concrete project, the caller must hold bb.issues.get+ * on that project or the request is denied.** @generated from field: string parent = 1;*/diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yamlindex f097cd19b7..664e961991 100644--- a/proto/gen/grpc-doc/openapi.yaml+++ b/proto/gen/grpc-doc/openapi.yaml@@ -29129,7 +29129,10 @@ components:description: |-The parent, which owns this collection of issues.Format: projects/{project}- Use "projects/-" to list all issues from all projects.+ Use the wildcard "projects/-" to search across collections (AIP-159); the+ result is restricted to the projects where the caller holds+ bb.issues.get. For a concrete project, the caller must hold bb.issues.get+ on that project or the request is denied.pageSize:type: integertitle: page_sizediff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.mdindex 3a3e1a3ccd..dbfa95e845 100644--- a/proto/gen/grpc-doc/v1/README.md+++ b/proto/gen/grpc-doc/v1/README.md@@ -3608,7 +3608,7 @@ For example: creator == "users/[email protected]" && status in [&#| Field | Type | Label | Description || ----- | ---- | ----- | ----------- |-| parent | [string](#string) | | The parent, which owns this collection of issues. Format: projects/{project} Use "projects/-" to list all issues from all projects. |+| parent | [string](#string) | | The parent, which owns this collection of issues. Format: projects/{project} Use the wildcard "projects/-" to search across collections (AIP-159); the result is restricted to the projects where the caller holds bb.issues.get. For a concrete project, the caller must hold bb.issues.get on that project or the request is denied. || page_size | [int32](#int32) | | The maximum number of issues to return. The service may return fewer than this value. If unspecified, at most 10 issues will be returned. The maximum value is 1000; values above 1000 will be coerced to 1000. || page_token | [string](#string) | | A page token, received from a previous `SearchIssues` call. Provide this to retrieve the subsequent page.diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.htmlindex 87e3159283..21bca5da6c 100644--- a/proto/gen/grpc-doc/v1/index.html+++ b/proto/gen/grpc-doc/v1/index.html@@ -10760,7 +10760,10 @@ Format: users/{email}. </p></td><td></td><td><p>The parent, which owns this collection of issues.Format: projects/{project}-Use "projects/-" to list all issues from all projects. </p></td>+Use the wildcard "projects/-" to search across collections (AIP-159); the+result is restricted to the projects where the caller holds+bb.issues.get. For a concrete project, the caller must hold bb.issues.get+on that project or the request is denied. </p></td></tr><tr>diff --git a/proto/v1/v1/issue_service.proto b/proto/v1/v1/issue_service.protoindex 12a2b69f8d..888c3eed7d 100644--- a/proto/v1/v1/issue_service.proto+++ b/proto/v1/v1/issue_service.proto@@ -266,7 +266,10 @@ message ListIssuesResponse {message SearchIssuesRequest {// The parent, which owns this collection of issues.// Format: projects/{project}- // Use "projects/-" to list all issues from all projects.+ // Use the wildcard "projects/-" to search across collections (AIP-159); the+ // result is restricted to the projects where the caller holds+ // bb.issues.get. For a concrete project, the caller must hold bb.issues.get+ // on that project or the request is denied.string parent = 1 [(google.api.field_behavior) = REQUIRED];// The maximum number of issues to return. The service may return fewer than