Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: return soft-deleted database for get request (#19161)

ecmadao07052012a88b
diff --git a/backend/api/v1/acl.go b/backend/api/v1/acl.go
index 72b4484e5c..f3a5c7505b 100644
--- a/backend/api/v1/acl.go
+++ b/backend/api/v1/acl.go
@@ -275,6 +275,7 @@ func populateRawResources(ctx context.Context, stores *store.Store, authContext
database, err := stores.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return errors.Wrapf(err, "failed to get database")
diff --git a/backend/api/v1/database_catalog_service.go b/backend/api/v1/database_catalog_service.go
index ac4dd17ff4..8b27c5c640 100644
--- a/backend/api/v1/database_catalog_service.go
+++ b/backend/api/v1/database_catalog_service.go
@@ -41,6 +41,7 @@ func (s *DatabaseCatalogService) GetDatabaseCatalog(ctx context.Context, req *co
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))
diff --git a/backend/api/v1/database_service.go b/backend/api/v1/database_service.go
index db0e8eed0d..fd7680b230 100644
--- a/backend/api/v1/database_service.go
+++ b/backend/api/v1/database_service.go
@@ -55,6 +55,7 @@ func (s *DatabaseService) GetDatabase(ctx context.Context, req *connect.Request[
databaseMessage, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))
@@ -94,6 +95,7 @@ func (s *DatabaseService) BatchGetDatabases(ctx context.Context, req *connect.Re
databaseMessage, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))
@@ -535,6 +537,7 @@ func (s *DatabaseService) GetDatabaseMetadata(ctx context.Context, req *connect.
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))
@@ -585,6 +588,7 @@ func (s *DatabaseService) GetDatabaseSchema(ctx context.Context, req *connect.Re
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Errorf("%v", err.Error()))
@@ -629,6 +633,7 @@ func (s *DatabaseService) GetDatabaseSDLSchema(ctx context.Context, req *connect
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Errorf("%v", err.Error()))
@@ -989,6 +994,7 @@ func (s *DatabaseService) GetSchemaString(ctx context.Context, req *connect.Requ
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database %q", req.Msg.Name))
diff --git a/backend/api/v1/database_service_changelog.go b/backend/api/v1/database_service_changelog.go
index c5f4298546..b1ae87a09e 100644
--- a/backend/api/v1/database_service_changelog.go
+++ b/backend/api/v1/database_service_changelog.go
@@ -96,6 +96,7 @@ func (s *DatabaseService) ListChangelogs(ctx context.Context, req *connect.Reque
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))
@@ -172,6 +173,7 @@ func (s *DatabaseService) GetChangelog(ctx context.Context, req *connect.Request
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, err)
diff --git a/backend/api/v1/revision_service.go b/backend/api/v1/revision_service.go
index 15dfe1828a..805b743ff8 100644
--- a/backend/api/v1/revision_service.go
+++ b/backend/api/v1/revision_service.go
@@ -44,6 +44,7 @@ func (s *RevisionService) ListRevisions(
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))
@@ -103,6 +104,7 @@ func (s *RevisionService) GetRevision(
database, err := s.store.GetDatabase(ctx, &store.FindDatabaseMessage{
InstanceID: &instanceID,
DatabaseName: &databaseName,
+ ShowDeleted: true,
})
if err != nil {
return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to get database"))