Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(frontend): the fourth guard, in the commit that wrote the rule

zchpeter07420aba9ede
diff --git a/frontend/src/lib/taskRun.test.ts b/frontend/src/lib/taskRun.test.ts
index 4daf87aae7..973f37d9eb 100644
--- a/frontend/src/lib/taskRun.test.ts
+++ b/frontend/src/lib/taskRun.test.ts
@@ -196,6 +196,19 @@ describe("getTaskRunComment", () => {
});
describe("getTaskRunWaitingMessage", () => {
+ test("names a run scheduled for the epoch rather than hiding it", () => {
+ // A time that is there is a time to name, even this one: the reading that
+ // treated it as absent could only ever be wrong about it.
+ expect(
+ getTaskRunWaitingMessage(
+ makeTaskRun({ runTime: ts(0), status: TaskRun_Status.PENDING }),
+ t
+ )
+ ).toBe(
+ 'task-run.status.enqueued-with-rollout-time:{"time":"Jan 1, 1970, 8:00:00 AM GMT+8"}'
+ );
+ });
+
test("reports waiting states and stays silent otherwise", () => {
expect(
getTaskRunWaitingMessage(
diff --git a/frontend/src/routes/project/plan-detail/components/deploy/DeployTaskRunHistorySheet.test.tsx b/frontend/src/routes/project/plan-detail/components/deploy/DeployTaskRunHistorySheet.test.tsx
index 93514b8253..b7e658d305 100644
--- a/frontend/src/routes/project/plan-detail/components/deploy/DeployTaskRunHistorySheet.test.tsx
+++ b/frontend/src/routes/project/plan-detail/components/deploy/DeployTaskRunHistorySheet.test.tsx
@@ -1,6 +1,6 @@
import { create } from "@bufbuild/protobuf";
import type { MessageInitShape } from "@bufbuild/protobuf";
-import { TimestampSchema, timestampFromMs } from "@bufbuild/protobuf/wkt";
+import { timestampFromMs } from "@bufbuild/protobuf/wkt";
import type { ReactElement, ReactNode } from "react";
import { act } from "react";
import { createRoot } from "react-dom/client";
diff --git a/frontend/src/routes/project/plan-detail/components/review/ReviewActivityTimeline.tsx b/frontend/src/routes/project/plan-detail/components/review/ReviewActivityTimeline.tsx
index 8fbc0f517b..ab8ac18034 100644
--- a/frontend/src/routes/project/plan-detail/components/review/ReviewActivityTimeline.tsx
+++ b/frontend/src/routes/project/plan-detail/components/review/ReviewActivityTimeline.tsx
@@ -317,12 +317,10 @@ function SyntheticHeader({
) : (
<ReviewSubmissionSentence />
)}
- {source.time && (
- <HumanizeTs
- className="text-xs text-control-light"
- tsMs={getTimeForPbTimestampProtoEs(source.time)}
- />
- )}
+ <HumanizeTs
+ className="text-xs text-control-light"
+ tsMs={getTimeForPbTimestampProtoEs(source.time)}
+ />
</>
);
}