Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
docs(design): reset expansion during render, not after it
zchpeter09a2195a90a7
diff --git a/docs/design/task-run-log-previous-attempts.md b/docs/design/task-run-log-previous-attempts.mdindex 0f09e70dcd..06cf6cc5b9 100644--- a/docs/design/task-run-log-previous-attempts.md+++ b/docs/design/task-run-log-previous-attempts.md@@ -243,6 +243,13 @@ supplies. The reset then fires on a marker — rare and meaningful — and neverordinary append. Nothing is expanded at the transition, so nothing opens byitself, and positional ids can stay as they are.+The reset must land in the render that shows the regrouped list. The hook clears+expansion in a passive effect today, which runs after that list has painted, so+for one frame the stale set opens the wrong section. The reset moves into render+instead — clear the sets when the key differs from the one they were built for —+which removes an effect rather than adding one. A remount key would work too, but+only the viewer sees the entries, so its parent cannot supply the marker count.+The cost is bounded. Retries usually arrive faster than the five-second poll, soseveral land in one step and the intermediate state is never rendered; a readerhas to be watching a live run whose `lock_timeout` is long enough to space markers@@ -279,17 +286,18 @@ Implementation follows in a separate PR.- `useTaskRunLogSections.ts`: a third grouping layer alongside the replica andrelease-file layers, and auto-expand restricted to error sections outside thesuperseded attempts. Also the marker count folded into the `datasetKey` the- viewer passes, so expansion clears when a marker regroups the list and no- section opens on its own.+ viewer passes, with the reset moved from its passive effect into render, so+ expansion clears in the same render as the regrouping and no section opens on+ its own.- `TaskRunLogViewer.tsx` and `SectionHeader.tsx`: the umbrella and nested-attemptrows, plus locale keys for the labels.- Tests mirror the truth table and the cutting cases: no marker, one marker,several markers, a marker inside a release-file group, several release-filegroups retrying different numbers of times, replica-grouped entries, an emptyfinal segment, and a prior-backup section that must stay outside attempt 1.- Transition coverage asserts that no section renders expanded after a marker- regroups the list, and that the marker folds the earlier sections without- disturbing the streaming segment.+ Transition coverage asserts that no section renders expanded on the render+ that regroups the list — not merely once effects settle — and that the marker+ folds the earlier sections without disturbing the streaming segment.### Building on #21417