Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(pg): propagate source columns for jsonb_array_elements to prevent masking bypass (#19436)

Vincent Huang0aa46b0739cf
diff --git a/backend/plugin/parser/pg/query_span_extractor.go b/backend/plugin/parser/pg/query_span_extractor.go
index 479080eeca..8b240d3f7f 100644
--- a/backend/plugin/parser/pg/query_span_extractor.go
+++ b/backend/plugin/parser/pg/query_span_extractor.go
@@ -26,6 +26,10 @@ const (
jsonEach = "json_each"
jsonbEachText = "jsonb_each_text"
jsonEachText = "json_each_text"
+ jsonbArrayElements = "jsonb_array_elements"
+ jsonArrayElements = "json_array_elements"
+ jsonbArrayElementsText = "jsonb_array_elements_text"
+ jsonArrayElementsText = "json_array_elements_text"
jsonPopulateRecord = "json_populate_record"
jsonbPopulateRecord = "jsonb_populate_record"
jsonPopulateRecordset = "json_populate_recordset"
@@ -3783,6 +3787,35 @@ func (q *querySpanExtractor) extractTableSourceFromSystemFunctionNew(funcName st
}
tableSource.Name = tableName
return tableSource, nil
+ case jsonbArrayElements, jsonArrayElements, jsonbArrayElementsText, jsonArrayElementsText:
+ // jsonb_array_elements returns a single "value" column (unlike jsonb_each which returns key + value).
+ // SELECT * FROM t, jsonb_array_elements(a) AS elems;
+ var tableSource base.TableSource = &base.PseudoTable{
+ Name: "",
+ Columns: []base.QuerySpanResult{
+ {
+ Name: "value",
+ SourceColumns: make(base.SourceColumnSet, 0),
+ },
+ },
+ }
+ tableSource, err := applyFuncAliasClauseToTableSource(tableSource, alias)
+ if err != nil {
+ return nil, errors.Wrapf(err, "failed to apply alias clause to %s", funcName)
+ }
+
+ if len(args) == 0 {
+ return nil, errors.Errorf("unexpected empty args for function %s", funcName)
+ }
+ fieldArg := args[0]
+ set, err := q.extractSourceColumnSetFromNode(fieldArg)
+ if err != nil {
+ return nil, errors.Wrapf(err, "failed to extract source columns from argument of %s", funcName)
+ }
+ for i := range tableSource.GetQuerySpanResult() {
+ tableSource.GetQuerySpanResult()[i].SourceColumns, _ = base.MergeSourceColumnSet(tableSource.GetQuerySpanResult()[i].SourceColumns, set)
+ }
+ return tableSource, nil
case jsonPopulateRecord, jsonbPopulateRecord, jsonPopulateRecordset, jsonbPopulateRecordset,
jsonToRecord, jsonbToRecord:
return nil, &base.TypeNotSupportedError{
diff --git a/backend/plugin/parser/pg/test-data/query_span.yaml b/backend/plugin/parser/pg/test-data/query_span.yaml
index 2b19ddc978..7b2e15c0db 100644
--- a/backend/plugin/parser/pg/test-data/query_span.yaml
+++ b/backend/plugin/parser/pg/test-data/query_span.yaml
@@ -2910,3 +2910,159 @@
table: users
column: ""
predicatecolumns: []
+- description: jsonb_array_elements as table source
+ statement: SELECT * FROM t, jsonb_array_elements(a) AS elems WHERE id = 1;
+ defaultDatabase: db
+ metadata: |-
+ {
+ "name": "db",
+ "schemas": [
+ {
+ "name": "public",
+ "tables": [
+ {
+ "name": "t",
+ "columns": [
+ {
+ "name": "a"
+ }
+ ]
+ }
+ ]
+ }
+ ]
+ }
+ querySpan:
+ type: 1
+ results:
+ - name: a
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: a
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: value
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: a
+ isplainfield: false
+ sourcefieldpaths: []
+ selectasterisk: false
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: ""
+ predicatecolumns: []
+- description: jsonb_array_elements with column alias
+ statement: SELECT * FROM t, jsonb_array_elements(a) AS elems(val) WHERE id = 1;
+ defaultDatabase: db
+ metadata: |-
+ {
+ "name": "db",
+ "schemas": [
+ {
+ "name": "public",
+ "tables": [
+ {
+ "name": "t",
+ "columns": [
+ {
+ "name": "a"
+ }
+ ]
+ }
+ ]
+ }
+ ]
+ }
+ querySpan:
+ type: 1
+ results:
+ - name: a
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: a
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: val
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: a
+ isplainfield: false
+ sourcefieldpaths: []
+ selectasterisk: false
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: ""
+ predicatecolumns: []
+- description: jsonb_array_elements_text as table source with alias
+ statement: SELECT * FROM t CROSS JOIN LATERAL jsonb_array_elements_text(a) AS part WHERE id = 1;
+ defaultDatabase: db
+ metadata: |-
+ {
+ "name": "db",
+ "schemas": [
+ {
+ "name": "public",
+ "tables": [
+ {
+ "name": "t",
+ "columns": [
+ {
+ "name": "a"
+ }
+ ]
+ }
+ ]
+ }
+ ]
+ }
+ querySpan:
+ type: 1
+ results:
+ - name: a
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: a
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: value
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: a
+ isplainfield: false
+ sourcefieldpaths: []
+ selectasterisk: false
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: t
+ column: ""
+ predicatecolumns: []