Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: improve MongoDB query error handling and bracket notation support (#18017)

h3n4l0ccc6a243f2e
diff --git a/backend/plugin/db/mongodb/mongodb.go b/backend/plugin/db/mongodb/mongodb.go
index 5d54518b9d..52a8b3cd2a 100644
--- a/backend/plugin/db/mongodb/mongodb.go
+++ b/backend/plugin/db/mongodb/mongodb.go
@@ -173,9 +173,11 @@ func (d *Driver) Execute(ctx context.Context, statement string, _ db.ExecuteOpti
mongoshCmd := exec.CommandContext(ctx, "mongosh", mongoshArgs...)
var errContent bytes.Buffer
+ var outContent bytes.Buffer
mongoshCmd.Stderr = &errContent
+ mongoshCmd.Stdout = &outContent
if err := mongoshCmd.Run(); err != nil {
- return 0, errors.Wrapf(err, "failed to execute statement in mongosh: %s", errContent.String())
+ return 0, errors.Wrapf(err, "failed to execute statement in mongosh: \n stdout: %s\n stderr: %s", outContent.String(), errContent.String())
}
return 0, nil
}
@@ -347,6 +349,17 @@ func (d *Driver) QueryConn(ctx context.Context, _ *sql.Conn, statement string, q
shCmd.Stderr = &errContent
shCmd.Stdout = &outContent
if err := shCmd.Run(); err != nil {
+ f, ferr := os.OpenFile(queryResultFileName, os.O_RDONLY, 0644)
+ if ferr == nil {
+ defer f.Close()
+ if content, ferr := io.ReadAll(f); ferr == nil {
+ return []*v1pb.QueryResult{{
+ Latency: durationpb.New(time.Since(startTime)),
+ Statement: statement,
+ Error: string(content),
+ }}, nil
+ }
+ }
return nil, errors.Wrapf(err, "failed to execute statement in mongosh: \n stdout: %s\n stderr: %s", outContent.String(), errContent.String())
}
@@ -443,5 +456,5 @@ func isMongoStatement(statement string) bool {
if strings.HasPrefix(statement, "db.") {
return true
}
- return strings.HasPrefix(statement, `db["`)
+ return strings.HasPrefix(statement, "db[")
}