Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: resolve issue (#18890)

ecmadao0f48b44607df
diff --git a/backend/runner/taskrun/scheduler.go b/backend/runner/taskrun/scheduler.go
index 343b3a31a1..8a7beecb8d 100644
--- a/backend/runner/taskrun/scheduler.go
+++ b/backend/runner/taskrun/scheduler.go
@@ -100,7 +100,8 @@ func (s *Scheduler) runTaskCompletionListener(ctx context.Context) {
}
// checkPlanCompletion checks if all tasks in a plan are complete and successful.
-// If so, sends PIPELINE_COMPLETED webhook.
+// If so, sends PIPELINE_COMPLETED webhook and auto-resolves issues for deferred rollout plans.
+// Deferred rollout plans (exportDataConfig, createDatabaseConfig) auto-resolve when tasks complete.
// Called when tasks are marked DONE/SKIPPED, or when tasks are skipped/canceled via API.
func (s *Scheduler) checkPlanCompletion(ctx context.Context, planID int64) {
// Get all tasks for this plan
@@ -157,4 +158,48 @@ func (s *Scheduler) checkPlanCompletion(ctx context.Context, planID int64) {
Rollout: webhook.NewRollout(plan),
},
})
+
+ // Auto-resolve issue for deferred rollout plans.
+ // Deferred rollout plans are those with only exportDataConfig or createDatabaseConfig specs.
+ // These are simple single-phase operations that don't require manual resolution.
+ if isDeferredRolloutPlan(plan) {
+ s.autoResolveIssue(ctx, planID)
+ }
+}
+
+// isDeferredRolloutPlan returns true if the plan contains only deferred rollout specs
+// (exportDataConfig or createDatabaseConfig).
+func isDeferredRolloutPlan(plan *store.PlanMessage) bool {
+ specs := plan.Config.GetSpecs()
+ if len(specs) == 0 {
+ return false
+ }
+ for _, spec := range specs {
+ if spec.GetExportDataConfig() == nil && spec.GetCreateDatabaseConfig() == nil {
+ return false
+ }
+ }
+ return true
+}
+
+// autoResolveIssue automatically resolves the issue associated with a plan by setting its status to DONE.
+func (s *Scheduler) autoResolveIssue(ctx context.Context, planID int64) {
+ issue, err := s.store.GetIssue(ctx, &store.FindIssueMessage{PlanUID: &planID})
+ if err != nil {
+ slog.Error("failed to get issue for auto-resolve", log.BBError(err))
+ return
+ }
+ if issue == nil {
+ return
+ }
+ if issue.Status != storepb.Issue_OPEN {
+ return
+ }
+
+ newStatus := storepb.Issue_DONE
+ if _, err := s.store.UpdateIssue(ctx, issue.UID, &store.UpdateIssueMessage{Status: &newStatus}); err != nil {
+ slog.Error("failed to auto-resolve issue", slog.Int("issueUID", issue.UID), log.BBError(err))
+ return
+ }
+ slog.Info("auto-resolved deferred rollout issue", slog.Int("issueUID", issue.UID), slog.Int64("planID", planID))
}
diff --git a/frontend/src/components/IssueV1/logic/action/issue.ts b/frontend/src/components/IssueV1/logic/action/issue.ts
index 52459b3c7e..8d093f843d 100644
--- a/frontend/src/components/IssueV1/logic/action/issue.ts
+++ b/frontend/src/components/IssueV1/logic/action/issue.ts
@@ -24,10 +24,7 @@ export const IssueStatusActionToIssueStatusMap: Record<
RESOLVE: IssueStatus.DONE,
};
-export const PossibleIssueStatusActionMap: Record<
- IssueStatus,
- IssueStatusAction[]
-> = {
+const PossibleIssueStatusActionMap: Record<IssueStatus, IssueStatusAction[]> = {
[IssueStatus.OPEN]: ["RESOLVE", "CLOSE"],
[IssueStatus.DONE]: ["REOPEN"],
[IssueStatus.CANCELED]: ["REOPEN"],
diff --git a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/IssueStatusSection.vue b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/IssueStatusSection.vue
index 12ba59281c..c1d9879083 100644
--- a/frontend/src/components/Plan/components/IssueReviewView/Sidebar/IssueStatusSection.vue
+++ b/frontend/src/components/Plan/components/IssueReviewView/Sidebar/IssueStatusSection.vue
@@ -1,5 +1,5 @@
<template>
- <div class="w-full flex flex-row justify-between items-center gap-2">
+ <div v-if="issueStatusText" class="w-full flex flex-row justify-between items-center gap-2">
<h3 class="textlabel">
{{ $t("common.status") }}
</h3>
@@ -26,72 +26,39 @@ const props = defineProps<{
const { t } = useI18n();
+const isRejected = computed(() =>
+ props.issue.approvers.some(
+ (app) => app.status === Issue_Approver_Status.REJECTED
+ )
+);
+
const issueStatusText = computed(() => {
const issueValue = props.issue;
-
- // Show review status instead of just "Open"
- if (issueValue.approvalStatus === Issue_ApprovalStatus.CHECKING) {
- return t("issue.table.open");
+ if (issueValue.status !== IssueStatus.OPEN) {
+ return "";
}
const rolloutReady =
issueValue.approvalStatus === Issue_ApprovalStatus.APPROVED ||
issueValue.approvalStatus === Issue_ApprovalStatus.SKIPPED;
- const reviewStatus = rolloutReady
- ? Issue_Approver_Status.APPROVED
- : issueValue.approvers.some(
- (app) => app.status === Issue_Approver_Status.REJECTED
- )
- ? Issue_Approver_Status.REJECTED
- : Issue_Approver_Status.PENDING;
-
- switch (reviewStatus) {
- case Issue_Approver_Status.APPROVED:
- return t("issue.review.approved");
- case Issue_Approver_Status.REJECTED:
- return t("issue.review.rejected");
- default:
- return t("issue.review.under-review");
+ if (rolloutReady) {
+ return t("issue.review.approved");
+ }
+ if (isRejected.value) {
+ return t("issue.review.rejected");
}
+ return t("issue.review.under-review");
});
const issueStatusTagType = computed(() => {
const issueValue = props.issue;
+ if (issueValue.status !== IssueStatus.OPEN) {
+ return "default";
+ }
- switch (issueValue.status) {
- case IssueStatus.OPEN:
- // Show different colors based on review status
- if (issueValue.approvalStatus === Issue_ApprovalStatus.CHECKING) {
- return "info";
- }
-
- const rolloutReady =
- issueValue.approvalStatus === Issue_ApprovalStatus.APPROVED ||
- issueValue.approvalStatus === Issue_ApprovalStatus.SKIPPED;
- const reviewStatus = rolloutReady
- ? Issue_Approver_Status.APPROVED
- : issueValue.approvers.some(
- (app) => app.status === Issue_Approver_Status.REJECTED
- )
- ? Issue_Approver_Status.REJECTED
- : Issue_Approver_Status.PENDING;
-
- switch (reviewStatus) {
- case Issue_Approver_Status.APPROVED:
- return "success";
- case Issue_Approver_Status.REJECTED:
- return "error";
- case Issue_Approver_Status.PENDING:
- return "warning";
- default:
- return "info";
- }
- case IssueStatus.DONE:
- return "success";
- case IssueStatus.CANCELED:
- return "default";
- default:
- return "default";
+ if (isRejected.value) {
+ return "error";
}
+ return "success";
});
</script>
diff --git a/frontend/src/components/v2/Select/RemoteResourceSelector/index.vue b/frontend/src/components/v2/Select/RemoteResourceSelector/index.vue
index 34d90a8d77..b1e66f64ce 100644
--- a/frontend/src/components/v2/Select/RemoteResourceSelector/index.vue
+++ b/frontend/src/components/v2/Select/RemoteResourceSelector/index.vue
@@ -102,10 +102,17 @@ const searchText = ref("");
const show = ref(false);
const rawOptions = ref([]) as Ref<ResourceSelectOption<T>[]>;
-const appendDataToRawList = (data: ResourceSelectOption<T>[]) => {
+const appendDataToRawList = (
+ data: ResourceSelectOption<T>[],
+ unshift: boolean = false
+) => {
for (const item of data) {
if (!rawOptions.value.find((raw) => raw.value === item.value)) {
- rawOptions.value.unshift(item);
+ if (unshift) {
+ rawOptions.value.unshift(item);
+ } else {
+ rawOptions.value.push(item);
+ }
}
}
};
@@ -118,7 +125,7 @@ watch(
],
([additionalOptions, isLoadingNextPage, searchText]) => {
if (!isLoadingNextPage && !searchText) {
- appendDataToRawList(additionalOptions);
+ appendDataToRawList(additionalOptions, true);
}
},
{ deep: true }