Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

feat: hide specific changelog filters and remove affected tables section (#18405)

Danny Xu0ff0203b9640
diff --git a/frontend/src/components/Changelog/AffectedTablesSelect.vue b/frontend/src/components/Changelog/AffectedTablesSelect.vue
deleted file mode 100644
index ae689d5a52..0000000000
--- a/frontend/src/components/Changelog/AffectedTablesSelect.vue
+++ /dev/null
@@ -1,99 +0,0 @@
-<template>
- <NSelect
- :value="selectedKeys"
- :options="affectedTableOptions"
- filterable
- multiple
- tag
- :placeholder="$t('changelog.select-affection-tables')"
- :render-label="renderLabel"
- @update:value="updateSelectedKey"
- />
-</template>
-
-<script setup lang="tsx">
-import type { SelectOption } from "naive-ui";
-import { NSelect } from "naive-ui";
-import { computed } from "vue";
-import { useDBSchemaV1Store } from "@/store";
-import { type ComposedDatabase, type Table } from "@/types";
-
-type AffectedTablesSelectOption = SelectOption & {
- table: Table;
- value: string;
-};
-
-const props = defineProps<{
- database: ComposedDatabase;
- tables?: Table[];
-}>();
-
-const emit = defineEmits<{
- (event: "update:tables", tables?: Table[]): void;
-}>();
-
-const dbSchemaStore = useDBSchemaV1Store();
-
-const metadata = computed(() => {
- return dbSchemaStore.getDatabaseMetadata(props.database.name);
-});
-
-const affectedTables = computed((): Table[] => {
- return metadata.value.schemas
- .map((schema) =>
- schema.tables.map((table) => ({
- schema: schema.name,
- table: table.name,
- }))
- )
- .flat();
-});
-
-const affectedTableOptions = computed(() => {
- return affectedTables.value.map<AffectedTablesSelectOption>((table) => {
- return {
- value: stringifyTable(table),
- table: table,
- };
- });
-});
-
-const renderLabel = (option: SelectOption) => {
- const { table, label } = option as AffectedTablesSelectOption;
- if (!table) return String(label);
- return <span class="truncate">{stringifyTable(table)}</span>;
-};
-
-const selectedKeys = computed(() => {
- return props.tables?.map((table) => stringifyTable(table)) || [];
-});
-
-const updateSelectedKey = (
- _: string,
- options: AffectedTablesSelectOption[]
-) => {
- emit(
- "update:tables",
- options.map((option) => {
- const { table, label } = option;
- if (table) return table;
-
- let schema = "";
- let tableName = String(label);
- if (tableName.includes(".")) {
- schema = tableName.split(".")[0];
- tableName = tableName.split(".").slice(1).join(".");
- }
- return { schema, table: tableName };
- })
- );
-};
-
-const stringifyTable = (table: Table) => {
- const { schema, table: tableName } = table;
- if (schema !== "") {
- return `${schema}.${tableName}`;
- }
- return tableName;
-};
-</script>
diff --git a/frontend/src/components/Changelog/ChangelogDataTable.vue b/frontend/src/components/Changelog/ChangelogDataTable.vue
index 4cb824fd62..c684e67248 100644
--- a/frontend/src/components/Changelog/ChangelogDataTable.vue
+++ b/frontend/src/components/Changelog/ChangelogDataTable.vue
@@ -24,12 +24,8 @@ import {
Changelog_Status,
Changelog_Type,
} from "@/types/proto-es/v1/database_service_pb";
-import { extractIssueUID, getAffectedTableDisplayName } from "@/utils";
-import {
- changelogLink,
- getAffectedTablesOfChangelog,
- getChangelogChangeType,
-} from "@/utils/v1/changelog";
+import { extractIssueUID } from "@/utils";
+import { changelogLink, getChangelogChangeType } from "@/utils/v1/changelog";
import HumanizeDate from "../misc/HumanizeDate.vue";
import ChangelogStatusIcon from "./ChangelogStatusIcon.vue";
@@ -119,26 +115,6 @@ const columnList = computed(() => {
resizable: true,
render: (changelog) => changelog.version || "-",
},
- {
- key: "tables",
- title: t("db.tables"),
- width: "15rem",
- resizable: true,
- ellipsis: true,
- render: (changelog) => {
- const tables = getAffectedTablesOfChangelog(changelog);
- if (tables.length === 0) return "-";
- return (
- <p class="flex gap-x-2 truncate">
- {tables.map((table) => (
- <span class={table.dropped ? "text-gray-400 italic" : ""}>
- {getAffectedTableDisplayName(table)}
- </span>
- ))}
- </p>
- );
- },
- },
{
key: "statement",
title: t("common.statement"),
diff --git a/frontend/src/components/Changelog/ChangelogDetail.vue b/frontend/src/components/Changelog/ChangelogDetail.vue
index 44bca95b3b..1d5493b506 100644
--- a/frontend/src/components/Changelog/ChangelogDetail.vue
+++ b/frontend/src/components/Changelog/ChangelogDetail.vue
@@ -48,24 +48,6 @@
</div>
<div class="flex flex-col gap-y-6">
- <div v-if="affectedTables.length > 0">
- <span class="flex items-center text-lg text-main capitalize">
- {{ $t("changelog.affected-tables") }}
- </span>
- <div class="flex flex-wrap gap-x-3 gap-y-2">
- <span
- v-for="(affectedTable, i) in affectedTables"
- :key="`${i}.${affectedTable.schema}.${affectedTable.table}`"
- :class="[
- !affectedTable.dropped
- ? 'text-blue-600 cursor-pointer'
- : 'mb-2 text-gray-400 italic',
- ]"
- >
- {{ getAffectedTableDisplayName(affectedTable) }}
- </span>
- </div>
- </div>
<div class="flex flex-col gap-y-2">
<p class="flex items-center text-lg text-main capitalize gap-x-2">
{{ $t("common.statement") }}
@@ -146,15 +128,11 @@ import {
} from "@/types/proto-es/v1/database_service_pb";
import {
extractIssueUID,
- getAffectedTableDisplayName,
getStatementSize,
hasProjectPermissionV2,
wrapRefAsPromise,
} from "@/utils";
-import {
- getAffectedTablesOfChangelog,
- getChangelogChangeType,
-} from "@/utils/v1/changelog";
+import { getChangelogChangeType } from "@/utils/v1/changelog";
import NoPermissionPlaceholder from "../misc/NoPermissionPlaceholder.vue";
import ChangelogStatusIcon from "./ChangelogStatusIcon.vue";
@@ -210,13 +188,6 @@ const changelogStatement = computed(() => {
return statement;
});
-const affectedTables = computed(() => {
- if (changelog.value === undefined) {
- return [];
- }
- return getAffectedTablesOfChangelog(changelog.value);
-});
-
const showSchemaSnapshot = computed(() => {
return true;
});
diff --git a/frontend/src/components/Changelog/index.ts b/frontend/src/components/Changelog/index.ts
index 7f48be1e9b..e35be7d5a0 100644
--- a/frontend/src/components/Changelog/index.ts
+++ b/frontend/src/components/Changelog/index.ts
@@ -1,11 +1,5 @@
-import AffectedTablesSelect from "./AffectedTablesSelect.vue";
import ChangelogDataTable from "./ChangelogDataTable.vue";
import ChangelogDetail from "./ChangelogDetail.vue";
import ChangelogStatusIcon from "./ChangelogStatusIcon.vue";
-export {
- ChangelogDetail,
- ChangelogStatusIcon,
- ChangelogDataTable,
- AffectedTablesSelect,
-};
+export { ChangelogDetail, ChangelogStatusIcon, ChangelogDataTable };
diff --git a/frontend/src/components/Database/DatabaseChangelogPanel.vue b/frontend/src/components/Database/DatabaseChangelogPanel.vue
index b1e8d455e1..6fed881886 100644
--- a/frontend/src/components/Database/DatabaseChangelogPanel.vue
+++ b/frontend/src/components/Database/DatabaseChangelogPanel.vue
@@ -1,14 +1,5 @@
<template>
<div class="flex flex-col gap-y-4" v-bind="$attrs">
- <div class="w-full flex flex-row justify-between items-center gap-x-2">
- <div class="flex flex-row justify-start items-center gap-x-4">
- <div class="w-52">
- <AffectedTablesSelect
- v-model:tables="state.selectedAffectedTables"
- :database="database"
- />
- </div>
- </div>
<div class="flex flex-row justify-end items-center grow gap-x-2">
<BBSpin
v-if="state.loading"
@@ -69,7 +60,7 @@
</template>
</TooltipButton>
</div>
- </div>
+
<PagedTable
ref="changedlogPagedTable"
@@ -111,15 +102,12 @@ import { FieldMaskSchema } from "@bufbuild/protobuf/wkt";
import dayjs from "dayjs";
import saveAs from "file-saver";
import JSZip from "jszip";
-import { computed, reactive, ref, watch } from "vue";
+import { computed, reactive, ref } from "vue";
import type { ComponentExposed } from "vue-component-type-helpers";
import { useI18n } from "vue-i18n";
import { useRouter } from "vue-router";
import { BBAlert, BBSpin } from "@/bbkit";
-import {
- AffectedTablesSelect,
- ChangelogDataTable,
-} from "@/components/Changelog";
+import { ChangelogDataTable } from "@/components/Changelog";
import { useDatabaseDetailContext } from "@/components/Database/context";
import { TooltipButton } from "@/components/v2";
import PagedTable from "@/components/v2/Model/PagedTable.vue";
@@ -129,7 +117,7 @@ import {
useChangelogStore,
useDatabaseV1Store,
} from "@/store";
-import type { ComposedDatabase, SearchChangeLogParams, Table } from "@/types";
+import type { ComposedDatabase } from "@/types";
import { DEFAULT_PROJECT_NAME } from "@/types";
import type { Changelog } from "@/types/proto-es/v1/database_service_pb";
import {
@@ -146,7 +134,6 @@ interface LocalState {
loading: boolean;
selectedChangelogNames: string[];
isExporting: boolean;
- selectedAffectedTables: Table[];
}
const props = defineProps<{
@@ -165,26 +152,10 @@ const state = reactive<LocalState>({
loading: false,
selectedChangelogNames: [],
isExporting: false,
- selectedAffectedTables: [],
});
-const searchChangeLogParams = computed(
- (): SearchChangeLogParams => ({
- tables: state.selectedAffectedTables,
- })
-);
-
const searchChangelogFilter = computed(() => {
- const filter: string[] = [];
- if (
- searchChangeLogParams.value.tables &&
- searchChangeLogParams.value.tables.length > 0
- ) {
- filter.push(
- `table = "${searchChangeLogParams.value.tables.map((table) => `tableExists('${props.database.databaseName}', '${table.schema}', '${table.table}')`).join(" || ")}"`
- );
- }
- return filter.join(" && ");
+ return "";
});
const fetchChangelogList = async ({
@@ -208,11 +179,6 @@ const fetchChangelogList = async ({
};
};
-watch(
- () => searchChangelogFilter.value,
- () => changedlogPagedTable.value?.refresh()
-);
-
const { allowAlterSchema } = useDatabaseDetailContext();
const allowExportChangelog = computed(() => {
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index cae008f41b..460fe51f0f 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -1626,9 +1626,7 @@
"establish-database-baseline": "Establish \"{name}\" baseline",
"export": "Export Changelog",
"need-to-select-first": "Need to select changelog first",
- "all-tables": "All tables",
- "affected-tables": "Affected Tables",
- "select-affection-tables": "Select affected tables",
+
"rollback-tip": "Select a specific DDL changelog to rollback."
},
"database": {
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index ce5aeaf3a7..f0eddef395 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -1626,9 +1626,7 @@
"establish-database-baseline": "Establecer línea base de \"{name}\"",
"export": "Exportar historial de cambios",
"need-to-select-first": "Necesita seleccionar primero el historial de cambios",
- "all-tables": "Todas las tablas",
- "affected-tables": "Tablas afectadas",
- "select-affection-tables": "Seleccionar tablas afectadas",
+
"rollback-tip": "Seleccione un historial de DDL específico para revertir."
},
"database": {
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index fef131fc41..72018694c7 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -1626,9 +1626,7 @@
"establish-database-baseline": "ベースライン「{name}」を作成します",
"export": "変更履歴のエクスポート",
"need-to-select-first": "最初に変更履歴を選択する必要があります",
- "all-tables": "すべてのテーブル",
- "affected-tables": "影響を受けるテーブル",
- "select-affection-tables": "影響を受けるテーブルを選択",
+
"rollback-tip": "ロールバックする特定の DDL 履歴を選択します。"
},
"database": {
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index d1de79683e..9bfd04b858 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -1626,9 +1626,7 @@
"establish-database-baseline": "Thiết lập đường cơ sở \"{name}\"",
"export": "Xuất Nhật ký thay đổi",
"need-to-select-first": "Cần chọn nhật ký thay đổi trước",
- "all-tables": "Tất cả các bảng",
- "affected-tables": "Bảng bị ảnh hưởng",
- "select-affection-tables": "Chọn bảng bị ảnh hưởng",
+
"rollback-tip": "Chọn một nhật ký thay đổi DDL cụ thể để hoàn tác."
},
"database": {
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index 821b0452c9..beee0be960 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -1626,9 +1626,7 @@
"establish-database-baseline": "建立「{name}」基线",
"export": "导出变更历史",
"need-to-select-first": "需要先选择变更历史",
- "all-tables": "所有表",
- "affected-tables": "受影响的表",
- "select-affection-tables": "选择受影响的表",
+
"rollback-tip": "选择要回滚到的某个 DDL 历史记录。"
},
"database": {
diff --git a/frontend/src/utils/v1/changelog.ts b/frontend/src/utils/v1/changelog.ts
index 613e270d05..f8d4da4df9 100644
--- a/frontend/src/utils/v1/changelog.ts
+++ b/frontend/src/utils/v1/changelog.ts
@@ -1,9 +1,8 @@
import { create } from "@bufbuild/protobuf";
-import { isEqual, isUndefined, orderBy, uniqBy } from "lodash-es";
import { t } from "@/plugins/i18n";
-import { useDatabaseV1Store, useDBSchemaV1Store } from "@/store";
+import { useDatabaseV1Store } from "@/store";
import type { ComposedDatabase } from "@/types";
-import { type AffectedTable, EmptyAffectedTable, UNKNOWN_ID } from "@/types";
+import { UNKNOWN_ID } from "@/types";
import type { Changelog } from "@/types/proto-es/v1/database_service_pb";
import {
Changelog_Type,
@@ -45,57 +44,6 @@ export const changelogLink = (changelog: Changelog): string => {
);
};
-export const getAffectedTablesOfChangelog = (
- changelog: Changelog
-): AffectedTable[] => {
- const { databaseName } = extractDatabaseNameAndChangelogUID(changelog.name);
- const database = useDatabaseV1Store().getDatabaseByName(databaseName);
- const metadata = useDBSchemaV1Store().getDatabaseMetadata(database.name);
- return uniqBy(
- orderBy(
- changelog.changedResources?.databases
- .find((db) => db.name === database.databaseName)
- ?.schemas.map((schema) => {
- return schema.tables.map((table) => {
- const dropped = isUndefined(
- metadata.schemas
- .find((s) => s.name === schema.name)
- ?.tables.find((t) => t.name === table.name)
- );
- return {
- schema: schema.name,
- table: table.name,
- dropped,
- };
- });
- })
- .flat() || [],
- ["dropped"]
- ),
- (affectedTable) => `${affectedTable.schema}.${affectedTable.table}`
- );
-};
-
-export const stringifyAffectedTable = (affectedTable: AffectedTable) => {
- const { schema, table } = affectedTable;
- if (schema !== "") {
- return `${schema}.${table}`;
- }
- return table;
-};
-
-export const getAffectedTableDisplayName = (affectedTable: AffectedTable) => {
- if (isEqual(affectedTable, EmptyAffectedTable)) {
- return t("changelog.all-tables");
- }
-
- let name = stringifyAffectedTable(affectedTable);
- if (affectedTable.dropped) {
- name = `${name}(deleted)`;
- }
- return name;
-};
-
export const mockLatestChangelog = (
database: ComposedDatabase,
schema: string = ""