Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor: extract banner section into separate component (#17717)
boojack11e45da9e404
diff --git a/frontend/src/components/Plan/components/BannerSection/BannerSection.vue b/frontend/src/components/Plan/components/BannerSection/BannerSection.vuenew file mode 100644index 0000000000..473170aaf6--- /dev/null+++ b/frontend/src/components/Plan/components/BannerSection/BannerSection.vue@@ -0,0 +1,130 @@+<template>+ <div>+ <div+ v-show="showClosedBanner"+ class="h-8 w-full text-base font-medium bg-gray-400 text-white flex justify-center items-center shrink-0"+ >+ {{ $t("common.closed") }}+ </div>+ <div+ v-show="showSuccessBanner"+ class="h-8 w-full text-base font-medium bg-success text-white flex justify-center items-center shrink-0"+ >+ {{ $t("common.done") }}+ </div>+ <div+ v-show="showReadyForRollout"+ class="h-8 w-full text-base font-medium bg-accent text-white flex justify-center items-center shrink-0"+ >+ <NButton+ text+ class="!text-white hover:opacity-80"+ :icon-placement="'right'"+ @click="handleGoToRollout"+ >+ {{ $t("issue.approval.approved-and-waiting-for-rollout") }}+ <template #icon>+ <ArrowRightIcon class="w-4 h-4" />+ </template>+ </NButton>+ </div>+ </div>+</template>++<script lang="ts" setup>+import { ArrowRightIcon } from "lucide-vue-next";+import { NButton } from "naive-ui";+import { computed } from "vue";+import { useRouter } from "vue-router";+import { usePlanContext } from "@/components/Plan";+import { PROJECT_V1_ROUTE_ROLLOUT_DETAIL } from "@/router/dashboard/projectV1";+import { State } from "@/types/proto-es/v1/common_pb";+import {+ IssueStatus,+ Issue_ApprovalStatus,+ Issue_Type,+} from "@/types/proto-es/v1/issue_service_pb";+import { Task_Status, Task_Type } from "@/types/proto-es/v1/rollout_service_pb";+import {+ activeTaskInRollout,+ extractProjectResourceName,+ extractRolloutUID,+} from "@/utils";++const props = defineProps<{+ currentTab: string;+}>();++const router = useRouter();+const { plan, issue, rollout } = usePlanContext();++const showClosedBanner = computed(() => {+ return (+ plan.value.state === State.DELETED ||+ (issue.value && issue.value.status === IssueStatus.CANCELED)+ );+});++const showSuccessBanner = computed(() => {+ return issue.value && issue.value.status === IssueStatus.DONE;+});++const showReadyForRollout = computed(() => {+ // Only show for OPEN issues+ if (!issue.value || issue.value.status !== IssueStatus.OPEN) return false;++ // Only show for database change issues+ if (issue.value.type !== Issue_Type.DATABASE_CHANGE) return false;++ // Check if issue is approved+ if (+ issue.value.approvalStatus !== Issue_ApprovalStatus.APPROVED &&+ issue.value.approvalStatus !== Issue_ApprovalStatus.SKIPPED+ ) {+ return false;+ }++ // Hide if on rollout tab+ if (props.currentTab === "rollout") {+ return false;+ }++ if (!rollout.value) {+ return false;+ }++ // Don't show for rollouts with database creation/export tasks+ const hasDatabaseCreateOrExportTasks = rollout.value.stages.some((stage) =>+ stage.tasks.some(+ (task) =>+ task.type === Task_Type.DATABASE_CREATE ||+ task.type === Task_Type.DATABASE_EXPORT+ )+ );+ if (hasDatabaseCreateOrExportTasks) {+ return false;+ }++ // Check if there's an active task that needs action+ const activeTask = activeTaskInRollout(rollout.value);+ return (+ activeTask.status === Task_Status.NOT_STARTED ||+ activeTask.status === Task_Status.PENDING ||+ activeTask.status === Task_Status.RUNNING ||+ activeTask.status === Task_Status.FAILED ||+ activeTask.status === Task_Status.CANCELED+ );+});++const handleGoToRollout = () => {+ if (!rollout.value) return;++ router.push({+ name: PROJECT_V1_ROUTE_ROLLOUT_DETAIL,+ params: {+ projectId: extractProjectResourceName(plan.value.name),+ rolloutId: extractRolloutUID(rollout.value.name),+ },+ });+};+</script>diff --git a/frontend/src/components/Plan/components/BannerSection/index.ts b/frontend/src/components/Plan/components/BannerSection/index.tsnew file mode 100644index 0000000000..120e113f66--- /dev/null+++ b/frontend/src/components/Plan/components/BannerSection/index.ts@@ -0,0 +1,3 @@+import BannerSection from "./BannerSection.vue";++export default BannerSection;diff --git a/frontend/src/components/Plan/components/index.ts b/frontend/src/components/Plan/components/index.tsindex 2e67011ce0..2d5cdf7558 100644--- a/frontend/src/components/Plan/components/index.ts+++ b/frontend/src/components/Plan/components/index.ts@@ -1,3 +1,4 @@+import BannerSection from "./BannerSection";import { ChecksView } from "./ChecksView";import HeaderSection from "./HeaderSection";import SQLCheckSection from "./SQLCheckSection";@@ -5,6 +6,7 @@ import SpecDetailView from "./SpecDetailView";import StatementSection from "./StatementSection";export {+ BannerSection,ChecksView,HeaderSection,SpecDetailView,diff --git a/frontend/src/views/project/CICDLayout.vue b/frontend/src/views/project/CICDLayout.vueindex 62043d5203..044b7ff591 100644--- a/frontend/src/views/project/CICDLayout.vue+++ b/frontend/src/views/project/CICDLayout.vue@@ -3,37 +3,7 @@<template v-if="ready"><PollerProvider><div class="h-full flex flex-col">- <!-- Banner Section -->- <template v-if="showBanner">- <div- v-if="showClosedBanner"- class="h-8 w-full text-base font-medium bg-gray-400 text-white flex justify-center items-center shrink-0"- >- {{ $t("common.closed") }}- </div>- <div- v-else-if="showSuccessBanner"- class="h-8 w-full text-base font-medium bg-success text-white flex justify-center items-center shrink-0"- >- {{ $t("common.done") }}- </div>- <div- v-else-if="showReadyForRollout"- class="h-8 w-full text-base font-medium bg-accent text-white flex justify-center items-center shrink-0"- >- <NButton- text- class="!text-white hover:opacity-80"- :icon-placement="'right'"- @click="goToRollout"- >- {{ $t("issue.approval.approved-and-waiting-for-rollout") }}- <template #icon>- <ArrowRightIcon class="w-4 h-4" />- </template>- </NButton>- </div>- </template>+ <BannerSection :current-tab="tabKey" /><HeaderSection />@@ -79,13 +49,8 @@<script lang="tsx" setup>import { useTitle } from "@vueuse/core";-import {- ArrowRightIcon,- CirclePlayIcon,- FileDiffIcon,- Layers2Icon,-} from "lucide-vue-next";-import { NButton, NSpin, NTab, NTabs, NTag } from "naive-ui";+import { CirclePlayIcon, FileDiffIcon, Layers2Icon } from "lucide-vue-next";+import { NSpin, NTab, NTabs, NTag } from "naive-ui";import { computed, ref, toRef, watch } from "vue";import { useI18n } from "vue-i18n";import {@@ -100,7 +65,7 @@ import {useInitializePlan,} from "@/components/Plan";import PollerProvider from "@/components/Plan/PollerProvider.vue";-import { HeaderSection } from "@/components/Plan/components";+import { BannerSection, HeaderSection } from "@/components/Plan/components";import RefreshIndicator from "@/components/Plan/components/RefreshIndicator.vue";import { provideSidebarContext } from "@/components/Plan/logic/sidebar";import { useNavigationGuard } from "@/components/Plan/logic/useNavigationGuard";@@ -116,15 +81,7 @@ import {PROJECT_V1_ROUTE_ROLLOUT_DETAIL_STAGE_DETAIL,PROJECT_V1_ROUTE_ROLLOUT_DETAIL_TASK_DETAIL,} from "@/router/dashboard/projectV1";-import { State } from "@/types/proto-es/v1/common_pb";-import {- IssueStatus,- Issue_ApprovalStatus,- Issue_Type,-} from "@/types/proto-es/v1/issue_service_pb";-import { Task_Status, Task_Type } from "@/types/proto-es/v1/rollout_service_pb";import {- activeTaskInRollout,extractIssueUID,extractPlanUID,extractProjectResourceName,@@ -370,85 +327,6 @@ const documentTitle = computed(() => {return t("common.loading");});-// Banner conditions-const showClosedBanner = computed(() => {- return (- plan.value.state === State.DELETED ||- (issue.value && issue.value.status === IssueStatus.CANCELED)- );-});--const showSuccessBanner = computed(() => {- return issue.value && issue.value.status === IssueStatus.DONE;-});--const showReadyForRollout = computed(() => {- // Only show for OPEN issues- if (!issue.value || issue.value.status !== IssueStatus.OPEN) return false;-- // Only show for database change issues- if (issue.value.type !== Issue_Type.DATABASE_CHANGE) return false;-- // Check if issue is approved- if (- issue.value.approvalStatus !== Issue_ApprovalStatus.APPROVED &&- issue.value.approvalStatus !== Issue_ApprovalStatus.SKIPPED- ) {- return false;- }-- // Hide if on rollout tab- if (tabKey.value === TabKey.Rollout) {- return false;- }-- if (!rollout.value) {- return false;- }-- // Don't show for rollouts with database creation/export tasks- const hasDatabaseCreateOrExportTasks = rollout.value.stages.some((stage) =>- stage.tasks.some(- (task) =>- task.type === Task_Type.DATABASE_CREATE ||- task.type === Task_Type.DATABASE_EXPORT- )- );- if (hasDatabaseCreateOrExportTasks) {- return false;- }-- // Check if there's an active task that needs action- const activeTask = activeTaskInRollout(rollout.value);- return (- activeTask.status === Task_Status.NOT_STARTED ||- activeTask.status === Task_Status.PENDING ||- activeTask.status === Task_Status.RUNNING ||- activeTask.status === Task_Status.FAILED ||- activeTask.status === Task_Status.CANCELED- );-});--const showBanner = computed(() => {- return (- showClosedBanner.value ||- showSuccessBanner.value ||- showReadyForRollout.value- );-});--const goToRollout = () => {- if (!rollout.value) return;-- router.push({- name: PROJECT_V1_ROUTE_ROLLOUT_DETAIL,- params: {- projectId: extractProjectResourceName(plan.value.name),- rolloutId: extractRolloutUID(rollout.value.name),- },- });-};-useTitle(documentTitle);// Set up navigation guards to check for unsaved changes