Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(frontend): clean up project members page and masking exemption permissions (#19869)
Danny Xu15018e92840c
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex c91a967fb1..f13f99321e 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -1980,7 +1980,6 @@"description": "Project members determine the permission to operate database and issues inside the project. Project Owner, Workspace Admin and Workspace DBA all have full project permissions.","never-expires": "Never","role-never-expires": "This role never expires.",- "add-more": "Add more","workspace-level-roles": "Workspace level roles","roles-are-filtered-by-permissions": "Roles are filtered by the permissions","allow-ddl": "Allow running DDL/DML statements in the selected environments."diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex 35e677f53e..0b0a03076c 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -1980,7 +1980,6 @@"description": "Los miembros del proyecto determinan el permiso para operar la base de datos y los problemas dentro del proyecto. El propietario del proyecto, el administrador del espacio de trabajo y el DBA del espacio de trabajo tienen permisos completos para el proyecto.","never-expires": "Nunca caduca","role-never-expires": "Este rol nunca expira.",- "add-more": "Agregar más","workspace-level-roles": "Roles a nivel de espacio de trabajo","roles-are-filtered-by-permissions": "Roles are filtered by the permissions","allow-ddl": "Permitir ejecutar sentencias DDL/DML en los entornos seleccionados."diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex 584553578d..00f66e5e61 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -1980,7 +1980,6 @@"description": "プロジェクトメンバーのロールにより、プロジェクト内のデータベースとイシューを操作するための権限が決まります。プロジェクト所有者、ワークスペース管理者、および DBA はすべて、プロジェクトに対する完全な権限を持っています。","never-expires": "有効期限が切れることはありません","role-never-expires": "このロールには有効期限はありません。",- "add-more": "さらに追加","workspace-level-roles": "ワークスペースレベルのロール","roles-are-filtered-by-permissions": "Roles are filtered by the permissions","allow-ddl": "選択した環境で DDL/DML ステートメントの実行を許可する。"diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex ad2fe6900d..321639acd5 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -1980,7 +1980,6 @@"description": "Thành viên dự án xác định quyền để vận hành cơ sở dữ liệu và các vấn đề bên trong dự án. Chủ sở hữu dự án, Quản trị viên không gian làm việc và DBA không gian làm việc đều có toàn quyền dự án.","never-expires": "Không bao giờ","role-never-expires": "Vai trò này không bao giờ hết hạn.",- "add-more": "Thêm","workspace-level-roles": "Vai trò cấp độ không gian làm việc","roles-are-filtered-by-permissions": "Roles are filtered by the permissions","allow-ddl": "Cho phép chạy câu lệnh DDL/DML trong các môi trường đã chọn."diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex 589f00d393..93f4505a1f 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -1980,7 +1980,6 @@"description": "项目成员角色决定了操作项目中的数据库和工单的权限。项目的所有者,工作空间管理员和 DBA 都具有项目所有的权限。","never-expires": "永不过期","role-never-expires": "此角色没有过期时间。",- "add-more": "增加更多","workspace-level-roles": "工作空间级别角色","roles-are-filtered-by-permissions": "角色已按权限筛选","allow-ddl": "允许在所选环境中执行 DDL/DML 语句。"diff --git a/frontend/src/react/locales/en-US.json b/frontend/src/react/locales/en-US.jsonindex 036eda1011..0e4e96c388 100644--- a/frontend/src/react/locales/en-US.json+++ b/frontend/src/react/locales/en-US.json@@ -485,7 +485,6 @@},"filter-projects": "Filter projects","members": {- "add-more": "Add more","allow-ddl": "Allow running DDL/DML statements in the selected environments.","description": "Project members determine the permission to operate database and issues inside the project. Project Owner, Workspace Admin and Workspace DBA all have full project permissions.","disallow-ddl-all-environments": "Disallow running DDL/DML statements for all environments.",diff --git a/frontend/src/react/locales/es-ES.json b/frontend/src/react/locales/es-ES.jsonindex de7b8807cb..d045a109ea 100644--- a/frontend/src/react/locales/es-ES.json+++ b/frontend/src/react/locales/es-ES.json@@ -485,7 +485,6 @@},"filter-projects": "Filtrar proyectos","members": {- "add-more": "Add more","allow-ddl": "Permitir ejecutar sentencias DDL/DML en los entornos seleccionados.","description": "Los miembros del proyecto determinan el permiso para operar la base de datos y los problemas dentro del proyecto. El propietario del proyecto, el administrador del espacio de trabajo y el DBA del espacio de trabajo tienen permisos completos para el proyecto.","disallow-ddl-all-environments": "No permitir ejecutar sentencias DDL/DML en ningún entorno.",diff --git a/frontend/src/react/locales/ja-JP.json b/frontend/src/react/locales/ja-JP.jsonindex ae5f35f1a1..1ebd1c0854 100644--- a/frontend/src/react/locales/ja-JP.json+++ b/frontend/src/react/locales/ja-JP.json@@ -485,7 +485,6 @@},"filter-projects": "プロジェクトをフィルタリング","members": {- "add-more": "Add more","allow-ddl": "選択した環境で DDL/DML ステートメントの実行を許可する。","description": "プロジェクトメンバーのロールにより、プロジェクト内のデータベースとイシューを操作するための権限が決まります。プロジェクト所有者、ワークスペース管理者、および DBA はすべて、プロジェクトに対する完全な権限を持っています。","disallow-ddl-all-environments": "すべての環境で DDL/DML ステートメントの実行を禁止する。",diff --git a/frontend/src/react/locales/vi-VN.json b/frontend/src/react/locales/vi-VN.jsonindex 1f34ec9aa7..aff81451c4 100644--- a/frontend/src/react/locales/vi-VN.json+++ b/frontend/src/react/locales/vi-VN.json@@ -485,7 +485,6 @@},"filter-projects": "Lọc dự án","members": {- "add-more": "Add more","allow-ddl": "Cho phép chạy câu lệnh DDL/DML trong các môi trường đã chọn.","description": "Thành viên dự án xác định quyền để vận hành cơ sở dữ liệu và các vấn đề bên trong dự án. Chủ sở hữu dự án, Quản trị viên không gian làm việc và DBA không gian làm việc đều có toàn quyền dự án.","disallow-ddl-all-environments": "Không cho phép chạy câu lệnh DDL/DML cho tất cả các môi trường.",diff --git a/frontend/src/react/locales/zh-CN.json b/frontend/src/react/locales/zh-CN.jsonindex e7a9867afb..4b83d87ee2 100644--- a/frontend/src/react/locales/zh-CN.json+++ b/frontend/src/react/locales/zh-CN.json@@ -485,7 +485,6 @@},"filter-projects": "过滤项目","members": {- "add-more": "Add more","allow-ddl": "允许在所选环境中执行 DDL/DML 语句。","description": "项目成员角色决定了操作项目中的数据库和工单的权限。项目的所有者,工作空间管理员和 DBA 都具有项目所有的权限。","disallow-ddl-all-environments": "禁止在所有环境中执行 DDL/DML 语句。",diff --git a/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx b/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsxindex 6b2d998505..c104834672 100644--- a/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx+++ b/frontend/src/react/pages/project/ProjectMaskingExemptionPage.tsx@@ -111,6 +111,22 @@ export function ProjectMaskingExemptionPage({: false,[project]);+ const hasCreatePermission = useMemo(+ () =>+ project+ ? hasProjectPermissionV2(+ project,+ "bb.policies.createMaskingExemptionPolicy"+ ) &&+ hasProjectPermissionV2(+ project,+ "bb.policies.updateMaskingExemptionPolicy"+ ) &&+ hasProjectPermissionV2(project, "bb.databases.list") &&+ hasProjectPermissionV2(project, "bb.databaseCatalogs.get")+ : false,+ [project]+ );const hasSensitiveDataFeature = useVueState(() =>hasFeature(PlanFeature.FEATURE_DATA_MASKING));@@ -379,7 +395,7 @@ export function ProjectMaskingExemptionPage({scopeOptions={scopeOptions}placeholder={t("issue.advanced-search.filter")}/>- <Button onClick={handleGrantClick} disabled={!hasPermission}>+ <Button onClick={handleGrantClick} disabled={!hasCreatePermission}><ShieldCheck className="w-4 h-4" /><FeatureBadgefeature={PlanFeature.FEATURE_DATA_MASKING}diff --git a/frontend/src/react/pages/settings/MembersPage.tsx b/frontend/src/react/pages/settings/MembersPage.tsxindex 65b1de855e..dbf378a70a 100644--- a/frontend/src/react/pages/settings/MembersPage.tsx+++ b/frontend/src/react/pages/settings/MembersPage.tsx@@ -58,14 +58,9 @@ import {ALL_USERS_USER_EMAIL,type DatabaseResource,isDefaultProject,- PRESET_WORKSPACE_ROLES,userBindingPrefix,} from "@/types";-import {- PRESET_PROJECT_ROLES,- PRESET_ROLES,- PresetRoleType,-} from "@/types/iam";+import { PRESET_PROJECT_ROLES, PRESET_ROLES } from "@/types/iam";import { ExprSchema as ConditionExprSchema } from "@/types/proto-es/google/type/expr_pb";import { State } from "@/types/proto-es/v1/common_pb";import { type Binding, BindingSchema } from "@/types/proto-es/v1/iam_policy_pb";@@ -87,6 +82,8 @@ import { AccountMultiSelect } from "./shared/AccountMultiSelect";import { RoleMultiSelect } from "./shared/RoleMultiSelect";import { UserAvatar } from "./shared/UserAvatar";+const EMPTY_ROLE_SET = new Set<string>();+// ============================================================// MemberTable (view by members)// ============================================================@@ -1098,45 +1095,17 @@ function EditMemberRoleDrawer({const [isRequesting, setIsRequesting] = useState(false);const [showNestedGrant, setShowNestedGrant] = useState(false);- // Project create mode: manage multiple role binding forms- const [forms, setForms] = useState<RoleBindingFormState[]>(() => [- {- id: crypto.randomUUID(),- role: PresetRoleType.PROJECT_VIEWER,- reason: "",- expirationDays: 7,- expirationTimestampInMS: computeExpirationTimestamp(7),- databaseMode: "ALL",- databaseResources: [],- celExpression: "",- environments: [],- },- ]);-- const updateForm = (id: string, updated: RoleBindingFormState) => {- setForms((prev) => prev.map((f) => (f.id === id ? updated : f)));- };-- const removeForm = (id: string) => {- setForms((prev) => prev.filter((f) => f.id !== id));- };-- const addForm = () => {- setForms((prev) => [- ...prev,- {- id: crypto.randomUUID(),- role: "",- reason: "",- expirationDays: 7,- expirationTimestampInMS: computeExpirationTimestamp(7),- databaseMode: "ALL",- databaseResources: [],- celExpression: "",- environments: [],- },- ]);- };+ const [form, setForm] = useState<RoleBindingFormState>(() => ({+ id: crypto.randomUUID(),+ role: "",+ reason: "",+ expirationDays: 7,+ expirationTimestampInMS: computeExpirationTimestamp(7),+ databaseMode: "ALL",+ databaseResources: [],+ celExpression: "",+ environments: [],+ }));useEscapeKey(true, onClose);@@ -1256,9 +1225,9 @@ function EditMemberRoleDrawer({}}} else {- // Create mode with role binding forms- for (const form of forms) {- if (!form.role) continue;+ // Create mode with role binding form+ {+ if (!form.role) throw new Error("role is required");const databaseResources =form.databaseMode === "SELECT" &&form.databaseResources.length > 0@@ -1426,16 +1395,12 @@ function EditMemberRoleDrawer({const allowConfirm = isProjectCreateMode? selectedBindings.length > 0 &&- forms.every((f) => {- if (!f.role) return false;- if (- roleHasDatabaseLimitation(f.role) &&- f.databaseMode === "SELECT" &&- f.databaseResources.length === 0- )- return false;- return true;- })+ !!form.role &&+ !(+ roleHasDatabaseLimitation(form.role) &&+ form.databaseMode === "SELECT" &&+ form.databaseResources.length === 0+ ): isEditMode? selectedRoles.length > 0: selectedBindings.length > 0 && selectedRoles.length > 0;@@ -1676,24 +1641,13 @@ function EditMemberRoleDrawer({{/* Roles — project create mode uses rich form, otherwise simple multi-select */}{isProjectCreateMode ? (<div className="flex flex-col gap-y-4">- {forms.map((form) => (- <ProjectRoleBindingForm- key={form.id}- form={form}- onChange={(updated) => updateForm(form.id, updated)}- onRemove={() => removeForm(form.id)}- canRemove={forms.length > 1}- projectName={projectName}- />- ))}- <Button- variant="outline"- className="self-start"- onClick={addForm}- >- <Plus className="h-4 w-4 mr-1" />- {t("project.members.add-more")}- </Button>+ <ProjectRoleBindingForm+ form={form}+ onChange={setForm}+ onRemove={() => {}}+ canRemove={false}+ projectName={projectName}+ /></div>) : (<div className="flex flex-col gap-y-2">@@ -1780,19 +1734,11 @@ export function MembersPage({ projectId }: { projectId?: string }) {: undefined);- const workspaceRoles = useMemo(() => new Set(PRESET_WORKSPACE_ROLES), []);-const memberBindings = useVueState(() =>getMemberBindings({policies:projectName && projectIamPolicy- ? [- {- level: "WORKSPACE" as const,- policy: workspaceStore.workspaceIamPolicy,- },- { level: "PROJECT" as const, policy: projectIamPolicy },- ]+ ? [{ level: "PROJECT" as const, policy: projectIamPolicy }]: [{level: "WORKSPACE" as const,@@ -1800,7 +1746,7 @@ export function MembersPage({ projectId }: { projectId?: string }) {},],searchText: memberSearchText,- ignoreRoles: projectName ? workspaceRoles : new Set([]),+ ignoreRoles: EMPTY_ROLE_SET,}));