Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: sql editor ux and i18n (#21513)
ecmadao15e5705d1906
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.jsonindex fdd446cc66..bfb575ffe1 100644--- a/frontend/src/locales/en-US.json+++ b/frontend/src/locales/en-US.json@@ -2680,7 +2680,7 @@"first-prompt": {"description": "Once connected, try asking your AI assistant:","example": "List all projects in my Bytebase instance",- "title": "Your First Prompt"+ "title": "Your first prompt"},"ladder": {"disabled": "Nothing is allowed; no MCP session can connect.",@@ -2696,7 +2696,7 @@},"row": {"export": {- "details": "Download results as a file. Data leaves Bytebase",+ "details": "Download results as a file. Data leaves Bytebase.","title": "Export query results"},"manage": {@@ -2704,7 +2704,7 @@"title": "Manage database housekeeping"},"propose": {- "details": "Create sheets · Create and edit plans and issues · Run plan checks and reviews · Create, delete and restore releases · Create and delete revisions · Generate schema diffs. An agent never approves its own change; the project's approval policy decides whether a human must",+ "details": "Create sheets · Create and edit plans and issues · Run plan checks and reviews · Create, delete and restore releases · Create and delete revisions · Generate schema diffs. An agent never approves its own change; the project's approval policy decides whether a human must approve it.","title": "Propose changes"},"read-data": {@@ -2744,7 +2744,7 @@},"policy": {"current": "Current policy: {{mode}}",- "description": "The most any MCP session may do here. Sessions are also capped by each user's permissions, and policy refusals are streamed to stdout when audit logging to stdout is enabled.",+ "description": "This is the maximum any MCP session may do in this workspace. Sessions are also capped by each user's permissions, and policy refusals are streamed to stdout when audit logging to stdout is enabled.","edit": "Edit policy","loading": "Reading the access policy…","masking": {@@ -2762,7 +2762,7 @@"mode": {"disabled": {"best-for": "Best for: keeping MCP off until you are ready to turn it on.",- "caption": "No sessions connect",+ "caption": "No sessions can connect","description": "No MCP session can connect to this workspace.","title": "Disabled"},@@ -2778,7 +2778,7 @@}},"read-failed": {- "description": "Reload to try again. If it keeps failing, the stored policy is one Bytebase cannot parse and an operator has to repair the row directly. Until it can be read, every MCP connection is refused.",+ "description": "Reload to try again. If it keeps failing, Bytebase cannot parse the stored policy and an operator must repair the row directly. Until then, every MCP connection is refused.","title": "The access policy could not be read"},"save": "Save policy",@@ -2792,8 +2792,8 @@"title": "The stored access policy cannot be read"},"unserved": {- "description": "This workspace stores {{stored}}, which is not a ceiling this build serves. Every MCP connection is being refused. Pick a mode and save to set it right.",- "title": "The stored access policy is not one this build serves"+ "description": "This workspace stores {{stored}}, which this build does not support. Every MCP connection is being refused. Pick a mode and save to correct it.",+ "title": "The stored access policy is not supported by this build"}},"title": "MCP Integration"@@ -3472,6 +3472,7 @@"search-scope-row-number-description": "Enter a row number to jump to that row.","search-scope-row-number-title": "Row number","select-a-database-to-start": "Select a database to start",+ "select-a-project-to-choose-a-database": "Select a project to choose a database","select-connection": "Please select connections","select-encoding": "Select encoding","self": "SQL Editor",diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.jsonindex d900e59660..1532e4b943 100644--- a/frontend/src/locales/es-ES.json+++ b/frontend/src/locales/es-ES.json@@ -2679,8 +2679,8 @@"description": "Conecte asistentes de IA a Bytebase usando el Model Context Protocol.","first-prompt": {"description": "Una vez conectado, intente preguntar a su asistente de IA:",- "example": "Listar todos los proyectos en mi instancia de Bytebase",- "title": "Tu primer prompt"+ "example": "Enumera todos los proyectos de mi instancia de Bytebase",+ "title": "Su primer prompt"},"ladder": {"disabled": "No se permite nada; ninguna sesión MCP puede conectarse.",@@ -2696,7 +2696,7 @@},"row": {"export": {- "details": "Descargar resultados como archivo. Los datos salen de Bytebase",+ "details": "Descargar resultados como archivo. Los datos salen de Bytebase.","title": "Exportar resultados de consulta"},"manage": {@@ -2762,7 +2762,7 @@"mode": {"disabled": {"best-for": "Ideal para: mantener MCP apagado hasta que esté listo para activarlo.",- "caption": "Ninguna sesión conecta",+ "caption": "Ninguna sesión puede conectarse","description": "Ninguna sesión MCP puede conectarse a este espacio de trabajo.","title": "Desactivado"},@@ -2792,8 +2792,8 @@"title": "No se puede leer la política de acceso almacenada"},"unserved": {- "description": "Este espacio de trabajo almacena {{stored}}, que no es un techo que esta versión ofrezca. Se está rechazando cada conexión MCP. Elija un modo y guarde para corregirlo.",- "title": "La política de acceso almacenada no es una que esta versión ofrezca"+ "description": "Este espacio de trabajo almacena {{stored}}, que esta versión no admite. Se rechaza toda conexión MCP. Elija un modo y guarde para corregirlo.",+ "title": "La política de acceso almacenada no es compatible con esta versión"}},"title": "Integración MCP"@@ -3472,6 +3472,7 @@"search-scope-row-number-description": "Ingrese un número de fila para saltar a esa fila.","search-scope-row-number-title": "Número de fila","select-a-database-to-start": "Seleccione una base de datos para comenzar",+ "select-a-project-to-choose-a-database": "Seleccione un proyecto para elegir una base de datos","select-connection": "Por favor seleccione conexiones","select-encoding": "Seleccionar codificación","self": "Editor de SQL",diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.jsonindex befa90fbde..2b3363db9e 100644--- a/frontend/src/locales/ja-JP.json+++ b/frontend/src/locales/ja-JP.json@@ -2696,7 +2696,7 @@},"row": {"export": {- "details": "結果をファイルとしてダウンロード。データが Bytebase の外に出ます",+ "details": "結果をファイルとしてダウンロードします。データが Bytebase の外に出ます。","title": "クエリ結果をエクスポートする"},"manage": {@@ -2762,7 +2762,7 @@"mode": {"disabled": {"best-for": "適する場面:有効にする準備が整うまで MCP をオフにしておきたいとき。",- "caption": "セッションは接続不可",+ "caption": "MCP セッションは接続できません","description": "このワークスペースにはどの MCP セッションも接続できません。","title": "無効"},@@ -2792,8 +2792,8 @@"title": "保存されたアクセスポリシーを読み取れません"},"unserved": {- "description": "このワークスペースには {{stored}} が保存されていますが、このビルドが提供する上限ではありません。MCP 接続はすべて拒否されています。モードを選んで保存すると修復されます。",- "title": "保存されたアクセスポリシーはこのビルドが提供するものではありません"+ "description": "このワークスペースには {{stored}} が保存されていますが、このビルドは対応していません。MCP 接続はすべて拒否されています。モードを選択して保存し、修正してください。",+ "title": "保存されたアクセスポリシーはこのビルドではサポートされていません"}},"title": "MCP 連携"@@ -3472,6 +3472,7 @@"search-scope-row-number-description": "行番号を入力してその行にジャンプします。","search-scope-row-number-title": "行番号","select-a-database-to-start": "開始するにはデータベースを選択してください",+ "select-a-project-to-choose-a-database": "データベースを選択するにはプロジェクトを選択してください","select-connection": "データ接続を選択してください","select-encoding": "エンコーディングの選択","self": "SQLエディタ",diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.jsonindex 8f7db9464d..61b6336b67 100644--- a/frontend/src/locales/vi-VN.json+++ b/frontend/src/locales/vi-VN.json@@ -2680,7 +2680,7 @@"first-prompt": {"description": "Sau khi kết nối, hãy thử hỏi trợ lý AI của bạn:","example": "Liệt kê tất cả các dự án trong phiên bản Bytebase của tôi",- "title": "Prompt đầu tiên của bạn"+ "title": "Lời nhắc đầu tiên của bạn"},"ladder": {"disabled": "Không cho phép gì; không phiên MCP nào có thể kết nối.",@@ -2696,7 +2696,7 @@},"row": {"export": {- "details": "Tải kết quả về dưới dạng tệp. Dữ liệu rời khỏi Bytebase",+ "details": "Tải kết quả về dưới dạng tệp. Dữ liệu rời khỏi Bytebase.","title": "Xuất kết quả truy vấn"},"manage": {@@ -2762,7 +2762,7 @@"mode": {"disabled": {"best-for": "Phù hợp khi: giữ MCP tắt cho tới khi bạn sẵn sàng bật.",- "caption": "Không phiên nào kết nối",+ "caption": "Không phiên MCP nào có thể kết nối","description": "Không phiên MCP nào có thể kết nối tới không gian làm việc này.","title": "Tắt"},@@ -2792,8 +2792,8 @@"title": "Không đọc được chính sách truy cập đã lưu"},"unserved": {- "description": "Không gian làm việc này lưu {{stored}}, không phải mức trần mà bản dựng này phục vụ. Mọi kết nối MCP đang bị từ chối. Hãy chọn một chế độ và lưu để sửa lại.",- "title": "Chính sách truy cập đã lưu không phải loại bản dựng này phục vụ"+ "description": "Không gian làm việc này lưu {{stored}}, nhưng bản dựng này không hỗ trợ giá trị đó. Mọi kết nối MCP đều bị từ chối. Hãy chọn một chế độ và lưu để sửa lại.",+ "title": "Bản dựng này không hỗ trợ chính sách truy cập đã lưu"}},"title": "Tích hợp MCP"@@ -3472,6 +3472,7 @@"search-scope-row-number-description": "Nhập số dòng để chuyển đến dòng đó.","search-scope-row-number-title": "Số dòng","select-a-database-to-start": "Chọn một cơ sở dữ liệu để bắt đầu",+ "select-a-project-to-choose-a-database": "Chọn một dự án để chọn cơ sở dữ liệu","select-connection": "Vui lòng chọn kết nối","select-encoding": "Chọn mã hóa","self": "Trình soạn thảo SQL",diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.jsonindex a9750043c8..f722b4fb49 100644--- a/frontend/src/locales/zh-CN.json+++ b/frontend/src/locales/zh-CN.json@@ -2680,7 +2680,7 @@"first-prompt": {"description": "连接后,尝试向 AI 助手提问:","example": "列出我的 Bytebase 实例中的所有项目",- "title": "您的第一个提示"+ "title": "你的第一个提示词"},"ladder": {"disabled": "不允许任何操作;MCP 会话无法连接。",@@ -2696,7 +2696,7 @@},"row": {"export": {- "details": "将结果下载为文件。数据会离开 Bytebase",+ "details": "将结果下载为文件。数据会离开 Bytebase。","title": "导出查询结果"},"manage": {@@ -2762,7 +2762,7 @@"mode": {"disabled": {"best-for": "适用于:在准备好开启之前先关闭 MCP。",- "caption": "会话无法连接",+ "caption": "MCP 会话无法连接","description": "任何 MCP 会话都无法连接到本工作空间。","title": "禁用"},@@ -2787,13 +2787,13 @@"tightening-change": "{{from}} → {{to}} 从每个运行中会话的下一个请求起生效。","title": "访问策略","unreadable": {- "description": "此工作区存储的能力值是当前构建无法理解的。所有 MCP 连接都会被拒绝。请选择一种模式并保存以修正。",+ "description": "本工作空间存储的能力值是当前构建无法理解的。所有 MCP 连接都会被拒绝。请选择一种模式并保存以修正。","pick": "请选择一种模式后再保存此策略。","title": "无法读取已存储的访问策略"},"unserved": {- "description": "本工作空间存储的值为 {{stored}},当前版本不提供该上限。所有 MCP 连接都会被拒绝。请选择一种模式并保存以修复。",- "title": "当前版本不提供已存储的访问策略"+ "description": "本工作空间存储了 {{stored}},当前构建不支持该值。所有 MCP 连接都会被拒绝。请选择一种模式并保存以修正。",+ "title": "当前构建不支持已存储的访问策略"}},"title": "MCP 集成"@@ -3472,6 +3472,7 @@"search-scope-row-number-description": "输入行号跳转到指定行。","search-scope-row-number-title": "行号","select-a-database-to-start": "选择数据库以开始",+ "select-a-project-to-choose-a-database": "选择项目以选择数据库","select-connection": "请选择数据连接","select-encoding": "选择编码","self": "SQL 编辑器",diff --git a/frontend/src/modules/sql-editor/components/DatabaseChooser.test.tsx b/frontend/src/modules/sql-editor/components/DatabaseChooser.test.tsxindex a9c0429061..68b88ef089 100644--- a/frontend/src/modules/sql-editor/components/DatabaseChooser.test.tsx+++ b/frontend/src/modules/sql-editor/components/DatabaseChooser.test.tsx@@ -12,12 +12,14 @@ const mocks = vi.hoisted(() => ({useCurrentSQLEditorTab: vi.fn(),useIsInBatchMode: vi.fn(() => false),// editor zustand store selector value.+ projectName: "projects/test",projectContextReady: true,useConnectionOfCurrentSQLEditorTab: vi.fn(),// New zustand store setter.setShowConnectionPanel: vi.fn(),isValidInstanceName: vi.fn(),isValidDatabaseName: vi.fn(),+ isValidProjectName: vi.fn(),extractDatabaseResourceName: vi.fn(),getDatabaseEnvironment: vi.fn(),getInstanceResource: vi.fn(),@@ -41,8 +43,12 @@ vi.mock("@/modules/sql-editor/store/tab", () => ({vi.mock("@/modules/sql-editor/store/editor", () => ({useSQLEditorEditorState: (- selector: (s: { projectContextReady: boolean }) => unknown- ) => selector({ projectContextReady: mocks.projectContextReady }),+ selector: (s: { project: string; projectContextReady: boolean }) => unknown+ ) =>+ selector({+ project: mocks.projectName,+ projectContextReady: mocks.projectContextReady,+ }),}));vi.mock("@/modules/sql-editor/store", () => ({@@ -57,6 +63,7 @@ vi.mock("@/modules/sql-editor/store", () => ({vi.mock("@/types", () => ({isValidInstanceName: mocks.isValidInstanceName,isValidDatabaseName: mocks.isValidDatabaseName,+ isValidProjectName: mocks.isValidProjectName,}));vi.mock("@/utils", () => ({@@ -117,9 +124,13 @@ beforeEach(async () => {});mocks.useCurrentSQLEditorTab.mockReturnValue({ id: "tab1" });mocks.useIsInBatchMode.mockReturnValue(false);+ mocks.projectName = "projects/test";mocks.projectContextReady = true;mocks.isValidInstanceName.mockReturnValue(true);mocks.isValidDatabaseName.mockReturnValue(true);+ mocks.isValidProjectName.mockImplementation((name: string) =>+ name.startsWith("projects/")+ );mocks.getInstanceResource.mockReturnValue(mockInstance);mocks.getDatabaseEnvironment.mockReturnValue(mockEnvironment);mocks.extractDatabaseResourceName.mockReturnValue({ databaseName: "mydb" });@@ -172,6 +183,25 @@ describe("DatabaseChooser", () => {unmount();});+ test("requires a project before opening the connection panel", () => {+ mocks.projectName = "";+ const { container, render, unmount } = renderIntoContainer(+ <DatabaseChooser />+ );+ render();++ const button = container.querySelector("button");+ expect(button?.hasAttribute("disabled")).toBe(true);+ expect(container.textContent).toContain(+ "sql-editor.select-a-project-to-choose-a-database"+ );+ act(() => {+ button?.click();+ });+ expect(mocks.setShowConnectionPanel).not.toHaveBeenCalled();+ unmount();+ });+test("click invokes setShowConnectionPanel(true)", () => {const { container, render, unmount } = renderIntoContainer(<DatabaseChooser />diff --git a/frontend/src/modules/sql-editor/components/DatabaseChooser.tsx b/frontend/src/modules/sql-editor/components/DatabaseChooser.tsxindex 9b2e7aa3ff..f262f134b1 100644--- a/frontend/src/modules/sql-editor/components/DatabaseChooser.tsx+++ b/frontend/src/modules/sql-editor/components/DatabaseChooser.tsx@@ -11,7 +11,11 @@ import {useCurrentSQLEditorTab,useIsInBatchMode,} from "@/modules/sql-editor/store/tab";-import { isValidDatabaseName, isValidInstanceName } from "@/types";+import {+ isValidDatabaseName,+ isValidInstanceName,+ isValidProjectName,+} from "@/types";import {extractDatabaseResourceName,getDatabaseEnvironment,@@ -38,6 +42,7 @@ export function DatabaseChooser({ disabled = false }: DatabaseChooserProps) {const projectContextReady = useSQLEditorEditorState((s) => s.projectContextReady);+ const projectName = useSQLEditorEditorState((s) => s.project);const instance = getInstanceResource(database);const environment = getDatabaseEnvironment(database);@@ -47,6 +52,7 @@ export function DatabaseChooser({ disabled = false }: DatabaseChooserProps) {!!currentTab &&isValidInstanceName(instance.name) &&isValidDatabaseName(database.name);+ const hasProject = isValidProjectName(projectName);const handleClick = () => {setShowConnectionPanel(true);@@ -54,11 +60,11 @@ export function DatabaseChooser({ disabled = false }: DatabaseChooserProps) {return (<ConnectionChooserButton- disabled={disabled || !projectContextReady}+ disabled={disabled || !projectContextReady || !hasProject}onClick={handleClick}className="overflow-hidden">- {isConnected ? (+ {hasProject && isConnected ? (<div className="flex flex-row items-center text-control truncate">{isInBatchMode && (<Tooltip content={t("sql-editor.batch-query.batch")}>@@ -77,8 +83,10 @@ export function DatabaseChooser({ disabled = false }: DatabaseChooserProps) {<span className="truncate">{databaseName}</span></div></div>- ) : (+ ) : hasProject ? (<span>{t("sql-editor.select-a-database-to-start")}</span>+ ) : (+ <span>{t("sql-editor.select-a-project-to-choose-a-database")}</span>)}</ConnectionChooserButton>);