Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(doris): handle table dropped during schema dump (#19262)
Danny Xu169ac40a7f1e
diff --git a/backend/plugin/db/starrocks/dump.go b/backend/plugin/db/starrocks/dump.goindex 996ce7e8a0..2365d841b3 100644--- a/backend/plugin/db/starrocks/dump.go+++ b/backend/plugin/db/starrocks/dump.go@@ -8,6 +8,7 @@ import ("log/slog""strings"+ "github.com/go-sql-driver/mysql""github.com/pkg/errors""github.com/bytebase/bytebase/backend/common"@@ -15,6 +16,11 @@ import ("github.com/bytebase/bytebase/backend/plugin/db/util")+const (+ // MySQL error code for "Unknown table".+ errUnknownTable = 1051+)+// Dump and restore.const (settingsStmt = "" +@@ -300,9 +306,18 @@ func getTables(db *sql.DB, dbName string, dbType storepb.Engine) ([]*TableSchema}}+ var result []*TableSchemafor _, tbl := range tables {stmt, err := getTableStmt(db, dbName, tbl.Name, tbl.TableType)if err != nil {+ // Skip tables that were dropped between listing and fetching CREATE statement.+ var mysqlErr *mysql.MySQLError+ if errors.As(err, &mysqlErr) && mysqlErr.Number == errUnknownTable {+ slog.Debug("table was dropped during dump, skipping",+ slog.String("database", dbName),+ slog.String("table", tbl.Name))+ continue+ }return nil, errors.Wrapf(err, "failed to call getTableStmt(%q, %q, %q)", dbName, tbl.Name, tbl.TableType)}tbl.Statement = stmt@@ -314,8 +329,9 @@ func getTables(db *sql.DB, dbName string, dbType storepb.Engine) ([]*TableSchematbl.ViewColumns = viewColumns}}+ result = append(result, tbl)}- return tables, nil+ return result, nil}// getTableStmt gets the create statement of a table.