Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(plan-detail): deprecate deploy run history (#20355)

boojack1849790e6ecf
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index 3b21e03fe0..e05fd29ee1 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -2701,9 +2701,7 @@
"online-migration": {
"self": "Online migration"
},
- "only-showing-latest-n-runs": "Only showing latest {n} runs",
"prior-backup": "Prior backup",
- "run-history": "Run History",
"run-immediately": {
"description": "Tasks will start executing as soon as you click Run. No delay or scheduling required.",
"self": "Run immediately"
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index 3ffa3f6dea..d8e97c311b 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -2701,9 +2701,7 @@
"online-migration": {
"self": "Migración en línea"
},
- "only-showing-latest-n-runs": "Solo se muestran las últimas {n} ejecuciones",
"prior-backup": "Respaldo previo",
- "run-history": "Historial de ejecución",
"run-immediately": {
"description": "Las tareas comenzarán a ejecutarse en cuanto haga clic en \"Ejecutar\". No requiere demora ni programación.",
"self": "Corre inmediatamente"
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index c1f99ecbd0..3ad3c4eb7f 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -2701,9 +2701,7 @@
"online-migration": {
"self": "オンラインでの大規模なテーブル変更"
},
- "only-showing-latest-n-runs": "最新の {n} 実行のみを表示",
"prior-backup": "影響を受けるデータの事前バックアップ",
- "run-history": "実行履歴",
"run-immediately": {
"description": "「実行」をクリックするとすぐにタスクの実行が開始されます。遅延やスケジュール設定は必要ありません。",
"self": "すぐに実行"
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index ea7f5f39f4..72cae6deae 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -2701,9 +2701,7 @@
"online-migration": {
"self": "Di chuyển trực tuyến"
},
- "only-showing-latest-n-runs": "Chỉ hiển thị các lần chạy {n} mới nhất",
"prior-backup": "Sao lưu trước",
- "run-history": "Lịch sử chạy",
"run-immediately": {
"description": "Các tác vụ sẽ bắt đầu thực thi ngay khi bạn nhấp vào Chạy. Không cần trì hoãn hay lên lịch.",
"self": "Chạy ngay lập tức"
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index 119a3673f3..f76f33d16d 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -2701,9 +2701,7 @@
"online-migration": {
"self": "在线大表变更"
},
- "only-showing-latest-n-runs": "仅显示最近 {n} 条记录",
"prior-backup": "预备份受影响数据",
- "run-history": "执行历史",
"run-immediately": {
"description": "点击“运行”后,任务将立即开始执行。",
"self": "立即运行"
diff --git a/frontend/src/react/locales/en-US.json b/frontend/src/react/locales/en-US.json
index 1298dda69b..a601fbd0e8 100644
--- a/frontend/src/react/locales/en-US.json
+++ b/frontend/src/react/locales/en-US.json
@@ -3816,9 +3816,7 @@
"task.no-skippable-tasks": "No skippable tasks",
"task.no-tasks-selected": "No tasks selected",
"task.online-migration.self": "Online migration",
- "task.only-showing-latest-n-runs": "Only showing latest {{n}} runs",
"task.prior-backup": "Prior backup",
- "task.run-history": "Run History",
"task.scheduled-time": "Scheduled time",
"task.select-task": "Select Task",
"two-factor": {
diff --git a/frontend/src/react/locales/es-ES.json b/frontend/src/react/locales/es-ES.json
index 0707ec1689..49cee64a64 100644
--- a/frontend/src/react/locales/es-ES.json
+++ b/frontend/src/react/locales/es-ES.json
@@ -3804,9 +3804,7 @@
"task.no-skippable-tasks": "No hay tareas que se puedan omitir",
"task.no-tasks-selected": "No hay tareas seleccionadas",
"task.online-migration.self": "Migración en línea",
- "task.only-showing-latest-n-runs": "Solo se muestran las últimas {{n}} ejecuciones",
"task.prior-backup": "Respaldo previo",
- "task.run-history": "Historial de ejecución",
"task.scheduled-time": "Hora programada",
"task.select-task": "Seleccionar tarea",
"two-factor": {
diff --git a/frontend/src/react/locales/ja-JP.json b/frontend/src/react/locales/ja-JP.json
index ecf9328d16..534054770d 100644
--- a/frontend/src/react/locales/ja-JP.json
+++ b/frontend/src/react/locales/ja-JP.json
@@ -3804,9 +3804,7 @@
"task.no-skippable-tasks": "スキップ可能なタスクはありません",
"task.no-tasks-selected": "タスクが選択されていません",
"task.online-migration.self": "オンラインでの大規模なテーブル変更",
- "task.only-showing-latest-n-runs": "最新の {{n}} 実行のみを表示",
"task.prior-backup": "影響を受けるデータの事前バックアップ",
- "task.run-history": "実行履歴",
"task.scheduled-time": "スケジュール時刻",
"task.select-task": "タスクを選択",
"two-factor": {
diff --git a/frontend/src/react/locales/vi-VN.json b/frontend/src/react/locales/vi-VN.json
index 0b66577aba..18eb559894 100644
--- a/frontend/src/react/locales/vi-VN.json
+++ b/frontend/src/react/locales/vi-VN.json
@@ -3804,9 +3804,7 @@
"task.no-skippable-tasks": "Không có nhiệm vụ nào có thể bỏ qua",
"task.no-tasks-selected": "Không có nhiệm vụ nào được chọn",
"task.online-migration.self": "Di chuyển trực tuyến",
- "task.only-showing-latest-n-runs": "Chỉ hiển thị {{n}} lần chạy gần nhất",
"task.prior-backup": "Sao lưu trước",
- "task.run-history": "Lịch sử chạy",
"task.scheduled-time": "Thời gian đã lên lịch",
"task.select-task": "Chọn tác vụ",
"two-factor": {
diff --git a/frontend/src/react/locales/zh-CN.json b/frontend/src/react/locales/zh-CN.json
index 49e1473f9e..e163bb9c76 100644
--- a/frontend/src/react/locales/zh-CN.json
+++ b/frontend/src/react/locales/zh-CN.json
@@ -3804,9 +3804,7 @@
"task.no-skippable-tasks": "没有可跳过的任务",
"task.no-tasks-selected": "未选择任何任务",
"task.online-migration.self": "在线大表变更",
- "task.only-showing-latest-n-runs": "仅显示最近 {{n}} 条记录",
"task.prior-backup": "预备份受影响数据",
- "task.run-history": "执行历史",
"task.scheduled-time": "计划执行时间",
"task.select-task": "选择任务",
"two-factor": {
diff --git a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentSidebar.tsx b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentSidebar.tsx
deleted file mode 100644
index 3ba2d21760..0000000000
--- a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentSidebar.tsx
+++ /dev/null
@@ -1,239 +0,0 @@
-import { DatabaseBackup } from "lucide-react";
-import { useEffect, useMemo, useState } from "react";
-import { useTranslation } from "react-i18next";
-import { Button } from "@/react/components/ui/button";
-import {
- Sheet,
- SheetBody,
- SheetContent,
- SheetHeader,
- SheetTitle,
-} from "@/react/components/ui/sheet";
-import { useDatabaseV1Store, useUserStore } from "@/store";
-import { getDateForPbTimestampProtoEs } from "@/types";
-import {
- type Stage,
- type TaskRun,
- TaskRun_Status,
-} from "@/types/proto-es/v1/rollout_service_pb";
-import { humanizeDate } from "@/utils";
-import { extractTaskNameFromTaskRunName } from "@/utils/v1/issue/rollout";
-import { usePlanDetailContext } from "../../shell/PlanDetailContext";
-import { DatabaseTarget } from "../PlanDetailChangesBranch";
-import { PlanDetailRollbackSheet } from "../PlanDetailRollbackSheet";
-import { PlanDetailTaskRunDetail } from "../PlanDetailTaskRunDetail";
-import { DeployTaskStatus } from "./DeployTaskStatus";
-import { getTaskRunDuration, taskRunStatusToTaskStatus } from "./taskRunUtils";
-import type { RollbackItem } from "./types";
-
-const MAX_DISPLAY_ITEMS = 10;
-
-export function DeployStageContentSidebar({ stage }: { stage: Stage }) {
- const { t } = useTranslation();
- const page = usePlanDetailContext();
- const userStore = useUserStore();
- const databaseStore = useDatabaseV1Store();
- const [rollbackOpen, setRollbackOpen] = useState(false);
- const [selectedTaskRun, setSelectedTaskRun] = useState<TaskRun | undefined>();
- const [creatorTitleByRun, setCreatorTitleByRun] = useState<
- Record<string, string>
- >({});
-
- const tasksByName = useMemo(
- () => new Map(stage.tasks.map((task) => [task.name, task])),
- [stage.tasks]
- );
-
- const selectedDatabaseEngine = useMemo(() => {
- if (!selectedTaskRun) return undefined;
- const target = tasksByName.get(
- extractTaskNameFromTaskRunName(selectedTaskRun.name)
- )?.target;
- return target
- ? databaseStore.getDatabaseByName(target).instanceResource?.engine
- : undefined;
- }, [databaseStore, selectedTaskRun, tasksByName]);
-
- const stageTaskRuns = useMemo(() => {
- return page.taskRuns.filter((taskRun) =>
- tasksByName.has(extractTaskNameFromTaskRunName(taskRun.name))
- );
- }, [page.taskRuns, tasksByName]);
-
- const sortedTaskRuns = useMemo(() => {
- return [...stageTaskRuns].sort((left, right) => {
- const leftTime = left.updateTime ? Number(left.updateTime.seconds) : 0;
- const rightTime = right.updateTime ? Number(right.updateTime.seconds) : 0;
- return rightTime - leftTime;
- });
- }, [stageTaskRuns]);
-
- const displayedTaskRuns = sortedTaskRuns.slice(0, MAX_DISPLAY_ITEMS);
- const displayedTaskRunsKey = displayedTaskRuns
- .map((taskRun) => `${taskRun.name}:${taskRun.creator}`)
- .join("|");
-
- useEffect(() => {
- const creators = displayedTaskRuns
- .map((taskRun) => taskRun.creator)
- .filter((creator): creator is string => Boolean(creator));
- if (creators.length === 0) {
- setCreatorTitleByRun({});
- return;
- }
-
- let canceled = false;
- void userStore.batchGetOrFetchUsers(creators).then(() => {
- if (canceled) return;
- const next = Object.fromEntries(
- displayedTaskRuns.map((taskRun) => {
- const creator = taskRun.creator;
- const user = creator
- ? userStore.getUserByIdentifier(creator)
- : undefined;
- return [
- taskRun.name,
- user?.title ||
- user?.email ||
- creator.match(/users\/([^/]+)/)?.[1] ||
- "",
- ];
- })
- );
- setCreatorTitleByRun(next);
- });
-
- return () => {
- canceled = true;
- };
- }, [displayedTaskRunsKey, userStore]);
-
- const rollbackItems = useMemo<RollbackItem[]>(() => {
- return stage.tasks
- .map((task) => {
- const taskRun = page.taskRuns.find(
- (run) =>
- run.name.startsWith(`${task.name}/taskRuns/`) &&
- run.status === TaskRun_Status.DONE &&
- run.hasPriorBackup
- );
- return taskRun ? { task, taskRun } : undefined;
- })
- .filter((item): item is RollbackItem => Boolean(item));
- }, [page.taskRuns, stage.tasks]);
-
- return (
- <>
- <div className="w-full px-4 py-2">
- {rollbackItems.length > 0 && (
- <div className="pb-2">
- <Button
- className="px-0 text-control hover:bg-transparent"
- onClick={() => setRollbackOpen(true)}
- size="sm"
- variant="ghost"
- >
- <DatabaseBackup className="h-4 w-4" />
- {t("task-run.rollback.available", {
- count: rollbackItems.length,
- })}
- </Button>
- </div>
- )}
-
- {stageTaskRuns.length > 0 && (
- <div>
- <div className="flex items-center justify-between px-3 py-2">
- <div className="flex items-center gap-2">
- <span className="text-sm font-medium text-gray-700">
- {t("task.run-history")}
- </span>
- </div>
- </div>
-
- <div className="flex flex-col gap-y-2 overflow-y-auto px-3 pb-3 pt-1">
- {displayedTaskRuns.map((taskRun) => {
- const task = tasksByName.get(
- extractTaskNameFromTaskRunName(taskRun.name)
- );
- if (!task) return null;
- const creatorTitle = creatorTitleByRun[taskRun.name] ?? "";
- const duration = getTaskRunDuration(taskRun);
- const updateDate = taskRun.updateTime
- ? getDateForPbTimestampProtoEs(taskRun.updateTime)
- : undefined;
- return (
- <button
- key={taskRun.name}
- className="flex w-full items-start gap-2 rounded-sm px-1 py-1 text-left hover:bg-gray-50"
- onClick={() => setSelectedTaskRun(taskRun)}
- type="button"
- >
- <div className="pt-0.5">
- <DeployTaskStatus
- size="small"
- status={taskRunStatusToTaskStatus(taskRun.status)}
- />
- </div>
- <div className="-mt-0.5 min-w-0 flex-1 px-1 py-0.5">
- <DatabaseTarget target={task.target} />
- {taskRun.status === TaskRun_Status.FAILED &&
- taskRun.detail && (
- <div className="mt-0.5 line-clamp-3 text-xs text-error">
- {taskRun.detail}
- </div>
- )}
- <div className="mt-0.5 flex items-center gap-1 text-xs text-gray-400">
- <span>
- {updateDate ? humanizeDate(updateDate) : "-"}
- </span>
- {creatorTitle && <span>· {creatorTitle}</span>}
- {duration && <span>· {duration}</span>}
- </div>
- </div>
- </button>
- );
- })}
- {sortedTaskRuns.length > MAX_DISPLAY_ITEMS && (
- <div className="text-left text-xs text-gray-400">
- {t("task.only-showing-latest-n-runs", {
- n: MAX_DISPLAY_ITEMS,
- })}
- </div>
- )}
- </div>
- </div>
- )}
- </div>
-
- {rollbackItems.length > 0 && (
- <PlanDetailRollbackSheet
- items={rollbackItems}
- onOpenChange={setRollbackOpen}
- open={rollbackOpen}
- projectName={`projects/${page.projectId}`}
- rolloutName={page.rollout?.name ?? ""}
- />
- )}
-
- <Sheet
- onOpenChange={(open) => !open && setSelectedTaskRun(undefined)}
- open={Boolean(selectedTaskRun)}
- >
- <SheetContent width="wide">
- <SheetHeader>
- <SheetTitle>{t("common.detail")}</SheetTitle>
- </SheetHeader>
- <SheetBody>
- {selectedTaskRun && (
- <PlanDetailTaskRunDetail
- databaseEngine={selectedDatabaseEngine}
- taskRun={selectedTaskRun}
- />
- )}
- </SheetBody>
- </SheetContent>
- </Sheet>
- </>
- );
-}
diff --git a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentView.tsx b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentView.tsx
index 361127e384..4b189d3ae3 100644
--- a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentView.tsx
+++ b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageContentView.tsx
@@ -17,7 +17,7 @@ import {
} from "../../../issue-detail/utils/rollout";
import { usePlanDetailContext } from "../../shell/PlanDetailContext";
import { PlanDetailTaskRolloutActionPanel } from "../PlanDetailTaskRolloutActionPanel";
-import { DeployStageContentSidebar } from "./DeployStageContentSidebar";
+import { DeployStageRollbackSection } from "./DeployStageRollbackSection";
import { DeployTaskFilter } from "./DeployTaskFilter";
import { DeployTaskList } from "./DeployTaskList";
@@ -150,7 +150,7 @@ export function DeployStageContentView({
}}
/>
- {isStageCreated && <DeployStageContentSidebar stage={stage} />}
+ {isStageCreated && <DeployStageRollbackSection stage={stage} />}
</div>
<PlanDetailTaskRolloutActionPanel
diff --git a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageRollbackSection.test.tsx b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageRollbackSection.test.tsx
new file mode 100644
index 0000000000..3aea9faef1
--- /dev/null
+++ b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageRollbackSection.test.tsx
@@ -0,0 +1,93 @@
+import type { ReactElement } from "react";
+import { act } from "react";
+import { createRoot } from "react-dom/client";
+import { describe, expect, test, vi } from "vitest";
+import {
+ type Stage,
+ TaskRun_Status,
+} from "@/types/proto-es/v1/rollout_service_pb";
+import type { PlanDetailPageState } from "../../shell/hooks/types";
+import { PlanDetailProvider } from "../../shell/PlanDetailContext";
+import { DeployStageRollbackSection } from "./DeployStageRollbackSection";
+
+(
+ globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
+).IS_REACT_ACT_ENVIRONMENT = true;
+
+const mocks = vi.hoisted(() => ({
+ useTranslation: vi.fn(() => ({
+ t: (key: string) => key,
+ })),
+}));
+
+vi.mock("react-i18next", () => ({
+ useTranslation: mocks.useTranslation,
+}));
+
+vi.mock("../PlanDetailRollbackSheet", () => ({
+ PlanDetailRollbackSheet: () => null,
+}));
+
+const renderIntoContainer = (element: ReactElement) => {
+ const container = document.createElement("div");
+ const root = createRoot(container);
+
+ return {
+ container,
+ render: () => {
+ act(() => {
+ root.render(element);
+ });
+ },
+ unmount: () =>
+ act(() => {
+ root.unmount();
+ }),
+ };
+};
+
+const taskName = "projects/p1/rollouts/r1/stages/s1/tasks/t1";
+
+const makePageState = (): PlanDetailPageState =>
+ ({
+ pageKey: "projects/p1/plans/1",
+ plan: { name: "projects/p1/plans/1" },
+ projectId: "p1",
+ rollout: { name: "projects/p1/rollouts/r1" },
+ taskRuns: [
+ {
+ creator: "users/[email protected]",
+ hasPriorBackup: true,
+ name: `${taskName}/taskRuns/1`,
+ status: TaskRun_Status.DONE,
+ },
+ ],
+ }) as unknown as PlanDetailPageState;
+
+describe("DeployStageRollbackSection", () => {
+ test("hides stage run history while keeping rollback action", () => {
+ const { container, render, unmount } = renderIntoContainer(
+ <PlanDetailProvider value={makePageState()}>
+ <DeployStageRollbackSection
+ stage={
+ {
+ tasks: [
+ {
+ name: taskName,
+ target: "instances/prod/databases/app",
+ },
+ ],
+ } as unknown as Stage
+ }
+ />
+ </PlanDetailProvider>
+ );
+
+ render();
+
+ expect(container.textContent).toContain("task-run.rollback.available");
+ expect(container.textContent).not.toContain("task.run-history");
+
+ unmount();
+ });
+});
diff --git a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageRollbackSection.tsx b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageRollbackSection.tsx
new file mode 100644
index 0000000000..646851fd3b
--- /dev/null
+++ b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployStageRollbackSection.tsx
@@ -0,0 +1,56 @@
+import { DatabaseBackup } from "lucide-react";
+import { useMemo, useState } from "react";
+import { useTranslation } from "react-i18next";
+import { Button } from "@/react/components/ui/button";
+import {
+ type Stage,
+ TaskRun_Status,
+} from "@/types/proto-es/v1/rollout_service_pb";
+import { usePlanDetailContext } from "../../shell/PlanDetailContext";
+import { PlanDetailRollbackSheet } from "../PlanDetailRollbackSheet";
+import type { RollbackItem } from "./types";
+
+export function DeployStageRollbackSection({ stage }: { stage: Stage }) {
+ const { t } = useTranslation();
+ const page = usePlanDetailContext();
+ const [rollbackOpen, setRollbackOpen] = useState(false);
+
+ const rollbackItems = useMemo<RollbackItem[]>(() => {
+ return stage.tasks
+ .map((task) => {
+ const taskRun = page.taskRuns.find(
+ (run) =>
+ run.name.startsWith(`${task.name}/taskRuns/`) &&
+ run.status === TaskRun_Status.DONE &&
+ run.hasPriorBackup
+ );
+ return taskRun ? { task, taskRun } : undefined;
+ })
+ .filter((item): item is RollbackItem => Boolean(item));
+ }, [page.taskRuns, stage.tasks]);
+
+ if (rollbackItems.length === 0) {
+ return null;
+ }
+
+ return (
+ <>
+ <div className="w-full px-4 pb-2">
+ <Button onClick={() => setRollbackOpen(true)} size="sm" variant="ghost">
+ <DatabaseBackup className="h-4 w-4" />
+ {t("task-run.rollback.available", {
+ count: rollbackItems.length,
+ })}
+ </Button>
+ </div>
+
+ <PlanDetailRollbackSheet
+ items={rollbackItems}
+ onOpenChange={setRollbackOpen}
+ open={rollbackOpen}
+ projectName={`projects/${page.projectId}`}
+ rolloutName={page.rollout?.name ?? ""}
+ />
+ </>
+ );
+}