Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(frontend): extract IssueListItem and simplify IssueListV1 (#19428)
boojack1c0bd9c03c56
diff --git a/frontend/src/components/IssueV1/components/IssueApprovalStatus.vue b/frontend/src/components/IssueV1/components/IssueApprovalStatus.vueindex 02280a5301..f5637bdbb8 100644--- a/frontend/src/components/IssueV1/components/IssueApprovalStatus.vue+++ b/frontend/src/components/IssueV1/components/IssueApprovalStatus.vue@@ -44,7 +44,7 @@</NPopover><!-- No approval required -->- <NTag v-else size="small" round class="shrink-0 mt-1">+ <NTag v-else size="small" round :bordered="false" class="shrink-0 mt-1">{{ t("custom-approval.approval-flow.skip") }}</NTag></template>diff --git a/frontend/src/components/IssueV1/components/IssueListItem.vue b/frontend/src/components/IssueV1/components/IssueListItem.vuenew file mode 100644index 0000000000..d8d3a5ff47--- /dev/null+++ b/frontend/src/components/IssueV1/components/IssueListItem.vue@@ -0,0 +1,207 @@+<template>+ <div+ class="flex items-start gap-x-2 px-3 sm:px-4 py-3 cursor-pointer border-b border-gray-100 hover:bg-gray-50"+ @click="onRowClick($event)"+ >+ <!-- Checkbox -->+ <NCheckbox+ v-if="showSelection"+ class="shrink-0 mt-1"+ :checked="selected"+ @update:checked="$emit('toggle-selection')"+ @click.stop+ />++ <!-- Content + Approval: column on mobile, row on sm+ -->+ <div+ class="flex-1 min-w-0 flex flex-col sm:flex-row sm:items-start sm:gap-x-2"+ >+ <!-- Left: issue content -->+ <div class="flex-1 min-w-0">+ <!-- Line 1: status icon + title + labels -->+ <div class="flex items-center gap-x-1.5">+ <div class="h-6 flex justify-center items-center">+ <IssueStatusIcon class="shrink-0" :issue-status="issue.status" />+ </div>+ <a+ :href="issueUrl"+ class="font-medium text-main text-base truncate hover:underline"+ @click.stop+ v-html="highlightedTitle"+ ></a>+ <span+ v-for="label in labels"+ :key="label.value"+ class="inline-flex items-center gap-x-1 px-1.5 py-0.5 rounded text-xs whitespace-nowrap border shrink-0"+ >+ <span+ class="w-2.5 h-2.5 rounded-sm shrink-0"+ :style="{ backgroundColor: label.color }"+ ></span>+ {{ label.value }}+ </span>+ </div>+ <!-- Line 2: metadata -->+ <div+ class="flex items-center flex-wrap gap-x-1 text-xs text-control-light mt-1"+ >+ <span class="opacity-80">+ #{{ extractIssueUID(issue.name) }}+ </span>+ <span>·</span>+ <span>{{ updateTimeText }}</span>+ <span>·</span>+ <router-link+ :to="{+ name: WORKSPACE_ROUTE_USER_PROFILE,+ params: { principalEmail: creator.email },+ }"+ class="hover:underline"+ @click.stop+ >+ {{ creator.title }}+ </router-link>+ <template v-if="showProject">+ <span>·</span>+ <router-link+ :to="{+ name: PROJECT_V1_ROUTE_DETAIL,+ params: {+ projectId: extractProjectResourceName(project.name),+ },+ }"+ class="hover:underline"+ @click.stop+ >+ {{ project.title }}+ </router-link>+ </template>+ </div>+ <!-- Expanded description for search highlights -->+ <div+ v-if="expanded"+ class="mt-2 max-h-80 overflow-auto whitespace-pre-wrap wrap-break-word break-all text-sm text-control-light"+ v-html="highlightedDescription"+ ></div>+ </div>++ <!-- Right: approval status tag -->+ <IssueApprovalStatus :issue="issue" />+ </div>+ </div>+</template>++<script lang="ts" setup>+import { NCheckbox } from "naive-ui";+import { computed } from "vue";+import { useRouter } from "vue-router";+import { PROJECT_V1_ROUTE_DETAIL } from "@/router/dashboard/projectV1";+import { WORKSPACE_ROUTE_USER_PROFILE } from "@/router/dashboard/workspaceRoutes";+import { useUserStore } from "@/store";+import { getTimeForPbTimestampProtoEs, unknownUser } from "@/types";+import type { Issue } from "@/types/proto-es/v1/issue_service_pb";+import {+ extractIssueUID,+ extractProjectResourceName,+ getHighlightHTMLByRegExp,+ getIssueRoute,+ humanizeTs,+ projectOfIssue,+} from "@/utils";+import IssueApprovalStatus from "./IssueApprovalStatus.vue";+import { getValidIssueLabels } from "./IssueLabelSelector.vue";+import IssueStatusIcon from "./IssueStatusIcon.vue";++const props = withDefaults(+ defineProps<{+ issue: Issue;+ selected?: boolean;+ showSelection?: boolean;+ showProject?: boolean;+ highlightText?: string;+ }>(),+ {+ selected: false,+ showSelection: true,+ showProject: false,+ highlightText: "",+ }+);++defineEmits<{+ (e: "toggle-selection"): void;+}>();++const router = useRouter();+const userStore = useUserStore();++// Navigation+const issueUrl = computed(() => {+ const issueRoute = getIssueRoute(props.issue);+ return router.resolve({+ name: issueRoute.name,+ params: issueRoute.params,+ }).fullPath;+});++const onRowClick = (e: MouseEvent) => {+ if (e.ctrlKey || e.metaKey) {+ window.open(issueUrl.value, "_blank");+ } else {+ router.push(issueUrl.value);+ }+};++// Metadata+const creator = computed(() => {+ return (+ userStore.getUserByIdentifier(props.issue.creator) ||+ unknownUser(props.issue.creator)+ );+});++const project = computed(() => projectOfIssue(props.issue));++const updateTimeText = computed(() => {+ return humanizeTs(+ getTimeForPbTimestampProtoEs(props.issue.updateTime, 0) / 1000+ );+});++// Labels+const labels = computed(() => {+ const proj = project.value;+ const validValues = getValidIssueLabels(props.issue.labels, proj.issueLabels);+ return proj.issueLabels.filter((label) => validValues.includes(label.value));+});++// Search highlighting+const highlightWords = computed(() => {+ if (!props.highlightText) return [];+ return props.highlightText.toLowerCase().split(" ");+});++const highlightedTitle = computed(() => {+ return getHighlightHTMLByRegExp(+ props.issue.title,+ highlightWords.value,+ false,+ "bg-yellow-100"+ );+});++const highlightedDescription = computed(() => {+ return getHighlightHTMLByRegExp(+ props.issue.description,+ highlightWords.value,+ false,+ "bg-yellow-100"+ );+});++const expanded = computed(() => {+ if (!props.highlightText || !props.issue.description) return false;+ const desc = props.issue.description.toLowerCase();+ return highlightWords.value.some((word) => desc.includes(word));+});+</script>diff --git a/frontend/src/components/IssueV1/components/IssueListV1.vue b/frontend/src/components/IssueV1/components/IssueListV1.vueindex 1a757b98d3..1f89f6b436 100644--- a/frontend/src/components/IssueV1/components/IssueListV1.vue+++ b/frontend/src/components/IssueV1/components/IssueListV1.vue@@ -1,123 +1,31 @@<template>- <div- v-if="title"- class="text-left pl-4 pt-4 pb-2 text-base leading-6 font-medium text-gray-900"- >- {{ title }}- </div>- <div ref="listRef">+ <div><NSpin :show="loading">- <div+ <IssueListItemv-for="issue in sortedIssueList":key="issue.name"- class="flex items-start gap-x-2 px-3 sm:px-4 py-3 cursor-pointer border-b hover:bg-gray-50"- @click="onRowClick(issue, $event)"- >- <!-- Checkbox -->- <NCheckbox- v-if="showSelection"- class="shrink-0 mt-1"- :checked="selectedIssueNames.has(issue.name)"- @update:checked="toggleSelection(issue)"- @click.stop- />-- <!-- Content + Approval: column on mobile, row on sm+ -->- <div- class="flex-1 min-w-0 flex flex-col sm:flex-row sm:items-start sm:gap-x-2"- >- <!-- Left: issue content -->- <div class="flex-1 min-w-0">- <!-- Line 1: status icon + title + labels -->- <div class="flex items-center gap-x-1.5">- <div class="h-6 flex justify-center items-center">- <IssueStatusIcon- class="shrink-0"- :issue-status="issue.status"- />- </div>- <a- :href="issueUrl(issue)"- class="font-medium text-main text-base truncate hover:underline"- @click.stop- v-html="highlight(issue.title)"- ></a>- <span- v-for="label in validLabels(issue)"- :key="label.value"- class="inline-flex items-center gap-x-1 px-1.5 py-0.5 rounded text-xs whitespace-nowrap border shrink-0"- >- <span- class="w-2.5 h-2.5 rounded-sm shrink-0"- :style="{ backgroundColor: label.color }"- ></span>- {{ label.value }}- </span>- </div>- <!-- Line 2: metadata -->- <div- class="flex items-center flex-wrap gap-x-1 text-xs text-control-light mt-1"- >- <span class="opacity-80">- #{{ extractIssueUID(issue.name) }}- </span>- <span>·</span>- <span>{{- humanizeTs(- getTimeForPbTimestampProtoEs(issue.updateTime, 0) / 1000- )- }}</span>- <span>·</span>- <router-link- :to="{- name: WORKSPACE_ROUTE_USER_PROFILE,- params: {- principalEmail: creatorOfIssue(issue).email,- },- }"- class="hover:underline"- @click.stop- >- {{ creatorOfIssue(issue).title }}- </router-link>- <template v-if="showProject">- <span>·</span>- <router-link- :to="{- name: PROJECT_V1_ROUTE_DETAIL,- params: {- projectId: extractProjectResourceName(- projectOfIssue(issue).name- ),- },- }"- class="hover:underline"- @click.stop- >- {{ projectOfIssue(issue).title }}- </router-link>- </template>- </div>- <!-- Expanded description for search highlights -->- <div- v-if="isIssueExpanded(issue)"- class="mt-2 max-h-80 overflow-auto whitespace-pre-wrap wrap-break-word break-all text-sm text-control-light"- v-html="highlight(issue.description)"- ></div>- </div>-- <!-- Right: approval status tag -->- <IssueApprovalStatus :issue="issue" />- </div>- </div>+ :issue="issue"+ :selected="selectedIssueNames.has(issue.name)"+ :show-selection="showSelection"+ :show-project="showProject"+ :highlight-text="highlightText"+ @toggle-selection="toggleSelection(issue)"+ /></NSpin></div><div- v-if="isListInViewport && selectedIssueList.length > 0"+ v-if="selectedIssueList.length > 0"class="sticky bottom-0 w-full bg-white flex items-center gap-x-2 px-3 sm:px-4 py-2 border-y"- :class="bordered && 'border-x'">+ <NCheckbox+ :checked="allSelected"+ :indeterminate="!allSelected"+ @update:checked="toggleSelectAll"+ />+ <span class="text-sm text-control-light">+ {{ selectedIssueList.length }} / {{ issueList.length }}+ </span><BatchIssueActionsV1 :issue-list="selectedIssueList" /></div></template>@@ -126,50 +34,26 @@import { orderBy } from "lodash-es";import { NCheckbox, NSpin } from "naive-ui";import { computed, ref, watch } from "vue";-import { useRouter } from "vue-router";-import { useElementVisibilityInScrollParent } from "@/composables/useElementVisibilityInScrollParent";-import { PROJECT_V1_ROUTE_DETAIL } from "@/router/dashboard/projectV1";-import { WORKSPACE_ROUTE_USER_PROFILE } from "@/router/dashboard/workspaceRoutes";-import { useUserStore } from "@/store";-import { getTimeForPbTimestampProtoEs, unknownUser } from "@/types";import type { Issue } from "@/types/proto-es/v1/issue_service_pb";-import {- extractIssueUID,- extractProjectResourceName,- getHighlightHTMLByRegExp,- getIssueRoute,- humanizeTs,- projectOfIssue,-} from "@/utils";+import { extractIssueUID } from "@/utils";import BatchIssueActionsV1 from "./BatchIssueActionsV1.vue";-import IssueApprovalStatus from "./IssueApprovalStatus.vue";-import { getValidIssueLabels } from "./IssueLabelSelector.vue";-import IssueStatusIcon from "./IssueStatusIcon.vue";+import IssueListItem from "./IssueListItem.vue";const props = withDefaults(defineProps<{issueList: Issue[];- bordered?: boolean;- title?: string;highlightText?: string;loading?: boolean;showProject?: boolean;showSelection?: boolean;}>(),{- title: "",highlightText: "",loading: true,- bordered: false,showSelection: true,});-const router = useRouter();-const userStore = useUserStore();--const listRef = ref<HTMLDivElement>();-const isListInViewport = useElementVisibilityInScrollParent(listRef);const selectedIssueNames = ref(new Set<string>());// Sorting: matching issues first when searching, then by ID descending@@ -197,6 +81,13 @@ const selectedIssueList = computed(() => {);});+const allSelected = computed(() => {+ return (+ props.issueList.length > 0 &&+ props.issueList.every((issue) => selectedIssueNames.value.has(issue.name))+ );+});+const toggleSelection = (issue: Issue) => {if (selectedIssueNames.value.has(issue.name)) {selectedIssueNames.value.delete(issue.name);@@ -205,6 +96,16 @@ const toggleSelection = (issue: Issue) => {}};+const toggleSelectAll = () => {+ if (allSelected.value) {+ selectedIssueNames.value.clear();+ } else {+ for (const issue of props.issueList) {+ selectedIssueNames.value.add(issue.name);+ }+ }+};+watch(() => props.issueList,(list) => {@@ -216,59 +117,4 @@ watch(}});--// Navigation-const issueUrl = (issue: Issue) => {- const issueRoute = getIssueRoute(issue);- return router.resolve({- name: issueRoute.name,- params: issueRoute.params,- }).fullPath;-};--const onRowClick = (issue: Issue, e: MouseEvent) => {- const url = issueUrl(issue);- if (e.ctrlKey || e.metaKey) {- window.open(url, "_blank");- } else {- router.push(url);- }-};--// Labels-const validLabels = (issue: Issue) => {- const project = projectOfIssue(issue);- const validValues = getValidIssueLabels(issue.labels, project.issueLabels);- return project.issueLabels.filter((label) =>- validValues.includes(label.value)- );-};--// Creator-const creatorOfIssue = (issue: Issue) => {- return (- userStore.getUserByIdentifier(issue.creator) || unknownUser(issue.creator)- );-};--// Search highlighting-const highlightWords = computed(() => {- if (!props.highlightText) return [];- return props.highlightText.toLowerCase().split(" ");-});--const highlight = (content: string) => {- return getHighlightHTMLByRegExp(- content,- highlightWords.value,- false,- "bg-yellow-100"- );-};--const isIssueExpanded = (issue: Issue): boolean => {- if (!props.highlightText || !issue.description) return false;- const desc = issue.description.toLowerCase();- return highlightWords.value.some((word) => desc.includes(word));-};</script>