Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(review): name the engine map reviewFuncs after the contract type
rebelice204d2d1a1716
diff --git a/backend/runner/reviewrun/reviewers.go b/backend/runner/reviewrun/review_funcs.gosimilarity index 71%rename from backend/runner/reviewrun/reviewers.gorename to backend/runner/reviewrun/review_funcs.goindex 7cc4e0679c..324c957d26 100644--- a/backend/runner/reviewrun/reviewers.go+++ b/backend/runner/reviewrun/review_funcs.go@@ -6,8 +6,8 @@ import (storepb "github.com/bytebase/bytebase/backend/generated-go/store")-// reviewers maps an engine to its omni review entry point. An engine absent+// reviewFuncs maps an engine to its omni Review entry point. An engine absent// here has no standard rule review, and a run touching it fails. The map// fills in as omni ships engine review packages (pg/review, mysql/review,// ...): each one is a line here and nothing else.-var reviewers = map[storepb.Engine]review.ReviewFunc{}+var reviewFuncs = map[storepb.Engine]review.ReviewFunc{}diff --git a/backend/runner/reviewrun/rule_executor.go b/backend/runner/reviewrun/rule_executor.goindex 6827753215..4aabaad1d3 100644--- a/backend/runner/reviewrun/rule_executor.go+++ b/backend/runner/reviewrun/rule_executor.go@@ -24,13 +24,13 @@ const maxBackupSize = common.MaxSheetCheckSize// call per (spec, engine), the caller resolving every input that needs the// store and the engine deriving the findings.type RuleExecutor struct {- store *store.Store- reviewers map[storepb.Engine]review.ReviewFunc+ store *store.Store+ reviewFuncs map[storepb.Engine]review.ReviewFunc}// NewRuleExecutor creates the standard-rule review executor.func NewRuleExecutor(s *store.Store) *RuleExecutor {- return &RuleExecutor{store: s, reviewers: reviewers}+ return &RuleExecutor{store: s, reviewFuncs: reviewFuncs}}// RunOnce implements Executor. Collect-all, no fail-fast: every unit is@@ -97,7 +97,7 @@ func (e *RuleExecutor) RunOnce(ctx context.Context, projectID string, issueUID iif err := ctx.Err(); err != nil {return nil, err}- reviewer, ok := e.reviewers[unit.Engine]+ reviewFunc, ok := e.reviewFuncs[unit.Engine]if !ok {unitErrs = append(unitErrs, unit.failures(errors.Errorf("engine %s has no standard rule reviewer", unit.Engine))...)continue@@ -120,7 +120,7 @@ func (e *RuleExecutor) RunOnce(ctx context.Context, projectID string, issueUID ifor _, target := range unit.Targets {inputs = append(inputs, target.Input)}- result, err := reviewer(ctx, sql, unit.Options, inputs)+ result, err := reviewFunc(ctx, sql, unit.Options, inputs)if err != nil {unitErrs = append(unitErrs, unit.failures(err)...)continue