Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: prefetch members (#20553)
ecmadao20af99b5b66d
diff --git a/frontend/src/react/stores/app/iam.ts b/frontend/src/react/stores/app/iam.tsindex bce059415a..2a14559132 100644--- a/frontend/src/react/stores/app/iam.ts+++ b/frontend/src/react/stores/app/iam.ts@@ -94,18 +94,28 @@ export const createIamSlice: AppSliceCreator<IamSlice> = (set, get) => ({).then(async (workspacePolicy) => {set({ workspacePolicy, workspacePolicyRequest: undefined });- // Prefetch groups referenced by the policy so derived role/user- // maps (and any UI that resolves group display names) read from- // a populated cache. Without this every page that reads the- // policy had to hedge with its own fetchWorkspaceIamPolicy().- const groupMembers = workspacePolicy.bindings- .flatMap((binding) => binding.members)- .filter((member) => member.startsWith(groupBindingPrefix));- if (groupMembers.length > 0) {- await get()- .batchGetOrFetchGroups(groupMembers)- .catch(() => []);+ // Prefetch the group / user members referenced by the policy so+ // derived role maps and any UI that resolves member display names+ // (e.g. the workspace members table's `getMemberBindings`) read+ // from a populated cache. Without the user prefetch every member+ // failed the `getUserByIdentifier` lookup and was flagged pending,+ // rendering an "Invited" badge for everyone in SaaS mode. Mirrors+ // the project IAM path in `loadProjectIamPolicy`.+ const groupMembers: string[] = [];+ const userMembers: string[] = [];+ for (const binding of workspacePolicy.bindings) {+ for (const member of binding.members) {+ if (member.startsWith(groupBindingPrefix)) {+ groupMembers.push(member);+ } else {+ userMembers.push(member);+ }+ }}+ await Promise.allSettled([+ get().batchGetOrFetchGroups(groupMembers),+ get().batchGetOrFetchUsers(userMembers),+ ]);return workspacePolicy;}).catch(() => {diff --git a/frontend/src/react/stores/app/index.test.ts b/frontend/src/react/stores/app/index.test.tsindex 002708a263..8347994b2a 100644--- a/frontend/src/react/stores/app/index.test.ts+++ b/frontend/src/react/stores/app/index.test.ts@@ -863,6 +863,35 @@ describe("useAppStore", () => {expect(store.getState().roleList).toEqual([roleA, roleB]);});+ test("prefetches user members referenced by the workspace policy", async () => {+ mocks.getCurrentUser.mockResolvedValue(user);+ mocks.getActuatorInfo.mockResolvedValue({+ workspace: "workspaces/default",+ });+ mocks.getWorkspace.mockResolvedValue({ name: "workspaces/default" });+ mocks.listRoles.mockResolvedValue({ roles: [roleA] });+ mocks.getIamPolicy.mockResolvedValue(+ createProto(IamPolicySchema, {+ bindings: [+ createProto(BindingSchema, {+ role: roleA.name,+ members: [`user:${userA.email}`],+ }),+ ],+ })+ );+ mocks.batchGetUsers.mockResolvedValue({ users: [userA] });+ const store = createAppStore();++ await store.getState().loadWorkspacePermissionState();++ expect(mocks.batchGetUsers).toHaveBeenCalledWith(+ expect.objectContaining({ names: [userA.name] }),+ expect.anything()+ );+ expect(store.getState().usersByName[userA.name]).toBe(userA);+ });+test("lists releases and marks cached release deleted", async () => {mocks.listReleases.mockResolvedValue({releases: [releaseA, releaseB],