Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor: remove redundant IAM permission checks in allow_missing scenarios (#18306)

Danny Xu250e72948793
diff --git a/backend/api/v1/database_group_service.go b/backend/api/v1/database_group_service.go
index d82b8a1f25..e14bc90bcc 100644
--- a/backend/api/v1/database_group_service.go
+++ b/backend/api/v1/database_group_service.go
@@ -119,11 +119,6 @@ func (s *DatabaseGroupService) UpdateDatabaseGroup(ctx context.Context, req *con
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %q has been deleted", projectResourceID))
}
- user, ok := GetUserFromContext(ctx)
- if !ok {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))
- }
-
existedDatabaseGroup, err := s.store.GetDatabaseGroup(ctx, &store.FindDatabaseGroupMessage{
ProjectID: &project.ResourceID,
ResourceID: &databaseGroupResourceID,
@@ -133,13 +128,6 @@ func (s *DatabaseGroupService) UpdateDatabaseGroup(ctx context.Context, req *con
}
if existedDatabaseGroup == nil {
if req.Msg.AllowMissing {
- ok, err := s.iamManager.CheckPermission(ctx, iam.PermissionDatabaseGroupsCreate, user, project.ResourceID)
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to check permission"))
- }
- if !ok {
- return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q", iam.PermissionDatabaseGroupsCreate))
- }
return s.CreateDatabaseGroup(ctx, connect.NewRequest(&v1pb.CreateDatabaseGroupRequest{
Parent: common.FormatProject(project.ResourceID),
DatabaseGroupId: databaseGroupResourceID,
diff --git a/backend/api/v1/instance_service.go b/backend/api/v1/instance_service.go
index 324401e92b..47b7c82f84 100644
--- a/backend/api/v1/instance_service.go
+++ b/backend/api/v1/instance_service.go
@@ -326,23 +326,11 @@ func (s *InstanceService) UpdateInstance(ctx context.Context, req *connect.Reque
if err != nil {
if strings.Contains(err.Error(), "not found") && req.Msg.AllowMissing {
// When allow_missing is true and instance doesn't exist, create a new one
- user, ok := GetUserFromContext(ctx)
- if !ok {
- return nil, connect.NewError(connect.CodeInternal, errors.New("user not found"))
- }
-
instanceID, ierr := common.GetInstanceID(req.Msg.Instance.Name)
if ierr != nil {
return nil, connect.NewError(connect.CodeInvalidArgument, ierr)
}
- ok, err = s.iamManager.CheckPermission(ctx, iam.PermissionInstancesCreate, user)
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to check permission"))
- }
- if !ok {
- return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q", iam.PermissionInstancesCreate))
- }
return s.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{
InstanceId: instanceID,
Instance: req.Msg.Instance,
@@ -691,11 +679,6 @@ func (s *InstanceService) UpdateDataSource(ctx context.Context, req *connect.Req
return nil, connect.NewError(connect.CodeInvalidArgument, errors.New("update_mask must be set"))
}
- user, ok := GetUserFromContext(ctx)
- if !ok {
- return nil, connect.NewError(connect.CodeInternal, errors.New("user not found"))
- }
-
instance, err := getInstanceMessage(ctx, s.store, req.Msg.Name)
if err != nil {
return nil, err
@@ -713,13 +696,6 @@ func (s *InstanceService) UpdateDataSource(ctx context.Context, req *connect.Req
}
if dataSource == nil {
if req.Msg.AllowMissing {
- ok, err := s.iamManager.CheckPermission(ctx, iam.PermissionInstancesCreate, user)
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to check permission"))
- }
- if !ok {
- return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q", iam.PermissionInstancesCreate))
- }
return s.AddDataSource(ctx, connect.NewRequest(&v1pb.AddDataSourceRequest{
Name: req.Msg.Name,
DataSource: req.Msg.DataSource,
diff --git a/backend/api/v1/project_service.go b/backend/api/v1/project_service.go
index 4e53fd0a12..a92b0e9fef 100644
--- a/backend/api/v1/project_service.go
+++ b/backend/api/v1/project_service.go
@@ -225,23 +225,11 @@ func (s *ProjectService) UpdateProject(ctx context.Context, req *connect.Request
if err != nil {
if connect.CodeOf(err) == connect.CodeNotFound && req.Msg.AllowMissing {
// When allow_missing is true and project doesn't exist, create a new one
- user, ok := GetUserFromContext(ctx)
- if !ok {
- return nil, connect.NewError(connect.CodeInternal, errors.New("user not found"))
- }
-
projectID, perr := common.GetProjectID(req.Msg.Project.Name)
if perr != nil {
return nil, connect.NewError(connect.CodeInvalidArgument, perr)
}
- ok, err = s.iamManager.CheckPermission(ctx, iam.PermissionProjectsCreate, user)
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to check permission"))
- }
- if !ok {
- return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q", iam.PermissionProjectsCreate))
- }
return s.CreateProject(ctx, connect.NewRequest(&v1pb.CreateProjectRequest{
Project: req.Msg.Project,
ProjectId: projectID,
@@ -863,18 +851,6 @@ func (s *ProjectService) UpdateWebhook(ctx context.Context, req *connect.Request
if webhook == nil {
if req.Msg.AllowMissing {
// When allow_missing is true and webhook doesn't exist, create a new one
- user, ok := GetUserFromContext(ctx)
- if !ok {
- return nil, connect.NewError(connect.CodeInternal, errors.New("user not found"))
- }
- // Check if user has permission to update project (which includes adding webhooks)
- ok, err := s.iamManager.CheckPermission(ctx, iam.PermissionProjectsUpdate, user, project.ResourceID)
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to check permission"))
- }
- if !ok {
- return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q", iam.PermissionProjectsUpdate))
- }
// Call AddWebhook instead since we're creating a new webhook
return s.AddWebhook(ctx, connect.NewRequest(&v1pb.AddWebhookRequest{
Project: fmt.Sprintf("projects/%s", project.ResourceID),
diff --git a/backend/api/v1/release_service.go b/backend/api/v1/release_service.go
index 5eab7eaa47..661e943719 100644
--- a/backend/api/v1/release_service.go
+++ b/backend/api/v1/release_service.go
@@ -287,11 +287,6 @@ func (s *ReleaseService) UpdateRelease(ctx context.Context, req *connect.Request
return nil, connect.NewError(connect.CodeInvalidArgument, errors.Wrapf(err, "failed to get release uid"))
}
- user, ok := GetUserFromContext(ctx)
- if !ok {
- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))
- }
-
// Use GetReleaseV2 with FindReleaseMessage for database-level filtering
release, err := s.store.GetReleaseV2(ctx, &store.FindReleaseMessage{
ProjectID: &projectID,
@@ -309,13 +304,6 @@ func (s *ReleaseService) UpdateRelease(ctx context.Context, req *connect.Request
if project == nil {
return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project %s not found", projectID))
}
- ok, err := s.iamManager.CheckPermission(ctx, iam.PermissionReleasesCreate, user, project.ResourceID)
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrap(err, "failed to check permission"))
- }
- if !ok {
- return nil, connect.NewError(connect.CodePermissionDenied, errors.Errorf("user does not have permission %q", iam.PermissionReleasesCreate))
- }
return s.CreateRelease(ctx, connect.NewRequest(&v1pb.CreateReleaseRequest{
Parent: common.FormatProject(project.ResourceID),
Release: req.Msg.Release,