Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: validate issue ownership in UpdateIssueComment to prevent IDOR (#19552)
p0ny270e25529731
diff --git a/backend/api/v1/issue_service.go b/backend/api/v1/issue_service.goindex 5d00436350..b90181a6f1 100644--- a/backend/api/v1/issue_service.go+++ b/backend/api/v1/issue_service.go@@ -1144,11 +1144,19 @@ func (s *IssueService) UpdateIssueComment(ctx context.Context, req *connect.Requreturn nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))}- _, _, issueCommentUID, err := common.GetProjectIDIssueUIDIssueCommentUID(req.Msg.IssueComment.Name)+ _, parentIssueUID, err := common.GetProjectIDIssueUID(req.Msg.Parent)+ if err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("invalid parent %q: %v", req.Msg.Parent, err))+ }++ _, commentIssueUID, issueCommentUID, err := common.GetProjectIDIssueUIDIssueCommentUID(req.Msg.IssueComment.Name)if err != nil {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("invalid comment name %q: %v", req.Msg.IssueComment.Name, err))}- issueComment, err := s.store.GetIssueComment(ctx, &store.FindIssueCommentMessage{UID: &issueCommentUID})+ if parentIssueUID != commentIssueUID {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("issue comment %q does not belong to parent %q", req.Msg.IssueComment.Name, req.Msg.Parent))+ }+ issueComment, err := s.store.GetIssueComment(ctx, &store.FindIssueCommentMessage{UID: &issueCommentUID, IssueUID: &parentIssueUID})if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get issue comment: %v", err))}@@ -1168,7 +1176,6 @@ func (s *IssueService) UpdateIssueComment(ctx context.Context, req *connect.Requ}return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("issue comment not found"))}-update := &store.UpdateIssueCommentMessage{UID: issueCommentUID,}