Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(store): remove unnecessary single-operation transactions (#19064)
p0ny298510c4cda1
diff --git a/backend/store/query_history.go b/backend/store/query_history.goindex f1b7d20200..0b6c9ed410 100644--- a/backend/store/query_history.go+++ b/backend/store/query_history.go@@ -93,21 +93,12 @@ func (s *Store) CreateQueryHistory(ctx context.Context, create *QueryHistoryMessreturn nil, errors.Wrapf(err, "failed to build sql")}- tx, err := s.GetDB().BeginTx(ctx, nil)- if err != nil {- return nil, err- }- defer tx.Rollback()-- if err := tx.QueryRowContext(ctx, sql, args...).Scan(+ if err := s.GetDB().QueryRowContext(ctx, sql, args...).Scan(&create.UID,&create.CreatedAt,); err != nil {return nil, err}- if err := tx.Commit(); err != nil {- return nil, errors.Wrapf(err, "failed to commit transaction")- }return create, nil}diff --git a/backend/store/sheet.go b/backend/store/sheet.goindex e6a85b3fb7..8130962320 100644--- a/backend/store/sheet.go+++ b/backend/store/sheet.go@@ -3,7 +3,6 @@ package storeimport ("context""crypto/sha256"- "database/sql""encoding/hex""fmt"@@ -76,13 +75,7 @@ func (s *Store) getSheet(ctx context.Context, sha256Hex string, loadFull bool) (return nil, errors.Wrapf(err, "failed to build sql")}- tx, err := s.GetDB().BeginTx(ctx, &sql.TxOptions{ReadOnly: true})- if err != nil {- return nil, err- }- defer tx.Rollback()-- rows, err := tx.QueryContext(ctx, query, args...)+ rows, err := s.GetDB().QueryContext(ctx, query, args...)if err != nil {return nil, err}@@ -104,9 +97,6 @@ func (s *Store) getSheet(ctx context.Context, sha256Hex string, loadFull bool) (if err := rows.Err(); err != nil {return nil, err}- if err := tx.Commit(); err != nil {- return nil, err- }if sheet == nil {return nil, nildiff --git a/backend/store/sync_history.go b/backend/store/sync_history.goindex 9da4bdff3f..6820c554e7 100644--- a/backend/store/sync_history.go+++ b/backend/store/sync_history.go@@ -86,19 +86,10 @@ func (s *Store) CreateSyncHistory(ctx context.Context, instanceID, databaseNamereturn 0, errors.Wrapf(err, "failed to build sql")}- tx, err := s.GetDB().BeginTx(ctx, nil)- if err != nil {- return 0, errors.Wrapf(err, "failed to begin tx")- }- defer tx.Rollback()-var id int64- if err := tx.QueryRowContext(ctx, query, args...).Scan(&id); err != nil {+ if err := s.GetDB().QueryRowContext(ctx, query, args...).Scan(&id); err != nil {return 0, errors.Wrapf(err, "failed to insert")}- if err := tx.Commit(); err != nil {- return 0, errors.Wrapf(err, "failed to commit")- }return id, nil}diff --git a/backend/store/worksheet.go b/backend/store/worksheet.goindex 1dc8cc6f03..ef490002ef 100644--- a/backend/store/worksheet.go+++ b/backend/store/worksheet.go@@ -201,12 +201,7 @@ func (s *Store) CreateWorkSheet(ctx context.Context, create *WorkSheetMessage) (return nil, errors.Wrapf(err, "failed to build sql")}- tx, err := s.GetDB().BeginTx(ctx, nil)- if err != nil {- return nil, err- }- defer tx.Rollback()- if err := tx.QueryRowContext(ctx, query, args...).Scan(+ if err := s.GetDB().QueryRowContext(ctx, query, args...).Scan(&create.UID,&create.CreatedAt,&create.UpdatedAt,@@ -217,9 +212,6 @@ func (s *Store) CreateWorkSheet(ctx context.Context, create *WorkSheetMessage) (}return nil, err}- if err := tx.Commit(); err != nil {- return nil, errors.Wrapf(err, "failed to commit transaction")- }return create, nil}@@ -341,12 +333,6 @@ func (s *Store) GetWorksheetOrganizer(ctx context.Context, worksheetUID int, pri// UpsertWorksheetOrganizer upserts a new SheetOrganizerMessage.func (s *Store) UpsertWorksheetOrganizer(ctx context.Context, patch *WorksheetOrganizerMessage) (*WorksheetOrganizerMessage, error) {- tx, err := s.GetDB().BeginTx(ctx, nil)- if err != nil {- return nil, err- }- defer tx.Rollback()-payloadStr, err := protojson.Marshal(patch.Payload)if err != nil {return nil, err@@ -374,7 +360,7 @@ func (s *Store) UpsertWorksheetOrganizer(ctx context.Context, patch *WorksheetOrvar worksheetOrganizer WorksheetOrganizerMessagevar payload []byte- if err := tx.QueryRowContext(ctx, query, args...).Scan(+ if err := s.GetDB().QueryRowContext(ctx, query, args...).Scan(&worksheetOrganizer.UID,&worksheetOrganizer.WorksheetUID,&worksheetOrganizer.Principal,@@ -391,10 +377,6 @@ func (s *Store) UpsertWorksheetOrganizer(ctx context.Context, patch *WorksheetOr}worksheetOrganizer.Payload = workSheetPayload- if err := tx.Commit(); err != nil {- return nil, err- }-return &worksheetOrganizer, nil}