Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: display function/procedure signatures instead of names (#17688)

Vincent Huang2ad28fbee045
diff --git a/frontend/src/components/FunctionDataTable.vue b/frontend/src/components/FunctionDataTable.vue
index d651888fef..900ebcb37a 100644
--- a/frontend/src/components/FunctionDataTable.vue
+++ b/frontend/src/components/FunctionDataTable.vue
@@ -7,7 +7,7 @@
:striped="true"
:bordered="true"
:loading="loading"
- :row-key="(f: FunctionMetadata) => `${database.name}.${schemaName}.${f.name}`"
+ :row-key="(f: FunctionMetadata) => `${database.name}.${schemaName}.${f.signature || f.name}`"
/>
</template>
@@ -58,7 +58,7 @@ const columns = computed(() => {
tooltip: true,
},
render: (row) => {
- return row.name;
+ return row.signature || row.name;
},
},
{
diff --git a/frontend/src/components/SchemaEditorLite/Aside/common.ts b/frontend/src/components/SchemaEditorLite/Aside/common.ts
index baa3e11ce5..5325fe68fe 100644
--- a/frontend/src/components/SchemaEditorLite/Aside/common.ts
+++ b/frontend/src/components/SchemaEditorLite/Aside/common.ts
@@ -470,7 +470,7 @@ export const useBuildTree = () => {
type: "procedure",
parent,
key: keyForResource(db, metadata),
- label: procedure.name,
+ label: procedure.signature || procedure.name,
isLeaf: true,
db,
metadata,
@@ -496,7 +496,7 @@ export const useBuildTree = () => {
type: "function",
parent,
key: keyForResource(db, metadata),
- label: func.name,
+ label: func.signature || func.name,
isLeaf: true,
db,
metadata,
diff --git a/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/FunctionNode.vue b/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/FunctionNode.vue
index 87978162b2..ad4e3031cb 100644
--- a/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/FunctionNode.vue
+++ b/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/FunctionNode.vue
@@ -27,12 +27,11 @@ const dbSchema = useDBSchemaV1Store();
const target = computed(() => (props.node as TreeNode<"function">).meta.target);
-const functionMetadata = computed(() =>
- dbSchema
- .getSchemaMetadata({
+const functionMetadata = computed(
+ () =>
+ dbSchema.getSchemaMetadata({
database: target.value.database,
schema: target.value.schema,
- })
- .functions.find((f) => f.name === target.value.function)
+ }).functions[target.value.position]
);
</script>
diff --git a/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/ProcedureNode.vue b/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/ProcedureNode.vue
index a0e58af597..7e9b33c101 100644
--- a/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/ProcedureNode.vue
+++ b/frontend/src/views/sql-editor/AsidePanel/SchemaPane/TreeNode/ProcedureNode.vue
@@ -1,6 +1,6 @@
<template>
<CommonNode
- :text="target.procedure"
+ :text="(procedureMetadata?.signature || procedureMetadata?.name) ?? ''"
:keyword="keyword"
:highlight="true"
:indent="0"
@@ -14,6 +14,7 @@
<script setup lang="ts">
import { computed } from "vue";
import { ProcedureIcon } from "@/components/Icon";
+import { useDBSchemaV1Store } from "@/store";
import type { TreeNode } from "../tree";
import CommonNode from "./CommonNode.vue";
@@ -22,7 +23,17 @@ const props = defineProps<{
keyword: string;
}>();
+const dbSchema = useDBSchemaV1Store();
+
const target = computed(
() => (props.node as TreeNode<"procedure">).meta.target
);
+
+const procedureMetadata = computed(
+ () =>
+ dbSchema.getSchemaMetadata({
+ database: target.value.database,
+ schema: target.value.schema,
+ }).procedures[target.value.position]
+);
</script>