Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(frontend): align agent input composer controls (#19972)
p0ny2e1d0d176d85
diff --git a/frontend/src/react/plugins/agent/components/AgentInput.test.tsx b/frontend/src/react/plugins/agent/components/AgentInput.test.tsxnew file mode 100644index 0000000000..1b20bf2343--- /dev/null+++ b/frontend/src/react/plugins/agent/components/AgentInput.test.tsx@@ -0,0 +1,244 @@+import type { ReactElement } from "react";+import { act } from "react";+import { createRoot } from "react-dom/client";+import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";+import { createAgentStore, useAgentStore } from "../store/agent";++(+ globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }+).IS_REACT_ACT_ENVIRONMENT = true;++const mocks = vi.hoisted(() => ({+ useTranslation: vi.fn(() => ({+ t: (key: string) => key,+ })),+ routerPush: vi.fn(),+ lazyExtractDomRefSuggestions: vi.fn(async () => []),+ runAgentLoop: vi.fn(),+ isAgentAIConfigurationError: vi.fn(() => false),+ buildOutboundHistory: vi.fn(() => []),+ buildSystemPrompt: vi.fn(() => "system"),+ createToolExecutor: vi.fn(() => ({})),+ getToolDefinitions: vi.fn(() => []),+}));++let AgentInput: typeof import("./AgentInput").AgentInput;++function createMockStorage(): Storage {+ let store: Record<string, string> = {};+ return {+ get length() {+ return Object.keys(store).length;+ },+ key(index: number) {+ return Object.keys(store)[index] ?? null;+ },+ getItem(key: string) {+ return store[key] ?? null;+ },+ setItem(key: string, value: string) {+ store[key] = String(value);+ },+ removeItem(key: string) {+ delete store[key];+ },+ clear() {+ store = {};+ },+ };+}++vi.mock("react-i18next", () => ({+ useTranslation: mocks.useTranslation,+}));++vi.mock("@/router", () => ({+ router: {+ currentRoute: {+ value: {+ fullPath: "/demo",+ },+ },+ push: mocks.routerPush,+ },+}));++vi.mock("../dom", () => ({+ lazyExtractDomRefSuggestions: mocks.lazyExtractDomRefSuggestions,+}));++vi.mock("../logic/agentLoop", () => ({+ runAgentLoop: mocks.runAgentLoop,+}));++vi.mock("../logic/aiConfiguration", () => ({+ isAgentAIConfigurationError: mocks.isAgentAIConfigurationError,+}));++vi.mock("../logic/outboundHistory", () => ({+ buildOutboundHistory: mocks.buildOutboundHistory,+}));++vi.mock("../logic/prompt", () => ({+ buildSystemPrompt: mocks.buildSystemPrompt,+}));++vi.mock("../logic/tools", () => ({+ createToolExecutor: mocks.createToolExecutor,+ getToolDefinitions: mocks.getToolDefinitions,+}));++const renderIntoContainer = (element: ReactElement) => {+ const container = document.createElement("div");+ const root = createRoot(container);++ return {+ container,+ render: () => {+ act(() => {+ root.render(element);+ });+ },+ unmount: () =>+ act(() => {+ root.unmount();+ }),+ };+};++const setTextareaValue = (textarea: HTMLTextAreaElement, value: string) => {+ const descriptor = Object.getOwnPropertyDescriptor(+ HTMLTextAreaElement.prototype,+ "value"+ );+ descriptor?.set?.call(textarea, value);+};++beforeEach(async () => {+ vi.stubGlobal("localStorage", createMockStorage());+ useAgentStore.setState(createAgentStore().getState(), true);++ mocks.useTranslation.mockReset();+ mocks.useTranslation.mockReturnValue({+ t: (key: string) => key,+ });+ mocks.routerPush.mockReset();+ mocks.lazyExtractDomRefSuggestions.mockReset();+ mocks.lazyExtractDomRefSuggestions.mockResolvedValue([]);+ mocks.runAgentLoop.mockReset();+ mocks.isAgentAIConfigurationError.mockReset();+ mocks.isAgentAIConfigurationError.mockReturnValue(false);+ mocks.buildOutboundHistory.mockReset();+ mocks.buildOutboundHistory.mockReturnValue([]);+ mocks.buildSystemPrompt.mockReset();+ mocks.buildSystemPrompt.mockReturnValue("system");+ mocks.createToolExecutor.mockReset();+ mocks.createToolExecutor.mockReturnValue({});+ mocks.getToolDefinitions.mockReset();+ mocks.getToolDefinitions.mockReturnValue([]);++ ({ AgentInput } = await import("./AgentInput"));+});++afterEach(() => {+ vi.unstubAllGlobals();+});++describe("AgentInput", () => {+ test("shows a single-line overlay placeholder and hides it when typing", () => {+ const { container, render, unmount } = renderIntoContainer(<AgentInput />);++ render();++ const placeholder = container.querySelector(+ "[data-agent-input-placeholder]"+ );+ expect(placeholder?.textContent).toBe("agent.input-placeholder");+ expect(placeholder?.className).toContain("truncate");+ expect(placeholder?.className).toContain("pointer-events-none");++ const textarea = container.querySelector("textarea");+ expect(textarea).toBeInstanceOf(HTMLTextAreaElement);++ act(() => {+ setTextareaValue(textarea as HTMLTextAreaElement, "hello");+ textarea?.dispatchEvent(new Event("input", { bubbles: true }));+ });++ expect(+ container.querySelector("[data-agent-input-placeholder]")+ ).toBeNull();++ unmount();+ });++ test("uses the same single-line height for the textarea and send button", () => {+ const { container, render, unmount } = renderIntoContainer(<AgentInput />);++ render();++ const row = container.querySelector("[data-agent-input-row]");+ expect(row?.className).toContain("items-end");+ expect(container.querySelector("textarea")?.className).toContain(+ "min-h-[34px]"+ );+ expect(container.querySelector("textarea")?.className).toContain(+ "max-h-[134px]"+ );+ expect(container.querySelector("textarea")?.className).toContain("block");+ expect(container.querySelector("button")?.className).toContain("h-[34px]");++ unmount();+ });++ test("sizes from CSS min/max heights and enables scrolling only at max height", () => {+ const { container, render, unmount } = renderIntoContainer(<AgentInput />);++ render();++ const textarea = container.querySelector("textarea");+ expect(textarea).toBeInstanceOf(HTMLTextAreaElement);++ const element = textarea as HTMLTextAreaElement;+ let scrollHeight = 32;+ Object.defineProperty(element, "scrollHeight", {+ configurable: true,+ get: () => scrollHeight,+ });+ Object.defineProperty(element, "offsetHeight", {+ configurable: true,+ get: () => 34,+ });+ Object.defineProperty(element, "clientHeight", {+ configurable: true,+ get: () => 32,+ });+ const getComputedStyleSpy = vi+ .spyOn(window, "getComputedStyle")+ .mockReturnValue({+ minHeight: "34px",+ maxHeight: "134px",+ } as CSSStyleDeclaration);++ act(() => {+ setTextareaValue(element, "hello");+ element.dispatchEvent(new Event("input", { bubbles: true }));+ });++ expect(element.style.height).toBe("34px");+ expect(element.style.overflowY).toBe("hidden");++ scrollHeight = 200;++ act(() => {+ setTextareaValue(element, "a\nb\nc\nd\ne\nf\ng");+ element.dispatchEvent(new Event("input", { bubbles: true }));+ });++ expect(element.style.height).toBe("134px");+ expect(element.style.overflowY).toBe("auto");++ getComputedStyleSpy.mockRestore();+ unmount();+ });+});diff --git a/frontend/src/react/plugins/agent/components/AgentInput.tsx b/frontend/src/react/plugins/agent/components/AgentInput.tsxindex 03676d6eaf..0b48c4813f 100644--- a/frontend/src/react/plugins/agent/components/AgentInput.tsx+++ b/frontend/src/react/plugins/agent/components/AgentInput.tsx@@ -214,11 +214,20 @@ export function AgentInput() {const autoResize = useCallback(() => {const el = textareaRef.current;if (!el) return;+el.style.height = "auto";- const maxRows = 6;- const lineHeight = 20;- const maxHeight = lineHeight * maxRows;- el.style.height = `${Math.min(el.scrollHeight, maxHeight)}px`;++ const styles = window.getComputedStyle(el);+ const minHeight =+ Number.parseFloat(styles.minHeight) || el.getBoundingClientRect().height;+ const maxHeight =+ Number.parseFloat(styles.maxHeight) || Number.POSITIVE_INFINITY;+ const borderHeight = el.offsetHeight - el.clientHeight;+ const contentHeight = el.scrollHeight + borderHeight;+ const nextHeight = Math.max(minHeight, Math.min(contentHeight, maxHeight));++ el.style.height = `${nextHeight}px`;+ el.style.overflowY = contentHeight > maxHeight ? "auto" : "hidden";}, []);useEffect(() => {@@ -675,18 +684,22 @@ export function AgentInput() {</div>) : (/* Input row with @-mention autocomplete */- <div- className="relative flex items-center gap-x-2"- data-agent-input-row- >+ <div className="relative flex items-end gap-x-2" data-agent-input-row><div className="relative w-full">+ {!input && (+ <div+ className="pointer-events-none absolute inset-x-3 top-1.5 z-10 truncate text-sm leading-5 text-control-light"+ data-agent-input-placeholder+ >+ {inputPlaceholder}+ </div>+ )}<textarearef={textareaRef}value={input}rows={1}- className="w-full resize-none rounded-xs border px-3 py-1.5 text-sm outline-none focus:ring-1 focus:ring-accent disabled:opacity-50"- style={{ maxHeight: 120 }}- placeholder={inputPlaceholder}+ className="block min-h-[34px] max-h-[134px] w-full resize-none overflow-y-hidden rounded-xs border px-3 py-1.5 text-sm leading-5 outline-none focus:ring-1 focus:ring-accent disabled:opacity-50"+ aria-label={inputPlaceholder}disabled={isCurrentChatRunning || isAIConfigurationBlocked}onChange={(e) => {setInput(e.target.value);@@ -747,7 +760,7 @@ export function AgentInput() {<Buttonvariant="destructive"size="sm"- className="whitespace-nowrap"+ className="h-[34px] shrink-0 self-end whitespace-nowrap"onClick={() => useAgentStore.getState().cancel(currentChat?.id)}>{t("agent.stop")}@@ -755,7 +768,7 @@ export function AgentInput() {) : (<Buttonsize="sm"- className="whitespace-nowrap"+ className="h-[34px] shrink-0 self-end whitespace-nowrap"disabled={isSendDisabled}onClick={() => void send()}>