Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(frontend): distinct icons for close/reopen in plan review activity (#20724)
boojack2ed47c85a044
diff --git a/frontend/src/react/components/issue-activity/IssueCommentActivity.tsx b/frontend/src/react/components/issue-activity/IssueCommentActivity.tsxindex 1654c3ede9..2ba161628f 100644--- a/frontend/src/react/components/issue-activity/IssueCommentActivity.tsx+++ b/frontend/src/react/components/issue-activity/IssueCommentActivity.tsx@@ -297,8 +297,14 @@ function IssueCommentActionIcon({ issue, plan, comment }: ActivityProps) {return <ActivityBadge spec={ISSUE_EVENT_ICON.resolved} />;}- const { fromLabels, toDescription, toLabels, toTitle } =+ const { fromLabels, toDescription, toLabels, toStatus, toTitle } =comment.event.value;+ if (toStatus === IssueStatus.CANCELED) {+ return <ActivityBadge spec={ISSUE_EVENT_ICON.closed} />;+ }+ if (toStatus === IssueStatus.OPEN) {+ return <ActivityBadge spec={ISSUE_EVENT_ICON.reopened} />;+ }if (toTitle !== undefined ||toDescription !== undefined ||diff --git a/frontend/src/react/components/issue-activity/activityIcons.ts b/frontend/src/react/components/issue-activity/activityIcons.tsindex a4cb6d2e07..ce3362e782 100644--- a/frontend/src/react/components/issue-activity/activityIcons.ts+++ b/frontend/src/react/components/issue-activity/activityIcons.ts@@ -16,11 +16,15 @@// Plan change (activity): added / deleted / edited — one symmetric "file"// trio, so "edit a change" (FilePen) never collides with an issue-field// edit (Pencil) or a reject.-// Issue event (activity): field edit (Pencil) / resolved (CheckCircle2)+// Issue event (activity): field edit (Pencil) / resolved (CheckCircle2) /+// closed (Ban) / reopened (CircleDot) — a close/reopen is a lifecycle+// transition, so it stays neutral rather than reading as a verdict.//// `Pencil` is reserved for exactly one meaning — an issue *field* edit.import {+ Ban,CheckCircle2,+ CircleDot,FileMinus2,FilePen,FilePlus2,@@ -57,6 +61,8 @@ export const PLAN_CHANGE_ICON = {export const ISSUE_EVENT_ICON = {fieldEdit: { Icon: Pencil, tone: "neutral" },resolved: { Icon: CheckCircle2, tone: "success" },+ closed: { Icon: Ban, tone: "neutral" },+ reopened: { Icon: CircleDot, tone: "neutral" },} satisfies Record<string, ActivityIconSpec>;// Tone → classes. Activity badges fill the circle (white glyph on bg-tone);