Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(backend): update issue status to DONE when manually creating rollout (#19151)

boojack33c39d021bde
diff --git a/backend/api/v1/rollout_service.go b/backend/api/v1/rollout_service.go
index 9f1edb7769..18d071b2cf 100644
--- a/backend/api/v1/rollout_service.go
+++ b/backend/api/v1/rollout_service.go
@@ -250,6 +250,15 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
return nil, connect.NewError(connect.CodeInternal, errors.New("user not found"))
}
+ // Fetch issue associated with this plan (if any)
+ issue, err := s.store.GetIssue(ctx, &store.FindIssueMessage{
+ ProjectID: &projectID,
+ PlanUID: &planID,
+ })
+ if err != nil {
+ return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find issue"))
+ }
+
// Check permission: allow if user has bb.rollouts.create permission
hasPermission, err := s.iamManager.CheckPermission(ctx, permission.RolloutsCreate, user, project.ResourceID)
if err != nil {
@@ -257,14 +266,6 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
}
if !hasPermission {
- // Check if this is a data export issue and user is the creator
- issue, err := s.store.GetIssue(ctx, &store.FindIssueMessage{
- ProjectID: &projectID,
- PlanUID: &planID,
- })
- if err != nil {
- return nil, connect.NewError(connect.CodeInternal, errors.Wrapf(err, "failed to find issue"))
- }
// Allow data export issue creators to create rollout for their own issues
if issue == nil || issue.Type != storepb.Issue_DATABASE_EXPORT || issue.CreatorEmail != user.Email {
return nil, connect.NewError(connect.CodePermissionDenied, errors.New("permission denied to create rollout"))
@@ -282,7 +283,7 @@ func (s *RolloutService) CreateRollout(ctx context.Context, req *connect.Request
}
}
- if err := CreateRolloutAndPendingTasks(ctx, s.store, plan, nil, project, tasks); err != nil {
+ if err := CreateRolloutAndPendingTasks(ctx, s.store, plan, issue, project, tasks); err != nil {
return nil, connect.NewError(connect.CodeInternal, err)
}