Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: backfill default rollout policy for environments (#17686)
boojack342e5b18393b
diff --git a/backend/migrator/migration/3.11/0011##backfill_default_rollout_policy.sql b/backend/migrator/migration/3.11/0011##backfill_default_rollout_policy.sqlnew file mode 100644index 0000000000..4de6749070--- /dev/null+++ b/backend/migrator/migration/3.11/0011##backfill_default_rollout_policy.sql@@ -0,0 +1,32 @@+-- Backfill default rollout policies for environments that don't have one+-- This ensures all environments have a rollout policy with default checkers++WITH environment_ids AS (+ SELECT jsonb_array_elements(value::jsonb->'environments')->>'id' AS env_id+ FROM setting+ WHERE name = 'ENVIRONMENT'+)+INSERT INTO policy (resource_type, resource, type, payload, inherit_from_parent, enforce, updated_at)+SELECT+ 'ENVIRONMENT',+ 'environments/' || env_id,+ 'ROLLOUT',+ jsonb_build_object(+ 'checkers', jsonb_build_object(+ 'requiredIssueApproval', true,+ 'requiredStatusChecks', jsonb_build_object(+ 'planCheckEnforcement', 'ERROR_ONLY'+ )+ )+ ),+ true,+ true,+ now()+FROM environment_ids+WHERE NOT EXISTS (+ SELECT 1+ FROM policy p+ WHERE p.resource_type = 'ENVIRONMENT'+ AND p.resource = 'environments/' || env_id+ AND p.type = 'ROLLOUT'+);diff --git a/backend/migrator/migrator_test.go b/backend/migrator/migrator_test.goindex 4de47aac31..b8ded3d6da 100644--- a/backend/migrator/migrator_test.go+++ b/backend/migrator/migrator_test.go@@ -12,7 +12,7 @@ import (func TestLatestVersion(t *testing.T) {files, err := getSortedVersionedFiles()require.NoError(t, err)- require.Equal(t, semver.MustParse("3.11.10"), *files[len(files)-1].version)+ require.Equal(t, semver.MustParse("3.11.11"), *files[len(files)-1].version)}func TestVersionUnique(t *testing.T) {diff --git a/backend/store/policy.go b/backend/store/policy.goindex bf492f651d..921c8fed40 100644--- a/backend/store/policy.go+++ b/backend/store/policy.go@@ -141,7 +141,15 @@ func (s *Store) GetRolloutPolicy(ctx context.Context, environment string) (*storreturn nil, errors.Wrapf(err, "failed to get policy")}if policy == nil {- return &storepb.RolloutPolicy{}, nil+ // Return default rollout policy with checkers.+ return &storepb.RolloutPolicy{+ Checkers: &storepb.RolloutPolicy_Checkers{+ RequiredIssueApproval: true,+ RequiredStatusChecks: &storepb.RolloutPolicy_Checkers_RequiredStatusChecks{+ PlanCheckEnforcement: storepb.RolloutPolicy_Checkers_ERROR_ONLY,+ },+ },+ }, nil}p := &storepb.RolloutPolicy{}