Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
refactor(react): decouple rollout/plan/issueComment/issue stores from React (#20463)
boojack368e8e38ddbc
diff --git a/frontend/src/react/components/Quickstart.tsx b/frontend/src/react/components/Quickstart.tsxindex d4943e546d..59c8c3c482 100644--- a/frontend/src/react/components/Quickstart.tsx+++ b/frontend/src/react/components/Quickstart.tsx@@ -18,7 +18,6 @@ import { SQL_EDITOR_WORKSHEET_MODULE } from "@/router/sqlEditor";import {pushNotification,useActuatorV1Store,- useIssueV1Store,useProjectV1Store,useUIStateStore,} from "@/store";@@ -71,7 +70,6 @@ export function Quickstart() {const projectStore = useProjectV1Store();const uiStateStore = useUIStateStore();const actuatorStore = useActuatorV1Store();- const issueStore = useIssueV1Store();const loadProjectIamPolicy = useAppStore((state) => state.loadProjectIamPolicy);@@ -142,10 +140,12 @@ export function Quickstart() {}let cancelled = false;void (async () => {- const issue = await issueStore.fetchIssueByName(- `${sampleProject.name}/issues/${SAMPLE_ISSUE_ID}`,- true /* silent */- );+ const issue = await useAppStore+ .getState()+ .fetchIssueByName(+ `${sampleProject.name}/issues/${SAMPLE_ISSUE_ID}`,+ true /* silent */+ );if (!cancelled) setSampleIssueExists(!!issue);})();void (async () => {@@ -160,7 +160,7 @@ export function Quickstart() {return () => {cancelled = true;};- }, [sampleProject, issueStore]);+ }, [sampleProject]);// ---- intro list (memoized + permission-filtered) ----------------------diff --git a/frontend/src/react/components/database/CreateDatabaseSheet.test.tsx b/frontend/src/react/components/database/CreateDatabaseSheet.test.tsxindex 2f4704517f..570dd2a50c 100644--- a/frontend/src/react/components/database/CreateDatabaseSheet.test.tsx+++ b/frontend/src/react/components/database/CreateDatabaseSheet.test.tsx@@ -141,10 +141,13 @@ vi.mock("@/store", () => ({useProjectV1Store: () => stableProjectStore,useInstanceV1Store: () => stableInstanceStore,useEnvironmentV1Store: () => ({ environmentList: [] }),- experimentalCreateIssueByPlan: mocks.experimentalCreateIssueByPlan,pushNotification: vi.fn(),}));+vi.mock("@/react/stores/app/issue", () => ({+ experimentalCreateIssueByPlan: mocks.experimentalCreateIssueByPlan,+}));+vi.mock("@/react/hooks/useAppState", () => ({useCurrentUser: () => mocks.currentUser,}));diff --git a/frontend/src/react/components/database/CreateDatabaseSheet.tsx b/frontend/src/react/components/database/CreateDatabaseSheet.tsxindex 43f9486cf1..0535ed9271 100644--- a/frontend/src/react/components/database/CreateDatabaseSheet.tsx+++ b/frontend/src/react/components/database/CreateDatabaseSheet.tsx@@ -20,9 +20,9 @@ import {import { useCurrentUser } from "@/react/hooks/useAppState";import { useVueState } from "@/react/hooks/useVueState";import { cn } from "@/react/lib/utils";+import { experimentalCreateIssueByPlan } from "@/react/stores/app/issue";import { router } from "@/router";import {- experimentalCreateIssueByPlan,pushNotification,useEnvironmentV1Store,useInstanceV1Store,diff --git a/frontend/src/react/components/task-run-log/model.test.ts b/frontend/src/react/components/task-run-log/model.test.tsindex 4375cc731e..15b2ed54ea 100644--- a/frontend/src/react/components/task-run-log/model.test.ts+++ b/frontend/src/react/components/task-run-log/model.test.ts@@ -39,10 +39,6 @@ vi.mock("@/react/stores/app", () => ({useAppStore: () => vi.fn(),}));-vi.mock("@/store", () => ({- useRolloutStore: () => ({}),-}));-vi.mock("@/utils", () => ({extractRolloutNameFromTaskRunName: () => "",extractTaskNameFromTaskRunName: () => "",diff --git a/frontend/src/react/components/task-run-log/useTaskRunLogData.ts b/frontend/src/react/components/task-run-log/useTaskRunLogData.tsindex aee171cb39..bde6087d61 100644--- a/frontend/src/react/components/task-run-log/useTaskRunLogData.ts+++ b/frontend/src/react/components/task-run-log/useTaskRunLogData.ts@@ -4,9 +4,8 @@ import {rolloutServiceClientConnect,sheetServiceClientConnect,} from "@/connect";-import { useVueState } from "@/react/hooks/useVueState";import { useAppStore } from "@/react/stores/app";-import { useRolloutStore } from "@/store";+import { unknownRollout } from "@/types";import {GetTaskRunLogRequestSchema,type Task,@@ -156,7 +155,6 @@ export const buildReleaseSheetFetchResult = (export const useTaskRunLogData = (taskRunName?: string): UseTaskRunLogDataResult => {- const rolloutStore = useRolloutStore();const fetchRelease = useAppStore((state) => state.fetchRelease);const [entries, setEntries] = useState<TaskRunLogEntry[]>([]);@@ -189,7 +187,8 @@ export const useTaskRunLogData = (}setMetadataFetchState({ status: "loading" });- void rolloutStore+ void useAppStore+ .getState().fetchRolloutByName(rolloutName, true).then((fetchedRollout) => {if (version !== metadataFetchVersion.current) return;@@ -210,12 +209,18 @@ export const useTaskRunLogData = (error: getErrorMessage(error),});});- }, [rolloutName, rolloutStore, taskRunName]);+ }, [rolloutName, taskRunName]);- const rollout = useVueState(() => {- if (!rolloutName) return undefined;- return rolloutStore.getRolloutByName(rolloutName);- });+ // Subscribe to the cached entry directly (stable ref) and derive the unknown+ // fallback outside the selector — a selector returning `unknownRollout()`+ // would yield a fresh object each call and loop forever.+ const cachedRollout = useAppStore((state) =>+ rolloutName ? state.rolloutsByName[rolloutName] : undefined+ );+ const rollout = useMemo(+ () => (rolloutName ? (cachedRollout ?? unknownRollout()) : undefined),+ [rolloutName, cachedRollout]+ );const task = useMemo(() => getTaskFromRollout(taskRunName, rollout),diff --git a/frontend/src/react/lib/issue/issueListRefresh.ts b/frontend/src/react/lib/issue/issueListRefresh.tsnew file mode 100644index 0000000000..ad50561a73--- /dev/null+++ b/frontend/src/react/lib/issue/issueListRefresh.ts@@ -0,0 +1,21 @@+import { useEffect } from "react";++// Global "refresh the issue list" signal, relocated from the legacy Pinia+// `issue` module (which used a Vue ref + watch). Plain module-level listener+// set so callers don't pull Vue reactivity into React feature code.+const listeners = new Set<() => void>();++export const refreshIssueList = (): void => {+ for (const listener of listeners) {+ listener();+ }+};++export const useRefreshIssueList = (callback: () => void): void => {+ useEffect(() => {+ listeners.add(callback);+ return () => {+ listeners.delete(callback);+ };+ }, [callback]);+};diff --git a/frontend/src/react/pages/project/ProjectDataExportPage.tsx b/frontend/src/react/pages/project/ProjectDataExportPage.tsxindex 49ea89fdcc..136571af22 100644--- a/frontend/src/react/pages/project/ProjectDataExportPage.tsx+++ b/frontend/src/react/pages/project/ProjectDataExportPage.tsx@@ -20,7 +20,6 @@ import { WORKSPACE_ROUTE_USER_PROFILE } from "@/router/dashboard/workspaceRoutesimport {useDatabaseV1Store,useInstanceV1Store,- useIssueV1Store,useProjectV1Store,} from "@/store";import { projectNamePrefix } from "@/store/modules/v1/common";@@ -47,7 +46,6 @@ import { DataExportPrepSheet } from "./export-center/DataExportPrepSheet";export function ProjectDataExportPage({ projectId }: { projectId: string }) {const { t } = useTranslation();- const issueStore = useIssueV1Store();const projectStore = useProjectV1Store();const batchGetOrFetchUsers = useAppStore((state) => state.batchGetOrFetchUsers@@ -193,14 +191,16 @@ export function ProjectDataExportPage({ projectId }: { projectId: string }) {const fetchIssueList = useCallback(async (params: { pageSize: number; pageToken: string }) => {- const { nextPageToken, issues } = await issueStore.listIssues({- find: issueFilter,- pageSize: params.pageSize,- pageToken: params.pageToken,- });+ const { nextPageToken, issues } = await useAppStore+ .getState()+ .listIssues({+ find: issueFilter,+ pageSize: params.pageSize,+ pageToken: params.pageToken,+ });return { list: issues, nextPageToken };},- [issueStore, issueFilter]+ [issueFilter]);const paged = usePagedData<Issue>({diff --git a/frontend/src/react/pages/project/ProjectIssueDashboardPage.tsx b/frontend/src/react/pages/project/ProjectIssueDashboardPage.tsxindex 5f7f1469d9..1f8d0e6eac 100644--- a/frontend/src/react/pages/project/ProjectIssueDashboardPage.tsx+++ b/frontend/src/react/pages/project/ProjectIssueDashboardPage.tsx@@ -14,9 +14,10 @@ import { Alert } from "@/react/components/ui/alert";import { useCurrentUser } from "@/react/hooks/useAppState";import { PagedTableFooter, usePagedData } from "@/react/hooks/usePagedData";import { useVueState } from "@/react/hooks/useVueState";+import { refreshIssueList } from "@/react/lib/issue/issueListRefresh";import { useAppStore } from "@/react/stores/app";import { router } from "@/router";-import { refreshIssueList, useIssueV1Store, useUIStateStore } from "@/store";+import { useUIStateStore } from "@/store";import { projectNamePrefix } from "@/store/modules/v1/common";import { ApprovalStatus } from "@/types/proto-es/v1/common_pb";import type { Issue } from "@/types/proto-es/v1/issue_service_pb";@@ -36,7 +37,6 @@ export function ProjectIssueDashboardPage({projectId: string;}) {const { t } = useTranslation();- const issueStore = useIssueV1Store();const uiStateStore = useUIStateStore();const batchGetOrFetchUsers = useAppStore((state) => state.batchGetOrFetchUsers@@ -159,14 +159,16 @@ export function ProjectIssueDashboardPage({const fetchIssueList = useCallback(async (params: { pageSize: number; pageToken: string }) => {- const { nextPageToken, issues } = await issueStore.listIssues({- find: issueFilter,- pageSize: params.pageSize,- pageToken: params.pageToken,- });+ const { nextPageToken, issues } = await useAppStore+ .getState()+ .listIssues({+ find: issueFilter,+ pageSize: params.pageSize,+ pageToken: params.pageToken,+ });return { list: issues, nextPageToken };},- [issueStore, issueFilter]+ [issueFilter]);const paged = usePagedData<Issue>({diff --git a/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx b/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsxindex 147479e59c..3ed0b2f47f 100644--- a/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx+++ b/frontend/src/react/pages/project/ProjectPlanDashboardPage.tsx@@ -53,6 +53,7 @@ import { useVueState } from "@/react/hooks/useVueState";import { applyPlanTitleToQuery } from "@/react/lib/plan/title";import { cn } from "@/react/lib/utils";import { useAppStore } from "@/react/stores/app";+import { buildPlanFindBySearchParams } from "@/react/stores/app/plan";import { router } from "@/router";import {PROJECT_V1_ROUTE_PLAN_DETAIL,@@ -66,10 +67,6 @@ import {useUIStateStore,} from "@/store";import { projectNamePrefix } from "@/store/modules/v1/common";-import {- buildPlanFindBySearchParams,- usePlanStore,-} from "@/store/modules/v1/plan";import {formatEnvironmentName,getTimeForPbTimestampProtoEs,@@ -121,7 +118,6 @@ const TASK_STATUS_FILTERS: Task_Status[] = [export function ProjectPlanDashboardPage({ projectId }: { projectId: string }) {const { t } = useTranslation();- const planStore = usePlanStore();const projectStore = useProjectV1Store();const listUsers = useAppStore((state) => state.listUsers);const batchGetOrFetchUsers = useAppStore(@@ -230,14 +226,14 @@ export function ProjectPlanDashboardPage({ projectId }: { projectId: string }) {const fetchPlanList = useCallback(async (params: { pageSize: number; pageToken: string }) => {- const { nextPageToken, plans } = await planStore.listPlans({+ const { nextPageToken, plans } = await useAppStore.getState().listPlans({find: planFilter,pageSize: params.pageSize,pageToken: params.pageToken,});return { list: plans, nextPageToken };},- [planStore, planFilter]+ [planFilter]);const paged = usePagedData<Plan>({diff --git a/frontend/src/react/pages/project/export-center/DataExportPrepSheet.test.tsx b/frontend/src/react/pages/project/export-center/DataExportPrepSheet.test.tsxindex cdbfcea50a..c9de670d12 100644--- a/frontend/src/react/pages/project/export-center/DataExportPrepSheet.test.tsx+++ b/frontend/src/react/pages/project/export-center/DataExportPrepSheet.test.tsx@@ -228,7 +228,6 @@ vi.mock("@/store", () => ({useDatabaseV1Store: () => stableDatabaseStore,useSheetV1Store: () => stableSheetStore,useSettingV1Store: () => stableSettingStore,- experimentalCreateIssueByPlan: mocks.experimentalCreateIssueByPlan,pushNotification: mocks.pushNotification,}));@@ -236,6 +235,10 @@ vi.mock("@/react/stores/app", () => ({useAppStore: { getState: () => stableDBGroupStore },}));+vi.mock("@/react/stores/app/issue", () => ({+ experimentalCreateIssueByPlan: mocks.experimentalCreateIssueByPlan,+}));+vi.mock("@/react/hooks/useAppState", () => ({useCurrentUser: () => mocks.currentUser,}));diff --git a/frontend/src/react/pages/project/export-center/DataExportPrepSheet.tsx b/frontend/src/react/pages/project/export-center/DataExportPrepSheet.tsxindex b8eb9fcfb0..3ef1daa173 100644--- a/frontend/src/react/pages/project/export-center/DataExportPrepSheet.tsx+++ b/frontend/src/react/pages/project/export-center/DataExportPrepSheet.tsx@@ -24,11 +24,11 @@ import { useSessionPageSize } from "@/react/hooks/useSessionPageSize";import { useVueState } from "@/react/hooks/useVueState";import { cn } from "@/react/lib/utils";import { useAppStore } from "@/react/stores/app";+import { experimentalCreateIssueByPlan } from "@/react/stores/app/issue";import { router } from "@/router";import { PROJECT_V1_ROUTE_ISSUE_DETAIL } from "@/router/dashboard/projectV1";import {DEFAULT_MAX_RESULT_SIZE_IN_MB,- experimentalCreateIssueByPlan,pushNotification,useDatabaseV1Store,useProjectV1Store,diff --git a/frontend/src/react/pages/project/issue-detail/components/IssueDetailActionBar.tsx b/frontend/src/react/pages/project/issue-detail/components/IssueDetailActionBar.tsxindex 46e47fe163..67533c50b8 100644--- a/frontend/src/react/pages/project/issue-detail/components/IssueDetailActionBar.tsx+++ b/frontend/src/react/pages/project/issue-detail/components/IssueDetailActionBar.tsx@@ -44,6 +44,7 @@ import { useCurrentUser } from "@/react/hooks/useAppState";import { useClickOutside } from "@/react/hooks/useClickOutside";import { useVueState } from "@/react/hooks/useVueState";import { cn } from "@/react/lib/utils";+import { useAppStore } from "@/react/stores/app";import { router } from "@/router";import {PROJECT_V1_ROUTE_ISSUE_DETAIL,@@ -53,12 +54,7 @@ import {buildPlanDeployRouteFromPlanName,buildPlanDeployRouteFromRolloutName,} from "@/router/dashboard/projectV1RouteHelpers";-import {- pushNotification,- useIssueCommentStore,- useProjectV1Store,- useSQLStore,-} from "@/store";+import { pushNotification, useProjectV1Store, useSQLStore } from "@/store";import { projectNamePrefix } from "@/store/modules/v1/common";import {ApproveIssueRequestSchema,@@ -100,7 +96,6 @@ export function IssueDetailActionBar() {const { t } = useTranslation();const page = useIssueDetailContext();const projectStore = useProjectV1Store();- const issueCommentStore = useIssueCommentStore();const sqlStore = useSQLStore();const currentUser = useCurrentUser();const [pendingConfirmAction, setPendingConfirmAction] =@@ -241,13 +236,13 @@ export function IssueDetailActionBar() {if (!page.issue?.name) {return;}- await issueCommentStore.listIssueComments(+ await useAppStore.getState().listIssueComments(create(ListIssueCommentsRequestSchema, {parent: page.issue.name,pageSize: 1000,}));- }, [issueCommentStore, page.issue?.name]);+ }, [page.issue?.name]);const handleRefreshIssueDetailState = useCallback(async () => {await refreshIssueDetailState(page);@@ -744,7 +739,6 @@ function IssueDetailReviewPopover({}) {const { t } = useTranslation();const page = useIssueDetailContext();- const issueCommentStore = useIssueCommentStore();const popoverRef = useRef<HTMLDivElement>(null);const [loading, setLoading] = useState(false);const [comment, setComment] = useState("");@@ -788,7 +782,7 @@ function IssueDetailReviewPopover({);page.patchState({ issue: response });} else {- await issueCommentStore.createIssueComment({+ await useAppStore.getState().createIssueComment({issueName: issue.name,comment,});@@ -831,7 +825,6 @@ function IssueDetailReviewPopover({}, [comment,issue,- issueCommentStore,onOpenChange,onRefreshIssueComments,onRefreshState,diff --git a/frontend/src/react/pages/project/issue-detail/components/IssueDetailCommentList.tsx b/frontend/src/react/pages/project/issue-detail/components/IssueDetailCommentList.tsxindex c10bfdd8e7..50858efd05 100644--- a/frontend/src/react/pages/project/issue-detail/components/IssueDetailCommentList.tsx+++ b/frontend/src/react/pages/project/issue-detail/components/IssueDetailCommentList.tsx@@ -32,14 +32,15 @@ import { useCurrentUser } from "@/react/hooks/useAppState";import { useVueState } from "@/react/hooks/useVueState";import { cn } from "@/react/lib/utils";import { useAppStore } from "@/react/stores/app";+import {+ getIssueCommentType,+ IssueCommentType,+} from "@/react/stores/app/issueComment";import { router } from "@/router";import { buildPlanDeployRouteFromPlanName } from "@/router/dashboard/projectV1RouteHelpers";import {extractUserEmail,- getIssueCommentType,- IssueCommentType,pushNotification,- useIssueCommentStore,useProjectV1Store,useSheetV1Store,} from "@/store";@@ -76,6 +77,9 @@ import {type SpecDiffEntry,} from "../utils/diffPlanSpecs";+// Stable empty reference for the no-issue branch of the comments selector.+const EMPTY_ISSUE_COMMENTS: IssueComment[] = [];+function useIssueRefTransform(projectName: string | undefined) {const { t } = useTranslation();return useCallback(@@ -107,14 +111,15 @@ export function IssueDetailCommentList() {const batchGetOrFetchUsers = useAppStore((state) => state.batchGetOrFetchUsers);- const issueCommentStore = useIssueCommentStore();const currentUser = useCurrentUser();const routeHash = useVueState(() => router.currentRoute.value.hash);const projectName = `${projectNamePrefix}${page.projectId}`;const project = useVueState(() => projectStore.getProjectByName(projectName));const issueName = page.issue?.name || page.plan?.issue || "";- const issueComments = useVueState(() =>- issueName ? issueCommentStore.getIssueComments(issueName) : []+ // `getIssueComments` returns a stable empty array on miss, so reading it+ // inside the selector won't loop.+ const issueComments = useAppStore((state) =>+ issueName ? state.getIssueComments(issueName) : EMPTY_ISSUE_COMMENTS);const issueUpdateKey = `${page.issue?.updateTime?.seconds ?? ""}:${page.issue?.updateTime?.nanos ?? ""}`;const [activeCommentName, setActiveCommentName] = useState<string>();@@ -148,7 +153,7 @@ export function IssueDetailCommentList() {const run = async () => {try {setIsRefreshing(true);- await issueCommentStore.listIssueComments(+ await useAppStore.getState().listIssueComments(create(ListIssueCommentsRequestSchema, {parent: issueName,pageSize: 1000,@@ -164,7 +169,7 @@ export function IssueDetailCommentList() {return () => {canceled = true;};- }, [issueCommentStore, issueName, issueUpdateKey]);+ }, [issueName, issueUpdateKey]);useEffect(() => {if (!routeHash.match(/^#activity(\d+)/)) {@@ -196,7 +201,7 @@ export function IssueDetailCommentList() {if (!issueName) {return;}- await issueCommentStore.listIssueComments(+ await useAppStore.getState().listIssueComments(create(ListIssueCommentsRequestSchema, {parent: issueName,pageSize: 1000,@@ -235,7 +240,7 @@ export function IssueDetailCommentList() {if (!activeComment || !allowUpdateComment) {return;}- await issueCommentStore.updateIssueComment({+ await useAppStore.getState().updateIssueComment({issueCommentName: activeComment.name,comment: editContent,});@@ -247,7 +252,7 @@ export function IssueDetailCommentList() {if (!issueName || !newComment) {return;}- await issueCommentStore.createIssueComment({+ await useAppStore.getState().createIssueComment({issueName,comment: newComment,});diff --git a/frontend/src/react/pages/project/issue-detail/utils/actionRegistry.ts b/frontend/src/react/pages/project/issue-detail/utils/actionRegistry.tsindex 2a9b3d7566..68e87b7b23 100644--- a/frontend/src/react/pages/project/issue-detail/utils/actionRegistry.ts+++ b/frontend/src/react/pages/project/issue-detail/utils/actionRegistry.ts@@ -1,6 +1,6 @@import type { TFunction } from "i18next";import { first, orderBy } from "lodash-es";-import { candidatesOfApprovalStepV1, extractUserEmail } from "@/store";+import { extractUserEmail } from "@/store";import { ApprovalStatus, State } from "@/types/proto-es/v1/common_pb";import type { Issue } from "@/types/proto-es/v1/issue_service_pb";import {@@ -28,6 +28,7 @@ import {isValidPlanName,} from "@/utils";import { isApprovalCompleted } from "./approval";+import { candidatesOfApprovalStepV1 } from "./approvalCandidates";export type IssueReviewAction = "ISSUE_REVIEW";export type IssueStatusAction = "ISSUE_STATUS_CLOSE" | "ISSUE_STATUS_REOPEN";diff --git a/frontend/src/react/pages/project/issue-detail/utils/activity.ts b/frontend/src/react/pages/project/issue-detail/utils/activity.tsindex 7640bf6ce4..4cc784d41c 100644--- a/frontend/src/react/pages/project/issue-detail/utils/activity.ts+++ b/frontend/src/react/pages/project/issue-detail/utils/activity.ts@@ -1,4 +1,7 @@-import { getIssueCommentType, IssueCommentType } from "@/store";+import {+ getIssueCommentType,+ IssueCommentType,+} from "@/react/stores/app/issueComment";import type { Issue, IssueComment } from "@/types/proto-es/v1/issue_service_pb";import { Issue_Type, IssueStatus } from "@/types/proto-es/v1/issue_service_pb";import type { Plan } from "@/types/proto-es/v1/plan_service_pb";diff --git a/frontend/src/react/pages/project/issue-detail/utils/approvalCandidates.ts b/frontend/src/react/pages/project/issue-detail/utils/approvalCandidates.tsnew file mode 100644index 0000000000..d1726f3411--- /dev/null+++ b/frontend/src/react/pages/project/issue-detail/utils/approvalCandidates.ts@@ -0,0 +1,37 @@+import { uniq } from "lodash-es";+import { useProjectIamPolicyStore, useProjectV1Store } from "@/store";+import { projectNamePrefix, userNamePrefix } from "@/store/modules/v1/common";+import type { Issue } from "@/types/proto-es/v1/issue_service_pb";+import {+ extractProjectResourceName,+ memberMapToRolesInProjectIAM,+} from "@/utils";++// candidatesOfApprovalStepV1 returns a user name list in users/{email} format.+// The list could include users/ALL_USERS_USER_EMAIL.+// Relocated from the legacy Pinia `issue` module; still reads the project and+// project-IAM Pinia stores, which remain until those stores are migrated.+export const candidatesOfApprovalStepV1 = (issue: Issue, role: string) => {+ const project = useProjectV1Store().getProjectByName(+ `${projectNamePrefix}${extractProjectResourceName(issue.name)}`+ );+ const candidatesForRoles = (role: string) => {+ const projectIamPolicyStore = useProjectIamPolicyStore();+ const iamPolicy = projectIamPolicyStore.getProjectIamPolicy(project.name);+ const memberMap = memberMapToRolesInProjectIAM(iamPolicy, role);+ return [...memberMap.keys()].filter((name) =>+ name.startsWith(userNamePrefix)+ );+ };+ const candidates = role ? candidatesForRoles(role) : [];++ return uniq(+ candidates.filter((user) => {+ // If the project does not allow self-approval, exclude the creator.+ if (!project.allowSelfApproval && user === issue.creator) {+ return false;+ }+ return true;+ })+ );+};diff --git a/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.test.tsx b/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.test.tsxindex 2dfd595181..e0eb208a5e 100644--- a/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.test.tsx+++ b/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.test.tsx@@ -85,18 +85,26 @@ vi.mock("@/react/hooks/useAppState", () => ({}));vi.mock("@/react/stores/app", () => ({- useAppStore: (selector: (state: unknown) => unknown) =>- selector({- batchGetOrFetchGroups: mocks.batchGetOrFetchGroups,- batchGetOrFetchUsers: mocks.batchGetOrFetchUsers,- getOrFetchUserByIdentifier: mocks.getOrFetchUserByIdentifier,- roleList: mocks.roleList,- loadProjectIamPolicy:- mocks.projectIamPolicyStore.getOrFetchProjectIamPolicy,- // The approval flow now subscribes to projectPoliciesByName directly- // so the candidate list re-renders when the policy resolves.- projectPoliciesByName: { "projects/p1": { bindings: [] } },- }),+ useAppStore: Object.assign(+ (selector: (state: unknown) => unknown) =>+ selector({+ batchGetOrFetchGroups: mocks.batchGetOrFetchGroups,+ batchGetOrFetchUsers: mocks.batchGetOrFetchUsers,+ getOrFetchUserByIdentifier: mocks.getOrFetchUserByIdentifier,+ roleList: mocks.roleList,+ loadProjectIamPolicy:+ mocks.projectIamPolicyStore.getOrFetchProjectIamPolicy,+ // The approval flow now subscribes to projectPoliciesByName directly+ // so the candidate list re-renders when the policy resolves.+ projectPoliciesByName: { "projects/p1": { bindings: [] } },+ getIssueComments: mocks.issueCommentStore.getIssueComments,+ }),+ {+ getState: () => ({+ listIssueComments: mocks.issueCommentStore.listIssueComments,+ }),+ }+ ),}));vi.mock("@/store/modules/v1/common", () => ({@@ -105,13 +113,12 @@ vi.mock("@/store/modules/v1/common", () => ({userNamePrefix: "users/",}));-vi.mock("@/store/modules/v1/issueComment", () => ({+vi.mock("@/react/stores/app/issueComment", () => ({IssueCommentType: {APPROVAL: "APPROVAL",},getIssueCommentType: (comment: { event?: { case?: string } }) =>comment.event?.case === "approval" ? "APPROVAL" : "USER_COMMENT",- useIssueCommentStore: () => mocks.issueCommentStore,}));vi.mock("@/utils", () => ({diff --git a/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.tsx b/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.tsxindex 05679356c6..90a2e3d5f4 100644--- a/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.tsx+++ b/frontend/src/react/pages/project/plan-detail/components/PlanDetailApprovalFlow.tsx@@ -20,15 +20,14 @@ import { displayRoleTitleFromList } from "@/react/lib/role";import { cn } from "@/react/lib/utils";import { useAppStore } from "@/react/stores/app";import { ensureGroupIdentifier } from "@/react/stores/app/group";+import {+ getIssueCommentType,+ IssueCommentType,+} from "@/react/stores/app/issueComment";import { router } from "@/router";import { PROJECT_V1_ROUTE_ISSUE_DETAIL } from "@/router/dashboard/projectV1";import { pushNotification, useProjectV1Store } from "@/store";import { projectNamePrefix, userNamePrefix } from "@/store/modules/v1/common";-import {- getIssueCommentType,- IssueCommentType,- useIssueCommentStore,-} from "@/store/modules/v1/issueComment";import {ApprovalStatus,RiskLevel,@@ -85,7 +84,6 @@ function PlanDetailApprovalFlowContent({const loadProjectIamPolicy = useAppStore((state) => state.loadProjectIamPolicy);- const issueCommentStore = useIssueCommentStore();const projectName = `${projectNamePrefix}${page.projectId}`;const issue = page.issue;@@ -103,7 +101,8 @@ function PlanDetailApprovalFlowContent({if (!issue?.name) {return;}- void issueCommentStore+ void useAppStore+ .getState().listIssueComments(create(ListIssueCommentsRequestSchema, {parent: issue.name,@@ -111,15 +110,13 @@ function PlanDetailApprovalFlowContent({})).catch(() => undefined);- }, [issue?.name, issueCommentStore, mode]);-- const comments = useVueState(() => {- if (!issue) return EMPTY_COMMENTS;- const list = issueCommentStore.getIssueComments(issue.name);- // The store returns a fresh `[]` on cache miss; normalise to a stable- // reference so useSyncExternalStore can short-circuit re-renders.- return list.length > 0 ? list : EMPTY_COMMENTS;- });+ }, [issue?.name, mode]);++ // `getIssueComments` returns a stable empty array on miss, so reading it+ // inside the selector won't loop.+ const comments = useAppStore((state) =>+ issue ? state.getIssueComments(issue.name) : EMPTY_COMMENTS+ );const lastRejection = useMemo(() => {if (!issue || issue.approvalStatus !== ApprovalStatus.REJECTED) {return undefined;diff --git a/frontend/src/react/pages/workspace/MyIssuesPage.tsx b/frontend/src/react/pages/workspace/MyIssuesPage.tsxindex c8ae64b851..e42070dc55 100644--- a/frontend/src/react/pages/workspace/MyIssuesPage.tsx+++ b/frontend/src/react/pages/workspace/MyIssuesPage.tsx@@ -12,9 +12,9 @@ import {} from "@/react/components/IssueTable";import { useCurrentUser } from "@/react/hooks/useAppState";import { PagedTableFooter, usePagedData } from "@/react/hooks/usePagedData";+import { refreshIssueList } from "@/react/lib/issue/issueListRefresh";import { useAppStore } from "@/react/stores/app";import { router } from "@/router";-import { refreshIssueList, useIssueV1Store } from "@/store";import { ApprovalStatus } from "@/types/proto-es/v1/common_pb";import type { Issue } from "@/types/proto-es/v1/issue_service_pb";import { IssueStatus } from "@/types/proto-es/v1/issue_service_pb";@@ -27,7 +27,6 @@ import {export function MyIssuesPage() {const { t } = useTranslation();- const issueStore = useIssueV1Store();const batchGetOrFetchUsers = useAppStore((state) => state.batchGetOrFetchUsers);@@ -111,14 +110,16 @@ export function MyIssuesPage() {const fetchIssueList = useCallback(async (params: { pageSize: number; pageToken: string }) => {- const { nextPageToken, issues } = await issueStore.listIssues({- find: issueFilter,- pageSize: params.pageSize,- pageToken: params.pageToken,- });+ const { nextPageToken, issues } = await useAppStore+ .getState()+ .listIssues({+ find: issueFilter,+ pageSize: params.pageSize,+ pageToken: params.pageToken,+ });return { list: issues, nextPageToken };},- [issueStore, issueFilter]+ [issueFilter]);const paged = usePagedData<Issue>({diff --git a/frontend/src/react/plugins/agent/logic/context.ts b/frontend/src/react/plugins/agent/logic/context.tsindex d129bf7279..bc3a44dcd5 100644--- a/frontend/src/react/plugins/agent/logic/context.ts+++ b/frontend/src/react/plugins/agent/logic/context.ts@@ -78,12 +78,9 @@ export async function extractRouteContext(// Issue contextif (projectId && issueId) {try {- const { useIssueV1Store } = await import("@/store");- const store = useIssueV1Store();- const issue = await store.fetchIssueByName(- `projects/${projectId}/issues/${issueId}`,- true- );+ const issue = await useAppStore+ .getState()+ .fetchIssueByName(`projects/${projectId}/issues/${issueId}`, true);if (issue?.name) {ctx.issue = {name: issue.name,diff --git a/frontend/src/react/stores/app/index.ts b/frontend/src/react/stores/app/index.tsindex b3a7054d26..b472d69548 100644--- a/frontend/src/react/stores/app/index.ts+++ b/frontend/src/react/stores/app/index.ts@@ -8,6 +8,7 @@ import { createDBSchemaSlice } from "./dbSchema";import { createGroupSlice } from "./group";import { createIamSlice } from "./iam";import { createIdentityProviderSlice } from "./identityProvider";+import { createIssueCommentSlice } from "./issueComment";import { createInstanceSlice } from "./instance";import { createInstanceRoleSlice } from "./instanceRole";import { createIssueSlice } from "./issue";@@ -18,7 +19,9 @@ import { createProjectSlice } from "./project";import { createProjectWebhookSlice } from "./projectWebhook";import { createReleaseSlice } from "./release";import { createRevisionSlice } from "./revision";+import { createPlanSlice } from "./plan";import { createRoleSlice } from "./role";+import { createRolloutSlice } from "./rollout";import { createServiceAccountSlice } from "./serviceAccount";import { createSheetSlice } from "./sheet";import { createSQLSlice } from "./sql";@@ -56,6 +59,9 @@ export const createAppStore = () =>...createAccessGrantSlice(...args),...createUserSlice(...args),...createRoleSlice(...args),+ ...createRolloutSlice(...args),+ ...createPlanSlice(...args),+ ...createIssueCommentSlice(...args),...createReleaseSlice(...args),...createRevisionSlice(...args),...createChangelogSlice(...args),diff --git a/frontend/src/react/stores/app/issue.ts b/frontend/src/react/stores/app/issue.tsindex 27ab1f3c96..19d505e8a5 100644--- a/frontend/src/react/stores/app/issue.ts+++ b/frontend/src/react/stores/app/issue.ts@@ -1,8 +1,29 @@import { create as createProto } from "@bufbuild/protobuf";import { createContextValues } from "@connectrpc/connect";-import { issueServiceClientConnect } from "@/connect";+import dayjs from "dayjs";+import { uniq } from "lodash-es";+import {+ issueServiceClientConnect,+ planServiceClientConnect,+ rolloutServiceClientConnect,+} from "@/connect";import { silentContextKey } from "@/connect/context-key";-import { GetIssueRequestSchema } from "@/types/proto-es/v1/issue_service_pb";+import type { IssueFilter } from "@/types";+import { ApprovalStatus, RiskLevel } from "@/types/proto-es/v1/common_pb";+import {+ CreateIssueRequestSchema,+ GetIssueRequestSchema,+ type Issue,+ Issue_Type,+ IssueStatus,+ SearchIssuesRequestSchema,+} from "@/types/proto-es/v1/issue_service_pb";+import {+ CreatePlanRequestSchema,+ type Plan,+} from "@/types/proto-es/v1/plan_service_pb";+import type { Project } from "@/types/proto-es/v1/project_service_pb";+import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";import type { AppSliceCreator, IssueSlice } from "./types";// Resource names are `projects/{project}/issues/{issue}` — yank the project@@ -13,12 +34,98 @@ function projectResourceFromIssueName(issueName: string): string {return match?.[1] ?? "";}+export const buildIssueFilter = (find: IssueFilter): string => {+ const filter: string[] = [];+ if (find.creator) {+ filter.push(`creator == "${find.creator}"`);+ }+ if (find.currentApprover) {+ filter.push(`current_approver == "${find.currentApprover}"`);+ }+ if (find.approvalStatus) {+ filter.push(`approval_status == "${ApprovalStatus[find.approvalStatus]}"`);+ }+ if (find.statusList && find.statusList.length > 0) {+ filter.push(+ `status in [${find.statusList.map((s) => `"${IssueStatus[s]}"`).join(",")}]`+ );+ }+ if (find.riskLevelList && find.riskLevelList.length > 0) {+ filter.push(+ `risk_level in [${find.riskLevelList.map((r) => `"${RiskLevel[r]}"`).join(",")}]`+ );+ }+ if (find.createdTsAfter) {+ filter.push(+ `create_time >= "${dayjs(find.createdTsAfter).utc().format()}"`+ );+ }+ if (find.createdTsBefore) {+ filter.push(+ `create_time <= "${dayjs(find.createdTsBefore).utc().format()}"`+ );+ }+ if (find.typeList && find.typeList.length > 0) {+ filter.push(+ `type in [${find.typeList.map((t) => `"${Issue_Type[t]}"`).join(",")}]`+ );+ }+ if (find.labels && find.labels.length > 0) {+ filter.push(`labels in [${find.labels.map((l) => `"${l}"`).join(",")}]`);+ }+ return filter.join(" && ");+};++export interface CreateIssueByPlanOptions {+ skipRollout?: boolean;+}++/**+ * Creates a plan, then an issue referencing it, and (unless skipped) a rollout.+ * Relocated from the legacy Pinia `experimental-issue` module — a stateless+ * orchestration helper over the plan/issue/rollout services.+ */+export const experimentalCreateIssueByPlan = async (+ project: Project,+ issueCreate: Issue,+ planCreate: Plan,+ options?: CreateIssueByPlanOptions+) => {+ const createdPlan = await planServiceClientConnect.createPlan(+ createProto(CreatePlanRequestSchema, {+ parent: project.name,+ plan: planCreate,+ })+ );+ issueCreate.plan = createdPlan.name;++ const createdIssue = await issueServiceClientConnect.createIssue(+ createProto(CreateIssueRequestSchema, {+ parent: project.name,+ issue: issueCreate,+ })+ );++ // Skip rollout creation for plans that create rollout on-demand+ // (e.g., database creation).+ if (options?.skipRollout) {+ return { createdPlan, createdIssue, createdRollout: undefined };+ }++ const createdRollout = await rolloutServiceClientConnect.createRollout(+ createProto(CreateRolloutRequestSchema, {+ parent: createdPlan.name,+ })+ );++ return { createdPlan, createdIssue, createdRollout };+};+/**- * Port of the legacy Pinia `useIssueV1Store.fetchIssueByName`. Stateless- * fetch (no per-issue cache — callers consume the result once) that also- * primes the owning project in the app store, matching the Pinia behavior- * so downstream code that reads the project synchronously after the call- * sees it cached.+ * Port of the legacy Pinia `useIssueV1Store`. Stateless fetches (no per-issue+ * cache — callers consume the result once) that also prime the owning+ * project(s) in the app store, matching the Pinia behavior so downstream code+ * that reads a project synchronously after the call sees it cached.*/export const createIssueSlice: AppSliceCreator<IssueSlice> = (_set, get) => ({fetchIssueByName: async (name, silent = false) => {@@ -34,4 +141,27 @@ export const createIssueSlice: AppSliceCreator<IssueSlice> = (_set, get) => ({}return issue;},++ listIssues: async ({ find, pageSize, pageToken }) => {+ const resp = await issueServiceClientConnect.searchIssues(+ createProto(SearchIssuesRequestSchema, {+ parent: find.project,+ filter: buildIssueFilter(find),+ query: find.query,+ pageSize,+ pageToken,+ orderBy: find.orderBy,+ })+ );+ const issues = resp.issues;+ await get().batchFetchProjects(+ uniq(+ issues.map((issue) => projectResourceFromIssueName(issue.name))+ ).filter(Boolean)+ );+ await get().batchGetOrFetchUsers(+ uniq(issues.map((issue) => issue.creator))+ );+ return { nextPageToken: resp.nextPageToken, issues };+ },});diff --git a/frontend/src/react/stores/app/issueComment.ts b/frontend/src/react/stores/app/issueComment.tsnew file mode 100644index 0000000000..782795d4ae--- /dev/null+++ b/frontend/src/react/stores/app/issueComment.ts@@ -0,0 +1,114 @@+import { create as createProto } from "@bufbuild/protobuf";+import { issueServiceClientConnect } from "@/connect";+import {+ getProjectIdIssueIdIssueCommentId,+ issueNamePrefix,+ projectNamePrefix,+} from "@/store/modules/v1/common";+import {+ CreateIssueCommentRequestSchema,+ type IssueComment,+ IssueCommentSchema,+ ListIssueCommentsRequestSchema,+ UpdateIssueCommentRequestSchema,+} from "@/types/proto-es/v1/issue_service_pb";+import type { AppSliceCreator, IssueCommentSlice } from "./types";++export enum IssueCommentType {+ USER_COMMENT = "USER_COMMENT",+ APPROVAL = "APPROVAL",+ ISSUE_UPDATE = "ISSUE_UPDATE",+ PLAN_UPDATE = "PLAN_UPDATE",+}++export const getIssueCommentType = (+ issueComment: IssueComment+): IssueCommentType => {+ if (issueComment.event?.case === "approval") {+ return IssueCommentType.APPROVAL;+ } else if (issueComment.event?.case === "issueUpdate") {+ return IssueCommentType.ISSUE_UPDATE;+ } else if (issueComment.event?.case === "planUpdate") {+ return IssueCommentType.PLAN_UPDATE;+ }+ return IssueCommentType.USER_COMMENT;+};++// Stable empty reference so `getIssueComments` can be read inside a reactive+// selector without producing a fresh array (which would loop forever).+const EMPTY_COMMENTS: IssueComment[] = [];++export const createIssueCommentSlice: AppSliceCreator<IssueCommentSlice> = (+ set,+ get+) => ({+ issueCommentsByIssue: {},++ listIssueComments: async (request) => {+ const resp = await issueServiceClientConnect.listIssueComments(+ createProto(ListIssueCommentsRequestSchema, {+ parent: request.parent,+ pageSize: request.pageSize,+ pageToken: request.pageToken,+ })+ );+ set((state) => ({+ issueCommentsByIssue: {+ ...state.issueCommentsByIssue,+ [request.parent]: resp.issueComments,+ },+ }));+ return {+ nextPageToken: resp.nextPageToken,+ issueComments: resp.issueComments,+ };+ },++ createIssueComment: async ({ issueName, comment }) => {+ const newIssueComment = await issueServiceClientConnect.createIssueComment(+ createProto(CreateIssueCommentRequestSchema, {+ parent: issueName,+ issueComment: createProto(IssueCommentSchema, { comment }),+ })+ );+ set((state) => ({+ issueCommentsByIssue: {+ ...state.issueCommentsByIssue,+ [issueName]: [+ ...(state.issueCommentsByIssue[issueName] ?? []),+ newIssueComment,+ ],+ },+ }));+ },++ updateIssueComment: async ({ issueCommentName, comment }) => {+ const { projectId, issueId } =+ getProjectIdIssueIdIssueCommentId(issueCommentName);+ const parent = `${projectNamePrefix}${projectId}/${issueNamePrefix}${issueId}`;+ await issueServiceClientConnect.updateIssueComment(+ createProto(UpdateIssueCommentRequestSchema, {+ parent,+ issueComment: createProto(IssueCommentSchema, {+ name: issueCommentName,+ comment,+ }),+ updateMask: { paths: ["comment"] },+ })+ );+ set((state) => ({+ issueCommentsByIssue: {+ ...state.issueCommentsByIssue,+ [parent]: (state.issueCommentsByIssue[parent] ?? []).map(+ (issueComment) =>+ issueComment.name === issueCommentName+ ? { ...issueComment, comment }+ : issueComment+ ),+ },+ }));+ },++ getIssueComments: (issueName) =>+ get().issueCommentsByIssue[issueName] ?? EMPTY_COMMENTS,+});diff --git a/frontend/src/store/modules/v1/plan.ts b/frontend/src/react/stores/app/plan.tssimilarity index 51%rename from frontend/src/store/modules/v1/plan.tsrename to frontend/src/react/stores/app/plan.tsindex 1ffd9edd2c..882319ab0e 100644--- a/frontend/src/store/modules/v1/plan.ts+++ b/frontend/src/react/stores/app/plan.ts@@ -1,32 +1,17 @@-import { create } from "@bufbuild/protobuf";+import { create as createProto } from "@bufbuild/protobuf";import dayjs from "dayjs";import { uniq } from "lodash-es";-import { defineStore } from "pinia";import { planServiceClientConnect } from "@/connect";-import type { Plan } from "@/types/proto-es/v1/plan_service_pb";import {- GetPlanRequestSchema,ListPlansRequestSchema,- UpdatePlanRequestSchema,+ type Plan,} from "@/types/proto-es/v1/plan_service_pb";import {getTsRangeFromSearchParams,getValueFromSearchParams,type SearchParams,} from "@/utils";-import { useUserStore } from "../user";--export interface PlanFind {- project: string;- query?: string;- creator?: string;- createdTsAfter?: number;- createdTsBefore?: number;- hasIssue?: boolean;- hasRollout?: boolean;- specType?: string;- state?: "ACTIVE" | "DELETED";-}+import type { AppSliceCreator, PlanFind, PlanSlice } from "./types";export const buildPlanFilter = (find: PlanFind): string => {const filter: string[] = [];@@ -85,54 +70,20 @@ export const buildPlanFindBySearchParams = (return filter;};-export type ListPlanParams = {- find: PlanFind;- pageSize?: number;- pageToken?: string;-};--export const usePlanStore = defineStore("plan", () => {- const listPlans = async ({ find, pageSize, pageToken }: ListPlanParams) => {- const request = create(ListPlansRequestSchema, {- parent: find.project,- filter: buildPlanFilter(find),- pageSize,- pageToken,- });- const { plans, nextPageToken } =- await planServiceClientConnect.listPlans(request);- // Prepare creator for the plans.- const users = uniq(plans.map((plan: Plan) => plan.creator));- await useUserStore().batchGetOrFetchUsers(users);- return {- nextPageToken: nextPageToken,- plans,- };- };-- const fetchPlanByName = async (name: string): Promise<Plan> => {- const request = create(GetPlanRequestSchema, {- name,- });- const response = await planServiceClientConnect.getPlan(request);- return response;- };-- const updatePlan = async (- plan: Plan,- updateMask: string[]- ): Promise<Plan> => {- const request = create(UpdatePlanRequestSchema, {- plan,- updateMask: { paths: updateMask },- });- const response = await planServiceClientConnect.updatePlan(request);- return response;- };-- return {- listPlans,- fetchPlanByName,- updatePlan,- };+export const createPlanSlice: AppSliceCreator<PlanSlice> = (_set, get) => ({+ listPlans: async ({ find, pageSize, pageToken }) => {+ const { plans, nextPageToken } = await planServiceClientConnect.listPlans(+ createProto(ListPlansRequestSchema, {+ parent: find.project,+ filter: buildPlanFilter(find),+ pageSize,+ pageToken,+ })+ );+ // Prefetch the plan creators so consumers can resolve them synchronously.+ await get().batchGetOrFetchUsers(+ uniq(plans.map((plan: Plan) => plan.creator))+ );+ return { nextPageToken, plans };+ },});diff --git a/frontend/src/react/stores/app/rollout.ts b/frontend/src/react/stores/app/rollout.tsnew file mode 100644index 0000000000..f3ec1ff13d--- /dev/null+++ b/frontend/src/react/stores/app/rollout.ts@@ -0,0 +1,27 @@+import { create as createProto } from "@bufbuild/protobuf";+import { createContextValues } from "@connectrpc/connect";+import { rolloutServiceClientConnect } from "@/connect";+import { silentContextKey } from "@/connect/context-key";+import { GetRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";+import { unknownRollout } from "@/types/rollout";+import type { AppSliceCreator, RolloutSlice } from "./types";++export const createRolloutSlice: AppSliceCreator<RolloutSlice> = (+ set,+ get+) => ({+ rolloutsByName: {},++ fetchRolloutByName: async (name, silent = false) => {+ const rollout = await rolloutServiceClientConnect.getRollout(+ createProto(GetRolloutRequestSchema, { name }),+ { contextValues: createContextValues().set(silentContextKey, silent) }+ );+ set((state) => ({+ rolloutsByName: { ...state.rolloutsByName, [rollout.name]: rollout },+ }));+ return rollout;+ },++ getRolloutByName: (name) => get().rolloutsByName[name] ?? unknownRollout(),+});diff --git a/frontend/src/react/stores/app/types.ts b/frontend/src/react/stores/app/types.tsindex a57bcb1444..98e0de5c51 100644--- a/frontend/src/react/stores/app/types.ts+++ b/frontend/src/react/stores/app/types.ts@@ -33,16 +33,22 @@ import type {Instance,InstanceResource,} from "@/types/proto-es/v1/instance_service_pb";-import type { Issue } from "@/types/proto-es/v1/issue_service_pb";+import type {+ Issue,+ IssueComment,+ ListIssueCommentsRequest,+} from "@/types/proto-es/v1/issue_service_pb";import type {Policy,PolicyType,QueryDataPolicy,} from "@/types/proto-es/v1/org_policy_service_pb";+import type { Plan } from "@/types/proto-es/v1/plan_service_pb";import type { Project, Webhook } from "@/types/proto-es/v1/project_service_pb";import type { Release } from "@/types/proto-es/v1/release_service_pb";import type { Revision } from "@/types/proto-es/v1/revision_service_pb";import type { Role } from "@/types/proto-es/v1/role_service_pb";+import type { Rollout } from "@/types/proto-es/v1/rollout_service_pb";import type { ServiceAccount } from "@/types/proto-es/v1/service_account_service_pb";import type {Setting,@@ -70,6 +76,7 @@ import type {} from "@/types/proto-es/v1/worksheet_service_pb";import type { Workspace } from "@/types/proto-es/v1/workspace_service_pb";import type { Environment } from "@/types/v1/environment";+import type { IssueFilter } from "@/types/v1/issue/issue";import type { SQLResultSetV1 } from "@/types/v1/sql";import type { AccessGrantFilterStatus } from "@/utils";@@ -664,8 +671,17 @@ export type PolicySlice = {// thin wrapper around `issueServiceClientConnect.getIssue`. Returns the// fresh issue (no cache) and pre-fetches the owning project into the app// store so downstream code can read it synchronously.+export type ListIssueParams = {+ find: IssueFilter;+ pageSize?: number;+ pageToken?: string;+};+export type IssueSlice = {fetchIssueByName: (name: string, silent?: boolean) => Promise<Issue>;+ listIssues: (+ params: ListIssueParams+ ) => Promise<{ nextPageToken: string; issues: Issue[] }>;};// Stateless SQL service slice (mirrors the legacy Pinia `useSQLStore`):@@ -750,6 +766,55 @@ export type DBSchemaSlice = {) => Promise<DatabaseMetadata>;};+export type IssueCommentSlice = {+ // Cache keyed by issue resource name → its comment list.+ issueCommentsByIssue: Record<string, IssueComment[]>;+ listIssueComments: (+ request: ListIssueCommentsRequest+ ) => Promise<{ nextPageToken: string; issueComments: IssueComment[] }>;+ createIssueComment: (params: {+ issueName: string;+ comment: string;+ }) => Promise<void>;+ updateIssueComment: (params: {+ issueCommentName: string;+ comment: string;+ }) => Promise<void>;+ // Synchronous cache read; returns a stable empty array on miss.+ getIssueComments: (issueName: string) => IssueComment[];+};++export interface PlanFind {+ project: string;+ query?: string;+ creator?: string;+ createdTsAfter?: number;+ createdTsBefore?: number;+ hasIssue?: boolean;+ hasRollout?: boolean;+ specType?: string;+ state?: "ACTIVE" | "DELETED";+}++export type ListPlanParams = {+ find: PlanFind;+ pageSize?: number;+ pageToken?: string;+};++export type PlanSlice = {+ listPlans: (+ params: ListPlanParams+ ) => Promise<{ plans: Plan[]; nextPageToken: string }>;+};++export type RolloutSlice = {+ rolloutsByName: Record<string, Rollout>;+ fetchRolloutByName: (name: string, silent?: boolean) => Promise<Rollout>;+ // Synchronous cache read; returns `unknownRollout()` on miss.+ getRolloutByName: (name: string) => Rollout;+};+export type AppStoreState = AuthSlice &WorkspaceSlice &IamSlice &@@ -776,6 +841,9 @@ export type AppStoreState = AuthSlice &SQLSlice &IssueSlice &PolicySlice &- DBSchemaSlice;+ DBSchemaSlice &+ RolloutSlice &+ PlanSlice &+ IssueCommentSlice;export type AppSliceCreator<Slice> = StateCreator<AppStoreState, [], [], Slice>;diff --git a/frontend/src/store/modules/index.ts b/frontend/src/store/modules/index.tsindex c210f9d48b..b8979a3457 100644--- a/frontend/src/store/modules/index.ts+++ b/frontend/src/store/modules/index.ts@@ -9,6 +9,5 @@ export * from "./workloadIdentity";export * from "./workspaceApprovalSetting";export * from "./role";export * from "./utils";-export * from "./rollout";export * from "./v1";diff --git a/frontend/src/store/modules/rollout.ts b/frontend/src/store/modules/rollout.tsdeleted file mode 100644index 79db9299a5..0000000000--- a/frontend/src/store/modules/rollout.ts+++ /dev/null@@ -1,153 +0,0 @@-import { create } from "@bufbuild/protobuf";-import { createContextValues } from "@connectrpc/connect";-import dayjs from "dayjs";-import { defineStore } from "pinia";-import { computed, reactive, ref, unref, watch } from "vue";-import { rolloutServiceClientConnect } from "@/connect";-import { silentContextKey } from "@/connect/context-key";-import type { MaybeRef } from "@/types";-import { isValidRolloutName, unknownRollout } from "@/types";-import {- GetRolloutRequestSchema,- ListRolloutsRequestSchema,- type Rollout,- Task_Type,-} from "@/types/proto-es/v1/rollout_service_pb";-import {- getTsRangeFromSearchParams,- getValueFromSearchParams,- type SearchParams,-} from "@/utils";--export interface RolloutFind {- project: string;- taskType?: Task_Type[];- query?: string;- updatedTsAfter?: number;- updatedTsBefore?: number;-}--export const buildRolloutFilter = (find: RolloutFind): string => {- const filter: string[] = [];- if (find.taskType && find.taskType.length > 0) {- const types = find.taskType.map((t) => `"${Task_Type[t]}"`).join(", ");- filter.push(`task_type in [${types}]`);- }- if (find.updatedTsAfter) {- filter.push(- `update_time >= "${dayjs(find.updatedTsAfter).utc().toISOString()}"`- );- }- if (find.updatedTsBefore) {- filter.push(- `update_time <= "${dayjs(find.updatedTsBefore).utc().toISOString()}"`- );- }- return filter.join(" && ");-};--export const buildRolloutFindBySearchParams = (- params: SearchParams,- defaultFind?: Partial<RolloutFind>-) => {- const projectScope = getValueFromSearchParams(params, "project");- const updatedTsRange = getTsRangeFromSearchParams(params, "updated");-- const filter: RolloutFind = {- ...defaultFind,- project: `projects/${projectScope || "-"}`,- query: params.query,- updatedTsAfter: updatedTsRange?.[0],- updatedTsBefore: updatedTsRange?.[1],- };- return filter;-};--export type ListRolloutParams = {- find: RolloutFind;- pageSize?: number;- pageToken?: string;-};--export const useRolloutStore = defineStore("rollout", () => {- const rolloutMapByName = reactive(new Map<string, Rollout>());-- const rolloutList = computed(() => {- return Array.from(rolloutMapByName.values());- });-- const listRollouts = async ({- find,- pageSize,- pageToken,- }: ListRolloutParams) => {- const request = create(ListRolloutsRequestSchema, {- parent: find.project,- pageSize: pageSize,- pageToken: pageToken || "",- filter: buildRolloutFilter(find),- });- const resp = await rolloutServiceClientConnect.listRollouts(request);- const rollouts = resp.rollouts;- rollouts.forEach((rollout) => {- rolloutMapByName.set(rollout.name, rollout);- });- return {- rollouts: rollouts,- nextPageToken: resp.nextPageToken,- };- };-- const fetchRolloutByName = async (name: string, silent = false) => {- const request = create(GetRolloutRequestSchema, {- name,- });- const rollout = await rolloutServiceClientConnect.getRollout(request, {- contextValues: createContextValues().set(silentContextKey, silent),- });- rolloutMapByName.set(rollout.name, rollout);- return rollout;- };-- const getRolloutByName = (name: string) => {- return rolloutMapByName.get(name) ?? unknownRollout();- };-- return {- rolloutList,- listRollouts,- fetchRolloutByName,- getRolloutByName,- };-});--export const useRolloutByName = (name: MaybeRef<string>) => {- const store = useRolloutStore();- const ready = ref(true);- watch(- () => unref(name),- async (name) => {- if (!isValidRolloutName(name)) {- return;- }-- const cached = store.getRolloutByName(name);- if (!isValidRolloutName(cached.name)) {- ready.value = false;- try {- await store.fetchRolloutByName(name);- } catch {- // ignore- }- ready.value = true;- }- },- { immediate: true }- );- const rollout = computed(() => store.getRolloutByName(unref(name)));-- return {- rollout,- ready,- };-};diff --git a/frontend/src/store/modules/v1/experimental-issue.ts b/frontend/src/store/modules/v1/experimental-issue.tsdeleted file mode 100644index 693c1e2330..0000000000--- a/frontend/src/store/modules/v1/experimental-issue.ts+++ /dev/null@@ -1,54 +0,0 @@-import { create } from "@bufbuild/protobuf";-import {- issueServiceClientConnect,- planServiceClientConnect,- rolloutServiceClientConnect,-} from "@/connect";-import type { Issue } from "@/types/proto-es/v1/issue_service_pb";-import { CreateIssueRequestSchema } from "@/types/proto-es/v1/issue_service_pb";-import type { Plan } from "@/types/proto-es/v1/plan_service_pb";-import { CreatePlanRequestSchema } from "@/types/proto-es/v1/plan_service_pb";-import type { Project } from "@/types/proto-es/v1/project_service_pb";-import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";--export interface CreateIssueByPlanOptions {- skipRollout?: boolean;-}--export const experimentalCreateIssueByPlan = async (- project: Project,- issueCreate: Issue,- planCreate: Plan,- options?: CreateIssueByPlanOptions-) => {- const newPlan = planCreate;- const request = create(CreatePlanRequestSchema, {- parent: project.name,- plan: newPlan,- });- const response = await planServiceClientConnect.createPlan(request);- const createdPlan = response;- issueCreate.plan = createdPlan.name;-- const issueRequest = create(CreateIssueRequestSchema, {- parent: project.name,- issue: issueCreate,- });- const newCreatedIssue =- await issueServiceClientConnect.createIssue(issueRequest);- const createdIssue = newCreatedIssue;-- // Skip rollout creation for plans that create rollout on-demand (e.g., database creation)- if (options?.skipRollout) {- return { createdPlan, createdIssue, createdRollout: undefined };- }-- const rolloutRequest = create(CreateRolloutRequestSchema, {- parent: createdPlan.name,- });- const rolloutResponse =- await rolloutServiceClientConnect.createRollout(rolloutRequest);- const createdRollout = rolloutResponse;-- return { createdPlan, createdIssue, createdRollout };-};diff --git a/frontend/src/store/modules/v1/index.ts b/frontend/src/store/modules/v1/index.tsindex ec3dc97130..75d7b24e82 100644--- a/frontend/src/store/modules/v1/index.ts+++ b/frontend/src/store/modules/v1/index.ts@@ -5,12 +5,9 @@ export * from "./database";export * from "./databaseCatalog";export * from "./dbSchema";export * from "./environment";-export * from "./experimental-issue";export * from "./group";export * from "./instance";export * from "./instanceResource";-export * from "./issue";-export * from "./issueComment";export * from "./permission";export * from "./policy";export * from "./project";@@ -21,4 +18,3 @@ export * from "./sql";export * from "./storage";export * from "./subscription";export * from "./workspace";-export * from "./plan";diff --git a/frontend/src/store/modules/v1/issue.ts b/frontend/src/store/modules/v1/issue.tsdeleted file mode 100644index 0b2373eece..0000000000--- a/frontend/src/store/modules/v1/issue.ts+++ /dev/null@@ -1,162 +0,0 @@-import { create } from "@bufbuild/protobuf";-import { createContextValues } from "@connectrpc/connect";-import dayjs from "dayjs";-import { uniq } from "lodash-es";-import { defineStore } from "pinia";-import type { WatchCallback } from "vue";-import { ref, watch } from "vue";-import { issueServiceClientConnect } from "@/connect";-import { silentContextKey } from "@/connect/context-key";-import { type IssueFilter } from "@/types";-import { ApprovalStatus, RiskLevel } from "@/types/proto-es/v1/common_pb";-import type { Issue } from "@/types/proto-es/v1/issue_service_pb";-import {- GetIssueRequestSchema,- Issue_Type,- IssueStatus,- SearchIssuesRequestSchema,-} from "@/types/proto-es/v1/issue_service_pb";-import {- extractProjectResourceName,- memberMapToRolesInProjectIAM,-} from "@/utils";-import { useUserStore } from "../user";-import { projectNamePrefix, userNamePrefix } from "./common";-import { useProjectV1Store } from "./project";-import { useProjectIamPolicyStore } from "./projectIamPolicy";--export type ListIssueParams = {- find: IssueFilter;- pageSize?: number;- pageToken?: string;-};--export const buildIssueFilter = (find: IssueFilter): string => {- const filter: string[] = [];- if (find.creator) {- filter.push(`creator == "${find.creator}"`);- }- if (find.currentApprover) {- filter.push(`current_approver == "${find.currentApprover}"`);- }- if (find.approvalStatus) {- filter.push(`approval_status == "${ApprovalStatus[find.approvalStatus]}"`);- }- if (find.statusList && find.statusList.length > 0) {- filter.push(- `status in [${find.statusList.map((s) => `"${IssueStatus[s]}"`).join(",")}]`- );- }- if (find.riskLevelList && find.riskLevelList.length > 0) {- filter.push(- `risk_level in [${find.riskLevelList.map((r) => `"${RiskLevel[r]}"`).join(",")}]`- );- }- if (find.createdTsAfter) {- filter.push(- `create_time >= "${dayjs(find.createdTsAfter).utc().format()}"`- );- }- if (find.createdTsBefore) {- filter.push(- `create_time <= "${dayjs(find.createdTsBefore).utc().format()}"`- );- }- if (find.typeList && find.typeList.length > 0) {- filter.push(- `type in [${find.typeList.map((t) => `"${Issue_Type[t]}"`).join(",")}]`- );- }- if (find.labels && find.labels.length > 0) {- filter.push(`labels in [${find.labels.map((l) => `"${l}"`).join(",")}]`);- }- return filter.join(" && ");-};--export const useIssueV1Store = defineStore("issue_v1", () => {- const projectStore = useProjectV1Store();-- const listIssues = async ({- find,- pageSize,- pageToken,- }: ListIssueParams): Promise<{ nextPageToken: string; issues: Issue[] }> => {- const request = create(SearchIssuesRequestSchema, {- parent: find.project,- filter: buildIssueFilter(find),- query: find.query,- pageSize,- pageToken,- orderBy: find.orderBy,- });- const resp = await issueServiceClientConnect.searchIssues(request);- const issues = resp.issues;-- const projects = issues.map((issue) => {- return `projects/${extractProjectResourceName(issue.name)}`;- });- await projectStore.batchGetOrFetchProjects(projects);- // Prepare creator for the issues.- const users = uniq(issues.map((issue) => issue.creator));- await useUserStore().batchGetOrFetchUsers(users);- return {- nextPageToken: resp.nextPageToken,- issues,- };- };-- const fetchIssueByName = async (- name: string,- silent: boolean = false- ): Promise<Issue> => {- const request = create(GetIssueRequestSchema, { name });- const issue = await issueServiceClientConnect.getIssue(request, {- contextValues: createContextValues().set(silentContextKey, silent),- });- await projectStore.getOrFetchProjectByName(- `projects/${extractProjectResourceName(issue.name)}`- );- return issue;- };-- return {- listIssues,- fetchIssueByName,- };-});--// candidatesOfApprovalStepV1 return user name list in users/{email} format.-// The list could includs users/ALL_USERS_USER_EMAIL-export const candidatesOfApprovalStepV1 = (issue: Issue, role: string) => {- const project = useProjectV1Store().getProjectByName(- `${projectNamePrefix}${extractProjectResourceName(issue.name)}`- );- const candidatesForRoles = (role: string) => {- const projectIamPolicyStore = useProjectIamPolicyStore();- const iamPolicy = projectIamPolicyStore.getProjectIamPolicy(project.name);- const memberMap = memberMapToRolesInProjectIAM(iamPolicy, role);- return [...memberMap.keys()].filter((name) =>- name.startsWith(userNamePrefix)- );- };- const candidates = role ? candidatesForRoles(role) : [];-- return uniq(- candidates.filter((user) => {- // If the project does not allow self-approval, exclude the creator.- if (!project.allowSelfApproval && user === issue.creator) {- return false;- }- return true;- })- );-};--// expose global list refresh features-const REFRESH_ISSUE_LIST = ref(Math.random());-export const refreshIssueList = () => {- REFRESH_ISSUE_LIST.value = Math.random();-};-export const useRefreshIssueList = (callback: WatchCallback) => {- watch(REFRESH_ISSUE_LIST, callback);-};diff --git a/frontend/src/store/modules/v1/issueComment.ts b/frontend/src/store/modules/v1/issueComment.tsdeleted file mode 100644index 376522b749..0000000000--- a/frontend/src/store/modules/v1/issueComment.ts+++ /dev/null@@ -1,127 +0,0 @@-import { create } from "@bufbuild/protobuf";-import { defineStore } from "pinia";-import { reactive } from "vue";-import { issueServiceClientConnect } from "@/connect";-import type {- IssueComment,- ListIssueCommentsRequest,-} from "@/types/proto-es/v1/issue_service_pb";-import {- CreateIssueCommentRequestSchema,- IssueCommentSchema,- ListIssueCommentsRequestSchema,- UpdateIssueCommentRequestSchema,-} from "@/types/proto-es/v1/issue_service_pb";-import {- getProjectIdIssueIdIssueCommentId,- issueNamePrefix,- projectNamePrefix,-} from "./common";--export enum IssueCommentType {- USER_COMMENT = "USER_COMMENT",- APPROVAL = "APPROVAL",- ISSUE_UPDATE = "ISSUE_UPDATE",- PLAN_UPDATE = "PLAN_UPDATE",-}--export const getIssueCommentType = (- issueComment: IssueComment-): IssueCommentType => {- if (issueComment.event?.case === "approval") {- return IssueCommentType.APPROVAL;- } else if (issueComment.event?.case === "issueUpdate") {- return IssueCommentType.ISSUE_UPDATE;- } else if (issueComment.event?.case === "planUpdate") {- return IssueCommentType.PLAN_UPDATE;- }- return IssueCommentType.USER_COMMENT;-};--export const useIssueCommentStore = defineStore("issue_comment", () => {- // issueCommentMap is a map of issueName to IssueComment[].- const issueCommentMap = reactive(new Map<string, IssueComment[]>());-- const listIssueComments = async (request: ListIssueCommentsRequest) => {- const connectRequest = create(ListIssueCommentsRequestSchema, {- parent: request.parent,- pageSize: request.pageSize,- pageToken: request.pageToken,- });- const resp =- await issueServiceClientConnect.listIssueComments(connectRequest);- const issueComments = resp.issueComments;- issueCommentMap.set(request.parent, issueComments);-- return {- nextPageToken: resp.nextPageToken,- issueComments,- };- };-- const createIssueComment = async ({- issueName,- comment,- }: {- issueName: string;- comment: string;- }) => {- const request = create(CreateIssueCommentRequestSchema, {- parent: issueName,- issueComment: create(IssueCommentSchema, {- comment,- }),- });- const newIssueComment =- await issueServiceClientConnect.createIssueComment(request);- const issueComment = newIssueComment;- issueCommentMap.set(issueName, [- ...(issueCommentMap.get(issueName) ?? []),- issueComment,- ]);- };-- const updateIssueComment = async ({- issueCommentName,- comment,- }: {- issueCommentName: string;- comment: string;- }) => {- const { projectId, issueId } =- getProjectIdIssueIdIssueCommentId(issueCommentName);- const parent = `${projectNamePrefix}${projectId}/${issueNamePrefix}${issueId}`;- const request = create(UpdateIssueCommentRequestSchema, {- parent: parent,- issueComment: create(IssueCommentSchema, {- name: issueCommentName,- comment,- }),- updateMask: { paths: ["comment"] },- });- await issueServiceClientConnect.updateIssueComment(request);- issueCommentMap.set(- parent,- (issueCommentMap.get(parent) ?? []).map((issueComment) => {- if (issueComment.name === issueCommentName) {- return {- ...issueComment,- comment,- };- }- return issueComment;- })- );- };-- const getIssueComments = (issueName: string): IssueComment[] => {- return issueCommentMap.get(issueName) ?? [];- };-- return {- listIssueComments,- createIssueComment,- updateIssueComment,- getIssueComments,- };-});