Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(plan): prevent task SQL preview clipping (#20398)

boojack3ae4b35c47d2
diff --git a/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.test.tsx b/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.test.tsx
new file mode 100644
index 0000000000..31c82bd010
--- /dev/null
+++ b/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.test.tsx
@@ -0,0 +1,22 @@
+import { describe, expect, test } from "vitest";
+
+import source from "./PlanDetailRollbackSheet.tsx?raw";
+
+const rollbackReadonlyMonacoProps = (src: string): string => {
+ const match = src.match(
+ /<ReadonlyMonaco[\s\S]*?content=\{preview\.statement\}[\s\S]*?\/>/
+ );
+ expect(match, "expected rollback preview ReadonlyMonaco").not.toBeNull();
+ return match?.[0] ?? "";
+};
+
+describe("PlanDetailRollbackSheet statement preview", () => {
+ test("lets Monaco own the compact preview viewport", () => {
+ const props = rollbackReadonlyMonacoProps(source);
+
+ expect(props).toContain("max={256}");
+ expect(props).toContain("min={128}");
+ expect(props).not.toContain("max-h-[320px]");
+ expect(props).not.toContain("overflow-hidden");
+ });
+});
diff --git a/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.tsx b/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.tsx
index b2ee146b89..21fbc6ea5f 100644
--- a/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.tsx
+++ b/frontend/src/react/pages/project/plan-detail/components/PlanDetailRollbackSheet.tsx
@@ -239,9 +239,11 @@ export function PlanDetailRollbackSheet({
</div>
) : preview.statement ? (
<ReadonlyMonaco
- className="relative h-auto max-h-[320px] min-h-[120px] overflow-hidden rounded-md border border-control-border"
+ className="relative rounded-md border border-control-border"
content={preview.statement}
language="sql"
+ min={128}
+ max={256}
/>
) : (
<div className="flex items-center justify-center rounded-md border bg-gray-50 p-8">
diff --git a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.test.tsx b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.test.tsx
new file mode 100644
index 0000000000..0479ac39b8
--- /dev/null
+++ b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.test.tsx
@@ -0,0 +1,22 @@
+import { describe, expect, test } from "vitest";
+
+import source from "./DeployTaskItem.tsx?raw";
+
+const statementReadonlyMonacoProps = (src: string): string => {
+ const match = src.match(
+ /<ReadonlyMonaco[\s\S]*?content=\{statement\}[\s\S]*?\/>/
+ );
+ expect(match, "expected statement ReadonlyMonaco").not.toBeNull();
+ return match?.[0] ?? "";
+};
+
+describe("DeployTaskItem statement editor", () => {
+ test("lets Monaco own the compact statement viewport", () => {
+ const props = statementReadonlyMonacoProps(source);
+
+ expect(props).toContain("max={256}");
+ expect(props).toContain("min={128}");
+ expect(props).not.toContain("max-h-64");
+ expect(props).not.toContain("overflow-hidden");
+ });
+});
diff --git a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.tsx b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.tsx
index 5e1a96d4af..6a6a56a9de 100644
--- a/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.tsx
+++ b/frontend/src/react/pages/project/plan-detail/components/deploy/DeployTaskItem.tsx
@@ -300,11 +300,13 @@ export function DeployTaskItem({
<>
<ReadonlyMonaco
className={cn(
- "relative max-h-64 min-h-[120px] overflow-hidden rounded border text-sm",
+ "relative rounded border text-sm",
isTruncated && "rounded-b-none"
)}
content={statement}
language="sql"
+ min={128}
+ max={256}
/>
{isTruncated && (
<div className="rounded-b border border-t-0 bg-gray-50 px-3 py-1.5 text-xs text-gray-500">