Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor: use enum for SQL review rule type (#18364)

Danny Xu3b6b910ce9c8
diff --git a/backend/api/v1/org_policy_service_converter.go b/backend/api/v1/org_policy_service_converter.go
index 347ebe7e61..1bda1bd304 100644
--- a/backend/api/v1/org_policy_service_converter.go
+++ b/backend/api/v1/org_policy_service_converter.go
@@ -24,7 +24,7 @@ func convertToV1PBSQLReviewRules(ruleList []*storepb.SQLReviewRule) []*v1pb.SQLR
}
rules = append(rules, &v1pb.SQLReviewRule{
Level: level,
- Type: string(rule.Type),
+ Type: v1pb.SQLReviewRule_Type(rule.Type),
Payload: rule.Payload,
Engine: convertToEngine(rule.Engine),
})
@@ -48,7 +48,7 @@ func convertToSQLReviewRules(rules []*v1pb.SQLReviewRule) ([]*storepb.SQLReviewR
ruleList = append(ruleList, &storepb.SQLReviewRule{
Level: level,
Payload: rule.Payload,
- Type: rule.Type,
+ Type: storepb.SQLReviewRule_Type(rule.Type),
Engine: convertEngine(rule.Engine),
})
}
diff --git a/backend/api/v1/review_config_service.go b/backend/api/v1/review_config_service.go
index cf528da963..009e960874 100644
--- a/backend/api/v1/review_config_service.go
+++ b/backend/api/v1/review_config_service.go
@@ -295,35 +295,35 @@ func validateSQLReviewRules(rules []*v1pb.SQLReviewRule) error {
if rule.Level == v1pb.SQLReviewRule_LEVEL_UNSPECIFIED {
return errors.Errorf("invalid rule level: LEVEL_UNSPECIFIED is not allowed for rule %q", rule.Type)
}
- ruleType := advisor.SQLReviewRuleType(rule.Type)
+ ruleType := storepb.SQLReviewRule_Type(rule.Type)
// TODO(rebelice): add other SQL review rule validation.
switch ruleType {
- case advisor.SchemaRuleTableNaming, advisor.SchemaRuleColumnNaming, advisor.SchemaRuleAutoIncrementColumnNaming:
+ case storepb.SQLReviewRule_NAMING_TABLE, storepb.SQLReviewRule_NAMING_COLUMN, storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT:
if _, _, err := advisor.UnmarshalNamingRulePayloadAsRegexp(rule.Payload); err != nil {
return err
}
- case advisor.SchemaRuleFKNaming, advisor.SchemaRuleIDXNaming, advisor.SchemaRuleUKNaming:
+ case storepb.SQLReviewRule_NAMING_INDEX_FK, storepb.SQLReviewRule_NAMING_INDEX_IDX, storepb.SQLReviewRule_NAMING_INDEX_UK:
if _, _, _, err := advisor.UnmarshalNamingRulePayloadAsTemplate(ruleType, rule.Payload); err != nil {
return err
}
- case advisor.SchemaRuleRequiredColumn:
+ case storepb.SQLReviewRule_COLUMN_REQUIRED:
if _, err := advisor.UnmarshalRequiredColumnList(rule.Payload); err != nil {
return err
}
- case advisor.SchemaRuleColumnCommentConvention, advisor.SchemaRuleTableCommentConvention:
+ case storepb.SQLReviewRule_COLUMN_COMMENT, storepb.SQLReviewRule_TABLE_COMMENT:
if _, err := advisor.UnmarshalCommentConventionRulePayload(rule.Payload); err != nil {
return err
}
- case advisor.SchemaRuleIndexKeyNumberLimit, advisor.SchemaRuleStatementInsertRowLimit, advisor.SchemaRuleIndexTotalNumberLimit,
- advisor.SchemaRuleColumnMaximumCharacterLength, advisor.SchemaRuleColumnMaximumVarcharLength, advisor.SchemaRuleColumnAutoIncrementInitialValue, advisor.SchemaRuleStatementAffectedRowLimit:
+ case storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE, storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT:
if _, err := advisor.UnmarshalNumberTypeRulePayload(rule.Payload); err != nil {
return err
}
- case advisor.SchemaRuleColumnTypeDisallowList, advisor.SchemaRuleCharsetAllowlist, advisor.SchemaRuleCollationAllowlist, advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist:
+ case storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST, storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST, storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST:
if _, err := advisor.UnmarshalStringArrayTypeRulePayload(rule.Payload); err != nil {
return err
}
- case advisor.SchemaRuleIdentifierCase:
+ case storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE:
if _, err := advisor.UnmarshalNamingCaseRulePayload(rule.Payload); err != nil {
return err
}
diff --git a/backend/api/v1/review_config_service_test.go b/backend/api/v1/review_config_service_test.go
index 4860dae102..59679545a7 100644
--- a/backend/api/v1/review_config_service_test.go
+++ b/backend/api/v1/review_config_service_test.go
@@ -25,7 +25,7 @@ func TestValidateSQLReviewRules(t *testing.T) {
name: "valid ERROR level",
rules: []*v1pb.SQLReviewRule{
{
- Type: "table.require-pk",
+ Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
Payload: "",
@@ -37,7 +37,7 @@ func TestValidateSQLReviewRules(t *testing.T) {
name: "valid WARNING level",
rules: []*v1pb.SQLReviewRule{
{
- Type: "table.require-pk",
+ Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
Payload: "",
@@ -49,33 +49,33 @@ func TestValidateSQLReviewRules(t *testing.T) {
name: "invalid LEVEL_UNSPECIFIED",
rules: []*v1pb.SQLReviewRule{
{
- Type: "table.require-pk",
+ Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,
Level: v1pb.SQLReviewRule_LEVEL_UNSPECIFIED,
Engine: v1pb.Engine_POSTGRES,
Payload: "",
},
},
wantErr: true,
- errMsg: "invalid rule level: LEVEL_UNSPECIFIED is not allowed for rule \"table.require-pk\"",
+ errMsg: "invalid rule level: LEVEL_UNSPECIFIED is not allowed for rule \"TABLE_REQUIRE_PK\"",
},
{
name: "multiple rules with one invalid",
rules: []*v1pb.SQLReviewRule{
{
- Type: "table.require-pk",
+ Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
Payload: "",
},
{
- Type: "table.no-foreign-key",
+ Type: v1pb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
Level: v1pb.SQLReviewRule_LEVEL_UNSPECIFIED,
Engine: v1pb.Engine_POSTGRES,
Payload: "",
},
},
wantErr: true,
- errMsg: "invalid rule level: LEVEL_UNSPECIFIED is not allowed for rule \"table.no-foreign-key\"",
+ errMsg: "invalid rule level: LEVEL_UNSPECIFIED is not allowed for rule \"TABLE_NO_FOREIGN_KEY\"",
},
}
diff --git a/backend/generated-go/store/review_config.pb.go b/backend/generated-go/store/review_config.pb.go
index 8d7d2a16ac..bf45910771 100644
--- a/backend/generated-go/store/review_config.pb.go
+++ b/backend/generated-go/store/review_config.pb.go
@@ -74,6 +74,376 @@ func (SQLReviewRule_Level) EnumDescriptor() ([]byte, []int) {
return file_store_review_config_proto_rawDescGZIP(), []int{1, 0}
}
+type SQLReviewRule_Type int32
+
+const (
+ SQLReviewRule_TYPE_UNSPECIFIED SQLReviewRule_Type = 0
+ SQLReviewRule_ENGINE_MYSQL_USE_INNODB SQLReviewRule_Type = 1
+ SQLReviewRule_NAMING_FULLY_QUALIFIED SQLReviewRule_Type = 2
+ SQLReviewRule_NAMING_TABLE SQLReviewRule_Type = 3
+ SQLReviewRule_NAMING_COLUMN SQLReviewRule_Type = 4
+ SQLReviewRule_NAMING_INDEX_PK SQLReviewRule_Type = 5
+ SQLReviewRule_NAMING_INDEX_UK SQLReviewRule_Type = 6
+ SQLReviewRule_NAMING_INDEX_FK SQLReviewRule_Type = 7
+ SQLReviewRule_NAMING_INDEX_IDX SQLReviewRule_Type = 8
+ SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT SQLReviewRule_Type = 9
+ SQLReviewRule_NAMING_TABLE_NO_KEYWORD SQLReviewRule_Type = 10
+ SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD SQLReviewRule_Type = 11
+ SQLReviewRule_NAMING_IDENTIFIER_CASE SQLReviewRule_Type = 12
+ SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL SQLReviewRule_Type = 13
+ SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT SQLReviewRule_Type = 14
+ SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE SQLReviewRule_Type = 15
+ SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE SQLReviewRule_Type = 16
+ SQLReviewRule_STATEMENT_DISALLOW_ON_DEL_CASCADE SQLReviewRule_Type = 17
+ SQLReviewRule_STATEMENT_DISALLOW_RM_TBL_CASCADE SQLReviewRule_Type = 18
+ SQLReviewRule_STATEMENT_DISALLOW_COMMIT SQLReviewRule_Type = 19
+ SQLReviewRule_STATEMENT_DISALLOW_LIMIT SQLReviewRule_Type = 20
+ SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY SQLReviewRule_Type = 21
+ SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE SQLReviewRule_Type = 22
+ SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT SQLReviewRule_Type = 23
+ SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN SQLReviewRule_Type = 24
+ SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND SQLReviewRule_Type = 25
+ SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT SQLReviewRule_Type = 26
+ SQLReviewRule_STATEMENT_DML_DRY_RUN SQLReviewRule_Type = 27
+ SQLReviewRule_STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT SQLReviewRule_Type = 28
+ SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID SQLReviewRule_Type = 29
+ SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID SQLReviewRule_Type = 30
+ SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL SQLReviewRule_Type = 31
+ SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN SQLReviewRule_Type = 32
+ SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA SQLReviewRule_Type = 33
+ SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE SQLReviewRule_Type = 34
+ SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT SQLReviewRule_Type = 35
+ SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY SQLReviewRule_Type = 36
+ SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL SQLReviewRule_Type = 37
+ SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS SQLReviewRule_Type = 38
+ SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL SQLReviewRule_Type = 39
+ SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT SQLReviewRule_Type = 40
+ SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE SQLReviewRule_Type = 41
+ SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT SQLReviewRule_Type = 42
+ SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION SQLReviewRule_Type = 43
+ SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS SQLReviewRule_Type = 44
+ SQLReviewRule_STATEMENT_NON_TRANSACTIONAL SQLReviewRule_Type = 45
+ SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION SQLReviewRule_Type = 46
+ SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL SQLReviewRule_Type = 47
+ SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES SQLReviewRule_Type = 48
+ SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME SQLReviewRule_Type = 49
+ SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION SQLReviewRule_Type = 50
+ SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION SQLReviewRule_Type = 51
+ SQLReviewRule_STATEMENT_OBJECT_OWNER_CHECK SQLReviewRule_Type = 52
+ SQLReviewRule_TABLE_REQUIRE_PK SQLReviewRule_Type = 53
+ SQLReviewRule_TABLE_NO_FOREIGN_KEY SQLReviewRule_Type = 54
+ SQLReviewRule_TABLE_DROP_NAMING_CONVENTION SQLReviewRule_Type = 55
+ SQLReviewRule_TABLE_COMMENT SQLReviewRule_Type = 56
+ SQLReviewRule_TABLE_DISALLOW_PARTITION SQLReviewRule_Type = 57
+ SQLReviewRule_TABLE_DISALLOW_TRIGGER SQLReviewRule_Type = 58
+ SQLReviewRule_TABLE_NO_DUPLICATE_INDEX SQLReviewRule_Type = 59
+ SQLReviewRule_TABLE_TEXT_FIELDS_TOTAL_LENGTH SQLReviewRule_Type = 60
+ SQLReviewRule_TABLE_DISALLOW_SET_CHARSET SQLReviewRule_Type = 61
+ SQLReviewRule_TABLE_DISALLOW_DDL SQLReviewRule_Type = 62
+ SQLReviewRule_TABLE_DISALLOW_DML SQLReviewRule_Type = 63
+ SQLReviewRule_TABLE_LIMIT_SIZE SQLReviewRule_Type = 64
+ SQLReviewRule_TABLE_REQUIRE_CHARSET SQLReviewRule_Type = 65
+ SQLReviewRule_TABLE_REQUIRE_COLLATION SQLReviewRule_Type = 66
+ SQLReviewRule_COLUMN_REQUIRED SQLReviewRule_Type = 67
+ SQLReviewRule_COLUMN_NO_NULL SQLReviewRule_Type = 68
+ SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE SQLReviewRule_Type = 69
+ SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL SQLReviewRule_Type = 70
+ SQLReviewRule_COLUMN_DISALLOW_CHANGE SQLReviewRule_Type = 71
+ SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER SQLReviewRule_Type = 72
+ SQLReviewRule_COLUMN_DISALLOW_DROP SQLReviewRule_Type = 73
+ SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX SQLReviewRule_Type = 74
+ SQLReviewRule_COLUMN_COMMENT SQLReviewRule_Type = 75
+ SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER SQLReviewRule_Type = 76
+ SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST SQLReviewRule_Type = 77
+ SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET SQLReviewRule_Type = 78
+ SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH SQLReviewRule_Type = 79
+ SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH SQLReviewRule_Type = 80
+ SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE SQLReviewRule_Type = 81
+ SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED SQLReviewRule_Type = 82
+ SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT SQLReviewRule_Type = 83
+ SQLReviewRule_COLUMN_REQUIRE_DEFAULT SQLReviewRule_Type = 84
+ SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE SQLReviewRule_Type = 85
+ SQLReviewRule_COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT SQLReviewRule_Type = 86
+ SQLReviewRule_COLUMN_REQUIRE_CHARSET SQLReviewRule_Type = 87
+ SQLReviewRule_COLUMN_REQUIRE_COLLATION SQLReviewRule_Type = 88
+ SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY SQLReviewRule_Type = 89
+ SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE SQLReviewRule_Type = 90
+ SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN SQLReviewRule_Type = 91
+ SQLReviewRule_INDEX_KEY_NUMBER_LIMIT SQLReviewRule_Type = 92
+ SQLReviewRule_INDEX_PK_TYPE_LIMIT SQLReviewRule_Type = 93
+ SQLReviewRule_INDEX_TYPE_NO_BLOB SQLReviewRule_Type = 94
+ SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT SQLReviewRule_Type = 95
+ SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST SQLReviewRule_Type = 96
+ SQLReviewRule_INDEX_CREATE_CONCURRENTLY SQLReviewRule_Type = 97
+ SQLReviewRule_INDEX_TYPE_ALLOW_LIST SQLReviewRule_Type = 98
+ SQLReviewRule_INDEX_NOT_REDUNDANT SQLReviewRule_Type = 99
+ SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST SQLReviewRule_Type = 100
+ SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST SQLReviewRule_Type = 101
+ SQLReviewRule_SYSTEM_COMMENT_LENGTH SQLReviewRule_Type = 102
+ SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE SQLReviewRule_Type = 103
+ SQLReviewRule_SYSTEM_EVENT_DISALLOW_CREATE SQLReviewRule_Type = 104
+ SQLReviewRule_SYSTEM_VIEW_DISALLOW_CREATE SQLReviewRule_Type = 105
+ SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE SQLReviewRule_Type = 106
+ SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST SQLReviewRule_Type = 107
+ SQLReviewRule_ADVICE_ONLINE_MIGRATION SQLReviewRule_Type = 108
+ SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK SQLReviewRule_Type = 109
+)
+
+// Enum value maps for SQLReviewRule_Type.
+var (
+ SQLReviewRule_Type_name = map[int32]string{
+ 0: "TYPE_UNSPECIFIED",
+ 1: "ENGINE_MYSQL_USE_INNODB",
+ 2: "NAMING_FULLY_QUALIFIED",
+ 3: "NAMING_TABLE",
+ 4: "NAMING_COLUMN",
+ 5: "NAMING_INDEX_PK",
+ 6: "NAMING_INDEX_UK",
+ 7: "NAMING_INDEX_FK",
+ 8: "NAMING_INDEX_IDX",
+ 9: "NAMING_COLUMN_AUTO_INCREMENT",
+ 10: "NAMING_TABLE_NO_KEYWORD",
+ 11: "NAMING_IDENTIFIER_NO_KEYWORD",
+ 12: "NAMING_IDENTIFIER_CASE",
+ 13: "STATEMENT_SELECT_NO_SELECT_ALL",
+ 14: "STATEMENT_WHERE_REQUIRE_SELECT",
+ 15: "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE",
+ 16: "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE",
+ 17: "STATEMENT_DISALLOW_ON_DEL_CASCADE",
+ 18: "STATEMENT_DISALLOW_RM_TBL_CASCADE",
+ 19: "STATEMENT_DISALLOW_COMMIT",
+ 20: "STATEMENT_DISALLOW_LIMIT",
+ 21: "STATEMENT_DISALLOW_ORDER_BY",
+ 22: "STATEMENT_MERGE_ALTER_TABLE",
+ 23: "STATEMENT_INSERT_ROW_LIMIT",
+ 24: "STATEMENT_INSERT_MUST_SPECIFY_COLUMN",
+ 25: "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND",
+ 26: "STATEMENT_AFFECTED_ROW_LIMIT",
+ 27: "STATEMENT_DML_DRY_RUN",
+ 28: "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT",
+ 29: "STATEMENT_ADD_CHECK_NOT_VALID",
+ 30: "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID",
+ 31: "STATEMENT_DISALLOW_ADD_NOT_NULL",
+ 32: "STATEMENT_SELECT_FULL_TABLE_SCAN",
+ 33: "STATEMENT_CREATE_SPECIFY_SCHEMA",
+ 34: "STATEMENT_CHECK_SET_ROLE_VARIABLE",
+ 35: "STATEMENT_DISALLOW_USING_FILESORT",
+ 36: "STATEMENT_DISALLOW_USING_TEMPORARY",
+ 37: "STATEMENT_WHERE_NO_EQUAL_NULL",
+ 38: "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS",
+ 39: "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL",
+ 40: "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT",
+ 41: "STATEMENT_MAXIMUM_LIMIT_VALUE",
+ 42: "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT",
+ 43: "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION",
+ 44: "STATEMENT_JOIN_STRICT_COLUMN_ATTRS",
+ 45: "STATEMENT_NON_TRANSACTIONAL",
+ 46: "STATEMENT_ADD_COLUMN_WITHOUT_POSITION",
+ 47: "STATEMENT_DISALLOW_OFFLINE_DDL",
+ 48: "STATEMENT_DISALLOW_CROSS_DB_QUERIES",
+ 49: "STATEMENT_MAX_EXECUTION_TIME",
+ 50: "STATEMENT_REQUIRE_ALGORITHM_OPTION",
+ 51: "STATEMENT_REQUIRE_LOCK_OPTION",
+ 52: "STATEMENT_OBJECT_OWNER_CHECK",
+ 53: "TABLE_REQUIRE_PK",
+ 54: "TABLE_NO_FOREIGN_KEY",
+ 55: "TABLE_DROP_NAMING_CONVENTION",
+ 56: "TABLE_COMMENT",
+ 57: "TABLE_DISALLOW_PARTITION",
+ 58: "TABLE_DISALLOW_TRIGGER",
+ 59: "TABLE_NO_DUPLICATE_INDEX",
+ 60: "TABLE_TEXT_FIELDS_TOTAL_LENGTH",
+ 61: "TABLE_DISALLOW_SET_CHARSET",
+ 62: "TABLE_DISALLOW_DDL",
+ 63: "TABLE_DISALLOW_DML",
+ 64: "TABLE_LIMIT_SIZE",
+ 65: "TABLE_REQUIRE_CHARSET",
+ 66: "TABLE_REQUIRE_COLLATION",
+ 67: "COLUMN_REQUIRED",
+ 68: "COLUMN_NO_NULL",
+ 69: "COLUMN_DISALLOW_CHANGE_TYPE",
+ 70: "COLUMN_SET_DEFAULT_FOR_NOT_NULL",
+ 71: "COLUMN_DISALLOW_CHANGE",
+ 72: "COLUMN_DISALLOW_CHANGING_ORDER",
+ 73: "COLUMN_DISALLOW_DROP",
+ 74: "COLUMN_DISALLOW_DROP_IN_INDEX",
+ 75: "COLUMN_COMMENT",
+ 76: "COLUMN_AUTO_INCREMENT_MUST_INTEGER",
+ 77: "COLUMN_TYPE_DISALLOW_LIST",
+ 78: "COLUMN_DISALLOW_SET_CHARSET",
+ 79: "COLUMN_MAXIMUM_CHARACTER_LENGTH",
+ 80: "COLUMN_MAXIMUM_VARCHAR_LENGTH",
+ 81: "COLUMN_AUTO_INCREMENT_INITIAL_VALUE",
+ 82: "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED",
+ 83: "COLUMN_CURRENT_TIME_COUNT_LIMIT",
+ 84: "COLUMN_REQUIRE_DEFAULT",
+ 85: "COLUMN_DEFAULT_DISALLOW_VOLATILE",
+ 86: "COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT",
+ 87: "COLUMN_REQUIRE_CHARSET",
+ 88: "COLUMN_REQUIRE_COLLATION",
+ 89: "SCHEMA_BACKWARD_COMPATIBILITY",
+ 90: "DATABASE_DROP_EMPTY_DATABASE",
+ 91: "INDEX_NO_DUPLICATE_COLUMN",
+ 92: "INDEX_KEY_NUMBER_LIMIT",
+ 93: "INDEX_PK_TYPE_LIMIT",
+ 94: "INDEX_TYPE_NO_BLOB",
+ 95: "INDEX_TOTAL_NUMBER_LIMIT",
+ 96: "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST",
+ 97: "INDEX_CREATE_CONCURRENTLY",
+ 98: "INDEX_TYPE_ALLOW_LIST",
+ 99: "INDEX_NOT_REDUNDANT",
+ 100: "SYSTEM_CHARSET_ALLOWLIST",
+ 101: "SYSTEM_COLLATION_ALLOWLIST",
+ 102: "SYSTEM_COMMENT_LENGTH",
+ 103: "SYSTEM_PROCEDURE_DISALLOW_CREATE",
+ 104: "SYSTEM_EVENT_DISALLOW_CREATE",
+ 105: "SYSTEM_VIEW_DISALLOW_CREATE",
+ 106: "SYSTEM_FUNCTION_DISALLOW_CREATE",
+ 107: "SYSTEM_FUNCTION_DISALLOWED_LIST",
+ 108: "ADVICE_ONLINE_MIGRATION",
+ 109: "BUILTIN_PRIOR_BACKUP_CHECK",
+ }
+ SQLReviewRule_Type_value = map[string]int32{
+ "TYPE_UNSPECIFIED": 0,
+ "ENGINE_MYSQL_USE_INNODB": 1,
+ "NAMING_FULLY_QUALIFIED": 2,
+ "NAMING_TABLE": 3,
+ "NAMING_COLUMN": 4,
+ "NAMING_INDEX_PK": 5,
+ "NAMING_INDEX_UK": 6,
+ "NAMING_INDEX_FK": 7,
+ "NAMING_INDEX_IDX": 8,
+ "NAMING_COLUMN_AUTO_INCREMENT": 9,
+ "NAMING_TABLE_NO_KEYWORD": 10,
+ "NAMING_IDENTIFIER_NO_KEYWORD": 11,
+ "NAMING_IDENTIFIER_CASE": 12,
+ "STATEMENT_SELECT_NO_SELECT_ALL": 13,
+ "STATEMENT_WHERE_REQUIRE_SELECT": 14,
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": 15,
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": 16,
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": 17,
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": 18,
+ "STATEMENT_DISALLOW_COMMIT": 19,
+ "STATEMENT_DISALLOW_LIMIT": 20,
+ "STATEMENT_DISALLOW_ORDER_BY": 21,
+ "STATEMENT_MERGE_ALTER_TABLE": 22,
+ "STATEMENT_INSERT_ROW_LIMIT": 23,
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": 24,
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": 25,
+ "STATEMENT_AFFECTED_ROW_LIMIT": 26,
+ "STATEMENT_DML_DRY_RUN": 27,
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": 28,
+ "STATEMENT_ADD_CHECK_NOT_VALID": 29,
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": 30,
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": 31,
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": 32,
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": 33,
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": 34,
+ "STATEMENT_DISALLOW_USING_FILESORT": 35,
+ "STATEMENT_DISALLOW_USING_TEMPORARY": 36,
+ "STATEMENT_WHERE_NO_EQUAL_NULL": 37,
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": 38,
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": 39,
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": 40,
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": 41,
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": 42,
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": 43,
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": 44,
+ "STATEMENT_NON_TRANSACTIONAL": 45,
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": 46,
+ "STATEMENT_DISALLOW_OFFLINE_DDL": 47,
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": 48,
+ "STATEMENT_MAX_EXECUTION_TIME": 49,
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": 50,
+ "STATEMENT_REQUIRE_LOCK_OPTION": 51,
+ "STATEMENT_OBJECT_OWNER_CHECK": 52,
+ "TABLE_REQUIRE_PK": 53,
+ "TABLE_NO_FOREIGN_KEY": 54,
+ "TABLE_DROP_NAMING_CONVENTION": 55,
+ "TABLE_COMMENT": 56,
+ "TABLE_DISALLOW_PARTITION": 57,
+ "TABLE_DISALLOW_TRIGGER": 58,
+ "TABLE_NO_DUPLICATE_INDEX": 59,
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": 60,
+ "TABLE_DISALLOW_SET_CHARSET": 61,
+ "TABLE_DISALLOW_DDL": 62,
+ "TABLE_DISALLOW_DML": 63,
+ "TABLE_LIMIT_SIZE": 64,
+ "TABLE_REQUIRE_CHARSET": 65,
+ "TABLE_REQUIRE_COLLATION": 66,
+ "COLUMN_REQUIRED": 67,
+ "COLUMN_NO_NULL": 68,
+ "COLUMN_DISALLOW_CHANGE_TYPE": 69,
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": 70,
+ "COLUMN_DISALLOW_CHANGE": 71,
+ "COLUMN_DISALLOW_CHANGING_ORDER": 72,
+ "COLUMN_DISALLOW_DROP": 73,
+ "COLUMN_DISALLOW_DROP_IN_INDEX": 74,
+ "COLUMN_COMMENT": 75,
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": 76,
+ "COLUMN_TYPE_DISALLOW_LIST": 77,
+ "COLUMN_DISALLOW_SET_CHARSET": 78,
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": 79,
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": 80,
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": 81,
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": 82,
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": 83,
+ "COLUMN_REQUIRE_DEFAULT": 84,
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": 85,
+ "COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT": 86,
+ "COLUMN_REQUIRE_CHARSET": 87,
+ "COLUMN_REQUIRE_COLLATION": 88,
+ "SCHEMA_BACKWARD_COMPATIBILITY": 89,
+ "DATABASE_DROP_EMPTY_DATABASE": 90,
+ "INDEX_NO_DUPLICATE_COLUMN": 91,
+ "INDEX_KEY_NUMBER_LIMIT": 92,
+ "INDEX_PK_TYPE_LIMIT": 93,
+ "INDEX_TYPE_NO_BLOB": 94,
+ "INDEX_TOTAL_NUMBER_LIMIT": 95,
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": 96,
+ "INDEX_CREATE_CONCURRENTLY": 97,
+ "INDEX_TYPE_ALLOW_LIST": 98,
+ "INDEX_NOT_REDUNDANT": 99,
+ "SYSTEM_CHARSET_ALLOWLIST": 100,
+ "SYSTEM_COLLATION_ALLOWLIST": 101,
+ "SYSTEM_COMMENT_LENGTH": 102,
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": 103,
+ "SYSTEM_EVENT_DISALLOW_CREATE": 104,
+ "SYSTEM_VIEW_DISALLOW_CREATE": 105,
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": 106,
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": 107,
+ "ADVICE_ONLINE_MIGRATION": 108,
+ "BUILTIN_PRIOR_BACKUP_CHECK": 109,
+ }
+)
+
+func (x SQLReviewRule_Type) Enum() *SQLReviewRule_Type {
+ p := new(SQLReviewRule_Type)
+ *p = x
+ return p
+}
+
+func (x SQLReviewRule_Type) String() string {
+ return protoimpl.X.EnumStringOf(x.Descriptor(), protoreflect.EnumNumber(x))
+}
+
+func (SQLReviewRule_Type) Descriptor() protoreflect.EnumDescriptor {
+ return file_store_review_config_proto_enumTypes[1].Descriptor()
+}
+
+func (SQLReviewRule_Type) Type() protoreflect.EnumType {
+ return &file_store_review_config_proto_enumTypes[1]
+}
+
+func (x SQLReviewRule_Type) Number() protoreflect.EnumNumber {
+ return protoreflect.EnumNumber(x)
+}
+
+// Deprecated: Use SQLReviewRule_Type.Descriptor instead.
+func (SQLReviewRule_Type) EnumDescriptor() ([]byte, []int) {
+ return file_store_review_config_proto_rawDescGZIP(), []int{1, 1}
+}
+
type ReviewConfigPayload struct {
state protoimpl.MessageState `protogen:"open.v1"`
SqlReviewRules []*SQLReviewRule `protobuf:"bytes,1,rep,name=sql_review_rules,json=sqlReviewRules,proto3" json:"sql_review_rules,omitempty"`
@@ -120,7 +490,7 @@ func (x *ReviewConfigPayload) GetSqlReviewRules() []*SQLReviewRule {
type SQLReviewRule struct {
state protoimpl.MessageState `protogen:"open.v1"`
- Type string `protobuf:"bytes,1,opt,name=type,proto3" json:"type,omitempty"`
+ Type SQLReviewRule_Type `protobuf:"varint,1,opt,name=type,proto3,enum=bytebase.store.SQLReviewRule_Type" json:"type,omitempty"`
Level SQLReviewRule_Level `protobuf:"varint,2,opt,name=level,proto3,enum=bytebase.store.SQLReviewRule_Level" json:"level,omitempty"`
Payload string `protobuf:"bytes,3,opt,name=payload,proto3" json:"payload,omitempty"`
Engine Engine `protobuf:"varint,4,opt,name=engine,proto3,enum=bytebase.store.Engine" json:"engine,omitempty"`
@@ -158,11 +528,11 @@ func (*SQLReviewRule) Descriptor() ([]byte, []int) {
return file_store_review_config_proto_rawDescGZIP(), []int{1}
}
-func (x *SQLReviewRule) GetType() string {
+func (x *SQLReviewRule) GetType() SQLReviewRule_Type {
if x != nil {
return x.Type
}
- return ""
+ return SQLReviewRule_TYPE_UNSPECIFIED
}
func (x *SQLReviewRule) GetLevel() SQLReviewRule_Level {
@@ -192,16 +562,128 @@ const file_store_review_config_proto_rawDesc = "" +
"\n" +
"\x19store/review_config.proto\x12\x0ebytebase.store\x1a\x12store/common.proto\"^\n" +
"\x13ReviewConfigPayload\x12G\n" +
- "\x10sql_review_rules\x18\x01 \x03(\v2\x1d.bytebase.store.SQLReviewRuleR\x0esqlReviewRules\"\xe0\x01\n" +
- "\rSQLReviewRule\x12\x12\n" +
- "\x04type\x18\x01 \x01(\tR\x04type\x129\n" +
+ "\x10sql_review_rules\x18\x01 \x03(\v2\x1d.bytebase.store.SQLReviewRuleR\x0esqlReviewRules\"\xb7\x1e\n" +
+ "\rSQLReviewRule\x126\n" +
+ "\x04type\x18\x01 \x01(\x0e2\".bytebase.store.SQLReviewRule.TypeR\x04type\x129\n" +
"\x05level\x18\x02 \x01(\x0e2#.bytebase.store.SQLReviewRule.LevelR\x05level\x12\x18\n" +
"\apayload\x18\x03 \x01(\tR\apayload\x12.\n" +
"\x06engine\x18\x04 \x01(\x0e2\x16.bytebase.store.EngineR\x06engine\"6\n" +
"\x05Level\x12\x15\n" +
"\x11LEVEL_UNSPECIFIED\x10\x00\x12\t\n" +
"\x05ERROR\x10\x01\x12\v\n" +
- "\aWARNING\x10\x02B\x94\x01\n" +
+ "\aWARNING\x10\x02\"\xb0\x1c\n" +
+ "\x04Type\x12\x14\n" +
+ "\x10TYPE_UNSPECIFIED\x10\x00\x12\x1b\n" +
+ "\x17ENGINE_MYSQL_USE_INNODB\x10\x01\x12\x1a\n" +
+ "\x16NAMING_FULLY_QUALIFIED\x10\x02\x12\x10\n" +
+ "\fNAMING_TABLE\x10\x03\x12\x11\n" +
+ "\rNAMING_COLUMN\x10\x04\x12\x13\n" +
+ "\x0fNAMING_INDEX_PK\x10\x05\x12\x13\n" +
+ "\x0fNAMING_INDEX_UK\x10\x06\x12\x13\n" +
+ "\x0fNAMING_INDEX_FK\x10\a\x12\x14\n" +
+ "\x10NAMING_INDEX_IDX\x10\b\x12 \n" +
+ "\x1cNAMING_COLUMN_AUTO_INCREMENT\x10\t\x12\x1b\n" +
+ "\x17NAMING_TABLE_NO_KEYWORD\x10\n" +
+ "\x12 \n" +
+ "\x1cNAMING_IDENTIFIER_NO_KEYWORD\x10\v\x12\x1a\n" +
+ "\x16NAMING_IDENTIFIER_CASE\x10\f\x12\"\n" +
+ "\x1eSTATEMENT_SELECT_NO_SELECT_ALL\x10\r\x12\"\n" +
+ "\x1eSTATEMENT_WHERE_REQUIRE_SELECT\x10\x0e\x12)\n" +
+ "%STATEMENT_WHERE_REQUIRE_UPDATE_DELETE\x10\x0f\x12,\n" +
+ "(STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE\x10\x10\x12%\n" +
+ "!STATEMENT_DISALLOW_ON_DEL_CASCADE\x10\x11\x12%\n" +
+ "!STATEMENT_DISALLOW_RM_TBL_CASCADE\x10\x12\x12\x1d\n" +
+ "\x19STATEMENT_DISALLOW_COMMIT\x10\x13\x12\x1c\n" +
+ "\x18STATEMENT_DISALLOW_LIMIT\x10\x14\x12\x1f\n" +
+ "\x1bSTATEMENT_DISALLOW_ORDER_BY\x10\x15\x12\x1f\n" +
+ "\x1bSTATEMENT_MERGE_ALTER_TABLE\x10\x16\x12\x1e\n" +
+ "\x1aSTATEMENT_INSERT_ROW_LIMIT\x10\x17\x12(\n" +
+ "$STATEMENT_INSERT_MUST_SPECIFY_COLUMN\x10\x18\x12+\n" +
+ "'STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND\x10\x19\x12 \n" +
+ "\x1cSTATEMENT_AFFECTED_ROW_LIMIT\x10\x1a\x12\x19\n" +
+ "\x15STATEMENT_DML_DRY_RUN\x10\x1b\x12.\n" +
+ "*STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT\x10\x1c\x12!\n" +
+ "\x1dSTATEMENT_ADD_CHECK_NOT_VALID\x10\x1d\x12'\n" +
+ "#STATEMENT_ADD_FOREIGN_KEY_NOT_VALID\x10\x1e\x12#\n" +
+ "\x1fSTATEMENT_DISALLOW_ADD_NOT_NULL\x10\x1f\x12$\n" +
+ " STATEMENT_SELECT_FULL_TABLE_SCAN\x10 \x12#\n" +
+ "\x1fSTATEMENT_CREATE_SPECIFY_SCHEMA\x10!\x12%\n" +
+ "!STATEMENT_CHECK_SET_ROLE_VARIABLE\x10\"\x12%\n" +
+ "!STATEMENT_DISALLOW_USING_FILESORT\x10#\x12&\n" +
+ "\"STATEMENT_DISALLOW_USING_TEMPORARY\x10$\x12!\n" +
+ "\x1dSTATEMENT_WHERE_NO_EQUAL_NULL\x10%\x127\n" +
+ "3STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS\x10&\x12&\n" +
+ "\"STATEMENT_QUERY_MINIMUM_PLAN_LEVEL\x10'\x122\n" +
+ ".STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT\x10(\x12!\n" +
+ "\x1dSTATEMENT_MAXIMUM_LIMIT_VALUE\x10)\x12&\n" +
+ "\"STATEMENT_MAXIMUM_JOIN_TABLE_COUNT\x10*\x12/\n" +
+ "+STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION\x10+\x12&\n" +
+ "\"STATEMENT_JOIN_STRICT_COLUMN_ATTRS\x10,\x12\x1f\n" +
+ "\x1bSTATEMENT_NON_TRANSACTIONAL\x10-\x12)\n" +
+ "%STATEMENT_ADD_COLUMN_WITHOUT_POSITION\x10.\x12\"\n" +
+ "\x1eSTATEMENT_DISALLOW_OFFLINE_DDL\x10/\x12'\n" +
+ "#STATEMENT_DISALLOW_CROSS_DB_QUERIES\x100\x12 \n" +
+ "\x1cSTATEMENT_MAX_EXECUTION_TIME\x101\x12&\n" +
+ "\"STATEMENT_REQUIRE_ALGORITHM_OPTION\x102\x12!\n" +
+ "\x1dSTATEMENT_REQUIRE_LOCK_OPTION\x103\x12 \n" +
+ "\x1cSTATEMENT_OBJECT_OWNER_CHECK\x104\x12\x14\n" +
+ "\x10TABLE_REQUIRE_PK\x105\x12\x18\n" +
+ "\x14TABLE_NO_FOREIGN_KEY\x106\x12 \n" +
+ "\x1cTABLE_DROP_NAMING_CONVENTION\x107\x12\x11\n" +
+ "\rTABLE_COMMENT\x108\x12\x1c\n" +
+ "\x18TABLE_DISALLOW_PARTITION\x109\x12\x1a\n" +
+ "\x16TABLE_DISALLOW_TRIGGER\x10:\x12\x1c\n" +
+ "\x18TABLE_NO_DUPLICATE_INDEX\x10;\x12\"\n" +
+ "\x1eTABLE_TEXT_FIELDS_TOTAL_LENGTH\x10<\x12\x1e\n" +
+ "\x1aTABLE_DISALLOW_SET_CHARSET\x10=\x12\x16\n" +
+ "\x12TABLE_DISALLOW_DDL\x10>\x12\x16\n" +
+ "\x12TABLE_DISALLOW_DML\x10?\x12\x14\n" +
+ "\x10TABLE_LIMIT_SIZE\x10@\x12\x19\n" +
+ "\x15TABLE_REQUIRE_CHARSET\x10A\x12\x1b\n" +
+ "\x17TABLE_REQUIRE_COLLATION\x10B\x12\x13\n" +
+ "\x0fCOLUMN_REQUIRED\x10C\x12\x12\n" +
+ "\x0eCOLUMN_NO_NULL\x10D\x12\x1f\n" +
+ "\x1bCOLUMN_DISALLOW_CHANGE_TYPE\x10E\x12#\n" +
+ "\x1fCOLUMN_SET_DEFAULT_FOR_NOT_NULL\x10F\x12\x1a\n" +
+ "\x16COLUMN_DISALLOW_CHANGE\x10G\x12\"\n" +
+ "\x1eCOLUMN_DISALLOW_CHANGING_ORDER\x10H\x12\x18\n" +
+ "\x14COLUMN_DISALLOW_DROP\x10I\x12!\n" +
+ "\x1dCOLUMN_DISALLOW_DROP_IN_INDEX\x10J\x12\x12\n" +
+ "\x0eCOLUMN_COMMENT\x10K\x12&\n" +
+ "\"COLUMN_AUTO_INCREMENT_MUST_INTEGER\x10L\x12\x1d\n" +
+ "\x19COLUMN_TYPE_DISALLOW_LIST\x10M\x12\x1f\n" +
+ "\x1bCOLUMN_DISALLOW_SET_CHARSET\x10N\x12#\n" +
+ "\x1fCOLUMN_MAXIMUM_CHARACTER_LENGTH\x10O\x12!\n" +
+ "\x1dCOLUMN_MAXIMUM_VARCHAR_LENGTH\x10P\x12'\n" +
+ "#COLUMN_AUTO_INCREMENT_INITIAL_VALUE\x10Q\x12'\n" +
+ "#COLUMN_AUTO_INCREMENT_MUST_UNSIGNED\x10R\x12#\n" +
+ "\x1fCOLUMN_CURRENT_TIME_COUNT_LIMIT\x10S\x12\x1a\n" +
+ "\x16COLUMN_REQUIRE_DEFAULT\x10T\x12$\n" +
+ " COLUMN_DEFAULT_DISALLOW_VOLATILE\x10U\x12'\n" +
+ "#COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT\x10V\x12\x1a\n" +
+ "\x16COLUMN_REQUIRE_CHARSET\x10W\x12\x1c\n" +
+ "\x18COLUMN_REQUIRE_COLLATION\x10X\x12!\n" +
+ "\x1dSCHEMA_BACKWARD_COMPATIBILITY\x10Y\x12 \n" +
+ "\x1cDATABASE_DROP_EMPTY_DATABASE\x10Z\x12\x1d\n" +
+ "\x19INDEX_NO_DUPLICATE_COLUMN\x10[\x12\x1a\n" +
+ "\x16INDEX_KEY_NUMBER_LIMIT\x10\\\x12\x17\n" +
+ "\x13INDEX_PK_TYPE_LIMIT\x10]\x12\x16\n" +
+ "\x12INDEX_TYPE_NO_BLOB\x10^\x12\x1c\n" +
+ "\x18INDEX_TOTAL_NUMBER_LIMIT\x10_\x12$\n" +
+ " INDEX_PRIMARY_KEY_TYPE_ALLOWLIST\x10`\x12\x1d\n" +
+ "\x19INDEX_CREATE_CONCURRENTLY\x10a\x12\x19\n" +
+ "\x15INDEX_TYPE_ALLOW_LIST\x10b\x12\x17\n" +
+ "\x13INDEX_NOT_REDUNDANT\x10c\x12\x1c\n" +
+ "\x18SYSTEM_CHARSET_ALLOWLIST\x10d\x12\x1e\n" +
+ "\x1aSYSTEM_COLLATION_ALLOWLIST\x10e\x12\x19\n" +
+ "\x15SYSTEM_COMMENT_LENGTH\x10f\x12$\n" +
+ " SYSTEM_PROCEDURE_DISALLOW_CREATE\x10g\x12 \n" +
+ "\x1cSYSTEM_EVENT_DISALLOW_CREATE\x10h\x12\x1f\n" +
+ "\x1bSYSTEM_VIEW_DISALLOW_CREATE\x10i\x12#\n" +
+ "\x1fSYSTEM_FUNCTION_DISALLOW_CREATE\x10j\x12#\n" +
+ "\x1fSYSTEM_FUNCTION_DISALLOWED_LIST\x10k\x12\x1b\n" +
+ "\x17ADVICE_ONLINE_MIGRATION\x10l\x12\x1e\n" +
+ "\x1aBUILTIN_PRIOR_BACKUP_CHECK\x10mB\x94\x01\n" +
"\x12com.bytebase.storeB\x11ReviewConfigProtoP\x01Z\x12generated-go/store\xa2\x02\x03BSX\xaa\x02\x0eBytebase.Store\xca\x02\x0eBytebase\\Store\xe2\x02\x1aBytebase\\Store\\GPBMetadata\xea\x02\x0fBytebase::Storeb\x06proto3"
var (
@@ -216,23 +698,25 @@ func file_store_review_config_proto_rawDescGZIP() []byte {
return file_store_review_config_proto_rawDescData
}
-var file_store_review_config_proto_enumTypes = make([]protoimpl.EnumInfo, 1)
+var file_store_review_config_proto_enumTypes = make([]protoimpl.EnumInfo, 2)
var file_store_review_config_proto_msgTypes = make([]protoimpl.MessageInfo, 2)
var file_store_review_config_proto_goTypes = []any{
(SQLReviewRule_Level)(0), // 0: bytebase.store.SQLReviewRule.Level
- (*ReviewConfigPayload)(nil), // 1: bytebase.store.ReviewConfigPayload
- (*SQLReviewRule)(nil), // 2: bytebase.store.SQLReviewRule
- (Engine)(0), // 3: bytebase.store.Engine
+ (SQLReviewRule_Type)(0), // 1: bytebase.store.SQLReviewRule.Type
+ (*ReviewConfigPayload)(nil), // 2: bytebase.store.ReviewConfigPayload
+ (*SQLReviewRule)(nil), // 3: bytebase.store.SQLReviewRule
+ (Engine)(0), // 4: bytebase.store.Engine
}
var file_store_review_config_proto_depIdxs = []int32{
- 2, // 0: bytebase.store.ReviewConfigPayload.sql_review_rules:type_name -> bytebase.store.SQLReviewRule
- 0, // 1: bytebase.store.SQLReviewRule.level:type_name -> bytebase.store.SQLReviewRule.Level
- 3, // 2: bytebase.store.SQLReviewRule.engine:type_name -> bytebase.store.Engine
- 3, // [3:3] is the sub-list for method output_type
- 3, // [3:3] is the sub-list for method input_type
- 3, // [3:3] is the sub-list for extension type_name
- 3, // [3:3] is the sub-list for extension extendee
- 0, // [0:3] is the sub-list for field type_name
+ 3, // 0: bytebase.store.ReviewConfigPayload.sql_review_rules:type_name -> bytebase.store.SQLReviewRule
+ 1, // 1: bytebase.store.SQLReviewRule.type:type_name -> bytebase.store.SQLReviewRule.Type
+ 0, // 2: bytebase.store.SQLReviewRule.level:type_name -> bytebase.store.SQLReviewRule.Level
+ 4, // 3: bytebase.store.SQLReviewRule.engine:type_name -> bytebase.store.Engine
+ 4, // [4:4] is the sub-list for method output_type
+ 4, // [4:4] is the sub-list for method input_type
+ 4, // [4:4] is the sub-list for extension type_name
+ 4, // [4:4] is the sub-list for extension extendee
+ 0, // [0:4] is the sub-list for field type_name
}
func init() { file_store_review_config_proto_init() }
@@ -246,7 +730,7 @@ func file_store_review_config_proto_init() {
File: protoimpl.DescBuilder{
GoPackagePath: reflect.TypeOf(x{}).PkgPath(),
RawDescriptor: unsafe.Slice(unsafe.StringData(file_store_review_config_proto_rawDesc), len(file_store_review_config_proto_rawDesc)),
- NumEnums: 1,
+ NumEnums: 2,
NumMessages: 2,
NumExtensions: 0,
NumServices: 0,
diff --git a/backend/generated-go/v1/review_config_service.pb.go b/backend/generated-go/v1/review_config_service.pb.go
index 7567abe08c..12e48ba710 100644
--- a/backend/generated-go/v1/review_config_service.pb.go
+++ b/backend/generated-go/v1/review_config_service.pb.go
@@ -78,6 +78,376 @@ func (SQLReviewRule_Level) EnumDescriptor() ([]byte, []int) {
return file_v1_review_config_service_proto_rawDescGZIP(), []int{7, 0}
}
+type SQLReviewRule_Type int32
+
+const (
+ SQLReviewRule_TYPE_UNSPECIFIED SQLReviewRule_Type = 0
+ SQLReviewRule_ENGINE_MYSQL_USE_INNODB SQLReviewRule_Type = 1
+ SQLReviewRule_NAMING_FULLY_QUALIFIED SQLReviewRule_Type = 2
+ SQLReviewRule_NAMING_TABLE SQLReviewRule_Type = 3
+ SQLReviewRule_NAMING_COLUMN SQLReviewRule_Type = 4
+ SQLReviewRule_NAMING_INDEX_PK SQLReviewRule_Type = 5
+ SQLReviewRule_NAMING_INDEX_UK SQLReviewRule_Type = 6
+ SQLReviewRule_NAMING_INDEX_FK SQLReviewRule_Type = 7
+ SQLReviewRule_NAMING_INDEX_IDX SQLReviewRule_Type = 8
+ SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT SQLReviewRule_Type = 9
+ SQLReviewRule_NAMING_TABLE_NO_KEYWORD SQLReviewRule_Type = 10
+ SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD SQLReviewRule_Type = 11
+ SQLReviewRule_NAMING_IDENTIFIER_CASE SQLReviewRule_Type = 12
+ SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL SQLReviewRule_Type = 13
+ SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT SQLReviewRule_Type = 14
+ SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE SQLReviewRule_Type = 15
+ SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE SQLReviewRule_Type = 16
+ SQLReviewRule_STATEMENT_DISALLOW_ON_DEL_CASCADE SQLReviewRule_Type = 17
+ SQLReviewRule_STATEMENT_DISALLOW_RM_TBL_CASCADE SQLReviewRule_Type = 18
+ SQLReviewRule_STATEMENT_DISALLOW_COMMIT SQLReviewRule_Type = 19
+ SQLReviewRule_STATEMENT_DISALLOW_LIMIT SQLReviewRule_Type = 20
+ SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY SQLReviewRule_Type = 21
+ SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE SQLReviewRule_Type = 22
+ SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT SQLReviewRule_Type = 23
+ SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN SQLReviewRule_Type = 24
+ SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND SQLReviewRule_Type = 25
+ SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT SQLReviewRule_Type = 26
+ SQLReviewRule_STATEMENT_DML_DRY_RUN SQLReviewRule_Type = 27
+ SQLReviewRule_STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT SQLReviewRule_Type = 28
+ SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID SQLReviewRule_Type = 29
+ SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID SQLReviewRule_Type = 30
+ SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL SQLReviewRule_Type = 31
+ SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN SQLReviewRule_Type = 32
+ SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA SQLReviewRule_Type = 33
+ SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE SQLReviewRule_Type = 34
+ SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT SQLReviewRule_Type = 35
+ SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY SQLReviewRule_Type = 36
+ SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL SQLReviewRule_Type = 37
+ SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS SQLReviewRule_Type = 38
+ SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL SQLReviewRule_Type = 39
+ SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT SQLReviewRule_Type = 40
+ SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE SQLReviewRule_Type = 41
+ SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT SQLReviewRule_Type = 42
+ SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION SQLReviewRule_Type = 43
+ SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS SQLReviewRule_Type = 44
+ SQLReviewRule_STATEMENT_NON_TRANSACTIONAL SQLReviewRule_Type = 45
+ SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION SQLReviewRule_Type = 46
+ SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL SQLReviewRule_Type = 47
+ SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES SQLReviewRule_Type = 48
+ SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME SQLReviewRule_Type = 49
+ SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION SQLReviewRule_Type = 50
+ SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION SQLReviewRule_Type = 51
+ SQLReviewRule_STATEMENT_OBJECT_OWNER_CHECK SQLReviewRule_Type = 52
+ SQLReviewRule_TABLE_REQUIRE_PK SQLReviewRule_Type = 53
+ SQLReviewRule_TABLE_NO_FOREIGN_KEY SQLReviewRule_Type = 54
+ SQLReviewRule_TABLE_DROP_NAMING_CONVENTION SQLReviewRule_Type = 55
+ SQLReviewRule_TABLE_COMMENT SQLReviewRule_Type = 56
+ SQLReviewRule_TABLE_DISALLOW_PARTITION SQLReviewRule_Type = 57
+ SQLReviewRule_TABLE_DISALLOW_TRIGGER SQLReviewRule_Type = 58
+ SQLReviewRule_TABLE_NO_DUPLICATE_INDEX SQLReviewRule_Type = 59
+ SQLReviewRule_TABLE_TEXT_FIELDS_TOTAL_LENGTH SQLReviewRule_Type = 60
+ SQLReviewRule_TABLE_DISALLOW_SET_CHARSET SQLReviewRule_Type = 61
+ SQLReviewRule_TABLE_DISALLOW_DDL SQLReviewRule_Type = 62
+ SQLReviewRule_TABLE_DISALLOW_DML SQLReviewRule_Type = 63
+ SQLReviewRule_TABLE_LIMIT_SIZE SQLReviewRule_Type = 64
+ SQLReviewRule_TABLE_REQUIRE_CHARSET SQLReviewRule_Type = 65
+ SQLReviewRule_TABLE_REQUIRE_COLLATION SQLReviewRule_Type = 66
+ SQLReviewRule_COLUMN_REQUIRED SQLReviewRule_Type = 67
+ SQLReviewRule_COLUMN_NO_NULL SQLReviewRule_Type = 68
+ SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE SQLReviewRule_Type = 69
+ SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL SQLReviewRule_Type = 70
+ SQLReviewRule_COLUMN_DISALLOW_CHANGE SQLReviewRule_Type = 71
+ SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER SQLReviewRule_Type = 72
+ SQLReviewRule_COLUMN_DISALLOW_DROP SQLReviewRule_Type = 73
+ SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX SQLReviewRule_Type = 74
+ SQLReviewRule_COLUMN_COMMENT SQLReviewRule_Type = 75
+ SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER SQLReviewRule_Type = 76
+ SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST SQLReviewRule_Type = 77
+ SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET SQLReviewRule_Type = 78
+ SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH SQLReviewRule_Type = 79
+ SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH SQLReviewRule_Type = 80
+ SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE SQLReviewRule_Type = 81
+ SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED SQLReviewRule_Type = 82
+ SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT SQLReviewRule_Type = 83
+ SQLReviewRule_COLUMN_REQUIRE_DEFAULT SQLReviewRule_Type = 84
+ SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE SQLReviewRule_Type = 85
+ SQLReviewRule_COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT SQLReviewRule_Type = 86
+ SQLReviewRule_COLUMN_REQUIRE_CHARSET SQLReviewRule_Type = 87
+ SQLReviewRule_COLUMN_REQUIRE_COLLATION SQLReviewRule_Type = 88
+ SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY SQLReviewRule_Type = 89
+ SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE SQLReviewRule_Type = 90
+ SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN SQLReviewRule_Type = 91
+ SQLReviewRule_INDEX_KEY_NUMBER_LIMIT SQLReviewRule_Type = 92
+ SQLReviewRule_INDEX_PK_TYPE_LIMIT SQLReviewRule_Type = 93
+ SQLReviewRule_INDEX_TYPE_NO_BLOB SQLReviewRule_Type = 94
+ SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT SQLReviewRule_Type = 95
+ SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST SQLReviewRule_Type = 96
+ SQLReviewRule_INDEX_CREATE_CONCURRENTLY SQLReviewRule_Type = 97
+ SQLReviewRule_INDEX_TYPE_ALLOW_LIST SQLReviewRule_Type = 98
+ SQLReviewRule_INDEX_NOT_REDUNDANT SQLReviewRule_Type = 99
+ SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST SQLReviewRule_Type = 100
+ SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST SQLReviewRule_Type = 101
+ SQLReviewRule_SYSTEM_COMMENT_LENGTH SQLReviewRule_Type = 102
+ SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE SQLReviewRule_Type = 103
+ SQLReviewRule_SYSTEM_EVENT_DISALLOW_CREATE SQLReviewRule_Type = 104
+ SQLReviewRule_SYSTEM_VIEW_DISALLOW_CREATE SQLReviewRule_Type = 105
+ SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE SQLReviewRule_Type = 106
+ SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST SQLReviewRule_Type = 107
+ SQLReviewRule_ADVICE_ONLINE_MIGRATION SQLReviewRule_Type = 108
+ SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK SQLReviewRule_Type = 109
+)
+
+// Enum value maps for SQLReviewRule_Type.
+var (
+ SQLReviewRule_Type_name = map[int32]string{
+ 0: "TYPE_UNSPECIFIED",
+ 1: "ENGINE_MYSQL_USE_INNODB",
+ 2: "NAMING_FULLY_QUALIFIED",
+ 3: "NAMING_TABLE",
+ 4: "NAMING_COLUMN",
+ 5: "NAMING_INDEX_PK",
+ 6: "NAMING_INDEX_UK",
+ 7: "NAMING_INDEX_FK",
+ 8: "NAMING_INDEX_IDX",
+ 9: "NAMING_COLUMN_AUTO_INCREMENT",
+ 10: "NAMING_TABLE_NO_KEYWORD",
+ 11: "NAMING_IDENTIFIER_NO_KEYWORD",
+ 12: "NAMING_IDENTIFIER_CASE",
+ 13: "STATEMENT_SELECT_NO_SELECT_ALL",
+ 14: "STATEMENT_WHERE_REQUIRE_SELECT",
+ 15: "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE",
+ 16: "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE",
+ 17: "STATEMENT_DISALLOW_ON_DEL_CASCADE",
+ 18: "STATEMENT_DISALLOW_RM_TBL_CASCADE",
+ 19: "STATEMENT_DISALLOW_COMMIT",
+ 20: "STATEMENT_DISALLOW_LIMIT",
+ 21: "STATEMENT_DISALLOW_ORDER_BY",
+ 22: "STATEMENT_MERGE_ALTER_TABLE",
+ 23: "STATEMENT_INSERT_ROW_LIMIT",
+ 24: "STATEMENT_INSERT_MUST_SPECIFY_COLUMN",
+ 25: "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND",
+ 26: "STATEMENT_AFFECTED_ROW_LIMIT",
+ 27: "STATEMENT_DML_DRY_RUN",
+ 28: "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT",
+ 29: "STATEMENT_ADD_CHECK_NOT_VALID",
+ 30: "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID",
+ 31: "STATEMENT_DISALLOW_ADD_NOT_NULL",
+ 32: "STATEMENT_SELECT_FULL_TABLE_SCAN",
+ 33: "STATEMENT_CREATE_SPECIFY_SCHEMA",
+ 34: "STATEMENT_CHECK_SET_ROLE_VARIABLE",
+ 35: "STATEMENT_DISALLOW_USING_FILESORT",
+ 36: "STATEMENT_DISALLOW_USING_TEMPORARY",
+ 37: "STATEMENT_WHERE_NO_EQUAL_NULL",
+ 38: "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS",
+ 39: "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL",
+ 40: "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT",
+ 41: "STATEMENT_MAXIMUM_LIMIT_VALUE",
+ 42: "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT",
+ 43: "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION",
+ 44: "STATEMENT_JOIN_STRICT_COLUMN_ATTRS",
+ 45: "STATEMENT_NON_TRANSACTIONAL",
+ 46: "STATEMENT_ADD_COLUMN_WITHOUT_POSITION",
+ 47: "STATEMENT_DISALLOW_OFFLINE_DDL",
+ 48: "STATEMENT_DISALLOW_CROSS_DB_QUERIES",
+ 49: "STATEMENT_MAX_EXECUTION_TIME",
+ 50: "STATEMENT_REQUIRE_ALGORITHM_OPTION",
+ 51: "STATEMENT_REQUIRE_LOCK_OPTION",
+ 52: "STATEMENT_OBJECT_OWNER_CHECK",
+ 53: "TABLE_REQUIRE_PK",
+ 54: "TABLE_NO_FOREIGN_KEY",
+ 55: "TABLE_DROP_NAMING_CONVENTION",
+ 56: "TABLE_COMMENT",
+ 57: "TABLE_DISALLOW_PARTITION",
+ 58: "TABLE_DISALLOW_TRIGGER",
+ 59: "TABLE_NO_DUPLICATE_INDEX",
+ 60: "TABLE_TEXT_FIELDS_TOTAL_LENGTH",
+ 61: "TABLE_DISALLOW_SET_CHARSET",
+ 62: "TABLE_DISALLOW_DDL",
+ 63: "TABLE_DISALLOW_DML",
+ 64: "TABLE_LIMIT_SIZE",
+ 65: "TABLE_REQUIRE_CHARSET",
+ 66: "TABLE_REQUIRE_COLLATION",
+ 67: "COLUMN_REQUIRED",
+ 68: "COLUMN_NO_NULL",
+ 69: "COLUMN_DISALLOW_CHANGE_TYPE",
+ 70: "COLUMN_SET_DEFAULT_FOR_NOT_NULL",
+ 71: "COLUMN_DISALLOW_CHANGE",
+ 72: "COLUMN_DISALLOW_CHANGING_ORDER",
+ 73: "COLUMN_DISALLOW_DROP",
+ 74: "COLUMN_DISALLOW_DROP_IN_INDEX",
+ 75: "COLUMN_COMMENT",
+ 76: "COLUMN_AUTO_INCREMENT_MUST_INTEGER",
+ 77: "COLUMN_TYPE_DISALLOW_LIST",
+ 78: "COLUMN_DISALLOW_SET_CHARSET",
+ 79: "COLUMN_MAXIMUM_CHARACTER_LENGTH",
+ 80: "COLUMN_MAXIMUM_VARCHAR_LENGTH",
+ 81: "COLUMN_AUTO_INCREMENT_INITIAL_VALUE",
+ 82: "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED",
+ 83: "COLUMN_CURRENT_TIME_COUNT_LIMIT",
+ 84: "COLUMN_REQUIRE_DEFAULT",
+ 85: "COLUMN_DEFAULT_DISALLOW_VOLATILE",
+ 86: "COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT",
+ 87: "COLUMN_REQUIRE_CHARSET",
+ 88: "COLUMN_REQUIRE_COLLATION",
+ 89: "SCHEMA_BACKWARD_COMPATIBILITY",
+ 90: "DATABASE_DROP_EMPTY_DATABASE",
+ 91: "INDEX_NO_DUPLICATE_COLUMN",
+ 92: "INDEX_KEY_NUMBER_LIMIT",
+ 93: "INDEX_PK_TYPE_LIMIT",
+ 94: "INDEX_TYPE_NO_BLOB",
+ 95: "INDEX_TOTAL_NUMBER_LIMIT",
+ 96: "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST",
+ 97: "INDEX_CREATE_CONCURRENTLY",
+ 98: "INDEX_TYPE_ALLOW_LIST",
+ 99: "INDEX_NOT_REDUNDANT",
+ 100: "SYSTEM_CHARSET_ALLOWLIST",
+ 101: "SYSTEM_COLLATION_ALLOWLIST",
+ 102: "SYSTEM_COMMENT_LENGTH",
+ 103: "SYSTEM_PROCEDURE_DISALLOW_CREATE",
+ 104: "SYSTEM_EVENT_DISALLOW_CREATE",
+ 105: "SYSTEM_VIEW_DISALLOW_CREATE",
+ 106: "SYSTEM_FUNCTION_DISALLOW_CREATE",
+ 107: "SYSTEM_FUNCTION_DISALLOWED_LIST",
+ 108: "ADVICE_ONLINE_MIGRATION",
+ 109: "BUILTIN_PRIOR_BACKUP_CHECK",
+ }
+ SQLReviewRule_Type_value = map[string]int32{
+ "TYPE_UNSPECIFIED": 0,
+ "ENGINE_MYSQL_USE_INNODB": 1,
+ "NAMING_FULLY_QUALIFIED": 2,
+ "NAMING_TABLE": 3,
+ "NAMING_COLUMN": 4,
+ "NAMING_INDEX_PK": 5,
+ "NAMING_INDEX_UK": 6,
+ "NAMING_INDEX_FK": 7,
+ "NAMING_INDEX_IDX": 8,
+ "NAMING_COLUMN_AUTO_INCREMENT": 9,
+ "NAMING_TABLE_NO_KEYWORD": 10,
+ "NAMING_IDENTIFIER_NO_KEYWORD": 11,
+ "NAMING_IDENTIFIER_CASE": 12,
+ "STATEMENT_SELECT_NO_SELECT_ALL": 13,
+ "STATEMENT_WHERE_REQUIRE_SELECT": 14,
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": 15,
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": 16,
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": 17,
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": 18,
+ "STATEMENT_DISALLOW_COMMIT": 19,
+ "STATEMENT_DISALLOW_LIMIT": 20,
+ "STATEMENT_DISALLOW_ORDER_BY": 21,
+ "STATEMENT_MERGE_ALTER_TABLE": 22,
+ "STATEMENT_INSERT_ROW_LIMIT": 23,
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": 24,
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": 25,
+ "STATEMENT_AFFECTED_ROW_LIMIT": 26,
+ "STATEMENT_DML_DRY_RUN": 27,
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": 28,
+ "STATEMENT_ADD_CHECK_NOT_VALID": 29,
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": 30,
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": 31,
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": 32,
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": 33,
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": 34,
+ "STATEMENT_DISALLOW_USING_FILESORT": 35,
+ "STATEMENT_DISALLOW_USING_TEMPORARY": 36,
+ "STATEMENT_WHERE_NO_EQUAL_NULL": 37,
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": 38,
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": 39,
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": 40,
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": 41,
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": 42,
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": 43,
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": 44,
+ "STATEMENT_NON_TRANSACTIONAL": 45,
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": 46,
+ "STATEMENT_DISALLOW_OFFLINE_DDL": 47,
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": 48,
+ "STATEMENT_MAX_EXECUTION_TIME": 49,
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": 50,
+ "STATEMENT_REQUIRE_LOCK_OPTION": 51,
+ "STATEMENT_OBJECT_OWNER_CHECK": 52,
+ "TABLE_REQUIRE_PK": 53,
+ "TABLE_NO_FOREIGN_KEY": 54,
+ "TABLE_DROP_NAMING_CONVENTION": 55,
+ "TABLE_COMMENT": 56,
+ "TABLE_DISALLOW_PARTITION": 57,
+ "TABLE_DISALLOW_TRIGGER": 58,
+ "TABLE_NO_DUPLICATE_INDEX": 59,
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": 60,
+ "TABLE_DISALLOW_SET_CHARSET": 61,
+ "TABLE_DISALLOW_DDL": 62,
+ "TABLE_DISALLOW_DML": 63,
+ "TABLE_LIMIT_SIZE": 64,
+ "TABLE_REQUIRE_CHARSET": 65,
+ "TABLE_REQUIRE_COLLATION": 66,
+ "COLUMN_REQUIRED": 67,
+ "COLUMN_NO_NULL": 68,
+ "COLUMN_DISALLOW_CHANGE_TYPE": 69,
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": 70,
+ "COLUMN_DISALLOW_CHANGE": 71,
+ "COLUMN_DISALLOW_CHANGING_ORDER": 72,
+ "COLUMN_DISALLOW_DROP": 73,
+ "COLUMN_DISALLOW_DROP_IN_INDEX": 74,
+ "COLUMN_COMMENT": 75,
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": 76,
+ "COLUMN_TYPE_DISALLOW_LIST": 77,
+ "COLUMN_DISALLOW_SET_CHARSET": 78,
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": 79,
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": 80,
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": 81,
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": 82,
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": 83,
+ "COLUMN_REQUIRE_DEFAULT": 84,
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": 85,
+ "COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT": 86,
+ "COLUMN_REQUIRE_CHARSET": 87,
+ "COLUMN_REQUIRE_COLLATION": 88,
+ "SCHEMA_BACKWARD_COMPATIBILITY": 89,
+ "DATABASE_DROP_EMPTY_DATABASE": 90,
+ "INDEX_NO_DUPLICATE_COLUMN": 91,
+ "INDEX_KEY_NUMBER_LIMIT": 92,
+ "INDEX_PK_TYPE_LIMIT": 93,
+ "INDEX_TYPE_NO_BLOB": 94,
+ "INDEX_TOTAL_NUMBER_LIMIT": 95,
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": 96,
+ "INDEX_CREATE_CONCURRENTLY": 97,
+ "INDEX_TYPE_ALLOW_LIST": 98,
+ "INDEX_NOT_REDUNDANT": 99,
+ "SYSTEM_CHARSET_ALLOWLIST": 100,
+ "SYSTEM_COLLATION_ALLOWLIST": 101,
+ "SYSTEM_COMMENT_LENGTH": 102,
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": 103,
+ "SYSTEM_EVENT_DISALLOW_CREATE": 104,
+ "SYSTEM_VIEW_DISALLOW_CREATE": 105,
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": 106,
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": 107,
+ "ADVICE_ONLINE_MIGRATION": 108,
+ "BUILTIN_PRIOR_BACKUP_CHECK": 109,
+ }
+)
+
+func (x SQLReviewRule_Type) Enum() *SQLReviewRule_Type {
+ p := new(SQLReviewRule_Type)
+ *p = x
+ return p
+}
+
+func (x SQLReviewRule_Type) String() string {
+ return protoimpl.X.EnumStringOf(x.Descriptor(), protoreflect.EnumNumber(x))
+}
+
+func (SQLReviewRule_Type) Descriptor() protoreflect.EnumDescriptor {
+ return file_v1_review_config_service_proto_enumTypes[1].Descriptor()
+}
+
+func (SQLReviewRule_Type) Type() protoreflect.EnumType {
+ return &file_v1_review_config_service_proto_enumTypes[1]
+}
+
+func (x SQLReviewRule_Type) Number() protoreflect.EnumNumber {
+ return protoreflect.EnumNumber(x)
+}
+
+// Deprecated: Use SQLReviewRule_Type.Descriptor instead.
+func (SQLReviewRule_Type) EnumDescriptor() ([]byte, []int) {
+ return file_v1_review_config_service_proto_rawDescGZIP(), []int{7, 1}
+}
+
type ListReviewConfigsRequest struct {
state protoimpl.MessageState `protogen:"open.v1"`
unknownFields protoimpl.UnknownFields
@@ -449,7 +819,7 @@ func (x *ReviewConfig) GetResources() []string {
type SQLReviewRule struct {
state protoimpl.MessageState `protogen:"open.v1"`
// The type of SQL review rule.
- Type string `protobuf:"bytes,1,opt,name=type,proto3" json:"type,omitempty"`
+ Type SQLReviewRule_Type `protobuf:"varint,1,opt,name=type,proto3,enum=bytebase.v1.SQLReviewRule_Type" json:"type,omitempty"`
// The severity level of the rule.
Level SQLReviewRule_Level `protobuf:"varint,2,opt,name=level,proto3,enum=bytebase.v1.SQLReviewRule_Level" json:"level,omitempty"`
// The payload is a JSON string that varies by rule type.
@@ -490,11 +860,11 @@ func (*SQLReviewRule) Descriptor() ([]byte, []int) {
return file_v1_review_config_service_proto_rawDescGZIP(), []int{7}
}
-func (x *SQLReviewRule) GetType() string {
+func (x *SQLReviewRule) GetType() SQLReviewRule_Type {
if x != nil {
return x.Type
}
- return ""
+ return SQLReviewRule_TYPE_UNSPECIFIED
}
func (x *SQLReviewRule) GetLevel() SQLReviewRule_Level {
@@ -545,16 +915,128 @@ const file_v1_review_config_service_proto_rawDesc = "" +
"\aenabled\x18\x03 \x01(\bR\aenabled\x120\n" +
"\x05rules\x18\a \x03(\v2\x1a.bytebase.v1.SQLReviewRuleR\x05rules\x12\x1c\n" +
"\tresources\x18\b \x03(\tR\tresources:<\xeaA9\n" +
- "\x19bytebase.com/ReviewConfig\x12\x1creviewConfigs/{reviewConfig}\"\xda\x01\n" +
- "\rSQLReviewRule\x12\x12\n" +
- "\x04type\x18\x01 \x01(\tR\x04type\x126\n" +
+ "\x19bytebase.com/ReviewConfig\x12\x1creviewConfigs/{reviewConfig}\"\xae\x1e\n" +
+ "\rSQLReviewRule\x123\n" +
+ "\x04type\x18\x01 \x01(\x0e2\x1f.bytebase.v1.SQLReviewRule.TypeR\x04type\x126\n" +
"\x05level\x18\x02 \x01(\x0e2 .bytebase.v1.SQLReviewRule.LevelR\x05level\x12\x18\n" +
"\apayload\x18\x03 \x01(\tR\apayload\x12+\n" +
"\x06engine\x18\x04 \x01(\x0e2\x13.bytebase.v1.EngineR\x06engine\"6\n" +
"\x05Level\x12\x15\n" +
"\x11LEVEL_UNSPECIFIED\x10\x00\x12\t\n" +
"\x05ERROR\x10\x01\x12\v\n" +
- "\aWARNING\x10\x022\xed\x06\n" +
+ "\aWARNING\x10\x02\"\xb0\x1c\n" +
+ "\x04Type\x12\x14\n" +
+ "\x10TYPE_UNSPECIFIED\x10\x00\x12\x1b\n" +
+ "\x17ENGINE_MYSQL_USE_INNODB\x10\x01\x12\x1a\n" +
+ "\x16NAMING_FULLY_QUALIFIED\x10\x02\x12\x10\n" +
+ "\fNAMING_TABLE\x10\x03\x12\x11\n" +
+ "\rNAMING_COLUMN\x10\x04\x12\x13\n" +
+ "\x0fNAMING_INDEX_PK\x10\x05\x12\x13\n" +
+ "\x0fNAMING_INDEX_UK\x10\x06\x12\x13\n" +
+ "\x0fNAMING_INDEX_FK\x10\a\x12\x14\n" +
+ "\x10NAMING_INDEX_IDX\x10\b\x12 \n" +
+ "\x1cNAMING_COLUMN_AUTO_INCREMENT\x10\t\x12\x1b\n" +
+ "\x17NAMING_TABLE_NO_KEYWORD\x10\n" +
+ "\x12 \n" +
+ "\x1cNAMING_IDENTIFIER_NO_KEYWORD\x10\v\x12\x1a\n" +
+ "\x16NAMING_IDENTIFIER_CASE\x10\f\x12\"\n" +
+ "\x1eSTATEMENT_SELECT_NO_SELECT_ALL\x10\r\x12\"\n" +
+ "\x1eSTATEMENT_WHERE_REQUIRE_SELECT\x10\x0e\x12)\n" +
+ "%STATEMENT_WHERE_REQUIRE_UPDATE_DELETE\x10\x0f\x12,\n" +
+ "(STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE\x10\x10\x12%\n" +
+ "!STATEMENT_DISALLOW_ON_DEL_CASCADE\x10\x11\x12%\n" +
+ "!STATEMENT_DISALLOW_RM_TBL_CASCADE\x10\x12\x12\x1d\n" +
+ "\x19STATEMENT_DISALLOW_COMMIT\x10\x13\x12\x1c\n" +
+ "\x18STATEMENT_DISALLOW_LIMIT\x10\x14\x12\x1f\n" +
+ "\x1bSTATEMENT_DISALLOW_ORDER_BY\x10\x15\x12\x1f\n" +
+ "\x1bSTATEMENT_MERGE_ALTER_TABLE\x10\x16\x12\x1e\n" +
+ "\x1aSTATEMENT_INSERT_ROW_LIMIT\x10\x17\x12(\n" +
+ "$STATEMENT_INSERT_MUST_SPECIFY_COLUMN\x10\x18\x12+\n" +
+ "'STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND\x10\x19\x12 \n" +
+ "\x1cSTATEMENT_AFFECTED_ROW_LIMIT\x10\x1a\x12\x19\n" +
+ "\x15STATEMENT_DML_DRY_RUN\x10\x1b\x12.\n" +
+ "*STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT\x10\x1c\x12!\n" +
+ "\x1dSTATEMENT_ADD_CHECK_NOT_VALID\x10\x1d\x12'\n" +
+ "#STATEMENT_ADD_FOREIGN_KEY_NOT_VALID\x10\x1e\x12#\n" +
+ "\x1fSTATEMENT_DISALLOW_ADD_NOT_NULL\x10\x1f\x12$\n" +
+ " STATEMENT_SELECT_FULL_TABLE_SCAN\x10 \x12#\n" +
+ "\x1fSTATEMENT_CREATE_SPECIFY_SCHEMA\x10!\x12%\n" +
+ "!STATEMENT_CHECK_SET_ROLE_VARIABLE\x10\"\x12%\n" +
+ "!STATEMENT_DISALLOW_USING_FILESORT\x10#\x12&\n" +
+ "\"STATEMENT_DISALLOW_USING_TEMPORARY\x10$\x12!\n" +
+ "\x1dSTATEMENT_WHERE_NO_EQUAL_NULL\x10%\x127\n" +
+ "3STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS\x10&\x12&\n" +
+ "\"STATEMENT_QUERY_MINIMUM_PLAN_LEVEL\x10'\x122\n" +
+ ".STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT\x10(\x12!\n" +
+ "\x1dSTATEMENT_MAXIMUM_LIMIT_VALUE\x10)\x12&\n" +
+ "\"STATEMENT_MAXIMUM_JOIN_TABLE_COUNT\x10*\x12/\n" +
+ "+STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION\x10+\x12&\n" +
+ "\"STATEMENT_JOIN_STRICT_COLUMN_ATTRS\x10,\x12\x1f\n" +
+ "\x1bSTATEMENT_NON_TRANSACTIONAL\x10-\x12)\n" +
+ "%STATEMENT_ADD_COLUMN_WITHOUT_POSITION\x10.\x12\"\n" +
+ "\x1eSTATEMENT_DISALLOW_OFFLINE_DDL\x10/\x12'\n" +
+ "#STATEMENT_DISALLOW_CROSS_DB_QUERIES\x100\x12 \n" +
+ "\x1cSTATEMENT_MAX_EXECUTION_TIME\x101\x12&\n" +
+ "\"STATEMENT_REQUIRE_ALGORITHM_OPTION\x102\x12!\n" +
+ "\x1dSTATEMENT_REQUIRE_LOCK_OPTION\x103\x12 \n" +
+ "\x1cSTATEMENT_OBJECT_OWNER_CHECK\x104\x12\x14\n" +
+ "\x10TABLE_REQUIRE_PK\x105\x12\x18\n" +
+ "\x14TABLE_NO_FOREIGN_KEY\x106\x12 \n" +
+ "\x1cTABLE_DROP_NAMING_CONVENTION\x107\x12\x11\n" +
+ "\rTABLE_COMMENT\x108\x12\x1c\n" +
+ "\x18TABLE_DISALLOW_PARTITION\x109\x12\x1a\n" +
+ "\x16TABLE_DISALLOW_TRIGGER\x10:\x12\x1c\n" +
+ "\x18TABLE_NO_DUPLICATE_INDEX\x10;\x12\"\n" +
+ "\x1eTABLE_TEXT_FIELDS_TOTAL_LENGTH\x10<\x12\x1e\n" +
+ "\x1aTABLE_DISALLOW_SET_CHARSET\x10=\x12\x16\n" +
+ "\x12TABLE_DISALLOW_DDL\x10>\x12\x16\n" +
+ "\x12TABLE_DISALLOW_DML\x10?\x12\x14\n" +
+ "\x10TABLE_LIMIT_SIZE\x10@\x12\x19\n" +
+ "\x15TABLE_REQUIRE_CHARSET\x10A\x12\x1b\n" +
+ "\x17TABLE_REQUIRE_COLLATION\x10B\x12\x13\n" +
+ "\x0fCOLUMN_REQUIRED\x10C\x12\x12\n" +
+ "\x0eCOLUMN_NO_NULL\x10D\x12\x1f\n" +
+ "\x1bCOLUMN_DISALLOW_CHANGE_TYPE\x10E\x12#\n" +
+ "\x1fCOLUMN_SET_DEFAULT_FOR_NOT_NULL\x10F\x12\x1a\n" +
+ "\x16COLUMN_DISALLOW_CHANGE\x10G\x12\"\n" +
+ "\x1eCOLUMN_DISALLOW_CHANGING_ORDER\x10H\x12\x18\n" +
+ "\x14COLUMN_DISALLOW_DROP\x10I\x12!\n" +
+ "\x1dCOLUMN_DISALLOW_DROP_IN_INDEX\x10J\x12\x12\n" +
+ "\x0eCOLUMN_COMMENT\x10K\x12&\n" +
+ "\"COLUMN_AUTO_INCREMENT_MUST_INTEGER\x10L\x12\x1d\n" +
+ "\x19COLUMN_TYPE_DISALLOW_LIST\x10M\x12\x1f\n" +
+ "\x1bCOLUMN_DISALLOW_SET_CHARSET\x10N\x12#\n" +
+ "\x1fCOLUMN_MAXIMUM_CHARACTER_LENGTH\x10O\x12!\n" +
+ "\x1dCOLUMN_MAXIMUM_VARCHAR_LENGTH\x10P\x12'\n" +
+ "#COLUMN_AUTO_INCREMENT_INITIAL_VALUE\x10Q\x12'\n" +
+ "#COLUMN_AUTO_INCREMENT_MUST_UNSIGNED\x10R\x12#\n" +
+ "\x1fCOLUMN_CURRENT_TIME_COUNT_LIMIT\x10S\x12\x1a\n" +
+ "\x16COLUMN_REQUIRE_DEFAULT\x10T\x12$\n" +
+ " COLUMN_DEFAULT_DISALLOW_VOLATILE\x10U\x12'\n" +
+ "#COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT\x10V\x12\x1a\n" +
+ "\x16COLUMN_REQUIRE_CHARSET\x10W\x12\x1c\n" +
+ "\x18COLUMN_REQUIRE_COLLATION\x10X\x12!\n" +
+ "\x1dSCHEMA_BACKWARD_COMPATIBILITY\x10Y\x12 \n" +
+ "\x1cDATABASE_DROP_EMPTY_DATABASE\x10Z\x12\x1d\n" +
+ "\x19INDEX_NO_DUPLICATE_COLUMN\x10[\x12\x1a\n" +
+ "\x16INDEX_KEY_NUMBER_LIMIT\x10\\\x12\x17\n" +
+ "\x13INDEX_PK_TYPE_LIMIT\x10]\x12\x16\n" +
+ "\x12INDEX_TYPE_NO_BLOB\x10^\x12\x1c\n" +
+ "\x18INDEX_TOTAL_NUMBER_LIMIT\x10_\x12$\n" +
+ " INDEX_PRIMARY_KEY_TYPE_ALLOWLIST\x10`\x12\x1d\n" +
+ "\x19INDEX_CREATE_CONCURRENTLY\x10a\x12\x19\n" +
+ "\x15INDEX_TYPE_ALLOW_LIST\x10b\x12\x17\n" +
+ "\x13INDEX_NOT_REDUNDANT\x10c\x12\x1c\n" +
+ "\x18SYSTEM_CHARSET_ALLOWLIST\x10d\x12\x1e\n" +
+ "\x1aSYSTEM_COLLATION_ALLOWLIST\x10e\x12\x19\n" +
+ "\x15SYSTEM_COMMENT_LENGTH\x10f\x12$\n" +
+ " SYSTEM_PROCEDURE_DISALLOW_CREATE\x10g\x12 \n" +
+ "\x1cSYSTEM_EVENT_DISALLOW_CREATE\x10h\x12\x1f\n" +
+ "\x1bSYSTEM_VIEW_DISALLOW_CREATE\x10i\x12#\n" +
+ "\x1fSYSTEM_FUNCTION_DISALLOW_CREATE\x10j\x12#\n" +
+ "\x1fSYSTEM_FUNCTION_DISALLOWED_LIST\x10k\x12\x1b\n" +
+ "\x17ADVICE_ONLINE_MIGRATION\x10l\x12\x1e\n" +
+ "\x1aBUILTIN_PRIOR_BACKUP_CHECK\x10m2\xed\x06\n" +
"\x13ReviewConfigService\x12\xa3\x01\n" +
"\x12CreateReviewConfig\x12&.bytebase.v1.CreateReviewConfigRequest\x1a\x19.bytebase.v1.ReviewConfig\"J\xdaA\x00\x8a\xea0\x17bb.reviewConfigs.create\x90\xea0\x01\x82\xd3\xe4\x93\x02\":\rreview_config\"\x11/v1/reviewConfigs\x12\x9d\x01\n" +
"\x11ListReviewConfigs\x12%.bytebase.v1.ListReviewConfigsRequest\x1a&.bytebase.v1.ListReviewConfigsResponse\"9\xdaA\x00\x8a\xea0\x15bb.reviewConfigs.list\x90\xea0\x01\x82\xd3\xe4\x93\x02\x13\x12\x11/v1/reviewConfigs\x12\x98\x01\n" +
@@ -575,45 +1057,47 @@ func file_v1_review_config_service_proto_rawDescGZIP() []byte {
return file_v1_review_config_service_proto_rawDescData
}
-var file_v1_review_config_service_proto_enumTypes = make([]protoimpl.EnumInfo, 1)
+var file_v1_review_config_service_proto_enumTypes = make([]protoimpl.EnumInfo, 2)
var file_v1_review_config_service_proto_msgTypes = make([]protoimpl.MessageInfo, 8)
var file_v1_review_config_service_proto_goTypes = []any{
(SQLReviewRule_Level)(0), // 0: bytebase.v1.SQLReviewRule.Level
- (*ListReviewConfigsRequest)(nil), // 1: bytebase.v1.ListReviewConfigsRequest
- (*ListReviewConfigsResponse)(nil), // 2: bytebase.v1.ListReviewConfigsResponse
- (*CreateReviewConfigRequest)(nil), // 3: bytebase.v1.CreateReviewConfigRequest
- (*UpdateReviewConfigRequest)(nil), // 4: bytebase.v1.UpdateReviewConfigRequest
- (*GetReviewConfigRequest)(nil), // 5: bytebase.v1.GetReviewConfigRequest
- (*DeleteReviewConfigRequest)(nil), // 6: bytebase.v1.DeleteReviewConfigRequest
- (*ReviewConfig)(nil), // 7: bytebase.v1.ReviewConfig
- (*SQLReviewRule)(nil), // 8: bytebase.v1.SQLReviewRule
- (*fieldmaskpb.FieldMask)(nil), // 9: google.protobuf.FieldMask
- (Engine)(0), // 10: bytebase.v1.Engine
- (*emptypb.Empty)(nil), // 11: google.protobuf.Empty
+ (SQLReviewRule_Type)(0), // 1: bytebase.v1.SQLReviewRule.Type
+ (*ListReviewConfigsRequest)(nil), // 2: bytebase.v1.ListReviewConfigsRequest
+ (*ListReviewConfigsResponse)(nil), // 3: bytebase.v1.ListReviewConfigsResponse
+ (*CreateReviewConfigRequest)(nil), // 4: bytebase.v1.CreateReviewConfigRequest
+ (*UpdateReviewConfigRequest)(nil), // 5: bytebase.v1.UpdateReviewConfigRequest
+ (*GetReviewConfigRequest)(nil), // 6: bytebase.v1.GetReviewConfigRequest
+ (*DeleteReviewConfigRequest)(nil), // 7: bytebase.v1.DeleteReviewConfigRequest
+ (*ReviewConfig)(nil), // 8: bytebase.v1.ReviewConfig
+ (*SQLReviewRule)(nil), // 9: bytebase.v1.SQLReviewRule
+ (*fieldmaskpb.FieldMask)(nil), // 10: google.protobuf.FieldMask
+ (Engine)(0), // 11: bytebase.v1.Engine
+ (*emptypb.Empty)(nil), // 12: google.protobuf.Empty
}
var file_v1_review_config_service_proto_depIdxs = []int32{
- 7, // 0: bytebase.v1.ListReviewConfigsResponse.review_configs:type_name -> bytebase.v1.ReviewConfig
- 7, // 1: bytebase.v1.CreateReviewConfigRequest.review_config:type_name -> bytebase.v1.ReviewConfig
- 7, // 2: bytebase.v1.UpdateReviewConfigRequest.review_config:type_name -> bytebase.v1.ReviewConfig
- 9, // 3: bytebase.v1.UpdateReviewConfigRequest.update_mask:type_name -> google.protobuf.FieldMask
- 8, // 4: bytebase.v1.ReviewConfig.rules:type_name -> bytebase.v1.SQLReviewRule
- 0, // 5: bytebase.v1.SQLReviewRule.level:type_name -> bytebase.v1.SQLReviewRule.Level
- 10, // 6: bytebase.v1.SQLReviewRule.engine:type_name -> bytebase.v1.Engine
- 3, // 7: bytebase.v1.ReviewConfigService.CreateReviewConfig:input_type -> bytebase.v1.CreateReviewConfigRequest
- 1, // 8: bytebase.v1.ReviewConfigService.ListReviewConfigs:input_type -> bytebase.v1.ListReviewConfigsRequest
- 5, // 9: bytebase.v1.ReviewConfigService.GetReviewConfig:input_type -> bytebase.v1.GetReviewConfigRequest
- 4, // 10: bytebase.v1.ReviewConfigService.UpdateReviewConfig:input_type -> bytebase.v1.UpdateReviewConfigRequest
- 6, // 11: bytebase.v1.ReviewConfigService.DeleteReviewConfig:input_type -> bytebase.v1.DeleteReviewConfigRequest
- 7, // 12: bytebase.v1.ReviewConfigService.CreateReviewConfig:output_type -> bytebase.v1.ReviewConfig
- 2, // 13: bytebase.v1.ReviewConfigService.ListReviewConfigs:output_type -> bytebase.v1.ListReviewConfigsResponse
- 7, // 14: bytebase.v1.ReviewConfigService.GetReviewConfig:output_type -> bytebase.v1.ReviewConfig
- 7, // 15: bytebase.v1.ReviewConfigService.UpdateReviewConfig:output_type -> bytebase.v1.ReviewConfig
- 11, // 16: bytebase.v1.ReviewConfigService.DeleteReviewConfig:output_type -> google.protobuf.Empty
- 12, // [12:17] is the sub-list for method output_type
- 7, // [7:12] is the sub-list for method input_type
- 7, // [7:7] is the sub-list for extension type_name
- 7, // [7:7] is the sub-list for extension extendee
- 0, // [0:7] is the sub-list for field type_name
+ 8, // 0: bytebase.v1.ListReviewConfigsResponse.review_configs:type_name -> bytebase.v1.ReviewConfig
+ 8, // 1: bytebase.v1.CreateReviewConfigRequest.review_config:type_name -> bytebase.v1.ReviewConfig
+ 8, // 2: bytebase.v1.UpdateReviewConfigRequest.review_config:type_name -> bytebase.v1.ReviewConfig
+ 10, // 3: bytebase.v1.UpdateReviewConfigRequest.update_mask:type_name -> google.protobuf.FieldMask
+ 9, // 4: bytebase.v1.ReviewConfig.rules:type_name -> bytebase.v1.SQLReviewRule
+ 1, // 5: bytebase.v1.SQLReviewRule.type:type_name -> bytebase.v1.SQLReviewRule.Type
+ 0, // 6: bytebase.v1.SQLReviewRule.level:type_name -> bytebase.v1.SQLReviewRule.Level
+ 11, // 7: bytebase.v1.SQLReviewRule.engine:type_name -> bytebase.v1.Engine
+ 4, // 8: bytebase.v1.ReviewConfigService.CreateReviewConfig:input_type -> bytebase.v1.CreateReviewConfigRequest
+ 2, // 9: bytebase.v1.ReviewConfigService.ListReviewConfigs:input_type -> bytebase.v1.ListReviewConfigsRequest
+ 6, // 10: bytebase.v1.ReviewConfigService.GetReviewConfig:input_type -> bytebase.v1.GetReviewConfigRequest
+ 5, // 11: bytebase.v1.ReviewConfigService.UpdateReviewConfig:input_type -> bytebase.v1.UpdateReviewConfigRequest
+ 7, // 12: bytebase.v1.ReviewConfigService.DeleteReviewConfig:input_type -> bytebase.v1.DeleteReviewConfigRequest
+ 8, // 13: bytebase.v1.ReviewConfigService.CreateReviewConfig:output_type -> bytebase.v1.ReviewConfig
+ 3, // 14: bytebase.v1.ReviewConfigService.ListReviewConfigs:output_type -> bytebase.v1.ListReviewConfigsResponse
+ 8, // 15: bytebase.v1.ReviewConfigService.GetReviewConfig:output_type -> bytebase.v1.ReviewConfig
+ 8, // 16: bytebase.v1.ReviewConfigService.UpdateReviewConfig:output_type -> bytebase.v1.ReviewConfig
+ 12, // 17: bytebase.v1.ReviewConfigService.DeleteReviewConfig:output_type -> google.protobuf.Empty
+ 13, // [13:18] is the sub-list for method output_type
+ 8, // [8:13] is the sub-list for method input_type
+ 8, // [8:8] is the sub-list for extension type_name
+ 8, // [8:8] is the sub-list for extension extendee
+ 0, // [0:8] is the sub-list for field type_name
}
func init() { file_v1_review_config_service_proto_init() }
@@ -628,7 +1112,7 @@ func file_v1_review_config_service_proto_init() {
File: protoimpl.DescBuilder{
GoPackagePath: reflect.TypeOf(x{}).PkgPath(),
RawDescriptor: unsafe.Slice(unsafe.StringData(file_v1_review_config_service_proto_rawDesc), len(file_v1_review_config_service_proto_rawDesc)),
- NumEnums: 1,
+ NumEnums: 2,
NumMessages: 8,
NumExtensions: 0,
NumServices: 1,
diff --git a/backend/migrator/migration/3.13/0017##update_review_config_rule_type.sql b/backend/migrator/migration/3.13/0017##update_review_config_rule_type.sql
new file mode 100644
index 0000000000..a0fbf6858d
--- /dev/null
+++ b/backend/migrator/migration/3.13/0017##update_review_config_rule_type.sql
@@ -0,0 +1,132 @@
+
+DO $$
+DECLARE
+ r RECORD;
+BEGIN
+ FOR r IN SELECT id, payload FROM review_config
+ LOOP
+ UPDATE review_config
+ SET payload = jsonb_set(
+ r.payload,
+ '{sqlReviewRules}',
+ (
+ SELECT jsonb_agg(
+ CASE (rule->>'type')
+ WHEN 'naming.table' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_TABLE'::text))
+ WHEN 'naming.column' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_COLUMN'::text))
+ WHEN 'naming.index.pk' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_INDEX_PK'::text))
+ WHEN 'naming.index.uk' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_INDEX_UK'::text))
+ WHEN 'naming.index.fk' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_INDEX_FK'::text))
+ WHEN 'naming.index.idx' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_INDEX_IDX'::text))
+ WHEN 'naming.auto-increment-column' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_COLUMN_AUTO_INCREMENT'::text))
+ WHEN 'naming.table-no-keyword' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_TABLE_NO_KEYWORD'::text))
+ WHEN 'naming.identifier-no-keyword' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_IDENTIFIER_NO_KEYWORD'::text))
+ WHEN 'naming.identifier-case' THEN jsonb_set(rule, '{type}', to_jsonb('NAMING_IDENTIFIER_CASE'::text))
+ WHEN 'statement.select.no-select-all' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_SELECT_NO_SELECT_ALL'::text))
+ WHEN 'statement.where.require-select' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_WHERE_REQUIRE_SELECT'::text))
+ WHEN 'statement.where.require-update-delete' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_WHERE_REQUIRE_UPDATE_DELETE'::text))
+ WHEN 'statement.where.no-leading-wildcard-like' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE'::text))
+ WHEN 'statement.disallow-on-del-cascade' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_ON_DEL_CASCADE'::text))
+ WHEN 'statement.disallow-rm-tbl-cascade' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_RM_TBL_CASCADE'::text))
+ WHEN 'statement.disallow-commit' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_COMMIT'::text))
+ WHEN 'statement.disallow-limit' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_LIMIT'::text))
+ WHEN 'statement.disallow-order-by' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_ORDER_BY'::text))
+ WHEN 'statement.merge-alter-table' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_MERGE_ALTER_TABLE'::text))
+ WHEN 'statement.insert.row-limit' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_INSERT_ROW_LIMIT'::text))
+ WHEN 'statement.insert.must-specify-column' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_INSERT_MUST_SPECIFY_COLUMN'::text))
+ WHEN 'statement.insert.disallow-order-by-rand' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND'::text))
+ WHEN 'statement.affected-row-limit' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_AFFECTED_ROW_LIMIT'::text))
+ WHEN 'statement.dml-dry-run' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DML_DRY_RUN'::text))
+ WHEN 'statement.disallow-add-column-with-default' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT'::text))
+ WHEN 'statement.add-check-not-valid' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_ADD_CHECK_NOT_VALID'::text))
+ WHEN 'statement.add-foreign-key-not-valid' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_ADD_FOREIGN_KEY_NOT_VALID'::text))
+ WHEN 'statement.disallow-add-not-null' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_ADD_NOT_NULL'::text))
+ WHEN 'statement.select-full-table-scan' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_SELECT_FULL_TABLE_SCAN'::text))
+ WHEN 'statement.create-specify-schema' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_CREATE_SPECIFY_SCHEMA'::text))
+ WHEN 'statement.check-set-role-variable' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_CHECK_SET_ROLE_VARIABLE'::text))
+ WHEN 'statement.disallow-using-filesort' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_USING_FILESORT'::text))
+ WHEN 'statement.disallow-using-temporary' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_USING_TEMPORARY'::text))
+ WHEN 'statement.where-no-equal-null' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_WHERE_NO_EQUAL_NULL'::text))
+ WHEN 'statement.where-disallow-functions-and-calculations' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS'::text))
+ WHEN 'statement.query-minimum-plan-level' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_QUERY_MINIMUM_PLAN_LEVEL'::text))
+ WHEN 'statement.where-maximum-logical-operator-count' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT'::text))
+ WHEN 'statement.maximum-limit-value' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_MAXIMUM_LIMIT_VALUE'::text))
+ WHEN 'statement.maximum-join-table-count' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_MAXIMUM_JOIN_TABLE_COUNT'::text))
+ WHEN 'statement.maximum-statements-in-transaction' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION'::text))
+ WHEN 'statement.join-strict-column-attrs' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_JOIN_STRICT_COLUMN_ATTRS'::text))
+ WHEN 'statement.prior-backup-check' THEN jsonb_set(rule, '{type}', to_jsonb('BUILTIN_PRIOR_BACKUP_CHECK'::text))
+ WHEN 'statement.non-transactional' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_NON_TRANSACTIONAL'::text))
+ WHEN 'statement.add-column-without-position' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_ADD_COLUMN_WITHOUT_POSITION'::text))
+ WHEN 'statement.disallow-offline-ddl' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_OFFLINE_DDL'::text))
+ WHEN 'statement.disallow-cross-db-queries' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_DISALLOW_CROSS_DB_QUERIES'::text))
+ WHEN 'statement.max-execution-time' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_MAX_EXECUTION_TIME'::text))
+ WHEN 'statement.require-algorithm-option' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_REQUIRE_ALGORITHM_OPTION'::text))
+ WHEN 'statement.require-lock-option' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_REQUIRE_LOCK_OPTION'::text))
+ WHEN 'statement.object-owner-check' THEN jsonb_set(rule, '{type}', to_jsonb('STATEMENT_OBJECT_OWNER_CHECK'::text))
+ WHEN 'table.require-pk' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_REQUIRE_PK'::text))
+ WHEN 'table.no-fk' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_NO_FOREIGN_KEY'::text))
+ WHEN 'table.drop-naming-convention' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_DROP_NAMING_CONVENTION'::text))
+ WHEN 'table.comment' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_COMMENT'::text))
+ WHEN 'table.disallow-partition' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_DISALLOW_PARTITION'::text))
+ WHEN 'table.disallow-trigger' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_DISALLOW_TRIGGER'::text))
+ WHEN 'table.no-duplicate-index' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_NO_DUPLICATE_COLUMN'::text))
+ WHEN 'table.text-fields-total-length' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_TEXT_FIELDS_TOTAL_LENGTH'::text))
+ WHEN 'table.disallow-set-charset' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_DISALLOW_SET_CHARSET'::text))
+ WHEN 'table.disallow-ddl' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_DISALLOW_DDL'::text))
+ WHEN 'table.disallow-dml' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_DISALLOW_DML'::text))
+ WHEN 'table.limit-size' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_LIMIT_SIZE'::text))
+ WHEN 'table.require-charset' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_REQUIRE_CHARSET'::text))
+ WHEN 'table.require-collation' THEN jsonb_set(rule, '{type}', to_jsonb('TABLE_REQUIRE_COLLATION'::text))
+ WHEN 'column.required' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_REQUIRED'::text))
+ WHEN 'column.no-null' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_NO_NULL'::text))
+ WHEN 'column.disallow-change-type' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DISALLOW_CHANGE_TYPE'::text))
+ WHEN 'column.set-default-for-not-null' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_SET_DEFAULT_FOR_NOT_NULL'::text))
+ WHEN 'column.disallow-change' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DISALLOW_CHANGE'::text))
+ WHEN 'column.disallow-changing-order' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DISALLOW_CHANGING_ORDER'::text))
+ WHEN 'column.disallow-drop' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DISALLOW_DROP'::text))
+ WHEN 'column.disallow-drop-in-index' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DISALLOW_DROP_IN_INDEX'::text))
+ WHEN 'column.comment' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_COMMENT'::text))
+ WHEN 'column.auto-increment-must-integer' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_AUTO_INCREMENT_MUST_INTEGER'::text))
+ WHEN 'column.type-disallow-list' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_TYPE_DISALLOW_LIST'::text))
+ WHEN 'column.disallow-set-charset' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DISALLOW_SET_CHARSET'::text))
+ WHEN 'column.maximum-character-length' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_MAXIMUM_CHARACTER_LENGTH'::text))
+ WHEN 'column.maximum-varchar-length' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_MAXIMUM_VARCHAR_LENGTH'::text))
+ WHEN 'column.auto-increment-initial-value' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_AUTO_INCREMENT_INITIAL_VALUE'::text))
+ WHEN 'column.auto-increment-must-unsigned' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_AUTO_INCREMENT_MUST_UNSIGNED'::text))
+ WHEN 'column.current-time-column-count-limit' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_CURRENT_TIME_COUNT_LIMIT'::text))
+ WHEN 'column.require-default' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_REQUIRE_DEFAULT'::text))
+ WHEN 'column.default-disallow-volatile' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_DEFAULT_DISALLOW_VOLATILE'::text))
+ WHEN 'column.add-not-null-require-default' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT'::text))
+ WHEN 'column.require-charset' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_REQUIRE_CHARSET'::text))
+ WHEN 'column.require-collation' THEN jsonb_set(rule, '{type}', to_jsonb('COLUMN_REQUIRE_COLLATION'::text))
+ WHEN 'schema.backward-compatibility' THEN jsonb_set(rule, '{type}', to_jsonb('SCHEMA_BACKWARD_COMPATIBILITY'::text))
+ WHEN 'database.drop-empty-database' THEN jsonb_set(rule, '{type}', to_jsonb('DATABASE_DROP_EMPTY_DATABASE'::text))
+ WHEN 'index.no-duplicate-column' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_NO_DUPLICATE_COLUMN'::text))
+ WHEN 'index.key-number-limit' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_KEY_NUMBER_LIMIT'::text))
+ WHEN 'index.pk-type-limit' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_PK_TYPE_LIMIT'::text))
+ WHEN 'index.type-no-blob' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_TYPE_NO_BLOB'::text))
+ WHEN 'index.total-number-limit' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_TOTAL_NUMBER_LIMIT'::text))
+ WHEN 'index.primary-key-type-allowlist' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_PRIMARY_KEY_TYPE_ALLOWLIST'::text))
+ WHEN 'index.create-concurrently' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_CREATE_CONCURRENTLY'::text))
+ WHEN 'index.type-allow-list' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_TYPE_ALLOW_LIST'::text))
+ WHEN 'index.not-redundant' THEN jsonb_set(rule, '{type}', to_jsonb('INDEX_NOT_REDUNDANT'::text))
+ WHEN 'system.charset-allowlist' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_CHARSET_ALLOWLIST'::text))
+ WHEN 'system.collation-allowlist' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_COLLATION_ALLOWLIST'::text))
+ WHEN 'system.comment-length' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_COMMENT_LENGTH'::text))
+ WHEN 'system.procedure-disallow-create' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_PROCEDURE_DISALLOW_CREATE'::text))
+ WHEN 'system.event-disallow-create' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_EVENT_DISALLOW_CREATE'::text))
+ WHEN 'system.view-disallow-create' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_VIEW_DISALLOW_CREATE'::text))
+ WHEN 'system.function-disallow-create' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_FUNCTION_DISALLOW_CREATE'::text))
+ WHEN 'system.function-disallowed-list' THEN jsonb_set(rule, '{type}', to_jsonb('SYSTEM_FUNCTION_DISALLOWED_LIST'::text))
+ WHEN 'advice.online-migration' THEN jsonb_set(rule, '{type}', to_jsonb('ADVICE_ONLINE_MIGRATION'::text))
+ WHEN 'builtin.prior-backup-check' THEN jsonb_set(rule, '{type}', to_jsonb('BUILTIN_PRIOR_BACKUP_CHECK'::text))
+ WHEN 'engine.mysql.use-innodb' THEN jsonb_set(rule, '{type}', to_jsonb('ENGINE_MYSQL_USE_INNODB'::text))
+ ELSE rule
+ END
+ )
+ FROM jsonb_array_elements(r.payload->'sqlReviewRules') AS rules(rule)
+ )
+ )
+ WHERE id = r.id;
+ END LOOP;
+END $$;
diff --git a/backend/migrator/migrator_test.go b/backend/migrator/migrator_test.go
index 6ea6f00dc5..e03e4ccc5e 100644
--- a/backend/migrator/migrator_test.go
+++ b/backend/migrator/migrator_test.go
@@ -12,7 +12,7 @@ import (
func TestLatestVersion(t *testing.T) {
files, err := getSortedVersionedFiles()
require.NoError(t, err)
- require.Equal(t, semver.MustParse("3.13.16"), *files[len(files)-1].version)
+ require.Equal(t, semver.MustParse("3.13.17"), *files[len(files)-1].version)
}
func TestVersionUnique(t *testing.T) {
diff --git a/backend/plugin/advisor/advisor.go b/backend/plugin/advisor/advisor.go
index 832f68a196..375c94e4da 100644
--- a/backend/plugin/advisor/advisor.go
+++ b/backend/plugin/advisor/advisor.go
@@ -78,13 +78,13 @@ type Advisor interface {
var (
advisorMu sync.RWMutex
- advisors = make(map[storepb.Engine]map[SQLReviewRuleType]Advisor)
+ advisors = make(map[storepb.Engine]map[storepb.SQLReviewRule_Type]Advisor)
)
// Register makes a advisor available by the provided id.
// If Register is called twice with the same name or if advisor is nil,
// it panics.
-func Register(dbType storepb.Engine, ruleType SQLReviewRuleType, f Advisor) {
+func Register(dbType storepb.Engine, ruleType storepb.SQLReviewRule_Type, f Advisor) {
advisorMu.Lock()
defer advisorMu.Unlock()
if f == nil {
@@ -92,7 +92,7 @@ func Register(dbType storepb.Engine, ruleType SQLReviewRuleType, f Advisor) {
}
dbAdvisors, ok := advisors[dbType]
if !ok {
- advisors[dbType] = map[SQLReviewRuleType]Advisor{
+ advisors[dbType] = map[storepb.SQLReviewRule_Type]Advisor{
ruleType: f,
}
} else {
@@ -104,7 +104,7 @@ func Register(dbType storepb.Engine, ruleType SQLReviewRuleType, f Advisor) {
}
// Check runs the advisor and returns the advices.
-func Check(ctx context.Context, dbType storepb.Engine, ruleType SQLReviewRuleType, checkCtx Context) (adviceList []*storepb.Advice, err error) {
+func Check(ctx context.Context, dbType storepb.Engine, ruleType storepb.SQLReviewRule_Type, checkCtx Context) (adviceList []*storepb.Advice, err error) {
defer func() {
if panicErr := recover(); panicErr != nil {
panicErr, ok := panicErr.(error)
diff --git a/backend/plugin/advisor/builtin_rules.go b/backend/plugin/advisor/builtin_rules.go
index 14f17caf67..d34379225c 100644
--- a/backend/plugin/advisor/builtin_rules.go
+++ b/backend/plugin/advisor/builtin_rules.go
@@ -2,17 +2,13 @@ package advisor
import storepb "github.com/bytebase/bytebase/backend/generated-go/store"
-const (
- BuiltinRulePriorBackupCheck SQLReviewRuleType = "builtin.prior-backup-check"
-)
-
func GetBuiltinRules(engine storepb.Engine) []*storepb.SQLReviewRule {
switch engine {
case storepb.Engine_MYSQL, storepb.Engine_POSTGRES, storepb.Engine_TIDB, storepb.Engine_MSSQL, storepb.Engine_ORACLE:
return []*storepb.SQLReviewRule{
{
- Type: string(BuiltinRulePriorBackupCheck),
- Level: storepb.SQLReviewRule_ERROR,
+ Type: storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK,
+ Level: storepb.SQLReviewRule_WARNING,
Payload: "",
Engine: engine,
},
diff --git a/backend/plugin/advisor/mssql/mssql_rules_test.go b/backend/plugin/advisor/mssql/mssql_rules_test.go
index 5eb4f97caf..be696791dd 100644
--- a/backend/plugin/advisor/mssql/mssql_rules_test.go
+++ b/backend/plugin/advisor/mssql/mssql_rules_test.go
@@ -9,28 +9,28 @@ import (
)
func TestMSSQLRules(t *testing.T) {
- mssqlRules := []advisor.SQLReviewRuleType{
- advisor.SchemaRuleStatementNoSelectAll,
- advisor.SchemaRuleTableNaming,
- advisor.SchemaRuleTableNameNoKeyword,
- advisor.SchemaRuleIdentifierNoKeyword,
- advisor.SchemaRuleStatementRequireWhereForSelect,
- advisor.SchemaRuleStatementRequireWhereForUpdateDelete,
- advisor.SchemaRuleColumnMaximumVarcharLength,
- advisor.SchemaRuleTableDropNamingConvention,
- advisor.SchemaRuleTableRequirePK,
- advisor.SchemaRuleColumnNotNull,
- advisor.SchemaRuleTableNoFK,
- advisor.SchemaRuleTableDisallowDDL,
- advisor.SchemaRuleTableDisallowDML,
- advisor.SchemaRuleSchemaBackwardCompatibility,
- advisor.SchemaRuleRequiredColumn,
- advisor.SchemaRuleColumnTypeDisallowList,
- advisor.SchemaRuleFunctionDisallowCreate,
- advisor.SchemaRuleProcedureDisallowCreate,
- advisor.SchemaRuleStatementDisallowCrossDBQueries,
- advisor.SchemaRuleStatementWhereDisallowFunctionsAndCalculations,
- advisor.SchemaRuleIndexNotRedundant,
+ mssqlRules := []storepb.SQLReviewRule_Type{
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ storepb.SQLReviewRule_NAMING_TABLE,
+ storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD,
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH,
+ storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ storepb.SQLReviewRule_TABLE_DISALLOW_DDL,
+ storepb.SQLReviewRule_TABLE_DISALLOW_DML,
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
+ storepb.SQLReviewRule_COLUMN_REQUIRED,
+ storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
+ storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE,
+ storepb.SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES,
+ storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS,
+ storepb.SQLReviewRule_INDEX_NOT_REDUNDANT,
}
for _, rule := range mssqlRules {
@@ -40,8 +40,8 @@ func TestMSSQLRules(t *testing.T) {
}
// Add SQL review type here if you need metadata for test.
-var advisorNeedMockData = map[advisor.SQLReviewRuleType]bool{
- advisor.SchemaRuleStatementDisallowCrossDBQueries: true,
- advisor.SchemaRuleSchemaBackwardCompatibility: true,
- advisor.SchemaRuleIndexNotRedundant: true,
+var advisorNeedMockData = map[storepb.SQLReviewRule_Type]bool{
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES: true,
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY: true,
+ storepb.SQLReviewRule_INDEX_NOT_REDUNDANT: true,
}
diff --git a/backend/plugin/advisor/mssql/rule_builtin_prior_backup_check.go b/backend/plugin/advisor/mssql/rule_builtin_prior_backup_check.go
index 3cc8f7f7eb..b78c40f4ed 100644
--- a/backend/plugin/advisor/mssql/rule_builtin_prior_backup_check.go
+++ b/backend/plugin/advisor/mssql/rule_builtin_prior_backup_check.go
@@ -27,7 +27,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.BuiltinRulePriorBackupCheck, &StatementPriorBackupCheckAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK, &StatementPriorBackupCheckAdvisor{})
}
type StatementPriorBackupCheckAdvisor struct {
@@ -49,7 +49,7 @@ func (*StatementPriorBackupCheckAdvisor) Check(ctx context.Context, checkCtx adv
if err != nil {
return nil, err
}
- title := string(checkCtx.Rule.Type)
+ title := checkCtx.Rule.Type.String()
if len(checkCtx.Statements) > common.MaxSheetCheckSize {
adviceList = append(adviceList, &storepb.Advice{
diff --git a/backend/plugin/advisor/mssql/rule_column_maximum_varchar_length.go b/backend/plugin/advisor/mssql/rule_column_maximum_varchar_length.go
index 0225dde3b7..f93b227b9d 100644
--- a/backend/plugin/advisor/mssql/rule_column_maximum_varchar_length.go
+++ b/backend/plugin/advisor/mssql/rule_column_maximum_varchar_length.go
@@ -24,7 +24,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleColumnMaximumVarcharLength, &ColumnMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, &ColumnMaximumVarcharLengthAdvisor{})
}
// ColumnMaximumVarcharLengthAdvisor is the advisor checking for maximum varchar length..
@@ -53,7 +53,7 @@ func (*ColumnMaximumVarcharLengthAdvisor) Check(_ context.Context, checkCtx advi
}
// Create the rule
- rule := NewColumnMaximumVarcharLengthRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewColumnMaximumVarcharLengthRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_column_no_null.go b/backend/plugin/advisor/mssql/rule_column_no_null.go
index 6a08ca46fc..51aee2d4f8 100644
--- a/backend/plugin/advisor/mssql/rule_column_no_null.go
+++ b/backend/plugin/advisor/mssql/rule_column_no_null.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
}
// ColumnNoNullAdvisor is the advisor checking for column no NULL value..
@@ -40,7 +40,7 @@ func (*ColumnNoNullAdvisor) Check(_ context.Context, checkCtx advisor.Context) (
}
// Create the rule
- rule := NewColumnNoNullRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnNoNullRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_column_require.go b/backend/plugin/advisor/mssql/rule_column_require.go
index c94e932296..7a783e777e 100644
--- a/backend/plugin/advisor/mssql/rule_column_require.go
+++ b/backend/plugin/advisor/mssql/rule_column_require.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleRequiredColumn, &ColumnRequireAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequireAdvisor{})
}
// ColumnRequireAdvisor is the advisor checking for column requirement..
@@ -47,7 +47,7 @@ func (*ColumnRequireAdvisor) Check(_ context.Context, checkCtx advisor.Context)
}
// Create the rule
- rule := NewColumnRequireRule(level, string(checkCtx.Rule.Type), columnList)
+ rule := NewColumnRequireRule(level, checkCtx.Rule.Type.String(), columnList)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_column_type_disallow_list.go b/backend/plugin/advisor/mssql/rule_column_type_disallow_list.go
index b875bffcd8..1a424a1862 100644
--- a/backend/plugin/advisor/mssql/rule_column_type_disallow_list.go
+++ b/backend/plugin/advisor/mssql/rule_column_type_disallow_list.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
}
// ColumnTypeDisallowListAdvisor is the advisor checking for disallowed types for column.
@@ -49,7 +49,7 @@ func (*ColumnTypeDisallowListAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewColumnTypeDisallowListRule(level, string(checkCtx.Rule.Type), disallowTypes)
+ rule := NewColumnTypeDisallowListRule(level, checkCtx.Rule.Type.String(), disallowTypes)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_function_disallow_create_or_alter.go b/backend/plugin/advisor/mssql/rule_function_disallow_create_or_alter.go
index 27b1659b6f..2b635d7d03 100644
--- a/backend/plugin/advisor/mssql/rule_function_disallow_create_or_alter.go
+++ b/backend/plugin/advisor/mssql/rule_function_disallow_create_or_alter.go
@@ -13,7 +13,7 @@ import (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleFunctionDisallowCreate, &FunctionDisallowCreateOrAlterAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE, &FunctionDisallowCreateOrAlterAdvisor{})
}
type FunctionDisallowCreateOrAlterAdvisor struct{}
@@ -32,7 +32,7 @@ func (*FunctionDisallowCreateOrAlterAdvisor) Check(_ context.Context, checkCtx a
}
// Create the rule
- rule := NewFunctionDisallowCreateOrAlterRule(level, string(checkCtx.Rule.Type))
+ rule := NewFunctionDisallowCreateOrAlterRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_index_not_redundant.go b/backend/plugin/advisor/mssql/rule_index_not_redundant.go
index e37d24c0b6..c617495026 100644
--- a/backend/plugin/advisor/mssql/rule_index_not_redundant.go
+++ b/backend/plugin/advisor/mssql/rule_index_not_redundant.go
@@ -17,7 +17,7 @@ import (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleIndexNotRedundant, &IndexNotRedundantAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_INDEX_NOT_REDUNDANT, &IndexNotRedundantAdvisor{})
}
var dftMSSQLSchemaName = "dbo"
@@ -42,7 +42,7 @@ func (IndexNotRedundantAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewIndexNotRedundantRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, checkCtx.DBSchema)
+ rule := NewIndexNotRedundantRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, checkCtx.DBSchema)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_migration_compatibility.go b/backend/plugin/advisor/mssql/rule_migration_compatibility.go
index 788703dfa8..7ffd1e2267 100644
--- a/backend/plugin/advisor/mssql/rule_migration_compatibility.go
+++ b/backend/plugin/advisor/mssql/rule_migration_compatibility.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleSchemaBackwardCompatibility, &MigrationCompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &MigrationCompatibilityAdvisor{})
}
// MigrationCompatibilityAdvisor is the advisor checking for migration compatibility.
@@ -41,7 +41,7 @@ func (*MigrationCompatibilityAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewMigrationCompatibilityRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewMigrationCompatibilityRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_naming_identifier_no_keyword.go b/backend/plugin/advisor/mssql/rule_naming_identifier_no_keyword.go
index 7ddc6fcd47..e2b65bc957 100644
--- a/backend/plugin/advisor/mssql/rule_naming_identifier_no_keyword.go
+++ b/backend/plugin/advisor/mssql/rule_naming_identifier_no_keyword.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleIdentifierNoKeyword, &NamingIdentifierNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD, &NamingIdentifierNoKeywordAdvisor{})
}
// NamingIdentifierNoKeywordAdvisor is the advisor checking for identifier naming convention without keyword.
@@ -41,7 +41,7 @@ func (*NamingIdentifierNoKeywordAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewNamingIdentifierNoKeywordRule(level, string(checkCtx.Rule.Type))
+ rule := NewNamingIdentifierNoKeywordRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_naming_table.go b/backend/plugin/advisor/mssql/rule_naming_table.go
index 155a0c36b3..4940e69b70 100644
--- a/backend/plugin/advisor/mssql/rule_naming_table.go
+++ b/backend/plugin/advisor/mssql/rule_naming_table.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableNaming, &NamingTableAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableAdvisor{})
}
// NamingTableAdvisor is the advisor checking for table naming convention..
@@ -46,7 +46,7 @@ func (*NamingTableAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
}
// Create the rule
- rule := NewNamingTableRule(level, string(checkCtx.Rule.Type), format, maxLength)
+ rule := NewNamingTableRule(level, checkCtx.Rule.Type.String(), format, maxLength)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_naming_table_no_keyword.go b/backend/plugin/advisor/mssql/rule_naming_table_no_keyword.go
index 262b75436a..10cf6e28a8 100644
--- a/backend/plugin/advisor/mssql/rule_naming_table_no_keyword.go
+++ b/backend/plugin/advisor/mssql/rule_naming_table_no_keyword.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableNameNoKeyword, &NamingTableNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD, &NamingTableNoKeywordAdvisor{})
}
// NamingTableNoKeywordAdvisor is the advisor checking for table naming convention without keyword.
@@ -41,7 +41,7 @@ func (*NamingTableNoKeywordAdvisor) Check(_ context.Context, checkCtx advisor.Co
}
// Create the rule
- rule := NewNamingTableNoKeywordRule(level, string(checkCtx.Rule.Type))
+ rule := NewNamingTableNoKeywordRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_procedure_disallow_create_or_alter.go b/backend/plugin/advisor/mssql/rule_procedure_disallow_create_or_alter.go
index 9c7b321950..3990c0294f 100644
--- a/backend/plugin/advisor/mssql/rule_procedure_disallow_create_or_alter.go
+++ b/backend/plugin/advisor/mssql/rule_procedure_disallow_create_or_alter.go
@@ -13,7 +13,7 @@ import (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleProcedureDisallowCreate, &ProcedureDisallowCreateOrAlterAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE, &ProcedureDisallowCreateOrAlterAdvisor{})
}
type ProcedureDisallowCreateOrAlterAdvisor struct{}
@@ -31,7 +31,7 @@ func (*ProcedureDisallowCreateOrAlterAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewProcedureDisallowCreateOrAlterRule(level, string(checkCtx.Rule.Type))
+ rule := NewProcedureDisallowCreateOrAlterRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_select_no_select_all.go b/backend/plugin/advisor/mssql/rule_select_no_select_all.go
index cf10a036dd..2721accc55 100644
--- a/backend/plugin/advisor/mssql/rule_select_no_select_all.go
+++ b/backend/plugin/advisor/mssql/rule_select_no_select_all.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleStatementNoSelectAll, &SelectNoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &SelectNoSelectAllAdvisor{})
}
// SelectNoSelectAllAdvisor is the advisor checking for no select all.
@@ -38,7 +38,7 @@ func (*SelectNoSelectAllAdvisor) Check(_ context.Context, checkCtx advisor.Conte
}
// Create the rule
- rule := NewSelectNoSelectAllRule(level, string(checkCtx.Rule.Type))
+ rule := NewSelectNoSelectAllRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_statement_disallow_cross_db_queries.go b/backend/plugin/advisor/mssql/rule_statement_disallow_cross_db_queries.go
index e2c058743f..e74e520aa5 100644
--- a/backend/plugin/advisor/mssql/rule_statement_disallow_cross_db_queries.go
+++ b/backend/plugin/advisor/mssql/rule_statement_disallow_cross_db_queries.go
@@ -16,7 +16,7 @@ import (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleStatementDisallowCrossDBQueries, &DisallowCrossDBQueriesAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES, &DisallowCrossDBQueriesAdvisor{})
}
type DisallowCrossDBQueriesAdvisor struct{}
@@ -34,7 +34,7 @@ func (*DisallowCrossDBQueriesAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewDisallowCrossDBQueriesRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewDisallowCrossDBQueriesRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_statement_where_disallow_functions_and_calculations.go b/backend/plugin/advisor/mssql/rule_statement_where_disallow_functions_and_calculations.go
index 4691fb1d66..e784da60a8 100644
--- a/backend/plugin/advisor/mssql/rule_statement_where_disallow_functions_and_calculations.go
+++ b/backend/plugin/advisor/mssql/rule_statement_where_disallow_functions_and_calculations.go
@@ -14,7 +14,7 @@ import (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleStatementWhereDisallowFunctionsAndCalculations, &DisallowFuncAndCalculationsAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS, &DisallowFuncAndCalculationsAdvisor{})
}
type DisallowFuncAndCalculationsAdvisor struct{}
@@ -34,7 +34,7 @@ func (*DisallowFuncAndCalculationsAdvisor) Check(_ context.Context, checkCtx adv
}
// Create the rule
- rule := NewDisallowFuncAndCalculationsRule(level, string(checkCtx.Rule.Type))
+ rule := NewDisallowFuncAndCalculationsRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_select.go b/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_select.go
index 6cb63351ca..b7c3d2e390 100644
--- a/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_select.go
+++ b/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_select.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequirementForSelectAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequirementForSelectAdvisor{})
}
// WhereRequirementForSelectAdvisor is the advisor checking for WHERE clause requirement for SELECT statements.
@@ -38,7 +38,7 @@ func (*WhereRequirementForSelectAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewWhereRequirementForSelectRule(level, string(checkCtx.Rule.Type))
+ rule := NewWhereRequirementForSelectRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_update_delete.go b/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_update_delete.go
index 9bb24809de..17fa99cff6 100644
--- a/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_update_delete.go
+++ b/backend/plugin/advisor/mssql/rule_statement_where_requirement_for_update_delete.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequirementForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequirementForUpdateDeleteAdvisor{})
}
// WhereRequirementForUpdateDeleteAdvisor is the advisor checking for WHERE clause requirement for UPDATE/DELETE statements.
@@ -38,7 +38,7 @@ func (*WhereRequirementForUpdateDeleteAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewWhereRequirementForUpdateDeleteRule(level, string(checkCtx.Rule.Type))
+ rule := NewWhereRequirementForUpdateDeleteRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_table_disallow_ddl.go b/backend/plugin/advisor/mssql/rule_table_disallow_ddl.go
index 3a2b6b78df..a2a7544fe3 100644
--- a/backend/plugin/advisor/mssql/rule_table_disallow_ddl.go
+++ b/backend/plugin/advisor/mssql/rule_table_disallow_ddl.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableDisallowDDL, &TableDisallowDDLAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_TABLE_DISALLOW_DDL, &TableDisallowDDLAdvisor{})
}
// TableDisallowDDLAdvisor is the advisor checking for disallow DDL on specific tables.
@@ -44,7 +44,7 @@ func (*TableDisallowDDLAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewTableDisallowDDLRule(level, string(checkCtx.Rule.Type), payload.List)
+ rule := NewTableDisallowDDLRule(level, checkCtx.Rule.Type.String(), payload.List)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_table_disallow_dml.go b/backend/plugin/advisor/mssql/rule_table_disallow_dml.go
index 46de21daf4..26f0e67573 100644
--- a/backend/plugin/advisor/mssql/rule_table_disallow_dml.go
+++ b/backend/plugin/advisor/mssql/rule_table_disallow_dml.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableDisallowDML, &TableDisallowDMLAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_TABLE_DISALLOW_DML, &TableDisallowDMLAdvisor{})
}
// TableDisallowDMLAdvisor is the advisor checking for disallow DML on specific tables.
@@ -44,7 +44,7 @@ func (*TableDisallowDMLAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewTableDisallowDMLRule(level, string(checkCtx.Rule.Type), payload.List)
+ rule := NewTableDisallowDMLRule(level, checkCtx.Rule.Type.String(), payload.List)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_table_drop_naming_convention.go b/backend/plugin/advisor/mssql/rule_table_drop_naming_convention.go
index 2d82f30103..1e39baa843 100644
--- a/backend/plugin/advisor/mssql/rule_table_drop_naming_convention.go
+++ b/backend/plugin/advisor/mssql/rule_table_drop_naming_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
}
// TableDropNamingConventionAdvisor is the advisor checking for table drop with naming convention.
@@ -46,7 +46,7 @@ func (*TableDropNamingConventionAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewTableDropNamingConventionRule(level, string(checkCtx.Rule.Type), format)
+ rule := NewTableDropNamingConventionRule(level, checkCtx.Rule.Type.String(), format)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_table_no_foreign_key.go b/backend/plugin/advisor/mssql/rule_table_no_foreign_key.go
index 11e59af64b..9e975d3eea 100644
--- a/backend/plugin/advisor/mssql/rule_table_no_foreign_key.go
+++ b/backend/plugin/advisor/mssql/rule_table_no_foreign_key.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableNoFK, &TableNoForeignKeyAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoForeignKeyAdvisor{})
}
// TableNoForeignKeyAdvisor is the advisor checking for table disallow foreign key..
@@ -42,7 +42,7 @@ func (*TableNoForeignKeyAdvisor) Check(_ context.Context, checkCtx advisor.Conte
}
// Create the rule
- rule := NewTableNoForeignKeyRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableNoForeignKeyRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/rule_table_require_pk.go b/backend/plugin/advisor/mssql/rule_table_require_pk.go
index c2b11f9b48..c019aaaf03 100644
--- a/backend/plugin/advisor/mssql/rule_table_require_pk.go
+++ b/backend/plugin/advisor/mssql/rule_table_require_pk.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MSSQL, advisor.SchemaRuleTableRequirePK, &TableRequirePkAdvisor{})
+ advisor.Register(storepb.Engine_MSSQL, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePkAdvisor{})
}
// TableRequirePkAdvisor is the advisor checking for table require primary key..
@@ -40,7 +40,7 @@ func (*TableRequirePkAdvisor) Check(_ context.Context, checkCtx advisor.Context)
}
// Create the rule
- rule := NewTableRequirePkRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableRequirePkRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mssql/test/column_maximum_varchar_length.yaml b/backend/plugin/advisor/mssql/test/column_maximum_varchar_length.yaml
index a21ff23b87..cdc5e1debf 100644
--- a/backend/plugin/advisor/mssql/test/column_maximum_varchar_length.yaml
+++ b/backend/plugin/advisor/mssql/test/column_maximum_varchar_length.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/column_no_null.yaml b/backend/plugin/advisor/mssql/test/column_no_null.yaml
index 5a201f8838..c2bc2997d1 100644
--- a/backend/plugin/advisor/mssql/test/column_no_null.yaml
+++ b/backend/plugin/advisor/mssql/test/column_no_null.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column [age] is nullable, which is not allowed.
startposition:
line: 4
@@ -17,7 +17,7 @@
endposition: null
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column [address] is nullable, which is not allowed.
startposition:
line: 5
@@ -35,7 +35,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column [address] is nullable, which is not allowed.
startposition:
line: 5
@@ -46,7 +46,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column [name] is nullable, which is not allowed.
startposition:
line: 1
@@ -59,7 +59,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column [age] is nullable, which is not allowed.
startposition:
line: 1
@@ -70,7 +70,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column [age] is nullable, which is not allowed.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/column_required.yaml b/backend/plugin/advisor/mssql/test/column_required.yaml
index b28664eb69..0e0e2021ce 100644
--- a/backend/plugin/advisor/mssql/test/column_required.yaml
+++ b/backend/plugin/advisor/mssql/test/column_required.yaml
@@ -16,7 +16,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "created_ts"
startposition:
line: 1
@@ -24,7 +24,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "creator_id"
startposition:
line: 1
@@ -32,7 +32,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "id"
startposition:
line: 1
@@ -40,7 +40,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "updated_ts"
startposition:
line: 1
@@ -48,7 +48,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "updater_id"
startposition:
line: 1
@@ -65,7 +65,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "updated_ts"
startposition:
line: 1
@@ -76,7 +76,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "created_ts"
startposition:
line: 1
@@ -87,7 +87,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "creator_id"
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/column_type_disallow_list.yaml b/backend/plugin/advisor/mssql/test/column_type_disallow_list.yaml
index 0e4762b2cb..704096413a 100644
--- a/backend/plugin/advisor/mssql/test/column_type_disallow_list.yaml
+++ b/backend/plugin/advisor/mssql/test/column_type_disallow_list.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Column type JSON is disallowed
startposition:
line: 4
diff --git a/backend/plugin/advisor/mssql/test/index_not_redundant.yaml b/backend/plugin/advisor/mssql/test/index_not_redundant.yaml
index 68a13ca18c..a0ee1eb71d 100644
--- a/backend/plugin/advisor/mssql/test/index_not_redundant.yaml
+++ b/backend/plugin/advisor/mssql/test/index_not_redundant.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 817
- title: index.not-redundant
+ title: INDEX_NOT_REDUNDANT
content: Redundant indexes with the same prefix ('idx_0' and 'test_index') in 'dbo.pokes' is not allowed
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 817
- title: index.not-redundant
+ title: INDEX_NOT_REDUNDANT
content: Redundant indexes with the same prefix ('idx_0' and 'test_index') in 'dbo.pokes' is not allowed
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/naming_identifier_no_keyword.yaml b/backend/plugin/advisor/mssql/test/naming_identifier_no_keyword.yaml
index 0f55729cd2..3f4b00ad9c 100644
--- a/backend/plugin/advisor/mssql/test/naming_identifier_no_keyword.yaml
+++ b/backend/plugin/advisor/mssql/test/naming_identifier_no_keyword.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier [exec] is a keyword identifier and should be avoided.
startposition:
line: 1
@@ -13,7 +13,7 @@
endposition: null
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier [fillfactor] is a keyword identifier and should be avoided.
startposition:
line: 1
@@ -21,7 +21,7 @@
endposition: null
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier [add] is a keyword identifier and should be avoided.
startposition:
line: 2
@@ -29,7 +29,7 @@
endposition: null
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier [fillfactor] is a keyword identifier and should be avoided.
startposition:
line: 2
diff --git a/backend/plugin/advisor/mssql/test/naming_table.yaml b/backend/plugin/advisor/mssql/test/naming_table.yaml
index e5f86ad672..fb4f988091 100644
--- a/backend/plugin/advisor/mssql/test/naming_table.yaml
+++ b/backend/plugin/advisor/mssql/test/naming_table.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '[\\] mismatches table naming convention, naming format should be "^[A-Z]([_A-Za-z])*$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: all_lowercase mismatches table naming convention, naming format should be "^[A-Z]([_A-Za-z])*$"
startposition:
line: 1
@@ -31,7 +31,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: salesTerr mismatches table naming convention, naming format should be "^[A-Z]([_A-Za-z])*$"
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/naming_table_no_keyword.yaml b/backend/plugin/advisor/mssql/test/naming_table_no_keyword.yaml
index d7234c09dd..d2ccb628f5 100644
--- a/backend/plugin/advisor/mssql/test/naming_table_no_keyword.yaml
+++ b/backend/plugin/advisor/mssql/test/naming_table_no_keyword.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name [fillfactor] is a reserved keyword and should be avoided.
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name [fillfactor] is a reserved keyword and should be avoided.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/schema_backward_compatibility.yaml b/backend/plugin/advisor/mssql/test/schema_backward_compatibility.yaml
index e825f15abf..02d67cb567 100644
--- a/backend/plugin/advisor/mssql/test/schema_backward_compatibility.yaml
+++ b/backend/plugin/advisor/mssql/test/schema_backward_compatibility.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 102
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: sp_rename may cause incompatibility with the existing data and code, and break scripts and stored procedures.
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 112
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop table master.dbo.MyTable may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 112
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop schema master.myschema may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -44,7 +44,7 @@
want:
- status: 2
code: 112
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop database mydb may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -68,7 +68,7 @@
want:
- status: 2
code: 112
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop column mycolumnone, mycolumntwo may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -76,7 +76,7 @@
endposition: null
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Alter COLUMN mycolumnone may cause incompatibility with the existing data and code
startposition:
line: 2
@@ -84,7 +84,7 @@
endposition: null
- status: 2
code: 106
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Add PRIMARY KEY may cause incompatibility with the existing data and code
startposition:
line: 3
@@ -92,7 +92,7 @@
endposition: null
- status: 2
code: 107
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Add UNIQUE KEY may cause incompatibility with the existing data and code
startposition:
line: 4
@@ -100,7 +100,7 @@
endposition: null
- status: 2
code: 109
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Add CHECK may cause incompatibility with the existing data and code
startposition:
line: 5
@@ -108,7 +108,7 @@
endposition: null
- status: 2
code: 108
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Add CHECK WITH NO CHECK may cause incompatibility with the existing data and code
startposition:
line: 6
@@ -116,7 +116,7 @@
endposition: null
- status: 2
code: 108
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Add FOREIGN KEY WITH NO CHECK may cause incompatibility with the existing data and code
startposition:
line: 8
@@ -127,7 +127,7 @@
want:
- status: 2
code: 102
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: sp_rename may cause incompatibility with the existing data and code, and break scripts and stored procedures.
startposition:
line: 1
@@ -138,7 +138,7 @@
want:
- status: 2
code: 102
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: sp_rename may cause incompatibility with the existing data and code, and break scripts and stored procedures.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/statement_disallow_cross_db_queries.yaml b/backend/plugin/advisor/mssql/test/statement_disallow_cross_db_queries.yaml
index 73418c0efe..21121e3618 100644
--- a/backend/plugin/advisor/mssql/test/statement_disallow_cross_db_queries.yaml
+++ b/backend/plugin/advisor/mssql/test/statement_disallow_cross_db_queries.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 233
- title: statement.disallow-cross-db-queries
+ title: STATEMENT_DISALLOW_CROSS_DB_QUERIES
content: 'Cross database queries (target databse: ''master2'', current database: ''master'') are prohibited'
startposition:
line: 1
@@ -21,7 +21,7 @@
want:
- status: 2
code: 233
- title: statement.disallow-cross-db-queries
+ title: STATEMENT_DISALLOW_CROSS_DB_QUERIES
content: 'Cross database queries (target databse: ''master'', current database: ''master2'') are prohibited'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mssql/test/statement_select_no_select_all.yaml b/backend/plugin/advisor/mssql/test/statement_select_no_select_all.yaml
index 91130b858f..d8fe22afba 100644
--- a/backend/plugin/advisor/mssql/test/statement_select_no_select_all.yaml
+++ b/backend/plugin/advisor/mssql/test/statement_select_no_select_all.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/statement_where_disallow_functions_and_calculations.yaml b/backend/plugin/advisor/mssql/test/statement_where_disallow_functions_and_calculations.yaml
index b4ae973ec5..63d8cc721f 100644
--- a/backend/plugin/advisor/mssql/test/statement_where_disallow_functions_and_calculations.yaml
+++ b/backend/plugin/advisor/mssql/test/statement_where_disallow_functions_and_calculations.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 234
- title: statement.where.disallow-functions-and-calculations
+ title: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
content: Performing calculations in 'WHERE' clause is not allowed
startposition:
line: 2
@@ -15,7 +15,7 @@
endposition: null
- status: 2
code: 234
- title: statement.where.disallow-functions-and-calculations
+ title: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
content: Performing calculations in 'WHERE' clause is not allowed
startposition:
line: 4
@@ -28,7 +28,7 @@
want:
- status: 2
code: 234
- title: statement.where.disallow-functions-and-calculations
+ title: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
content: Performing calculations in 'WHERE' clause is not allowed
startposition:
line: 1
@@ -36,7 +36,7 @@
endposition: null
- status: 2
code: 234
- title: statement.where.disallow-functions-and-calculations
+ title: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
content: Calling function 'AVG(bar)' in 'WHERE' clause is not allowed
startposition:
line: 2
@@ -55,7 +55,7 @@
want:
- status: 2
code: 234
- title: statement.where.disallow-functions-and-calculations
+ title: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
content: Calling function 'AVG(a)' in 'WHERE' clause is not allowed
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/statement_where_require_select.yaml b/backend/plugin/advisor/mssql/test/statement_where_require_select.yaml
index d66d2254ad..3e5f157282 100644
--- a/backend/plugin/advisor/mssql/test/statement_where_require_select.yaml
+++ b/backend/plugin/advisor/mssql/test/statement_where_require_select.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELETE statement.
startposition:
line: 1
@@ -19,7 +19,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELETE statement.
startposition:
line: 2
@@ -27,7 +27,7 @@
endposition: null
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELETE statement.
startposition:
line: 3
diff --git a/backend/plugin/advisor/mssql/test/statement_where_require_update_delete.yaml b/backend/plugin/advisor/mssql/test/statement_where_require_update_delete.yaml
index 6546c8abbd..1301172bf0 100644
--- a/backend/plugin/advisor/mssql/test/statement_where_require_update_delete.yaml
+++ b/backend/plugin/advisor/mssql/test/statement_where_require_update_delete.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: WHERE clause is required for UPDATE statement.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: WHERE clause is required for DELETE statement.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/system_function_disallow_create.yaml b/backend/plugin/advisor/mssql/test/system_function_disallow_create.yaml
index b4e23edaf6..49b82e063b 100644
--- a/backend/plugin/advisor/mssql/test/system_function_disallow_create.yaml
+++ b/backend/plugin/advisor/mssql/test/system_function_disallow_create.yaml
@@ -17,7 +17,7 @@
want:
- status: 2
code: 1701
- title: system.function.disallow-create
+ title: SYSTEM_FUNCTION_DISALLOW_CREATE
content: Creating or altering functions is prohibited
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/system_procedure_disallow_create.yaml b/backend/plugin/advisor/mssql/test/system_procedure_disallow_create.yaml
index 5795e30bf7..ab1fe60e9d 100644
--- a/backend/plugin/advisor/mssql/test/system_procedure_disallow_create.yaml
+++ b/backend/plugin/advisor/mssql/test/system_procedure_disallow_create.yaml
@@ -21,7 +21,7 @@
want:
- status: 2
code: 1401
- title: system.procedure.disallow-create
+ title: SYSTEM_PROCEDURE_DISALLOW_CREATE
content: Creating or altering procedures is prohibited
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/table_disallow_ddl.yaml b/backend/plugin/advisor/mssql/test/table_disallow_ddl.yaml
index 8c2f521f3a..6277ffb648 100644
--- a/backend/plugin/advisor/mssql/test/table_disallow_ddl.yaml
+++ b/backend/plugin/advisor/mssql/test/table_disallow_ddl.yaml
@@ -11,7 +11,7 @@
want:
- status: 2
code: 613
- title: table.disallow-ddl
+ title: TABLE_DISALLOW_DDL
content: DDL is disallowed on table MySchema.Identifier.
startposition:
line: 5
diff --git a/backend/plugin/advisor/mssql/test/table_disallow_dml.yaml b/backend/plugin/advisor/mssql/test/table_disallow_dml.yaml
index 9533cf0a03..5b9f6b21f2 100644
--- a/backend/plugin/advisor/mssql/test/table_disallow_dml.yaml
+++ b/backend/plugin/advisor/mssql/test/table_disallow_dml.yaml
@@ -6,7 +6,7 @@
want:
- status: 2
code: 614
- title: table.disallow-dml
+ title: TABLE_DISALLOW_DML
content: DML is disallowed on table MySchema.Identifier.
startposition:
line: 1
@@ -19,7 +19,7 @@
want:
- status: 2
code: 614
- title: table.disallow-dml
+ title: TABLE_DISALLOW_DML
content: DML is disallowed on table MySchema.Identifier.
startposition:
line: 2
@@ -30,7 +30,7 @@
want:
- status: 2
code: 614
- title: table.disallow-dml
+ title: TABLE_DISALLOW_DML
content: DML is disallowed on table MySchema.Identifier.
startposition:
line: 1
@@ -41,7 +41,7 @@
want:
- status: 2
code: 614
- title: table.disallow-dml
+ title: TABLE_DISALLOW_DML
content: DML is disallowed on table MySchema.Identifier.
startposition:
line: 1
@@ -52,7 +52,7 @@
want:
- status: 2
code: 614
- title: table.disallow-dml
+ title: TABLE_DISALLOW_DML
content: DML is disallowed on table MySchema.Identifier.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/table_drop_naming_convention.yaml b/backend/plugin/advisor/mssql/test/table_drop_naming_convention.yaml
index ebe710aa5d..1830022b87 100644
--- a/backend/plugin/advisor/mssql/test/table_drop_naming_convention.yaml
+++ b/backend/plugin/advisor/mssql/test/table_drop_naming_convention.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '[foo] mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '[foo] mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/mssql/test/table_no_foreign_key.yaml b/backend/plugin/advisor/mssql/test/table_no_foreign_key.yaml
index 49ca2ac3a1..d4d0879115 100644
--- a/backend/plugin/advisor/mssql/test/table_no_foreign_key.yaml
+++ b/backend/plugin/advisor/mssql/test/table_no_foreign_key.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table MyTable.
startposition:
line: 3
@@ -27,7 +27,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table Customer.
startposition:
line: 6
@@ -45,7 +45,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table Customer.
startposition:
line: 7
diff --git a/backend/plugin/advisor/mssql/test/table_require_pk.yaml b/backend/plugin/advisor/mssql/test/table_require_pk.yaml
index aec424a9ea..e6376bdef0 100644
--- a/backend/plugin/advisor/mssql/test/table_require_pk.yaml
+++ b/backend/plugin/advisor/mssql/test/table_require_pk.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table MySchema.MyTable requires PRIMARY KEY.
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/mysql_rules_test.go b/backend/plugin/advisor/mysql/mysql_rules_test.go
index 0b5f33a700..58f35a8863 100644
--- a/backend/plugin/advisor/mysql/mysql_rules_test.go
+++ b/backend/plugin/advisor/mysql/mysql_rules_test.go
@@ -8,161 +8,161 @@ import (
)
func TestMySQLRules(t *testing.T) {
- mysqlRules := []advisor.SQLReviewRuleType{
- // advisor.SchemaRuleMySQLEngine enforce the innodb engine.
- advisor.SchemaRuleMySQLEngine,
+ mysqlRules := []storepb.SQLReviewRule_Type{
+ // storepb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB enforce the innodb engine.
+ storepb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB,
// Naming related rules.
- // advisor.SchemaRuleTableNaming enforce the table name format.
- advisor.SchemaRuleTableNaming,
- // advisor.SchemaRuleColumnNaming enforce the column name format.
- advisor.SchemaRuleColumnNaming,
- // advisor.SchemaRuleUKNaming enforce the unique key name format.
- advisor.SchemaRuleUKNaming,
- // advisor.SchemaRuleFKNaming enforce the foreign key name format.
- advisor.SchemaRuleFKNaming,
- // advisor.SchemaRuleIDXNaming enforce the index name format.
- advisor.SchemaRuleIDXNaming,
- // advisor.SchemaRuleAutoIncrementColumnNaming enforce the auto_increment column name format.
- advisor.SchemaRuleAutoIncrementColumnNaming,
- // advisor.SchemaRuleIdentifierNoKeyword enforce the identifier no keyword.
- advisor.SchemaRuleIdentifierNoKeyword,
+ // storepb.SQLReviewRule_NAMING_TABLE enforce the table name format.
+ storepb.SQLReviewRule_NAMING_TABLE,
+ // storepb.SQLReviewRule_NAMING_COLUMN enforce the column name format.
+ storepb.SQLReviewRule_NAMING_COLUMN,
+ // storepb.SQLReviewRule_NAMING_INDEX_UK enforce the unique key name format.
+ storepb.SQLReviewRule_NAMING_INDEX_UK,
+ // storepb.SQLReviewRule_NAMING_INDEX_FK enforce the foreign key name format.
+ storepb.SQLReviewRule_NAMING_INDEX_FK,
+ // storepb.SQLReviewRule_NAMING_INDEX_IDX enforce the index name format.
+ storepb.SQLReviewRule_NAMING_INDEX_IDX,
+ // storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT enforce the auto_increment column name format.
+ storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT,
+ // storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD enforce the identifier no keyword.
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD,
// Statement related rules.
- // advisor.SchemaRuleStatementNoSelectAll disallow 'SELECT *'.
- advisor.SchemaRuleStatementNoSelectAll,
- // advisor.SchemaRuleStatementRequireWhereForSelect require 'WHERE' clause for SELECT statement.
- advisor.SchemaRuleStatementRequireWhereForSelect,
- // advisor.SchemaRuleStatementRequireWhereForUpdateDelete require 'WHERE' clause for UPDATE/DELETE statement.
- advisor.SchemaRuleStatementRequireWhereForUpdateDelete,
- // advisor.SchemaRuleStatementNoLeadingWildcardLike disallow leading '%' in LIKE, e.g. LIKE foo = '%x' is not allowed.
- advisor.SchemaRuleStatementNoLeadingWildcardLike,
- // advisor.SchemaRuleStatementDisallowCommit disallow using commit in the issue.
- advisor.SchemaRuleStatementDisallowCommit,
- // advisor.SchemaRuleStatementDisallowLimit disallow the LIMIT clause in INSERT, DELETE and UPDATE statements.
- advisor.SchemaRuleStatementDisallowLimit,
- // advisor.SchemaRuleStatementDisallowOrderBy disallow the ORDER BY clause in DELETE and UPDATE statements.
- advisor.SchemaRuleStatementDisallowOrderBy,
- // advisor.SchemaRuleStatementMergeAlterTable disallow redundant ALTER TABLE statements.
- advisor.SchemaRuleStatementMergeAlterTable,
- // advisor.SchemaRuleStatementInsertRowLimit enforce the insert row limit.
- advisor.SchemaRuleStatementInsertRowLimit,
- // advisor.SchemaRuleStatementInsertMustSpecifyColumn enforce the insert column specified.
- advisor.SchemaRuleStatementInsertMustSpecifyColumn,
- // advisor.SchemaRuleStatementInsertDisallowOrderByRand disallow the order by rand in the INSERT statement.
- advisor.SchemaRuleStatementInsertDisallowOrderByRand,
- // advisor.SchemaRuleStatementAffectedRowLimit enforce the UPDATE/DELETE affected row limit.
- advisor.SchemaRuleStatementAffectedRowLimit,
- // advisor.SchemaRuleStatementDMLDryRun dry run the dml.
- advisor.SchemaRuleStatementDMLDryRun,
+ // storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL disallow 'SELECT *'.
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT require 'WHERE' clause for SELECT statement.
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE require 'WHERE' clause for UPDATE/DELETE statement.
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE disallow leading '%' in LIKE, e.g. LIKE foo = '%x' is not allowed.
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
+ // storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT disallow using commit in the issue.
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,
+ // storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT disallow the LIMIT clause in INSERT, DELETE and UPDATE statements.
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT,
+ // storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY disallow the ORDER BY clause in DELETE and UPDATE statements.
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY,
+ // storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE disallow redundant ALTER TABLE statements.
+ storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,
+ // storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT enforce the insert row limit.
+ storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT,
+ // storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN enforce the insert column specified.
+ storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,
+ // storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND disallow the order by rand in the INSERT statement.
+ storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,
+ // storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT enforce the UPDATE/DELETE affected row limit.
+ storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT,
+ // storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN dry run the dml.
+ storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN,
// advisor.SchemaRuleStatementNoEqualNull disallow the equal null.
- advisor.SchemaRuleStatementWhereNoEqualNull,
- // advisor.SchemaRuleStatementMaximumLimitValue enforce the maximum limit value.
- advisor.SchemaRuleStatementMaximumLimitValue,
- // advisor.SchemaRuleStatementMaximumJoinTableCount enforces maximum of tables in the joins.
- advisor.SchemaRuleStatementMaximumJoinTableCount,
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL,
+ // storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE enforce the maximum limit value.
+ storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE,
+ // storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT enforces maximum of tables in the joins.
+ storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT,
// advisor.SchemaRuleStatementWhereDisallowUsingFunction disallow using function in where clause.
- advisor.SchemaRuleStatementWhereDisallowFunctionsAndCalculations,
- // advisor.SchemaRuleStatementWhereMaximumLogicalOperatorCount enforces maximum number of logical operators in the where clause.
- advisor.SchemaRuleStatementWhereMaximumLogicalOperatorCount,
- // advisor.SchemaRuleStatementMaxExecutionTime enforce the maximum execution time.
- advisor.SchemaRuleStatementMaxExecutionTime,
- // advisor.SchemaRuleStatementRequireAlgorithmOption require the algorithm option in the alter table statement.
- advisor.SchemaRuleStatementRequireAlgorithmOption,
- // advisor.SchemaRuleStatementRequireLockOption require the lock option in the alter table statement.
- advisor.SchemaRuleStatementRequireLockOption,
+ storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT enforces maximum number of logical operators in the where clause.
+ storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT,
+ // storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME enforce the maximum execution time.
+ storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME,
+ // storepb.SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION require the algorithm option in the alter table statement.
+ storepb.SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION,
+ // storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION require the lock option in the alter table statement.
+ storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION,
// Database related rules.
- // advisor.SchemaRuleDropEmptyDatabase enforce the MySQL support check if the database is empty before users drop it.
- advisor.SchemaRuleDropEmptyDatabase,
+ // storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE enforce the MySQL support check if the database is empty before users drop it.
+ storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE,
// Table related rules.
- // advisor.SchemaRuleTableRequirePK require the table to have a primary key.
- advisor.SchemaRuleTableRequirePK,
- // advisor.SchemaRuleTableNoFK require the table disallow the foreign key.
- advisor.SchemaRuleTableNoFK,
- // advisor.SchemaRuleTableDropNamingConvention require only the table following the naming convention can be deleted.
- advisor.SchemaRuleTableDropNamingConvention,
- // advisor.SchemaRuleTableCommentConvention enforce the table comment convention.
- advisor.SchemaRuleTableCommentConvention,
- // advisor.SchemaRuleTableDisallowPartition disallow the table partition.
- advisor.SchemaRuleTableDisallowPartition,
- // advisor.SchemaRuleTableDisallowTrigger disallow the table trigger.
- advisor.SchemaRuleTableDisallowTrigger,
- // advisor.SchemaRuleTableNoDuplicateIndex require the table no duplicate index.
- advisor.SchemaRuleTableNoDuplicateIndex,
- // advisor.SchemaRuleTableDisallowSetCharset disallow set table charset when creating/altering table.
- advisor.SchemaRuleTableDisallowSetCharset,
+ // storepb.SQLReviewRule_TABLE_REQUIRE_PK require the table to have a primary key.
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ // storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY require the table disallow the foreign key.
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ // storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION require only the table following the naming convention can be deleted.
+ storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
+ // storepb.SQLReviewRule_TABLE_COMMENT enforce the table comment convention.
+ storepb.SQLReviewRule_TABLE_COMMENT,
+ // storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION disallow the table partition.
+ storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION,
+ // storepb.SQLReviewRule_TABLE_DISALLOW_TRIGGER disallow the table trigger.
+ storepb.SQLReviewRule_TABLE_DISALLOW_TRIGGER,
+ // storepb.SQLReviewRule_TABLE_NO_DUPLICATE_INDEX require the table no duplicate index.
+ storepb.SQLReviewRule_TABLE_NO_DUPLICATE_INDEX,
+ // storepb.SQLReviewRule_TABLE_DISALLOW_SET_CHARSET disallow set table charset when creating/altering table.
+ storepb.SQLReviewRule_TABLE_DISALLOW_SET_CHARSET,
// Column related rules.
- // advisor.SchemaRuleRequiredColumn enforce the required columns in each table.
- advisor.SchemaRuleRequiredColumn,
- // advisor.SchemaRuleColumnNotNull enforce the columns cannot have NULL value.
- advisor.SchemaRuleColumnNotNull,
- // advisor.SchemaRuleColumnDisallowChangeType disallow change column type.
- advisor.SchemaRuleColumnDisallowChangeType,
- // advisor.SchemaRuleColumnSetDefaultForNotNull require the not null column to set default value.
- advisor.SchemaRuleColumnSetDefaultForNotNull,
- // advisor.SchemaRuleColumnDisallowChange disallow CHANGE COLUMN statement.
- advisor.SchemaRuleColumnDisallowChange,
- // advisor.SchemaRuleColumnDisallowChangingOrder disallow changing column order.
- advisor.SchemaRuleColumnDisallowChangingOrder,
- // advisor.SchemaRuleColumnDisallowDropIndex disallow drop index column.
- advisor.SchemaRuleColumnDisallowDropInIndex,
- // advisor.SchemaRuleColumnCommentConvention enforce the column comment convention.
- advisor.SchemaRuleColumnCommentConvention,
- // advisor.SchemaRuleColumnAutoIncrementMustInteger require the auto-increment column to be integer.
- advisor.SchemaRuleColumnAutoIncrementMustInteger,
- // advisor.SchemaRuleColumnTypeDisallowList enforce the column type disallow list.
- advisor.SchemaRuleColumnTypeDisallowList,
- // advisor.SchemaRuleColumnDisallowSetCharset disallow set column charset.
- advisor.SchemaRuleColumnDisallowSetCharset,
- // advisor.SchemaRuleColumnMaximumCharacterLength enforce the maximum character length.
- advisor.SchemaRuleColumnMaximumCharacterLength,
- // advisor.SchemaRuleColumnMaximumCharacterLength enforce the maximum varchar length.
- advisor.SchemaRuleColumnMaximumVarcharLength,
- // advisor.SchemaRuleColumnAutoIncrementInitialValue enforce the initial auto-increment value.
- advisor.SchemaRuleColumnAutoIncrementInitialValue,
- // advisor.SchemaRuleColumnAutoIncrementMustUnsigned enforce the auto-increment column to be unsigned.
- advisor.SchemaRuleColumnAutoIncrementMustUnsigned,
- // advisor.SchemaRuleColumnRequireDefault enforce the column default.
- advisor.SchemaRuleColumnRequireDefault,
+ // storepb.SQLReviewRule_COLUMN_REQUIRED enforce the required columns in each table.
+ storepb.SQLReviewRule_COLUMN_REQUIRED,
+ // storepb.SQLReviewRule_COLUMN_NO_NULL enforce the columns cannot have NULL value.
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE disallow change column type.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,
+ // storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL require the not null column to set default value.
+ storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE disallow CHANGE COLUMN statement.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER disallow changing column order.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_DROPIndex disallow drop index column.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX,
+ // storepb.SQLReviewRule_COLUMN_COMMENT enforce the column comment convention.
+ storepb.SQLReviewRule_COLUMN_COMMENT,
+ // storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER require the auto-increment column to be integer.
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER,
+ // storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST enforce the column type disallow list.
+ storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET disallow set column charset.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET,
+ // storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH enforce the maximum character length.
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,
+ // storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH enforce the maximum varchar length.
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH,
+ // storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE enforce the initial auto-increment value.
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE,
+ // storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED enforce the auto-increment column to be unsigned.
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED,
+ // storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT enforce the column default.
+ storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,
// Index related rules.
- // advisor.SchemaRuleIndexNoDuplicateColumn require the index no duplicate column.
- advisor.SchemaRuleIndexNoDuplicateColumn,
- // advisor.SchemaRuleIndexKeyNumberLimit enforce the index key number limit.
- advisor.SchemaRuleIndexKeyNumberLimit,
- // advisor.SchemaRuleIndexPKTypeLimit enforce the type restriction of columns in primary key.
- advisor.SchemaRuleIndexPKTypeLimit,
- // advisor.SchemaRuleIndexTypeNoBlob enforce the type restriction of columns in index.
- advisor.SchemaRuleIndexTypeNoBlob,
- // advisor.SchemaRuleIndexTotalNumberLimit enforce the index total number limit.
- advisor.SchemaRuleIndexTotalNumberLimit,
- // advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist enforce the primary key type allowlist.
- advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist,
- // advisor.SchemaRuleIndexTypeAllowList enforce the index type allowlist.
- advisor.SchemaRuleIndexTypeAllowList,
+ // storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN require the index no duplicate column.
+ storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,
+ // storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT enforce the index key number limit.
+ storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,
+ // storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT enforce the type restriction of columns in primary key.
+ storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT,
+ // storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB enforce the type restriction of columns in index.
+ storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB,
+ // storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT enforce the index total number limit.
+ storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,
+ // storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST enforce the primary key type allowlist.
+ storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST,
+ // storepb.SQLReviewRule_INDEX_TYPE_ALLOW_LIST enforce the index type allowlist.
+ storepb.SQLReviewRule_INDEX_TYPE_ALLOW_LIST,
// System related rules.
- // advisor.SchemaRuleSchemaBackwardCompatibility enforce the MySQL and TiDB support check whether the schema change is backward compatible.
- advisor.SchemaRuleSchemaBackwardCompatibility,
- // advisor.SchemaRuleCurrentTimeColumnCountLimit enforce the current column count limit.
- advisor.SchemaRuleCurrentTimeColumnCountLimit,
- // advisor.SchemaRuleCharsetAllowlist enforce the charset allowlist.
- advisor.SchemaRuleCharsetAllowlist,
- // advisor.SchemaRuleCollationAllowlist enforce the collation allowlist.
- advisor.SchemaRuleCollationAllowlist,
+ // storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY enforce the MySQL and TiDB support check whether the schema change is backward compatible.
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
+ // storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT enforce the current column count limit.
+ storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT,
+ // storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST enforce the charset allowlist.
+ storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST,
+ // storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST enforce the collation allowlist.
+ storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST,
// advisor.SchemaRuleDisallowProcedure enforce the disallow create procedure.
- advisor.SchemaRuleProcedureDisallowCreate,
+ storepb.SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE,
// advisor.SchemaRuleDisallowEvent enforce the disallow create event.
- advisor.SchemaRuleEventDisallowCreate,
+ storepb.SQLReviewRule_SYSTEM_EVENT_DISALLOW_CREATE,
// advisor.SchemaRuleDisallowView enforce the disallow create view.
- advisor.SchemaRuleViewDisallowCreate,
- // advisor.SchemaRuleFunctionDisallowCreate enforce the disallow create function.
- advisor.SchemaRuleFunctionDisallowCreate,
- // advisor.SchemaRuleFunctionDisallowList enforce the function disallow list.
- advisor.SchemaRuleFunctionDisallowList,
+ storepb.SQLReviewRule_SYSTEM_VIEW_DISALLOW_CREATE,
+ // storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE enforce the disallow create function.
+ storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE,
+ // storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST enforce the function disallow list.
+ storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST,
}
for _, rule := range mysqlRules {
diff --git a/backend/plugin/advisor/mysql/rule_builtin_prior_backup_check.go b/backend/plugin/advisor/mysql/rule_builtin_prior_backup_check.go
index b2cb443ba4..dd514662bb 100644
--- a/backend/plugin/advisor/mysql/rule_builtin_prior_backup_check.go
+++ b/backend/plugin/advisor/mysql/rule_builtin_prior_backup_check.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.BuiltinRulePriorBackupCheck, &StatementPriorBackupCheckAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK, &StatementPriorBackupCheckAdvisor{})
}
type StatementPriorBackupCheckAdvisor struct {
@@ -42,7 +42,7 @@ func (*StatementPriorBackupCheckAdvisor) Check(ctx context.Context, checkCtx adv
if err != nil {
return nil, err
}
- title := string(checkCtx.Rule.Type)
+ title := checkCtx.Rule.Type.String()
if len(checkCtx.Statements) > common.MaxSheetCheckSize {
adviceList = append(adviceList, &storepb.Advice{
diff --git a/backend/plugin/advisor/mysql/rule_charset_allowlist.go b/backend/plugin/advisor/mysql/rule_charset_allowlist.go
index 28e51bac1f..a7e3af7c42 100644
--- a/backend/plugin/advisor/mysql/rule_charset_allowlist.go
+++ b/backend/plugin/advisor/mysql/rule_charset_allowlist.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleCharsetAllowlist, &CharsetAllowlistAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleCharsetAllowlist, &CharsetAllowlistAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleCharsetAllowlist, &CharsetAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST, &CharsetAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST, &CharsetAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST, &CharsetAllowlistAdvisor{})
}
// CharsetAllowlistAdvisor is the advisor checking for charset allowlist.
@@ -51,7 +51,7 @@ func (*CharsetAllowlistAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewCharsetAllowlistRule(level, string(checkCtx.Rule.Type), allowList)
+ rule := NewCharsetAllowlistRule(level, checkCtx.Rule.Type.String(), allowList)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_collation_allowlist.go b/backend/plugin/advisor/mysql/rule_collation_allowlist.go
index e592b10072..808a748a0c 100644
--- a/backend/plugin/advisor/mysql/rule_collation_allowlist.go
+++ b/backend/plugin/advisor/mysql/rule_collation_allowlist.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleCollationAllowlist, &CollationAllowlistAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleCollationAllowlist, &CollationAllowlistAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleCollationAllowlist, &CollationAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST, &CollationAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST, &CollationAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST, &CollationAllowlistAdvisor{})
}
// CollationAllowlistAdvisor is the advisor checking for collation allowlist.
@@ -47,7 +47,7 @@ func (*CollationAllowlistAdvisor) Check(_ context.Context, checkCtx advisor.Cont
}
// Create the rule
- rule := NewCollationAllowlistRule(level, string(checkCtx.Rule.Type), payload.List)
+ rule := NewCollationAllowlistRule(level, checkCtx.Rule.Type.String(), payload.List)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_auto_increment_initial_value.go b/backend/plugin/advisor/mysql/rule_column_auto_increment_initial_value.go
index b503f64a6d..189b2df1b1 100644
--- a/backend/plugin/advisor/mysql/rule_column_auto_increment_initial_value.go
+++ b/backend/plugin/advisor/mysql/rule_column_auto_increment_initial_value.go
@@ -23,9 +23,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnAutoIncrementInitialValue, &ColumnAutoIncrementInitialValueAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnAutoIncrementInitialValue, &ColumnAutoIncrementInitialValueAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnAutoIncrementInitialValue, &ColumnAutoIncrementInitialValueAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE, &ColumnAutoIncrementInitialValueAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE, &ColumnAutoIncrementInitialValueAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE, &ColumnAutoIncrementInitialValueAdvisor{})
}
// ColumnAutoIncrementInitialValueAdvisor is the advisor checking for auto-increment column initial value.
@@ -50,7 +50,7 @@ func (*ColumnAutoIncrementInitialValueAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewColumnAutoIncrementInitialValueRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewColumnAutoIncrementInitialValueRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_auto_increment_must_integer.go b/backend/plugin/advisor/mysql/rule_column_auto_increment_must_integer.go
index bda7bf238f..e318924fde 100644
--- a/backend/plugin/advisor/mysql/rule_column_auto_increment_must_integer.go
+++ b/backend/plugin/advisor/mysql/rule_column_auto_increment_must_integer.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnAutoIncrementMustInteger, &ColumnAutoIncrementMustIntegerAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnAutoIncrementMustInteger, &ColumnAutoIncrementMustIntegerAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnAutoIncrementMustInteger, &ColumnAutoIncrementMustIntegerAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER, &ColumnAutoIncrementMustIntegerAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER, &ColumnAutoIncrementMustIntegerAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER, &ColumnAutoIncrementMustIntegerAdvisor{})
}
// ColumnAutoIncrementMustIntegerAdvisor is the advisor checking for auto-increment column type.
@@ -45,7 +45,7 @@ func (*ColumnAutoIncrementMustIntegerAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewColumnAutoIncrementMustIntegerRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnAutoIncrementMustIntegerRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_auto_increment_must_unsigned.go b/backend/plugin/advisor/mysql/rule_column_auto_increment_must_unsigned.go
index 1d2cdc3680..42768c23b2 100644
--- a/backend/plugin/advisor/mysql/rule_column_auto_increment_must_unsigned.go
+++ b/backend/plugin/advisor/mysql/rule_column_auto_increment_must_unsigned.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnAutoIncrementMustUnsigned, &ColumnAutoIncrementMustUnsignedAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnAutoIncrementMustUnsigned, &ColumnAutoIncrementMustUnsignedAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnAutoIncrementMustUnsigned, &ColumnAutoIncrementMustUnsignedAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED, &ColumnAutoIncrementMustUnsignedAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED, &ColumnAutoIncrementMustUnsignedAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED, &ColumnAutoIncrementMustUnsignedAdvisor{})
}
// ColumnAutoIncrementMustUnsignedAdvisor is the advisor checking for unsigned auto-increment column.
@@ -45,7 +45,7 @@ func (*ColumnAutoIncrementMustUnsignedAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewColumnAutoIncrementMustUnsignedRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnAutoIncrementMustUnsignedRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_comment_convention.go b/backend/plugin/advisor/mysql/rule_column_comment_convention.go
index 52c48c5927..a5f9a7be49 100644
--- a/backend/plugin/advisor/mysql/rule_column_comment_convention.go
+++ b/backend/plugin/advisor/mysql/rule_column_comment_convention.go
@@ -19,9 +19,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnCommentConvention, &ColumnCommentConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnCommentConvention, &ColumnCommentConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnCommentConvention, &ColumnCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_COMMENT, &ColumnCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_COMMENT, &ColumnCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_COMMENT, &ColumnCommentConventionAdvisor{})
}
// ColumnCommentConventionAdvisor is the advisor checking for column comment convention.
@@ -46,7 +46,7 @@ func (*ColumnCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor
}
// Create the rule
- rule := NewColumnCommentConventionRule(level, string(checkCtx.Rule.Type), payload)
+ rule := NewColumnCommentConventionRule(level, checkCtx.Rule.Type.String(), payload)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_current_time_count_limit.go b/backend/plugin/advisor/mysql/rule_column_current_time_count_limit.go
index ecac2f546f..61c3f7b459 100644
--- a/backend/plugin/advisor/mysql/rule_column_current_time_count_limit.go
+++ b/backend/plugin/advisor/mysql/rule_column_current_time_count_limit.go
@@ -27,9 +27,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleCurrentTimeColumnCountLimit, &ColumnCurrentTimeCountLimitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleCurrentTimeColumnCountLimit, &ColumnCurrentTimeCountLimitAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleCurrentTimeColumnCountLimit, &ColumnCurrentTimeCountLimitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT, &ColumnCurrentTimeCountLimitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT, &ColumnCurrentTimeCountLimitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT, &ColumnCurrentTimeCountLimitAdvisor{})
}
// ColumnCurrentTimeCountLimitAdvisor is the advisor checking for current time column count limit.
@@ -50,7 +50,7 @@ func (*ColumnCurrentTimeCountLimitAdvisor) Check(_ context.Context, checkCtx adv
}
// Create the rule
- rule := NewColumnCurrentTimeCountLimitRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnCurrentTimeCountLimitRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_disallow_changing.go b/backend/plugin/advisor/mysql/rule_column_disallow_changing.go
index b9d65e6288..d44a99dcf4 100644
--- a/backend/plugin/advisor/mysql/rule_column_disallow_changing.go
+++ b/backend/plugin/advisor/mysql/rule_column_disallow_changing.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnDisallowChange, &ColumnDisallowChangingAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnDisallowChange, &ColumnDisallowChangingAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnDisallowChange, &ColumnDisallowChangingAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE, &ColumnDisallowChangingAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE, &ColumnDisallowChangingAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE, &ColumnDisallowChangingAdvisor{})
}
// ColumnDisallowChangingAdvisor is the advisor checking for disallow CHANGE COLUMN statement.
@@ -44,7 +44,7 @@ func (*ColumnDisallowChangingAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewColumnDisallowChangingRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnDisallowChangingRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_disallow_changing_order.go b/backend/plugin/advisor/mysql/rule_column_disallow_changing_order.go
index 970d01f7c9..dca5078bd4 100644
--- a/backend/plugin/advisor/mysql/rule_column_disallow_changing_order.go
+++ b/backend/plugin/advisor/mysql/rule_column_disallow_changing_order.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnDisallowChangingOrder, &ColumnDisallowChangingOrderAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnDisallowChangingOrder, &ColumnDisallowChangingOrderAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnDisallowChangingOrder, &ColumnDisallowChangingOrderAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER, &ColumnDisallowChangingOrderAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER, &ColumnDisallowChangingOrderAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER, &ColumnDisallowChangingOrderAdvisor{})
}
// ColumnDisallowChangingOrderAdvisor is the advisor checking for disallow changing column order.
@@ -44,7 +44,7 @@ func (*ColumnDisallowChangingOrderAdvisor) Check(_ context.Context, checkCtx adv
}
// Create the rule
- rule := NewColumnDisallowChangingOrderRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnDisallowChangingOrderRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_disallow_changing_type.go b/backend/plugin/advisor/mysql/rule_column_disallow_changing_type.go
index 58be5674e4..d6766559e4 100644
--- a/backend/plugin/advisor/mysql/rule_column_disallow_changing_type.go
+++ b/backend/plugin/advisor/mysql/rule_column_disallow_changing_type.go
@@ -23,9 +23,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnDisallowChangeType, &ColumnDisallowChangingTypeAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnDisallowChangeType, &ColumnDisallowChangingTypeAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnDisallowChangeType, &ColumnDisallowChangingTypeAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE, &ColumnDisallowChangingTypeAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE, &ColumnDisallowChangingTypeAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE, &ColumnDisallowChangingTypeAdvisor{})
}
// ColumnDisallowChangingTypeAdvisor is the advisor checking for disallow changing column type.
@@ -46,7 +46,7 @@ func (*ColumnDisallowChangingTypeAdvisor) Check(_ context.Context, checkCtx advi
}
// Create the rule
- rule := NewColumnDisallowChangingTypeRule(level, string(checkCtx.Rule.Type), checkCtx.OriginalMetadata)
+ rule := NewColumnDisallowChangingTypeRule(level, checkCtx.Rule.Type.String(), checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_disallow_drop.go b/backend/plugin/advisor/mysql/rule_column_disallow_drop.go
index 0fc533eccd..2669d9407a 100644
--- a/backend/plugin/advisor/mysql/rule_column_disallow_drop.go
+++ b/backend/plugin/advisor/mysql/rule_column_disallow_drop.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnDisallowDrop, &ColumnDisallowDropAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_DISALLOW_DROP, &ColumnDisallowDropAdvisor{})
}
// ColumnDisallowDropAdvisor is the advisor checking for disallow DROP COLUMN statement.
@@ -42,7 +42,7 @@ func (*ColumnDisallowDropAdvisor) Check(_ context.Context, checkCtx advisor.Cont
}
// Create the rule
- rule := NewColumnDisallowDropRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnDisallowDropRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_disallow_drop_in_index.go b/backend/plugin/advisor/mysql/rule_column_disallow_drop_in_index.go
index e55d662fef..008b194684 100644
--- a/backend/plugin/advisor/mysql/rule_column_disallow_drop_in_index.go
+++ b/backend/plugin/advisor/mysql/rule_column_disallow_drop_in_index.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnDisallowDropInIndex, &ColumnDisallowDropInIndexAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnDisallowDropInIndex, &ColumnDisallowDropInIndexAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnDisallowDropInIndex, &ColumnDisallowDropInIndexAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX, &ColumnDisallowDropInIndexAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX, &ColumnDisallowDropInIndexAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX, &ColumnDisallowDropInIndexAdvisor{})
}
// ColumnDisallowDropInIndexAdvisor is the advisor checking for disallow DROP COLUMN in index.
@@ -44,7 +44,7 @@ func (*ColumnDisallowDropInIndexAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewColumnDisallowDropInIndexRule(level, string(checkCtx.Rule.Type), checkCtx.OriginalMetadata)
+ rule := NewColumnDisallowDropInIndexRule(level, checkCtx.Rule.Type.String(), checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_disallow_set_charset.go b/backend/plugin/advisor/mysql/rule_column_disallow_set_charset.go
index 5f40a19341..fe9d34fcac 100644
--- a/backend/plugin/advisor/mysql/rule_column_disallow_set_charset.go
+++ b/backend/plugin/advisor/mysql/rule_column_disallow_set_charset.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnDisallowSetCharset, &ColumnDisallowSetCharsetAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnDisallowSetCharset, &ColumnDisallowSetCharsetAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnDisallowSetCharset, &ColumnDisallowSetCharsetAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET, &ColumnDisallowSetCharsetAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET, &ColumnDisallowSetCharsetAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET, &ColumnDisallowSetCharsetAdvisor{})
}
// ColumnDisallowSetCharsetAdvisor is the advisor checking for disallow set column charset.
@@ -43,7 +43,7 @@ func (*ColumnDisallowSetCharsetAdvisor) Check(_ context.Context, checkCtx adviso
}
// Create the rule
- rule := NewColumnDisallowSetCharsetRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnDisallowSetCharsetRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_maximum_character_length.go b/backend/plugin/advisor/mysql/rule_column_maximum_character_length.go
index 332c6b744e..3789b646c3 100644
--- a/backend/plugin/advisor/mysql/rule_column_maximum_character_length.go
+++ b/backend/plugin/advisor/mysql/rule_column_maximum_character_length.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnMaximumCharacterLength, &ColumnMaximumCharacterLengthAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnMaximumCharacterLength, &ColumnMaximumCharacterLengthAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnMaximumCharacterLength, &ColumnMaximumCharacterLengthAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, &ColumnMaximumCharacterLengthAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, &ColumnMaximumCharacterLengthAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, &ColumnMaximumCharacterLengthAdvisor{})
}
// ColumnMaximumCharacterLengthAdvisor is the advisor checking for max character length.
@@ -49,7 +49,7 @@ func (*ColumnMaximumCharacterLengthAdvisor) Check(_ context.Context, checkCtx ad
}
// Create the rule
- rule := NewColumnMaximumCharacterLengthRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewColumnMaximumCharacterLengthRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_maximum_varchar_length.go b/backend/plugin/advisor/mysql/rule_column_maximum_varchar_length.go
index 6929988925..ab0addca4f 100644
--- a/backend/plugin/advisor/mysql/rule_column_maximum_varchar_length.go
+++ b/backend/plugin/advisor/mysql/rule_column_maximum_varchar_length.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnMaximumVarcharLength, &ColumnMaximumVarcharLengthAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnMaximumVarcharLength, &ColumnMaximumVarcharLengthAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnMaximumVarcharLength, &ColumnMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, &ColumnMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, &ColumnMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, &ColumnMaximumVarcharLengthAdvisor{})
}
// ColumnMaximumVarcharLengthAdvisor is the advisor checking for max varchar length.
@@ -48,7 +48,7 @@ func (*ColumnMaximumVarcharLengthAdvisor) Check(_ context.Context, checkCtx advi
}
// Create the rule
- rule := NewVarcharLengthRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewVarcharLengthRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_no_null.go b/backend/plugin/advisor/mysql/rule_column_no_null.go
index faf19240d6..f3e62c52fa 100644
--- a/backend/plugin/advisor/mysql/rule_column_no_null.go
+++ b/backend/plugin/advisor/mysql/rule_column_no_null.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
}
// ColumnNoNullAdvisor is the advisor checking for column no NULL value.
@@ -44,7 +44,7 @@ func (*ColumnNoNullAdvisor) Check(_ context.Context, checkCtx advisor.Context) (
}
// Create the rule
- rule := NewColumnNoNullRule(level, string(checkCtx.Rule.Type), checkCtx.FinalMetadata)
+ rule := NewColumnNoNullRule(level, checkCtx.Rule.Type.String(), checkCtx.FinalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_require_charset.go b/backend/plugin/advisor/mysql/rule_column_require_charset.go
index be1f34177e..7adb2d9019 100644
--- a/backend/plugin/advisor/mysql/rule_column_require_charset.go
+++ b/backend/plugin/advisor/mysql/rule_column_require_charset.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnRequireCharset, &ColumnRequireCharsetAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_REQUIRE_CHARSET, &ColumnRequireCharsetAdvisor{})
}
// ColumnRequireCharsetAdvisor is the advisor checking for require charset.
@@ -41,7 +41,7 @@ func (*ColumnRequireCharsetAdvisor) Check(_ context.Context, checkCtx advisor.Co
}
// Create the rule
- rule := NewColumnRequireCharsetRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnRequireCharsetRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_require_collation.go b/backend/plugin/advisor/mysql/rule_column_require_collation.go
index 6939fd2da7..1764622cd3 100644
--- a/backend/plugin/advisor/mysql/rule_column_require_collation.go
+++ b/backend/plugin/advisor/mysql/rule_column_require_collation.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnRequireCollation, &ColumnRequireCollationAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_REQUIRE_COLLATION, &ColumnRequireCollationAdvisor{})
}
// ColumnRequireCollationAdvisor is the advisor checking for require collation.
@@ -40,7 +40,7 @@ func (*ColumnRequireCollationAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewColumnRequireCollationRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnRequireCollationRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_require_default.go b/backend/plugin/advisor/mysql/rule_column_require_default.go
index 8ac410a410..72cabdb441 100644
--- a/backend/plugin/advisor/mysql/rule_column_require_default.go
+++ b/backend/plugin/advisor/mysql/rule_column_require_default.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnRequireDefault, &ColumnRequireDefaultAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnRequireDefault, &ColumnRequireDefaultAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnRequireDefault, &ColumnRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT, &ColumnRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT, &ColumnRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT, &ColumnRequireDefaultAdvisor{})
}
// ColumnRequireDefaultAdvisor is the advisor checking for column default requirement.
@@ -43,7 +43,7 @@ func (*ColumnRequireDefaultAdvisor) Check(_ context.Context, checkCtx advisor.Co
}
// Create the rule
- rule := NewColumnRequireDefaultRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnRequireDefaultRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_required.go b/backend/plugin/advisor/mysql/rule_column_required.go
index bcd755811f..6dadb2de84 100644
--- a/backend/plugin/advisor/mysql/rule_column_required.go
+++ b/backend/plugin/advisor/mysql/rule_column_required.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleRequiredColumn, &ColumnRequirementAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleRequiredColumn, &ColumnRequirementAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleRequiredColumn, &ColumnRequirementAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequirementAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequirementAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequirementAdvisor{})
}
// ColumnRequirementAdvisor is the advisor checking for column requirement.
@@ -54,7 +54,7 @@ func (*ColumnRequirementAdvisor) Check(_ context.Context, checkCtx advisor.Conte
}
// Create the rule
- rule := NewColumnRequiredRule(level, string(checkCtx.Rule.Type), requiredColumns)
+ rule := NewColumnRequiredRule(level, checkCtx.Rule.Type.String(), requiredColumns)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_set_default_for_not_null.go b/backend/plugin/advisor/mysql/rule_column_set_default_for_not_null.go
index fa66cbffcb..73009ee121 100644
--- a/backend/plugin/advisor/mysql/rule_column_set_default_for_not_null.go
+++ b/backend/plugin/advisor/mysql/rule_column_set_default_for_not_null.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnSetDefaultForNotNull, &ColumnSetDefaultForNotNullAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnSetDefaultForNotNull, &ColumnSetDefaultForNotNullAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnSetDefaultForNotNull, &ColumnSetDefaultForNotNullAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL, &ColumnSetDefaultForNotNullAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL, &ColumnSetDefaultForNotNullAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL, &ColumnSetDefaultForNotNullAdvisor{})
}
// ColumnSetDefaultForNotNullAdvisor is the advisor checking for set default value for not null column.
@@ -44,7 +44,7 @@ func (*ColumnSetDefaultForNotNullAdvisor) Check(_ context.Context, checkCtx advi
}
// Create the rule
- rule := NewColumnSetDefaultForNotNullRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnSetDefaultForNotNullRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_column_type_disallow_list.go b/backend/plugin/advisor/mysql/rule_column_type_disallow_list.go
index 9d5a80e6c0..88764348d3 100644
--- a/backend/plugin/advisor/mysql/rule_column_type_disallow_list.go
+++ b/backend/plugin/advisor/mysql/rule_column_type_disallow_list.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
}
// ColumnTypeDisallowListAdvisor is the advisor checking for column type restriction.
@@ -54,7 +54,7 @@ func (*ColumnTypeDisallowListAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewColumnTypeDisallowListRule(level, string(checkCtx.Rule.Type), typeRestriction)
+ rule := NewColumnTypeDisallowListRule(level, checkCtx.Rule.Type.String(), typeRestriction)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_database_drop_empty_db.go b/backend/plugin/advisor/mysql/rule_database_drop_empty_db.go
index 8c5752c684..511fb6a2e8 100644
--- a/backend/plugin/advisor/mysql/rule_database_drop_empty_db.go
+++ b/backend/plugin/advisor/mysql/rule_database_drop_empty_db.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleDropEmptyDatabase, &DatabaseAllowDropIfEmptyAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleDropEmptyDatabase, &DatabaseAllowDropIfEmptyAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleDropEmptyDatabase, &DatabaseAllowDropIfEmptyAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE, &DatabaseAllowDropIfEmptyAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE, &DatabaseAllowDropIfEmptyAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE, &DatabaseAllowDropIfEmptyAdvisor{})
}
// DatabaseAllowDropIfEmptyAdvisor is the advisor checking the MySQLDatabaseAllowDropIfEmpty rule.
@@ -43,7 +43,7 @@ func (*DatabaseAllowDropIfEmptyAdvisor) Check(_ context.Context, checkCtx adviso
}
// Create the rule
- rule := NewDatabaseDropEmptyDBRule(level, string(checkCtx.Rule.Type), checkCtx.OriginalMetadata)
+ rule := NewDatabaseDropEmptyDBRule(level, checkCtx.Rule.Type.String(), checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_disallow_procedure.go b/backend/plugin/advisor/mysql/rule_disallow_procedure.go
index 5ce5f700e7..e326b7cbbb 100644
--- a/backend/plugin/advisor/mysql/rule_disallow_procedure.go
+++ b/backend/plugin/advisor/mysql/rule_disallow_procedure.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleProcedureDisallowCreate, &ProcedureDisallowCreateAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE, &ProcedureDisallowCreateAdvisor{})
}
// ProcedureDisallowCreateAdvisor is the advisor checking for disallow create procedure.
@@ -41,7 +41,7 @@ func (*ProcedureDisallowCreateAdvisor) Check(_ context.Context, checkCtx advisor
}
// Create the rule
- rule := NewProcedureDisallowCreateRule(level, string(checkCtx.Rule.Type))
+ rule := NewProcedureDisallowCreateRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_event_disallow_create.go b/backend/plugin/advisor/mysql/rule_event_disallow_create.go
index c980aab81d..ba2ec28fea 100644
--- a/backend/plugin/advisor/mysql/rule_event_disallow_create.go
+++ b/backend/plugin/advisor/mysql/rule_event_disallow_create.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleEventDisallowCreate, &EventDisallowCreateAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_EVENT_DISALLOW_CREATE, &EventDisallowCreateAdvisor{})
}
// EventDisallowCreateAdvisor is the advisor checking for disallow creating event.
@@ -41,7 +41,7 @@ func (*EventDisallowCreateAdvisor) Check(_ context.Context, checkCtx advisor.Con
}
// Create the rule
- rule := NewEventDisallowCreateRule(level, string(checkCtx.Rule.Type))
+ rule := NewEventDisallowCreateRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_function_disallow_create.go b/backend/plugin/advisor/mysql/rule_function_disallow_create.go
index 26e4b6c214..e39ea67f5b 100644
--- a/backend/plugin/advisor/mysql/rule_function_disallow_create.go
+++ b/backend/plugin/advisor/mysql/rule_function_disallow_create.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleFunctionDisallowCreate, &FunctionDisallowCreateAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE, &FunctionDisallowCreateAdvisor{})
}
// FunctionDisallowCreateAdvisor is the advisor checking for disallow creating function.
@@ -41,7 +41,7 @@ func (*FunctionDisallowCreateAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewFunctionDisallowCreateRule(level, string(checkCtx.Rule.Type))
+ rule := NewFunctionDisallowCreateRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_function_disallowed_list.go b/backend/plugin/advisor/mysql/rule_function_disallowed_list.go
index f008564622..5c46ae79c9 100644
--- a/backend/plugin/advisor/mysql/rule_function_disallowed_list.go
+++ b/backend/plugin/advisor/mysql/rule_function_disallowed_list.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleFunctionDisallowList, &FunctionDisallowedListAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST, &FunctionDisallowedListAdvisor{})
}
// FunctionDisallowedListAdvisor is the advisor checking for disallowed function list.
@@ -51,7 +51,7 @@ func (*FunctionDisallowedListAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewFunctionDisallowedListRule(level, string(checkCtx.Rule.Type), disallowList)
+ rule := NewFunctionDisallowedListRule(level, checkCtx.Rule.Type.String(), disallowList)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_key_number_limit.go b/backend/plugin/advisor/mysql/rule_index_key_number_limit.go
index c460389c67..e6f8bdf647 100644
--- a/backend/plugin/advisor/mysql/rule_index_key_number_limit.go
+++ b/backend/plugin/advisor/mysql/rule_index_key_number_limit.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexKeyNumberLimit, &IndexKeyNumberLimitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleIndexKeyNumberLimit, &IndexKeyNumberLimitAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIndexKeyNumberLimit, &IndexKeyNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, &IndexKeyNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, &IndexKeyNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, &IndexKeyNumberLimitAdvisor{})
}
// IndexKeyNumberLimitAdvisor is the advisor checking for index key number limit.
@@ -47,7 +47,7 @@ func (*IndexKeyNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.Con
}
// Create the rule
- rule := NewIndexKeyNumberLimitRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewIndexKeyNumberLimitRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_no_duplicate_column.go b/backend/plugin/advisor/mysql/rule_index_no_duplicate_column.go
index 763dce3008..d88830fe11 100644
--- a/backend/plugin/advisor/mysql/rule_index_no_duplicate_column.go
+++ b/backend/plugin/advisor/mysql/rule_index_no_duplicate_column.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexNoDuplicateColumn, &IndexNoDuplicateColumnAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleIndexNoDuplicateColumn, &IndexNoDuplicateColumnAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIndexNoDuplicateColumn, &IndexNoDuplicateColumnAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN, &IndexNoDuplicateColumnAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN, &IndexNoDuplicateColumnAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN, &IndexNoDuplicateColumnAdvisor{})
}
// IndexNoDuplicateColumnAdvisor is the advisor checking for no duplicate columns in index.
@@ -44,7 +44,7 @@ func (*IndexNoDuplicateColumnAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewIndexNoDuplicateColumnRule(level, string(checkCtx.Rule.Type))
+ rule := NewIndexNoDuplicateColumnRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_pk_type.go b/backend/plugin/advisor/mysql/rule_index_pk_type.go
index c4f32a90de..03ac963376 100644
--- a/backend/plugin/advisor/mysql/rule_index_pk_type.go
+++ b/backend/plugin/advisor/mysql/rule_index_pk_type.go
@@ -23,9 +23,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexPKTypeLimit, &IndexPkTypeAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleIndexPKTypeLimit, &IndexPkTypeAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIndexPKTypeLimit, &IndexPkTypeAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT, &IndexPkTypeAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT, &IndexPkTypeAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT, &IndexPkTypeAdvisor{})
}
// IndexPkTypeAdvisor is the advisor checking for correct type of PK.
@@ -46,7 +46,7 @@ func (*IndexPkTypeAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
}
// Create the rule
- rule := NewIndexPkTypeRule(level, string(checkCtx.Rule.Type), checkCtx.OriginalMetadata)
+ rule := NewIndexPkTypeRule(level, checkCtx.Rule.Type.String(), checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_primary_key_type_allowlist.go b/backend/plugin/advisor/mysql/rule_index_primary_key_type_allowlist.go
index 84fa170063..245c9d246c 100644
--- a/backend/plugin/advisor/mysql/rule_index_primary_key_type_allowlist.go
+++ b/backend/plugin/advisor/mysql/rule_index_primary_key_type_allowlist.go
@@ -23,8 +23,8 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist, &IndexPrimaryKeyTypeAllowlistAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist, &IndexPrimaryKeyTypeAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST, &IndexPrimaryKeyTypeAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST, &IndexPrimaryKeyTypeAllowlistAdvisor{})
}
// IndexPrimaryKeyTypeAllowlistAdvisor is the advisor checking for primary key type allowlist.
@@ -53,7 +53,7 @@ func (*IndexPrimaryKeyTypeAllowlistAdvisor) Check(_ context.Context, checkCtx ad
}
// Create the rule
- rule := NewIndexPrimaryKeyTypeAllowlistRule(level, string(checkCtx.Rule.Type), allowlist, checkCtx.OriginalMetadata)
+ rule := NewIndexPrimaryKeyTypeAllowlistRule(level, checkCtx.Rule.Type.String(), allowlist, checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_total_number_limit.go b/backend/plugin/advisor/mysql/rule_index_total_number_limit.go
index 54ca02ae4d..becb7f840b 100644
--- a/backend/plugin/advisor/mysql/rule_index_total_number_limit.go
+++ b/backend/plugin/advisor/mysql/rule_index_total_number_limit.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexTotalNumberLimit, &IndexTotalNumberLimitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleIndexTotalNumberLimit, &IndexTotalNumberLimitAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIndexTotalNumberLimit, &IndexTotalNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT, &IndexTotalNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT, &IndexTotalNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT, &IndexTotalNumberLimitAdvisor{})
}
// IndexTotalNumberLimitAdvisor is the advisor checking for index total number limit.
@@ -49,7 +49,7 @@ func (*IndexTotalNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.C
}
// Create the rule
- rule := NewIndexTotalNumberLimitRule(level, string(checkCtx.Rule.Type), payload.Number, checkCtx.FinalMetadata)
+ rule := NewIndexTotalNumberLimitRule(level, checkCtx.Rule.Type.String(), payload.Number, checkCtx.FinalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_type_allow_list.go b/backend/plugin/advisor/mysql/rule_index_type_allow_list.go
index efdb5d05eb..917ff66876 100644
--- a/backend/plugin/advisor/mysql/rule_index_type_allow_list.go
+++ b/backend/plugin/advisor/mysql/rule_index_type_allow_list.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexTypeAllowList, &IndexTypeAllowListAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_TYPE_ALLOW_LIST, &IndexTypeAllowListAdvisor{})
}
// IndexTypeAllowListAdvisor is the advisor checking for index types.
@@ -46,7 +46,7 @@ func (*IndexTypeAllowListAdvisor) Check(_ context.Context, checkCtx advisor.Cont
}
// Create the rule
- rule := NewIndexTypeAllowListRule(level, string(checkCtx.Rule.Type), payload.List)
+ rule := NewIndexTypeAllowListRule(level, checkCtx.Rule.Type.String(), payload.List)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_index_type_no_blob.go b/backend/plugin/advisor/mysql/rule_index_type_no_blob.go
index ca77b04ba5..58e21a3a76 100644
--- a/backend/plugin/advisor/mysql/rule_index_type_no_blob.go
+++ b/backend/plugin/advisor/mysql/rule_index_type_no_blob.go
@@ -23,9 +23,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIndexTypeNoBlob, &IndexTypeNoBlobAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleIndexTypeNoBlob, &IndexTypeNoBlobAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIndexTypeNoBlob, &IndexTypeNoBlobAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB, &IndexTypeNoBlobAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB, &IndexTypeNoBlobAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB, &IndexTypeNoBlobAdvisor{})
}
// IndexTypeNoBlobAdvisor is the advisor checking for index type no blob.
@@ -46,7 +46,7 @@ func (*IndexTypeNoBlobAdvisor) Check(_ context.Context, checkCtx advisor.Context
}
// Create the rule
- rule := NewIndexTypeNoBlobRule(level, string(checkCtx.Rule.Type), checkCtx.OriginalMetadata)
+ rule := NewIndexTypeNoBlobRule(level, checkCtx.Rule.Type.String(), checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_insert_disallow_order_by_rand.go b/backend/plugin/advisor/mysql/rule_insert_disallow_order_by_rand.go
index 3ef855ffdf..8a58010cae 100644
--- a/backend/plugin/advisor/mysql/rule_insert_disallow_order_by_rand.go
+++ b/backend/plugin/advisor/mysql/rule_insert_disallow_order_by_rand.go
@@ -22,9 +22,9 @@ var (
const RandFn = "rand()"
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementInsertDisallowOrderByRand, &InsertDisallowOrderByRandAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementInsertDisallowOrderByRand, &InsertDisallowOrderByRandAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementInsertDisallowOrderByRand, &InsertDisallowOrderByRandAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, &InsertDisallowOrderByRandAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, &InsertDisallowOrderByRandAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, &InsertDisallowOrderByRandAdvisor{})
}
// InsertDisallowOrderByRandAdvisor is the advisor checking for to disallow order by rand in INSERT statements.
@@ -45,7 +45,7 @@ func (*InsertDisallowOrderByRandAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewInsertDisallowOrderByRandRule(level, string(checkCtx.Rule.Type))
+ rule := NewInsertDisallowOrderByRandRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_insert_must_specify_column.go b/backend/plugin/advisor/mysql/rule_insert_must_specify_column.go
index ca7f503ecd..10d141ac4f 100644
--- a/backend/plugin/advisor/mysql/rule_insert_must_specify_column.go
+++ b/backend/plugin/advisor/mysql/rule_insert_must_specify_column.go
@@ -19,9 +19,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementInsertMustSpecifyColumn, &InsertMustSpecifyColumnAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementInsertMustSpecifyColumn, &InsertMustSpecifyColumnAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementInsertMustSpecifyColumn, &InsertMustSpecifyColumnAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, &InsertMustSpecifyColumnAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, &InsertMustSpecifyColumnAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, &InsertMustSpecifyColumnAdvisor{})
}
// InsertMustSpecifyColumnAdvisor is the advisor checking for to enforce column specified.
@@ -42,7 +42,7 @@ func (*InsertMustSpecifyColumnAdvisor) Check(_ context.Context, checkCtx advisor
}
// Create the rule
- rule := NewInsertMustSpecifyColumnRule(level, string(checkCtx.Rule.Type))
+ rule := NewInsertMustSpecifyColumnRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_insert_row_limit.go b/backend/plugin/advisor/mysql/rule_insert_row_limit.go
index e593dd00dd..492460f949 100644
--- a/backend/plugin/advisor/mysql/rule_insert_row_limit.go
+++ b/backend/plugin/advisor/mysql/rule_insert_row_limit.go
@@ -22,8 +22,8 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementInsertRowLimit, &InsertRowLimitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementInsertRowLimit, &InsertRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, &InsertRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, &InsertRowLimitAdvisor{})
}
// InsertRowLimitAdvisor is the advisor checking for insert row limit.
@@ -49,7 +49,7 @@ func (*InsertRowLimitAdvisor) Check(ctx context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewInsertRowLimitRule(ctx, level, string(checkCtx.Rule.Type), payload.Number, checkCtx.Driver)
+ rule := NewInsertRowLimitRule(ctx, level, checkCtx.Rule.Type.String(), payload.Number, checkCtx.Driver)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_migration_compatibility.go b/backend/plugin/advisor/mysql/rule_migration_compatibility.go
index d7ca644233..abf7175e80 100644
--- a/backend/plugin/advisor/mysql/rule_migration_compatibility.go
+++ b/backend/plugin/advisor/mysql/rule_migration_compatibility.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleSchemaBackwardCompatibility, &CompatibilityAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleSchemaBackwardCompatibility, &CompatibilityAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleSchemaBackwardCompatibility, &CompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &CompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &CompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &CompatibilityAdvisor{})
}
// CompatibilityAdvisor is the advisor checking for schema backward compatibility.
@@ -43,7 +43,7 @@ func (*CompatibilityAdvisor) Check(_ context.Context, checkCtx advisor.Context)
}
// Create the rule
- rule := NewCompatibilityRule(level, string(checkCtx.Rule.Type))
+ rule := NewCompatibilityRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_auto_increment_column.go b/backend/plugin/advisor/mysql/rule_naming_auto_increment_column.go
index 119de85efd..a00e9e64ec 100644
--- a/backend/plugin/advisor/mysql/rule_naming_auto_increment_column.go
+++ b/backend/plugin/advisor/mysql/rule_naming_auto_increment_column.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleAutoIncrementColumnNaming, &NamingAutoIncrementColumnAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleAutoIncrementColumnNaming, &NamingAutoIncrementColumnAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleAutoIncrementColumnNaming, &NamingAutoIncrementColumnAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT, &NamingAutoIncrementColumnAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT, &NamingAutoIncrementColumnAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT, &NamingAutoIncrementColumnAdvisor{})
}
// NamingAutoIncrementColumnAdvisor is the advisor checking for auto-increment naming convention.
@@ -47,7 +47,7 @@ func (*NamingAutoIncrementColumnAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewNamingAutoIncrementColumnRule(level, string(checkCtx.Rule.Type), format, maxLength)
+ rule := NewNamingAutoIncrementColumnRule(level, checkCtx.Rule.Type.String(), format, maxLength)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_column.go b/backend/plugin/advisor/mysql/rule_naming_column.go
index b7e3f59f30..190064045c 100644
--- a/backend/plugin/advisor/mysql/rule_naming_column.go
+++ b/backend/plugin/advisor/mysql/rule_naming_column.go
@@ -18,9 +18,9 @@ import (
var _ advisor.Advisor = (*NamingColumnConventionAdvisor)(nil)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnNaming, &NamingColumnConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleColumnNaming, &NamingColumnConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleColumnNaming, &NamingColumnConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_COLUMN, &NamingColumnConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_NAMING_COLUMN, &NamingColumnConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_NAMING_COLUMN, &NamingColumnConventionAdvisor{})
}
// NamingColumnConventionAdvisor is the advisor checking for column naming convention.
@@ -44,7 +44,7 @@ func (*NamingColumnConventionAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewNamingColumnRule(level, string(checkCtx.Rule.Type), format, maxLength)
+ rule := NewNamingColumnRule(level, checkCtx.Rule.Type.String(), format, maxLength)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_foreign_key_convention.go b/backend/plugin/advisor/mysql/rule_naming_foreign_key_convention.go
index de7cd6196e..18d58182c1 100644
--- a/backend/plugin/advisor/mysql/rule_naming_foreign_key_convention.go
+++ b/backend/plugin/advisor/mysql/rule_naming_foreign_key_convention.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleFKNaming, &NamingFKConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleFKNaming, &NamingFKConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleFKNaming, &NamingFKConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_INDEX_FK, &NamingFKConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_NAMING_INDEX_FK, &NamingFKConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_NAMING_INDEX_FK, &NamingFKConventionAdvisor{})
}
// NamingFKConventionAdvisor is the advisor checking for foreign key naming convention.
@@ -42,13 +42,13 @@ func (*NamingFKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
// Create the rule
- rule := NewNamingFKConventionRule(level, string(checkCtx.Rule.Type), format, maxLength, templateList)
+ rule := NewNamingFKConventionRule(level, checkCtx.Rule.Type.String(), format, maxLength, templateList)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_identifier_no_keyword.go b/backend/plugin/advisor/mysql/rule_naming_identifier_no_keyword.go
index 3c5ec954e1..4c5f5032d6 100644
--- a/backend/plugin/advisor/mysql/rule_naming_identifier_no_keyword.go
+++ b/backend/plugin/advisor/mysql/rule_naming_identifier_no_keyword.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIdentifierNoKeyword, &NamingIdentifierNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD, &NamingIdentifierNoKeywordAdvisor{})
}
// NamingIdentifierNoKeywordAdvisor is the advisor checking for identifier naming convention without keyword.
@@ -40,7 +40,7 @@ func (*NamingIdentifierNoKeywordAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewNamingIdentifierNoKeywordRule(level, string(checkCtx.Rule.Type))
+ rule := NewNamingIdentifierNoKeywordRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_index_convention.go b/backend/plugin/advisor/mysql/rule_naming_index_convention.go
index a693d790fc..b2d3209904 100644
--- a/backend/plugin/advisor/mysql/rule_naming_index_convention.go
+++ b/backend/plugin/advisor/mysql/rule_naming_index_convention.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleIDXNaming, &NamingIndexConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleIDXNaming, &NamingIndexConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleIDXNaming, &NamingIndexConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_INDEX_IDX, &NamingIndexConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_NAMING_INDEX_IDX, &NamingIndexConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_NAMING_INDEX_IDX, &NamingIndexConventionAdvisor{})
}
// indexMetaData is the metadata for index.
@@ -51,13 +51,13 @@ func (*NamingIndexConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
// Create the rule
- rule := NewNamingIndexConventionRule(level, string(checkCtx.Rule.Type), format, maxLength, templateList, checkCtx.OriginalMetadata)
+ rule := NewNamingIndexConventionRule(level, checkCtx.Rule.Type.String(), format, maxLength, templateList, checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_table.go b/backend/plugin/advisor/mysql/rule_naming_table.go
index c744e91fe8..07d326b499 100644
--- a/backend/plugin/advisor/mysql/rule_naming_table.go
+++ b/backend/plugin/advisor/mysql/rule_naming_table.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableNaming, &NamingTableConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleTableNaming, &NamingTableConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleTableNaming, &NamingTableConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableConventionAdvisor{})
}
// NamingTableConventionAdvisor is the advisor checking for table naming convention.
@@ -48,7 +48,7 @@ func (*NamingTableConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
}
// Create the rule
- rule := NewNamingTableRule(level, string(checkCtx.Rule.Type), format, maxLength)
+ rule := NewNamingTableRule(level, checkCtx.Rule.Type.String(), format, maxLength)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_naming_unique_key_convention.go b/backend/plugin/advisor/mysql/rule_naming_unique_key_convention.go
index f17ca85679..e9568acfaa 100644
--- a/backend/plugin/advisor/mysql/rule_naming_unique_key_convention.go
+++ b/backend/plugin/advisor/mysql/rule_naming_unique_key_convention.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleUKNaming, &NamingUKConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleUKNaming, &NamingUKConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleUKNaming, &NamingUKConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_NAMING_INDEX_UK, &NamingUKConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_NAMING_INDEX_UK, &NamingUKConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_NAMING_INDEX_UK, &NamingUKConventionAdvisor{})
}
// NamingUKConventionAdvisor is the advisor checking for unique key naming convention.
@@ -43,13 +43,13 @@ func (*NamingUKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
// Create the rule
- rule := NewNamingUKConventionRule(level, string(checkCtx.Rule.Type), format, maxLength, templateList, checkCtx.OriginalMetadata)
+ rule := NewNamingUKConventionRule(level, checkCtx.Rule.Type.String(), format, maxLength, templateList, checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_online_migration.go b/backend/plugin/advisor/mysql/rule_online_migration.go
index 55095f7c72..793196a569 100644
--- a/backend/plugin/advisor/mysql/rule_online_migration.go
+++ b/backend/plugin/advisor/mysql/rule_online_migration.go
@@ -25,8 +25,8 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleOnlineMigration, &OnlineMigrationAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleOnlineMigration, &OnlineMigrationAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_ADVICE_ONLINE_MIGRATION, &OnlineMigrationAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_ADVICE_ONLINE_MIGRATION, &OnlineMigrationAdvisor{})
}
// OnlineMigrationAdvisor is the advisor checking for using gh-ost to migrate large tables.
@@ -51,7 +51,7 @@ func (*OnlineMigrationAdvisor) Check(ctx context.Context, checkCtx advisor.Conte
return nil, err
}
dbMetadata := model.NewDatabaseMetadata(checkCtx.DBSchema, nil, nil, storepb.Engine_MYSQL, checkCtx.IsObjectCaseSensitive)
- title := string(checkCtx.Rule.Type)
+ title := checkCtx.Rule.Type.String()
// Check gh-ost database existence first if gh-ost is enabled.
if checkCtx.EnableGhost {
diff --git a/backend/plugin/advisor/mysql/rule_statement_add_column_without_position.go b/backend/plugin/advisor/mysql/rule_statement_add_column_without_position.go
index 586e7c7bbb..ce367acc3c 100644
--- a/backend/plugin/advisor/mysql/rule_statement_add_column_without_position.go
+++ b/backend/plugin/advisor/mysql/rule_statement_add_column_without_position.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementAddColumnWithoutPosition, &StatementAddColumnWithoutPositionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION, &StatementAddColumnWithoutPositionAdvisor{})
}
// StatementAddColumnWithoutPositionAdvisor is the advisor checking for checking no position in ADD COLUMN clause.
@@ -40,7 +40,7 @@ func (*StatementAddColumnWithoutPositionAdvisor) Check(_ context.Context, checkC
}
// Create the rule
- rule := NewStatementAddColumnWithoutPositionRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementAddColumnWithoutPositionRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_affected_row_limit.go b/backend/plugin/advisor/mysql/rule_statement_affected_row_limit.go
index 149990d1db..49ecfe75e8 100644
--- a/backend/plugin/advisor/mysql/rule_statement_affected_row_limit.go
+++ b/backend/plugin/advisor/mysql/rule_statement_affected_row_limit.go
@@ -22,8 +22,8 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementAffectedRowLimit, &StatementAffectedRowLimitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementAffectedRowLimit, &StatementAffectedRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT, &StatementAffectedRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT, &StatementAffectedRowLimitAdvisor{})
}
// StatementAffectedRowLimitAdvisor is the advisor checking for UPDATE/DELETE affected row limit.
@@ -48,7 +48,7 @@ func (*StatementAffectedRowLimitAdvisor) Check(ctx context.Context, checkCtx adv
}
// Create the rule
- rule := NewStatementAffectedRowLimitRule(ctx, level, string(checkCtx.Rule.Type), payload.Number, checkCtx.Driver)
+ rule := NewStatementAffectedRowLimitRule(ctx, level, checkCtx.Rule.Type.String(), payload.Number, checkCtx.Driver)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.go b/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.go
index 3242b65f7f..25162030fd 100644
--- a/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.go
+++ b/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementDisallowUsingFilesort, &StatementDisallowUsingFilesortAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT, &StatementDisallowUsingFilesortAdvisor{})
}
// StatementDisallowUsingFilesortAdvisor is the advisor checking for using filesort.
@@ -42,7 +42,7 @@ func (*StatementDisallowUsingFilesortAdvisor) Check(ctx context.Context, checkCt
}
// Create the rule
- rule := NewStatementDisallowUsingFilesortRule(ctx, level, string(checkCtx.Rule.Type), checkCtx.Driver)
+ rule := NewStatementDisallowUsingFilesortRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx.Driver)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.go b/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.go
index 9ef1e7bed9..d5f46579be 100644
--- a/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.go
+++ b/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementDisallowUsingTemporary, &StatementDisallowUsingTemporaryAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY, &StatementDisallowUsingTemporaryAdvisor{})
}
// StatementDisallowUsingTemporaryAdvisor is the advisor checking for using temporary.
@@ -42,7 +42,7 @@ func (*StatementDisallowUsingTemporaryAdvisor) Check(ctx context.Context, checkC
}
// Create the rule
- rule := NewStatementDisallowUsingTemporaryRule(ctx, level, string(checkCtx.Rule.Type), checkCtx.Driver)
+ rule := NewStatementDisallowUsingTemporaryRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx.Driver)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_dml_dry_run.go b/backend/plugin/advisor/mysql/rule_statement_dml_dry_run.go
index b8d3e0565e..21cf4ae638 100644
--- a/backend/plugin/advisor/mysql/rule_statement_dml_dry_run.go
+++ b/backend/plugin/advisor/mysql/rule_statement_dml_dry_run.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementDMLDryRun, &StatementDmlDryRunAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementDMLDryRun, &StatementDmlDryRunAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementDMLDryRun, &StatementDmlDryRunAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, &StatementDmlDryRunAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, &StatementDmlDryRunAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, &StatementDmlDryRunAdvisor{})
}
// StatementDmlDryRunAdvisor is the advisor checking for DML dry run.
@@ -43,7 +43,7 @@ func (*StatementDmlDryRunAdvisor) Check(ctx context.Context, checkCtx advisor.Co
}
// Create the rule
- rule := NewStatementDmlDryRunRule(ctx, level, string(checkCtx.Rule.Type), checkCtx.Driver)
+ rule := NewStatementDmlDryRunRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx.Driver)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.go b/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.go
index 2a7ed45bc0..7fc61959e6 100644
--- a/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.go
+++ b/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementJoinStrictColumnAttrs, &StatementJoinStrictColumnAttrsAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS, &StatementJoinStrictColumnAttrsAdvisor{})
}
type StatementJoinStrictColumnAttrsAdvisor struct {
@@ -40,7 +40,7 @@ func (*StatementJoinStrictColumnAttrsAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewStatementJoinStrictColumnAttrsRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementJoinStrictColumnAttrsRule(level, checkCtx.Rule.Type.String())
if checkCtx.DBSchema != nil {
dbMetadata := model.NewDatabaseMetadata(checkCtx.DBSchema, nil, nil, storepb.Engine_MYSQL, checkCtx.IsObjectCaseSensitive)
rule.dbMetadata = dbMetadata
diff --git a/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.go b/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.go
index b4aeafe07f..016e205f1f 100644
--- a/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.go
+++ b/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementMaximumJoinTableCount, &StatementMaximumJoinTableCountAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT, &StatementMaximumJoinTableCountAdvisor{})
}
type StatementMaximumJoinTableCountAdvisor struct {
@@ -41,7 +41,7 @@ func (*StatementMaximumJoinTableCountAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewStatementMaximumJoinTableCountRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewStatementMaximumJoinTableCountRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.go b/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.go
index 31bd3c0947..960ad05221 100644
--- a/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.go
+++ b/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementMaximumLimitValue, &StatementMaximumLimitValueAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementMaximumLimitValue, &StatementMaximumLimitValueAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementMaximumLimitValue, &StatementMaximumLimitValueAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})
}
type StatementMaximumLimitValueAdvisor struct {
@@ -45,7 +45,7 @@ func (*StatementMaximumLimitValueAdvisor) Check(_ context.Context, checkCtx advi
}
// Create the rule
- rule := NewStatementMaximumLimitValueRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewStatementMaximumLimitValueRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_maximum_statements_in_transaction.go b/backend/plugin/advisor/mysql/rule_statement_maximum_statements_in_transaction.go
index 12b905f291..4a564c756c 100644
--- a/backend/plugin/advisor/mysql/rule_statement_maximum_statements_in_transaction.go
+++ b/backend/plugin/advisor/mysql/rule_statement_maximum_statements_in_transaction.go
@@ -15,7 +15,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementMaximumStatementsInTransaction, &StatementMaximumStatementsInTransactionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION, &StatementMaximumStatementsInTransactionAdvisor{})
}
type StatementMaximumStatementsInTransactionAdvisor struct {
@@ -38,7 +38,7 @@ func (*StatementMaximumStatementsInTransactionAdvisor) Check(_ context.Context,
}
// Create the rule
- rule := NewStatementMaximumStatementsInTransactionRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewStatementMaximumStatementsInTransactionRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_merge_alter_table.go b/backend/plugin/advisor/mysql/rule_statement_merge_alter_table.go
index 16703e38a9..5fab55e816 100644
--- a/backend/plugin/advisor/mysql/rule_statement_merge_alter_table.go
+++ b/backend/plugin/advisor/mysql/rule_statement_merge_alter_table.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementMergeAlterTable, &StatementMergeAlterTableAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementMergeAlterTable, &StatementMergeAlterTableAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementMergeAlterTable, &StatementMergeAlterTableAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE, &StatementMergeAlterTableAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE, &StatementMergeAlterTableAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE, &StatementMergeAlterTableAdvisor{})
}
// StatementMergeAlterTableAdvisor is the advisor checking for merging ALTER TABLE statements.
@@ -43,7 +43,7 @@ func (*StatementMergeAlterTableAdvisor) Check(_ context.Context, checkCtx adviso
}
// Create the rule
- rule := NewStatementMergeAlterTableRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementMergeAlterTableRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.go b/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.go
index 0d0c37b070..dc06ee6404 100644
--- a/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.go
+++ b/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.go
@@ -23,7 +23,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementQueryMinumumPlanLevel, &StatementQueryMinumumPlanLevelAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL, &StatementQueryMinumumPlanLevelAdvisor{})
}
type StatementQueryMinumumPlanLevelAdvisor struct {
@@ -46,7 +46,7 @@ func (*StatementQueryMinumumPlanLevelAdvisor) Check(ctx context.Context, checkCt
}
// Create the rule
- rule := NewStatementQueryMinumumPlanLevelRule(ctx, level, string(checkCtx.Rule.Type), checkCtx.Driver, convertExplainTypeFromString(strings.ToUpper(payload.String)))
+ rule := NewStatementQueryMinumumPlanLevelRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx.Driver, convertExplainTypeFromString(strings.ToUpper(payload.String)))
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.go b/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.go
index c2fee7a456..2a21c1b0a8 100644
--- a/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.go
+++ b/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.go
@@ -23,9 +23,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementSelectFullTableScan, &StatementSelectFullTableScanAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementSelectFullTableScan, &StatementSelectFullTableScanAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementSelectFullTableScan, &StatementSelectFullTableScanAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN, &StatementSelectFullTableScanAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN, &StatementSelectFullTableScanAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN, &StatementSelectFullTableScanAdvisor{})
}
type StatementSelectFullTableScanAdvisor struct {
@@ -44,7 +44,7 @@ func (*StatementSelectFullTableScanAdvisor) Check(ctx context.Context, checkCtx
}
// Create the rule
- rule := NewStatementSelectFullTableScanRule(ctx, level, string(checkCtx.Rule.Type), checkCtx.Driver)
+ rule := NewStatementSelectFullTableScanRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx.Driver)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_where_disallow_using_function.go b/backend/plugin/advisor/mysql/rule_statement_where_disallow_using_function.go
index ac77af0fca..7e54782754 100644
--- a/backend/plugin/advisor/mysql/rule_statement_where_disallow_using_function.go
+++ b/backend/plugin/advisor/mysql/rule_statement_where_disallow_using_function.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementWhereDisallowFunctionsAndCalculations, &StatementWhereDisallowUsingFunctionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS, &StatementWhereDisallowUsingFunctionAdvisor{})
}
type StatementWhereDisallowUsingFunctionAdvisor struct {
@@ -38,7 +38,7 @@ func (*StatementWhereDisallowUsingFunctionAdvisor) Check(_ context.Context, chec
}
// Create the rule
- rule := NewStatementWhereDisallowUsingFunctionRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementWhereDisallowUsingFunctionRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_where_maximum_logical_operator_count.go b/backend/plugin/advisor/mysql/rule_statement_where_maximum_logical_operator_count.go
index 7e3d7222a0..6742e192d6 100644
--- a/backend/plugin/advisor/mysql/rule_statement_where_maximum_logical_operator_count.go
+++ b/backend/plugin/advisor/mysql/rule_statement_where_maximum_logical_operator_count.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementWhereMaximumLogicalOperatorCount, &StatementWhereMaximumLogicalOperatorCountAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT, &StatementWhereMaximumLogicalOperatorCountAdvisor{})
}
type StatementWhereMaximumLogicalOperatorCountAdvisor struct {
@@ -43,7 +43,7 @@ func (*StatementWhereMaximumLogicalOperatorCountAdvisor) Check(_ context.Context
var allAdvice []*storepb.Advice
for _, stmt := range stmtList {
// Create the rule for each statement
- rule := NewStatementWhereMaximumLogicalOperatorCountRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewStatementWhereMaximumLogicalOperatorCountRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_statement_where_no_equal_null.go b/backend/plugin/advisor/mysql/rule_statement_where_no_equal_null.go
index 28fb4ed966..e6ae92c95d 100644
--- a/backend/plugin/advisor/mysql/rule_statement_where_no_equal_null.go
+++ b/backend/plugin/advisor/mysql/rule_statement_where_no_equal_null.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementWhereNoEqualNull, &StatementWhereNoEqualNullAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL, &StatementWhereNoEqualNullAdvisor{})
}
type StatementWhereNoEqualNullAdvisor struct {
@@ -37,7 +37,7 @@ func (*StatementWhereNoEqualNullAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewStatementWhereNoEqualNullRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementWhereNoEqualNullRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_disallow_commit.go b/backend/plugin/advisor/mysql/rule_stmt_disallow_commit.go
index f6bb47f71e..7ff20f3357 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_disallow_commit.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_disallow_commit.go
@@ -19,9 +19,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementDisallowCommit, &StatementDisallowCommitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementDisallowCommit, &StatementDisallowCommitAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementDisallowCommit, &StatementDisallowCommitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT, &StatementDisallowCommitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT, &StatementDisallowCommitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT, &StatementDisallowCommitAdvisor{})
}
// StatementDisallowCommitAdvisor is the advisor checking for disallowing commit.
@@ -42,7 +42,7 @@ func (*StatementDisallowCommitAdvisor) Check(_ context.Context, checkCtx advisor
}
// Create the rule
- rule := NewStatementDisallowCommitRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementDisallowCommitRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_disallow_limit.go b/backend/plugin/advisor/mysql/rule_stmt_disallow_limit.go
index 989e4662bf..2ad638ed93 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_disallow_limit.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_disallow_limit.go
@@ -18,9 +18,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementDisallowLimit, &StatementDisallowLimitAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementDisallowLimit, &StatementDisallowLimitAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementDisallowLimit, &StatementDisallowLimitAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT, &StatementDisallowLimitAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT, &StatementDisallowLimitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT, &StatementDisallowLimitAdvisor{})
}
// StatementDisallowLimitAdvisor is the advisor checking for no LIMIT clause in INSERT/UPDATE statement.
@@ -41,7 +41,7 @@ func (*StatementDisallowLimitAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewStatementDisallowLimitRule(level, string(checkCtx.Rule.Type))
+ rule := NewStatementDisallowLimitRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_disallow_order_by.go b/backend/plugin/advisor/mysql/rule_stmt_disallow_order_by.go
index d08d3f0cd5..41808b4fb1 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_disallow_order_by.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_disallow_order_by.go
@@ -18,9 +18,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementDisallowOrderBy, &DisallowOrderByAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementDisallowOrderBy, &DisallowOrderByAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementDisallowOrderBy, &DisallowOrderByAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY, &DisallowOrderByAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY, &DisallowOrderByAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY, &DisallowOrderByAdvisor{})
}
// DisallowOrderByAdvisor is the advisor checking for no ORDER BY clause in DELETE/UPDATE statements.
@@ -41,7 +41,7 @@ func (*DisallowOrderByAdvisor) Check(_ context.Context, checkCtx advisor.Context
}
// Create the rule
- rule := NewDisallowOrderByRule(level, string(checkCtx.Rule.Type))
+ rule := NewDisallowOrderByRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_max_execution_time.go b/backend/plugin/advisor/mysql/rule_stmt_max_execution_time.go
index 61a68b0424..197cb9b682 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_max_execution_time.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_max_execution_time.go
@@ -20,8 +20,8 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementMaxExecutionTime, &MaxExecutionTimeAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementMaxExecutionTime, &MaxExecutionTimeAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME, &MaxExecutionTimeAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME, &MaxExecutionTimeAdvisor{})
}
// MaxExecutionTimeAdvisor is the advisor checking for the max execution time.
@@ -46,7 +46,7 @@ func (*MaxExecutionTimeAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewMaxExecutionTimeRule(level, string(checkCtx.Rule.Type), systemVariable)
+ rule := NewMaxExecutionTimeRule(level, checkCtx.Rule.Type.String(), systemVariable)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_no_leading_wildcard_like.go b/backend/plugin/advisor/mysql/rule_stmt_no_leading_wildcard_like.go
index 9f7c8b8274..fcc07457cb 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_no_leading_wildcard_like.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_no_leading_wildcard_like.go
@@ -19,9 +19,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementNoLeadingWildcardLike, &NoLeadingWildcardLikeAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementNoLeadingWildcardLike, &NoLeadingWildcardLikeAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementNoLeadingWildcardLike, &NoLeadingWildcardLikeAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, &NoLeadingWildcardLikeAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, &NoLeadingWildcardLikeAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, &NoLeadingWildcardLikeAdvisor{})
}
// NoLeadingWildcardLikeAdvisor is the advisor checking for no leading wildcard LIKE.
@@ -42,7 +42,7 @@ func (*NoLeadingWildcardLikeAdvisor) Check(_ context.Context, checkCtx advisor.C
}
// Create the rule
- rule := NewNoLeadingWildcardLikeRule(level, string(checkCtx.Rule.Type))
+ rule := NewNoLeadingWildcardLikeRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_no_select_all.go b/backend/plugin/advisor/mysql/rule_stmt_no_select_all.go
index 1d12e6ca2d..b977340664 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_no_select_all.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_no_select_all.go
@@ -18,9 +18,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementNoSelectAll, &NoSelectAllAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementNoSelectAll, &NoSelectAllAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementNoSelectAll, &NoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &NoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &NoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &NoSelectAllAdvisor{})
}
// NoSelectAllAdvisor is the advisor checking for no "select *".
@@ -41,7 +41,7 @@ func (*NoSelectAllAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
}
// Create the rule
- rule := NewNoSelectAllRule(level, string(checkCtx.Rule.Type))
+ rule := NewNoSelectAllRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_require_algorithm_or_lock_options.go b/backend/plugin/advisor/mysql/rule_stmt_require_algorithm_or_lock_options.go
index f2cd48ae63..d3cd5eeb72 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_require_algorithm_or_lock_options.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_require_algorithm_or_lock_options.go
@@ -19,11 +19,11 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementRequireAlgorithmOption, &RequireAlgorithmOrLockOptionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementRequireAlgorithmOption, &RequireAlgorithmOrLockOptionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION, &RequireAlgorithmOrLockOptionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION, &RequireAlgorithmOrLockOptionAdvisor{})
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementRequireLockOption, &RequireAlgorithmOrLockOptionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementRequireLockOption, &RequireAlgorithmOrLockOptionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION, &RequireAlgorithmOrLockOptionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION, &RequireAlgorithmOrLockOptionAdvisor{})
}
// RequireAlgorithmOrLockOptionAdvisor is the advisor checking for the max execution time.
@@ -42,12 +42,12 @@ func (*RequireAlgorithmOrLockOptionAdvisor) Check(_ context.Context, checkCtx ad
}
requiredOption, errorCode := "ALGORITHM", code.StatementNoAlgorithmOption
- if checkCtx.Rule.Type == string(advisor.SchemaRuleStatementRequireLockOption) {
+ if checkCtx.Rule.Type == storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION {
requiredOption, errorCode = "LOCK", code.StatementNoLockOption
}
// Create the rule
- rule := NewRequireAlgorithmOrLockOptionRule(level, string(checkCtx.Rule.Type), requiredOption, errorCode)
+ rule := NewRequireAlgorithmOrLockOptionRule(level, checkCtx.Rule.Type.String(), requiredOption, errorCode)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_select.go b/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_select.go
index d8b26a230f..58a4613176 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_select.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_select.go
@@ -19,9 +19,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequirementForSelectAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequirementForSelectAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequirementForSelectAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequirementForSelectAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequirementForSelectAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequirementForSelectAdvisor{})
}
// WhereRequirementForSelectAdvisor is the advisor checking for the WHERE clause requirement for SELECT statements.
@@ -41,7 +41,7 @@ func (*WhereRequirementForSelectAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewWhereRequirementForSelectRule(level, string(checkCtx.Rule.Type))
+ rule := NewWhereRequirementForSelectRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_update_delete.go b/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_update_delete.go
index b152210151..6145973f17 100644
--- a/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_update_delete.go
+++ b/backend/plugin/advisor/mysql/rule_stmt_where_requirement_for_update_delete.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequirementForUpdateDeleteAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequirementForUpdateDeleteAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequirementForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequirementForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequirementForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequirementForUpdateDeleteAdvisor{})
}
// WhereRequirementForUpdateDeleteAdvisor is the advisor checking for the WHERE clause requirement for SELECT statements.
@@ -42,7 +42,7 @@ func (*WhereRequirementForUpdateDeleteAdvisor) Check(_ context.Context, checkCtx
}
// Create the rule
- rule := NewWhereRequirementForUpdateDeleteRule(level, string(checkCtx.Rule.Type))
+ rule := NewWhereRequirementForUpdateDeleteRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_comment_convention.go b/backend/plugin/advisor/mysql/rule_table_comment_convention.go
index 0532b7be95..f22dced7e2 100644
--- a/backend/plugin/advisor/mysql/rule_table_comment_convention.go
+++ b/backend/plugin/advisor/mysql/rule_table_comment_convention.go
@@ -19,9 +19,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableCommentConvention, &TableCommentConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleTableCommentConvention, &TableCommentConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleTableCommentConvention, &TableCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_COMMENT, &TableCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_TABLE_COMMENT, &TableCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_TABLE_COMMENT, &TableCommentConventionAdvisor{})
}
// TableCommentConventionAdvisor is the advisor checking for table comment convention.
@@ -46,7 +46,7 @@ func (*TableCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewTableCommentConventionRule(level, string(checkCtx.Rule.Type), payload)
+ rule := NewTableCommentConventionRule(level, checkCtx.Rule.Type.String(), payload)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_disallow_ddl.go b/backend/plugin/advisor/mysql/rule_table_disallow_ddl.go
index 7c8b398480..421f4b33fa 100644
--- a/backend/plugin/advisor/mysql/rule_table_disallow_ddl.go
+++ b/backend/plugin/advisor/mysql/rule_table_disallow_ddl.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableDisallowDDL, &TableDisallowDDLAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_DISALLOW_DDL, &TableDisallowDDLAdvisor{})
}
// TableDisallowDDLAdvisor is the advisor checking for disallow DDL on specific tables.
@@ -44,7 +44,7 @@ func (*TableDisallowDDLAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewTableDisallowDDLRule(level, string(checkCtx.Rule.Type), payload.List)
+ rule := NewTableDisallowDDLRule(level, checkCtx.Rule.Type.String(), payload.List)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_disallow_dml.go b/backend/plugin/advisor/mysql/rule_table_disallow_dml.go
index 4590a10537..305be2e059 100644
--- a/backend/plugin/advisor/mysql/rule_table_disallow_dml.go
+++ b/backend/plugin/advisor/mysql/rule_table_disallow_dml.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableDisallowDML, &TableDisallowDMLAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_DISALLOW_DML, &TableDisallowDMLAdvisor{})
}
// TableDisallowDMLAdvisor is the advisor checking for disallow DML on specific tables.
@@ -44,7 +44,7 @@ func (*TableDisallowDMLAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
// Create the rule
- rule := NewTableDisallowDMLRule(level, string(checkCtx.Rule.Type), payload.List)
+ rule := NewTableDisallowDMLRule(level, checkCtx.Rule.Type.String(), payload.List)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_disallow_partition.go b/backend/plugin/advisor/mysql/rule_table_disallow_partition.go
index 02859bba08..5ccd59fd8a 100644
--- a/backend/plugin/advisor/mysql/rule_table_disallow_partition.go
+++ b/backend/plugin/advisor/mysql/rule_table_disallow_partition.go
@@ -20,9 +20,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableDisallowPartition, &TableDisallowPartitionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleTableDisallowPartition, &TableDisallowPartitionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleTableDisallowPartition, &TableDisallowPartitionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION, &TableDisallowPartitionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION, &TableDisallowPartitionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION, &TableDisallowPartitionAdvisor{})
}
// TableDisallowPartitionAdvisor is the advisor checking for disallow table partition.
@@ -43,7 +43,7 @@ func (*TableDisallowPartitionAdvisor) Check(_ context.Context, checkCtx advisor.
}
// Create the rule
- rule := NewTableDisallowPartitionRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableDisallowPartitionRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_disallow_set_charset.go b/backend/plugin/advisor/mysql/rule_table_disallow_set_charset.go
index 1f8781e129..71ee7acf80 100644
--- a/backend/plugin/advisor/mysql/rule_table_disallow_set_charset.go
+++ b/backend/plugin/advisor/mysql/rule_table_disallow_set_charset.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableDisallowSetCharset, &TableDisallowSetCharsetAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_DISALLOW_SET_CHARSET, &TableDisallowSetCharsetAdvisor{})
}
type TableDisallowSetCharsetAdvisor struct {
@@ -39,7 +39,7 @@ func (*TableDisallowSetCharsetAdvisor) Check(_ context.Context, checkCtx advisor
}
// Create the rule
- rule := NewTableDisallowSetCharsetRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableDisallowSetCharsetRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_disallow_trigger.go b/backend/plugin/advisor/mysql/rule_table_disallow_trigger.go
index e505d65c44..f34391bcdb 100644
--- a/backend/plugin/advisor/mysql/rule_table_disallow_trigger.go
+++ b/backend/plugin/advisor/mysql/rule_table_disallow_trigger.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableDisallowTrigger, &TableDisallowTriggerAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_DISALLOW_TRIGGER, &TableDisallowTriggerAdvisor{})
}
// TableDisallowTriggerAdvisor is the advisor checking for disallow table trigger.
@@ -41,7 +41,7 @@ func (*TableDisallowTriggerAdvisor) Check(_ context.Context, checkCtx advisor.Co
}
// Create the rule
- rule := NewTableDisallowTriggerRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableDisallowTriggerRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_drop_naming_convention.go b/backend/plugin/advisor/mysql/rule_table_drop_naming_convention.go
index ee7d0872d2..05fc199453 100644
--- a/backend/plugin/advisor/mysql/rule_table_drop_naming_convention.go
+++ b/backend/plugin/advisor/mysql/rule_table_drop_naming_convention.go
@@ -21,9 +21,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
}
// TableDropNamingConventionAdvisor is the advisor checking the MySQLTableDropNamingConvention rule.
@@ -47,7 +47,7 @@ func (*TableDropNamingConventionAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewTableDropNamingConventionRule(level, string(checkCtx.Rule.Type), format)
+ rule := NewTableDropNamingConventionRule(level, checkCtx.Rule.Type.String(), format)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_limit_size.go b/backend/plugin/advisor/mysql/rule_table_limit_size.go
index 3a946fe6c7..69e3a71e32 100644
--- a/backend/plugin/advisor/mysql/rule_table_limit_size.go
+++ b/backend/plugin/advisor/mysql/rule_table_limit_size.go
@@ -18,7 +18,7 @@ import (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableLimitSize, &MaximumTableSizeAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_LIMIT_SIZE, &MaximumTableSizeAdvisor{})
}
type MaximumTableSizeAdvisor struct {
@@ -55,7 +55,7 @@ func (*MaximumTableSizeAdvisor) Check(_ context.Context, checkCtx advisor.Contex
if statTypeChecker.IsDDL {
// Create the rule
- rule := NewTableLimitSizeRule(status, string(checkCtx.Rule.Type), payload.Number, checkCtx.DBSchema)
+ rule := NewTableLimitSizeRule(status, checkCtx.Rule.Type.String(), payload.Number, checkCtx.DBSchema)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_no_duplicate_index.go b/backend/plugin/advisor/mysql/rule_table_no_duplicate_index.go
index 57734b14c9..814e70b2be 100644
--- a/backend/plugin/advisor/mysql/rule_table_no_duplicate_index.go
+++ b/backend/plugin/advisor/mysql/rule_table_no_duplicate_index.go
@@ -24,7 +24,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableNoDuplicateIndex, &TableNoDuplicateIndexAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_NO_DUPLICATE_INDEX, &TableNoDuplicateIndexAdvisor{})
}
// TableNoDuplicateIndexAdvisor is the advisor checking for no duplicate index in table.
@@ -45,7 +45,7 @@ func (*TableNoDuplicateIndexAdvisor) Check(_ context.Context, checkCtx advisor.C
}
// Create the rule
- rule := NewTableNoDuplicateIndexRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableNoDuplicateIndexRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_no_fk.go b/backend/plugin/advisor/mysql/rule_table_no_fk.go
index 672fbc19b5..dc90b9d185 100644
--- a/backend/plugin/advisor/mysql/rule_table_no_fk.go
+++ b/backend/plugin/advisor/mysql/rule_table_no_fk.go
@@ -22,9 +22,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableNoFK, &TableNoFKAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleTableNoFK, &TableNoFKAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleTableNoFK, &TableNoFKAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoFKAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoFKAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoFKAdvisor{})
}
// TableNoFKAdvisor is the advisor checking table disallow foreign key.
@@ -44,7 +44,7 @@ func (*TableNoFKAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*
}
// Create the rule
- rule := NewTableNoFKRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableNoFKRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_require_charset.go b/backend/plugin/advisor/mysql/rule_table_require_charset.go
index 812df713b3..73c3ac4a38 100644
--- a/backend/plugin/advisor/mysql/rule_table_require_charset.go
+++ b/backend/plugin/advisor/mysql/rule_table_require_charset.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableRequireCharset, &TableRequireCharsetAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_REQUIRE_CHARSET, &TableRequireCharsetAdvisor{})
}
// TableRequireCharsetAdvisor is the advisor checking for require charset.
@@ -40,7 +40,7 @@ func (*TableRequireCharsetAdvisor) Check(_ context.Context, checkCtx advisor.Con
}
// Create the rule
- rule := NewTableRequireCharsetRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableRequireCharsetRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_require_collation.go b/backend/plugin/advisor/mysql/rule_table_require_collation.go
index 9cee504035..db650e36ab 100644
--- a/backend/plugin/advisor/mysql/rule_table_require_collation.go
+++ b/backend/plugin/advisor/mysql/rule_table_require_collation.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableRequireCollation, &TableRequireCollationAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_REQUIRE_COLLATION, &TableRequireCollationAdvisor{})
}
// TableRequireCollationAdvisor is the advisor checking for require collation.
@@ -40,7 +40,7 @@ func (*TableRequireCollationAdvisor) Check(_ context.Context, checkCtx advisor.C
}
// Create the rule
- rule := NewTableRequireCollationRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableRequireCollationRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_require_pk.go b/backend/plugin/advisor/mysql/rule_table_require_pk.go
index 950ba98e1d..0c7fb58427 100644
--- a/backend/plugin/advisor/mysql/rule_table_require_pk.go
+++ b/backend/plugin/advisor/mysql/rule_table_require_pk.go
@@ -26,9 +26,9 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableRequirePK, &TableRequirePKAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleTableRequirePK, &TableRequirePKAdvisor{})
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleTableRequirePK, &TableRequirePKAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePKAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePKAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePKAdvisor{})
}
// TableRequirePKAdvisor is the advisor checking table requires PK.
@@ -49,7 +49,7 @@ func (*TableRequirePKAdvisor) Check(_ context.Context, checkCtx advisor.Context)
}
// Create the rule
- rule := NewTableRequirePKRule(level, string(checkCtx.Rule.Type), checkCtx.OriginalMetadata)
+ rule := NewTableRequirePKRule(level, checkCtx.Rule.Type.String(), checkCtx.OriginalMetadata)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_table_text_fields_total_length.go b/backend/plugin/advisor/mysql/rule_table_text_fields_total_length.go
index 70122bccd1..a188b26c0f 100644
--- a/backend/plugin/advisor/mysql/rule_table_text_fields_total_length.go
+++ b/backend/plugin/advisor/mysql/rule_table_text_fields_total_length.go
@@ -25,7 +25,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleTableTextFieldsTotalLength, &TableMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_TABLE_TEXT_FIELDS_TOTAL_LENGTH, &TableMaximumVarcharLengthAdvisor{})
}
type TableMaximumVarcharLengthAdvisor struct {
@@ -48,7 +48,7 @@ func (*TableMaximumVarcharLengthAdvisor) Check(_ context.Context, checkCtx advis
}
// Create the rule
- rule := NewTableTextFieldsTotalLengthRule(level, string(checkCtx.Rule.Type), checkCtx.FinalMetadata, payload.Number)
+ rule := NewTableTextFieldsTotalLengthRule(level, checkCtx.Rule.Type.String(), checkCtx.FinalMetadata, payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_use_innodb.go b/backend/plugin/advisor/mysql/rule_use_innodb.go
index 159cf3cb13..f63e656614 100644
--- a/backend/plugin/advisor/mysql/rule_use_innodb.go
+++ b/backend/plugin/advisor/mysql/rule_use_innodb.go
@@ -25,8 +25,8 @@ const (
var _ advisor.Advisor = (*UseInnoDBAdvisor)(nil)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleMySQLEngine, &UseInnoDBAdvisor{})
- advisor.Register(storepb.Engine_MARIADB, advisor.SchemaRuleMySQLEngine, &UseInnoDBAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB, &UseInnoDBAdvisor{})
+ advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB, &UseInnoDBAdvisor{})
}
// UseInnoDBAdvisor is the advisor checking for using InnoDB engine.
@@ -46,7 +46,7 @@ func (*UseInnoDBAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*
}
// Create the rule
- rule := NewUseInnoDBRule(level, string(checkCtx.Rule.Type))
+ rule := NewUseInnoDBRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/rule_view_disallow_create.go b/backend/plugin/advisor/mysql/rule_view_disallow_create.go
index d20f554a69..42f361be41 100644
--- a/backend/plugin/advisor/mysql/rule_view_disallow_create.go
+++ b/backend/plugin/advisor/mysql/rule_view_disallow_create.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleViewDisallowCreate, &ViewDisallowCreateAdvisor{})
+ advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_SYSTEM_VIEW_DISALLOW_CREATE, &ViewDisallowCreateAdvisor{})
}
// ViewDisallowCreateAdvisor is the advisor checking for disallow creating view.
@@ -41,7 +41,7 @@ func (*ViewDisallowCreateAdvisor) Check(_ context.Context, checkCtx advisor.Cont
}
// Create the rule
- rule := NewViewDisallowCreateRule(level, string(checkCtx.Rule.Type))
+ rule := NewViewDisallowCreateRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/mysql/test/column_auto_increment_initial_value.yaml b/backend/plugin/advisor/mysql/test/column_auto_increment_initial_value.yaml
index 4d9267b9e0..55d0c298a1 100644
--- a/backend/plugin/advisor/mysql/test/column_auto_increment_initial_value.yaml
+++ b/backend/plugin/advisor/mysql/test/column_auto_increment_initial_value.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 416
- title: column.auto-increment-initial-value
+ title: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
content: The initial auto-increment value in table `t2` is 2, which doesn't equal 20
startposition:
line: 2
@@ -24,7 +24,7 @@
want:
- status: 2
code: 416
- title: column.auto-increment-initial-value
+ title: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
content: The initial auto-increment value in table `t` is 100, which doesn't equal 20
startposition:
line: 4
diff --git a/backend/plugin/advisor/mysql/test/column_auto_increment_must_integer.yaml b/backend/plugin/advisor/mysql/test/column_auto_increment_must_integer.yaml
index a421ea7403..0a1529949a 100644
--- a/backend/plugin/advisor/mysql/test/column_auto_increment_must_integer.yaml
+++ b/backend/plugin/advisor/mysql/test/column_auto_increment_must_integer.yaml
@@ -17,7 +17,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t2`.`a` requires integer type
startposition:
line: 2
@@ -30,7 +30,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
@@ -43,7 +43,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
@@ -56,7 +56,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
@@ -70,7 +70,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
@@ -83,7 +83,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_auto_increment_must_unsigned.yaml b/backend/plugin/advisor/mysql/test/column_auto_increment_must_unsigned.yaml
index 424ea95906..e78665c141 100644
--- a/backend/plugin/advisor/mysql/test/column_auto_increment_must_unsigned.yaml
+++ b/backend/plugin/advisor/mysql/test/column_auto_increment_must_unsigned.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 1
@@ -31,7 +31,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 2
@@ -45,7 +45,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 2
@@ -59,7 +59,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_comment.yaml b/backend/plugin/advisor/mysql/test/column_comment.yaml
index 1b802658f0..3ef6cd22db 100644
--- a/backend/plugin/advisor/mysql/test/column_comment.yaml
+++ b/backend/plugin/advisor/mysql/test/column_comment.yaml
@@ -15,7 +15,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `userTable`.`id` requires comments
startposition:
line: 2
@@ -23,7 +23,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `userTable`.`name` requires comments
startposition:
line: 3
@@ -31,7 +31,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `userTable`.`roomId` requires comments
startposition:
line: 4
@@ -62,7 +62,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`a` comment should be within 10 characters
startposition:
line: 2
@@ -70,7 +70,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 3
@@ -78,7 +78,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`c` requires comments
startposition:
line: 4
@@ -91,7 +91,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -104,7 +104,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -112,7 +112,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`c` requires comments
startposition:
line: 2
@@ -125,7 +125,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`a` comment should be within 10 characters
startposition:
line: 1
@@ -133,7 +133,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -146,7 +146,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`b` comment should be within 10 characters
startposition:
line: 1
@@ -154,7 +154,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -167,7 +167,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`b` comment should be within 10 characters
startposition:
line: 1
@@ -175,7 +175,7 @@
endposition: null
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`b` comment should be within 10 characters
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_current_time_count_limit.yaml b/backend/plugin/advisor/mysql/test/column_current_time_count_limit.yaml
index 49042a0288..4900f2f689 100644
--- a/backend/plugin/advisor/mysql/test/column_current_time_count_limit.yaml
+++ b/backend/plugin/advisor/mysql/test/column_current_time_count_limit.yaml
@@ -15,7 +15,7 @@
want:
- status: 2
code: 419
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `userTable` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.
startposition:
line: 6
@@ -46,7 +46,7 @@
want:
- status: 2
code: 418
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `t` has 3 DEFAULT CURRENT_TIMESTAMP() columns. The count greater than 2.
startposition:
line: 4
@@ -61,7 +61,7 @@
want:
- status: 2
code: 419
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `t` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.
startposition:
line: 3
@@ -74,7 +74,7 @@
want:
- status: 2
code: 419
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `tech_book` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_disallow_change.yaml b/backend/plugin/advisor/mysql/test/column_disallow_change.yaml
index c11bf3d939..badb2d720e 100644
--- a/backend/plugin/advisor/mysql/test/column_disallow_change.yaml
+++ b/backend/plugin/advisor/mysql/test/column_disallow_change.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 406
- title: column.disallow-change
+ title: COLUMN_DISALLOW_CHANGE
content: '"ALTER TABLE t CHANGE COLUMN b a int;" contains CHANGE COLUMN statement'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_disallow_change_type.yaml b/backend/plugin/advisor/mysql/test/column_disallow_change_type.yaml
index a0f5da374c..57e5d12ec0 100644
--- a/backend/plugin/advisor/mysql/test/column_disallow_change_type.yaml
+++ b/backend/plugin/advisor/mysql/test/column_disallow_change_type.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id INTEGER;" changes column type'
startposition:
line: 3
@@ -15,7 +15,7 @@
endposition: null
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id INTEGER UNSIGNED;" changes column type'
startposition:
line: 4
@@ -28,7 +28,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id int(4);" changes column type'
startposition:
line: 2
@@ -41,7 +41,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id bigint;" changes column type'
startposition:
line: 1
@@ -49,7 +49,7 @@
endposition: null
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id smallint;" changes column type'
startposition:
line: 2
@@ -60,7 +60,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book CHANGE name uname varchar(20);" changes column type'
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/column_disallow_changing_order.yaml b/backend/plugin/advisor/mysql/test/column_disallow_changing_order.yaml
index 6285680961..15b30eb146 100644
--- a/backend/plugin/advisor/mysql/test/column_disallow_changing_order.yaml
+++ b/backend/plugin/advisor/mysql/test/column_disallow_changing_order.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t MODIFY COLUMN a int FIRST;" changes column order'
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t CHANGE COLUMN a1 a int FIRST;" changes column order'
startposition:
line: 2
@@ -35,7 +35,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t MODIFY COLUMN a int AFTER b;" changes column order'
startposition:
line: 2
@@ -48,7 +48,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t CHANGE COLUMN a1 a int AFTER b;" changes column order'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_disallow_drop_in_index.yaml b/backend/plugin/advisor/mysql/test/column_disallow_drop_in_index.yaml
index b1ea77d936..f8ad764e08 100644
--- a/backend/plugin/advisor/mysql/test/column_disallow_drop_in_index.yaml
+++ b/backend/plugin/advisor/mysql/test/column_disallow_drop_in_index.yaml
@@ -36,7 +36,7 @@
want:
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`b` cannot drop index column'
startposition:
line: 2
@@ -49,7 +49,7 @@
want:
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`c` cannot drop index column'
startposition:
line: 2
@@ -68,7 +68,7 @@
want:
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`a` cannot drop index column'
startposition:
line: 2
@@ -76,9 +76,9 @@
endposition: null
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`c` cannot drop index column'
startposition:
line: 3
column: 0
- endposition: null
+ endposition: null
\ No newline at end of file
diff --git a/backend/plugin/advisor/mysql/test/column_disallow_set_charset.yaml b/backend/plugin/advisor/mysql/test/column_disallow_set_charset.yaml
index f93fcdb380..f433112dcc 100644
--- a/backend/plugin/advisor/mysql/test/column_disallow_set_charset.yaml
+++ b/backend/plugin/advisor/mysql/test/column_disallow_set_charset.yaml
@@ -11,7 +11,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "CREATE TABLE t1(a varchar(20) CHARSET ascii);" does
startposition:
line: 1
@@ -19,7 +19,7 @@
endposition: null
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "CREATE TABLE t2(a varchar(20) CHARSET ascii);" does
startposition:
line: 2
@@ -32,7 +32,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book ADD COLUMN b varchar(20) CHARSET ascii;" does
startposition:
line: 2
@@ -46,7 +46,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book ADD COLUMN (c varchar(20) CHARSET ascii, d varchar(20) CHARSET ascii);" does
startposition:
line: 2
@@ -54,7 +54,7 @@
endposition: null
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book ADD COLUMN (c varchar(20) CHARSET ascii, d varchar(20) CHARSET ascii);" does
startposition:
line: 2
@@ -62,7 +62,7 @@
endposition: null
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book ADD COLUMN e varchar(20) CHARSET ascii;" does
startposition:
line: 3
@@ -75,7 +75,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book MODIFY COLUMN id varchar(20) CHARSET ascii;" does
startposition:
line: 2
@@ -88,7 +88,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book CHANGE COLUMN name name varchar(20) CHARSET ascii;" does
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_maximum_character_length.yaml b/backend/plugin/advisor/mysql/test/column_maximum_character_length.yaml
index 2b23ce35ba..5242242dc5 100644
--- a/backend/plugin/advisor/mysql/test/column_maximum_character_length.yaml
+++ b/backend/plugin/advisor/mysql/test/column_maximum_character_length.yaml
@@ -11,7 +11,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `t2.name` is bigger than 20, please use VARCHAR instead
startposition:
line: 2
@@ -24,7 +24,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `tech_book.name_2` is bigger than 20, please use VARCHAR instead
startposition:
line: 2
@@ -37,7 +37,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `tech_book.name` is bigger than 20, please use VARCHAR instead
startposition:
line: 2
@@ -50,7 +50,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `tech_book.name` is bigger than 20, please use VARCHAR instead
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_maximum_varchar_length.yaml b/backend/plugin/advisor/mysql/test/column_maximum_varchar_length.yaml
index 09521a2f1f..1372cbf370 100644
--- a/backend/plugin/advisor/mysql/test/column_maximum_varchar_length.yaml
+++ b/backend/plugin/advisor/mysql/test/column_maximum_varchar_length.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The length of the VARCHAR column `t1.name` is bigger than 2560
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The length of the VARCHAR column `tech_book.name_2` is bigger than 2560
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_no_null.yaml b/backend/plugin/advisor/mysql/test/column_no_null.yaml
index 7c3eabc583..dba3adcc65 100644
--- a/backend/plugin/advisor/mysql/test/column_no_null.yaml
+++ b/backend/plugin/advisor/mysql/test/column_no_null.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`id` cannot have NULL value'
startposition:
line: 2
@@ -15,7 +15,7 @@
endposition: null
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 3
@@ -26,7 +26,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 1
@@ -37,7 +37,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 1
@@ -52,7 +52,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`id` cannot have NULL value'
startposition:
line: 2
@@ -65,7 +65,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`id` cannot have NULL value'
startposition:
line: 2
@@ -86,7 +86,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_require_default.yaml b/backend/plugin/advisor/mysql/test/column_require_default.yaml
index 3675293869..4d5d57bfee 100644
--- a/backend/plugin/advisor/mysql/test/column_require_default.yaml
+++ b/backend/plugin/advisor/mysql/test/column_require_default.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `t`.`b` doesn't have DEFAULT.
startposition:
line: 3
@@ -53,7 +53,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `t`.`a` doesn't have DEFAULT.
startposition:
line: 2
@@ -67,7 +67,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `tech_book`.`b` doesn't have DEFAULT.
startposition:
line: 2
@@ -75,7 +75,7 @@
endposition: null
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `tech_book`.`a` doesn't have DEFAULT.
startposition:
line: 3
@@ -86,7 +86,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `tech_book`.`b` doesn't have DEFAULT.
startposition:
line: 1
@@ -100,7 +100,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `tech_book`.`b` doesn't have DEFAULT.
startposition:
line: 3
diff --git a/backend/plugin/advisor/mysql/test/column_required.yaml b/backend/plugin/advisor/mysql/test/column_required.yaml
index 86d01e58b2..be09b8c9ed 100644
--- a/backend/plugin/advisor/mysql/test/column_required.yaml
+++ b/backend/plugin/advisor/mysql/test/column_required.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `t1` requires columns: created_ts, creator_id, id, updated_ts, updater_id'
startposition:
line: 1
@@ -17,7 +17,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: created_ts, creator_id, updated_ts, updater_id'
startposition:
line: 2
@@ -25,7 +25,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `t2` requires columns: created_ts, updated_ts, updater_id'
startposition:
line: 3
@@ -33,7 +33,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `t3` requires columns: updated_ts, updater_id'
startposition:
line: 4
@@ -41,7 +41,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `t4` requires columns: updated_ts'
startposition:
line: 5
@@ -69,7 +69,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 8
@@ -98,7 +98,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 8
@@ -127,7 +127,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 8
@@ -156,7 +156,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: updater_id'
startposition:
line: 1
@@ -188,7 +188,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 1
@@ -196,7 +196,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `student` requires columns: creator_id, updater_id'
startposition:
line: 7
diff --git a/backend/plugin/advisor/mysql/test/column_set_default_for_not_null.yaml b/backend/plugin/advisor/mysql/test/column_set_default_for_not_null.yaml
index ff8ea5d33b..d27532d993 100644
--- a/backend/plugin/advisor/mysql/test/column_set_default_for_not_null.yaml
+++ b/backend/plugin/advisor/mysql/test/column_set_default_for_not_null.yaml
@@ -16,7 +16,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -39,7 +39,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -52,7 +52,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`b` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -60,7 +60,7 @@
endposition: null
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`c` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -73,7 +73,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -94,7 +94,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/column_type_disallow_list.yaml b/backend/plugin/advisor/mysql/test/column_type_disallow_list.yaml
index 1e2228be24..5e29c8b28f 100644
--- a/backend/plugin/advisor/mysql/test/column_type_disallow_list.yaml
+++ b/backend/plugin/advisor/mysql/test/column_type_disallow_list.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 2
@@ -39,7 +39,7 @@
endposition: null
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`b` is
startposition:
line: 2
@@ -52,7 +52,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 2
@@ -65,7 +65,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`c` is
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/database_drop_empty_database.yaml b/backend/plugin/advisor/mysql/test/database_drop_empty_database.yaml
index ef87368005..1ef5f0452d 100644
--- a/backend/plugin/advisor/mysql/test/database_drop_empty_database.yaml
+++ b/backend/plugin/advisor/mysql/test/database_drop_empty_database.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 701
- title: database.drop-empty-database
+ title: DATABASE_DROP_EMPTY_DATABASE
content: Database `test` is not allowed to drop if not empty
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/engine_mysql_use_innodb.yaml b/backend/plugin/advisor/mysql/test/engine_mysql_use_innodb.yaml
index 1e1ce7a471..ef6be943df 100644
--- a/backend/plugin/advisor/mysql/test/engine_mysql_use_innodb.yaml
+++ b/backend/plugin/advisor/mysql/test/engine_mysql_use_innodb.yaml
@@ -15,7 +15,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: |-
"CREATE TABLE userTable(
id INT NOT NULL,
@@ -59,7 +59,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: |-
"CREATE TABLE book(
id INT,
@@ -79,7 +79,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: |-
"CREATE TABLE book(
id INT,
@@ -99,7 +99,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: '"ALTER TABLE tech_book ENGINE = CSV;" doesn''t use InnoDB engine'
startposition:
line: 3
@@ -114,7 +114,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: '"SET default_storage_engine=CSV;" doesn''t use InnoDB engine'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/index_key_number_limit.yaml b/backend/plugin/advisor/mysql/test/index_key_number_limit.yaml
index a352dc3f18..1747f7951b 100644
--- a/backend/plugin/advisor/mysql/test/index_key_number_limit.yaml
+++ b/backend/plugin/advisor/mysql/test/index_key_number_limit.yaml
@@ -12,7 +12,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `pk` in table `t` should be not greater than 5
startposition:
line: 4
@@ -20,7 +20,7 @@
endposition: null
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `uk` in table `t` should be not greater than 5
startposition:
line: 5
@@ -28,7 +28,7 @@
endposition: null
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `fk` in table `t` should be not greater than 5
startposition:
line: 6
@@ -42,7 +42,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `idx` in table `t` should be not greater than 5
startposition:
line: 2
@@ -50,7 +50,7 @@
endposition: null
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `uk` in table `t` should be not greater than 5
startposition:
line: 3
@@ -64,7 +64,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `pk` in table `t` should be not greater than 5
startposition:
line: 2
@@ -72,7 +72,7 @@
endposition: null
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `uk` in table `t` should be not greater than 5
startposition:
line: 3
@@ -85,7 +85,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `uk` in table `t` should be not greater than 5
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/index_no_duplicate_column.yaml b/backend/plugin/advisor/mysql/test/index_no_duplicate_column.yaml
index 8d486fb8b2..b1c50cbf85 100644
--- a/backend/plugin/advisor/mysql/test/index_no_duplicate_column.yaml
+++ b/backend/plugin/advisor/mysql/test/index_no_duplicate_column.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: PRIMARY KEY `` has duplicate column `t`.`a`
startposition:
line: 3
@@ -32,7 +32,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: FOREIGN KEY `fk1` has duplicate column `t3`.`a`
startposition:
line: 11
@@ -47,7 +47,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 3
@@ -61,7 +61,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 3
@@ -75,7 +75,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: UNIQUE INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 3
@@ -89,7 +89,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 3
@@ -102,7 +102,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: PRIMARY KEY `pk_a` has duplicate column `t`.`a`
startposition:
line: 2
@@ -120,7 +120,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: UNIQUE KEY `uk_a` has duplicate column `t`.`a`
startposition:
line: 3
@@ -134,7 +134,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: FOREIGN KEY `fk_a` has duplicate column `t`.`a`
startposition:
line: 3
diff --git a/backend/plugin/advisor/mysql/test/index_pk_type_limit.yaml b/backend/plugin/advisor/mysql/test/index_pk_type_limit.yaml
index dcfb1b92c4..de01aefdcc 100644
--- a/backend/plugin/advisor/mysql/test/index_pk_type_limit.yaml
+++ b/backend/plugin/advisor/mysql/test/index_pk_type_limit.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 1
@@ -35,7 +35,7 @@
endposition: null
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id3` is varchar(5)
startposition:
line: 1
@@ -52,7 +52,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -69,7 +69,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -82,7 +82,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 2
@@ -90,7 +90,7 @@
endposition: null
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id3` is varchar(5)
startposition:
line: 2
@@ -111,7 +111,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -124,7 +124,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 2
@@ -132,7 +132,7 @@
endposition: null
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id3` is varchar(5)
startposition:
line: 2
@@ -153,7 +153,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -170,7 +170,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/index_primary_key_type_allowlist.yaml b/backend/plugin/advisor/mysql/test/index_primary_key_type_allowlist.yaml
index fcec6b7aac..1da58bdcea 100644
--- a/backend/plugin/advisor/mysql/test/index_primary_key_type_allowlist.yaml
+++ b/backend/plugin/advisor/mysql/test/index_primary_key_type_allowlist.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -35,7 +35,7 @@
endposition: null
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id3` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -52,7 +52,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -69,7 +69,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -82,7 +82,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -90,7 +90,7 @@
endposition: null
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id3` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -111,7 +111,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -124,7 +124,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -132,7 +132,7 @@
endposition: null
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id3` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -153,7 +153,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -170,7 +170,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/index_total_number_limit.yaml b/backend/plugin/advisor/mysql/test/index_total_number_limit.yaml
index 6825fee445..f1fbc629df 100644
--- a/backend/plugin/advisor/mysql/test/index_total_number_limit.yaml
+++ b/backend/plugin/advisor/mysql/test/index_total_number_limit.yaml
@@ -12,7 +12,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `tech_book` should be no more than 5, but found 8
startposition:
line: 5
@@ -29,7 +29,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `t` should be no more than 5, but found 6
startposition:
line: 6
@@ -49,7 +49,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `t` should be no more than 5, but found 6
startposition:
line: 1
@@ -70,7 +70,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `t` should be no more than 5, but found 6
startposition:
line: 10
diff --git a/backend/plugin/advisor/mysql/test/index_type_allow_list.yaml b/backend/plugin/advisor/mysql/test/index_type_allow_list.yaml
index 4d6e9b0ec0..84957c82a4 100644
--- a/backend/plugin/advisor/mysql/test/index_type_allow_list.yaml
+++ b/backend/plugin/advisor/mysql/test/index_type_allow_list.yaml
@@ -24,7 +24,7 @@
want:
- status: 2
code: 816
- title: index.type-allow-list
+ title: INDEX_TYPE_ALLOW_LIST
content: Index type `SPATIAL` is not allowed
startposition:
line: 5
@@ -40,7 +40,7 @@
want:
- status: 2
code: 816
- title: index.type-allow-list
+ title: INDEX_TYPE_ALLOW_LIST
content: Index type `FULLTEXT` is not allowed
startposition:
line: 5
diff --git a/backend/plugin/advisor/mysql/test/index_type_no_blob.yaml b/backend/plugin/advisor/mysql/test/index_type_no_blob.yaml
index d252f8cfd8..747f1ab3eb 100644
--- a/backend/plugin/advisor/mysql/test/index_type_no_blob.yaml
+++ b/backend/plugin/advisor/mysql/test/index_type_no_blob.yaml
@@ -15,7 +15,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `userTable`.`content` is blob
startposition:
line: 12
@@ -39,7 +39,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -50,7 +50,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -58,7 +58,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 1
@@ -66,7 +66,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 1
@@ -77,7 +77,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -85,7 +85,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 1
@@ -93,7 +93,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 1
@@ -104,7 +104,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -112,7 +112,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 1
@@ -120,7 +120,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 1
@@ -135,7 +135,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -148,7 +148,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -156,7 +156,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 2
@@ -164,7 +164,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 2
@@ -177,7 +177,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -185,7 +185,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 2
@@ -193,7 +193,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 2
@@ -213,7 +213,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -221,7 +221,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 3
@@ -229,7 +229,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 4
@@ -247,7 +247,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 3
@@ -261,7 +261,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`d` is blob
startposition:
line: 3
diff --git a/backend/plugin/advisor/mysql/test/naming_column.yaml b/backend/plugin/advisor/mysql/test/naming_column.yaml
index 86d56d9780..e6d357285d 100644
--- a/backend/plugin/advisor/mysql/test/naming_column.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_column.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`creatorId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`gbhzmtchhsjzyrhdroxmyouwloxqezowdvhcbqalqcgqhfbjnvmhwrbggezmzeusx` mismatches column naming convention, its length should be within 64 characters'
startposition:
line: 1
@@ -30,7 +30,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`creatorId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
@@ -38,7 +38,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`gbhzmtchhsjzyrhdroxmyouwloxqezowdvhcbqalqcgqhfbjnvmhwrbggezmzeusx` mismatches column naming convention, its length should be within 64 characters'
startposition:
line: 3
@@ -51,7 +51,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`tech_book`.`gbhzmtchhsjzyrhdroxmyouwloxqezowdvhcbqalqcgqhfbjnvmhwrbggezmzeusx` mismatches column naming convention, its length should be within 64 characters'
startposition:
line: 2
@@ -69,7 +69,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`creatorId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 7
@@ -92,7 +92,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`contentString` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 6
@@ -109,7 +109,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`contentString` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 6
@@ -117,7 +117,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`personAge` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 6
@@ -137,7 +137,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`createdTs` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 3
@@ -145,7 +145,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`updaterId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 4
@@ -153,7 +153,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`student`.`createdTs` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 8
@@ -161,7 +161,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`student`.`updatedTs` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 9
diff --git a/backend/plugin/advisor/mysql/test/naming_column_auto_increment.yaml b/backend/plugin/advisor/mysql/test/naming_column_auto_increment.yaml
index 298adc1a5f..14a379d4c6 100644
--- a/backend/plugin/advisor/mysql/test/naming_column_auto_increment.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_column_auto_increment.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`book`.`a` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`tech_book`.`a` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`tech_book`.`a` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`tech_book`.`name` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/naming_identifier_no_keyword.yaml b/backend/plugin/advisor/mysql/test/naming_identifier_no_keyword.yaml
index f07df1a297..946966c37f 100644
--- a/backend/plugin/advisor/mysql/test/naming_identifier_no_keyword.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_identifier_no_keyword.yaml
@@ -16,7 +16,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "execute" is a keyword and should be avoided
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "execute" is a keyword and should be avoided
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "interval" is a keyword and should be avoided
startposition:
line: 1
@@ -49,7 +49,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "current_timestamp" is a keyword and should be avoided
startposition:
line: 3
@@ -60,7 +60,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "interval" is a keyword and should be avoided
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/naming_index_fk.yaml b/backend/plugin/advisor/mysql/test/naming_index_fk.yaml
index dc1ca53d4c..b53bc97a19 100644
--- a/backend/plugin/advisor/mysql/test/naming_index_fk.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_index_fk.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `userTable` mismatches the naming convention, expect "^$|^fk_userTable_roomId_room_id$" but found `fk1`
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `tech_book` mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found `fk_author_id`
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key `rvemempmcmmhutaskvcidmwaldtfjdgmcpkhmibtadfydtkexpuzczrrneucthfwk` in table `tech_book` mismatches the naming convention, its length should be within 64 characters
startposition:
line: 1
@@ -35,7 +35,7 @@
endposition: null
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `tech_book` mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found `rvemempmcmmhutaskvcidmwaldtfjdgmcpkhmibtadfydtkexpuzczrrneucthfwk`
startposition:
line: 1
@@ -65,7 +65,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `book` mismatches the naming convention, expect "^$|^fk_book_author_id_author_id$" but found `fk_book_author_id`
startposition:
line: 4
diff --git a/backend/plugin/advisor/mysql/test/naming_index_idx.yaml b/backend/plugin/advisor/mysql/test/naming_index_idx.yaml
index 3784345830..0fdddc42d4 100644
--- a/backend/plugin/advisor/mysql/test/naming_index_idx.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_index_idx.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index `afvjwsgrbgqzjfrkmbcoxzstznuypasijbbcdykoboredqovetzfcmmqliaelyavw` in table `tech_book` mismatches the naming convention, its length should be within 64 characters
startposition:
line: 1
@@ -24,7 +24,7 @@
endposition: null
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `afvjwsgrbgqzjfrkmbcoxzstznuypasijbbcdykoboredqovetzfcmmqliaelyavw`
startposition:
line: 1
@@ -37,7 +37,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `idx_tech_book`
startposition:
line: 1
@@ -50,7 +50,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/naming_index_uk.yaml b/backend/plugin/advisor/mysql/test/naming_index_uk.yaml
index 4b9e9f4784..be3b1f1542 100644
--- a/backend/plugin/advisor/mysql/test/naming_index_uk.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_index_uk.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 2
@@ -20,7 +20,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key `qtzmquwvlnttctfluoouxelxeliltcfzzstrtyocogwwyiyrflmrkbhbfasynlacy` in table `tech_book` mismatches the naming convention, its length should be within 64 characters
startposition:
line: 2
@@ -28,7 +28,7 @@
endposition: null
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `qtzmquwvlnttctfluoouxelxeliltcfzzstrtyocogwwyiyrflmrkbhbfasynlacy`
startposition:
line: 2
@@ -43,7 +43,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 2
@@ -58,7 +58,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `uk_tech_book`
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/naming_table.yaml b/backend/plugin/advisor/mysql/test/naming_table.yaml
index 1f2df8cdcf..dd860c8a32 100644
--- a/backend/plugin/advisor/mysql/test/naming_table.yaml
+++ b/backend/plugin/advisor/mysql/test/naming_table.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`techBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`cjnubexocfhqoogdmihudyahmmghviqkzvpixnwvxtxumvuannpwdcbtsgwrvzpde` mismatches table naming convention, its length should be within 64 characters'
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`TechBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
@@ -46,7 +46,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`LiteraryBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
@@ -60,7 +60,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`LiteraryBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 3
@@ -68,7 +68,7 @@
endposition: null
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`TechBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 3
diff --git a/backend/plugin/advisor/mysql/test/schema_backward_compatibility.yaml b/backend/plugin/advisor/mysql/test/schema_backward_compatibility.yaml
index 113d38f01a..deaf1e577e 100644
--- a/backend/plugin/advisor/mysql/test/schema_backward_compatibility.yaml
+++ b/backend/plugin/advisor/mysql/test/schema_backward_compatibility.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book CHANGE name f2 TEXT;" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT;" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -25,7 +25,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT NULL;" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT NOT NULL;" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -47,7 +47,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT COMMENT ''bla'';" may cause incompatibility with the existing data and code'
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/statement_disallow_commit.yaml b/backend/plugin/advisor/mysql/test/statement_disallow_commit.yaml
index 58b8b737c7..3f2413a5a4 100644
--- a/backend/plugin/advisor/mysql/test/statement_disallow_commit.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_disallow_commit.yaml
@@ -6,7 +6,7 @@
want:
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "COMMIT;"'
startposition:
line: 3
@@ -24,7 +24,7 @@
want:
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "COMMIT;"'
startposition:
line: 3
@@ -32,7 +32,7 @@
endposition: null
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "COMMIT;"'
startposition:
line: 7
diff --git a/backend/plugin/advisor/mysql/test/statement_disallow_limit.yaml b/backend/plugin/advisor/mysql/test/statement_disallow_limit.yaml
index 58918b0313..18da231d0f 100644
--- a/backend/plugin/advisor/mysql/test/statement_disallow_limit.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_disallow_limit.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1103
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "INSERT INTO tech_book SELECT * FROM tech_book LIMIT 1;" uses
startposition:
line: 2
@@ -20,7 +20,7 @@
want:
- status: 2
code: 1103
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "INSERT INTO tech_book SELECT * FROM tech_book UNION SELECT * FROM tech_book LIMIT 1;" uses
startposition:
line: 2
@@ -33,7 +33,7 @@
want:
- status: 2
code: 1103
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "INSERT INTO tech_book SELECT * FROM tech_book UNION SELECT * FROM tech_book LIMIT 1;" uses
startposition:
line: 2
@@ -46,7 +46,7 @@
want:
- status: 2
code: 1102
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "UPDATE tech_book SET name = 'my name' LIMIT 10;" uses
startposition:
line: 2
@@ -59,7 +59,7 @@
want:
- status: 2
code: 1106
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "DELETE FROM tech_book LIMIT 10;" uses
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/statement_disallow_order_by.yaml b/backend/plugin/advisor/mysql/test/statement_disallow_order_by.yaml
index 0747185c8a..647be18a4c 100644
--- a/backend/plugin/advisor/mysql/test/statement_disallow_order_by.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_disallow_order_by.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1104
- title: statement.disallow-order-by
+ title: STATEMENT_DISALLOW_ORDER_BY
content: ORDER BY clause is forbidden in DELETE and UPDATE statements, but "UPDATE tech_book SET name = 'my name' ORDER BY id;" uses
startposition:
line: 2
@@ -20,7 +20,7 @@
want:
- status: 2
code: 1105
- title: statement.disallow-order-by
+ title: STATEMENT_DISALLOW_ORDER_BY
content: ORDER BY clause is forbidden in DELETE and UPDATE statements, but "DELETE FROM tech_book ORDER BY id;" uses
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/statement_insert_disallow_order_by_rand.yaml b/backend/plugin/advisor/mysql/test/statement_insert_disallow_order_by_rand.yaml
index 174411beb4..273e97f540 100644
--- a/backend/plugin/advisor/mysql/test/statement_insert_disallow_order_by_rand.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_insert_disallow_order_by_rand.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1108
- title: statement.insert.disallow-order-by-rand
+ title: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
content: '"INSERT INTO tech_book SELECT * FROM tech_book ORDER BY rand();" uses ORDER BY RAND in the INSERT statement'
startposition:
line: 2
@@ -20,7 +20,7 @@
want:
- status: 2
code: 1108
- title: statement.insert.disallow-order-by-rand
+ title: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
content: '"INSERT INTO tech_book SELECT * FROM tech_book ORDER BY RAND() LIMIT 1;" uses ORDER BY RAND in the INSERT statement'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/statement_insert_must_specify_column.yaml b/backend/plugin/advisor/mysql/test/statement_insert_must_specify_column.yaml
index 1c91852b83..c72d8428d4 100644
--- a/backend/plugin/advisor/mysql/test/statement_insert_must_specify_column.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_insert_must_specify_column.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 1107
- title: statement.insert.must-specify-column
+ title: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
content: The INSERT statement must specify columns but "INSERT INTO t_copy SELECT * FROM t;" does not
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 1107
- title: statement.insert.must-specify-column
+ title: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
content: The INSERT statement must specify columns but "INSERT INTO tech_book VALUES (1, '1');" does not
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/statement_insert_row_limit.yaml b/backend/plugin/advisor/mysql/test/statement_insert_row_limit.yaml
index cb9a101af6..aa1af98470 100644
--- a/backend/plugin/advisor/mysql/test/statement_insert_row_limit.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_insert_row_limit.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1101
- title: statement.insert.row-limit
+ title: STATEMENT_INSERT_ROW_LIMIT
content: '"INSERT INTO tech_book values(1, ''a''), (2, ''b''), (3, ''c''), (4, ''d''), (5, ''e''), (6, ''f'');" inserts 6 rows. The count exceeds 5.'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/statement_max_execution_time.yaml b/backend/plugin/advisor/mysql/test/statement_max_execution_time.yaml
index 1fb17fcde6..48570acdab 100644
--- a/backend/plugin/advisor/mysql/test/statement_max_execution_time.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_max_execution_time.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 235
- title: statement.max-execution-time
+ title: STATEMENT_MAX_EXECUTION_TIME
content: The max_execution_time is not set
startposition: null
endposition: null
@@ -16,7 +16,7 @@
want:
- status: 2
code: 235
- title: statement.max-execution-time
+ title: STATEMENT_MAX_EXECUTION_TIME
content: The max_execution_time is not set
startposition: null
endposition: null
diff --git a/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yaml b/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yaml
index 52741e930a..728e16ebab 100644
--- a/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 223
- title: statement.maximum-join-table-count
+ title: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT
content: '"select name from hello join world on hello.id = world.id join baby on world.id = baby.id;" exceeds the maximum number of joins 2.'
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yaml b/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yaml
index 3b0124f5ea..ec1bc9b686 100644
--- a/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yaml
@@ -4,7 +4,7 @@
want:
- status: 2
code: 222
- title: statement.maximum-limit-value
+ title: STATEMENT_MAXIMUM_LIMIT_VALUE
content: The limit value 1000000 exceeds the maximum allowed value 1000
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/statement_merge_alter_table.yaml b/backend/plugin/advisor/mysql/test/statement_merge_alter_table.yaml
index d8f4b001a2..8f10d81b75 100644
--- a/backend/plugin/advisor/mysql/test/statement_merge_alter_table.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_merge_alter_table.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `tech_book`
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `t`
startposition:
line: 3
@@ -30,7 +30,7 @@
endposition: null
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `tech_book`
startposition:
line: 4
@@ -45,7 +45,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `tech_book`
startposition:
line: 3
@@ -53,7 +53,7 @@
endposition: null
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `t`
startposition:
line: 4
diff --git a/backend/plugin/advisor/mysql/test/statement_require_algorithm_option.yaml b/backend/plugin/advisor/mysql/test/statement_require_algorithm_option.yaml
index f54eeec6f2..79e734ecac 100644
--- a/backend/plugin/advisor/mysql/test/statement_require_algorithm_option.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_require_algorithm_option.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 236
- title: statement.require-algorithm-option
+ title: STATEMENT_REQUIRE_ALGORITHM_OPTION
content: ALTER TABLE statement should include ALGORITHM option
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/statement_require_lock_option.yaml b/backend/plugin/advisor/mysql/test/statement_require_lock_option.yaml
index 995811338b..1c5605cf7c 100644
--- a/backend/plugin/advisor/mysql/test/statement_require_lock_option.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_require_lock_option.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 237
- title: statement.require-lock-option
+ title: STATEMENT_REQUIRE_LOCK_OPTION
content: ALTER TABLE statement should include LOCK option
startposition:
line: 2
@@ -23,7 +23,7 @@
want:
- status: 2
code: 237
- title: statement.require-lock-option
+ title: STATEMENT_REQUIRE_LOCK_OPTION
content: ALTER TABLE statement should include LOCK option
startposition:
line: 3
diff --git a/backend/plugin/advisor/mysql/test/statement_select_no_select_all.yaml b/backend/plugin/advisor/mysql/test/statement_select_no_select_all.yaml
index 367e6c3733..bd7ce1209d 100644
--- a/backend/plugin/advisor/mysql/test/statement_select_no_select_all.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_select_no_select_all.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT * FROM t;" uses SELECT all'
startposition:
line: 1
@@ -19,7 +19,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT * FROM t;" uses SELECT all'
startposition:
line: 2
@@ -27,7 +27,7 @@
endposition: null
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT a, b FROM (SELECT * from t1 JOIN t2) t;" uses SELECT all'
startposition:
line: 3
@@ -42,7 +42,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: |-
"SELECT * FROM t1
UNION
@@ -53,7 +53,7 @@
endposition: null
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: |-
"SELECT * FROM t1
UNION
@@ -71,7 +71,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: |-
"WITH cte AS (
SELECT * FROM a
@@ -82,7 +82,7 @@
endposition: null
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: |-
"WITH cte AS (
SELECT * FROM a
@@ -100,7 +100,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: |-
"SELECT *
FROM a
diff --git a/backend/plugin/advisor/mysql/test/statement_where_disallow_functions_and_calculations.yaml b/backend/plugin/advisor/mysql/test/statement_where_disallow_functions_and_calculations.yaml
index fb8629c62c..9795a42a82 100644
--- a/backend/plugin/advisor/mysql/test/statement_where_disallow_functions_and_calculations.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_where_disallow_functions_and_calculations.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 1702
- title: statement.where.disallow-functions-and-calculations
+ title: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
content: Function is disallowed in where clause, but "SELECT * FROM employee WHERE id = RAND();" uses
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/statement_where_maximum_logical_operator_count.yaml b/backend/plugin/advisor/mysql/test/statement_where_maximum_logical_operator_count.yaml
index 0435e73824..5af84d3efb 100644
--- a/backend/plugin/advisor/mysql/test/statement_where_maximum_logical_operator_count.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_where_maximum_logical_operator_count.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 225
- title: statement.where.maximum-logical-operator-count
+ title: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
content: Number of tokens (5) in IN predicate operation exceeds limit (2) in statement "SELECT * FROM employee WHERE id IN (1, 2, 3, 4, 5);".
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 225
- title: statement.where.maximum-logical-operator-count
+ title: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
content: Number of tokens (5) in the OR predicate operation exceeds limit (2) in statement "SELECT * FROM employee WHERE id = 1 OR id = 2 OR id = 3 OR id = 4 OR id = 5;".
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/statement_where_no_equal_null.yaml b/backend/plugin/advisor/mysql/test/statement_where_no_equal_null.yaml
index 8d94416803..6a1d7efa89 100644
--- a/backend/plugin/advisor/mysql/test/statement_where_no_equal_null.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_where_no_equal_null.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 221
- title: statement.where.no-equal-null
+ title: STATEMENT_WHERE_NO_EQUAL_NULL
content: 'WHERE clause contains equal null: SELECT * FROM t WHERE name = ''test'' AND id = NULL;'
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/statement_where_no_leading_wildcard_like.yaml b/backend/plugin/advisor/mysql/test/statement_where_no_leading_wildcard_like.yaml
index 42329b42bd..1ab0285b34 100644
--- a/backend/plugin/advisor/mysql/test/statement_where_no_leading_wildcard_like.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_where_no_leading_wildcard_like.yaml
@@ -4,7 +4,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"DELETE FROM tech_book WHERE name like "%abc";" uses leading wildcard LIKE'
startposition:
line: 1
@@ -21,7 +21,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''%abc'';" uses leading wildcard LIKE'
startposition:
line: 2
@@ -34,7 +34,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''abc'' OR a LIKE ''%abc'';" uses leading wildcard LIKE'
startposition:
line: 2
@@ -50,7 +50,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: |-
"SELECT *
FROM t
@@ -62,7 +62,7 @@
endposition: null
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: |-
"SELECT *
FROM t
@@ -84,7 +84,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: |-
"SELECT * FROM
(
@@ -98,7 +98,7 @@
endposition: null
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: |-
"SELECT * FROM
(
diff --git a/backend/plugin/advisor/mysql/test/statement_where_require_select.yaml b/backend/plugin/advisor/mysql/test/statement_where_require_select.yaml
index e2a6040799..78ad014c49 100644
--- a/backend/plugin/advisor/mysql/test/statement_where_require_select.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_where_require_select.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: '"SELECT id FROM book;" requires WHERE clause'
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: |-
"SELECT id
FROM book
diff --git a/backend/plugin/advisor/mysql/test/statement_where_require_update_delete.yaml b/backend/plugin/advisor/mysql/test/statement_where_require_update_delete.yaml
index 30174d8af3..34abb23e4d 100644
--- a/backend/plugin/advisor/mysql/test/statement_where_require_update_delete.yaml
+++ b/backend/plugin/advisor/mysql/test/statement_where_require_update_delete.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: '"DELETE FROM book;" requires WHERE clause'
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: '"UPDATE book SET id = 1;" requires WHERE clause'
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/system_charset_allowlist.yaml b/backend/plugin/advisor/mysql/test/system_charset_allowlist.yaml
index 068e5ada47..2d9c56fa7b 100644
--- a/backend/plugin/advisor/mysql/test/system_charset_allowlist.yaml
+++ b/backend/plugin/advisor/mysql/test/system_charset_allowlist.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"CREATE TABLE t(a int) CHARSET ascii;" used disabled charset ''ascii'''
startposition:
line: 1
@@ -20,7 +20,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t CHARSET ascii;" used disabled charset ''ascii'''
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER DATABASE test CHARSET ascii;" used disabled charset ''ascii'''
startposition:
line: 1
@@ -42,7 +42,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"CREATE TABLE t(a varchar(255) CHARSET ascii);" used disabled charset ''ascii'''
startposition:
line: 1
@@ -55,7 +55,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t ADD COLUMN a varchar(255) CHARSET ascii;" used disabled charset ''ascii'''
startposition:
line: 2
@@ -68,7 +68,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t MODIFY COLUMN a varchar(255) CHARSET ascii;" used disabled charset ''ascii'''
startposition:
line: 2
@@ -81,7 +81,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t CHANGE COLUMN a a varchar(255) CHARSET ascii;" used disabled charset ''ascii'''
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/system_collation_allowlist.yaml b/backend/plugin/advisor/mysql/test/system_collation_allowlist.yaml
index b93a37b04a..df82bc0fb9 100644
--- a/backend/plugin/advisor/mysql/test/system_collation_allowlist.yaml
+++ b/backend/plugin/advisor/mysql/test/system_collation_allowlist.yaml
@@ -17,7 +17,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: |-
"CREATE TABLE userTable(
id INT NOT NULL,
@@ -53,7 +53,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"CREATE TABLE t(a int) COLLATE utf8mb4_polish_ci;" used disabled collation ''utf8mb4_polish_ci'''
startposition:
line: 1
@@ -66,7 +66,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"CREATE TABLE t(a int) COLLATE latin1_bin;" used disabled collation ''latin1_bin'''
startposition:
line: 1
@@ -79,7 +79,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t COLLATE latin1_bin;" used disabled collation ''latin1_bin'''
startposition:
line: 2
@@ -90,7 +90,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER DATABASE test COLLATE latin1_bin;" used disabled collation ''latin1_bin'''
startposition:
line: 1
@@ -101,7 +101,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"CREATE TABLE t(a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin);" used disabled collation ''latin1_bin'''
startposition:
line: 1
@@ -114,7 +114,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t ADD COLUMN a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin;" used disabled collation ''latin1_bin'''
startposition:
line: 2
@@ -127,7 +127,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t MODIFY COLUMN a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin;" used disabled collation ''latin1_bin'''
startposition:
line: 2
@@ -140,7 +140,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t CHANGE COLUMN a a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin;" used disabled collation ''latin1_bin'''
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/system_event_disallow_create.yaml b/backend/plugin/advisor/mysql/test/system_event_disallow_create.yaml
index e5d06217df..1b954224f1 100644
--- a/backend/plugin/advisor/mysql/test/system_event_disallow_create.yaml
+++ b/backend/plugin/advisor/mysql/test/system_event_disallow_create.yaml
@@ -13,7 +13,7 @@
want:
- status: 2
code: 1501
- title: system.event.disallow-create
+ title: SYSTEM_EVENT_DISALLOW_CREATE
content: |-
Event is forbidden, but "CREATE EVENT daily_backup
ON SCHEDULE
diff --git a/backend/plugin/advisor/mysql/test/system_function_disallow_create.yaml b/backend/plugin/advisor/mysql/test/system_function_disallow_create.yaml
index 7c9a2d1d8b..d135aa18cc 100644
--- a/backend/plugin/advisor/mysql/test/system_function_disallow_create.yaml
+++ b/backend/plugin/advisor/mysql/test/system_function_disallow_create.yaml
@@ -12,7 +12,7 @@
want:
- status: 2
code: 1701
- title: system.function.disallow-create
+ title: SYSTEM_FUNCTION_DISALLOW_CREATE
content: |-
Function is forbidden, but "CREATE FUNCTION add_two_numbers(a INT, b INT)
RETURNS INT
diff --git a/backend/plugin/advisor/mysql/test/system_function_disallowed_list.yaml b/backend/plugin/advisor/mysql/test/system_function_disallowed_list.yaml
index 5dacabf90d..8b1002b9a5 100644
--- a/backend/plugin/advisor/mysql/test/system_function_disallowed_list.yaml
+++ b/backend/plugin/advisor/mysql/test/system_function_disallowed_list.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1702
- title: system.function.disallowed-list
+ title: SYSTEM_FUNCTION_DISALLOWED_LIST
content: Function "RAND" is disallowed, but "SELECT RAND();" uses
startposition:
line: 1
@@ -21,7 +21,7 @@
want:
- status: 2
code: 1702
- title: system.function.disallowed-list
+ title: SYSTEM_FUNCTION_DISALLOWED_LIST
content: |-
Function "UUID" is disallowed, but "CREATE TABLE employee (
id VARCHAR(36) DEFAULT (UUID()) PRIMARY KEY,
@@ -37,7 +37,7 @@
want:
- status: 2
code: 1702
- title: system.function.disallowed-list
+ title: SYSTEM_FUNCTION_DISALLOWED_LIST
content: Function "SLEEP" is disallowed, but "SELECT SLEEP(5);" uses
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/system_procedure_disallow_create.yaml b/backend/plugin/advisor/mysql/test/system_procedure_disallow_create.yaml
index 5c7e438efe..56bbb2cc1d 100644
--- a/backend/plugin/advisor/mysql/test/system_procedure_disallow_create.yaml
+++ b/backend/plugin/advisor/mysql/test/system_procedure_disallow_create.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 1401
- title: system.procedure.disallow-create
+ title: SYSTEM_PROCEDURE_DISALLOW_CREATE
content: |-
Procedure is forbidden, but "CREATE PROCEDURE simpleProcedure()
BEGIN
diff --git a/backend/plugin/advisor/mysql/test/system_view_disallow_create.yaml b/backend/plugin/advisor/mysql/test/system_view_disallow_create.yaml
index 53369e9788..029e34ca05 100644
--- a/backend/plugin/advisor/mysql/test/system_view_disallow_create.yaml
+++ b/backend/plugin/advisor/mysql/test/system_view_disallow_create.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1601
- title: system.view.disallow-create
+ title: SYSTEM_VIEW_DISALLOW_CREATE
content: View is forbidden, but "CREATE VIEW get_one AS SELECT 1;" creates
startposition:
line: 1
diff --git a/backend/plugin/advisor/mysql/test/table_comment.yaml b/backend/plugin/advisor/mysql/test/table_comment.yaml
index 6013318992..e3ffd516ff 100644
--- a/backend/plugin/advisor/mysql/test/table_comment.yaml
+++ b/backend/plugin/advisor/mysql/test/table_comment.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1301
- title: table.comment
+ title: TABLE_COMMENT
content: The length of table `t` comment should be within 10 characters
startposition:
line: 2
@@ -18,7 +18,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Table `t` requires comments
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 1301
- title: table.comment
+ title: TABLE_COMMENT
content: The length of table `t` comment should be within 10 characters
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/table_disallow_partition.yaml b/backend/plugin/advisor/mysql/test/table_disallow_partition.yaml
index 2c1930dff2..ae2f39687b 100644
--- a/backend/plugin/advisor/mysql/test/table_disallow_partition.yaml
+++ b/backend/plugin/advisor/mysql/test/table_disallow_partition.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: |-
Table partition is forbidden, but "CREATE TABLE t(a int) PARTITION BY RANGE (a) (
PARTITION p0 VALUES LESS THAN (6),
@@ -29,7 +29,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: |-
Table partition is forbidden, but "ALTER TABLE tech_book PARTITION BY RANGE (a) (
PARTITION p0 VALUES LESS THAN (6),
@@ -52,7 +52,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: |-
Table partition is forbidden, but "CREATE TABLE t(a int) PARTITION BY RANGE (a) (
PARTITION p0 VALUES LESS THAN (6),
@@ -64,7 +64,7 @@
endposition: null
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: |-
Table partition is forbidden, but "ALTER TABLE tech_book PARTITION BY RANGE (a) (
PARTITION p0 VALUES LESS THAN (6),
diff --git a/backend/plugin/advisor/mysql/test/table_disallow_set_charset.yaml b/backend/plugin/advisor/mysql/test/table_disallow_set_charset.yaml
index f5c0cd8df4..13b58d390a 100644
--- a/backend/plugin/advisor/mysql/test/table_disallow_set_charset.yaml
+++ b/backend/plugin/advisor/mysql/test/table_disallow_set_charset.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 612
- title: table.disallow-set-charset
+ title: TABLE_DISALLOW_SET_CHARSET
content: |-
Set charset on tables is disallowed, but "CREATE TABLE employee (
id INT PRIMARY KEY,
@@ -27,7 +27,7 @@
want:
- status: 2
code: 612
- title: table.disallow-set-charset
+ title: TABLE_DISALLOW_SET_CHARSET
content: Set charset on tables is disallowed, but "ALTER TABLE employee CONVERT TO CHARACTER SET utf8;" uses
startposition:
line: 5
diff --git a/backend/plugin/advisor/mysql/test/table_disallow_trigger.yaml b/backend/plugin/advisor/mysql/test/table_disallow_trigger.yaml
index 70747f9d93..0a10ad5c92 100644
--- a/backend/plugin/advisor/mysql/test/table_disallow_trigger.yaml
+++ b/backend/plugin/advisor/mysql/test/table_disallow_trigger.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 610
- title: table.disallow-trigger
+ title: TABLE_DISALLOW_TRIGGER
content: |-
Trigger is forbidden, but "CREATE TRIGGER ins_sum BEFORE INSERT ON account
FOR EACH ROW SET @sum = @sum + NEW.amount;" creates
diff --git a/backend/plugin/advisor/mysql/test/table_drop_naming_convention.yaml b/backend/plugin/advisor/mysql/test/table_drop_naming_convention.yaml
index 28e86757a1..2bd947ab21 100644
--- a/backend/plugin/advisor/mysql/test/table_drop_naming_convention.yaml
+++ b/backend/plugin/advisor/mysql/test/table_drop_naming_convention.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '`foo` mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 2
@@ -25,7 +25,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '`bar` mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 4
diff --git a/backend/plugin/advisor/mysql/test/table_no_duplicate_index.yaml b/backend/plugin/advisor/mysql/test/table_no_duplicate_index.yaml
index 6b100d1074..0995e89759 100644
--- a/backend/plugin/advisor/mysql/test/table_no_duplicate_index.yaml
+++ b/backend/plugin/advisor/mysql/test/table_no_duplicate_index.yaml
@@ -31,7 +31,7 @@
want:
- status: 2
code: 815
- title: table.no-duplicate-index
+ title: TABLE_NO_DUPLICATE_INDEX
content: '`users` has duplicate index `idx_username_duplicate`'
startposition:
line: 7
@@ -50,7 +50,7 @@
want:
- status: 2
code: 815
- title: table.no-duplicate-index
+ title: TABLE_NO_DUPLICATE_INDEX
content: '`orders` has duplicate index ``'
startposition:
line: 7
@@ -70,7 +70,7 @@
want:
- status: 2
code: 815
- title: table.no-duplicate-index
+ title: TABLE_NO_DUPLICATE_INDEX
content: '`orders` has duplicate index `idx_duplicate`'
startposition:
line: 9
@@ -88,7 +88,7 @@
want:
- status: 2
code: 815
- title: table.no-duplicate-index
+ title: TABLE_NO_DUPLICATE_INDEX
content: '`orders` has duplicate index `idx_customer_id_duplicate`'
startposition:
line: 7
@@ -106,7 +106,7 @@
want:
- status: 2
code: 815
- title: table.no-duplicate-index
+ title: TABLE_NO_DUPLICATE_INDEX
content: '`orders` has duplicate index `idx_customer_duplicate`'
startposition:
line: 7
diff --git a/backend/plugin/advisor/mysql/test/table_no_foreign_key.yaml b/backend/plugin/advisor/mysql/test/table_no_foreign_key.yaml
index 44f68e7f4d..3e483ac03f 100644
--- a/backend/plugin/advisor/mysql/test/table_no_foreign_key.yaml
+++ b/backend/plugin/advisor/mysql/test/table_no_foreign_key.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: Foreign key is not allowed in the table `tech_book`
startposition:
line: 2
@@ -18,7 +18,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: Foreign key is not allowed in the table `book`
startposition:
line: 2
diff --git a/backend/plugin/advisor/mysql/test/table_require_pk.yaml b/backend/plugin/advisor/mysql/test/table_require_pk.yaml
index 982cd16c96..982d9c6490 100644
--- a/backend/plugin/advisor/mysql/test/table_require_pk.yaml
+++ b/backend/plugin/advisor/mysql/test/table_require_pk.yaml
@@ -15,7 +15,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `userTable` requires PRIMARY KEY
startposition:
line: 1
@@ -42,7 +42,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t2` requires PRIMARY KEY
startposition:
line: 2
@@ -56,7 +56,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t2` requires PRIMARY KEY
startposition:
line: 2
@@ -74,7 +74,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t2` requires PRIMARY KEY
startposition:
line: 2
@@ -97,7 +97,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 2
@@ -110,7 +110,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 2
@@ -144,7 +144,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 3
@@ -157,7 +157,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `tech_book` requires PRIMARY KEY
startposition:
line: 2
@@ -172,7 +172,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `tech_book` requires PRIMARY KEY
startposition:
line: 2
@@ -185,7 +185,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `tech_book` requires PRIMARY KEY
startposition:
line: 2
diff --git a/backend/plugin/advisor/oceanbase/advisor_disallow_offline_ddl.go b/backend/plugin/advisor/oceanbase/advisor_disallow_offline_ddl.go
index d513da0429..4b5aae384b 100644
--- a/backend/plugin/advisor/oceanbase/advisor_disallow_offline_ddl.go
+++ b/backend/plugin/advisor/oceanbase/advisor_disallow_offline_ddl.go
@@ -24,7 +24,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementDisallowOfflineDDL, &DisallowOfflineDdlAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL, &DisallowOfflineDdlAdvisor{})
}
// DisallowOfflineDdlAdvisor is the advisor checking for disallow Offline DDL.
@@ -46,7 +46,7 @@ func (*DisallowOfflineDdlAdvisor) Check(_ context.Context, checkCtx advisor.Cont
checker := &disallowOfflineDdlChecker{
level: level,
- title: checkCtx.Rule.Type,
+ title: checkCtx.Rule.Type.String(),
driver: checkCtx.Driver,
currentDB: checkCtx.CurrentDatabase,
}
diff --git a/backend/plugin/advisor/oceanbase/advisor_insert_row_limit.go b/backend/plugin/advisor/oceanbase/advisor_insert_row_limit.go
index 0f7074e902..8233384e09 100644
--- a/backend/plugin/advisor/oceanbase/advisor_insert_row_limit.go
+++ b/backend/plugin/advisor/oceanbase/advisor_insert_row_limit.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementInsertRowLimit, &InsertRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, &InsertRowLimitAdvisor{})
}
// InsertRowLimitAdvisor is the advisor checking for insert row limit.
@@ -47,7 +47,7 @@ func (*InsertRowLimitAdvisor) Check(ctx context.Context, checkCtx advisor.Contex
checker := &insertRowLimitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
maxRow: payload.Number,
driver: checkCtx.Driver,
ctx: ctx,
diff --git a/backend/plugin/advisor/oceanbase/advisor_statement_affected_row_limit.go b/backend/plugin/advisor/oceanbase/advisor_statement_affected_row_limit.go
index b57e0c0c23..8f0f4290fa 100644
--- a/backend/plugin/advisor/oceanbase/advisor_statement_affected_row_limit.go
+++ b/backend/plugin/advisor/oceanbase/advisor_statement_affected_row_limit.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_OCEANBASE, advisor.SchemaRuleStatementAffectedRowLimit, &StatementAffectedRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT, &StatementAffectedRowLimitAdvisor{})
}
// StatementAffectedRowLimitAdvisor is the advisor checking for UPDATE/DELETE affected row limit.
@@ -46,7 +46,7 @@ func (*StatementAffectedRowLimitAdvisor) Check(ctx context.Context, checkCtx adv
}
checker := &statementAffectedRowLimitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
maxRow: payload.Number,
driver: checkCtx.Driver,
ctx: ctx,
diff --git a/backend/plugin/advisor/oracle/oracle_rules_test.go b/backend/plugin/advisor/oracle/oracle_rules_test.go
index 0750a1f5a9..b27e3c3bac 100644
--- a/backend/plugin/advisor/oracle/oracle_rules_test.go
+++ b/backend/plugin/advisor/oracle/oracle_rules_test.go
@@ -9,28 +9,28 @@ import (
)
func TestOracleRules(t *testing.T) {
- oracleRules := []advisor.SQLReviewRuleType{
- advisor.SchemaRuleTableRequirePK,
- advisor.SchemaRuleTableNoFK,
- advisor.SchemaRuleTableNaming,
- advisor.SchemaRuleRequiredColumn,
- advisor.SchemaRuleColumnTypeDisallowList,
- advisor.SchemaRuleColumnMaximumCharacterLength,
- advisor.SchemaRuleStatementNoSelectAll,
- advisor.SchemaRuleStatementNoLeadingWildcardLike,
- advisor.SchemaRuleStatementRequireWhereForSelect,
- advisor.SchemaRuleStatementRequireWhereForUpdateDelete,
- advisor.SchemaRuleStatementInsertMustSpecifyColumn,
- advisor.SchemaRuleIndexKeyNumberLimit,
- advisor.SchemaRuleColumnNotNull,
- advisor.SchemaRuleColumnRequireDefault,
- advisor.SchemaRuleAddNotNullColumnRequireDefault,
- advisor.SchemaRuleColumnMaximumVarcharLength,
- advisor.SchemaRuleTableNameNoKeyword,
- advisor.SchemaRuleIdentifierNoKeyword,
- advisor.SchemaRuleIdentifierCase,
- advisor.SchemaRuleTableCommentConvention,
- advisor.SchemaRuleColumnCommentConvention,
+ oracleRules := []storepb.SQLReviewRule_Type{
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ storepb.SQLReviewRule_NAMING_TABLE,
+ storepb.SQLReviewRule_COLUMN_REQUIRED,
+ storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,
+ storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,
+ storepb.SQLReviewRule_COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT,
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH,
+ storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD,
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD,
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE,
+ storepb.SQLReviewRule_TABLE_COMMENT,
+ storepb.SQLReviewRule_COLUMN_COMMENT,
}
for _, rule := range oracleRules {
diff --git a/backend/plugin/advisor/oracle/rule_builtin_prior_backup_check.go b/backend/plugin/advisor/oracle/rule_builtin_prior_backup_check.go
index bb8860aa86..e224163d32 100644
--- a/backend/plugin/advisor/oracle/rule_builtin_prior_backup_check.go
+++ b/backend/plugin/advisor/oracle/rule_builtin_prior_backup_check.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.BuiltinRulePriorBackupCheck, &StatementPriorBackupCheckAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK, &StatementPriorBackupCheckAdvisor{})
}
type StatementPriorBackupCheckAdvisor struct {
@@ -43,7 +43,7 @@ func (*StatementPriorBackupCheckAdvisor) Check(ctx context.Context, checkCtx adv
return nil, err
}
- rule := NewStatementPriorBackupCheckRule(ctx, level, string(checkCtx.Rule.Type), checkCtx)
+ rule := NewStatementPriorBackupCheckRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_add_not_null_column_require_default.go b/backend/plugin/advisor/oracle/rule_column_add_not_null_column_require_default.go
index e784a8250d..37249020d6 100644
--- a/backend/plugin/advisor/oracle/rule_column_add_not_null_column_require_default.go
+++ b/backend/plugin/advisor/oracle/rule_column_add_not_null_column_require_default.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleAddNotNullColumnRequireDefault, &ColumnAddNotNullColumnRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT, &ColumnAddNotNullColumnRequireDefaultAdvisor{})
}
// ColumnAddNotNullColumnRequireDefaultAdvisor is the advisor checking for adding not null column requires default.
@@ -40,7 +40,7 @@ func (*ColumnAddNotNullColumnRequireDefaultAdvisor) Check(_ context.Context, che
return nil, err
}
- rule := NewColumnAddNotNullColumnRequireDefaultRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewColumnAddNotNullColumnRequireDefaultRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_comment_convention.go b/backend/plugin/advisor/oracle/rule_column_comment_convention.go
index c709b2519a..281df00662 100644
--- a/backend/plugin/advisor/oracle/rule_column_comment_convention.go
+++ b/backend/plugin/advisor/oracle/rule_column_comment_convention.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleColumnCommentConvention, &ColumnCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_COMMENT, &ColumnCommentConventionAdvisor{})
}
// ColumnCommentConventionAdvisor is the advisor checking for column comment convention.
@@ -43,7 +43,7 @@ func (*ColumnCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor
return nil, err
}
- rule := NewColumnCommentConventionRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, payload)
+ rule := NewColumnCommentConventionRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, payload)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_maximum_character_length.go b/backend/plugin/advisor/oracle/rule_column_maximum_character_length.go
index b210bec59a..374d22407d 100644
--- a/backend/plugin/advisor/oracle/rule_column_maximum_character_length.go
+++ b/backend/plugin/advisor/oracle/rule_column_maximum_character_length.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleColumnMaximumCharacterLength, &ColumnMaximumCharacterLengthAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, &ColumnMaximumCharacterLengthAdvisor{})
}
// ColumnMaximumCharacterLengthAdvisor is the advisor checking for maximum character length.
@@ -49,7 +49,7 @@ func (*ColumnMaximumCharacterLengthAdvisor) Check(_ context.Context, checkCtx ad
return nil, nil
}
- rule := NewColumnMaximumCharacterLengthRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewColumnMaximumCharacterLengthRule(level, checkCtx.Rule.Type.String(), payload.Number)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_maximum_varchar_length.go b/backend/plugin/advisor/oracle/rule_column_maximum_varchar_length.go
index 42927e7164..693dfe6638 100644
--- a/backend/plugin/advisor/oracle/rule_column_maximum_varchar_length.go
+++ b/backend/plugin/advisor/oracle/rule_column_maximum_varchar_length.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleColumnMaximumVarcharLength, &ColumnMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, &ColumnMaximumVarcharLengthAdvisor{})
}
// ColumnMaximumVarcharLengthAdvisor is the advisor checking for maximum varchar length.
@@ -49,7 +49,7 @@ func (*ColumnMaximumVarcharLengthAdvisor) Check(_ context.Context, checkCtx advi
return nil, nil
}
- rule := NewColumnMaximumVarcharLengthRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewColumnMaximumVarcharLengthRule(level, checkCtx.Rule.Type.String(), payload.Number)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_no_null.go b/backend/plugin/advisor/oracle/rule_column_no_null.go
index 7f037e2b9f..4e94edf3af 100644
--- a/backend/plugin/advisor/oracle/rule_column_no_null.go
+++ b/backend/plugin/advisor/oracle/rule_column_no_null.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
}
type columnMap map[string]int
@@ -42,7 +42,7 @@ func (*ColumnNoNullAdvisor) Check(_ context.Context, checkCtx advisor.Context) (
return nil, err
}
- rule := NewColumnNoNullRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewColumnNoNullRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_require.go b/backend/plugin/advisor/oracle/rule_column_require.go
index 15f2d60bb5..a0b1d7541e 100644
--- a/backend/plugin/advisor/oracle/rule_column_require.go
+++ b/backend/plugin/advisor/oracle/rule_column_require.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleRequiredColumn, &ColumnRequireAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequireAdvisor{})
}
// ColumnRequireAdvisor is the advisor checking for column requirement.
@@ -46,7 +46,7 @@ func (*ColumnRequireAdvisor) Check(_ context.Context, checkCtx advisor.Context)
return nil, err
}
- rule := NewColumnRequireRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, columnList)
+ rule := NewColumnRequireRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, columnList)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_require_default.go b/backend/plugin/advisor/oracle/rule_column_require_default.go
index 9674b81c49..fe2bf6fd75 100644
--- a/backend/plugin/advisor/oracle/rule_column_require_default.go
+++ b/backend/plugin/advisor/oracle/rule_column_require_default.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleColumnRequireDefault, &ColumnRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT, &ColumnRequireDefaultAdvisor{})
}
// ColumnRequireDefaultAdvisor is the advisor checking for column default requirement.
@@ -41,7 +41,7 @@ func (*ColumnRequireDefaultAdvisor) Check(_ context.Context, checkCtx advisor.Co
return nil, err
}
- rule := NewColumnRequireDefaultRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewColumnRequireDefaultRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_column_type_disallow_list.go b/backend/plugin/advisor/oracle/rule_column_type_disallow_list.go
index f11a2810c9..d5311ac994 100644
--- a/backend/plugin/advisor/oracle/rule_column_type_disallow_list.go
+++ b/backend/plugin/advisor/oracle/rule_column_type_disallow_list.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
}
// ColumnTypeDisallowListAdvisor is the advisor checking for column type disallow list.
@@ -46,7 +46,7 @@ func (*ColumnTypeDisallowListAdvisor) Check(_ context.Context, checkCtx advisor.
return nil, err
}
- rule := NewColumnTypeDisallowListRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, payload.List)
+ rule := NewColumnTypeDisallowListRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, payload.List)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_index_key_number_limit.go b/backend/plugin/advisor/oracle/rule_index_key_number_limit.go
index 7184a98566..a951e1a88a 100644
--- a/backend/plugin/advisor/oracle/rule_index_key_number_limit.go
+++ b/backend/plugin/advisor/oracle/rule_index_key_number_limit.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleIndexKeyNumberLimit, &IndexKeyNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, &IndexKeyNumberLimitAdvisor{})
}
// IndexKeyNumberLimitAdvisor is the advisor checking for index key number limit.
@@ -48,7 +48,7 @@ func (*IndexKeyNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.Con
return nil, nil
}
- rule := NewIndexKeyNumberLimitRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, payload.Number)
+ rule := NewIndexKeyNumberLimitRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, payload.Number)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_insert_must_specify_column.go b/backend/plugin/advisor/oracle/rule_insert_must_specify_column.go
index 8437ec388e..2eb6239032 100644
--- a/backend/plugin/advisor/oracle/rule_insert_must_specify_column.go
+++ b/backend/plugin/advisor/oracle/rule_insert_must_specify_column.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleStatementInsertMustSpecifyColumn, &InsertMustSpecifyColumnAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, &InsertMustSpecifyColumnAdvisor{})
}
// InsertMustSpecifyColumnAdvisor is the advisor checking for to enforce column specified.
@@ -38,7 +38,7 @@ func (*InsertMustSpecifyColumnAdvisor) Check(_ context.Context, checkCtx advisor
return nil, err
}
- rule := NewInsertMustSpecifyColumnRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewInsertMustSpecifyColumnRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_naming_identifier_case.go b/backend/plugin/advisor/oracle/rule_naming_identifier_case.go
index 2bcb876700..59435ad906 100644
--- a/backend/plugin/advisor/oracle/rule_naming_identifier_case.go
+++ b/backend/plugin/advisor/oracle/rule_naming_identifier_case.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleIdentifierCase, &NamingIdentifierCaseAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE, &NamingIdentifierCaseAdvisor{})
}
// NamingIdentifierCaseAdvisor is the advisor checking for identifier case.
@@ -44,7 +44,7 @@ func (*NamingIdentifierCaseAdvisor) Check(_ context.Context, checkCtx advisor.Co
return nil, err
}
- rule := NewNamingIdentifierCaseRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, payload.Upper)
+ rule := NewNamingIdentifierCaseRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, payload.Upper)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_naming_identifier_no_keyword.go b/backend/plugin/advisor/oracle/rule_naming_identifier_no_keyword.go
index dc05149a14..8fc2b04f80 100644
--- a/backend/plugin/advisor/oracle/rule_naming_identifier_no_keyword.go
+++ b/backend/plugin/advisor/oracle/rule_naming_identifier_no_keyword.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleIdentifierNoKeyword, &NamingIdentifierNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD, &NamingIdentifierNoKeywordAdvisor{})
}
// NamingIdentifierNoKeywordAdvisor is the advisor checking for identifier naming convention without keyword.
@@ -41,7 +41,7 @@ func (*NamingIdentifierNoKeywordAdvisor) Check(_ context.Context, checkCtx advis
return nil, err
}
- rule := NewNamingIdentifierNoKeywordRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewNamingIdentifierNoKeywordRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_naming_table.go b/backend/plugin/advisor/oracle/rule_naming_table.go
index 1cfaa995fe..a5ce3a07ef 100644
--- a/backend/plugin/advisor/oracle/rule_naming_table.go
+++ b/backend/plugin/advisor/oracle/rule_naming_table.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleTableNaming, &NamingTableAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableAdvisor{})
}
// NamingTableAdvisor is the advisor checking for table naming convention.
@@ -44,7 +44,7 @@ func (*NamingTableAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
return nil, err
}
- rule := NewNamingTableRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, format, maxLength)
+ rule := NewNamingTableRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, format, maxLength)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_naming_table_no_keyword.go b/backend/plugin/advisor/oracle/rule_naming_table_no_keyword.go
index cb06250bf7..df5535a997 100644
--- a/backend/plugin/advisor/oracle/rule_naming_table_no_keyword.go
+++ b/backend/plugin/advisor/oracle/rule_naming_table_no_keyword.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleTableNameNoKeyword, &NamingTableNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD, &NamingTableNoKeywordAdvisor{})
}
// NamingTableNoKeywordAdvisor is the advisor checking for table naming convention without keyword.
@@ -41,7 +41,7 @@ func (*NamingTableNoKeywordAdvisor) Check(_ context.Context, checkCtx advisor.Co
return nil, err
}
- rule := NewNamingTableNoKeywordRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewNamingTableNoKeywordRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_select_no_select_all.go b/backend/plugin/advisor/oracle/rule_select_no_select_all.go
index c6ca583b50..18b21ae177 100644
--- a/backend/plugin/advisor/oracle/rule_select_no_select_all.go
+++ b/backend/plugin/advisor/oracle/rule_select_no_select_all.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleStatementNoSelectAll, &SelectNoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &SelectNoSelectAllAdvisor{})
}
// SelectNoSelectAllAdvisor is the advisor checking for no select all.
@@ -38,7 +38,7 @@ func (*SelectNoSelectAllAdvisor) Check(_ context.Context, checkCtx advisor.Conte
return nil, err
}
- rule := NewSelectNoSelectAllRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewSelectNoSelectAllRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_statement_dml_dry_run.go b/backend/plugin/advisor/oracle/rule_statement_dml_dry_run.go
index b4be71909e..08b8d83990 100644
--- a/backend/plugin/advisor/oracle/rule_statement_dml_dry_run.go
+++ b/backend/plugin/advisor/oracle/rule_statement_dml_dry_run.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleStatementDMLDryRun, &StatementDmlDryRunAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, &StatementDmlDryRunAdvisor{})
}
type StatementDmlDryRunAdvisor struct {
@@ -39,7 +39,7 @@ func (*StatementDmlDryRunAdvisor) Check(ctx context.Context, checkCtx advisor.Co
return nil, err
}
- rule := NewStatementDmlDryRunRule(ctx, level, string(checkCtx.Rule.Type), checkCtx.Driver)
+ rule := NewStatementDmlDryRunRule(ctx, level, checkCtx.Rule.Type.String(), checkCtx.Driver)
checker := NewGenericChecker([]Rule{rule})
if checkCtx.Driver != nil {
diff --git a/backend/plugin/advisor/oracle/rule_table_comment_convention.go b/backend/plugin/advisor/oracle/rule_table_comment_convention.go
index 2a8919ea63..76ebf5da36 100644
--- a/backend/plugin/advisor/oracle/rule_table_comment_convention.go
+++ b/backend/plugin/advisor/oracle/rule_table_comment_convention.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleTableCommentConvention, &TableCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_TABLE_COMMENT, &TableCommentConventionAdvisor{})
}
// TableCommentConventionAdvisor is the advisor checking for table comment convention.
@@ -43,7 +43,7 @@ func (*TableCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor.
return nil, err
}
- rule := NewTableCommentConventionRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase, payload)
+ rule := NewTableCommentConventionRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase, payload)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_table_no_foreign_key.go b/backend/plugin/advisor/oracle/rule_table_no_foreign_key.go
index ab52ed68a1..da6618aa1a 100644
--- a/backend/plugin/advisor/oracle/rule_table_no_foreign_key.go
+++ b/backend/plugin/advisor/oracle/rule_table_no_foreign_key.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleTableNoFK, &TableNoForeignKeyAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoForeignKeyAdvisor{})
}
// TableNoForeignKeyAdvisor is the advisor checking for table disallow foreign key.
@@ -40,7 +40,7 @@ func (*TableNoForeignKeyAdvisor) Check(_ context.Context, checkCtx advisor.Conte
return nil, err
}
- rule := NewTableNoForeignKeyRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewTableNoForeignKeyRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_table_require_pk.go b/backend/plugin/advisor/oracle/rule_table_require_pk.go
index ae8d573235..eff9bab360 100644
--- a/backend/plugin/advisor/oracle/rule_table_require_pk.go
+++ b/backend/plugin/advisor/oracle/rule_table_require_pk.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleTableRequirePK, &TableRequirePKAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePKAdvisor{})
}
// TableRequirePKAdvisor is the advisor checking table requires PK.
@@ -39,7 +39,7 @@ func (*TableRequirePKAdvisor) Check(_ context.Context, checkCtx advisor.Context)
return nil, err
}
- rule := NewTableRequirePKRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewTableRequirePKRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_where_no_leading_wildcard_like.go b/backend/plugin/advisor/oracle/rule_where_no_leading_wildcard_like.go
index 45a87effbf..c2c10b9d23 100644
--- a/backend/plugin/advisor/oracle/rule_where_no_leading_wildcard_like.go
+++ b/backend/plugin/advisor/oracle/rule_where_no_leading_wildcard_like.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleStatementNoLeadingWildcardLike, &WhereNoLeadingWildcardLikeAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, &WhereNoLeadingWildcardLikeAdvisor{})
}
// WhereNoLeadingWildcardLikeAdvisor is the advisor checking for no leading wildcard LIKE.
@@ -39,7 +39,7 @@ func (*WhereNoLeadingWildcardLikeAdvisor) Check(_ context.Context, checkCtx advi
return nil, err
}
- rule := NewWhereNoLeadingWildcardLikeRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewWhereNoLeadingWildcardLikeRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_where_require_for_select.go b/backend/plugin/advisor/oracle/rule_where_require_for_select.go
index 34365a88ff..041bbd54ad 100644
--- a/backend/plugin/advisor/oracle/rule_where_require_for_select.go
+++ b/backend/plugin/advisor/oracle/rule_where_require_for_select.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequireForSelectAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequireForSelectAdvisor{})
}
// WhereRequireForSelectAdvisor is the advisor checking for WHERE clause requirement.
@@ -39,7 +39,7 @@ func (*WhereRequireForSelectAdvisor) Check(_ context.Context, checkCtx advisor.C
return nil, err
}
- rule := NewWhereRequireForSelectRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewWhereRequireForSelectRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/rule_where_require_for_update_delete.go b/backend/plugin/advisor/oracle/rule_where_require_for_update_delete.go
index bf1e651e06..9e9bfca30d 100644
--- a/backend/plugin/advisor/oracle/rule_where_require_for_update_delete.go
+++ b/backend/plugin/advisor/oracle/rule_where_require_for_update_delete.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_ORACLE, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequireForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_ORACLE, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequireForUpdateDeleteAdvisor{})
}
// WhereRequireForUpdateDeleteAdvisor is the advisor checking for WHERE clause requirement.
@@ -38,7 +38,7 @@ func (*WhereRequireForUpdateDeleteAdvisor) Check(_ context.Context, checkCtx adv
return nil, err
}
- rule := NewWhereRequireForUpdateDeleteRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewWhereRequireForUpdateDeleteRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, stmtNode := range stmtList {
diff --git a/backend/plugin/advisor/oracle/test/column_add_not_null_require_default.yaml b/backend/plugin/advisor/oracle/test/column_add_not_null_require_default.yaml
index 1fe40b8a68..3c7dc43108 100644
--- a/backend/plugin/advisor/oracle/test/column_add_not_null_require_default.yaml
+++ b/backend/plugin/advisor/oracle/test/column_add_not_null_require_default.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 404
- title: column.add-not-null-require-default
+ title: COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT
content: Adding not null column "READER" requires default.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/column_comment.yaml b/backend/plugin/advisor/oracle/test/column_comment.yaml
index a277992f12..75e517801e 100644
--- a/backend/plugin/advisor/oracle/test/column_comment.yaml
+++ b/backend/plugin/advisor/oracle/test/column_comment.yaml
@@ -14,7 +14,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Comment is required for column "TEST_DB"."T"."A"
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Comment is required for column "TEST_DB"."T"."D"
startposition:
line: 1
@@ -41,7 +41,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Comment is required for column "TEST_DB"."T"."A"
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/column_maximum_character_length.yaml b/backend/plugin/advisor/oracle/test/column_maximum_character_length.yaml
index 4e5835cd8f..51a79e6b5c 100644
--- a/backend/plugin/advisor/oracle/test/column_maximum_character_length.yaml
+++ b/backend/plugin/advisor/oracle/test/column_maximum_character_length.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The maximum character length is 20.
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The maximum character length is 20.
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The maximum character length is 20.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/column_maximum_varchar_length.yaml b/backend/plugin/advisor/oracle/test/column_maximum_varchar_length.yaml
index 7296c3ad30..d95dae2061 100644
--- a/backend/plugin/advisor/oracle/test/column_maximum_varchar_length.yaml
+++ b/backend/plugin/advisor/oracle/test/column_maximum_varchar_length.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/column_no_null.yaml b/backend/plugin/advisor/oracle/test/column_no_null.yaml
index 45d80b0581..a919f02452 100644
--- a/backend/plugin/advisor/oracle/test/column_no_null.yaml
+++ b/backend/plugin/advisor/oracle/test/column_no_null.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "ID" is nullable, which is not allowed.
startposition:
line: 2
@@ -15,7 +15,7 @@
endposition: null
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "NAME" is nullable, which is not allowed.
startposition:
line: 3
@@ -26,7 +26,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "NAME" is nullable, which is not allowed.
startposition:
line: 1
@@ -37,7 +37,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "NAME" is nullable, which is not allowed.
startposition:
line: 1
@@ -48,7 +48,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "NAME" is nullable, which is not allowed.
startposition:
line: 1
@@ -61,7 +61,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "READER" is nullable, which is not allowed.
startposition:
line: 1
@@ -80,7 +80,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "NAME" is nullable, which is not allowed.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/column_require_default.yaml b/backend/plugin/advisor/oracle/test/column_require_default.yaml
index d9155e2d8b..ddcf5402b9 100644
--- a/backend/plugin/advisor/oracle/test/column_require_default.yaml
+++ b/backend/plugin/advisor/oracle/test/column_require_default.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "A" doesn't have default value
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "A" doesn't have default value
startposition:
line: 2
diff --git a/backend/plugin/advisor/oracle/test/column_required.yaml b/backend/plugin/advisor/oracle/test/column_required.yaml
index 032ef38480..664679a5fe 100644
--- a/backend/plugin/advisor/oracle/test/column_required.yaml
+++ b/backend/plugin/advisor/oracle/test/column_required.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table "BOOK" requires columns: "created_ts", "creator_id", "updated_ts", "updater_id"'
startposition:
line: 1
@@ -24,7 +24,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table "TECH_BOOK" requires columns: "creator_id"'
startposition:
line: 2
@@ -37,7 +37,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table "TECH_BOOK" requires columns: "creator_id"'
startposition:
line: 2
diff --git a/backend/plugin/advisor/oracle/test/column_type_disallow_list.yaml b/backend/plugin/advisor/oracle/test/column_type_disallow_list.yaml
index 46d52a2c40..660e764958 100644
--- a/backend/plugin/advisor/oracle/test/column_type_disallow_list.yaml
+++ b/backend/plugin/advisor/oracle/test/column_type_disallow_list.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column "B" is
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column "A" is
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type BINARY_FLOAT but column "D" is
startposition:
line: 2
@@ -42,7 +42,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type BINARY_FLOAT but column "B" is
startposition:
line: 1
@@ -55,7 +55,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type BINARY_FLOAT but column "A" is
startposition:
line: 2
diff --git a/backend/plugin/advisor/oracle/test/index_key_number_limit.yaml b/backend/plugin/advisor/oracle/test/index_key_number_limit.yaml
index 3ff199980b..a7e82824f0 100644
--- a/backend/plugin/advisor/oracle/test/index_key_number_limit.yaml
+++ b/backend/plugin/advisor/oracle/test/index_key_number_limit.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: Index key number should be less than or equal to 5
startposition:
line: 1
@@ -20,7 +20,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: Index key number should be less than or equal to 5
startposition:
line: 1
@@ -33,7 +33,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: Index key number should be less than or equal to 5
startposition:
line: 2
@@ -46,7 +46,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: Index key number should be less than or equal to 5
startposition:
line: 2
@@ -59,7 +59,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: Index key number should be less than or equal to 5
startposition:
line: 2
diff --git a/backend/plugin/advisor/oracle/test/naming_identifier_case.yaml b/backend/plugin/advisor/oracle/test/naming_identifier_case.yaml
index 2df5d901e6..44cb06c98c 100644
--- a/backend/plugin/advisor/oracle/test/naming_identifier_case.yaml
+++ b/backend/plugin/advisor/oracle/test/naming_identifier_case.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 309
- title: naming.identifier.case
+ title: NAMING_IDENTIFIER_CASE
content: Identifier "table" should be upper case
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 309
- title: naming.identifier.case
+ title: NAMING_IDENTIFIER_CASE
content: Identifier "Tt" should be upper case
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/naming_identifier_no_keyword.yaml b/backend/plugin/advisor/oracle/test/naming_identifier_no_keyword.yaml
index ee1b00001d..e31a4c06d3 100644
--- a/backend/plugin/advisor/oracle/test/naming_identifier_no_keyword.yaml
+++ b/backend/plugin/advisor/oracle/test/naming_identifier_no_keyword.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "NAME" is a keyword and should be avoided
startposition:
line: 1
@@ -11,7 +11,7 @@
endposition: null
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "table" is a keyword and should be avoided
startposition:
line: 1
@@ -22,7 +22,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "NAME" is a keyword and should be avoided
startposition:
line: 1
@@ -33,7 +33,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "NAME" is a keyword and should be avoided
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/naming_table.yaml b/backend/plugin/advisor/oracle/test/naming_table.yaml
index 74cf3aa260..38a5342178 100644
--- a/backend/plugin/advisor/oracle/test/naming_table.yaml
+++ b/backend/plugin/advisor/oracle/test/naming_table.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"techBook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TECH_BOOK" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TECHBOOK" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"BOOK" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -49,7 +49,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TechBook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -62,7 +62,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TECHBOOK" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -70,7 +70,7 @@
endposition: null
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TECH_BOOK_TMP" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
@@ -83,7 +83,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TECH_BOOK" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/naming_table_no_keyword.yaml b/backend/plugin/advisor/oracle/test/naming_table_no_keyword.yaml
index e918cc2ff6..b4f375f1d8 100644
--- a/backend/plugin/advisor/oracle/test/naming_table_no_keyword.yaml
+++ b/backend/plugin/advisor/oracle/test/naming_table_no_keyword.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name "table" is a keyword identifier and should be avoided.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name "AVG" is a keyword identifier and should be avoided.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name "AVG" is a keyword identifier and should be avoided.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/statement_insert_must_specify_column.yaml b/backend/plugin/advisor/oracle/test/statement_insert_must_specify_column.yaml
index 7864251051..2a17e6374f 100644
--- a/backend/plugin/advisor/oracle/test/statement_insert_must_specify_column.yaml
+++ b/backend/plugin/advisor/oracle/test/statement_insert_must_specify_column.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1107
- title: statement.insert.must-specify-column
+ title: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
content: INSERT statement should specify column name.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/statement_select_no_select_all.yaml b/backend/plugin/advisor/oracle/test/statement_select_no_select_all.yaml
index 91130b858f..d8fe22afba 100644
--- a/backend/plugin/advisor/oracle/test/statement_select_no_select_all.yaml
+++ b/backend/plugin/advisor/oracle/test/statement_select_no_select_all.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/statement_where_no_leading_wildcard_like.yaml b/backend/plugin/advisor/oracle/test/statement_where_no_leading_wildcard_like.yaml
index ebc32e7a4d..bc2b6016e3 100644
--- a/backend/plugin/advisor/oracle/test/statement_where_no_leading_wildcard_like.yaml
+++ b/backend/plugin/advisor/oracle/test/statement_where_no_leading_wildcard_like.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: Avoid using leading wildcard LIKE.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: Avoid using leading wildcard LIKE.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: Avoid using leading wildcard LIKE.
startposition:
line: 1
@@ -35,7 +35,7 @@
endposition: null
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: Avoid using leading wildcard LIKE.
startposition:
line: 1
@@ -46,7 +46,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: Avoid using leading wildcard LIKE.
startposition:
line: 1
@@ -54,7 +54,7 @@
endposition: null
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: Avoid using leading wildcard LIKE.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/statement_where_require_select.yaml b/backend/plugin/advisor/oracle/test/statement_where_require_select.yaml
index 2da67f4f75..4695d430ac 100644
--- a/backend/plugin/advisor/oracle/test/statement_where_require_select.yaml
+++ b/backend/plugin/advisor/oracle/test/statement_where_require_select.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/statement_where_require_update_delete.yaml b/backend/plugin/advisor/oracle/test/statement_where_require_update_delete.yaml
index 3902319232..d5716d622f 100644
--- a/backend/plugin/advisor/oracle/test/statement_where_require_update_delete.yaml
+++ b/backend/plugin/advisor/oracle/test/statement_where_require_update_delete.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: WHERE clause is required for DELETE statement.
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: WHERE clause is required for UPDATE statement.
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/table_comment.yaml b/backend/plugin/advisor/oracle/test/table_comment.yaml
index f7323f7120..a87b51a68a 100644
--- a/backend/plugin/advisor/oracle/test/table_comment.yaml
+++ b/backend/plugin/advisor/oracle/test/table_comment.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table "TEST_DB"."T"
startposition:
line: 1
@@ -24,7 +24,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table "TEST_DB"."D"
startposition:
line: 2
@@ -38,7 +38,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table "TEST_DB"."T"
startposition:
line: 1
@@ -51,7 +51,7 @@
want:
- status: 2
code: 1301
- title: table.comment
+ title: TABLE_COMMENT
content: Table "TEST_DB"."T" comment is too long. The length of comment should be within 10 characters
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/table_no_foreign_key.yaml b/backend/plugin/advisor/oracle/test/table_no_foreign_key.yaml
index 9f90004526..d0455855c6 100644
--- a/backend/plugin/advisor/oracle/test/table_no_foreign_key.yaml
+++ b/backend/plugin/advisor/oracle/test/table_no_foreign_key.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: Foreign key is not allowed in the table "TEST_DB"."TECH_BOOK".
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: Foreign key is not allowed in the table "TEST_DB"."BOOK".
startposition:
line: 1
diff --git a/backend/plugin/advisor/oracle/test/table_require_pk.yaml b/backend/plugin/advisor/oracle/test/table_require_pk.yaml
index b5c9575406..5a4722229b 100644
--- a/backend/plugin/advisor/oracle/test/table_require_pk.yaml
+++ b/backend/plugin/advisor/oracle/test/table_require_pk.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table "TEST_DB"."T" requires PRIMARY KEY.
startposition:
line: 1
@@ -28,7 +28,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table "TEST_DB"."T" requires PRIMARY KEY.
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/advisor_builtin_prior_backup_check.go b/backend/plugin/advisor/pg/advisor_builtin_prior_backup_check.go
index 919414807d..6ac2fe0150 100644
--- a/backend/plugin/advisor/pg/advisor_builtin_prior_backup_check.go
+++ b/backend/plugin/advisor/pg/advisor_builtin_prior_backup_check.go
@@ -27,7 +27,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.BuiltinRulePriorBackupCheck, &BuiltinPriorBackupCheckAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK, &BuiltinPriorBackupCheckAdvisor{})
}
// BuiltinPriorBackupCheckAdvisor is the advisor checking for disallow mix DDL and DML.
@@ -44,7 +44,7 @@ func (*BuiltinPriorBackupCheckAdvisor) Check(_ context.Context, checkCtx advisor
if err != nil {
return nil, err
}
- title := string(checkCtx.Rule.Type)
+ title := checkCtx.Rule.Type.String()
var adviceList []*storepb.Advice
diff --git a/backend/plugin/advisor/pg/advisor_collation_allowlist.go b/backend/plugin/advisor/pg/advisor_collation_allowlist.go
index ea2ebe3348..1260d7f434 100644
--- a/backend/plugin/advisor/pg/advisor_collation_allowlist.go
+++ b/backend/plugin/advisor/pg/advisor_collation_allowlist.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleCollationAllowlist, &CollationAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST, &CollationAllowlistAdvisor{})
}
// CollationAllowlistAdvisor is the advisor checking for collation allowlist.
@@ -49,7 +49,7 @@ func (*CollationAllowlistAdvisor) Check(_ context.Context, checkCtx advisor.Cont
rule := &collationAllowlistRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
allowlist: allowlist,
}
diff --git a/backend/plugin/advisor/pg/advisor_column_comment_convention.go b/backend/plugin/advisor/pg/advisor_column_comment_convention.go
index 1442a904c6..06a793b839 100644
--- a/backend/plugin/advisor/pg/advisor_column_comment_convention.go
+++ b/backend/plugin/advisor/pg/advisor_column_comment_convention.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnCommentConvention, &ColumnCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_COMMENT, &ColumnCommentConventionAdvisor{})
}
// ColumnCommentConventionAdvisor is the advisor checking for column comment convention.
@@ -43,7 +43,7 @@ func (*ColumnCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor
rule := &columnCommentConventionRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
payload: payload,
}
diff --git a/backend/plugin/advisor/pg/advisor_column_default_disallow_volatile.go b/backend/plugin/advisor/pg/advisor_column_default_disallow_volatile.go
index 59fb501fa2..1a87012844 100644
--- a/backend/plugin/advisor/pg/advisor_column_default_disallow_volatile.go
+++ b/backend/plugin/advisor/pg/advisor_column_default_disallow_volatile.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnDefaultDisallowVolatile, &ColumnDefaultDisallowVolatileAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE, &ColumnDefaultDisallowVolatileAdvisor{})
}
// ColumnDefaultDisallowVolatileAdvisor is the advisor checking for column default volatile functions.
@@ -43,7 +43,7 @@ func (*ColumnDefaultDisallowVolatileAdvisor) Check(_ context.Context, checkCtx a
rule := &columnDefaultDisallowVolatileRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
columnSet: make(map[string]columnData),
}
@@ -73,7 +73,7 @@ type columnDefaultDisallowVolatileRule struct {
}
func (*columnDefaultDisallowVolatileRule) Name() string {
- return string(advisor.SchemaRuleColumnDefaultDisallowVolatile)
+ return string(storepb.SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE)
}
func (r *columnDefaultDisallowVolatileRule) OnEnter(ctx antlr.ParserRuleContext, nodeType string) error {
diff --git a/backend/plugin/advisor/pg/advisor_column_disallow_changing_type.go b/backend/plugin/advisor/pg/advisor_column_disallow_changing_type.go
index 6643681e31..c6ad425751 100644
--- a/backend/plugin/advisor/pg/advisor_column_disallow_changing_type.go
+++ b/backend/plugin/advisor/pg/advisor_column_disallow_changing_type.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnDisallowChangeType, &ColumnDisallowChangingTypeAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE, &ColumnDisallowChangingTypeAdvisor{})
}
// ColumnDisallowChangingTypeAdvisor is the advisor checking for disallow changing column type.
@@ -41,7 +41,7 @@ func (*ColumnDisallowChangingTypeAdvisor) Check(_ context.Context, checkCtx advi
rule := &columnDisallowChangingTypeRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_column_maximum_character_length.go b/backend/plugin/advisor/pg/advisor_column_maximum_character_length.go
index 2ee55f65c5..21125a4d87 100644
--- a/backend/plugin/advisor/pg/advisor_column_maximum_character_length.go
+++ b/backend/plugin/advisor/pg/advisor_column_maximum_character_length.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnMaximumCharacterLength, &ColumnMaximumCharacterLengthAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, &ColumnMaximumCharacterLengthAdvisor{})
}
// ColumnMaximumCharacterLengthAdvisor is the advisor checking for maximum character length.
@@ -50,7 +50,7 @@ func (*ColumnMaximumCharacterLengthAdvisor) Check(_ context.Context, checkCtx ad
rule := &columnMaximumCharacterLengthRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
maximum: payload.Number,
}
diff --git a/backend/plugin/advisor/pg/advisor_column_no_null.go b/backend/plugin/advisor/pg/advisor_column_no_null.go
index 04e5a25db1..24bb87218d 100644
--- a/backend/plugin/advisor/pg/advisor_column_no_null.go
+++ b/backend/plugin/advisor/pg/advisor_column_no_null.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
}
// ColumnNoNullAdvisor is the advisor checking for column no NULL value.
@@ -43,7 +43,7 @@ func (*ColumnNoNullAdvisor) Check(_ context.Context, checkCtx advisor.Context) (
rule := &columnNoNullRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
originalMetadata: checkCtx.OriginalMetadata,
nullableColumns: make(columnMap),
diff --git a/backend/plugin/advisor/pg/advisor_column_require_default.go b/backend/plugin/advisor/pg/advisor_column_require_default.go
index 0f152f0388..53a646ba30 100644
--- a/backend/plugin/advisor/pg/advisor_column_require_default.go
+++ b/backend/plugin/advisor/pg/advisor_column_require_default.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnRequireDefault, &ColumnRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT, &ColumnRequireDefaultAdvisor{})
}
// ColumnRequireDefaultAdvisor is the advisor checking for column default requirement.
@@ -43,7 +43,7 @@ func (*ColumnRequireDefaultAdvisor) Check(_ context.Context, checkCtx advisor.Co
rule := &columnRequireDefaultRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_column_required.go b/backend/plugin/advisor/pg/advisor_column_required.go
index 5d192da9e2..9495ba61d8 100644
--- a/backend/plugin/advisor/pg/advisor_column_required.go
+++ b/backend/plugin/advisor/pg/advisor_column_required.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleRequiredColumn, &ColumnRequirementAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequirementAdvisor{})
}
type columnSet map[string]bool
@@ -57,7 +57,7 @@ func (*ColumnRequirementAdvisor) Check(_ context.Context, checkCtx advisor.Conte
rule := &columnRequirementRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
requiredColumnsMap: requiredColumnsMap,
}
diff --git a/backend/plugin/advisor/pg/advisor_column_type_disallow_list.go b/backend/plugin/advisor/pg/advisor_column_type_disallow_list.go
index 320461947c..958faaa436 100644
--- a/backend/plugin/advisor/pg/advisor_column_type_disallow_list.go
+++ b/backend/plugin/advisor/pg/advisor_column_type_disallow_list.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
}
// ColumnTypeDisallowListAdvisor is the advisor checking for column type restriction.
@@ -54,7 +54,7 @@ func (*ColumnTypeDisallowListAdvisor) Check(_ context.Context, checkCtx advisor.
rule := &columnTypeDisallowListRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
typeRestriction: typeRestriction,
}
diff --git a/backend/plugin/advisor/pg/advisor_comment_convention.go b/backend/plugin/advisor/pg/advisor_comment_convention.go
index fa594bec3e..e01dbddd22 100644
--- a/backend/plugin/advisor/pg/advisor_comment_convention.go
+++ b/backend/plugin/advisor/pg/advisor_comment_convention.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleCommentLength, &CommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_SYSTEM_COMMENT_LENGTH, &CommentConventionAdvisor{})
}
// CommentConventionAdvisor is the advisor checking for comment length.
@@ -45,7 +45,7 @@ func (*CommentConventionAdvisor) Check(_ context.Context, checkCtx advisor.Conte
rule := &commentConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
maxLength: payload.Number,
}
diff --git a/backend/plugin/advisor/pg/advisor_encoding_allowlist.go b/backend/plugin/advisor/pg/advisor_encoding_allowlist.go
index f69962e168..fdc1d5b5ed 100644
--- a/backend/plugin/advisor/pg/advisor_encoding_allowlist.go
+++ b/backend/plugin/advisor/pg/advisor_encoding_allowlist.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleCharsetAllowlist, &EncodingAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST, &EncodingAllowlistAdvisor{})
}
// EncodingAllowlistAdvisor is the advisor checking for encoding allowlist.
@@ -52,7 +52,7 @@ func (*EncodingAllowlistAdvisor) Check(_ context.Context, checkCtx advisor.Conte
rule := &encodingAllowlistRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
allowlist: allowlist,
}
diff --git a/backend/plugin/advisor/pg/advisor_index_create_concurrently.go b/backend/plugin/advisor/pg/advisor_index_create_concurrently.go
index e828ab4fa1..e318264176 100644
--- a/backend/plugin/advisor/pg/advisor_index_create_concurrently.go
+++ b/backend/plugin/advisor/pg/advisor_index_create_concurrently.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleCreateIndexConcurrently, &IndexConcurrentlyAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_INDEX_CREATE_CONCURRENTLY, &IndexConcurrentlyAdvisor{})
}
// IndexConcurrentlyAdvisor is the advisor checking for to create index concurrently.
@@ -40,7 +40,7 @@ func (*IndexConcurrentlyAdvisor) Check(_ context.Context, checkCtx advisor.Conte
rule := &indexCreateConcurrentlyRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
newlyCreatedTables: make(map[string]bool),
}
diff --git a/backend/plugin/advisor/pg/advisor_index_key_number_limit.go b/backend/plugin/advisor/pg/advisor_index_key_number_limit.go
index 98b06718eb..bf6713071f 100644
--- a/backend/plugin/advisor/pg/advisor_index_key_number_limit.go
+++ b/backend/plugin/advisor/pg/advisor_index_key_number_limit.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleIndexKeyNumberLimit, &IndexKeyNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, &IndexKeyNumberLimitAdvisor{})
}
// IndexKeyNumberLimitAdvisor is the advisor checking for index key number limit.
@@ -47,7 +47,7 @@ func (*IndexKeyNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.Con
rule := &indexKeyNumberLimitRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
max: payload.Number,
}
diff --git a/backend/plugin/advisor/pg/advisor_index_no_duplicate_column.go b/backend/plugin/advisor/pg/advisor_index_no_duplicate_column.go
index cee0a0f6fb..13f2c4c85b 100644
--- a/backend/plugin/advisor/pg/advisor_index_no_duplicate_column.go
+++ b/backend/plugin/advisor/pg/advisor_index_no_duplicate_column.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleIndexNoDuplicateColumn, &IndexNoDuplicateColumnAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN, &IndexNoDuplicateColumnAdvisor{})
}
// IndexNoDuplicateColumnAdvisor is the advisor checking for no duplicate columns in index.
@@ -42,7 +42,7 @@ func (*IndexNoDuplicateColumnAdvisor) Check(_ context.Context, checkCtx advisor.
rule := &indexNoDuplicateColumnRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_index_primary_key_type_allowlist.go b/backend/plugin/advisor/pg/advisor_index_primary_key_type_allowlist.go
index bb39ec9651..226cc89825 100644
--- a/backend/plugin/advisor/pg/advisor_index_primary_key_type_allowlist.go
+++ b/backend/plugin/advisor/pg/advisor_index_primary_key_type_allowlist.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist, &IndexPrimaryKeyTypeAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST, &IndexPrimaryKeyTypeAllowlistAdvisor{})
}
// IndexPrimaryKeyTypeAllowlistAdvisor is the advisor checking for primary key type allowlist.
@@ -45,7 +45,7 @@ func (*IndexPrimaryKeyTypeAllowlistAdvisor) Check(_ context.Context, checkCtx ad
}
rule := &indexPrimaryKeyTypeAllowlistRule{
- BaseRule: BaseRule{level: level, title: string(checkCtx.Rule.Type)},
+ BaseRule: BaseRule{level: level, title: checkCtx.Rule.Type.String()},
allowlist: payload.List,
}
diff --git a/backend/plugin/advisor/pg/advisor_index_total_number_limit.go b/backend/plugin/advisor/pg/advisor_index_total_number_limit.go
index 65953251ff..67b1f8f8f9 100644
--- a/backend/plugin/advisor/pg/advisor_index_total_number_limit.go
+++ b/backend/plugin/advisor/pg/advisor_index_total_number_limit.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleIndexTotalNumberLimit, &IndexTotalNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT, &IndexTotalNumberLimitAdvisor{})
}
// IndexTotalNumberLimitAdvisor is the advisor checking for index total number limit.
@@ -45,7 +45,7 @@ func (*IndexTotalNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.C
}
rule := &indexTotalNumberLimitRule{
- BaseRule: BaseRule{level: level, title: string(checkCtx.Rule.Type)},
+ BaseRule: BaseRule{level: level, title: checkCtx.Rule.Type.String()},
max: payload.Number,
finalMetadata: checkCtx.FinalMetadata,
tableLine: make(tableLineMap),
diff --git a/backend/plugin/advisor/pg/advisor_insert_disallow_order_by_rand.go b/backend/plugin/advisor/pg/advisor_insert_disallow_order_by_rand.go
index fa9fb0184a..94a6cb2905 100644
--- a/backend/plugin/advisor/pg/advisor_insert_disallow_order_by_rand.go
+++ b/backend/plugin/advisor/pg/advisor_insert_disallow_order_by_rand.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementInsertDisallowOrderByRand, &InsertDisallowOrderByRandAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, &InsertDisallowOrderByRandAdvisor{})
}
// InsertDisallowOrderByRandAdvisor is the advisor checking for to disallow order by rand in INSERT statements.
@@ -41,7 +41,7 @@ func (*InsertDisallowOrderByRandAdvisor) Check(_ context.Context, checkCtx advis
rule := &insertDisallowOrderByRandRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_insert_must_specify_column.go b/backend/plugin/advisor/pg/advisor_insert_must_specify_column.go
index 0268b98c36..8a7cd41d88 100644
--- a/backend/plugin/advisor/pg/advisor_insert_must_specify_column.go
+++ b/backend/plugin/advisor/pg/advisor_insert_must_specify_column.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementInsertMustSpecifyColumn, &InsertMustSpecifyColumnAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, &InsertMustSpecifyColumnAdvisor{})
}
// InsertMustSpecifyColumnAdvisor is the advisor checking for to enforce column specified.
@@ -40,7 +40,7 @@ func (*InsertMustSpecifyColumnAdvisor) Check(_ context.Context, checkCtx advisor
rule := &insertMustSpecifyColumnRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_insert_row_limit.go b/backend/plugin/advisor/pg/advisor_insert_row_limit.go
index bf8659ca16..fb9cc767d1 100644
--- a/backend/plugin/advisor/pg/advisor_insert_row_limit.go
+++ b/backend/plugin/advisor/pg/advisor_insert_row_limit.go
@@ -23,7 +23,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementInsertRowLimit, &InsertRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, &InsertRowLimitAdvisor{})
}
// InsertRowLimitAdvisor is the advisor checking for to limit INSERT rows.
@@ -49,7 +49,7 @@ func (*InsertRowLimitAdvisor) Check(ctx context.Context, checkCtx advisor.Contex
rule := &insertRowLimitRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
maxRow: payload.Number,
driver: checkCtx.Driver,
diff --git a/backend/plugin/advisor/pg/advisor_migration_compatibility.go b/backend/plugin/advisor/pg/advisor_migration_compatibility.go
index 9eca0c0fe4..96a45a3a30 100644
--- a/backend/plugin/advisor/pg/advisor_migration_compatibility.go
+++ b/backend/plugin/advisor/pg/advisor_migration_compatibility.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleSchemaBackwardCompatibility, &CompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &CompatibilityAdvisor{})
}
// CompatibilityAdvisor is the advisor checking for schema backward compatibility.
@@ -40,7 +40,7 @@ func (*CompatibilityAdvisor) Check(_ context.Context, checkCtx advisor.Context)
rule := &compatibilityRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_naming_column.go b/backend/plugin/advisor/pg/advisor_naming_column.go
index 8607c2414c..fd793c3926 100644
--- a/backend/plugin/advisor/pg/advisor_naming_column.go
+++ b/backend/plugin/advisor/pg/advisor_naming_column.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleColumnNaming, &NamingColumnConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_COLUMN, &NamingColumnConventionAdvisor{})
}
// NamingColumnConventionAdvisor is the advisor checking for column naming convention.
@@ -47,7 +47,7 @@ func (*NamingColumnConventionAdvisor) Check(_ context.Context, checkCtx advisor.
rule := &namingColumnConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
maxLength: maxLength,
diff --git a/backend/plugin/advisor/pg/advisor_naming_foreign_key_convention.go b/backend/plugin/advisor/pg/advisor_naming_foreign_key_convention.go
index da0f40cfc8..a06804c79a 100644
--- a/backend/plugin/advisor/pg/advisor_naming_foreign_key_convention.go
+++ b/backend/plugin/advisor/pg/advisor_naming_foreign_key_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleFKNaming, &NamingFKConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_INDEX_FK, &NamingFKConventionAdvisor{})
}
// NamingFKConventionAdvisor is the advisor checking for foreign key naming convention.
@@ -40,7 +40,7 @@ func (*NamingFKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
@@ -48,7 +48,7 @@ func (*NamingFKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
rule := &namingFKConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
maxLength: maxLength,
diff --git a/backend/plugin/advisor/pg/advisor_naming_fully_qualified.go b/backend/plugin/advisor/pg/advisor_naming_fully_qualified.go
index 6a8d94392a..080a1afcb6 100644
--- a/backend/plugin/advisor/pg/advisor_naming_fully_qualified.go
+++ b/backend/plugin/advisor/pg/advisor_naming_fully_qualified.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleFullyQualifiedObjectName, &FullyQualifiedObjectNameAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_FULLY_QUALIFIED, &FullyQualifiedObjectNameAdvisor{})
}
// FullyQualifiedObjectNameAdvisor is the advisor checking for fully qualified object names.
@@ -43,7 +43,7 @@ func (*FullyQualifiedObjectNameAdvisor) Check(_ context.Context, checkCtx adviso
rule := &fullyQualifiedObjectNameRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
dbMetadata: checkCtx.DBSchema,
statementsText: checkCtx.Statements,
diff --git a/backend/plugin/advisor/pg/advisor_naming_index_convention.go b/backend/plugin/advisor/pg/advisor_naming_index_convention.go
index 9108d17626..02b27928e6 100644
--- a/backend/plugin/advisor/pg/advisor_naming_index_convention.go
+++ b/backend/plugin/advisor/pg/advisor_naming_index_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleIDXNaming, &NamingIndexConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_INDEX_IDX, &NamingIndexConventionAdvisor{})
}
// NamingIndexConventionAdvisor is the advisor checking for index naming convention.
@@ -40,7 +40,7 @@ func (*NamingIndexConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
@@ -48,7 +48,7 @@ func (*NamingIndexConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
rule := &namingIndexConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
maxLength: maxLength,
diff --git a/backend/plugin/advisor/pg/advisor_naming_primary_key_convention.go b/backend/plugin/advisor/pg/advisor_naming_primary_key_convention.go
index ffb52d3b5e..329b2eba9a 100644
--- a/backend/plugin/advisor/pg/advisor_naming_primary_key_convention.go
+++ b/backend/plugin/advisor/pg/advisor_naming_primary_key_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRulePKNaming, &NamingPKConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_INDEX_PK, &NamingPKConventionAdvisor{})
}
// NamingPKConventionAdvisor is the advisor checking for primary key naming convention.
@@ -40,7 +40,7 @@ func (*NamingPKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
@@ -48,7 +48,7 @@ func (*NamingPKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
rule := &namingPKConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
maxLength: maxLength,
diff --git a/backend/plugin/advisor/pg/advisor_naming_table.go b/backend/plugin/advisor/pg/advisor_naming_table.go
index c548cf6bda..ee6215097f 100644
--- a/backend/plugin/advisor/pg/advisor_naming_table.go
+++ b/backend/plugin/advisor/pg/advisor_naming_table.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleTableNaming, &NamingTableConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableConventionAdvisor{})
}
// NamingTableConventionAdvisor is the advisor checking for table naming convention.
@@ -47,7 +47,7 @@ func (*NamingTableConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
rule := &namingTableConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
maxLength: maxLength,
@@ -72,7 +72,7 @@ type namingTableConventionRule struct {
}
func (*namingTableConventionRule) Name() string {
- return string(advisor.SchemaRuleTableNaming)
+ return string(storepb.SQLReviewRule_NAMING_TABLE)
}
func (r *namingTableConventionRule) OnEnter(ctx antlr.ParserRuleContext, nodeType string) error {
diff --git a/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go b/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go
index 5e60153f48..1c2e8630b5 100644
--- a/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go
+++ b/backend/plugin/advisor/pg/advisor_naming_unique_key_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleUKNaming, &NamingUKConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_NAMING_INDEX_UK, &NamingUKConventionAdvisor{})
}
// NamingUKConventionAdvisor is the advisor checking for unique key naming convention.
@@ -40,7 +40,7 @@ func (*NamingUKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
@@ -48,7 +48,7 @@ func (*NamingUKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
rule := &namingUKConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
maxLength: maxLength,
diff --git a/backend/plugin/advisor/pg/advisor_statement_add_check_not_valid.go b/backend/plugin/advisor/pg/advisor_statement_add_check_not_valid.go
index 732f413a6d..4dcaa56c18 100644
--- a/backend/plugin/advisor/pg/advisor_statement_add_check_not_valid.go
+++ b/backend/plugin/advisor/pg/advisor_statement_add_check_not_valid.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementAddCheckNotValid, &StatementAddCheckNotValidAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID, &StatementAddCheckNotValidAdvisor{})
}
// StatementAddCheckNotValidAdvisor is the advisor checking for to add check not valid.
@@ -39,7 +39,7 @@ func (*StatementAddCheckNotValidAdvisor) Check(_ context.Context, checkCtx advis
rule := &statementAddCheckNotValidRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_add_fk_not_valid.go b/backend/plugin/advisor/pg/advisor_statement_add_fk_not_valid.go
index c906d1151c..ba3814a640 100644
--- a/backend/plugin/advisor/pg/advisor_statement_add_fk_not_valid.go
+++ b/backend/plugin/advisor/pg/advisor_statement_add_fk_not_valid.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementAddFKNotValid, &StatementAddFKNotValidAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID, &StatementAddFKNotValidAdvisor{})
}
// StatementAddFKNotValidAdvisor is the advisor checking for adding foreign key constraints without NOT VALID.
@@ -39,7 +39,7 @@ func (*StatementAddFKNotValidAdvisor) Check(_ context.Context, checkCtx advisor.
rule := &statementAddFKNotValidRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_affected_row_limit.go b/backend/plugin/advisor/pg/advisor_statement_affected_row_limit.go
index d6b3d69a54..00ce4a488c 100644
--- a/backend/plugin/advisor/pg/advisor_statement_affected_row_limit.go
+++ b/backend/plugin/advisor/pg/advisor_statement_affected_row_limit.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementAffectedRowLimit, &StatementAffectedRowLimitAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT, &StatementAffectedRowLimitAdvisor{})
}
// StatementAffectedRowLimitAdvisor is the advisor checking for UPDATE/DELETE affected row limit.
@@ -47,7 +47,7 @@ func (*StatementAffectedRowLimitAdvisor) Check(ctx context.Context, checkCtx adv
rule := &statementAffectedRowLimitRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
maxRow: payload.Number,
ctx: ctx,
diff --git a/backend/plugin/advisor/pg/advisor_statement_check_set_role_variable.go b/backend/plugin/advisor/pg/advisor_statement_check_set_role_variable.go
index bf0cc61eaa..9e2308177c 100644
--- a/backend/plugin/advisor/pg/advisor_statement_check_set_role_variable.go
+++ b/backend/plugin/advisor/pg/advisor_statement_check_set_role_variable.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementCheckSetRoleVariable, &StatementCheckSetRoleVariable{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE, &StatementCheckSetRoleVariable{})
}
type StatementCheckSetRoleVariable struct {
@@ -37,7 +37,7 @@ func (*StatementCheckSetRoleVariable) Check(_ context.Context, checkCtx advisor.
rule := &StatementCheckSetRoleVariableRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_create_specify_schema.go b/backend/plugin/advisor/pg/advisor_statement_create_specify_schema.go
index c09a362e83..083b157f3c 100644
--- a/backend/plugin/advisor/pg/advisor_statement_create_specify_schema.go
+++ b/backend/plugin/advisor/pg/advisor_statement_create_specify_schema.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementCreateSpecifySchema, &StatementCreateSpecifySchema{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA, &StatementCreateSpecifySchema{})
}
type StatementCreateSpecifySchema struct {
@@ -37,7 +37,7 @@ func (*StatementCreateSpecifySchema) Check(_ context.Context, checkCtx advisor.C
rule := &statementCreateSpecifySchemaRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_disallow_add_column_with_default.go b/backend/plugin/advisor/pg/advisor_statement_disallow_add_column_with_default.go
index 4a67f53211..2bb68955ae 100644
--- a/backend/plugin/advisor/pg/advisor_statement_disallow_add_column_with_default.go
+++ b/backend/plugin/advisor/pg/advisor_statement_disallow_add_column_with_default.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementDisallowAddColumnWithDefault, &StatementDisallowAddColumnWithDefaultAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT, &StatementDisallowAddColumnWithDefaultAdvisor{})
}
// StatementDisallowAddColumnWithDefaultAdvisor is the advisor checking for to disallow add column with default.
@@ -39,7 +39,7 @@ func (*StatementDisallowAddColumnWithDefaultAdvisor) Check(_ context.Context, ch
rule := &statementDisallowAddColumnWithDefaultRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_disallow_add_not_null.go b/backend/plugin/advisor/pg/advisor_statement_disallow_add_not_null.go
index 5c5e162cda..eed2b53adc 100644
--- a/backend/plugin/advisor/pg/advisor_statement_disallow_add_not_null.go
+++ b/backend/plugin/advisor/pg/advisor_statement_disallow_add_not_null.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementDisallowAddNotNull, &StatementDisallowAddNotNullAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL, &StatementDisallowAddNotNullAdvisor{})
}
// StatementDisallowAddNotNullAdvisor is the advisor checking for to disallow add not null.
@@ -41,7 +41,7 @@ func (*StatementDisallowAddNotNullAdvisor) Check(_ context.Context, checkCtx adv
rule := &statementDisallowAddNotNullRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_disallow_commit.go b/backend/plugin/advisor/pg/advisor_statement_disallow_commit.go
index 29385b8419..c067f327d4 100644
--- a/backend/plugin/advisor/pg/advisor_statement_disallow_commit.go
+++ b/backend/plugin/advisor/pg/advisor_statement_disallow_commit.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementDisallowCommit, &StatementDisallowCommitAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT, &StatementDisallowCommitAdvisor{})
}
// StatementDisallowCommitAdvisor is the advisor checking for disallowing COMMIT statements.
@@ -38,7 +38,7 @@ func (*StatementDisallowCommitAdvisor) Check(_ context.Context, checkCtx advisor
}
rule := &statementDisallowCommitRule{
- BaseRule: BaseRule{level: level, title: string(checkCtx.Rule.Type)},
+ BaseRule: BaseRule{level: level, title: checkCtx.Rule.Type.String()},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_disallow_on_del_cascade.go b/backend/plugin/advisor/pg/advisor_statement_disallow_on_del_cascade.go
index b85276c444..c4ba590882 100644
--- a/backend/plugin/advisor/pg/advisor_statement_disallow_on_del_cascade.go
+++ b/backend/plugin/advisor/pg/advisor_statement_disallow_on_del_cascade.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementDisallowOnDelCascade, &StatementDisallowOnDelCascadeAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_DISALLOW_ON_DEL_CASCADE, &StatementDisallowOnDelCascadeAdvisor{})
}
// StatementDisallowOnDelCascadeAdvisor is the advisor checking for ON DELETE CASCADE.
@@ -40,7 +40,7 @@ func (*StatementDisallowOnDelCascadeAdvisor) Check(_ context.Context, checkCtx a
rule := &statementDisallowOnDelCascadeRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_disallow_rm_tbl_cascade.go b/backend/plugin/advisor/pg/advisor_statement_disallow_rm_tbl_cascade.go
index 2aa679de97..69f4591b20 100644
--- a/backend/plugin/advisor/pg/advisor_statement_disallow_rm_tbl_cascade.go
+++ b/backend/plugin/advisor/pg/advisor_statement_disallow_rm_tbl_cascade.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementDisallowRemoveTblCascade, &StatementDisallowRemoveTblCascadeAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_DISALLOW_RM_TBL_CASCADE, &StatementDisallowRemoveTblCascadeAdvisor{})
}
// StatementDisallowRemoveTblCascadeAdvisor is the advisor checking for disallow CASCADE option when removing tables.
@@ -39,7 +39,7 @@ func (*StatementDisallowRemoveTblCascadeAdvisor) Check(_ context.Context, checkC
rule := &statementDisallowRemoveTblCascadeRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_dml_dry_run.go b/backend/plugin/advisor/pg/advisor_statement_dml_dry_run.go
index d79416ab43..841af4a2af 100644
--- a/backend/plugin/advisor/pg/advisor_statement_dml_dry_run.go
+++ b/backend/plugin/advisor/pg/advisor_statement_dml_dry_run.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementDMLDryRun, &StatementDMLDryRunAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, &StatementDMLDryRunAdvisor{})
}
// StatementDMLDryRunAdvisor is the advisor checking for DML dry run.
@@ -41,7 +41,7 @@ func (*StatementDMLDryRunAdvisor) Check(ctx context.Context, checkCtx advisor.Co
rule := &statementDMLDryRunRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
ctx: ctx,
driver: checkCtx.Driver,
diff --git a/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.go b/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.go
index 888c658e53..5adaa6d44c 100644
--- a/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.go
+++ b/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementMaximumLimitValue, &StatementMaximumLimitValueAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})
}
// StatementMaximumLimitValueAdvisor is the advisor checking for maximum LIMIT value.
@@ -45,7 +45,7 @@ func (*StatementMaximumLimitValueAdvisor) Check(_ context.Context, checkCtx advi
rule := &statementMaximumLimitValueRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
limitMaxValue: payload.Number,
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_merge_alter_table.go b/backend/plugin/advisor/pg/advisor_statement_merge_alter_table.go
index 7a3b9a4705..bf8730291b 100644
--- a/backend/plugin/advisor/pg/advisor_statement_merge_alter_table.go
+++ b/backend/plugin/advisor/pg/advisor_statement_merge_alter_table.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementMergeAlterTable, &StatementMergeAlterTableAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE, &StatementMergeAlterTableAdvisor{})
}
// StatementMergeAlterTableAdvisor is the advisor checking for no redundant ALTER TABLE statements.
@@ -40,7 +40,7 @@ func (*StatementMergeAlterTableAdvisor) Check(_ context.Context, checkCtx adviso
rule := &statementMergeAlterTableRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
tableMap: make(tableMap),
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_no_leading_wildcard_like.go b/backend/plugin/advisor/pg/advisor_statement_no_leading_wildcard_like.go
index 065df43a34..c7e3001b33 100644
--- a/backend/plugin/advisor/pg/advisor_statement_no_leading_wildcard_like.go
+++ b/backend/plugin/advisor/pg/advisor_statement_no_leading_wildcard_like.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementNoLeadingWildcardLike, &StatementNoLeadingWildcardLikeAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, &StatementNoLeadingWildcardLikeAdvisor{})
}
// StatementNoLeadingWildcardLikeAdvisor is the advisor checking for no leading wildcard LIKE.
@@ -40,7 +40,7 @@ func (*StatementNoLeadingWildcardLikeAdvisor) Check(_ context.Context, checkCtx
rule := &statementNoLeadingWildcardLikeRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
reportedStatements: make(map[antlr.ParserRuleContext]bool),
diff --git a/backend/plugin/advisor/pg/advisor_statement_no_select_all.go b/backend/plugin/advisor/pg/advisor_statement_no_select_all.go
index 0d2f2494df..66b83a9b0d 100644
--- a/backend/plugin/advisor/pg/advisor_statement_no_select_all.go
+++ b/backend/plugin/advisor/pg/advisor_statement_no_select_all.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementNoSelectAll, &NoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &NoSelectAllAdvisor{})
}
// NoSelectAllAdvisor is the advisor checking for no "select *".
@@ -40,7 +40,7 @@ func (*NoSelectAllAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
rule := &noSelectAllRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_non_transactional.go b/backend/plugin/advisor/pg/advisor_statement_non_transactional.go
index 36238365ca..ff5e146f21 100644
--- a/backend/plugin/advisor/pg/advisor_statement_non_transactional.go
+++ b/backend/plugin/advisor/pg/advisor_statement_non_transactional.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementNonTransactional, &NonTransactionalAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_NON_TRANSACTIONAL, &NonTransactionalAdvisor{})
}
// NonTransactionalAdvisor is the advisor checking for non-transactional statements.
@@ -40,7 +40,7 @@ func (*NonTransactionalAdvisor) Check(_ context.Context, checkCtx advisor.Contex
rule := &nonTransactionalRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_object_owner_check.go b/backend/plugin/advisor/pg/advisor_statement_object_owner_check.go
index 2bc0f2b479..709bc3c02e 100644
--- a/backend/plugin/advisor/pg/advisor_statement_object_owner_check.go
+++ b/backend/plugin/advisor/pg/advisor_statement_object_owner_check.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementObjectOwnerCheck, &StatementObjectOwnerCheckAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_OBJECT_OWNER_CHECK, &StatementObjectOwnerCheckAdvisor{})
}
const (
@@ -56,7 +56,7 @@ func (*StatementObjectOwnerCheckAdvisor) Check(ctx context.Context, checkCtx adv
rule := &statementObjectOwnerCheckRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
dbMetadata: dbMetadata,
currentRole: currentRole,
diff --git a/backend/plugin/advisor/pg/advisor_statement_where_required_select.go b/backend/plugin/advisor/pg/advisor_statement_where_required_select.go
index 4af600d1f5..3f0963b947 100644
--- a/backend/plugin/advisor/pg/advisor_statement_where_required_select.go
+++ b/backend/plugin/advisor/pg/advisor_statement_where_required_select.go
@@ -17,7 +17,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementRequireWhereForSelect, &StatementWhereRequiredSelectAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &StatementWhereRequiredSelectAdvisor{})
}
// StatementWhereRequiredSelectAdvisor is the advisor checking for WHERE clause requirement in SELECT statements.
@@ -39,7 +39,7 @@ func (*StatementWhereRequiredSelectAdvisor) Check(_ context.Context, checkCtx ad
rule := &statementWhereRequiredSelectRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_statement_where_required_update_delete.go b/backend/plugin/advisor/pg/advisor_statement_where_required_update_delete.go
index 4349a4d08f..dbdb19a439 100644
--- a/backend/plugin/advisor/pg/advisor_statement_where_required_update_delete.go
+++ b/backend/plugin/advisor/pg/advisor_statement_where_required_update_delete.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &StatementWhereRequiredUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &StatementWhereRequiredUpdateDeleteAdvisor{})
}
// StatementWhereRequiredUpdateDeleteAdvisor is the advisor checking for WHERE clause requirement in UPDATE/DELETE.
@@ -40,7 +40,7 @@ func (*StatementWhereRequiredUpdateDeleteAdvisor) Check(_ context.Context, check
rule := &statementWhereRequiredRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_table_comment_convention.go b/backend/plugin/advisor/pg/advisor_table_comment_convention.go
index 0131b06a1a..d1b304d73d 100644
--- a/backend/plugin/advisor/pg/advisor_table_comment_convention.go
+++ b/backend/plugin/advisor/pg/advisor_table_comment_convention.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleTableCommentConvention, &TableCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_TABLE_COMMENT, &TableCommentConventionAdvisor{})
}
// TableCommentConventionAdvisor is the advisor checking for table comment convention.
@@ -45,7 +45,7 @@ func (*TableCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor.
rule := &tableCommentConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
payload: payload,
statementsText: checkCtx.Statements,
diff --git a/backend/plugin/advisor/pg/advisor_table_disallow_partition.go b/backend/plugin/advisor/pg/advisor_table_disallow_partition.go
index 7c1a790693..cc4a195bbd 100644
--- a/backend/plugin/advisor/pg/advisor_table_disallow_partition.go
+++ b/backend/plugin/advisor/pg/advisor_table_disallow_partition.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleTableDisallowPartition, &TableDisallowPartitionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION, &TableDisallowPartitionAdvisor{})
}
// TableDisallowPartitionAdvisor is the advisor checking for partitioned tables.
@@ -41,7 +41,7 @@ func (*TableDisallowPartitionAdvisor) Check(_ context.Context, checkCtx advisor.
rule := &tableDisallowPartitionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_table_drop_naming_convention.go b/backend/plugin/advisor/pg/advisor_table_drop_naming_convention.go
index 836c084443..1801ccce8a 100644
--- a/backend/plugin/advisor/pg/advisor_table_drop_naming_convention.go
+++ b/backend/plugin/advisor/pg/advisor_table_drop_naming_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
}
// TableDropNamingConventionAdvisor is the advisor checking for table drop with naming convention.
@@ -48,7 +48,7 @@ func (*TableDropNamingConventionAdvisor) Check(_ context.Context, checkCtx advis
rule := &tableDropNamingConventionRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
format: format,
}
diff --git a/backend/plugin/advisor/pg/advisor_table_no_fk.go b/backend/plugin/advisor/pg/advisor_table_no_fk.go
index f673f879f0..ad76a10ead 100644
--- a/backend/plugin/advisor/pg/advisor_table_no_fk.go
+++ b/backend/plugin/advisor/pg/advisor_table_no_fk.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleTableNoFK, &TableNoFKAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoFKAdvisor{})
}
// TableNoFKAdvisor is the advisor checking table disallow foreign key.
@@ -41,7 +41,7 @@ func (*TableNoFKAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*
rule := &tableNoFKRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
}
diff --git a/backend/plugin/advisor/pg/advisor_table_require_pk.go b/backend/plugin/advisor/pg/advisor_table_require_pk.go
index d6086a8db3..8c3d43fea6 100644
--- a/backend/plugin/advisor/pg/advisor_table_require_pk.go
+++ b/backend/plugin/advisor/pg/advisor_table_require_pk.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_POSTGRES, advisor.SchemaRuleTableRequirePK, &TableRequirePKAdvisor{})
+ advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePKAdvisor{})
}
// TableRequirePKAdvisor is the advisor checking table requires PK.
@@ -42,7 +42,7 @@ func (*TableRequirePKAdvisor) Check(_ context.Context, checkCtx advisor.Context)
rule := &tableRequirePKRule{
BaseRule: BaseRule{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
},
statementsText: checkCtx.Statements,
finalMetadata: checkCtx.FinalMetadata,
diff --git a/backend/plugin/advisor/pg/pg_rules_test.go b/backend/plugin/advisor/pg/pg_rules_test.go
new file mode 100644
index 0000000000..6d93a16b2c
--- /dev/null
+++ b/backend/plugin/advisor/pg/pg_rules_test.go
@@ -0,0 +1,68 @@
+package pg
+
+import (
+ "testing"
+
+ storepb "github.com/bytebase/bytebase/backend/generated-go/store"
+)
+
+func TestPostgreSQLANTLRRules(t *testing.T) {
+ antlrRules := []storepb.SQLReviewRule_Type{
+ storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK,
+ storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST,
+ storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST,
+ storepb.SQLReviewRule_COLUMN_COMMENT,
+ storepb.SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE,
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,
+ storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
+ storepb.SQLReviewRule_SYSTEM_COMMENT_LENGTH,
+ storepb.SQLReviewRule_INDEX_CREATE_CONCURRENTLY,
+ storepb.SQLReviewRule_NAMING_INDEX_FK,
+ storepb.SQLReviewRule_NAMING_FULLY_QUALIFIED,
+ storepb.SQLReviewRule_NAMING_INDEX_IDX,
+ storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,
+ storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,
+ storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST,
+ storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,
+ storepb.SQLReviewRule_NAMING_INDEX_PK,
+ storepb.SQLReviewRule_COLUMN_REQUIRED,
+ storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,
+ storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,
+ storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT,
+ storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE,
+ storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ storepb.SQLReviewRule_STATEMENT_OBJECT_OWNER_CHECK,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ storepb.SQLReviewRule_NAMING_COLUMN,
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
+ storepb.SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID,
+ storepb.SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID,
+ storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT,
+ storepb.SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE,
+ storepb.SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ON_DEL_CASCADE,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_RM_TBL_CASCADE,
+ storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN,
+ storepb.SQLReviewRule_STATEMENT_NON_TRANSACTIONAL,
+ storepb.SQLReviewRule_TABLE_COMMENT,
+ storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION,
+ storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
+ storepb.SQLReviewRule_NAMING_TABLE,
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ storepb.SQLReviewRule_NAMING_INDEX_UK,
+ }
+
+ for _, rule := range antlrRules {
+ RunPGSQLReviewRuleTest(t, rule, storepb.Engine_POSTGRES, false /* record */)
+ }
+}
diff --git a/backend/plugin/advisor/pg/pgantlr_test.go b/backend/plugin/advisor/pg/pgantlr_test.go
deleted file mode 100644
index d175c19863..0000000000
--- a/backend/plugin/advisor/pg/pgantlr_test.go
+++ /dev/null
@@ -1,69 +0,0 @@
-package pg
-
-import (
- "testing"
-
- storepb "github.com/bytebase/bytebase/backend/generated-go/store"
- "github.com/bytebase/bytebase/backend/plugin/advisor"
-)
-
-func TestPostgreSQLANTLRRules(t *testing.T) {
- antlrRules := []advisor.SQLReviewRuleType{
- advisor.BuiltinRulePriorBackupCheck,
- advisor.SchemaRuleCharsetAllowlist,
- advisor.SchemaRuleCollationAllowlist,
- advisor.SchemaRuleColumnCommentConvention,
- advisor.SchemaRuleColumnDefaultDisallowVolatile,
- advisor.SchemaRuleColumnDisallowChangeType,
- advisor.SchemaRuleColumnMaximumCharacterLength,
- advisor.SchemaRuleColumnNotNull,
- advisor.SchemaRuleColumnRequireDefault,
- advisor.SchemaRuleColumnTypeDisallowList,
- advisor.SchemaRuleCommentLength,
- advisor.SchemaRuleCreateIndexConcurrently,
- advisor.SchemaRuleFKNaming,
- advisor.SchemaRuleFullyQualifiedObjectName,
- advisor.SchemaRuleIDXNaming,
- advisor.SchemaRuleIndexKeyNumberLimit,
- advisor.SchemaRuleIndexNoDuplicateColumn,
- advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist,
- advisor.SchemaRuleIndexTotalNumberLimit,
- advisor.SchemaRulePKNaming,
- advisor.SchemaRuleRequiredColumn,
- advisor.SchemaRuleStatementInsertDisallowOrderByRand,
- advisor.SchemaRuleStatementInsertMustSpecifyColumn,
- advisor.SchemaRuleStatementInsertRowLimit,
- advisor.SchemaRuleStatementMaximumLimitValue,
- advisor.SchemaRuleStatementMergeAlterTable,
- advisor.SchemaRuleStatementNoLeadingWildcardLike,
- advisor.SchemaRuleStatementNoSelectAll,
- advisor.SchemaRuleStatementObjectOwnerCheck,
- advisor.SchemaRuleStatementRequireWhereForSelect,
- advisor.SchemaRuleStatementRequireWhereForUpdateDelete,
- advisor.SchemaRuleColumnNaming,
- advisor.SchemaRuleSchemaBackwardCompatibility,
- advisor.SchemaRuleStatementAddCheckNotValid,
- advisor.SchemaRuleStatementAddFKNotValid,
- advisor.SchemaRuleStatementAffectedRowLimit,
- advisor.SchemaRuleStatementCheckSetRoleVariable,
- advisor.SchemaRuleStatementCreateSpecifySchema,
- advisor.SchemaRuleStatementDisallowAddColumnWithDefault,
- advisor.SchemaRuleStatementDisallowAddNotNull,
- advisor.SchemaRuleStatementDisallowCommit,
- advisor.SchemaRuleStatementDisallowOnDelCascade,
- advisor.SchemaRuleStatementDisallowRemoveTblCascade,
- advisor.SchemaRuleStatementDMLDryRun,
- advisor.SchemaRuleStatementNonTransactional,
- advisor.SchemaRuleTableCommentConvention,
- advisor.SchemaRuleTableDisallowPartition,
- advisor.SchemaRuleTableDropNamingConvention,
- advisor.SchemaRuleTableNaming,
- advisor.SchemaRuleTableNoFK,
- advisor.SchemaRuleTableRequirePK,
- advisor.SchemaRuleUKNaming,
- }
-
- for _, rule := range antlrRules {
- RunANTLRAdvisorRuleTest(t, rule, storepb.Engine_POSTGRES, false /* record */)
- }
-}
diff --git a/backend/plugin/advisor/pg/test/builtin_prior_backup_check.yaml b/backend/plugin/advisor/pg/test/builtin_prior_backup_check.yaml
index 6927bf5a11..005fd6b619 100644
--- a/backend/plugin/advisor/pg/test/builtin_prior_backup_check.yaml
+++ b/backend/plugin/advisor/pg/test/builtin_prior_backup_check.yaml
@@ -33,7 +33,7 @@
want:
- status: 2
code: 2001
- title: builtin.prior-backup-check
+ title: BUILTIN_PRIOR_BACKUP_CHECK
content: Data change can only run DML, "CREATE TABLE t_test_backup(a int)" is not DML
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/column_comment.yaml b/backend/plugin/advisor/pg/test/column_comment.yaml
index d62bd0e41a..d18f9e0a8f 100644
--- a/backend/plugin/advisor/pg/test/column_comment.yaml
+++ b/backend/plugin/advisor/pg/test/column_comment.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Comment is required for column `t.a`
startposition:
line: 1
@@ -20,7 +20,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t.a` comment is too long. The length of comment should be within 10 characters
startposition:
line: 2
@@ -33,7 +33,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Comment is required for column `t.d`
startposition:
line: 1
@@ -47,7 +47,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Comment is required for column `t.a`
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/column_default_disallow_volatile.yaml b/backend/plugin/advisor/pg/test/column_default_disallow_volatile.yaml
index 85d842a879..3fa8967cd4 100644
--- a/backend/plugin/advisor/pg/test/column_default_disallow_volatile.yaml
+++ b/backend/plugin/advisor/pg/test/column_default_disallow_volatile.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 420
- title: column.default-disallow-volatile
+ title: COLUMN_DEFAULT_DISALLOW_VOLATILE
content: Column "tech_book"."b" in schema "public" has volatile DEFAULT
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/column_disallow_change_type.yaml b/backend/plugin/advisor/pg/test/column_disallow_change_type.yaml
index 4541a807e6..be5adb4f6d 100644
--- a/backend/plugin/advisor/pg/test/column_disallow_change_type.yaml
+++ b/backend/plugin/advisor/pg/test/column_disallow_change_type.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: The statement "ALTER TABLE tech_book ALTER COLUMN id SET DATA TYPE INTEGER" changes column type
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/column_maximum_character_length.yaml b/backend/plugin/advisor/pg/test/column_maximum_character_length.yaml
index d6eeec361b..12165714cd 100644
--- a/backend/plugin/advisor/pg/test/column_maximum_character_length.yaml
+++ b/backend/plugin/advisor/pg/test/column_maximum_character_length.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column "name" in table "t" is bigger than 20, please use VARCHAR instead
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column "name_2" in table "public"."tech_book" is bigger than 20, please use VARCHAR instead
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column "name" in table "tech_book" is bigger than 20, please use VARCHAR instead
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/column_no_null.yaml b/backend/plugin/advisor/pg/test/column_no_null.yaml
index 895f757eb0..7383a7040b 100644
--- a/backend/plugin/advisor/pg/test/column_no_null.yaml
+++ b/backend/plugin/advisor/pg/test/column_no_null.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "id" in "public"."book" cannot have NULL value
startposition:
line: 2
@@ -15,7 +15,7 @@
endposition: null
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "name" in "public"."book" cannot have NULL value
startposition:
line: 3
@@ -26,7 +26,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "name" in "public"."book" cannot have NULL value
startposition:
line: 1
@@ -37,7 +37,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "name" in "public"."book" cannot have NULL value
startposition:
line: 1
@@ -48,7 +48,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "name" in "public"."book" cannot have NULL value
startposition:
line: 1
@@ -61,7 +61,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "reader" in "public"."tech_book" cannot have NULL value
startposition:
line: 1
@@ -79,7 +79,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column "name" in "public"."tech_book" cannot have NULL value
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/column_require_default.yaml b/backend/plugin/advisor/pg/test/column_require_default.yaml
index 65691f6aba..ec9eac07bf 100644
--- a/backend/plugin/advisor/pg/test/column_require_default.yaml
+++ b/backend/plugin/advisor/pg/test/column_require_default.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "t"."a" in schema "public" doesn't have DEFAULT
startposition:
line: 2
@@ -16,7 +16,7 @@
endposition: null
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "t"."b" in schema "public" doesn't have DEFAULT
startposition:
line: 3
@@ -33,7 +33,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "t"."a" in schema "public" doesn't have DEFAULT
startposition:
line: 2
@@ -46,7 +46,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "tech_book"."a" in schema "public" doesn't have DEFAULT
startposition:
line: 1
@@ -54,7 +54,7 @@
endposition: null
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column "tech_book"."b" in schema "public" doesn't have DEFAULT
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/column_required.yaml b/backend/plugin/advisor/pg/test/column_required.yaml
index e0ed57553b..df338ace9d 100644
--- a/backend/plugin/advisor/pg/test/column_required.yaml
+++ b/backend/plugin/advisor/pg/test/column_required.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table "book" requires columns: created_ts, creator_id, updated_ts, updater_id'
startposition:
line: 1
@@ -24,7 +24,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table "tech_book" requires columns: creator_id'
startposition:
line: 2
@@ -37,7 +37,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table "tech_book" requires columns: creator_id'
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/column_type_disallow_list.yaml b/backend/plugin/advisor/pg/test/column_type_disallow_list.yaml
index c24eefb0e3..f52f17612f 100644
--- a/backend/plugin/advisor/pg/test/column_type_disallow_list.yaml
+++ b/backend/plugin/advisor/pg/test/column_type_disallow_list.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column "t"."b" is
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column "t"."a" is
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/index_create_concurrently.yaml b/backend/plugin/advisor/pg/test/index_create_concurrently.yaml
index 564d6485c9..81715b8708 100644
--- a/backend/plugin/advisor/pg/test/index_create_concurrently.yaml
+++ b/backend/plugin/advisor/pg/test/index_create_concurrently.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 814
- title: index.create-concurrently
+ title: INDEX_CREATE_CONCURRENTLY
content: Creating indexes will block writes on the table, unless use CONCURRENTLY
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/index_key_number_limit.yaml b/backend/plugin/advisor/pg/test/index_key_number_limit.yaml
index 7f413d596f..d057255a4c 100644
--- a/backend/plugin/advisor/pg/test/index_key_number_limit.yaml
+++ b/backend/plugin/advisor/pg/test/index_key_number_limit.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of keys of index "t_id_name" in table "t" should be not greater than 5
startposition:
line: 1
@@ -20,7 +20,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of keys of index "t_id_name" in table "t" should be not greater than 5
startposition:
line: 1
@@ -33,7 +33,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of keys of index "idx_address_phone" in table "address" should be not greater than 5
startposition:
line: 2
@@ -46,7 +46,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of keys of index "idx_address_phone" in table "address" should be not greater than 5
startposition:
line: 2
@@ -59,7 +59,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of keys of index "address_id_name" in table "address" should be not greater than 5
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/index_no_duplicate_column.yaml b/backend/plugin/advisor/pg/test/index_no_duplicate_column.yaml
index f64dbd808b..2bd372c62b 100644
--- a/backend/plugin/advisor/pg/test/index_no_duplicate_column.yaml
+++ b/backend/plugin/advisor/pg/test/index_no_duplicate_column.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: PRIMARY KEY "" has duplicate column "t"."a"
startposition:
line: 3
@@ -21,7 +21,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX "idx_a" has duplicate column "t"."a"
startposition:
line: 2
@@ -34,7 +34,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: UNIQUE KEY "uk_a" has duplicate column "t"."a"
startposition:
line: 2
@@ -47,7 +47,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: PRIMARY KEY "pk_a" has duplicate column "t"."a"
startposition:
line: 2
@@ -60,7 +60,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: FOREIGN KEY "fk_a" has duplicate column "t"."a"
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/index_primary_key_type_allowlist.yaml b/backend/plugin/advisor/pg/test/index_primary_key_type_allowlist.yaml
index 081fdbe689..847ed6fe46 100644
--- a/backend/plugin/advisor/pg/test/index_primary_key_type_allowlist.yaml
+++ b/backend/plugin/advisor/pg/test/index_primary_key_type_allowlist.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column "a" is one of the primary key, but its type "character varying(20)" is not in allowlist
startposition:
line: 2
@@ -25,7 +25,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column "a" is one of the primary key, but its type "character varying(20)" is not in allowlist
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/index_total_number_limit.yaml b/backend/plugin/advisor/pg/test/index_total_number_limit.yaml
index 0da89ace7c..2e997b9f3c 100644
--- a/backend/plugin/advisor/pg/test/index_total_number_limit.yaml
+++ b/backend/plugin/advisor/pg/test/index_total_number_limit.yaml
@@ -12,7 +12,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table "public"."tech_book" should be no more than 5, but found 8
startposition:
line: 5
@@ -29,7 +29,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table "public"."t" should be no more than 5, but found 6
startposition:
line: 6
@@ -49,7 +49,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table "public"."t" should be no more than 5, but found 6
startposition:
line: 9
diff --git a/backend/plugin/advisor/pg/test/naming_column.yaml b/backend/plugin/advisor/pg/test/naming_column.yaml
index 7e96c3fe6d..0deb1dd946 100644
--- a/backend/plugin/advisor/pg/test/naming_column.yaml
+++ b/backend/plugin/advisor/pg/test/naming_column.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '"book"."creatorId" mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -24,7 +24,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '"book"."creatorId" mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 3
@@ -37,7 +37,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '"book"."creatorId" mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
@@ -54,7 +54,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '"book"."creatorId" mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/naming_fully_qualified.yaml b/backend/plugin/advisor/pg/test/naming_fully_qualified.yaml
index f09ac6c1b3..1741312f0d 100644
--- a/backend/plugin/advisor/pg/test/naming_fully_qualified.yaml
+++ b/backend/plugin/advisor/pg/test/naming_fully_qualified.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''pokesv2'''
startposition:
line: 4
@@ -21,7 +21,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''seq'''
startposition:
line: 2
@@ -37,7 +37,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''pokesv1'''
startposition:
line: 4
@@ -52,7 +52,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''pokesv1'''
startposition:
line: 2
@@ -66,7 +66,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''pokesv1'''
startposition:
line: 2
@@ -82,7 +82,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''pokesv1'''
startposition:
line: 4
@@ -93,7 +93,7 @@
want:
- status: 2
code: 310
- title: naming.fully-qualified
+ title: NAMING_FULLY_QUALIFIED
content: 'unqualified object name: ''tech_book'''
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/naming_index_fk.yaml b/backend/plugin/advisor/pg/test/naming_index_fk.yaml
index 8ccacc5cb9..c75764ddab 100644
--- a/backend/plugin/advisor/pg/test/naming_index_fk.yaml
+++ b/backend/plugin/advisor/pg/test/naming_index_fk.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table "tech_book" mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found "fk_author_id"
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table "tech_book" mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found "wlwflloczhmazamdotbibvqrrzyhmvkslvyzpmlmxt"
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table "tech_book" mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found "fk_author_id"
startposition:
line: 1
@@ -42,7 +42,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table "book" mismatches the naming convention, expect "^$|^fk_book_author_id_author_id$" but found "fk_book_author_id"
startposition:
line: 1
@@ -60,7 +60,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table "book" mismatches the naming convention, expect "^$|^fk_book_author_id_author_id$" but found "fk_book_author_id"
startposition:
line: 4
diff --git a/backend/plugin/advisor/pg/test/naming_index_idx.yaml b/backend/plugin/advisor/pg/test/naming_index_idx.yaml
index 55040616e3..970d44d51e 100644
--- a/backend/plugin/advisor/pg/test/naming_index_idx.yaml
+++ b/backend/plugin/advisor/pg/test/naming_index_idx.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table "tech_book" mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found "tech_book_id_name"
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table "tech_book" mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found "wfdtqyetsyoovcvikjlyfukxyjxxxhifl"
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table "tech_book" mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found "idx_tech_book"
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/naming_index_pk.yaml b/backend/plugin/advisor/pg/test/naming_index_pk.yaml
index 204bd0b772..47166c5472 100644
--- a/backend/plugin/advisor/pg/test/naming_index_pk.yaml
+++ b/backend/plugin/advisor/pg/test/naming_index_pk.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 306
- title: naming.index.pk
+ title: NAMING_INDEX_PK
content: Primary key in table "tech_book" mismatches the naming convention, expect "^$|^pk_tech_book_id_name$" but found "tech_book_id_name"
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 306
- title: naming.index.pk
+ title: NAMING_INDEX_PK
content: Primary key in table "tech_book" mismatches the naming convention, expect "^$|^pk_tech_book_id_name$" but found "udmhjtnsaablcmjhqcznfiwtnevcehcvw"
startposition:
line: 2
@@ -41,7 +41,7 @@
want:
- status: 2
code: 306
- title: naming.index.pk
+ title: NAMING_INDEX_PK
content: Primary key in table "book" mismatches the naming convention, expect "^$|^pk_book_name$" but found "tech_book_name"
startposition:
line: 5
@@ -62,7 +62,7 @@
want:
- status: 2
code: 306
- title: naming.index.pk
+ title: NAMING_INDEX_PK
content: Primary key in table "tech_book" mismatches the naming convention, expect "^$|^pk_tech_book_id_name$" but found "pk_tech_book"
startposition:
line: 2
@@ -75,7 +75,7 @@
want:
- status: 2
code: 306
- title: naming.index.pk
+ title: NAMING_INDEX_PK
content: Primary key in table "tech_book" mismatches the naming convention, expect "^$|^pk_tech_book_id_name$" but found "pk_tech_book"
startposition:
line: 1
@@ -88,7 +88,7 @@
want:
- status: 2
code: 306
- title: naming.index.pk
+ title: NAMING_INDEX_PK
content: Primary key in table "tech_book" mismatches the naming convention, expect "^$|^pk_tech_book_id_name$" but found "pk_tech_book"
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/naming_index_uk.yaml b/backend/plugin/advisor/pg/test/naming_index_uk.yaml
index 247f5c6ac6..676f061816 100644
--- a/backend/plugin/advisor/pg/test/naming_index_uk.yaml
+++ b/backend/plugin/advisor/pg/test/naming_index_uk.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "tech_book" mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found "tech_book_id_name"
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "tech_book" mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found "dzfzqbhnkiiegdhvqjeqoevesfuwcmokrehxlapoqj"
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "tech_book" mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found "tech_book_id_name"
startposition:
line: 1
@@ -48,7 +48,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "book" mismatches the naming convention, expect "^$|^uk_book_name$" but found "book_name"
startposition:
line: 5
@@ -65,7 +65,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "tech_book" mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found "uk_tech_book"
startposition:
line: 1
@@ -78,7 +78,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "tech_book" mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found "uk_tech_book"
startposition:
line: 1
@@ -91,7 +91,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table "tech_book" mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found "uk_tech_book"
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/naming_table.yaml b/backend/plugin/advisor/pg/test/naming_table.yaml
index 05d68fb8ac..4c613f0566 100644
--- a/backend/plugin/advisor/pg/test/naming_table.yaml
+++ b/backend/plugin/advisor/pg/test/naming_table.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"techBook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"_techbook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -31,7 +31,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TechBook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -48,7 +48,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"_techbook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -56,7 +56,7 @@
endposition: null
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"TechBook" mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/schema_backward_compatibility.yaml b/backend/plugin/advisor/pg/test/schema_backward_compatibility.yaml
index 5634d89b14..2fa6d4a2db 100644
--- a/backend/plugin/advisor/pg/test/schema_backward_compatibility.yaml
+++ b/backend/plugin/advisor/pg/test/schema_backward_compatibility.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book ALTER COLUMN name TYPE TEXT" may cause incompatibility with the existing data and code'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_add_check_not_valid.yaml b/backend/plugin/advisor/pg/test/statement_add_check_not_valid.yaml
index db79c3a467..55db634479 100644
--- a/backend/plugin/advisor/pg/test/statement_add_check_not_valid.yaml
+++ b/backend/plugin/advisor/pg/test/statement_add_check_not_valid.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 211
- title: statement.add-check-not-valid
+ title: STATEMENT_ADD_CHECK_NOT_VALID
content: Adding check constraints with validation will block reads and writes. You can add check constraints not valid and then validate separately
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_add_foreign_key_not_valid.yaml b/backend/plugin/advisor/pg/test/statement_add_foreign_key_not_valid.yaml
index 9fe5e326c4..8bebfaf8de 100644
--- a/backend/plugin/advisor/pg/test/statement_add_foreign_key_not_valid.yaml
+++ b/backend/plugin/advisor/pg/test/statement_add_foreign_key_not_valid.yaml
@@ -15,7 +15,7 @@
want:
- status: 2
code: 229
- title: statement.add-foreign-key-not-valid
+ title: STATEMENT_ADD_FOREIGN_KEY_NOT_VALID
content: Adding foreign keys with validation will block reads and writes. You can add check foreign keys not valid and then validate separately
startposition:
line: 12
diff --git a/backend/plugin/advisor/pg/test/statement_check_set_role_variable.yaml b/backend/plugin/advisor/pg/test/statement_check_set_role_variable.yaml
index 0e76beb7a9..d8dadc3d87 100644
--- a/backend/plugin/advisor/pg/test/statement_check_set_role_variable.yaml
+++ b/backend/plugin/advisor/pg/test/statement_check_set_role_variable.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 217
- title: statement.check-set-role-variable
+ title: STATEMENT_CHECK_SET_ROLE_VARIABLE
content: No SET ROLE statement found.
startposition: null
endposition: null
diff --git a/backend/plugin/advisor/pg/test/statement_create_specify_schema.yaml b/backend/plugin/advisor/pg/test/statement_create_specify_schema.yaml
index 0e2c765b41..152098fe3b 100644
--- a/backend/plugin/advisor/pg/test/statement_create_specify_schema.yaml
+++ b/backend/plugin/advisor/pg/test/statement_create_specify_schema.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 216
- title: statement.create-specify-schema
+ title: STATEMENT_CREATE_SPECIFY_SCHEMA
content: Table schema should be specified.
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_disallow_add_column_with_default.yaml b/backend/plugin/advisor/pg/test/statement_disallow_add_column_with_default.yaml
index 758055fbf9..98f4f2022a 100644
--- a/backend/plugin/advisor/pg/test/statement_disallow_add_column_with_default.yaml
+++ b/backend/plugin/advisor/pg/test/statement_disallow_add_column_with_default.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 210
- title: statement.disallow-add-column-with-default
+ title: STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT
content: Adding column with DEFAULT will locked the whole table and rewriting each rows
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_disallow_add_not_null.yaml b/backend/plugin/advisor/pg/test/statement_disallow_add_not_null.yaml
index 516692b1c8..4af70576f8 100644
--- a/backend/plugin/advisor/pg/test/statement_disallow_add_not_null.yaml
+++ b/backend/plugin/advisor/pg/test/statement_disallow_add_not_null.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 212
- title: statement.disallow-add-not-null
+ title: STATEMENT_DISALLOW_ADD_NOT_NULL
content: Setting NOT NULL will block reads and writes. You can use CHECK ("name" IS NOT NULL) instead
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_disallow_commit.yaml b/backend/plugin/advisor/pg/test/statement_disallow_commit.yaml
index c8a201180f..5df5fa79d6 100644
--- a/backend/plugin/advisor/pg/test/statement_disallow_commit.yaml
+++ b/backend/plugin/advisor/pg/test/statement_disallow_commit.yaml
@@ -6,7 +6,7 @@
want:
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "CREATE TABLE techBook(id int, name varchar(255));"'
startposition:
line: 3
@@ -24,7 +24,7 @@
want:
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "CREATE TABLE techBook(id int, name varchar(255));"'
startposition:
line: 3
@@ -32,7 +32,7 @@
endposition: null
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "CREATE TABLE techBook(id int, name varchar(255));"'
startposition:
line: 7
diff --git a/backend/plugin/advisor/pg/test/statement_disallow_on_del_cascade.yaml b/backend/plugin/advisor/pg/test/statement_disallow_on_del_cascade.yaml
index c857849dd3..9e9e5abf2a 100644
--- a/backend/plugin/advisor/pg/test/statement_disallow_on_del_cascade.yaml
+++ b/backend/plugin/advisor/pg/test/statement_disallow_on_del_cascade.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 213
- title: statement.disallow-on-del-cascade
+ title: STATEMENT_DISALLOW_ON_DEL_CASCADE
content: The CASCADE option is not permitted for ON DELETE clauses
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 213
- title: statement.disallow-on-del-cascade
+ title: STATEMENT_DISALLOW_ON_DEL_CASCADE
content: The CASCADE option is not permitted for ON DELETE clauses
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/statement_disallow_rm_tbl_cascade.yaml b/backend/plugin/advisor/pg/test/statement_disallow_rm_tbl_cascade.yaml
index 7c4bd65518..4dcf36042a 100644
--- a/backend/plugin/advisor/pg/test/statement_disallow_rm_tbl_cascade.yaml
+++ b/backend/plugin/advisor/pg/test/statement_disallow_rm_tbl_cascade.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 213
- title: statement.disallow-rm-tbl-cascade
+ title: STATEMENT_DISALLOW_RM_TBL_CASCADE
content: The use of CASCADE is not permitted when removing a table
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 213
- title: statement.disallow-rm-tbl-cascade
+ title: STATEMENT_DISALLOW_RM_TBL_CASCADE
content: The use of CASCADE is not permitted when removing a table
startposition:
line: 1
@@ -44,7 +44,7 @@
endposition: null
- status: 2
code: 213
- title: statement.disallow-rm-tbl-cascade
+ title: STATEMENT_DISALLOW_RM_TBL_CASCADE
content: The use of CASCADE is not permitted when removing a table
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/statement_insert_disallow_order_by_rand.yaml b/backend/plugin/advisor/pg/test/statement_insert_disallow_order_by_rand.yaml
index 1a68ee82e8..93e8c8cd4e 100644
--- a/backend/plugin/advisor/pg/test/statement_insert_disallow_order_by_rand.yaml
+++ b/backend/plugin/advisor/pg/test/statement_insert_disallow_order_by_rand.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1108
- title: statement.insert.disallow-order-by-rand
+ title: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
content: The INSERT statement uses ORDER BY random() or random_between(), related statement "INSERT INTO tech_book SELECT * FROM tech_book ORDER BY random()"
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_insert_must_specify_column.yaml b/backend/plugin/advisor/pg/test/statement_insert_must_specify_column.yaml
index b089a7fc59..945800b0c6 100644
--- a/backend/plugin/advisor/pg/test/statement_insert_must_specify_column.yaml
+++ b/backend/plugin/advisor/pg/test/statement_insert_must_specify_column.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1107
- title: statement.insert.must-specify-column
+ title: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
content: The INSERT statement must specify columns but "INSERT INTO tech_book VALUES (1, '1')" does not
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_insert_row_limit.yaml b/backend/plugin/advisor/pg/test/statement_insert_row_limit.yaml
index ff6a96ce06..a75f7d264f 100644
--- a/backend/plugin/advisor/pg/test/statement_insert_row_limit.yaml
+++ b/backend/plugin/advisor/pg/test/statement_insert_row_limit.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1101
- title: statement.insert.row-limit
+ title: STATEMENT_INSERT_ROW_LIMIT
content: The statement "INSERT INTO tech_book values(1, 'a'), (2, 'b'), (3, 'c'), (4, 'd'), (5, 'e'), (6, 'f')" inserts 6 rows. The count exceeds 5.
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yaml b/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yaml
index 3b0124f5ea..ec1bc9b686 100644
--- a/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yaml
+++ b/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yaml
@@ -4,7 +4,7 @@
want:
- status: 2
code: 222
- title: statement.maximum-limit-value
+ title: STATEMENT_MAXIMUM_LIMIT_VALUE
content: The limit value 1000000 exceeds the maximum allowed value 1000
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_merge_alter_table.yaml b/backend/plugin/advisor/pg/test/statement_merge_alter_table.yaml
index b3f7f4bef9..108cec1124 100644
--- a/backend/plugin/advisor/pg/test/statement_merge_alter_table.yaml
+++ b/backend/plugin/advisor/pg/test/statement_merge_alter_table.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `t`
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/statement_non_transactional.yaml b/backend/plugin/advisor/pg/test/statement_non_transactional.yaml
index 992f3c9fe3..d77744f4a5 100644
--- a/backend/plugin/advisor/pg/test/statement_non_transactional.yaml
+++ b/backend/plugin/advisor/pg/test/statement_non_transactional.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 230
- title: statement.non-transactional
+ title: STATEMENT_NON_TRANSACTIONAL
content: This statement is non-transactional
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 230
- title: statement.non-transactional
+ title: STATEMENT_NON_TRANSACTIONAL
content: This statement is non-transactional
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_select_no_select_all.yaml b/backend/plugin/advisor/pg/test/statement_select_no_select_all.yaml
index be1d9ece14..62ccc2c28a 100644
--- a/backend/plugin/advisor/pg/test/statement_select_no_select_all.yaml
+++ b/backend/plugin/advisor/pg/test/statement_select_no_select_all.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT * FROM t" uses SELECT all'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT a, b FROM (SELECT * from t1, t2) t" uses SELECT all'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"INSERT INTO t SELECT * FROM t1" uses SELECT all'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_where_no_leading_wildcard_like.yaml b/backend/plugin/advisor/pg/test/statement_where_no_leading_wildcard_like.yaml
index 1e2a33d904..6cb384930f 100644
--- a/backend/plugin/advisor/pg/test/statement_where_no_leading_wildcard_like.yaml
+++ b/backend/plugin/advisor/pg/test/statement_where_no_leading_wildcard_like.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''%abc''" uses leading wildcard LIKE'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''abc'' OR a LIKE ''%abc''" uses leading wildcard LIKE'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''%acc'' OR a LIKE ''%abc''" uses leading wildcard LIKE'
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM (SELECT * FROM t WHERE a LIKE ''%acc'' OR a LIKE ''%abc'') t1" uses leading wildcard LIKE'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_where_require_select.yaml b/backend/plugin/advisor/pg/test/statement_where_require_select.yaml
index 9d01185a66..86c6decb7a 100644
--- a/backend/plugin/advisor/pg/test/statement_where_require_select.yaml
+++ b/backend/plugin/advisor/pg/test/statement_where_require_select.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: '"SELECT a FROM t" requires WHERE clause'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: '"SELECT a FROM t WHERE a > (SELECT max(id) FROM user)" requires WHERE clause'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/statement_where_require_update_delete.yaml b/backend/plugin/advisor/pg/test/statement_where_require_update_delete.yaml
index 0feac1472f..bda70a0301 100644
--- a/backend/plugin/advisor/pg/test/statement_where_require_update_delete.yaml
+++ b/backend/plugin/advisor/pg/test/statement_where_require_update_delete.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: '"DELETE FROM t1" requires WHERE clause'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: '"UPDATE t1 SET a = 1" requires WHERE clause'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/system_charset_allowlist.yaml b/backend/plugin/advisor/pg/test/system_charset_allowlist.yaml
index a73f504104..f273a6a9fc 100644
--- a/backend/plugin/advisor/pg/test/system_charset_allowlist.yaml
+++ b/backend/plugin/advisor/pg/test/system_charset_allowlist.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"" used disabled encoding ''latin1'''
startposition:
line: 0
diff --git a/backend/plugin/advisor/pg/test/system_collation_allowlist.yaml b/backend/plugin/advisor/pg/test/system_collation_allowlist.yaml
index 7edae7f7c8..c4d38973a8 100644
--- a/backend/plugin/advisor/pg/test/system_collation_allowlist.yaml
+++ b/backend/plugin/advisor/pg/test/system_collation_allowlist.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: Use disabled collation "unknown", related statement "CREATE TABLE t(a text COLLATE "unknown")"
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: Use disabled collation "unknown", related statement "ALTER TABLE tech_book ADD COLUMN c1 text COLLATE "unknown""
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: Use disabled collation "unknown", related statement "ALTER TABLE tech_book ALTER COLUMN id TYPE text COLLATE "unknown""
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/system_comment_length.yaml b/backend/plugin/advisor/pg/test/system_comment_length.yaml
index 1718cdfdb7..724801332c 100644
--- a/backend/plugin/advisor/pg/test/system_comment_length.yaml
+++ b/backend/plugin/advisor/pg/test/system_comment_length.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1301
- title: system.comment.length
+ title: SYSTEM_COMMENT_LENGTH
content: The length of comment should be within 20 characters
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 1301
- title: system.comment.length
+ title: SYSTEM_COMMENT_LENGTH
content: The length of comment should be within 20 characters
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/table_comment.yaml b/backend/plugin/advisor/pg/test/table_comment.yaml
index f825e809d8..2a2bbfe1a1 100644
--- a/backend/plugin/advisor/pg/test/table_comment.yaml
+++ b/backend/plugin/advisor/pg/test/table_comment.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table `t`
startposition:
line: 1
@@ -21,7 +21,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table `d`
startposition:
line: 3
@@ -35,7 +35,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table `t`
startposition:
line: 2
@@ -49,7 +49,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Comment is required for table `t`
startposition:
line: 2
@@ -62,7 +62,7 @@
want:
- status: 2
code: 1301
- title: table.comment
+ title: TABLE_COMMENT
content: Table `t` comment is too long. The length of comment should be within 10 characters
startposition:
line: 2
diff --git a/backend/plugin/advisor/pg/test/table_disallow_partition.yaml b/backend/plugin/advisor/pg/test/table_disallow_partition.yaml
index fe50b1ebe2..c7f8e125c8 100644
--- a/backend/plugin/advisor/pg/test/table_disallow_partition.yaml
+++ b/backend/plugin/advisor/pg/test/table_disallow_partition.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: Table partition is forbidden, but "CREATE TABLE t(a int) PARTITION BY RANGE (a);" creates
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: Table partition is forbidden, but "ALTER TABLE tech_book ATTACH PARTITION p1 DEFAULT;" creates
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/table_drop_naming_convention.yaml b/backend/plugin/advisor/pg/test/table_drop_naming_convention.yaml
index 7dd7f76328..d6e4c98217 100644
--- a/backend/plugin/advisor/pg/test/table_drop_naming_convention.yaml
+++ b/backend/plugin/advisor/pg/test/table_drop_naming_convention.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '`foo` mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '`bar` mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/table_no_foreign_key.yaml b/backend/plugin/advisor/pg/test/table_no_foreign_key.yaml
index acf0effa26..bca9c59149 100644
--- a/backend/plugin/advisor/pg/test/table_no_foreign_key.yaml
+++ b/backend/plugin/advisor/pg/test/table_no_foreign_key.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: 'Foreign key is not allowed in the table "public"."tech_book", related statement: "ALTER TABLE tech_book ADD CONSTRAINT fk_tech_book_author_id_author_id FOREIGN KEY (author_id) REFERENCES author (id)"'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: 'Foreign key is not allowed in the table "public"."book", related statement: "CREATE TABLE book(id INT, author_id INT, CONSTRAINT fk_book_author_id_author_id FOREIGN KEY (author_id) REFERENCES author (id))"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/pg/test/table_require_pk.yaml b/backend/plugin/advisor/pg/test/table_require_pk.yaml
index 96ba12f5c6..5833d8f9ca 100644
--- a/backend/plugin/advisor/pg/test/table_require_pk.yaml
+++ b/backend/plugin/advisor/pg/test/table_require_pk.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: 'Table "public"."t" requires PRIMARY KEY, related statement: "CREATE TABLE t(id INT)"'
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: 'Table "public"."tech_book" requires PRIMARY KEY, related statement: "ALTER TABLE \"tech_book\" DROP CONSTRAINT \"old_pk\""'
startposition:
line: 1
@@ -33,7 +33,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: 'Table "public"."tech_book" requires PRIMARY KEY, related statement: "ALTER TABLE \"tech_book\" DROP COLUMN id"'
startposition:
line: 1
@@ -54,7 +54,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: 'Table "public"."book" requires PRIMARY KEY, related statement: "ALTER TABLE book DROP CONSTRAINT book_pkey;"'
startposition:
line: 2
@@ -68,7 +68,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: 'Table "public"."product" requires PRIMARY KEY, related statement: "ALTER TABLE product DROP CONSTRAINT product_pkey;"'
startposition:
line: 3
diff --git a/backend/plugin/advisor/pg/test_helper.go b/backend/plugin/advisor/pg/test_helper.go
index 61948e8d3e..e7f0d58805 100644
--- a/backend/plugin/advisor/pg/test_helper.go
+++ b/backend/plugin/advisor/pg/test_helper.go
@@ -30,9 +30,9 @@ type TestCase struct {
Want []*storepb.Advice `yaml:"want,omitempty"`
}
-// RunANTLRAdvisorRuleTest helps to test ANTLR-based SQL review rules.
-// This is similar to advisor.RunSQLReviewRuleTest but for ANTLR advisors.
-func RunANTLRAdvisorRuleTest(t *testing.T, rule advisor.SQLReviewRuleType, dbType storepb.Engine, record bool) {
+// RunPGSQLReviewRuleTest helps to test PostgreSQL SQL review rules.
+// This is similar to advisor.RunSQLReviewRuleTest.
+func RunPGSQLReviewRuleTest(t *testing.T, rule storepb.SQLReviewRule_Type, dbType storepb.Engine, record bool) {
var tests []TestCase
fileName := strings.Map(func(r rune) rune {
@@ -42,7 +42,7 @@ func RunANTLRAdvisorRuleTest(t *testing.T, rule advisor.SQLReviewRuleType, dbTyp
default:
return r
}
- }, string(rule))
+ }, strings.ToLower(rule.String()))
filepath := filepath.Join("test", fileName+".yaml")
yamlFile, err := os.Open(filepath)
require.NoError(t, err)
@@ -102,7 +102,7 @@ func RunANTLRAdvisorRuleTest(t *testing.T, rule advisor.SQLReviewRuleType, dbTyp
ruleList := []*storepb.SQLReviewRule{
{
- Type: string(rule),
+ Type: rule,
Level: storepb.SQLReviewRule_WARNING,
Payload: payload,
},
diff --git a/backend/plugin/advisor/redshift/advisor_table_drop_naming_convention.go b/backend/plugin/advisor/redshift/advisor_table_drop_naming_convention.go
index b1407f2fdb..23359e4c11 100644
--- a/backend/plugin/advisor/redshift/advisor_table_drop_naming_convention.go
+++ b/backend/plugin/advisor/redshift/advisor_table_drop_naming_convention.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_REDSHIFT, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_REDSHIFT, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
}
// TableDropNamingConventionAdvisor is the advisor checking for table drop with naming convention.
@@ -46,7 +46,7 @@ func (*TableDropNamingConventionAdvisor) Check(_ context.Context, checkCtx advis
listener := &tableDropNamingConventionListener{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
adviceList: []*storepb.Advice{},
}
diff --git a/backend/plugin/advisor/snowflake/rule_column_maximum_varchar_length.go b/backend/plugin/advisor/snowflake/rule_column_maximum_varchar_length.go
index 9c9744964d..59a6701e9e 100644
--- a/backend/plugin/advisor/snowflake/rule_column_maximum_varchar_length.go
+++ b/backend/plugin/advisor/snowflake/rule_column_maximum_varchar_length.go
@@ -26,7 +26,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleColumnMaximumVarcharLength, &ColumnMaximumVarcharLengthAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH, &ColumnMaximumVarcharLengthAdvisor{})
}
// ColumnMaximumVarcharLengthAdvisor is the advisor checking for maximum varchar length.
@@ -54,7 +54,7 @@ func (*ColumnMaximumVarcharLengthAdvisor) Check(_ context.Context, checkCtx advi
}
// Create the rule
- rule := NewColumnMaximumVarcharLengthRule(level, string(checkCtx.Rule.Type), payload.Number)
+ rule := NewColumnMaximumVarcharLengthRule(level, checkCtx.Rule.Type.String(), payload.Number)
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/snowflake/rule_column_no_null.go b/backend/plugin/advisor/snowflake/rule_column_no_null.go
index ab50183bfa..bd79da9229 100644
--- a/backend/plugin/advisor/snowflake/rule_column_no_null.go
+++ b/backend/plugin/advisor/snowflake/rule_column_no_null.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
}
// ColumnNoNullAdvisor is the advisor checking for column no NULL value.
@@ -39,7 +39,7 @@ func (*ColumnNoNullAdvisor) Check(_ context.Context, checkCtx advisor.Context) (
}
// Create the rule
- rule := NewColumnNoNullRule(level, string(checkCtx.Rule.Type))
+ rule := NewColumnNoNullRule(level, checkCtx.Rule.Type.String())
// Create the generic checker with the rule
checker := NewGenericChecker([]Rule{rule})
diff --git a/backend/plugin/advisor/snowflake/rule_column_require.go b/backend/plugin/advisor/snowflake/rule_column_require.go
index 58c3fb31d0..bad284c958 100644
--- a/backend/plugin/advisor/snowflake/rule_column_require.go
+++ b/backend/plugin/advisor/snowflake/rule_column_require.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleRequiredColumn, &ColumnRequireAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequireAdvisor{})
}
// ColumnRequireAdvisor is the advisor checking for column requirement.
@@ -50,7 +50,7 @@ func (*ColumnRequireAdvisor) Check(_ context.Context, checkCtx advisor.Context)
requireColumns[column] = true
}
- rule := NewColumnRequireRule(level, string(checkCtx.Rule.Type), requireColumns)
+ rule := NewColumnRequireRule(level, checkCtx.Rule.Type.String(), requireColumns)
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_migration_compatibility.go b/backend/plugin/advisor/snowflake/rule_migration_compatibility.go
index b510943d2c..eadace266f 100644
--- a/backend/plugin/advisor/snowflake/rule_migration_compatibility.go
+++ b/backend/plugin/advisor/snowflake/rule_migration_compatibility.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleSchemaBackwardCompatibility, &MigrationCompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &MigrationCompatibilityAdvisor{})
}
// MigrationCompatibilityAdvisor is the advisor checking for migration compatibility.
@@ -40,7 +40,7 @@ func (*MigrationCompatibilityAdvisor) Check(_ context.Context, checkCtx advisor.
return nil, err
}
- rule := NewMigrationCompatibilityRule(level, string(checkCtx.Rule.Type), checkCtx.CurrentDatabase)
+ rule := NewMigrationCompatibilityRule(level, checkCtx.Rule.Type.String(), checkCtx.CurrentDatabase)
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_naming_identifier_case.go b/backend/plugin/advisor/snowflake/rule_naming_identifier_case.go
index 12ea04c123..5a2fa3acad 100644
--- a/backend/plugin/advisor/snowflake/rule_naming_identifier_case.go
+++ b/backend/plugin/advisor/snowflake/rule_naming_identifier_case.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleIdentifierCase, &NamingIdentifierCaseAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE, &NamingIdentifierCaseAdvisor{})
}
// NamingIdentifierCaseAdvisor is the advisor checking for identifier case.
@@ -40,7 +40,7 @@ func (*NamingIdentifierCaseAdvisor) Check(_ context.Context, checkCtx advisor.Co
return nil, err
}
- rule := NewNamingIdentifierCaseRule(level, string(checkCtx.Rule.Type))
+ rule := NewNamingIdentifierCaseRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_naming_identifier_no_keyword.go b/backend/plugin/advisor/snowflake/rule_naming_identifier_no_keyword.go
index fd04fd1de5..c621657fb3 100644
--- a/backend/plugin/advisor/snowflake/rule_naming_identifier_no_keyword.go
+++ b/backend/plugin/advisor/snowflake/rule_naming_identifier_no_keyword.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleIdentifierNoKeyword, &NamingIdentifierNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD, &NamingIdentifierNoKeywordAdvisor{})
}
// NamingIdentifierNoKeywordAdvisor is the advisor checking for identifier naming convention without keyword.
@@ -40,7 +40,7 @@ func (*NamingIdentifierNoKeywordAdvisor) Check(_ context.Context, checkCtx advis
return nil, err
}
- rule := NewNamingIdentifierNoKeywordRule(level, string(checkCtx.Rule.Type))
+ rule := NewNamingIdentifierNoKeywordRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_naming_table.go b/backend/plugin/advisor/snowflake/rule_naming_table.go
index 6205b318c0..54428466b4 100644
--- a/backend/plugin/advisor/snowflake/rule_naming_table.go
+++ b/backend/plugin/advisor/snowflake/rule_naming_table.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleTableNaming, &NamingTableAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableAdvisor{})
}
// NamingTableAdvisor is the advisor checking for table naming convention.
@@ -45,7 +45,7 @@ func (*NamingTableAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
return nil, err
}
- rule := NewNamingTableRule(level, string(checkCtx.Rule.Type), format, maxLength)
+ rule := NewNamingTableRule(level, checkCtx.Rule.Type.String(), format, maxLength)
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_naming_table_no_keyword.go b/backend/plugin/advisor/snowflake/rule_naming_table_no_keyword.go
index 0088434aad..deba2d20b8 100644
--- a/backend/plugin/advisor/snowflake/rule_naming_table_no_keyword.go
+++ b/backend/plugin/advisor/snowflake/rule_naming_table_no_keyword.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleTableNameNoKeyword, &NamingTableNoKeywordAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD, &NamingTableNoKeywordAdvisor{})
}
// NamingTableNoKeywordAdvisor is the advisor checking for table naming convention without keyword.
@@ -39,7 +39,7 @@ func (*NamingTableNoKeywordAdvisor) Check(_ context.Context, checkCtx advisor.Co
return nil, err
}
- rule := NewNamingTableNoKeywordRule(level, string(checkCtx.Rule.Type))
+ rule := NewNamingTableNoKeywordRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_select_no_select_all.go b/backend/plugin/advisor/snowflake/rule_select_no_select_all.go
index b2598a9d00..7f02bca23a 100644
--- a/backend/plugin/advisor/snowflake/rule_select_no_select_all.go
+++ b/backend/plugin/advisor/snowflake/rule_select_no_select_all.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleStatementNoSelectAll, &SelectNoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &SelectNoSelectAllAdvisor{})
}
// SelectNoSelectAllAdvisor is the advisor checking for no select all.
@@ -37,7 +37,7 @@ func (*SelectNoSelectAllAdvisor) Check(_ context.Context, checkCtx advisor.Conte
return nil, err
}
- rule := NewSelectNoSelectAllRule(level, string(checkCtx.Rule.Type))
+ rule := NewSelectNoSelectAllRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_table_drop_naming_convention.go b/backend/plugin/advisor/snowflake/rule_table_drop_naming_convention.go
index 1f58b2780b..7e1e98b9a0 100644
--- a/backend/plugin/advisor/snowflake/rule_table_drop_naming_convention.go
+++ b/backend/plugin/advisor/snowflake/rule_table_drop_naming_convention.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
}
// TableDropNamingConventionAdvisor is the advisor checking for table drop with naming convention.
@@ -46,7 +46,7 @@ func (*TableDropNamingConventionAdvisor) Check(_ context.Context, checkCtx advis
return nil, err
}
- rule := NewTableDropNamingConventionRule(level, string(checkCtx.Rule.Type), format)
+ rule := NewTableDropNamingConventionRule(level, checkCtx.Rule.Type.String(), format)
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_table_no_foreign_key.go b/backend/plugin/advisor/snowflake/rule_table_no_foreign_key.go
index e8b1dcb6bf..8d348c4145 100644
--- a/backend/plugin/advisor/snowflake/rule_table_no_foreign_key.go
+++ b/backend/plugin/advisor/snowflake/rule_table_no_foreign_key.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleTableNoFK, &TableNoForeignKeyAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoForeignKeyAdvisor{})
}
// TableNoForeignKeyAdvisor is the advisor checking for table disallow foreign key.
@@ -39,7 +39,7 @@ func (*TableNoForeignKeyAdvisor) Check(_ context.Context, checkCtx advisor.Conte
return nil, err
}
- rule := NewTableNoForeignKeyRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableNoForeignKeyRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_table_require_pk.go b/backend/plugin/advisor/snowflake/rule_table_require_pk.go
index 6a6d50e62e..66c696a50e 100644
--- a/backend/plugin/advisor/snowflake/rule_table_require_pk.go
+++ b/backend/plugin/advisor/snowflake/rule_table_require_pk.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleTableRequirePK, &TableRequirePkAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePkAdvisor{})
}
// TableRequirePkAdvisor is the advisor checking for table require primary key.
@@ -39,7 +39,7 @@ func (*TableRequirePkAdvisor) Check(_ context.Context, checkCtx advisor.Context)
return nil, err
}
- rule := NewTableRequirePkRule(level, string(checkCtx.Rule.Type))
+ rule := NewTableRequirePkRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_where_require_select.go b/backend/plugin/advisor/snowflake/rule_where_require_select.go
index 47e7c92958..8c8312e240 100644
--- a/backend/plugin/advisor/snowflake/rule_where_require_select.go
+++ b/backend/plugin/advisor/snowflake/rule_where_require_select.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequireForSelectAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequireForSelectAdvisor{})
}
// WhereRequireForSelectAdvisor is the advisor checking for WHERE clause requirement for SELECT statement.
@@ -37,7 +37,7 @@ func (*WhereRequireForSelectAdvisor) Check(_ context.Context, checkCtx advisor.C
return nil, err
}
- rule := NewWhereRequireForSelectRule(level, string(checkCtx.Rule.Type))
+ rule := NewWhereRequireForSelectRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/rule_where_require_update_delete.go b/backend/plugin/advisor/snowflake/rule_where_require_update_delete.go
index b8ec741f7b..2118bac603 100644
--- a/backend/plugin/advisor/snowflake/rule_where_require_update_delete.go
+++ b/backend/plugin/advisor/snowflake/rule_where_require_update_delete.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_SNOWFLAKE, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequireForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_SNOWFLAKE, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequireForUpdateDeleteAdvisor{})
}
// WhereRequireForUpdateDeleteAdvisor is the advisor checking for WHERE clause requirement for UPDATE and DELETE statement.
@@ -37,7 +37,7 @@ func (*WhereRequireForUpdateDeleteAdvisor) Check(_ context.Context, checkCtx adv
return nil, err
}
- rule := NewWhereRequireForUpdateDeleteRule(level, string(checkCtx.Rule.Type))
+ rule := NewWhereRequireForUpdateDeleteRule(level, checkCtx.Rule.Type.String())
checker := NewGenericChecker([]Rule{rule})
for _, parseResult := range parseResults {
diff --git a/backend/plugin/advisor/snowflake/snowflake_rules_test.go b/backend/plugin/advisor/snowflake/snowflake_rules_test.go
index be3027b3cf..8cc1349722 100644
--- a/backend/plugin/advisor/snowflake/snowflake_rules_test.go
+++ b/backend/plugin/advisor/snowflake/snowflake_rules_test.go
@@ -9,21 +9,21 @@ import (
)
func TestSnowflakeRules(t *testing.T) {
- snowflakeRules := []advisor.SQLReviewRuleType{
- advisor.SchemaRuleTableNaming,
- advisor.SchemaRuleTableRequirePK,
- advisor.SchemaRuleTableNoFK,
- advisor.SchemaRuleColumnMaximumVarcharLength,
- advisor.SchemaRuleTableNameNoKeyword,
- advisor.SchemaRuleStatementRequireWhereForSelect,
- advisor.SchemaRuleStatementRequireWhereForUpdateDelete,
- advisor.SchemaRuleIdentifierNoKeyword,
- advisor.SchemaRuleRequiredColumn,
- advisor.SchemaRuleIdentifierCase,
- advisor.SchemaRuleColumnNotNull,
- advisor.SchemaRuleStatementNoSelectAll,
- advisor.SchemaRuleTableDropNamingConvention,
- advisor.SchemaRuleSchemaBackwardCompatibility,
+ snowflakeRules := []storepb.SQLReviewRule_Type{
+ storepb.SQLReviewRule_NAMING_TABLE,
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH,
+ storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD,
+ storepb.SQLReviewRule_COLUMN_REQUIRED,
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE,
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
}
for _, rule := range snowflakeRules {
diff --git a/backend/plugin/advisor/snowflake/test/column_maximum_varchar_length.yaml b/backend/plugin/advisor/snowflake/test/column_maximum_varchar_length.yaml
index 3503e6c2d7..cb7eb08c48 100644
--- a/backend/plugin/advisor/snowflake/test/column_maximum_varchar_length.yaml
+++ b/backend/plugin/advisor/snowflake/test/column_maximum_varchar_length.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
@@ -51,7 +51,7 @@
want:
- status: 2
code: 422
- title: column.maximum-varchar-length
+ title: COLUMN_MAXIMUM_VARCHAR_LENGTH
content: The maximum varchar length is 2560.
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/column_no_null.yaml b/backend/plugin/advisor/snowflake/test/column_no_null.yaml
index d11e9c1d2a..0979a4b7db 100644
--- a/backend/plugin/advisor/snowflake/test/column_no_null.yaml
+++ b/backend/plugin/advisor/snowflake/test/column_no_null.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column AGE is nullable, which is not allowed.
startposition:
line: 4
@@ -17,7 +17,7 @@
endposition: null
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column ADDRESS is nullable, which is not allowed.
startposition:
line: 5
@@ -35,7 +35,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column ADDRESS is nullable, which is not allowed.
startposition:
line: 5
@@ -54,7 +54,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: Column AGE is nullable, which is not allowed.
startposition:
line: 1
@@ -67,7 +67,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: After dropping NOT NULL of column AGE, it will be nullable, which is not allowed.
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/column_required.yaml b/backend/plugin/advisor/snowflake/test/column_required.yaml
index 0c6f6aeab8..27a17c27c3 100644
--- a/backend/plugin/advisor/snowflake/test/column_required.yaml
+++ b/backend/plugin/advisor/snowflake/test/column_required.yaml
@@ -16,7 +16,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "created_ts"
startposition:
line: 3
@@ -24,7 +24,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "creator_id"
startposition:
line: 3
@@ -32,7 +32,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "id"
startposition:
line: 3
@@ -40,7 +40,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "updated_ts"
startposition:
line: 3
@@ -48,7 +48,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "updater_id"
startposition:
line: 3
@@ -65,7 +65,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "updated_ts"
startposition:
line: 5
@@ -76,7 +76,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: Table t missing required column "created_ts"
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/naming_identifier_case.yaml b/backend/plugin/advisor/snowflake/test/naming_identifier_case.yaml
index c2394b7a10..98c5cb6e6f 100644
--- a/backend/plugin/advisor/snowflake/test/naming_identifier_case.yaml
+++ b/backend/plugin/advisor/snowflake/test/naming_identifier_case.yaml
@@ -14,7 +14,7 @@
want:
- status: 2
code: 309
- title: naming.identifier.case
+ title: NAMING_IDENTIFIER_CASE
content: Identifier "address" should be upper case
startposition:
line: 2
@@ -30,7 +30,7 @@
want:
- status: 2
code: 309
- title: naming.identifier.case
+ title: NAMING_IDENTIFIER_CASE
content: Identifier "address" should be upper case
startposition:
line: 2
@@ -48,7 +48,7 @@
want:
- status: 2
code: 309
- title: naming.identifier.case
+ title: NAMING_IDENTIFIER_CASE
content: Identifier "address" should be upper case
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/naming_identifier_no_keyword.yaml b/backend/plugin/advisor/snowflake/test/naming_identifier_no_keyword.yaml
index 37bbeb8e62..b41bc6774c 100644
--- a/backend/plugin/advisor/snowflake/test/naming_identifier_no_keyword.yaml
+++ b/backend/plugin/advisor/snowflake/test/naming_identifier_no_keyword.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "CONNECT" is a keyword and should be avoided
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "connect" is a keyword and should be avoided
startposition:
line: 2
@@ -43,7 +43,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "connect" is a keyword and should be avoided
startposition:
line: 2
@@ -60,7 +60,7 @@
want:
- status: 2
code: 308
- title: naming.identifier.no-keyword
+ title: NAMING_IDENTIFIER_NO_KEYWORD
content: Identifier "connect" is a keyword and should be avoided
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/naming_table.yaml b/backend/plugin/advisor/snowflake/test/naming_table.yaml
index 09424c9523..43f8854ef2 100644
--- a/backend/plugin/advisor/snowflake/test/naming_table.yaml
+++ b/backend/plugin/advisor/snowflake/test/naming_table.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"lower_case_table_name_without_double_quotes" mismatches table naming convention, naming format should be "^[A-Z]+(_[A-Z]+)*$"'
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"lower_case_table_name_with_double_quotes" mismatches table naming convention, naming format should be "^[A-Z]+(_[A-Z]+)*$"'
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: "\"\U0001F608EMOJI\U0001F604\" mismatches table naming convention, naming format should be \"^[A-Z]+(_[A-Z]+)*$\""
startposition:
line: 1
@@ -42,7 +42,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"lower_case_table_with_double_quotes" mismatches table naming convention, naming format should be "^[A-Z]+(_[A-Z]+)*$"'
startposition:
line: 1
@@ -55,7 +55,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"lower_case_table_with_double_quotes" mismatches table naming convention, naming format should be "^[A-Z]+(_[A-Z]+)*$"'
startposition:
line: 2
@@ -68,7 +68,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"lower_case_table_name_with_double_quotes" mismatches table naming convention, naming format should be "^[A-Z]+(_[A-Z]+)*$"'
startposition:
line: 1
@@ -81,7 +81,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '"lowercase" mismatches table naming convention, naming format should be "^[A-Z]+(_[A-Z]+)*$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/naming_table_no_keyword.yaml b/backend/plugin/advisor/snowflake/test/naming_table_no_keyword.yaml
index 9366803671..6e9b1ca590 100644
--- a/backend/plugin/advisor/snowflake/test/naming_table_no_keyword.yaml
+++ b/backend/plugin/advisor/snowflake/test/naming_table_no_keyword.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name "CONNECT" is a keyword identifier and should be avoided.
startposition: null
endposition: null
@@ -12,7 +12,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name "CONNECT" is a keyword identifier and should be avoided.
startposition: null
endposition: null
@@ -23,7 +23,7 @@
want:
- status: 2
code: 308
- title: naming.table.no-keyword
+ title: NAMING_TABLE_NO_KEYWORD
content: Table name "CONNECT" is a keyword identifier and should be avoided.
startposition: null
endposition: null
diff --git a/backend/plugin/advisor/snowflake/test/schema_backward_compatibility.yaml b/backend/plugin/advisor/snowflake/test/schema_backward_compatibility.yaml
index 57b165acb6..351f43e7fe 100644
--- a/backend/plugin/advisor/snowflake/test/schema_backward_compatibility.yaml
+++ b/backend/plugin/advisor/snowflake/test/schema_backward_compatibility.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 101
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop database "DB" may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 112
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop schema "TEST_DB.SCHEMA1" may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -25,7 +25,7 @@
want:
- status: 2
code: 103
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop table "TEST_DB.PUBLIC.T" may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 105
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop column "COL1" may cause incompatibility with the existing data and code
startposition:
line: 1
@@ -49,7 +49,7 @@
want:
- status: 2
code: 103
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: Drop table "TEST_DB.PUBLIC.T" may cause incompatibility with the existing data and code
startposition:
line: 2
diff --git a/backend/plugin/advisor/snowflake/test/statement_select_no_select_all.yaml b/backend/plugin/advisor/snowflake/test/statement_select_no_select_all.yaml
index 91130b858f..d8fe22afba 100644
--- a/backend/plugin/advisor/snowflake/test/statement_select_no_select_all.yaml
+++ b/backend/plugin/advisor/snowflake/test/statement_select_no_select_all.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: Avoid using SELECT *.
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/statement_where_require_select.yaml b/backend/plugin/advisor/snowflake/test/statement_where_require_select.yaml
index 4ed1a2b7c4..fec3f89090 100644
--- a/backend/plugin/advisor/snowflake/test/statement_where_require_select.yaml
+++ b/backend/plugin/advisor/snowflake/test/statement_where_require_select.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 1
@@ -44,7 +44,7 @@
endposition: null
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 5
@@ -60,7 +60,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: WHERE clause is required for SELECT statement.
startposition:
line: 2
diff --git a/backend/plugin/advisor/snowflake/test/statement_where_require_update_delete.yaml b/backend/plugin/advisor/snowflake/test/statement_where_require_update_delete.yaml
index 8632c8b5c4..0d9da9012c 100644
--- a/backend/plugin/advisor/snowflake/test/statement_where_require_update_delete.yaml
+++ b/backend/plugin/advisor/snowflake/test/statement_where_require_update_delete.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: WHERE clause is required for UPDATE statement.
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: WHERE clause is required for DELETE statement.
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/table_drop_naming_convention.yaml b/backend/plugin/advisor/snowflake/test/table_drop_naming_convention.yaml
index 73ea0d3f31..393ebe4fb0 100644
--- a/backend/plugin/advisor/snowflake/test/table_drop_naming_convention.yaml
+++ b/backend/plugin/advisor/snowflake/test/table_drop_naming_convention.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '"FOO" mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/snowflake/test/table_no_foreign_key.yaml b/backend/plugin/advisor/snowflake/test/table_no_foreign_key.yaml
index effb87326e..3b1e0571b1 100644
--- a/backend/plugin/advisor/snowflake/test/table_no_foreign_key.yaml
+++ b/backend/plugin/advisor/snowflake/test/table_no_foreign_key.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table CUSTOMER.
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table CUSTOMER.
startposition:
line: 6
@@ -45,7 +45,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table CUSTOMER.
startposition:
line: 7
@@ -63,7 +63,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table "ANOTHER_SCHEMA"."CUSTOMER".
startposition:
line: 1
@@ -96,7 +96,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: FOREIGN KEY is not allowed in the table CUSTOMER.
startposition:
line: 13
diff --git a/backend/plugin/advisor/snowflake/test/table_require_pk.yaml b/backend/plugin/advisor/snowflake/test/table_require_pk.yaml
index 16d3c3f19c..8b75d61e23 100644
--- a/backend/plugin/advisor/snowflake/test/table_require_pk.yaml
+++ b/backend/plugin/advisor/snowflake/test/table_require_pk.yaml
@@ -26,7 +26,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table CUSTOMER requires PRIMARY KEY.
startposition:
line: 1
@@ -44,7 +44,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table CUSTOMER requires PRIMARY KEY.
startposition:
line: 7
@@ -87,7 +87,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table CUSTOMER requires PRIMARY KEY.
startposition:
line: 9
@@ -123,7 +123,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table CUSTOMER requires PRIMARY KEY.
startposition:
line: 25
@@ -131,7 +131,7 @@
endposition: null
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table ORDERING requires PRIMARY KEY.
startposition:
line: 25
diff --git a/backend/plugin/advisor/sql_review.go b/backend/plugin/advisor/sql_review.go
index fc4aa2d28f..af3cc78205 100644
--- a/backend/plugin/advisor/sql_review.go
+++ b/backend/plugin/advisor/sql_review.go
@@ -21,239 +21,10 @@ import (
// How to add a SQL review rule:
// 1. Implement an advisor.(plugin/advisor/mysql or plugin/advisor/pg)
-// 2. Register this advisor in map[storepb.Engine][SQLReviewRuleType].(plugin/advisor.go)
+// 2. Register this advisor in map[storepb.Engine][storepb.SQLReviewRule_Type].(plugin/advisor.go)
// 3. Add advisor error code if needed(plugin/advisor/code.go).
-// SQLReviewRuleType is the type of schema rule.
-type SQLReviewRuleType string
-
const (
- // SchemaRuleMySQLEngine require InnoDB as the storage engine.
- SchemaRuleMySQLEngine SQLReviewRuleType = "engine.mysql.use-innodb"
-
- // SchemaRuleFullyQualifiedObjectName enforces using fully qualified object name.
- SchemaRuleFullyQualifiedObjectName SQLReviewRuleType = "naming.fully-qualified"
- // SchemaRuleTableNaming enforce the table name format.
- SchemaRuleTableNaming SQLReviewRuleType = "naming.table"
- // SchemaRuleColumnNaming enforce the column name format.
- SchemaRuleColumnNaming SQLReviewRuleType = "naming.column"
- // SchemaRulePKNaming enforce the primary key name format.
- SchemaRulePKNaming SQLReviewRuleType = "naming.index.pk"
- // SchemaRuleUKNaming enforce the unique key name format.
- SchemaRuleUKNaming SQLReviewRuleType = "naming.index.uk"
- // SchemaRuleFKNaming enforce the foreign key name format.
- SchemaRuleFKNaming SQLReviewRuleType = "naming.index.fk"
- // SchemaRuleIDXNaming enforce the index name format.
- SchemaRuleIDXNaming SQLReviewRuleType = "naming.index.idx"
- // SchemaRuleAutoIncrementColumnNaming enforce the auto_increment column name format.
- SchemaRuleAutoIncrementColumnNaming SQLReviewRuleType = "naming.column.auto-increment"
- // SchemaRuleTableNameNoKeyword enforce the table name not to use keyword.
- SchemaRuleTableNameNoKeyword SQLReviewRuleType = "naming.table.no-keyword"
- // SchemaRuleIdentifierNoKeyword enforce the identifier not to use keyword.
- SchemaRuleIdentifierNoKeyword SQLReviewRuleType = "naming.identifier.no-keyword"
- // SchemaRuleIdentifierCase enforce the identifier case.
- SchemaRuleIdentifierCase SQLReviewRuleType = "naming.identifier.case"
-
- // SchemaRuleStatementNoSelectAll disallow 'SELECT *'.
- SchemaRuleStatementNoSelectAll SQLReviewRuleType = "statement.select.no-select-all"
- // SchemaRuleStatementRequireWhereForSelect require 'WHERE' clause for SELECT statements.
- SchemaRuleStatementRequireWhereForSelect SQLReviewRuleType = "statement.where.require.select"
- // SchemaRuleStatementRequireWhereForUpdateDelete require 'WHERE' clause for UPDATE and DELETE statements.
- SchemaRuleStatementRequireWhereForUpdateDelete SQLReviewRuleType = "statement.where.require.update-delete"
- // SchemaRuleStatementNoLeadingWildcardLike disallow leading '%' in LIKE, e.g. LIKE foo = '%x' is not allowed.
- SchemaRuleStatementNoLeadingWildcardLike SQLReviewRuleType = "statement.where.no-leading-wildcard-like"
- // SchemaRuleStatementDisallowOnDelCascade disallows ON DELETE CASCADE clauses.
- SchemaRuleStatementDisallowOnDelCascade SQLReviewRuleType = "statement.disallow-on-del-cascade"
- // SchemaRuleStatementDisallowRemoveTblCascade disallows CASCADE when removing a table.
- SchemaRuleStatementDisallowRemoveTblCascade SQLReviewRuleType = "statement.disallow-rm-tbl-cascade"
- // SchemaRuleStatementDisallowCommit disallow using commit in the issue.
- SchemaRuleStatementDisallowCommit SQLReviewRuleType = "statement.disallow-commit"
- // SchemaRuleStatementDisallowLimit disallow the LIMIT clause in INSERT, DELETE and UPDATE statements.
- SchemaRuleStatementDisallowLimit SQLReviewRuleType = "statement.disallow-limit"
- // SchemaRuleStatementDisallowOrderBy disallow the ORDER BY clause in DELETE and UPDATE statements.
- SchemaRuleStatementDisallowOrderBy SQLReviewRuleType = "statement.disallow-order-by"
- // SchemaRuleStatementMergeAlterTable disallow redundant ALTER TABLE statements.
- SchemaRuleStatementMergeAlterTable SQLReviewRuleType = "statement.merge-alter-table"
- // SchemaRuleStatementInsertRowLimit enforce the insert row limit.
- SchemaRuleStatementInsertRowLimit SQLReviewRuleType = "statement.insert.row-limit"
- // SchemaRuleStatementInsertMustSpecifyColumn enforce the insert column specified.
- SchemaRuleStatementInsertMustSpecifyColumn SQLReviewRuleType = "statement.insert.must-specify-column"
- // SchemaRuleStatementInsertDisallowOrderByRand disallow the order by rand in the INSERT statement.
- SchemaRuleStatementInsertDisallowOrderByRand SQLReviewRuleType = "statement.insert.disallow-order-by-rand"
- // SchemaRuleStatementAffectedRowLimit enforce the UPDATE/DELETE affected row limit.
- SchemaRuleStatementAffectedRowLimit SQLReviewRuleType = "statement.affected-row-limit"
- // SchemaRuleStatementDMLDryRun dry run the dml.
- SchemaRuleStatementDMLDryRun SQLReviewRuleType = "statement.dml-dry-run"
- // SchemaRuleStatementDisallowAddColumnWithDefault disallow to add column with DEFAULT.
- SchemaRuleStatementDisallowAddColumnWithDefault SQLReviewRuleType = "statement.disallow-add-column-with-default"
- // SchemaRuleStatementAddCheckNotValid require add check constraints not valid.
- SchemaRuleStatementAddCheckNotValid SQLReviewRuleType = "statement.add-check-not-valid"
- // SchemaRuleStatementAddFKNotValid require add foreign key not valid.
- SchemaRuleStatementAddFKNotValid SQLReviewRuleType = "statement.add-foreign-key-not-valid"
- // SchemaRuleStatementDisallowAddNotNull disallow to add NOT NULL.
- SchemaRuleStatementDisallowAddNotNull SQLReviewRuleType = "statement.disallow-add-not-null"
- // SchemaRuleStatementSelectFullTableScan disallow full table scan.
- SchemaRuleStatementSelectFullTableScan SQLReviewRuleType = "statement.select-full-table-scan"
- // SchemaRuleStatementCreateSpecifySchema disallow to create table without specifying schema.
- SchemaRuleStatementCreateSpecifySchema SQLReviewRuleType = "statement.create-specify-schema"
- // SchemaRuleStatementCheckSetRoleVariable require add a check for SET ROLE variable.
- SchemaRuleStatementCheckSetRoleVariable SQLReviewRuleType = "statement.check-set-role-variable"
- // SchemaRuleStatementDisallowUsingFilesort disallow using filesort in execution plan.
- SchemaRuleStatementDisallowUsingFilesort SQLReviewRuleType = "statement.disallow-using-filesort"
- // SchemaRuleStatementDisallowUsingTemporary disallow using temporary in execution plan.
- SchemaRuleStatementDisallowUsingTemporary SQLReviewRuleType = "statement.disallow-using-temporary"
- // SchemaRuleStatementWhereNoEqualNull check the WHERE clause no equal null.
- SchemaRuleStatementWhereNoEqualNull SQLReviewRuleType = "statement.where.no-equal-null"
- // SchemaRuleStatementWhereDisallowFunctionsAndCalculations disallow using function in WHERE clause.
- SchemaRuleStatementWhereDisallowFunctionsAndCalculations SQLReviewRuleType = "statement.where.disallow-functions-and-calculations"
- // SchemaRuleStatementQueryMinumumPlanLevel enforce the minimum plan level.
- SchemaRuleStatementQueryMinumumPlanLevel SQLReviewRuleType = "statement.query.minimum-plan-level"
- // SchemaRuleStatementWhereMaximumLogicalOperatorCount enforce the maximum logical operator count in WHERE clause.
- SchemaRuleStatementWhereMaximumLogicalOperatorCount SQLReviewRuleType = "statement.where.maximum-logical-operator-count"
- // SchemaRuleStatementMaximumLimitValue enforce the maximum limit value.
- SchemaRuleStatementMaximumLimitValue SQLReviewRuleType = "statement.maximum-limit-value"
- // SchemaRuleStatementMaximumJoinTableCount enforce the maximum join table count in the statement.
- SchemaRuleStatementMaximumJoinTableCount SQLReviewRuleType = "statement.maximum-join-table-count"
- // SchemaRuleStatementMaximumStatementsInTransaction enforce the maximum statements in transaction.
- SchemaRuleStatementMaximumStatementsInTransaction SQLReviewRuleType = "statement.maximum-statements-in-transaction"
- // SchemaRuleStatementJoinStrictColumnAttrs enforce the join strict column attributes.
- SchemaRuleStatementJoinStrictColumnAttrs SQLReviewRuleType = "statement.join-strict-column-attrs"
- // SchemaRuleStatementPriorBackupCheck checks for prior backup.
- SchemaRuleStatementPriorBackupCheck SQLReviewRuleType = "statement.prior-backup-check"
- // SchemaRuleStatementNonTransactional checks for non-transactional statements.
- SchemaRuleStatementNonTransactional SQLReviewRuleType = "statement.non-transactional"
- // SchemaRuleStatementAddColumnWithoutPosition check no position in ADD COLUMN clause.
- SchemaRuleStatementAddColumnWithoutPosition SQLReviewRuleType = "statement.add-column-without-position"
- // SchemaRuleStatementDisallowOfflineDDL disallow offline ddl.
- SchemaRuleStatementDisallowOfflineDDL SQLReviewRuleType = "statement.disallow-offline-ddl"
- // SchemaRuleStatementDisallowCrossDBQueries disallow cross database queries.
- SchemaRuleStatementDisallowCrossDBQueries SQLReviewRuleType = "statement.disallow-cross-db-queries"
- // SchemaRuleStatementMaxExecutionTime enforce the maximum execution time.
- SchemaRuleStatementMaxExecutionTime SQLReviewRuleType = "statement.max-execution-time"
- // SchemaRuleStatementRequireAlgorithmOption require set ALGORITHM option in ALTER TABLE statement.
- SchemaRuleStatementRequireAlgorithmOption SQLReviewRuleType = "statement.require-algorithm-option"
- // SchemaRuleStatementRequireLockOption require set LOCK option in ALTER TABLE statement.
- SchemaRuleStatementRequireLockOption SQLReviewRuleType = "statement.require-lock-option"
- // SchemaRuleStatementObjectOwnerCheck checks the object owner for the statement.
- SchemaRuleStatementObjectOwnerCheck SQLReviewRuleType = "statement.object-owner-check"
- // SchemaRuleTableRequirePK require the table to have a primary key.
- SchemaRuleTableRequirePK SQLReviewRuleType = "table.require-pk"
- // SchemaRuleTableNoFK require the table disallow the foreign key.
- SchemaRuleTableNoFK SQLReviewRuleType = "table.no-foreign-key"
- // SchemaRuleTableDropNamingConvention require only the table following the naming convention can be deleted.
- SchemaRuleTableDropNamingConvention SQLReviewRuleType = "table.drop-naming-convention"
- // SchemaRuleTableCommentConvention enforce the table comment convention.
- SchemaRuleTableCommentConvention SQLReviewRuleType = "table.comment"
- // SchemaRuleTableDisallowPartition disallow the table partition.
- SchemaRuleTableDisallowPartition SQLReviewRuleType = "table.disallow-partition"
- // SchemaRuleTableDisallowTrigger disallow the table trigger.
- SchemaRuleTableDisallowTrigger SQLReviewRuleType = "table.disallow-trigger"
- // SchemaRuleTableNoDuplicateIndex require the table no duplicate index.
- SchemaRuleTableNoDuplicateIndex SQLReviewRuleType = "table.no-duplicate-index"
- // SchemaRuleTableTextFieldsTotalLength enforce the total length of text fields.
- SchemaRuleTableTextFieldsTotalLength SQLReviewRuleType = "table.text-fields-total-length"
- // SchemaRuleTableDisallowSetCharset disallow set table charset.
- SchemaRuleTableDisallowSetCharset SQLReviewRuleType = "table.disallow-set-charset"
- // SchemaRuleTableDisallowDDL disallow executing DDL for specific tables.
- SchemaRuleTableDisallowDDL SQLReviewRuleType = "table.disallow-ddl"
- // SchemaRuleTableDisallowDML disallow executing DML on specific tables.
- SchemaRuleTableDisallowDML SQLReviewRuleType = "table.disallow-dml"
- // SchemaRuleTableLimitSize restrict access to tables based on size.
- SchemaRuleTableLimitSize SQLReviewRuleType = "table.limit-size"
- // SchemaRuleTableRequireCharset enforce the table charset.
- SchemaRuleTableRequireCharset SQLReviewRuleType = "table.require-charset"
- // SchemaRuleTableRequireCollation enforce the table collation.
- SchemaRuleTableRequireCollation SQLReviewRuleType = "table.require-collation"
- // SchemaRuleRequiredColumn enforce the required columns in each table.
- SchemaRuleRequiredColumn SQLReviewRuleType = "column.required"
- // SchemaRuleColumnNotNull enforce the columns cannot have NULL value.
- SchemaRuleColumnNotNull SQLReviewRuleType = "column.no-null"
- // SchemaRuleColumnDisallowChangeType disallow change column type.
- SchemaRuleColumnDisallowChangeType SQLReviewRuleType = "column.disallow-change-type"
- // SchemaRuleColumnSetDefaultForNotNull require the not null column to set default value.
- SchemaRuleColumnSetDefaultForNotNull SQLReviewRuleType = "column.set-default-for-not-null"
- // SchemaRuleColumnDisallowChange disallow CHANGE COLUMN statement.
- SchemaRuleColumnDisallowChange SQLReviewRuleType = "column.disallow-change"
- // SchemaRuleColumnDisallowChangingOrder disallow changing column order.
- SchemaRuleColumnDisallowChangingOrder SQLReviewRuleType = "column.disallow-changing-order"
- // SchemaRuleColumnDisallowDrop disallow drop column.
- SchemaRuleColumnDisallowDrop SQLReviewRuleType = "column.disallow-drop"
- // SchemaRuleColumnDisallowDropInIndex disallow drop index column.
- SchemaRuleColumnDisallowDropInIndex SQLReviewRuleType = "column.disallow-drop-in-index"
- // SchemaRuleColumnCommentConvention enforce the column comment convention.
- SchemaRuleColumnCommentConvention SQLReviewRuleType = "column.comment"
- // SchemaRuleColumnAutoIncrementMustInteger require the auto-increment column to be integer.
- SchemaRuleColumnAutoIncrementMustInteger SQLReviewRuleType = "column.auto-increment-must-integer"
- // SchemaRuleColumnTypeDisallowList enforce the column type disallow list.
- SchemaRuleColumnTypeDisallowList SQLReviewRuleType = "column.type-disallow-list"
- // SchemaRuleColumnDisallowSetCharset disallow set column charset.
- SchemaRuleColumnDisallowSetCharset SQLReviewRuleType = "column.disallow-set-charset"
- // SchemaRuleColumnMaximumCharacterLength enforce the maximum character length.
- SchemaRuleColumnMaximumCharacterLength SQLReviewRuleType = "column.maximum-character-length"
- // SchemaRuleColumnMaximumVarcharLength enforce the maximum varchar length.
- SchemaRuleColumnMaximumVarcharLength SQLReviewRuleType = "column.maximum-varchar-length"
- // SchemaRuleColumnAutoIncrementInitialValue enforce the initial auto-increment value.
- SchemaRuleColumnAutoIncrementInitialValue SQLReviewRuleType = "column.auto-increment-initial-value"
- // SchemaRuleColumnAutoIncrementMustUnsigned enforce the auto-increment column to be unsigned.
- SchemaRuleColumnAutoIncrementMustUnsigned SQLReviewRuleType = "column.auto-increment-must-unsigned"
- // SchemaRuleCurrentTimeColumnCountLimit enforce the current column count limit.
- SchemaRuleCurrentTimeColumnCountLimit SQLReviewRuleType = "column.current-time-count-limit"
- // SchemaRuleColumnRequireDefault enforce the column default.
- SchemaRuleColumnRequireDefault SQLReviewRuleType = "column.require-default"
- // SchemaRuleColumnDefaultDisallowVolatile enforce the column default disallow volatile.
- SchemaRuleColumnDefaultDisallowVolatile SQLReviewRuleType = "column.default-disallow-volatile"
- // SchemaRuleAddNotNullColumnRequireDefault enforce the adding not null column requires default.
- SchemaRuleAddNotNullColumnRequireDefault SQLReviewRuleType = "column.add-not-null-require-default"
- // SchemaRuleColumnRequireCharset enforce the column require charset.
- SchemaRuleColumnRequireCharset SQLReviewRuleType = "column.require-charset"
- // SchemaRuleColumnRequireCollation enforce the column require collation.
- SchemaRuleColumnRequireCollation SQLReviewRuleType = "column.require-collation"
-
- // SchemaRuleSchemaBackwardCompatibility enforce the MySQL and TiDB support check whether the schema change is backward compatible.
- SchemaRuleSchemaBackwardCompatibility SQLReviewRuleType = "schema.backward-compatibility"
-
- // SchemaRuleDropEmptyDatabase enforce the MySQL and TiDB support check if the database is empty before users drop it.
- SchemaRuleDropEmptyDatabase SQLReviewRuleType = "database.drop-empty-database"
-
- // SchemaRuleIndexNoDuplicateColumn require the index no duplicate column.
- SchemaRuleIndexNoDuplicateColumn SQLReviewRuleType = "index.no-duplicate-column"
- // SchemaRuleIndexKeyNumberLimit enforce the index key number limit.
- SchemaRuleIndexKeyNumberLimit SQLReviewRuleType = "index.key-number-limit"
- // SchemaRuleIndexPKTypeLimit enforce the type restriction of columns in primary key.
- SchemaRuleIndexPKTypeLimit SQLReviewRuleType = "index.pk-type-limit"
- // SchemaRuleIndexTypeNoBlob enforce the type restriction of columns in index.
- SchemaRuleIndexTypeNoBlob SQLReviewRuleType = "index.type-no-blob"
- // SchemaRuleIndexTotalNumberLimit enforce the index total number limit.
- SchemaRuleIndexTotalNumberLimit SQLReviewRuleType = "index.total-number-limit"
- // SchemaRuleIndexPrimaryKeyTypeAllowlist enforce the primary key type allowlist.
- SchemaRuleIndexPrimaryKeyTypeAllowlist SQLReviewRuleType = "index.primary-key-type-allowlist"
- // SchemaRuleCreateIndexConcurrently require creating indexes concurrently.
- SchemaRuleCreateIndexConcurrently SQLReviewRuleType = "index.create-concurrently"
- // SchemaRuleIndexTypeAllowList enforce the index type allowlist.
- SchemaRuleIndexTypeAllowList SQLReviewRuleType = "index.type-allow-list"
- // SchemaRuleIndexNotRedundant prohibits createing redundant indices.
- SchemaRuleIndexNotRedundant SQLReviewRuleType = "index.not-redundant"
-
- // SchemaRuleCharsetAllowlist enforce the charset allowlist.
- SchemaRuleCharsetAllowlist SQLReviewRuleType = "system.charset.allowlist"
- // SchemaRuleCollationAllowlist enforce the collation allowlist.
- SchemaRuleCollationAllowlist SQLReviewRuleType = "system.collation.allowlist"
- // SchemaRuleCommentLength limit comment length.
- SchemaRuleCommentLength SQLReviewRuleType = "system.comment.length"
- // SchemaRuleProcedureDisallowCreate disallow create procedure.
- SchemaRuleProcedureDisallowCreate SQLReviewRuleType = "system.procedure.disallow-create"
- // SchemaRuleEventDisallowCreate disallow create event.
- SchemaRuleEventDisallowCreate SQLReviewRuleType = "system.event.disallow-create"
- // SchemaRuleViewDisallowCreate disallow create view.
- SchemaRuleViewDisallowCreate SQLReviewRuleType = "system.view.disallow-create"
- // SchemaRuleFunctionDisallowCreate disallow create function.
- SchemaRuleFunctionDisallowCreate SQLReviewRuleType = "system.function.disallow-create"
- // SchemaRuleFunctionDisallowList enforce the disallowed function list.
- SchemaRuleFunctionDisallowList SQLReviewRuleType = "system.function.disallowed-list"
-
- // SchemaRuleOnlineMigration advises using online migration to migrate large tables.
- SchemaRuleOnlineMigration SQLReviewRuleType = "advice.online-migration"
-
// TableNameTemplateToken is the token for table name.
TableNameTemplateToken = "{{table}}"
// ColumnListTemplateToken is the token for column name list.
@@ -276,20 +47,20 @@ const (
var (
// TemplateNamingTokens is the mapping for rule type to template token.
- TemplateNamingTokens = map[SQLReviewRuleType]map[string]bool{
- SchemaRuleIDXNaming: {
+ TemplateNamingTokens = map[storepb.SQLReviewRule_Type]map[string]bool{
+ storepb.SQLReviewRule_NAMING_INDEX_IDX: {
TableNameTemplateToken: true,
ColumnListTemplateToken: true,
},
- SchemaRulePKNaming: {
+ storepb.SQLReviewRule_NAMING_INDEX_PK: {
TableNameTemplateToken: true,
ColumnListTemplateToken: true,
},
- SchemaRuleUKNaming: {
+ storepb.SQLReviewRule_NAMING_INDEX_UK: {
TableNameTemplateToken: true,
ColumnListTemplateToken: true,
},
- SchemaRuleFKNaming: {
+ storepb.SQLReviewRule_NAMING_INDEX_FK: {
ReferencingTableNameTemplateToken: true,
ReferencingColumnNameTemplateToken: true,
ReferencedTableNameTemplateToken: true,
@@ -360,7 +131,7 @@ func UnmarshalNamingRulePayloadAsRegexp(payload string) (*regexp.Regexp, int, er
// UnmarshalNamingRulePayloadAsTemplate will unmarshal payload to NamingRulePayload and extract all the template keys.
// For example, "hard_code_{{table}}_{{column}}_end" will return
// "hard_code_{{table}}_{{column}}_end", ["{{table}}", "{{column}}"].
-func UnmarshalNamingRulePayloadAsTemplate(ruleType SQLReviewRuleType, payload string) (string, []string, int, error) {
+func UnmarshalNamingRulePayloadAsTemplate(ruleType storepb.SQLReviewRule_Type, payload string) (string, []string, int, error) {
var nr NamingRulePayload
if err := json.Unmarshal([]byte(payload), &nr); err != nil {
return "", nil, 0, errors.Wrapf(err, "failed to unmarshal naming rule payload %q", payload)
@@ -521,7 +292,7 @@ func SQLReviewCheck(
continue
}
- ruleType := SQLReviewRuleType(rule.Type)
+ ruleType := rule.Type
// Set per-rule fields
checkContext.AST = asts
diff --git a/backend/plugin/advisor/template_test.go b/backend/plugin/advisor/template_test.go
index e89513890a..a65bfe372c 100644
--- a/backend/plugin/advisor/template_test.go
+++ b/backend/plugin/advisor/template_test.go
@@ -14,7 +14,7 @@ import (
"github.com/stretchr/testify/require"
"gopkg.in/yaml.v3"
- "github.com/bytebase/bytebase/backend/plugin/advisor"
+ storepb "github.com/bytebase/bytebase/backend/generated-go/store"
)
// TestTemplateAdvisorRegistrations validates that all SQL review rules in frontend templates
@@ -130,7 +130,7 @@ func collectAdvisorRegistrations(repoRoot string) (map[AdvisorRegistration]bool,
for scanner.Scan() {
line := scanner.Text()
- // Line format: filepath: advisor.Register(storepb.Engine_MYSQL, advisor.SchemaRuleColumnNotNull, ...)
+ // Line format: filepath: advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_COLUMN_NO_NULL, ...)
// Extract the registration part after the filename
parts := strings.SplitN(line, "advisor.Register(storepb.Engine_", 2)
@@ -138,7 +138,7 @@ func collectAdvisorRegistrations(repoRoot string) (map[AdvisorRegistration]bool,
continue
}
- // parts[1] looks like: "MYSQL, advisor.SchemaRuleColumnNotNull, ...)"
+ // parts[1] looks like: "MYSQL, storepb.SQLReviewRule_COLUMN_NO_NULL, ...)"
regPart := parts[1]
// Extract engine and rule type
@@ -259,117 +259,118 @@ func validateTemplate(templatePath string, registrations map[AdvisorRegistration
}
// buildRuleTypeMapping creates a mapping from template rule types to SchemaRule constant names.
-// This is extracted from advisor.SQLReviewRuleType constants.
+// This is extracted from storepb.SQLReviewRule_Type constants.
+// buildRuleTypeMapping creates a mapping from template rule types (original string values) to SchemaRule constant names.
func buildRuleTypeMapping() map[string]string {
return map[string]string{
- string(advisor.SchemaRuleMySQLEngine): "SchemaRuleMySQLEngine",
- string(advisor.SchemaRuleFullyQualifiedObjectName): "SchemaRuleFullyQualifiedObjectName",
- string(advisor.SchemaRuleTableNaming): "SchemaRuleTableNaming",
- string(advisor.SchemaRuleColumnNaming): "SchemaRuleColumnNaming",
- string(advisor.SchemaRulePKNaming): "SchemaRulePKNaming",
- string(advisor.SchemaRuleUKNaming): "SchemaRuleUKNaming",
- string(advisor.SchemaRuleFKNaming): "SchemaRuleFKNaming",
- string(advisor.SchemaRuleIDXNaming): "SchemaRuleIDXNaming",
- string(advisor.SchemaRuleAutoIncrementColumnNaming): "SchemaRuleAutoIncrementColumnNaming",
- string(advisor.SchemaRuleTableNameNoKeyword): "SchemaRuleTableNameNoKeyword",
- string(advisor.SchemaRuleIdentifierNoKeyword): "SchemaRuleIdentifierNoKeyword",
- string(advisor.SchemaRuleIdentifierCase): "SchemaRuleIdentifierCase",
- string(advisor.SchemaRuleStatementNoSelectAll): "SchemaRuleStatementNoSelectAll",
- string(advisor.SchemaRuleStatementRequireWhereForSelect): "SchemaRuleStatementRequireWhereForSelect",
- string(advisor.SchemaRuleStatementRequireWhereForUpdateDelete): "SchemaRuleStatementRequireWhereForUpdateDelete",
- string(advisor.SchemaRuleStatementNoLeadingWildcardLike): "SchemaRuleStatementNoLeadingWildcardLike",
- string(advisor.SchemaRuleStatementDisallowOnDelCascade): "SchemaRuleStatementDisallowOnDelCascade",
- string(advisor.SchemaRuleStatementDisallowRemoveTblCascade): "SchemaRuleStatementDisallowRemoveTblCascade",
- string(advisor.SchemaRuleStatementDisallowCommit): "SchemaRuleStatementDisallowCommit",
- string(advisor.SchemaRuleStatementDisallowLimit): "SchemaRuleStatementDisallowLimit",
- string(advisor.SchemaRuleStatementDisallowOrderBy): "SchemaRuleStatementDisallowOrderBy",
- string(advisor.SchemaRuleStatementMergeAlterTable): "SchemaRuleStatementMergeAlterTable",
- string(advisor.SchemaRuleStatementInsertRowLimit): "SchemaRuleStatementInsertRowLimit",
- string(advisor.SchemaRuleStatementInsertMustSpecifyColumn): "SchemaRuleStatementInsertMustSpecifyColumn",
- string(advisor.SchemaRuleStatementInsertDisallowOrderByRand): "SchemaRuleStatementInsertDisallowOrderByRand",
- string(advisor.SchemaRuleStatementAffectedRowLimit): "SchemaRuleStatementAffectedRowLimit",
- string(advisor.SchemaRuleStatementDMLDryRun): "SchemaRuleStatementDMLDryRun",
- string(advisor.SchemaRuleStatementDisallowAddColumnWithDefault): "SchemaRuleStatementDisallowAddColumnWithDefault",
- string(advisor.SchemaRuleStatementAddCheckNotValid): "SchemaRuleStatementAddCheckNotValid",
- string(advisor.SchemaRuleStatementAddFKNotValid): "SchemaRuleStatementAddFKNotValid",
- string(advisor.SchemaRuleStatementDisallowAddNotNull): "SchemaRuleStatementDisallowAddNotNull",
- string(advisor.SchemaRuleStatementSelectFullTableScan): "SchemaRuleStatementSelectFullTableScan",
- string(advisor.SchemaRuleStatementCreateSpecifySchema): "SchemaRuleStatementCreateSpecifySchema",
- string(advisor.SchemaRuleStatementCheckSetRoleVariable): "SchemaRuleStatementCheckSetRoleVariable",
- string(advisor.SchemaRuleStatementDisallowUsingFilesort): "SchemaRuleStatementDisallowUsingFilesort",
- string(advisor.SchemaRuleStatementDisallowUsingTemporary): "SchemaRuleStatementDisallowUsingTemporary",
- string(advisor.SchemaRuleStatementWhereNoEqualNull): "SchemaRuleStatementWhereNoEqualNull",
- string(advisor.SchemaRuleStatementWhereDisallowFunctionsAndCalculations): "SchemaRuleStatementWhereDisallowFunctionsAndCalculations",
- string(advisor.SchemaRuleStatementQueryMinumumPlanLevel): "SchemaRuleStatementQueryMinumumPlanLevel",
- string(advisor.SchemaRuleStatementWhereMaximumLogicalOperatorCount): "SchemaRuleStatementWhereMaximumLogicalOperatorCount",
- string(advisor.SchemaRuleStatementMaximumLimitValue): "SchemaRuleStatementMaximumLimitValue",
- string(advisor.SchemaRuleStatementMaximumJoinTableCount): "SchemaRuleStatementMaximumJoinTableCount",
- string(advisor.SchemaRuleStatementMaximumStatementsInTransaction): "SchemaRuleStatementMaximumStatementsInTransaction",
- string(advisor.SchemaRuleStatementJoinStrictColumnAttrs): "SchemaRuleStatementJoinStrictColumnAttrs",
- string(advisor.SchemaRuleStatementPriorBackupCheck): "SchemaRuleStatementPriorBackupCheck",
- string(advisor.SchemaRuleStatementNonTransactional): "SchemaRuleStatementNonTransactional",
- string(advisor.SchemaRuleStatementAddColumnWithoutPosition): "SchemaRuleStatementAddColumnWithoutPosition",
- string(advisor.SchemaRuleStatementDisallowOfflineDDL): "SchemaRuleStatementDisallowOfflineDDL",
- string(advisor.SchemaRuleStatementDisallowCrossDBQueries): "SchemaRuleStatementDisallowCrossDBQueries",
- string(advisor.SchemaRuleStatementMaxExecutionTime): "SchemaRuleStatementMaxExecutionTime",
- string(advisor.SchemaRuleStatementObjectOwnerCheck): "SchemaRuleStatementObjectOwnerCheck",
- string(advisor.SchemaRuleStatementRequireAlgorithmOption): "SchemaRuleStatementRequireAlgorithmOption",
- string(advisor.SchemaRuleStatementRequireLockOption): "SchemaRuleStatementRequireLockOption",
- string(advisor.SchemaRuleTableNoDuplicateIndex): "SchemaRuleTableNoDuplicateIndex",
- string(advisor.SchemaRuleTableTextFieldsTotalLength): "SchemaRuleTableTextFieldsTotalLength",
- string(advisor.SchemaRuleTableDisallowSetCharset): "SchemaRuleTableDisallowSetCharset",
- string(advisor.SchemaRuleTableLimitSize): "SchemaRuleTableLimitSize",
- string(advisor.SchemaRuleTableRequireCharset): "SchemaRuleTableRequireCharset",
- string(advisor.SchemaRuleTableRequireCollation): "SchemaRuleTableRequireCollation",
- string(advisor.SchemaRuleTableDisallowDML): "SchemaRuleTableDisallowDML",
- string(advisor.SchemaRuleTableDisallowDDL): "SchemaRuleTableDisallowDDL",
- string(advisor.SchemaRuleTableRequirePK): "SchemaRuleTableRequirePK",
- string(advisor.SchemaRuleTableNoFK): "SchemaRuleTableNoFK",
- string(advisor.SchemaRuleTableDropNamingConvention): "SchemaRuleTableDropNamingConvention",
- string(advisor.SchemaRuleTableCommentConvention): "SchemaRuleTableCommentConvention",
- string(advisor.SchemaRuleTableDisallowPartition): "SchemaRuleTableDisallowPartition",
- string(advisor.SchemaRuleTableDisallowTrigger): "SchemaRuleTableDisallowTrigger",
- string(advisor.SchemaRuleSchemaBackwardCompatibility): "SchemaRuleSchemaBackwardCompatibility",
- string(advisor.SchemaRuleDropEmptyDatabase): "SchemaRuleDropEmptyDatabase",
- string(advisor.SchemaRuleIndexNoDuplicateColumn): "SchemaRuleIndexNoDuplicateColumn",
- string(advisor.SchemaRuleIndexPKTypeLimit): "SchemaRuleIndexPKTypeLimit",
- string(advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist): "SchemaRuleIndexPrimaryKeyTypeAllowlist",
- string(advisor.SchemaRuleIndexKeyNumberLimit): "SchemaRuleIndexKeyNumberLimit",
- string(advisor.SchemaRuleIndexTotalNumberLimit): "SchemaRuleIndexTotalNumberLimit",
- string(advisor.SchemaRuleIndexTypeAllowList): "SchemaRuleIndexTypeAllowList",
- string(advisor.SchemaRuleIndexTypeNoBlob): "SchemaRuleIndexTypeNoBlob",
- string(advisor.SchemaRuleIndexNotRedundant): "SchemaRuleIndexNotRedundant",
- string(advisor.SchemaRuleCreateIndexConcurrently): "SchemaRuleCreateIndexConcurrently",
- string(advisor.SchemaRuleCharsetAllowlist): "SchemaRuleCharsetAllowlist",
- string(advisor.SchemaRuleCollationAllowlist): "SchemaRuleCollationAllowlist",
- string(advisor.SchemaRuleCommentLength): "SchemaRuleCommentLength",
- string(advisor.SchemaRuleRequiredColumn): "SchemaRuleRequiredColumn",
- string(advisor.SchemaRuleColumnNotNull): "SchemaRuleColumnNotNull",
- string(advisor.SchemaRuleColumnDisallowChangeType): "SchemaRuleColumnDisallowChangeType",
- string(advisor.SchemaRuleColumnSetDefaultForNotNull): "SchemaRuleColumnSetDefaultForNotNull",
- string(advisor.SchemaRuleColumnDisallowChange): "SchemaRuleColumnDisallowChange",
- string(advisor.SchemaRuleColumnDisallowDrop): "SchemaRuleColumnDisallowDrop",
- string(advisor.SchemaRuleColumnDisallowDropInIndex): "SchemaRuleColumnDisallowDropInIndex",
- string(advisor.SchemaRuleColumnDisallowChangingOrder): "SchemaRuleColumnDisallowChangingOrder",
- string(advisor.SchemaRuleColumnCommentConvention): "SchemaRuleColumnCommentConvention",
- string(advisor.SchemaRuleColumnAutoIncrementMustInteger): "SchemaRuleColumnAutoIncrementMustInteger",
- string(advisor.SchemaRuleColumnTypeDisallowList): "SchemaRuleColumnTypeDisallowList",
- string(advisor.SchemaRuleColumnDisallowSetCharset): "SchemaRuleColumnDisallowSetCharset",
- string(advisor.SchemaRuleColumnMaximumCharacterLength): "SchemaRuleColumnMaximumCharacterLength",
- string(advisor.SchemaRuleColumnMaximumVarcharLength): "SchemaRuleColumnMaximumVarcharLength",
- string(advisor.SchemaRuleColumnRequireCharset): "SchemaRuleColumnRequireCharset",
- string(advisor.SchemaRuleColumnRequireCollation): "SchemaRuleColumnRequireCollation",
- string(advisor.SchemaRuleColumnAutoIncrementInitialValue): "SchemaRuleColumnAutoIncrementInitialValue",
- string(advisor.SchemaRuleColumnAutoIncrementMustUnsigned): "SchemaRuleColumnAutoIncrementMustUnsigned",
- string(advisor.SchemaRuleCurrentTimeColumnCountLimit): "SchemaRuleCurrentTimeColumnCountLimit",
- string(advisor.SchemaRuleColumnRequireDefault): "SchemaRuleColumnRequireDefault",
- string(advisor.SchemaRuleColumnDefaultDisallowVolatile): "SchemaRuleColumnDefaultDisallowVolatile",
- string(advisor.SchemaRuleAddNotNullColumnRequireDefault): "SchemaRuleAddNotNullColumnRequireDefault",
- string(advisor.SchemaRuleProcedureDisallowCreate): "SchemaRuleProcedureDisallowCreate",
- string(advisor.SchemaRuleEventDisallowCreate): "SchemaRuleEventDisallowCreate",
- string(advisor.SchemaRuleViewDisallowCreate): "SchemaRuleViewDisallowCreate",
- string(advisor.SchemaRuleFunctionDisallowCreate): "SchemaRuleFunctionDisallowCreate",
- string(advisor.SchemaRuleFunctionDisallowList): "SchemaRuleFunctionDisallowList",
- string(advisor.SchemaRuleOnlineMigration): "SchemaRuleOnlineMigration",
+ "ENGINE_MYSQL_USE_INNODB": "storepb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB",
+ "NAMING_FULLY_QUALIFIED": "storepb.SQLReviewRule_NAMING_FULLY_QUALIFIED",
+ "NAMING_TABLE": "storepb.SQLReviewRule_NAMING_TABLE",
+ "NAMING_COLUMN": "storepb.SQLReviewRule_NAMING_COLUMN",
+ "NAMING_INDEX_PK": "storepb.SQLReviewRule_NAMING_INDEX_PK",
+ "NAMING_INDEX_UK": "storepb.SQLReviewRule_NAMING_INDEX_UK",
+ "NAMING_INDEX_FK": "storepb.SQLReviewRule_NAMING_INDEX_FK",
+ "NAMING_INDEX_IDX": "storepb.SQLReviewRule_NAMING_INDEX_IDX",
+ "NAMING_COLUMN_AUTO_INCREMENT": "storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT",
+ "NAMING_TABLE_NO_KEYWORD": "storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD",
+ "NAMING_IDENTIFIER_NO_KEYWORD": "storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD",
+ "NAMING_IDENTIFIER_CASE": "storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE",
+ "STATEMENT_SELECT_NO_SELECT_ALL": "storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL",
+ "STATEMENT_WHERE_REQUIRE_SELECT": "storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT",
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": "storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE",
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": "storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE",
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": "storepb.SQLReviewRule_STATEMENT_DISALLOW_ON_DEL_CASCADE",
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": "storepb.SQLReviewRule_STATEMENT_DISALLOW_RM_TBL_CASCADE",
+ "STATEMENT_DISALLOW_COMMIT": "storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT",
+ "STATEMENT_DISALLOW_LIMIT": "storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT",
+ "STATEMENT_DISALLOW_ORDER_BY": "storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY",
+ "STATEMENT_MERGE_ALTER_TABLE": "storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE",
+ "STATEMENT_INSERT_ROW_LIMIT": "storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT",
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": "storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN",
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": "storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND",
+ "STATEMENT_AFFECTED_ROW_LIMIT": "storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT",
+ "STATEMENT_DML_DRY_RUN": "storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN",
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": "storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT",
+ "STATEMENT_ADD_CHECK_NOT_VALID": "storepb.SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID",
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": "storepb.SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID",
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": "storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL",
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": "storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN",
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": "storepb.SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA",
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": "storepb.SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE",
+ "STATEMENT_DISALLOW_USING_FILESORT": "storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT",
+ "STATEMENT_DISALLOW_USING_TEMPORARY": "storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY",
+ "STATEMENT_WHERE_NO_EQUAL_NULL": "storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL",
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": "storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS",
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": "storepb.SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL",
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": "storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT",
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": "storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE",
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": "storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT",
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": "storepb.SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION",
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": "storepb.SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS",
+ "STATEMENT_NON_TRANSACTIONAL": "storepb.SQLReviewRule_STATEMENT_NON_TRANSACTIONAL",
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": "storepb.SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION",
+ "STATEMENT_DISALLOW_OFFLINE_DDL": "storepb.SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL",
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": "storepb.SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES",
+ "STATEMENT_MAX_EXECUTION_TIME": "storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME",
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": "storepb.SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION",
+ "STATEMENT_REQUIRE_LOCK_OPTION": "storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION",
+ "STATEMENT_OBJECT_OWNER_CHECK": "storepb.SQLReviewRule_STATEMENT_OBJECT_OWNER_CHECK",
+ "TABLE_REQUIRE_PK": "storepb.SQLReviewRule_TABLE_REQUIRE_PK",
+ "TABLE_NO_FOREIGN_KEY": "storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY",
+ "TABLE_DROP_NAMING_CONVENTION": "storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION",
+ "TABLE_COMMENT": "storepb.SQLReviewRule_TABLE_COMMENT",
+ "TABLE_DISALLOW_PARTITION": "storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION",
+ "TABLE_DISALLOW_TRIGGER": "storepb.SQLReviewRule_TABLE_DISALLOW_TRIGGER",
+ "TABLE_NO_DUPLICATE_INDEX": "storepb.SQLReviewRule_TABLE_NO_DUPLICATE_INDEX",
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": "storepb.SQLReviewRule_TABLE_TEXT_FIELDS_TOTAL_LENGTH",
+ "TABLE_DISALLOW_SET_CHARSET": "storepb.SQLReviewRule_TABLE_DISALLOW_SET_CHARSET",
+ "TABLE_DISALLOW_DDL": "storepb.SQLReviewRule_TABLE_DISALLOW_DDL",
+ "TABLE_DISALLOW_DML": "storepb.SQLReviewRule_TABLE_DISALLOW_DML",
+ "TABLE_LIMIT_SIZE": "storepb.SQLReviewRule_TABLE_LIMIT_SIZE",
+ "TABLE_REQUIRE_CHARSET": "storepb.SQLReviewRule_TABLE_REQUIRE_CHARSET",
+ "TABLE_REQUIRE_COLLATION": "storepb.SQLReviewRule_TABLE_REQUIRE_COLLATION",
+ "COLUMN_REQUIRED": "storepb.SQLReviewRule_COLUMN_REQUIRED",
+ "COLUMN_NO_NULL": "storepb.SQLReviewRule_COLUMN_NO_NULL",
+ "COLUMN_DISALLOW_CHANGE_TYPE": "storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE",
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": "storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL",
+ "COLUMN_DISALLOW_CHANGE": "storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE",
+ "COLUMN_DISALLOW_CHANGING_ORDER": "storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER",
+ "COLUMN_DISALLOW_DROP": "storepb.SQLReviewRule_COLUMN_DISALLOW_DROP",
+ "COLUMN_DISALLOW_DROP_IN_INDEX": "storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX",
+ "COLUMN_COMMENT": "storepb.SQLReviewRule_COLUMN_COMMENT",
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": "storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER",
+ "COLUMN_TYPE_DISALLOW_LIST": "storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST",
+ "COLUMN_DISALLOW_SET_CHARSET": "storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET",
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": "storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH",
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": "storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH",
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": "storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE",
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": "storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED",
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": "storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT",
+ "COLUMN_REQUIRE_DEFAULT": "storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT",
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": "storepb.SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE",
+ "COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT": "storepb.SQLReviewRule_COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT",
+ "COLUMN_REQUIRE_CHARSET": "storepb.SQLReviewRule_COLUMN_REQUIRE_CHARSET",
+ "COLUMN_REQUIRE_COLLATION": "storepb.SQLReviewRule_COLUMN_REQUIRE_COLLATION",
+ "SCHEMA_BACKWARD_COMPATIBILITY": "storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY",
+ "DATABASE_DROP_EMPTY_DATABASE": "storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE",
+ "INDEX_NO_DUPLICATE_COLUMN": "storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN",
+ "INDEX_KEY_NUMBER_LIMIT": "storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT",
+ "INDEX_PK_TYPE_LIMIT": "storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT",
+ "INDEX_TYPE_NO_BLOB": "storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB",
+ "INDEX_TOTAL_NUMBER_LIMIT": "storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT",
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": "storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST",
+ "INDEX_CREATE_CONCURRENTLY": "storepb.SQLReviewRule_INDEX_CREATE_CONCURRENTLY",
+ "INDEX_TYPE_ALLOW_LIST": "storepb.SQLReviewRule_INDEX_TYPE_ALLOW_LIST",
+ "INDEX_NOT_REDUNDANT": "storepb.SQLReviewRule_INDEX_NOT_REDUNDANT",
+ "SYSTEM_CHARSET_ALLOWLIST": "storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST",
+ "SYSTEM_COLLATION_ALLOWLIST": "storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST",
+ "SYSTEM_COMMENT_LENGTH": "storepb.SQLReviewRule_SYSTEM_COMMENT_LENGTH",
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": "storepb.SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE",
+ "SYSTEM_EVENT_DISALLOW_CREATE": "storepb.SQLReviewRule_SYSTEM_EVENT_DISALLOW_CREATE",
+ "SYSTEM_VIEW_DISALLOW_CREATE": "storepb.SQLReviewRule_SYSTEM_VIEW_DISALLOW_CREATE",
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": "storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE",
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": "storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST",
+ "ADVICE_ONLINE_MIGRATION": "storepb.SQLReviewRule_ADVICE_ONLINE_MIGRATION",
+ "BUILTIN_PRIOR_BACKUP_CHECK": storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK.String(),
}
}
diff --git a/backend/plugin/advisor/tidb/advisor_builtin_prior_backup_check.go b/backend/plugin/advisor/tidb/advisor_builtin_prior_backup_check.go
index 10a1cc88dd..9d64b30372 100644
--- a/backend/plugin/advisor/tidb/advisor_builtin_prior_backup_check.go
+++ b/backend/plugin/advisor/tidb/advisor_builtin_prior_backup_check.go
@@ -26,7 +26,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.BuiltinRulePriorBackupCheck, &StatementPriorBackupCheckAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK, &StatementPriorBackupCheckAdvisor{})
}
// StatementPriorBackupCheckAdvisor is the advisor checking for no mixed DDL and DML.
@@ -50,7 +50,7 @@ func (*StatementPriorBackupCheckAdvisor) Check(ctx context.Context, checkCtx adv
if err != nil {
return nil, err
}
- title := string(checkCtx.Rule.Type)
+ title := checkCtx.Rule.Type.String()
var updateStatements []*ast.UpdateStmt
var deleteStatements []*ast.DeleteStmt
@@ -85,8 +85,8 @@ func (*StatementPriorBackupCheckAdvisor) Check(ctx context.Context, checkCtx adv
adviceList = append(adviceList, &storepb.Advice{
Status: level,
Title: title,
- Content: fmt.Sprintf("Need database %q to do prior backup but it does not exist", databaseName),
- Code: code.DatabaseNotExists.Int32(),
+ Content: fmt.Sprintf("Prior backup check failed: need database %q to do prior backup but it does not exist", databaseName),
+ Code: code.BuiltinPriorBackupCheck.Int32(),
StartPosition: nil,
})
}
diff --git a/backend/plugin/advisor/tidb/advisor_charset_allowlist.go b/backend/plugin/advisor/tidb/advisor_charset_allowlist.go
index fa4e5cc1cb..87042912ac 100644
--- a/backend/plugin/advisor/tidb/advisor_charset_allowlist.go
+++ b/backend/plugin/advisor/tidb/advisor_charset_allowlist.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleCharsetAllowlist, &CharsetAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST, &CharsetAllowlistAdvisor{})
}
// CharsetAllowlistAdvisor is the advisor checking for charset allowlist.
@@ -45,7 +45,7 @@ func (*CharsetAllowlistAdvisor) Check(_ context.Context, checkCtx advisor.Contex
}
checker := &charsetAllowlistChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
allowlist: make(map[string]bool),
}
for _, charset := range payload.List {
diff --git a/backend/plugin/advisor/tidb/advisor_collation_allowlist.go b/backend/plugin/advisor/tidb/advisor_collation_allowlist.go
index c1f0091eb8..1288d416f8 100644
--- a/backend/plugin/advisor/tidb/advisor_collation_allowlist.go
+++ b/backend/plugin/advisor/tidb/advisor_collation_allowlist.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleCollationAllowlist, &CollationAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST, &CollationAllowlistAdvisor{})
}
// CollationAllowlistAdvisor is the advisor checking for collation allowlist.
@@ -46,7 +46,7 @@ func (*CollationAllowlistAdvisor) Check(_ context.Context, checkCtx advisor.Cont
}
checker := &collationAllowlistChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
allowlist: make(map[string]bool),
}
for _, collation := range payload.List {
diff --git a/backend/plugin/advisor/tidb/advisor_column_auto_increment_initial_value.go b/backend/plugin/advisor/tidb/advisor_column_auto_increment_initial_value.go
index 59e149fdfd..6dfd5dcf77 100644
--- a/backend/plugin/advisor/tidb/advisor_column_auto_increment_initial_value.go
+++ b/backend/plugin/advisor/tidb/advisor_column_auto_increment_initial_value.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnAutoIncrementInitialValue, &ColumnAutoIncrementInitialValueAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE, &ColumnAutoIncrementInitialValueAdvisor{})
}
// ColumnAutoIncrementInitialValueAdvisor is the advisor checking for auto-increment column initial value.
@@ -46,7 +46,7 @@ func (*ColumnAutoIncrementInitialValueAdvisor) Check(_ context.Context, checkCtx
}
checker := &columnAutoIncrementInitialValueChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
value: payload.Number,
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_integer.go b/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_integer.go
index d6e1dff0bf..11c4269f89 100644
--- a/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_integer.go
+++ b/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_integer.go
@@ -23,7 +23,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnAutoIncrementMustInteger, &ColumnAutoIncrementMustIntegerAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER, &ColumnAutoIncrementMustIntegerAdvisor{})
}
// ColumnAutoIncrementMustIntegerAdvisor is the advisor checking for auto-increment column type.
@@ -44,7 +44,7 @@ func (*ColumnAutoIncrementMustIntegerAdvisor) Check(_ context.Context, checkCtx
}
checker := &columnAutoIncrementMustIntegerChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_unsigned.go b/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_unsigned.go
index f47ffc6180..28431f4eb5 100644
--- a/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_unsigned.go
+++ b/backend/plugin/advisor/tidb/advisor_column_auto_increment_must_unsigned.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnAutoIncrementMustUnsigned, &ColumnAutoIncrementMustUnsignedAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED, &ColumnAutoIncrementMustUnsignedAdvisor{})
}
// ColumnAutoIncrementMustUnsignedAdvisor is the advisor checking for unsigned auto-increment column.
@@ -43,7 +43,7 @@ func (*ColumnAutoIncrementMustUnsignedAdvisor) Check(_ context.Context, checkCtx
}
checker := &columnAutoIncrementMustUnsignedChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_comment_convention.go b/backend/plugin/advisor/tidb/advisor_column_comment_convention.go
index 0a21feef38..bf57a697b7 100644
--- a/backend/plugin/advisor/tidb/advisor_column_comment_convention.go
+++ b/backend/plugin/advisor/tidb/advisor_column_comment_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnCommentConvention, &ColumnCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_COMMENT, &ColumnCommentConventionAdvisor{})
}
// ColumnCommentConventionAdvisor is the advisor checking for column comment convention.
@@ -46,7 +46,7 @@ func (*ColumnCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor
}
checker := &columnCommentConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
payload: payload,
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_current_time_count_limit.go b/backend/plugin/advisor/tidb/advisor_column_current_time_count_limit.go
index 0a883750e4..9ede41a5fc 100644
--- a/backend/plugin/advisor/tidb/advisor_column_current_time_count_limit.go
+++ b/backend/plugin/advisor/tidb/advisor_column_current_time_count_limit.go
@@ -29,7 +29,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleCurrentTimeColumnCountLimit, &ColumnCurrentTimeCountLimitAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT, &ColumnCurrentTimeCountLimitAdvisor{})
}
// ColumnCurrentTimeCountLimitAdvisor is the advisor checking for current time column count limit.
@@ -50,7 +50,7 @@ func (*ColumnCurrentTimeCountLimitAdvisor) Check(_ context.Context, checkCtx adv
}
checker := &columnCurrentTimeCountLimitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
tableSet: make(map[string]tableData),
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_disallow_changing.go b/backend/plugin/advisor/tidb/advisor_column_disallow_changing.go
index 8f783c55ed..e78d88602b 100644
--- a/backend/plugin/advisor/tidb/advisor_column_disallow_changing.go
+++ b/backend/plugin/advisor/tidb/advisor_column_disallow_changing.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnDisallowChange, &ColumnDisallowChangingAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE, &ColumnDisallowChangingAdvisor{})
}
// ColumnDisallowChangingAdvisor is the advisor checking for disallow CHANGE COLUMN statement.
@@ -42,7 +42,7 @@ func (*ColumnDisallowChangingAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &columnDisallowChangingChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_disallow_changing_order.go b/backend/plugin/advisor/tidb/advisor_column_disallow_changing_order.go
index 70e848712f..4a647ee7b4 100644
--- a/backend/plugin/advisor/tidb/advisor_column_disallow_changing_order.go
+++ b/backend/plugin/advisor/tidb/advisor_column_disallow_changing_order.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnDisallowChangingOrder, &ColumnDisallowChangingOrderAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER, &ColumnDisallowChangingOrderAdvisor{})
}
// ColumnDisallowChangingOrderAdvisor is the advisor checking for disallow changing column order.
@@ -42,7 +42,7 @@ func (*ColumnDisallowChangingOrderAdvisor) Check(_ context.Context, checkCtx adv
}
checker := &columnDisallowChangingOrderChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_disallow_changing_type.go b/backend/plugin/advisor/tidb/advisor_column_disallow_changing_type.go
index 42d29fd4b2..067d656f5c 100644
--- a/backend/plugin/advisor/tidb/advisor_column_disallow_changing_type.go
+++ b/backend/plugin/advisor/tidb/advisor_column_disallow_changing_type.go
@@ -23,7 +23,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnDisallowChangeType, &ColumnDisallowChangingTypeAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE, &ColumnDisallowChangingTypeAdvisor{})
}
// ColumnDisallowChangingTypeAdvisor is the advisor checking for disallow changing column type..
@@ -44,7 +44,7 @@ func (*ColumnDisallowChangingTypeAdvisor) Check(_ context.Context, checkCtx advi
}
checker := &columnDisallowChangingTypeChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
originalMetadata: checkCtx.OriginalMetadata,
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_disallow_drop_in_index.go b/backend/plugin/advisor/tidb/advisor_column_disallow_drop_in_index.go
index 452213364a..b6793b33b7 100644
--- a/backend/plugin/advisor/tidb/advisor_column_disallow_drop_in_index.go
+++ b/backend/plugin/advisor/tidb/advisor_column_disallow_drop_in_index.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnDisallowDropInIndex, &ColumnDisallowDropInIndexAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX, &ColumnDisallowDropInIndexAdvisor{})
}
// ColumnDisallowDropInIndexAdvisor is the advisor checking for disallow DROP COLUMN in index.
@@ -44,7 +44,7 @@ func (*ColumnDisallowDropInIndexAdvisor) Check(_ context.Context, checkCtx advis
checker := &columnDisallowDropInIndexChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
tables: make(tableState),
originalMetadata: checkCtx.OriginalMetadata,
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_disallow_set_charset.go b/backend/plugin/advisor/tidb/advisor_column_disallow_set_charset.go
index dd894778f0..927ca2322a 100644
--- a/backend/plugin/advisor/tidb/advisor_column_disallow_set_charset.go
+++ b/backend/plugin/advisor/tidb/advisor_column_disallow_set_charset.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnDisallowSetCharset, &ColumnDisallowSetCharsetAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET, &ColumnDisallowSetCharsetAdvisor{})
}
// ColumnDisallowSetCharsetAdvisor is the advisor checking for disallow set column charset.
@@ -42,7 +42,7 @@ func (*ColumnDisallowSetCharsetAdvisor) Check(_ context.Context, checkCtx adviso
}
checker := &columnDisallowSetCharsetChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_maximum_character_length.go b/backend/plugin/advisor/tidb/advisor_column_maximum_character_length.go
index db89c8a79e..c7fdfc347e 100644
--- a/backend/plugin/advisor/tidb/advisor_column_maximum_character_length.go
+++ b/backend/plugin/advisor/tidb/advisor_column_maximum_character_length.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnMaximumCharacterLength, &ColumnMaximumCharacterLengthAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH, &ColumnMaximumCharacterLengthAdvisor{})
}
// ColumnMaximumCharacterLengthAdvisor is the advisor checking for max character length.
@@ -47,7 +47,7 @@ func (*ColumnMaximumCharacterLengthAdvisor) Check(_ context.Context, checkCtx ad
}
checker := &columnMaximumCharacterLengthChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
maximum: payload.Number,
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_no_null.go b/backend/plugin/advisor/tidb/advisor_column_no_null.go
index d1a7dffc20..3df3c352cf 100644
--- a/backend/plugin/advisor/tidb/advisor_column_no_null.go
+++ b/backend/plugin/advisor/tidb/advisor_column_no_null.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnNotNull, &ColumnNoNullAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_NO_NULL, &ColumnNoNullAdvisor{})
}
// ColumnNoNullAdvisor is the advisor checking for column no NULL value.
@@ -41,7 +41,7 @@ func (*ColumnNoNullAdvisor) Check(_ context.Context, checkCtx advisor.Context) (
}
checker := &columnNoNullChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
columnSet: make(map[string]columnName),
finalMetadata: checkCtx.FinalMetadata,
}
diff --git a/backend/plugin/advisor/tidb/advisor_column_require_default.go b/backend/plugin/advisor/tidb/advisor_column_require_default.go
index 2ae8d93e49..947e0c674b 100644
--- a/backend/plugin/advisor/tidb/advisor_column_require_default.go
+++ b/backend/plugin/advisor/tidb/advisor_column_require_default.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnRequireDefault, &ColumRequireDefaultAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT, &ColumRequireDefaultAdvisor{})
}
// ColumRequireDefaultAdvisor is the advisor checking for column default requirement.
@@ -42,7 +42,7 @@ func (*ColumRequireDefaultAdvisor) Check(_ context.Context, checkCtx advisor.Con
}
checker := &columRequireDefaultChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_required.go b/backend/plugin/advisor/tidb/advisor_column_required.go
index bcf678bc54..5d71a45a1d 100644
--- a/backend/plugin/advisor/tidb/advisor_column_required.go
+++ b/backend/plugin/advisor/tidb/advisor_column_required.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleRequiredColumn, &ColumnRequirementAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_REQUIRED, &ColumnRequirementAdvisor{})
}
// ColumnRequirementAdvisor is the advisor checking for column requirement.
@@ -50,7 +50,7 @@ func (*ColumnRequirementAdvisor) Check(_ context.Context, checkCtx advisor.Conte
}
checker := &columnRequirementChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
requiredColumns: requiredColumns,
tables: make(tableState),
line: make(map[string]int),
diff --git a/backend/plugin/advisor/tidb/advisor_column_set_default_for_not_null.go b/backend/plugin/advisor/tidb/advisor_column_set_default_for_not_null.go
index 52840eeefb..a2f153205a 100644
--- a/backend/plugin/advisor/tidb/advisor_column_set_default_for_not_null.go
+++ b/backend/plugin/advisor/tidb/advisor_column_set_default_for_not_null.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnSetDefaultForNotNull, &ColumnSetDefaultForNotNullAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL, &ColumnSetDefaultForNotNullAdvisor{})
}
// ColumnSetDefaultForNotNullAdvisor is the advisor checking for set default value for not null column.
@@ -42,7 +42,7 @@ func (*ColumnSetDefaultForNotNullAdvisor) Check(_ context.Context, checkCtx advi
}
checker := &columnSetDefaultForNotNullChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_column_type_disallow_list.go b/backend/plugin/advisor/tidb/advisor_column_type_disallow_list.go
index 350a9a4da1..1cee6d6952 100644
--- a/backend/plugin/advisor/tidb/advisor_column_type_disallow_list.go
+++ b/backend/plugin/advisor/tidb/advisor_column_type_disallow_list.go
@@ -22,7 +22,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnTypeDisallowList, &ColumnTypeDisallowListAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST, &ColumnTypeDisallowListAdvisor{})
}
// ColumnTypeDisallowListAdvisor is the advisor checking for column type restriction.
@@ -47,7 +47,7 @@ func (*ColumnTypeDisallowListAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &columnTypeDisallowListChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
typeRestriction: make(map[string]bool),
}
for _, tp := range paylaod.List {
diff --git a/backend/plugin/advisor/tidb/advisor_database_drop_empty_db.go b/backend/plugin/advisor/tidb/advisor_database_drop_empty_db.go
index 34b4a82e46..d15daadb84 100644
--- a/backend/plugin/advisor/tidb/advisor_database_drop_empty_db.go
+++ b/backend/plugin/advisor/tidb/advisor_database_drop_empty_db.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleDropEmptyDatabase, &DatabaseAllowDropIfEmptyAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE, &DatabaseAllowDropIfEmptyAdvisor{})
}
// DatabaseAllowDropIfEmptyAdvisor is the advisor checking the MySQLDatabaseAllowDropIfEmpty rule.
@@ -42,7 +42,7 @@ func (*DatabaseAllowDropIfEmptyAdvisor) Check(_ context.Context, checkCtx adviso
checker := &allowDropEmptyDBChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
originalMetadata: checkCtx.OriginalMetadata,
}
for _, stmtNode := range root {
diff --git a/backend/plugin/advisor/tidb/advisor_index_key_number_limit.go b/backend/plugin/advisor/tidb/advisor_index_key_number_limit.go
index dba1a8cbae..9ff6370f76 100644
--- a/backend/plugin/advisor/tidb/advisor_index_key_number_limit.go
+++ b/backend/plugin/advisor/tidb/advisor_index_key_number_limit.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIndexKeyNumberLimit, &IndexKeyNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, &IndexKeyNumberLimitAdvisor{})
}
// IndexKeyNumberLimitAdvisor is the advisor checking for index key number limit.
@@ -46,7 +46,7 @@ func (*IndexKeyNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.Con
}
checker := &indexKeyNumberLimitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
max: payload.Number,
}
diff --git a/backend/plugin/advisor/tidb/advisor_index_no_duplicate_column.go b/backend/plugin/advisor/tidb/advisor_index_no_duplicate_column.go
index 349ac2c36b..975072745b 100644
--- a/backend/plugin/advisor/tidb/advisor_index_no_duplicate_column.go
+++ b/backend/plugin/advisor/tidb/advisor_index_no_duplicate_column.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIndexNoDuplicateColumn, &IndexNoDuplicateColumnAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN, &IndexNoDuplicateColumnAdvisor{})
}
// IndexNoDuplicateColumnAdvisor is the advisor checking for no duplicate columns in index.
@@ -42,7 +42,7 @@ func (*IndexNoDuplicateColumnAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &indexNoDuplicateColumnChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_index_pk_type.go b/backend/plugin/advisor/tidb/advisor_index_pk_type.go
index 9d7c27456a..88fe8f8084 100644
--- a/backend/plugin/advisor/tidb/advisor_index_pk_type.go
+++ b/backend/plugin/advisor/tidb/advisor_index_pk_type.go
@@ -25,7 +25,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIndexPKTypeLimit, &IndexPkTypeAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT, &IndexPkTypeAdvisor{})
}
// IndexPkTypeAdvisor is the advisor checking for correct type of PK.
@@ -46,7 +46,7 @@ func (*IndexPkTypeAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
}
checker := &indexPkTypeChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
line: make(map[string]int),
originalMetadata: checkCtx.OriginalMetadata,
tablesNewColumns: make(map[string]columnNameToColumnDef),
diff --git a/backend/plugin/advisor/tidb/advisor_index_primary_key_type_allowlist.go b/backend/plugin/advisor/tidb/advisor_index_primary_key_type_allowlist.go
index 3a6566ce4a..251e5537b1 100644
--- a/backend/plugin/advisor/tidb/advisor_index_primary_key_type_allowlist.go
+++ b/backend/plugin/advisor/tidb/advisor_index_primary_key_type_allowlist.go
@@ -25,7 +25,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist, &IndexPrimaryKeyTypeAllowlistAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST, &IndexPrimaryKeyTypeAllowlistAdvisor{})
}
// IndexPrimaryKeyTypeAllowlistAdvisor is the advisor checking for primary key type allowlist.
@@ -54,7 +54,7 @@ func (*IndexPrimaryKeyTypeAllowlistAdvisor) Check(_ context.Context, checkCtx ad
}
checker := &indexPrimaryKeyTypeAllowlistChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
allowlist: allowlist,
originalMetadata: checkCtx.OriginalMetadata,
tablesNewColumns: make(map[string]columnNameToColumnDef),
diff --git a/backend/plugin/advisor/tidb/advisor_index_total_number_limit.go b/backend/plugin/advisor/tidb/advisor_index_total_number_limit.go
index 025101f58f..43191f8fb4 100644
--- a/backend/plugin/advisor/tidb/advisor_index_total_number_limit.go
+++ b/backend/plugin/advisor/tidb/advisor_index_total_number_limit.go
@@ -23,7 +23,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIndexTotalNumberLimit, &IndexTotalNumberLimitAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT, &IndexTotalNumberLimitAdvisor{})
}
// IndexTotalNumberLimitAdvisor is the advisor checking for index total number limit.
@@ -48,7 +48,7 @@ func (*IndexTotalNumberLimitAdvisor) Check(_ context.Context, checkCtx advisor.C
}
checker := &indexTotalNumberLimitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
max: payload.Number,
lineForTable: make(map[string]int),
finalMetadata: checkCtx.FinalMetadata,
diff --git a/backend/plugin/advisor/tidb/advisor_index_type_no_blob.go b/backend/plugin/advisor/tidb/advisor_index_type_no_blob.go
index bb695a2de7..8794a15c3f 100644
--- a/backend/plugin/advisor/tidb/advisor_index_type_no_blob.go
+++ b/backend/plugin/advisor/tidb/advisor_index_type_no_blob.go
@@ -26,7 +26,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIndexTypeNoBlob, &IndexTypeNoBlobAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB, &IndexTypeNoBlobAdvisor{})
}
// IndexTypeNoBlobAdvisor is the advisor checking for index type no blob.
@@ -47,7 +47,7 @@ func (*IndexTypeNoBlobAdvisor) Check(_ context.Context, checkCtx advisor.Context
}
checker := &indexTypeNoBlobChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
originalMetadata: checkCtx.OriginalMetadata,
tablesNewColumns: make(map[string]columnNameToColumnDef),
}
diff --git a/backend/plugin/advisor/tidb/advisor_insert_disallow_order_by_rand.go b/backend/plugin/advisor/tidb/advisor_insert_disallow_order_by_rand.go
index 344330d82c..fd5d1eafe6 100644
--- a/backend/plugin/advisor/tidb/advisor_insert_disallow_order_by_rand.go
+++ b/backend/plugin/advisor/tidb/advisor_insert_disallow_order_by_rand.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementInsertDisallowOrderByRand, &InsertDisallowOrderByRandAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, &InsertDisallowOrderByRandAdvisor{})
}
// InsertDisallowOrderByRandAdvisor is the advisor checking for to disallow order by rand in INSERT statements.
@@ -41,7 +41,7 @@ func (*InsertDisallowOrderByRandAdvisor) Check(_ context.Context, checkCtx advis
}
checker := &insertDisallowOrderByRandChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_insert_must_specify_column.go b/backend/plugin/advisor/tidb/advisor_insert_must_specify_column.go
index bbd3b30cec..8f8ff9e209 100644
--- a/backend/plugin/advisor/tidb/advisor_insert_must_specify_column.go
+++ b/backend/plugin/advisor/tidb/advisor_insert_must_specify_column.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementInsertMustSpecifyColumn, &InsertMustSpecifyColumnAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, &InsertMustSpecifyColumnAdvisor{})
}
// InsertMustSpecifyColumnAdvisor is the advisor checking for to enforce column specified.
@@ -41,7 +41,7 @@ func (*InsertMustSpecifyColumnAdvisor) Check(_ context.Context, checkCtx advisor
}
checker := &insertMustSpecifyColumnChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_migration_compatibility.go b/backend/plugin/advisor/tidb/advisor_migration_compatibility.go
index db80f96366..934df27f2e 100644
--- a/backend/plugin/advisor/tidb/advisor_migration_compatibility.go
+++ b/backend/plugin/advisor/tidb/advisor_migration_compatibility.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleSchemaBackwardCompatibility, &CompatibilityAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY, &CompatibilityAdvisor{})
}
// CompatibilityAdvisor is the advisor checking for schema backward compatibility.
@@ -40,7 +40,7 @@ func (*CompatibilityAdvisor) Check(_ context.Context, checkCtx advisor.Context)
c := &compatibilityChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmtNode := range root {
(stmtNode).Accept(c)
diff --git a/backend/plugin/advisor/tidb/advisor_naming_auto_increment_column.go b/backend/plugin/advisor/tidb/advisor_naming_auto_increment_column.go
index 56db09a6e4..c4c8b8e665 100644
--- a/backend/plugin/advisor/tidb/advisor_naming_auto_increment_column.go
+++ b/backend/plugin/advisor/tidb/advisor_naming_auto_increment_column.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleAutoIncrementColumnNaming, &NamingAutoIncrementColumnAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT, &NamingAutoIncrementColumnAdvisor{})
}
// NamingAutoIncrementColumnAdvisor is the advisor checking for auto-increment naming convention.
@@ -46,7 +46,7 @@ func (*NamingAutoIncrementColumnAdvisor) Check(_ context.Context, checkCtx advis
}
checker := &namingAutoIncrementColumnChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
maxLength: maxLength,
}
diff --git a/backend/plugin/advisor/tidb/advisor_naming_column.go b/backend/plugin/advisor/tidb/advisor_naming_column.go
index 4d07be7c1b..d3ed4ca6a3 100644
--- a/backend/plugin/advisor/tidb/advisor_naming_column.go
+++ b/backend/plugin/advisor/tidb/advisor_naming_column.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleColumnNaming, &NamingColumnConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_NAMING_COLUMN, &NamingColumnConventionAdvisor{})
}
// NamingColumnConventionAdvisor is the advisor checking for column naming convention.
@@ -44,7 +44,7 @@ func (*NamingColumnConventionAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &namingColumnConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
maxLength: maxLength,
}
diff --git a/backend/plugin/advisor/tidb/advisor_naming_foreign_key_convention.go b/backend/plugin/advisor/tidb/advisor_naming_foreign_key_convention.go
index 9b7dab7a56..57d1839f6b 100644
--- a/backend/plugin/advisor/tidb/advisor_naming_foreign_key_convention.go
+++ b/backend/plugin/advisor/tidb/advisor_naming_foreign_key_convention.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleFKNaming, &NamingFKConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_NAMING_INDEX_FK, &NamingFKConventionAdvisor{})
}
// NamingFKConventionAdvisor is the advisor checking for foreign key naming convention.
@@ -39,13 +39,13 @@ func (*NamingFKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
checker := &namingFKConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
maxLength: maxLength,
templateList: templateList,
diff --git a/backend/plugin/advisor/tidb/advisor_naming_index_convention.go b/backend/plugin/advisor/tidb/advisor_naming_index_convention.go
index 6238c7bc6f..04f27e7880 100644
--- a/backend/plugin/advisor/tidb/advisor_naming_index_convention.go
+++ b/backend/plugin/advisor/tidb/advisor_naming_index_convention.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleIDXNaming, &NamingIndexConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_NAMING_INDEX_IDX, &NamingIndexConventionAdvisor{})
}
// NamingIndexConventionAdvisor is the advisor checking for index naming convention.
@@ -41,13 +41,13 @@ func (*NamingIndexConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
checker := &namingIndexConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
maxLength: maxLength,
templateList: templateList,
diff --git a/backend/plugin/advisor/tidb/advisor_naming_table.go b/backend/plugin/advisor/tidb/advisor_naming_table.go
index 9075fd3bca..69d0f6e556 100644
--- a/backend/plugin/advisor/tidb/advisor_naming_table.go
+++ b/backend/plugin/advisor/tidb/advisor_naming_table.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleTableNaming, &NamingTableConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_NAMING_TABLE, &NamingTableConventionAdvisor{})
}
// NamingTableConventionAdvisor is the advisor checking for table naming convention.
@@ -44,7 +44,7 @@ func (*NamingTableConventionAdvisor) Check(_ context.Context, checkCtx advisor.C
}
checker := &namingTableConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
maxLength: maxLength,
}
diff --git a/backend/plugin/advisor/tidb/advisor_naming_unique_key_convention.go b/backend/plugin/advisor/tidb/advisor_naming_unique_key_convention.go
index 4258186112..e086fddd20 100644
--- a/backend/plugin/advisor/tidb/advisor_naming_unique_key_convention.go
+++ b/backend/plugin/advisor/tidb/advisor_naming_unique_key_convention.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleUKNaming, &NamingUKConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_NAMING_INDEX_UK, &NamingUKConventionAdvisor{})
}
// NamingUKConventionAdvisor is the advisor checking for unique key naming convention.
@@ -40,13 +40,13 @@ func (*NamingUKConventionAdvisor) Check(_ context.Context, checkCtx advisor.Cont
return nil, err
}
- format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(advisor.SQLReviewRuleType(checkCtx.Rule.Type), checkCtx.Rule.Payload)
+ format, templateList, maxLength, err := advisor.UnmarshalNamingRulePayloadAsTemplate(storepb.SQLReviewRule_Type(checkCtx.Rule.Type), checkCtx.Rule.Payload)
if err != nil {
return nil, err
}
checker := &namingUKConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
maxLength: maxLength,
templateList: templateList,
diff --git a/backend/plugin/advisor/tidb/advisor_statement_dml_dry_run.go b/backend/plugin/advisor/tidb/advisor_statement_dml_dry_run.go
index 4e06839786..4bdac09772 100644
--- a/backend/plugin/advisor/tidb/advisor_statement_dml_dry_run.go
+++ b/backend/plugin/advisor/tidb/advisor_statement_dml_dry_run.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementDMLDryRun, &StatementDmlDryRunAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, &StatementDmlDryRunAdvisor{})
}
// StatementDmlDryRunAdvisor is the advisor checking for DML dry run.
@@ -42,7 +42,7 @@ func (*StatementDmlDryRunAdvisor) Check(ctx context.Context, checkCtx advisor.Co
}
checker := &statementDmlDryRunChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
driver: checkCtx.Driver,
ctx: ctx,
}
diff --git a/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.go b/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.go
index bcf9c33b29..dd4bc9bd29 100644
--- a/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.go
+++ b/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementMaximumLimitValue, &StatementMaximumLimitValueAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})
}
// StatementMaximumLimitValueAdvisor is the advisor checking for LIMIT maximum value.
@@ -47,7 +47,7 @@ func (*StatementMaximumLimitValueAdvisor) Check(_ context.Context, checkCtx advi
checker := &statementMaximumLimitValueChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
limitMaxValue: payload.Number,
}
diff --git a/backend/plugin/advisor/tidb/advisor_statement_merge_alter_table.go b/backend/plugin/advisor/tidb/advisor_statement_merge_alter_table.go
index bccc1c9c95..63fe0852bd 100644
--- a/backend/plugin/advisor/tidb/advisor_statement_merge_alter_table.go
+++ b/backend/plugin/advisor/tidb/advisor_statement_merge_alter_table.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementMergeAlterTable, &StatementMergeAlterTableAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE, &StatementMergeAlterTableAdvisor{})
}
// StatementMergeAlterTableAdvisor is the advisor checking for merging ALTER TABLE statements.
@@ -42,7 +42,7 @@ func (*StatementMergeAlterTableAdvisor) Check(_ context.Context, checkCtx adviso
}
checker := &statementMergeAlterTableChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
tableMap: make(map[string]tableStatement),
}
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_disallow_commit.go b/backend/plugin/advisor/tidb/advisor_stmt_disallow_commit.go
index b86edd3237..fced3237b7 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_disallow_commit.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_disallow_commit.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementDisallowCommit, &StatementDisallowCommitAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT, &StatementDisallowCommitAdvisor{})
}
// StatementDisallowCommitAdvisor is the advisor checking for index type no blob.
@@ -41,7 +41,7 @@ func (*StatementDisallowCommitAdvisor) Check(_ context.Context, checkCtx advisor
}
checker := &statementDisallowCommitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_disallow_limit.go b/backend/plugin/advisor/tidb/advisor_stmt_disallow_limit.go
index 735f468317..1e0cf7a295 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_disallow_limit.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_disallow_limit.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementDisallowLimit, &StatementDisallowLimitAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT, &StatementDisallowLimitAdvisor{})
}
// StatementDisallowLimitAdvisor is the advisor checking for no LIMIT clause in INSERT/UPDATE statement.
@@ -41,7 +41,7 @@ func (*StatementDisallowLimitAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &statementDisallowLimitChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_disallow_order_by.go b/backend/plugin/advisor/tidb/advisor_stmt_disallow_order_by.go
index 4d3114c831..904592e8a2 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_disallow_order_by.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_disallow_order_by.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementDisallowOrderBy, &DisallowOrderByAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY, &DisallowOrderByAdvisor{})
}
// DisallowOrderByAdvisor is the advisor checking for no ORDER BY clause in DELETE/UPDATE statements.
@@ -41,7 +41,7 @@ func (*DisallowOrderByAdvisor) Check(_ context.Context, checkCtx advisor.Context
}
checker := &disallowOrderByChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_no_leading_wildcard_like.go b/backend/plugin/advisor/tidb/advisor_stmt_no_leading_wildcard_like.go
index d544293ec4..99f398e882 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_no_leading_wildcard_like.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_no_leading_wildcard_like.go
@@ -23,7 +23,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementNoLeadingWildcardLike, &NoLeadingWildcardLikeAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, &NoLeadingWildcardLikeAdvisor{})
}
// NoLeadingWildcardLikeAdvisor is the advisor checking for no leading wildcard LIKE.
@@ -53,7 +53,7 @@ func (*NoLeadingWildcardLikeAdvisor) Check(_ context.Context, checkCtx advisor.C
checker.adviceList = append(checker.adviceList, &storepb.Advice{
Status: checker.level,
Code: code.StatementLeadingWildcardLike.Int32(),
- Title: string(checkCtx.Rule.Type),
+ Title: checkCtx.Rule.Type.String(),
Content: fmt.Sprintf("\"%s\" uses leading wildcard LIKE", checker.text),
StartPosition: common.ConvertANTLRLineToPosition(stmtNode.OriginTextPosition()),
})
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_no_select_all.go b/backend/plugin/advisor/tidb/advisor_stmt_no_select_all.go
index 2c071221f7..e79b51a8f8 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_no_select_all.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_no_select_all.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementNoSelectAll, &NoSelectAllAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL, &NoSelectAllAdvisor{})
}
// NoSelectAllAdvisor is the advisor checking for no "select *".
@@ -39,7 +39,7 @@ func (*NoSelectAllAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([
}
checker := &noSelectAllChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmtNode := range root {
checker.text = stmtNode.Text()
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_select.go b/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_select.go
index 1b5d809d8b..dc099944db 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_select.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_select.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementRequireWhereForSelect, &WhereRequirementForSelectAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT, &WhereRequirementForSelectAdvisor{})
}
// WhereRequirementForSelectAdvisor is the advisor checking for the WHERE clause requirement for SELECT statements.
@@ -39,7 +39,7 @@ func (*WhereRequirementForSelectAdvisor) Check(_ context.Context, checkCtx advis
}
checker := &whereRequirementForSelectChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmtNode := range root {
checker.text = stmtNode.Text()
diff --git a/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_update_delete.go b/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_update_delete.go
index d6f3441e04..2b36d6bc52 100644
--- a/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_update_delete.go
+++ b/backend/plugin/advisor/tidb/advisor_stmt_where_required_for_update_delete.go
@@ -18,7 +18,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleStatementRequireWhereForUpdateDelete, &WhereRequirementForUpdateDeleteAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE, &WhereRequirementForUpdateDeleteAdvisor{})
}
// WhereRequirementForUpdateDeleteAdvisor is the advisor checking for the WHERE clause requirement for UPDATE and DELETE statements.
@@ -39,7 +39,7 @@ func (*WhereRequirementForUpdateDeleteAdvisor) Check(_ context.Context, checkCtx
}
checker := &whereRequirementForUpdateDeleteChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmtNode := range root {
checker.text = stmtNode.Text()
diff --git a/backend/plugin/advisor/tidb/advisor_table_comment_convention.go b/backend/plugin/advisor/tidb/advisor_table_comment_convention.go
index 94ae92ecea..520379e054 100644
--- a/backend/plugin/advisor/tidb/advisor_table_comment_convention.go
+++ b/backend/plugin/advisor/tidb/advisor_table_comment_convention.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleTableCommentConvention, &TableCommentConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_TABLE_COMMENT, &TableCommentConventionAdvisor{})
}
// TableCommentConventionAdvisor is the advisor checking for table comment convention.
@@ -45,7 +45,7 @@ func (*TableCommentConventionAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &tableCommentConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
payload: payload,
}
diff --git a/backend/plugin/advisor/tidb/advisor_table_disallow_partition.go b/backend/plugin/advisor/tidb/advisor_table_disallow_partition.go
index 2abb002ca2..176c2d07ad 100644
--- a/backend/plugin/advisor/tidb/advisor_table_disallow_partition.go
+++ b/backend/plugin/advisor/tidb/advisor_table_disallow_partition.go
@@ -21,7 +21,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleTableDisallowPartition, &TableDisallowPartitionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION, &TableDisallowPartitionAdvisor{})
}
// TableDisallowPartitionAdvisor is the advisor checking for disallow table partition.
@@ -42,7 +42,7 @@ func (*TableDisallowPartitionAdvisor) Check(_ context.Context, checkCtx advisor.
}
checker := &tableDisallowPartitionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmt := range stmtList {
diff --git a/backend/plugin/advisor/tidb/advisor_table_drop_naming_convention.go b/backend/plugin/advisor/tidb/advisor_table_drop_naming_convention.go
index 5c78e3619a..501eb2a402 100644
--- a/backend/plugin/advisor/tidb/advisor_table_drop_naming_convention.go
+++ b/backend/plugin/advisor/tidb/advisor_table_drop_naming_convention.go
@@ -20,7 +20,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleTableDropNamingConvention, &TableDropNamingConventionAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, &TableDropNamingConventionAdvisor{})
}
// TableDropNamingConventionAdvisor is the advisor checking the MySQLTableDropNamingConvention rule.
@@ -46,7 +46,7 @@ func (*TableDropNamingConventionAdvisor) Check(_ context.Context, checkCtx advis
checker := &namingDropTableConventionChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
format: format,
}
for _, stmtNode := range root {
diff --git a/backend/plugin/advisor/tidb/advisor_table_no_fk.go b/backend/plugin/advisor/tidb/advisor_table_no_fk.go
index 9c041f3679..d6214d759e 100644
--- a/backend/plugin/advisor/tidb/advisor_table_no_fk.go
+++ b/backend/plugin/advisor/tidb/advisor_table_no_fk.go
@@ -19,7 +19,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleTableNoFK, &TableNoFKAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, &TableNoFKAdvisor{})
}
// TableNoFKAdvisor is the advisor checking table disallow foreign key.
@@ -40,7 +40,7 @@ func (*TableNoFKAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*
checker := &tableNoFKChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
}
for _, stmtNode := range root {
(stmtNode).Accept(checker)
diff --git a/backend/plugin/advisor/tidb/advisor_table_require_pk.go b/backend/plugin/advisor/tidb/advisor_table_require_pk.go
index 05ea79a309..e73196907a 100644
--- a/backend/plugin/advisor/tidb/advisor_table_require_pk.go
+++ b/backend/plugin/advisor/tidb/advisor_table_require_pk.go
@@ -24,7 +24,7 @@ var (
)
func init() {
- advisor.Register(storepb.Engine_TIDB, advisor.SchemaRuleTableRequirePK, &TableRequirePKAdvisor{})
+ advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_TABLE_REQUIRE_PK, &TableRequirePKAdvisor{})
}
// TableRequirePKAdvisor is the advisor checking table requires PK.
@@ -45,7 +45,7 @@ func (*TableRequirePKAdvisor) Check(_ context.Context, checkCtx advisor.Context)
}
checker := &tableRequirePKChecker{
level: level,
- title: string(checkCtx.Rule.Type),
+ title: checkCtx.Rule.Type.String(),
tables: make(tablePK),
line: make(map[string]int),
originalMetadata: checkCtx.OriginalMetadata,
diff --git a/backend/plugin/advisor/tidb/test/column_auto_increment_initial_value.yaml b/backend/plugin/advisor/tidb/test/column_auto_increment_initial_value.yaml
index 929710f0a4..267ff8356f 100644
--- a/backend/plugin/advisor/tidb/test/column_auto_increment_initial_value.yaml
+++ b/backend/plugin/advisor/tidb/test/column_auto_increment_initial_value.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 416
- title: column.auto-increment-initial-value
+ title: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
content: The initial auto-increment value in table `t` is 2, which doesn't equal 20
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/column_auto_increment_must_integer.yaml b/backend/plugin/advisor/tidb/test/column_auto_increment_must_integer.yaml
index 8eaecf3328..871127b7a6 100644
--- a/backend/plugin/advisor/tidb/test/column_auto_increment_must_integer.yaml
+++ b/backend/plugin/advisor/tidb/test/column_auto_increment_must_integer.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
@@ -44,7 +44,7 @@
want:
- status: 2
code: 410
- title: column.auto-increment-must-integer
+ title: COLUMN_AUTO_INCREMENT_MUST_INTEGER
content: Auto-increment column `t`.`a` requires integer type
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_auto_increment_must_unsigned.yaml b/backend/plugin/advisor/tidb/test/column_auto_increment_must_unsigned.yaml
index de64d2965b..ce45a705c8 100644
--- a/backend/plugin/advisor/tidb/test/column_auto_increment_must_unsigned.yaml
+++ b/backend/plugin/advisor/tidb/test/column_auto_increment_must_unsigned.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 2
@@ -44,7 +44,7 @@
want:
- status: 2
code: 417
- title: column.auto-increment-must-unsigned
+ title: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
content: Auto-increment column `t`.`a` is not UNSIGNED type
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_comment.yaml b/backend/plugin/advisor/tidb/test/column_comment.yaml
index 0f1d9f0894..aeb6eb4c37 100644
--- a/backend/plugin/advisor/tidb/test/column_comment.yaml
+++ b/backend/plugin/advisor/tidb/test/column_comment.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`a` comment should be within 10 characters
startposition:
line: 2
@@ -17,7 +17,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 3
@@ -25,7 +25,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`c` requires comments
startposition:
line: 4
@@ -38,7 +38,7 @@
want:
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -51,7 +51,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`a` comment should be within 10 characters
startposition:
line: 1
@@ -59,7 +59,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -72,7 +72,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`b` comment should be within 10 characters
startposition:
line: 1
@@ -80,7 +80,7 @@
endposition: null
- status: 2
code: 1032
- title: column.comment
+ title: COLUMN_COMMENT
content: Column `t`.`b` requires comments
startposition:
line: 2
@@ -93,7 +93,7 @@
want:
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`b` comment should be within 10 characters
startposition:
line: 1
@@ -101,7 +101,7 @@
endposition: null
- status: 2
code: 1301
- title: column.comment
+ title: COLUMN_COMMENT
content: The length of column `t`.`b` comment should be within 10 characters
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_current_time_count_limit.yaml b/backend/plugin/advisor/tidb/test/column_current_time_count_limit.yaml
index 0a44bc65e0..fdfb13f2c5 100644
--- a/backend/plugin/advisor/tidb/test/column_current_time_count_limit.yaml
+++ b/backend/plugin/advisor/tidb/test/column_current_time_count_limit.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 418
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `t` has 3 DEFAULT CURRENT_TIMESTAMP() columns. The count greater than 2.
startposition:
line: 5
@@ -25,7 +25,7 @@
want:
- status: 2
code: 419
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `t` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.
startposition:
line: 4
@@ -38,7 +38,7 @@
want:
- status: 2
code: 419
- title: column.current-time-count-limit
+ title: COLUMN_CURRENT_TIME_COUNT_LIMIT
content: Table `tech_book` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_disallow_change.yaml b/backend/plugin/advisor/tidb/test/column_disallow_change.yaml
index 699b64ca7d..d2826aeb62 100644
--- a/backend/plugin/advisor/tidb/test/column_disallow_change.yaml
+++ b/backend/plugin/advisor/tidb/test/column_disallow_change.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 406
- title: column.disallow-change
+ title: COLUMN_DISALLOW_CHANGE
content: '"ALTER TABLE t CHANGE COLUMN b a int" contains CHANGE COLUMN statement'
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_disallow_change_type.yaml b/backend/plugin/advisor/tidb/test/column_disallow_change_type.yaml
index b5dad841bd..45b87eacc6 100644
--- a/backend/plugin/advisor/tidb/test/column_disallow_change_type.yaml
+++ b/backend/plugin/advisor/tidb/test/column_disallow_change_type.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id INTEGER UNSIGNED" changes column type'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book MODIFY id bigint" changes column type'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 403
- title: column.disallow-change-type
+ title: COLUMN_DISALLOW_CHANGE_TYPE
content: '"ALTER TABLE tech_book CHANGE name uname varchar(20)" changes column type'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/column_disallow_changing_order.yaml b/backend/plugin/advisor/tidb/test/column_disallow_changing_order.yaml
index 28819131c6..711cd57bae 100644
--- a/backend/plugin/advisor/tidb/test/column_disallow_changing_order.yaml
+++ b/backend/plugin/advisor/tidb/test/column_disallow_changing_order.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t MODIFY COLUMN a int FIRST" changes column order'
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t CHANGE COLUMN a1 a int FIRST" changes column order'
startposition:
line: 2
@@ -35,7 +35,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t MODIFY COLUMN a int AFTER b" changes column order'
startposition:
line: 2
@@ -48,7 +48,7 @@
want:
- status: 2
code: 407
- title: column.disallow-changing-order
+ title: COLUMN_DISALLOW_CHANGING_ORDER
content: '"ALTER TABLE t CHANGE COLUMN a1 a int AFTER b" changes column order'
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_disallow_drop_in_index.yaml b/backend/plugin/advisor/tidb/test/column_disallow_drop_in_index.yaml
index 28ade96008..83de8a462c 100644
--- a/backend/plugin/advisor/tidb/test/column_disallow_drop_in_index.yaml
+++ b/backend/plugin/advisor/tidb/test/column_disallow_drop_in_index.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`b` cannot drop index column'
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`c` cannot drop index column'
startposition:
line: 2
@@ -41,7 +41,7 @@
want:
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`a` cannot drop index column'
startposition:
line: 2
@@ -49,9 +49,9 @@
endposition: null
- status: 2
code: 424
- title: column.disallow-drop-in-index
+ title: COLUMN_DISALLOW_DROP_IN_INDEX
content: '`t`.`c` cannot drop index column'
startposition:
line: 3
column: 0
- endposition: null
+ endposition: null
\ No newline at end of file
diff --git a/backend/plugin/advisor/tidb/test/column_disallow_set_charset.yaml b/backend/plugin/advisor/tidb/test/column_disallow_set_charset.yaml
index d490f3db78..d3ec85a603 100644
--- a/backend/plugin/advisor/tidb/test/column_disallow_set_charset.yaml
+++ b/backend/plugin/advisor/tidb/test/column_disallow_set_charset.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "CREATE TABLE t(a varchar(20) CHARSET ascii)" does
startposition:
line: 1
@@ -20,7 +20,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book ADD COLUMN a varchar(20) CHARSET ascii" does
startposition:
line: 1
@@ -31,7 +31,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book MODIFY COLUMN id varchar(20) CHARSET ascii" does
startposition:
line: 1
@@ -42,7 +42,7 @@
want:
- status: 2
code: 414
- title: column.disallow-set-charset
+ title: COLUMN_DISALLOW_SET_CHARSET
content: Disallow set column charset but "ALTER TABLE tech_book CHANGE COLUMN name name varchar(20) CHARSET ascii" does
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/column_maximum_character_length.yaml b/backend/plugin/advisor/tidb/test/column_maximum_character_length.yaml
index 67f00e6289..253d9ee34a 100644
--- a/backend/plugin/advisor/tidb/test/column_maximum_character_length.yaml
+++ b/backend/plugin/advisor/tidb/test/column_maximum_character_length.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `name` is bigger than 20, please use VARCHAR instead
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `name_2` is bigger than 20, please use VARCHAR instead
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `name` is bigger than 20, please use VARCHAR instead
startposition:
line: 1
@@ -40,7 +40,7 @@
want:
- status: 2
code: 415
- title: column.maximum-character-length
+ title: COLUMN_MAXIMUM_CHARACTER_LENGTH
content: The length of the CHAR column `name` is bigger than 20, please use VARCHAR instead
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/column_no_null.yaml b/backend/plugin/advisor/tidb/test/column_no_null.yaml
index c2196d9161..7eed9262dd 100644
--- a/backend/plugin/advisor/tidb/test/column_no_null.yaml
+++ b/backend/plugin/advisor/tidb/test/column_no_null.yaml
@@ -6,7 +6,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`id` cannot have NULL value'
startposition:
line: 2
@@ -14,7 +14,7 @@
endposition: null
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 3
@@ -25,7 +25,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 1
@@ -51,7 +51,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`id` cannot have NULL value'
startposition:
line: 2
@@ -68,7 +68,7 @@
want:
- status: 2
code: 402
- title: column.no-null
+ title: COLUMN_NO_NULL
content: '`book`.`name` cannot have NULL value'
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_require_default.yaml b/backend/plugin/advisor/tidb/test/column_require_default.yaml
index 0da74b7784..d9df699ac0 100644
--- a/backend/plugin/advisor/tidb/test/column_require_default.yaml
+++ b/backend/plugin/advisor/tidb/test/column_require_default.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `t`.`b` doesn't have DEFAULT.
startposition:
line: 3
@@ -25,7 +25,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `t`.`a` doesn't have DEFAULT.
startposition:
line: 2
@@ -39,7 +39,7 @@
want:
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `tech_book`.`b` doesn't have DEFAULT.
startposition:
line: 2
@@ -47,7 +47,7 @@
endposition: null
- status: 2
code: 420
- title: column.require-default
+ title: COLUMN_REQUIRE_DEFAULT
content: Column `tech_book`.`a` doesn't have DEFAULT.
startposition:
line: 3
diff --git a/backend/plugin/advisor/tidb/test/column_required.yaml b/backend/plugin/advisor/tidb/test/column_required.yaml
index 87dd89fbd0..6a71e65c51 100644
--- a/backend/plugin/advisor/tidb/test/column_required.yaml
+++ b/backend/plugin/advisor/tidb/test/column_required.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: created_ts, creator_id, updated_ts, updater_id'
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 7
@@ -56,7 +56,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 7
@@ -83,7 +83,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 7
@@ -110,7 +110,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: updater_id'
startposition:
line: 5
@@ -139,7 +139,7 @@
want:
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `book` requires columns: creator_id'
startposition:
line: 5
@@ -147,7 +147,7 @@
endposition: null
- status: 2
code: 401
- title: column.required
+ title: COLUMN_REQUIRED
content: 'Table `student` requires columns: creator_id, updater_id'
startposition:
line: 9
diff --git a/backend/plugin/advisor/tidb/test/column_set_default_for_not_null.yaml b/backend/plugin/advisor/tidb/test/column_set_default_for_not_null.yaml
index 8ca4b06ff2..e9c00294c6 100644
--- a/backend/plugin/advisor/tidb/test/column_set_default_for_not_null.yaml
+++ b/backend/plugin/advisor/tidb/test/column_set_default_for_not_null.yaml
@@ -16,7 +16,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -39,7 +39,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -52,7 +52,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
@@ -73,7 +73,7 @@
want:
- status: 2
code: 404
- title: column.set-default-for-not-null
+ title: COLUMN_SET_DEFAULT_FOR_NOT_NULL
content: Column `book`.`id` is NOT NULL but doesn't have DEFAULT
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/column_type_disallow_list.yaml b/backend/plugin/advisor/tidb/test/column_type_disallow_list.yaml
index 438593123a..4bf03d6d10 100644
--- a/backend/plugin/advisor/tidb/test/column_type_disallow_list.yaml
+++ b/backend/plugin/advisor/tidb/test/column_type_disallow_list.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 1
@@ -18,7 +18,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 411
- title: column.type-disallow-list
+ title: COLUMN_TYPE_DISALLOW_LIST
content: Disallow column type JSON but column `t`.`a` is
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/database_drop_empty_database.yaml b/backend/plugin/advisor/tidb/test/database_drop_empty_database.yaml
index df7d4729cc..96cf756d77 100644
--- a/backend/plugin/advisor/tidb/test/database_drop_empty_database.yaml
+++ b/backend/plugin/advisor/tidb/test/database_drop_empty_database.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 701
- title: database.drop-empty-database
+ title: DATABASE_DROP_EMPTY_DATABASE
content: Database `test` is not allowed to drop if not empty
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/engine_mysql_use_innodb.yaml b/backend/plugin/advisor/tidb/test/engine_mysql_use_innodb.yaml
index 83b551d698..5aae5e3a82 100644
--- a/backend/plugin/advisor/tidb/test/engine_mysql_use_innodb.yaml
+++ b/backend/plugin/advisor/tidb/test/engine_mysql_use_innodb.yaml
@@ -18,7 +18,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: |-
"CREATE TABLE book(id int) ENGINE = CSV
;" doesn't use InnoDB engine
@@ -36,7 +36,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: |-
"ALTER TABLE tech_book ENGINE = CSV
;" doesn't use InnoDB engine
@@ -54,7 +54,7 @@
want:
- status: 2
code: 501
- title: engine.mysql.use-innodb
+ title: ENGINE_MYSQL_USE_INNODB
content: |-
"SET default_storage_engine=CSV
;" doesn't use InnoDB engine
diff --git a/backend/plugin/advisor/tidb/test/index_key_number_limit.yaml b/backend/plugin/advisor/tidb/test/index_key_number_limit.yaml
index f7f49d2a72..e5ef57e976 100644
--- a/backend/plugin/advisor/tidb/test/index_key_number_limit.yaml
+++ b/backend/plugin/advisor/tidb/test/index_key_number_limit.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `pk` in table `t` should be not greater than 5
startposition:
line: 4
@@ -22,7 +22,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `idx` in table `t` should be not greater than 5
startposition:
line: 2
@@ -35,7 +35,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `uk` in table `t` should be not greater than 5
startposition:
line: 2
@@ -48,7 +48,7 @@
want:
- status: 2
code: 802
- title: index.key-number-limit
+ title: INDEX_KEY_NUMBER_LIMIT
content: The number of index `uk` in table `t` should be not greater than 5
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/index_no_duplicate_column.yaml b/backend/plugin/advisor/tidb/test/index_no_duplicate_column.yaml
index 966c7a1e02..0f7c8c0896 100644
--- a/backend/plugin/advisor/tidb/test/index_no_duplicate_column.yaml
+++ b/backend/plugin/advisor/tidb/test/index_no_duplicate_column.yaml
@@ -8,7 +8,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 3
@@ -21,7 +21,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 2
@@ -34,7 +34,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: INDEX `idx_a` has duplicate column `t`.`a`
startposition:
line: 2
@@ -47,7 +47,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: PRIMARY KEY `pk_a` has duplicate column `t`.`a`
startposition:
line: 2
@@ -60,7 +60,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: UNIQUE KEY `uk_a` has duplicate column `t`.`a`
startposition:
line: 2
@@ -73,7 +73,7 @@
want:
- status: 2
code: 812
- title: index.no-duplicate-column
+ title: INDEX_NO_DUPLICATE_COLUMN
content: FOREIGN KEY `fk_a` has duplicate column `t`.`a`
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/index_pk_type_limit.yaml b/backend/plugin/advisor/tidb/test/index_pk_type_limit.yaml
index 2ce7e066b7..d20cf8b831 100644
--- a/backend/plugin/advisor/tidb/test/index_pk_type_limit.yaml
+++ b/backend/plugin/advisor/tidb/test/index_pk_type_limit.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 1
@@ -35,7 +35,7 @@
endposition: null
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id3` is varchar(5)
startposition:
line: 1
@@ -52,7 +52,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -69,7 +69,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -82,7 +82,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 2
@@ -90,7 +90,7 @@
endposition: null
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id3` is varchar(5)
startposition:
line: 2
@@ -111,7 +111,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -124,7 +124,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 2
@@ -132,7 +132,7 @@
endposition: null
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id3` is varchar(5)
startposition:
line: 2
@@ -153,7 +153,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id` is varchar(5)
startposition:
line: 2
@@ -170,7 +170,7 @@
want:
- status: 2
code: 803
- title: index.pk-type-limit
+ title: INDEX_PK_TYPE_LIMIT
content: Columns in primary key must be INT/BIGINT but `t`.`id2` is varchar(5)
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/index_primary_key_type_allowlist.yaml b/backend/plugin/advisor/tidb/test/index_primary_key_type_allowlist.yaml
index 6aaaaa429b..25e543e8e6 100644
--- a/backend/plugin/advisor/tidb/test/index_primary_key_type_allowlist.yaml
+++ b/backend/plugin/advisor/tidb/test/index_primary_key_type_allowlist.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -35,7 +35,7 @@
endposition: null
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id3` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 1
@@ -52,7 +52,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -69,7 +69,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -82,7 +82,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -90,7 +90,7 @@
endposition: null
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id3` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -111,7 +111,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -124,7 +124,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -132,7 +132,7 @@
endposition: null
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id3` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -153,7 +153,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
@@ -170,7 +170,7 @@
want:
- status: 2
code: 803
- title: index.primary-key-type-allowlist
+ title: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
content: The column `id2` in table `t` is one of the primary key, but its type "varchar" is not in allowlist
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/index_total_number_limit.yaml b/backend/plugin/advisor/tidb/test/index_total_number_limit.yaml
index aeb466262d..80dee17c33 100644
--- a/backend/plugin/advisor/tidb/test/index_total_number_limit.yaml
+++ b/backend/plugin/advisor/tidb/test/index_total_number_limit.yaml
@@ -12,7 +12,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `tech_book` should be no more than 5, but found 8
startposition:
line: 5
@@ -29,7 +29,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `t` should be no more than 5, but found 6
startposition:
line: 6
@@ -49,7 +49,7 @@
want:
- status: 2
code: 813
- title: index.total-number-limit
+ title: INDEX_TOTAL_NUMBER_LIMIT
content: The count of index in table `t` should be no more than 5, but found 6
startposition:
line: 9
diff --git a/backend/plugin/advisor/tidb/test/index_type_no_blob.yaml b/backend/plugin/advisor/tidb/test/index_type_no_blob.yaml
index f45cdd0c3d..4102da6937 100644
--- a/backend/plugin/advisor/tidb/test/index_type_no_blob.yaml
+++ b/backend/plugin/advisor/tidb/test/index_type_no_blob.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -22,7 +22,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 1
@@ -30,7 +30,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 1
@@ -41,7 +41,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -49,7 +49,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 1
@@ -57,7 +57,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 1
@@ -68,7 +68,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 1
@@ -76,7 +76,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 1
@@ -84,7 +84,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 1
@@ -99,7 +99,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -112,7 +112,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -120,7 +120,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 2
@@ -128,7 +128,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 2
@@ -141,7 +141,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -149,7 +149,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 2
@@ -157,7 +157,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 2
@@ -177,7 +177,7 @@
want:
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`b` is blob
startposition:
line: 2
@@ -185,7 +185,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`mb` is mediumblob
startposition:
line: 3
@@ -193,7 +193,7 @@
endposition: null
- status: 2
code: 804
- title: index.type-no-blob
+ title: INDEX_TYPE_NO_BLOB
content: Columns in index must not be BLOB but `t`.`lb` is longblob
startposition:
line: 4
diff --git a/backend/plugin/advisor/tidb/test/naming_column.yaml b/backend/plugin/advisor/tidb/test/naming_column.yaml
index 38d5f3e770..0e45c7e8b6 100644
--- a/backend/plugin/advisor/tidb/test/naming_column.yaml
+++ b/backend/plugin/advisor/tidb/test/naming_column.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`creatorId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`gbhzmtchhsjzyrhdroxmyouwloxqezowdvhcbqalqcgqhfbjnvmhwrbggezmzeusx` mismatches column naming convention, its length should be within 64 characters'
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`creatorId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 2
@@ -49,7 +49,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`creatorId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 7
@@ -70,7 +70,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`contentString` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 6
@@ -90,7 +90,7 @@
want:
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`createdTs` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 3
@@ -98,7 +98,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`book`.`updaterId` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 4
@@ -106,7 +106,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`student`.`createdTs` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 8
@@ -114,7 +114,7 @@
endposition: null
- status: 2
code: 302
- title: naming.column
+ title: NAMING_COLUMN
content: '`student`.`updatedTs` mismatches column naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 9
diff --git a/backend/plugin/advisor/tidb/test/naming_column_auto_increment.yaml b/backend/plugin/advisor/tidb/test/naming_column_auto_increment.yaml
index 9f710d952e..47f87e7da6 100644
--- a/backend/plugin/advisor/tidb/test/naming_column_auto_increment.yaml
+++ b/backend/plugin/advisor/tidb/test/naming_column_auto_increment.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`book`.`a` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`tech_book`.`a` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`tech_book`.`a` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 307
- title: naming.column.auto-increment
+ title: NAMING_COLUMN_AUTO_INCREMENT
content: '`tech_book`.`name` mismatches auto_increment column naming convention, naming format should be "^id$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/naming_index_fk.yaml b/backend/plugin/advisor/tidb/test/naming_index_fk.yaml
index 1e266de636..1728a2f6c8 100644
--- a/backend/plugin/advisor/tidb/test/naming_index_fk.yaml
+++ b/backend/plugin/advisor/tidb/test/naming_index_fk.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `tech_book` mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found `fk_author_id`
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key `rvemempmcmmhutaskvcidmwaldtfjdgmcpkhmibtadfydtkexpuzczrrneucthfwk` in table `tech_book` mismatches the naming convention, its length should be within 64 characters
startposition:
line: 1
@@ -24,7 +24,7 @@
endposition: null
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `tech_book` mismatches the naming convention, expect "^$|^fk_tech_book_author_id_author_id$" but found `rvemempmcmmhutaskvcidmwaldtfjdgmcpkhmibtadfydtkexpuzczrrneucthfwk`
startposition:
line: 1
@@ -39,7 +39,7 @@
want:
- status: 2
code: 305
- title: naming.index.fk
+ title: NAMING_INDEX_FK
content: Foreign key in table `book` mismatches the naming convention, expect "^$|^fk_book_author_id_author_id$" but found `fk_book_author_id`
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/naming_index_idx.yaml b/backend/plugin/advisor/tidb/test/naming_index_idx.yaml
index 1634033c1a..05e6b6ef71 100644
--- a/backend/plugin/advisor/tidb/test/naming_index_idx.yaml
+++ b/backend/plugin/advisor/tidb/test/naming_index_idx.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index `afvjwsgrbgqzjfrkmbcoxzstznuypasijbbcdykoboredqovetzfcmmqliaelyavw` in table `tech_book` mismatches the naming convention, its length should be within 64 characters
startposition:
line: 1
@@ -24,7 +24,7 @@
endposition: null
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `afvjwsgrbgqzjfrkmbcoxzstznuypasijbbcdykoboredqovetzfcmmqliaelyavw`
startposition:
line: 1
@@ -37,7 +37,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `idx_tech_book`
startposition:
line: 1
@@ -50,7 +50,7 @@
want:
- status: 2
code: 303
- title: naming.index.idx
+ title: NAMING_INDEX_IDX
content: Index in table `tech_book` mismatches the naming convention, expect "^$|^idx_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/naming_index_uk.yaml b/backend/plugin/advisor/tidb/test/naming_index_uk.yaml
index c772848e57..b755170fcf 100644
--- a/backend/plugin/advisor/tidb/test/naming_index_uk.yaml
+++ b/backend/plugin/advisor/tidb/test/naming_index_uk.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key `qtzmquwvlnttctfluoouxelxeliltcfzzstrtyocogwwyiyrflmrkbhbfasynlacy` in table `tech_book` mismatches the naming convention, its length should be within 64 characters
startposition:
line: 1
@@ -24,7 +24,7 @@
endposition: null
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `qtzmquwvlnttctfluoouxelxeliltcfzzstrtyocogwwyiyrflmrkbhbfasynlacy`
startposition:
line: 1
@@ -37,7 +37,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `tech_book_id_name`
startposition:
line: 1
@@ -50,7 +50,7 @@
want:
- status: 2
code: 304
- title: naming.index.uk
+ title: NAMING_INDEX_UK
content: Unique key in table `tech_book` mismatches the naming convention, expect "^$|^uk_tech_book_id_name$" but found `uk_tech_book`
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/naming_table.yaml b/backend/plugin/advisor/tidb/test/naming_table.yaml
index 717bfa5ccd..7f378f8c0b 100644
--- a/backend/plugin/advisor/tidb/test/naming_table.yaml
+++ b/backend/plugin/advisor/tidb/test/naming_table.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`techBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`cjnubexocfhqoogdmihudyahmmghviqkzvpixnwvxtxumvuannpwdcbtsgwrvzpde` mismatches table naming convention, its length should be within 64 characters'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`TechBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -40,7 +40,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`LiteraryBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -51,7 +51,7 @@
want:
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`LiteraryBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
@@ -59,7 +59,7 @@
endposition: null
- status: 2
code: 301
- title: naming.table
+ title: NAMING_TABLE
content: '`TechBook` mismatches table naming convention, naming format should be "^[a-z]+(_[a-z]+)*$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/schema_backward_compatibility.yaml b/backend/plugin/advisor/tidb/test/schema_backward_compatibility.yaml
index 5db634edbd..471e18f998 100644
--- a/backend/plugin/advisor/tidb/test/schema_backward_compatibility.yaml
+++ b/backend/plugin/advisor/tidb/test/schema_backward_compatibility.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book CHANGE name f2 TEXT" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -25,7 +25,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT NULL" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -36,7 +36,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT NOT NULL" may cause incompatibility with the existing data and code'
startposition:
line: 1
@@ -47,7 +47,7 @@
want:
- status: 2
code: 111
- title: schema.backward-compatibility
+ title: SCHEMA_BACKWARD_COMPATIBILITY
content: '"ALTER TABLE tech_book MODIFY name TEXT COMMENT ''bla''" may cause incompatibility with the existing data and code'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_disallow_commit.yaml b/backend/plugin/advisor/tidb/test/statement_disallow_commit.yaml
index 58b8b737c7..3f2413a5a4 100644
--- a/backend/plugin/advisor/tidb/test/statement_disallow_commit.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_disallow_commit.yaml
@@ -6,7 +6,7 @@
want:
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "COMMIT;"'
startposition:
line: 3
@@ -24,7 +24,7 @@
want:
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "COMMIT;"'
startposition:
line: 3
@@ -32,7 +32,7 @@
endposition: null
- status: 2
code: 206
- title: statement.disallow-commit
+ title: STATEMENT_DISALLOW_COMMIT
content: 'Commit is not allowed, related statement: "COMMIT;"'
startposition:
line: 7
diff --git a/backend/plugin/advisor/tidb/test/statement_disallow_limit.yaml b/backend/plugin/advisor/tidb/test/statement_disallow_limit.yaml
index 82afdd872e..c235d7a0fa 100644
--- a/backend/plugin/advisor/tidb/test/statement_disallow_limit.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_disallow_limit.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1103
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "INSERT INTO tech_book SELECT * FROM tech_book LIMIT 1" uses
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 1103
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "INSERT INTO tech_book SELECT * FROM tech_book UNION SELECT * FROM tech_book LIMIT 1" uses
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 1102
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "UPDATE tech_book SET name = 'my name' LIMIT 10" uses
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 1106
- title: statement.disallow-limit
+ title: STATEMENT_DISALLOW_LIMIT
content: LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but "DELETE FROM tech_book LIMIT 10" uses
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_disallow_order_by.yaml b/backend/plugin/advisor/tidb/test/statement_disallow_order_by.yaml
index d62071bce6..bbfdf4353d 100644
--- a/backend/plugin/advisor/tidb/test/statement_disallow_order_by.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_disallow_order_by.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1104
- title: statement.disallow-order-by
+ title: STATEMENT_DISALLOW_ORDER_BY
content: ORDER BY clause is forbidden in DELETE and UPDATE statements, but "UPDATE tech_book SET name = 'my name' ORDER BY id" uses
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 1105
- title: statement.disallow-order-by
+ title: STATEMENT_DISALLOW_ORDER_BY
content: ORDER BY clause is forbidden in DELETE and UPDATE statements, but "DELETE FROM tech_book ORDER BY id" uses
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_insert_disallow_order_by_rand.yaml b/backend/plugin/advisor/tidb/test/statement_insert_disallow_order_by_rand.yaml
index eff7751c40..3f0d54c723 100644
--- a/backend/plugin/advisor/tidb/test/statement_insert_disallow_order_by_rand.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_insert_disallow_order_by_rand.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1108
- title: statement.insert.disallow-order-by-rand
+ title: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
content: '"INSERT INTO tech_book SELECT * FROM tech_book ORDER BY rand()" uses ORDER BY RAND in the INSERT statement'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_insert_must_specify_column.yaml b/backend/plugin/advisor/tidb/test/statement_insert_must_specify_column.yaml
index b089a7fc59..945800b0c6 100644
--- a/backend/plugin/advisor/tidb/test/statement_insert_must_specify_column.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_insert_must_specify_column.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 1107
- title: statement.insert.must-specify-column
+ title: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
content: The INSERT statement must specify columns but "INSERT INTO tech_book VALUES (1, '1')" does not
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_insert_row_limit.yaml b/backend/plugin/advisor/tidb/test/statement_insert_row_limit.yaml
index 8fba6e672a..d41b591ef8 100644
--- a/backend/plugin/advisor/tidb/test/statement_insert_row_limit.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_insert_row_limit.yaml
@@ -10,7 +10,7 @@
want:
- status: 2
code: 1101
- title: statement.insert.row-limit
+ title: STATEMENT_INSERT_ROW_LIMIT
content: |-
"INSERT INTO tech_book values(1, 'a'), (2, 'b'), (3, 'c'), (4, 'd'), (5, 'e'), (6, 'f')
;" inserts 6 rows. The count exceeds 5.
diff --git a/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yaml b/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yaml
index 3b0124f5ea..ec1bc9b686 100644
--- a/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yaml
@@ -4,7 +4,7 @@
want:
- status: 2
code: 222
- title: statement.maximum-limit-value
+ title: STATEMENT_MAXIMUM_LIMIT_VALUE
content: The limit value 1000000 exceeds the maximum allowed value 1000
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_merge_alter_table.yaml b/backend/plugin/advisor/tidb/test/statement_merge_alter_table.yaml
index f7cf6ff5dc..bb7394e8f8 100644
--- a/backend/plugin/advisor/tidb/test/statement_merge_alter_table.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_merge_alter_table.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `tech_book`
startposition:
line: 2
@@ -22,7 +22,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `t`
startposition:
line: 3
@@ -30,7 +30,7 @@
endposition: null
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `tech_book`
startposition:
line: 4
@@ -45,7 +45,7 @@
want:
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `tech_book`
startposition:
line: 3
@@ -53,7 +53,7 @@
endposition: null
- status: 2
code: 207
- title: statement.merge-alter-table
+ title: STATEMENT_MERGE_ALTER_TABLE
content: There are 2 statements to modify table `t`
startposition:
line: 4
diff --git a/backend/plugin/advisor/tidb/test/statement_prior_backup_check.yaml b/backend/plugin/advisor/tidb/test/statement_prior_backup_check.yaml
index dcd8f3bf18..4f06939948 100644
--- a/backend/plugin/advisor/tidb/test/statement_prior_backup_check.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_prior_backup_check.yaml
@@ -20,7 +20,7 @@
want:
- status: 2
code: 227
- title: statement.prior-backup-check
+ title: BUILTIN_PRIOR_BACKUP_CHECK
content: Found 1 DELETE, 1 UPDATE on table ``.`tech_book`, disallow mixing different types of DML statements
line: 0
column: 0
diff --git a/backend/plugin/advisor/tidb/test/statement_select_no_select_all.yaml b/backend/plugin/advisor/tidb/test/statement_select_no_select_all.yaml
index 1187116383..202ab36747 100644
--- a/backend/plugin/advisor/tidb/test/statement_select_no_select_all.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_select_no_select_all.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT * FROM t" uses SELECT all'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 203
- title: statement.select.no-select-all
+ title: STATEMENT_SELECT_NO_SELECT_ALL
content: '"SELECT a, b FROM (SELECT * from t1 JOIN t2) t" uses SELECT all'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_where_no_leading_wildcard_like.yaml b/backend/plugin/advisor/tidb/test/statement_where_no_leading_wildcard_like.yaml
index 1e2a33d904..6cb384930f 100644
--- a/backend/plugin/advisor/tidb/test/statement_where_no_leading_wildcard_like.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_where_no_leading_wildcard_like.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''%abc''" uses leading wildcard LIKE'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''abc'' OR a LIKE ''%abc''" uses leading wildcard LIKE'
startposition:
line: 1
@@ -27,7 +27,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM t WHERE a LIKE ''%acc'' OR a LIKE ''%abc''" uses leading wildcard LIKE'
startposition:
line: 1
@@ -38,7 +38,7 @@
want:
- status: 2
code: 204
- title: statement.where.no-leading-wildcard-like
+ title: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
content: '"SELECT * FROM (SELECT * FROM t WHERE a LIKE ''%acc'' OR a LIKE ''%abc'') t1" uses leading wildcard LIKE'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_where_require_select.yaml b/backend/plugin/advisor/tidb/test/statement_where_require_select.yaml
index e1ca84cf66..4a60e5f5b2 100644
--- a/backend/plugin/advisor/tidb/test/statement_where_require_select.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_where_require_select.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: '"SELECT id FROM tech_book" requires WHERE clause'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.select
+ title: STATEMENT_WHERE_REQUIRE_SELECT
content: '"SELECT id FROM tech_book WHERE id > (SELECT max(id) FROM tech_book)" requires WHERE clause'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/statement_where_require_update_delete.yaml b/backend/plugin/advisor/tidb/test/statement_where_require_update_delete.yaml
index 1758f8553d..3809646ab7 100644
--- a/backend/plugin/advisor/tidb/test/statement_where_require_update_delete.yaml
+++ b/backend/plugin/advisor/tidb/test/statement_where_require_update_delete.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: '"DELETE FROM tech_book" requires WHERE clause'
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 202
- title: statement.where.require.update-delete
+ title: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
content: '"UPDATE tech_book SET id = 1" requires WHERE clause'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/system_charset_allowlist.yaml b/backend/plugin/advisor/tidb/test/system_charset_allowlist.yaml
index 2ec46d36a0..449633a547 100644
--- a/backend/plugin/advisor/tidb/test/system_charset_allowlist.yaml
+++ b/backend/plugin/advisor/tidb/test/system_charset_allowlist.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"CREATE TABLE t(a int) CHARSET ascii" used disabled charset ''ascii'''
startposition:
line: 1
@@ -20,7 +20,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t CHARSET ascii" used disabled charset ''ascii'''
startposition:
line: 2
@@ -31,7 +31,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER DATABASE test CHARSET ascii" used disabled charset ''ascii'''
startposition:
line: 1
@@ -42,7 +42,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"CREATE TABLE t(a varchar(255) CHARSET ascii)" used disabled charset ''ascii'''
startposition:
line: 1
@@ -55,7 +55,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t ADD COLUMN a varchar(255) CHARSET ascii" used disabled charset ''ascii'''
startposition:
line: 2
@@ -68,7 +68,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t MODIFY COLUMN a varchar(255) CHARSET ascii" used disabled charset ''ascii'''
startposition:
line: 2
@@ -81,7 +81,7 @@
want:
- status: 2
code: 1001
- title: system.charset.allowlist
+ title: SYSTEM_CHARSET_ALLOWLIST
content: '"ALTER TABLE t CHANGE COLUMN a a varchar(255) CHARSET ascii" used disabled charset ''ascii'''
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/system_collation_allowlist.yaml b/backend/plugin/advisor/tidb/test/system_collation_allowlist.yaml
index c8e616d396..a2bd9e7e7d 100644
--- a/backend/plugin/advisor/tidb/test/system_collation_allowlist.yaml
+++ b/backend/plugin/advisor/tidb/test/system_collation_allowlist.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"CREATE TABLE t(a int) COLLATE utf8mb4_polish_ci" used disabled collation ''utf8mb4_polish_ci'''
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"CREATE TABLE t(a int) COLLATE latin1_bin" used disabled collation ''latin1_bin'''
startposition:
line: 1
@@ -29,7 +29,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t COLLATE latin1_bin" used disabled collation ''latin1_bin'''
startposition:
line: 2
@@ -40,7 +40,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER DATABASE test COLLATE latin1_bin" used disabled collation ''latin1_bin'''
startposition:
line: 1
@@ -51,7 +51,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"CREATE TABLE t(a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin)" used disabled collation ''latin1_bin'''
startposition:
line: 1
@@ -64,7 +64,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t ADD COLUMN a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin" used disabled collation ''latin1_bin'''
startposition:
line: 2
@@ -77,7 +77,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t MODIFY COLUMN a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin" used disabled collation ''latin1_bin'''
startposition:
line: 2
@@ -90,7 +90,7 @@
want:
- status: 2
code: 1201
- title: system.collation.allowlist
+ title: SYSTEM_COLLATION_ALLOWLIST
content: '"ALTER TABLE t CHANGE COLUMN a a varchar(255) CHARACTER SET latin1 COLLATE latin1_bin" used disabled collation ''latin1_bin'''
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/test/table_comment.yaml b/backend/plugin/advisor/tidb/test/table_comment.yaml
index a6e1e52b3c..ef34d2532c 100644
--- a/backend/plugin/advisor/tidb/test/table_comment.yaml
+++ b/backend/plugin/advisor/tidb/test/table_comment.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 1301
- title: table.comment
+ title: TABLE_COMMENT
content: The length of table `t` comment should be within 10 characters
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 1032
- title: table.comment
+ title: TABLE_COMMENT
content: Table `t` requires comments
startposition:
line: 1
@@ -25,7 +25,7 @@
want:
- status: 2
code: 1301
- title: table.comment
+ title: TABLE_COMMENT
content: The length of table `t` comment should be within 10 characters
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/table_disallow_partition.yaml b/backend/plugin/advisor/tidb/test/table_disallow_partition.yaml
index 5900d6ea22..cca95a356c 100644
--- a/backend/plugin/advisor/tidb/test/table_disallow_partition.yaml
+++ b/backend/plugin/advisor/tidb/test/table_disallow_partition.yaml
@@ -9,7 +9,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: |-
Table partition is forbidden, but "CREATE TABLE t(a int) PARTITION BY RANGE (a) (
PARTITION p0 VALUES LESS THAN (6),
@@ -28,7 +28,7 @@
want:
- status: 2
code: 608
- title: table.disallow-partition
+ title: TABLE_DISALLOW_PARTITION
content: |-
Table partition is forbidden, but "ALTER TABLE tech_book PARTITION BY RANGE (a) (
PARTITION p0 VALUES LESS THAN (6),
diff --git a/backend/plugin/advisor/tidb/test/table_drop_naming_convention.yaml b/backend/plugin/advisor/tidb/test/table_drop_naming_convention.yaml
index 7dd7f76328..d6e4c98217 100644
--- a/backend/plugin/advisor/tidb/test/table_drop_naming_convention.yaml
+++ b/backend/plugin/advisor/tidb/test/table_drop_naming_convention.yaml
@@ -5,7 +5,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '`foo` mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
@@ -16,7 +16,7 @@
want:
- status: 2
code: 603
- title: table.drop-naming-convention
+ title: TABLE_DROP_NAMING_CONVENTION
content: '`bar` mismatches drop table naming convention, naming format should be "_delete$"'
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/table_no_foreign_key.yaml b/backend/plugin/advisor/tidb/test/table_no_foreign_key.yaml
index d16843f5d6..4467ca9714 100644
--- a/backend/plugin/advisor/tidb/test/table_no_foreign_key.yaml
+++ b/backend/plugin/advisor/tidb/test/table_no_foreign_key.yaml
@@ -3,7 +3,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: Foreign key is not allowed in the table `tech_book`
startposition:
line: 1
@@ -14,7 +14,7 @@
want:
- status: 2
code: 602
- title: table.no-foreign-key
+ title: TABLE_NO_FOREIGN_KEY
content: Foreign key is not allowed in the table `book`
startposition:
line: 1
diff --git a/backend/plugin/advisor/tidb/test/table_require_pk.yaml b/backend/plugin/advisor/tidb/test/table_require_pk.yaml
index b87ed3b7a1..b15d33b00a 100644
--- a/backend/plugin/advisor/tidb/test/table_require_pk.yaml
+++ b/backend/plugin/advisor/tidb/test/table_require_pk.yaml
@@ -7,7 +7,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `no_pk` requires PRIMARY KEY
startposition:
line: 2
@@ -15,7 +15,7 @@
endposition: null
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `no_pk_fork` requires PRIMARY KEY
startposition:
line: 4
@@ -30,7 +30,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 1
@@ -51,7 +51,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 2
@@ -64,7 +64,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 2
@@ -97,7 +97,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `t` requires PRIMARY KEY
startposition:
line: 2
@@ -108,7 +108,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `tech_book` requires PRIMARY KEY
startposition:
line: 1
@@ -123,7 +123,7 @@
want:
- status: 2
code: 601
- title: table.require-pk
+ title: TABLE_REQUIRE_PK
content: Table `tech_book` requires PRIMARY KEY
startposition:
line: 2
diff --git a/backend/plugin/advisor/tidb/tidb_rules_test.go b/backend/plugin/advisor/tidb/tidb_rules_test.go
index 472e6f6639..f8ac927e67 100644
--- a/backend/plugin/advisor/tidb/tidb_rules_test.go
+++ b/backend/plugin/advisor/tidb/tidb_rules_test.go
@@ -8,111 +8,111 @@ import (
)
func TestTiDBRules(t *testing.T) {
- tidbRules := []advisor.SQLReviewRuleType{
- // advisor.SchemaRuleTableNaming enforce the table name format.
- advisor.SchemaRuleTableNaming,
- // advisor.SchemaRuleColumnNaming enforce the column name format.
- advisor.SchemaRuleColumnNaming,
- // advisor.SchemaRuleUKNaming enforce the unique key name format.
- advisor.SchemaRuleUKNaming,
- // advisor.SchemaRuleFKNaming enforce the foreign key name format.
- advisor.SchemaRuleFKNaming,
- // advisor.SchemaRuleIDXNaming enforce the index name format.
- advisor.SchemaRuleIDXNaming,
- // advisor.SchemaRuleAutoIncrementColumnNaming enforce the auto_increment column name format.
- advisor.SchemaRuleAutoIncrementColumnNaming,
+ tidbRules := []storepb.SQLReviewRule_Type{
+ // storepb.SQLReviewRule_NAMING_TABLE enforce the table name format.
+ storepb.SQLReviewRule_NAMING_TABLE,
+ // storepb.SQLReviewRule_NAMING_COLUMN enforce the column name format.
+ storepb.SQLReviewRule_NAMING_COLUMN,
+ // storepb.SQLReviewRule_NAMING_INDEX_UK enforce the unique key name format.
+ storepb.SQLReviewRule_NAMING_INDEX_UK,
+ // storepb.SQLReviewRule_NAMING_INDEX_FK enforce the foreign key name format.
+ storepb.SQLReviewRule_NAMING_INDEX_FK,
+ // storepb.SQLReviewRule_NAMING_INDEX_IDX enforce the index name format.
+ storepb.SQLReviewRule_NAMING_INDEX_IDX,
+ // storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT enforce the auto_increment column name format.
+ storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT,
- // advisor.SchemaRuleStatementNoSelectAll disallow 'SELECT *'.
- advisor.SchemaRuleStatementNoSelectAll,
- // advisor.SchemaRuleStatementRequireWhereForSelect require 'WHERE' clause for SELECT statement.
- advisor.SchemaRuleStatementRequireWhereForSelect,
- // advisor.SchemaRuleStatementRequireWhereForUpdateDelete require 'WHERE' clause for UPDATE and DELETE statement.
- advisor.SchemaRuleStatementRequireWhereForUpdateDelete,
- // advisor.SchemaRuleStatementNoLeadingWildcardLike disallow leading '%' in LIKE, e.g. LIKE foo = '%x' is not allowed.
- advisor.SchemaRuleStatementNoLeadingWildcardLike,
- // advisor.SchemaRuleStatementDisallowCommit disallow using commit in the issue.
- advisor.SchemaRuleStatementDisallowCommit,
- // advisor.SchemaRuleStatementDisallowLimit disallow the LIMIT clause in INSERT, DELETE and UPDATE statements.
- advisor.SchemaRuleStatementDisallowLimit,
- // advisor.SchemaRuleStatementDisallowOrderBy disallow the ORDER BY clause in DELETE and UPDATE statements.
- advisor.SchemaRuleStatementDisallowOrderBy,
- // advisor.SchemaRuleStatementMergeAlterTable disallow redundant ALTER TABLE statements.
- advisor.SchemaRuleStatementMergeAlterTable,
- // advisor.SchemaRuleStatementInsertMustSpecifyColumn enforce the insert column specified.
- advisor.SchemaRuleStatementInsertMustSpecifyColumn,
- // advisor.SchemaRuleStatementInsertDisallowOrderByRand disallow the order by rand in the INSERT statement.
- advisor.SchemaRuleStatementInsertDisallowOrderByRand,
- // advisor.SchemaRuleStatementDMLDryRun dry run the dml.
- advisor.SchemaRuleStatementDMLDryRun,
- advisor.SchemaRuleStatementMaximumLimitValue,
+ // storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL disallow 'SELECT *'.
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT require 'WHERE' clause for SELECT statement.
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE require 'WHERE' clause for UPDATE and DELETE statement.
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ // storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE disallow leading '%' in LIKE, e.g. LIKE foo = '%x' is not allowed.
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
+ // storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT disallow using commit in the issue.
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,
+ // storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT disallow the LIMIT clause in INSERT, DELETE and UPDATE statements.
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT,
+ // storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY disallow the ORDER BY clause in DELETE and UPDATE statements.
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY,
+ // storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE disallow redundant ALTER TABLE statements.
+ storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,
+ // storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN enforce the insert column specified.
+ storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,
+ // storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND disallow the order by rand in the INSERT statement.
+ storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,
+ // storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN dry run the dml.
+ storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN,
+ storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE,
- // advisor.SchemaRuleTableRequirePK require the table to have a primary key.
- advisor.SchemaRuleTableRequirePK,
- // advisor.SchemaRuleTableNoFK require the table disallow the foreign key.
- advisor.SchemaRuleTableNoFK,
- // advisor.SchemaRuleTableDropNamingConvention require only the table following the naming convention can be deleted.
- advisor.SchemaRuleTableDropNamingConvention,
- // advisor.SchemaRuleTableCommentConvention enforce the table comment convention.
- advisor.SchemaRuleTableCommentConvention,
- // advisor.SchemaRuleTableDisallowPartition disallow the table partition.
- advisor.SchemaRuleTableDisallowPartition,
+ // storepb.SQLReviewRule_TABLE_REQUIRE_PK require the table to have a primary key.
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ // storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY require the table disallow the foreign key.
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ // storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION require only the table following the naming convention can be deleted.
+ storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
+ // storepb.SQLReviewRule_TABLE_COMMENT enforce the table comment convention.
+ storepb.SQLReviewRule_TABLE_COMMENT,
+ // storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION disallow the table partition.
+ storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION,
- // advisor.SchemaRuleRequiredColumn enforce the required columns in each table.
- advisor.SchemaRuleRequiredColumn,
- // advisor.SchemaRuleColumnNotNull enforce the columns cannot have NULL value.
- advisor.SchemaRuleColumnNotNull,
- // advisor.SchemaRuleColumnDisallowChangeType disallow change column type.
- advisor.SchemaRuleColumnDisallowChangeType,
- // advisor.SchemaRuleColumnSetDefaultForNotNull require the not null column to set default value.
- advisor.SchemaRuleColumnSetDefaultForNotNull,
- // advisor.SchemaRuleColumnDisallowChange disallow CHANGE COLUMN statement.
- advisor.SchemaRuleColumnDisallowChange,
- // advisor.SchemaRuleColumnDisallowChangingOrder disallow changing column order.
- advisor.SchemaRuleColumnDisallowChangingOrder,
- // advisor.SchemaRuleColumnDisallowDropIndex disallow drop index column.
- advisor.SchemaRuleColumnDisallowDropInIndex,
- // advisor.SchemaRuleColumnCommentConvention enforce the column comment convention.
- advisor.SchemaRuleColumnCommentConvention,
- // advisor.SchemaRuleColumnAutoIncrementMustInteger require the auto-increment column to be integer.
- advisor.SchemaRuleColumnAutoIncrementMustInteger,
- // advisor.SchemaRuleColumnTypeDisallowList enforce the column type disallow list.
- advisor.SchemaRuleColumnTypeDisallowList,
- // advisor.SchemaRuleColumnDisallowSetCharset disallow set column charset.
- advisor.SchemaRuleColumnDisallowSetCharset,
- // advisor.SchemaRuleColumnMaximumCharacterLength enforce the maximum character length.
- advisor.SchemaRuleColumnMaximumCharacterLength,
- // advisor.SchemaRuleColumnAutoIncrementInitialValue enforce the initial auto-increment value.
- advisor.SchemaRuleColumnAutoIncrementInitialValue,
- // advisor.SchemaRuleColumnAutoIncrementMustUnsigned enforce the auto-increment column to be unsigned.
- advisor.SchemaRuleColumnAutoIncrementMustUnsigned,
- // advisor.SchemaRuleCurrentTimeColumnCountLimit enforce the current column count limit.
- advisor.SchemaRuleCurrentTimeColumnCountLimit,
- // advisor.SchemaRuleColumnRequireDefault enforce the column default.
- advisor.SchemaRuleColumnRequireDefault,
+ // storepb.SQLReviewRule_COLUMN_REQUIRED enforce the required columns in each table.
+ storepb.SQLReviewRule_COLUMN_REQUIRED,
+ // storepb.SQLReviewRule_COLUMN_NO_NULL enforce the columns cannot have NULL value.
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE disallow change column type.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,
+ // storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL require the not null column to set default value.
+ storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE disallow CHANGE COLUMN statement.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER disallow changing column order.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_DROPIndex disallow drop index column.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX,
+ // storepb.SQLReviewRule_COLUMN_COMMENT enforce the column comment convention.
+ storepb.SQLReviewRule_COLUMN_COMMENT,
+ // storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER require the auto-increment column to be integer.
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER,
+ // storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST enforce the column type disallow list.
+ storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
+ // storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET disallow set column charset.
+ storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET,
+ // storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH enforce the maximum character length.
+ storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,
+ // storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE enforce the initial auto-increment value.
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE,
+ // storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED enforce the auto-increment column to be unsigned.
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED,
+ // storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT enforce the current column count limit.
+ storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT,
+ // storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT enforce the column default.
+ storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,
- // advisor.SchemaRuleSchemaBackwardCompatibility enforce the MySQL and TiDB support check whether the schema change is backward compatible.
- advisor.SchemaRuleSchemaBackwardCompatibility,
+ // storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY enforce the MySQL and TiDB support check whether the schema change is backward compatible.
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
- // advisor.SchemaRuleDropEmptyDatabase enforce the MySQL and TiDB support check if the database is empty before users drop it.
- advisor.SchemaRuleDropEmptyDatabase,
+ // storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE enforce the MySQL and TiDB support check if the database is empty before users drop it.
+ storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE,
- // advisor.SchemaRuleIndexNoDuplicateColumn require the index no duplicate column.
- advisor.SchemaRuleIndexNoDuplicateColumn,
- // advisor.SchemaRuleIndexKeyNumberLimit enforce the index key number limit.
- advisor.SchemaRuleIndexKeyNumberLimit,
- // advisor.SchemaRuleIndexPKTypeLimit enforce the type restriction of columns in primary key.
- advisor.SchemaRuleIndexPKTypeLimit,
- // advisor.SchemaRuleIndexTypeNoBlob enforce the type restriction of columns in index.
- advisor.SchemaRuleIndexTypeNoBlob,
- // advisor.SchemaRuleIndexTotalNumberLimit enforce the index total number limit.
- advisor.SchemaRuleIndexTotalNumberLimit,
- advisor.SchemaRuleIndexPrimaryKeyTypeAllowlist,
+ // storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN require the index no duplicate column.
+ storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,
+ // storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT enforce the index key number limit.
+ storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,
+ // storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT enforce the type restriction of columns in primary key.
+ storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT,
+ // storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB enforce the type restriction of columns in index.
+ storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB,
+ // storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT enforce the index total number limit.
+ storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,
+ storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST,
- // advisor.SchemaRuleCharsetAllowlist enforce the charset allowlist.
- advisor.SchemaRuleCharsetAllowlist,
+ // storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST enforce the charset allowlist.
+ storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST,
- // advisor.SchemaRuleCollationAllowlist enforce the collation allowlist.
- advisor.SchemaRuleCollationAllowlist,
+ // storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST enforce the collation allowlist.
+ storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST,
}
for _, rule := range tidbRules {
diff --git a/backend/plugin/advisor/utils_for_tests.go b/backend/plugin/advisor/utils_for_tests.go
index 73fb1b4bde..49ce3b9cb9 100644
--- a/backend/plugin/advisor/utils_for_tests.go
+++ b/backend/plugin/advisor/utils_for_tests.go
@@ -157,7 +157,7 @@ type TestCase struct {
}
// RunSQLReviewRuleTest helps to test the SQL review rule.
-func RunSQLReviewRuleTest(t *testing.T, rule SQLReviewRuleType, dbType storepb.Engine, needMetaData bool, record bool) {
+func RunSQLReviewRuleTest(t *testing.T, rule storepb.SQLReviewRule_Type, dbType storepb.Engine, needMetaData bool, record bool) {
var tests []TestCase
fileName := strings.Map(func(r rune) rune {
@@ -167,7 +167,7 @@ func RunSQLReviewRuleTest(t *testing.T, rule SQLReviewRuleType, dbType storepb.E
default:
return r
}
- }, string(rule))
+ }, strings.ToLower(rule.String()))
filepath := filepath.Join("test", fileName+".yaml")
yamlFile, err := os.Open(filepath)
require.NoError(t, err)
@@ -229,7 +229,7 @@ func RunSQLReviewRuleTest(t *testing.T, rule SQLReviewRuleType, dbType storepb.E
ruleList := []*storepb.SQLReviewRule{
{
- Type: string(rule),
+ Type: rule,
Level: storepb.SQLReviewRule_WARNING,
Payload: string(payload),
},
@@ -343,80 +343,79 @@ func (*MockDriver) Dump(_ context.Context, _ io.Writer, _ *storepb.DatabaseSchem
}
// SetDefaultSQLReviewRulePayload sets the default payload for this rule.
-func SetDefaultSQLReviewRulePayload(ruleTp SQLReviewRuleType, dbType storepb.Engine) (string, error) {
+func SetDefaultSQLReviewRulePayload(ruleTp storepb.SQLReviewRule_Type, dbType storepb.Engine) (string, error) {
var payload []byte
var err error
switch ruleTp {
- case SchemaRuleMySQLEngine,
- BuiltinRulePriorBackupCheck,
- SchemaRuleFullyQualifiedObjectName,
- SchemaRuleStatementNoSelectAll,
- SchemaRuleStatementRequireWhereForSelect,
- SchemaRuleStatementRequireWhereForUpdateDelete,
- SchemaRuleStatementNoLeadingWildcardLike,
- SchemaRuleStatementDisallowOnDelCascade,
- SchemaRuleStatementDisallowRemoveTblCascade,
- SchemaRuleStatementDisallowCommit,
- SchemaRuleStatementDisallowLimit,
- SchemaRuleStatementDisallowOrderBy,
- SchemaRuleStatementMergeAlterTable,
- SchemaRuleStatementInsertMustSpecifyColumn,
- SchemaRuleStatementInsertDisallowOrderByRand,
- SchemaRuleStatementDMLDryRun,
- SchemaRuleStatementDisallowUsingFilesort,
- SchemaRuleStatementDisallowUsingTemporary,
- SchemaRuleTableRequirePK,
- SchemaRuleTableNoFK,
- SchemaRuleTableDisallowPartition,
- SchemaRuleTableDisallowTrigger,
- SchemaRuleTableNoDuplicateIndex,
- SchemaRuleColumnNotNull,
- SchemaRuleColumnDisallowChangeType,
- SchemaRuleColumnSetDefaultForNotNull,
- SchemaRuleColumnDisallowChange,
- SchemaRuleColumnDisallowChangingOrder,
- SchemaRuleColumnDisallowDropInIndex,
- SchemaRuleColumnAutoIncrementMustInteger,
- SchemaRuleColumnDisallowSetCharset,
- SchemaRuleColumnAutoIncrementMustUnsigned,
- SchemaRuleAddNotNullColumnRequireDefault,
- SchemaRuleCurrentTimeColumnCountLimit,
- SchemaRuleColumnRequireDefault,
- SchemaRuleColumnDefaultDisallowVolatile,
- SchemaRuleSchemaBackwardCompatibility,
- SchemaRuleDropEmptyDatabase,
- SchemaRuleIndexNoDuplicateColumn,
- SchemaRuleIndexPKTypeLimit,
- SchemaRuleStatementDisallowAddColumnWithDefault,
- SchemaRuleStatementNonTransactional,
- SchemaRuleCreateIndexConcurrently,
- SchemaRuleStatementAddCheckNotValid,
- SchemaRuleStatementAddFKNotValid,
- SchemaRuleStatementDisallowAddNotNull,
- SchemaRuleStatementWhereNoEqualNull,
- SchemaRuleIndexTypeNoBlob,
- SchemaRuleIdentifierNoKeyword,
- SchemaRuleTableNameNoKeyword,
- SchemaRuleProcedureDisallowCreate,
- SchemaRuleEventDisallowCreate,
- SchemaRuleViewDisallowCreate,
- SchemaRuleFunctionDisallowCreate,
- SchemaRuleStatementCreateSpecifySchema,
- SchemaRuleStatementCheckSetRoleVariable,
- SchemaRuleStatementWhereDisallowFunctionsAndCalculations,
- SchemaRuleStatementPriorBackupCheck,
- SchemaRuleStatementJoinStrictColumnAttrs,
- SchemaRuleStatementMaxExecutionTime,
- SchemaRuleStatementRequireAlgorithmOption,
- SchemaRuleStatementRequireLockOption,
- SchemaRuleTableDisallowSetCharset,
- SchemaRuleStatementDisallowCrossDBQueries,
- SchemaRuleIndexNotRedundant:
- case SchemaRuleTableDropNamingConvention:
+ case storepb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB,
+ storepb.SQLReviewRule_BUILTIN_PRIOR_BACKUP_CHECK,
+ storepb.SQLReviewRule_NAMING_FULLY_QUALIFIED,
+ storepb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
+ storepb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ON_DEL_CASCADE,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_RM_TBL_CASCADE,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY,
+ storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,
+ storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,
+ storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,
+ storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY,
+ storepb.SQLReviewRule_TABLE_REQUIRE_PK,
+ storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
+ storepb.SQLReviewRule_TABLE_DISALLOW_PARTITION,
+ storepb.SQLReviewRule_TABLE_DISALLOW_TRIGGER,
+ storepb.SQLReviewRule_TABLE_NO_DUPLICATE_INDEX,
+ storepb.SQLReviewRule_COLUMN_NO_NULL,
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,
+ storepb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL,
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGE,
+ storepb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER,
+ storepb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX,
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER,
+ storepb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET,
+ storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED,
+ storepb.SQLReviewRule_COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT,
+ storepb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT,
+ storepb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,
+ storepb.SQLReviewRule_COLUMN_DEFAULT_DISALLOW_VOLATILE,
+ storepb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
+ storepb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE,
+ storepb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,
+ storepb.SQLReviewRule_INDEX_PK_TYPE_LIMIT,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT,
+ storepb.SQLReviewRule_STATEMENT_NON_TRANSACTIONAL,
+ storepb.SQLReviewRule_INDEX_CREATE_CONCURRENTLY,
+ storepb.SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID,
+ storepb.SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL,
+ storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL,
+ storepb.SQLReviewRule_INDEX_TYPE_NO_BLOB,
+ storepb.SQLReviewRule_NAMING_IDENTIFIER_NO_KEYWORD,
+ storepb.SQLReviewRule_NAMING_TABLE_NO_KEYWORD,
+ storepb.SQLReviewRule_SYSTEM_PROCEDURE_DISALLOW_CREATE,
+ storepb.SQLReviewRule_SYSTEM_EVENT_DISALLOW_CREATE,
+ storepb.SQLReviewRule_SYSTEM_VIEW_DISALLOW_CREATE,
+ storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOW_CREATE,
+ storepb.SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA,
+ storepb.SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE,
+ storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS,
+ storepb.SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS,
+ storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME,
+ storepb.SQLReviewRule_STATEMENT_REQUIRE_ALGORITHM_OPTION,
+ storepb.SQLReviewRule_STATEMENT_REQUIRE_LOCK_OPTION,
+ storepb.SQLReviewRule_TABLE_DISALLOW_SET_CHARSET,
+ storepb.SQLReviewRule_STATEMENT_DISALLOW_CROSS_DB_QUERIES,
+ storepb.SQLReviewRule_INDEX_NOT_REDUNDANT:
+ case storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION:
payload, err = json.Marshal(NamingRulePayload{
Format: "_delete$",
})
- case SchemaRuleTableNaming, SchemaRuleColumnNaming:
+ case storepb.SQLReviewRule_NAMING_TABLE, storepb.SQLReviewRule_NAMING_COLUMN:
format := "^[a-z]+(_[a-z]+)*$"
maxLength := 64
switch dbType {
@@ -431,53 +430,53 @@ func SetDefaultSQLReviewRulePayload(ruleTp SQLReviewRuleType, dbType storepb.Eng
Format: format,
MaxLength: maxLength,
})
- case SchemaRuleIDXNaming:
+ case storepb.SQLReviewRule_NAMING_INDEX_IDX:
payload, err = json.Marshal(NamingRulePayload{
Format: "^$|^idx_{{table}}_{{column_list}}$",
MaxLength: 64,
})
- case SchemaRulePKNaming:
+ case storepb.SQLReviewRule_NAMING_INDEX_PK:
payload, err = json.Marshal(NamingRulePayload{
Format: "^$|^pk_{{table}}_{{column_list}}$",
MaxLength: 64,
})
- case SchemaRuleUKNaming:
+ case storepb.SQLReviewRule_NAMING_INDEX_UK:
payload, err = json.Marshal(NamingRulePayload{
Format: "^$|^uk_{{table}}_{{column_list}}$",
MaxLength: 64,
})
- case SchemaRuleFKNaming:
+ case storepb.SQLReviewRule_NAMING_INDEX_FK:
payload, err = json.Marshal(NamingRulePayload{
Format: "^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$",
MaxLength: 64,
})
- case SchemaRuleAutoIncrementColumnNaming:
+ case storepb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT:
payload, err = json.Marshal(NamingRulePayload{
Format: "^id$",
MaxLength: 64,
})
- case SchemaRuleStatementInsertRowLimit, SchemaRuleStatementAffectedRowLimit:
+ case storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 5,
})
- case SchemaRuleStatementMaximumJoinTableCount:
+ case storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 2,
})
- case SchemaRuleStatementWhereMaximumLogicalOperatorCount:
+ case storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 2,
})
- case SchemaRuleStatementMaximumLimitValue:
+ case storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 1000,
})
- case SchemaRuleTableCommentConvention, SchemaRuleColumnCommentConvention:
+ case storepb.SQLReviewRule_TABLE_COMMENT, storepb.SQLReviewRule_COLUMN_COMMENT:
payload, err = json.Marshal(CommentConventionRulePayload{
Required: true,
MaxLength: 10,
})
- case SchemaRuleRequiredColumn:
+ case storepb.SQLReviewRule_COLUMN_REQUIRED:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{
"id",
@@ -487,23 +486,23 @@ func SetDefaultSQLReviewRulePayload(ruleTp SQLReviewRuleType, dbType storepb.Eng
"updater_id",
},
})
- case SchemaRuleColumnTypeDisallowList:
+ case storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"JSON", "BINARY_FLOAT"},
})
- case SchemaRuleColumnMaximumCharacterLength:
+ case storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 20,
})
- case SchemaRuleColumnMaximumVarcharLength:
+ case storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 2560,
})
- case SchemaRuleColumnAutoIncrementInitialValue:
+ case storepb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 20,
})
- case SchemaRuleTableDisallowDDL:
+ case storepb.SQLReviewRule_TABLE_DISALLOW_DDL:
if dbType == storepb.Engine_MSSQL {
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"MySchema.Identifier"},
@@ -513,7 +512,7 @@ func SetDefaultSQLReviewRulePayload(ruleTp SQLReviewRuleType, dbType storepb.Eng
List: []string{"identifier"},
})
}
- case SchemaRuleTableDisallowDML:
+ case storepb.SQLReviewRule_TABLE_DISALLOW_DML:
if dbType == storepb.Engine_MSSQL {
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"MySchema.Identifier"},
@@ -523,35 +522,35 @@ func SetDefaultSQLReviewRulePayload(ruleTp SQLReviewRuleType, dbType storepb.Eng
List: []string{"identifier"},
})
}
- case SchemaRuleIndexKeyNumberLimit, SchemaRuleIndexTotalNumberLimit:
+ case storepb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT, storepb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 5,
})
- case SchemaRuleCharsetAllowlist:
+ case storepb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"utf8mb4", "UTF8"},
})
- case SchemaRuleCollationAllowlist:
+ case storepb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"utf8mb4_0900_ai_ci"},
})
- case SchemaRuleCommentLength:
+ case storepb.SQLReviewRule_SYSTEM_COMMENT_LENGTH:
payload, err = json.Marshal(NumberTypeRulePayload{
Number: 20,
})
- case SchemaRuleIndexPrimaryKeyTypeAllowlist:
+ case storepb.SQLReviewRule_INDEX_PRIMARY_KEY_TYPE_ALLOWLIST:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"serial", "bigserial", "int", "bigint"},
})
- case SchemaRuleIndexTypeAllowList:
+ case storepb.SQLReviewRule_INDEX_TYPE_ALLOW_LIST:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"BTREE", "HASH"},
})
- case SchemaRuleIdentifierCase:
+ case storepb.SQLReviewRule_NAMING_IDENTIFIER_CASE:
payload, err = json.Marshal(NamingCaseRulePayload{
Upper: true,
})
- case SchemaRuleFunctionDisallowList:
+ case storepb.SQLReviewRule_SYSTEM_FUNCTION_DISALLOWED_LIST:
payload, err = json.Marshal(StringArrayTypeRulePayload{
List: []string{"rand", "uuid", "sleep"},
})
diff --git a/backend/tests/sql_review_test.go b/backend/tests/sql_review_test.go
index 8b916a0b4c..75363a81f5 100644
--- a/backend/tests/sql_review_test.go
+++ b/backend/tests/sql_review_test.go
@@ -532,153 +532,153 @@ func prodTemplateReviewConfigForPostgreSQL() (*v1pb.ReviewConfig, error) {
Rules: []*v1pb.SQLReviewRule{
// Naming
{
- Type: string(advisor.SchemaRuleTableNaming),
+ Type: v1pb.SQLReviewRule_NAMING_TABLE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleColumnNaming),
+ Type: v1pb.SQLReviewRule_NAMING_COLUMN,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleIDXNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_IDX,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRulePKNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_PK,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleUKNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_UK,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleFKNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_FK,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
// Statement
{
- Type: string(advisor.SchemaRuleStatementNoSelectAll),
+ Type: v1pb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleStatementRequireWhereForSelect),
+ Type: v1pb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleStatementRequireWhereForUpdateDelete),
+ Type: v1pb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleStatementNoLeadingWildcardLike),
+ Type: v1pb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleStatementDisallowCommit),
+ Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleStatementMergeAlterTable),
+ Type: v1pb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleStatementInsertDisallowOrderByRand),
+ Type: v1pb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
// TABLE
{
- Type: string(advisor.SchemaRuleTableRequirePK),
+ Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleTableNoFK),
+ Type: v1pb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleTableDropNamingConvention),
+ Type: v1pb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleTableCommentConvention),
+ Type: v1pb.SQLReviewRule_TABLE_COMMENT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleTableDisallowPartition),
+ Type: v1pb.SQLReviewRule_TABLE_DISALLOW_PARTITION,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
// COLUMN
{
- Type: string(advisor.SchemaRuleRequiredColumn),
+ Type: v1pb.SQLReviewRule_COLUMN_REQUIRED,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleColumnNotNull),
+ Type: v1pb.SQLReviewRule_COLUMN_NO_NULL,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleColumnDisallowChangeType),
+ Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleColumnTypeDisallowList),
+ Type: v1pb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleColumnMaximumCharacterLength),
+ Type: v1pb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
// SCHEMA
{
- Type: string(advisor.SchemaRuleSchemaBackwardCompatibility),
+ Type: v1pb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
// INDEX
{
- Type: string(advisor.SchemaRuleIndexNoDuplicateColumn),
+ Type: v1pb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleIndexKeyNumberLimit),
+ Type: v1pb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleIndexTotalNumberLimit),
+ Type: v1pb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
// SYSTEM
{
- Type: string(advisor.SchemaRuleCharsetAllowlist),
+ Type: v1pb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
{
- Type: string(advisor.SchemaRuleCollationAllowlist),
+ Type: v1pb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_POSTGRES,
},
@@ -686,7 +686,7 @@ func prodTemplateReviewConfigForPostgreSQL() (*v1pb.ReviewConfig, error) {
}
for _, rule := range config.Rules {
- payload, err := advisor.SetDefaultSQLReviewRulePayload(advisor.SQLReviewRuleType(rule.Type), storepb.Engine_POSTGRES)
+ payload, err := advisor.SetDefaultSQLReviewRulePayload(storepb.SQLReviewRule_Type(rule.Type), storepb.Engine_POSTGRES)
if err != nil {
return nil, err
}
@@ -703,260 +703,260 @@ func prodTemplateReviewConfigForMySQL() (*v1pb.ReviewConfig, error) {
Rules: []*v1pb.SQLReviewRule{
// Engine
{
- Type: string(advisor.SchemaRuleMySQLEngine),
+ Type: v1pb.SQLReviewRule_ENGINE_MYSQL_USE_INNODB,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
// Naming
{
- Type: string(advisor.SchemaRuleTableNaming),
+ Type: v1pb.SQLReviewRule_NAMING_TABLE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnNaming),
+ Type: v1pb.SQLReviewRule_NAMING_COLUMN,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleIDXNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_IDX,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleUKNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_UK,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleFKNaming),
+ Type: v1pb.SQLReviewRule_NAMING_INDEX_FK,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleAutoIncrementColumnNaming),
+ Type: v1pb.SQLReviewRule_NAMING_COLUMN_AUTO_INCREMENT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
// Statement
{
- Type: string(advisor.SchemaRuleStatementNoSelectAll),
+ Type: v1pb.SQLReviewRule_STATEMENT_SELECT_NO_SELECT_ALL,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementRequireWhereForSelect),
+ Type: v1pb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_SELECT,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementRequireWhereForUpdateDelete),
+ Type: v1pb.SQLReviewRule_STATEMENT_WHERE_REQUIRE_UPDATE_DELETE,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementNoLeadingWildcardLike),
+ Type: v1pb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementDisallowCommit),
+ Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_COMMIT,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementDisallowLimit),
+ Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementDisallowOrderBy),
+ Type: v1pb.SQLReviewRule_STATEMENT_DISALLOW_ORDER_BY,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementMergeAlterTable),
+ Type: v1pb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementInsertRowLimit),
+ Type: v1pb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementInsertMustSpecifyColumn),
+ Type: v1pb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementInsertDisallowOrderByRand),
+ Type: v1pb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementAffectedRowLimit),
+ Type: v1pb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleStatementDMLDryRun),
+ Type: v1pb.SQLReviewRule_STATEMENT_DML_DRY_RUN,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
// TABLE
{
- Type: string(advisor.SchemaRuleTableRequirePK),
+ Type: v1pb.SQLReviewRule_TABLE_REQUIRE_PK,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleTableNoFK),
+ Type: v1pb.SQLReviewRule_TABLE_NO_FOREIGN_KEY,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleTableDropNamingConvention),
+ Type: v1pb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleTableCommentConvention),
+ Type: v1pb.SQLReviewRule_TABLE_COMMENT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleTableDisallowPartition),
+ Type: v1pb.SQLReviewRule_TABLE_DISALLOW_PARTITION,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
// COLUMN
{
- Type: string(advisor.SchemaRuleRequiredColumn),
+ Type: v1pb.SQLReviewRule_COLUMN_REQUIRED,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnNotNull),
+ Type: v1pb.SQLReviewRule_COLUMN_NO_NULL,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnDisallowDropInIndex),
+ Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_DROP_IN_INDEX,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnDisallowChangeType),
+ Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGE_TYPE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnSetDefaultForNotNull),
+ Type: v1pb.SQLReviewRule_COLUMN_SET_DEFAULT_FOR_NOT_NULL,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnDisallowChange),
+ Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnDisallowChangingOrder),
+ Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_CHANGING_ORDER,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnCommentConvention),
+ Type: v1pb.SQLReviewRule_COLUMN_COMMENT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnAutoIncrementMustInteger),
+ Type: v1pb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_INTEGER,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnTypeDisallowList),
+ Type: v1pb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnDisallowSetCharset),
+ Type: v1pb.SQLReviewRule_COLUMN_DISALLOW_SET_CHARSET,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnMaximumCharacterLength),
+ Type: v1pb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnAutoIncrementInitialValue),
+ Type: v1pb.SQLReviewRule_COLUMN_AUTO_INCREMENT_INITIAL_VALUE,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnAutoIncrementMustUnsigned),
+ Type: v1pb.SQLReviewRule_COLUMN_AUTO_INCREMENT_MUST_UNSIGNED,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleCurrentTimeColumnCountLimit),
+ Type: v1pb.SQLReviewRule_COLUMN_CURRENT_TIME_COUNT_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleColumnRequireDefault),
+ Type: v1pb.SQLReviewRule_COLUMN_REQUIRE_DEFAULT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
// SCHEMA
{
- Type: string(advisor.SchemaRuleSchemaBackwardCompatibility),
+ Type: v1pb.SQLReviewRule_SCHEMA_BACKWARD_COMPATIBILITY,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
// DATABASE
{
- Type: string(advisor.SchemaRuleDropEmptyDatabase),
+ Type: v1pb.SQLReviewRule_DATABASE_DROP_EMPTY_DATABASE,
Level: v1pb.SQLReviewRule_ERROR,
Engine: v1pb.Engine_MYSQL,
},
// INDEX
{
- Type: string(advisor.SchemaRuleIndexNoDuplicateColumn),
+ Type: v1pb.SQLReviewRule_INDEX_NO_DUPLICATE_COLUMN,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleIndexKeyNumberLimit),
+ Type: v1pb.SQLReviewRule_INDEX_KEY_NUMBER_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleIndexPKTypeLimit),
+ Type: v1pb.SQLReviewRule_INDEX_PK_TYPE_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleIndexTypeNoBlob),
+ Type: v1pb.SQLReviewRule_INDEX_TYPE_NO_BLOB,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleIndexTotalNumberLimit),
+ Type: v1pb.SQLReviewRule_INDEX_TOTAL_NUMBER_LIMIT,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
// SYSTEM
{
- Type: string(advisor.SchemaRuleCharsetAllowlist),
+ Type: v1pb.SQLReviewRule_SYSTEM_CHARSET_ALLOWLIST,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
{
- Type: string(advisor.SchemaRuleCollationAllowlist),
+ Type: v1pb.SQLReviewRule_SYSTEM_COLLATION_ALLOWLIST,
Level: v1pb.SQLReviewRule_WARNING,
Engine: v1pb.Engine_MYSQL,
},
@@ -964,7 +964,7 @@ func prodTemplateReviewConfigForMySQL() (*v1pb.ReviewConfig, error) {
}
for _, rule := range config.Rules {
- payload, err := advisor.SetDefaultSQLReviewRulePayload(advisor.SQLReviewRuleType(rule.Type), storepb.Engine_POSTGRES)
+ payload, err := advisor.SetDefaultSQLReviewRulePayload(storepb.SQLReviewRule_Type(rule.Type), storepb.Engine_POSTGRES)
if err != nil {
return nil, err
}
diff --git a/backend/tests/test-data/sql_review_mysql.yaml b/backend/tests/test-data/sql_review_mysql.yaml
index bae74cf846..3ccfc49207 100644
--- a/backend/tests/test-data/sql_review_mysql.yaml
+++ b/backend/tests/test-data/sql_review_mysql.yaml
@@ -27,7 +27,7 @@
- |-
{
"status": "ERROR",
- "title": "engine.mysql.use-innodb",
+ "title": "ENGINE_MYSQL_USE_INNODB",
"content": "\"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content)) ENGINE = CSV COLLATE latin1_bin;\" doesn't use InnoDB engine",
"code": 501,
"sqlReviewReport": {
@@ -39,7 +39,7 @@
- |-
{
"status": "ERROR",
- "title": "table.require-pk",
+ "title": "TABLE_REQUIRE_PK",
"content": "Table `userTable` requires PRIMARY KEY",
"code": 601,
"sqlReviewReport": {
@@ -51,7 +51,7 @@
- |-
{
"status": "ERROR",
- "title": "table.no-foreign-key",
+ "title": "TABLE_NO_FOREIGN_KEY",
"content": "Foreign key is not allowed in the table `userTable`",
"code": 602,
"sqlReviewReport": {
@@ -63,7 +63,7 @@
- |-
{
"status": "ERROR",
- "title": "column.type-disallow-list",
+ "title": "COLUMN_TYPE_DISALLOW_LIST",
"content": "Disallow column type JSON but column `userTable`.`json_content` is",
"code": 411,
"sqlReviewReport": {
@@ -75,7 +75,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.table",
+ "title": "NAMING_TABLE",
"content": "`userTable` mismatches table naming convention, naming format should be \"^[a-z]+(_[a-z]+)*$\"",
"code": 301,
"sqlReviewReport": {
@@ -87,7 +87,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.column",
+ "title": "NAMING_COLUMN",
"content": "`userTable`.`roomId` mismatches column naming convention, naming format should be \"^[a-z]+(_[a-z]+)*$\"",
"code": 302,
"sqlReviewReport": {
@@ -99,7 +99,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.index.idx",
+ "title": "NAMING_INDEX_IDX",
"content": "Index in table `userTable` mismatches the naming convention, expect \"^$|^idx_userTable_name$\" but found `idx1`",
"code": 303,
"sqlReviewReport": {
@@ -111,7 +111,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.index.uk",
+ "title": "NAMING_INDEX_UK",
"content": "Unique key in table `userTable` mismatches the naming convention, expect \"^$|^uk_userTable_id_name$\" but found `uk1`",
"code": 304,
"sqlReviewReport": {
@@ -123,7 +123,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.index.fk",
+ "title": "NAMING_INDEX_FK",
"content": "Foreign key in table `userTable` mismatches the naming convention, expect \"^$|^fk_userTable_roomId_room_id$\" but found `fk1`",
"code": 305,
"sqlReviewReport": {
@@ -135,7 +135,7 @@
- |-
{
"status": "WARNING",
- "title": "table.comment",
+ "title": "TABLE_COMMENT",
"content": "Table `userTable` requires comments",
"code": 1032,
"sqlReviewReport": {
@@ -147,7 +147,7 @@
- |-
{
"status": "WARNING",
- "title": "column.required",
+ "title": "COLUMN_REQUIRED",
"content": "Table `userTable` requires columns: created_ts, creator_id, updated_ts, updater_id",
"code": 401,
"sqlReviewReport": {
@@ -159,7 +159,7 @@
- |-
{
"status": "WARNING",
- "title": "column.no-null",
+ "title": "COLUMN_NO_NULL",
"content": "`userTable`.`name` cannot have NULL value",
"code": 402,
"sqlReviewReport": {
@@ -171,7 +171,7 @@
- |-
{
"status": "WARNING",
- "title": "column.no-null",
+ "title": "COLUMN_NO_NULL",
"content": "`userTable`.`roomId` cannot have NULL value",
"code": 402,
"sqlReviewReport": {
@@ -183,7 +183,7 @@
- |-
{
"status": "WARNING",
- "title": "column.set-default-for-not-null",
+ "title": "COLUMN_SET_DEFAULT_FOR_NOT_NULL",
"content": "Column `userTable`.`id` is NOT NULL but doesn't have DEFAULT",
"code": 404,
"sqlReviewReport": {
@@ -195,7 +195,7 @@
- |-
{
"status": "WARNING",
- "title": "column.comment",
+ "title": "COLUMN_COMMENT",
"content": "Column `userTable`.`id` requires comments",
"code": 1032,
"sqlReviewReport": {
@@ -207,7 +207,7 @@
- |-
{
"status": "WARNING",
- "title": "column.comment",
+ "title": "COLUMN_COMMENT",
"content": "Column `userTable`.`name` requires comments",
"code": 1032,
"sqlReviewReport": {
@@ -219,7 +219,7 @@
- |-
{
"status": "WARNING",
- "title": "column.comment",
+ "title": "COLUMN_COMMENT",
"content": "Column `userTable`.`roomId` requires comments",
"code": 1032,
"sqlReviewReport": {
@@ -231,7 +231,7 @@
- |-
{
"status": "WARNING",
- "title": "column.disallow-set-charset",
+ "title": "COLUMN_DISALLOW_SET_CHARSET",
"content": "Disallow set column charset but \"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content)) ENGINE = CSV COLLATE latin1_bin;\" does",
"code": 414,
"sqlReviewReport": {
@@ -243,7 +243,7 @@
- |-
{
"status": "WARNING",
- "title": "column.current-time-count-limit",
+ "title": "COLUMN_CURRENT_TIME_COUNT_LIMIT",
"content": "Table `userTable` has 2 ON UPDATE CURRENT_TIMESTAMP() columns. The count greater than 1.",
"code": 419,
"sqlReviewReport": {
@@ -255,7 +255,7 @@
- |-
{
"status": "WARNING",
- "title": "column.require-default",
+ "title": "COLUMN_REQUIRE_DEFAULT",
"content": "Column `userTable`.`id` doesn't have DEFAULT.",
"code": 420,
"sqlReviewReport": {
@@ -267,7 +267,7 @@
- |-
{
"status": "WARNING",
- "title": "column.require-default",
+ "title": "COLUMN_REQUIRE_DEFAULT",
"content": "Column `userTable`.`name` doesn't have DEFAULT.",
"code": 420,
"sqlReviewReport": {
@@ -279,7 +279,7 @@
- |-
{
"status": "WARNING",
- "title": "column.require-default",
+ "title": "COLUMN_REQUIRE_DEFAULT",
"content": "Column `userTable`.`roomId` doesn't have DEFAULT.",
"code": 420,
"sqlReviewReport": {
@@ -291,7 +291,7 @@
- |-
{
"status": "WARNING",
- "title": "index.type-no-blob",
+ "title": "INDEX_TYPE_NO_BLOB",
"content": "Columns in index must not be BLOB but `userTable`.`content` is blob",
"code": 804,
"sqlReviewReport": {
@@ -303,7 +303,7 @@
- |-
{
"status": "WARNING",
- "title": "system.charset.allowlist",
+ "title": "SYSTEM_CHARSET_ALLOWLIST",
"content": "\"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content)) ENGINE = CSV COLLATE latin1_bin;\" used disabled charset 'ascii'",
"code": 1001,
"sqlReviewReport": {
@@ -315,7 +315,7 @@
- |-
{
"status": "WARNING",
- "title": "system.collation.allowlist",
+ "title": "SYSTEM_COLLATION_ALLOWLIST",
"content": "\"CREATE TABLE userTable(id INT NOT NULL,name VARCHAR(255) CHARSET ascii,roomId INT,time_created TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',time_updated TIMESTAMP NOT NULL DEFAULT NOW() ON UPDATE NOW() COMMENT 'comment',content BLOB NOT NULL COMMENT 'comment',json_content JSON NOT NULL COMMENT 'comment',INDEX idx1(name),UNIQUE KEY uk1(id, name),FOREIGN KEY fk1(roomId) REFERENCES room(id),INDEX idx_userTable_content(content)) ENGINE = CSV COLLATE latin1_bin;\" used disabled collation 'latin1_bin'",
"code": 1201,
"sqlReviewReport": {
@@ -330,7 +330,7 @@
- |-
{
"status": "ERROR",
- "title": "column.auto-increment-must-integer",
+ "title": "COLUMN_AUTO_INCREMENT_MUST_INTEGER",
"content": "Auto-increment column `t_auto`.`auto_id` requires integer type",
"code": 410,
"sqlReviewReport": {
@@ -342,7 +342,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.column.auto-increment",
+ "title": "NAMING_COLUMN_AUTO_INCREMENT",
"content": "`t_auto`.`auto_id` mismatches auto_increment column naming convention, naming format should be \"^id$\"",
"code": 307,
"sqlReviewReport": {
@@ -354,7 +354,7 @@
- |-
{
"status": "WARNING",
- "title": "column.required",
+ "title": "COLUMN_REQUIRED",
"content": "Table `t_auto` requires columns: created_ts, creator_id, id, updated_ts, updater_id",
"code": 401,
"sqlReviewReport": {
@@ -366,7 +366,7 @@
- |-
{
"status": "WARNING",
- "title": "column.auto-increment-initial-value",
+ "title": "COLUMN_AUTO_INCREMENT_INITIAL_VALUE",
"content": "The initial auto-increment value in table `t_auto` is 2, which doesn't equal 20",
"code": 416,
"sqlReviewReport": {
@@ -378,7 +378,7 @@
- |-
{
"status": "WARNING",
- "title": "column.auto-increment-must-unsigned",
+ "title": "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED",
"content": "Auto-increment column `t_auto`.`auto_id` is not UNSIGNED type",
"code": 417,
"sqlReviewReport": {
@@ -390,7 +390,7 @@
- |-
{
"status": "WARNING",
- "title": "index.pk-type-limit",
+ "title": "INDEX_PK_TYPE_LIMIT",
"content": "Columns in primary key must be INT/BIGINT but `t_auto`.`auto_id` is varchar(20)",
"code": 803,
"sqlReviewReport": {
@@ -405,7 +405,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.where.require.update-delete",
+ "title": "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE",
"content": "\"DELETE FROM tech_book;\" requires WHERE clause",
"code": 202,
"sqlReviewReport": {
@@ -417,7 +417,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.dml-dry-run",
+ "title": "STATEMENT_DML_DRY_RUN",
"content": "\"DELETE FROM tech_book\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",
"code": 208,
"sqlReviewReport": {
@@ -429,7 +429,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.affected-row-limit",
+ "title": "STATEMENT_AFFECTED_ROW_LIMIT",
"content": "\"DELETE FROM tech_book;\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",
"code": 209,
"sqlReviewReport": {
@@ -444,7 +444,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.where.no-leading-wildcard-like",
+ "title": "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE",
"content": "\"DELETE FROM tech_book WHERE name like \"%abc\";\" uses leading wildcard LIKE",
"code": 204,
"sqlReviewReport": {
@@ -456,7 +456,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.dml-dry-run",
+ "title": "STATEMENT_DML_DRY_RUN",
"content": "\"DELETE FROM tech_book WHERE name like \"%abc\"\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",
"code": 208,
"sqlReviewReport": {
@@ -468,7 +468,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.affected-row-limit",
+ "title": "STATEMENT_AFFECTED_ROW_LIMIT",
"content": "\"DELETE FROM tech_book WHERE name like \"%abc\";\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",
"code": 209,
"sqlReviewReport": {
@@ -483,7 +483,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.select.no-select-all",
+ "title": "STATEMENT_SELECT_NO_SELECT_ALL",
"content": "\"INSERT INTO t_copy SELECT * FROM t;\" uses SELECT all",
"code": 203,
"sqlReviewReport": {
@@ -495,7 +495,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.where.require.select",
+ "title": "STATEMENT_WHERE_REQUIRE_SELECT",
"content": "\"INSERT INTO t_copy SELECT * FROM t;\" requires WHERE clause",
"code": 202,
"sqlReviewReport": {
@@ -507,7 +507,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.dml-dry-run",
+ "title": "STATEMENT_DML_DRY_RUN",
"content": "\"INSERT INTO t_copy SELECT * FROM t\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.t_copy' doesn't exist",
"code": 208,
"sqlReviewReport": {
@@ -519,7 +519,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.insert.row-limit",
+ "title": "STATEMENT_INSERT_ROW_LIMIT",
"content": "\"INSERT INTO t_copy SELECT * FROM t;\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.t_copy' doesn't exist",
"code": 1101,
"sqlReviewReport": {
@@ -531,7 +531,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.insert.must-specify-column",
+ "title": "STATEMENT_INSERT_MUST_SPECIFY_COLUMN",
"content": "The INSERT statement must specify columns but \"INSERT INTO t_copy SELECT * FROM t;\" does not",
"code": 1107,
"sqlReviewReport": {
@@ -546,7 +546,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.dml-dry-run",
+ "title": "STATEMENT_DML_DRY_RUN",
"content": "\"INSERT INTO t VALUES (1, 1, now(), 1, now())\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.t' doesn't exist",
"code": 208,
"sqlReviewReport": {
@@ -558,7 +558,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.insert.must-specify-column",
+ "title": "STATEMENT_INSERT_MUST_SPECIFY_COLUMN",
"content": "The INSERT statement must specify columns but \"INSERT INTO t VALUES (1, 1, now(), 1, now());\" does not",
"code": 1107,
"sqlReviewReport": {
@@ -573,7 +573,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.dml-dry-run",
+ "title": "STATEMENT_DML_DRY_RUN",
"content": "\"DELETE FROM tech_book WHERE id = (SELECT max(id) FROM tech_book WHERE name = 'bytebase')\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",
"code": 208,
"sqlReviewReport": {
@@ -585,7 +585,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.affected-row-limit",
+ "title": "STATEMENT_AFFECTED_ROW_LIMIT",
"content": "\"DELETE FROM tech_book WHERE id = (SELECT max(id) FROM tech_book WHERE name = 'bytebase');\" dry runs failed: Error 1146 (42S02): Table 'testsqlreview.tech_book' doesn't exist",
"code": 209,
"sqlReviewReport": {
@@ -600,7 +600,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.disallow-commit",
+ "title": "STATEMENT_DISALLOW_COMMIT",
"content": "Commit is not allowed, related statement: \"COMMIT;\"",
"code": 206,
"sqlReviewReport": {
@@ -647,7 +647,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.affected-row-limit",
+ "title": "STATEMENT_AFFECTED_ROW_LIMIT",
"content": "\"DELETE FROM user WHERE id <= 10;\" affected 10 rows (estimated). The count exceeds 5.",
"code": 209,
"sqlReviewReport": {
@@ -672,7 +672,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.insert.row-limit",
+ "title": "STATEMENT_INSERT_ROW_LIMIT",
"content": "\"INSERT INTO user(id, name) SELECT id, name FROM (SELECT 1 AS id, 'a' AS name WHERE 1=1 UNION ALL\n SELECT 2 AS id, 'b' AS name WHERE 1=1 UNION ALL\n SELECT 3 AS id, 'c' AS name WHERE 1=1 UNION ALL\n SELECT 4 AS id, 'd' AS name WHERE 1=1 UNION ALL\n SELECT 5 AS id, 'e' AS name WHERE 1=1 UNION ALL\n SELECT 6 AS id, 'f' AS name WHERE 1=1 UNION ALL\n SELECT 7 AS id, 'g' AS name WHERE 1=1 UNION ALL\n SELECT 8 AS id, 'h' AS name WHERE 1=1 UNION ALL\n SELECT 9 AS id, 'i' AS name WHERE 1=1 UNION ALL\n SELECT 10 AS id, 'j' AS name WHERE 1=1) value_table WHERE 1=1;\" inserts 10 rows. The count exceeds 5.",
"code": 1101,
"sqlReviewReport": {
@@ -687,7 +687,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.disallow-limit",
+ "title": "STATEMENT_DISALLOW_LIMIT",
"content": "LIMIT clause is forbidden in INSERT, UPDATE and DELETE statement, but \"INSERT INTO user(id, name) SELECT id, name FROM user WHERE id=1 LIMIT 1;\" uses",
"code": 1103,
"sqlReviewReport": {
@@ -702,7 +702,7 @@
- |-
{
"status": "WARNING",
- "title": "table.disallow-partition",
+ "title": "TABLE_DISALLOW_PARTITION",
"content": "Table partition is forbidden, but \"ALTER TABLE user PARTITION BY HASH(id) PARTITIONS 8;\" creates",
"code": 608,
"sqlReviewReport": {
@@ -719,7 +719,7 @@
- |-
{
"status": "WARNING",
- "title": "statement.merge-alter-table",
+ "title": "STATEMENT_MERGE_ALTER_TABLE",
"content": "There are 2 statements to modify table `user`",
"code": 207,
"sqlReviewReport": {
@@ -731,7 +731,7 @@
- |-
{
"status": "WARNING",
- "title": "column.disallow-change-type",
+ "title": "COLUMN_DISALLOW_CHANGE_TYPE",
"content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" changes column type",
"code": 403,
"sqlReviewReport": {
@@ -743,7 +743,7 @@
- |-
{
"status": "WARNING",
- "title": "column.disallow-change",
+ "title": "COLUMN_DISALLOW_CHANGE",
"content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" contains CHANGE COLUMN statement",
"code": 406,
"sqlReviewReport": {
@@ -755,7 +755,7 @@
- |-
{
"status": "WARNING",
- "title": "column.disallow-changing-order",
+ "title": "COLUMN_DISALLOW_CHANGING_ORDER",
"content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" changes column order",
"code": 407,
"sqlReviewReport": {
@@ -767,7 +767,7 @@
- |-
{
"status": "WARNING",
- "title": "schema.backward-compatibility",
+ "title": "SCHEMA_BACKWARD_COMPATIBILITY",
"content": "\"ALTER TABLE user CHANGE name name varchar(320) NOT NULL DEFAULT '' COMMENT 'COMMENT' FIRST;\" may cause incompatibility with the existing data and code",
"code": 111,
"sqlReviewReport": {
@@ -782,7 +782,7 @@
- |-
{
"status": "ERROR",
- "title": "table.drop-naming-convention",
+ "title": "TABLE_DROP_NAMING_CONVENTION",
"content": "`user` mismatches drop table naming convention, naming format should be \"_delete$\"",
"code": 603,
"sqlReviewReport": {
@@ -794,7 +794,7 @@
- |-
{
"status": "WARNING",
- "title": "schema.backward-compatibility",
+ "title": "SCHEMA_BACKWARD_COMPATIBILITY",
"content": "\"DROP TABLE user;\" may cause incompatibility with the existing data and code",
"code": 103,
"sqlReviewReport": {
diff --git a/backend/tests/test-data/sql_review_pg.yaml b/backend/tests/test-data/sql_review_pg.yaml
index 699420d912..2561b4f587 100644
--- a/backend/tests/test-data/sql_review_pg.yaml
+++ b/backend/tests/test-data/sql_review_pg.yaml
@@ -47,7 +47,7 @@
- |-
{
"status": "ERROR",
- "title": "table.require-pk",
+ "title": "TABLE_REQUIRE_PK",
"content": "Table \"public\".\"userTable\" requires PRIMARY KEY, related statement: \"CREATE TABLE \\\"userTable\\\"( id INT, name VARCHAR(255), \\\"roomId\\\" INT, CONSTRAINT uk1 UNIQUE (id, name), CONSTRAINT fk1 FOREIGN KEY (\\\"roomId\\\") REFERENCES room(id) );\"",
"code": 601,
"sqlReviewReport": {
@@ -59,7 +59,7 @@
- |-
{
"status": "ERROR",
- "title": "table.no-foreign-key",
+ "title": "TABLE_NO_FOREIGN_KEY",
"content": "Foreign key is not allowed in the table \"public\".\"userTable\", related statement: \"CREATE TABLE \"userTable\"( id INT, name VARCHAR(255), \"roomId\" INT, CONSTRAINT uk1 UNIQUE (id, name), CONSTRAINT fk1 FOREIGN KEY (\"roomId\") REFERENCES room(id) );\"",
"code": 602,
"sqlReviewReport": {
@@ -71,7 +71,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.table",
+ "title": "NAMING_TABLE",
"content": "\"userTable\" mismatches table naming convention, naming format should be \"^[a-z]+(_[a-z]+)*$\"",
"code": 301,
"sqlReviewReport": {
@@ -83,7 +83,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.column",
+ "title": "NAMING_COLUMN",
"content": "\"userTable\".\"roomId\" mismatches column naming convention, naming format should be \"^[a-z]+(_[a-z]+)*$\"",
"code": 302,
"sqlReviewReport": {
@@ -95,7 +95,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.index.uk",
+ "title": "NAMING_INDEX_UK",
"content": "Unique key in table \"userTable\" mismatches the naming convention, expect \"^$|^uk_userTable_id_name$\" but found \"uk1\"",
"code": 304,
"sqlReviewReport": {
@@ -107,7 +107,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.index.fk",
+ "title": "NAMING_INDEX_FK",
"content": "Foreign key in table \"userTable\" mismatches the naming convention, expect \"^$|^fk_userTable_roomId_room_id$\" but found \"fk1\"",
"code": 305,
"sqlReviewReport": {
@@ -119,7 +119,7 @@
- |-
{
"status": "WARNING",
- "title": "column.required",
+ "title": "COLUMN_REQUIRED",
"content": "Table \"userTable\" requires columns: created_ts, creator_id, updated_ts, updater_id",
"code": 401,
"sqlReviewReport": {
@@ -131,7 +131,7 @@
- |-
{
"status": "WARNING",
- "title": "column.no-null",
+ "title": "COLUMN_NO_NULL",
"content": "Column \"id\" in \"public\".\"userTable\" cannot have NULL value",
"code": 402,
"sqlReviewReport": {
@@ -143,7 +143,7 @@
- |-
{
"status": "WARNING",
- "title": "column.no-null",
+ "title": "COLUMN_NO_NULL",
"content": "Column \"name\" in \"public\".\"userTable\" cannot have NULL value",
"code": 402,
"sqlReviewReport": {
@@ -155,7 +155,7 @@
- |-
{
"status": "WARNING",
- "title": "column.no-null",
+ "title": "COLUMN_NO_NULL",
"content": "Column \"roomId\" in \"public\".\"userTable\" cannot have NULL value",
"code": 402,
"sqlReviewReport": {
@@ -170,7 +170,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.where.require.update-delete",
+ "title": "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE",
"content": "\"DELETE FROM t\" requires WHERE clause",
"code": 202,
"sqlReviewReport": {
@@ -185,7 +185,7 @@
- |-
{
"status": "ERROR",
- "title": "statement.where.no-leading-wildcard-like",
+ "title": "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE",
"content": "\"DELETE FROM t WHERE a like '%abc'\" uses leading wildcard LIKE",
"code": 204,
"sqlReviewReport": {
@@ -233,7 +233,7 @@
- |-
{
"status": "WARNING",
- "title": "naming.index.pk",
+ "title": "NAMING_INDEX_PK",
"content": "Primary key in table \"tech_book\" mismatches the naming convention, expect \"^$|^pk_tech_book_id$\" but found \"pk1\"",
"code": 306,
"sqlReviewReport": {
@@ -245,7 +245,7 @@
- |-
{
"status": "WARNING",
- "title": "schema.backward-compatibility",
+ "title": "SCHEMA_BACKWARD_COMPATIBILITY",
"content": "\"ALTER INDEX pk_tech_book_id RENAME TO pk1\" may cause incompatibility with the existing data and code",
"code": 102,
"sqlReviewReport": {
diff --git a/frontend/src/bbkit/BBAttention.vue b/frontend/src/bbkit/BBAttention.vue
index 290918185a..ce1931fa25 100644
--- a/frontend/src/bbkit/BBAttention.vue
+++ b/frontend/src/bbkit/BBAttention.vue
@@ -7,7 +7,7 @@
<div v-if="description" class="text-sm">
<p class="whitespace-pre-wrap">
{{ $te(description) ? $t(description) : description }}
- <LearnMoreLink :url="link" class="ml-1 text-sm" />
+ <LearnMoreLink v-if="link" :url="link" class="ml-1 text-sm" />
</p>
</div>
</slot>
diff --git a/frontend/src/components/Plan/components/common/CheckResultItem.vue b/frontend/src/components/Plan/components/common/CheckResultItem.vue
index 50d5569441..788528aee2 100644
--- a/frontend/src/components/Plan/components/common/CheckResultItem.vue
+++ b/frontend/src/components/Plan/components/common/CheckResultItem.vue
@@ -41,7 +41,12 @@
import { AlertCircleIcon, CheckCircleIcon, XCircleIcon } from "lucide-vue-next";
import { NTag } from "naive-ui";
import { computed } from "vue";
-import { getRuleLocalization, ruleTemplateMapV2 } from "@/types";
+import {
+ getRuleLocalization,
+ ruleTemplateMapV2,
+ ruleTypeToString,
+} from "@/types";
+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
export interface CheckResultPosition {
line: number;
@@ -85,9 +90,16 @@ const statusColor = computed(() => {
});
const getRuleTemplateByType = (type: string) => {
+ // Convert string to enum
+ const typeKey = type as keyof typeof SQLReviewRule_Type;
+ const typeEnum = SQLReviewRule_Type[typeKey];
+ if (typeEnum === undefined) {
+ return;
+ }
+
for (const mapByType of ruleTemplateMapV2.values()) {
- if (mapByType.has(type)) {
- return mapByType.get(type);
+ if (mapByType.has(typeEnum)) {
+ return mapByType.get(typeEnum);
}
}
return;
@@ -115,7 +127,10 @@ const displayTitle = computed(() => {
const rule = getRuleTemplateByType(props.title);
if (rule) {
- const ruleLocalization = getRuleLocalization(rule.type, rule.engine);
+ const ruleLocalization = getRuleLocalization(
+ ruleTypeToString(rule.type),
+ rule.engine
+ );
const title = messageWithCode(ruleLocalization.title, code);
return title;
} else if (props.title.startsWith("builtin.")) {
diff --git a/frontend/src/components/PlanCheckRun/PlanCheckRunDetail.vue b/frontend/src/components/PlanCheckRun/PlanCheckRunDetail.vue
index 2d2624c2fc..928bedb4d1 100644
--- a/frontend/src/components/PlanCheckRun/PlanCheckRunDetail.vue
+++ b/frontend/src/components/PlanCheckRun/PlanCheckRunDetail.vue
@@ -254,6 +254,7 @@ import {
GeneralErrorCode,
getRuleLocalization,
ruleTemplateMapV2,
+ ruleTypeToString,
SQLReviewPolicyErrorCode,
} from "@/types";
import type {
@@ -265,7 +266,10 @@ import {
PlanCheckRun_ResultSchema,
PlanCheckRun_Status,
} from "@/types/proto-es/v1/plan_service_pb";
-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";
+import {
+ SQLReviewRule_Level,
+ SQLReviewRule_Type,
+} from "@/types/proto-es/v1/review_config_service_pb";
import { Advice_Level } from "@/types/proto-es/v1/sql_service_pb";
import { convertPositionLineToMonacoLine } from "@/utils/v1/position";
import { usePlanCheckRunContext } from "./context";
@@ -341,16 +345,23 @@ const showCancelButton = computed(
);
const getRuleTemplateByType = (type: string) => {
+ // Convert string to enum
+ const typeKey = type as keyof typeof SQLReviewRule_Type;
+ const typeEnum = SQLReviewRule_Type[typeKey];
+ if (typeEnum === undefined) {
+ return;
+ }
+
if (props.database) {
return ruleTemplateMapV2
.get(props.database.instanceResource.engine)
- ?.get(type);
+ ?.get(typeEnum);
}
// fallback
for (const mapByType of ruleTemplateMapV2.values()) {
- if (mapByType.has(type)) {
- return mapByType.get(type);
+ if (mapByType.has(typeEnum)) {
+ return mapByType.get(typeEnum);
}
}
return;
@@ -360,6 +371,15 @@ const isBuiltinRule = (type: string) => {
return type.startsWith("builtin.");
};
+const builtinRuleType = (type: string): SQLReviewRule_Type | undefined => {
+ // Convert dot-separated to SCREAMING_SNAKE_CASE
+ const typeKey = type
+ .toUpperCase()
+ .replace(/\./g, "_")
+ .replace(/-/g, "_") as keyof typeof SQLReviewRule_Type;
+ return SQLReviewRule_Type[typeKey];
+};
+
const builtinRuleLevel = (type: string): SQLReviewRule_Level => {
switch (type) {
case "builtin.prior-backup-check":
@@ -383,7 +403,10 @@ const categoryAndTitle = (
}
const rule = getRuleTemplateByType(checkResult.title);
if (rule) {
- const ruleLocalization = getRuleLocalization(rule.type, rule.engine);
+ const ruleLocalization = getRuleLocalization(
+ ruleTypeToString(rule.type),
+ rule.engine
+ );
const key = `sql-review.category.${rule.category.toLowerCase()}`;
const category = t(key);
const title = messageWithCode(ruleLocalization.title, code);
@@ -492,8 +515,12 @@ const reviewPolicy = useReviewPolicyForDatabase(
const getActiveRule = (type: string): RuleTemplateV2 | undefined => {
const engine = props.database?.instanceResource.engine;
if (isBuiltinRule(type) && engine) {
+ const typeEnum = builtinRuleType(type);
+ if (!typeEnum) {
+ return undefined;
+ }
return {
- type,
+ type: typeEnum,
category: "BUILTIN",
engine: engine,
level: builtinRuleLevel(type),
diff --git a/frontend/src/components/SQLReview/SQLReviewConfig.vue b/frontend/src/components/SQLReview/SQLReviewConfig.vue
index 8e964c070a..3822ae4b24 100644
--- a/frontend/src/components/SQLReview/SQLReviewConfig.vue
+++ b/frontend/src/components/SQLReview/SQLReviewConfig.vue
@@ -45,13 +45,14 @@
import { NButton, NEmpty } from "naive-ui";
import { ref } from "vue";
import type { Engine } from "@/types/proto-es/v1/common_pb";
+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
import type { RuleTemplateV2 } from "@/types/sqlReview";
import SQLReviewRulesSelectPanel from "./components/SQLReviewRulesSelectPanel.vue";
import SQLReviewTabsByEngine from "./components/SQLReviewTabsByEngine.vue";
import SQLRuleTableWithFilter from "./components/SQLRuleTableWithFilter.vue";
defineProps<{
- ruleMapByEngine: Map<Engine, Map<string, RuleTemplateV2>>;
+ ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;
}>();
const emit = defineEmits<{
diff --git a/frontend/src/components/SQLReview/SQLReviewCreation.vue b/frontend/src/components/SQLReview/SQLReviewCreation.vue
index 27d5bcea94..2d47e7de1d 100644
--- a/frontend/src/components/SQLReview/SQLReviewCreation.vue
+++ b/frontend/src/components/SQLReview/SQLReviewCreation.vue
@@ -68,6 +68,7 @@ import {
getRuleMapByEngine,
} from "@/types";
import { Engine } from "@/types/proto-es/v1/common_pb";
+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
import { hasWorkspacePermissionV2, sqlReviewPolicySlug } from "@/utils";
import { getTemplateId } from "./components";
import SQLReviewConfig from "./SQLReviewConfig.vue";
@@ -78,7 +79,7 @@ interface LocalState {
name: string;
resourceId: string;
attachedResources: string[];
- selectedRuleMapByEngine: Map<Engine, Map<string, RuleTemplateV2>>;
+ selectedRuleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;
selectedTemplateId: string | undefined;
ruleUpdated: boolean;
pendingApplyTemplate: SQLReviewPolicyTemplateV2 | undefined;
@@ -262,7 +263,7 @@ const upsertRule = (
if (!state.selectedRuleMapByEngine.has(rule.engine)) {
state.selectedRuleMapByEngine.set(
rule.engine,
- new Map<string, RuleTemplateV2>()
+ new Map<SQLReviewRule_Type, RuleTemplateV2>()
);
}
diff --git a/frontend/src/components/SQLReview/components/RuleConfigComponents/RuleConfig.vue b/frontend/src/components/SQLReview/components/RuleConfigComponents/RuleConfig.vue
index 1ef0824f00..acc13eb7c6 100644
--- a/frontend/src/components/SQLReview/components/RuleConfigComponents/RuleConfig.vue
+++ b/frontend/src/components/SQLReview/components/RuleConfigComponents/RuleConfig.vue
@@ -59,7 +59,7 @@
/>
<TemplateComponent
v-else-if="config.payload.type === 'TEMPLATE'"
- :rule-type="rule.type"
+ :rule-type="ruleTypeToString(rule.type)"
:value="payload[index] as string"
:config="config"
:disabled="disabled"
@@ -75,7 +75,7 @@ import { NTooltip } from "naive-ui";
import { ref, watch } from "vue";
import { useI18n } from "vue-i18n";
import type { RuleConfigComponent, RuleTemplateV2 } from "@/types/sqlReview";
-import { getRuleLocalizationKey } from "@/types/sqlReview";
+import { getRuleLocalizationKey, ruleTypeToString } from "@/types/sqlReview";
import BooleanComponent from "./BooleanComponent.vue";
import NumberComponent from "./NumberComponent.vue";
import StringArrayComponent from "./StringArrayComponent.vue";
@@ -95,14 +95,14 @@ const payload = ref<PayloadValueType[]>([]);
const configTitle = (config: RuleConfigComponent): string => {
const key = `sql-review.rule.${getRuleLocalizationKey(
- props.rule.type
+ ruleTypeToString(props.rule.type)
)}.component.${config.key}.title`;
return t(key);
};
const configTooltip = (config: RuleConfigComponent): string => {
const key = `sql-review.rule.${getRuleLocalizationKey(
- props.rule.type
+ ruleTypeToString(props.rule.type)
)}.component.${config.key}.tooltip`;
return te(key) ? t(key) : "";
};
diff --git a/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vue b/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vue
index 614cbe1412..3fa3e36bee 100644
--- a/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vue
+++ b/frontend/src/components/SQLReview/components/SQLReviewRulesSelectPanel.vue
@@ -46,6 +46,7 @@
import { NButton } from "naive-ui";
import { Drawer, DrawerContent } from "@/components/v2";
import { type Engine } from "@/types/proto-es/v1/common_pb";
+import type { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
import type { RuleTemplateV2 } from "@/types/sqlReview";
import { ruleTemplateMapV2 } from "@/types/sqlReview";
import SQLReviewTabsByEngine from "./SQLReviewTabsByEngine.vue";
@@ -54,7 +55,7 @@ import { getRuleKey } from "./utils";
const props = defineProps<{
show: boolean;
- selectedRuleMap: Map<Engine, Map<string, RuleTemplateV2>>;
+ selectedRuleMap: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;
}>();
const emit = defineEmits<{
@@ -86,7 +87,8 @@ const onSelectedRuleKeysUpdateForEngine = (engine: Engine, keys: string[]) => {
}
const [engineStr, ruleKey] = key.split(":");
const engineNum = parseInt(engineStr) as Engine;
- const rule = ruleTemplateMapV2.get(engineNum)?.get(ruleKey);
+ const ruleType = parseInt(ruleKey) as SQLReviewRule_Type;
+ const rule = ruleTemplateMapV2.get(engineNum)?.get(ruleType);
if (rule) {
emit("rule-select", rule);
}
@@ -96,7 +98,8 @@ const onSelectedRuleKeysUpdateForEngine = (engine: Engine, keys: string[]) => {
for (const oldKey of oldSelectedKeys) {
const [engineStr, ruleKey] = oldKey.split(":");
const engineNum = parseInt(engineStr) as Engine;
- const rule = props.selectedRuleMap.get(engineNum)?.get(ruleKey);
+ const ruleType = parseInt(ruleKey) as SQLReviewRule_Type;
+ const rule = props.selectedRuleMap.get(engineNum)?.get(ruleType);
if (rule) {
emit("rule-remove", rule);
}
diff --git a/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vue b/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vue
index 5d6935fc90..e38bb8cbdc 100644
--- a/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vue
+++ b/frontend/src/components/SQLReview/components/SQLReviewTabsByEngine.vue
@@ -32,12 +32,13 @@ import { computed, ref, watch } from "vue";
import { RichEngineName } from "@/components/v2";
import type { RuleTemplateV2 } from "@/types";
import { Engine } from "@/types/proto-es/v1/common_pb";
+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
import { supportedEngineV1List } from "@/utils";
const selectedEngine = ref<Engine>(0); // UNSPECIFIED
const props = defineProps<{
- ruleMapByEngine: Map<Engine, Map<string, RuleTemplateV2>>;
+ ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;
}>();
watch(
@@ -53,12 +54,14 @@ const engineWithOrderRank = computed(() => {
}, new Map<Engine, number>());
});
-const sortedData = computed((): [Engine, Map<string, RuleTemplateV2>][] => {
- return [...props.ruleMapByEngine.entries()].sort(([e1], [e2]) => {
- return (
- (engineWithOrderRank.value.get(e1) ?? 0) -
- (engineWithOrderRank.value.get(e2) ?? 0)
- );
- });
-});
+const sortedData = computed(
+ (): [Engine, Map<SQLReviewRule_Type, RuleTemplateV2>][] => {
+ return [...props.ruleMapByEngine.entries()].sort(([e1], [e2]) => {
+ return (
+ (engineWithOrderRank.value.get(e1) ?? 0) -
+ (engineWithOrderRank.value.get(e2) ?? 0)
+ );
+ });
+ }
+);
</script>
diff --git a/frontend/src/components/SQLReview/components/SQLRuleEditDialog.vue b/frontend/src/components/SQLReview/components/SQLRuleEditDialog.vue
index 9efd12c4f1..671b4334d8 100644
--- a/frontend/src/components/SQLReview/components/SQLRuleEditDialog.vue
+++ b/frontend/src/components/SQLReview/components/SQLRuleEditDialog.vue
@@ -1,6 +1,6 @@
<template>
<BBModal
- :title="getRuleLocalization(rule.type, rule.engine).title"
+ :title="getRuleLocalization(ruleTypeToString(rule.type), rule.engine).title"
@close="$emit('cancel')"
>
<div class="flex flex-col gap-y-4 w-[calc(100vw-5rem)] sm:w-[40rem] pb-1">
@@ -18,7 +18,7 @@
</div>
</div>
<div class="textinfolabel flex items-center gap-x-2">
- {{ getRuleLocalization(rule.type, rule.engine).title }}
+ {{ getRuleLocalization(ruleTypeToString(rule.type), rule.engine).title }}
<a
:href="`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`"
target="__blank"
@@ -45,7 +45,7 @@
{{ $t("common.description") }}
</h3>
<div class="text-sm text-gray-700">
- {{ getRuleLocalization(rule.type, rule.engine).description || $t('common.description') }}
+ {{ getRuleLocalization(ruleTypeToString(rule.type), rule.engine).description || $t('common.description') }}
</div>
</div>
<RuleConfig
@@ -74,7 +74,7 @@ import { payloadValueListToComponentList } from "@/components/SQLReview/componen
import { RichEngineName } from "@/components/v2";
import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";
import type { RuleTemplateV2 } from "@/types/sqlReview";
-import { getRuleLocalization } from "@/types/sqlReview";
+import { getRuleLocalization, ruleTypeToString } from "@/types/sqlReview";
import RuleConfig from "./RuleConfigComponents/RuleConfig.vue";
import RuleLevelSwitch from "./RuleLevelSwitch.vue";
diff --git a/frontend/src/components/SQLReview/components/SQLRuleFilter.vue b/frontend/src/components/SQLReview/components/SQLRuleFilter.vue
index aa5c4f7f3a..47a602ecde 100644
--- a/frontend/src/components/SQLReview/components/SQLRuleFilter.vue
+++ b/frontend/src/components/SQLReview/components/SQLRuleFilter.vue
@@ -53,7 +53,7 @@
import { NCheckbox, NDivider } from "naive-ui";
import { SearchBox } from "@/components/v2";
import type { RuleTemplateV2 } from "@/types";
-import { getRuleLocalization } from "@/types";
+import { getRuleLocalization, ruleTypeToString } from "@/types";
import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";
import type { RuleListWithCategory } from "./SQLReviewCategoryTabFilter.vue";
import SQLReviewCategoryTabFilter from "./SQLReviewCategoryTabFilter.vue";
@@ -110,8 +110,11 @@ const filterRule = (rule: RuleTemplateV2) => {
const filterRuleByKeyword = (rule: RuleTemplateV2, searchText: string) => {
const keyword = searchText.trim().toLowerCase();
if (!keyword) return true;
- if (rule.type.toLowerCase().includes(keyword)) return true;
- const localization = getRuleLocalization(rule.type, rule.engine);
+ if (ruleTypeToString(rule.type).toLowerCase().includes(keyword)) return true;
+ const localization = getRuleLocalization(
+ ruleTypeToString(rule.type),
+ rule.engine
+ );
if (localization.title.toLowerCase().includes(keyword)) return true;
if (localization.description.toLowerCase().includes(keyword)) return true;
return false;
diff --git a/frontend/src/components/SQLReview/components/SQLRuleTable.vue b/frontend/src/components/SQLReview/components/SQLRuleTable.vue
index 91d3866f80..90f39360c3 100644
--- a/frontend/src/components/SQLReview/components/SQLRuleTable.vue
+++ b/frontend/src/components/SQLReview/components/SQLRuleTable.vue
@@ -39,7 +39,7 @@
<div class="flex justify-between items-center gap-x-2">
<div class="flex items-center gap-x-1">
<span>
- {{ getRuleLocalization(rule.type, rule.engine).title }}
+ {{ getRuleLocalization(ruleTypeToString(rule.type), rule.engine).title }}
<a
:href="`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`"
target="_blank"
@@ -79,7 +79,7 @@
@level-change="updateLevel(rule, $event)"
/>
<p class="textinfolabel">
- {{ getRuleLocalization(rule.type, rule.engine).description }}
+ {{ getRuleLocalization(ruleTypeToString(rule.type), rule.engine).description }}
</p>
</div>
</div>
@@ -102,7 +102,7 @@ import { NButton, NCheckbox, NDataTable, NDivider } from "naive-ui";
import { computed, reactive } from "vue";
import { useI18n } from "vue-i18n";
import type { RuleTemplateV2 } from "@/types";
-import { getRuleLocalization } from "@/types";
+import { getRuleLocalization, ruleTypeToString } from "@/types";
import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";
import RuleConfig from "./RuleConfigComponents/RuleConfig.vue";
import RuleLevelSwitch from "./RuleLevelSwitch.vue";
@@ -165,12 +165,15 @@ const columns = computed(() => {
type: "expand",
expandable: (rule: RuleTemplateV2) => {
return !!(
- getRuleLocalization(rule.type, rule.engine).description ||
- rule.componentList.length > 0
+ getRuleLocalization(ruleTypeToString(rule.type), rule.engine)
+ .description || rule.componentList.length > 0
);
},
renderExpand: (rule: RuleTemplateV2) => {
- const comment = getRuleLocalization(rule.type, rule.engine).description;
+ const comment = getRuleLocalization(
+ ruleTypeToString(rule.type),
+ rule.engine
+ ).description;
return (
<div class="px-10">
<p class="w-full text-left text-gray-500">{comment}</p>
@@ -203,7 +206,12 @@ const columns = computed(() => {
render: (rule: RuleTemplateV2) => {
return (
<div class="flex items-center gap-x-2">
- <span>{getRuleLocalization(rule.type, rule.engine).title}</span>
+ <span>
+ {
+ getRuleLocalization(ruleTypeToString(rule.type), rule.engine)
+ .title
+ }
+ </span>
<a
href={`https://docs.bytebase.com/sql-review/review-rules#${rule.type}`}
target="_blank"
diff --git a/frontend/src/components/SQLReview/components/utils.ts b/frontend/src/components/SQLReview/components/utils.ts
index 7c9c977503..bd4e0478e5 100644
--- a/frontend/src/components/SQLReview/components/utils.ts
+++ b/frontend/src/components/SQLReview/components/utils.ts
@@ -4,6 +4,7 @@ import type {
SQLReviewPolicy,
} from "@/types";
import { convertPolicyRuleToRuleTemplate, ruleTemplateMapV2 } from "@/types";
+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
import type { PayloadValueType } from "./RuleConfigComponents";
export const getRuleKey = (rule: RuleTemplateV2) =>
@@ -16,7 +17,12 @@ export const rulesToTemplate = (review: SQLReviewPolicy) => {
const ruleTemplateList: RuleTemplateV2[] = [];
for (const rule of review.ruleList) {
- const ruleTemplate = ruleTemplateMapV2.get(rule.engine)?.get(rule.type);
+ // Convert type string to enum for map lookup
+ const typeKey = rule.type as keyof typeof SQLReviewRule_Type;
+ const type =
+ SQLReviewRule_Type[typeKey] ?? SQLReviewRule_Type.TYPE_UNSPECIFIED;
+
+ const ruleTemplate = ruleTemplateMapV2.get(rule.engine)?.get(type);
if (!ruleTemplate) {
continue;
}
diff --git a/frontend/src/locales/sql-review/en-US.json b/frontend/src/locales/sql-review/en-US.json
index 8a3204110f..407107ed61 100644
--- a/frontend/src/locales/sql-review/en-US.json
+++ b/frontend/src/locales/sql-review/en-US.json
@@ -33,55 +33,39 @@
"bb-sql-review-empty-desc": "An empty template. You need to add needed rules by yourself."
},
"rule": {
- "engine-mysql-use-innodb": {
- "title": "Enforce InnoDB storage engine",
- "description": "InnoDB is the default storage engine for MySQL that provides transaction support. It also provides better performance for high-concurrency and low-latency scenarios, and supports online data backup and recovery. It is the preferred choice for OLTP businesses. Suggestion error level: Error"
- },
- "table-require-pk": {
- "title": "Enforce inclusion of primary key in a table",
- "description": "Various data synchronization, comparison, and rollback tools require tables to have primary key. Suggestion error level: Error"
- },
- "table-no-foreign-key": {
- "title": "Prohibit using foreign key constraints",
- "description": "The advantages and disadvantages of foreign key are highly controversial. Using foreign key may significantly increase the difficulty of database changes, scalability (such as sharding), etc. And may even prevent the use of some tools. Therefore, another option is to implement foreign key constraints at the application layer. Suggestion error level: Warning"
- },
- "table-drop-naming-convention": {
- "title": "Restrict the naming format of tables to be deleted",
- "description": "For example, by requiring the \"_del\" suffix, it can effectively prevent accidental deletions. Suggestion error level: Error",
+ "ADVICE_ONLINE_MIGRATION": {
+ "title": "Online migration",
+ "description": "Advise enabling online migration if the migrated table row count exceeds your setting. Suggested error level: Warning",
"component": {
- "format": {
- "title": "Table name format (regex)"
+ "number": {
+ "title": "Threshold value"
}
}
},
- "table-disallow-partition": {
- "title": "Prohibit using partition table",
- "description": "In some database engines, partitioned tables are not mature, and the use and maintenance are inconvenient. Therefore, it is more inclined to use manual data partitioning methods such as database and table sharding. Suggestion error level: Warning"
- },
- "table-disallow-trigger": {
- "title": "Prevent the use of triggers on tables",
- "description": "This rule restricts the usage of triggers on tables. Triggers can introduce complexity and potential performance issues to database operations. By disallowing triggers, the system can maintain a simpler and more predictable behavior. Suggestion error level: Warning"
- },
- "table-no-duplicate-index": {
- "title": "Disallow duplicate indexes",
- "description": "This rule prohibits the creation of duplicate indexes on a table. Duplicate indexes consume extra storage space and can potentially reduce query performance. Suggestion error level: Warning"
+ "BUILTIN_PRIOR_BACKUP_CHECK": {
+ "title": "Prior backup feasibility check",
+ "description": "This rule checks whether a backup can be created before data changes. It verifies the existence of the backup target database and disallows non-supported scenarios. It's builtin and cannot skip."
},
- "table-text-fields-total-length": {
- "title": "Restrict the total length of text fields in a table",
- "description": "This rule limits the amount of data a table can hold, preventing excessive storage usage.",
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": {
+ "title": "Restrict the initial value of auto-increment columns",
+ "description": "based on management requirements to limit the initial value of the auto-increment column. Suggestion error level: Warning",
"component": {
"number": {
- "title": "Maximum length"
+ "title": "Initial value"
}
}
},
- "table-disallow-set-charset": {
- "title": "Prohibit defining character set in table properties",
- "description": "It is recommended to set the charset at the database level. Setting the charset at finer granularity can bring unnecessary complexities. Suggested error level: Error."
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": {
+ "title": "Enforce the use of \"INTEGER\" data type for auto-increment columns",
+ "description": "MySQL's auto-increment column are generally used as business-independent primary key. Using integer types occupies less storage space and makes the primary key index structure more compact, bringing better query and DML performance. Suggested error level: Error"
},
- "table-comment": {
- "title": "Table comment convention",
- "description": "Configure whether the table requires comments and the maximum comment length.",
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": {
+ "title": "Enforce the use of \"UNSIGNED\" data type for auto-increment columns",
+ "description": "Unsigned types do not store negative numbers, and the range of values that can be stored by the same type is doubled, which can avoid auto-increment columns overflow. Suggested error level: Warning"
+ },
+ "COLUMN_COMMENT": {
+ "title": "Column comment convention",
+ "description": "Adding comments to columns is a good development practice, but excessively long comments can decrease the readability of the schema. Suggested error level: Warning",
"component": {
"required": {
"title": "Require comment"
@@ -95,58 +79,159 @@
}
}
},
- "table-disallow-ddl": {
- "title": "Disallow DDL",
- "description": "Configure which tables are prohibited from executing DDL. Suggestion error level: Warning",
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": {
+ "title": "Restrict the number of columns in the table that acquire system time",
+ "description": "Only columns recording the creation time of the record with \"DEFAULT NOW()\" and recording the update time of the record with \"DEFAULT NOW() ON UPDATE\" need to call function to get system time. It is meaningless and will increase resource overhead to record system time in other columns. Suggestion error level: Error"
+ },
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": {
+ "title": "Disallow setting volatile default value on columns",
+ "description": "Volatile functions (e.g., clock_timestamp()) update each row with the value at the time of ALTER TABLE ADD COLUMN execution, potentially causing lengthy updates."
+ },
+ "COLUMN_DISALLOW_CHANGE": {
+ "title": "Prohibit using \"CHANGE COLUMN\" statement",
+ "description": "\"CHANGE COLUMN\" is unique to MySQL syntax and can be used to modify column names and other properties at the same time. However, it may cause the column name to be mistakenly changed when modifying properties. It is recommended to still use standard \"RENAME\" and \"MODIFY\" statements to distinguish between the two types of changes. Suggested error level: Error"
+ },
+ "COLUMN_DISALLOW_CHANGE_TYPE": {
+ "title": "Prohibit modifying column types",
+ "description": "Modifying column types may affect system performance, maintainability, and even lead to data loss. Suggested error level: Warning"
+ },
+ "COLUMN_DISALLOW_CHANGING_ORDER": {
+ "title": "Prohibit changing the order of columns in a table",
+ "description": "Modifying the order of columns may cause some applications or views that depend on the default order of the original table to produce unexpected results, such as \"select *\". Suggested error level: Warning"
+ },
+ "COLUMN_DISALLOW_DROP": {
+ "title": "Prohibit dropping columns",
+ "description": "Prohibit dropping columns. Suggested error level: Warning"
+ },
+ "COLUMN_DISALLOW_DROP_IN_INDEX": {
+ "title": "Prohibit dropping columns in index",
+ "description": "Prohibit dropping columns in index. Suggested error level: Error"
+ },
+ "COLUMN_DISALLOW_SET_CHARSET": {
+ "title": "Prohibit defining character set in column properties",
+ "description": "It is recommended to set the charset at the database level or table level. Setting the charset at finer granularity can bring unnecessary complexities. Suggested error level: Error."
+ },
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": {
+ "title": "Restrict the length of \"CHAR\" data type",
+ "description": "\"CHAR\" is a fixed-length type. For example, the CHAR(20) column will occupy 20 character spaces even if only one character is stored, causing waste. When the string is too long and the length is not fixed, consider using VARCHAR for MySQL and using TEXT for PostgreSQL. Suggestion error level: Error",
"component": {
- "list": {
- "title": "Table names"
+ "number": {
+ "title": "Maximum length"
}
}
},
- "table-limit-size": {
- "title": "Limit DDL operations on tables with a large number of rows",
- "description": "Configure the maximum number of rows in tables for which DDL can be executed. Recommended error level: warning",
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": {
+ "title": "Restrict the length of \"VARCHAR\" data type",
+ "description": "",
"component": {
"number": {
- "title": "Max row count"
+ "title": "Maximum length"
}
}
},
- "table-disallow-dml": {
- "title": "Disallow DML",
- "description": "Configure which tables are prohibited from executing DML. Suggestion error level: Warning",
+ "COLUMN_NO_NULL": {
+ "title": "Enforce \"NOT NULL\" constraints on columns",
+ "description": "Columns cannot have NULL value."
+ },
+ "COLUMN_REQUIRED": {
+ "title": "Enforce the inclusion of specific columns in a table",
+ "description": "Some common columns are helpful for better application maintenance. For example, adding a business-independent \"ID\" column as the primary key avoids primary key conflicts caused by business changes (such as business mergers), and in some scenarios can also bring better data insertion performance. Suggested error level: Warning",
"component": {
"list": {
- "title": "Table names"
+ "title": "Required column names"
}
}
},
- "table-require-charset": {
- "title": "Require charset",
- "description": "The charset of the table must be specified. Suggestion error level: Warning"
+ "COLUMN_REQUIRE_CHARSET": {
+ "title": "Require charset for text columns",
+ "description": "The charset of columns with text data types must be specified. Suggestion error level: Warning"
},
- "table-require-collation": {
- "title": "Require collation",
- "description": "The collation of the table must be specified. Suggestion error level: Warning"
+ "COLUMN_REQUIRE_COLLATION": {
+ "title": "Require collation for text columns",
+ "description": "The collation of columns with text data types must be specified. Suggestion error level: Warning"
},
- "naming-fully-qualified": {
- "title": "Fully qualified object name",
- "description": "Enforce the use of fully qualified object names. For example, “schema.table”, suggested error level: Warning"
+ "COLUMN_REQUIRE_DEFAULT": {
+ "title": "Enforce setting default value on columns",
+ "description": "Setting default values that satisfy business logic can effectively improve the data quality of downstream analytical pipeline. This rule does not check \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\" types. Suggestion error level: Warning"
},
- "naming-table": {
- "title": "Enforce table naming format",
- "description": "The default format is all lowercase letters, separated by underscores between words, and no more than 63 characters long, such as \"abc\" and \"abc_def\". Suggestion error level: Warning",
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": {
+ "title": "Enforce default value on \"NOT NULL\" columns",
+ "description": "For a 'NOT NULL' column, if a value is not assigned to the column when inserting a new row and the column does not have a default value, the database will reject the insertion of that row. Setting a default value for a new column can also ensure compatibility with legacy application. Suggested error level: Error"
+ },
+ "COLUMN_TYPE_DISALLOW_LIST": {
+ "title": "Prohibit the use of certain column data types",
+ "description": "Abusing column types can have serious negative effects on system maintainability and performance. For example, using \"LOB\" column to store large amounts of audio and video data may cause database performance to decrease, backup and recovery times to lengthen, and data synchronization tools incompatible. Suggested error level: Error",
"component": {
- "format": {
- "title": "Table name format (regex)"
- },
- "maxLength": {
- "title": "Length limit"
+ "list": {
+ "title": "Disallow list"
+ }
+ }
+ },
+ "DATABASE_DROP_EMPTY_DATABASE": {
+ "title": "Prohibit deleting non-empty database",
+ "description": "Deletion is only allowed when there are no tables in the database, which can greatly avoid accidental deletion. Suggested error level: Error"
+ },
+ "ENGINE_MYSQL_USE_INNODB": {
+ "title": "Enforce InnoDB storage engine",
+ "description": "InnoDB is the default storage engine for MySQL that provides transaction support. It also provides better performance for high-concurrency and low-latency scenarios, and supports online data backup and recovery. It is the preferred choice for OLTP businesses. Suggestion error level: Error"
+ },
+ "INDEX_CREATE_CONCURRENTLY": {
+ "title": "Enforce concurrent index creation",
+ "description": "In PostgreSQL 11 and above, using the standard statement to create an index will cause table locking and unable to write. Using the \"CONCURRENTLY\" mode can avoid this problem. Suggestion error level: Warning"
+ },
+ "INDEX_KEY_NUMBER_LIMIT": {
+ "title": "Restrict the number of columns in a single index",
+ "description": "A composite index with over 5 columns does not significantly improve query performance, but it occupies a lot of space and reduces DML performance. Suggestion error level: Warning",
+ "component": {
+ "number": {
+ "title": "Maximum column count"
+ }
+ }
+ },
+ "INDEX_NOT_REDUNDANT": {
+ "title": "Disallow redundant indexes",
+ "description": "Redundant index may result in performance loss and occupy additional space. For example, the index on columns (c1, c2) will be treated as redundant indexes if there is already a index on column (c1). Suggestion error level: Warning"
+ },
+ "INDEX_NO_DUPLICATE_COLUMN": {
+ "title": "Prohibit indexes containing duplicate columns",
+ "description": "Creating an index with duplicate columns will result in failure. Suggestion error level: Error"
+ },
+ "INDEX_PK_TYPE_LIMIT": {
+ "title": "Primary key type limit",
+ "description": "Enforce the primary key type to be INT or BIGINT."
+ },
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": {
+ "title": "Allowable list of primary key types",
+ "description": "The appropriate primary key type can optimize storage structure, reduce space usage, and beneficial for insert and query performance. Suggestion error level: Warning",
+ "component": {
+ "list": {
+ "title": "Allow list"
+ }
+ }
+ },
+ "INDEX_TOTAL_NUMBER_LIMIT": {
+ "title": "Restrict the number of indexes on a single table",
+ "description": "Although indexes can improve query performance, they also occupy a lot of space and reduce DML performance. Therefore, it is not recommended to create more than 5 indexes in a table. Suggestion error level: Warning",
+ "component": {
+ "number": {
+ "title": "Maximum index count"
+ }
+ }
+ },
+ "INDEX_TYPE_ALLOW_LIST": {
+ "title": "Allowable list of index types",
+ "description": "Different index types have different performance characteristics. For example, B-tree indexes are suitable for range queries, while hash indexes are suitable for equality queries. Suggestion error level: Warning",
+ "component": {
+ "list": {
+ "title": "Allow list"
}
}
},
- "naming-column": {
+ "INDEX_TYPE_NO_BLOB": {
+ "title": "Prohibit creating indexes on \"BLOB\" and \"TEXT\" data type columns",
+ "description": "The \"BLOB\" type is usually used to store binary data and should not be used as a query condition. If an index is created on this column type by mistake, it will consume a lot of resources and cause serious performance impact. Suggestion error level: Error"
+ },
+ "NAMING_COLUMN": {
"title": "Enforce column naming format",
"description": "The default format is all lowercase letters, separated by underscores between words, which is no more than 63 characters long, such as \"abc\" and \"abc_def\". Suggestion error level: Warning",
"component": {
@@ -158,39 +243,36 @@
}
}
},
- "naming-index-uk": {
- "title": "Enforce unique key naming format",
- "description": "The name is allowed to be empty and named by the database. If not empty, the default format is \"uk_<table name>_<unique key column name combination>\", which is no more than 63 characters long, such as \"uk_my_table_id_name\". Suggestion error level: Warning",
+ "NAMING_COLUMN_AUTO_INCREMENT": {
+ "title": " Enforce auto-increment column naming format",
+ "description": "The default column name is \"ID\", and is no more than 63 characters long.",
"component": {
"format": {
- "title": "Unique key name format",
- "template": {
- "table": "The table name",
- "column_list": "Index column names, joined by _"
- }
+ "title": "Auto-increment column name format (regex)"
},
"maxLength": {
"title": "Length limit"
}
}
},
- "naming-index-pk": {
- "title": "Enforce primary key naming format",
- "description": "The name is allowed to be empty and named by the database. If not empty, the default format is \"pk_<table name>_<unique key column name combination>\", which is no more than 63 characters long, such as \"pk_my_table_id_name\". Suggestion error level: Warning",
+ "NAMING_FULLY_QUALIFIED": {
+ "title": "Fully qualified object name",
+ "description": "Enforce the use of fully qualified object names. For example, “schema.table”, suggested error level: Warning"
+ },
+ "NAMING_IDENTIFIER_CASE": {
+ "title": "Enforce identifier case",
+ "description": "",
"component": {
- "format": {
- "title": "Primary key name format",
- "template": {
- "table": "The table name",
- "column_list": "Index column names, joined by _"
- }
- },
- "maxLength": {
- "title": "Length limit"
+ "upper": {
+ "title": "Upper case"
}
}
},
- "naming-index-fk": {
+ "NAMING_IDENTIFIER_NO_KEYWORD": {
+ "title": "Prohibit using keywords as identifiers",
+ "description": ""
+ },
+ "NAMING_INDEX_FK": {
"title": "Enforce foreign key naming format",
"description": "The name is allowed to be empty and named by the database. If not empty, the default format is \"fk_<table name>_<unique key column name combination>\", which is no more than 63 characters long, such as \"fk_my_table_id_name\". Suggestion error level: Warning",
"component": {
@@ -208,7 +290,7 @@
}
}
},
- "naming-index-idx": {
+ "NAMING_INDEX_IDX": {
"title": "Enforce index naming format",
"description": "The name is allowed to be empty and named by the database. If not empty, the default format is \"idx_<table name>_<unique key column name combination>\", which is no more than 63 characters long, such as \"idx_my_table_id_name\". Suggestion error level: Warning",
"component": {
@@ -224,214 +306,71 @@
}
}
},
- "naming-column-auto-increment": {
- "title": " Enforce auto-increment column naming format",
- "description": "The default column name is \"ID\", and is no more than 63 characters long.",
+ "NAMING_INDEX_PK": {
+ "title": "Enforce primary key naming format",
+ "description": "The name is allowed to be empty and named by the database. If not empty, the default format is \"pk_<table name>_<unique key column name combination>\", which is no more than 63 characters long, such as \"pk_my_table_id_name\". Suggestion error level: Warning",
"component": {
"format": {
- "title": "Auto-increment column name format (regex)"
+ "title": "Primary key name format",
+ "template": {
+ "table": "The table name",
+ "column_list": "Index column names, joined by _"
+ }
},
"maxLength": {
"title": "Length limit"
}
}
},
- "naming-table-no-keyword": {
- "title": "Prohibit using keywords as table names",
- "description": ""
- },
- "naming-identifier-no-keyword": {
- "title": "Prohibit using keywords as identifiers",
- "description": ""
- },
- "naming-identifier-case": {
- "title": "Enforce identifier case",
- "description": "",
- "component": {
- "upper": {
- "title": "Upper case"
- }
- }
- },
- "column-required": {
- "title": "Enforce the inclusion of specific columns in a table",
- "description": "Some common columns are helpful for better application maintenance. For example, adding a business-independent \"ID\" column as the primary key avoids primary key conflicts caused by business changes (such as business mergers), and in some scenarios can also bring better data insertion performance. Suggested error level: Warning",
- "component": {
- "list": {
- "title": "Required column names"
- }
- }
- },
- "column-type-disallow-list": {
- "title": "Prohibit the use of certain column data types",
- "description": "Abusing column types can have serious negative effects on system maintainability and performance. For example, using \"LOB\" column to store large amounts of audio and video data may cause database performance to decrease, backup and recovery times to lengthen, and data synchronization tools incompatible. Suggested error level: Error",
- "component": {
- "list": {
- "title": "Disallow list"
- }
- }
- },
- "column-no-null": {
- "title": "Enforce \"NOT NULL\" constraints on columns",
- "description": "Columns cannot have NULL value."
- },
- "column-disallow-set-charset": {
- "title": "Prohibit defining character set in column properties",
- "description": "It is recommended to set the charset at the database level or table level. Setting the charset at finer granularity can bring unnecessary complexities. Suggested error level: Error."
- },
- "column-disallow-change-type": {
- "title": "Prohibit modifying column types",
- "description": "Modifying column types may affect system performance, maintainability, and even lead to data loss. Suggested error level: Warning"
- },
- "column-disallow-change": {
- "title": "Prohibit using \"CHANGE COLUMN\" statement",
- "description": "\"CHANGE COLUMN\" is unique to MySQL syntax and can be used to modify column names and other properties at the same time. However, it may cause the column name to be mistakenly changed when modifying properties. It is recommended to still use standard \"RENAME\" and \"MODIFY\" statements to distinguish between the two types of changes. Suggested error level: Error"
- },
- "column-disallow-changing-order": {
- "title": "Prohibit changing the order of columns in a table",
- "description": "Modifying the order of columns may cause some applications or views that depend on the default order of the original table to produce unexpected results, such as \"select *\". Suggested error level: Warning"
- },
- "column-disallow-drop": {
- "title": "Prohibit dropping columns",
- "description": "Prohibit dropping columns. Suggested error level: Warning"
- },
- "column-disallow-drop-in-index": {
- "title": "Prohibit dropping columns in index",
- "description": "Prohibit dropping columns in index. Suggested error level: Error"
- },
- "column-set-default-for-not-null": {
- "title": "Enforce default value on \"NOT NULL\" columns",
- "description": "For a 'NOT NULL' column, if a value is not assigned to the column when inserting a new row and the column does not have a default value, the database will reject the insertion of that row. Setting a default value for a new column can also ensure compatibility with legacy application. Suggested error level: Error"
- },
- "column-auto-increment-must-integer": {
- "title": "Enforce the use of \"INTEGER\" data type for auto-increment columns",
- "description": "MySQL's auto-increment column are generally used as business-independent primary key. Using integer types occupies less storage space and makes the primary key index structure more compact, bringing better query and DML performance. Suggested error level: Error"
- },
- "column-auto-increment-must-unsigned": {
- "title": "Enforce the use of \"UNSIGNED\" data type for auto-increment columns",
- "description": "Unsigned types do not store negative numbers, and the range of values that can be stored by the same type is doubled, which can avoid auto-increment columns overflow. Suggested error level: Warning"
- },
- "column-comment": {
- "title": "Column comment convention",
- "description": "Adding comments to columns is a good development practice, but excessively long comments can decrease the readability of the schema. Suggested error level: Warning",
+ "NAMING_INDEX_UK": {
+ "title": "Enforce unique key naming format",
+ "description": "The name is allowed to be empty and named by the database. If not empty, the default format is \"uk_<table name>_<unique key column name combination>\", which is no more than 63 characters long, such as \"uk_my_table_id_name\". Suggestion error level: Warning",
"component": {
- "required": {
- "title": "Require comment"
- },
- "requiredClassification": {
- "title": "Require classification",
- "tooltip": "The comment should follow {'{'}classification id{'}'}-{'{'}comment{'}'} format."
+ "format": {
+ "title": "Unique key name format",
+ "template": {
+ "table": "The table name",
+ "column_list": "Index column names, joined by _"
+ }
},
"maxLength": {
- "title": "Max length"
- }
- }
- },
- "column-maximum-character-length": {
- "title": "Restrict the length of \"CHAR\" data type",
- "description": "\"CHAR\" is a fixed-length type. For example, the CHAR(20) column will occupy 20 character spaces even if only one character is stored, causing waste. When the string is too long and the length is not fixed, consider using VARCHAR for MySQL and using TEXT for PostgreSQL. Suggestion error level: Error",
- "component": {
- "number": {
- "title": "Maximum length"
- }
- }
- },
- "column-maximum-varchar-length": {
- "title": "Restrict the length of \"VARCHAR\" data type",
- "description": "",
- "component": {
- "number": {
- "title": "Maximum length"
+ "title": "Length limit"
}
}
},
- "column-auto-increment-initial-value": {
- "title": "Restrict the initial value of auto-increment columns",
- "description": "based on management requirements to limit the initial value of the auto-increment column. Suggestion error level: Warning",
+ "NAMING_TABLE": {
+ "title": "Enforce table naming format",
+ "description": "The default format is all lowercase letters, separated by underscores between words, and no more than 63 characters long, such as \"abc\" and \"abc_def\". Suggestion error level: Warning",
"component": {
- "number": {
- "title": "Initial value"
+ "format": {
+ "title": "Table name format (regex)"
+ },
+ "maxLength": {
+ "title": "Length limit"
}
}
},
- "column-current-time-count-limit": {
- "title": "Restrict the number of columns in the table that acquire system time",
- "description": "Only columns recording the creation time of the record with \"DEFAULT NOW()\" and recording the update time of the record with \"DEFAULT NOW() ON UPDATE\" need to call function to get system time. It is meaningless and will increase resource overhead to record system time in other columns. Suggestion error level: Error"
- },
- "column-require-default": {
- "title": "Enforce setting default value on columns",
- "description": "Setting default values that satisfy business logic can effectively improve the data quality of downstream analytical pipeline. This rule does not check \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\" types. Suggestion error level: Warning"
- },
- "column-default-disallow-volatile": {
- "title": "Disallow setting volatile default value on columns",
- "description": "Volatile functions (e.g., clock_timestamp()) update each row with the value at the time of ALTER TABLE ADD COLUMN execution, potentially causing lengthy updates."
- },
- "column-require-charset": {
- "title": "Require charset for text columns",
- "description": "The charset of columns with text data types must be specified. Suggestion error level: Warning"
- },
- "column-require-collation": {
- "title": "Require collation for text columns",
- "description": "The collation of columns with text data types must be specified. Suggestion error level: Warning"
- },
- "statement-select-no-select-all": {
- "title": "Prohibit using \"SELECT *\"",
- "description": "SELECT * to fetch entire row data may cause unnecessary resource overhead and may also cause unexpected results in applications once the table adds or removes columns. Suggestion error level: Error"
- },
- "statement-where-require-select": {
- "title": "Enforce the presence of \"WHERE\" condition in SELECT statements",
- "description": "Queries without WHERE clause may cause huge uncessary resource overhead. Suggestion error level: Error"
- },
- "statement-where-require-update-delete": {
- "title": "Enforce the presence of \"WHERE\" condition in UDPATE/DELETE statements",
- "description": "DMLs without WHERE clause may cause massive accidental data loss. Suggestion error level: Error"
- },
- "statement-where-no-leading-wildcard-like": {
- "title": "Prohibit using leading wildcard in filter conditions",
- "description": "When using leading wildcard, such as \"LIKE '%ABC'\", the database optimizer cannot use fast index scan, and fallback to full table scan or full index scan, which may cause serious performance impact. Suggestion error level: Error"
- },
- "statement-disallow-on-del-cascade": {
- "title": "Prohibit using CASCADE option for ON DELETE clauses",
- "description": "The \"CASCADE\" option in 'ON DELETE' can cause a large number of dependent objects to be deleted or modified, which may cause unexpected results. Suggestion error level: Error"
- },
- "statement-disallow-rm-tbl-cascade": {
- "title": "Prohibit using CASCADE when removing a table",
- "description": "Using the \"CASCADE\" option when removing a table can cause a large number of dependent objects to be deleted or modified, which may cause unexpected results. Suggestion error level: Error"
- },
- "statement-disallow-commit": {
- "title": "Prohibit explicit \"COMMIT\" statement",
- "description": "In some cases, multiple statements are required to be included in a transaction committed by the system, in order to quickly rerun in case of partial failure. Therefore, explicit \"COMMIT\" is not allowed. Suggestion error level: Warning"
- },
- "statement-disallow-limit": {
- "title": "Prohibit using \"LIMIT\" clause in DML statements",
- "description": "If LIMIT is used in DML statements without an ORDER BY clause, the affected rows order are not fixed, which may cause data inconsistency between the primary and replica databases in some replication modes. Suggestion error level: Error"
- },
- "statement-disallow-order-by": {
- "title": "Prohibit using \"ORDER BY\" clause in \"UPDATE\" and \"DELETE\" statements",
- "description": "Sorting operations are extremely resource-intensive, so for update and delete operations, it is recommended to use a deterministic filtering condition as much as possible instead of using ORDER BY and LIMIT. Suggestion error level: Error"
+ "NAMING_TABLE_NO_KEYWORD": {
+ "title": "Prohibit using keywords as table names",
+ "description": ""
},
- "statement-merge-alter-table": {
- "title": "Prohibit issuing multiple independent changes on the same table",
- "description": "Every change to a table may cause a table-level lock and consume a large amount of resources. If there are multiple changes to the same table, they should be merged into a single change statement. Suggestion error level: Error"
+ "SCHEMA_BACKWARD_COMPATIBILITY": {
+ "title": "Check application backward compatibility",
+ "description": "Some changes may affect running applications, such as modifying the name of database object, adding new constraints, etc. This rule can avoid careless changes that lead to the failure of existing application. Suggestion error level: Warning"
},
- "statement-insert-must-specify-column": {
- "title": "Enforce specifying column names in \"INSERT\" statements",
- "description": "The \"INSERT INTO table VALUES (...)\" statement does not explicit list column names. Once the column order changes or columns are added or dropped, the statement may faile or generate unexpected data. Suggestion error level: Error"
+ "STATEMENT_ADD_CHECK_NOT_VALID": {
+ "title": "Enforce including \"NOT VALID\" option when adding \"CHECK\" constraints",
+ "description": "Adding a CHECK constraint needs to verify the existing data and requires ACCESS EXCLUSIVE table lock. This blocks read and write, which may cause business interruption. It is recommended to add the \"NOT VALID\" option to validate new data and manually validate existing data after the change is completed. Suggestion error level: Warning"
},
- "statement-insert-disallow-order-by-rand": {
- "title": "Prohibit using \"ORDER BY rand()\" in \"INSERT\" statement",
- "description": "Randomly sorting the data to be inserted is meaningless and will only consume uncessary resources. Suggestion error level: Error"
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": {
+ "title": "Check no position in ADD COLUMN clause",
+ "description": "In some cases, using FIRST/AFTER to add columns will cause data reorganization (rewriting all data). Suggested error level: Warning"
},
- "statement-insert-row-limit": {
- "title": "Restrict the maximum number of inserted rows",
- "description": "Reveal the number of rows to be inserted can help determine whether the statement meets business expectations. Suggestion error level: Warning",
- "component": {
- "number": {
- "title": "Maximum insert amount"
- }
- }
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": {
+ "title": "Enforce including \"NOT VALID\" option when adding foreign keys",
+ "description": "Adding foreign keys needs to verify the existing data and requires SHARE ROW EXCLUSIVE table lock. This blocks write, which may cause business interruption. It is recommended to add the \"NOT VALID\" option to validate new data and validate existing data after the change is completed. Suggestion error level: Warning"
},
- "statement-affected-row-limit": {
+ "STATEMENT_AFFECTED_ROW_LIMIT": {
"title": "Restrict the maximum number of updated or deleted rows (estimated).",
"description": "Reveal the number of rows to be updated or deleted can help determine whether the statement meets business expectations. Suggestion error level: Warning",
"component": {
@@ -440,87 +379,102 @@
}
}
},
- "statement-dml-dry-run": {
- "title": "Validate the executability of DML statements",
- "description": "When the syntax is correct, but the table name is incorrect or the permission is insufficient, it can be discovered by dry run before the actual execution. Suggestion error level: Warning"
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": {
+ "title": "Check if Set Role statement at the beginning",
+ "description": "Failure to set the role statement properly at the beginning of a session may lead to unauthorized access or improper permissions assignment, potentially compromising data security and integrity. Suggestion error level: Warning"
+ },
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": {
+ "title": "Prohibit creating objects without specifying the schema",
+ "description": "If the schema is not specified, the object will be created in the default schema, which may cause unexpected results."
},
- "statement-disallow-add-column-with-default": {
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": {
"title": "Restrict adding columns with default values to a table",
"description": "Before PostgreSQL 11, adding a column with a default value cause table locking and unable to read and write, which may cause business interruption. In PostgreSQL 11 and above, this issue has been optimized and there is no need to pay attention to this rule. Suggestion error level: Warning"
},
- "statement-add-check-not-valid": {
- "title": "Enforce including \"NOT VALID\" option when adding \"CHECK\" constraints",
- "description": "Adding a CHECK constraint needs to verify the existing data and requires ACCESS EXCLUSIVE table lock. This blocks read and write, which may cause business interruption. It is recommended to add the \"NOT VALID\" option to validate new data and manually validate existing data after the change is completed. Suggestion error level: Warning"
- },
- "statement-disallow-add-not-null": {
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": {
"title": "Restrict adding \"NOT NULL\" constraint to existing columns",
"description": "Adding NOT NULL constraint with default value before PostgreSQL 11 or adding NOT NULL constraint without default value requires to verify the existing data. This blocks read and write, which may cause business interruption. Suggestion error level: Warning"
},
- "statement-select-full-table-scan": {
- "title": "Check full table scan for queries",
- "description": "Full table scan is a resource-intensive operation and may cause serious performance impact. Suggestion error level: Error"
+ "STATEMENT_DISALLOW_COMMIT": {
+ "title": "Prohibit explicit \"COMMIT\" statement",
+ "description": "In some cases, multiple statements are required to be included in a transaction committed by the system, in order to quickly rerun in case of partial failure. Therefore, explicit \"COMMIT\" is not allowed. Suggestion error level: Warning"
},
- "statement-create-specify-schema": {
- "title": "Prohibit creating objects without specifying the schema",
- "description": "If the schema is not specified, the object will be created in the default schema, which may cause unexpected results."
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": {
+ "title": "Disallow cross database queries",
+ "description": "Cross-database queries increase system coupling and can lead to efficiency issues. Suggested error level: Warning"
},
- "statement-check-set-role-variable": {
- "title": "Check if Set Role statement at the beginning",
- "description": "Failure to set the role statement properly at the beginning of a session may lead to unauthorized access or improper permissions assignment, potentially compromising data security and integrity. Suggestion error level: Warning"
+ "STATEMENT_DISALLOW_LIMIT": {
+ "title": "Prohibit using \"LIMIT\" clause in DML statements",
+ "description": "If LIMIT is used in DML statements without an ORDER BY clause, the affected rows order are not fixed, which may cause data inconsistency between the primary and replica databases in some replication modes. Suggestion error level: Error"
},
- "statement-disallow-using-temporary": {
- "title": "Prohibit using temporary tables",
- "description": "Temporary tables are not recommended for use in production environments. They can cause resource contention and performance issues. Suggestion error level: Warning"
+ "STATEMENT_DISALLOW_OFFLINE_DDL": {
+ "title": "Disallow Offline DDL",
+ "description": "To prevent database changes from impacting your business, avoid using Offline DDL."
+ },
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": {
+ "title": "Prohibit using CASCADE option for ON DELETE clauses",
+ "description": "The \"CASCADE\" option in 'ON DELETE' can cause a large number of dependent objects to be deleted or modified, which may cause unexpected results. Suggestion error level: Error"
+ },
+ "STATEMENT_DISALLOW_ORDER_BY": {
+ "title": "Prohibit using \"ORDER BY\" clause in \"UPDATE\" and \"DELETE\" statements",
+ "description": "Sorting operations are extremely resource-intensive, so for update and delete operations, it is recommended to use a deterministic filtering condition as much as possible instead of using ORDER BY and LIMIT. Suggestion error level: Error"
+ },
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": {
+ "title": "Prohibit using CASCADE when removing a table",
+ "description": "Using the \"CASCADE\" option when removing a table can cause a large number of dependent objects to be deleted or modified, which may cause unexpected results. Suggestion error level: Error"
},
- "statement-disallow-using-filesort": {
+ "STATEMENT_DISALLOW_USING_FILESORT": {
"title": "Prohibit using filesort",
"description": "Filesort is a resource-intensive operation and may cause serious performance impact. Suggestion error level: Warning"
},
- "statement-where-no-equal-null": {
- "title": "Prohibit using NULL equality comparison in WHERE clause",
- "description": "The result of NULL equality comparison is always NULL, which may cause unexpected results. Suggestion error level: Warning"
+ "STATEMENT_DISALLOW_USING_TEMPORARY": {
+ "title": "Prohibit using temporary tables",
+ "description": "Temporary tables are not recommended for use in production environments. They can cause resource contention and performance issues. Suggestion error level: Warning"
},
- "statement-where-disallow-functions-and-calculations": {
- "title": "Do not apply functions or perform calculations on indexed fields in the WHERE clause",
- "description": "If you apply a function or perform a calculation on the indexed field, the database cannot use the index and has to scan the entire table instead."
+ "STATEMENT_DML_DRY_RUN": {
+ "title": "Validate the executability of DML statements",
+ "description": "When the syntax is correct, but the table name is incorrect or the permission is insufficient, it can be discovered by dry run before the actual execution. Suggestion error level: Warning"
},
- "statement-query-minimum-plan-level": {
- "title": "Restrict the maximum level of query access method",
- "description": "SQL performance optimization strives for constant (const) access, aiming for reference (ref) level as a baseline, with acceptable performance at range level.",
- "component": {
- "level": {
- "title": "Maximum level"
- }
- }
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": {
+ "title": "Prohibit using \"ORDER BY rand()\" in \"INSERT\" statement",
+ "description": "Randomly sorting the data to be inserted is meaningless and will only consume uncessary resources. Suggestion error level: Error"
},
- "statement-where-maximum-logical-operator-count": {
- "title": "Restrict the number of values in the IN or OR clause of the WHERE clause",
- "description": "This prevents performance degradation due to extensive comparisons and resource limitations.",
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": {
+ "title": "Enforce specifying column names in \"INSERT\" statements",
+ "description": "The \"INSERT INTO table VALUES (...)\" statement does not explicit list column names. Once the column order changes or columns are added or dropped, the statement may faile or generate unexpected data. Suggestion error level: Error"
+ },
+ "STATEMENT_INSERT_ROW_LIMIT": {
+ "title": "Restrict the maximum number of inserted rows",
+ "description": "Reveal the number of rows to be inserted can help determine whether the statement meets business expectations. Suggestion error level: Warning",
"component": {
"number": {
- "title": "Maximum count"
+ "title": "Maximum insert amount"
}
}
},
- "statement-maximum-limit-value": {
- "title": "Restrict the maximum number of the LIMIT clause",
- "description": "Limiting the number of rows through LIMIT ensures the database processes manageable chunks, improving query execution speed. A capped LIMIT value prevents excessive memory usage, safeguarding overall system stability and preventing performance degradation.",
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {
+ "title": "Fields to be joined must have identical data types, character sets",
+ "description": "If the data types, character sets of the join columns are not identical, the database may not be able to correctly identify matching rows, leading to inaccurate or incomplete results."
+ },
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {
+ "title": "Restrict the number of tables to be joined",
+ "description": "The more tables you join, the more complex the query becomes and the longer it takes to execute. In general, it is best to keep the number of joins to a minimum.",
"component": {
"number": {
"title": "Maximum value"
}
}
},
- "statement-maximum-join-table-count": {
- "title": "Restrict the number of tables to be joined",
- "description": "The more tables you join, the more complex the query becomes and the longer it takes to execute. In general, it is best to keep the number of joins to a minimum.",
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": {
+ "title": "Restrict the maximum number of the LIMIT clause",
+ "description": "Limiting the number of rows through LIMIT ensures the database processes manageable chunks, improving query execution speed. A capped LIMIT value prevents excessive memory usage, safeguarding overall system stability and preventing performance degradation.",
"component": {
"number": {
"title": "Maximum value"
}
}
},
- "statement-maximum-statements-in-transaction": {
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {
"title": "Restrict the number of statements in a transaction",
"description": "Large transactions can significantly impact database performance. If a large number of statements are involved and one fails, rolling back the entire transaction becomes complex. Limiting statements minimizes the potential damage caused by a single failure and simplifies rollback procedures.",
"component": {
@@ -529,31 +483,7 @@
}
}
},
- "statement-join-strict-column-attrs": {
- "title": "Fields to be joined must have identical data types, character sets",
- "description": "If the data types, character sets of the join columns are not identical, the database may not be able to correctly identify matching rows, leading to inaccurate or incomplete results."
- },
- "statement-prior-backup-check": {
- "title": "Check for prior backup before data change",
- "description": "This rule will check if a backup can be created before the data change. For more details, contains the backup target database exists and disallow the DDL statement."
- },
- "statement-add-column-without-position": {
- "title": "Check no position in ADD COLUMN clause",
- "description": "In some cases, using FIRST/AFTER to add columns will cause data reorganization (rewriting all data). Suggested error level: Warning"
- },
- "statement-disallow-offline-ddl": {
- "title": "Disallow Offline DDL",
- "description": "To prevent database changes from impacting your business, avoid using Offline DDL."
- },
- "statement-disallow-cross-db-queries": {
- "title": "Disallow cross database queries",
- "description": "Cross-database queries increase system coupling and can lead to efficiency issues. Suggested error level: Warning"
- },
- "schema-backward-compatibility": {
- "title": "Check application backward compatibility",
- "description": "Some changes may affect running applications, such as modifying the name of database object, adding new constraints, etc. This rule can avoid careless changes that lead to the failure of existing application. Suggestion error level: Warning"
- },
- "statement-max-execution-time": {
+ "STATEMENT_MAX_EXECUTION_TIME": {
"title": "Enforce set the max execution time parameter",
"description": "Set the maximum execution time for SQL statements. If the execution time exceeds the limit, the statement will be terminated. Suggestion error level: Warning",
"mysql": {
@@ -565,75 +495,73 @@
"description": "Set the MAX_STATEMENT_TIME parameter in the change script to explicitly control the maximum execution time of the statement. Suggestion error level: Warning"
}
},
- "statement-require-algorithm-option": {
+ "STATEMENT_MERGE_ALTER_TABLE": {
+ "title": "Prohibit issuing multiple independent changes on the same table",
+ "description": "Every change to a table may cause a table-level lock and consume a large amount of resources. If there are multiple changes to the same table, they should be merged into a single change statement. Suggestion error level: Error"
+ },
+ "STATEMENT_NON_TRANSACTIONAL": {
+ "title": "Detect and report non-transactional statements",
+ "description": ""
+ },
+ "STATEMENT_OBJECT_OWNER_CHECK": {
+ "title": "Object owner check",
+ "description": "This rule checks whether the object owner for DDL is the same as the current user."
+ },
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {
+ "title": "Restrict the maximum level of query access method",
+ "description": "SQL performance optimization strives for constant (const) access, aiming for reference (ref) level as a baseline, with acceptable performance at range level.",
+ "component": {
+ "level": {
+ "title": "Maximum level"
+ }
+ }
+ },
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": {
"title": "Require specifying the ALGORITHM option in ALTER TABLE statements",
"description": "Specifying the ALGORITHM option in ALTER TABLE statements ensures more control over how table changes are applied, minimizing potential disruptions by avoiding full table copies or locks. It helps optimize performance and reduce downtime during schema modifications. Suggested error level: Warning."
},
- "statement-require-lock-option": {
+ "STATEMENT_REQUIRE_LOCK_OPTION": {
"title": "Require specifying the LOCK option in ALTER TABLE statements",
"description": "The LOCK option in ALTER TABLE statements allows you to control the level of locking during schema changes, helping to prevent unnecessary table locks and ensuring better concurrency. Proper use of this option can significantly reduce the impact of DDL operations on active queries. Suggested error level: Warning."
},
- "database-drop-empty-database": {
- "title": "Prohibit deleting non-empty database",
- "description": "Deletion is only allowed when there are no tables in the database, which can greatly avoid accidental deletion. Suggested error level: Error"
- },
- "index-no-duplicate-column": {
- "title": "Prohibit indexes containing duplicate columns",
- "description": "Creating an index with duplicate columns will result in failure. Suggestion error level: Error"
- },
- "index-type-no-blob": {
- "title": "Prohibit creating indexes on \"BLOB\" and \"TEXT\" data type columns",
- "description": "The \"BLOB\" type is usually used to store binary data and should not be used as a query condition. If an index is created on this column type by mistake, it will consume a lot of resources and cause serious performance impact. Suggestion error level: Error"
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": {
+ "title": "Check full table scan for queries",
+ "description": "Full table scan is a resource-intensive operation and may cause serious performance impact. Suggestion error level: Error"
},
- "index-pk-type-limit": {
- "title": "Primary key type limit",
- "description": "Enforce the primary key type to be INT or BIGINT."
+ "STATEMENT_SELECT_NO_SELECT_ALL": {
+ "title": "Prohibit using \"SELECT *\"",
+ "description": "SELECT * to fetch entire row data may cause unnecessary resource overhead and may also cause unexpected results in applications once the table adds or removes columns. Suggestion error level: Error"
},
- "index-key-number-limit": {
- "title": "Restrict the number of columns in a single index",
- "description": "A composite index with over 5 columns does not significantly improve query performance, but it occupies a lot of space and reduces DML performance. Suggestion error level: Warning",
- "component": {
- "number": {
- "title": "Maximum column count"
- }
- }
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": {
+ "title": "Do not apply functions or perform calculations on indexed fields in the WHERE clause",
+ "description": "If you apply a function or perform a calculation on the indexed field, the database cannot use the index and has to scan the entire table instead."
},
- "index-total-number-limit": {
- "title": "Restrict the number of indexes on a single table",
- "description": "Although indexes can improve query performance, they also occupy a lot of space and reduce DML performance. Therefore, it is not recommended to create more than 5 indexes in a table. Suggestion error level: Warning",
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": {
+ "title": "Restrict the number of values in the IN or OR clause of the WHERE clause",
+ "description": "This prevents performance degradation due to extensive comparisons and resource limitations.",
"component": {
"number": {
- "title": "Maximum index count"
+ "title": "Maximum count"
}
}
},
- "index-primary-key-type-allowlist": {
- "title": "Allowable list of primary key types",
- "description": "The appropriate primary key type can optimize storage structure, reduce space usage, and beneficial for insert and query performance. Suggestion error level: Warning",
- "component": {
- "list": {
- "title": "Allow list"
- }
- }
+ "STATEMENT_WHERE_NO_EQUAL_NULL": {
+ "title": "Prohibit using NULL equality comparison in WHERE clause",
+ "description": "The result of NULL equality comparison is always NULL, which may cause unexpected results. Suggestion error level: Warning"
},
- "index-create-concurrently": {
- "title": "Enforce concurrent index creation",
- "description": "In PostgreSQL 11 and above, using the standard statement to create an index will cause table locking and unable to write. Using the \"CONCURRENTLY\" mode can avoid this problem. Suggestion error level: Warning"
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": {
+ "title": "Prohibit using leading wildcard in filter conditions",
+ "description": "When using leading wildcard, such as \"LIKE '%ABC'\", the database optimizer cannot use fast index scan, and fallback to full table scan or full index scan, which may cause serious performance impact. Suggestion error level: Error"
},
- "index-type-allow-list": {
- "title": "Allowable list of index types",
- "description": "Different index types have different performance characteristics. For example, B-tree indexes are suitable for range queries, while hash indexes are suitable for equality queries. Suggestion error level: Warning",
- "component": {
- "list": {
- "title": "Allow list"
- }
- }
+ "STATEMENT_WHERE_REQUIRE_SELECT": {
+ "title": "Enforce the presence of \"WHERE\" condition in SELECT statements",
+ "description": "Queries without WHERE clause may cause huge uncessary resource overhead. Suggestion error level: Error"
},
- "index-not-redundant": {
- "title": "Disallow redundant indexes",
- "description": "Redundant index may result in performance loss and occupy additional space. For example, the index on columns (c1, c2) will be treated as redundant indexes if there is already a index on column (c1). Suggestion error level: Warning"
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": {
+ "title": "Enforce the presence of \"WHERE\" condition in UDPATE/DELETE statements",
+ "description": "DMLs without WHERE clause may cause massive accidental data loss. Suggestion error level: Error"
},
- "system-charset-allowlist": {
+ "SYSTEM_CHARSET_ALLOWLIST": {
"title": "Allowable list of Charset",
"description": "The character set determines which characters can be stored in the table. Using the wrong character set may result in certain characters in the application being unable to be stored and displayed correctly, such as CJK and Emoji. Suggested error level: Error",
"component": {
@@ -642,7 +570,7 @@
}
}
},
- "system-collation-allowlist": {
+ "SYSTEM_COLLATION_ALLOWLIST": {
"title": "Allowable list of Collation",
"description": "The collation determines the rules for character comparison and sorting. For example, when using a case-insensitive collation, \"ABC\" and \"abc\" will be treated as the same string in queries. Suggested error level: Error",
"component": {
@@ -651,7 +579,7 @@
}
}
},
- "system-comment-length": {
+ "SYSTEM_COMMENT_LENGTH": {
"title": "Restrict the length of comments",
"description": "",
"component": {
@@ -660,55 +588,123 @@
}
}
},
- "system-procedure-disallow-create": {
- "title": "Disallow to create procedures",
- "description": "This rule prohibits the execution of procedures within the database. System procedures often perform critical operations that could impact the stability and security of the database environment. By disallowing their execution, it helps prevent unintended changes and potential vulnerabilities. Suggested error level: Warning"
- },
- "system-event-disallow-create": {
+ "SYSTEM_EVENT_DISALLOW_CREATE": {
"title": "Disallow to create events",
"description": "This rule prohibits the creation of events within the database. System events often perform automated tasks that could affect the database environment. By disallowing their creation, it helps maintain control over database operations and prevents potential disruptions. Suggested error level: Warning"
},
- "system-view-disallow-create": {
- "title": "Disallow to create views",
- "description": "This rule prohibits the creation of views within the database. Views provide a virtual representation of data that can simplify queries and enhance data security. By disallowing their creation, it helps maintain control over database schema and prevents potential security risks. Suggested error level: Warning"
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": {
+ "title": "Prohibit the use of certain functions",
+ "description": "This rule restricts the usage of specific functions within the database. By disallowing the use of these functions, it helps maintain data consistency and security. Suggested error level: Warning",
+ "component": {
+ "list": {
+ "title": "Disallow list"
+ }
+ }
},
- "system-function-disallow-create": {
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": {
"title": "Disallow to create functions",
"description": "This rule prohibits the creation of functions within the database. Functions provide reusable logic that can simplify queries and enhance data integrity. By disallowing their creation, it helps maintain control over database schema and prevents potential security risks. Suggested error level: Warning"
},
- "system-function-disallowed-list": {
- "title": "Prohibit the use of certain functions",
- "description": "This rule restricts the usage of specific functions within the database. By disallowing the use of these functions, it helps maintain data consistency and security. Suggested error level: Warning",
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": {
+ "title": "Disallow to create procedures",
+ "description": "This rule prohibits the execution of procedures within the database. System procedures often perform critical operations that could impact the stability and security of the database environment. By disallowing their execution, it helps prevent unintended changes and potential vulnerabilities. Suggested error level: Warning"
+ },
+ "SYSTEM_VIEW_DISALLOW_CREATE": {
+ "title": "Disallow to create views",
+ "description": "This rule prohibits the creation of views within the database. Views provide a virtual representation of data that can simplify queries and enhance data security. By disallowing their creation, it helps maintain control over database schema and prevents potential security risks. Suggested error level: Warning"
+ },
+ "TABLE_COMMENT": {
+ "title": "Table comment convention",
+ "description": "Configure whether the table requires comments and the maximum comment length.",
+ "component": {
+ "required": {
+ "title": "Require comment"
+ },
+ "requiredClassification": {
+ "title": "Require classification",
+ "tooltip": "The comment should follow {'{'}classification id{'}'}-{'{'}comment{'}'} format."
+ },
+ "maxLength": {
+ "title": "Max length"
+ }
+ }
+ },
+ "TABLE_DISALLOW_DDL": {
+ "title": "Disallow DDL",
+ "description": "Configure which tables are prohibited from executing DDL. Suggestion error level: Warning",
"component": {
"list": {
- "title": "Disallow list"
+ "title": "Table names"
}
}
},
- "advice-online-migration": {
- "title": "Online migration",
- "description": "Advise enabling online migration if the migrated table row count exceeds your setting. Suggested error level: Warning",
+ "TABLE_DISALLOW_DML": {
+ "title": "Disallow DML",
+ "description": "Configure which tables are prohibited from executing DML. Suggestion error level: Warning",
+ "component": {
+ "list": {
+ "title": "Table names"
+ }
+ }
+ },
+ "TABLE_DISALLOW_PARTITION": {
+ "title": "Prohibit using partition table",
+ "description": "In some database engines, partitioned tables are not mature, and the use and maintenance are inconvenient. Therefore, it is more inclined to use manual data partitioning methods such as database and table sharding. Suggestion error level: Warning"
+ },
+ "TABLE_DISALLOW_SET_CHARSET": {
+ "title": "Prohibit defining character set in table properties",
+ "description": "It is recommended to set the charset at the database level. Setting the charset at finer granularity can bring unnecessary complexities. Suggested error level: Error."
+ },
+ "TABLE_DISALLOW_TRIGGER": {
+ "title": "Prevent the use of triggers on tables",
+ "description": "This rule restricts the usage of triggers on tables. Triggers can introduce complexity and potential performance issues to database operations. By disallowing triggers, the system can maintain a simpler and more predictable behavior. Suggestion error level: Warning"
+ },
+ "TABLE_DROP_NAMING_CONVENTION": {
+ "title": "Restrict the naming format of tables to be deleted",
+ "description": "For example, by requiring the \"_del\" suffix, it can effectively prevent accidental deletions. Suggestion error level: Error",
+ "component": {
+ "format": {
+ "title": "Table name format (regex)"
+ }
+ }
+ },
+ "TABLE_LIMIT_SIZE": {
+ "title": "Limit DDL operations on tables with a large number of rows",
+ "description": "Configure the maximum number of rows in tables for which DDL can be executed. Recommended error level: warning",
"component": {
"number": {
- "title": "Threshold value"
+ "title": "Max row count"
}
}
},
- "statement-add-foreign-key-not-valid": {
- "title": "Enforce including \"NOT VALID\" option when adding foreign keys",
- "description": "Adding foreign keys needs to verify the existing data and requires SHARE ROW EXCLUSIVE table lock. This blocks write, which may cause business interruption. It is recommended to add the \"NOT VALID\" option to validate new data and validate existing data after the change is completed. Suggestion error level: Warning"
+ "TABLE_NO_DUPLICATE_INDEX": {
+ "title": "Prohibit duplicate indexes on table",
+ "description": "This rule requires that a table does not have duplicate indexes. Duplicate indexes consume extra storage space and can potentially reduce query performance. Suggested error level: Warning."
},
- "statement-non-transactional": {
- "title": "Detect and report non-transactional statements",
- "description": ""
+ "TABLE_NO_FOREIGN_KEY": {
+ "title": "Prohibit using foreign key constraints",
+ "description": "The advantages and disadvantages of foreign key are highly controversial. Using foreign key may significantly increase the difficulty of database changes, scalability (such as sharding), etc. And may even prevent the use of some tools. Therefore, another option is to implement foreign key constraints at the application layer. Suggestion error level: Warning"
},
- "builtin-prior-backup-check": {
- "title": "Prior backup feasibility check",
- "description": "This rule checks whether a backup can be created before data changes. It verifies the existence of the backup target database and disallows non-supported scenarios. It's builtin and cannot skip."
+ "TABLE_REQUIRE_CHARSET": {
+ "title": "Require charset",
+ "description": "The charset of the table must be specified. Suggestion error level: Warning"
},
- "statement-object-owner-check": {
- "title": "Object owner check",
- "description": "This rule checks whether the object owner for DDL is the same as the current user."
+ "TABLE_REQUIRE_COLLATION": {
+ "title": "Require collation",
+ "description": "The collation of the table must be specified. Suggestion error level: Warning"
+ },
+ "TABLE_REQUIRE_PK": {
+ "title": "Enforce inclusion of primary key in a table",
+ "description": "Various data synchronization, comparison, and rollback tools require tables to have primary key. Suggestion error level: Error"
+ },
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": {
+ "title": "Restrict the total length of text fields in a table",
+ "description": "This rule limits the amount of data a table can hold, preventing excessive storage usage.",
+ "component": {
+ "number": {
+ "title": "Maximum length"
+ }
+ }
}
},
"level": {
diff --git a/frontend/src/locales/sql-review/es-ES.json b/frontend/src/locales/sql-review/es-ES.json
index 2701abc3a1..9d138b9e14 100644
--- a/frontend/src/locales/sql-review/es-ES.json
+++ b/frontend/src/locales/sql-review/es-ES.json
@@ -33,58 +33,42 @@
"bb-sql-review-empty-desc": "Una plantilla vacía. Debe agregar las reglas necesarias usted mismo."
},
"rule": {
- "engine-mysql-use-innodb": {
- "title": "Imponer el motor de almacenamiento InnoDB",
- "description": "InnoDB es el motor de almacenamiento predeterminado para MySQL que proporciona soporte para transacciones. También proporciona un mejor rendimiento para escenarios de alta concurrencia y baja latencia, y admite copias de seguridad y recuperación de datos en línea. Es la opción preferida para las empresas OLTP. Nivel de sugerencia de error: Error"
- },
- "table-require-pk": {
- "title": "Imponer la inclusión de clave primaria en una tabla",
- "description": "Varias herramientas de sincronización, comparación y recuperación de datos a menudo requieren que las tablas tengan una clave principal. Nivel de error sugerido: Error"
- },
- "table-no-foreign-key": {
- "title": "Prohibir el uso de restricciones de clave externa",
- "description": "Las ventajas y desventajas de las claves externas son altamente controvertidas. El uso de claves externas puede aumentar significativamente la dificultad de los cambios en la base de datos, la escalabilidad (como la fragmentación), etc. Y incluso puede evitar el uso de algunas herramientas. Por lo tanto, otra opción es implementar restricciones de claves externas en la capa de aplicación. Nivel de sugerencia de error: Advertencia"
- },
- "table-drop-naming-convention": {
- "title": "Restringir el formato de nomenclatura de las tablas a eliminar",
- "description": "Por ejemplo, al requerir el sufijo \"_del\", se puede prevenir efectivamente las eliminaciones accidentales. Nivel de sugerencia de error: Error",
+ "ADVICE_ONLINE_MIGRATION": {
+ "title": "Migración en línea",
+ "description": "Se recomienda habilitar la migración en línea si el recuento de filas de la tabla migrada supera su configuración. Nivel de error sugerido: Advertencia",
"component": {
- "format": {
- "title": "Formato de nombre de tabla (regex)"
+ "number": {
+ "title": "Valor de umbral"
}
}
},
- "table-disallow-partition": {
- "title": "Prohibir el uso de tablas particionadas",
- "description": "En algunos motores de base de datos, las tablas particionadas no están maduras y el uso y mantenimiento son incómodos. Por lo tanto, es más propenso a utilizar métodos manuales de partición de datos como la fragmentación de bases de datos y tablas. Nivel de sugerencia de error: Advertencia"
- },
- "table-disallow-trigger": {
- "title": "Prohibir el uso de desencadenadores en tablas",
- "description": "Los desencadenadores pueden hacer que el flujo de control sea difícil de seguir y aumentar la complejidad del sistema. En lugar de usar desencadenadores, se recomienda utilizar la lógica de la aplicación para realizar operaciones de base de datos. Nivel de sugerencia de error: Advertencia"
- },
- "table-no-duplicate-index": {
- "title": "No se permiten índices duplicados",
- "description": "Esta regla prohíbe la creación de índices duplicados en una tabla. Los índices duplicados consumen espacio de almacenamiento adicional y pueden reducir el rendimiento de las consultas. Nivel de error de sugerencia: Advertencia"
+ "BUILTIN_PRIOR_BACKUP_CHECK": {
+ "title": "Comprobación previa de viabilidad de la copia de seguridad",
+ "description": "Esta regla verifica si se puede crear una copia de seguridad antes de que se modifiquen los datos. Verifica la existencia de la base de datos de destino de la copia de seguridad y rechaza los escenarios no admitidos. Está incorporada y no se puede omitir."
},
- "table-text-fields-total-length": {
- "title": "Limitar la longitud total de los campos de texto en una tabla",
- "description": "Esta regla limita la cantidad de datos que una tabla puede almacenar, evitando un uso excesivo de almacenamiento.",
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": {
+ "title": "Restringir el valor inicial de las columnas de autoincremento",
+ "description": "Basándose en los requisitos de gestión, se debe limitar el valor inicial de la columna de autoincremento. Nivel de error sugerido: Advertencia",
"component": {
"number": {
- "title": "Longitud máxima"
+ "title": "Valor inicial"
}
}
},
- "table-disallow-set-charset": {
- "title": "Prohibir la definición del juego de caracteres en las propiedades de la tabla",
- "description": "Se recomienda establecer el juego de caracteres a nivel de la base de datos. Establecer el juego de caracteres con una granularidad más fina puede generar complejidades innecesarias. Nivel de error sugerido: Error."
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": {
+ "title": "Forzar el uso del tipo de datos \"INTEGER\" para columnas de autoincremento",
+ "description": "Las columnas de autoincremento de MySQL se utilizan generalmente como claves primarias independientes del negocio. El uso de tipos enteros ocupa menos espacio de almacenamiento y hace que la estructura de índice de clave primaria sea más compacta, lo que mejora el rendimiento de consultas y DML. Nivel de error sugerido: Error"
},
- "table-comment": {
- "title": "Convención de comentarios de tabla",
- "description": "Configure si la tabla requiere comentarios y la longitud máxima de comentarios.",
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": {
+ "title": "Hacer obligatorio el uso del tipo de dato \"UNSIGNED\" para columnas de autoincremento",
+ "description": "Los tipos no signados no almacenan números negativos, y el rango de valores que pueden almacenar se duplica, lo que puede evitar que las columnas de autoincremento desborden. Nivel de error sugerido: Advertencia"
+ },
+ "COLUMN_COMMENT": {
+ "title": "Convención de comentarios de columnas",
+ "description": "Agregar comentarios a las columnas es una buena práctica de desarrollo, pero comentarios demasiado largos pueden disminuir la legibilidad del esquema. Nivel de error sugerido: Advertencia",
"component": {
"required": {
- "title": "Requerir comentario"
+ "title": "Comentario obligatorio"
},
"requiredClassification": {
"title": "Requerir clasificación",
@@ -95,58 +79,159 @@
}
}
},
- "table-disallow-ddl": {
- "title": "No permitir DDL",
- "description": "Configure qué tablas tienen prohibido ejecutar DDL. Nivel de error de sugerencia: Advertencia",
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": {
+ "title": "Restringir el número de columnas en la tabla que adquieren la hora del sistema",
+ "description": "Solo las columnas que registran la hora de creación del registro con \"DEFAULT NOW()\" y que registran la hora de actualización del registro con \"DEFAULT NOW() ON UPDATE\" necesitan llamar a la función para obtener la hora del sistema. Es inútil y aumentará la sobrecarga de recursos registrar la hora del sistema en otras columnas. Nivel de error sugerido: Error"
+ },
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": {
+ "title": "No permitir establecer valores predeterminados volátiles en las columnas",
+ "description": "Las funciones volátiles (por ejemplo, clock_timestamp()) actualizan cada fila con el valor en el momento de la ejecución de ALTER TABLE ADD COLUMN, lo que puede causar actualizaciones prolongadas."
+ },
+ "COLUMN_DISALLOW_CHANGE": {
+ "title": "Prohibir el uso de la instrucción \"CHANGE COLUMN\"",
+ "description": "\"CHANGE COLUMN\" es único en la sintaxis de MySQL y se puede usar para modificar los nombres de las columnas y otras propiedades al mismo tiempo. Sin embargo, puede causar que el nombre de la columna se cambie por error al modificar las propiedades. Se recomienda seguir utilizando las instrucciones estándar \"RENAME\" y \"MODIFY\" para distinguir entre los dos tipos de cambios. Nivel de error sugerido: Error"
+ },
+ "COLUMN_DISALLOW_CHANGE_TYPE": {
+ "title": "Prohibir la modificación de los tipos de columnas",
+ "description": "Modificar los tipos de columnas puede afectar el rendimiento del sistema, la mantenibilidad e incluso llevar a la pérdida de datos. Nivel de error sugerido: Advertencia"
+ },
+ "COLUMN_DISALLOW_CHANGING_ORDER": {
+ "title": "Prohibir el cambio del orden de las columnas en una tabla",
+ "description": "Modificar el orden de las columnas puede hacer que algunas aplicaciones o vistas que dependen del orden predeterminado de la tabla original produzcan resultados inesperados, como \"select *\". Nivel de error sugerido: Advertencia"
+ },
+ "COLUMN_DISALLOW_DROP": {
+ "title": "Prohibir eliminar columnas",
+ "description": "Se prohíbe eliminar columnas. Nivel de error sugerido: advertencia."
+ },
+ "COLUMN_DISALLOW_DROP_IN_INDEX": {
+ "title": "Prohibir eliminar columnas en el índice",
+ "description": "Prohibir eliminar columnas en el índice. Nivel de error sugerido: Advertencia"
+ },
+ "COLUMN_DISALLOW_SET_CHARSET": {
+ "title": "Prohibir la definición del conjunto de caracteres en las propiedades de las columnas",
+ "description": "Se recomienda establecer el conjunto de caracteres a nivel de base de datos o de tabla. Establecer el conjunto de caracteres a una granularidad más fina puede traer complejidades innecesarias. Nivel de error sugerido: Error."
+ },
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": {
+ "title": "Restringir la longitud del tipo de dato \"CHAR\"",
+ "description": "\"CHAR\" es un tipo de longitud fija. Por ejemplo, la columna CHAR(20) ocupará 20 espacios de caracteres aunque solo se almacene un carácter, lo que causa desperdicio. Cuando la cadena sea demasiado larga y la longitud no sea fija, se debe considerar el uso de VARCHAR para MySQL y el uso de TEXT para PostgreSQL. Nivel de error sugerido: Error",
"component": {
- "list": {
- "title": "Nombres de tablas"
+ "number": {
+ "title": "Longitud máxima"
}
}
},
- "table-limit-size": {
- "title": "Limitar operaciones DDL en tablas con gran número de filas",
- "description": "Configurar el número máximo de filas en tablas para las cuales se puede ejecutar DDL. Nivel de error recomendado: advertencia",
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": {
+ "title": "Restringir la longitud del tipo de dato \"VARCHAR\"",
+ "description": "",
"component": {
"number": {
- "title": "Recuento máximo de filas"
+ "title": "Longitud máxima"
}
}
},
- "table-disallow-dml": {
- "title": "No permitir DML",
- "description": "Configure qué tablas tienen prohibido ejecutar DML. Nivel de error de sugerencia: Advertencia",
+ "COLUMN_NO_NULL": {
+ "title": "Forzar restricciones \"NOT NULL\" en las columnas",
+ "description": "Las columnas no pueden tener un valor NULL."
+ },
+ "COLUMN_REQUIRED": {
+ "title": "Imponer la inclusión de columnas específicas en una tabla",
+ "description": "Algunas columnas comunes son útiles para el mantenimiento de la aplicación. Por ejemplo, agregar una columna de \"ID\" independiente del negocio como clave primaria evita conflictos de clave primaria causados por cambios en el negocio (como fusiones de negocios) y en algunos escenarios también puede mejorar el rendimiento de inserción de datos. Nivel de error sugerido: Advertencia",
"component": {
"list": {
- "title": "Nombres de tablas"
+ "title": "Lista de prohibiciones"
}
}
},
- "table-require-charset": {
- "title": "Requerir juego de caracteres",
- "description": "Se debe especificar el conjunto de caracteres de la tabla. Nivel de error sugerido: Advertencia"
+ "COLUMN_REQUIRE_CHARSET": {
+ "title": "Requerir juego de caracteres para columnas de texto",
+ "description": "Se debe especificar el conjunto de caracteres de las columnas con tipos de datos de texto. Nivel de error sugerido: Advertencia"
},
- "table-require-collation": {
- "title": "Requerir intercalación",
- "description": "Se debe especificar la intercalación de la tabla. Nivel de error sugerido: Advertencia"
+ "COLUMN_REQUIRE_COLLATION": {
+ "title": "Requerir intercalación para columnas de texto",
+ "description": "Se debe especificar la intercalación de columnas con tipos de datos de texto. Nivel de error sugerido: Advertencia"
},
- "naming-fully-qualified": {
- "title": "Nombre de objeto completo",
- "description": "Forzar el uso de nombres de objetos completamente calificados. Por ejemplo, “schema.table”, nivel de error sugerido: Advertencia"
+ "COLUMN_REQUIRE_DEFAULT": {
+ "title": "Hacer obligatorio establecer un valor por defecto en las columnas",
+ "description": "Establecer valores por defecto que satisfagan la lógica de negocio puede mejorar efectivamente la calidad de los datos del pipeline analítico aguas abajo. Esta regla no verifica los tipos \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\". Nivel de error sugerido: Advertencia"
},
- "naming-table": {
- "title": "Imponer formato de nomenclatura de tabla",
- "description": "El formato predeterminado es todo en minúsculas, separado por guiones bajos entre palabras, y no más de 63 caracteres de largo, como \"abc\" y \"abc_def\". Nivel de sugerencia de error: Advertencia",
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": {
+ "title": "Forzar un valor predeterminado en columnas \"NOT NULL\"",
+ "description": "Para una columna 'NOT NULL', si no se asigna un valor a la columna al insertar una nueva fila y la columna no tiene un valor predeterminado, la base de datos rechazará la inserción de esa fila. Establecer un valor predeterminado para una nueva columna también puede garantizar la compatibilidad con la aplicación heredada. Nivel de error sugerido: Error"
+ },
+ "COLUMN_TYPE_DISALLOW_LIST": {
+ "title": "Prohibir el uso de ciertos tipos de datos de columna",
+ "description": "Abusar de los tipos de columna puede tener graves efectos negativos en el mantenimiento y rendimiento del sistema. Por ejemplo, el uso de una columna \"LOB\" para almacenar grandes cantidades de datos de audio y video puede disminuir el rendimiento de la base de datos, aumentar los tiempos de copia de seguridad y recuperación, y hacer que las herramientas de sincronización de datos sean incompatibles. Nivel de error sugerido: Error",
"component": {
- "format": {
- "title": "Formato de nombre de tabla (regex)"
- },
- "maxLength": {
- "title": "Límite de longitud"
+ "list": {
+ "title": "Prohibir lista"
+ }
+ }
+ },
+ "DATABASE_DROP_EMPTY_DATABASE": {
+ "title": "Prohibir eliminar base de datos no vacía",
+ "description": "Solo se permite la eliminación cuando no hay tablas en la base de datos, lo que puede evitar la eliminación accidental. Nivel de error sugerido: Error"
+ },
+ "ENGINE_MYSQL_USE_INNODB": {
+ "title": "Imponer el motor de almacenamiento InnoDB",
+ "description": "InnoDB es el motor de almacenamiento predeterminado para MySQL que proporciona soporte para transacciones. También proporciona un mejor rendimiento para escenarios de alta concurrencia y baja latencia, y admite copias de seguridad y recuperación de datos en línea. Es la opción preferida para las empresas OLTP. Nivel de sugerencia de error: Error"
+ },
+ "INDEX_CREATE_CONCURRENTLY": {
+ "title": "Aplicar creación de índices concurrentes",
+ "description": "En PostgreSQL 11 y versiones posteriores, usar la declaración estándar para crear un índice causará un bloqueo de tabla y no permitirá escribir. Usar el modo \"CONCURRENTLY\" puede evitar este problema. Nivel de error sugerido: Advertencia"
+ },
+ "INDEX_KEY_NUMBER_LIMIT": {
+ "title": "Restringir el número de columnas en un solo índice",
+ "description": "Un índice compuesto con más de 5 columnas no mejora significativamente el rendimiento de la consulta, pero ocupa mucho espacio y reduce el rendimiento de DML. Nivel de error sugerido: Advertencia",
+ "component": {
+ "number": {
+ "title": "Número máximo de columnas"
}
}
},
- "naming-column": {
+ "INDEX_NOT_REDUNDANT": {
+ "title": "Prohibir índices redundantes",
+ "description": "El índice redundante puede resultar en pérdida de rendimiento y ocupar espacio adicional. Por ejemplo, el índice en las columnas (c1, c2) se tratará como índices redundantes si ya hay un índice en la columna (c1). Nivel de error sugerido: Advertencia"
+ },
+ "INDEX_NO_DUPLICATE_COLUMN": {
+ "title": "Prohibir índices que contengan columnas duplicadas",
+ "description": "La creación de un índice con columnas duplicadas dará como resultado un fallo. Nivel de error sugerido: Error"
+ },
+ "INDEX_PK_TYPE_LIMIT": {
+ "title": "Límite de tipo de clave primaria",
+ "description": "Forzar que el tipo de clave primaria sea INT o BIGINT."
+ },
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": {
+ "title": "Lista permitida de tipos de clave primaria",
+ "description": "El tipo de clave primaria adecuado puede optimizar la estructura de almacenamiento, reducir el uso de espacio y ser beneficioso para el rendimiento de inserción y consulta. Nivel de error sugerido: Advertencia",
+ "component": {
+ "list": {
+ "title": "Permitir lista"
+ }
+ }
+ },
+ "INDEX_TOTAL_NUMBER_LIMIT": {
+ "title": "Restringir el número de índices en una sola tabla",
+ "description": "Aunque los índices pueden mejorar el rendimiento de la consulta, también ocupan mucho espacio y reducen el rendimiento de DML. Por lo tanto, no se recomienda crear más de 5 índices en una tabla. Nivel de error sugerido: Advertencia",
+ "component": {
+ "number": {
+ "title": "Número máximo de índices"
+ }
+ }
+ },
+ "INDEX_TYPE_ALLOW_LIST": {
+ "title": "Lista de tipos de índice permitidos",
+ "description": "Los diferentes tipos de índice tienen diferentes características de rendimiento. Por ejemplo, los índices B-tree son adecuados para consultas de rango, mientras que los índices hash son adecuados para consultas de igualdad. Nivel de error de sugerencia: Advertencia",
+ "component": {
+ "list": {
+ "title": "Lista permitida"
+ }
+ }
+ },
+ "INDEX_TYPE_NO_BLOB": {
+ "title": "Prohibir la creación de índices en columnas de tipo de datos \"BLOB\" y \"TEXT\"",
+ "description": "El tipo \"BLOB\" se utiliza generalmente para almacenar datos binarios y no debe utilizarse como condición de consulta. Si se crea un índice en este tipo de columna por error, consumirá muchos recursos y causará un grave impacto en el rendimiento. Nivel de error sugerido: Error"
+ },
+ "NAMING_COLUMN": {
"title": "Imponer formato de nomenclatura de columna",
"description": "El formato predeterminado es todo en minúsculas, separado por guiones bajos entre palabras, y no más de 63 caracteres de largo, como \"abc\" y \"abc_def\". Nivel de sugerencia de error: Advertencia",
"component": {
@@ -158,39 +243,36 @@
}
}
},
- "naming-index-uk": {
- "title": "Imponer formato de nomenclatura de clave única",
- "description": "El nombre puede estar vacío y nombrado por la base de datos. Si no está vacío, el formato predeterminado es \"uk_<nombre de tabla><combinación de nombre de columna de clave única>\", que no debe superar los 63 caracteres, como \"uk_my_table_id_name\". Nivel de sugerencia de error: Advertencia",
+ "NAMING_COLUMN_AUTO_INCREMENT": {
+ "title": " Imponer el formato de nombres de columna de autoincremento",
+ "description": "El nombre predeterminado de la columna es \"ID\" y no tiene más de 63 caracteres de longitud.",
"component": {
"format": {
- "title": "Formato de nombre de clave única",
- "template": {
- "table": "El nombre de la tabla",
- "column_list": "Nombres de columna del índice, unidos por _"
- }
+ "title": "Formato del nombre de columna de autoincremento (regex)"
},
"maxLength": {
"title": "Límite de longitud"
}
}
},
- "naming-index-pk": {
- "title": "Imponer formato de nomenclatura de clave primaria",
- "description": "El nombre puede estar vacío y nombrado por la base de datos. Si no está vacío, el formato predeterminado es \"pk<nombre de tabla><combinación de nombre de columna de clave única>\", que no debe superar los 63 caracteres, como \"pk_my_table_id_name\". Nivel de sugerencia de error: Advertencia",
+ "NAMING_FULLY_QUALIFIED": {
+ "title": "Nombre de objeto completo",
+ "description": "Forzar el uso de nombres de objetos completamente calificados. Por ejemplo, “schema.table”, nivel de error sugerido: Advertencia"
+ },
+ "NAMING_IDENTIFIER_CASE": {
+ "title": "Hacer cumplir el caso del identificador",
+ "description": "",
"component": {
- "format": {
- "title": "Formato del nombre de clave primaria",
- "template": {
- "table": "El nombre de la tabla",
- "column_list": "Nombres de las columnas de índice, unidos por _"
- }
- },
- "maxLength": {
- "title": "Límite de longitud"
+ "upper": {
+ "title": "Capital"
}
}
},
- "naming-index-fk": {
+ "NAMING_IDENTIFIER_NO_KEYWORD": {
+ "title": "Prohibir el uso de palabras clave como identificadores",
+ "description": ""
+ },
+ "NAMING_INDEX_FK": {
"title": "Imponer el formato de nombres de clave foránea",
"description": "El nombre puede estar vacío y ser nombrado por la base de datos. Si no está vacío, el formato predeterminado es \"fk<nombre de la tabla><combinación de nombres de columna de clave única>\", que no tiene más de 63 caracteres de longitud, como \"fk_my_table_id_name\". Nivel de error sugerido: Advertencia",
"component": {
@@ -208,7 +290,7 @@
}
}
},
- "naming-index-idx": {
+ "NAMING_INDEX_IDX": {
"title": "Imponer el formato de nombres de índice",
"description": "El nombre puede estar vacío y ser nombrado por la base de datos. Si no está vacío, el formato predeterminado es \"idx<nombre de la tabla>_<combinación de nombres de columna de clave única>\", que no tiene más de 63 caracteres de longitud, como \"idx_my_table_id_name\". Nivel de error sugerido: Advertencia",
"component": {
@@ -224,214 +306,71 @@
}
}
},
- "naming-column-auto-increment": {
- "title": " Imponer el formato de nombres de columna de autoincremento",
- "description": "El nombre predeterminado de la columna es \"ID\" y no tiene más de 63 caracteres de longitud.",
+ "NAMING_INDEX_PK": {
+ "title": "Imponer formato de nomenclatura de clave primaria",
+ "description": "El nombre puede estar vacío y nombrado por la base de datos. Si no está vacío, el formato predeterminado es \"pk<nombre de tabla><combinación de nombre de columna de clave única>\", que no debe superar los 63 caracteres, como \"pk_my_table_id_name\". Nivel de sugerencia de error: Advertencia",
"component": {
"format": {
- "title": "Formato del nombre de columna de autoincremento (regex)"
+ "title": "Formato del nombre de clave primaria",
+ "template": {
+ "table": "El nombre de la tabla",
+ "column_list": "Nombres de las columnas de índice, unidos por _"
+ }
},
"maxLength": {
"title": "Límite de longitud"
}
}
},
- "naming-table-no-keyword": {
- "title": "Prohibir el uso de palabras clave como nombres de tablas",
- "description": ""
- },
- "naming-identifier-no-keyword": {
- "title": "Prohibir el uso de palabras clave como identificadores",
- "description": ""
- },
- "naming-identifier-case": {
- "title": "Hacer cumplir el caso del identificador",
- "description": "",
- "component": {
- "upper": {
- "title": "Capital"
- }
- }
- },
- "column-required": {
- "title": "Imponer la inclusión de columnas específicas en una tabla",
- "description": "Algunas columnas comunes son útiles para el mantenimiento de la aplicación. Por ejemplo, agregar una columna de \"ID\" independiente del negocio como clave primaria evita conflictos de clave primaria causados por cambios en el negocio (como fusiones de negocios) y en algunos escenarios también puede mejorar el rendimiento de inserción de datos. Nivel de error sugerido: Advertencia",
- "component": {
- "list": {
- "title": "Lista de prohibiciones"
- }
- }
- },
- "column-type-disallow-list": {
- "title": "Prohibir el uso de ciertos tipos de datos de columna",
- "description": "Abusar de los tipos de columna puede tener graves efectos negativos en el mantenimiento y rendimiento del sistema. Por ejemplo, el uso de una columna \"LOB\" para almacenar grandes cantidades de datos de audio y video puede disminuir el rendimiento de la base de datos, aumentar los tiempos de copia de seguridad y recuperación, y hacer que las herramientas de sincronización de datos sean incompatibles. Nivel de error sugerido: Error",
- "component": {
- "list": {
- "title": "Prohibir lista"
- }
- }
- },
- "column-no-null": {
- "title": "Forzar restricciones \"NOT NULL\" en las columnas",
- "description": "Las columnas no pueden tener un valor NULL."
- },
- "column-disallow-set-charset": {
- "title": "Prohibir la definición del conjunto de caracteres en las propiedades de las columnas",
- "description": "Se recomienda establecer el conjunto de caracteres a nivel de base de datos o de tabla. Establecer el conjunto de caracteres a una granularidad más fina puede traer complejidades innecesarias. Nivel de error sugerido: Error."
- },
- "column-disallow-change-type": {
- "title": "Prohibir la modificación de los tipos de columnas",
- "description": "Modificar los tipos de columnas puede afectar el rendimiento del sistema, la mantenibilidad e incluso llevar a la pérdida de datos. Nivel de error sugerido: Advertencia"
- },
- "column-disallow-change": {
- "title": "Prohibir el uso de la instrucción \"CHANGE COLUMN\"",
- "description": "\"CHANGE COLUMN\" es único en la sintaxis de MySQL y se puede usar para modificar los nombres de las columnas y otras propiedades al mismo tiempo. Sin embargo, puede causar que el nombre de la columna se cambie por error al modificar las propiedades. Se recomienda seguir utilizando las instrucciones estándar \"RENAME\" y \"MODIFY\" para distinguir entre los dos tipos de cambios. Nivel de error sugerido: Error"
- },
- "column-disallow-changing-order": {
- "title": "Prohibir el cambio del orden de las columnas en una tabla",
- "description": "Modificar el orden de las columnas puede hacer que algunas aplicaciones o vistas que dependen del orden predeterminado de la tabla original produzcan resultados inesperados, como \"select *\". Nivel de error sugerido: Advertencia"
- },
- "column-disallow-drop": {
- "title": "Prohibir eliminar columnas",
- "description": "Se prohíbe eliminar columnas. Nivel de error sugerido: advertencia."
- },
- "column-disallow-drop-in-index": {
- "title": "Prohibir eliminar columnas en el índice",
- "description": "Prohibir eliminar columnas en el índice. Nivel de error sugerido: Advertencia"
- },
- "column-set-default-for-not-null": {
- "title": "Forzar un valor predeterminado en columnas \"NOT NULL\"",
- "description": "Para una columna 'NOT NULL', si no se asigna un valor a la columna al insertar una nueva fila y la columna no tiene un valor predeterminado, la base de datos rechazará la inserción de esa fila. Establecer un valor predeterminado para una nueva columna también puede garantizar la compatibilidad con la aplicación heredada. Nivel de error sugerido: Error"
- },
- "column-auto-increment-must-integer": {
- "title": "Forzar el uso del tipo de datos \"INTEGER\" para columnas de autoincremento",
- "description": "Las columnas de autoincremento de MySQL se utilizan generalmente como claves primarias independientes del negocio. El uso de tipos enteros ocupa menos espacio de almacenamiento y hace que la estructura de índice de clave primaria sea más compacta, lo que mejora el rendimiento de consultas y DML. Nivel de error sugerido: Error"
- },
- "column-auto-increment-must-unsigned": {
- "title": "Hacer obligatorio el uso del tipo de dato \"UNSIGNED\" para columnas de autoincremento",
- "description": "Los tipos no signados no almacenan números negativos, y el rango de valores que pueden almacenar se duplica, lo que puede evitar que las columnas de autoincremento desborden. Nivel de error sugerido: Advertencia"
- },
- "column-comment": {
- "title": "Convención de comentarios de columnas",
- "description": "Agregar comentarios a las columnas es una buena práctica de desarrollo, pero comentarios demasiado largos pueden disminuir la legibilidad del esquema. Nivel de error sugerido: Advertencia",
+ "NAMING_INDEX_UK": {
+ "title": "Imponer formato de nomenclatura de clave única",
+ "description": "El nombre puede estar vacío y nombrado por la base de datos. Si no está vacío, el formato predeterminado es \"uk_<nombre de tabla><combinación de nombre de columna de clave única>\", que no debe superar los 63 caracteres, como \"uk_my_table_id_name\". Nivel de sugerencia de error: Advertencia",
"component": {
- "required": {
- "title": "Comentario obligatorio"
- },
- "requiredClassification": {
- "title": "Requerir clasificación",
- "tooltip": "El comentario debe seguir el formato {'{'}identificación de clasificación{'}'}-{'{'}comentario{'}'}."
+ "format": {
+ "title": "Formato de nombre de clave única",
+ "template": {
+ "table": "El nombre de la tabla",
+ "column_list": "Nombres de columna del índice, unidos por _"
+ }
},
"maxLength": {
- "title": "Longitud máxima"
- }
- }
- },
- "column-maximum-character-length": {
- "title": "Restringir la longitud del tipo de dato \"CHAR\"",
- "description": "\"CHAR\" es un tipo de longitud fija. Por ejemplo, la columna CHAR(20) ocupará 20 espacios de caracteres aunque solo se almacene un carácter, lo que causa desperdicio. Cuando la cadena sea demasiado larga y la longitud no sea fija, se debe considerar el uso de VARCHAR para MySQL y el uso de TEXT para PostgreSQL. Nivel de error sugerido: Error",
- "component": {
- "number": {
- "title": "Longitud máxima"
- }
- }
- },
- "column-maximum-varchar-length": {
- "title": "Restringir la longitud del tipo de dato \"VARCHAR\"",
- "description": "",
- "component": {
- "number": {
- "title": "Longitud máxima"
+ "title": "Límite de longitud"
}
}
},
- "column-auto-increment-initial-value": {
- "title": "Restringir el valor inicial de las columnas de autoincremento",
- "description": "Basándose en los requisitos de gestión, se debe limitar el valor inicial de la columna de autoincremento. Nivel de error sugerido: Advertencia",
+ "NAMING_TABLE": {
+ "title": "Imponer formato de nomenclatura de tabla",
+ "description": "El formato predeterminado es todo en minúsculas, separado por guiones bajos entre palabras, y no más de 63 caracteres de largo, como \"abc\" y \"abc_def\". Nivel de sugerencia de error: Advertencia",
"component": {
- "number": {
- "title": "Valor inicial"
+ "format": {
+ "title": "Formato de nombre de tabla (regex)"
+ },
+ "maxLength": {
+ "title": "Límite de longitud"
}
}
},
- "column-current-time-count-limit": {
- "title": "Restringir el número de columnas en la tabla que adquieren la hora del sistema",
- "description": "Solo las columnas que registran la hora de creación del registro con \"DEFAULT NOW()\" y que registran la hora de actualización del registro con \"DEFAULT NOW() ON UPDATE\" necesitan llamar a la función para obtener la hora del sistema. Es inútil y aumentará la sobrecarga de recursos registrar la hora del sistema en otras columnas. Nivel de error sugerido: Error"
- },
- "column-require-default": {
- "title": "Hacer obligatorio establecer un valor por defecto en las columnas",
- "description": "Establecer valores por defecto que satisfagan la lógica de negocio puede mejorar efectivamente la calidad de los datos del pipeline analítico aguas abajo. Esta regla no verifica los tipos \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\". Nivel de error sugerido: Advertencia"
- },
- "column-default-disallow-volatile": {
- "title": "No permitir establecer valores predeterminados volátiles en las columnas",
- "description": "Las funciones volátiles (por ejemplo, clock_timestamp()) actualizan cada fila con el valor en el momento de la ejecución de ALTER TABLE ADD COLUMN, lo que puede causar actualizaciones prolongadas."
- },
- "column-require-charset": {
- "title": "Requerir juego de caracteres para columnas de texto",
- "description": "Se debe especificar el conjunto de caracteres de las columnas con tipos de datos de texto. Nivel de error sugerido: Advertencia"
- },
- "column-require-collation": {
- "title": "Requerir intercalación para columnas de texto",
- "description": "Se debe especificar la intercalación de columnas con tipos de datos de texto. Nivel de error sugerido: Advertencia"
- },
- "statement-select-no-select-all": {
- "title": "Prohibir el uso de \"SELECT *\"",
- "description": "El uso de SELECT * para obtener todos los datos de una fila puede causar una sobrecarga de recursos innecesaria y también puede causar resultados inesperados en las aplicaciones una vez que la tabla agrega o elimina columnas. Nivel de sugerencia de error: Error"
- },
- "statement-where-require-select": {
- "title": "Hacer cumplir la presencia de la condición \"WHERE\" en las instrucciones SELECT",
- "description": "Las consultas sin la cláusula WHERE pueden causar una sobrecarga de recursos innecesaria y enorme. Nivel de error sugerido: Error"
- },
- "statement-where-require-update-delete": {
- "title": "Hacer cumplir la presencia de la condición \"WHERE\" en las declaraciones",
- "description": "Los DML sin cláusula WHERE pueden provocar una pérdida masiva de datos accidental. Nivel de error sugerido: Error"
- },
- "statement-where-no-leading-wildcard-like": {
- "title": "Prohibir el uso de comodines principales en las condiciones de filtrado",
- "description": "Al usar comodines principales, como \"LIKE '%ABC'\", el optimizador de la base de datos no puede usar el escaneo de índice rápido y debe recurrir al escaneo completo de la tabla o del índice completo, lo que puede causar un impacto grave en el rendimiento. Nivel de sugerencia de error: Error"
- },
- "statement-disallow-on-del-cascade": {
- "title": "Prohibir el uso de la opción CASCADE en las cláusulas ON DELETE",
- "description": "La opción 'CASCADE' en 'ON DELETE' puede causar que se eliminen o modifiquen un gran número de objetos dependientes, lo que puede causar resultados inesperados. Nivel de error sugerido: Error"
- },
- "statement-disallow-rm-tbl-cascade": {
- "title": "Prohibir el uso de CASCADE al eliminar una tabla",
- "description": "Using the \"CASCADE\" option when removing a table can cause a large number of dependent objects to be deleted or modified, which may cause unexpected results. Suggestion error level: Error"
- },
- "statement-disallow-commit": {
- "title": "Prohibir la declaración explícita de \"COMMIT\"",
- "description": "En algunos casos, se requiere que varias declaraciones se incluyan en una transacción confirmada por el sistema, para poder volver a ejecutarse rápidamente en caso de fallo parcial. Por lo tanto, no se permite la declaración explícita de \"COMMIT\". Nivel de sugerencia de error: Advertencia"
- },
- "statement-disallow-limit": {
- "title": "Prohibir el uso de la cláusula \"LIMIT\" en declaraciones DML",
- "description": "Si se utiliza LIMIT en declaraciones DML sin una cláusula ORDER BY, el orden de las filas afectadas no está fijo, lo que puede causar inconsistencias de datos entre las bases de datos primarias y de réplica en algunos modos de replicación. Nivel de sugerencia de error: Error"
- },
- "statement-disallow-order-by": {
- "title": "Prohibir el uso de la cláusula \"ORDER BY\" en las declaraciones \"UPDATE\" y \"DELETE\"",
- "description": "Las operaciones de clasificación son extremadamente intensivas en recursos, por lo que para operaciones de actualización y eliminación, se recomienda utilizar una condición de filtrado determinista tanto como sea posible en lugar de usar ORDER BY y LIMIT. Nivel de sugerencia de error: Error"
+ "NAMING_TABLE_NO_KEYWORD": {
+ "title": "Prohibir el uso de palabras clave como nombres de tablas",
+ "description": ""
},
- "statement-merge-alter-table": {
- "title": "Prohibir la emisión de múltiples cambios independientes en la misma tabla",
- "description": "Cada cambio en una tabla puede causar un bloqueo a nivel de tabla y consumir una gran cantidad de recursos. Si hay múltiples cambios en la misma tabla, deben fusionarse en una única declaración de cambio. Nivel de sugerencia de error: Error"
+ "SCHEMA_BACKWARD_COMPATIBILITY": {
+ "title": "Comprobación de la compatibilidad con versiones anteriores de la aplicación",
+ "description": "Algunos cambios pueden afectar las aplicaciones en ejecución, como modificar el nombre del objeto de la base de datos, agregar nuevas restricciones, etc. Esta regla puede evitar cambios descuidados que lleven al fallo de la aplicación existente. Nivel de error sugerido: Advertencia"
},
- "statement-insert-must-specify-column": {
- "title": "Obligar a especificar nombres de columnas en declaraciones \"INSERT\"",
- "description": "La declaración \"INSERT INTO table VALUES (...)\" no lista explícitamente los nombres de las columnas. Una vez que cambia el orden de las columnas o se agregan o eliminan columnas, la declaración puede fallar o generar datos inesperados. Nivel de sugerencia de error: Error"
+ "STATEMENT_ADD_CHECK_NOT_VALID": {
+ "title": "Obligar a incluir la opción \"NOT VALID\" al agregar restricciones \"CHECK\"",
+ "description": "Agregar una restricción CHECK necesita verificar los datos existentes y requiere el bloqueo de tabla ACCESS EXCLUSIVE. Esto bloquea la lectura y la escritura, lo que puede provocar la interrupción del negocio. Se recomienda agregar la opción \"NOT VALID\" para validar nuevos datos y validar manualmente los datos existentes después de completar el cambio. Nivel de sugerencia de error: Advertencia"
},
- "statement-insert-disallow-order-by-rand": {
- "title": "Prohibir el uso de \"ORDER BY rand()\" en declaraciones \"INSERT\"",
- "description": "Ordenar aleatoriamente los datos a insertar no tiene sentido y solo consume recursos innecesarios. Nivel de sugerencia de error: Error"
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": {
+ "title": "Prohibir añadir columnas en una posición especificada",
+ "description": "En algunos casos, usar FIRST/AFTER para añadir columnas en una posición especificada puede causar una reorganización de los datos (reescribiendo los datos originales). Nivel de recomendación: advertencia."
},
- "statement-insert-row-limit": {
- "title": "Restringir el número máximo de filas insertadas",
- "description": "Revelar el número de filas a insertar puede ayudar a determinar si la declaración cumple con las expectativas comerciales. Nivel de sugerencia de error: Advertencia",
- "component": {
- "number": {
- "title": "Cantidad máxima de inserciones"
- }
- }
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": {
+ "title": "Aplicar la opción \"NO VÁLIDO\" al agregar claves externas",
+ "description": "Agregar claves externas necesita verificar los datos existentes y requiere el bloqueo de tabla SHARE ROW EXCLUSIVE. \nEsto bloquea la escritura, lo que puede provocar la interrupción del negocio. \nSe recomienda agregar la opción \"NO VÁLIDO\" para validar datos nuevos y validar los datos existentes una vez completado el cambio. \nNivel de error de sugerencia: Advertencia"
},
- "statement-affected-row-limit": {
+ "STATEMENT_AFFECTED_ROW_LIMIT": {
"title": "Restringir el número máximo de filas actualizadas o eliminadas (estimada).",
"description": "Revelar el número de filas a actualizar o eliminar puede ayudar a determinar si la declaración cumple con las expectativas comerciales. Nivel de sugerencia de error: Advertencia",
"component": {
@@ -440,87 +379,102 @@
}
}
},
- "statement-dml-dry-run": {
- "title": "Validar la ejecutabilidad de declaraciones DML",
- "description": "Cuando la sintaxis es correcta, pero el nombre de la tabla es incorrecto o el permiso es insuficiente, se puede descubrir mediante una simulación antes de la ejecución real. Nivel de sugerencia de error: Advertencia"
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": {
+ "title": "Verificar si la Declaración de Establecimiento de Rol está al Principio",
+ "description": "La falla al establecer correctamente la declaración de rol al principio de una sesión puede llevar a accesos no autorizados o asignación de permisos incorrecta, comprometiendo potencialmente la seguridad e integridad de los datos. Nivel de error: Advertencia"
+ },
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": {
+ "title": "Prohibir la creación de objetos sin especificar el esquema",
+ "description": "Si no se especifica el esquema, el objeto se creará en el esquema predeterminado, lo que puede causar resultados inesperados."
},
- "statement-disallow-add-column-with-default": {
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": {
"title": "Restringir agregar columnas con valores predeterminados a una tabla",
"description": "Antes de PostgreSQL 11, agregar una columna con un valor predeterminado causaba bloqueos en la tabla y no se podía leer ni escribir, lo que podía causar interrupciones comerciales. En PostgreSQL 11 y versiones posteriores, este problema se ha optimizado y no es necesario prestar atención a esta regla. Nivel de sugerencia de error: Advertencia"
},
- "statement-add-check-not-valid": {
- "title": "Obligar a incluir la opción \"NOT VALID\" al agregar restricciones \"CHECK\"",
- "description": "Agregar una restricción CHECK necesita verificar los datos existentes y requiere el bloqueo de tabla ACCESS EXCLUSIVE. Esto bloquea la lectura y la escritura, lo que puede provocar la interrupción del negocio. Se recomienda agregar la opción \"NOT VALID\" para validar nuevos datos y validar manualmente los datos existentes después de completar el cambio. Nivel de sugerencia de error: Advertencia"
- },
- "statement-disallow-add-not-null": {
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": {
"title": "Restricción de agregar restricción \"NOT NULL\" a columnas existentes",
"description": "Agregar una restricción NOT NULL con un valor predeterminado antes de PostgreSQL 11 o agregar una restricción NOT NULL sin un valor predeterminado requiere verificar los datos existentes. Esto bloquea la lectura y la escritura, lo que puede provocar la interrupción del negocio. Nivel de error sugerido: Advertencia"
},
- "statement-select-full-table-scan": {
- "title": "Verificar escaneo completo de tabla en consultas",
- "description": "El escaneo completo de tabla es una operación intensiva en recursos y puede causar un impacto grave en el rendimiento. Nivel de sugerencia de error: Error"
+ "STATEMENT_DISALLOW_COMMIT": {
+ "title": "Prohibir la declaración explícita de \"COMMIT\"",
+ "description": "En algunos casos, se requiere que varias declaraciones se incluyan en una transacción confirmada por el sistema, para poder volver a ejecutarse rápidamente en caso de fallo parcial. Por lo tanto, no se permite la declaración explícita de \"COMMIT\". Nivel de sugerencia de error: Advertencia"
},
- "statement-create-specify-schema": {
- "title": "Prohibir la creación de objetos sin especificar el esquema",
- "description": "Si no se especifica el esquema, el objeto se creará en el esquema predeterminado, lo que puede causar resultados inesperados."
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": {
+ "title": "Prohibir consultas entre bases de datos",
+ "description": "Las consultas entre bases de datos aumentan el acoplamiento del sistema y pueden llevar a problemas de eficiencia. Nivel de error sugerido: Advertencia"
},
- "statement-check-set-role-variable": {
- "title": "Verificar si la Declaración de Establecimiento de Rol está al Principio",
- "description": "La falla al establecer correctamente la declaración de rol al principio de una sesión puede llevar a accesos no autorizados o asignación de permisos incorrecta, comprometiendo potencialmente la seguridad e integridad de los datos. Nivel de error: Advertencia"
+ "STATEMENT_DISALLOW_LIMIT": {
+ "title": "Prohibir el uso de la cláusula \"LIMIT\" en declaraciones DML",
+ "description": "Si se utiliza LIMIT en declaraciones DML sin una cláusula ORDER BY, el orden de las filas afectadas no está fijo, lo que puede causar inconsistencias de datos entre las bases de datos primarias y de réplica en algunos modos de replicación. Nivel de sugerencia de error: Error"
},
- "statement-disallow-using-temporary": {
- "title": "Prohibir el uso de tablas temporales",
- "description": "Las tablas temporales pueden causar problemas de rendimiento y de mantenimiento. Nivel de error sugerido: Advertencia"
+ "STATEMENT_DISALLOW_OFFLINE_DDL": {
+ "title": "Prohibir DDL sin conexión",
+ "description": "Para evitar que los cambios en la base de datos afecten su negocio, por favor evite usar DDL sin conexión."
+ },
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": {
+ "title": "Prohibir el uso de la opción CASCADE en las cláusulas ON DELETE",
+ "description": "La opción 'CASCADE' en 'ON DELETE' puede causar que se eliminen o modifiquen un gran número de objetos dependientes, lo que puede causar resultados inesperados. Nivel de error sugerido: Error"
+ },
+ "STATEMENT_DISALLOW_ORDER_BY": {
+ "title": "Prohibir el uso de la cláusula \"ORDER BY\" en las declaraciones \"UPDATE\" y \"DELETE\"",
+ "description": "Las operaciones de clasificación son extremadamente intensivas en recursos, por lo que para operaciones de actualización y eliminación, se recomienda utilizar una condición de filtrado determinista tanto como sea posible en lugar de usar ORDER BY y LIMIT. Nivel de sugerencia de error: Error"
+ },
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": {
+ "title": "Prohibir el uso de CASCADE al eliminar una tabla",
+ "description": "Using the \"CASCADE\" option when removing a table can cause a large number of dependent objects to be deleted or modified, which may cause unexpected results. Suggestion error level: Error"
},
- "statement-disallow-using-filesort": {
+ "STATEMENT_DISALLOW_USING_FILESORT": {
"title": "Prohibir el uso de filesort",
"description": "El uso de filesort puede causar un impacto grave en el rendimiento. Nivel de error sugerido: Advertencia"
},
- "statement-where-no-equal-null": {
- "title": "Prohibir el uso de comparación de igualdad con NULL en la cláusula WHERE",
- "description": "El resultado de la comparación de igualdad con NULL siempre es NULL, lo que puede causar resultados inesperados. Nivel de error de sugerencia: Advertencia"
+ "STATEMENT_DISALLOW_USING_TEMPORARY": {
+ "title": "Prohibir el uso de tablas temporales",
+ "description": "Las tablas temporales pueden causar problemas de rendimiento y de mantenimiento. Nivel de error sugerido: Advertencia"
},
- "statement-where-disallow-functions-and-calculations": {
- "title": "No aplique funciones ni realice cálculos en campos indexados en la cláusula WHERE",
- "description": "Si aplica una función o realiza un cálculo en el campo indexado, la base de datos no puede usar el índice y tiene que escanear toda la tabla."
+ "STATEMENT_DML_DRY_RUN": {
+ "title": "Validar la ejecutabilidad de declaraciones DML",
+ "description": "Cuando la sintaxis es correcta, pero el nombre de la tabla es incorrecto o el permiso es insuficiente, se puede descubrir mediante una simulación antes de la ejecución real. Nivel de sugerencia de error: Advertencia"
},
- "statement-query-minimum-plan-level": {
- "title": "Limitar el nivel máximo del método de acceso a la consulta",
- "description": "La optimización del rendimiento de SQL busca un acceso constante (const), con el nivel de referencia (ref) como base, y un rendimiento aceptable a nivel de rango.",
- "component": {
- "level": {
- "title": "Nivel maximo"
- }
- }
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": {
+ "title": "Prohibir el uso de \"ORDER BY rand()\" en declaraciones \"INSERT\"",
+ "description": "Ordenar aleatoriamente los datos a insertar no tiene sentido y solo consume recursos innecesarios. Nivel de sugerencia de error: Error"
},
- "statement-where-maximum-logical-operator-count": {
- "title": "Limitar el número de valores en las cláusulas IN u OR dentro de la cláusula WHERE",
- "description": "Esto evita la degradación del rendimiento debido a comparaciones exhaustivas y limitaciones de recursos.",
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": {
+ "title": "Obligar a especificar nombres de columnas en declaraciones \"INSERT\"",
+ "description": "La declaración \"INSERT INTO table VALUES (...)\" no lista explícitamente los nombres de las columnas. Una vez que cambia el orden de las columnas o se agregan o eliminan columnas, la declaración puede fallar o generar datos inesperados. Nivel de sugerencia de error: Error"
+ },
+ "STATEMENT_INSERT_ROW_LIMIT": {
+ "title": "Restringir el número máximo de filas insertadas",
+ "description": "Revelar el número de filas a insertar puede ayudar a determinar si la declaración cumple con las expectativas comerciales. Nivel de sugerencia de error: Advertencia",
"component": {
"number": {
- "title": "Número máximo"
+ "title": "Cantidad máxima de inserciones"
}
}
},
- "statement-maximum-limit-value": {
- "title": "Limitar el número máximo de la cláusula LIMIT",
- "description": "Limitar el número de filas mediante LIMIT garantiza que la base de datos procese bloques manejables, lo que mejora la velocidad de ejecución de las consultas. Un valor LIMIT limitado evita el uso excesivo de memoria, salvaguardando la estabilidad general del sistema y evitando la degradación del rendimiento.",
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {
+ "title": "Los campos a unir deben tener tipos de datos y conjuntos de caracteres idénticos",
+ "description": "Si los tipos de datos y los juegos de caracteres de las columnas de unión no son idénticos, es posible que la base de datos no pueda identificar correctamente las filas coincidentes, lo que dará lugar a resultados inexactos o incompletos."
+ },
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {
+ "title": "Limite el número de tablas a unir",
+ "description": "Cuanto más tablas unes, más compleja se vuelve la consulta y más tardará en ejecutarse. En general, es recomendable mantener el número de uniones al mínimo.",
"component": {
"number": {
"title": "Valor máximo"
}
}
},
- "statement-maximum-join-table-count": {
- "title": "Limite el número de tablas a unir",
- "description": "Cuanto más tablas unes, más compleja se vuelve la consulta y más tardará en ejecutarse. En general, es recomendable mantener el número de uniones al mínimo.",
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": {
+ "title": "Limitar el número máximo de la cláusula LIMIT",
+ "description": "Limitar el número de filas mediante LIMIT garantiza que la base de datos procese bloques manejables, lo que mejora la velocidad de ejecución de las consultas. Un valor LIMIT limitado evita el uso excesivo de memoria, salvaguardando la estabilidad general del sistema y evitando la degradación del rendimiento.",
"component": {
"number": {
"title": "Valor máximo"
}
}
},
- "statement-maximum-statements-in-transaction": {
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {
"title": "Limitar el número de sentencias en una transacción",
"description": "Las transacciones grandes pueden impactar significativamente el rendimiento de la base de datos. Si se involucra una gran cantidad de sentencias y una falla, revertir toda la transacción se vuelve complejo. Limitar las sentencias minimiza el daño potencial causado por una sola falla y simplifica los procedimientos de recuperación.",
"component": {
@@ -529,31 +483,7 @@
}
}
},
- "statement-join-strict-column-attrs": {
- "title": "Los campos a unir deben tener tipos de datos y conjuntos de caracteres idénticos",
- "description": "Si los tipos de datos y los juegos de caracteres de las columnas de unión no son idénticos, es posible que la base de datos no pueda identificar correctamente las filas coincidentes, lo que dará lugar a resultados inexactos o incompletos."
- },
- "statement-prior-backup-check": {
- "title": "Verificar la existencia de una copia de seguridad previa antes de cambiar los datos",
- "description": "Esta regla verificará si se puede crear una copia de seguridad antes del cambio de datos. Para más detalles, contiene la existencia de la base de datos objetivo de la copia de seguridad y no permite la sentencia DDL."
- },
- "statement-add-column-without-position": {
- "title": "Prohibir añadir columnas en una posición especificada",
- "description": "En algunos casos, usar FIRST/AFTER para añadir columnas en una posición especificada puede causar una reorganización de los datos (reescribiendo los datos originales). Nivel de recomendación: advertencia."
- },
- "statement-disallow-offline-ddl": {
- "title": "Prohibir DDL sin conexión",
- "description": "Para evitar que los cambios en la base de datos afecten su negocio, por favor evite usar DDL sin conexión."
- },
- "statement-disallow-cross-db-queries": {
- "title": "Prohibir consultas entre bases de datos",
- "description": "Las consultas entre bases de datos aumentan el acoplamiento del sistema y pueden llevar a problemas de eficiencia. Nivel de error sugerido: Advertencia"
- },
- "schema-backward-compatibility": {
- "title": "Comprobación de la compatibilidad con versiones anteriores de la aplicación",
- "description": "Algunos cambios pueden afectar las aplicaciones en ejecución, como modificar el nombre del objeto de la base de datos, agregar nuevas restricciones, etc. Esta regla puede evitar cambios descuidados que lleven al fallo de la aplicación existente. Nivel de error sugerido: Advertencia"
- },
- "statement-max-execution-time": {
+ "STATEMENT_MAX_EXECUTION_TIME": {
"title": "Aplicar el parámetro de tiempo máximo de ejecución",
"description": "Establezca el tiempo máximo de ejecución de las sentencias SQL. Si el tiempo de ejecución supera el límite, la sentencia finalizará. Nivel de error sugerido: Advertencia",
"mysql": {
@@ -565,75 +495,73 @@
"description": "Establezca el parámetro MAX_STATEMENT_TIME en el script de cambio para controlar explícitamente el tiempo máximo de ejecución de la declaración. Nivel de error sugerido: Advertencia"
}
},
- "statement-require-algorithm-option": {
+ "STATEMENT_MERGE_ALTER_TABLE": {
+ "title": "Prohibir la emisión de múltiples cambios independientes en la misma tabla",
+ "description": "Cada cambio en una tabla puede causar un bloqueo a nivel de tabla y consumir una gran cantidad de recursos. Si hay múltiples cambios en la misma tabla, deben fusionarse en una única declaración de cambio. Nivel de sugerencia de error: Error"
+ },
+ "STATEMENT_NON_TRANSACTIONAL": {
+ "title": "Detectar y reportar declaraciones no transaccionales",
+ "description": ""
+ },
+ "STATEMENT_OBJECT_OWNER_CHECK": {
+ "title": "Verificación del propietario del objeto",
+ "description": "Esta regla verifica si el propietario del objeto para DDL es el mismo que el usuario actual."
+ },
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {
+ "title": "Limitar el nivel máximo del método de acceso a la consulta",
+ "description": "La optimización del rendimiento de SQL busca un acceso constante (const), con el nivel de referencia (ref) como base, y un rendimiento aceptable a nivel de rango.",
+ "component": {
+ "level": {
+ "title": "Nivel maximo"
+ }
+ }
+ },
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": {
"title": "Requiere especificar la opción ALGORITMO en las instrucciones ALTER TABLE",
"description": "La especificación de la opción ALGORITHM en las instrucciones ALTER TABLE garantiza un mayor control sobre cómo se aplican los cambios en las tablas, lo que minimiza las posibles interrupciones al evitar copias o bloqueos completos de las tablas. Ayuda a optimizar el rendimiento y reducir el tiempo de inactividad durante las modificaciones del esquema. Nivel de error sugerido: Advertencia."
},
- "statement-require-lock-option": {
+ "STATEMENT_REQUIRE_LOCK_OPTION": {
"title": "Requerir especificar la opción LOCK en las instrucciones ALTER TABLE",
"description": "La opción LOCK en las instrucciones ALTER TABLE le permite controlar el nivel de bloqueo durante los cambios de esquema, lo que ayuda a evitar bloqueos de tablas innecesarios y garantiza una mejor concurrencia. El uso adecuado de esta opción puede reducir significativamente el impacto de las operaciones DDL en las consultas activas. Nivel de error sugerido: Advertencia."
},
- "database-drop-empty-database": {
- "title": "Prohibir eliminar base de datos no vacía",
- "description": "Solo se permite la eliminación cuando no hay tablas en la base de datos, lo que puede evitar la eliminación accidental. Nivel de error sugerido: Error"
- },
- "index-no-duplicate-column": {
- "title": "Prohibir índices que contengan columnas duplicadas",
- "description": "La creación de un índice con columnas duplicadas dará como resultado un fallo. Nivel de error sugerido: Error"
- },
- "index-type-no-blob": {
- "title": "Prohibir la creación de índices en columnas de tipo de datos \"BLOB\" y \"TEXT\"",
- "description": "El tipo \"BLOB\" se utiliza generalmente para almacenar datos binarios y no debe utilizarse como condición de consulta. Si se crea un índice en este tipo de columna por error, consumirá muchos recursos y causará un grave impacto en el rendimiento. Nivel de error sugerido: Error"
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": {
+ "title": "Verificar escaneo completo de tabla en consultas",
+ "description": "El escaneo completo de tabla es una operación intensiva en recursos y puede causar un impacto grave en el rendimiento. Nivel de sugerencia de error: Error"
},
- "index-pk-type-limit": {
- "title": "Límite de tipo de clave primaria",
- "description": "Forzar que el tipo de clave primaria sea INT o BIGINT."
+ "STATEMENT_SELECT_NO_SELECT_ALL": {
+ "title": "Prohibir el uso de \"SELECT *\"",
+ "description": "El uso de SELECT * para obtener todos los datos de una fila puede causar una sobrecarga de recursos innecesaria y también puede causar resultados inesperados en las aplicaciones una vez que la tabla agrega o elimina columnas. Nivel de sugerencia de error: Error"
},
- "index-key-number-limit": {
- "title": "Restringir el número de columnas en un solo índice",
- "description": "Un índice compuesto con más de 5 columnas no mejora significativamente el rendimiento de la consulta, pero ocupa mucho espacio y reduce el rendimiento de DML. Nivel de error sugerido: Advertencia",
- "component": {
- "number": {
- "title": "Número máximo de columnas"
- }
- }
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": {
+ "title": "No aplique funciones ni realice cálculos en campos indexados en la cláusula WHERE",
+ "description": "Si aplica una función o realiza un cálculo en el campo indexado, la base de datos no puede usar el índice y tiene que escanear toda la tabla."
},
- "index-total-number-limit": {
- "title": "Restringir el número de índices en una sola tabla",
- "description": "Aunque los índices pueden mejorar el rendimiento de la consulta, también ocupan mucho espacio y reducen el rendimiento de DML. Por lo tanto, no se recomienda crear más de 5 índices en una tabla. Nivel de error sugerido: Advertencia",
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": {
+ "title": "Limitar el número de valores en las cláusulas IN u OR dentro de la cláusula WHERE",
+ "description": "Esto evita la degradación del rendimiento debido a comparaciones exhaustivas y limitaciones de recursos.",
"component": {
"number": {
- "title": "Número máximo de índices"
+ "title": "Número máximo"
}
}
},
- "index-primary-key-type-allowlist": {
- "title": "Lista permitida de tipos de clave primaria",
- "description": "El tipo de clave primaria adecuado puede optimizar la estructura de almacenamiento, reducir el uso de espacio y ser beneficioso para el rendimiento de inserción y consulta. Nivel de error sugerido: Advertencia",
- "component": {
- "list": {
- "title": "Permitir lista"
- }
- }
+ "STATEMENT_WHERE_NO_EQUAL_NULL": {
+ "title": "Prohibir el uso de comparación de igualdad con NULL en la cláusula WHERE",
+ "description": "El resultado de la comparación de igualdad con NULL siempre es NULL, lo que puede causar resultados inesperados. Nivel de error de sugerencia: Advertencia"
},
- "index-create-concurrently": {
- "title": "Aplicar creación de índices concurrentes",
- "description": "En PostgreSQL 11 y versiones posteriores, usar la declaración estándar para crear un índice causará un bloqueo de tabla y no permitirá escribir. Usar el modo \"CONCURRENTLY\" puede evitar este problema. Nivel de error sugerido: Advertencia"
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": {
+ "title": "Prohibir el uso de comodines principales en las condiciones de filtrado",
+ "description": "Al usar comodines principales, como \"LIKE '%ABC'\", el optimizador de la base de datos no puede usar el escaneo de índice rápido y debe recurrir al escaneo completo de la tabla o del índice completo, lo que puede causar un impacto grave en el rendimiento. Nivel de sugerencia de error: Error"
},
- "index-type-allow-list": {
- "title": "Lista de tipos de índice permitidos",
- "description": "Los diferentes tipos de índice tienen diferentes características de rendimiento. Por ejemplo, los índices B-tree son adecuados para consultas de rango, mientras que los índices hash son adecuados para consultas de igualdad. Nivel de error de sugerencia: Advertencia",
- "component": {
- "list": {
- "title": "Lista permitida"
- }
- }
+ "STATEMENT_WHERE_REQUIRE_SELECT": {
+ "title": "Hacer cumplir la presencia de la condición \"WHERE\" en las instrucciones SELECT",
+ "description": "Las consultas sin la cláusula WHERE pueden causar una sobrecarga de recursos innecesaria y enorme. Nivel de error sugerido: Error"
},
- "index-not-redundant": {
- "title": "Prohibir índices redundantes",
- "description": "El índice redundante puede resultar en pérdida de rendimiento y ocupar espacio adicional. Por ejemplo, el índice en las columnas (c1, c2) se tratará como índices redundantes si ya hay un índice en la columna (c1). Nivel de error sugerido: Advertencia"
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": {
+ "title": "Hacer cumplir la presencia de la condición \"WHERE\" en las declaraciones",
+ "description": "Los DML sin cláusula WHERE pueden provocar una pérdida masiva de datos accidental. Nivel de error sugerido: Error"
},
- "system-charset-allowlist": {
+ "SYSTEM_CHARSET_ALLOWLIST": {
"title": "Lista permitida de juegos de caracteres",
"description": "El juego de caracteres determina qué caracteres se pueden almacenar en la tabla. El uso de un juego de caracteres incorrecto puede hacer que ciertos caracteres de la aplicación no se puedan almacenar ni mostrar correctamente, como los caracteres CJK y Emoji. Nivel de error sugerido: Error",
"component": {
@@ -642,7 +570,7 @@
}
}
},
- "system-collation-allowlist": {
+ "SYSTEM_COLLATION_ALLOWLIST": {
"title": "Lista permitida de ordenaciones",
"description": "La ordenación determina las reglas para la comparación y clasificación de caracteres. Por ejemplo, al utilizar una ordenación que no distingue entre mayúsculas y minúsculas, \"ABC\" y \"abc\" se tratarán como la misma cadena en las consultas. Nivel de error sugerido: Error",
"component": {
@@ -651,7 +579,7 @@
}
}
},
- "system-comment-length": {
+ "SYSTEM_COMMENT_LENGTH": {
"title": "Restricción en la longitud de los comentarios",
"description": "",
"component": {
@@ -660,55 +588,123 @@
}
}
},
- "system-procedure-disallow-create": {
- "title": "Prohibir la ejecución de procedimientos del sistema",
- "description": "Los procedimientos del sistema pueden realizar operaciones de alto riesgo, como la eliminación de datos, la modificación de la estructura de la base de datos, etc. Nivel de error sugerido: Advertencia"
- },
- "system-event-disallow-create": {
+ "SYSTEM_EVENT_DISALLOW_CREATE": {
"title": "Prohibir la creación de eventos",
"description": "Esta regla prohíbe la creación de eventos dentro de la base de datos. Los eventos del sistema a menudo realizan tareas automatizadas que podrían afectar el entorno de la base de datos. Al prohibir su creación, ayuda a mantener el control sobre las operaciones de la base de datos y previene posibles interrupciones. Nivel de error sugerido: Advertencia"
},
- "system-view-disallow-create": {
- "title": "Prohibir la creación de vistas",
- "description": "Esta regla prohíbe la creación de vistas dentro de la base de datos. Las vistas proporcionan una representación virtual de los datos que puede simplificar las consultas y mejorar la seguridad de los datos. Al prohibir su creación, ayuda a mantener el control sobre el esquema de la base de datos y previene posibles riesgos de seguridad. Nivel de error sugerido: Advertencia"
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": {
+ "title": "Prohibir el uso de ciertas funciones",
+ "description": "Esta regla restringe el uso de funciones específicas dentro de la base de datos. Al prohibir el uso de estas funciones, ayuda a mantener la consistencia y seguridad de los datos. Nivel de error sugerido: Advertencia",
+ "component": {
+ "list": {
+ "title": "Prohibir lista"
+ }
+ }
},
- "system-function-disallow-create": {
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": {
"title": "Prohibición de crear funciones",
"description": "Esta regla prohíbe la creación de funciones dentro de la base de datos. Las funciones proporcionan lógica reutilizable que puede simplificar las consultas y mejorar la integridad de los datos. Al prohibir su creación, se ayuda a mantener el control sobre el esquema de la base de datos y se previenen posibles riesgos de seguridad. Nivel de error sugerido: Advertencia"
},
- "system-function-disallowed-list": {
- "title": "Prohibir el uso de ciertas funciones",
- "description": "Esta regla restringe el uso de funciones específicas dentro de la base de datos. Al prohibir el uso de estas funciones, ayuda a mantener la consistencia y seguridad de los datos. Nivel de error sugerido: Advertencia",
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": {
+ "title": "Prohibir la ejecución de procedimientos del sistema",
+ "description": "Los procedimientos del sistema pueden realizar operaciones de alto riesgo, como la eliminación de datos, la modificación de la estructura de la base de datos, etc. Nivel de error sugerido: Advertencia"
+ },
+ "SYSTEM_VIEW_DISALLOW_CREATE": {
+ "title": "Prohibir la creación de vistas",
+ "description": "Esta regla prohíbe la creación de vistas dentro de la base de datos. Las vistas proporcionan una representación virtual de los datos que puede simplificar las consultas y mejorar la seguridad de los datos. Al prohibir su creación, ayuda a mantener el control sobre el esquema de la base de datos y previene posibles riesgos de seguridad. Nivel de error sugerido: Advertencia"
+ },
+ "TABLE_COMMENT": {
+ "title": "Convención de comentarios de tabla",
+ "description": "Configure si la tabla requiere comentarios y la longitud máxima de comentarios.",
+ "component": {
+ "required": {
+ "title": "Requerir comentario"
+ },
+ "requiredClassification": {
+ "title": "Requerir clasificación",
+ "tooltip": "El comentario debe seguir el formato {'{'}identificación de clasificación{'}'}-{'{'}comentario{'}'}."
+ },
+ "maxLength": {
+ "title": "Longitud máxima"
+ }
+ }
+ },
+ "TABLE_DISALLOW_DDL": {
+ "title": "No permitir DDL",
+ "description": "Configure qué tablas tienen prohibido ejecutar DDL. Nivel de error de sugerencia: Advertencia",
"component": {
"list": {
- "title": "Prohibir lista"
+ "title": "Nombres de tablas"
}
}
},
- "advice-online-migration": {
- "title": "Migración en línea",
- "description": "Se recomienda habilitar la migración en línea si el recuento de filas de la tabla migrada supera su configuración. Nivel de error sugerido: Advertencia",
+ "TABLE_DISALLOW_DML": {
+ "title": "No permitir DML",
+ "description": "Configure qué tablas tienen prohibido ejecutar DML. Nivel de error de sugerencia: Advertencia",
+ "component": {
+ "list": {
+ "title": "Nombres de tablas"
+ }
+ }
+ },
+ "TABLE_DISALLOW_PARTITION": {
+ "title": "Prohibir el uso de tablas particionadas",
+ "description": "En algunos motores de base de datos, las tablas particionadas no están maduras y el uso y mantenimiento son incómodos. Por lo tanto, es más propenso a utilizar métodos manuales de partición de datos como la fragmentación de bases de datos y tablas. Nivel de sugerencia de error: Advertencia"
+ },
+ "TABLE_DISALLOW_SET_CHARSET": {
+ "title": "Prohibir la definición del juego de caracteres en las propiedades de la tabla",
+ "description": "Se recomienda establecer el juego de caracteres a nivel de la base de datos. Establecer el juego de caracteres con una granularidad más fina puede generar complejidades innecesarias. Nivel de error sugerido: Error."
+ },
+ "TABLE_DISALLOW_TRIGGER": {
+ "title": "Prohibir el uso de desencadenadores en tablas",
+ "description": "Los desencadenadores pueden hacer que el flujo de control sea difícil de seguir y aumentar la complejidad del sistema. En lugar de usar desencadenadores, se recomienda utilizar la lógica de la aplicación para realizar operaciones de base de datos. Nivel de sugerencia de error: Advertencia"
+ },
+ "TABLE_DROP_NAMING_CONVENTION": {
+ "title": "Restringir el formato de nomenclatura de las tablas a eliminar",
+ "description": "Por ejemplo, al requerir el sufijo \"_del\", se puede prevenir efectivamente las eliminaciones accidentales. Nivel de sugerencia de error: Error",
+ "component": {
+ "format": {
+ "title": "Formato de nombre de tabla (regex)"
+ }
+ }
+ },
+ "TABLE_LIMIT_SIZE": {
+ "title": "Limitar operaciones DDL en tablas con gran número de filas",
+ "description": "Configurar el número máximo de filas en tablas para las cuales se puede ejecutar DDL. Nivel de error recomendado: advertencia",
"component": {
"number": {
- "title": "Valor de umbral"
+ "title": "Recuento máximo de filas"
}
}
},
- "statement-add-foreign-key-not-valid": {
- "title": "Aplicar la opción \"NO VÁLIDO\" al agregar claves externas",
- "description": "Agregar claves externas necesita verificar los datos existentes y requiere el bloqueo de tabla SHARE ROW EXCLUSIVE. \nEsto bloquea la escritura, lo que puede provocar la interrupción del negocio. \nSe recomienda agregar la opción \"NO VÁLIDO\" para validar datos nuevos y validar los datos existentes una vez completado el cambio. \nNivel de error de sugerencia: Advertencia"
+ "TABLE_NO_DUPLICATE_INDEX": {
+ "title": "Prohibir índices duplicados en la tabla",
+ "description": "Esta regla requiere que una tabla no tenga índices duplicados. Los índices duplicados consumen espacio de almacenamiento adicional y pueden reducir el rendimiento de las consultas. Nivel de error sugerido: Advertencia."
},
- "statement-non-transactional": {
- "title": "Detectar y reportar declaraciones no transaccionales",
- "description": ""
+ "TABLE_NO_FOREIGN_KEY": {
+ "title": "Prohibir el uso de restricciones de clave externa",
+ "description": "Las ventajas y desventajas de las claves externas son altamente controvertidas. El uso de claves externas puede aumentar significativamente la dificultad de los cambios en la base de datos, la escalabilidad (como la fragmentación), etc. Y incluso puede evitar el uso de algunas herramientas. Por lo tanto, otra opción es implementar restricciones de claves externas en la capa de aplicación. Nivel de sugerencia de error: Advertencia"
},
- "builtin-prior-backup-check": {
- "title": "Comprobación previa de viabilidad de la copia de seguridad",
- "description": "Esta regla verifica si se puede crear una copia de seguridad antes de que se modifiquen los datos. Verifica la existencia de la base de datos de destino de la copia de seguridad y rechaza los escenarios no admitidos. Está incorporada y no se puede omitir."
+ "TABLE_REQUIRE_CHARSET": {
+ "title": "Requerir juego de caracteres",
+ "description": "Se debe especificar el conjunto de caracteres de la tabla. Nivel de error sugerido: Advertencia"
},
- "statement-object-owner-check": {
- "title": "Verificación del propietario del objeto",
- "description": "Esta regla verifica si el propietario del objeto para DDL es el mismo que el usuario actual."
+ "TABLE_REQUIRE_COLLATION": {
+ "title": "Requerir intercalación",
+ "description": "Se debe especificar la intercalación de la tabla. Nivel de error sugerido: Advertencia"
+ },
+ "TABLE_REQUIRE_PK": {
+ "title": "Imponer la inclusión de clave primaria en una tabla",
+ "description": "Varias herramientas de sincronización, comparación y recuperación de datos a menudo requieren que las tablas tengan una clave principal. Nivel de error sugerido: Error"
+ },
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": {
+ "title": "Limitar la longitud total de los campos de texto en una tabla",
+ "description": "Esta regla limita la cantidad de datos que una tabla puede almacenar, evitando un uso excesivo de almacenamiento.",
+ "component": {
+ "number": {
+ "title": "Longitud máxima"
+ }
+ }
}
},
"level": {
diff --git a/frontend/src/locales/sql-review/ja-JP.json b/frontend/src/locales/sql-review/ja-JP.json
index a25c59eb20..1591987bbb 100644
--- a/frontend/src/locales/sql-review/ja-JP.json
+++ b/frontend/src/locales/sql-review/ja-JP.json
@@ -33,55 +33,39 @@
"bb-sql-review-empty-desc": "空のテンプレートです。必要なルールを自分で追加する必要があります。"
},
"rule": {
- "engine-mysql-use-innodb": {
- "title": "InnoDBストレージエンジンの強制",
- "description": "InnoDBはMySQLのデフォルトのストレージエンジンであり、トランザクションのサポートを提供します。高並行性と低遅延のシナリオにおいても優れたパフォーマンスを提供し、オンラインデータのバックアップとリカバリをサポートします。OLTPビジネスにおいては優先される選択肢です。提案エラーレベル:エラー"
- },
- "table-require-pk": {
- "title": "テーブルに主キーの含まれることを強制する",
- "description": "さまざまなデータ同期、比較、ロールバック ツールでは、テーブルに主キーが必要になることがよくあります。提案エラー レベル: エラー"
- },
- "table-no-foreign-key": {
- "title": "外部キー制約の使用を禁止する",
- "description": "外部キーの利点と欠点は非常に議論が分かれています。外部キーの使用は、データベースの変更やスケーラビリティ(シャーディングなど)の難しさを大幅に増加させる可能性があります。また、一部のツールの使用を妨げることさえあります。そのため、別のオプションとして、アプリケーションレイヤーで外部キー制約を実装することがあります。提案エラーレベル:警告"
- },
- "table-drop-naming-convention": {
- "title": "削除するテーブルの命名形式を制限する",
- "description": "例えば、「_del」の接尾辞を要求することで、誤って削除することを効果的に防ぐことができます。提案エラーレベル:エラー",
+ "ADVICE_ONLINE_MIGRATION": {
+ "title": "オンライン移行",
+ "description": "移行されたテーブル行数が設定値を超えた場合、オンライン移行の有効化を推奨します。推奨されるエラーレベル: 警告",
"component": {
- "format": {
- "title": "テーブル名の形式(正規表現)"
+ "number": {
+ "title": "しきい値"
}
}
},
- "table-disallow-partition": {
- "title": "パーティションテーブルの使用を禁止する",
- "description": "一部のデータベースエンジンでは、パーティションテーブルは未熟であり、使用やメンテナンスが不便です。そのため、データベースやテーブルのシャーディングなどの手動のデータパーティショニング方法の使用がより好まれます。提案エラーレベル:警告"
- },
- "table-disallow-trigger": {
- "title": "テーブルにトリガの使用を禁止する",
- "description": "トリガはデータベースの複雑さを増加させ、データの整合性を保つための手段としては適切ではありません。代わりに、アプリケーションレイヤーでデータの整合性を保つことをお勧めします。提案エラーレベル:警告"
- },
- "table-no-duplicate-index": {
- "title": "重複インデックスの禁止",
- "description": "このルールは、テーブル上の重複インデックスの作成を禁止します。重複インデックスは、余分なストレージスペースを占有し、クエリのパフォーマンスを低下させる可能性があります。推奨エラーレベル: 警告"
+ "BUILTIN_PRIOR_BACKUP_CHECK": {
+ "title": "事前のバックアップ実行可能性チェック",
+ "description": "このルールは、データが変更される前にバックアップを作成できるかどうかを確認します。バックアップ ターゲット データベースの存在を確認し、サポートされていないシナリオを禁止します。これは組み込みであり、スキップできません。"
},
- "table-text-fields-total-length": {
- "title": "テキスト入力欄の文字数を制限する",
- "description": "このルールは、テーブルが保持できるデータ量を制限し、過剰なストレージ使用を防ぎます。",
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": {
+ "title": "自動インクリメントカラムの初期値を制限する",
+ "description": "管理要件に基づいて自動インクリメントカラムの初期値を制限します。推奨エラーレベル:警告",
"component": {
"number": {
- "title": "最大長さ"
+ "title": "初期値"
}
}
},
- "table-disallow-set-charset": {
- "title": "テーブルプロパティでの文字セットの定義を禁止する",
- "description": "データベースの文字セットは、データベースレベルで設定することを推奨します。より細かいレベルで文字セットを設定すると、不要な複雑さが生じる可能性があります。推奨されるエラーレベル: エラー。"
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": {
+ "title": "自動増分列に「INTEGER」データ型の使用を強制します",
+ "description": "MySQLの自動増分列は一般的にビジネスに依存しない主キーとして使用されます。整数型を使用することで、ストレージスペースを節約し、主キーのインデックス構造をよりコンパクトにし、クエリとDMLのパフォーマンスを向上させることができます。推奨エラーレベル:エラー"
},
- "table-comment": {
- "title": "コメントの規約",
- "description": "テーブルにコメントが必要かどうか、および最大コメント長を設定します。",
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": {
+ "title": "自動増分列に「UNSIGNED」データ型の使用を強制します",
+ "description": "符号なしの型は負の数を格納せず、同じ型で格納できる値の範囲が倍増するため、自動増分列のオーバーフローを回避することができます。推奨エラーレベル:警告"
+ },
+ "COLUMN_COMMENT": {
+ "title": "列コメントの規則",
+ "description": "カラムにコメントを追加することは良い開発の慣行ですが、極端に長いコメントはスキーマの可読性を低下させる可能性があります。推奨エラーレベル:警告",
"component": {
"required": {
"title": "コメントの必須化"
@@ -95,58 +79,159 @@
}
}
},
- "table-disallow-ddl": {
- "title": "DDL を禁止する",
- "description": "DDL の実行を禁止するテーブルを設定します。提案エラー レベル: 警告",
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": {
+ "title": "システム時刻を取得する必要のあるテーブルのカラム数を制限する",
+ "description": "レコードの作成時に\"DEFAULT NOW()\"で作成時刻を記録し、レコードの更新時に\"DEFAULT NOW() ON UPDATE\"で更新時刻を記録するカラムのみ、システム時刻を取得するための関数を呼び出す必要があります。他のカラムにシステム時刻を記録することは意味がなく、リソースのオーバーヘッドを増やすだけです。推奨エラーレベル:エラー"
+ },
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": {
+ "title": "列に対して揮発性のあるデフォルト値の設定を禁止します",
+ "description": "ボラタイル関数(例: clock_timestamp())は、ALTER TABLE ADD COLUMN 実行時の値で各行を更新し、更新が長引く可能性があります。"
+ },
+ "COLUMN_DISALLOW_CHANGE": {
+ "title": "\"CHANGE COLUMN\" ステートメントの使用を禁止する",
+ "description": "\"CHANGE COLUMN\" は MySQL の構文に固有のものであり、列名やその他のプロパティを同時に変更するために使用できます。ただし、プロパティを変更する際に列名が誤って変更される可能性があります。2つの変更の種類を区別するために、引き続き標準の \"RENAME\" および \"MODIFY\" ステートメントを使用することを推奨します。推奨エラーレベル:エラー"
+ },
+ "COLUMN_DISALLOW_CHANGE_TYPE": {
+ "title": "列の型の変更を禁止する",
+ "description": "列の型を変更すると、システムのパフォーマンス、保守性、さらにはデータの損失に影響を与える可能性があります。推奨エラーレベル:警告"
+ },
+ "COLUMN_DISALLOW_CHANGING_ORDER": {
+ "title": "テーブル内の列の順序の変更を禁止する",
+ "description": "列の順序を変更すると、元のテーブルのデフォルトの順序に依存する一部のアプリケーションやビューが予期しない結果(\"select *\" など)を生成する可能性があります。推奨エラーレベル:警告"
+ },
+ "COLUMN_DISALLOW_DROP": {
+ "title": "列の削除を禁止",
+ "description": "列を削除することは禁止されています。推奨されるエラーレベル:警告。"
+ },
+ "COLUMN_DISALLOW_DROP_IN_INDEX": {
+ "title": "インデックス内の列の削除を禁止する",
+ "description": "インデックス内の列の削除を禁止します。推奨エラーレベル:エラー"
+ },
+ "COLUMN_DISALLOW_SET_CHARSET": {
+ "title": "列のプロパティで文字セットの定義を禁止する",
+ "description": "データベースレベルまたはテーブルレベルで文字セットを設定することをおすすめします。細かい粒度で文字セットを設定すると、不必要な複雑さが生じる場合があります。推奨エラーレベル:エラー。"
+ },
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": {
+ "title": "\"CHAR\"データ型の長さを制限する",
+ "description": "\"CHAR\"は固定長のタイプです。例えば、CHAR(20)のカラムは1文字しか格納されていなくても20文字分のスペースを占有し、無駄になります。文字列が長すぎて長さが固定されていない場合は、MySQLではVARCHARを使用し、PostgreSQLではTEXTを使用することを検討してください。推奨エラーレベル:エラー",
"component": {
- "list": {
- "title": "テーブル名"
+ "number": {
+ "title": "最大長"
}
}
},
- "table-limit-size": {
- "title": "行数の多いテーブルに対するDDL操作を制限する",
- "description": "DDLが実行可能なテーブルの最大行数を設定します。推奨エラーレベル:警告",
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": {
+ "title": "\"VARCHAR\"データ型の長さを制限する",
+ "description": "",
"component": {
"number": {
- "title": "最大行数"
+ "title": "最大長"
}
}
},
- "table-disallow-dml": {
- "title": "DML を禁止する",
- "description": "DML の実行を禁止するテーブルを設定します。提案エラー レベル: 警告",
+ "COLUMN_NO_NULL": {
+ "title": "列に「NOT NULL」制約を強制する",
+ "description": "列にNULL値を持つことはできません。"
+ },
+ "COLUMN_REQUIRED": {
+ "title": "テーブルに特定の列を含めることを強制する",
+ "description": "いくつかの共通の列は、アプリケーションのメンテナンスを向上させるために役立ちます。例えば、ビジネスに依存しない「ID」列を主キーとして追加することで、ビジネスの変更(ビジネスの統合など)による主キーの競合を回避することができ、一部のシナリオではデータの挿入パフォーマンスも向上させることができます。推奨エラーレベル:警告",
"component": {
"list": {
- "title": "テーブル名"
+ "title": "必須の列名"
}
}
},
- "table-require-charset": {
- "title": "文字セットを要求する",
- "description": "テーブルの文字セットを指定する必要があります。提案エラーレベル: 警告"
+ "COLUMN_REQUIRE_CHARSET": {
+ "title": "テキスト列に文字セットを要求する",
+ "description": "テキスト データ型の列の文字セットを指定する必要があります。提案エラー レベル: 警告"
},
- "table-require-collation": {
- "title": "照合を要求する",
- "description": "テーブルの照合順序を指定する必要があります。提案エラー レベル: 警告"
+ "COLUMN_REQUIRE_COLLATION": {
+ "title": "テキスト列の照合を要求する",
+ "description": "テキスト データ型の列の照合を指定する必要があります。提案エラー レベル: 警告"
},
- "naming-fully-qualified": {
- "title": "完全修飾オブジェクト名",
- "description": "完全修飾オブジェクト名の使用を強制します。 例えば、「schema.table」、推奨エラーレベル:警告"
+ "COLUMN_REQUIRE_DEFAULT": {
+ "title": "カラムにデフォルト値の設定を強制する",
+ "description": "ビジネスロジックを満たすデフォルト値の設定は、ダウンストリームの分析パイプラインのデータ品質を効果的に向上させることができます。このルールは「PRIMARY KEY」、「JSON」、「BLOB」、「TEXT」、「GEOMETRY」、「AUTO_INCREMENT」、「GENERATED」のタイプをチェックしません。提案エラーレベル:警告"
},
- "naming-table": {
- "title": "テーブルの命名形式の強制",
- "description": "デフォルトの形式はすべて小文字で、単語間にアンダースコアで区切られ、最大63文字までです。例えば「abc」や「abc_def」です。提案エラーレベル:警告",
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": {
+ "title": "「NOT NULL」列にデフォルト値を強制します",
+ "description": "「NOT NULL」列に新しい行を挿入する際に列に値が割り当てられていない場合、かつ列にデフォルト値がない場合、データベースはその行の挿入を拒否します。新しい列にデフォルト値を設定することで、レガシーアプリケーションとの互換性も確保できます。推奨エラーレベル:エラー"
+ },
+ "COLUMN_TYPE_DISALLOW_LIST": {
+ "title": "特定の列データ型の使用を禁止する",
+ "description": "列のデータ型の乱用は、システムの保守性とパフォーマンスに深刻な悪影響を与える可能性があります。例えば、「LOB」列を使用して大量の音声やビデオデータを保存すると、データベースのパフォーマンスが低下し、バックアップと復旧時間が長くなり、データ同期ツールとの互換性が失われる可能性があります。推奨エラーレベル:エラー",
"component": {
- "format": {
- "title": "テーブル名の形式(正規表現)"
- },
- "maxLength": {
- "title": "長さ制限"
+ "list": {
+ "title": "禁止リスト"
+ }
+ }
+ },
+ "DATABASE_DROP_EMPTY_DATABASE": {
+ "title": "空でないデータベースの削除を禁止する",
+ "description": "データベース内にテーブルが存在しない場合のみ削除が許可されます。これにより、誤って削除することを大幅に防ぐことができます。提案されるエラーレベル:エラー"
+ },
+ "ENGINE_MYSQL_USE_INNODB": {
+ "title": "InnoDBストレージエンジンの強制",
+ "description": "InnoDBはMySQLのデフォルトのストレージエンジンであり、トランザクションのサポートを提供します。高並行性と低遅延のシナリオにおいても優れたパフォーマンスを提供し、オンラインデータのバックアップとリカバリをサポートします。OLTPビジネスにおいては優先される選択肢です。提案エラーレベル:エラー"
+ },
+ "INDEX_CREATE_CONCURRENTLY": {
+ "title": "同時インデックス作成の強制",
+ "description": "PostgreSQL 11以降では、標準のステートメントを使用してインデックスを作成すると、テーブルのロックが発生し、書き込みができなくなります。\"CONCURRENTLY\"モードを使用すると、この問題を回避できます。提案エラーレベル:警告"
+ },
+ "INDEX_KEY_NUMBER_LIMIT": {
+ "title": "単一のインデックス内の列の数を制限する",
+ "description": "5つ以上の列を持つ複合インデックスは、クエリのパフォーマンスを大幅に向上させるわけではありませんが、多くのスペースを占有し、DMLのパフォーマンスを低下させます。提案エラーレベル:警告",
+ "component": {
+ "number": {
+ "title": "最大列数"
+ }
+ }
+ },
+ "INDEX_NOT_REDUNDANT": {
+ "title": "冗長なインデックスを禁止する",
+ "description": "冗長なインデックスはパフォーマンスの損失と追加のスペースの占有を引き起こす可能性があります。例えば、列(c1)にすでにインデックスが存在する場合、列(c1、c2)上のインデックスは冗長なインデックスとして扱われます。提案されるエラーレベル:警告"
+ },
+ "INDEX_NO_DUPLICATE_COLUMN": {
+ "title": "重複する列を含むインデックスの作成を禁止する",
+ "description": "重複する列を持つインデックスの作成は失敗します。提案されるエラーレベル:エラー"
+ },
+ "INDEX_PK_TYPE_LIMIT": {
+ "title": "プライマリキーのタイプ制限",
+ "description": "プライマリキーのタイプをINTまたはBIGINTに制限します。"
+ },
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": {
+ "title": "許可される主キーのタイプのリスト",
+ "description": "適切な主キーのタイプは、ストレージ構造を最適化し、スペース使用量を減らし、挿入およびクエリのパフォーマンスを向上させることができます。提案エラーレベル:警告",
+ "component": {
+ "list": {
+ "title": "許可リスト"
+ }
+ }
+ },
+ "INDEX_TOTAL_NUMBER_LIMIT": {
+ "title": "単一のテーブルにおけるインデックスの数を制限します",
+ "description": "インデックスはクエリのパフォーマンスを向上させることができますが、多くのスペースを占有し、DMLのパフォーマンスを低下させることもあります。したがって、テーブルに5つ以上のインデックスを作成することは推奨されません。提案エラーレベル:警告",
+ "component": {
+ "number": {
+ "title": "最大インデックス数"
+ }
+ }
+ },
+ "INDEX_TYPE_ALLOW_LIST": {
+ "title": "許可されたインデックスタイプのリスト",
+ "description": "異なるインデックスタイプには異なるパフォーマンス特性があります。例えば、B-tree インデックスは範囲クエリに適していますが、ハッシュインデックスは等価クエリに適しています。提案エラーレベル: 警告",
+ "component": {
+ "list": {
+ "title": "許可リスト"
}
}
},
- "naming-column": {
+ "INDEX_TYPE_NO_BLOB": {
+ "title": "\"BLOB\"および\"TEXT\"データ型の列にインデックスの作成を禁止する",
+ "description": "\"BLOB\"タイプは通常、バイナリデータを格納するために使用され、クエリ条件として使用するべきではありません。誤ってこの列タイプにインデックスを作成すると、多くのリソースを消費し、重大なパフォーマンスの影響を引き起こす可能性があります。提案されるエラーレベル:エラー"
+ },
+ "NAMING_COLUMN": {
"title": "列名の形式を強制する",
"description": "デフォルトの形式はすべて小文字で、単語間にアンダースコアで区切られ、最大63文字までです。例えば「abc」や「abc_def」です。提案エラーレベル:警告",
"component": {
@@ -158,39 +243,36 @@
}
}
},
- "naming-index-uk": {
- "title": "一意キーの命名形式を強制する",
- "description": "名前は空白であることが許可され、データベースによって命名されます。空でない場合、デフォルトの形式は「uk_<テーブル名>_<一意キーカラム名の組み合わせ>」で、最大63文字までです。例えば「uk_my_table_id_name」です。提案エラーレベル:警告",
+ "NAMING_COLUMN_AUTO_INCREMENT": {
+ "title": "オートインクリメント列の命名形式を強制する",
+ "description": "デフォルトの列名は「ID」で、63文字を超えないようにします。",
"component": {
"format": {
- "title": "一意キーの名前の形式",
- "template": {
- "table": "テーブル名",
- "column_list": "インデックス列名は_で結合されます"
- }
+ "title": "オートインクリメント列の名前の形式(正規表現)"
},
"maxLength": {
"title": "長さ制限"
}
}
},
- "naming-index-pk": {
- "title": "主キーの命名形式を強制する",
- "description": "名前は空白であることが許可され、データベースによって命名されます。空でない場合、デフォルトの形式は「pk_<テーブル名>_<一意キーカラム名の組み合わせ>」で、最大63文字までです。例えば「pk_my_table_id_name」です。提案エラーレベル:警告",
+ "NAMING_FULLY_QUALIFIED": {
+ "title": "完全修飾オブジェクト名",
+ "description": "完全修飾オブジェクト名の使用を強制します。 例えば、「schema.table」、推奨エラーレベル:警告"
+ },
+ "NAMING_IDENTIFIER_CASE": {
+ "title": "識別子の大文字小文字を強制する",
+ "description": "",
"component": {
- "format": {
- "title": "プライマリキーの名前の形式",
- "template": {
- "table": "テーブル名",
- "column_list": "_で結合されたインデックス列の名前"
- }
- },
- "maxLength": {
- "title": "長さ制限"
+ "upper": {
+ "title": "大文字にする"
}
}
},
- "naming-index-fk": {
+ "NAMING_IDENTIFIER_NO_KEYWORD": {
+ "title": "識別子としてキーワードの使用を禁止する",
+ "description": ""
+ },
+ "NAMING_INDEX_FK": {
"title": "外部キーの命名形式を強制する",
"description": "名前は空であることもあり、データベースによって命名されることもあります。空でない場合、デフォルトの形式は「fk_<テーブル名>_<一意のキーカラム名の組み合わせ>」で、63文字を超えないようにします。例えば「fk_my_table_id_name」です。提案エラーレベル:警告",
"component": {
@@ -208,7 +290,7 @@
}
}
},
- "naming-index-idx": {
+ "NAMING_INDEX_IDX": {
"title": "インデックスの命名形式を強制する",
"description": "名前は空であることもあり、データベースによって命名されることもあります。空でない場合、デフォルトの形式は「idx_<テーブル名>_<一意のキーカラム名の組み合わせ>」で、63文字を超えないようにします。例えば「idx_my_table_id_name」です。提案エラーレベル:警告",
"component": {
@@ -224,214 +306,71 @@
}
}
},
- "naming-column-auto-increment": {
- "title": "オートインクリメント列の命名形式を強制する",
- "description": "デフォルトの列名は「ID」で、63文字を超えないようにします。",
+ "NAMING_INDEX_PK": {
+ "title": "主キーの命名形式を強制する",
+ "description": "名前は空白であることが許可され、データベースによって命名されます。空でない場合、デフォルトの形式は「pk_<テーブル名>_<一意キーカラム名の組み合わせ>」で、最大63文字までです。例えば「pk_my_table_id_name」です。提案エラーレベル:警告",
"component": {
"format": {
- "title": "オートインクリメント列の名前の形式(正規表現)"
+ "title": "プライマリキーの名前の形式",
+ "template": {
+ "table": "テーブル名",
+ "column_list": "_で結合されたインデックス列の名前"
+ }
},
"maxLength": {
"title": "長さ制限"
}
}
},
- "naming-table-no-keyword": {
- "title": "テーブル名としてキーワードの使用を禁止する",
- "description": ""
- },
- "naming-identifier-no-keyword": {
- "title": "識別子としてキーワードの使用を禁止する",
- "description": ""
- },
- "naming-identifier-case": {
- "title": "識別子の大文字小文字を強制する",
- "description": "",
- "component": {
- "upper": {
- "title": "大文字にする"
- }
- }
- },
- "column-required": {
- "title": "テーブルに特定の列を含めることを強制する",
- "description": "いくつかの共通の列は、アプリケーションのメンテナンスを向上させるために役立ちます。例えば、ビジネスに依存しない「ID」列を主キーとして追加することで、ビジネスの変更(ビジネスの統合など)による主キーの競合を回避することができ、一部のシナリオではデータの挿入パフォーマンスも向上させることができます。推奨エラーレベル:警告",
- "component": {
- "list": {
- "title": "必須の列名"
- }
- }
- },
- "column-type-disallow-list": {
- "title": "特定の列データ型の使用を禁止する",
- "description": "列のデータ型の乱用は、システムの保守性とパフォーマンスに深刻な悪影響を与える可能性があります。例えば、「LOB」列を使用して大量の音声やビデオデータを保存すると、データベースのパフォーマンスが低下し、バックアップと復旧時間が長くなり、データ同期ツールとの互換性が失われる可能性があります。推奨エラーレベル:エラー",
- "component": {
- "list": {
- "title": "禁止リスト"
- }
- }
- },
- "column-no-null": {
- "title": "列に「NOT NULL」制約を強制する",
- "description": "列にNULL値を持つことはできません。"
- },
- "column-disallow-set-charset": {
- "title": "列のプロパティで文字セットの定義を禁止する",
- "description": "データベースレベルまたはテーブルレベルで文字セットを設定することをおすすめします。細かい粒度で文字セットを設定すると、不必要な複雑さが生じる場合があります。推奨エラーレベル:エラー。"
- },
- "column-disallow-change-type": {
- "title": "列の型の変更を禁止する",
- "description": "列の型を変更すると、システムのパフォーマンス、保守性、さらにはデータの損失に影響を与える可能性があります。推奨エラーレベル:警告"
- },
- "column-disallow-change": {
- "title": "\"CHANGE COLUMN\" ステートメントの使用を禁止する",
- "description": "\"CHANGE COLUMN\" は MySQL の構文に固有のものであり、列名やその他のプロパティを同時に変更するために使用できます。ただし、プロパティを変更する際に列名が誤って変更される可能性があります。2つの変更の種類を区別するために、引き続き標準の \"RENAME\" および \"MODIFY\" ステートメントを使用することを推奨します。推奨エラーレベル:エラー"
- },
- "column-disallow-changing-order": {
- "title": "テーブル内の列の順序の変更を禁止する",
- "description": "列の順序を変更すると、元のテーブルのデフォルトの順序に依存する一部のアプリケーションやビューが予期しない結果(\"select *\" など)を生成する可能性があります。推奨エラーレベル:警告"
- },
- "column-disallow-drop": {
- "title": "列の削除を禁止",
- "description": "列を削除することは禁止されています。推奨されるエラーレベル:警告。"
- },
- "column-disallow-drop-in-index": {
- "title": "インデックス内の列の削除を禁止する",
- "description": "インデックス内の列の削除を禁止します。推奨エラーレベル:エラー"
- },
- "column-set-default-for-not-null": {
- "title": "「NOT NULL」列にデフォルト値を強制します",
- "description": "「NOT NULL」列に新しい行を挿入する際に列に値が割り当てられていない場合、かつ列にデフォルト値がない場合、データベースはその行の挿入を拒否します。新しい列にデフォルト値を設定することで、レガシーアプリケーションとの互換性も確保できます。推奨エラーレベル:エラー"
- },
- "column-auto-increment-must-integer": {
- "title": "自動増分列に「INTEGER」データ型の使用を強制します",
- "description": "MySQLの自動増分列は一般的にビジネスに依存しない主キーとして使用されます。整数型を使用することで、ストレージスペースを節約し、主キーのインデックス構造をよりコンパクトにし、クエリとDMLのパフォーマンスを向上させることができます。推奨エラーレベル:エラー"
- },
- "column-auto-increment-must-unsigned": {
- "title": "自動増分列に「UNSIGNED」データ型の使用を強制します",
- "description": "符号なしの型は負の数を格納せず、同じ型で格納できる値の範囲が倍増するため、自動増分列のオーバーフローを回避することができます。推奨エラーレベル:警告"
- },
- "column-comment": {
- "title": "列コメントの規則",
- "description": "カラムにコメントを追加することは良い開発の慣行ですが、極端に長いコメントはスキーマの可読性を低下させる可能性があります。推奨エラーレベル:警告",
+ "NAMING_INDEX_UK": {
+ "title": "一意キーの命名形式を強制する",
+ "description": "名前は空白であることが許可され、データベースによって命名されます。空でない場合、デフォルトの形式は「uk_<テーブル名>_<一意キーカラム名の組み合わせ>」で、最大63文字までです。例えば「uk_my_table_id_name」です。提案エラーレベル:警告",
"component": {
- "required": {
- "title": "コメントの必須化"
- },
- "requiredClassification": {
- "title": "分類が必要",
- "tooltip": "コメントは、{'{'}分類 ID{'}'}-{'{'}コメント{'}'} の形式に従う必要があります。"
+ "format": {
+ "title": "一意キーの名前の形式",
+ "template": {
+ "table": "テーブル名",
+ "column_list": "インデックス列名は_で結合されます"
+ }
},
"maxLength": {
- "title": "最大長"
- }
- }
- },
- "column-maximum-character-length": {
- "title": "\"CHAR\"データ型の長さを制限する",
- "description": "\"CHAR\"は固定長のタイプです。例えば、CHAR(20)のカラムは1文字しか格納されていなくても20文字分のスペースを占有し、無駄になります。文字列が長すぎて長さが固定されていない場合は、MySQLではVARCHARを使用し、PostgreSQLではTEXTを使用することを検討してください。推奨エラーレベル:エラー",
- "component": {
- "number": {
- "title": "最大長"
- }
- }
- },
- "column-maximum-varchar-length": {
- "title": "\"VARCHAR\"データ型の長さを制限する",
- "description": "",
- "component": {
- "number": {
- "title": "最大長"
+ "title": "長さ制限"
}
}
},
- "column-auto-increment-initial-value": {
- "title": "自動インクリメントカラムの初期値を制限する",
- "description": "管理要件に基づいて自動インクリメントカラムの初期値を制限します。推奨エラーレベル:警告",
+ "NAMING_TABLE": {
+ "title": "テーブルの命名形式の強制",
+ "description": "デフォルトの形式はすべて小文字で、単語間にアンダースコアで区切られ、最大63文字までです。例えば「abc」や「abc_def」です。提案エラーレベル:警告",
"component": {
- "number": {
- "title": "初期値"
+ "format": {
+ "title": "テーブル名の形式(正規表現)"
+ },
+ "maxLength": {
+ "title": "長さ制限"
}
}
},
- "column-current-time-count-limit": {
- "title": "システム時刻を取得する必要のあるテーブルのカラム数を制限する",
- "description": "レコードの作成時に\"DEFAULT NOW()\"で作成時刻を記録し、レコードの更新時に\"DEFAULT NOW() ON UPDATE\"で更新時刻を記録するカラムのみ、システム時刻を取得するための関数を呼び出す必要があります。他のカラムにシステム時刻を記録することは意味がなく、リソースのオーバーヘッドを増やすだけです。推奨エラーレベル:エラー"
- },
- "column-require-default": {
- "title": "カラムにデフォルト値の設定を強制する",
- "description": "ビジネスロジックを満たすデフォルト値の設定は、ダウンストリームの分析パイプラインのデータ品質を効果的に向上させることができます。このルールは「PRIMARY KEY」、「JSON」、「BLOB」、「TEXT」、「GEOMETRY」、「AUTO_INCREMENT」、「GENERATED」のタイプをチェックしません。提案エラーレベル:警告"
- },
- "column-default-disallow-volatile": {
- "title": "列に対して揮発性のあるデフォルト値の設定を禁止します",
- "description": "ボラタイル関数(例: clock_timestamp())は、ALTER TABLE ADD COLUMN 実行時の値で各行を更新し、更新が長引く可能性があります。"
- },
- "column-require-charset": {
- "title": "テキスト列に文字セットを要求する",
- "description": "テキスト データ型の列の文字セットを指定する必要があります。提案エラー レベル: 警告"
- },
- "column-require-collation": {
- "title": "テキスト列の照合を要求する",
- "description": "テキスト データ型の列の照合を指定する必要があります。提案エラー レベル: 警告"
- },
- "statement-select-no-select-all": {
- "title": "「SELECT *」の使用を禁止する",
- "description": "「SELECT *」を使用して全行データを取得すると、不必要なリソースのオーバーヘッドが発生し、テーブルに列を追加または削除した場合にアプリケーションで予期しない結果が発生する可能性があります。提案エラーレベル:エラー"
- },
- "statement-where-require-select": {
- "title": "SELECT文に「WHERE」条件を強制する",
- "description": "WHERE 句のないクエリは、膨大なリソースのオーバーヘッドを引き起こす可能性があります。提案エラー レベル: エラー"
- },
- "statement-where-require-update-delete": {
- "title": "ステートメント内の「WHERE」条件の存在を強制する",
- "description": "WHERE 句のない DML は、大量の偶発的なデータ損失を引き起こす可能性があります。提案エラー レベル: エラー"
- },
- "statement-where-no-leading-wildcard-like": {
- "title": "フィルタ条件で先行ワイルドカードの使用を禁止する",
- "description": "「LIKE '%ABC'」のような先行ワイルドカードを使用すると、データベースの最適化プランナーは高速なインデックススキャンを使用できず、フルテーブルスキャンまたはフルインデックススキャンにフォールバックする可能性があります。これにより、重大なパフォーマンスの影響が発生する可能性があります。提案エラーレベル:エラー"
- },
- "statement-disallow-on-del-cascade": {
- "title": "ON DELETE節での CASCADE オプションの使用を禁止する",
- "description": "'ON DELETEの\"CASCADE\"オプションは、多数の依存オブジェクトが削除または変更される原因となり、予期しない結果をもたらす可能性があります。提案されるエラーレベル:エラー"
- },
- "statement-disallow-rm-tbl-cascade": {
- "title": "テーブルの削除時に\"CASCADE\"を使用することを禁止する",
- "description": "テーブルを削除する際の\"CASCADE\"オプションの使用は、多数の依存オブジェクトが削除または変更される原因となり、予期しない結果をもたらす可能性があります。提案されるエラーレベル:エラー"
- },
- "statement-disallow-commit": {
- "title": "明示的な\"COMMIT\"ステートメントの禁止",
- "description": "システムによってコミットされるトランザクションには複数のステートメントが含まれる場合があり、部分的な障害の場合にはすばやく再実行するために必要です。そのため、明示的な\"COMMIT\"は許可されていません。提案エラーレベル:警告"
- },
- "statement-disallow-limit": {
- "title": "DMLステートメントでの\"LIMIT\"句の使用の禁止",
- "description": "ORDER BY句がない場合にDMLステートメントでLIMITを使用すると、影響を受ける行の順序が固定されないため、一部のレプリケーションモードではプライマリとレプリカのデータの整合性の問題が発生する可能性があります。提案エラーレベル:エラー"
- },
- "statement-disallow-order-by": {
- "title": "\"UPDATE\"および\"DELETE\"ステートメントでの\"ORDER BY\"句の使用の禁止",
- "description": "ソート操作は非常にリソースを消費するため、更新および削除操作では、ORDER BYおよびLIMITの代わりに可能な限り決定論的なフィルタリング条件を使用することをお勧めします。提案エラーレベル:エラー"
+ "NAMING_TABLE_NO_KEYWORD": {
+ "title": "テーブル名としてキーワードの使用を禁止する",
+ "description": ""
},
- "statement-merge-alter-table": {
- "title": "同じテーブルに対して複数の独立した変更の発行の禁止",
- "description": "テーブルへの変更ごとにテーブルレベルのロックが発生し、大量のリソースを消費する可能性があります。同じテーブルに複数の変更がある場合は、それらを1つの変更ステートメントに統合する必要があります。提案エラーレベル:エラー"
+ "SCHEMA_BACKWARD_COMPATIBILITY": {
+ "title": "アプリケーションの後方互換性を確認する",
+ "description": "一部の変更は実行中のアプリケーションに影響を与える可能性があります。データベースオブジェクトの名前の変更や新しい制約の追加などが該当します。このルールにより、既存のアプリケーションの障害を防ぐことができます。提案されるエラーレベル:警告"
},
- "statement-insert-must-specify-column": {
- "title": "\"INSERT\" ステートメントで列名の指定を強制する",
- "description": "\"INSERT INTO table VALUES (...)\" ステートメントは列名を明示的にリストしません。列の順序が変更されたり、列が追加または削除された場合、ステートメントは失敗するか予期しないデータを生成する可能性があります。提案エラーレベル:エラー"
+ "STATEMENT_ADD_CHECK_NOT_VALID": {
+ "title": "\"CHECK\"制約を追加する際に\"NOT VALID\"オプションを強制する",
+ "description": "CHECK 制約を追加するには、既存のデータを検証する必要があり、ACCESS EXCLUSIVE テーブル ロックが必要です。 これにより読み取りと書き込みがブロックされ、ビジネスの中断が発生する可能性があります。新しいデータを検証するために\"NOT VALID\"オプションを追加し、変更が完了した後に既存のデータを手動で検証することをおすすめします。提案エラーレベル:警告"
},
- "statement-insert-disallow-order-by-rand": {
- "title": "\"INSERT\" ステートメントで \"ORDER BY rand()\" の使用を禁止する",
- "description": "挿入するデータをランダムに並べ替えることは意味がなく、不必要なリソースを消費するだけです。提案エラーレベル:エラー"
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": {
+ "title": "指定位置への列の追加を禁止",
+ "description": "場合によっては、FIRST/AFTER を使用して指定位置に列を追加すると、データの再編成(元のデータを再び書き直す)が発生する可能性があります。推奨エラーレベル:警告。"
},
- "statement-insert-row-limit": {
- "title": "挿入される行数の最大制限",
- "description": "挿入される行数を明示することで、ステートメントがビジネスの期待に沿っているかどうかを判断するのに役立ちます。提案エラーレベル:警告",
- "component": {
- "number": {
- "title": "最大挿入量"
- }
- }
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": {
+ "title": "外部キーを追加するときに「NOT VALID」オプションを含めることを強制する",
+ "description": "外部キーを追加するには、既存のデータを検証する必要があり、SHARE ROW EXCLUSIVE テーブル ロックが必要です。\nこれにより書き込みがブロックされ、業務が中断される可能性があります。\n新しいデータを検証し、変更の完了後に既存のデータを検証するには、「NOT VALID」オプションを追加することをお勧めします。\n提案エラーレベル: 警告"
},
- "statement-affected-row-limit": {
+ "STATEMENT_AFFECTED_ROW_LIMIT": {
"title": "更新または削除される行数の最大制限 (推定)",
"description": "更新または削除される行数を明示することで、ステートメントがビジネスの期待に沿っているかどうかを判断するのに役立ちます。提案エラーレベル:警告",
"component": {
@@ -440,87 +379,102 @@
}
}
},
- "statement-dml-dry-run": {
- "title": "DML ステートメントの実行可能性を検証する",
- "description": "構文は正しいが、テーブル名が間違っているか、権限が不足している場合、実際の実行前にドライランで発見できます。提案エラーレベル:警告"
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": {
+ "title": "開始時にロールステートメントが設定されているかを確認する",
+ "description": "セッションの初めにロールステートメントを適切に設定しないと、不正なアクセスや不適切な権限の割り当てが発生し、データのセキュリティと完全性が危険にさらされる可能性があります。エラーレベル:警告"
+ },
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": {
+ "title": "スキーマを指定せずにオブジェクトを作成することを禁止する",
+ "description": "スキーマが指定されていない場合、オブジェクトはデフォルトのスキーマに作成され、予期しない結果を引き起こす可能性があります。"
},
- "statement-disallow-add-column-with-default": {
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": {
"title": "テーブルにデフォルト値を持つ列を追加することを制限する",
"description": "PostgreSQL 11以前では、デフォルト値を持つ列を追加するとテーブルがロックされて読み書きができなくなり、業務の中断を引き起こす可能性があります。PostgreSQL 11以降では、この問題が最適化されており、このルールに注意する必要はありません。提案エラーレベル:警告"
},
- "statement-add-check-not-valid": {
- "title": "\"CHECK\"制約を追加する際に\"NOT VALID\"オプションを強制する",
- "description": "CHECK 制約を追加するには、既存のデータを検証する必要があり、ACCESS EXCLUSIVE テーブル ロックが必要です。 これにより読み取りと書き込みがブロックされ、ビジネスの中断が発生する可能性があります。新しいデータを検証するために\"NOT VALID\"オプションを追加し、変更が完了した後に既存のデータを手動で検証することをおすすめします。提案エラーレベル:警告"
- },
- "statement-disallow-add-not-null": {
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": {
"title": "既存の列に\"NOT NULL\"制約を追加することを制限する",
"description": "PostgreSQL 11 より前にデフォルト値のある NOT NULL 制約を追加する場合、またはデフォルト値なしの NOT NULL 制約を追加する場合は、既存のデータを検証する必要があります。 これにより読み取りと書き込みがブロックされ、ビジネスの中断が発生する可能性があります。提案エラーレベル:警告"
},
- "statement-select-full-table-scan": {
- "title": "クエリのフルテーブルスキャンをチェックする",
- "description": "フルテーブルスキャンはリソースを消費する操作であり、重大なパフォーマンスの影響を引き起こす可能性があります。提案エラーレベル:エラー"
+ "STATEMENT_DISALLOW_COMMIT": {
+ "title": "明示的な\"COMMIT\"ステートメントの禁止",
+ "description": "システムによってコミットされるトランザクションには複数のステートメントが含まれる場合があり、部分的な障害の場合にはすばやく再実行するために必要です。そのため、明示的な\"COMMIT\"は許可されていません。提案エラーレベル:警告"
},
- "statement-create-specify-schema": {
- "title": "スキーマを指定せずにオブジェクトを作成することを禁止する",
- "description": "スキーマが指定されていない場合、オブジェクトはデフォルトのスキーマに作成され、予期しない結果を引き起こす可能性があります。"
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": {
+ "title": "データベース間のクエリを禁止する",
+ "description": "データベース間のクエリはシステムの結合度を高め、効率性に問題を引き起こす可能性があります。推奨されるエラーレベル:警告"
},
- "statement-check-set-role-variable": {
- "title": "開始時にロールステートメントが設定されているかを確認する",
- "description": "セッションの初めにロールステートメントを適切に設定しないと、不正なアクセスや不適切な権限の割り当てが発生し、データのセキュリティと完全性が危険にさらされる可能性があります。エラーレベル:警告"
+ "STATEMENT_DISALLOW_LIMIT": {
+ "title": "DMLステートメントでの\"LIMIT\"句の使用の禁止",
+ "description": "ORDER BY句がない場合にDMLステートメントでLIMITを使用すると、影響を受ける行の順序が固定されないため、一部のレプリケーションモードではプライマリとレプリカのデータの整合性の問題が発生する可能性があります。提案エラーレベル:エラー"
},
- "statement-disallow-using-temporary": {
- "title": "一時テーブルの使用を禁止する",
- "description": "一時テーブルは、データの永続化が不要な場合にのみ使用することをお勧めします。一時テーブルはディスクに書き込まれるため、パフォーマンスが低下する可能性があります。提案エラーレベル:警告"
+ "STATEMENT_DISALLOW_OFFLINE_DDL": {
+ "title": "オフラインDDLを禁止",
+ "description": "データベースの変更がビジネスに影響するのを防ぐために、オフラインDDLの使用を避けてください。"
+ },
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": {
+ "title": "ON DELETE節での CASCADE オプションの使用を禁止する",
+ "description": "'ON DELETEの\"CASCADE\"オプションは、多数の依存オブジェクトが削除または変更される原因となり、予期しない結果をもたらす可能性があります。提案されるエラーレベル:エラー"
+ },
+ "STATEMENT_DISALLOW_ORDER_BY": {
+ "title": "\"UPDATE\"および\"DELETE\"ステートメントでの\"ORDER BY\"句の使用の禁止",
+ "description": "ソート操作は非常にリソースを消費するため、更新および削除操作では、ORDER BYおよびLIMITの代わりに可能な限り決定論的なフィルタリング条件を使用することをお勧めします。提案エラーレベル:エラー"
+ },
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": {
+ "title": "テーブルの削除時に\"CASCADE\"を使用することを禁止する",
+ "description": "テーブルを削除する際の\"CASCADE\"オプションの使用は、多数の依存オブジェクトが削除または変更される原因となり、予期しない結果をもたらす可能性があります。提案されるエラーレベル:エラー"
},
- "statement-disallow-using-filesort": {
+ "STATEMENT_DISALLOW_USING_FILESORT": {
"title": "ファイルソートの使用を禁止する",
"description": "ファイルソートは、データの大量の読み書きを伴うため、パフォーマンスが低下する可能性があります。提案エラーレベル:警告"
},
- "statement-where-no-equal-null": {
- "title": "WHERE句でのNULL等価比較の使用を禁止する",
- "description": "NULL等価比較の結果は常にNULLです、これは予期しない結果を引き起こす可能性があります。推奨エラーレベル:警告"
+ "STATEMENT_DISALLOW_USING_TEMPORARY": {
+ "title": "一時テーブルの使用を禁止する",
+ "description": "一時テーブルは、データの永続化が不要な場合にのみ使用することをお勧めします。一時テーブルはディスクに書き込まれるため、パフォーマンスが低下する可能性があります。提案エラーレベル:警告"
},
- "statement-where-disallow-functions-and-calculations": {
- "title": "WHERE 句でインデックス付きフィールドに関数や計算を適用しないでください",
- "description": "あなたがインデックス付けされたフィールドに関数や計算を適用すると、データベースはインデックスを使用できず、代わりにテーブル全体をスキャンする必要があります。"
+ "STATEMENT_DML_DRY_RUN": {
+ "title": "DML ステートメントの実行可能性を検証する",
+ "description": "構文は正しいが、テーブル名が間違っているか、権限が不足している場合、実際の実行前にドライランで発見できます。提案エラーレベル:警告"
},
- "statement-query-minimum-plan-level": {
- "title": "クエリ アクセス メソッドの最大レベルを制限する",
- "description": "SQL パフォーマンス最適化は、定数時間 (じょうすうじかん) アクセスを目指すもので、基準として参照 (さんしょう) レベルを置き、許容範囲として範囲 (はんい) レベルのパフォーマンスを想定します。",
- "component": {
- "level": {
- "title": "最大レベル"
- }
- }
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": {
+ "title": "\"INSERT\" ステートメントで \"ORDER BY rand()\" の使用を禁止する",
+ "description": "挿入するデータをランダムに並べ替えることは意味がなく、不必要なリソースを消費するだけです。提案エラーレベル:エラー"
},
- "statement-where-maximum-logical-operator-count": {
- "title": "WHERE 句の IN または OR 句の値数を制限する",
- "description": "このアプローチは、広範な比較とリソースの制限によるパフォーマンスの低下を防ぎます。",
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": {
+ "title": "\"INSERT\" ステートメントで列名の指定を強制する",
+ "description": "\"INSERT INTO table VALUES (...)\" ステートメントは列名を明示的にリストしません。列の順序が変更されたり、列が追加または削除された場合、ステートメントは失敗するか予期しないデータを生成する可能性があります。提案エラーレベル:エラー"
+ },
+ "STATEMENT_INSERT_ROW_LIMIT": {
+ "title": "挿入される行数の最大制限",
+ "description": "挿入される行数を明示することで、ステートメントがビジネスの期待に沿っているかどうかを判断するのに役立ちます。提案エラーレベル:警告",
"component": {
"number": {
- "title": "最大値"
+ "title": "最大挿入量"
}
}
},
- "statement-maximum-limit-value": {
- "title": "リミット節の上限値を制限する",
- "description": "LIMIT による行数の制限は、データベースが管理可能なサイズの塊で処理を行い、クエリの実行速度を向上させます。上限を設定した LIMIT は、過度なメモリ使用を防ぎ、システム全体の安定性とパフォーマンスの低下を防ぐセーフガードとして機能します。",
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {
+ "title": "ジョインするフィールドは、データ型と文字セットが一致している必要があります",
+ "description": "加入カラムのデータ型、文字セットが一致しないと、データベースは一致する行を正しく識別できず、不正確または不完全な結果が生じるおそれがあります。"
+ },
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {
+ "title": "結合するテーブル数を制限する",
+ "description": "結合するテーブル数が増えるほど、クエリは 複雑 (fukuzatsu) になり、実行時間が 長くなります (nagaku narimasu)。 一般的に、結合数を 最小限 (saishougen) に抑えることが望ましいです。",
"component": {
"number": {
"title": "最大値"
}
}
},
- "statement-maximum-join-table-count": {
- "title": "結合するテーブル数を制限する",
- "description": "結合するテーブル数が増えるほど、クエリは 複雑 (fukuzatsu) になり、実行時間が 長くなります (nagaku narimasu)。 一般的に、結合数を 最小限 (saishougen) に抑えることが望ましいです。",
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": {
+ "title": "リミット節の上限値を制限する",
+ "description": "LIMIT による行数の制限は、データベースが管理可能なサイズの塊で処理を行い、クエリの実行速度を向上させます。上限を設定した LIMIT は、過度なメモリ使用を防ぎ、システム全体の安定性とパフォーマンスの低下を防ぐセーフガードとして機能します。",
"component": {
"number": {
"title": "最大値"
}
}
},
- "statement-maximum-statements-in-transaction": {
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {
"title": "トランザクション内のステートメント数を制限する",
"description": "大きなトランザクションは、データベースのパフォーマンスに著しく影響を及ぼします。 多数のステートメントが関与しており、1つでも失敗すると、トランザクション全体のロールバックが複雑になります。 ステートメントを制限することで、単一の障害による潜在的な損害を最小限に抑え、ロールバック手順を簡素化できます。",
"component": {
@@ -529,31 +483,7 @@
}
}
},
- "statement-join-strict-column-attrs": {
- "title": "ジョインするフィールドは、データ型と文字セットが一致している必要があります",
- "description": "加入カラムのデータ型、文字セットが一致しないと、データベースは一致する行を正しく識別できず、不正確または不完全な結果が生じるおそれがあります。"
- },
- "statement-prior-backup-check": {
- "title": "事前にデータのバックアップが可能か確認する",
- "description": "このルールは、データが変更される前にバックアップを作成できるかどうかをチェックします。このルールでは、バックアップ ターゲット データベースが存在し、DDL ステートメントが含まれていないことが必要です。"
- },
- "statement-add-column-without-position": {
- "title": "指定位置への列の追加を禁止",
- "description": "場合によっては、FIRST/AFTER を使用して指定位置に列を追加すると、データの再編成(元のデータを再び書き直す)が発生する可能性があります。推奨エラーレベル:警告。"
- },
- "statement-disallow-offline-ddl": {
- "title": "オフラインDDLを禁止",
- "description": "データベースの変更がビジネスに影響するのを防ぐために、オフラインDDLの使用を避けてください。"
- },
- "statement-disallow-cross-db-queries": {
- "title": "データベース間のクエリを禁止する",
- "description": "データベース間のクエリはシステムの結合度を高め、効率性に問題を引き起こす可能性があります。推奨されるエラーレベル:警告"
- },
- "schema-backward-compatibility": {
- "title": "アプリケーションの後方互換性を確認する",
- "description": "一部の変更は実行中のアプリケーションに影響を与える可能性があります。データベースオブジェクトの名前の変更や新しい制約の追加などが該当します。このルールにより、既存のアプリケーションの障害を防ぐことができます。提案されるエラーレベル:警告"
- },
- "statement-max-execution-time": {
+ "STATEMENT_MAX_EXECUTION_TIME": {
"title": "最大実行時間パラメータの設定を強制する",
"description": "SQL 文の最大実行時間を設定します。実行時間が制限を超えると、文は終了します。提案エラー レベル: 警告",
"mysql": {
@@ -565,75 +495,73 @@
"description": "変更スクリプトで MAX_STATEMENT_TIME パラメータを設定して、ステートメントの最大実行時間を明示的に制御します。提案エラー レベル: 警告"
}
},
- "statement-require-algorithm-option": {
+ "STATEMENT_MERGE_ALTER_TABLE": {
+ "title": "同じテーブルに対して複数の独立した変更の発行の禁止",
+ "description": "テーブルへの変更ごとにテーブルレベルのロックが発生し、大量のリソースを消費する可能性があります。同じテーブルに複数の変更がある場合は、それらを1つの変更ステートメントに統合する必要があります。提案エラーレベル:エラー"
+ },
+ "STATEMENT_NON_TRANSACTIONAL": {
+ "title": "非トランザクションステートメントを検出してレポートする",
+ "description": ""
+ },
+ "STATEMENT_OBJECT_OWNER_CHECK": {
+ "title": "オブジェクト所有者のチェック",
+ "description": "このルールは、DDLのオブジェクト所有者が現在のユーザーと同じであるかどうかを確認します。"
+ },
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {
+ "title": "クエリ アクセス メソッドの最大レベルを制限する",
+ "description": "SQL パフォーマンス最適化は、定数時間 (じょうすうじかん) アクセスを目指すもので、基準として参照 (さんしょう) レベルを置き、許容範囲として範囲 (はんい) レベルのパフォーマンスを想定します。",
+ "component": {
+ "level": {
+ "title": "最大レベル"
+ }
+ }
+ },
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": {
"title": "ALTER TABLE文でALGORITHMオプションを指定する必要がある",
"description": "ALTER TABLE ステートメントで ALGORITHM オプションを指定すると、テーブルの変更の適用方法をより細かく制御できるようになり、テーブル全体のコピーやロックを回避することで潜在的な中断を最小限に抑えることができます。これにより、パフォーマンスが最適化され、スキーマ変更中のダウンタイムが短縮されます。推奨されるエラー レベル: 警告。"
},
- "statement-require-lock-option": {
+ "STATEMENT_REQUIRE_LOCK_OPTION": {
"title": "ALTER TABLE文でLOCKオプションを指定する必要がある",
"description": "ALTER TABLE ステートメントの LOCK オプションを使用すると、スキーマ変更時のロック レベルを制御できるため、不要なテーブル ロックを防止し、同時実行性を向上させることができます。このオプションを適切に使用すると、アクティブなクエリに対する DDL 操作の影響を大幅に軽減できます。推奨されるエラー レベル: 警告。"
},
- "database-drop-empty-database": {
- "title": "空でないデータベースの削除を禁止する",
- "description": "データベース内にテーブルが存在しない場合のみ削除が許可されます。これにより、誤って削除することを大幅に防ぐことができます。提案されるエラーレベル:エラー"
- },
- "index-no-duplicate-column": {
- "title": "重複する列を含むインデックスの作成を禁止する",
- "description": "重複する列を持つインデックスの作成は失敗します。提案されるエラーレベル:エラー"
- },
- "index-type-no-blob": {
- "title": "\"BLOB\"および\"TEXT\"データ型の列にインデックスの作成を禁止する",
- "description": "\"BLOB\"タイプは通常、バイナリデータを格納するために使用され、クエリ条件として使用するべきではありません。誤ってこの列タイプにインデックスを作成すると、多くのリソースを消費し、重大なパフォーマンスの影響を引き起こす可能性があります。提案されるエラーレベル:エラー"
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": {
+ "title": "クエリのフルテーブルスキャンをチェックする",
+ "description": "フルテーブルスキャンはリソースを消費する操作であり、重大なパフォーマンスの影響を引き起こす可能性があります。提案エラーレベル:エラー"
},
- "index-pk-type-limit": {
- "title": "プライマリキーのタイプ制限",
- "description": "プライマリキーのタイプをINTまたはBIGINTに制限します。"
+ "STATEMENT_SELECT_NO_SELECT_ALL": {
+ "title": "「SELECT *」の使用を禁止する",
+ "description": "「SELECT *」を使用して全行データを取得すると、不必要なリソースのオーバーヘッドが発生し、テーブルに列を追加または削除した場合にアプリケーションで予期しない結果が発生する可能性があります。提案エラーレベル:エラー"
},
- "index-key-number-limit": {
- "title": "単一のインデックス内の列の数を制限する",
- "description": "5つ以上の列を持つ複合インデックスは、クエリのパフォーマンスを大幅に向上させるわけではありませんが、多くのスペースを占有し、DMLのパフォーマンスを低下させます。提案エラーレベル:警告",
- "component": {
- "number": {
- "title": "最大列数"
- }
- }
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": {
+ "title": "WHERE 句でインデックス付きフィールドに関数や計算を適用しないでください",
+ "description": "あなたがインデックス付けされたフィールドに関数や計算を適用すると、データベースはインデックスを使用できず、代わりにテーブル全体をスキャンする必要があります。"
},
- "index-total-number-limit": {
- "title": "単一のテーブルにおけるインデックスの数を制限します",
- "description": "インデックスはクエリのパフォーマンスを向上させることができますが、多くのスペースを占有し、DMLのパフォーマンスを低下させることもあります。したがって、テーブルに5つ以上のインデックスを作成することは推奨されません。提案エラーレベル:警告",
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": {
+ "title": "WHERE 句の IN または OR 句の値数を制限する",
+ "description": "このアプローチは、広範な比較とリソースの制限によるパフォーマンスの低下を防ぎます。",
"component": {
"number": {
- "title": "最大インデックス数"
+ "title": "最大値"
}
}
},
- "index-primary-key-type-allowlist": {
- "title": "許可される主キーのタイプのリスト",
- "description": "適切な主キーのタイプは、ストレージ構造を最適化し、スペース使用量を減らし、挿入およびクエリのパフォーマンスを向上させることができます。提案エラーレベル:警告",
- "component": {
- "list": {
- "title": "許可リスト"
- }
- }
+ "STATEMENT_WHERE_NO_EQUAL_NULL": {
+ "title": "WHERE句でのNULL等価比較の使用を禁止する",
+ "description": "NULL等価比較の結果は常にNULLです、これは予期しない結果を引き起こす可能性があります。推奨エラーレベル:警告"
},
- "index-create-concurrently": {
- "title": "同時インデックス作成の強制",
- "description": "PostgreSQL 11以降では、標準のステートメントを使用してインデックスを作成すると、テーブルのロックが発生し、書き込みができなくなります。\"CONCURRENTLY\"モードを使用すると、この問題を回避できます。提案エラーレベル:警告"
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": {
+ "title": "フィルタ条件で先行ワイルドカードの使用を禁止する",
+ "description": "「LIKE '%ABC'」のような先行ワイルドカードを使用すると、データベースの最適化プランナーは高速なインデックススキャンを使用できず、フルテーブルスキャンまたはフルインデックススキャンにフォールバックする可能性があります。これにより、重大なパフォーマンスの影響が発生する可能性があります。提案エラーレベル:エラー"
},
- "index-type-allow-list": {
- "title": "許可されたインデックスタイプのリスト",
- "description": "異なるインデックスタイプには異なるパフォーマンス特性があります。例えば、B-tree インデックスは範囲クエリに適していますが、ハッシュインデックスは等価クエリに適しています。提案エラーレベル: 警告",
- "component": {
- "list": {
- "title": "許可リスト"
- }
- }
+ "STATEMENT_WHERE_REQUIRE_SELECT": {
+ "title": "SELECT文に「WHERE」条件を強制する",
+ "description": "WHERE 句のないクエリは、膨大なリソースのオーバーヘッドを引き起こす可能性があります。提案エラー レベル: エラー"
},
- "index-not-redundant": {
- "title": "冗長なインデックスを禁止する",
- "description": "冗長なインデックスはパフォーマンスの損失と追加のスペースの占有を引き起こす可能性があります。例えば、列(c1)にすでにインデックスが存在する場合、列(c1、c2)上のインデックスは冗長なインデックスとして扱われます。提案されるエラーレベル:警告"
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": {
+ "title": "ステートメント内の「WHERE」条件の存在を強制する",
+ "description": "WHERE 句のない DML は、大量の偶発的なデータ損失を引き起こす可能性があります。提案エラー レベル: エラー"
},
- "system-charset-allowlist": {
+ "SYSTEM_CHARSET_ALLOWLIST": {
"title": "許可される文字セットのリスト",
"description": "文字セットは、テーブルに格納できる文字を決定します。間違った文字セットを使用すると、アプリケーションの一部の文字が正しく格納および表示されない場合があります。CJKや絵文字などが該当します。提案エラーレベル:エラー",
"component": {
@@ -642,7 +570,7 @@
}
}
},
- "system-collation-allowlist": {
+ "SYSTEM_COLLATION_ALLOWLIST": {
"title": "許可可能な照合のリスト",
"description": "照合は文字の比較とソートのルールを決定します。例えば、大文字小文字を区別しない照合を使用する場合、クエリ内では\"ABC\"と\"abc\"は同じ文字列として扱われます。推奨エラーレベル:エラー",
"component": {
@@ -651,7 +579,7 @@
}
}
},
- "system-comment-length": {
+ "SYSTEM_COMMENT_LENGTH": {
"title": "コメントの長さを制限する",
"description": "",
"component": {
@@ -660,55 +588,123 @@
}
}
},
- "system-procedure-disallow-create": {
- "title": "システムプロシージャの実行を禁止する",
- "description": "システムプロシージャは、データベースのメタデータを変更するために使用されるため、誤って実行するとデータベースの整合性が失われる可能性があります。提案エラーレベル:警告"
- },
- "system-event-disallow-create": {
+ "SYSTEM_EVENT_DISALLOW_CREATE": {
"title": "イベントの作成は許可されていません",
"description": "このルールは、データベース内でのイベントの作成を禁止します。システム イベントは、多くの場合、データベース環境に影響を与える可能性のある自動タスクを実行します。イベントの作成を禁止することで、データベース操作の制御を維持し、潜在的な問題を防ぐことができます。推奨エラー レベル:警告"
},
- "system-view-disallow-create": {
- "title": "ビューの作成を禁止",
- "description": "このルールは、データベース内でのビューの作成を禁止します。ビューは、クエリを単純化し、データのセキュリティを向上させることができるデータの仮想表現を提供します。その作成を禁止することで、データベーススキーマの管理を維持し、潜在的なセキュリティリスクを防ぐのに役立ちます。推奨されるエラーレベル:警告"
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": {
+ "title": "特定の関数の使用を禁止する",
+ "description": "このルールは、データベース内の特定の関数の使用を制限します。これらの関数の使用を禁止することで、データの一貫性とセキュリティを維持するのに役立ちます。推奨エラーレベル:警告",
+ "component": {
+ "list": {
+ "title": "禁止リスト"
+ }
+ }
},
- "system-function-disallow-create": {
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": {
"title": "関数の作成を禁止する",
"description": "このルールは、データベース内での関数の作成を禁止します。関数は再利用可能なロジックを提供し、クエリを簡素化し、データの整合性を向上させることができます。その作成を禁止することで、データベーススキーマの制御を維持し、潜在的なセキュリティリスクを防止します。推奨されるエラーレベル:警告"
},
- "system-function-disallowed-list": {
- "title": "特定の関数の使用を禁止する",
- "description": "このルールは、データベース内の特定の関数の使用を制限します。これらの関数の使用を禁止することで、データの一貫性とセキュリティを維持するのに役立ちます。推奨エラーレベル:警告",
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": {
+ "title": "システムプロシージャの実行を禁止する",
+ "description": "システムプロシージャは、データベースのメタデータを変更するために使用されるため、誤って実行するとデータベースの整合性が失われる可能性があります。提案エラーレベル:警告"
+ },
+ "SYSTEM_VIEW_DISALLOW_CREATE": {
+ "title": "ビューの作成を禁止",
+ "description": "このルールは、データベース内でのビューの作成を禁止します。ビューは、クエリを単純化し、データのセキュリティを向上させることができるデータの仮想表現を提供します。その作成を禁止することで、データベーススキーマの管理を維持し、潜在的なセキュリティリスクを防ぐのに役立ちます。推奨されるエラーレベル:警告"
+ },
+ "TABLE_COMMENT": {
+ "title": "コメントの規約",
+ "description": "テーブルにコメントが必要かどうか、および最大コメント長を設定します。",
+ "component": {
+ "required": {
+ "title": "コメントの必須化"
+ },
+ "requiredClassification": {
+ "title": "分類が必要",
+ "tooltip": "コメントは、{'{'}分類 ID{'}'}-{'{'}コメント{'}'} の形式に従う必要があります。"
+ },
+ "maxLength": {
+ "title": "最大長"
+ }
+ }
+ },
+ "TABLE_DISALLOW_DDL": {
+ "title": "DDL を禁止する",
+ "description": "DDL の実行を禁止するテーブルを設定します。提案エラー レベル: 警告",
"component": {
"list": {
- "title": "禁止リスト"
+ "title": "テーブル名"
}
}
},
- "advice-online-migration": {
- "title": "オンライン移行",
- "description": "移行されたテーブル行数が設定値を超えた場合、オンライン移行の有効化を推奨します。推奨されるエラーレベル: 警告",
+ "TABLE_DISALLOW_DML": {
+ "title": "DML を禁止する",
+ "description": "DML の実行を禁止するテーブルを設定します。提案エラー レベル: 警告",
+ "component": {
+ "list": {
+ "title": "テーブル名"
+ }
+ }
+ },
+ "TABLE_DISALLOW_PARTITION": {
+ "title": "パーティションテーブルの使用を禁止する",
+ "description": "一部のデータベースエンジンでは、パーティションテーブルは未熟であり、使用やメンテナンスが不便です。そのため、データベースやテーブルのシャーディングなどの手動のデータパーティショニング方法の使用がより好まれます。提案エラーレベル:警告"
+ },
+ "TABLE_DISALLOW_SET_CHARSET": {
+ "title": "テーブルプロパティでの文字セットの定義を禁止する",
+ "description": "データベースの文字セットは、データベースレベルで設定することを推奨します。より細かいレベルで文字セットを設定すると、不要な複雑さが生じる可能性があります。推奨されるエラーレベル: エラー。"
+ },
+ "TABLE_DISALLOW_TRIGGER": {
+ "title": "テーブルにトリガの使用を禁止する",
+ "description": "トリガはデータベースの複雑さを増加させ、データの整合性を保つための手段としては適切ではありません。代わりに、アプリケーションレイヤーでデータの整合性を保つことをお勧めします。提案エラーレベル:警告"
+ },
+ "TABLE_DROP_NAMING_CONVENTION": {
+ "title": "削除するテーブルの命名形式を制限する",
+ "description": "例えば、「_del」の接尾辞を要求することで、誤って削除することを効果的に防ぐことができます。提案エラーレベル:エラー",
+ "component": {
+ "format": {
+ "title": "テーブル名の形式(正規表現)"
+ }
+ }
+ },
+ "TABLE_LIMIT_SIZE": {
+ "title": "行数の多いテーブルに対するDDL操作を制限する",
+ "description": "DDLが実行可能なテーブルの最大行数を設定します。推奨エラーレベル:警告",
"component": {
"number": {
- "title": "しきい値"
+ "title": "最大行数"
}
}
},
- "statement-add-foreign-key-not-valid": {
- "title": "外部キーを追加するときに「NOT VALID」オプションを含めることを強制する",
- "description": "外部キーを追加するには、既存のデータを検証する必要があり、SHARE ROW EXCLUSIVE テーブル ロックが必要です。\nこれにより書き込みがブロックされ、業務が中断される可能性があります。\n新しいデータを検証し、変更の完了後に既存のデータを検証するには、「NOT VALID」オプションを追加することをお勧めします。\n提案エラーレベル: 警告"
+ "TABLE_NO_DUPLICATE_INDEX": {
+ "title": "テーブル内の重複インデックスを禁止する",
+ "description": "このルールは、テーブルに重複するインデックスがないことを要求します。重複するインデックスは余分なストレージスペースを消費し、クエリパフォーマンスを低下させる可能性があります。推奨されるエラーレベル:警告。"
},
- "statement-non-transactional": {
- "title": "非トランザクションステートメントを検出してレポートする",
- "description": ""
+ "TABLE_NO_FOREIGN_KEY": {
+ "title": "外部キー制約の使用を禁止する",
+ "description": "外部キーの利点と欠点は非常に議論が分かれています。外部キーの使用は、データベースの変更やスケーラビリティ(シャーディングなど)の難しさを大幅に増加させる可能性があります。また、一部のツールの使用を妨げることさえあります。そのため、別のオプションとして、アプリケーションレイヤーで外部キー制約を実装することがあります。提案エラーレベル:警告"
},
- "builtin-prior-backup-check": {
- "title": "事前のバックアップ実行可能性チェック",
- "description": "このルールは、データが変更される前にバックアップを作成できるかどうかを確認します。バックアップ ターゲット データベースの存在を確認し、サポートされていないシナリオを禁止します。これは組み込みであり、スキップできません。"
+ "TABLE_REQUIRE_CHARSET": {
+ "title": "文字セットを要求する",
+ "description": "テーブルの文字セットを指定する必要があります。提案エラーレベル: 警告"
},
- "statement-object-owner-check": {
- "title": "オブジェクト所有者のチェック",
- "description": "このルールは、DDLのオブジェクト所有者が現在のユーザーと同じであるかどうかを確認します。"
+ "TABLE_REQUIRE_COLLATION": {
+ "title": "照合を要求する",
+ "description": "テーブルの照合順序を指定する必要があります。提案エラー レベル: 警告"
+ },
+ "TABLE_REQUIRE_PK": {
+ "title": "テーブルに主キーの含まれることを強制する",
+ "description": "さまざまなデータ同期、比較、ロールバック ツールでは、テーブルに主キーが必要になることがよくあります。提案エラー レベル: エラー"
+ },
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": {
+ "title": "テキスト入力欄の文字数を制限する",
+ "description": "このルールは、テーブルが保持できるデータ量を制限し、過剰なストレージ使用を防ぎます。",
+ "component": {
+ "number": {
+ "title": "最大長さ"
+ }
+ }
}
},
"level": {
diff --git a/frontend/src/locales/sql-review/vi-VN.json b/frontend/src/locales/sql-review/vi-VN.json
index be54c6663e..65551060ce 100644
--- a/frontend/src/locales/sql-review/vi-VN.json
+++ b/frontend/src/locales/sql-review/vi-VN.json
@@ -33,55 +33,39 @@
"bb-sql-review-empty-desc": "Một mẫu trống. Bạn cần tự thêm các quy tắc cần thiết."
},
"rule": {
- "engine-mysql-use-innodb": {
- "title": "Bắt buộc sử dụng engine lưu trữ InnoDB",
- "description": "InnoDB là engine lưu trữ mặc định cho MySQL, cung cấp hỗ trợ giao dịch. Nó cũng cung cấp hiệu suất tốt hơn cho các tình huống có tính đồng thời cao và độ trễ thấp, đồng thời hỗ trợ sao lưu và phục hồi dữ liệu trực tuyến. Đây là lựa chọn ưu tiên cho các doanh nghiệp OLTP. Mức độ lỗi gợi ý: Lỗi"
- },
- "table-require-pk": {
- "title": "Bắt buộc bảng phải có khóa chính",
- "description": "Các công cụ đồng bộ hóa, so sánh và hoàn tác dữ liệu khác nhau yêu cầu bảng phải có khóa chính. Mức độ lỗi gợi ý: Lỗi"
- },
- "table-no-foreign-key": {
- "title": "Cấm sử dụng ràng buộc khóa ngoại",
- "description": "Ưu điểm và nhược điểm của khóa ngoại rất gây tranh cãi. Sử dụng khóa ngoại có thể làm tăng đáng kể độ khó của việc thay đổi cơ sở dữ liệu, khả năng mở rộng (chẳng hạn như phân mảnh), v.v. Và thậm chí có thể ngăn cản việc sử dụng một số công cụ. Do đó, một tùy chọn khác là triển khai các ràng buộc khóa ngoại ở lớp ứng dụng. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "table-drop-naming-convention": {
- "title": "Hạn chế định dạng đặt tên của các bảng sẽ bị xóa",
- "description": "Ví dụ: bằng cách yêu cầu hậu tố \"_del\", nó có thể ngăn chặn hiệu quả việc xóa do nhầm lẫn. Mức độ lỗi gợi ý: Lỗi",
+ "ADVICE_ONLINE_MIGRATION": {
+ "title": "Di chuyển trực tuyến",
+ "description": "Đề nghị bật di chuyển trực tuyến nếu số lượng hàng của bảng được di chuyển vượt quá cài đặt của bạn. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
- "format": {
- "title": "Định dạng tên bảng (biểu thức chính quy)"
+ "number": {
+ "title": "Giá trị ngưỡng"
}
}
},
- "table-disallow-partition": {
- "title": "Cấm sử dụng bảng phân vùng",
- "description": "Trong một số engine cơ sở dữ liệu, các bảng phân vùng chưa hoàn thiện, việc sử dụng và bảo trì không thuận tiện. Do đó, người ta có xu hướng sử dụng các phương pháp phân vùng dữ liệu thủ công như phân mảnh cơ sở dữ liệu và bảng. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "table-disallow-trigger": {
- "title": "Ngăn chặn việc sử dụng trigger trên bảng",
- "description": "Quy tắc này hạn chế việc sử dụng trigger trên bảng. Trigger có thể gây ra sự phức tạp và các vấn đề hiệu suất tiềm ẩn cho các hoạt động cơ sở dữ liệu. Bằng cách không cho phép trigger, hệ thống có thể duy trì hành vi đơn giản và dễ đoán hơn. Mức độ lỗi đề xuất: Cảnh báo"
- },
- "table-no-duplicate-index": {
- "title": "Không cho phép chỉ mục trùng lặp",
- "description": "Quy tắc này cấm tạo chỉ mục trùng lặp trên một bảng. Các chỉ mục trùng lặp tiêu tốn thêm không gian lưu trữ và có khả năng làm giảm hiệu suất truy vấn. Mức độ lỗi gợi ý: Cảnh báo"
+ "BUILTIN_PRIOR_BACKUP_CHECK": {
+ "title": "Kiểm tra tính khả thi của sao lưu trước",
+ "description": "Quy tắc này kiểm tra xem có thể tạo bản sao lưu trước khi thay đổi dữ liệu hay không. Nó xác minh sự tồn tại của cơ sở dữ liệu đích sao lưu và không cho phép các kịch bản không được hỗ trợ. Nó được tích hợp sẵn và không thể bỏ qua."
},
- "table-text-fields-total-length": {
- "title": "Hạn chế tổng độ dài của các trường văn bản trong bảng",
- "description": "Quy tắc này giới hạn lượng dữ liệu mà một bảng có thể chứa, ngăn chặn việc sử dụng quá nhiều bộ nhớ.",
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": {
+ "title": "Hạn chế giá trị ban đầu của cột tự tăng",
+ "description": "dựa trên các yêu cầu quản lý để giới hạn giá trị ban đầu của cột tự tăng. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
"number": {
- "title": "Độ dài tối đa"
+ "title": "Giá trị ban đầu"
}
}
},
- "table-disallow-set-charset": {
- "title": "Cấm xác định bộ ký tự trong thuộc tính bảng",
- "description": "Khuyến nghị nên đặt charset ở cấp cơ sở dữ liệu. Đặt charset ở mức độ chi tiết hơn có thể mang lại những phức tạp không cần thiết. Mức độ lỗi gợi ý: Lỗi."
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": {
+ "title": "Bắt buộc sử dụng kiểu dữ liệu \"INTEGER\" cho các cột tự tăng",
+ "description": "Cột tự tăng của MySQL thường được sử dụng làm khóa chính độc lập với nghiệp vụ. Sử dụng kiểu số nguyên chiếm ít không gian lưu trữ hơn và làm cho cấu trúc chỉ mục khóa chính gọn hơn, mang lại hiệu suất truy vấn và DML tốt hơn. Mức độ lỗi gợi ý: Lỗi"
},
- "table-comment": {
- "title": "Quy ước bình luận bảng",
- "description": "Định cấu hình xem bảng có yêu cầu bình luận hay không và độ dài bình luận tối đa.",
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": {
+ "title": "Bắt buộc sử dụng kiểu dữ liệu \"UNSIGNED\" cho các cột tự tăng",
+ "description": "Kiểu không dấu không lưu trữ số âm và phạm vi giá trị có thể được lưu trữ bởi cùng một kiểu được nhân đôi, có thể tránh tràn cột tự tăng. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "COLUMN_COMMENT": {
+ "title": "Quy ước bình luận cột",
+ "description": "Thêm bình luận vào cột là một phương pháp phát triển tốt, nhưng bình luận quá dài có thể làm giảm khả năng đọc của lược đồ. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
"required": {
"title": "Yêu cầu bình luận"
@@ -95,58 +79,159 @@
}
}
},
- "table-disallow-ddl": {
- "title": "Không cho phép DDL",
- "description": "Định cấu hình bảng nào bị cấm thực hiện DDL. Mức độ lỗi gợi ý: Cảnh báo",
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": {
+ "title": "Hạn chế số lượng cột trong bảng lấy thời gian hệ thống",
+ "description": "Chỉ các cột ghi lại thời gian tạo bản ghi với \"DEFAULT NOW()\" và ghi lại thời gian cập nhật bản ghi với \"DEFAULT NOW() ON UPDATE\" cần gọi hàm để lấy thời gian hệ thống. Việc ghi lại thời gian hệ thống trong các cột khác là vô nghĩa và sẽ làm tăng chi phí tài nguyên. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": {
+ "title": "Không cho phép đặt giá trị mặc định không ổn định trên các cột",
+ "description": "Các hàm không ổn định (ví dụ: clock_timestamp()) cập nhật từng hàng với giá trị tại thời điểm thực hiện ALTER TABLE ADD COLUMN, có khả năng gây ra các bản cập nhật kéo dài."
+ },
+ "COLUMN_DISALLOW_CHANGE": {
+ "title": "Cấm sử dụng câu lệnh \"CHANGE COLUMN\"",
+ "description": "\"CHANGE COLUMN\" là cú pháp riêng của MySQL và có thể được sử dụng để sửa đổi tên cột và các thuộc tính khác cùng một lúc. Tuy nhiên, nó có thể khiến tên cột bị thay đổi nhầm khi sửa đổi thuộc tính. Khuyến nghị vẫn sử dụng các câu lệnh \"RENAME\" và \"MODIFY\" tiêu chuẩn để phân biệt giữa hai loại thay đổi. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "COLUMN_DISALLOW_CHANGE_TYPE": {
+ "title": "Cấm sửa đổi loại cột",
+ "description": "Sửa đổi loại cột có thể ảnh hưởng đến hiệu suất hệ thống, khả năng bảo trì và thậm chí dẫn đến mất dữ liệu. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "COLUMN_DISALLOW_CHANGING_ORDER": {
+ "title": "Cấm thay đổi thứ tự của các cột trong bảng",
+ "description": "Sửa đổi thứ tự của các cột có thể làm cho một số ứng dụng hoặc khung nhìn phụ thuộc vào thứ tự mặc định của bảng gốc tạo ra các kết quả không mong muốn, chẳng hạn như \"select *\". Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "COLUMN_DISALLOW_DROP": {
+ "title": "Cấm xóa cột",
+ "description": "Cấm xóa cột. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "COLUMN_DISALLOW_DROP_IN_INDEX": {
+ "title": "Cấm xóa cột trong chỉ mục",
+ "description": "Cấm xóa cột trong chỉ mục. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "COLUMN_DISALLOW_SET_CHARSET": {
+ "title": "Cấm xác định bộ ký tự trong thuộc tính cột",
+ "description": "Khuyến nghị nên đặt charset ở cấp cơ sở dữ liệu hoặc cấp bảng. Đặt charset ở mức độ chi tiết hơn có thể mang lại những phức tạp không cần thiết. Mức độ lỗi gợi ý: Lỗi."
+ },
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": {
+ "title": "Hạn chế độ dài của kiểu dữ liệu \"CHAR\"",
+ "description": "\"CHAR\" là một loại có độ dài cố định. Ví dụ: cột CHAR(20) sẽ chiếm 20 khoảng trống ký tự ngay cả khi chỉ có một ký tự được lưu trữ, gây lãng phí. Khi chuỗi quá dài và độ dài không cố định, hãy xem xét sử dụng VARCHAR cho MySQL và sử dụng TEXT cho PostgreSQL. Mức độ lỗi gợi ý: Lỗi",
"component": {
- "list": {
- "title": "Tên bảng"
+ "number": {
+ "title": "Độ dài tối đa"
}
}
},
- "table-limit-size": {
- "title": "Giới hạn hoạt động DDL trên các bảng có số lượng hàng lớn",
- "description": "Định cấu hình số lượng hàng tối đa trong các bảng mà DDL có thể được thực thi. Mức độ lỗi được khuyến nghị: cảnh báo",
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": {
+ "title": "Hạn chế độ dài của kiểu dữ liệu \"VARCHAR\"",
+ "description": "",
"component": {
"number": {
- "title": "Số lượng hàng tối đa"
+ "title": "Độ dài tối đa"
}
}
},
- "table-disallow-dml": {
- "title": "Không cho phép DML",
- "description": "Định cấu hình bảng nào bị cấm thực hiện DML. Mức độ lỗi gợi ý: Cảnh báo",
+ "COLUMN_NO_NULL": {
+ "title": "Bắt buộc ràng buộc \"NOT NULL\" trên các cột",
+ "description": "Cột không được phép có giá trị NULL."
+ },
+ "COLUMN_REQUIRED": {
+ "title": "Bắt buộc bao gồm các cột cụ thể trong bảng",
+ "description": "Một số cột chung rất hữu ích cho việc bảo trì ứng dụng tốt hơn. Ví dụ: thêm cột \"ID\" độc lập với nghiệp vụ làm khóa chính tránh được xung đột khóa chính do thay đổi nghiệp vụ (chẳng hạn như sáp nhập nghiệp vụ) và trong một số trường hợp cũng có thể mang lại hiệu suất chèn dữ liệu tốt hơn. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
"list": {
- "title": "Tên bảng"
+ "title": "Tên cột bắt buộc"
}
}
},
- "table-require-charset": {
- "title": "Yêu cầu charset",
- "description": "Charset của bảng phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
+ "COLUMN_REQUIRE_CHARSET": {
+ "title": "Yêu cầu charset cho cột kiểu text",
+ "description": "Charset của các cột có kiểu dữ liệu text phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
},
- "table-require-collation": {
- "title": "Yêu cầu đối chiếu",
- "description": "Đối chiếu (collation) của bảng phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
+ "COLUMN_REQUIRE_COLLATION": {
+ "title": "Yêu cầu đối chiếu (collation) cho các cột kiểu text",
+ "description": "Đối chiếu của các cột có kiểu dữ liệu text phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
},
- "naming-fully-qualified": {
- "title": "Tên đối tượng đủ điều kiện",
- "description": "Bắt buộc sử dụng tên đối tượng đủ điều kiện. Ví dụ: “schema.table”, mức độ lỗi gợi ý: Cảnh báo"
+ "COLUMN_REQUIRE_DEFAULT": {
+ "title": "Bắt buộc đặt giá trị mặc định trên các cột",
+ "description": "Đặt giá trị mặc định thỏa mãn logic nghiệp vụ có thể cải thiện hiệu quả chất lượng dữ liệu của quy trình phân tích xuôi dòng. Quy tắc này không kiểm tra các loại \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\". Mức độ lỗi gợi ý: Cảnh báo"
},
- "naming-table": {
- "title": "Bắt buộc định dạng đặt tên bảng",
- "description": "Định dạng mặc định là tất cả các chữ cái viết thường, được phân tách bằng dấu gạch dưới giữa các từ và không quá 63 ký tự, chẳng hạn như \"abc\" và \"abc_def\". Mức độ lỗi gợi ý: Cảnh báo",
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": {
+ "title": "Bắt buộc giá trị mặc định trên cột \"NOT NULL\"",
+ "description": "Đối với cột 'NOT NULL', nếu giá trị không được gán cho cột khi chèn một hàng mới và cột không có giá trị mặc định, cơ sở dữ liệu sẽ từ chối việc chèn hàng đó. Đặt giá trị mặc định cho một cột mới cũng có thể đảm bảo khả năng tương thích với ứng dụng cũ. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "COLUMN_TYPE_DISALLOW_LIST": {
+ "title": "Cấm sử dụng một số loại dữ liệu cột nhất định",
+ "description": "Lạm dụng các loại cột có thể có tác động tiêu cực nghiêm trọng đến khả năng bảo trì và hiệu suất của hệ thống. Ví dụ: sử dụng cột \"LOB\" để lưu trữ một lượng lớn dữ liệu âm thanh và video có thể khiến hiệu suất cơ sở dữ liệu giảm, thời gian sao lưu và phục hồi kéo dài và các công cụ đồng bộ hóa dữ liệu không tương thích. Mức độ lỗi gợi ý: Lỗi",
"component": {
- "format": {
- "title": "Định dạng tên bảng (biểu thức chính quy)"
- },
- "maxLength": {
- "title": "Giới hạn độ dài"
+ "list": {
+ "title": "Danh sách không cho phép"
+ }
+ }
+ },
+ "DATABASE_DROP_EMPTY_DATABASE": {
+ "title": "Cấm xóa cơ sở dữ liệu không trống",
+ "description": "Chỉ được phép xóa khi không có bảng nào trong cơ sở dữ liệu, điều này có thể tránh được việc xóa do nhầm lẫn. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "ENGINE_MYSQL_USE_INNODB": {
+ "title": "Bắt buộc sử dụng engine lưu trữ InnoDB",
+ "description": "InnoDB là engine lưu trữ mặc định cho MySQL, cung cấp hỗ trợ giao dịch. Nó cũng cung cấp hiệu suất tốt hơn cho các tình huống có tính đồng thời cao và độ trễ thấp, đồng thời hỗ trợ sao lưu và phục hồi dữ liệu trực tuyến. Đây là lựa chọn ưu tiên cho các doanh nghiệp OLTP. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "INDEX_CREATE_CONCURRENTLY": {
+ "title": "Bắt buộc tạo chỉ mục đồng thời",
+ "description": "Trong PostgreSQL 11 trở lên, sử dụng câu lệnh tiêu chuẩn để tạo chỉ mục sẽ gây ra khóa bảng và không thể ghi. Sử dụng chế độ \"CONCURRENTLY\" có thể tránh được vấn đề này. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "INDEX_KEY_NUMBER_LIMIT": {
+ "title": "Hạn chế số lượng cột trong một chỉ mục duy nhất",
+ "description": "Một chỉ mục tổng hợp có hơn 5 cột không cải thiện đáng kể hiệu suất truy vấn, nhưng nó chiếm rất nhiều không gian và làm giảm hiệu suất DML. Mức độ lỗi gợi ý: Cảnh báo",
+ "component": {
+ "number": {
+ "title": "Số lượng cột tối đa"
+ }
+ }
+ },
+ "INDEX_NOT_REDUNDANT": {
+ "title": "Không cho phép chỉ mục dư thừa",
+ "description": "Chỉ mục dư thừa có thể dẫn đến mất hiệu suất và chiếm thêm dung lượng. Ví dụ: chỉ mục trên các cột (c1, c2) sẽ được coi là chỉ mục dư thừa nếu đã có chỉ mục trên cột (c1). Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "INDEX_NO_DUPLICATE_COLUMN": {
+ "title": "Cấm chỉ mục chứa các cột trùng lặp",
+ "description": "Tạo một chỉ mục với các cột trùng lặp sẽ dẫn đến lỗi. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "INDEX_PK_TYPE_LIMIT": {
+ "title": "Giới hạn loại khóa chính",
+ "description": "Bắt buộc loại khóa chính là INT hoặc BIGINT."
+ },
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": {
+ "title": "Danh sách loại khóa chính được phép",
+ "description": "Loại khóa chính thích hợp có thể tối ưu hóa cấu trúc lưu trữ, giảm mức sử dụng không gian và có lợi cho hiệu suất chèn và truy vấn. Mức độ lỗi gợi ý: Cảnh báo",
+ "component": {
+ "list": {
+ "title": "Danh sách cho phép"
+ }
+ }
+ },
+ "INDEX_TOTAL_NUMBER_LIMIT": {
+ "title": "Hạn chế số lượng chỉ mục trên một bảng duy nhất",
+ "description": "Mặc dù các chỉ mục có thể cải thiện hiệu suất truy vấn, chúng cũng chiếm rất nhiều không gian và làm giảm hiệu suất DML. Do đó, không nên tạo quá 5 chỉ mục trong một bảng. Mức độ lỗi gợi ý: Cảnh báo",
+ "component": {
+ "number": {
+ "title": "Số lượng chỉ mục tối đa"
+ }
+ }
+ },
+ "INDEX_TYPE_ALLOW_LIST": {
+ "title": "Danh sách loại chỉ mục được phép",
+ "description": "Các loại chỉ mục khác nhau có các đặc điểm hiệu suất khác nhau. Ví dụ: chỉ mục B-tree phù hợp cho các truy vấn phạm vi, trong khi chỉ mục băm phù hợp cho các truy vấn bằng. Mức độ lỗi gợi ý: Cảnh báo",
+ "component": {
+ "list": {
+ "title": "Danh sách cho phép"
}
}
},
- "naming-column": {
+ "INDEX_TYPE_NO_BLOB": {
+ "title": "Cấm tạo chỉ mục trên các cột loại \"BLOB\" và \"TEXT\"",
+ "description": "Loại \"BLOB\" thường được sử dụng để lưu trữ dữ liệu nhị phân và không nên được sử dụng làm điều kiện truy vấn. Nếu một chỉ mục được tạo trên loại cột này do nhầm lẫn, nó sẽ tiêu tốn rất nhiều tài nguyên và gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "NAMING_COLUMN": {
"title": "Bắt buộc định dạng đặt tên cột",
"description": "Định dạng mặc định là tất cả các chữ cái viết thường, được phân tách bằng dấu gạch dưới giữa các từ, không quá 63 ký tự, chẳng hạn như \"abc\" và \"abc_def\". Mức độ lỗi gợi ý: Cảnh báo",
"component": {
@@ -158,39 +243,36 @@
}
}
},
- "naming-index-uk": {
- "title": "Bắt buộc định dạng đặt tên khóa duy nhất",
- "description": "Tên được phép để trống và được đặt tên bởi cơ sở dữ liệu. Nếu không để trống, định dạng mặc định là \"uk_<tên bảng>_<tổ hợp tên cột khóa duy nhất>\", không quá 63 ký tự, chẳng hạn như \"uk_my_table_id_name\". Mức độ lỗi gợi ý: Cảnh báo",
+ "NAMING_COLUMN_AUTO_INCREMENT": {
+ "title": " Bắt buộc định dạng đặt tên cột tự tăng",
+ "description": "Tên cột mặc định là \"ID\" và không quá 63 ký tự.",
"component": {
"format": {
- "title": "Định dạng tên khóa duy nhất",
- "template": {
- "table": "Tên bảng",
- "column_list": "Tên cột chỉ mục, được nối bằng dấu gạch dưới (_)"
- }
+ "title": "Định dạng tên cột tự tăng (biểu thức chính quy)"
},
"maxLength": {
"title": "Giới hạn độ dài"
}
}
},
- "naming-index-pk": {
- "title": "Bắt buộc định dạng đặt tên khóa chính",
- "description": "Tên được phép để trống và được đặt tên bởi cơ sở dữ liệu. Nếu không để trống, định dạng mặc định là \"pk_<tên bảng>_<tổ hợp tên cột khóa duy nhất>\", không quá 63 ký tự, chẳng hạn như \"pk_my_table_id_name\". Mức độ lỗi gợi ý: Cảnh báo",
+ "NAMING_FULLY_QUALIFIED": {
+ "title": "Tên đối tượng đủ điều kiện",
+ "description": "Bắt buộc sử dụng tên đối tượng đủ điều kiện. Ví dụ: “schema.table”, mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "NAMING_IDENTIFIER_CASE": {
+ "title": "Bắt buộc kiểu chữ của định danh",
+ "description": "",
"component": {
- "format": {
- "title": "Định dạng tên khóa chính",
- "template": {
- "table": "Tên bảng",
- "column_list": "Tên cột chỉ mục, được nối bằng dấu gạch dưới (_)"
- }
- },
- "maxLength": {
- "title": "Giới hạn độ dài"
+ "upper": {
+ "title": "Chữ hoa"
}
}
},
- "naming-index-fk": {
+ "NAMING_IDENTIFIER_NO_KEYWORD": {
+ "title": "Cấm sử dụng từ khóa làm định danh",
+ "description": ""
+ },
+ "NAMING_INDEX_FK": {
"title": "Bắt buộc định dạng đặt tên khóa ngoại",
"description": "Tên được phép để trống và được đặt tên bởi cơ sở dữ liệu. Nếu không để trống, định dạng mặc định là \"fk_<tên bảng>_<tổ hợp tên cột khóa duy nhất>\", không quá 63 ký tự, chẳng hạn như \"fk_my_table_id_name\". Mức độ lỗi gợi ý: Cảnh báo",
"component": {
@@ -208,7 +290,7 @@
}
}
},
- "naming-index-idx": {
+ "NAMING_INDEX_IDX": {
"title": "Bắt buộc định dạng đặt tên chỉ mục",
"description": "Tên được phép để trống và được đặt tên bởi cơ sở dữ liệu. Nếu không để trống, định dạng mặc định là \"idx_<tên bảng>_<tổ hợp tên cột khóa duy nhất>\", không quá 63 ký tự, chẳng hạn như \"idx_my_table_id_name\". Mức độ lỗi gợi ý: Cảnh báo",
"component": {
@@ -224,214 +306,71 @@
}
}
},
- "naming-column-auto-increment": {
- "title": " Bắt buộc định dạng đặt tên cột tự tăng",
- "description": "Tên cột mặc định là \"ID\" và không quá 63 ký tự.",
+ "NAMING_INDEX_PK": {
+ "title": "Bắt buộc định dạng đặt tên khóa chính",
+ "description": "Tên được phép để trống và được đặt tên bởi cơ sở dữ liệu. Nếu không để trống, định dạng mặc định là \"pk_<tên bảng>_<tổ hợp tên cột khóa duy nhất>\", không quá 63 ký tự, chẳng hạn như \"pk_my_table_id_name\". Mức độ lỗi gợi ý: Cảnh báo",
"component": {
"format": {
- "title": "Định dạng tên cột tự tăng (biểu thức chính quy)"
+ "title": "Định dạng tên khóa chính",
+ "template": {
+ "table": "Tên bảng",
+ "column_list": "Tên cột chỉ mục, được nối bằng dấu gạch dưới (_)"
+ }
},
"maxLength": {
"title": "Giới hạn độ dài"
}
}
},
- "naming-table-no-keyword": {
- "title": "Cấm sử dụng từ khóa làm tên bảng",
- "description": ""
- },
- "naming-identifier-no-keyword": {
- "title": "Cấm sử dụng từ khóa làm định danh",
- "description": ""
- },
- "naming-identifier-case": {
- "title": "Bắt buộc kiểu chữ của định danh",
- "description": "",
- "component": {
- "upper": {
- "title": "Chữ hoa"
- }
- }
- },
- "column-required": {
- "title": "Bắt buộc bao gồm các cột cụ thể trong bảng",
- "description": "Một số cột chung rất hữu ích cho việc bảo trì ứng dụng tốt hơn. Ví dụ: thêm cột \"ID\" độc lập với nghiệp vụ làm khóa chính tránh được xung đột khóa chính do thay đổi nghiệp vụ (chẳng hạn như sáp nhập nghiệp vụ) và trong một số trường hợp cũng có thể mang lại hiệu suất chèn dữ liệu tốt hơn. Mức độ lỗi gợi ý: Cảnh báo",
- "component": {
- "list": {
- "title": "Tên cột bắt buộc"
- }
- }
- },
- "column-type-disallow-list": {
- "title": "Cấm sử dụng một số loại dữ liệu cột nhất định",
- "description": "Lạm dụng các loại cột có thể có tác động tiêu cực nghiêm trọng đến khả năng bảo trì và hiệu suất của hệ thống. Ví dụ: sử dụng cột \"LOB\" để lưu trữ một lượng lớn dữ liệu âm thanh và video có thể khiến hiệu suất cơ sở dữ liệu giảm, thời gian sao lưu và phục hồi kéo dài và các công cụ đồng bộ hóa dữ liệu không tương thích. Mức độ lỗi gợi ý: Lỗi",
- "component": {
- "list": {
- "title": "Danh sách không cho phép"
- }
- }
- },
- "column-no-null": {
- "title": "Bắt buộc ràng buộc \"NOT NULL\" trên các cột",
- "description": "Cột không được phép có giá trị NULL."
- },
- "column-disallow-set-charset": {
- "title": "Cấm xác định bộ ký tự trong thuộc tính cột",
- "description": "Khuyến nghị nên đặt charset ở cấp cơ sở dữ liệu hoặc cấp bảng. Đặt charset ở mức độ chi tiết hơn có thể mang lại những phức tạp không cần thiết. Mức độ lỗi gợi ý: Lỗi."
- },
- "column-disallow-change-type": {
- "title": "Cấm sửa đổi loại cột",
- "description": "Sửa đổi loại cột có thể ảnh hưởng đến hiệu suất hệ thống, khả năng bảo trì và thậm chí dẫn đến mất dữ liệu. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "column-disallow-change": {
- "title": "Cấm sử dụng câu lệnh \"CHANGE COLUMN\"",
- "description": "\"CHANGE COLUMN\" là cú pháp riêng của MySQL và có thể được sử dụng để sửa đổi tên cột và các thuộc tính khác cùng một lúc. Tuy nhiên, nó có thể khiến tên cột bị thay đổi nhầm khi sửa đổi thuộc tính. Khuyến nghị vẫn sử dụng các câu lệnh \"RENAME\" và \"MODIFY\" tiêu chuẩn để phân biệt giữa hai loại thay đổi. Mức độ lỗi gợi ý: Lỗi"
- },
- "column-disallow-changing-order": {
- "title": "Cấm thay đổi thứ tự của các cột trong bảng",
- "description": "Sửa đổi thứ tự của các cột có thể làm cho một số ứng dụng hoặc khung nhìn phụ thuộc vào thứ tự mặc định của bảng gốc tạo ra các kết quả không mong muốn, chẳng hạn như \"select *\". Mức độ lỗi gợi ý: Cảnh báo"
- },
- "column-disallow-drop": {
- "title": "Cấm xóa cột",
- "description": "Cấm xóa cột. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "column-disallow-drop-in-index": {
- "title": "Cấm xóa cột trong chỉ mục",
- "description": "Cấm xóa cột trong chỉ mục. Mức độ lỗi gợi ý: Lỗi"
- },
- "column-set-default-for-not-null": {
- "title": "Bắt buộc giá trị mặc định trên cột \"NOT NULL\"",
- "description": "Đối với cột 'NOT NULL', nếu giá trị không được gán cho cột khi chèn một hàng mới và cột không có giá trị mặc định, cơ sở dữ liệu sẽ từ chối việc chèn hàng đó. Đặt giá trị mặc định cho một cột mới cũng có thể đảm bảo khả năng tương thích với ứng dụng cũ. Mức độ lỗi gợi ý: Lỗi"
- },
- "column-auto-increment-must-integer": {
- "title": "Bắt buộc sử dụng kiểu dữ liệu \"INTEGER\" cho các cột tự tăng",
- "description": "Cột tự tăng của MySQL thường được sử dụng làm khóa chính độc lập với nghiệp vụ. Sử dụng kiểu số nguyên chiếm ít không gian lưu trữ hơn và làm cho cấu trúc chỉ mục khóa chính gọn hơn, mang lại hiệu suất truy vấn và DML tốt hơn. Mức độ lỗi gợi ý: Lỗi"
- },
- "column-auto-increment-must-unsigned": {
- "title": "Bắt buộc sử dụng kiểu dữ liệu \"UNSIGNED\" cho các cột tự tăng",
- "description": "Kiểu không dấu không lưu trữ số âm và phạm vi giá trị có thể được lưu trữ bởi cùng một kiểu được nhân đôi, có thể tránh tràn cột tự tăng. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "column-comment": {
- "title": "Quy ước bình luận cột",
- "description": "Thêm bình luận vào cột là một phương pháp phát triển tốt, nhưng bình luận quá dài có thể làm giảm khả năng đọc của lược đồ. Mức độ lỗi gợi ý: Cảnh báo",
+ "NAMING_INDEX_UK": {
+ "title": "Bắt buộc định dạng đặt tên khóa duy nhất",
+ "description": "Tên được phép để trống và được đặt tên bởi cơ sở dữ liệu. Nếu không để trống, định dạng mặc định là \"uk_<tên bảng>_<tổ hợp tên cột khóa duy nhất>\", không quá 63 ký tự, chẳng hạn như \"uk_my_table_id_name\". Mức độ lỗi gợi ý: Cảnh báo",
"component": {
- "required": {
- "title": "Yêu cầu bình luận"
- },
- "requiredClassification": {
- "title": "Yêu cầu phân loại",
- "tooltip": "Bình luận phải tuân theo định dạng {'{'}id phân loại{'}'}-{'{'}bình luận{'}'}."
+ "format": {
+ "title": "Định dạng tên khóa duy nhất",
+ "template": {
+ "table": "Tên bảng",
+ "column_list": "Tên cột chỉ mục, được nối bằng dấu gạch dưới (_)"
+ }
},
"maxLength": {
- "title": "Độ dài tối đa"
- }
- }
- },
- "column-maximum-character-length": {
- "title": "Hạn chế độ dài của kiểu dữ liệu \"CHAR\"",
- "description": "\"CHAR\" là một loại có độ dài cố định. Ví dụ: cột CHAR(20) sẽ chiếm 20 khoảng trống ký tự ngay cả khi chỉ có một ký tự được lưu trữ, gây lãng phí. Khi chuỗi quá dài và độ dài không cố định, hãy xem xét sử dụng VARCHAR cho MySQL và sử dụng TEXT cho PostgreSQL. Mức độ lỗi gợi ý: Lỗi",
- "component": {
- "number": {
- "title": "Độ dài tối đa"
- }
- }
- },
- "column-maximum-varchar-length": {
- "title": "Hạn chế độ dài của kiểu dữ liệu \"VARCHAR\"",
- "description": "",
- "component": {
- "number": {
- "title": "Độ dài tối đa"
+ "title": "Giới hạn độ dài"
}
}
},
- "column-auto-increment-initial-value": {
- "title": "Hạn chế giá trị ban đầu của cột tự tăng",
- "description": "dựa trên các yêu cầu quản lý để giới hạn giá trị ban đầu của cột tự tăng. Mức độ lỗi gợi ý: Cảnh báo",
+ "NAMING_TABLE": {
+ "title": "Bắt buộc định dạng đặt tên bảng",
+ "description": "Định dạng mặc định là tất cả các chữ cái viết thường, được phân tách bằng dấu gạch dưới giữa các từ và không quá 63 ký tự, chẳng hạn như \"abc\" và \"abc_def\". Mức độ lỗi gợi ý: Cảnh báo",
"component": {
- "number": {
- "title": "Giá trị ban đầu"
+ "format": {
+ "title": "Định dạng tên bảng (biểu thức chính quy)"
+ },
+ "maxLength": {
+ "title": "Giới hạn độ dài"
}
}
},
- "column-current-time-count-limit": {
- "title": "Hạn chế số lượng cột trong bảng lấy thời gian hệ thống",
- "description": "Chỉ các cột ghi lại thời gian tạo bản ghi với \"DEFAULT NOW()\" và ghi lại thời gian cập nhật bản ghi với \"DEFAULT NOW() ON UPDATE\" cần gọi hàm để lấy thời gian hệ thống. Việc ghi lại thời gian hệ thống trong các cột khác là vô nghĩa và sẽ làm tăng chi phí tài nguyên. Mức độ lỗi gợi ý: Lỗi"
- },
- "column-require-default": {
- "title": "Bắt buộc đặt giá trị mặc định trên các cột",
- "description": "Đặt giá trị mặc định thỏa mãn logic nghiệp vụ có thể cải thiện hiệu quả chất lượng dữ liệu của quy trình phân tích xuôi dòng. Quy tắc này không kiểm tra các loại \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\". Mức độ lỗi gợi ý: Cảnh báo"
- },
- "column-default-disallow-volatile": {
- "title": "Không cho phép đặt giá trị mặc định không ổn định trên các cột",
- "description": "Các hàm không ổn định (ví dụ: clock_timestamp()) cập nhật từng hàng với giá trị tại thời điểm thực hiện ALTER TABLE ADD COLUMN, có khả năng gây ra các bản cập nhật kéo dài."
- },
- "column-require-charset": {
- "title": "Yêu cầu charset cho cột kiểu text",
- "description": "Charset của các cột có kiểu dữ liệu text phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "column-require-collation": {
- "title": "Yêu cầu đối chiếu (collation) cho các cột kiểu text",
- "description": "Đối chiếu của các cột có kiểu dữ liệu text phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "statement-select-no-select-all": {
- "title": "Cấm sử dụng \"SELECT *\"",
- "description": "SELECT * để tìm nạp toàn bộ dữ liệu hàng có thể gây ra chi phí tài nguyên không cần thiết và cũng có thể gây ra kết quả không mong muốn trong các ứng dụng khi bảng thêm hoặc xóa cột. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-where-require-select": {
- "title": "Bắt buộc phải có điều kiện \"WHERE\" trong câu lệnh SELECT",
- "description": "Các truy vấn không có mệnh đề WHERE có thể gây ra chi phí tài nguyên rất lớn không cần thiết. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-where-require-update-delete": {
- "title": "Bắt buộc phải có điều kiện \"WHERE\" trong câu lệnh UPDATE/DELETE",
- "description": "DML không có mệnh đề WHERE có thể gây ra mất dữ liệu lớn do tai nạn. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-where-no-leading-wildcard-like": {
- "title": "Cấm sử dụng ký tự đại diện đứng đầu trong điều kiện lọc",
- "description": "Khi sử dụng ký tự đại diện đứng đầu, chẳng hạn như \"LIKE '%ABC'\", trình tối ưu hóa cơ sở dữ liệu không thể sử dụng quét chỉ mục nhanh và quay trở lại quét toàn bộ bảng hoặc quét toàn bộ chỉ mục, điều này có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-disallow-on-del-cascade": {
- "title": "Cấm sử dụng tùy chọn CASCADE cho mệnh đề ON DELETE",
- "description": "Tùy chọn \"CASCADE\" trong 'ON DELETE' có thể khiến một số lượng lớn các đối tượng phụ thuộc bị xóa hoặc sửa đổi, điều này có thể gây ra kết quả không mong muốn. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-disallow-rm-tbl-cascade": {
- "title": "Cấm sử dụng CASCADE khi xóa bảng",
- "description": "Sử dụng tùy chọn \"CASCADE\" khi xóa bảng có thể khiến một số lượng lớn các đối tượng phụ thuộc bị xóa hoặc sửa đổi, điều này có thể gây ra kết quả không mong muốn. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-disallow-commit": {
- "title": "Cấm câu lệnh \"COMMIT\" rõ ràng",
- "description": "Trong một số trường hợp, nhiều câu lệnh được yêu cầu phải được đưa vào một giao dịch do hệ thống cam kết, để nhanh chóng chạy lại trong trường hợp lỗi một phần. Do đó, \"COMMIT\" rõ ràng không được phép. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "statement-disallow-limit": {
- "title": "Cấm sử dụng mệnh đề \"LIMIT\" trong câu lệnh DML",
- "description": "Nếu LIMIT được sử dụng trong câu lệnh DML mà không có mệnh đề ORDER BY, thứ tự các hàng bị ảnh hưởng không cố định, điều này có thể gây ra sự không nhất quán dữ liệu giữa cơ sở dữ liệu chính và cơ sở dữ liệu sao chép trong một số chế độ sao chép. Mức độ lỗi gợi ý: Lỗi"
- },
- "statement-disallow-order-by": {
- "title": "Cấm sử dụng mệnh đề \"ORDER BY\" trong câu lệnh \"UPDATE\" và \"DELETE\"",
- "description": "Các hoạt động sắp xếp cực kỳ tốn tài nguyên, vì vậy đối với các hoạt động cập nhật và xóa, bạn nên sử dụng một điều kiện lọc xác định càng nhiều càng tốt thay vì sử dụng ORDER BY và LIMIT. Mức độ lỗi gợi ý: Lỗi"
+ "NAMING_TABLE_NO_KEYWORD": {
+ "title": "Cấm sử dụng từ khóa làm tên bảng",
+ "description": ""
},
- "statement-merge-alter-table": {
- "title": "Cấm phát hành nhiều thay đổi độc lập trên cùng một bảng",
- "description": "Mỗi thay đổi đối với một bảng có thể gây ra khóa cấp bảng và tiêu tốn một lượng lớn tài nguyên. Nếu có nhiều thay đổi đối với cùng một bảng, chúng nên được hợp nhất thành một câu lệnh thay đổi duy nhất. Mức độ lỗi gợi ý: Lỗi"
+ "SCHEMA_BACKWARD_COMPATIBILITY": {
+ "title": "Kiểm tra khả năng tương thích ngược của ứng dụng",
+ "description": "Một số thay đổi có thể ảnh hưởng đến các ứng dụng đang chạy, chẳng hạn như sửa đổi tên của đối tượng cơ sở dữ liệu, thêm ràng buộc mới, v.v. Quy tắc này có thể tránh những thay đổi bất cẩn dẫn đến lỗi ứng dụng hiện có. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-insert-must-specify-column": {
- "title": "Bắt buộc chỉ định tên cột trong câu lệnh \"INSERT\"",
- "description": "Câu lệnh \"INSERT INTO table VALUES (...)\" không liệt kê rõ ràng tên cột. Khi thứ tự cột thay đổi hoặc cột được thêm hoặc bớt, câu lệnh có thể thất bại hoặc tạo ra dữ liệu không mong muốn. Mức độ lỗi gợi ý: Lỗi"
+ "STATEMENT_ADD_CHECK_NOT_VALID": {
+ "title": "Bắt buộc bao gồm tùy chọn \"NOT VALID\" khi thêm ràng buộc \"CHECK\"",
+ "description": "Thêm ràng buộc CHECK cần xác minh dữ liệu hiện có và yêu cầu khóa bảng ACCESS EXCLUSIVE. Điều này chặn đọc và ghi, có thể gây gián đoạn kinh doanh. Bạn nên thêm tùy chọn \"NOT VALID\" để xác thực dữ liệu mới và xác thực thủ công dữ liệu hiện có sau khi thay đổi hoàn tất. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-insert-disallow-order-by-rand": {
- "title": "Cấm sử dụng \"ORDER BY rand()\" trong câu lệnh \"INSERT\"",
- "description": "Sắp xếp ngẫu nhiên dữ liệu sẽ được chèn là vô nghĩa và sẽ chỉ tiêu tốn tài nguyên không cần thiết. Mức độ lỗi gợi ý: Lỗi"
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": {
+ "title": "Kiểm tra không có vị trí trong mệnh đề ADD COLUMN",
+ "description": "Trong một số trường hợp, sử dụng FIRST/AFTER để thêm cột sẽ gây ra việc tổ chức lại dữ liệu (ghi lại tất cả dữ liệu). Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-insert-row-limit": {
- "title": "Hạn chế số lượng hàng được chèn tối đa",
- "description": "Tiết lộ số lượng hàng sẽ được chèn có thể giúp xác định xem câu lệnh có đáp ứng mong đợi của doanh nghiệp hay không. Mức độ lỗi gợi ý: Cảnh báo",
- "component": {
- "number": {
- "title": "Số lượng chèn tối đa"
- }
- }
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": {
+ "title": "Bắt buộc bao gồm tùy chọn \"NOT VALID\" khi thêm khóa ngoại",
+ "description": "Thêm khóa ngoại cần xác minh dữ liệu hiện có và yêu cầu khóa bảng SHARE ROW EXCLUSIVE. Điều này chặn ghi, có thể gây gián đoạn kinh doanh. Bạn nên thêm tùy chọn \"NOT VALID\" để xác thực dữ liệu mới và xác thực thủ công dữ liệu hiện có sau khi thay đổi hoàn tất. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-affected-row-limit": {
+ "STATEMENT_AFFECTED_ROW_LIMIT": {
"title": "Hạn chế số lượng hàng được cập nhật hoặc xóa tối đa (ước tính).",
"description": "Tiết lộ số lượng hàng sẽ được cập nhật hoặc xóa có thể giúp xác định xem câu lệnh có đáp ứng mong đợi của doanh nghiệp hay không. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
@@ -440,87 +379,102 @@
}
}
},
- "statement-dml-dry-run": {
- "title": "Xác thực khả năng thực thi của câu lệnh DML",
- "description": "Khi cú pháp chính xác, nhưng tên bảng không chính xác hoặc không đủ quyền, nó có thể được phát hiện bằng cách chạy thử trước khi thực hiện thực tế. Mức độ lỗi gợi ý: Cảnh báo"
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": {
+ "title": "Kiểm tra xem câu lệnh Set Role ở đầu",
+ "description": "Không đặt đúng câu lệnh vai trò ở đầu phiên có thể dẫn đến truy cập trái phép hoặc gán quyền không phù hợp, có khả năng ảnh hưởng đến bảo mật và tính toàn vẹn dữ liệu. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": {
+ "title": "Cấm tạo đối tượng mà không chỉ định lược đồ",
+ "description": "Nếu lược đồ không được chỉ định, đối tượng sẽ được tạo trong lược đồ mặc định, điều này có thể gây ra kết quả không mong muốn."
},
- "statement-disallow-add-column-with-default": {
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": {
"title": "Hạn chế thêm cột có giá trị mặc định vào bảng",
"description": "Trước PostgreSQL 11, việc thêm một cột có giá trị mặc định gây ra khóa bảng và không thể đọc và ghi, điều này có thể gây gián đoạn kinh doanh. Trong PostgreSQL 11 trở lên, vấn đề này đã được tối ưu hóa và không cần phải chú ý đến quy tắc này. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-add-check-not-valid": {
- "title": "Bắt buộc bao gồm tùy chọn \"NOT VALID\" khi thêm ràng buộc \"CHECK\"",
- "description": "Thêm ràng buộc CHECK cần xác minh dữ liệu hiện có và yêu cầu khóa bảng ACCESS EXCLUSIVE. Điều này chặn đọc và ghi, có thể gây gián đoạn kinh doanh. Bạn nên thêm tùy chọn \"NOT VALID\" để xác thực dữ liệu mới và xác thực thủ công dữ liệu hiện có sau khi thay đổi hoàn tất. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "statement-disallow-add-not-null": {
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": {
"title": "Hạn chế thêm ràng buộc \"NOT NULL\" vào các cột hiện có",
"description": "Thêm ràng buộc NOT NULL với giá trị mặc định trước PostgreSQL 11 hoặc thêm ràng buộc NOT NULL mà không có giá trị mặc định yêu cầu xác minh dữ liệu hiện có. Điều này chặn đọc và ghi, có thể gây gián đoạn kinh doanh. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-select-full-table-scan": {
- "title": "Kiểm tra quét toàn bộ bảng cho các truy vấn",
- "description": "Quét toàn bộ bảng là một hoạt động tốn nhiều tài nguyên và có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi"
+ "STATEMENT_DISALLOW_COMMIT": {
+ "title": "Cấm câu lệnh \"COMMIT\" rõ ràng",
+ "description": "Trong một số trường hợp, nhiều câu lệnh được yêu cầu phải được đưa vào một giao dịch do hệ thống cam kết, để nhanh chóng chạy lại trong trường hợp lỗi một phần. Do đó, \"COMMIT\" rõ ràng không được phép. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-create-specify-schema": {
- "title": "Cấm tạo đối tượng mà không chỉ định lược đồ",
- "description": "Nếu lược đồ không được chỉ định, đối tượng sẽ được tạo trong lược đồ mặc định, điều này có thể gây ra kết quả không mong muốn."
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": {
+ "title": "Không cho phép truy vấn chéo cơ sở dữ liệu",
+ "description": "Truy vấn chéo cơ sở dữ liệu làm tăng sự kết hợp hệ thống và có thể dẫn đến các vấn đề về hiệu quả. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-check-set-role-variable": {
- "title": "Kiểm tra xem câu lệnh Set Role ở đầu",
- "description": "Không đặt đúng câu lệnh vai trò ở đầu phiên có thể dẫn đến truy cập trái phép hoặc gán quyền không phù hợp, có khả năng ảnh hưởng đến bảo mật và tính toàn vẹn dữ liệu. Mức độ lỗi gợi ý: Cảnh báo"
+ "STATEMENT_DISALLOW_LIMIT": {
+ "title": "Cấm sử dụng mệnh đề \"LIMIT\" trong câu lệnh DML",
+ "description": "Nếu LIMIT được sử dụng trong câu lệnh DML mà không có mệnh đề ORDER BY, thứ tự các hàng bị ảnh hưởng không cố định, điều này có thể gây ra sự không nhất quán dữ liệu giữa cơ sở dữ liệu chính và cơ sở dữ liệu sao chép trong một số chế độ sao chép. Mức độ lỗi gợi ý: Lỗi"
},
- "statement-disallow-using-temporary": {
- "title": "Cấm sử dụng bảng tạm",
- "description": "Bảng tạm không được khuyến nghị sử dụng trong môi trường sản xuất. Chúng có thể gây ra tranh chấp tài nguyên và các vấn đề hiệu suất. Mức độ lỗi gợi ý: Cảnh báo"
+ "STATEMENT_DISALLOW_OFFLINE_DDL": {
+ "title": "Không cho phép DDL ngoại tuyến",
+ "description": "Để ngăn các thay đổi cơ sở dữ liệu ảnh hưởng đến doanh nghiệp của bạn, hãy tránh sử dụng DDL ngoại tuyến."
+ },
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": {
+ "title": "Cấm sử dụng tùy chọn CASCADE cho mệnh đề ON DELETE",
+ "description": "Tùy chọn \"CASCADE\" trong 'ON DELETE' có thể khiến một số lượng lớn các đối tượng phụ thuộc bị xóa hoặc sửa đổi, điều này có thể gây ra kết quả không mong muốn. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "STATEMENT_DISALLOW_ORDER_BY": {
+ "title": "Cấm sử dụng mệnh đề \"ORDER BY\" trong câu lệnh \"UPDATE\" và \"DELETE\"",
+ "description": "Các hoạt động sắp xếp cực kỳ tốn tài nguyên, vì vậy đối với các hoạt động cập nhật và xóa, bạn nên sử dụng một điều kiện lọc xác định càng nhiều càng tốt thay vì sử dụng ORDER BY và LIMIT. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": {
+ "title": "Cấm sử dụng CASCADE khi xóa bảng",
+ "description": "Sử dụng tùy chọn \"CASCADE\" khi xóa bảng có thể khiến một số lượng lớn các đối tượng phụ thuộc bị xóa hoặc sửa đổi, điều này có thể gây ra kết quả không mong muốn. Mức độ lỗi gợi ý: Lỗi"
},
- "statement-disallow-using-filesort": {
+ "STATEMENT_DISALLOW_USING_FILESORT": {
"title": "Cấm sử dụng filesort",
"description": "Filesort là một hoạt động tốn nhiều tài nguyên và có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-where-no-equal-null": {
- "title": "Cấm sử dụng so sánh bằng NULL trong mệnh đề WHERE",
- "description": "Kết quả của so sánh bằng NULL luôn là NULL, điều này có thể gây ra kết quả không mong muốn. Mức độ lỗi gợi ý: Cảnh báo"
+ "STATEMENT_DISALLOW_USING_TEMPORARY": {
+ "title": "Cấm sử dụng bảng tạm",
+ "description": "Bảng tạm không được khuyến nghị sử dụng trong môi trường sản xuất. Chúng có thể gây ra tranh chấp tài nguyên và các vấn đề hiệu suất. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-where-disallow-functions-and-calculations": {
- "title": "Không áp dụng hàm hoặc thực hiện tính toán trên các trường được lập chỉ mục trong mệnh đề WHERE",
- "description": "Nếu bạn áp dụng một hàm hoặc thực hiện một phép tính trên trường được lập chỉ mục, cơ sở dữ liệu không thể sử dụng chỉ mục và phải quét toàn bộ bảng thay thế."
+ "STATEMENT_DML_DRY_RUN": {
+ "title": "Xác thực khả năng thực thi của câu lệnh DML",
+ "description": "Khi cú pháp chính xác, nhưng tên bảng không chính xác hoặc không đủ quyền, nó có thể được phát hiện bằng cách chạy thử trước khi thực hiện thực tế. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-query-minimum-plan-level": {
- "title": "Hạn chế mức tối đa của phương thức truy cập truy vấn",
- "description": "Tối ưu hóa hiệu suất SQL cố gắng truy cập không đổi (const), nhắm mục tiêu mức tham chiếu (ref) làm đường cơ sở, với hiệu suất chấp nhận được ở mức phạm vi.",
- "component": {
- "level": {
- "title": "Mức tối đa"
- }
- }
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": {
+ "title": "Cấm sử dụng \"ORDER BY rand()\" trong câu lệnh \"INSERT\"",
+ "description": "Sắp xếp ngẫu nhiên dữ liệu sẽ được chèn là vô nghĩa và sẽ chỉ tiêu tốn tài nguyên không cần thiết. Mức độ lỗi gợi ý: Lỗi"
},
- "statement-where-maximum-logical-operator-count": {
- "title": "Hạn chế số lượng toán tử logic trong mệnh đề WHERE",
- "description": "Điều này ngăn chặn sự suy giảm hiệu suất do so sánh quá nhiều và giới hạn tài nguyên.",
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": {
+ "title": "Bắt buộc chỉ định tên cột trong câu lệnh \"INSERT\"",
+ "description": "Câu lệnh \"INSERT INTO table VALUES (...)\" không liệt kê rõ ràng tên cột. Khi thứ tự cột thay đổi hoặc cột được thêm hoặc bớt, câu lệnh có thể thất bại hoặc tạo ra dữ liệu không mong muốn. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "STATEMENT_INSERT_ROW_LIMIT": {
+ "title": "Hạn chế số lượng hàng được chèn tối đa",
+ "description": "Tiết lộ số lượng hàng sẽ được chèn có thể giúp xác định xem câu lệnh có đáp ứng mong đợi của doanh nghiệp hay không. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
"number": {
- "title": "Số lượng tối đa"
+ "title": "Số lượng chèn tối đa"
}
}
},
- "statement-maximum-limit-value": {
- "title": "Hạn chế số lượng tối đa của mệnh đề LIMIT",
- "description": "Giới hạn số lượng hàng thông qua LIMIT đảm bảo cơ sở dữ liệu xử lý các phần có thể quản lý được, cải thiện tốc độ thực hiện truy vấn. Giá trị LIMIT được giới hạn ngăn chặn việc sử dụng bộ nhớ quá mức, bảo vệ sự ổn định tổng thể của hệ thống và ngăn chặn sự suy giảm hiệu suất.",
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {
+ "title": "Các trường được nối phải có kiểu dữ liệu, bộ ký tự giống hệt nhau",
+ "description": "Nếu kiểu dữ liệu, bộ ký tự của các cột nối không giống hệt nhau, cơ sở dữ liệu có thể không xác định chính xác các hàng phù hợp, dẫn đến kết quả không chính xác hoặc không đầy đủ."
+ },
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {
+ "title": "Hạn chế số lượng bảng được nối",
+ "description": "Bạn càng nối nhiều bảng, truy vấn càng trở nên phức tạp và thời gian thực hiện càng lâu. Nói chung, tốt nhất là giữ số lượng phép nối ở mức tối thiểu.",
"component": {
"number": {
"title": "Giá trị tối đa"
}
}
},
- "statement-maximum-join-table-count": {
- "title": "Hạn chế số lượng bảng được nối",
- "description": "Bạn càng nối nhiều bảng, truy vấn càng trở nên phức tạp và thời gian thực hiện càng lâu. Nói chung, tốt nhất là giữ số lượng phép nối ở mức tối thiểu.",
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": {
+ "title": "Hạn chế số lượng tối đa của mệnh đề LIMIT",
+ "description": "Giới hạn số lượng hàng thông qua LIMIT đảm bảo cơ sở dữ liệu xử lý các phần có thể quản lý được, cải thiện tốc độ thực hiện truy vấn. Giá trị LIMIT được giới hạn ngăn chặn việc sử dụng bộ nhớ quá mức, bảo vệ sự ổn định tổng thể của hệ thống và ngăn chặn sự suy giảm hiệu suất.",
"component": {
"number": {
"title": "Giá trị tối đa"
}
}
},
- "statement-maximum-statements-in-transaction": {
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {
"title": "Hạn chế số lượng câu lệnh trong một giao dịch",
"description": "Các giao dịch lớn có thể ảnh hưởng đáng kể đến hiệu suất cơ sở dữ liệu. Nếu một số lượng lớn các câu lệnh có liên quan và một câu lệnh thất bại, việc khôi phục toàn bộ giao dịch trở nên phức tạp. Giới hạn số lượng câu lệnh giảm thiểu thiệt hại tiềm ẩn do một lỗi duy nhất gây ra và đơn giản hóa các quy trình khôi phục.",
"component": {
@@ -529,31 +483,7 @@
}
}
},
- "statement-join-strict-column-attrs": {
- "title": "Các trường được nối phải có kiểu dữ liệu, bộ ký tự giống hệt nhau",
- "description": "Nếu kiểu dữ liệu, bộ ký tự của các cột nối không giống hệt nhau, cơ sở dữ liệu có thể không xác định chính xác các hàng phù hợp, dẫn đến kết quả không chính xác hoặc không đầy đủ."
- },
- "statement-prior-backup-check": {
- "title": "Kiểm tra sao lưu trước khi thay đổi dữ liệu",
- "description": "Quy tắc này sẽ kiểm tra xem có thể tạo bản sao lưu trước khi thay đổi dữ liệu hay không. Để biết thêm chi tiết, bao gồm cơ sở dữ liệu đích sao lưu tồn tại và không cho phép câu lệnh DDL."
- },
- "statement-add-column-without-position": {
- "title": "Kiểm tra không có vị trí trong mệnh đề ADD COLUMN",
- "description": "Trong một số trường hợp, sử dụng FIRST/AFTER để thêm cột sẽ gây ra việc tổ chức lại dữ liệu (ghi lại tất cả dữ liệu). Mức độ lỗi gợi ý: Cảnh báo"
- },
- "statement-disallow-offline-ddl": {
- "title": "Không cho phép DDL ngoại tuyến",
- "description": "Để ngăn các thay đổi cơ sở dữ liệu ảnh hưởng đến doanh nghiệp của bạn, hãy tránh sử dụng DDL ngoại tuyến."
- },
- "statement-disallow-cross-db-queries": {
- "title": "Không cho phép truy vấn chéo cơ sở dữ liệu",
- "description": "Truy vấn chéo cơ sở dữ liệu làm tăng sự kết hợp hệ thống và có thể dẫn đến các vấn đề về hiệu quả. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "schema-backward-compatibility": {
- "title": "Kiểm tra khả năng tương thích ngược của ứng dụng",
- "description": "Một số thay đổi có thể ảnh hưởng đến các ứng dụng đang chạy, chẳng hạn như sửa đổi tên của đối tượng cơ sở dữ liệu, thêm ràng buộc mới, v.v. Quy tắc này có thể tránh những thay đổi bất cẩn dẫn đến lỗi ứng dụng hiện có. Mức độ lỗi gợi ý: Cảnh báo"
- },
- "statement-max-execution-time": {
+ "STATEMENT_MAX_EXECUTION_TIME": {
"title": "Bắt buộc đặt tham số thời gian thực hiện tối đa",
"description": "Đặt thời gian thực hiện tối đa cho các câu lệnh SQL. Nếu thời gian thực hiện vượt quá giới hạn, câu lệnh sẽ bị chấm dứt. Mức độ lỗi gợi ý: Cảnh báo",
"mysql": {
@@ -565,75 +495,73 @@
"description": "Đặt tham số MAX_STATEMENT_TIME trong tập lệnh thay đổi để kiểm soát rõ ràng thời gian thực hiện tối đa của câu lệnh. Mức độ lỗi gợi ý: Cảnh báo"
}
},
- "statement-require-algorithm-option": {
+ "STATEMENT_MERGE_ALTER_TABLE": {
+ "title": "Cấm phát hành nhiều thay đổi độc lập trên cùng một bảng",
+ "description": "Mỗi thay đổi đối với một bảng có thể gây ra khóa cấp bảng và tiêu tốn một lượng lớn tài nguyên. Nếu có nhiều thay đổi đối với cùng một bảng, chúng nên được hợp nhất thành một câu lệnh thay đổi duy nhất. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "STATEMENT_NON_TRANSACTIONAL": {
+ "title": "Phát hiện và báo cáo các câu lệnh không giao dịch",
+ "description": ""
+ },
+ "STATEMENT_OBJECT_OWNER_CHECK": {
+ "title": "Kiểm tra chủ sở hữu đối tượng",
+ "description": "Quy tắc này kiểm tra xem chủ sở hữu đối tượng cho DDL có giống với người dùng hiện tại không."
+ },
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {
+ "title": "Hạn chế mức tối đa của phương thức truy cập truy vấn",
+ "description": "Tối ưu hóa hiệu suất SQL cố gắng truy cập không đổi (const), nhắm mục tiêu mức tham chiếu (ref) làm đường cơ sở, với hiệu suất chấp nhận được ở mức phạm vi.",
+ "component": {
+ "level": {
+ "title": "Mức tối đa"
+ }
+ }
+ },
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": {
"title": "Yêu cầu chỉ định tùy chọn ALGORITHM trong câu lệnh ALTER TABLE",
"description": "Chỉ định tùy chọn ALGORITHM trong câu lệnh ALTER TABLE đảm bảo kiểm soát nhiều hơn về cách áp dụng các thay đổi bảng, giảm thiểu các gián đoạn tiềm ẩn bằng cách tránh sao chép hoặc khóa toàn bộ bảng. Nó giúp tối ưu hóa hiệu suất và giảm thời gian chết trong quá trình sửa đổi lược đồ. Mức độ lỗi đề xuất: Cảnh báo."
},
- "statement-require-lock-option": {
+ "STATEMENT_REQUIRE_LOCK_OPTION": {
"title": "Yêu cầu chỉ định tùy chọn LOCK trong câu lệnh ALTER TABLE",
"description": "Tùy chọn LOCK trong câu lệnh ALTER TABLE cho phép bạn kiểm soát mức độ khóa trong quá trình thay đổi lược đồ, giúp ngăn chặn khóa bảng không cần thiết và đảm bảo tính đồng thời tốt hơn. Sử dụng tùy chọn này đúng cách có thể giảm đáng kể tác động của các hoạt động DDL đối với các truy vấn đang hoạt động. Mức độ lỗi đề xuất: Cảnh báo."
},
- "database-drop-empty-database": {
- "title": "Cấm xóa cơ sở dữ liệu không trống",
- "description": "Chỉ được phép xóa khi không có bảng nào trong cơ sở dữ liệu, điều này có thể tránh được việc xóa do nhầm lẫn. Mức độ lỗi gợi ý: Lỗi"
- },
- "index-no-duplicate-column": {
- "title": "Cấm chỉ mục chứa các cột trùng lặp",
- "description": "Tạo một chỉ mục với các cột trùng lặp sẽ dẫn đến lỗi. Mức độ lỗi gợi ý: Lỗi"
- },
- "index-type-no-blob": {
- "title": "Cấm tạo chỉ mục trên các cột loại \"BLOB\" và \"TEXT\"",
- "description": "Loại \"BLOB\" thường được sử dụng để lưu trữ dữ liệu nhị phân và không nên được sử dụng làm điều kiện truy vấn. Nếu một chỉ mục được tạo trên loại cột này do nhầm lẫn, nó sẽ tiêu tốn rất nhiều tài nguyên và gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi"
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": {
+ "title": "Kiểm tra quét toàn bộ bảng cho các truy vấn",
+ "description": "Quét toàn bộ bảng là một hoạt động tốn nhiều tài nguyên và có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi"
},
- "index-pk-type-limit": {
- "title": "Giới hạn loại khóa chính",
- "description": "Bắt buộc loại khóa chính là INT hoặc BIGINT."
+ "STATEMENT_SELECT_NO_SELECT_ALL": {
+ "title": "Cấm sử dụng \"SELECT *\"",
+ "description": "SELECT * để tìm nạp toàn bộ dữ liệu hàng có thể gây ra chi phí tài nguyên không cần thiết và cũng có thể gây ra kết quả không mong muốn trong các ứng dụng khi bảng thêm hoặc xóa cột. Mức độ lỗi gợi ý: Lỗi"
},
- "index-key-number-limit": {
- "title": "Hạn chế số lượng cột trong một chỉ mục duy nhất",
- "description": "Một chỉ mục tổng hợp có hơn 5 cột không cải thiện đáng kể hiệu suất truy vấn, nhưng nó chiếm rất nhiều không gian và làm giảm hiệu suất DML. Mức độ lỗi gợi ý: Cảnh báo",
- "component": {
- "number": {
- "title": "Số lượng cột tối đa"
- }
- }
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": {
+ "title": "Không áp dụng hàm hoặc thực hiện tính toán trên các trường được lập chỉ mục trong mệnh đề WHERE",
+ "description": "Nếu bạn áp dụng một hàm hoặc thực hiện một phép tính trên trường được lập chỉ mục, cơ sở dữ liệu không thể sử dụng chỉ mục và phải quét toàn bộ bảng thay thế."
},
- "index-total-number-limit": {
- "title": "Hạn chế số lượng chỉ mục trên một bảng duy nhất",
- "description": "Mặc dù các chỉ mục có thể cải thiện hiệu suất truy vấn, chúng cũng chiếm rất nhiều không gian và làm giảm hiệu suất DML. Do đó, không nên tạo quá 5 chỉ mục trong một bảng. Mức độ lỗi gợi ý: Cảnh báo",
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": {
+ "title": "Hạn chế số lượng toán tử logic trong mệnh đề WHERE",
+ "description": "Điều này ngăn chặn sự suy giảm hiệu suất do so sánh quá nhiều và giới hạn tài nguyên.",
"component": {
"number": {
- "title": "Số lượng chỉ mục tối đa"
+ "title": "Số lượng tối đa"
}
}
},
- "index-primary-key-type-allowlist": {
- "title": "Danh sách loại khóa chính được phép",
- "description": "Loại khóa chính thích hợp có thể tối ưu hóa cấu trúc lưu trữ, giảm mức sử dụng không gian và có lợi cho hiệu suất chèn và truy vấn. Mức độ lỗi gợi ý: Cảnh báo",
- "component": {
- "list": {
- "title": "Danh sách cho phép"
- }
- }
+ "STATEMENT_WHERE_NO_EQUAL_NULL": {
+ "title": "Cấm sử dụng so sánh bằng NULL trong mệnh đề WHERE",
+ "description": "Kết quả của so sánh bằng NULL luôn là NULL, điều này có thể gây ra kết quả không mong muốn. Mức độ lỗi gợi ý: Cảnh báo"
},
- "index-create-concurrently": {
- "title": "Bắt buộc tạo chỉ mục đồng thời",
- "description": "Trong PostgreSQL 11 trở lên, sử dụng câu lệnh tiêu chuẩn để tạo chỉ mục sẽ gây ra khóa bảng và không thể ghi. Sử dụng chế độ \"CONCURRENTLY\" có thể tránh được vấn đề này. Mức độ lỗi gợi ý: Cảnh báo"
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": {
+ "title": "Cấm sử dụng ký tự đại diện đứng đầu trong điều kiện lọc",
+ "description": "Khi sử dụng ký tự đại diện đứng đầu, chẳng hạn như \"LIKE '%ABC'\", trình tối ưu hóa cơ sở dữ liệu không thể sử dụng quét chỉ mục nhanh và quay trở lại quét toàn bộ bảng hoặc quét toàn bộ chỉ mục, điều này có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi"
},
- "index-type-allow-list": {
- "title": "Danh sách loại chỉ mục được phép",
- "description": "Các loại chỉ mục khác nhau có các đặc điểm hiệu suất khác nhau. Ví dụ: chỉ mục B-tree phù hợp cho các truy vấn phạm vi, trong khi chỉ mục băm phù hợp cho các truy vấn bằng. Mức độ lỗi gợi ý: Cảnh báo",
- "component": {
- "list": {
- "title": "Danh sách cho phép"
- }
- }
+ "STATEMENT_WHERE_REQUIRE_SELECT": {
+ "title": "Bắt buộc phải có điều kiện \"WHERE\" trong câu lệnh SELECT",
+ "description": "Các truy vấn không có mệnh đề WHERE có thể gây ra chi phí tài nguyên rất lớn không cần thiết. Mức độ lỗi gợi ý: Lỗi"
},
- "index-not-redundant": {
- "title": "Không cho phép chỉ mục dư thừa",
- "description": "Chỉ mục dư thừa có thể dẫn đến mất hiệu suất và chiếm thêm dung lượng. Ví dụ: chỉ mục trên các cột (c1, c2) sẽ được coi là chỉ mục dư thừa nếu đã có chỉ mục trên cột (c1). Mức độ lỗi gợi ý: Cảnh báo"
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": {
+ "title": "Bắt buộc phải có điều kiện \"WHERE\" trong câu lệnh UPDATE/DELETE",
+ "description": "DML không có mệnh đề WHERE có thể gây ra mất dữ liệu lớn do tai nạn. Mức độ lỗi gợi ý: Lỗi"
},
- "system-charset-allowlist": {
+ "SYSTEM_CHARSET_ALLOWLIST": {
"title": "Danh sách Charset được phép",
"description": "Bộ ký tự xác định những ký tự nào có thể được lưu trữ trong bảng. Sử dụng bộ ký tự sai có thể dẫn đến một số ký tự trong ứng dụng không thể được lưu trữ và hiển thị chính xác, chẳng hạn như CJK và Emoji. Mức độ lỗi gợi ý: Lỗi",
"component": {
@@ -642,7 +570,7 @@
}
}
},
- "system-collation-allowlist": {
+ "SYSTEM_COLLATION_ALLOWLIST": {
"title": "Danh sách đối chiếu được phép",
"description": "Đối chiếu xác định các quy tắc so sánh và sắp xếp ký tự. Ví dụ: khi sử dụng đối chiếu không phân biệt chữ hoa chữ thường, \"ABC\" và \"abc\" sẽ được coi là cùng một chuỗi trong các truy vấn. Mức độ lỗi gợi ý: Lỗi",
"component": {
@@ -651,7 +579,7 @@
}
}
},
- "system-comment-length": {
+ "SYSTEM_COMMENT_LENGTH": {
"title": "Hạn chế độ dài của bình luận",
"description": "",
"component": {
@@ -660,55 +588,123 @@
}
}
},
- "system-procedure-disallow-create": {
- "title": "Không cho phép tạo thủ tục",
- "description": "Quy tắc này cấm thực hiện các thủ tục trong cơ sở dữ liệu. Các thủ tục hệ thống thường thực hiện các hoạt động quan trọng có thể ảnh hưởng đến tính ổn định và bảo mật của môi trường cơ sở dữ liệu. Bằng cách không cho phép thực hiện chúng, nó giúp ngăn ngừa những thay đổi không mong muốn và các lỗ hổng tiềm ẩn. Mức độ lỗi đề xuất: Cảnh báo"
- },
- "system-event-disallow-create": {
+ "SYSTEM_EVENT_DISALLOW_CREATE": {
"title": "Không cho phép tạo sự kiện",
"description": "Quy tắc này cấm tạo sự kiện trong cơ sở dữ liệu. Các sự kiện hệ thống thường thực hiện các tác vụ tự động có thể ảnh hưởng đến môi trường cơ sở dữ liệu. Bằng cách không cho phép tạo chúng, nó giúp duy trì quyền kiểm soát đối với các hoạt động của cơ sở dữ liệu và ngăn chặn sự gián đoạn tiềm ẩn. Mức độ lỗi đề xuất: Cảnh báo"
},
- "system-view-disallow-create": {
- "title": "Không cho phép tạo khung nhìn",
- "description": "Quy tắc này cấm tạo khung nhìn trong cơ sở dữ liệu. Khung nhìn cung cấp một bản trình bày ảo của dữ liệu có thể đơn giản hóa các truy vấn và tăng cường bảo mật dữ liệu. Bằng cách không cho phép tạo chúng, nó giúp duy trì quyền kiểm soát đối với lược đồ cơ sở dữ liệu và ngăn chặn các rủi ro bảo mật tiềm ẩn. Mức độ lỗi đề xuất: Cảnh báo"
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": {
+ "title": "Cấm sử dụng một số hàm nhất định",
+ "description": "Quy tắc này hạn chế việc sử dụng các hàm cụ thể trong cơ sở dữ liệu. Bằng cách không cho phép sử dụng các hàm này, nó giúp duy trì tính nhất quán và bảo mật dữ liệu. Mức độ lỗi đề xuất: Cảnh báo",
+ "component": {
+ "list": {
+ "title": "Danh sách không cho phép"
+ }
+ }
},
- "system-function-disallow-create": {
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": {
"title": "Không cho phép tạo hàm",
"description": "Quy tắc này cấm tạo các hàm trong cơ sở dữ liệu. Các hàm cung cấp logic có thể sử dụng lại có thể đơn giản hóa các truy vấn và tăng cường tính toàn vẹn dữ liệu. Bằng cách không cho phép tạo chúng, nó giúp duy trì quyền kiểm soát đối với lược đồ cơ sở dữ liệu và ngăn chặn các rủi ro bảo mật tiềm ẩn. Mức độ lỗi đề xuất: Cảnh báo"
},
- "system-function-disallowed-list": {
- "title": "Cấm sử dụng một số hàm nhất định",
- "description": "Quy tắc này hạn chế việc sử dụng các hàm cụ thể trong cơ sở dữ liệu. Bằng cách không cho phép sử dụng các hàm này, nó giúp duy trì tính nhất quán và bảo mật dữ liệu. Mức độ lỗi đề xuất: Cảnh báo",
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": {
+ "title": "Không cho phép tạo thủ tục",
+ "description": "Quy tắc này cấm thực hiện các thủ tục trong cơ sở dữ liệu. Các thủ tục hệ thống thường thực hiện các hoạt động quan trọng có thể ảnh hưởng đến tính ổn định và bảo mật của môi trường cơ sở dữ liệu. Bằng cách không cho phép thực hiện chúng, nó giúp ngăn ngừa những thay đổi không mong muốn và các lỗ hổng tiềm ẩn. Mức độ lỗi đề xuất: Cảnh báo"
+ },
+ "SYSTEM_VIEW_DISALLOW_CREATE": {
+ "title": "Không cho phép tạo khung nhìn",
+ "description": "Quy tắc này cấm tạo khung nhìn trong cơ sở dữ liệu. Khung nhìn cung cấp một bản trình bày ảo của dữ liệu có thể đơn giản hóa các truy vấn và tăng cường bảo mật dữ liệu. Bằng cách không cho phép tạo chúng, nó giúp duy trì quyền kiểm soát đối với lược đồ cơ sở dữ liệu và ngăn chặn các rủi ro bảo mật tiềm ẩn. Mức độ lỗi đề xuất: Cảnh báo"
+ },
+ "TABLE_COMMENT": {
+ "title": "Quy ước bình luận bảng",
+ "description": "Định cấu hình xem bảng có yêu cầu bình luận hay không và độ dài bình luận tối đa.",
+ "component": {
+ "required": {
+ "title": "Yêu cầu bình luận"
+ },
+ "requiredClassification": {
+ "title": "Yêu cầu phân loại",
+ "tooltip": "Bình luận phải tuân theo định dạng {'{'}id phân loại{'}'}-{'{'}bình luận{'}'}."
+ },
+ "maxLength": {
+ "title": "Độ dài tối đa"
+ }
+ }
+ },
+ "TABLE_DISALLOW_DDL": {
+ "title": "Không cho phép DDL",
+ "description": "Định cấu hình bảng nào bị cấm thực hiện DDL. Mức độ lỗi gợi ý: Cảnh báo",
"component": {
"list": {
- "title": "Danh sách không cho phép"
+ "title": "Tên bảng"
}
}
},
- "advice-online-migration": {
- "title": "Di chuyển trực tuyến",
- "description": "Đề nghị bật di chuyển trực tuyến nếu số lượng hàng của bảng được di chuyển vượt quá cài đặt của bạn. Mức độ lỗi gợi ý: Cảnh báo",
+ "TABLE_DISALLOW_DML": {
+ "title": "Không cho phép DML",
+ "description": "Định cấu hình bảng nào bị cấm thực hiện DML. Mức độ lỗi gợi ý: Cảnh báo",
+ "component": {
+ "list": {
+ "title": "Tên bảng"
+ }
+ }
+ },
+ "TABLE_DISALLOW_PARTITION": {
+ "title": "Cấm sử dụng bảng phân vùng",
+ "description": "Trong một số engine cơ sở dữ liệu, các bảng phân vùng chưa hoàn thiện, việc sử dụng và bảo trì không thuận tiện. Do đó, người ta có xu hướng sử dụng các phương pháp phân vùng dữ liệu thủ công như phân mảnh cơ sở dữ liệu và bảng. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "TABLE_DISALLOW_SET_CHARSET": {
+ "title": "Cấm xác định bộ ký tự trong thuộc tính bảng",
+ "description": "Khuyến nghị nên đặt charset ở cấp cơ sở dữ liệu. Đặt charset ở mức độ chi tiết hơn có thể mang lại những phức tạp không cần thiết. Mức độ lỗi gợi ý: Lỗi."
+ },
+ "TABLE_DISALLOW_TRIGGER": {
+ "title": "Ngăn chặn việc sử dụng trigger trên bảng",
+ "description": "Quy tắc này hạn chế việc sử dụng trigger trên bảng. Trigger có thể gây ra sự phức tạp và các vấn đề hiệu suất tiềm ẩn cho các hoạt động cơ sở dữ liệu. Bằng cách không cho phép trigger, hệ thống có thể duy trì hành vi đơn giản và dễ đoán hơn. Mức độ lỗi đề xuất: Cảnh báo"
+ },
+ "TABLE_DROP_NAMING_CONVENTION": {
+ "title": "Hạn chế định dạng đặt tên của các bảng sẽ bị xóa",
+ "description": "Ví dụ: bằng cách yêu cầu hậu tố \"_del\", nó có thể ngăn chặn hiệu quả việc xóa do nhầm lẫn. Mức độ lỗi gợi ý: Lỗi",
+ "component": {
+ "format": {
+ "title": "Định dạng tên bảng (biểu thức chính quy)"
+ }
+ }
+ },
+ "TABLE_LIMIT_SIZE": {
+ "title": "Giới hạn hoạt động DDL trên các bảng có số lượng hàng lớn",
+ "description": "Định cấu hình số lượng hàng tối đa trong các bảng mà DDL có thể được thực thi. Mức độ lỗi được khuyến nghị: cảnh báo",
"component": {
"number": {
- "title": "Giá trị ngưỡng"
+ "title": "Số lượng hàng tối đa"
}
}
},
- "statement-add-foreign-key-not-valid": {
- "title": "Bắt buộc bao gồm tùy chọn \"NOT VALID\" khi thêm khóa ngoại",
- "description": "Thêm khóa ngoại cần xác minh dữ liệu hiện có và yêu cầu khóa bảng SHARE ROW EXCLUSIVE. Điều này chặn ghi, có thể gây gián đoạn kinh doanh. Bạn nên thêm tùy chọn \"NOT VALID\" để xác thực dữ liệu mới và xác thực thủ công dữ liệu hiện có sau khi thay đổi hoàn tất. Mức độ lỗi gợi ý: Cảnh báo"
+ "TABLE_NO_DUPLICATE_INDEX": {
+ "title": "Cấm các chỉ mục trùng lặp trên bảng",
+ "description": "Quy tắc này yêu cầu một bảng không có chỉ mục trùng lặp. Các chỉ mục trùng lặp tiêu tốn thêm không gian lưu trữ và có khả năng làm giảm hiệu suất truy vấn. Mức lỗi được đề xuất: Cảnh báo."
},
- "statement-non-transactional": {
- "title": "Phát hiện và báo cáo các câu lệnh không giao dịch",
- "description": ""
+ "TABLE_NO_FOREIGN_KEY": {
+ "title": "Cấm sử dụng ràng buộc khóa ngoại",
+ "description": "Ưu điểm và nhược điểm của khóa ngoại rất gây tranh cãi. Sử dụng khóa ngoại có thể làm tăng đáng kể độ khó của việc thay đổi cơ sở dữ liệu, khả năng mở rộng (chẳng hạn như phân mảnh), v.v. Và thậm chí có thể ngăn cản việc sử dụng một số công cụ. Do đó, một tùy chọn khác là triển khai các ràng buộc khóa ngoại ở lớp ứng dụng. Mức độ lỗi gợi ý: Cảnh báo"
},
- "builtin-prior-backup-check": {
- "title": "Kiểm tra tính khả thi của sao lưu trước",
- "description": "Quy tắc này kiểm tra xem có thể tạo bản sao lưu trước khi thay đổi dữ liệu hay không. Nó xác minh sự tồn tại của cơ sở dữ liệu đích sao lưu và không cho phép các kịch bản không được hỗ trợ. Nó được tích hợp sẵn và không thể bỏ qua."
+ "TABLE_REQUIRE_CHARSET": {
+ "title": "Yêu cầu charset",
+ "description": "Charset của bảng phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
},
- "statement-object-owner-check": {
- "title": "Kiểm tra chủ sở hữu đối tượng",
- "description": "Quy tắc này kiểm tra xem chủ sở hữu đối tượng cho DDL có giống với người dùng hiện tại không."
+ "TABLE_REQUIRE_COLLATION": {
+ "title": "Yêu cầu đối chiếu",
+ "description": "Đối chiếu (collation) của bảng phải được chỉ định. Mức độ lỗi gợi ý: Cảnh báo"
+ },
+ "TABLE_REQUIRE_PK": {
+ "title": "Bắt buộc bảng phải có khóa chính",
+ "description": "Các công cụ đồng bộ hóa, so sánh và hoàn tác dữ liệu khác nhau yêu cầu bảng phải có khóa chính. Mức độ lỗi gợi ý: Lỗi"
+ },
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": {
+ "title": "Hạn chế tổng độ dài của các trường văn bản trong bảng",
+ "description": "Quy tắc này giới hạn lượng dữ liệu mà một bảng có thể chứa, ngăn chặn việc sử dụng quá nhiều bộ nhớ.",
+ "component": {
+ "number": {
+ "title": "Độ dài tối đa"
+ }
+ }
}
},
"level": {
diff --git a/frontend/src/locales/sql-review/zh-CN.json b/frontend/src/locales/sql-review/zh-CN.json
index 74068c8b07..efc34404a7 100644
--- a/frontend/src/locales/sql-review/zh-CN.json
+++ b/frontend/src/locales/sql-review/zh-CN.json
@@ -33,55 +33,39 @@
"bb-sql-review-empty-desc": "一个空的模板,需要您自行添加需要的规则。"
},
"rule": {
- "engine-mysql-use-innodb": {
- "title": "强制使用 InnoDB 存储引擎",
- "description": "InnoDB 是 MySQL 默认的存储引擎,能够确保事务一致性,同时对高并发低延迟的场景有更好的性能表现,还可以支持在线数据备份与恢复,是 OLTP 业务的首选。建议错误等级:错误"
- },
- "table-require-pk": {
- "title": "强制表包含主键",
- "description": "各种数据同步、比对、回滚的工具往往要求表有主键。建议错误等级:错误"
- },
- "table-no-foreign-key": {
- "title": "禁止使用外键约束",
- "description": "外键的优缺点争议较大,使用外键可能导致数据库变更、扩展(如分库)等工作的难度明显增加,甚至无法使用一些工具。因此可以考虑在应用层实现外键约束。建议错误等级:警告"
- },
- "table-drop-naming-convention": {
- "title": "限制待删除表的命名格式",
- "description": "通过重命名待删除表,例如增加 _del 后缀,可以有效避免误操作发生。建议错误等级:错误",
+ "ADVICE_ONLINE_MIGRATION": {
+ "title": "在线大表变更",
+ "description": "如果迁移的表行数超过您的设置,建议启用在线迁移。建议的错误级别: 警告",
"component": {
- "format": {
- "title": "命名规则(正则)"
+ "number": {
+ "title": "阈值"
}
}
},
- "table-disallow-partition": {
- "title": "禁止使用分区表",
- "description": "在一些数据库引擎中,分区表技术并不成熟,使用与维护都较为不便,因此更倾向于通过分库分表等方式进行人工数据分区。建议错误等级:警告"
- },
- "table-disallow-trigger": {
- "title": "禁止使用触发器",
- "description": "触发器可能导致数据库的隐式行为,增加数据库的复杂性,降低可维护性。建议错误等级:警告"
- },
- "table-no-duplicate-index": {
- "title": "禁止重复索引",
- "description": "此规则禁止在表上创建重复的索引。重复索引会占用额外的存储空间并可能降低查询性能。建议错误等级:警告"
+ "BUILTIN_PRIOR_BACKUP_CHECK": {
+ "title": "事先备份可行性检查",
+ "description": "此规则检查是否可以在数据更改之前创建备份。它会验证备份目标数据库是否存在,并禁止不支持的方案。它是内置的,无法跳过。"
},
- "table-text-fields-total-length": {
- "title": "限制表格文本字段的总长度",
- "description": "该规则限制了表格所能容纳的数据量,防止存储空间的使用过量。",
+ "COLUMN_AUTO_INCREMENT_INITIAL_VALUE": {
+ "title": "限制自增列初始值",
+ "description": "结合管理要求限制自增列的初始值。建议错误等级:警告",
"component": {
"number": {
- "title": "最大长度"
+ "title": "初始值"
}
}
},
- "table-disallow-set-charset": {
- "title": "禁止在表格属性中定义字符集",
- "description": "建议在数据库层面设置字符集。在更细粒度设置字符集会带来不必要的复杂性。建议错误等级:错误。"
+ "COLUMN_AUTO_INCREMENT_MUST_INTEGER": {
+ "title": "强制自增列使用整数类型",
+ "description": "MySQL 的自增列一般用做业务无关主键,使用整数类型占用更少的存储空间,还能让主键索引结构更紧凑,带来更好的查询与 DML 性能。建议错误等级:错误"
},
- "table-comment": {
- "title": "表注释检查",
- "description": "配置表是否需要注释和最大注释长度。",
+ "COLUMN_AUTO_INCREMENT_MUST_UNSIGNED": {
+ "title": "强制自增列使用 \"UNSIGNED\" 类型",
+ "description": "无符号类型不存储负数,同样的类型存放的数值范围增加一倍,可以避免自增列超出上限。建议错误等级:警告"
+ },
+ "COLUMN_COMMENT": {
+ "title": "列注释检查",
+ "description": "对列添加注释是良好的开发习惯,但过长的注释将导致 Schema 易读性降低。建议错误等级:警告",
"component": {
"required": {
"title": "必须注释"
@@ -95,78 +79,210 @@
}
}
},
- "table-disallow-ddl": {
- "title": "禁止DDL",
- "description": "配置哪些表禁止执行 DDL。建议错误级别:警告",
+ "COLUMN_CURRENT_TIME_COUNT_LIMIT": {
+ "title": "限制表中获取系统时间的列的数量",
+ "description": "列需要调用函数获取系统时间的情况一般只包括记录创建时间的 \"DEFAULT NOW()\" 与记录更新时间的 \"DEFAULT NOW() ON UPDATE NOW()\",额外的列记录系统时间没有意义且会增加资源开销。建议错误等级:错误"
+ },
+ "COLUMN_DEFAULT_DISALLOW_VOLATILE": {
+ "title": "禁止在列上设置易变的默认值",
+ "description": "易变函数(例如,clock_timestamp())会在执行 ALTER TABLE ADD COLUMN 时更新每一行的值,可能导致更新操作时间过长。"
+ },
+ "COLUMN_DISALLOW_CHANGE": {
+ "title": "禁止使用 \"CHANGE COLUMN\" 语句",
+ "description": "\"CHANGE COLUMN\" 是 MySQL 特有的语法,可以同时修改列名与其他属性,但可能导致修改属性时误改了列名,建议仍然使用标准的 \"RENAME\",\"MODIFY\" 语句区分两类变更。建议错误等级:错误"
+ },
+ "COLUMN_DISALLOW_CHANGE_TYPE": {
+ "title": "禁止修改列类型",
+ "description": "修改列类型可能影响系统的性能、可维护性,甚至导致数据丢失。建议错误等级:警告"
+ },
+ "COLUMN_DISALLOW_CHANGING_ORDER": {
+ "title": "禁止修改表中的列顺序",
+ "description": "修改列顺序可能导致部分依赖原表默认顺序的应用或视图出现不符合预期的结果,例如 \"SELECT * \"。建议错误等级:警告"
+ },
+ "COLUMN_DISALLOW_DROP": {
+ "title": "禁止删除列",
+ "description": "禁止删除列。建议错误等级:警告"
+ },
+ "COLUMN_DISALLOW_DROP_IN_INDEX": {
+ "title": "禁止删除有索引的列",
+ "description": "禁止删除一个已经有索引的列。建议错误等级:错误"
+ },
+ "COLUMN_DISALLOW_SET_CHARSET": {
+ "title": "禁止在列属性中定义字符集",
+ "description": "字符集一般建议在数据库级别或表级别设置,更细粒度的字符集设置极易造成开发管理混乱。建议错误等级:错误"
+ },
+ "COLUMN_MAXIMUM_CHARACTER_LENGTH": {
+ "title": "限制 \"CHAR\" 类型长度",
+ "description": "\"CHAR\" 是定长类型,例如 CHAR(20) 列即便只存放1个字符也将占用20个字符空间造成浪费,当字符串过长且长度不固定时,MySQL 可考虑用 VARCHAR 替代,PostgreSQL 可考虑用 TEXT 替代。建议错误等级:错误",
+ "component": {
+ "number": {
+ "title": "最大长度"
+ }
+ }
+ },
+ "COLUMN_MAXIMUM_VARCHAR_LENGTH": {
+ "title": "限制 \"VARCHAR\" 类型长度",
+ "description": "",
+ "component": {
+ "number": {
+ "title": "最大长度"
+ }
+ }
+ },
+ "COLUMN_NO_NULL": {
+ "title": "强制非空约束",
+ "description": "表中的字段不允许存在 NULL 值。"
+ },
+ "COLUMN_REQUIRED": {
+ "title": "强制表中包含特定列",
+ "description": "部分通用列有助于更好的维护应用,例如增加 \"ID\" 作为业务无关的通用主键避免了业务变化(如业务合并)导致的主键冲突,部分场景还能带来更好的数据插入性能。建议错误等级:警告",
"component": {
"list": {
- "title": "表名"
+ "title": "必须包含的字段名"
}
}
},
- "table-limit-size": {
- "title": "限制对多行数表的 DDL 操作",
- "description": "配置可以执行 DDL 的表的最大行数。推荐错误级别:警告",
+ "COLUMN_REQUIRE_CHARSET": {
+ "title": "要求列设置字符集",
+ "description": "必须指定字符数据类型的列的字符集。建议错误级别:警告"
+ },
+ "COLUMN_REQUIRE_COLLATION": {
+ "title": "要求对列设置排序规则",
+ "description": "必须指定字符数据类型的列的排序规则。建议错误级别:警告"
+ },
+ "COLUMN_REQUIRE_DEFAULT": {
+ "title": "强制列设置默认值",
+ "description": "设置符合业务特点的默认值可以有效提升下游统计分析业务的数据质量,此规范不检查 \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\" 类型。建议错误等级:警告"
+ },
+ "COLUMN_SET_DEFAULT_FOR_NOT_NULL": {
+ "title": "强制 \"NOT NULL\" 列设置默认值",
+ "description": "对于 \"NOT NULL\" 列,在插入新行时如果不给该列赋值且该列没有默认值,数据库将会拒绝该行插入。对于新增列设置默认值也可以更好的兼容旧应用代码。建议错误等级:错误"
+ },
+ "COLUMN_TYPE_DISALLOW_LIST": {
+ "title": "禁止使用的列类型列表",
+ "description": "滥用列类型可能对系统可维护性与性能带来严重负面影响,例如使用 \"LOB\" 类列存放大量音视频数据可能导致数据库性能降低、备份恢复时间延长、数据同步工具不兼容等问题。建议错误等级:错误",
+ "component": {
+ "list": {
+ "title": "禁止的类型"
+ }
+ }
+ },
+ "DATABASE_DROP_EMPTY_DATABASE": {
+ "title": "禁止删除非空数据库",
+ "description": "只有当数据库中不包含任何表时才允许被删除,这能最大程度避免误删除的发生。建议错误等级:错误"
+ },
+ "ENGINE_MYSQL_USE_INNODB": {
+ "title": "强制使用 InnoDB 存储引擎",
+ "description": "InnoDB 是 MySQL 默认的存储引擎,能够确保事务一致性,同时对高并发低延迟的场景有更好的性能表现,还可以支持在线数据备份与恢复,是 OLTP 业务的首选。建议错误等级:错误"
+ },
+ "INDEX_CREATE_CONCURRENTLY": {
+ "title": "强制并行索引创建",
+ "description": "在 PostgreSQL 11 及以上版本中,使用普通方式创建索引将导致表锁定无法写入数据,使用 \"CONCURRENTLY\" 模式可以实现无锁创建索引,不影响表的正常访问。建议错误等级:警告"
+ },
+ "INDEX_KEY_NUMBER_LIMIT": {
+ "title": "限制单个索引中的列数量",
+ "description": "组合索引列超过 5 个对查询性能的提升并不明显,但却占用大量空间并降低 DML 性能。建议错误等级:警告",
"component": {
"number": {
- "title": "最大行数"
+ "title": "字段数量上限"
}
}
},
- "table-disallow-dml": {
- "title": "禁止 DML",
- "description": "配置哪些表禁止执行 DML。建议错误级别:警告",
+ "INDEX_NOT_REDUNDANT": {
+ "title": "禁止冗余索引",
+ "description": "冗余索引可能会导致性能损失并占用额外空间。例如,如果列(c1)上已经有一个索引,那么在列(c1,c2)上的索引将被视为冗余索引。建议的错误级别:警告"
+ },
+ "INDEX_NO_DUPLICATE_COLUMN": {
+ "title": "禁止索引包含重复列",
+ "description": "创建索引含重复列时语句将执行失败。建议错误等级:错误"
+ },
+ "INDEX_PK_TYPE_LIMIT": {
+ "title": "主键类型限制",
+ "description": "限制主键类型必须是 INT 或 BIGINT。"
+ },
+ "INDEX_PRIMARY_KEY_TYPE_ALLOWLIST": {
+ "title": "允许主键使用的类型列表",
+ "description": "合适的主键类型可以优化存储结构,减少空间占用并带来更好的插入与查询性能。建议错误等级:警告",
"component": {
"list": {
- "title": "表名"
+ "title": "允许的主键列的类型"
}
}
},
- "table-require-charset": {
- "title": "需要指定字符集",
- "description": "必须指定表格的字符集。建议错误级别:警告"
+ "INDEX_TOTAL_NUMBER_LIMIT": {
+ "title": "限制单表的索引数量",
+ "description": "索引虽然能提升查询性能,但却占用大量空间并降低 DML 性能,因此不建议单个表创建的索引数量超过5个。建议错误等级:警告",
+ "component": {
+ "number": {
+ "title": "索引数量上限"
+ }
+ }
},
- "table-require-collation": {
- "title": "需要指定排序规则",
- "description": "必须指定表的排序规则。建议错误级别:警告"
+ "INDEX_TYPE_ALLOW_LIST": {
+ "title": "可允许的索引类型列表",
+ "description": "不同的索引类型具有不同的性能特征。例如,B-tree 索引适用于范围查询,而哈希索引适用于相等查询。建议错误级别:警告",
+ "component": {
+ "list": {
+ "title": "允许的索引类型"
+ }
+ }
},
- "naming-fully-qualified": {
- "title": "完全限定对象名称",
- "description": "强制使用完全限定的对象名称。例如 “schema.table”,建议错误级别:警告"
+ "INDEX_TYPE_NO_BLOB": {
+ "title": "禁止对 \"BLOB\" 与 \"TEXT\" 类型列创建索引",
+ "description": "\"BLOB\" 等类型一般用于存放二进制数据,并不会作为查询条件,如果误在此类列上创建索引,将占用大量资源并产生严重的性能问题。建议错误等级:错误"
},
- "naming-table": {
- "title": "强制表命名格式",
+ "NAMING_COLUMN": {
+ "title": "强制列命名格式",
"description": "默认格式为全小写字母,单词之间以下划线分割,长度不超过 63 个字符,例如 \"abc\",\"abc_def\"。建议错误等级:警告",
"component": {
"format": {
- "title": "表命名规则(正则)"
+ "title": "列命名规则(正则)"
},
"maxLength": {
"title": "长度限制"
}
}
},
- "naming-column": {
- "title": "强制列命名格式",
- "description": "默认格式为全小写字母,单词之间以下划线分割,长度不超过 63 个字符,例如 \"abc\",\"abc_def\"。建议错误等级:警告",
+ "NAMING_COLUMN_AUTO_INCREMENT": {
+ "title": "强制自增列命名格式",
+ "description": "默认列名为 \"ID\",且不超过 63 个字符。",
"component": {
"format": {
- "title": "列命名规则(正则)"
+ "title": "自增列命名规则(正则)"
},
"maxLength": {
"title": "长度限制"
}
}
},
- "naming-index-uk": {
- "title": "强制唯一键命名格式",
- "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 uk_<表名>_<唯一键包含的列名组合> ,且不超过 63 个字符,例如 \"uk_my_table_id_name\"。建议错误等级:警告",
+ "NAMING_FULLY_QUALIFIED": {
+ "title": "完全限定对象名称",
+ "description": "强制使用完全限定的对象名称。例如 “schema.table”,建议错误级别:警告"
+ },
+ "NAMING_IDENTIFIER_CASE": {
+ "title": "强制字段名大小写",
+ "description": "",
+ "component": {
+ "upper": {
+ "title": "大写"
+ }
+ }
+ },
+ "NAMING_IDENTIFIER_NO_KEYWORD": {
+ "title": "禁止使用关键字作为字段名",
+ "description": ""
+ },
+ "NAMING_INDEX_FK": {
+ "title": "强制外键命名格式",
+ "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 fk_<目标表名>_<目标列名>_<被引用表名>_<被引用列名>,且不超过 63 个字符,例如 \"fk_my_table_id_foreign_table_id\"。",
"component": {
"format": {
- "title": "唯一键命名规则",
+ "title": "外键命名规则",
"template": {
- "table": "表名",
- "column_list": "索引包含的字段名,通过 _ 连接"
+ "referencing_table": "目标表名",
+ "referencing_column": "目标字段名",
+ "referenced_table": "被引用的表名",
+ "referenced_column": "被引用的字段名"
}
},
"maxLength": {
@@ -174,12 +290,12 @@
}
}
},
- "naming-index-pk": {
- "title": "强制主键命名格式",
- "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 pk_<表名>_<主键包含的列名组合> ,且不超过 63 个字符,例如 \"pk_my_table_id_name\"。建议错误等级:警告",
+ "NAMING_INDEX_IDX": {
+ "title": "强制索引命名格式",
+ "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 idx_<表名>_<索引包含的列名组合> ,且不超过 63 个字符,例如 \"idx_my_table_id_name\"。建议错误等级:警告",
"component": {
"format": {
- "title": "主键命名规则",
+ "title": "索引命名规则",
"template": {
"table": "表名",
"column_list": "索引包含的字段名,通过 _ 连接"
@@ -190,17 +306,15 @@
}
}
},
- "naming-index-fk": {
- "title": "强制外键命名格式",
- "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 fk_<目标表名>_<目标列名>_<被引用表名>_<被引用列名>,且不超过 63 个字符,例如 \"fk_my_table_id_foreign_table_id\"。",
+ "NAMING_INDEX_PK": {
+ "title": "强制主键命名格式",
+ "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 pk_<表名>_<主键包含的列名组合> ,且不超过 63 个字符,例如 \"pk_my_table_id_name\"。建议错误等级:警告",
"component": {
"format": {
- "title": "外键命名规则",
+ "title": "主键命名规则",
"template": {
- "referencing_table": "目标表名",
- "referencing_column": "目标字段名",
- "referenced_table": "被引用的表名",
- "referenced_column": "被引用的字段名"
+ "table": "表名",
+ "column_list": "索引包含的字段名,通过 _ 连接"
}
},
"maxLength": {
@@ -208,12 +322,12 @@
}
}
},
- "naming-index-idx": {
- "title": "强制索引命名格式",
- "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 idx_<表名>_<索引包含的列名组合> ,且不超过 63 个字符,例如 \"idx_my_table_id_name\"。建议错误等级:警告",
+ "NAMING_INDEX_UK": {
+ "title": "强制唯一键命名格式",
+ "description": "允许名字为空并由数据库自动命名,若非空则默认格式为 uk_<表名>_<唯一键包含的列名组合> ,且不超过 63 个字符,例如 \"uk_my_table_id_name\"。建议错误等级:警告",
"component": {
"format": {
- "title": "索引命名规则",
+ "title": "唯一键命名规则",
"template": {
"table": "表名",
"column_list": "索引包含的字段名,通过 _ 连接"
@@ -224,205 +338,112 @@
}
}
},
- "naming-column-auto-increment": {
- "title": "强制自增列命名格式",
- "description": "默认列名为 \"ID\",且不超过 63 个字符。",
+ "NAMING_TABLE": {
+ "title": "强制表命名格式",
+ "description": "默认格式为全小写字母,单词之间以下划线分割,长度不超过 63 个字符,例如 \"abc\",\"abc_def\"。建议错误等级:警告",
"component": {
"format": {
- "title": "自增列命名规则(正则)"
+ "title": "表命名规则(正则)"
},
"maxLength": {
"title": "长度限制"
}
}
},
- "naming-table-no-keyword": {
+ "NAMING_TABLE_NO_KEYWORD": {
"title": "禁止使用关键字作为表名",
"description": ""
},
- "naming-identifier-no-keyword": {
- "title": "禁止使用关键字作为字段名",
- "description": ""
+ "SCHEMA_BACKWARD_COMPATIBILITY": {
+ "title": "检查应用向后兼容性",
+ "description": "部分变更可能影响现有应用功能,例如修改数据库对象名,增加新的约束等,此规范可避免不谨慎变更导致现有应用运行失败。建议错误等级:警告"
},
- "naming-identifier-case": {
- "title": "强制字段名大小写",
- "description": "",
- "component": {
- "upper": {
- "title": "大写"
- }
- }
+ "STATEMENT_ADD_CHECK_NOT_VALID": {
+ "title": "强制添加 \"CHECK\" 约束时附带 \"NOT VALID\" 选项",
+ "description": "添加 CHECK 约束将对已有数据进行校验并要求 ACCESS EXCLUSIVE 表锁,阻塞读写,这可能导致业务中断。建议附带 \"NOT VALID\" 选项只对新数据进行校验,变更完成后再手动校验已有数据。建议错误等级:警告"
},
- "column-required": {
- "title": "强制表中包含特定列",
- "description": "部分通用列有助于更好的维护应用,例如增加 \"ID\" 作为业务无关的通用主键避免了业务变化(如业务合并)导致的主键冲突,部分场景还能带来更好的数据插入性能。建议错误等级:警告",
+ "STATEMENT_ADD_COLUMN_WITHOUT_POSITION": {
+ "title": "禁止在指定位置加列",
+ "description": "部分情况下,使用 FIRST/AFTER 在指定位置加列将引起数据重整(把原来的数据重写一遍)。建议错误级别:警告"
+ },
+ "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": {
+ "title": "强制添加外键时附带 \"NOT VALID\" 选项",
+ "description": "添加外键会校验已有数据并要求 SHARE ROW EXCLUSIVE 表锁,阻塞写入,这可能导致业务中断。建议附带 \"NOT VALID\" 选项只对新数据进行校验,变更完成后再校验已有数据。建议错误等级:警告"
+ },
+ "STATEMENT_AFFECTED_ROW_LIMIT": {
+ "title": "限制最大更新或删除行数(预估)",
+ "description": "通过提示更新或删除的行数辅助判断语句是否符合业务预期。建议错误等级:警告",
"component": {
- "list": {
- "title": "必须包含的字段名"
+ "number": {
+ "title": "最大影响行数"
}
}
},
- "column-type-disallow-list": {
- "title": "禁止使用的列类型列表",
- "description": "滥用列类型可能对系统可维护性与性能带来严重负面影响,例如使用 \"LOB\" 类列存放大量音视频数据可能导致数据库性能降低、备份恢复时间延长、数据同步工具不兼容等问题。建议错误等级:错误",
- "component": {
- "list": {
- "title": "禁止的类型"
- }
- }
- },
- "column-no-null": {
- "title": "强制非空约束",
- "description": "表中的字段不允许存在 NULL 值。"
- },
- "column-disallow-set-charset": {
- "title": "禁止在列属性中定义字符集",
- "description": "字符集一般建议在数据库级别或表级别设置,更细粒度的字符集设置极易造成开发管理混乱。建议错误等级:错误"
- },
- "column-disallow-change-type": {
- "title": "禁止修改列类型",
- "description": "修改列类型可能影响系统的性能、可维护性,甚至导致数据丢失。建议错误等级:警告"
- },
- "column-disallow-change": {
- "title": "禁止使用 \"CHANGE COLUMN\" 语句",
- "description": "\"CHANGE COLUMN\" 是 MySQL 特有的语法,可以同时修改列名与其他属性,但可能导致修改属性时误改了列名,建议仍然使用标准的 \"RENAME\",\"MODIFY\" 语句区分两类变更。建议错误等级:错误"
- },
- "column-disallow-changing-order": {
- "title": "禁止修改表中的列顺序",
- "description": "修改列顺序可能导致部分依赖原表默认顺序的应用或视图出现不符合预期的结果,例如 \"SELECT * \"。建议错误等级:警告"
- },
- "column-disallow-drop": {
- "title": "禁止删除列",
- "description": "禁止删除列。建议错误等级:警告"
- },
- "column-disallow-drop-in-index": {
- "title": "禁止删除有索引的列",
- "description": "禁止删除一个已经有索引的列。建议错误等级:错误"
- },
- "column-set-default-for-not-null": {
- "title": "强制 \"NOT NULL\" 列设置默认值",
- "description": "对于 \"NOT NULL\" 列,在插入新行时如果不给该列赋值且该列没有默认值,数据库将会拒绝该行插入。对于新增列设置默认值也可以更好的兼容旧应用代码。建议错误等级:错误"
- },
- "column-auto-increment-must-integer": {
- "title": "强制自增列使用整数类型",
- "description": "MySQL 的自增列一般用做业务无关主键,使用整数类型占用更少的存储空间,还能让主键索引结构更紧凑,带来更好的查询与 DML 性能。建议错误等级:错误"
- },
- "column-auto-increment-must-unsigned": {
- "title": "强制自增列使用 \"UNSIGNED\" 类型",
- "description": "无符号类型不存储负数,同样的类型存放的数值范围增加一倍,可以避免自增列超出上限。建议错误等级:警告"
- },
- "column-comment": {
- "title": "列注释检查",
- "description": "对列添加注释是良好的开发习惯,但过长的注释将导致 Schema 易读性降低。建议错误等级:警告",
- "component": {
- "required": {
- "title": "必须注释"
- },
- "requiredClassification": {
- "title": "需要分类",
- "tooltip": "评论应遵循{'{'}分类 ID{'}'}-{'{'}评论{'}'}格式。"
- },
- "maxLength": {
- "title": "长度限制"
- }
- }
- },
- "column-maximum-character-length": {
- "title": "限制 \"CHAR\" 类型长度",
- "description": "\"CHAR\" 是定长类型,例如 CHAR(20) 列即便只存放1个字符也将占用20个字符空间造成浪费,当字符串过长且长度不固定时,MySQL 可考虑用 VARCHAR 替代,PostgreSQL 可考虑用 TEXT 替代。建议错误等级:错误",
- "component": {
- "number": {
- "title": "最大长度"
- }
- }
- },
- "column-maximum-varchar-length": {
- "title": "限制 \"VARCHAR\" 类型长度",
- "description": "",
- "component": {
- "number": {
- "title": "最大长度"
- }
- }
- },
- "column-auto-increment-initial-value": {
- "title": "限制自增列初始值",
- "description": "结合管理要求限制自增列的初始值。建议错误等级:警告",
- "component": {
- "number": {
- "title": "初始值"
- }
- }
- },
- "column-current-time-count-limit": {
- "title": "限制表中获取系统时间的列的数量",
- "description": "列需要调用函数获取系统时间的情况一般只包括记录创建时间的 \"DEFAULT NOW()\" 与记录更新时间的 \"DEFAULT NOW() ON UPDATE NOW()\",额外的列记录系统时间没有意义且会增加资源开销。建议错误等级:错误"
- },
- "column-require-default": {
- "title": "强制列设置默认值",
- "description": "设置符合业务特点的默认值可以有效提升下游统计分析业务的数据质量,此规范不检查 \"PRIMARY KEY\", \"JSON\", \"BLOB\", \"TEXT\", \"GEOMETRY\", \"AUTO_INCREMENT\", \"GENERATED\" 类型。建议错误等级:警告"
+ "STATEMENT_CHECK_SET_ROLE_VARIABLE": {
+ "title": "检查语句开头是否存在 SET ROLE 语句",
+ "description": "在会话开始时未正确设置角色语句可能导致未经授权的访问或权限分配不当,可能危及数据安全性和完整性。错误等级:警告"
},
- "column-default-disallow-volatile": {
- "title": "禁止在列上设置易变的默认值",
- "description": "易变函数(例如,clock_timestamp())会在执行 ALTER TABLE ADD COLUMN 时更新每一行的值,可能导致更新操作时间过长。"
+ "STATEMENT_CREATE_SPECIFY_SCHEMA": {
+ "title": "禁止创建未指定 schema 的对象",
+ "description": "如果未指定 schema,对象将在默认模式中创建,可能导致意外结果。"
},
- "column-require-charset": {
- "title": "要求列设置字符集",
- "description": "必须指定字符数据类型的列的字符集。建议错误级别:警告"
+ "STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT": {
+ "title": "限制向表中添加带默认值的列",
+ "description": "在 PostgreSQL 11 之前的版本中,添加带有默认值的列将导致全表锁定无法读写,这可能导致业务中断。在 PostgreSQL 11 及以上版本中该问题已得到优化,无需关注此规范。建议错误等级:警告"
},
- "column-require-collation": {
- "title": "要求对列设置排序规则",
- "description": "必须指定字符数据类型的列的排序规则。建议错误级别:警告"
+ "STATEMENT_DISALLOW_ADD_NOT_NULL": {
+ "title": "限制向已有列添加 \"NOT NULL\" 约束",
+ "description": "在 PostgreSQL 11 之前添加带默认值的 NOT NULL 约束或在所有 PostgreSQL 版本中添加不带默认值的 NOT NULL 约束需要验证现有数据。这会阻塞读写,可能会导致业务中断。建议错误等级:警告"
},
- "statement-select-no-select-all": {
- "title": "禁止使用 \"SELECT *\"",
- "description": "SELECT * 拉取整行数据可能造成不必要的资源开销,同时一旦表增减列,也可能造成应用出现不符合预期的结果。建议错误等级:错误"
+ "STATEMENT_DISALLOW_COMMIT": {
+ "title": "禁止显式 \"COMMIT\"",
+ "description": "部分情况要求多条语句包含在一个事务中由系统提交,只允许同时成功或同时失败,以便部分出错时快速重跑,因此不允许出现显式的 \"COMMIT\"。建议错误等级:警告"
},
- "statement-where-require-select": {
- "title": "强制要求在 SELECT 语句中带有 \"WHERE\" 条件",
- "description": "没有 WHERE 子句的查询可能会造成巨大的不必要的资源开销。建议错误等级:错误"
+ "STATEMENT_DISALLOW_CROSS_DB_QUERIES": {
+ "title": "禁止跨数据库查询",
+ "description": "跨数据库查询会增加系统的耦合性,并可能导致效率问题。建议的错误级别:警告"
},
- "statement-where-require-update-delete": {
- "title": "强制要求在 DML 语句中带有 \"WHERE\" 条件",
- "description": "没有 WHERE 子句的 DML 可能会造成大规模数据丢失。建议错误等级:错误"
+ "STATEMENT_DISALLOW_LIMIT": {
+ "title": "禁止在 DML 语句中使用 \"LIMIT\"",
+ "description": "如果 DML 语句中使用 LIMIT 不伴随 ORDER BY,影响的行是不确定的,在部分复制模式下可能导致主库与从库变更了不同的行,造成数据不一致。建议错误等级:错误"
},
- "statement-where-no-leading-wildcard-like": {
- "title": "禁止过滤条件使用左模糊匹配",
- "description": "当使用左模糊匹配,例如 \"LIKE '%ABC'\",数据库优化器将无法进行快速索引扫描,而只能执行全表或全索引扫描,可能造成极为严重的性能问题。建议错误等级:错误"
+ "STATEMENT_DISALLOW_OFFLINE_DDL": {
+ "title": "禁止离线 DDL",
+ "description": "为了防止数据库更改影响您的业务,请避免使用离线 DDL。"
},
- "statement-disallow-on-del-cascade": {
+ "STATEMENT_DISALLOW_ON_DEL_CASCADE": {
"title": "禁止在ON DELETE子句中使用 CASCADE 选项",
"description": "'ON DELETE'中的'CASCADE'选项可能导致大量依赖对象被删除或修改,这可能导致意外的结果。建议的错误级别:错误"
},
- "statement-disallow-rm-tbl-cascade": {
+ "STATEMENT_DISALLOW_ORDER_BY": {
+ "title": "禁止在 \"UPDATE\",\"DELETE\" 语句中使用 \"ORDER BY\"",
+ "description": "排序操作是极为耗费资源的,对于更新与删除操作应该尽可能用确定的过滤条件,而不要使用 ORDER BY 加 LIMIT 的方式。建议错误等级:错误"
+ },
+ "STATEMENT_DISALLOW_RM_TBL_CASCADE": {
"title": "禁止在删除表时使用 CASCADE 选项",
"description": "在删除表时使用'CASCADE'选项可能导致大量依赖对象被删除或修改,这可能导致意外的结果。建议的错误级别:错误"
},
- "statement-disallow-commit": {
- "title": "禁止显式 \"COMMIT\"",
- "description": "部分情况要求多条语句包含在一个事务中由系统提交,只允许同时成功或同时失败,以便部分出错时快速重跑,因此不允许出现显式的 \"COMMIT\"。建议错误等级:警告"
+ "STATEMENT_DISALLOW_USING_FILESORT": {
+ "title": "禁止 Using filesort",
+ "description": "禁止 Using filesort 可以帮助优化查询性能,减少系统资源的消耗,提高系统的稳定性和可靠性。通常,通过合适的索引、查询优化和数据模型设计,可以避免或减少文件排序的需要。建议错误等级:警告"
},
- "statement-disallow-limit": {
- "title": "禁止在 DML 语句中使用 \"LIMIT\"",
- "description": "如果 DML 语句中使用 LIMIT 不伴随 ORDER BY,影响的行是不确定的,在部分复制模式下可能导致主库与从库变更了不同的行,造成数据不一致。建议错误等级:错误"
+ "STATEMENT_DISALLOW_USING_TEMPORARY": {
+ "title": "禁止 Using temporary",
+ "description": "禁止 Using temporary 可以帮助优化查询性能,减少系统资源的消耗,提高系统的稳定性和可靠性。建议错误等级:警告"
},
- "statement-disallow-order-by": {
- "title": "禁止在 \"UPDATE\",\"DELETE\" 语句中使用 \"ORDER BY\"",
- "description": "排序操作是极为耗费资源的,对于更新与删除操作应该尽可能用确定的过滤条件,而不要使用 ORDER BY 加 LIMIT 的方式。建议错误等级:错误"
+ "STATEMENT_DML_DRY_RUN": {
+ "title": "验证 DML 语句可执行性",
+ "description": "当语法正确但表名错误或权限不足时,可以在正式运行前通过模拟运行发现。建议错误等级:警告"
},
- "statement-merge-alter-table": {
- "title": "禁止对同一张表发起多次独立变更",
- "description": "每一次对表的变更都可能造成锁表并且消耗大量资源,如果存在对同一张表的多次变更,应该合并为一个变更语句。建议错误等级:错误"
+ "STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND": {
+ "title": "禁止在 \"INSERT\" 语句中使用 \"ORDER BY RAND()\"",
+ "description": "对待插入的数据进行随机排序是没有意义的,只会无端消耗资源。建议错误等级:错误"
},
- "statement-insert-must-specify-column": {
+ "STATEMENT_INSERT_MUST_SPECIFY_COLUMN": {
"title": "强制 \"INSERT\" 语句显示指定列名",
"description": "\"INSERT INTO table VALUES (...)\" 语句没有显式列出列名,一旦发生列顺序变化或列增减,语句就可能失败或写入不符合预期的数据。建议错误等级:错误"
},
- "statement-insert-disallow-order-by-rand": {
- "title": "禁止在 \"INSERT\" 语句中使用 \"ORDER BY RAND()\"",
- "description": "对待插入的数据进行随机排序是没有意义的,只会无端消耗资源。建议错误等级:错误"
- },
- "statement-insert-row-limit": {
+ "STATEMENT_INSERT_ROW_LIMIT": {
"title": "限制最大插入行数",
"description": "通过提示插入的行数辅助判断语句是否符合业务预期。建议错误等级:警告",
"component": {
@@ -431,78 +452,20 @@
}
}
},
- "statement-affected-row-limit": {
- "title": "限制最大更新或删除行数(预估)",
- "description": "通过提示更新或删除的行数辅助判断语句是否符合业务预期。建议错误等级:警告",
- "component": {
- "number": {
- "title": "最大影响行数"
- }
- }
- },
- "statement-dml-dry-run": {
- "title": "验证 DML 语句可执行性",
- "description": "当语法正确但表名错误或权限不足时,可以在正式运行前通过模拟运行发现。建议错误等级:警告"
- },
- "statement-disallow-add-column-with-default": {
- "title": "限制向表中添加带默认值的列",
- "description": "在 PostgreSQL 11 之前的版本中,添加带有默认值的列将导致全表锁定无法读写,这可能导致业务中断。在 PostgreSQL 11 及以上版本中该问题已得到优化,无需关注此规范。建议错误等级:警告"
- },
- "statement-add-check-not-valid": {
- "title": "强制添加 \"CHECK\" 约束时附带 \"NOT VALID\" 选项",
- "description": "添加 CHECK 约束将对已有数据进行校验并要求 ACCESS EXCLUSIVE 表锁,阻塞读写,这可能导致业务中断。建议附带 \"NOT VALID\" 选项只对新数据进行校验,变更完成后再手动校验已有数据。建议错误等级:警告"
- },
- "statement-disallow-add-not-null": {
- "title": "限制向已有列添加 \"NOT NULL\" 约束",
- "description": "在 PostgreSQL 11 之前添加带默认值的 NOT NULL 约束或在所有 PostgreSQL 版本中添加不带默认值的 NOT NULL 约束需要验证现有数据。这会阻塞读写,可能会导致业务中断。建议错误等级:警告"
- },
- "statement-select-full-table-scan": {
- "title": "检查查询是否存在全表扫描",
- "description": "全表扫描是一种消耗大量资源的操作,可能导致严重的性能影响。建议错误等级:错误"
- },
- "statement-create-specify-schema": {
- "title": "禁止创建未指定 schema 的对象",
- "description": "如果未指定 schema,对象将在默认模式中创建,可能导致意外结果。"
- },
- "statement-check-set-role-variable": {
- "title": "检查语句开头是否存在 SET ROLE 语句",
- "description": "在会话开始时未正确设置角色语句可能导致未经授权的访问或权限分配不当,可能危及数据安全性和完整性。错误等级:警告"
- },
- "statement-disallow-using-temporary": {
- "title": "禁止 Using temporary",
- "description": "禁止 Using temporary 可以帮助优化查询性能,减少系统资源的消耗,提高系统的稳定性和可靠性。建议错误等级:警告"
- },
- "statement-disallow-using-filesort": {
- "title": "禁止 Using filesort",
- "description": "禁止 Using filesort 可以帮助优化查询性能,减少系统资源的消耗,提高系统的稳定性和可靠性。通常,通过合适的索引、查询优化和数据模型设计,可以避免或减少文件排序的需要。建议错误等级:警告"
- },
- "statement-where-no-equal-null": {
- "title": "禁止在WHERE子句中使用NULL等式比较",
- "description": "NULL 等式比较的结果始终是 NULL,可能导致意外的结果。建议错误级别:警告"
- },
- "statement-where-disallow-functions-and-calculations": {
- "title": "在 WHERE 子句中避免对索引字段应用函数或执行计算",
- "description": "如果对索引字段应用函数或执行计算,则数据库无法使用索引,而必须扫描整个表。"
- },
- "statement-query-minimum-plan-level": {
- "title": "限制查询访问方法的最大级别",
- "description": "在 SQL 性能优化中,追求常量访问速度,以引用级别作为基线,区间级别的性能尚可接受。",
- "component": {
- "level": {
- "title": "最大级别"
- }
- }
+ "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {
+ "title": "要进行连接的字段必须具有相同的数据类型和字符集。",
+ "description": "如果连接列的数据类型、字符集不一致,数据库可能无法正确识别匹配的行,从而导致结果不准确或不完整。"
},
- "statement-where-maximum-logical-operator-count": {
- "title": "限制 WHERE 子句中的 IN 或 OR 子句中的值的数量",
- "description": "这可以防止因频繁对比和资源限制导致性能下降。",
+ "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {
+ "title": "限制语句中连接的表数量",
+ "description": "连接的表越多,查询就越复杂,执行时间也越长。 通常情况下,最好将连接数控制在最低限度。",
"component": {
"number": {
- "title": "最大数量"
+ "title": "最大值"
}
}
},
- "statement-maximum-limit-value": {
+ "STATEMENT_MAXIMUM_LIMIT_VALUE": {
"title": "限制 LIMIT 子句的最大行数",
"description": "通过 LIMIT 限制行数可以确保数据库处理可管理的大小块数据,从而提高查询执行速度。 限制 LIMIT 的值可以防止过度使用内存,从而保护系统整体稳定性和防止性能下降。",
"component": {
@@ -511,16 +474,7 @@
}
}
},
- "statement-maximum-join-table-count": {
- "title": "限制语句中连接的表数量",
- "description": "连接的表越多,查询就越复杂,执行时间也越长。 通常情况下,最好将连接数控制在最低限度。",
- "component": {
- "number": {
- "title": "最大值"
- }
- }
- },
- "statement-maximum-statements-in-transaction": {
+ "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {
"title": "限制事务中的语句数量",
"description": "巨大的事务会显著影响数据库性能。如果涉及大量语句并且其中一个语句失败,则回滚整个事务会变得复杂。限制语句数量可以最小化单个故障造成的潜在损害并简化回滚过程。",
"component": {
@@ -529,31 +483,7 @@
}
}
},
- "statement-join-strict-column-attrs": {
- "title": "要进行连接的字段必须具有相同的数据类型和字符集。",
- "description": "如果连接列的数据类型、字符集不一致,数据库可能无法正确识别匹配的行,从而导致结果不准确或不完整。"
- },
- "statement-prior-backup-check": {
- "title": "检查能否预先备份数据",
- "description": "此规则将检查是否可以在数据更改前创建备份。该规则要求备份目标数据库存在且不存在DDL语句。"
- },
- "statement-add-column-without-position": {
- "title": "禁止在指定位置加列",
- "description": "部分情况下,使用 FIRST/AFTER 在指定位置加列将引起数据重整(把原来的数据重写一遍)。建议错误级别:警告"
- },
- "statement-disallow-offline-ddl": {
- "title": "禁止离线 DDL",
- "description": "为了防止数据库更改影响您的业务,请避免使用离线 DDL。"
- },
- "statement-disallow-cross-db-queries": {
- "title": "禁止跨数据库查询",
- "description": "跨数据库查询会增加系统的耦合性,并可能导致效率问题。建议的错误级别:警告"
- },
- "schema-backward-compatibility": {
- "title": "检查应用向后兼容性",
- "description": "部分变更可能影响现有应用功能,例如修改数据库对象名,增加新的约束等,此规范可避免不谨慎变更导致现有应用运行失败。建议错误等级:警告"
- },
- "statement-max-execution-time": {
+ "STATEMENT_MAX_EXECUTION_TIME": {
"title": "强制设置最大执行时间参数",
"description": "设置SQL语句的最大执行时间,如果执行时间超过限制,语句将被终止。建议错误级别:警告",
"mysql": {
@@ -565,75 +495,73 @@
"description": "在变更脚本中设置 MAX_STATEMENT_TIME 参数以显式控制语句最长执行时间。建议错误级别:警告"
}
},
- "statement-require-algorithm-option": {
+ "STATEMENT_MERGE_ALTER_TABLE": {
+ "title": "禁止对同一张表发起多次独立变更",
+ "description": "每一次对表的变更都可能造成锁表并且消耗大量资源,如果存在对同一张表的多次变更,应该合并为一个变更语句。建议错误等级:错误"
+ },
+ "STATEMENT_NON_TRANSACTIONAL": {
+ "title": "检测并报告非事务性语句",
+ "description": ""
+ },
+ "STATEMENT_OBJECT_OWNER_CHECK": {
+ "title": "对象所有者检查",
+ "description": "此规则检查 DDL 的对象所有者是否与当前用户相同。"
+ },
+ "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {
+ "title": "限制查询访问方法的最大级别",
+ "description": "在 SQL 性能优化中,追求常量访问速度,以引用级别作为基线,区间级别的性能尚可接受。",
+ "component": {
+ "level": {
+ "title": "最大级别"
+ }
+ }
+ },
+ "STATEMENT_REQUIRE_ALGORITHM_OPTION": {
"title": "需要在 ALTER TABLE 语句中指定 ALGORITHM 选项",
"description": "在 ALTER TABLE 语句中指定 ALGORITHM 选项可确保更好地控制表更改的应用方式,通过避免全表复制或锁定来最大限度地减少潜在的中断。它有助于优化性能并减少 ALTER TABLE 操作的停机时间。建议的错误级别:警告。"
},
- "statement-require-lock-option": {
+ "STATEMENT_REQUIRE_LOCK_OPTION": {
"title": "需要在 ALTER TABLE 语句中指定 LOCK 选项",
"description": "ALTER TABLE 语句中的 LOCK 选项允许您控制架构更改期间的锁定级别,有助于防止不必要的表锁定并确保更好的并发性。正确使用此选项可以显著减少 ALTER TABLE 操作对活动查询的影响。建议的错误级别:警告。"
},
- "database-drop-empty-database": {
- "title": "禁止删除非空数据库",
- "description": "只有当数据库中不包含任何表时才允许被删除,这能最大程度避免误删除的发生。建议错误等级:错误"
- },
- "index-no-duplicate-column": {
- "title": "禁止索引包含重复列",
- "description": "创建索引含重复列时语句将执行失败。建议错误等级:错误"
- },
- "index-type-no-blob": {
- "title": "禁止对 \"BLOB\" 与 \"TEXT\" 类型列创建索引",
- "description": "\"BLOB\" 等类型一般用于存放二进制数据,并不会作为查询条件,如果误在此类列上创建索引,将占用大量资源并产生严重的性能问题。建议错误等级:错误"
+ "STATEMENT_SELECT_FULL_TABLE_SCAN": {
+ "title": "检查查询是否存在全表扫描",
+ "description": "全表扫描是一种消耗大量资源的操作,可能导致严重的性能影响。建议错误等级:错误"
},
- "index-pk-type-limit": {
- "title": "主键类型限制",
- "description": "限制主键类型必须是 INT 或 BIGINT。"
+ "STATEMENT_SELECT_NO_SELECT_ALL": {
+ "title": "禁止使用 \"SELECT *\"",
+ "description": "SELECT * 拉取整行数据可能造成不必要的资源开销,同时一旦表增减列,也可能造成应用出现不符合预期的结果。建议错误等级:错误"
},
- "index-key-number-limit": {
- "title": "限制单个索引中的列数量",
- "description": "组合索引列超过 5 个对查询性能的提升并不明显,但却占用大量空间并降低 DML 性能。建议错误等级:警告",
- "component": {
- "number": {
- "title": "字段数量上限"
- }
- }
+ "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": {
+ "title": "在 WHERE 子句中避免对索引字段应用函数或执行计算",
+ "description": "如果对索引字段应用函数或执行计算,则数据库无法使用索引,而必须扫描整个表。"
},
- "index-total-number-limit": {
- "title": "限制单表的索引数量",
- "description": "索引虽然能提升查询性能,但却占用大量空间并降低 DML 性能,因此不建议单个表创建的索引数量超过5个。建议错误等级:警告",
+ "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": {
+ "title": "限制 WHERE 子句中的 IN 或 OR 子句中的值的数量",
+ "description": "这可以防止因频繁对比和资源限制导致性能下降。",
"component": {
"number": {
- "title": "索引数量上限"
+ "title": "最大数量"
}
}
},
- "index-primary-key-type-allowlist": {
- "title": "允许主键使用的类型列表",
- "description": "合适的主键类型可以优化存储结构,减少空间占用并带来更好的插入与查询性能。建议错误等级:警告",
- "component": {
- "list": {
- "title": "允许的主键列的类型"
- }
- }
+ "STATEMENT_WHERE_NO_EQUAL_NULL": {
+ "title": "禁止在WHERE子句中使用NULL等式比较",
+ "description": "NULL 等式比较的结果始终是 NULL,可能导致意外的结果。建议错误级别:警告"
},
- "index-create-concurrently": {
- "title": "强制并行索引创建",
- "description": "在 PostgreSQL 11 及以上版本中,使用普通方式创建索引将导致表锁定无法写入数据,使用 \"CONCURRENTLY\" 模式可以实现无锁创建索引,不影响表的正常访问。建议错误等级:警告"
+ "STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE": {
+ "title": "禁止过滤条件使用左模糊匹配",
+ "description": "当使用左模糊匹配,例如 \"LIKE '%ABC'\",数据库优化器将无法进行快速索引扫描,而只能执行全表或全索引扫描,可能造成极为严重的性能问题。建议错误等级:错误"
},
- "index-type-allow-list": {
- "title": "可允许的索引类型列表",
- "description": "不同的索引类型具有不同的性能特征。例如,B-tree 索引适用于范围查询,而哈希索引适用于相等查询。建议错误级别:警告",
- "component": {
- "list": {
- "title": "允许的索引类型"
- }
- }
+ "STATEMENT_WHERE_REQUIRE_SELECT": {
+ "title": "强制要求在 SELECT 语句中带有 \"WHERE\" 条件",
+ "description": "没有 WHERE 子句的查询可能会造成巨大的不必要的资源开销。建议错误等级:错误"
},
- "index-not-redundant": {
- "title": "禁止冗余索引",
- "description": "冗余索引可能会导致性能损失并占用额外空间。例如,如果列(c1)上已经有一个索引,那么在列(c1,c2)上的索引将被视为冗余索引。建议的错误级别:警告"
+ "STATEMENT_WHERE_REQUIRE_UPDATE_DELETE": {
+ "title": "强制要求在 DML 语句中带有 \"WHERE\" 条件",
+ "description": "没有 WHERE 子句的 DML 可能会造成大规模数据丢失。建议错误等级:错误"
},
- "system-charset-allowlist": {
+ "SYSTEM_CHARSET_ALLOWLIST": {
"title": "允许使用的字符集(Charset)列表",
"description": "字符集决定了表中可以存储哪些字符,使用错误的字符集可能导致应用中的部分字符无法正确存储与显示,例如中文与 Emoji 表情。建议错误等级:错误",
"component": {
@@ -642,7 +570,7 @@
}
}
},
- "system-collation-allowlist": {
+ "SYSTEM_COLLATION_ALLOWLIST": {
"title": "允许使用的字符序(Collation)列表",
"description": "字符序决定了字符比对与排序的规则,例如使用不区分大小写的字符序时 \"ABC\" 与 \"abc\" 在查询时将被视为相同字符串。建议错误等级:错误",
"component": {
@@ -651,7 +579,7 @@
}
}
},
- "system-comment-length": {
+ "SYSTEM_COMMENT_LENGTH": {
"title": "限制注释长度",
"description": "过长的注释将导致 Schema 易读性降低,并可能带来潜在的性能风险。建议错误等级:警告",
"component": {
@@ -660,55 +588,123 @@
}
}
},
- "system-procedure-disallow-create": {
- "title": "禁止创建存储过程",
- "description": "存储过程通常会执行可能影响数据库环境稳定性和安全性的关键操作。禁止创建存储过程有助于防止意外更改和潜在漏洞。建议错误等级:警告"
- },
- "system-event-disallow-create": {
+ "SYSTEM_EVENT_DISALLOW_CREATE": {
"title": "禁止创建事件",
"description": "该规则禁止在数据库中创建事件。系统事件通常执行可能影响数据库环境的自动化任务。通过禁止创建它们,有助于控制数据库操作并防止潜在的中断。建议的错误级别:警告"
},
- "system-view-disallow-create": {
- "title": "禁止创建视图",
- "description": "该规则禁止在数据库中创建视图。视图提供了数据的虚拟表示,可以简化查询并增强数据安全性。通过禁止创建它们,有助于维护对数据库模式的控制,并防止潜在的安全风险。建议的错误级别:警告"
+ "SYSTEM_FUNCTION_DISALLOWED_LIST": {
+ "title": "禁止使用的函数",
+ "description": "此规则限制数据库内特定函数的使用。通过禁止使用这些函数,有助于维护数据一致性和安全性。建议错误级别:警告",
+ "component": {
+ "list": {
+ "title": "禁止的函数"
+ }
+ }
},
- "system-function-disallow-create": {
+ "SYSTEM_FUNCTION_DISALLOW_CREATE": {
"title": "禁止创建函数",
"description": "该规则禁止在数据库中创建函数。函数提供可重用的逻辑,可以简化查询并增强数据完整性。通过禁止创建它们,有助于保持对数据库架构的控制,并预防潜在的安全风险。建议的错误级别:警告"
},
- "system-function-disallowed-list": {
- "title": "禁止使用的函数",
- "description": "此规则限制数据库内特定函数的使用。通过禁止使用这些函数,有助于维护数据一致性和安全性。建议错误级别:警告",
+ "SYSTEM_PROCEDURE_DISALLOW_CREATE": {
+ "title": "禁止创建存储过程",
+ "description": "存储过程通常会执行可能影响数据库环境稳定性和安全性的关键操作。禁止创建存储过程有助于防止意外更改和潜在漏洞。建议错误等级:警告"
+ },
+ "SYSTEM_VIEW_DISALLOW_CREATE": {
+ "title": "禁止创建视图",
+ "description": "该规则禁止在数据库中创建视图。视图提供了数据的虚拟表示,可以简化查询并增强数据安全性。通过禁止创建它们,有助于维护对数据库模式的控制,并防止潜在的安全风险。建议的错误级别:警告"
+ },
+ "TABLE_COMMENT": {
+ "title": "表注释检查",
+ "description": "配置表是否需要注释和最大注释长度。",
+ "component": {
+ "required": {
+ "title": "必须注释"
+ },
+ "requiredClassification": {
+ "title": "需要分类",
+ "tooltip": "评论应遵循{'{'}分类 ID{'}'}-{'{'}评论{'}'}格式。"
+ },
+ "maxLength": {
+ "title": "长度限制"
+ }
+ }
+ },
+ "TABLE_DISALLOW_DDL": {
+ "title": "禁止DDL",
+ "description": "配置哪些表禁止执行 DDL。建议错误级别:警告",
"component": {
"list": {
- "title": "禁止的函数"
+ "title": "表名"
}
}
},
- "advice-online-migration": {
- "title": "在线大表变更",
- "description": "如果迁移的表行数超过您的设置,建议启用在线迁移。建议的错误级别: 警告",
+ "TABLE_DISALLOW_DML": {
+ "title": "禁止 DML",
+ "description": "配置哪些表禁止执行 DML。建议错误级别:警告",
+ "component": {
+ "list": {
+ "title": "表名"
+ }
+ }
+ },
+ "TABLE_DISALLOW_PARTITION": {
+ "title": "禁止使用分区表",
+ "description": "在一些数据库引擎中,分区表技术并不成熟,使用与维护都较为不便,因此更倾向于通过分库分表等方式进行人工数据分区。建议错误等级:警告"
+ },
+ "TABLE_DISALLOW_SET_CHARSET": {
+ "title": "禁止在表格属性中定义字符集",
+ "description": "建议在数据库层面设置字符集。在更细粒度设置字符集会带来不必要的复杂性。建议错误等级:错误。"
+ },
+ "TABLE_DISALLOW_TRIGGER": {
+ "title": "禁止使用触发器",
+ "description": "触发器可能导致数据库的隐式行为,增加数据库的复杂性,降低可维护性。建议错误等级:警告"
+ },
+ "TABLE_DROP_NAMING_CONVENTION": {
+ "title": "限制待删除表的命名格式",
+ "description": "通过重命名待删除表,例如增加 _del 后缀,可以有效避免误操作发生。建议错误等级:错误",
+ "component": {
+ "format": {
+ "title": "命名规则(正则)"
+ }
+ }
+ },
+ "TABLE_LIMIT_SIZE": {
+ "title": "限制对多行数表的 DDL 操作",
+ "description": "配置可以执行 DDL 的表的最大行数。推荐错误级别:警告",
"component": {
"number": {
- "title": "阈值"
+ "title": "最大行数"
}
}
},
- "statement-add-foreign-key-not-valid": {
- "title": "强制添加外键时附带 \"NOT VALID\" 选项",
- "description": "添加外键会校验已有数据并要求 SHARE ROW EXCLUSIVE 表锁,阻塞写入,这可能导致业务中断。建议附带 \"NOT VALID\" 选项只对新数据进行校验,变更完成后再校验已有数据。建议错误等级:警告"
+ "TABLE_NO_DUPLICATE_INDEX": {
+ "title": "禁止表上重复索引",
+ "description": "此规则要求表上没有重复索引。重复索引会占用额外的存储空间であり、クエリパフォーマンスを低下させる可能性があります。推奨エラーレベル:警告。"
},
- "statement-non-transactional": {
- "title": "检测并报告非事务性语句",
- "description": ""
+ "TABLE_NO_FOREIGN_KEY": {
+ "title": "禁止使用外键约束",
+ "description": "外键的优缺点争议较大,使用外键可能导致数据库变更、扩展(如分库)等工作的难度明显增加,甚至无法使用一些工具。因此可以考虑在应用层实现外键约束。建议错误等级:警告"
},
- "builtin-prior-backup-check": {
- "title": "事先备份可行性检查",
- "description": "此规则检查是否可以在数据更改之前创建备份。它会验证备份目标数据库是否存在,并禁止不支持的方案。它是内置的,无法跳过。"
+ "TABLE_REQUIRE_CHARSET": {
+ "title": "需要指定字符集",
+ "description": "必须指定表格的字符集。建议错误级别:警告"
},
- "statement-object-owner-check": {
- "title": "对象所有者检查",
- "description": "此规则检查 DDL 的对象所有者是否与当前用户相同。"
+ "TABLE_REQUIRE_COLLATION": {
+ "title": "需要指定排序规则",
+ "description": "必须指定表的排序规则。建议错误级别:警告"
+ },
+ "TABLE_REQUIRE_PK": {
+ "title": "强制表包含主键",
+ "description": "各种数据同步、比对、回滚的工具往往要求表有主键。建议错误等级:错误"
+ },
+ "TABLE_TEXT_FIELDS_TOTAL_LENGTH": {
+ "title": "限制表格文本字段的总长度",
+ "description": "该规则限制了表格所能容纳的数据量,防止存储空间的使用过量。",
+ "component": {
+ "number": {
+ "title": "最大长度"
+ }
+ }
}
},
"level": {
diff --git a/frontend/src/plugins/i18n.test.ts b/frontend/src/plugins/i18n.test.ts
index 15e85e9806..0d242fab2b 100644
--- a/frontend/src/plugins/i18n.test.ts
+++ b/frontend/src/plugins/i18n.test.ts
@@ -1,7 +1,11 @@
import { describe, expect, test } from "vitest";
import { Engine } from "@/types/proto-es/v1/common_pb";
import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";
-import { getRuleLocalizationKey, TEMPLATE_LIST_V2 } from "../types/sqlReview";
+import {
+ getRuleLocalizationKey,
+ ruleTypeToString,
+ TEMPLATE_LIST_V2,
+} from "../types/sqlReview";
import { mergedLocalMessage } from "./i18n-messages";
describe("Test i18n messages", () => {
@@ -45,8 +49,8 @@ describe("Test i18n for SQL review", () => {
expect(!!i18nForSQLReview["template"][`${key}-desc`]).toBe(true);
for (const rule of template.ruleList) {
- test(`check i18n for rule ${rule.type}`, () => {
- const key = getRuleLocalizationKey(rule.type);
+ test(`check i18n for rule ${ruleTypeToString(rule.type)}`, () => {
+ const key = getRuleLocalizationKey(ruleTypeToString(rule.type));
expect(!!i18nForSQLReview["rule"][key], "rule-key").toBe(true);
expect(
!!i18nForSQLReview["rule"][key]["title"],
diff --git a/frontend/src/store/modules/sqlReview.ts b/frontend/src/store/modules/sqlReview.ts
index b1c25e5560..c7c377302d 100644
--- a/frontend/src/store/modules/sqlReview.ts
+++ b/frontend/src/store/modules/sqlReview.ts
@@ -22,6 +22,7 @@ import {
GetReviewConfigRequestSchema,
ListReviewConfigsRequestSchema,
ReviewConfigSchema,
+ SQLReviewRule_Type,
SQLReviewRuleSchema,
UpdateReviewConfigRequestSchema,
} from "@/types/proto-es/v1/review_config_service_pb";
@@ -70,7 +71,7 @@ const convertToSQLReviewPolicy = (
const ruleList: SchemaPolicyRule[] = [];
for (const r of reviewConfig.rules) {
const rule: SchemaPolicyRule = {
- type: r.type,
+ type: SQLReviewRule_Type[r.type] as string,
level: r.level,
engine: r.engine,
};
@@ -192,7 +193,7 @@ export const useSQLReviewStore = defineStore("sqlReview", {
updateMask.push("rules");
patch.rules = ruleList.map((r) => {
return create(SQLReviewRuleSchema, {
- type: r.type,
+ type: SQLReviewRule_Type[r.type as keyof typeof SQLReviewRule_Type],
level: r.level,
engine: r.engine,
payload: r.payload ? JSON.stringify(r.payload) : "{}",
diff --git a/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts b/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts
index 8b76b3d746..c7bc767d62 100644
--- a/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts
+++ b/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts
@@ -190,9 +190,9 @@ export declare type SQLReviewRule = Message<"bytebase.v1.SQLReviewRule"> & {
/**
* The type of SQL review rule.
*
- * @generated from field: string type = 1;
+ * @generated from field: bytebase.v1.SQLReviewRule.Type type = 1;
*/
- type: string;
+ type: SQLReviewRule_Type;
/**
* The severity level of the rule.
@@ -255,6 +255,566 @@ export enum SQLReviewRule_Level {
*/
export declare const SQLReviewRule_LevelSchema: GenEnum<SQLReviewRule_Level>;
+/**
+ * @generated from enum bytebase.v1.SQLReviewRule.Type
+ */
+export enum SQLReviewRule_Type {
+ /**
+ * @generated from enum value: TYPE_UNSPECIFIED = 0;
+ */
+ TYPE_UNSPECIFIED = 0,
+
+ /**
+ * @generated from enum value: ENGINE_MYSQL_USE_INNODB = 1;
+ */
+ ENGINE_MYSQL_USE_INNODB = 1,
+
+ /**
+ * @generated from enum value: NAMING_FULLY_QUALIFIED = 2;
+ */
+ NAMING_FULLY_QUALIFIED = 2,
+
+ /**
+ * @generated from enum value: NAMING_TABLE = 3;
+ */
+ NAMING_TABLE = 3,
+
+ /**
+ * @generated from enum value: NAMING_COLUMN = 4;
+ */
+ NAMING_COLUMN = 4,
+
+ /**
+ * @generated from enum value: NAMING_INDEX_PK = 5;
+ */
+ NAMING_INDEX_PK = 5,
+
+ /**
+ * @generated from enum value: NAMING_INDEX_UK = 6;
+ */
+ NAMING_INDEX_UK = 6,
+
+ /**
+ * @generated from enum value: NAMING_INDEX_FK = 7;
+ */
+ NAMING_INDEX_FK = 7,
+
+ /**
+ * @generated from enum value: NAMING_INDEX_IDX = 8;
+ */
+ NAMING_INDEX_IDX = 8,
+
+ /**
+ * @generated from enum value: NAMING_COLUMN_AUTO_INCREMENT = 9;
+ */
+ NAMING_COLUMN_AUTO_INCREMENT = 9,
+
+ /**
+ * @generated from enum value: NAMING_TABLE_NO_KEYWORD = 10;
+ */
+ NAMING_TABLE_NO_KEYWORD = 10,
+
+ /**
+ * @generated from enum value: NAMING_IDENTIFIER_NO_KEYWORD = 11;
+ */
+ NAMING_IDENTIFIER_NO_KEYWORD = 11,
+
+ /**
+ * @generated from enum value: NAMING_IDENTIFIER_CASE = 12;
+ */
+ NAMING_IDENTIFIER_CASE = 12,
+
+ /**
+ * @generated from enum value: STATEMENT_SELECT_NO_SELECT_ALL = 13;
+ */
+ STATEMENT_SELECT_NO_SELECT_ALL = 13,
+
+ /**
+ * @generated from enum value: STATEMENT_WHERE_REQUIRE_SELECT = 14;
+ */
+ STATEMENT_WHERE_REQUIRE_SELECT = 14,
+
+ /**
+ * @generated from enum value: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE = 15;
+ */
+ STATEMENT_WHERE_REQUIRE_UPDATE_DELETE = 15,
+
+ /**
+ * @generated from enum value: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE = 16;
+ */
+ STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE = 16,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_ON_DEL_CASCADE = 17;
+ */
+ STATEMENT_DISALLOW_ON_DEL_CASCADE = 17,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_RM_TBL_CASCADE = 18;
+ */
+ STATEMENT_DISALLOW_RM_TBL_CASCADE = 18,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_COMMIT = 19;
+ */
+ STATEMENT_DISALLOW_COMMIT = 19,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_LIMIT = 20;
+ */
+ STATEMENT_DISALLOW_LIMIT = 20,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_ORDER_BY = 21;
+ */
+ STATEMENT_DISALLOW_ORDER_BY = 21,
+
+ /**
+ * @generated from enum value: STATEMENT_MERGE_ALTER_TABLE = 22;
+ */
+ STATEMENT_MERGE_ALTER_TABLE = 22,
+
+ /**
+ * @generated from enum value: STATEMENT_INSERT_ROW_LIMIT = 23;
+ */
+ STATEMENT_INSERT_ROW_LIMIT = 23,
+
+ /**
+ * @generated from enum value: STATEMENT_INSERT_MUST_SPECIFY_COLUMN = 24;
+ */
+ STATEMENT_INSERT_MUST_SPECIFY_COLUMN = 24,
+
+ /**
+ * @generated from enum value: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND = 25;
+ */
+ STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND = 25,
+
+ /**
+ * @generated from enum value: STATEMENT_AFFECTED_ROW_LIMIT = 26;
+ */
+ STATEMENT_AFFECTED_ROW_LIMIT = 26,
+
+ /**
+ * @generated from enum value: STATEMENT_DML_DRY_RUN = 27;
+ */
+ STATEMENT_DML_DRY_RUN = 27,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT = 28;
+ */
+ STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT = 28,
+
+ /**
+ * @generated from enum value: STATEMENT_ADD_CHECK_NOT_VALID = 29;
+ */
+ STATEMENT_ADD_CHECK_NOT_VALID = 29,
+
+ /**
+ * @generated from enum value: STATEMENT_ADD_FOREIGN_KEY_NOT_VALID = 30;
+ */
+ STATEMENT_ADD_FOREIGN_KEY_NOT_VALID = 30,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_ADD_NOT_NULL = 31;
+ */
+ STATEMENT_DISALLOW_ADD_NOT_NULL = 31,
+
+ /**
+ * @generated from enum value: STATEMENT_SELECT_FULL_TABLE_SCAN = 32;
+ */
+ STATEMENT_SELECT_FULL_TABLE_SCAN = 32,
+
+ /**
+ * @generated from enum value: STATEMENT_CREATE_SPECIFY_SCHEMA = 33;
+ */
+ STATEMENT_CREATE_SPECIFY_SCHEMA = 33,
+
+ /**
+ * @generated from enum value: STATEMENT_CHECK_SET_ROLE_VARIABLE = 34;
+ */
+ STATEMENT_CHECK_SET_ROLE_VARIABLE = 34,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_USING_FILESORT = 35;
+ */
+ STATEMENT_DISALLOW_USING_FILESORT = 35,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_USING_TEMPORARY = 36;
+ */
+ STATEMENT_DISALLOW_USING_TEMPORARY = 36,
+
+ /**
+ * @generated from enum value: STATEMENT_WHERE_NO_EQUAL_NULL = 37;
+ */
+ STATEMENT_WHERE_NO_EQUAL_NULL = 37,
+
+ /**
+ * @generated from enum value: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38;
+ */
+ STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38,
+
+ /**
+ * @generated from enum value: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39;
+ */
+ STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39,
+
+ /**
+ * @generated from enum value: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40;
+ */
+ STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40,
+
+ /**
+ * @generated from enum value: STATEMENT_MAXIMUM_LIMIT_VALUE = 41;
+ */
+ STATEMENT_MAXIMUM_LIMIT_VALUE = 41,
+
+ /**
+ * @generated from enum value: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42;
+ */
+ STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42,
+
+ /**
+ * @generated from enum value: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43;
+ */
+ STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43,
+
+ /**
+ * @generated from enum value: STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44;
+ */
+ STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44,
+
+ /**
+ * @generated from enum value: STATEMENT_NON_TRANSACTIONAL = 45;
+ */
+ STATEMENT_NON_TRANSACTIONAL = 45,
+
+ /**
+ * @generated from enum value: STATEMENT_ADD_COLUMN_WITHOUT_POSITION = 46;
+ */
+ STATEMENT_ADD_COLUMN_WITHOUT_POSITION = 46,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_OFFLINE_DDL = 47;
+ */
+ STATEMENT_DISALLOW_OFFLINE_DDL = 47,
+
+ /**
+ * @generated from enum value: STATEMENT_DISALLOW_CROSS_DB_QUERIES = 48;
+ */
+ STATEMENT_DISALLOW_CROSS_DB_QUERIES = 48,
+
+ /**
+ * @generated from enum value: STATEMENT_MAX_EXECUTION_TIME = 49;
+ */
+ STATEMENT_MAX_EXECUTION_TIME = 49,
+
+ /**
+ * @generated from enum value: STATEMENT_REQUIRE_ALGORITHM_OPTION = 50;
+ */
+ STATEMENT_REQUIRE_ALGORITHM_OPTION = 50,
+
+ /**
+ * @generated from enum value: STATEMENT_REQUIRE_LOCK_OPTION = 51;
+ */
+ STATEMENT_REQUIRE_LOCK_OPTION = 51,
+
+ /**
+ * @generated from enum value: STATEMENT_OBJECT_OWNER_CHECK = 52;
+ */
+ STATEMENT_OBJECT_OWNER_CHECK = 52,
+
+ /**
+ * @generated from enum value: TABLE_REQUIRE_PK = 53;
+ */
+ TABLE_REQUIRE_PK = 53,
+
+ /**
+ * @generated from enum value: TABLE_NO_FOREIGN_KEY = 54;
+ */
+ TABLE_NO_FOREIGN_KEY = 54,
+
+ /**
+ * @generated from enum value: TABLE_DROP_NAMING_CONVENTION = 55;
+ */
+ TABLE_DROP_NAMING_CONVENTION = 55,
+
+ /**
+ * @generated from enum value: TABLE_COMMENT = 56;
+ */
+ TABLE_COMMENT = 56,
+
+ /**
+ * @generated from enum value: TABLE_DISALLOW_PARTITION = 57;
+ */
+ TABLE_DISALLOW_PARTITION = 57,
+
+ /**
+ * @generated from enum value: TABLE_DISALLOW_TRIGGER = 58;
+ */
+ TABLE_DISALLOW_TRIGGER = 58,
+
+ /**
+ * @generated from enum value: TABLE_NO_DUPLICATE_INDEX = 59;
+ */
+ TABLE_NO_DUPLICATE_INDEX = 59,
+
+ /**
+ * @generated from enum value: TABLE_TEXT_FIELDS_TOTAL_LENGTH = 60;
+ */
+ TABLE_TEXT_FIELDS_TOTAL_LENGTH = 60,
+
+ /**
+ * @generated from enum value: TABLE_DISALLOW_SET_CHARSET = 61;
+ */
+ TABLE_DISALLOW_SET_CHARSET = 61,
+
+ /**
+ * @generated from enum value: TABLE_DISALLOW_DDL = 62;
+ */
+ TABLE_DISALLOW_DDL = 62,
+
+ /**
+ * @generated from enum value: TABLE_DISALLOW_DML = 63;
+ */
+ TABLE_DISALLOW_DML = 63,
+
+ /**
+ * @generated from enum value: TABLE_LIMIT_SIZE = 64;
+ */
+ TABLE_LIMIT_SIZE = 64,
+
+ /**
+ * @generated from enum value: TABLE_REQUIRE_CHARSET = 65;
+ */
+ TABLE_REQUIRE_CHARSET = 65,
+
+ /**
+ * @generated from enum value: TABLE_REQUIRE_COLLATION = 66;
+ */
+ TABLE_REQUIRE_COLLATION = 66,
+
+ /**
+ * @generated from enum value: COLUMN_REQUIRED = 67;
+ */
+ COLUMN_REQUIRED = 67,
+
+ /**
+ * @generated from enum value: COLUMN_NO_NULL = 68;
+ */
+ COLUMN_NO_NULL = 68,
+
+ /**
+ * @generated from enum value: COLUMN_DISALLOW_CHANGE_TYPE = 69;
+ */
+ COLUMN_DISALLOW_CHANGE_TYPE = 69,
+
+ /**
+ * @generated from enum value: COLUMN_SET_DEFAULT_FOR_NOT_NULL = 70;
+ */
+ COLUMN_SET_DEFAULT_FOR_NOT_NULL = 70,
+
+ /**
+ * @generated from enum value: COLUMN_DISALLOW_CHANGE = 71;
+ */
+ COLUMN_DISALLOW_CHANGE = 71,
+
+ /**
+ * @generated from enum value: COLUMN_DISALLOW_CHANGING_ORDER = 72;
+ */
+ COLUMN_DISALLOW_CHANGING_ORDER = 72,
+
+ /**
+ * @generated from enum value: COLUMN_DISALLOW_DROP = 73;
+ */
+ COLUMN_DISALLOW_DROP = 73,
+
+ /**
+ * @generated from enum value: COLUMN_DISALLOW_DROP_IN_INDEX = 74;
+ */
+ COLUMN_DISALLOW_DROP_IN_INDEX = 74,
+
+ /**
+ * @generated from enum value: COLUMN_COMMENT = 75;
+ */
+ COLUMN_COMMENT = 75,
+
+ /**
+ * @generated from enum value: COLUMN_AUTO_INCREMENT_MUST_INTEGER = 76;
+ */
+ COLUMN_AUTO_INCREMENT_MUST_INTEGER = 76,
+
+ /**
+ * @generated from enum value: COLUMN_TYPE_DISALLOW_LIST = 77;
+ */
+ COLUMN_TYPE_DISALLOW_LIST = 77,
+
+ /**
+ * @generated from enum value: COLUMN_DISALLOW_SET_CHARSET = 78;
+ */
+ COLUMN_DISALLOW_SET_CHARSET = 78,
+
+ /**
+ * @generated from enum value: COLUMN_MAXIMUM_CHARACTER_LENGTH = 79;
+ */
+ COLUMN_MAXIMUM_CHARACTER_LENGTH = 79,
+
+ /**
+ * @generated from enum value: COLUMN_MAXIMUM_VARCHAR_LENGTH = 80;
+ */
+ COLUMN_MAXIMUM_VARCHAR_LENGTH = 80,
+
+ /**
+ * @generated from enum value: COLUMN_AUTO_INCREMENT_INITIAL_VALUE = 81;
+ */
+ COLUMN_AUTO_INCREMENT_INITIAL_VALUE = 81,
+
+ /**
+ * @generated from enum value: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED = 82;
+ */
+ COLUMN_AUTO_INCREMENT_MUST_UNSIGNED = 82,
+
+ /**
+ * @generated from enum value: COLUMN_CURRENT_TIME_COUNT_LIMIT = 83;
+ */
+ COLUMN_CURRENT_TIME_COUNT_LIMIT = 83,
+
+ /**
+ * @generated from enum value: COLUMN_REQUIRE_DEFAULT = 84;
+ */
+ COLUMN_REQUIRE_DEFAULT = 84,
+
+ /**
+ * @generated from enum value: COLUMN_DEFAULT_DISALLOW_VOLATILE = 85;
+ */
+ COLUMN_DEFAULT_DISALLOW_VOLATILE = 85,
+
+ /**
+ * @generated from enum value: COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT = 86;
+ */
+ COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT = 86,
+
+ /**
+ * @generated from enum value: COLUMN_REQUIRE_CHARSET = 87;
+ */
+ COLUMN_REQUIRE_CHARSET = 87,
+
+ /**
+ * @generated from enum value: COLUMN_REQUIRE_COLLATION = 88;
+ */
+ COLUMN_REQUIRE_COLLATION = 88,
+
+ /**
+ * @generated from enum value: SCHEMA_BACKWARD_COMPATIBILITY = 89;
+ */
+ SCHEMA_BACKWARD_COMPATIBILITY = 89,
+
+ /**
+ * @generated from enum value: DATABASE_DROP_EMPTY_DATABASE = 90;
+ */
+ DATABASE_DROP_EMPTY_DATABASE = 90,
+
+ /**
+ * @generated from enum value: INDEX_NO_DUPLICATE_COLUMN = 91;
+ */
+ INDEX_NO_DUPLICATE_COLUMN = 91,
+
+ /**
+ * @generated from enum value: INDEX_KEY_NUMBER_LIMIT = 92;
+ */
+ INDEX_KEY_NUMBER_LIMIT = 92,
+
+ /**
+ * @generated from enum value: INDEX_PK_TYPE_LIMIT = 93;
+ */
+ INDEX_PK_TYPE_LIMIT = 93,
+
+ /**
+ * @generated from enum value: INDEX_TYPE_NO_BLOB = 94;
+ */
+ INDEX_TYPE_NO_BLOB = 94,
+
+ /**
+ * @generated from enum value: INDEX_TOTAL_NUMBER_LIMIT = 95;
+ */
+ INDEX_TOTAL_NUMBER_LIMIT = 95,
+
+ /**
+ * @generated from enum value: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST = 96;
+ */
+ INDEX_PRIMARY_KEY_TYPE_ALLOWLIST = 96,
+
+ /**
+ * @generated from enum value: INDEX_CREATE_CONCURRENTLY = 97;
+ */
+ INDEX_CREATE_CONCURRENTLY = 97,
+
+ /**
+ * @generated from enum value: INDEX_TYPE_ALLOW_LIST = 98;
+ */
+ INDEX_TYPE_ALLOW_LIST = 98,
+
+ /**
+ * @generated from enum value: INDEX_NOT_REDUNDANT = 99;
+ */
+ INDEX_NOT_REDUNDANT = 99,
+
+ /**
+ * @generated from enum value: SYSTEM_CHARSET_ALLOWLIST = 100;
+ */
+ SYSTEM_CHARSET_ALLOWLIST = 100,
+
+ /**
+ * @generated from enum value: SYSTEM_COLLATION_ALLOWLIST = 101;
+ */
+ SYSTEM_COLLATION_ALLOWLIST = 101,
+
+ /**
+ * @generated from enum value: SYSTEM_COMMENT_LENGTH = 102;
+ */
+ SYSTEM_COMMENT_LENGTH = 102,
+
+ /**
+ * @generated from enum value: SYSTEM_PROCEDURE_DISALLOW_CREATE = 103;
+ */
+ SYSTEM_PROCEDURE_DISALLOW_CREATE = 103,
+
+ /**
+ * @generated from enum value: SYSTEM_EVENT_DISALLOW_CREATE = 104;
+ */
+ SYSTEM_EVENT_DISALLOW_CREATE = 104,
+
+ /**
+ * @generated from enum value: SYSTEM_VIEW_DISALLOW_CREATE = 105;
+ */
+ SYSTEM_VIEW_DISALLOW_CREATE = 105,
+
+ /**
+ * @generated from enum value: SYSTEM_FUNCTION_DISALLOW_CREATE = 106;
+ */
+ SYSTEM_FUNCTION_DISALLOW_CREATE = 106,
+
+ /**
+ * @generated from enum value: SYSTEM_FUNCTION_DISALLOWED_LIST = 107;
+ */
+ SYSTEM_FUNCTION_DISALLOWED_LIST = 107,
+
+ /**
+ * @generated from enum value: ADVICE_ONLINE_MIGRATION = 108;
+ */
+ ADVICE_ONLINE_MIGRATION = 108,
+
+ /**
+ * @generated from enum value: BUILTIN_PRIOR_BACKUP_CHECK = 109;
+ */
+ BUILTIN_PRIOR_BACKUP_CHECK = 109,
+}
+
+/**
+ * Describes the enum bytebase.v1.SQLReviewRule.Type.
+ */
+export declare const SQLReviewRule_TypeSchema: GenEnum<SQLReviewRule_Type>;
+
/**
* ReviewConfigService manages approval flow configurations.
*
diff --git a/frontend/src/types/proto-es/v1/review_config_service_pb.js b/frontend/src/types/proto-es/v1/review_config_service_pb.js
index e9bafb4dce..e2785a1a69 100644
--- a/frontend/src/types/proto-es/v1/review_config_service_pb.js
+++ b/frontend/src/types/proto-es/v1/review_config_service_pb.js
@@ -16,7 +16,7 @@ import { file_v1_common } from "./common_pb";
* Describes the file v1/review_config_service.proto.
*/
export const file_v1_review_config_service = /*@__PURE__*/
- fileDesc("Ch52MS9yZXZpZXdfY29uZmlnX3NlcnZpY2UucHJvdG8SC2J5dGViYXNlLnYxIhoKGExpc3RSZXZpZXdDb25maWdzUmVxdWVzdCJOChlMaXN0UmV2aWV3Q29uZmlnc1Jlc3BvbnNlEjEKDnJldmlld19jb25maWdzGAEgAygLMhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIlIKGUNyZWF0ZVJldmlld0NvbmZpZ1JlcXVlc3QSNQoNcmV2aWV3X2NvbmZpZxgBIAEoCzIZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZ0ID4EECIpoBChlVcGRhdGVSZXZpZXdDb25maWdSZXF1ZXN0EjUKDXJldmlld19jb25maWcYASABKAsyGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWdCA+BBAhIvCgt1cGRhdGVfbWFzaxgCIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2sSFQoNYWxsb3dfbWlzc2luZxgDIAEoCCJJChZHZXRSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyJMChlEZWxldGVSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyLHAQoMUmV2aWV3Q29uZmlnEhEKBG5hbWUYASABKAlCA+BBAxIXCgV0aXRsZRgCIAEoCUIIukgFcgMYyAESDwoHZW5hYmxlZBgDIAEoCBIpCgVydWxlcxgHIAMoCzIaLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUSEQoJcmVzb3VyY2VzGAggAygJOjzqQTkKGWJ5dGViYXNlLmNvbS9SZXZpZXdDb25maWcSHHJldmlld0NvbmZpZ3Mve3Jldmlld0NvbmZpZ30ivAEKDVNRTFJldmlld1J1bGUSDAoEdHlwZRgBIAEoCRIvCgVsZXZlbBgCIAEoDjIgLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuTGV2ZWwSDwoHcGF5bG9hZBgDIAEoCRIjCgZlbmdpbmUYBCABKA4yEy5ieXRlYmFzZS52MS5FbmdpbmUiNgoFTGV2ZWwSFQoRTEVWRUxfVU5TUEVDSUZJRUQQABIJCgVFUlJPUhABEgsKB1dBUk5JTkcQAjLtBgoTUmV2aWV3Q29uZmlnU2VydmljZRKjAQoSQ3JlYXRlUmV2aWV3Q29uZmlnEiYuYnl0ZWJhc2UudjEuQ3JlYXRlUmV2aWV3Q29uZmlnUmVxdWVzdBoZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZyJK2kEAiuowF2JiLnJldmlld0NvbmZpZ3MuY3JlYXRlkOowAYLT5JMCIjoNcmV2aWV3X2NvbmZpZyIRL3YxL3Jldmlld0NvbmZpZ3MSnQEKEUxpc3RSZXZpZXdDb25maWdzEiUuYnl0ZWJhc2UudjEuTGlzdFJldmlld0NvbmZpZ3NSZXF1ZXN0GiYuYnl0ZWJhc2UudjEuTGlzdFJldmlld0NvbmZpZ3NSZXNwb25zZSI52kEAiuowFWJiLnJldmlld0NvbmZpZ3MubGlzdJDqMAGC0+STAhMSES92MS9yZXZpZXdDb25maWdzEpgBCg9HZXRSZXZpZXdDb25maWcSIy5ieXRlYmFzZS52MS5HZXRSZXZpZXdDb25maWdSZXF1ZXN0GhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIkXaQQRuYW1liuowFGJiLnJldmlld0NvbmZpZ3MuZ2V0kOowAYLT5JMCHBIaL3YxL3tuYW1lPXJldmlld0NvbmZpZ3MvKn0S0wEKElVwZGF0ZVJldmlld0NvbmZpZxImLmJ5dGViYXNlLnYxLlVwZGF0ZVJldmlld0NvbmZpZ1JlcXVlc3QaGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWcietpBGXJldmlld19jb25maWcsdXBkYXRlX21hc2uK6jAXYmIucmV2aWV3Q29uZmlncy51cGRhdGWQ6jABgtPkkwI5Og1yZXZpZXdfY29uZmlnMigvdjEve3Jldmlld19jb25maWcubmFtZT1yZXZpZXdDb25maWdzLyp9Ep4BChJEZWxldGVSZXZpZXdDb25maWcSJi5ieXRlYmFzZS52MS5EZWxldGVSZXZpZXdDb25maWdSZXF1ZXN0GhYuZ29vZ2xlLnByb3RvYnVmLkVtcHR5IkjaQQRuYW1liuowF2JiLnJldmlld0NvbmZpZ3MuZGVsZXRlkOowAYLT5JMCHCoaL3YxL3tuYW1lPXJldmlld0NvbmZpZ3MvKn1CrgEKD2NvbS5ieXRlYmFzZS52MUIYUmV2aWV3Q29uZmlnU2VydmljZVByb3RvUAFaNGdpdGh1Yi5jb20vYnl0ZWJhc2UvYnl0ZWJhc2UvYmFja2VuZC9nZW5lcmF0ZWQtZ28vdjGiAgNCWFiqAgtCeXRlYmFzZS5WMcoCC0J5dGViYXNlXFYx4gIXQnl0ZWJhc2VcVjFcR1BCTWV0YWRhdGHqAgxCeXRlYmFzZTo6VjFiBnByb3RvMw", [file_buf_validate_validate, file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_field_mask, file_v1_annotation, file_v1_common]);
+ fileDesc("Ch52MS9yZXZpZXdfY29uZmlnX3NlcnZpY2UucHJvdG8SC2J5dGViYXNlLnYxIhoKGExpc3RSZXZpZXdDb25maWdzUmVxdWVzdCJOChlMaXN0UmV2aWV3Q29uZmlnc1Jlc3BvbnNlEjEKDnJldmlld19jb25maWdzGAEgAygLMhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIlIKGUNyZWF0ZVJldmlld0NvbmZpZ1JlcXVlc3QSNQoNcmV2aWV3X2NvbmZpZxgBIAEoCzIZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZ0ID4EECIpoBChlVcGRhdGVSZXZpZXdDb25maWdSZXF1ZXN0EjUKDXJldmlld19jb25maWcYASABKAsyGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWdCA+BBAhIvCgt1cGRhdGVfbWFzaxgCIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2sSFQoNYWxsb3dfbWlzc2luZxgDIAEoCCJJChZHZXRSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyJMChlEZWxldGVSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyLHAQoMUmV2aWV3Q29uZmlnEhEKBG5hbWUYASABKAlCA+BBAxIXCgV0aXRsZRgCIAEoCUIIukgFcgMYyAESDwoHZW5hYmxlZBgDIAEoCBIpCgVydWxlcxgHIAMoCzIaLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUSEQoJcmVzb3VyY2VzGAggAygJOjzqQTkKGWJ5dGViYXNlLmNvbS9SZXZpZXdDb25maWcSHHJldmlld0NvbmZpZ3Mve3Jldmlld0NvbmZpZ30ikB4KDVNRTFJldmlld1J1bGUSLQoEdHlwZRgBIAEoDjIfLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuVHlwZRIvCgVsZXZlbBgCIAEoDjIgLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuTGV2ZWwSDwoHcGF5bG9hZBgDIAEoCRIjCgZlbmdpbmUYBCABKA4yEy5ieXRlYmFzZS52MS5FbmdpbmUiNgoFTGV2ZWwSFQoRTEVWRUxfVU5TUEVDSUZJRUQQABIJCgVFUlJPUhABEgsKB1dBUk5JTkcQAiKwHAoEVHlwZRIUChBUWVBFX1VOU1BFQ0lGSUVEEAASGwoXRU5HSU5FX01ZU1FMX1VTRV9JTk5PREIQARIaChZOQU1JTkdfRlVMTFlfUVVBTElGSUVEEAISEAoMTkFNSU5HX1RBQkxFEAMSEQoNTkFNSU5HX0NPTFVNThAEEhMKD05BTUlOR19JTkRFWF9QSxAFEhMKD05BTUlOR19JTkRFWF9VSxAGEhMKD05BTUlOR19JTkRFWF9GSxAHEhQKEE5BTUlOR19JTkRFWF9JRFgQCBIgChxOQU1JTkdfQ09MVU1OX0FVVE9fSU5DUkVNRU5UEAkSGwoXTkFNSU5HX1RBQkxFX05PX0tFWVdPUkQQChIgChxOQU1JTkdfSURFTlRJRklFUl9OT19LRVlXT1JEEAsSGgoWTkFNSU5HX0lERU5USUZJRVJfQ0FTRRAMEiIKHlNUQVRFTUVOVF9TRUxFQ1RfTk9fU0VMRUNUX0FMTBANEiIKHlNUQVRFTUVOVF9XSEVSRV9SRVFVSVJFX1NFTEVDVBAOEikKJVNUQVRFTUVOVF9XSEVSRV9SRVFVSVJFX1VQREFURV9ERUxFVEUQDxIsCihTVEFURU1FTlRfV0hFUkVfTk9fTEVBRElOR19XSUxEQ0FSRF9MSUtFEBASJQohU1RBVEVNRU5UX0RJU0FMTE9XX09OX0RFTF9DQVNDQURFEBESJQohU1RBVEVNRU5UX0RJU0FMTE9XX1JNX1RCTF9DQVNDQURFEBISHQoZU1RBVEVNRU5UX0RJU0FMTE9XX0NPTU1JVBATEhwKGFNUQVRFTUVOVF9ESVNBTExPV19MSU1JVBAUEh8KG1NUQVRFTUVOVF9ESVNBTExPV19PUkRFUl9CWRAVEh8KG1NUQVRFTUVOVF9NRVJHRV9BTFRFUl9UQUJMRRAWEh4KGlNUQVRFTUVOVF9JTlNFUlRfUk9XX0xJTUlUEBcSKAokU1RBVEVNRU5UX0lOU0VSVF9NVVNUX1NQRUNJRllfQ09MVU1OEBgSKwonU1RBVEVNRU5UX0lOU0VSVF9ESVNBTExPV19PUkRFUl9CWV9SQU5EEBkSIAocU1RBVEVNRU5UX0FGRkVDVEVEX1JPV19MSU1JVBAaEhkKFVNUQVRFTUVOVF9ETUxfRFJZX1JVThAbEi4KKlNUQVRFTUVOVF9ESVNBTExPV19BRERfQ09MVU1OX1dJVEhfREVGQVVMVBAcEiEKHVNUQVRFTUVOVF9BRERfQ0hFQ0tfTk9UX1ZBTElEEB0SJwojU1RBVEVNRU5UX0FERF9GT1JFSUdOX0tFWV9OT1RfVkFMSUQQHhIjCh9TVEFURU1FTlRfRElTQUxMT1dfQUREX05PVF9OVUxMEB8SJAogU1RBVEVNRU5UX1NFTEVDVF9GVUxMX1RBQkxFX1NDQU4QIBIjCh9TVEFURU1FTlRfQ1JFQVRFX1NQRUNJRllfU0NIRU1BECESJQohU1RBVEVNRU5UX0NIRUNLX1NFVF9ST0xFX1ZBUklBQkxFECISJQohU1RBVEVNRU5UX0RJU0FMTE9XX1VTSU5HX0ZJTEVTT1JUECMSJgoiU1RBVEVNRU5UX0RJU0FMTE9XX1VTSU5HX1RFTVBPUkFSWRAkEiEKHVNUQVRFTUVOVF9XSEVSRV9OT19FUVVBTF9OVUxMECUSNwozU1RBVEVNRU5UX1dIRVJFX0RJU0FMTE9XX0ZVTkNUSU9OU19BTkRfQ0FMQ1VMQVRJT05TECYSJgoiU1RBVEVNRU5UX1FVRVJZX01JTklNVU1fUExBTl9MRVZFTBAnEjIKLlNUQVRFTUVOVF9XSEVSRV9NQVhJTVVNX0xPR0lDQUxfT1BFUkFUT1JfQ09VTlQQKBIhCh1TVEFURU1FTlRfTUFYSU1VTV9MSU1JVF9WQUxVRRApEiYKIlNUQVRFTUVOVF9NQVhJTVVNX0pPSU5fVEFCTEVfQ09VTlQQKhIvCitTVEFURU1FTlRfTUFYSU1VTV9TVEFURU1FTlRTX0lOX1RSQU5TQUNUSU9OECsSJgoiU1RBVEVNRU5UX0pPSU5fU1RSSUNUX0NPTFVNTl9BVFRSUxAsEh8KG1NUQVRFTUVOVF9OT05fVFJBTlNBQ1RJT05BTBAtEikKJVNUQVRFTUVOVF9BRERfQ09MVU1OX1dJVEhPVVRfUE9TSVRJT04QLhIiCh5TVEFURU1FTlRfRElTQUxMT1dfT0ZGTElORV9EREwQLxInCiNTVEFURU1FTlRfRElTQUxMT1dfQ1JPU1NfREJfUVVFUklFUxAwEiAKHFNUQVRFTUVOVF9NQVhfRVhFQ1VUSU9OX1RJTUUQMRImCiJTVEFURU1FTlRfUkVRVUlSRV9BTEdPUklUSE1fT1BUSU9OEDISIQodU1RBVEVNRU5UX1JFUVVJUkVfTE9DS19PUFRJT04QMxIgChxTVEFURU1FTlRfT0JKRUNUX09XTkVSX0NIRUNLEDQSFAoQVEFCTEVfUkVRVUlSRV9QSxA1EhgKFFRBQkxFX05PX0ZPUkVJR05fS0VZEDYSIAocVEFCTEVfRFJPUF9OQU1JTkdfQ09OVkVOVElPThA3EhEKDVRBQkxFX0NPTU1FTlQQOBIcChhUQUJMRV9ESVNBTExPV19QQVJUSVRJT04QORIaChZUQUJMRV9ESVNBTExPV19UUklHR0VSEDoSHAoYVEFCTEVfTk9fRFVQTElDQVRFX0lOREVYEDsSIgoeVEFCTEVfVEVYVF9GSUVMRFNfVE9UQUxfTEVOR1RIEDwSHgoaVEFCTEVfRElTQUxMT1dfU0VUX0NIQVJTRVQQPRIWChJUQUJMRV9ESVNBTExPV19EREwQPhIWChJUQUJMRV9ESVNBTExPV19ETUwQPxIUChBUQUJMRV9MSU1JVF9TSVpFEEASGQoVVEFCTEVfUkVRVUlSRV9DSEFSU0VUEEESGwoXVEFCTEVfUkVRVUlSRV9DT0xMQVRJT04QQhITCg9DT0xVTU5fUkVRVUlSRUQQQxISCg5DT0xVTU5fTk9fTlVMTBBEEh8KG0NPTFVNTl9ESVNBTExPV19DSEFOR0VfVFlQRRBFEiMKH0NPTFVNTl9TRVRfREVGQVVMVF9GT1JfTk9UX05VTEwQRhIaChZDT0xVTU5fRElTQUxMT1dfQ0hBTkdFEEcSIgoeQ09MVU1OX0RJU0FMTE9XX0NIQU5HSU5HX09SREVSEEgSGAoUQ09MVU1OX0RJU0FMTE9XX0RST1AQSRIhCh1DT0xVTU5fRElTQUxMT1dfRFJPUF9JTl9JTkRFWBBKEhIKDkNPTFVNTl9DT01NRU5UEEsSJgoiQ09MVU1OX0FVVE9fSU5DUkVNRU5UX01VU1RfSU5URUdFUhBMEh0KGUNPTFVNTl9UWVBFX0RJU0FMTE9XX0xJU1QQTRIfChtDT0xVTU5fRElTQUxMT1dfU0VUX0NIQVJTRVQQThIjCh9DT0xVTU5fTUFYSU1VTV9DSEFSQUNURVJfTEVOR1RIEE8SIQodQ09MVU1OX01BWElNVU1fVkFSQ0hBUl9MRU5HVEgQUBInCiNDT0xVTU5fQVVUT19JTkNSRU1FTlRfSU5JVElBTF9WQUxVRRBREicKI0NPTFVNTl9BVVRPX0lOQ1JFTUVOVF9NVVNUX1VOU0lHTkVEEFISIwofQ09MVU1OX0NVUlJFTlRfVElNRV9DT1VOVF9MSU1JVBBTEhoKFkNPTFVNTl9SRVFVSVJFX0RFRkFVTFQQVBIkCiBDT0xVTU5fREVGQVVMVF9ESVNBTExPV19WT0xBVElMRRBVEicKI0NPTFVNTl9BRERfTk9UX05VTExfUkVRVUlSRV9ERUZBVUxUEFYSGgoWQ09MVU1OX1JFUVVJUkVfQ0hBUlNFVBBXEhwKGENPTFVNTl9SRVFVSVJFX0NPTExBVElPThBYEiEKHVNDSEVNQV9CQUNLV0FSRF9DT01QQVRJQklMSVRZEFkSIAocREFUQUJBU0VfRFJPUF9FTVBUWV9EQVRBQkFTRRBaEh0KGUlOREVYX05PX0RVUExJQ0FURV9DT0xVTU4QWxIaChZJTkRFWF9LRVlfTlVNQkVSX0xJTUlUEFwSFwoTSU5ERVhfUEtfVFlQRV9MSU1JVBBdEhYKEklOREVYX1RZUEVfTk9fQkxPQhBeEhwKGElOREVYX1RPVEFMX05VTUJFUl9MSU1JVBBfEiQKIElOREVYX1BSSU1BUllfS0VZX1RZUEVfQUxMT1dMSVNUEGASHQoZSU5ERVhfQ1JFQVRFX0NPTkNVUlJFTlRMWRBhEhkKFUlOREVYX1RZUEVfQUxMT1dfTElTVBBiEhcKE0lOREVYX05PVF9SRURVTkRBTlQQYxIcChhTWVNURU1fQ0hBUlNFVF9BTExPV0xJU1QQZBIeChpTWVNURU1fQ09MTEFUSU9OX0FMTE9XTElTVBBlEhkKFVNZU1RFTV9DT01NRU5UX0xFTkdUSBBmEiQKIFNZU1RFTV9QUk9DRURVUkVfRElTQUxMT1dfQ1JFQVRFEGcSIAocU1lTVEVNX0VWRU5UX0RJU0FMTE9XX0NSRUFURRBoEh8KG1NZU1RFTV9WSUVXX0RJU0FMTE9XX0NSRUFURRBpEiMKH1NZU1RFTV9GVU5DVElPTl9ESVNBTExPV19DUkVBVEUQahIjCh9TWVNURU1fRlVOQ1RJT05fRElTQUxMT1dFRF9MSVNUEGsSGwoXQURWSUNFX09OTElORV9NSUdSQVRJT04QbBIeChpCVUlMVElOX1BSSU9SX0JBQ0tVUF9DSEVDSxBtMu0GChNSZXZpZXdDb25maWdTZXJ2aWNlEqMBChJDcmVhdGVSZXZpZXdDb25maWcSJi5ieXRlYmFzZS52MS5DcmVhdGVSZXZpZXdDb25maWdSZXF1ZXN0GhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIkraQQCK6jAXYmIucmV2aWV3Q29uZmlncy5jcmVhdGWQ6jABgtPkkwIiOg1yZXZpZXdfY29uZmlnIhEvdjEvcmV2aWV3Q29uZmlncxKdAQoRTGlzdFJldmlld0NvbmZpZ3MSJS5ieXRlYmFzZS52MS5MaXN0UmV2aWV3Q29uZmlnc1JlcXVlc3QaJi5ieXRlYmFzZS52MS5MaXN0UmV2aWV3Q29uZmlnc1Jlc3BvbnNlIjnaQQCK6jAVYmIucmV2aWV3Q29uZmlncy5saXN0kOowAYLT5JMCExIRL3YxL3Jldmlld0NvbmZpZ3MSmAEKD0dldFJldmlld0NvbmZpZxIjLmJ5dGViYXNlLnYxLkdldFJldmlld0NvbmZpZ1JlcXVlc3QaGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWciRdpBBG5hbWWK6jAUYmIucmV2aWV3Q29uZmlncy5nZXSQ6jABgtPkkwIcEhovdjEve25hbWU9cmV2aWV3Q29uZmlncy8qfRLTAQoSVXBkYXRlUmV2aWV3Q29uZmlnEiYuYnl0ZWJhc2UudjEuVXBkYXRlUmV2aWV3Q29uZmlnUmVxdWVzdBoZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZyJ62kEZcmV2aWV3X2NvbmZpZyx1cGRhdGVfbWFza4rqMBdiYi5yZXZpZXdDb25maWdzLnVwZGF0ZZDqMAGC0+STAjk6DXJldmlld19jb25maWcyKC92MS97cmV2aWV3X2NvbmZpZy5uYW1lPXJldmlld0NvbmZpZ3MvKn0SngEKEkRlbGV0ZVJldmlld0NvbmZpZxImLmJ5dGViYXNlLnYxLkRlbGV0ZVJldmlld0NvbmZpZ1JlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiSNpBBG5hbWWK6jAXYmIucmV2aWV3Q29uZmlncy5kZWxldGWQ6jABgtPkkwIcKhovdjEve25hbWU9cmV2aWV3Q29uZmlncy8qfUKuAQoPY29tLmJ5dGViYXNlLnYxQhhSZXZpZXdDb25maWdTZXJ2aWNlUHJvdG9QAVo0Z2l0aHViLmNvbS9ieXRlYmFzZS9ieXRlYmFzZS9iYWNrZW5kL2dlbmVyYXRlZC1nby92MaICA0JYWKoCC0J5dGViYXNlLlYxygILQnl0ZWJhc2VcVjHiAhdCeXRlYmFzZVxWMVxHUEJNZXRhZGF0YeoCDEJ5dGViYXNlOjpWMWIGcHJvdG8z", [file_buf_validate_validate, file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_field_mask, file_v1_annotation, file_v1_common]);
/**
* Describes the message bytebase.v1.ListReviewConfigsRequest.
@@ -88,6 +88,18 @@ export const SQLReviewRule_LevelSchema = /*@__PURE__*/
export const SQLReviewRule_Level = /*@__PURE__*/
tsEnum(SQLReviewRule_LevelSchema);
+/**
+ * Describes the enum bytebase.v1.SQLReviewRule.Type.
+ */
+export const SQLReviewRule_TypeSchema = /*@__PURE__*/
+ enumDesc(file_v1_review_config_service, 7, 1);
+
+/**
+ * @generated from enum bytebase.v1.SQLReviewRule.Type
+ */
+export const SQLReviewRule_Type = /*@__PURE__*/
+ tsEnum(SQLReviewRule_TypeSchema);
+
/**
* ReviewConfigService manages approval flow configurations.
*
diff --git a/frontend/src/types/sql-review-schema.yaml b/frontend/src/types/sql-review-schema.yaml
index e906ee59a8..1a5a95d466 100644
--- a/frontend/src/types/sql-review-schema.yaml
+++ b/frontend/src/types/sql-review-schema.yaml
@@ -1,58 +1,58 @@
-- type: engine.mysql.use-innodb
+- type: ENGINE_MYSQL_USE_INNODB
category: ENGINE
engine: MYSQL
-- type: engine.mysql.use-innodb
+- type: ENGINE_MYSQL_USE_INNODB
category: ENGINE
engine: MARIADB
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: MYSQL
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: TIDB
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: POSTGRES
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: ORACLE
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: OCEANBASE
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: SNOWFLAKE
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: MSSQL
-- type: table.require-pk
+- type: TABLE_REQUIRE_PK
category: TABLE
engine: MARIADB
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: MYSQL
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: TIDB
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: POSTGRES
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: ORACLE
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: OCEANBASE
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: SNOWFLAKE
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: MSSQL
-- type: table.no-foreign-key
+- type: TABLE_NO_FOREIGN_KEY
category: TABLE
engine: MARIADB
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -60,7 +60,7 @@
type: STRING
default: _del$
engine: MYSQL
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -68,7 +68,7 @@
type: STRING
default: _del$
engine: TIDB
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -76,7 +76,7 @@
type: STRING
default: _del$
engine: POSTGRES
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -84,7 +84,7 @@
type: STRING
default: _del$
engine: OCEANBASE
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -92,7 +92,7 @@
type: STRING
default: _del$
engine: SNOWFLAKE
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -100,7 +100,7 @@
type: STRING
default: _del$
engine: REDSHIFT
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -108,7 +108,7 @@
type: STRING
default: _del$
engine: MSSQL
-- type: table.drop-naming-convention
+- type: TABLE_DROP_NAMING_CONVENTION
category: TABLE
componentList:
- key: format
@@ -116,7 +116,7 @@
type: STRING
default: _del$
engine: MARIADB
-- type: table.comment
+- type: TABLE_COMMENT
category: TABLE
componentList:
- key: required
@@ -132,7 +132,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: table.comment
+- type: TABLE_COMMENT
category: TABLE
componentList:
- key: required
@@ -148,7 +148,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: table.comment
+- type: TABLE_COMMENT
category: TABLE
componentList:
- key: required
@@ -164,7 +164,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: table.comment
+- type: TABLE_COMMENT
category: TABLE
componentList:
- key: required
@@ -180,7 +180,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: table.comment
+- type: TABLE_COMMENT
category: TABLE
componentList:
- key: required
@@ -196,28 +196,28 @@
type: NUMBER
default: 64
engine: ORACLE
-- type: table.disallow-partition
+- type: TABLE_DISALLOW_PARTITION
category: TABLE
engine: MYSQL
-- type: table.disallow-partition
+- type: TABLE_DISALLOW_PARTITION
category: TABLE
engine: TIDB
-- type: table.disallow-partition
+- type: TABLE_DISALLOW_PARTITION
category: TABLE
engine: POSTGRES
-- type: table.disallow-partition
+- type: TABLE_DISALLOW_PARTITION
category: TABLE
engine: OCEANBASE
-- type: table.disallow-partition
+- type: TABLE_DISALLOW_PARTITION
category: TABLE
engine: MARIADB
-- type: table.disallow-trigger
+- type: TABLE_DISALLOW_TRIGGER
category: TABLE
engine: MYSQL
-- type: table.no-duplicate-index
+- type: TABLE_NO_DUPLICATE_INDEX
category: TABLE
engine: MYSQL
-- type: table.text-fields-total-length
+- type: TABLE_TEXT_FIELDS_TOTAL_LENGTH
category: TABLE
componentList:
- key: number
@@ -225,10 +225,10 @@
type: NUMBER
default: 1000
engine: MYSQL
-- type: table.disallow-set-charset
+- type: TABLE_DISALLOW_SET_CHARSET
category: TABLE
engine: MYSQL
-- type: table.disallow-ddl
+- type: TABLE_DISALLOW_DDL
category: TABLE
componentList:
- key: list
@@ -236,7 +236,7 @@
type: STRING_ARRAY
default: []
engine: MSSQL
-- type: table.disallow-ddl
+- type: TABLE_DISALLOW_DDL
category: TABLE
componentList:
- key: list
@@ -244,7 +244,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: table.disallow-dml
+- type: TABLE_DISALLOW_DML
category: TABLE
componentList:
- key: list
@@ -252,7 +252,7 @@
type: STRING_ARRAY
default: []
engine: MSSQL
-- type: table.disallow-dml
+- type: TABLE_DISALLOW_DML
category: TABLE
componentList:
- key: list
@@ -260,7 +260,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: table.limit-size
+- type: TABLE_LIMIT_SIZE
category: TABLE
componentList:
- key: number
@@ -268,163 +268,163 @@
type: NUMBER
default: 10000000
engine: MYSQL
-- type: table.require-charset
+- type: TABLE_REQUIRE_CHARSET
category: TABLE
engine: MYSQL
-- type: table.require-collation
+- type: TABLE_REQUIRE_COLLATION
category: TABLE
engine: MYSQL
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: MYSQL
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: TIDB
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: POSTGRES
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: ORACLE
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: OCEANBASE
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: SNOWFLAKE
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: MSSQL
-- type: statement.select.no-select-all
+- type: STATEMENT_SELECT_NO_SELECT_ALL
category: STATEMENT
engine: MARIADB
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: MYSQL
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: TIDB
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: POSTGRES
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: ORACLE
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: OCEANBASE
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: SNOWFLAKE
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: MSSQL
-- type: statement.where.require.select
+- type: STATEMENT_WHERE_REQUIRE_SELECT
category: STATEMENT
engine: MARIADB
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: MYSQL
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: TIDB
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: POSTGRES
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: ORACLE
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: OCEANBASE
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: SNOWFLAKE
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: MSSQL
-- type: statement.where.require.update-delete
+- type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
category: STATEMENT
engine: MARIADB
-- type: statement.where.no-leading-wildcard-like
+- type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
category: STATEMENT
engine: MYSQL
-- type: statement.where.no-leading-wildcard-like
+- type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
category: STATEMENT
engine: TIDB
-- type: statement.where.no-leading-wildcard-like
+- type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
category: STATEMENT
engine: POSTGRES
-- type: statement.where.no-leading-wildcard-like
+- type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
category: STATEMENT
engine: ORACLE
-- type: statement.where.no-leading-wildcard-like
+- type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
category: STATEMENT
engine: OCEANBASE
-- type: statement.where.no-leading-wildcard-like
+- type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
category: STATEMENT
engine: MARIADB
-- type: statement.disallow-on-del-cascade
+- type: STATEMENT_DISALLOW_ON_DEL_CASCADE
category: STATEMENT
engine: POSTGRES
-- type: statement.disallow-rm-tbl-cascade
+- type: STATEMENT_DISALLOW_RM_TBL_CASCADE
category: STATEMENT
engine: POSTGRES
-- type: statement.disallow-commit
+- type: STATEMENT_DISALLOW_COMMIT
category: STATEMENT
engine: MYSQL
-- type: statement.disallow-commit
+- type: STATEMENT_DISALLOW_COMMIT
category: STATEMENT
engine: TIDB
-- type: statement.disallow-commit
+- type: STATEMENT_DISALLOW_COMMIT
category: STATEMENT
engine: POSTGRES
-- type: statement.disallow-commit
+- type: STATEMENT_DISALLOW_COMMIT
category: STATEMENT
engine: OCEANBASE
-- type: statement.disallow-commit
+- type: STATEMENT_DISALLOW_COMMIT
category: STATEMENT
engine: MARIADB
-- type: statement.disallow-limit
+- type: STATEMENT_DISALLOW_LIMIT
category: STATEMENT
engine: MYSQL
-- type: statement.disallow-limit
+- type: STATEMENT_DISALLOW_LIMIT
category: STATEMENT
engine: TIDB
-- type: statement.disallow-limit
+- type: STATEMENT_DISALLOW_LIMIT
category: STATEMENT
engine: OCEANBASE
-- type: statement.disallow-limit
+- type: STATEMENT_DISALLOW_LIMIT
category: STATEMENT
engine: MARIADB
-- type: statement.disallow-order-by
+- type: STATEMENT_DISALLOW_ORDER_BY
category: STATEMENT
engine: MYSQL
-- type: statement.disallow-order-by
+- type: STATEMENT_DISALLOW_ORDER_BY
category: STATEMENT
engine: TIDB
-- type: statement.disallow-order-by
+- type: STATEMENT_DISALLOW_ORDER_BY
category: STATEMENT
engine: OCEANBASE
-- type: statement.disallow-order-by
+- type: STATEMENT_DISALLOW_ORDER_BY
category: STATEMENT
engine: MARIADB
-- type: statement.merge-alter-table
+- type: STATEMENT_MERGE_ALTER_TABLE
category: STATEMENT
engine: MYSQL
-- type: statement.merge-alter-table
+- type: STATEMENT_MERGE_ALTER_TABLE
category: STATEMENT
engine: TIDB
-- type: statement.merge-alter-table
+- type: STATEMENT_MERGE_ALTER_TABLE
category: STATEMENT
engine: POSTGRES
-- type: statement.merge-alter-table
+- type: STATEMENT_MERGE_ALTER_TABLE
category: STATEMENT
engine: OCEANBASE
-- type: statement.merge-alter-table
+- type: STATEMENT_MERGE_ALTER_TABLE
category: STATEMENT
engine: MARIADB
-- type: statement.insert.row-limit
+- type: STATEMENT_INSERT_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -432,7 +432,7 @@
type: NUMBER
default: 1000
engine: MYSQL
-- type: statement.insert.row-limit
+- type: STATEMENT_INSERT_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -440,7 +440,7 @@
type: NUMBER
default: 1000
engine: POSTGRES
-- type: statement.insert.row-limit
+- type: STATEMENT_INSERT_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -448,7 +448,7 @@
type: NUMBER
default: 1000
engine: OCEANBASE
-- type: statement.insert.row-limit
+- type: STATEMENT_INSERT_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -456,40 +456,40 @@
type: NUMBER
default: 1000
engine: MARIADB
-- type: statement.insert.must-specify-column
+- type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
category: STATEMENT
engine: MYSQL
-- type: statement.insert.must-specify-column
+- type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
category: STATEMENT
engine: TIDB
-- type: statement.insert.must-specify-column
+- type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
category: STATEMENT
engine: POSTGRES
-- type: statement.insert.must-specify-column
+- type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
category: STATEMENT
engine: ORACLE
-- type: statement.insert.must-specify-column
+- type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
category: STATEMENT
engine: OCEANBASE
-- type: statement.insert.must-specify-column
+- type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
category: STATEMENT
engine: MARIADB
-- type: statement.insert.disallow-order-by-rand
+- type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
category: STATEMENT
engine: MYSQL
-- type: statement.insert.disallow-order-by-rand
+- type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
category: STATEMENT
engine: TIDB
-- type: statement.insert.disallow-order-by-rand
+- type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
category: STATEMENT
engine: POSTGRES
-- type: statement.insert.disallow-order-by-rand
+- type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
category: STATEMENT
engine: OCEANBASE
-- type: statement.insert.disallow-order-by-rand
+- type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
category: STATEMENT
engine: MARIADB
-- type: statement.affected-row-limit
+- type: STATEMENT_AFFECTED_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -497,7 +497,7 @@
type: NUMBER
default: 1000
engine: MYSQL
-- type: statement.affected-row-limit
+- type: STATEMENT_AFFECTED_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -505,7 +505,7 @@
type: NUMBER
default: 1000
engine: POSTGRES
-- type: statement.affected-row-limit
+- type: STATEMENT_AFFECTED_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -513,7 +513,7 @@
type: NUMBER
default: 1000
engine: OCEANBASE
-- type: statement.affected-row-limit
+- type: STATEMENT_AFFECTED_ROW_LIMIT
category: STATEMENT
componentList:
- key: number
@@ -521,64 +521,64 @@
type: NUMBER
default: 1000
engine: MARIADB
-- type: statement.dml-dry-run
+- type: STATEMENT_DML_DRY_RUN
category: STATEMENT
engine: MYSQL
-- type: statement.dml-dry-run
+- type: STATEMENT_DML_DRY_RUN
category: STATEMENT
engine: POSTGRES
-- type: statement.dml-dry-run
+- type: STATEMENT_DML_DRY_RUN
category: STATEMENT
engine: OCEANBASE
-- type: statement.dml-dry-run
+- type: STATEMENT_DML_DRY_RUN
category: STATEMENT
engine: MARIADB
-- type: statement.dml-dry-run
+- type: STATEMENT_DML_DRY_RUN
category: STATEMENT
engine: TIDB
-- type: statement.dml-dry-run
+- type: STATEMENT_DML_DRY_RUN
category: STATEMENT
engine: ORACLE
-- type: statement.disallow-add-column-with-default
+- type: STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT
category: STATEMENT
engine: POSTGRES
-- type: statement.add-check-not-valid
+- type: STATEMENT_ADD_CHECK_NOT_VALID
category: STATEMENT
engine: POSTGRES
-- type: statement.disallow-add-not-null
+- type: STATEMENT_DISALLOW_ADD_NOT_NULL
category: STATEMENT
engine: POSTGRES
-- type: statement.select-full-table-scan
+- type: STATEMENT_SELECT_FULL_TABLE_SCAN
category: STATEMENT
engine: MYSQL
-- type: statement.select-full-table-scan
+- type: STATEMENT_SELECT_FULL_TABLE_SCAN
category: STATEMENT
engine: OCEANBASE
-- type: statement.select-full-table-scan
+- type: STATEMENT_SELECT_FULL_TABLE_SCAN
category: STATEMENT
engine: MARIADB
-- type: statement.create-specify-schema
+- type: STATEMENT_CREATE_SPECIFY_SCHEMA
category: STATEMENT
engine: POSTGRES
-- type: statement.check-set-role-variable
+- type: STATEMENT_CHECK_SET_ROLE_VARIABLE
category: STATEMENT
engine: POSTGRES
-- type: statement.disallow-using-temporary
+- type: STATEMENT_DISALLOW_USING_TEMPORARY
category: STATEMENT
engine: MYSQL
-- type: statement.disallow-using-filesort
+- type: STATEMENT_DISALLOW_USING_FILESORT
category: STATEMENT
engine: MYSQL
-- type: statement.where.no-equal-null
+- type: STATEMENT_WHERE_NO_EQUAL_NULL
category: STATEMENT
engine: MYSQL
-- type: statement.where.disallow-functions-and-calculations
+- type: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
category: STATEMENT
engine: MYSQL
-- type: statement.where.disallow-functions-and-calculations
+- type: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
category: STATEMENT
engine: MSSQL
-- type: statement.query.minimum-plan-level
+- type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL
category: STATEMENT
componentList:
- key: level
@@ -586,7 +586,7 @@
type: STRING
default: INDEX
engine: MYSQL
-- type: statement.where.maximum-logical-operator-count
+- type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
category: STATEMENT
componentList:
- key: number
@@ -594,7 +594,7 @@
type: NUMBER
default: 10
engine: MYSQL
-- type: statement.maximum-limit-value
+- type: STATEMENT_MAXIMUM_LIMIT_VALUE
category: STATEMENT
componentList:
- key: number
@@ -602,7 +602,7 @@
type: NUMBER
default: 1000
engine: MYSQL
-- type: statement.maximum-limit-value
+- type: STATEMENT_MAXIMUM_LIMIT_VALUE
category: STATEMENT
componentList:
- key: number
@@ -610,7 +610,7 @@
type: NUMBER
default: 1000
engine: OCEANBASE
-- type: statement.maximum-limit-value
+- type: STATEMENT_MAXIMUM_LIMIT_VALUE
category: STATEMENT
componentList:
- key: number
@@ -618,7 +618,7 @@
type: NUMBER
default: 1000
engine: MARIADB
-- type: statement.maximum-limit-value
+- type: STATEMENT_MAXIMUM_LIMIT_VALUE
category: STATEMENT
componentList:
- key: number
@@ -626,7 +626,7 @@
type: NUMBER
default: 1000
engine: TIDB
-- type: statement.maximum-limit-value
+- type: STATEMENT_MAXIMUM_LIMIT_VALUE
category: STATEMENT
componentList:
- key: number
@@ -634,7 +634,7 @@
type: NUMBER
default: 1000
engine: POSTGRES
-- type: statement.maximum-join-table-count
+- type: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT
category: STATEMENT
componentList:
- key: number
@@ -642,7 +642,7 @@
type: NUMBER
default: 2
engine: MYSQL
-- type: statement.maximum-statements-in-transaction
+- type: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION
category: STATEMENT
componentList:
- key: number
@@ -650,40 +650,40 @@
type: NUMBER
default: 10
engine: MYSQL
-- type: statement.join-strict-column-attrs
+- type: STATEMENT_JOIN_STRICT_COLUMN_ATTRS
category: STATEMENT
engine: MYSQL
-- type: statement.add-column-without-position
+- type: STATEMENT_ADD_COLUMN_WITHOUT_POSITION
category: STATEMENT
engine: OCEANBASE
-- type: statement.disallow-offline-ddl
+- type: STATEMENT_DISALLOW_OFFLINE_DDL
category: STATEMENT
engine: OCEANBASE
-- type: statement.disallow-cross-db-queries
+- type: STATEMENT_DISALLOW_CROSS_DB_QUERIES
category: STATEMENT
engine: MSSQL
-- type: statement.max-execution-time
+- type: STATEMENT_MAX_EXECUTION_TIME
category: STATEMENT
engine: MYSQL
-- type: statement.max-execution-time
+- type: STATEMENT_MAX_EXECUTION_TIME
category: STATEMENT
engine: MARIADB
-- type: statement.require-algorithm-option
+- type: STATEMENT_REQUIRE_ALGORITHM_OPTION
category: STATEMENT
engine: MYSQL
-- type: statement.require-algorithm-option
+- type: STATEMENT_REQUIRE_ALGORITHM_OPTION
category: STATEMENT
engine: MARIADB
-- type: statement.require-lock-option
+- type: STATEMENT_REQUIRE_LOCK_OPTION
category: STATEMENT
engine: MYSQL
-- type: statement.require-lock-option
+- type: STATEMENT_REQUIRE_LOCK_OPTION
category: STATEMENT
engine: MARIADB
-- type: naming.fully-qualified
+- type: NAMING_FULLY_QUALIFIED
category: NAMING
engine: POSTGRES
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -695,7 +695,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -707,7 +707,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -719,7 +719,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -731,7 +731,7 @@
type: NUMBER
default: 64
engine: ORACLE
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -743,7 +743,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -755,7 +755,7 @@
type: NUMBER
default: 64
engine: SNOWFLAKE
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -767,7 +767,7 @@
type: NUMBER
default: 64
engine: MSSQL
-- type: naming.table
+- type: NAMING_TABLE
category: NAMING
componentList:
- key: format
@@ -779,7 +779,7 @@
type: NUMBER
default: 64
engine: MARIADB
-- type: naming.column
+- type: NAMING_COLUMN
category: NAMING
componentList:
- key: format
@@ -791,7 +791,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: naming.column
+- type: NAMING_COLUMN
category: NAMING
componentList:
- key: format
@@ -803,7 +803,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: naming.column
+- type: NAMING_COLUMN
category: NAMING
componentList:
- key: format
@@ -815,7 +815,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: naming.column
+- type: NAMING_COLUMN
category: NAMING
componentList:
- key: format
@@ -827,7 +827,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: naming.column
+- type: NAMING_COLUMN
category: NAMING
componentList:
- key: format
@@ -839,7 +839,7 @@
type: NUMBER
default: 64
engine: MARIADB
-- type: naming.index.uk
+- type: NAMING_INDEX_UK
category: NAMING
componentList:
- key: format
@@ -854,7 +854,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: naming.index.uk
+- type: NAMING_INDEX_UK
category: NAMING
componentList:
- key: format
@@ -869,7 +869,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: naming.index.uk
+- type: NAMING_INDEX_UK
category: NAMING
componentList:
- key: format
@@ -884,7 +884,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: naming.index.uk
+- type: NAMING_INDEX_UK
category: NAMING
componentList:
- key: format
@@ -899,7 +899,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: naming.index.uk
+- type: NAMING_INDEX_UK
category: NAMING
componentList:
- key: format
@@ -914,7 +914,7 @@
type: NUMBER
default: 64
engine: MARIADB
-- type: naming.index.idx
+- type: NAMING_INDEX_IDX
category: NAMING
componentList:
- key: format
@@ -929,7 +929,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: naming.index.idx
+- type: NAMING_INDEX_IDX
category: NAMING
componentList:
- key: format
@@ -944,7 +944,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: naming.index.idx
+- type: NAMING_INDEX_IDX
category: NAMING
componentList:
- key: format
@@ -959,7 +959,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: naming.index.idx
+- type: NAMING_INDEX_IDX
category: NAMING
componentList:
- key: format
@@ -974,7 +974,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: naming.index.idx
+- type: NAMING_INDEX_IDX
category: NAMING
componentList:
- key: format
@@ -989,7 +989,7 @@
type: NUMBER
default: 64
engine: MARIADB
-- type: naming.index.fk
+- type: NAMING_INDEX_FK
category: NAMING
componentList:
- key: format
@@ -1006,7 +1006,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: naming.index.fk
+- type: NAMING_INDEX_FK
category: NAMING
componentList:
- key: format
@@ -1023,7 +1023,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: naming.index.fk
+- type: NAMING_INDEX_FK
category: NAMING
componentList:
- key: format
@@ -1040,7 +1040,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: naming.index.fk
+- type: NAMING_INDEX_FK
category: NAMING
componentList:
- key: format
@@ -1057,7 +1057,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: naming.index.fk
+- type: NAMING_INDEX_FK
category: NAMING
componentList:
- key: format
@@ -1074,7 +1074,7 @@
type: NUMBER
default: 64
engine: MARIADB
-- type: naming.index.pk
+- type: NAMING_INDEX_PK
category: NAMING
componentList:
- key: format
@@ -1089,7 +1089,7 @@
type: NUMBER
default: 63
engine: POSTGRES
-- type: naming.column.auto-increment
+- type: NAMING_COLUMN_AUTO_INCREMENT
category: NAMING
componentList:
- key: format
@@ -1101,7 +1101,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: naming.column.auto-increment
+- type: NAMING_COLUMN_AUTO_INCREMENT
category: NAMING
componentList:
- key: format
@@ -1113,7 +1113,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: naming.column.auto-increment
+- type: NAMING_COLUMN_AUTO_INCREMENT
category: NAMING
componentList:
- key: format
@@ -1125,7 +1125,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: naming.column.auto-increment
+- type: NAMING_COLUMN_AUTO_INCREMENT
category: NAMING
componentList:
- key: format
@@ -1137,28 +1137,28 @@
type: NUMBER
default: 64
engine: MARIADB
-- type: naming.table.no-keyword
+- type: NAMING_TABLE_NO_KEYWORD
category: NAMING
engine: ORACLE
-- type: naming.table.no-keyword
+- type: NAMING_TABLE_NO_KEYWORD
category: NAMING
engine: SNOWFLAKE
-- type: naming.table.no-keyword
+- type: NAMING_TABLE_NO_KEYWORD
category: NAMING
engine: MSSQL
-- type: naming.identifier.no-keyword
+- type: NAMING_IDENTIFIER_NO_KEYWORD
category: NAMING
engine: ORACLE
-- type: naming.identifier.no-keyword
+- type: NAMING_IDENTIFIER_NO_KEYWORD
category: NAMING
engine: SNOWFLAKE
-- type: naming.identifier.no-keyword
+- type: NAMING_IDENTIFIER_NO_KEYWORD
category: NAMING
engine: MSSQL
-- type: naming.identifier.no-keyword
+- type: NAMING_IDENTIFIER_NO_KEYWORD
category: NAMING
engine: MYSQL
-- type: naming.identifier.case
+- type: NAMING_IDENTIFIER_CASE
category: NAMING
componentList:
- key: upper
@@ -1166,7 +1166,7 @@
type: BOOLEAN
default: true
engine: ORACLE
-- type: naming.identifier.case
+- type: NAMING_IDENTIFIER_CASE
category: NAMING
componentList:
- key: upper
@@ -1174,7 +1174,7 @@
type: BOOLEAN
default: true
engine: SNOWFLAKE
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1187,7 +1187,7 @@
- creator_id
- updater_id
engine: MYSQL
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1200,7 +1200,7 @@
- creator_id
- updater_id
engine: TIDB
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1213,7 +1213,7 @@
- creator_id
- updater_id
engine: POSTGRES
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1226,7 +1226,7 @@
- CREATOR_ID
- UPDATER_ID
engine: ORACLE
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1239,7 +1239,7 @@
- creator_id
- updater_id
engine: OCEANBASE
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1252,7 +1252,7 @@
- CREATOR_ID
- UPDATER_ID
engine: SNOWFLAKE
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1265,7 +1265,7 @@
- creator_id
- updater_id
engine: MSSQL
-- type: column.required
+- type: COLUMN_REQUIRED
category: COLUMN
componentList:
- key: list
@@ -1278,97 +1278,97 @@
- creator_id
- updater_id
engine: MARIADB
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: MYSQL
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: TIDB
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: POSTGRES
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: ORACLE
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: OCEANBASE
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: SNOWFLAKE
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: MSSQL
-- type: column.no-null
+- type: COLUMN_NO_NULL
category: COLUMN
engine: MARIADB
-- type: column.disallow-change-type
+- type: COLUMN_DISALLOW_CHANGE_TYPE
category: COLUMN
engine: MYSQL
-- type: column.disallow-change-type
+- type: COLUMN_DISALLOW_CHANGE_TYPE
category: COLUMN
engine: TIDB
-- type: column.disallow-change-type
+- type: COLUMN_DISALLOW_CHANGE_TYPE
category: COLUMN
engine: POSTGRES
-- type: column.disallow-change-type
+- type: COLUMN_DISALLOW_CHANGE_TYPE
category: COLUMN
engine: OCEANBASE
-- type: column.disallow-change-type
+- type: COLUMN_DISALLOW_CHANGE_TYPE
category: COLUMN
engine: MARIADB
-- type: column.set-default-for-not-null
+- type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
category: COLUMN
engine: MYSQL
-- type: column.set-default-for-not-null
+- type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
category: COLUMN
engine: TIDB
-- type: column.set-default-for-not-null
+- type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
category: COLUMN
engine: OCEANBASE
-- type: column.set-default-for-not-null
+- type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
category: COLUMN
engine: MARIADB
-- type: column.disallow-change
+- type: COLUMN_DISALLOW_CHANGE
category: COLUMN
engine: MYSQL
-- type: column.disallow-change
+- type: COLUMN_DISALLOW_CHANGE
category: COLUMN
engine: TIDB
-- type: column.disallow-change
+- type: COLUMN_DISALLOW_CHANGE
category: COLUMN
engine: OCEANBASE
-- type: column.disallow-change
+- type: COLUMN_DISALLOW_CHANGE
category: COLUMN
engine: MARIADB
-- type: column.disallow-changing-order
+- type: COLUMN_DISALLOW_CHANGING_ORDER
category: COLUMN
engine: MYSQL
-- type: column.disallow-changing-order
+- type: COLUMN_DISALLOW_CHANGING_ORDER
category: COLUMN
engine: TIDB
-- type: column.disallow-changing-order
+- type: COLUMN_DISALLOW_CHANGING_ORDER
category: COLUMN
engine: OCEANBASE
-- type: column.disallow-changing-order
+- type: COLUMN_DISALLOW_CHANGING_ORDER
category: COLUMN
engine: MARIADB
-- type: column.disallow-drop
+- type: COLUMN_DISALLOW_DROP
category: COLUMN
engine: OCEANBASE
-- type: column.disallow-drop-in-index
+- type: COLUMN_DISALLOW_DROP_IN_INDEX
category: COLUMN
engine: MYSQL
-- type: column.disallow-drop-in-index
+- type: COLUMN_DISALLOW_DROP_IN_INDEX
category: COLUMN
engine: TIDB
-- type: column.disallow-drop-in-index
+- type: COLUMN_DISALLOW_DROP_IN_INDEX
category: COLUMN
engine: OCEANBASE
-- type: column.disallow-drop-in-index
+- type: COLUMN_DISALLOW_DROP_IN_INDEX
category: COLUMN
engine: MARIADB
-- type: column.comment
+- type: COLUMN_COMMENT
category: COLUMN
componentList:
- key: required
@@ -1384,7 +1384,7 @@
type: NUMBER
default: 64
engine: MYSQL
-- type: column.comment
+- type: COLUMN_COMMENT
category: COLUMN
componentList:
- key: required
@@ -1400,7 +1400,7 @@
type: NUMBER
default: 64
engine: TIDB
-- type: column.comment
+- type: COLUMN_COMMENT
category: COLUMN
componentList:
- key: required
@@ -1416,7 +1416,7 @@
type: NUMBER
default: 64
engine: OCEANBASE
-- type: column.comment
+- type: COLUMN_COMMENT
category: COLUMN
componentList:
- key: required
@@ -1432,7 +1432,7 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: column.comment
+- type: COLUMN_COMMENT
category: COLUMN
componentList:
- key: required
@@ -1448,19 +1448,19 @@
type: NUMBER
default: 64
engine: ORACLE
-- type: column.auto-increment-must-integer
+- type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
category: COLUMN
engine: MYSQL
-- type: column.auto-increment-must-integer
+- type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
category: COLUMN
engine: TIDB
-- type: column.auto-increment-must-integer
+- type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
category: COLUMN
engine: OCEANBASE
-- type: column.auto-increment-must-integer
+- type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
category: COLUMN
engine: MARIADB
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1468,7 +1468,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1476,7 +1476,7 @@
type: STRING_ARRAY
default: []
engine: TIDB
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1484,7 +1484,7 @@
type: STRING_ARRAY
default: []
engine: POSTGRES
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1492,7 +1492,7 @@
type: STRING_ARRAY
default: []
engine: ORACLE
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1500,7 +1500,7 @@
type: STRING_ARRAY
default: []
engine: OCEANBASE
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1508,7 +1508,7 @@
type: STRING_ARRAY
default: []
engine: MARIADB
-- type: column.type-disallow-list
+- type: COLUMN_TYPE_DISALLOW_LIST
category: COLUMN
componentList:
- key: list
@@ -1516,19 +1516,19 @@
type: STRING_ARRAY
default: []
engine: MSSQL
-- type: column.disallow-set-charset
+- type: COLUMN_DISALLOW_SET_CHARSET
category: COLUMN
engine: MYSQL
-- type: column.disallow-set-charset
+- type: COLUMN_DISALLOW_SET_CHARSET
category: COLUMN
engine: TIDB
-- type: column.disallow-set-charset
+- type: COLUMN_DISALLOW_SET_CHARSET
category: COLUMN
engine: OCEANBASE
-- type: column.disallow-set-charset
+- type: COLUMN_DISALLOW_SET_CHARSET
category: COLUMN
engine: MARIADB
-- type: column.maximum-character-length
+- type: COLUMN_MAXIMUM_CHARACTER_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1536,7 +1536,7 @@
type: NUMBER
default: 20
engine: MYSQL
-- type: column.maximum-character-length
+- type: COLUMN_MAXIMUM_CHARACTER_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1544,7 +1544,7 @@
type: NUMBER
default: 20
engine: TIDB
-- type: column.maximum-character-length
+- type: COLUMN_MAXIMUM_CHARACTER_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1552,7 +1552,7 @@
type: NUMBER
default: 20
engine: POSTGRES
-- type: column.maximum-character-length
+- type: COLUMN_MAXIMUM_CHARACTER_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1560,7 +1560,7 @@
type: NUMBER
default: 20
engine: ORACLE
-- type: column.maximum-character-length
+- type: COLUMN_MAXIMUM_CHARACTER_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1568,7 +1568,7 @@
type: NUMBER
default: 20
engine: OCEANBASE
-- type: column.maximum-character-length
+- type: COLUMN_MAXIMUM_CHARACTER_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1576,7 +1576,7 @@
type: NUMBER
default: 20
engine: MARIADB
-- type: column.maximum-varchar-length
+- type: COLUMN_MAXIMUM_VARCHAR_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1584,7 +1584,7 @@
type: NUMBER
default: 2560
engine: MYSQL
-- type: column.maximum-varchar-length
+- type: COLUMN_MAXIMUM_VARCHAR_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1592,7 +1592,7 @@
type: NUMBER
default: 2560
engine: OCEANBASE
-- type: column.maximum-varchar-length
+- type: COLUMN_MAXIMUM_VARCHAR_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1600,7 +1600,7 @@
type: NUMBER
default: 2560
engine: MARIADB
-- type: column.maximum-varchar-length
+- type: COLUMN_MAXIMUM_VARCHAR_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1608,7 +1608,7 @@
type: NUMBER
default: 2560
engine: ORACLE
-- type: column.maximum-varchar-length
+- type: COLUMN_MAXIMUM_VARCHAR_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1616,7 +1616,7 @@
type: NUMBER
default: 2560
engine: SNOWFLAKE
-- type: column.maximum-varchar-length
+- type: COLUMN_MAXIMUM_VARCHAR_LENGTH
category: COLUMN
componentList:
- key: number
@@ -1624,7 +1624,7 @@
type: NUMBER
default: 2560
engine: MSSQL
-- type: column.auto-increment-initial-value
+- type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
category: COLUMN
componentList:
- key: number
@@ -1632,7 +1632,7 @@
type: NUMBER
default: 1
engine: MYSQL
-- type: column.auto-increment-initial-value
+- type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
category: COLUMN
componentList:
- key: number
@@ -1640,7 +1640,7 @@
type: NUMBER
default: 1
engine: TIDB
-- type: column.auto-increment-initial-value
+- type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
category: COLUMN
componentList:
- key: number
@@ -1648,7 +1648,7 @@
type: NUMBER
default: 1
engine: OCEANBASE
-- type: column.auto-increment-initial-value
+- type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
category: COLUMN
componentList:
- key: number
@@ -1656,106 +1656,106 @@
type: NUMBER
default: 1
engine: MARIADB
-- type: column.auto-increment-must-unsigned
+- type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
category: COLUMN
engine: MYSQL
-- type: column.auto-increment-must-unsigned
+- type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
category: COLUMN
engine: TIDB
-- type: column.auto-increment-must-unsigned
+- type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
category: COLUMN
engine: OCEANBASE
-- type: column.auto-increment-must-unsigned
+- type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
category: COLUMN
engine: MARIADB
-- type: column.current-time-count-limit
+- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
category: COLUMN
engine: MYSQL
-- type: column.current-time-count-limit
+- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
category: COLUMN
engine: TIDB
-- type: column.current-time-count-limit
+- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
category: COLUMN
engine: OCEANBASE
-- type: column.current-time-count-limit
+- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
category: COLUMN
engine: MARIADB
-- type: column.require-default
+- type: COLUMN_REQUIRE_DEFAULT
category: COLUMN
engine: MYSQL
-- type: column.require-default
+- type: COLUMN_REQUIRE_DEFAULT
category: COLUMN
engine: TIDB
-- type: column.require-default
+- type: COLUMN_REQUIRE_DEFAULT
category: COLUMN
engine: POSTGRES
-- type: column.require-default
+- type: COLUMN_REQUIRE_DEFAULT
category: COLUMN
engine: ORACLE
-- type: column.require-default
+- type: COLUMN_REQUIRE_DEFAULT
category: COLUMN
engine: OCEANBASE
-- type: column.require-default
+- type: COLUMN_REQUIRE_DEFAULT
category: COLUMN
engine: MARIADB
-- type: column.default-disallow-volatile
+- type: COLUMN_DEFAULT_DISALLOW_VOLATILE
category: COLUMN
engine: POSTGRES
-- type: column.require-charset
+- type: COLUMN_REQUIRE_CHARSET
category: COLUMN
engine: MYSQL
-- type: column.require-collation
+- type: COLUMN_REQUIRE_COLLATION
category: COLUMN
engine: MYSQL
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: MYSQL
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: TIDB
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: POSTGRES
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: OCEANBASE
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: SNOWFLAKE
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: MSSQL
-- type: schema.backward-compatibility
+- type: SCHEMA_BACKWARD_COMPATIBILITY
category: SCHEMA
engine: MARIADB
-- type: database.drop-empty-database
+- type: DATABASE_DROP_EMPTY_DATABASE
category: DATABASE
engine: MYSQL
-- type: database.drop-empty-database
+- type: DATABASE_DROP_EMPTY_DATABASE
category: DATABASE
engine: TIDB
-- type: database.drop-empty-database
+- type: DATABASE_DROP_EMPTY_DATABASE
category: DATABASE
engine: OCEANBASE
-- type: database.drop-empty-database
+- type: DATABASE_DROP_EMPTY_DATABASE
category: DATABASE
engine: MARIADB
-- type: index.no-duplicate-column
+- type: INDEX_NO_DUPLICATE_COLUMN
category: INDEX
engine: MYSQL
-- type: index.no-duplicate-column
+- type: INDEX_NO_DUPLICATE_COLUMN
category: INDEX
engine: TIDB
-- type: index.no-duplicate-column
+- type: INDEX_NO_DUPLICATE_COLUMN
category: INDEX
engine: POSTGRES
-- type: index.no-duplicate-column
+- type: INDEX_NO_DUPLICATE_COLUMN
category: INDEX
engine: OCEANBASE
-- type: index.no-duplicate-column
+- type: INDEX_NO_DUPLICATE_COLUMN
category: INDEX
engine: MARIADB
-- type: index.key-number-limit
+- type: INDEX_KEY_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1763,7 +1763,7 @@
type: NUMBER
default: 5
engine: MYSQL
-- type: index.key-number-limit
+- type: INDEX_KEY_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1771,7 +1771,7 @@
type: NUMBER
default: 5
engine: TIDB
-- type: index.key-number-limit
+- type: INDEX_KEY_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1779,7 +1779,7 @@
type: NUMBER
default: 5
engine: POSTGRES
-- type: index.key-number-limit
+- type: INDEX_KEY_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1787,7 +1787,7 @@
type: NUMBER
default: 5
engine: ORACLE
-- type: index.key-number-limit
+- type: INDEX_KEY_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1795,7 +1795,7 @@
type: NUMBER
default: 5
engine: OCEANBASE
-- type: index.key-number-limit
+- type: INDEX_KEY_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1803,31 +1803,31 @@
type: NUMBER
default: 5
engine: MARIADB
-- type: index.pk-type-limit
+- type: INDEX_PK_TYPE_LIMIT
category: INDEX
engine: MYSQL
-- type: index.pk-type-limit
+- type: INDEX_PK_TYPE_LIMIT
category: INDEX
engine: TIDB
-- type: index.pk-type-limit
+- type: INDEX_PK_TYPE_LIMIT
category: INDEX
engine: OCEANBASE
-- type: index.pk-type-limit
+- type: INDEX_PK_TYPE_LIMIT
category: INDEX
engine: MARIADB
-- type: index.type-no-blob
+- type: INDEX_TYPE_NO_BLOB
category: INDEX
engine: MYSQL
-- type: index.type-no-blob
+- type: INDEX_TYPE_NO_BLOB
category: INDEX
engine: TIDB
-- type: index.type-no-blob
+- type: INDEX_TYPE_NO_BLOB
category: INDEX
engine: OCEANBASE
-- type: index.type-no-blob
+- type: INDEX_TYPE_NO_BLOB
category: INDEX
engine: MARIADB
-- type: index.total-number-limit
+- type: INDEX_TOTAL_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1835,7 +1835,7 @@
type: NUMBER
default: 5
engine: MYSQL
-- type: index.total-number-limit
+- type: INDEX_TOTAL_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1843,7 +1843,7 @@
type: NUMBER
default: 5
engine: TIDB
-- type: index.total-number-limit
+- type: INDEX_TOTAL_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1851,7 +1851,7 @@
type: NUMBER
default: 5
engine: POSTGRES
-- type: index.total-number-limit
+- type: INDEX_TOTAL_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1859,7 +1859,7 @@
type: NUMBER
default: 5
engine: OCEANBASE
-- type: index.total-number-limit
+- type: INDEX_TOTAL_NUMBER_LIMIT
category: INDEX
componentList:
- key: number
@@ -1867,7 +1867,7 @@
type: NUMBER
default: 5
engine: MARIADB
-- type: index.primary-key-type-allowlist
+- type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
category: INDEX
componentList:
- key: list
@@ -1875,7 +1875,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: index.primary-key-type-allowlist
+- type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
category: INDEX
componentList:
- key: list
@@ -1883,7 +1883,7 @@
type: STRING_ARRAY
default: []
engine: TIDB
-- type: index.primary-key-type-allowlist
+- type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
category: INDEX
componentList:
- key: list
@@ -1891,7 +1891,7 @@
type: STRING_ARRAY
default: []
engine: POSTGRES
-- type: index.primary-key-type-allowlist
+- type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
category: INDEX
componentList:
- key: list
@@ -1899,10 +1899,10 @@
type: STRING_ARRAY
default: []
engine: OCEANBASE
-- type: index.create-concurrently
+- type: INDEX_CREATE_CONCURRENTLY
category: INDEX
engine: POSTGRES
-- type: index.type-allow-list
+- type: INDEX_TYPE_ALLOW_LIST
category: INDEX
componentList:
- key: list
@@ -1910,10 +1910,10 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: index.not-redundant
+- type: INDEX_NOT_REDUNDANT
category: INDEX
engine: MSSQL
-- type: system.charset.allowlist
+- type: SYSTEM_CHARSET_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1921,7 +1921,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: system.charset.allowlist
+- type: SYSTEM_CHARSET_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1929,7 +1929,7 @@
type: STRING_ARRAY
default: []
engine: TIDB
-- type: system.charset.allowlist
+- type: SYSTEM_CHARSET_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1937,7 +1937,7 @@
type: STRING_ARRAY
default: []
engine: POSTGRES
-- type: system.charset.allowlist
+- type: SYSTEM_CHARSET_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1945,7 +1945,7 @@
type: STRING_ARRAY
default: []
engine: OCEANBASE
-- type: system.charset.allowlist
+- type: SYSTEM_CHARSET_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1953,7 +1953,7 @@
type: STRING_ARRAY
default: []
engine: MARIADB
-- type: system.collation.allowlist
+- type: SYSTEM_COLLATION_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1961,7 +1961,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: system.collation.allowlist
+- type: SYSTEM_COLLATION_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1969,7 +1969,7 @@
type: STRING_ARRAY
default: []
engine: TIDB
-- type: system.collation.allowlist
+- type: SYSTEM_COLLATION_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1977,7 +1977,7 @@
type: STRING_ARRAY
default: []
engine: POSTGRES
-- type: system.collation.allowlist
+- type: SYSTEM_COLLATION_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1985,7 +1985,7 @@
type: STRING_ARRAY
default: []
engine: OCEANBASE
-- type: system.collation.allowlist
+- type: SYSTEM_COLLATION_ALLOWLIST
category: SYSTEM
componentList:
- key: list
@@ -1993,7 +1993,7 @@
type: STRING_ARRAY
default: []
engine: MARIADB
-- type: system.comment.length
+- type: SYSTEM_COMMENT_LENGTH
category: SYSTEM
componentList:
- key: number
@@ -2001,25 +2001,25 @@
type: NUMBER
default: 64
engine: POSTGRES
-- type: system.procedure.disallow-create
+- type: SYSTEM_PROCEDURE_DISALLOW_CREATE
category: SYSTEM
engine: MYSQL
-- type: system.procedure.disallow-create
+- type: SYSTEM_PROCEDURE_DISALLOW_CREATE
category: SYSTEM
engine: MSSQL
-- type: system.event.disallow-create
+- type: SYSTEM_EVENT_DISALLOW_CREATE
category: SYSTEM
engine: MYSQL
-- type: system.view.disallow-create
+- type: SYSTEM_VIEW_DISALLOW_CREATE
category: SYSTEM
engine: MYSQL
-- type: system.function.disallow-create
+- type: SYSTEM_FUNCTION_DISALLOW_CREATE
category: SYSTEM
engine: MYSQL
-- type: system.function.disallow-create
+- type: SYSTEM_FUNCTION_DISALLOW_CREATE
category: SYSTEM
engine: MSSQL
-- type: system.function.disallowed-list
+- type: SYSTEM_FUNCTION_DISALLOWED_LIST
category: SYSTEM
componentList:
- key: list
@@ -2027,7 +2027,7 @@
type: STRING_ARRAY
default: []
engine: MYSQL
-- type: advice.online-migration
+- type: ADVICE_ONLINE_MIGRATION
category: ADVICE
componentList:
- key: number
@@ -2035,7 +2035,7 @@
type: NUMBER
default: 100000000
engine: MYSQL
-- type: advice.online-migration
+- type: ADVICE_ONLINE_MIGRATION
category: ADVICE
componentList:
- key: number
@@ -2043,12 +2043,12 @@
type: NUMBER
default: 100000000
engine: MARIADB
-- type: statement.add-foreign-key-not-valid
+- type: STATEMENT_ADD_FOREIGN_KEY_NOT_VALID
category: STATEMENT
engine: POSTGRES
-- type: statement.non-transactional
+- type: STATEMENT_NON_TRANSACTIONAL
category: STATEMENT
engine: POSTGRES
-- type: statement.object-owner-check
+- type: STATEMENT_OBJECT_OWNER_CHECK
category: STATEMENT
engine: POSTGRES
diff --git a/frontend/src/types/sql-review.dev.yaml b/frontend/src/types/sql-review.dev.yaml
index 643d405b0c..205c620f4e 100644
--- a/frontend/src/types/sql-review.dev.yaml
+++ b/frontend/src/types/sql-review.dev.yaml
@@ -1,706 +1,706 @@
id: bb.sql-review.dev
ruleList:
- - type: engine.mysql.use-innodb
+ - type: ENGINE_MYSQL_USE_INNODB
level: ERROR
engine: MYSQL
- - type: engine.mysql.use-innodb
+ - type: ENGINE_MYSQL_USE_INNODB
level: ERROR
engine: MARIADB
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: MYSQL
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: TIDB
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: POSTGRES
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: ORACLE
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: OCEANBASE
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: SNOWFLAKE
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: MSSQL
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: MARIADB
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: MYSQL
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: TIDB
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: POSTGRES
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: ORACLE
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: OCEANBASE
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: SNOWFLAKE
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: MSSQL
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: WARNING
engine: MARIADB
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MYSQL
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: TIDB
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: POSTGRES
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: OCEANBASE
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: SNOWFLAKE
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MSSQL
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MARIADB
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: MYSQL
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: TIDB
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: POSTGRES
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: OCEANBASE
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: MARIADB
- - type: table.disallow-trigger
+ - type: TABLE_DISALLOW_TRIGGER
level: ERROR
engine: MYSQL
- - type: table.comment
+ - type: TABLE_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: MYSQL
- - type: table.comment
+ - type: TABLE_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: TIDB
- - type: table.comment
+ - type: TABLE_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: OCEANBASE
- - type: table.comment
+ - type: TABLE_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: MARIADB
- - type: table.no-duplicate-index
+ - type: TABLE_NO_DUPLICATE_INDEX
level: WARNING
engine: MYSQL
- - type: table.text-fields-total-length
+ - type: TABLE_TEXT_FIELDS_TOTAL_LENGTH
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: table.disallow-set-charset
+ - type: TABLE_DISALLOW_SET_CHARSET
level: WARNING
engine: MYSQL
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: MYSQL
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: TIDB
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: POSTGRES
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: ORACLE
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: OCEANBASE
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: SNOWFLAKE
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: MSSQL
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: WARNING
engine: MARIADB
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: MYSQL
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: TIDB
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: POSTGRES
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: ORACLE
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: OCEANBASE
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: SNOWFLAKE
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: MSSQL
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: WARNING
engine: MARIADB
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: MYSQL
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: TIDB
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: POSTGRES
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: ORACLE
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: OCEANBASE
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: SNOWFLAKE
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: MSSQL
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: WARNING
engine: MARIADB
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: WARNING
engine: MYSQL
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: WARNING
engine: TIDB
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: WARNING
engine: POSTGRES
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: WARNING
engine: ORACLE
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: WARNING
engine: OCEANBASE
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: WARNING
engine: MARIADB
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: WARNING
engine: MYSQL
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: WARNING
engine: TIDB
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: WARNING
engine: POSTGRES
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: WARNING
engine: OCEANBASE
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: WARNING
engine: MARIADB
- - type: statement.disallow-on-del-cascade
+ - type: STATEMENT_DISALLOW_ON_DEL_CASCADE
level: ERROR
engine: POSTGRES
- - type: statement.disallow-rm-tbl-cascade
+ - type: STATEMENT_DISALLOW_RM_TBL_CASCADE
level: ERROR
engine: POSTGRES
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: MYSQL
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: TIDB
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: OCEANBASE
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: MARIADB
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: WARNING
engine: MYSQL
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: WARNING
engine: TIDB
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: WARNING
engine: OCEANBASE
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: WARNING
engine: MARIADB
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: WARNING
engine: MYSQL
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: WARNING
engine: TIDB
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: WARNING
engine: POSTGRES
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: WARNING
engine: OCEANBASE
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: WARNING
engine: MARIADB
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: WARNING
engine: MYSQL
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: WARNING
engine: TIDB
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: WARNING
engine: POSTGRES
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: WARNING
engine: ORACLE
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: WARNING
engine: OCEANBASE
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: WARNING
engine: MARIADB
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: WARNING
engine: MYSQL
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: WARNING
engine: TIDB
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: WARNING
engine: POSTGRES
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: WARNING
engine: OCEANBASE
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: WARNING
engine: MARIADB
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: POSTGRES
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: POSTGRES
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: MYSQL
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: POSTGRES
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: OCEANBASE
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: MARIADB
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: TIDB
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: ORACLE
- - type: statement.disallow-add-column-with-default
+ - type: STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT
level: WARNING
engine: POSTGRES
- - type: statement.add-check-not-valid
+ - type: STATEMENT_ADD_CHECK_NOT_VALID
level: WARNING
engine: POSTGRES
- - type: statement.disallow-add-not-null
+ - type: STATEMENT_DISALLOW_ADD_NOT_NULL
level: WARNING
engine: POSTGRES
- - type: statement.select-full-table-scan
+ - type: STATEMENT_SELECT_FULL_TABLE_SCAN
level: WARNING
engine: MYSQL
- - type: statement.select-full-table-scan
+ - type: STATEMENT_SELECT_FULL_TABLE_SCAN
level: WARNING
engine: OCEANBASE
- - type: statement.select-full-table-scan
+ - type: STATEMENT_SELECT_FULL_TABLE_SCAN
level: WARNING
engine: MARIADB
- - type: statement.create-specify-schema
+ - type: STATEMENT_CREATE_SPECIFY_SCHEMA
level: WARNING
engine: POSTGRES
- - type: statement.check-set-role-variable
+ - type: STATEMENT_CHECK_SET_ROLE_VARIABLE
level: WARNING
engine: POSTGRES
- - type: statement.disallow-using-filesort
+ - type: STATEMENT_DISALLOW_USING_FILESORT
level: WARNING
engine: MYSQL
- - type: statement.disallow-using-temporary
+ - type: STATEMENT_DISALLOW_USING_TEMPORARY
level: WARNING
engine: MYSQL
- - type: statement.where.no-equal-null
+ - type: STATEMENT_WHERE_NO_EQUAL_NULL
level: WARNING
engine: MYSQL
- - type: statement.query.minimum-plan-level
+ - type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL
level: WARNING
payload:
required: true
maxLength: 64
engine: MYSQL
- - type: statement.where.maximum-logical-operator-count
+ - type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
level: WARNING
payload:
number: 10
engine: MYSQL
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: TIDB
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: POSTGRES
- - type: statement.maximum-join-table-count
+ - type: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT
level: WARNING
payload:
number: 10
engine: MYSQL
- - type: statement.maximum-statements-in-transaction
+ - type: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION
level: WARNING
payload:
number: 10
engine: MYSQL
- - type: statement.join-strict-column-attrs
+ - type: STATEMENT_JOIN_STRICT_COLUMN_ATTRS
level: WARNING
engine: MYSQL
- - type: statement.disallow-cross-db-queries
+ - type: STATEMENT_DISALLOW_CROSS_DB_QUERIES
level: WARNING
engine: MSSQL
- - type: naming.fully-qualified
+ - type: NAMING_FULLY_QUALIFIED
level: WARNING
engine: POSTGRES
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MYSQL
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: TIDB
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: POSTGRES
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: ORACLE
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: OCEANBASE
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: SNOWFLAKE
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MSSQL
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MARIADB
- - type: naming.table.no-keyword
+ - type: NAMING_TABLE_NO_KEYWORD
level: WARNING
engine: ORACLE
- - type: naming.table.no-keyword
+ - type: NAMING_TABLE_NO_KEYWORD
level: WARNING
engine: SNOWFLAKE
- - type: naming.table.no-keyword
+ - type: NAMING_TABLE_NO_KEYWORD
level: WARNING
engine: MSSQL
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MYSQL
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: TIDB
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: POSTGRES
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: OCEANBASE
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MARIADB
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: MYSQL
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: TIDB
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: OCEANBASE
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: MARIADB
- - type: naming.index.pk
+ - type: NAMING_INDEX_PK
level: WARNING
payload:
format: ^$|^pk_{{table}}_{{column_list}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: MYSQL
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: TIDB
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: OCEANBASE
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: MARIADB
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: MYSQL
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: TIDB
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: OCEANBASE
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: MARIADB
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: MYSQL
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: TIDB
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: OCEANBASE
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: MARIADB
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: ORACLE
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: SNOWFLAKE
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: MSSQL
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: MYSQL
- - type: naming.identifier.case
+ - type: NAMING_IDENTIFIER_CASE
level: WARNING
payload:
upper: true
engine: ORACLE
- - type: naming.identifier.case
+ - type: NAMING_IDENTIFIER_CASE
level: WARNING
payload:
upper: true
engine: SNOWFLAKE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -710,7 +710,7 @@ ruleList:
- creator_id
- updater_id
engine: MYSQL
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -720,7 +720,7 @@ ruleList:
- creator_id
- updater_id
engine: TIDB
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -730,7 +730,7 @@ ruleList:
- creator_id
- updater_id
engine: POSTGRES
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -740,7 +740,7 @@ ruleList:
- creator_id
- updater_id
engine: ORACLE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -750,7 +750,7 @@ ruleList:
- creator_id
- updater_id
engine: OCEANBASE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -760,7 +760,7 @@ ruleList:
- creator_id
- updater_id
engine: SNOWFLAKE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -770,7 +770,7 @@ ruleList:
- creator_id
- updater_id
engine: MSSQL
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -780,456 +780,456 @@ ruleList:
- creator_id
- updater_id
engine: MARIADB
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
engine: SNOWFLAKE
payload:
list:
- ID
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
engine: ORACLE
payload:
list:
- ID
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: MYSQL
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: TIDB
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: POSTGRES
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: ORACLE
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: OCEANBASE
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: MARIADB
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: WARNING
payload:
list:
- JSON
engine: MSSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MYSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: TIDB
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: POSTGRES
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: ORACLE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: OCEANBASE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: SNOWFLAKE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MSSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MARIADB
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: MYSQL
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: TIDB
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: POSTGRES
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: OCEANBASE
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: MARIADB
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: MYSQL
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: TIDB
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: OCEANBASE
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: MARIADB
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: MYSQL
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: TIDB
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: OCEANBASE
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: MARIADB
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: MYSQL
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: TIDB
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: OCEANBASE
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: MARIADB
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: MYSQL
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: TIDB
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: OCEANBASE
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: MARIADB
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: MYSQL
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: TIDB
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: OCEANBASE
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: MARIADB
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: MYSQL
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: TIDB
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: OCEANBASE
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: MARIADB
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: MYSQL
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: TIDB
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: OCEANBASE
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: MARIADB
- - type: column.comment
+ - type: COLUMN_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: MYSQL
- - type: column.comment
+ - type: COLUMN_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: TIDB
- - type: column.comment
+ - type: COLUMN_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: OCEANBASE
- - type: column.comment
+ - type: COLUMN_COMMENT
level: WARNING
payload:
required: true
maxLength: 64
engine: MARIADB
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: MYSQL
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: TIDB
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: POSTGRES
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: ORACLE
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: OCEANBASE
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: MARIADB
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: MYSQL
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: OCEANBASE
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: MARIADB
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: ORACLE
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: SNOWFLAKE
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: MSSQL
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: MYSQL
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: TIDB
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: OCEANBASE
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: MARIADB
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: TIDB
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: MYSQL
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: TIDB
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: POSTGRES
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: ORACLE
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: OCEANBASE
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: MARIADB
- - type: column.default-disallow-volatile
+ - type: COLUMN_DEFAULT_DISALLOW_VOLATILE
level: WARNING
engine: POSTGRES
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: MYSQL
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: TIDB
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: POSTGRES
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: OCEANBASE
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: SNOWFLAKE
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: MSSQL
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: MARIADB
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: MYSQL
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: TIDB
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: OCEANBASE
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: MARIADB
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: MYSQL
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: TIDB
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: POSTGRES
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: OCEANBASE
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: MARIADB
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: MYSQL
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: TIDB
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: OCEANBASE
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: MARIADB
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: WARNING
engine: MYSQL
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: WARNING
engine: TIDB
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: WARNING
engine: OCEANBASE
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: WARNING
engine: MARIADB
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MYSQL
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: TIDB
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: POSTGRES
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: ORACLE
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: OCEANBASE
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MARIADB
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MYSQL
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: TIDB
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: POSTGRES
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: OCEANBASE
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MARIADB
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1238,7 +1238,7 @@ ruleList:
- INT
- BIGINT
engine: MYSQL
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1247,7 +1247,7 @@ ruleList:
- INT
- BIGINT
engine: TIDB
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1256,7 +1256,7 @@ ruleList:
- INT
- BIGINT
engine: POSTGRES
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1265,103 +1265,103 @@ ruleList:
- INT
- BIGINT
engine: OCEANBASE
- - type: index.create-concurrently
+ - type: INDEX_CREATE_CONCURRENTLY
level: WARNING
engine: POSTGRES
- - type: index.type-allow-list
+ - type: INDEX_TYPE_ALLOW_LIST
level: WARNING
payload:
list:
- BTREE
- HASH
engine: MYSQL
- - type: index.not-redundant
+ - type: INDEX_NOT_REDUNDANT
level: WARNING
engine: MSSQL
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4
engine: MYSQL
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4
engine: TIDB
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4
engine: POSTGRES
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4
engine: OCEANBASE
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4
engine: MARIADB
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4_0900_ai_ci
engine: MYSQL
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4_0900_ai_ci
engine: TIDB
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4_0900_ai_ci
engine: POSTGRES
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4_0900_ai_ci
engine: OCEANBASE
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: WARNING
payload:
list:
- utf8mb4_0900_ai_ci
engine: MARIADB
- - type: system.comment.length
+ - type: SYSTEM_COMMENT_LENGTH
level: WARNING
payload:
number: 64
engine: POSTGRES
- - type: system.procedure.disallow-create
+ - type: SYSTEM_PROCEDURE_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.procedure.disallow-create
+ - type: SYSTEM_PROCEDURE_DISALLOW_CREATE
level: WARNING
engine: MSSQL
- - type: system.event.disallow-create
+ - type: SYSTEM_EVENT_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.view.disallow-create
+ - type: SYSTEM_VIEW_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.function.disallow-create
+ - type: SYSTEM_FUNCTION_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.function.disallow-create
+ - type: SYSTEM_FUNCTION_DISALLOW_CREATE
level: WARNING
engine: MSSQL
- - type: system.function.disallowed-list
+ - type: SYSTEM_FUNCTION_DISALLOWED_LIST
level: WARNING
payload:
list:
@@ -1369,6 +1369,6 @@ ruleList:
- UUID
- SLEEP
engine: MYSQL
- - type: statement.object-owner-check
+ - type: STATEMENT_OBJECT_OWNER_CHECK
level: WARNING
engine: POSTGRES
diff --git a/frontend/src/types/sql-review.prod.yaml b/frontend/src/types/sql-review.prod.yaml
index f80ebc8f4b..07b2ba8fd9 100644
--- a/frontend/src/types/sql-review.prod.yaml
+++ b/frontend/src/types/sql-review.prod.yaml
@@ -1,771 +1,771 @@
id: bb.sql-review.prod
ruleList:
- - type: engine.mysql.use-innodb
+ - type: ENGINE_MYSQL_USE_INNODB
level: ERROR
engine: MYSQL
- - type: engine.mysql.use-innodb
+ - type: ENGINE_MYSQL_USE_INNODB
level: ERROR
engine: MARIADB
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: MYSQL
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: TIDB
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: POSTGRES
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: ORACLE
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: OCEANBASE
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: SNOWFLAKE
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: MSSQL
- - type: table.require-pk
+ - type: TABLE_REQUIRE_PK
level: ERROR
engine: MARIADB
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: MYSQL
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: TIDB
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: POSTGRES
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: ORACLE
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: OCEANBASE
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: SNOWFLAKE
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: MSSQL
- - type: table.no-foreign-key
+ - type: TABLE_NO_FOREIGN_KEY
level: ERROR
engine: MARIADB
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MYSQL
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: TIDB
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: POSTGRES
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: OCEANBASE
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: SNOWFLAKE
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MSSQL
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MARIADB
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: MYSQL
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: TIDB
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: POSTGRES
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: OCEANBASE
- - type: table.disallow-partition
+ - type: TABLE_DISALLOW_PARTITION
level: ERROR
engine: MARIADB
- - type: table.disallow-trigger
+ - type: TABLE_DISALLOW_TRIGGER
level: ERROR
engine: MYSQL
- - type: table.comment
+ - type: TABLE_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: MYSQL
- - type: table.comment
+ - type: TABLE_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: TIDB
- - type: table.comment
+ - type: TABLE_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: OCEANBASE
- - type: table.comment
+ - type: TABLE_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: MARIADB
- - type: table.comment
+ - type: TABLE_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: POSTGRES
- - type: table.comment
+ - type: TABLE_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: ORACLE
- - type: table.no-duplicate-index
+ - type: TABLE_NO_DUPLICATE_INDEX
level: WARNING
engine: MYSQL
- - type: table.text-fields-total-length
+ - type: TABLE_TEXT_FIELDS_TOTAL_LENGTH
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: table.disallow-set-charset
+ - type: TABLE_DISALLOW_SET_CHARSET
level: WARNING
engine: MYSQL
- - type: table.disallow-ddl
+ - type: TABLE_DISALLOW_DDL
level: WARNING
engine: MSSQL
- - type: table.disallow-ddl
+ - type: TABLE_DISALLOW_DDL
level: WARNING
engine: MYSQL
- - type: table.disallow-dml
+ - type: TABLE_DISALLOW_DML
level: WARNING
engine: MSSQL
- - type: table.disallow-dml
+ - type: TABLE_DISALLOW_DML
level: WARNING
engine: MYSQL
- - type: table.limit-size
+ - type: TABLE_LIMIT_SIZE
level: WARNING
payload:
number: 10000000
engine: MYSQL
- - type: table.require-charset
+ - type: TABLE_REQUIRE_CHARSET
level: WARNING
engine: MYSQL
- - type: table.require-collation
+ - type: TABLE_REQUIRE_COLLATION
level: WARNING
engine: MYSQL
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: MYSQL
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: TIDB
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: POSTGRES
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: ORACLE
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: OCEANBASE
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: SNOWFLAKE
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: MSSQL
- - type: statement.select.no-select-all
+ - type: STATEMENT_SELECT_NO_SELECT_ALL
level: ERROR
engine: MARIADB
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: MYSQL
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: TIDB
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: POSTGRES
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: ORACLE
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: OCEANBASE
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: SNOWFLAKE
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: MSSQL
- - type: statement.where.require.select
+ - type: STATEMENT_WHERE_REQUIRE_SELECT
level: ERROR
engine: MARIADB
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: MYSQL
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: TIDB
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: POSTGRES
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: ORACLE
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: OCEANBASE
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: SNOWFLAKE
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: MSSQL
- - type: statement.where.require.update-delete
+ - type: STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
level: ERROR
engine: MARIADB
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: ERROR
engine: MYSQL
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: ERROR
engine: TIDB
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: ERROR
engine: POSTGRES
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: ERROR
engine: ORACLE
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: ERROR
engine: OCEANBASE
- - type: statement.where.no-leading-wildcard-like
+ - type: STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
level: ERROR
engine: MARIADB
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: ERROR
engine: MYSQL
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: ERROR
engine: TIDB
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: ERROR
engine: POSTGRES
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: ERROR
engine: OCEANBASE
- - type: statement.disallow-commit
+ - type: STATEMENT_DISALLOW_COMMIT
level: ERROR
engine: MARIADB
- - type: statement.disallow-on-del-cascade
+ - type: STATEMENT_DISALLOW_ON_DEL_CASCADE
level: ERROR
engine: POSTGRES
- - type: statement.disallow-rm-tbl-cascade
+ - type: STATEMENT_DISALLOW_RM_TBL_CASCADE
level: ERROR
engine: POSTGRES
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: MYSQL
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: TIDB
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: OCEANBASE
- - type: statement.disallow-limit
+ - type: STATEMENT_DISALLOW_LIMIT
level: WARNING
engine: MARIADB
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: ERROR
engine: MYSQL
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: ERROR
engine: TIDB
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: ERROR
engine: OCEANBASE
- - type: statement.disallow-order-by
+ - type: STATEMENT_DISALLOW_ORDER_BY
level: ERROR
engine: MARIADB
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: ERROR
engine: MYSQL
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: ERROR
engine: TIDB
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: ERROR
engine: POSTGRES
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: ERROR
engine: OCEANBASE
- - type: statement.merge-alter-table
+ - type: STATEMENT_MERGE_ALTER_TABLE
level: ERROR
engine: MARIADB
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: ERROR
engine: MYSQL
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: ERROR
engine: TIDB
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: ERROR
engine: POSTGRES
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: ERROR
engine: ORACLE
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: ERROR
engine: OCEANBASE
- - type: statement.insert.must-specify-column
+ - type: STATEMENT_INSERT_MUST_SPECIFY_COLUMN
level: ERROR
engine: MARIADB
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: ERROR
engine: MYSQL
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: ERROR
engine: TIDB
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: ERROR
engine: POSTGRES
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: ERROR
engine: OCEANBASE
- - type: statement.insert.disallow-order-by-rand
+ - type: STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
level: ERROR
engine: MARIADB
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: POSTGRES
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: statement.insert.row-limit
+ - type: STATEMENT_INSERT_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: POSTGRES
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: statement.affected-row-limit
+ - type: STATEMENT_AFFECTED_ROW_LIMIT
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: MYSQL
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: POSTGRES
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: OCEANBASE
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: MARIADB
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: TIDB
- - type: statement.dml-dry-run
+ - type: STATEMENT_DML_DRY_RUN
level: ERROR
engine: ORACLE
- - type: statement.disallow-add-column-with-default
+ - type: STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT
level: WARNING
engine: POSTGRES
- - type: statement.add-check-not-valid
+ - type: STATEMENT_ADD_CHECK_NOT_VALID
level: WARNING
engine: POSTGRES
- - type: statement.disallow-add-not-null
+ - type: STATEMENT_DISALLOW_ADD_NOT_NULL
level: WARNING
engine: POSTGRES
- - type: statement.select-full-table-scan
+ - type: STATEMENT_SELECT_FULL_TABLE_SCAN
level: ERROR
engine: MYSQL
- - type: statement.select-full-table-scan
+ - type: STATEMENT_SELECT_FULL_TABLE_SCAN
level: ERROR
engine: OCEANBASE
- - type: statement.select-full-table-scan
+ - type: STATEMENT_SELECT_FULL_TABLE_SCAN
level: ERROR
engine: MARIADB
- - type: statement.create-specify-schema
+ - type: STATEMENT_CREATE_SPECIFY_SCHEMA
level: WARNING
engine: POSTGRES
- - type: statement.check-set-role-variable
+ - type: STATEMENT_CHECK_SET_ROLE_VARIABLE
level: WARNING
engine: POSTGRES
- - type: statement.disallow-using-filesort
+ - type: STATEMENT_DISALLOW_USING_FILESORT
level: WARNING
engine: MYSQL
- - type: statement.disallow-using-temporary
+ - type: STATEMENT_DISALLOW_USING_TEMPORARY
level: WARNING
engine: MYSQL
- - type: statement.where.no-equal-null
+ - type: STATEMENT_WHERE_NO_EQUAL_NULL
level: WARNING
engine: MYSQL
- - type: statement.where.disallow-functions-and-calculations
+ - type: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
level: WARNING
engine: MYSQL
- - type: statement.where.disallow-functions-and-calculations
+ - type: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
level: WARNING
engine: MSSQL
- - type: statement.query.minimum-plan-level
+ - type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL
level: WARNING
payload:
required: true
maxLength: 64
engine: MYSQL
- - type: statement.where.maximum-logical-operator-count
+ - type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
level: WARNING
payload:
number: 10
engine: MYSQL
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: TIDB
- - type: statement.maximum-limit-value
+ - type: STATEMENT_MAXIMUM_LIMIT_VALUE
level: WARNING
payload:
number: 1000
engine: POSTGRES
- - type: statement.maximum-join-table-count
+ - type: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT
level: WARNING
payload:
number: 10
engine: MYSQL
- - type: statement.maximum-statements-in-transaction
+ - type: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION
level: WARNING
payload:
number: 10
engine: MYSQL
- - type: statement.join-strict-column-attrs
+ - type: STATEMENT_JOIN_STRICT_COLUMN_ATTRS
level: WARNING
engine: MYSQL
- - type: statement.add-column-without-position
+ - type: STATEMENT_ADD_COLUMN_WITHOUT_POSITION
level: WARNING
engine: OCEANBASE
- - type: statement.disallow-offline-ddl
+ - type: STATEMENT_DISALLOW_OFFLINE_DDL
level: WARNING
engine: OCEANBASE
- - type: statement.disallow-cross-db-queries
+ - type: STATEMENT_DISALLOW_CROSS_DB_QUERIES
level: WARNING
engine: MSSQL
- - type: statement.max-execution-time
+ - type: STATEMENT_MAX_EXECUTION_TIME
level: ERROR
engine: MYSQL
- - type: statement.max-execution-time
+ - type: STATEMENT_MAX_EXECUTION_TIME
level: ERROR
engine: MARIADB
- - type: statement.require-algorithm-option
+ - type: STATEMENT_REQUIRE_ALGORITHM_OPTION
level: ERROR
engine: MYSQL
- - type: statement.require-algorithm-option
+ - type: STATEMENT_REQUIRE_ALGORITHM_OPTION
level: ERROR
engine: MARIADB
- - type: statement.require-lock-option
+ - type: STATEMENT_REQUIRE_LOCK_OPTION
level: ERROR
engine: MYSQL
- - type: statement.require-lock-option
+ - type: STATEMENT_REQUIRE_LOCK_OPTION
level: ERROR
engine: MARIADB
- - type: naming.fully-qualified
+ - type: NAMING_FULLY_QUALIFIED
level: WARNING
engine: POSTGRES
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MYSQL
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: TIDB
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: POSTGRES
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: ORACLE
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: OCEANBASE
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: SNOWFLAKE
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MSSQL
- - type: naming.table
+ - type: NAMING_TABLE
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MARIADB
- - type: naming.table.no-keyword
+ - type: NAMING_TABLE_NO_KEYWORD
level: WARNING
engine: ORACLE
- - type: naming.table.no-keyword
+ - type: NAMING_TABLE_NO_KEYWORD
level: WARNING
engine: SNOWFLAKE
- - type: naming.table.no-keyword
+ - type: NAMING_TABLE_NO_KEYWORD
level: WARNING
engine: MSSQL
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MYSQL
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: TIDB
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: POSTGRES
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: OCEANBASE
- - type: naming.column
+ - type: NAMING_COLUMN
level: WARNING
payload:
format: ^[a-z]+(_[a-z]+)*$
maxLength: 63
engine: MARIADB
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: MYSQL
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: TIDB
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: OCEANBASE
- - type: naming.index.uk
+ - type: NAMING_INDEX_UK
level: WARNING
payload:
format: ^$|^uk_{{table}}_{{column_list}}$
maxLength: 63
engine: MARIADB
- - type: naming.index.pk
+ - type: NAMING_INDEX_PK
level: WARNING
payload:
format: ^$|^pk_{{table}}_{{column_list}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: MYSQL
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: TIDB
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: OCEANBASE
- - type: naming.index.idx
+ - type: NAMING_INDEX_IDX
level: WARNING
payload:
format: ^$|^idx_{{table}}_{{column_list}}$
maxLength: 63
engine: MARIADB
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: MYSQL
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: TIDB
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: POSTGRES
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: OCEANBASE
- - type: naming.index.fk
+ - type: NAMING_INDEX_FK
level: WARNING
payload:
format: ^$|^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$
maxLength: 63
engine: MARIADB
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: MYSQL
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: TIDB
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: OCEANBASE
- - type: naming.column.auto-increment
+ - type: NAMING_COLUMN_AUTO_INCREMENT
level: WARNING
payload:
format: ^id$
maxLength: 63
engine: MARIADB
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: ORACLE
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: SNOWFLAKE
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: MSSQL
- - type: naming.identifier.no-keyword
+ - type: NAMING_IDENTIFIER_NO_KEYWORD
level: WARNING
engine: MYSQL
- - type: naming.identifier.case
+ - type: NAMING_IDENTIFIER_CASE
level: WARNING
payload:
upper: true
engine: ORACLE
- - type: naming.identifier.case
+ - type: NAMING_IDENTIFIER_CASE
level: WARNING
payload:
upper: true
engine: SNOWFLAKE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -775,7 +775,7 @@ ruleList:
- creator_id
- updater_id
engine: MYSQL
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -785,7 +785,7 @@ ruleList:
- creator_id
- updater_id
engine: TIDB
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -795,7 +795,7 @@ ruleList:
- creator_id
- updater_id
engine: POSTGRES
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -805,7 +805,7 @@ ruleList:
- creator_id
- updater_id
engine: ORACLE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -815,7 +815,7 @@ ruleList:
- creator_id
- updater_id
engine: OCEANBASE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -825,7 +825,7 @@ ruleList:
- creator_id
- updater_id
engine: SNOWFLAKE
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -835,7 +835,7 @@ ruleList:
- creator_id
- updater_id
engine: MSSQL
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
payload:
list:
@@ -845,477 +845,477 @@ ruleList:
- creator_id
- updater_id
engine: MARIADB
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
engine: SNOWFLAKE
payload:
list:
- ID
- - type: column.required
+ - type: COLUMN_REQUIRED
level: WARNING
engine: ORACLE
payload:
list:
- ID
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: MYSQL
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: TIDB
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: POSTGRES
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: ORACLE
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: OCEANBASE
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: MARIADB
- - type: column.type-disallow-list
+ - type: COLUMN_TYPE_DISALLOW_LIST
level: ERROR
payload:
list:
- JSON
engine: MSSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MYSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: TIDB
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: POSTGRES
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: ORACLE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: OCEANBASE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: SNOWFLAKE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MSSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MARIADB
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: MYSQL
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: TIDB
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: POSTGRES
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: OCEANBASE
- - type: column.disallow-change-type
+ - type: COLUMN_DISALLOW_CHANGE_TYPE
level: ERROR
engine: MARIADB
- - type: column.disallow-drop
+ - type: COLUMN_DISALLOW_DROP
level: WARNING
engine: OCEANBASE
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: MYSQL
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: TIDB
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: OCEANBASE
- - type: column.disallow-drop-in-index
+ - type: COLUMN_DISALLOW_DROP_IN_INDEX
level: ERROR
engine: MARIADB
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: MYSQL
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: TIDB
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: OCEANBASE
- - type: column.set-default-for-not-null
+ - type: COLUMN_SET_DEFAULT_FOR_NOT_NULL
level: ERROR
engine: MARIADB
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: MYSQL
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: TIDB
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: OCEANBASE
- - type: column.disallow-change
+ - type: COLUMN_DISALLOW_CHANGE
level: ERROR
engine: MARIADB
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: MYSQL
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: TIDB
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: OCEANBASE
- - type: column.disallow-changing-order
+ - type: COLUMN_DISALLOW_CHANGING_ORDER
level: ERROR
engine: MARIADB
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: MYSQL
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: TIDB
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: OCEANBASE
- - type: column.auto-increment-must-integer
+ - type: COLUMN_AUTO_INCREMENT_MUST_INTEGER
level: ERROR
engine: MARIADB
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: MYSQL
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: TIDB
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: OCEANBASE
- - type: column.disallow-set-charset
+ - type: COLUMN_DISALLOW_SET_CHARSET
level: ERROR
engine: MARIADB
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: MYSQL
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: TIDB
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: OCEANBASE
- - type: column.auto-increment-must-unsigned
+ - type: COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
level: ERROR
engine: MARIADB
- - type: column.comment
+ - type: COLUMN_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: MYSQL
- - type: column.comment
+ - type: COLUMN_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: TIDB
- - type: column.comment
+ - type: COLUMN_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: OCEANBASE
- - type: column.comment
+ - type: COLUMN_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: MARIADB
- - type: column.comment
+ - type: COLUMN_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: POSTGRES
- - type: column.comment
+ - type: COLUMN_COMMENT
level: ERROR
payload:
required: true
maxLength: 64
engine: ORACLE
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: MYSQL
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: TIDB
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: POSTGRES
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: ORACLE
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: OCEANBASE
- - type: column.maximum-character-length
+ - type: COLUMN_MAXIMUM_CHARACTER_LENGTH
level: WARNING
payload:
number: 20
engine: MARIADB
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: MYSQL
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: OCEANBASE
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: MARIADB
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: ORACLE
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: SNOWFLAKE
- - type: column.maximum-varchar-length
+ - type: COLUMN_MAXIMUM_VARCHAR_LENGTH
level: WARNING
payload:
number: 2560
engine: MSSQL
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: MYSQL
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: TIDB
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: OCEANBASE
- - type: column.auto-increment-initial-value
+ - type: COLUMN_AUTO_INCREMENT_INITIAL_VALUE
level: WARNING
payload:
number: 1
engine: MARIADB
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: MYSQL
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: TIDB
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: OCEANBASE
- - type: column.current-time-count-limit
+ - type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
payload:
number: 1000
engine: MARIADB
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: MYSQL
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: TIDB
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: POSTGRES
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: ORACLE
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: OCEANBASE
- - type: column.require-default
+ - type: COLUMN_REQUIRE_DEFAULT
level: WARNING
engine: MARIADB
- - type: column.default-disallow-volatile
+ - type: COLUMN_DEFAULT_DISALLOW_VOLATILE
level: WARNING
engine: POSTGRES
- - type: column.require-charset
+ - type: COLUMN_REQUIRE_CHARSET
level: WARNING
engine: MYSQL
- - type: column.require-collation
+ - type: COLUMN_REQUIRE_COLLATION
level: WARNING
engine: MYSQL
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: MYSQL
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: TIDB
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: POSTGRES
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: OCEANBASE
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: SNOWFLAKE
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: MSSQL
- - type: schema.backward-compatibility
+ - type: SCHEMA_BACKWARD_COMPATIBILITY
level: WARNING
engine: MARIADB
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: MYSQL
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: TIDB
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: OCEANBASE
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: MARIADB
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: MYSQL
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: TIDB
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: POSTGRES
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: OCEANBASE
- - type: index.no-duplicate-column
+ - type: INDEX_NO_DUPLICATE_COLUMN
level: ERROR
engine: MARIADB
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: MYSQL
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: TIDB
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: OCEANBASE
- - type: index.type-no-blob
+ - type: INDEX_TYPE_NO_BLOB
level: ERROR
engine: MARIADB
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: ERROR
engine: MYSQL
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: ERROR
engine: TIDB
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: ERROR
engine: OCEANBASE
- - type: index.pk-type-limit
+ - type: INDEX_PK_TYPE_LIMIT
level: ERROR
engine: MARIADB
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MYSQL
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: TIDB
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: POSTGRES
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: ORACLE
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: OCEANBASE
- - type: index.key-number-limit
+ - type: INDEX_KEY_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MARIADB
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MYSQL
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: TIDB
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: POSTGRES
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: OCEANBASE
- - type: index.total-number-limit
+ - type: INDEX_TOTAL_NUMBER_LIMIT
level: WARNING
payload:
number: 5
engine: MARIADB
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1324,7 +1324,7 @@ ruleList:
- INT
- BIGINT
engine: MYSQL
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1333,7 +1333,7 @@ ruleList:
- INT
- BIGINT
engine: TIDB
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1342,7 +1342,7 @@ ruleList:
- INT
- BIGINT
engine: POSTGRES
- - type: index.primary-key-type-allowlist
+ - type: INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
level: ERROR
payload:
list:
@@ -1351,103 +1351,103 @@ ruleList:
- INT
- BIGINT
engine: OCEANBASE
- - type: index.create-concurrently
+ - type: INDEX_CREATE_CONCURRENTLY
level: WARNING
engine: POSTGRES
- - type: index.type-allow-list
+ - type: INDEX_TYPE_ALLOW_LIST
level: WARNING
payload:
list:
- BTREE
- HASH
engine: MYSQL
- - type: index.not-redundant
+ - type: INDEX_NOT_REDUNDANT
level: WARNING
engine: MSSQL
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4
engine: MYSQL
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4
engine: TIDB
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4
engine: POSTGRES
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4
engine: OCEANBASE
- - type: system.charset.allowlist
+ - type: SYSTEM_CHARSET_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4
engine: MARIADB
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4_0900_ai_ci
engine: MYSQL
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4_0900_ai_ci
engine: TIDB
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4_0900_ai_ci
engine: POSTGRES
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4_0900_ai_ci
engine: OCEANBASE
- - type: system.collation.allowlist
+ - type: SYSTEM_COLLATION_ALLOWLIST
level: ERROR
payload:
list:
- utf8mb4_0900_ai_ci
engine: MARIADB
- - type: system.comment.length
+ - type: SYSTEM_COMMENT_LENGTH
level: WARNING
payload:
number: 64
engine: POSTGRES
- - type: system.procedure.disallow-create
+ - type: SYSTEM_PROCEDURE_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.procedure.disallow-create
+ - type: SYSTEM_PROCEDURE_DISALLOW_CREATE
level: WARNING
engine: MSSQL
- - type: system.event.disallow-create
+ - type: SYSTEM_EVENT_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.view.disallow-create
+ - type: SYSTEM_VIEW_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.function.disallow-create
+ - type: SYSTEM_FUNCTION_DISALLOW_CREATE
level: WARNING
engine: MYSQL
- - type: system.function.disallow-create
+ - type: SYSTEM_FUNCTION_DISALLOW_CREATE
level: WARNING
engine: MSSQL
- - type: system.function.disallowed-list
+ - type: SYSTEM_FUNCTION_DISALLOWED_LIST
level: WARNING
payload:
list:
@@ -1455,22 +1455,22 @@ ruleList:
- UUID
- SLEEP
engine: MYSQL
- - type: advice.online-migration
+ - type: ADVICE_ONLINE_MIGRATION
level: ERROR
payload:
number: 100000000
engine: MYSQL
- - type: advice.online-migration
+ - type: ADVICE_ONLINE_MIGRATION
level: ERROR
payload:
number: 100000000
engine: MARIADB
- - type: statement.add-foreign-key-not-valid
+ - type: STATEMENT_ADD_FOREIGN_KEY_NOT_VALID
level: WARNING
engine: POSTGRES
- - type: statement.non-transactional
+ - type: STATEMENT_NON_TRANSACTIONAL
level: WARNING
engine: POSTGRES
- - type: statement.object-owner-check
+ - type: STATEMENT_OBJECT_OWNER_CHECK
level: ERROR
engine: POSTGRES
diff --git a/frontend/src/types/sql-review.sample.yaml b/frontend/src/types/sql-review.sample.yaml
index 8cf46d6a8c..09dc89743c 100644
--- a/frontend/src/types/sql-review.sample.yaml
+++ b/frontend/src/types/sql-review.sample.yaml
@@ -1,73 +1,73 @@
id: bb.sql-review.sample
ruleList:
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: MYSQL
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: TIDB
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: OCEANBASE
- - type: database.drop-empty-database
+ - type: DATABASE_DROP_EMPTY_DATABASE
level: ERROR
engine: MARIADB
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MYSQL
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: TIDB
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: POSTGRES
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: OCEANBASE
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: SNOWFLAKE
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MSSQL
- - type: table.drop-naming-convention
+ - type: TABLE_DROP_NAMING_CONVENTION
level: ERROR
payload:
format: _del$
engine: MARIADB
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MYSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: TIDB
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: POSTGRES
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: ORACLE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: OCEANBASE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: SNOWFLAKE
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MSSQL
- - type: column.no-null
+ - type: COLUMN_NO_NULL
level: WARNING
engine: MARIADB
diff --git a/frontend/src/types/sqlReview.ts b/frontend/src/types/sqlReview.ts
index a308fbd627..7f21e9dfc4 100644
--- a/frontend/src/types/sqlReview.ts
+++ b/frontend/src/types/sqlReview.ts
@@ -1,6 +1,9 @@
import { t, te } from "@/plugins/i18n";
import { Engine } from "@/types/proto-es/v1/common_pb";
-import { SQLReviewRule_Level } from "@/types/proto-es/v1/review_config_service_pb";
+import {
+ SQLReviewRule_Level,
+ SQLReviewRule_Type,
+} from "@/types/proto-es/v1/review_config_service_pb";
import sqlReviewDevTemplate from "./sql-review.dev.yaml";
import sqlReviewProdTemplate from "./sql-review.prod.yaml";
import sqlReviewSampleTemplate from "./sql-review.sample.yaml";
@@ -127,10 +130,10 @@ export interface SQLReviewPolicy {
resources: string[];
}
-// engine and level are enum strings.
+// type, engine, and level are enum strings.
// we need to convert them first.
interface RuleTemplateV2Raw {
- type: string;
+ type: string; // keyof typeof SQLReviewRule_Type
category: string;
engine: string; // keyof typeof Engine
level: string; // keyof typeof SQLReviewRule_Level
@@ -139,7 +142,7 @@ interface RuleTemplateV2Raw {
// RuleTemplateV2 is the rule template. Used by the frontend
export interface RuleTemplateV2 {
- type: string;
+ type: SQLReviewRule_Type;
category: string;
engine: Engine;
level: SQLReviewRule_Level;
@@ -152,9 +155,14 @@ export interface SQLReviewPolicyTemplateV2 {
ruleList: RuleTemplateV2[];
}
+// Helper to convert SQLReviewRule_Type enum value to string key
+export const ruleTypeToString = (type: SQLReviewRule_Type): string => {
+ return SQLReviewRule_Type[type] as string;
+};
+
export const getRuleMapByEngine = (
ruleList: RuleTemplateV2[]
-): Map<Engine, Map<string, RuleTemplateV2>> => {
+): Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>> => {
return ruleList.reduce((map, rule) => {
const engine = rule.engine; // Engine is already numeric enum, no conversion needed
if (!map.has(engine)) {
@@ -167,13 +175,18 @@ export const getRuleMapByEngine = (
componentList: rule.componentList || [],
});
return map;
- }, new Map<Engine, Map<string, RuleTemplateV2>>());
+ }, new Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>());
};
const convertRuleTemplateV2Raw = (
sqlReviewSchema: RuleTemplateV2Raw[]
): RuleTemplateV2[] => {
return sqlReviewSchema.map((rawRule) => {
+ // Convert type string key to enum value
+ const typeKey = rawRule.type as keyof typeof SQLReviewRule_Type;
+ const type =
+ SQLReviewRule_Type[typeKey] ?? SQLReviewRule_Type.TYPE_UNSPECIFIED;
+
// Convert engine string key to enum value
const engineKey = rawRule.engine as keyof typeof Engine;
const engine = Engine[engineKey] ?? Engine.ENGINE_UNSPECIFIED;
@@ -184,6 +197,7 @@ const convertRuleTemplateV2Raw = (
return {
...rawRule,
+ type,
engine,
level,
};
@@ -217,11 +231,16 @@ export const TEMPLATE_LIST_V2: SQLReviewPolicyTemplateV2[] = (function () {
const ruleList: RuleTemplateV2[] = [];
for (const rule of template.ruleList) {
+ // Convert type string to enum for map lookup
+ const typeKey = rule.type as keyof typeof SQLReviewRule_Type;
+ const type =
+ SQLReviewRule_Type[typeKey] ?? SQLReviewRule_Type.TYPE_UNSPECIFIED;
+
// Convert engine string to enum for map lookup
const engineKey = rule.engine as keyof typeof Engine;
const engine = Engine[engineKey] ?? Engine.ENGINE_UNSPECIFIED;
- const ruleTemplate = ruleTemplateMapV2.get(engine)?.get(rule.type);
+ const ruleTemplate = ruleTemplateMapV2.get(engine)?.get(type);
if (!ruleTemplate) {
continue;
}
@@ -292,9 +311,9 @@ export const convertPolicyRuleToRuleTemplate = (
policyRule: SchemaPolicyRule,
ruleTemplate: RuleTemplateV2
): RuleTemplateV2 => {
- if (policyRule.type !== ruleTemplate.type) {
+ if (policyRule.type !== ruleTypeToString(ruleTemplate.type)) {
throw new Error(
- `The rule type is not same. policyRule:${ruleTemplate.type}, ruleTemplate:${ruleTemplate.type}`
+ `The rule type is not same. policyRule:${policyRule.type}, ruleTemplate:${ruleTypeToString(ruleTemplate.type)}`
);
}
@@ -328,9 +347,9 @@ export const convertPolicyRuleToRuleTemplate = (
);
switch (ruleTemplate.type) {
- case "statement.query.minimum-plan-level":
+ case SQLReviewRule_Type.STATEMENT_QUERY_MINIMUM_PLAN_LEVEL:
if (!stringComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -346,9 +365,9 @@ export const convertPolicyRuleToRuleTemplate = (
],
};
// Following rules require STRING component.
- case "table.drop-naming-convention":
+ case SQLReviewRule_Type.TABLE_DROP_NAMING_CONVENTION:
if (!stringComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -364,11 +383,11 @@ export const convertPolicyRuleToRuleTemplate = (
],
};
// Following rules require STRING and NUMBER component.
- case "naming.column":
- case "naming.column.auto-increment":
- case "naming.table":
+ case SQLReviewRule_Type.NAMING_COLUMN:
+ case SQLReviewRule_Type.NAMING_COLUMN_AUTO_INCREMENT:
+ case SQLReviewRule_Type.NAMING_TABLE:
if (!stringComponent || !numberComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -391,9 +410,9 @@ export const convertPolicyRuleToRuleTemplate = (
],
};
// Following rules require TEMPLATE component.
- case "naming.index.pk":
+ case SQLReviewRule_Type.NAMING_INDEX_PK:
if (!templateComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -409,11 +428,11 @@ export const convertPolicyRuleToRuleTemplate = (
],
};
// Following rules require TEMPLATE and NUMBER component.
- case "naming.index.idx":
- case "naming.index.uk":
- case "naming.index.fk":
+ case SQLReviewRule_Type.NAMING_INDEX_IDX:
+ case SQLReviewRule_Type.NAMING_INDEX_UK:
+ case SQLReviewRule_Type.NAMING_INDEX_FK:
if (!templateComponent || !numberComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -436,9 +455,9 @@ export const convertPolicyRuleToRuleTemplate = (
],
};
// Following rules require BOOLEAN component.
- case "naming.identifier.case":
+ case SQLReviewRule_Type.NAMING_IDENTIFIER_CASE:
if (!booleanComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
...res,
@@ -449,7 +468,7 @@ export const convertPolicyRuleToRuleTemplate = (
},
],
};
- case "column.required": {
+ case SQLReviewRule_Type.COLUMN_REQUIRED: {
const requiredColumnComponent = componentList[0];
// The columnList payload is deprecated.
// Just keep it to compatible with old data, we can remove this later.
@@ -472,16 +491,16 @@ export const convertPolicyRuleToRuleTemplate = (
};
}
// Following rules require STRING_ARRAY component.
- case "column.type-disallow-list":
- case "index.primary-key-type-allowlist":
- case "index.type-allow-list":
- case "system.charset.allowlist":
- case "system.collation.allowlist":
- case "system.function.disallowed-list":
- case "table.disallow-dml":
- case "table.disallow-ddl": {
+ case SQLReviewRule_Type.COLUMN_TYPE_DISALLOW_LIST:
+ case SQLReviewRule_Type.INDEX_PRIMARY_KEY_TYPE_ALLOWLIST:
+ case SQLReviewRule_Type.INDEX_TYPE_ALLOW_LIST:
+ case SQLReviewRule_Type.SYSTEM_CHARSET_ALLOWLIST:
+ case SQLReviewRule_Type.SYSTEM_COLLATION_ALLOWLIST:
+ case SQLReviewRule_Type.SYSTEM_FUNCTION_DISALLOWED_LIST:
+ case SQLReviewRule_Type.TABLE_DISALLOW_DML:
+ case SQLReviewRule_Type.TABLE_DISALLOW_DDL: {
if (!stringArrayComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
const stringArrayPayload = {
...stringArrayComponent.payload,
@@ -498,8 +517,8 @@ export const convertPolicyRuleToRuleTemplate = (
};
}
// Following rules require BOOLEAN and NUMBER component.
- case "column.comment":
- case "table.comment": {
+ case SQLReviewRule_Type.COLUMN_COMMENT:
+ case SQLReviewRule_Type.TABLE_COMMENT: {
const requireComponent = componentList.find((c) => c.key === "required");
const requiredClassificationComponent = componentList.find(
(c) => c.key === "requiredClassification"
@@ -510,7 +529,7 @@ export const convertPolicyRuleToRuleTemplate = (
!requiredClassificationComponent ||
!numberComponent
) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -541,23 +560,23 @@ export const convertPolicyRuleToRuleTemplate = (
};
}
// Following rules require NUMBER component.
- case "statement.insert.row-limit":
- case "statement.affected-row-limit":
- case "column.maximum-character-length":
- case "column.maximum-varchar-length":
- case "column.auto-increment-initial-value":
- case "index.key-number-limit":
- case "index.total-number-limit":
- case "system.comment.length":
- case "advice.online-migration":
- case "table.text-fields-total-length":
- case "table.limit-size":
- case "statement.where.maximum-logical-operator-count":
- case "statement.maximum-limit-value":
- case "statement.maximum-join-table-count":
- case "statement.maximum-statements-in-transaction":
+ case SQLReviewRule_Type.STATEMENT_INSERT_ROW_LIMIT:
+ case SQLReviewRule_Type.STATEMENT_AFFECTED_ROW_LIMIT:
+ case SQLReviewRule_Type.COLUMN_MAXIMUM_CHARACTER_LENGTH:
+ case SQLReviewRule_Type.COLUMN_MAXIMUM_VARCHAR_LENGTH:
+ case SQLReviewRule_Type.COLUMN_AUTO_INCREMENT_INITIAL_VALUE:
+ case SQLReviewRule_Type.INDEX_KEY_NUMBER_LIMIT:
+ case SQLReviewRule_Type.INDEX_TOTAL_NUMBER_LIMIT:
+ case SQLReviewRule_Type.SYSTEM_COMMENT_LENGTH:
+ case SQLReviewRule_Type.ADVICE_ONLINE_MIGRATION:
+ case SQLReviewRule_Type.TABLE_TEXT_FIELDS_TOTAL_LENGTH:
+ case SQLReviewRule_Type.TABLE_LIMIT_SIZE:
+ case SQLReviewRule_Type.STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT:
+ case SQLReviewRule_Type.STATEMENT_MAXIMUM_LIMIT_VALUE:
+ case SQLReviewRule_Type.STATEMENT_MAXIMUM_JOIN_TABLE_COUNT:
+ case SQLReviewRule_Type.STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION:
if (!numberComponent) {
- throw new Error(`Invalid rule ${ruleTemplate.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);
}
return {
@@ -596,9 +615,9 @@ const mergeIndividualConfigAsRule = (
)?.payload as StringArrayPayload | undefined;
switch (template.type) {
- case "statement.query.minimum-plan-level":
+ case SQLReviewRule_Type.STATEMENT_QUERY_MINIMUM_PLAN_LEVEL:
if (!stringPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
@@ -608,9 +627,9 @@ const mergeIndividualConfigAsRule = (
},
};
// Following rules require STRING component.
- case "table.drop-naming-convention":
+ case SQLReviewRule_Type.TABLE_DROP_NAMING_CONVENTION:
if (!stringPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
@@ -620,11 +639,11 @@ const mergeIndividualConfigAsRule = (
},
};
// Following rules require STRING and NUMBER component.
- case "naming.column":
- case "naming.column.auto-increment":
- case "naming.table":
+ case SQLReviewRule_Type.NAMING_COLUMN:
+ case SQLReviewRule_Type.NAMING_COLUMN_AUTO_INCREMENT:
+ case SQLReviewRule_Type.NAMING_TABLE:
if (!stringPayload || !numberPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
@@ -635,9 +654,9 @@ const mergeIndividualConfigAsRule = (
},
};
// Following rules require TEMPLATE component.
- case "naming.index.pk":
+ case SQLReviewRule_Type.NAMING_INDEX_PK:
if (!templatePayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
...base,
@@ -646,11 +665,11 @@ const mergeIndividualConfigAsRule = (
},
};
// Following rules require TEMPLATE and NUMBER component.
- case "naming.index.idx":
- case "naming.index.uk":
- case "naming.index.fk":
+ case SQLReviewRule_Type.NAMING_INDEX_IDX:
+ case SQLReviewRule_Type.NAMING_INDEX_UK:
+ case SQLReviewRule_Type.NAMING_INDEX_FK:
if (!templatePayload || !numberPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
...base,
@@ -660,9 +679,9 @@ const mergeIndividualConfigAsRule = (
},
};
// Following rules require BOOLEAN component.
- case "naming.identifier.case":
+ case SQLReviewRule_Type.NAMING_IDENTIFIER_CASE:
if (!booleanPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
...base,
@@ -671,17 +690,17 @@ const mergeIndividualConfigAsRule = (
},
};
// Following rules require STRING_ARRAY component.
- case "column.required":
- case "column.type-disallow-list":
- case "index.primary-key-type-allowlist":
- case "index.type-allow-list":
- case "system.charset.allowlist":
- case "system.collation.allowlist":
- case "system.function.disallowed-list":
- case "table.disallow-dml":
- case "table.disallow-ddl": {
+ case SQLReviewRule_Type.COLUMN_REQUIRED:
+ case SQLReviewRule_Type.COLUMN_TYPE_DISALLOW_LIST:
+ case SQLReviewRule_Type.INDEX_PRIMARY_KEY_TYPE_ALLOWLIST:
+ case SQLReviewRule_Type.INDEX_TYPE_ALLOW_LIST:
+ case SQLReviewRule_Type.SYSTEM_CHARSET_ALLOWLIST:
+ case SQLReviewRule_Type.SYSTEM_COLLATION_ALLOWLIST:
+ case SQLReviewRule_Type.SYSTEM_FUNCTION_DISALLOWED_LIST:
+ case SQLReviewRule_Type.TABLE_DISALLOW_DML:
+ case SQLReviewRule_Type.TABLE_DISALLOW_DDL: {
if (!stringArrayPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
...base,
@@ -691,8 +710,8 @@ const mergeIndividualConfigAsRule = (
};
}
// Following rules require BOOLEAN and NUMBER component.
- case "column.comment":
- case "table.comment": {
+ case SQLReviewRule_Type.COLUMN_COMMENT:
+ case SQLReviewRule_Type.TABLE_COMMENT: {
const requirePayload = componentList.find((c) => c.key === "required")
?.payload as BooleanPayload | undefined;
const requiredClassificationPayload = componentList.find(
@@ -700,7 +719,7 @@ const mergeIndividualConfigAsRule = (
)?.payload as BooleanPayload | undefined;
if (!requirePayload || !numberPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
...base,
@@ -715,23 +734,23 @@ const mergeIndividualConfigAsRule = (
};
}
// Following rules require NUMBER component.
- case "statement.insert.row-limit":
- case "statement.affected-row-limit":
- case "column.maximum-character-length":
- case "column.maximum-varchar-length":
- case "column.auto-increment-initial-value":
- case "index.key-number-limit":
- case "index.total-number-limit":
- case "system.comment.length":
- case "advice.online-migration":
- case "table.text-fields-total-length":
- case "table.limit-size":
- case "statement.where.maximum-logical-operator-count":
- case "statement.maximum-limit-value":
- case "statement.maximum-join-table-count":
- case "statement.maximum-statements-in-transaction":
+ case SQLReviewRule_Type.STATEMENT_INSERT_ROW_LIMIT:
+ case SQLReviewRule_Type.STATEMENT_AFFECTED_ROW_LIMIT:
+ case SQLReviewRule_Type.COLUMN_MAXIMUM_CHARACTER_LENGTH:
+ case SQLReviewRule_Type.COLUMN_MAXIMUM_VARCHAR_LENGTH:
+ case SQLReviewRule_Type.COLUMN_AUTO_INCREMENT_INITIAL_VALUE:
+ case SQLReviewRule_Type.INDEX_KEY_NUMBER_LIMIT:
+ case SQLReviewRule_Type.INDEX_TOTAL_NUMBER_LIMIT:
+ case SQLReviewRule_Type.SYSTEM_COMMENT_LENGTH:
+ case SQLReviewRule_Type.ADVICE_ONLINE_MIGRATION:
+ case SQLReviewRule_Type.TABLE_TEXT_FIELDS_TOTAL_LENGTH:
+ case SQLReviewRule_Type.TABLE_LIMIT_SIZE:
+ case SQLReviewRule_Type.STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT:
+ case SQLReviewRule_Type.STATEMENT_MAXIMUM_LIMIT_VALUE:
+ case SQLReviewRule_Type.STATEMENT_MAXIMUM_JOIN_TABLE_COUNT:
+ case SQLReviewRule_Type.STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION:
if (!numberPayload) {
- throw new Error(`Invalid rule ${template.type}`);
+ throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);
}
return {
...base,
@@ -745,7 +764,7 @@ const mergeIndividualConfigAsRule = (
};
export const convertRuleMapToPolicyRuleList = (
- ruleMapByEngine: Map<Engine, Map<string, RuleTemplateV2>>
+ ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>
): SchemaPolicyRule[] => {
const resp: SchemaPolicyRule[] = [];
@@ -764,7 +783,7 @@ const convertRuleTemplateToPolicyRule = (
rule: RuleTemplateV2
): SchemaPolicyRule => {
const base: SchemaPolicyRule = {
- type: rule.type,
+ type: ruleTypeToString(rule.type),
level: rule.level,
engine: rule.engine,
};
@@ -776,7 +795,9 @@ const convertRuleTemplateToPolicyRule = (
};
export const getRuleLocalizationKey = (type: string): string => {
- return type.split(".").join("-");
+ // Return the SCREAMING_SNAKE_CASE format as-is
+ // This matches the keys in the locale files (e.g., "TABLE_REQUIRE_PK")
+ return type;
};
export const getRuleLocalization = (
diff --git a/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue b/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue
index 50127386db..6e7693cf46 100644
--- a/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue
+++ b/frontend/src/views/SettingWorkspaceSQLReviewDetail.vue
@@ -52,9 +52,9 @@
<BBAttention
v-if="reviewPolicy.resources.length === 0"
type="warning"
- :title="$t('sql-review.attach-resource.no-linked-resources')"
- :description="$t('sql-review.attach-resource.label')"
- :action-text="$t('sql-review.attach-resource.self')"
+ title="sql-review.attach-resource.no-linked-resources"
+ description="sql-review.attach-resource.label"
+ action-text="sql-review.attach-resource.self"
@click="state.showResourcePanel = true"
/>
<div class="flex flex-col gap-y-2 gap-x-2">
@@ -180,6 +180,7 @@ import {
unknown,
} from "@/types";
import type { Engine } from "@/types/proto-es/v1/common_pb";
+import { SQLReviewRule_Type } from "@/types/proto-es/v1/review_config_service_pb";
import { hasWorkspacePermissionV2, sqlReviewNameFromSlug } from "@/utils";
const props = defineProps<{
@@ -191,7 +192,7 @@ interface LocalState {
showEnableModal: boolean;
selectedCategory?: string;
editMode: boolean;
- ruleMapByEngine: Map<Engine, Map<string, RuleTemplateV2>>;
+ ruleMapByEngine: Map<Engine, Map<SQLReviewRule_Type, RuleTemplateV2>>;
rulesUpdated: boolean;
updating: boolean;
editingTitle: boolean;
diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yaml
index 73c69d0560..71b7e9d8ff 100644
--- a/proto/gen/grpc-doc/openapi.yaml
+++ b/proto/gen/grpc-doc/openapi.yaml
@@ -13367,8 +13367,120 @@ components:
type: object
properties:
type:
+ enum:
+ - TYPE_UNSPECIFIED
+ - ENGINE_MYSQL_USE_INNODB
+ - NAMING_FULLY_QUALIFIED
+ - NAMING_TABLE
+ - NAMING_COLUMN
+ - NAMING_INDEX_PK
+ - NAMING_INDEX_UK
+ - NAMING_INDEX_FK
+ - NAMING_INDEX_IDX
+ - NAMING_COLUMN_AUTO_INCREMENT
+ - NAMING_TABLE_NO_KEYWORD
+ - NAMING_IDENTIFIER_NO_KEYWORD
+ - NAMING_IDENTIFIER_CASE
+ - STATEMENT_SELECT_NO_SELECT_ALL
+ - STATEMENT_WHERE_REQUIRE_SELECT
+ - STATEMENT_WHERE_REQUIRE_UPDATE_DELETE
+ - STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE
+ - STATEMENT_DISALLOW_ON_DEL_CASCADE
+ - STATEMENT_DISALLOW_RM_TBL_CASCADE
+ - STATEMENT_DISALLOW_COMMIT
+ - STATEMENT_DISALLOW_LIMIT
+ - STATEMENT_DISALLOW_ORDER_BY
+ - STATEMENT_MERGE_ALTER_TABLE
+ - STATEMENT_INSERT_ROW_LIMIT
+ - STATEMENT_INSERT_MUST_SPECIFY_COLUMN
+ - STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND
+ - STATEMENT_AFFECTED_ROW_LIMIT
+ - STATEMENT_DML_DRY_RUN
+ - STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT
+ - STATEMENT_ADD_CHECK_NOT_VALID
+ - STATEMENT_ADD_FOREIGN_KEY_NOT_VALID
+ - STATEMENT_DISALLOW_ADD_NOT_NULL
+ - STATEMENT_SELECT_FULL_TABLE_SCAN
+ - STATEMENT_CREATE_SPECIFY_SCHEMA
+ - STATEMENT_CHECK_SET_ROLE_VARIABLE
+ - STATEMENT_DISALLOW_USING_FILESORT
+ - STATEMENT_DISALLOW_USING_TEMPORARY
+ - STATEMENT_WHERE_NO_EQUAL_NULL
+ - STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS
+ - STATEMENT_QUERY_MINIMUM_PLAN_LEVEL
+ - STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
+ - STATEMENT_MAXIMUM_LIMIT_VALUE
+ - STATEMENT_MAXIMUM_JOIN_TABLE_COUNT
+ - STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION
+ - STATEMENT_JOIN_STRICT_COLUMN_ATTRS
+ - STATEMENT_NON_TRANSACTIONAL
+ - STATEMENT_ADD_COLUMN_WITHOUT_POSITION
+ - STATEMENT_DISALLOW_OFFLINE_DDL
+ - STATEMENT_DISALLOW_CROSS_DB_QUERIES
+ - STATEMENT_MAX_EXECUTION_TIME
+ - STATEMENT_REQUIRE_ALGORITHM_OPTION
+ - STATEMENT_REQUIRE_LOCK_OPTION
+ - STATEMENT_OBJECT_OWNER_CHECK
+ - TABLE_REQUIRE_PK
+ - TABLE_NO_FOREIGN_KEY
+ - TABLE_DROP_NAMING_CONVENTION
+ - TABLE_COMMENT
+ - TABLE_DISALLOW_PARTITION
+ - TABLE_DISALLOW_TRIGGER
+ - TABLE_NO_DUPLICATE_INDEX
+ - TABLE_TEXT_FIELDS_TOTAL_LENGTH
+ - TABLE_DISALLOW_SET_CHARSET
+ - TABLE_DISALLOW_DDL
+ - TABLE_DISALLOW_DML
+ - TABLE_LIMIT_SIZE
+ - TABLE_REQUIRE_CHARSET
+ - TABLE_REQUIRE_COLLATION
+ - COLUMN_REQUIRED
+ - COLUMN_NO_NULL
+ - COLUMN_DISALLOW_CHANGE_TYPE
+ - COLUMN_SET_DEFAULT_FOR_NOT_NULL
+ - COLUMN_DISALLOW_CHANGE
+ - COLUMN_DISALLOW_CHANGING_ORDER
+ - COLUMN_DISALLOW_DROP
+ - COLUMN_DISALLOW_DROP_IN_INDEX
+ - COLUMN_COMMENT
+ - COLUMN_AUTO_INCREMENT_MUST_INTEGER
+ - COLUMN_TYPE_DISALLOW_LIST
+ - COLUMN_DISALLOW_SET_CHARSET
+ - COLUMN_MAXIMUM_CHARACTER_LENGTH
+ - COLUMN_MAXIMUM_VARCHAR_LENGTH
+ - COLUMN_AUTO_INCREMENT_INITIAL_VALUE
+ - COLUMN_AUTO_INCREMENT_MUST_UNSIGNED
+ - COLUMN_CURRENT_TIME_COUNT_LIMIT
+ - COLUMN_REQUIRE_DEFAULT
+ - COLUMN_DEFAULT_DISALLOW_VOLATILE
+ - COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT
+ - COLUMN_REQUIRE_CHARSET
+ - COLUMN_REQUIRE_COLLATION
+ - SCHEMA_BACKWARD_COMPATIBILITY
+ - DATABASE_DROP_EMPTY_DATABASE
+ - INDEX_NO_DUPLICATE_COLUMN
+ - INDEX_KEY_NUMBER_LIMIT
+ - INDEX_PK_TYPE_LIMIT
+ - INDEX_TYPE_NO_BLOB
+ - INDEX_TOTAL_NUMBER_LIMIT
+ - INDEX_PRIMARY_KEY_TYPE_ALLOWLIST
+ - INDEX_CREATE_CONCURRENTLY
+ - INDEX_TYPE_ALLOW_LIST
+ - INDEX_NOT_REDUNDANT
+ - SYSTEM_CHARSET_ALLOWLIST
+ - SYSTEM_COLLATION_ALLOWLIST
+ - SYSTEM_COMMENT_LENGTH
+ - SYSTEM_PROCEDURE_DISALLOW_CREATE
+ - SYSTEM_EVENT_DISALLOW_CREATE
+ - SYSTEM_VIEW_DISALLOW_CREATE
+ - SYSTEM_FUNCTION_DISALLOW_CREATE
+ - SYSTEM_FUNCTION_DISALLOWED_LIST
+ - ADVICE_ONLINE_MIGRATION
+ - BUILTIN_PRIOR_BACKUP_CHECK
type: string
description: The type of SQL review rule.
+ format: enum
level:
enum:
- LEVEL_UNSPECIFIED
diff --git a/proto/gen/grpc-doc/store/README.md b/proto/gen/grpc-doc/store/README.md
index 589e39affa..620240b515 100644
--- a/proto/gen/grpc-doc/store/README.md
+++ b/proto/gen/grpc-doc/store/README.md
@@ -246,6 +246,7 @@
- [SQLReviewRule](#bytebase-store-SQLReviewRule)
- [SQLReviewRule.Level](#bytebase-store-SQLReviewRule-Level)
+ - [SQLReviewRule.Type](#bytebase-store-SQLReviewRule-Type)
- [store/revision.proto](#store_revision-proto)
- [RevisionPayload](#bytebase-store-RevisionPayload)
@@ -4007,7 +4008,7 @@ ISSUE_CREATE represents creating an issue. |
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
-| type | [string](#string) | | |
+| type | [SQLReviewRule.Type](#bytebase-store-SQLReviewRule-Type) | | |
| level | [SQLReviewRule.Level](#bytebase-store-SQLReviewRule-Level) | | |
| payload | [string](#string) | | |
| engine | [Engine](#bytebase-store-Engine) | | |
@@ -4031,6 +4032,126 @@ The severity level for SQL review rules.
| WARNING | 2 | Rule violation is a warning. |
+
+<a name="bytebase-store-SQLReviewRule-Type"></a>
+
+### SQLReviewRule.Type
+
+
+| Name | Number | Description |
+| ---- | ------ | ----------- |
+| TYPE_UNSPECIFIED | 0 | |
+| ENGINE_MYSQL_USE_INNODB | 1 | |
+| NAMING_FULLY_QUALIFIED | 2 | |
+| NAMING_TABLE | 3 | |
+| NAMING_COLUMN | 4 | |
+| NAMING_INDEX_PK | 5 | |
+| NAMING_INDEX_UK | 6 | |
+| NAMING_INDEX_FK | 7 | |
+| NAMING_INDEX_IDX | 8 | |
+| NAMING_COLUMN_AUTO_INCREMENT | 9 | |
+| NAMING_TABLE_NO_KEYWORD | 10 | |
+| NAMING_IDENTIFIER_NO_KEYWORD | 11 | |
+| NAMING_IDENTIFIER_CASE | 12 | |
+| STATEMENT_SELECT_NO_SELECT_ALL | 13 | |
+| STATEMENT_WHERE_REQUIRE_SELECT | 14 | |
+| STATEMENT_WHERE_REQUIRE_UPDATE_DELETE | 15 | |
+| STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE | 16 | |
+| STATEMENT_DISALLOW_ON_DEL_CASCADE | 17 | |
+| STATEMENT_DISALLOW_RM_TBL_CASCADE | 18 | |
+| STATEMENT_DISALLOW_COMMIT | 19 | |
+| STATEMENT_DISALLOW_LIMIT | 20 | |
+| STATEMENT_DISALLOW_ORDER_BY | 21 | |
+| STATEMENT_MERGE_ALTER_TABLE | 22 | |
+| STATEMENT_INSERT_ROW_LIMIT | 23 | |
+| STATEMENT_INSERT_MUST_SPECIFY_COLUMN | 24 | |
+| STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND | 25 | |
+| STATEMENT_AFFECTED_ROW_LIMIT | 26 | |
+| STATEMENT_DML_DRY_RUN | 27 | |
+| STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT | 28 | |
+| STATEMENT_ADD_CHECK_NOT_VALID | 29 | |
+| STATEMENT_ADD_FOREIGN_KEY_NOT_VALID | 30 | |
+| STATEMENT_DISALLOW_ADD_NOT_NULL | 31 | |
+| STATEMENT_SELECT_FULL_TABLE_SCAN | 32 | |
+| STATEMENT_CREATE_SPECIFY_SCHEMA | 33 | |
+| STATEMENT_CHECK_SET_ROLE_VARIABLE | 34 | |
+| STATEMENT_DISALLOW_USING_FILESORT | 35 | |
+| STATEMENT_DISALLOW_USING_TEMPORARY | 36 | |
+| STATEMENT_WHERE_NO_EQUAL_NULL | 37 | |
+| STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS | 38 | |
+| STATEMENT_QUERY_MINIMUM_PLAN_LEVEL | 39 | |
+| STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT | 40 | |
+| STATEMENT_MAXIMUM_LIMIT_VALUE | 41 | |
+| STATEMENT_MAXIMUM_JOIN_TABLE_COUNT | 42 | |
+| STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION | 43 | |
+| STATEMENT_JOIN_STRICT_COLUMN_ATTRS | 44 | |
+| STATEMENT_NON_TRANSACTIONAL | 45 | |
+| STATEMENT_ADD_COLUMN_WITHOUT_POSITION | 46 | |
+| STATEMENT_DISALLOW_OFFLINE_DDL | 47 | |
+| STATEMENT_DISALLOW_CROSS_DB_QUERIES | 48 | |
+| STATEMENT_MAX_EXECUTION_TIME | 49 | |
+| STATEMENT_REQUIRE_ALGORITHM_OPTION | 50 | |
+| STATEMENT_REQUIRE_LOCK_OPTION | 51 | |
+| STATEMENT_OBJECT_OWNER_CHECK | 52 | |
+| TABLE_REQUIRE_PK | 53 | |
+| TABLE_NO_FOREIGN_KEY | 54 | |
+| TABLE_DROP_NAMING_CONVENTION | 55 | |
+| TABLE_COMMENT | 56 | |
+| TABLE_DISALLOW_PARTITION | 57 | |
+| TABLE_DISALLOW_TRIGGER | 58 | |
+| TABLE_NO_DUPLICATE_INDEX | 59 | |
+| TABLE_TEXT_FIELDS_TOTAL_LENGTH | 60 | |
+| TABLE_DISALLOW_SET_CHARSET | 61 | |
+| TABLE_DISALLOW_DDL | 62 | |
+| TABLE_DISALLOW_DML | 63 | |
+| TABLE_LIMIT_SIZE | 64 | |
+| TABLE_REQUIRE_CHARSET | 65 | |
+| TABLE_REQUIRE_COLLATION | 66 | |
+| COLUMN_REQUIRED | 67 | |
+| COLUMN_NO_NULL | 68 | |
+| COLUMN_DISALLOW_CHANGE_TYPE | 69 | |
+| COLUMN_SET_DEFAULT_FOR_NOT_NULL | 70 | |
+| COLUMN_DISALLOW_CHANGE | 71 | |
+| COLUMN_DISALLOW_CHANGING_ORDER | 72 | |
+| COLUMN_DISALLOW_DROP | 73 | |
+| COLUMN_DISALLOW_DROP_IN_INDEX | 74 | |
+| COLUMN_COMMENT | 75 | |
+| COLUMN_AUTO_INCREMENT_MUST_INTEGER | 76 | |
+| COLUMN_TYPE_DISALLOW_LIST | 77 | |
+| COLUMN_DISALLOW_SET_CHARSET | 78 | |
+| COLUMN_MAXIMUM_CHARACTER_LENGTH | 79 | |
+| COLUMN_MAXIMUM_VARCHAR_LENGTH | 80 | |
+| COLUMN_AUTO_INCREMENT_INITIAL_VALUE | 81 | |
+| COLUMN_AUTO_INCREMENT_MUST_UNSIGNED | 82 | |
+| COLUMN_CURRENT_TIME_COUNT_LIMIT | 83 | |
+| COLUMN_REQUIRE_DEFAULT | 84 | |
+| COLUMN_DEFAULT_DISALLOW_VOLATILE | 85 | |
+| COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT | 86 | |
+| COLUMN_REQUIRE_CHARSET | 87 | |
+| COLUMN_REQUIRE_COLLATION | 88 | |
+| SCHEMA_BACKWARD_COMPATIBILITY | 89 | |
+| DATABASE_DROP_EMPTY_DATABASE | 90 | |
+| INDEX_NO_DUPLICATE_COLUMN | 91 | |
+| INDEX_KEY_NUMBER_LIMIT | 92 | |
+| INDEX_PK_TYPE_LIMIT | 93 | |
+| INDEX_TYPE_NO_BLOB | 94 | |
+| INDEX_TOTAL_NUMBER_LIMIT | 95 | |
+| INDEX_PRIMARY_KEY_TYPE_ALLOWLIST | 96 | |
+| INDEX_CREATE_CONCURRENTLY | 97 | |
+| INDEX_TYPE_ALLOW_LIST | 98 | |
+| INDEX_NOT_REDUNDANT | 99 | |
+| SYSTEM_CHARSET_ALLOWLIST | 100 | |
+| SYSTEM_COLLATION_ALLOWLIST | 101 | |
+| SYSTEM_COMMENT_LENGTH | 102 | |
+| SYSTEM_PROCEDURE_DISALLOW_CREATE | 103 | |
+| SYSTEM_EVENT_DISALLOW_CREATE | 104 | |
+| SYSTEM_VIEW_DISALLOW_CREATE | 105 | |
+| SYSTEM_FUNCTION_DISALLOW_CREATE | 106 | |
+| SYSTEM_FUNCTION_DISALLOWED_LIST | 107 | |
+| ADVICE_ONLINE_MIGRATION | 108 | |
+| BUILTIN_PRIOR_BACKUP_CHECK | 109 | |
+
+
diff --git a/proto/gen/grpc-doc/store/index.html b/proto/gen/grpc-doc/store/index.html
index 4f7c05803a..7fa5c34e1b 100644
--- a/proto/gen/grpc-doc/store/index.html
+++ b/proto/gen/grpc-doc/store/index.html
@@ -1150,6 +1150,10 @@
<a href="#bytebase.store.SQLReviewRule.Level"><span class="badge">E</span>SQLReviewRule.Level</a>
</li>
+ <li>
+ <a href="#bytebase.store.SQLReviewRule.Type"><span class="badge">E</span>SQLReviewRule.Type</a>
+ </li>
+
</ul>
@@ -10822,7 +10826,7 @@ Format: projects/{project}/sheets/{sheet} </p></td>
<tr>
<td>type</td>
- <td><a href="#string">string</a></td>
+ <td><a href="#bytebase.store.SQLReviewRule.Type">SQLReviewRule.Type</a></td>
<td></td>
<td><p> </p></td>
</tr>
@@ -10886,6 +10890,677 @@ Format: projects/{project}/sheets/{sheet} </p></td>
</tbody>
</table>
+ <h3 id="bytebase.store.SQLReviewRule.Type">SQLReviewRule.Type</h3>
+ <p></p>
+ <table class="enum-table">
+ <thead>
+ <tr><td>Name</td><td>Number</td><td>Description</td></tr>
+ </thead>
+ <tbody>
+
+ <tr>
+ <td>TYPE_UNSPECIFIED</td>
+ <td>0</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>ENGINE_MYSQL_USE_INNODB</td>
+ <td>1</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_FULLY_QUALIFIED</td>
+ <td>2</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_TABLE</td>
+ <td>3</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_COLUMN</td>
+ <td>4</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_PK</td>
+ <td>5</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_UK</td>
+ <td>6</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_FK</td>
+ <td>7</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_IDX</td>
+ <td>8</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_COLUMN_AUTO_INCREMENT</td>
+ <td>9</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_TABLE_NO_KEYWORD</td>
+ <td>10</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_IDENTIFIER_NO_KEYWORD</td>
+ <td>11</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_IDENTIFIER_CASE</td>
+ <td>12</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_SELECT_NO_SELECT_ALL</td>
+ <td>13</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_REQUIRE_SELECT</td>
+ <td>14</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_REQUIRE_UPDATE_DELETE</td>
+ <td>15</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE</td>
+ <td>16</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ON_DEL_CASCADE</td>
+ <td>17</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_RM_TBL_CASCADE</td>
+ <td>18</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_COMMIT</td>
+ <td>19</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_LIMIT</td>
+ <td>20</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ORDER_BY</td>
+ <td>21</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MERGE_ALTER_TABLE</td>
+ <td>22</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_INSERT_ROW_LIMIT</td>
+ <td>23</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_INSERT_MUST_SPECIFY_COLUMN</td>
+ <td>24</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND</td>
+ <td>25</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_AFFECTED_ROW_LIMIT</td>
+ <td>26</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DML_DRY_RUN</td>
+ <td>27</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT</td>
+ <td>28</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_ADD_CHECK_NOT_VALID</td>
+ <td>29</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_ADD_FOREIGN_KEY_NOT_VALID</td>
+ <td>30</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ADD_NOT_NULL</td>
+ <td>31</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_SELECT_FULL_TABLE_SCAN</td>
+ <td>32</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_CREATE_SPECIFY_SCHEMA</td>
+ <td>33</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_CHECK_SET_ROLE_VARIABLE</td>
+ <td>34</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_USING_FILESORT</td>
+ <td>35</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_USING_TEMPORARY</td>
+ <td>36</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_NO_EQUAL_NULL</td>
+ <td>37</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS</td>
+ <td>38</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_QUERY_MINIMUM_PLAN_LEVEL</td>
+ <td>39</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT</td>
+ <td>40</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAXIMUM_LIMIT_VALUE</td>
+ <td>41</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAXIMUM_JOIN_TABLE_COUNT</td>
+ <td>42</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION</td>
+ <td>43</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_JOIN_STRICT_COLUMN_ATTRS</td>
+ <td>44</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_NON_TRANSACTIONAL</td>
+ <td>45</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_ADD_COLUMN_WITHOUT_POSITION</td>
+ <td>46</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_OFFLINE_DDL</td>
+ <td>47</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_CROSS_DB_QUERIES</td>
+ <td>48</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAX_EXECUTION_TIME</td>
+ <td>49</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_REQUIRE_ALGORITHM_OPTION</td>
+ <td>50</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_REQUIRE_LOCK_OPTION</td>
+ <td>51</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_OBJECT_OWNER_CHECK</td>
+ <td>52</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_REQUIRE_PK</td>
+ <td>53</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_NO_FOREIGN_KEY</td>
+ <td>54</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DROP_NAMING_CONVENTION</td>
+ <td>55</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_COMMENT</td>
+ <td>56</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_PARTITION</td>
+ <td>57</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_TRIGGER</td>
+ <td>58</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_NO_DUPLICATE_INDEX</td>
+ <td>59</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_TEXT_FIELDS_TOTAL_LENGTH</td>
+ <td>60</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_SET_CHARSET</td>
+ <td>61</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_DDL</td>
+ <td>62</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_DML</td>
+ <td>63</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_LIMIT_SIZE</td>
+ <td>64</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_REQUIRE_CHARSET</td>
+ <td>65</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_REQUIRE_COLLATION</td>
+ <td>66</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRED</td>
+ <td>67</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_NO_NULL</td>
+ <td>68</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_CHANGE_TYPE</td>
+ <td>69</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_SET_DEFAULT_FOR_NOT_NULL</td>
+ <td>70</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_CHANGE</td>
+ <td>71</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_CHANGING_ORDER</td>
+ <td>72</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_DROP</td>
+ <td>73</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_DROP_IN_INDEX</td>
+ <td>74</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_COMMENT</td>
+ <td>75</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_AUTO_INCREMENT_MUST_INTEGER</td>
+ <td>76</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_TYPE_DISALLOW_LIST</td>
+ <td>77</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_SET_CHARSET</td>
+ <td>78</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_MAXIMUM_CHARACTER_LENGTH</td>
+ <td>79</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_MAXIMUM_VARCHAR_LENGTH</td>
+ <td>80</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_AUTO_INCREMENT_INITIAL_VALUE</td>
+ <td>81</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_AUTO_INCREMENT_MUST_UNSIGNED</td>
+ <td>82</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_CURRENT_TIME_COUNT_LIMIT</td>
+ <td>83</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRE_DEFAULT</td>
+ <td>84</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DEFAULT_DISALLOW_VOLATILE</td>
+ <td>85</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT</td>
+ <td>86</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRE_CHARSET</td>
+ <td>87</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRE_COLLATION</td>
+ <td>88</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SCHEMA_BACKWARD_COMPATIBILITY</td>
+ <td>89</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>DATABASE_DROP_EMPTY_DATABASE</td>
+ <td>90</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_NO_DUPLICATE_COLUMN</td>
+ <td>91</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_KEY_NUMBER_LIMIT</td>
+ <td>92</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_PK_TYPE_LIMIT</td>
+ <td>93</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_TYPE_NO_BLOB</td>
+ <td>94</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_TOTAL_NUMBER_LIMIT</td>
+ <td>95</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_PRIMARY_KEY_TYPE_ALLOWLIST</td>
+ <td>96</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_CREATE_CONCURRENTLY</td>
+ <td>97</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_TYPE_ALLOW_LIST</td>
+ <td>98</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_NOT_REDUNDANT</td>
+ <td>99</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_CHARSET_ALLOWLIST</td>
+ <td>100</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_COLLATION_ALLOWLIST</td>
+ <td>101</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_COMMENT_LENGTH</td>
+ <td>102</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_PROCEDURE_DISALLOW_CREATE</td>
+ <td>103</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_EVENT_DISALLOW_CREATE</td>
+ <td>104</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_VIEW_DISALLOW_CREATE</td>
+ <td>105</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_FUNCTION_DISALLOW_CREATE</td>
+ <td>106</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_FUNCTION_DISALLOWED_LIST</td>
+ <td>107</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>ADVICE_ONLINE_MIGRATION</td>
+ <td>108</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>BUILTIN_PRIOR_BACKUP_CHECK</td>
+ <td>109</td>
+ <td><p></p></td>
+ </tr>
+
+ </tbody>
+ </table>
+
diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.md
index 5cb870515f..135ca8e11e 100644
--- a/proto/gen/grpc-doc/v1/README.md
+++ b/proto/gen/grpc-doc/v1/README.md
@@ -550,6 +550,7 @@
- [UpdateReviewConfigRequest](#bytebase-v1-UpdateReviewConfigRequest)
- [SQLReviewRule.Level](#bytebase-v1-SQLReviewRule-Level)
+ - [SQLReviewRule.Type](#bytebase-v1-SQLReviewRule-Type)
- [ReviewConfigService](#bytebase-v1-ReviewConfigService)
@@ -9003,7 +9004,7 @@ SQL review rule configuration. Check the SQL_REVIEW_RULES_DOCUMENTATION.md for d
| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
-| type | [string](#string) | | The type of SQL review rule. |
+| type | [SQLReviewRule.Type](#bytebase-v1-SQLReviewRule-Type) | | The type of SQL review rule. |
| level | [SQLReviewRule.Level](#bytebase-v1-SQLReviewRule-Level) | | The severity level of the rule. |
| payload | [string](#string) | | The payload is a JSON string that varies by rule type. |
| engine | [Engine](#bytebase-v1-Engine) | | The database engine this rule applies to. |
@@ -9046,6 +9047,126 @@ The severity level for SQL review rules.
| WARNING | 2 | Rule violation is a warning. |
+
+<a name="bytebase-v1-SQLReviewRule-Type"></a>
+
+### SQLReviewRule.Type
+
+
+| Name | Number | Description |
+| ---- | ------ | ----------- |
+| TYPE_UNSPECIFIED | 0 | |
+| ENGINE_MYSQL_USE_INNODB | 1 | |
+| NAMING_FULLY_QUALIFIED | 2 | |
+| NAMING_TABLE | 3 | |
+| NAMING_COLUMN | 4 | |
+| NAMING_INDEX_PK | 5 | |
+| NAMING_INDEX_UK | 6 | |
+| NAMING_INDEX_FK | 7 | |
+| NAMING_INDEX_IDX | 8 | |
+| NAMING_COLUMN_AUTO_INCREMENT | 9 | |
+| NAMING_TABLE_NO_KEYWORD | 10 | |
+| NAMING_IDENTIFIER_NO_KEYWORD | 11 | |
+| NAMING_IDENTIFIER_CASE | 12 | |
+| STATEMENT_SELECT_NO_SELECT_ALL | 13 | |
+| STATEMENT_WHERE_REQUIRE_SELECT | 14 | |
+| STATEMENT_WHERE_REQUIRE_UPDATE_DELETE | 15 | |
+| STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE | 16 | |
+| STATEMENT_DISALLOW_ON_DEL_CASCADE | 17 | |
+| STATEMENT_DISALLOW_RM_TBL_CASCADE | 18 | |
+| STATEMENT_DISALLOW_COMMIT | 19 | |
+| STATEMENT_DISALLOW_LIMIT | 20 | |
+| STATEMENT_DISALLOW_ORDER_BY | 21 | |
+| STATEMENT_MERGE_ALTER_TABLE | 22 | |
+| STATEMENT_INSERT_ROW_LIMIT | 23 | |
+| STATEMENT_INSERT_MUST_SPECIFY_COLUMN | 24 | |
+| STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND | 25 | |
+| STATEMENT_AFFECTED_ROW_LIMIT | 26 | |
+| STATEMENT_DML_DRY_RUN | 27 | |
+| STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT | 28 | |
+| STATEMENT_ADD_CHECK_NOT_VALID | 29 | |
+| STATEMENT_ADD_FOREIGN_KEY_NOT_VALID | 30 | |
+| STATEMENT_DISALLOW_ADD_NOT_NULL | 31 | |
+| STATEMENT_SELECT_FULL_TABLE_SCAN | 32 | |
+| STATEMENT_CREATE_SPECIFY_SCHEMA | 33 | |
+| STATEMENT_CHECK_SET_ROLE_VARIABLE | 34 | |
+| STATEMENT_DISALLOW_USING_FILESORT | 35 | |
+| STATEMENT_DISALLOW_USING_TEMPORARY | 36 | |
+| STATEMENT_WHERE_NO_EQUAL_NULL | 37 | |
+| STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS | 38 | |
+| STATEMENT_QUERY_MINIMUM_PLAN_LEVEL | 39 | |
+| STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT | 40 | |
+| STATEMENT_MAXIMUM_LIMIT_VALUE | 41 | |
+| STATEMENT_MAXIMUM_JOIN_TABLE_COUNT | 42 | |
+| STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION | 43 | |
+| STATEMENT_JOIN_STRICT_COLUMN_ATTRS | 44 | |
+| STATEMENT_NON_TRANSACTIONAL | 45 | |
+| STATEMENT_ADD_COLUMN_WITHOUT_POSITION | 46 | |
+| STATEMENT_DISALLOW_OFFLINE_DDL | 47 | |
+| STATEMENT_DISALLOW_CROSS_DB_QUERIES | 48 | |
+| STATEMENT_MAX_EXECUTION_TIME | 49 | |
+| STATEMENT_REQUIRE_ALGORITHM_OPTION | 50 | |
+| STATEMENT_REQUIRE_LOCK_OPTION | 51 | |
+| STATEMENT_OBJECT_OWNER_CHECK | 52 | |
+| TABLE_REQUIRE_PK | 53 | |
+| TABLE_NO_FOREIGN_KEY | 54 | |
+| TABLE_DROP_NAMING_CONVENTION | 55 | |
+| TABLE_COMMENT | 56 | |
+| TABLE_DISALLOW_PARTITION | 57 | |
+| TABLE_DISALLOW_TRIGGER | 58 | |
+| TABLE_NO_DUPLICATE_INDEX | 59 | |
+| TABLE_TEXT_FIELDS_TOTAL_LENGTH | 60 | |
+| TABLE_DISALLOW_SET_CHARSET | 61 | |
+| TABLE_DISALLOW_DDL | 62 | |
+| TABLE_DISALLOW_DML | 63 | |
+| TABLE_LIMIT_SIZE | 64 | |
+| TABLE_REQUIRE_CHARSET | 65 | |
+| TABLE_REQUIRE_COLLATION | 66 | |
+| COLUMN_REQUIRED | 67 | |
+| COLUMN_NO_NULL | 68 | |
+| COLUMN_DISALLOW_CHANGE_TYPE | 69 | |
+| COLUMN_SET_DEFAULT_FOR_NOT_NULL | 70 | |
+| COLUMN_DISALLOW_CHANGE | 71 | |
+| COLUMN_DISALLOW_CHANGING_ORDER | 72 | |
+| COLUMN_DISALLOW_DROP | 73 | |
+| COLUMN_DISALLOW_DROP_IN_INDEX | 74 | |
+| COLUMN_COMMENT | 75 | |
+| COLUMN_AUTO_INCREMENT_MUST_INTEGER | 76 | |
+| COLUMN_TYPE_DISALLOW_LIST | 77 | |
+| COLUMN_DISALLOW_SET_CHARSET | 78 | |
+| COLUMN_MAXIMUM_CHARACTER_LENGTH | 79 | |
+| COLUMN_MAXIMUM_VARCHAR_LENGTH | 80 | |
+| COLUMN_AUTO_INCREMENT_INITIAL_VALUE | 81 | |
+| COLUMN_AUTO_INCREMENT_MUST_UNSIGNED | 82 | |
+| COLUMN_CURRENT_TIME_COUNT_LIMIT | 83 | |
+| COLUMN_REQUIRE_DEFAULT | 84 | |
+| COLUMN_DEFAULT_DISALLOW_VOLATILE | 85 | |
+| COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT | 86 | |
+| COLUMN_REQUIRE_CHARSET | 87 | |
+| COLUMN_REQUIRE_COLLATION | 88 | |
+| SCHEMA_BACKWARD_COMPATIBILITY | 89 | |
+| DATABASE_DROP_EMPTY_DATABASE | 90 | |
+| INDEX_NO_DUPLICATE_COLUMN | 91 | |
+| INDEX_KEY_NUMBER_LIMIT | 92 | |
+| INDEX_PK_TYPE_LIMIT | 93 | |
+| INDEX_TYPE_NO_BLOB | 94 | |
+| INDEX_TOTAL_NUMBER_LIMIT | 95 | |
+| INDEX_PRIMARY_KEY_TYPE_ALLOWLIST | 96 | |
+| INDEX_CREATE_CONCURRENTLY | 97 | |
+| INDEX_TYPE_ALLOW_LIST | 98 | |
+| INDEX_NOT_REDUNDANT | 99 | |
+| SYSTEM_CHARSET_ALLOWLIST | 100 | |
+| SYSTEM_COLLATION_ALLOWLIST | 101 | |
+| SYSTEM_COMMENT_LENGTH | 102 | |
+| SYSTEM_PROCEDURE_DISALLOW_CREATE | 103 | |
+| SYSTEM_EVENT_DISALLOW_CREATE | 104 | |
+| SYSTEM_VIEW_DISALLOW_CREATE | 105 | |
+| SYSTEM_FUNCTION_DISALLOW_CREATE | 106 | |
+| SYSTEM_FUNCTION_DISALLOWED_LIST | 107 | |
+| ADVICE_ONLINE_MIGRATION | 108 | |
+| BUILTIN_PRIOR_BACKUP_CHECK | 109 | |
+
+
diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.html
index 7c0ea4d632..8e1e31c328 100644
--- a/proto/gen/grpc-doc/v1/index.html
+++ b/proto/gen/grpc-doc/v1/index.html
@@ -2277,6 +2277,10 @@
<a href="#bytebase.v1.SQLReviewRule.Level"><span class="badge">E</span>SQLReviewRule.Level</a>
</li>
+ <li>
+ <a href="#bytebase.v1.SQLReviewRule.Type"><span class="badge">E</span>SQLReviewRule.Type</a>
+ </li>
+
<li>
@@ -25217,7 +25221,7 @@ Format: {resource}/{resource id}, e.g., environments/test. </p></td>
<tr>
<td>type</td>
- <td><a href="#string">string</a></td>
+ <td><a href="#bytebase.v1.SQLReviewRule.Type">SQLReviewRule.Type</a></td>
<td></td>
<td><p>The type of SQL review rule. </p></td>
</tr>
@@ -25322,6 +25326,677 @@ In this situation, `update_mask` is ignored. </p></td>
</tbody>
</table>
+ <h3 id="bytebase.v1.SQLReviewRule.Type">SQLReviewRule.Type</h3>
+ <p></p>
+ <table class="enum-table">
+ <thead>
+ <tr><td>Name</td><td>Number</td><td>Description</td></tr>
+ </thead>
+ <tbody>
+
+ <tr>
+ <td>TYPE_UNSPECIFIED</td>
+ <td>0</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>ENGINE_MYSQL_USE_INNODB</td>
+ <td>1</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_FULLY_QUALIFIED</td>
+ <td>2</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_TABLE</td>
+ <td>3</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_COLUMN</td>
+ <td>4</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_PK</td>
+ <td>5</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_UK</td>
+ <td>6</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_FK</td>
+ <td>7</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_INDEX_IDX</td>
+ <td>8</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_COLUMN_AUTO_INCREMENT</td>
+ <td>9</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_TABLE_NO_KEYWORD</td>
+ <td>10</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_IDENTIFIER_NO_KEYWORD</td>
+ <td>11</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>NAMING_IDENTIFIER_CASE</td>
+ <td>12</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_SELECT_NO_SELECT_ALL</td>
+ <td>13</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_REQUIRE_SELECT</td>
+ <td>14</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_REQUIRE_UPDATE_DELETE</td>
+ <td>15</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE</td>
+ <td>16</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ON_DEL_CASCADE</td>
+ <td>17</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_RM_TBL_CASCADE</td>
+ <td>18</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_COMMIT</td>
+ <td>19</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_LIMIT</td>
+ <td>20</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ORDER_BY</td>
+ <td>21</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MERGE_ALTER_TABLE</td>
+ <td>22</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_INSERT_ROW_LIMIT</td>
+ <td>23</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_INSERT_MUST_SPECIFY_COLUMN</td>
+ <td>24</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND</td>
+ <td>25</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_AFFECTED_ROW_LIMIT</td>
+ <td>26</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DML_DRY_RUN</td>
+ <td>27</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT</td>
+ <td>28</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_ADD_CHECK_NOT_VALID</td>
+ <td>29</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_ADD_FOREIGN_KEY_NOT_VALID</td>
+ <td>30</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_ADD_NOT_NULL</td>
+ <td>31</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_SELECT_FULL_TABLE_SCAN</td>
+ <td>32</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_CREATE_SPECIFY_SCHEMA</td>
+ <td>33</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_CHECK_SET_ROLE_VARIABLE</td>
+ <td>34</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_USING_FILESORT</td>
+ <td>35</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_USING_TEMPORARY</td>
+ <td>36</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_NO_EQUAL_NULL</td>
+ <td>37</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS</td>
+ <td>38</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_QUERY_MINIMUM_PLAN_LEVEL</td>
+ <td>39</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT</td>
+ <td>40</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAXIMUM_LIMIT_VALUE</td>
+ <td>41</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAXIMUM_JOIN_TABLE_COUNT</td>
+ <td>42</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION</td>
+ <td>43</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_JOIN_STRICT_COLUMN_ATTRS</td>
+ <td>44</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_NON_TRANSACTIONAL</td>
+ <td>45</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_ADD_COLUMN_WITHOUT_POSITION</td>
+ <td>46</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_OFFLINE_DDL</td>
+ <td>47</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_DISALLOW_CROSS_DB_QUERIES</td>
+ <td>48</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_MAX_EXECUTION_TIME</td>
+ <td>49</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_REQUIRE_ALGORITHM_OPTION</td>
+ <td>50</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_REQUIRE_LOCK_OPTION</td>
+ <td>51</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>STATEMENT_OBJECT_OWNER_CHECK</td>
+ <td>52</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_REQUIRE_PK</td>
+ <td>53</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_NO_FOREIGN_KEY</td>
+ <td>54</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DROP_NAMING_CONVENTION</td>
+ <td>55</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_COMMENT</td>
+ <td>56</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_PARTITION</td>
+ <td>57</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_TRIGGER</td>
+ <td>58</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_NO_DUPLICATE_INDEX</td>
+ <td>59</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_TEXT_FIELDS_TOTAL_LENGTH</td>
+ <td>60</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_SET_CHARSET</td>
+ <td>61</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_DDL</td>
+ <td>62</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_DISALLOW_DML</td>
+ <td>63</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_LIMIT_SIZE</td>
+ <td>64</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_REQUIRE_CHARSET</td>
+ <td>65</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>TABLE_REQUIRE_COLLATION</td>
+ <td>66</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRED</td>
+ <td>67</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_NO_NULL</td>
+ <td>68</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_CHANGE_TYPE</td>
+ <td>69</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_SET_DEFAULT_FOR_NOT_NULL</td>
+ <td>70</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_CHANGE</td>
+ <td>71</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_CHANGING_ORDER</td>
+ <td>72</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_DROP</td>
+ <td>73</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_DROP_IN_INDEX</td>
+ <td>74</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_COMMENT</td>
+ <td>75</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_AUTO_INCREMENT_MUST_INTEGER</td>
+ <td>76</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_TYPE_DISALLOW_LIST</td>
+ <td>77</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DISALLOW_SET_CHARSET</td>
+ <td>78</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_MAXIMUM_CHARACTER_LENGTH</td>
+ <td>79</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_MAXIMUM_VARCHAR_LENGTH</td>
+ <td>80</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_AUTO_INCREMENT_INITIAL_VALUE</td>
+ <td>81</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_AUTO_INCREMENT_MUST_UNSIGNED</td>
+ <td>82</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_CURRENT_TIME_COUNT_LIMIT</td>
+ <td>83</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRE_DEFAULT</td>
+ <td>84</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_DEFAULT_DISALLOW_VOLATILE</td>
+ <td>85</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT</td>
+ <td>86</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRE_CHARSET</td>
+ <td>87</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>COLUMN_REQUIRE_COLLATION</td>
+ <td>88</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SCHEMA_BACKWARD_COMPATIBILITY</td>
+ <td>89</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>DATABASE_DROP_EMPTY_DATABASE</td>
+ <td>90</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_NO_DUPLICATE_COLUMN</td>
+ <td>91</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_KEY_NUMBER_LIMIT</td>
+ <td>92</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_PK_TYPE_LIMIT</td>
+ <td>93</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_TYPE_NO_BLOB</td>
+ <td>94</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_TOTAL_NUMBER_LIMIT</td>
+ <td>95</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_PRIMARY_KEY_TYPE_ALLOWLIST</td>
+ <td>96</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_CREATE_CONCURRENTLY</td>
+ <td>97</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_TYPE_ALLOW_LIST</td>
+ <td>98</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>INDEX_NOT_REDUNDANT</td>
+ <td>99</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_CHARSET_ALLOWLIST</td>
+ <td>100</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_COLLATION_ALLOWLIST</td>
+ <td>101</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_COMMENT_LENGTH</td>
+ <td>102</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_PROCEDURE_DISALLOW_CREATE</td>
+ <td>103</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_EVENT_DISALLOW_CREATE</td>
+ <td>104</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_VIEW_DISALLOW_CREATE</td>
+ <td>105</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_FUNCTION_DISALLOW_CREATE</td>
+ <td>106</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>SYSTEM_FUNCTION_DISALLOWED_LIST</td>
+ <td>107</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>ADVICE_ONLINE_MIGRATION</td>
+ <td>108</td>
+ <td><p></p></td>
+ </tr>
+
+ <tr>
+ <td>BUILTIN_PRIOR_BACKUP_CHECK</td>
+ <td>109</td>
+ <td><p></p></td>
+ </tr>
+
+ </tbody>
+ </table>
+
diff --git a/proto/store/store/review_config.proto b/proto/store/store/review_config.proto
index d1282d9102..58eac75774 100644
--- a/proto/store/store/review_config.proto
+++ b/proto/store/store/review_config.proto
@@ -21,7 +21,120 @@ message SQLReviewRule {
WARNING = 2;
}
- string type = 1;
+ enum Type {
+ TYPE_UNSPECIFIED = 0;
+ ENGINE_MYSQL_USE_INNODB = 1;
+ NAMING_FULLY_QUALIFIED = 2;
+ NAMING_TABLE = 3;
+ NAMING_COLUMN = 4;
+ NAMING_INDEX_PK = 5;
+ NAMING_INDEX_UK = 6;
+ NAMING_INDEX_FK = 7;
+ NAMING_INDEX_IDX = 8;
+ NAMING_COLUMN_AUTO_INCREMENT = 9;
+ NAMING_TABLE_NO_KEYWORD = 10;
+ NAMING_IDENTIFIER_NO_KEYWORD = 11;
+ NAMING_IDENTIFIER_CASE = 12;
+ STATEMENT_SELECT_NO_SELECT_ALL = 13;
+ STATEMENT_WHERE_REQUIRE_SELECT = 14;
+ STATEMENT_WHERE_REQUIRE_UPDATE_DELETE = 15;
+ STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE = 16;
+ STATEMENT_DISALLOW_ON_DEL_CASCADE = 17;
+ STATEMENT_DISALLOW_RM_TBL_CASCADE = 18;
+ STATEMENT_DISALLOW_COMMIT = 19;
+ STATEMENT_DISALLOW_LIMIT = 20;
+ STATEMENT_DISALLOW_ORDER_BY = 21;
+ STATEMENT_MERGE_ALTER_TABLE = 22;
+ STATEMENT_INSERT_ROW_LIMIT = 23;
+ STATEMENT_INSERT_MUST_SPECIFY_COLUMN = 24;
+ STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND = 25;
+ STATEMENT_AFFECTED_ROW_LIMIT = 26;
+ STATEMENT_DML_DRY_RUN = 27;
+ STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT = 28;
+ STATEMENT_ADD_CHECK_NOT_VALID = 29;
+ STATEMENT_ADD_FOREIGN_KEY_NOT_VALID = 30;
+ STATEMENT_DISALLOW_ADD_NOT_NULL = 31;
+ STATEMENT_SELECT_FULL_TABLE_SCAN = 32;
+ STATEMENT_CREATE_SPECIFY_SCHEMA = 33;
+ STATEMENT_CHECK_SET_ROLE_VARIABLE = 34;
+ STATEMENT_DISALLOW_USING_FILESORT = 35;
+ STATEMENT_DISALLOW_USING_TEMPORARY = 36;
+ STATEMENT_WHERE_NO_EQUAL_NULL = 37;
+ STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38;
+ STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39;
+ STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40;
+ STATEMENT_MAXIMUM_LIMIT_VALUE = 41;
+ STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42;
+ STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43;
+ STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44;
+ STATEMENT_NON_TRANSACTIONAL = 45;
+ STATEMENT_ADD_COLUMN_WITHOUT_POSITION = 46;
+ STATEMENT_DISALLOW_OFFLINE_DDL = 47;
+ STATEMENT_DISALLOW_CROSS_DB_QUERIES = 48;
+ STATEMENT_MAX_EXECUTION_TIME = 49;
+ STATEMENT_REQUIRE_ALGORITHM_OPTION = 50;
+ STATEMENT_REQUIRE_LOCK_OPTION = 51;
+ STATEMENT_OBJECT_OWNER_CHECK = 52;
+ TABLE_REQUIRE_PK = 53;
+ TABLE_NO_FOREIGN_KEY = 54;
+ TABLE_DROP_NAMING_CONVENTION = 55;
+ TABLE_COMMENT = 56;
+ TABLE_DISALLOW_PARTITION = 57;
+ TABLE_DISALLOW_TRIGGER = 58;
+ TABLE_NO_DUPLICATE_INDEX = 59;
+ TABLE_TEXT_FIELDS_TOTAL_LENGTH = 60;
+ TABLE_DISALLOW_SET_CHARSET = 61;
+ TABLE_DISALLOW_DDL = 62;
+ TABLE_DISALLOW_DML = 63;
+ TABLE_LIMIT_SIZE = 64;
+ TABLE_REQUIRE_CHARSET = 65;
+ TABLE_REQUIRE_COLLATION = 66;
+ COLUMN_REQUIRED = 67;
+ COLUMN_NO_NULL = 68;
+ COLUMN_DISALLOW_CHANGE_TYPE = 69;
+ COLUMN_SET_DEFAULT_FOR_NOT_NULL = 70;
+ COLUMN_DISALLOW_CHANGE = 71;
+ COLUMN_DISALLOW_CHANGING_ORDER = 72;
+ COLUMN_DISALLOW_DROP = 73;
+ COLUMN_DISALLOW_DROP_IN_INDEX = 74;
+ COLUMN_COMMENT = 75;
+ COLUMN_AUTO_INCREMENT_MUST_INTEGER = 76;
+ COLUMN_TYPE_DISALLOW_LIST = 77;
+ COLUMN_DISALLOW_SET_CHARSET = 78;
+ COLUMN_MAXIMUM_CHARACTER_LENGTH = 79;
+ COLUMN_MAXIMUM_VARCHAR_LENGTH = 80;
+ COLUMN_AUTO_INCREMENT_INITIAL_VALUE = 81;
+ COLUMN_AUTO_INCREMENT_MUST_UNSIGNED = 82;
+ COLUMN_CURRENT_TIME_COUNT_LIMIT = 83;
+ COLUMN_REQUIRE_DEFAULT = 84;
+ COLUMN_DEFAULT_DISALLOW_VOLATILE = 85;
+ COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT = 86;
+ COLUMN_REQUIRE_CHARSET = 87;
+ COLUMN_REQUIRE_COLLATION = 88;
+ SCHEMA_BACKWARD_COMPATIBILITY = 89;
+ DATABASE_DROP_EMPTY_DATABASE = 90;
+ INDEX_NO_DUPLICATE_COLUMN = 91;
+ INDEX_KEY_NUMBER_LIMIT = 92;
+ INDEX_PK_TYPE_LIMIT = 93;
+ INDEX_TYPE_NO_BLOB = 94;
+ INDEX_TOTAL_NUMBER_LIMIT = 95;
+ INDEX_PRIMARY_KEY_TYPE_ALLOWLIST = 96;
+ INDEX_CREATE_CONCURRENTLY = 97;
+ INDEX_TYPE_ALLOW_LIST = 98;
+ INDEX_NOT_REDUNDANT = 99;
+ SYSTEM_CHARSET_ALLOWLIST = 100;
+ SYSTEM_COLLATION_ALLOWLIST = 101;
+ SYSTEM_COMMENT_LENGTH = 102;
+ SYSTEM_PROCEDURE_DISALLOW_CREATE = 103;
+ SYSTEM_EVENT_DISALLOW_CREATE = 104;
+ SYSTEM_VIEW_DISALLOW_CREATE = 105;
+ SYSTEM_FUNCTION_DISALLOW_CREATE = 106;
+ SYSTEM_FUNCTION_DISALLOWED_LIST = 107;
+ ADVICE_ONLINE_MIGRATION = 108;
+ BUILTIN_PRIOR_BACKUP_CHECK = 109;
+ }
+
+ Type type = 1;
Level level = 2;
string payload = 3;
Engine engine = 4;
diff --git a/proto/v1/v1/SQL_REVIEW_RULES_DOCUMENTATION.md b/proto/v1/v1/SQL_REVIEW_RULES_DOCUMENTATION.md
deleted file mode 100644
index c7c39badde..0000000000
--- a/proto/v1/v1/SQL_REVIEW_RULES_DOCUMENTATION.md
+++ /dev/null
@@ -1,966 +0,0 @@
-# SQL Review Rules Documentation
-
-This document provides comprehensive documentation for all SQL Review Rule types available in Bytebase, including their payload structures and examples.
-
-## Table of Contents
-
-1. [Rule Categories](#rule-categories)
-2. [Payload Structure Types](#payload-structure-types)
-3. [Template Tokens](#template-tokens)
-4. [Engine Support](#engine-support)
-
-## Rule Categories
-
-### 1. Engine Rules
-
-#### `engine.mysql.use-innodb`
-**Description**: Require InnoDB as storage engine (MySQL/MariaDB only)
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
----
-
-### 2. Naming Rules
-
-#### `naming.fully-qualified`
-**Description**: Enforce using fully qualified object names
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `naming.table`
-**Description**: Enforce table name format
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^[a-z]+(_[a-z]+)*$",
- "maxLength": 64
-}
-```
-
-#### `naming.column`
-**Description**: Enforce column name format
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^[a-z]+(_[a-z]+)*$",
- "maxLength": 64
-}
-```
-
-#### `naming.index.pk`
-**Description**: Enforce primary key name format
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^pk_{{table}}_{{column_list}}$",
- "maxLength": 64
-}
-```
-
-#### `naming.index.uk`
-**Description**: Enforce unique key name format
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^uk_{{table}}_{{column_list}}$",
- "maxLength": 64
-}
-```
-
-#### `naming.index.fk`
-**Description**: Enforce foreign key name format
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$",
- "maxLength": 64
-}
-```
-
-#### `naming.index.idx`
-**Description**: Enforce index name format
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^idx_{{table}}_{{column_list}}$",
- "maxLength": 64
-}
-```
-
-#### `naming.column.auto-increment`
-**Description**: Enforce auto-increment column name format
-**Engines**: MySQL, MariaDB
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "^id$",
- "maxLength": 64
-}
-```
-
-#### `naming.table.no-keyword`
-**Description**: Enforce table name not to use keywords
-**Engines**: All
-**Payload**: None (empty)
-
-#### `naming.identifier.no-keyword`
-**Description**: Enforce identifier not to use keywords
-**Engines**: All
-**Payload**: None (empty)
-
-#### `naming.identifier.case`
-**Description**: Enforce identifier case convention
-**Engines**: All
-**Payload Structure**: `NamingCaseRulePayload`
-```json
-{
- "upper": true
-}
-```
-
----
-
-### 3. Statement Rules
-
-#### Basic Statement Rules
-
-#### `statement.select.no-select-all`
-**Description**: Disallow 'SELECT *' statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.where.require.select`
-**Description**: Require 'WHERE' clause for SELECT statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.where.require.update-delete`
-**Description**: Require 'WHERE' clause for UPDATE/DELETE statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.where.no-leading-wildcard-like`
-**Description**: Disallow leading '%' in LIKE conditions
-**Engines**: All
-**Payload**: None (empty)
-
-#### DDL/DML Control Rules
-
-#### `statement.disallow-commit`
-**Description**: Disallow using COMMIT statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.disallow-limit`
-**Description**: Disallow LIMIT in INSERT/DELETE/UPDATE statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.disallow-order-by`
-**Description**: Disallow ORDER BY in DELETE/UPDATE statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.merge-alter-table`
-**Description**: Disallow redundant ALTER TABLE statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.disallow-mix-in-ddl`
-**Description**: Disallow DML statements in DDL transactions
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.disallow-mix-in-dml`
-**Description**: Disallow DDL statements in DML transactions
-**Engines**: All
-**Payload**: None (empty)
-
-#### Insert Rules
-
-#### `statement.insert.row-limit`
-**Description**: Enforce insert row limit
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 1000
-}
-```
-
-#### `statement.insert.must-specify-column`
-**Description**: Enforce column specification in INSERT statements
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.insert.disallow-order-by-rand`
-**Description**: Disallow ORDER BY RAND in INSERT statements
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### Performance Rules
-
-#### `statement.affected-row-limit`
-**Description**: Enforce UPDATE/DELETE affected row limit
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 1000
-}
-```
-
-#### `statement.maximum-limit-value`
-**Description**: Enforce maximum LIMIT value
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 1000
-}
-```
-
-#### `statement.maximum-join-table-count`
-**Description**: Enforce maximum join table count
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 2
-}
-```
-
-#### `statement.where.maximum-logical-operator-count`
-**Description**: Enforce maximum logical operators in WHERE clause
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 10
-}
-```
-
-#### Advanced Statement Rules
-
-#### `statement.dml-dry-run`
-**Description**: Dry run DML statements before execution
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.where.no-equal-null`
-**Description**: Check WHERE clause does not use equality with NULL
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.where.disallow-functions-and-calculations`
-**Description**: Disallow functions and calculations in WHERE clause
-**Engines**: All
-**Payload**: None (empty)
-
-#### `statement.query.minimum-plan-level`
-**Description**: Enforce minimum query execution plan level
-**Engines**: All
-**Payload Structure**: `StringTypeRulePayload`
-```json
-{
- "string": "INDEX"
-}
-```
-
-#### `statement.max-execution-time`
-**Description**: Enforce maximum execution time
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `statement.require-algorithm-option`
-**Description**: Require ALGORITHM option in ALTER TABLE
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `statement.require-lock-option`
-**Description**: Require LOCK option in ALTER TABLE
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### PostgreSQL-specific Statement Rules
-
-#### `statement.disallow-on-del-cascade`
-**Description**: Disallow ON DELETE CASCADE
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.disallow-rm-tbl-cascade`
-**Description**: Disallow CASCADE when removing table
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.disallow-add-column-with-default`
-**Description**: Disallow adding column with DEFAULT value
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.add-check-not-valid`
-**Description**: Require adding check constraints as NOT VALID
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.add-foreign-key-not-valid`
-**Description**: Require adding foreign key as NOT VALID
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.disallow-add-not-null`
-**Description**: Disallow adding NOT NULL constraint
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.create-specify-schema`
-**Description**: Disallow creating table without schema specification
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.check-set-role-variable`
-**Description**: Require check for SET ROLE variable
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.object-owner-check`
-**Description**: Check object ownership
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `statement.non-transactional`
-**Description**: Check for non-transactional statements
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
----
-
-### 4. Table Rules
-
-#### `table.require-pk`
-**Description**: Require table to have primary key
-**Engines**: All
-**Payload**: None (empty)
-
-#### `table.no-foreign-key`
-**Description**: Disallow foreign keys
-**Engines**: All
-**Payload**: None (empty)
-
-#### `table.drop-naming-convention`
-**Description**: Only allow dropping tables that match naming convention
-**Engines**: All
-**Payload Structure**: `NamingRulePayload`
-```json
-{
- "format": "_del$"
-}
-```
-
-#### `table.comment`
-**Description**: Enforce table comment convention
-**Engines**: All
-**Payload Structure**: `CommentConventionRulePayload`
-```json
-{
- "required": true,
- "requiredClassification": false,
- "maxLength": 64
-}
-```
-
-#### `table.disallow-partition`
-**Description**: Disallow table partitioning
-**Engines**: All
-**Payload**: None (empty)
-
-#### `table.disallow-trigger`
-**Description**: Disallow table triggers
-**Engines**: All
-**Payload**: None (empty)
-
-#### `table.no-duplicate-index`
-**Description**: Require no duplicate indexes
-**Engines**: All
-**Payload**: None (empty)
-
-#### `table.text-fields-total-length`
-**Description**: Enforce total length limit of text fields
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 1000
-}
-```
-
-#### `table.disallow-set-charset`
-**Description**: Disallow setting table charset
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `table.disallow-ddl`
-**Description**: Disallow DDL operations on specific tables
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["table1", "table2", "sensitive_table"]
-}
-```
-
-#### `table.disallow-dml`
-**Description**: Disallow DML operations on specific tables
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["readonly_table", "archive_table"]
-}
-```
-
-#### `table.limit-size`
-**Description**: Restrict access to tables based on size
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 10000000
-}
-```
-
-#### `table.require-charset`
-**Description**: Enforce table charset requirement
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `table.require-collation`
-**Description**: Enforce table collation requirement
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
----
-
-### 5. Column Rules
-
-#### `column.required`
-**Description**: Enforce required columns in tables
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["id", "created_ts", "updated_ts", "creator_id", "updater_id"]
-}
-```
-
-#### `column.no-null`
-**Description**: Enforce columns cannot have NULL values
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.disallow-change-type`
-**Description**: Disallow changing column data type
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.set-default-for-not-null`
-**Description**: Require default value for NOT NULL columns
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.disallow-change`
-**Description**: Disallow CHANGE COLUMN operations
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `column.disallow-changing-order`
-**Description**: Disallow changing column order
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.disallow-drop`
-**Description**: Disallow dropping columns
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.disallow-drop-in-index`
-**Description**: Disallow dropping columns that are part of an index
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.comment`
-**Description**: Enforce column comment convention
-**Engines**: All
-**Payload Structure**: `CommentConventionRulePayload`
-```json
-{
- "required": true,
- "requiredClassification": false,
- "maxLength": 64
-}
-```
-
-#### `column.auto-increment-must-integer`
-**Description**: Require auto-increment columns to be integer type
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `column.type-disallow-list`
-**Description**: Enforce column type disallow list
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["JSON", "BINARY_FLOAT", "BLOB", "LONGTEXT"]
-}
-```
-
-#### `column.disallow-set-charset`
-**Description**: Disallow setting column charset
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `column.maximum-character-length`
-**Description**: Enforce maximum character length for string columns
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 20
-}
-```
-
-#### `column.maximum-varchar-length`
-**Description**: Enforce maximum varchar length
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 2560
-}
-```
-
-#### `column.auto-increment-initial-value`
-**Description**: Enforce auto-increment initial value
-**Engines**: MySQL, MariaDB
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 1
-}
-```
-
-#### `column.auto-increment-must-unsigned`
-**Description**: Require auto-increment columns to be unsigned
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `column.current-time-count-limit`
-**Description**: Enforce current time column count limit
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `column.require-default`
-**Description**: Enforce column default value requirement
-**Engines**: All
-**Payload**: None (empty)
-
-#### `column.default-disallow-volatile`
-**Description**: Disallow volatile functions in column defaults
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `column.require-charset`
-**Description**: Enforce column charset requirement
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `column.require-collation`
-**Description**: Enforce column collation requirement
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
----
-
-### 6. Index Rules
-
-#### `index.no-duplicate-column`
-**Description**: Require no duplicate columns in index
-**Engines**: All
-**Payload**: None (empty)
-
-#### `index.key-number-limit`
-**Description**: Enforce index key number limit
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 5
-}
-```
-
-#### `index.pk-type-limit`
-**Description**: Enforce primary key type restriction
-**Engines**: All
-**Payload**: None (empty)
-
-#### `index.type-no-blob`
-**Description**: Enforce no BLOB columns in index
-**Engines**: All
-**Payload**: None (empty)
-
-#### `index.total-number-limit`
-**Description**: Enforce total index number limit per table
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 5
-}
-```
-
-#### `index.primary-key-type-allowlist`
-**Description**: Enforce primary key type allowlist
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["serial", "bigserial", "int", "bigint", "uuid"]
-}
-```
-
-#### `index.create-concurrently`
-**Description**: Require creating indexes concurrently
-**Engines**: PostgreSQL
-**Payload**: None (empty)
-
-#### `index.type-allow-list`
-**Description**: Enforce index type allowlist
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["BTREE", "HASH", "GIN", "GIST"]
-}
-```
-
-#### `index.not-redundant`
-**Description**: Prohibit redundant indices
-**Engines**: All
-**Payload**: None (empty)
-
----
-
-### 7. System Rules
-
-#### `system.charset.allowlist`
-**Description**: Enforce charset allowlist
-**Engines**: MySQL, MariaDB
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["utf8mb4", "UTF8"]
-}
-```
-
-#### `system.collation.allowlist`
-**Description**: Enforce collation allowlist
-**Engines**: MySQL, MariaDB
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["utf8mb4_0900_ai_ci", "utf8mb4_unicode_ci"]
-}
-```
-
-#### `system.comment.length`
-**Description**: Limit comment length
-**Engines**: All
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 64
-}
-```
-
-#### `system.procedure.disallow-create`
-**Description**: Disallow creating stored procedures
-**Engines**: All
-**Payload**: None (empty)
-
-#### `system.event.disallow-create`
-**Description**: Disallow creating events
-**Engines**: MySQL, MariaDB
-**Payload**: None (empty)
-
-#### `system.view.disallow-create`
-**Description**: Disallow creating views
-**Engines**: All
-**Payload**: None (empty)
-
-#### `system.function.disallow-create`
-**Description**: Disallow creating functions
-**Engines**: All
-**Payload**: None (empty)
-
-#### `system.function.disallowed-list`
-**Description**: Enforce disallowed function list
-**Engines**: All
-**Payload Structure**: `StringArrayTypeRulePayload`
-```json
-{
- "list": ["rand", "uuid", "sleep", "now"]
-}
-```
-
----
-
-### 8. Schema Rules
-
-#### `schema.backward-compatibility`
-**Description**: Enforce backward compatibility in schema changes
-**Engines**: All
-**Payload**: None (empty)
-
----
-
-### 9. Database Rules
-
-#### `database.drop-empty-database`
-**Description**: Check if database is empty before allowing drop
-**Engines**: All
-**Payload**: None (empty)
-
----
-
-### 10. Advice Rules
-
-#### `advice.online-migration`
-**Description**: Advise using online migration for large tables
-**Engines**: MySQL, MariaDB
-**Payload Structure**: `NumberTypeRulePayload`
-```json
-{
- "number": 100000000
-}
-```
-
----
-
-### 11. Builtin Rules
-
-#### `builtin.prior-backup-check`
-**Description**: Check for prior backup before executing destructive operations
-**Engines**: All
-**Payload**: None (empty)
-
----
-
-## Payload Structure Types
-
-### 1. NamingRulePayload
-Used for naming convention rules that require format patterns and length limits.
-```json
-{
- "format": "string (regex pattern)",
- "maxLength": "number"
-}
-```
-
-**Example:**
-```json
-{
- "format": "^[a-z]+(_[a-z]+)*$",
- "maxLength": 64
-}
-```
-
-### 2. StringArrayTypeRulePayload
-Used for rules that work with lists of strings (allowlists, disallow lists, required items).
-```json
-{
- "list": ["string1", "string2", "string3"]
-}
-```
-
-**Example:**
-```json
-{
- "list": ["id", "created_ts", "updated_ts", "creator_id", "updater_id"]
-}
-```
-
-### 3. NumberTypeRulePayload
-Used for rules that enforce numeric limits or thresholds.
-```json
-{
- "number": "number"
-}
-```
-
-**Example:**
-```json
-{
- "number": 1000
-}
-```
-
-### 4. StringTypeRulePayload
-Used for rules that require a single string value.
-```json
-{
- "string": "string value"
-}
-```
-
-**Example:**
-```json
-{
- "string": "INDEX"
-}
-```
-
-### 5. CommentConventionRulePayload
-Used for comment-related rules that define requirements and constraints.
-```json
-{
- "required": "boolean",
- "requiredClassification": "boolean",
- "maxLength": "number"
-}
-```
-
-**Example:**
-```json
-{
- "required": true,
- "requiredClassification": false,
- "maxLength": 64
-}
-```
-
-### 6. NamingCaseRulePayload
-Used for case convention rules.
-```json
-{
- "upper": "boolean"
-}
-```
-
-**Example:**
-```json
-{
- "upper": true
-}
-```
-
----
-
-## Template Tokens
-
-For naming rules that support templates, the following tokens are available:
-
-| Token | Description | Usage Example |
-|-------|-------------|---------------|
-| `{{table}}` | Current table name | `idx_{{table}}_name` |
-| `{{column_list}}` | List of column names | `pk_{{table}}_{{column_list}}` |
-| `{{referencing_table}}` | Table that references another | `fk_{{referencing_table}}_{{referenced_table}}` |
-| `{{referencing_column}}` | Column that references another | `fk_{{referencing_table}}_{{referencing_column}}` |
-| `{{referenced_table}}` | Table being referenced | `fk_{{referencing_table}}_{{referenced_table}}` |
-| `{{referenced_column}}` | Column being referenced | `fk_{{referenced_table}}_{{referenced_column}}` |
-
-**Template Example:**
-```json
-{
- "format": "^fk_{{referencing_table}}_{{referencing_column}}_{{referenced_table}}_{{referenced_column}}$",
- "maxLength": 64
-}
-```
-
----
-
-## Engine Support
-
-Based on actual implementation in the codebase, the following database engines support SQL review rules:
-
-### Fully Supported Engines (100+ rules)
-- **MySQL** (`storepb.Engine_MYSQL`) - ~100+ rules with comprehensive coverage
-- **TiDB** (`storepb.Engine_TIDB`) - ~85+ rules with TiDB-specific optimizations
-
-### Well-Supported Engines (50+ rules)
-- **PostgreSQL** (`storepb.Engine_POSTGRES`) - ~65+ rules including PostgreSQL-specific features
-
-### Good Support (25-50 rules)
-- **Oracle** (`storepb.Engine_ORACLE`) - ~35+ rules covering fundamental areas
-- **Microsoft SQL Server** (`storepb.Engine_MSSQL`) - ~35+ rules with MSSQL-specific features
-- **Snowflake** (`storepb.Engine_SNOWFLAKE`) - ~27+ rules focused on key areas
-
-### Limited Support (< 10 rules)
-- **MariaDB** (`storepb.Engine_MARIADB`) - Inherits MySQL rule implementations
-- **OceanBase** (`storepb.Engine_OCEANBASE`) - ~3 rules with basic OceanBase optimizations
-
-### No SQL Review Support
-The following engines do **NOT** support SQL review rules:
-- ClickHouse, SQLite, MongoDB, Redis, Spanner, Redshift, StarRocks, Doris, Hive, Elasticsearch, BigQuery, DynamoDB, Databricks, CockroachDB, CosmosDB, Trino, Cassandra
-
-### Engine-Specific Rules
-
-#### MySQL/TiDB/MariaDB Specific
-- `engine.mysql.use-innodb`
-- `column.auto-increment-*` rules
-- `statement.require-algorithm-option`
-- `statement.require-lock-option`
-- `table.require-charset`
-- `system.charset.allowlist`
-- `system.collation.allowlist`
-
-#### PostgreSQL Specific
-- `naming.fully-qualified`
-- `statement.disallow-on-del-cascade`
-- `statement.disallow-rm-tbl-cascade`
-- `statement.add-check-not-valid`
-- `statement.add-foreign-key-not-valid`
-- `statement.disallow-add-column-with-default`
-- `statement.disallow-add-not-null`
-- `statement.create-specify-schema`
-- `index.create-concurrently`
-- `column.default-disallow-volatile`
-
-#### Oracle Specific
-- Oracle-compatible naming and type rules
-
-#### SQL Server Specific
-- MSSQL-compatible syntax and feature rules
-
-#### Snowflake Specific
-- Snowflake-compatible data types and syntax rules
-
-#### Cross-Engine Rules
-Most naming, table, column, and basic statement rules work across all supported engines with engine-appropriate implementations.
-
----
-
-## Usage Notes
-
-1. **Empty Payload**: Rules with no configuration options use an empty payload (`""` or `null`).
-
-2. **Default Values**: When creating rules programmatically, use the `SetDefaultSQLReviewRulePayload` function to generate appropriate default payloads.
-
-3. **Validation**: All payloads are validated against their expected structure when rules are created or updated.
-
-4. **Engine Compatibility**: Always check engine support before applying rules to ensure compatibility.
-
-5. **Template Expansion**: Template tokens are expanded at rule evaluation time using the actual schema object names.
-
-6. **Regular Expressions**: Format patterns in naming rules use standard regular expression syntax.
-
----
-
-This documentation covers all 150+ SQL review rule types available in Bytebase across all supported database engines. Each rule is designed to enforce specific database standards and best practices to maintain code quality, performance, and consistency.
\ No newline at end of file
diff --git a/proto/v1/v1/review_config_service.proto b/proto/v1/v1/review_config_service.proto
index a24497187b..bb3c6a8c82 100644
--- a/proto/v1/v1/review_config_service.proto
+++ b/proto/v1/v1/review_config_service.proto
@@ -149,8 +149,121 @@ message SQLReviewRule {
WARNING = 2;
}
+ enum Type {
+ TYPE_UNSPECIFIED = 0;
+ ENGINE_MYSQL_USE_INNODB = 1;
+ NAMING_FULLY_QUALIFIED = 2;
+ NAMING_TABLE = 3;
+ NAMING_COLUMN = 4;
+ NAMING_INDEX_PK = 5;
+ NAMING_INDEX_UK = 6;
+ NAMING_INDEX_FK = 7;
+ NAMING_INDEX_IDX = 8;
+ NAMING_COLUMN_AUTO_INCREMENT = 9;
+ NAMING_TABLE_NO_KEYWORD = 10;
+ NAMING_IDENTIFIER_NO_KEYWORD = 11;
+ NAMING_IDENTIFIER_CASE = 12;
+ STATEMENT_SELECT_NO_SELECT_ALL = 13;
+ STATEMENT_WHERE_REQUIRE_SELECT = 14;
+ STATEMENT_WHERE_REQUIRE_UPDATE_DELETE = 15;
+ STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE = 16;
+ STATEMENT_DISALLOW_ON_DEL_CASCADE = 17;
+ STATEMENT_DISALLOW_RM_TBL_CASCADE = 18;
+ STATEMENT_DISALLOW_COMMIT = 19;
+ STATEMENT_DISALLOW_LIMIT = 20;
+ STATEMENT_DISALLOW_ORDER_BY = 21;
+ STATEMENT_MERGE_ALTER_TABLE = 22;
+ STATEMENT_INSERT_ROW_LIMIT = 23;
+ STATEMENT_INSERT_MUST_SPECIFY_COLUMN = 24;
+ STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND = 25;
+ STATEMENT_AFFECTED_ROW_LIMIT = 26;
+ STATEMENT_DML_DRY_RUN = 27;
+ STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT = 28;
+ STATEMENT_ADD_CHECK_NOT_VALID = 29;
+ STATEMENT_ADD_FOREIGN_KEY_NOT_VALID = 30;
+ STATEMENT_DISALLOW_ADD_NOT_NULL = 31;
+ STATEMENT_SELECT_FULL_TABLE_SCAN = 32;
+ STATEMENT_CREATE_SPECIFY_SCHEMA = 33;
+ STATEMENT_CHECK_SET_ROLE_VARIABLE = 34;
+ STATEMENT_DISALLOW_USING_FILESORT = 35;
+ STATEMENT_DISALLOW_USING_TEMPORARY = 36;
+ STATEMENT_WHERE_NO_EQUAL_NULL = 37;
+ STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38;
+ STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39;
+ STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40;
+ STATEMENT_MAXIMUM_LIMIT_VALUE = 41;
+ STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42;
+ STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43;
+ STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44;
+ STATEMENT_NON_TRANSACTIONAL = 45;
+ STATEMENT_ADD_COLUMN_WITHOUT_POSITION = 46;
+ STATEMENT_DISALLOW_OFFLINE_DDL = 47;
+ STATEMENT_DISALLOW_CROSS_DB_QUERIES = 48;
+ STATEMENT_MAX_EXECUTION_TIME = 49;
+ STATEMENT_REQUIRE_ALGORITHM_OPTION = 50;
+ STATEMENT_REQUIRE_LOCK_OPTION = 51;
+ STATEMENT_OBJECT_OWNER_CHECK = 52;
+ TABLE_REQUIRE_PK = 53;
+ TABLE_NO_FOREIGN_KEY = 54;
+ TABLE_DROP_NAMING_CONVENTION = 55;
+ TABLE_COMMENT = 56;
+ TABLE_DISALLOW_PARTITION = 57;
+ TABLE_DISALLOW_TRIGGER = 58;
+ TABLE_NO_DUPLICATE_INDEX = 59;
+ TABLE_TEXT_FIELDS_TOTAL_LENGTH = 60;
+ TABLE_DISALLOW_SET_CHARSET = 61;
+ TABLE_DISALLOW_DDL = 62;
+ TABLE_DISALLOW_DML = 63;
+ TABLE_LIMIT_SIZE = 64;
+ TABLE_REQUIRE_CHARSET = 65;
+ TABLE_REQUIRE_COLLATION = 66;
+ COLUMN_REQUIRED = 67;
+ COLUMN_NO_NULL = 68;
+ COLUMN_DISALLOW_CHANGE_TYPE = 69;
+ COLUMN_SET_DEFAULT_FOR_NOT_NULL = 70;
+ COLUMN_DISALLOW_CHANGE = 71;
+ COLUMN_DISALLOW_CHANGING_ORDER = 72;
+ COLUMN_DISALLOW_DROP = 73;
+ COLUMN_DISALLOW_DROP_IN_INDEX = 74;
+ COLUMN_COMMENT = 75;
+ COLUMN_AUTO_INCREMENT_MUST_INTEGER = 76;
+ COLUMN_TYPE_DISALLOW_LIST = 77;
+ COLUMN_DISALLOW_SET_CHARSET = 78;
+ COLUMN_MAXIMUM_CHARACTER_LENGTH = 79;
+ COLUMN_MAXIMUM_VARCHAR_LENGTH = 80;
+ COLUMN_AUTO_INCREMENT_INITIAL_VALUE = 81;
+ COLUMN_AUTO_INCREMENT_MUST_UNSIGNED = 82;
+ COLUMN_CURRENT_TIME_COUNT_LIMIT = 83;
+ COLUMN_REQUIRE_DEFAULT = 84;
+ COLUMN_DEFAULT_DISALLOW_VOLATILE = 85;
+ COLUMN_ADD_NOT_NULL_REQUIRE_DEFAULT = 86;
+ COLUMN_REQUIRE_CHARSET = 87;
+ COLUMN_REQUIRE_COLLATION = 88;
+ SCHEMA_BACKWARD_COMPATIBILITY = 89;
+ DATABASE_DROP_EMPTY_DATABASE = 90;
+ INDEX_NO_DUPLICATE_COLUMN = 91;
+ INDEX_KEY_NUMBER_LIMIT = 92;
+ INDEX_PK_TYPE_LIMIT = 93;
+ INDEX_TYPE_NO_BLOB = 94;
+ INDEX_TOTAL_NUMBER_LIMIT = 95;
+ INDEX_PRIMARY_KEY_TYPE_ALLOWLIST = 96;
+ INDEX_CREATE_CONCURRENTLY = 97;
+ INDEX_TYPE_ALLOW_LIST = 98;
+ INDEX_NOT_REDUNDANT = 99;
+ SYSTEM_CHARSET_ALLOWLIST = 100;
+ SYSTEM_COLLATION_ALLOWLIST = 101;
+ SYSTEM_COMMENT_LENGTH = 102;
+ SYSTEM_PROCEDURE_DISALLOW_CREATE = 103;
+ SYSTEM_EVENT_DISALLOW_CREATE = 104;
+ SYSTEM_VIEW_DISALLOW_CREATE = 105;
+ SYSTEM_FUNCTION_DISALLOW_CREATE = 106;
+ SYSTEM_FUNCTION_DISALLOWED_LIST = 107;
+ ADVICE_ONLINE_MIGRATION = 108;
+ BUILTIN_PRIOR_BACKUP_CHECK = 109;
+ }
+
// The type of SQL review rule.
- string type = 1;
+ Type type = 1;
// The severity level of the rule.
Level level = 2;