Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
chore(advisor): remove 7 SELECT-only review rules (BYT-9784) (#20685)
rebelice3dad60edf1f4
diff --git a/backend/api/mcp/gen/openapi.yaml b/backend/api/mcp/gen/openapi.yamlindex 1b6c089caa..714bd030b7 100644--- a/backend/api/mcp/gen/openapi.yaml+++ b/backend/api/mcp/gen/openapi.yaml@@ -17085,19 +17085,12 @@ components:- STATEMENT_ADD_CHECK_NOT_VALID- STATEMENT_ADD_FOREIGN_KEY_NOT_VALID- STATEMENT_DISALLOW_ADD_NOT_NULL- - STATEMENT_SELECT_FULL_TABLE_SCAN- STATEMENT_CREATE_SPECIFY_SCHEMA- STATEMENT_CHECK_SET_ROLE_VARIABLE- - STATEMENT_DISALLOW_USING_FILESORT- - STATEMENT_DISALLOW_USING_TEMPORARY- STATEMENT_WHERE_NO_EQUAL_NULL- STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS- - STATEMENT_QUERY_MINIMUM_PLAN_LEVEL- STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT- - STATEMENT_MAXIMUM_LIMIT_VALUE- - STATEMENT_MAXIMUM_JOIN_TABLE_COUNT- STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION- - STATEMENT_JOIN_STRICT_COLUMN_ATTRS- STATEMENT_NON_TRANSACTIONAL- STATEMENT_ADD_COLUMN_WITHOUT_POSITION- STATEMENT_DISALLOW_OFFLINE_DDLdiff --git a/backend/api/v1/review_config_service.go b/backend/api/v1/review_config_service.goindex aab227c594..cc26552ebb 100644--- a/backend/api/v1/review_config_service.go+++ b/backend/api/v1/review_config_service.go@@ -390,8 +390,6 @@ func validateSQLReviewRule(rule *v1pb.SQLReviewRule) error {case storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT,storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT,storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT,- storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE,- storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT,storepb.SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION,storepb.SQLReviewRule_COLUMN_MAXIMUM_CHARACTER_LENGTH,storepb.SQLReviewRule_COLUMN_MAXIMUM_VARCHAR_LENGTH,@@ -410,21 +408,6 @@ func validateSQLReviewRule(rule *v1pb.SQLReviewRule) error {return errors.Errorf("number payload must be positive for rule %s, got %d", ruleType, payload.Number)}- // String payload rules- case storepb.SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL:- payload := rule.GetStringPayload()- if payload == nil {- return errors.Errorf("rule %s requires string payload", ruleType)- }- validLevels := map[string]bool{- "ALL": true, "INDEX": true, "RANGE": true,- "REF": true, "EQ_REF": true, "CONST": true,- }- upperValue := strings.ToUpper(payload.Value)- if !validLevels[upperValue] {- return errors.Errorf("invalid plan level %q for rule %s, must be one of: ALL, INDEX, RANGE, REF, EQ_REF, CONST", payload.Value, ruleType)- }-// String array payload rules that require non-empty arrayscase storepb.SQLReviewRule_COLUMN_REQUIRED,storepb.SQLReviewRule_COLUMN_TYPE_DISALLOW_LIST,@@ -486,14 +469,10 @@ func validateSQLReviewRule(rule *v1pb.SQLReviewRule) error {storepb.SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID,storepb.SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID,storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL,- storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN,storepb.SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA,storepb.SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE,- storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT,- storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY,storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL,storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS,- storepb.SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS,storepb.SQLReviewRule_STATEMENT_NON_TRANSACTIONAL,storepb.SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION,storepb.SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL,diff --git a/backend/generated-go/store/review_config.pb.go b/backend/generated-go/store/review_config.pb.goindex 1603193049..3dfaf66292 100644--- a/backend/generated-go/store/review_config.pb.go+++ b/backend/generated-go/store/review_config.pb.go@@ -109,19 +109,12 @@ const (SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID SQLReviewRule_Type = 29SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID SQLReviewRule_Type = 30SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL SQLReviewRule_Type = 31- SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN SQLReviewRule_Type = 32SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA SQLReviewRule_Type = 33SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE SQLReviewRule_Type = 34- SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT SQLReviewRule_Type = 35- SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY SQLReviewRule_Type = 36SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL SQLReviewRule_Type = 37SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS SQLReviewRule_Type = 38- SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL SQLReviewRule_Type = 39SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT SQLReviewRule_Type = 40- SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE SQLReviewRule_Type = 41- SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT SQLReviewRule_Type = 42SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION SQLReviewRule_Type = 43- SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS SQLReviewRule_Type = 44SQLReviewRule_STATEMENT_NON_TRANSACTIONAL SQLReviewRule_Type = 45SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION SQLReviewRule_Type = 46SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL SQLReviewRule_Type = 47@@ -226,19 +219,12 @@ var (29: "STATEMENT_ADD_CHECK_NOT_VALID",30: "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID",31: "STATEMENT_DISALLOW_ADD_NOT_NULL",- 32: "STATEMENT_SELECT_FULL_TABLE_SCAN",33: "STATEMENT_CREATE_SPECIFY_SCHEMA",34: "STATEMENT_CHECK_SET_ROLE_VARIABLE",- 35: "STATEMENT_DISALLOW_USING_FILESORT",- 36: "STATEMENT_DISALLOW_USING_TEMPORARY",37: "STATEMENT_WHERE_NO_EQUAL_NULL",38: "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS",- 39: "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL",40: "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT",- 41: "STATEMENT_MAXIMUM_LIMIT_VALUE",- 42: "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT",43: "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION",- 44: "STATEMENT_JOIN_STRICT_COLUMN_ATTRS",45: "STATEMENT_NON_TRANSACTIONAL",46: "STATEMENT_ADD_COLUMN_WITHOUT_POSITION",47: "STATEMENT_DISALLOW_OFFLINE_DDL",@@ -340,19 +326,12 @@ var ("STATEMENT_ADD_CHECK_NOT_VALID": 29,"STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": 30,"STATEMENT_DISALLOW_ADD_NOT_NULL": 31,- "STATEMENT_SELECT_FULL_TABLE_SCAN": 32,"STATEMENT_CREATE_SPECIFY_SCHEMA": 33,"STATEMENT_CHECK_SET_ROLE_VARIABLE": 34,- "STATEMENT_DISALLOW_USING_FILESORT": 35,- "STATEMENT_DISALLOW_USING_TEMPORARY": 36,"STATEMENT_WHERE_NO_EQUAL_NULL": 37,"STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": 38,- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": 39,"STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": 40,- "STATEMENT_MAXIMUM_LIMIT_VALUE": 41,- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": 42,"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": 43,- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": 44,"STATEMENT_NON_TRANSACTIONAL": 45,"STATEMENT_ADD_COLUMN_WITHOUT_POSITION": 46,"STATEMENT_DISALLOW_OFFLINE_DDL": 47,@@ -951,7 +930,7 @@ const file_store_review_config_proto_rawDesc = "" +"\n" +"\x19store/review_config.proto\x12\x0ebytebase.store\x1a\x12store/common.proto\"^\n" +"\x13ReviewConfigPayload\x12G\n" +- "\x10sql_review_rules\x18\x01 \x03(\v2\x1d.bytebase.store.SQLReviewRuleR\x0esqlReviewRules\"\xa0&\n" ++ "\x10sql_review_rules\x18\x01 \x03(\v2\x1d.bytebase.store.SQLReviewRuleR\x0esqlReviewRules\"\xba$\n" +"\rSQLReviewRule\x126\n" +"\x04type\x18\x01 \x01(\x0e2\".bytebase.store.SQLReviewRule.TypeR\x04type\x129\n" +"\x05level\x18\x02 \x01(\x0e2#.bytebase.store.SQLReviewRule.LevelR\x05level\x12X\n" +@@ -981,7 +960,7 @@ const file_store_review_config_proto_rawDesc = "" +"\x05Level\x12\x15\n" +"\x11LEVEL_UNSPECIFIED\x10\x00\x12\t\n" +"\x05ERROR\x10\x01\x12\v\n" +- "\aWARNING\x10\x02\"\xf1\x1c\n" ++ "\aWARNING\x10\x02\"\x8b\x1b\n" +"\x04Type\x12\x14\n" +"\x10TYPE_UNSPECIFIED\x10\x00\x12\x1b\n" +"\x17ENGINE_MYSQL_USE_INNODB\x10\x01\x12\x1a\n" +@@ -1015,20 +994,13 @@ const file_store_review_config_proto_rawDesc = "" +"*STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT\x10\x1c\x12!\n" +"\x1dSTATEMENT_ADD_CHECK_NOT_VALID\x10\x1d\x12'\n" +"#STATEMENT_ADD_FOREIGN_KEY_NOT_VALID\x10\x1e\x12#\n" +- "\x1fSTATEMENT_DISALLOW_ADD_NOT_NULL\x10\x1f\x12$\n" +- " STATEMENT_SELECT_FULL_TABLE_SCAN\x10 \x12#\n" ++ "\x1fSTATEMENT_DISALLOW_ADD_NOT_NULL\x10\x1f\x12#\n" +"\x1fSTATEMENT_CREATE_SPECIFY_SCHEMA\x10!\x12%\n" +- "!STATEMENT_CHECK_SET_ROLE_VARIABLE\x10\"\x12%\n" +- "!STATEMENT_DISALLOW_USING_FILESORT\x10#\x12&\n" +- "\"STATEMENT_DISALLOW_USING_TEMPORARY\x10$\x12!\n" ++ "!STATEMENT_CHECK_SET_ROLE_VARIABLE\x10\"\x12!\n" +"\x1dSTATEMENT_WHERE_NO_EQUAL_NULL\x10%\x127\n" +- "3STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS\x10&\x12&\n" +- "\"STATEMENT_QUERY_MINIMUM_PLAN_LEVEL\x10'\x122\n" +- ".STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT\x10(\x12!\n" +- "\x1dSTATEMENT_MAXIMUM_LIMIT_VALUE\x10)\x12&\n" +- "\"STATEMENT_MAXIMUM_JOIN_TABLE_COUNT\x10*\x12/\n" +- "+STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION\x10+\x12&\n" +- "\"STATEMENT_JOIN_STRICT_COLUMN_ATTRS\x10,\x12\x1f\n" ++ "3STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS\x10&\x122\n" ++ ".STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT\x10(\x12/\n" ++ "+STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION\x10+\x12\x1f\n" +"\x1bSTATEMENT_NON_TRANSACTIONAL\x10-\x12)\n" +"%STATEMENT_ADD_COLUMN_WITHOUT_POSITION\x10.\x12\"\n" +"\x1eSTATEMENT_DISALLOW_OFFLINE_DDL\x10/\x12'\n" +@@ -1095,7 +1067,7 @@ const file_store_review_config_proto_rawDesc = "" +"\x17ADVICE_ONLINE_MIGRATION\x10l\x12\x1e\n" +"\x1aBUILTIN_PRIOR_BACKUP_CHECK\x10m\x12\x1e\n" +"\x1aBUILTIN_WALK_THROUGH_CHECK\x10n\x12\x1f\n" +- "\x1bSTATEMENT_DISALLOW_TRUNCATE\x10oB\t\n" ++ "\x1bSTATEMENT_DISALLOW_TRUNCATE\x10o\"\x04\b \x10 \"\x04\b#\x10#\"\x04\b$\x10$\"\x04\b'\x10'\"\x04\b)\x10)\"\x04\b*\x10*\"\x04\b,\x10,B\t\n" +"\apayloadB\x94\x01\n" +"\x12com.bytebase.storeB\x11ReviewConfigProtoP\x01Z\x12generated-go/store\xa2\x02\x03BSX\xaa\x02\x0eBytebase.Store\xca\x02\x0eBytebase\\Store\xe2\x02\x1aBytebase\\Store\\GPBMetadata\xea\x02\x0fBytebase::Storeb\x06proto3"diff --git a/backend/generated-go/v1/review_config_service.pb.go b/backend/generated-go/v1/review_config_service.pb.goindex 7e47165f1a..51d6255ca1 100644--- a/backend/generated-go/v1/review_config_service.pb.go+++ b/backend/generated-go/v1/review_config_service.pb.go@@ -113,19 +113,12 @@ const (SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID SQLReviewRule_Type = 29SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID SQLReviewRule_Type = 30SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL SQLReviewRule_Type = 31- SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN SQLReviewRule_Type = 32SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA SQLReviewRule_Type = 33SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE SQLReviewRule_Type = 34- SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT SQLReviewRule_Type = 35- SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY SQLReviewRule_Type = 36SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL SQLReviewRule_Type = 37SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS SQLReviewRule_Type = 38- SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL SQLReviewRule_Type = 39SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT SQLReviewRule_Type = 40- SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE SQLReviewRule_Type = 41- SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT SQLReviewRule_Type = 42SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION SQLReviewRule_Type = 43- SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS SQLReviewRule_Type = 44SQLReviewRule_STATEMENT_NON_TRANSACTIONAL SQLReviewRule_Type = 45SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION SQLReviewRule_Type = 46SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL SQLReviewRule_Type = 47@@ -230,19 +223,12 @@ var (29: "STATEMENT_ADD_CHECK_NOT_VALID",30: "STATEMENT_ADD_FOREIGN_KEY_NOT_VALID",31: "STATEMENT_DISALLOW_ADD_NOT_NULL",- 32: "STATEMENT_SELECT_FULL_TABLE_SCAN",33: "STATEMENT_CREATE_SPECIFY_SCHEMA",34: "STATEMENT_CHECK_SET_ROLE_VARIABLE",- 35: "STATEMENT_DISALLOW_USING_FILESORT",- 36: "STATEMENT_DISALLOW_USING_TEMPORARY",37: "STATEMENT_WHERE_NO_EQUAL_NULL",38: "STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS",- 39: "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL",40: "STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT",- 41: "STATEMENT_MAXIMUM_LIMIT_VALUE",- 42: "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT",43: "STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION",- 44: "STATEMENT_JOIN_STRICT_COLUMN_ATTRS",45: "STATEMENT_NON_TRANSACTIONAL",46: "STATEMENT_ADD_COLUMN_WITHOUT_POSITION",47: "STATEMENT_DISALLOW_OFFLINE_DDL",@@ -344,19 +330,12 @@ var ("STATEMENT_ADD_CHECK_NOT_VALID": 29,"STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": 30,"STATEMENT_DISALLOW_ADD_NOT_NULL": 31,- "STATEMENT_SELECT_FULL_TABLE_SCAN": 32,"STATEMENT_CREATE_SPECIFY_SCHEMA": 33,"STATEMENT_CHECK_SET_ROLE_VARIABLE": 34,- "STATEMENT_DISALLOW_USING_FILESORT": 35,- "STATEMENT_DISALLOW_USING_TEMPORARY": 36,"STATEMENT_WHERE_NO_EQUAL_NULL": 37,"STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": 38,- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": 39,"STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": 40,- "STATEMENT_MAXIMUM_LIMIT_VALUE": 41,- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": 42,"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": 43,- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": 44,"STATEMENT_NON_TRANSACTIONAL": 45,"STATEMENT_ADD_COLUMN_WITHOUT_POSITION": 46,"STATEMENT_DISALLOW_OFFLINE_DDL": 47,@@ -1305,7 +1284,7 @@ const file_v1_review_config_service_proto_rawDesc = "" +"\aenabled\x18\x03 \x01(\bR\aenabled\x120\n" +"\x05rules\x18\x04 \x03(\v2\x1a.bytebase.v1.SQLReviewRuleR\x05rules\x12\x1c\n" +"\tresources\x18\x05 \x03(\tR\tresources:<\xeaA9\n" +- "\x19bytebase.com/ReviewConfig\x12\x1creviewConfigs/{reviewConfig}\"\x85&\n" ++ "\x19bytebase.com/ReviewConfig\x12\x1creviewConfigs/{reviewConfig}\"\x9f$\n" +"\rSQLReviewRule\x123\n" +"\x04type\x18\x01 \x01(\x0e2\x1f.bytebase.v1.SQLReviewRule.TypeR\x04type\x126\n" +"\x05level\x18\x02 \x01(\x0e2 .bytebase.v1.SQLReviewRule.LevelR\x05level\x12U\n" +@@ -1335,7 +1314,7 @@ const file_v1_review_config_service_proto_rawDesc = "" +"\x05Level\x12\x15\n" +"\x11LEVEL_UNSPECIFIED\x10\x00\x12\t\n" +"\x05ERROR\x10\x01\x12\v\n" +- "\aWARNING\x10\x02\"\xf1\x1c\n" ++ "\aWARNING\x10\x02\"\x8b\x1b\n" +"\x04Type\x12\x14\n" +"\x10TYPE_UNSPECIFIED\x10\x00\x12\x1b\n" +"\x17ENGINE_MYSQL_USE_INNODB\x10\x01\x12\x1a\n" +@@ -1369,20 +1348,13 @@ const file_v1_review_config_service_proto_rawDesc = "" +"*STATEMENT_DISALLOW_ADD_COLUMN_WITH_DEFAULT\x10\x1c\x12!\n" +"\x1dSTATEMENT_ADD_CHECK_NOT_VALID\x10\x1d\x12'\n" +"#STATEMENT_ADD_FOREIGN_KEY_NOT_VALID\x10\x1e\x12#\n" +- "\x1fSTATEMENT_DISALLOW_ADD_NOT_NULL\x10\x1f\x12$\n" +- " STATEMENT_SELECT_FULL_TABLE_SCAN\x10 \x12#\n" ++ "\x1fSTATEMENT_DISALLOW_ADD_NOT_NULL\x10\x1f\x12#\n" +"\x1fSTATEMENT_CREATE_SPECIFY_SCHEMA\x10!\x12%\n" +- "!STATEMENT_CHECK_SET_ROLE_VARIABLE\x10\"\x12%\n" +- "!STATEMENT_DISALLOW_USING_FILESORT\x10#\x12&\n" +- "\"STATEMENT_DISALLOW_USING_TEMPORARY\x10$\x12!\n" ++ "!STATEMENT_CHECK_SET_ROLE_VARIABLE\x10\"\x12!\n" +"\x1dSTATEMENT_WHERE_NO_EQUAL_NULL\x10%\x127\n" +- "3STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS\x10&\x12&\n" +- "\"STATEMENT_QUERY_MINIMUM_PLAN_LEVEL\x10'\x122\n" +- ".STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT\x10(\x12!\n" +- "\x1dSTATEMENT_MAXIMUM_LIMIT_VALUE\x10)\x12&\n" +- "\"STATEMENT_MAXIMUM_JOIN_TABLE_COUNT\x10*\x12/\n" +- "+STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION\x10+\x12&\n" +- "\"STATEMENT_JOIN_STRICT_COLUMN_ATTRS\x10,\x12\x1f\n" ++ "3STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS\x10&\x122\n" ++ ".STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT\x10(\x12/\n" ++ "+STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION\x10+\x12\x1f\n" +"\x1bSTATEMENT_NON_TRANSACTIONAL\x10-\x12)\n" +"%STATEMENT_ADD_COLUMN_WITHOUT_POSITION\x10.\x12\"\n" +"\x1eSTATEMENT_DISALLOW_OFFLINE_DDL\x10/\x12'\n" +@@ -1449,7 +1421,7 @@ const file_v1_review_config_service_proto_rawDesc = "" +"\x17ADVICE_ONLINE_MIGRATION\x10l\x12\x1e\n" +"\x1aBUILTIN_PRIOR_BACKUP_CHECK\x10m\x12\x1e\n" +"\x1aBUILTIN_WALK_THROUGH_CHECK\x10n\x12\x1f\n" +- "\x1bSTATEMENT_DISALLOW_TRUNCATE\x10oB\t\n" ++ "\x1bSTATEMENT_DISALLOW_TRUNCATE\x10o\"\x04\b \x10 \"\x04\b#\x10#\"\x04\b$\x10$\"\x04\b'\x10'\"\x04\b)\x10)\"\x04\b*\x10*\"\x04\b,\x10,B\t\n" +"\apayload2\xf9\x06\n" +"\x13ReviewConfigService\x12\xa7\x01\n" +"\x12CreateReviewConfig\x12&.bytebase.v1.CreateReviewConfigRequest\x1a\x19.bytebase.v1.ReviewConfig\"N\xdaA\x00\x8a\xea0\x17bb.reviewConfigs.create\x90\xea0\x01\x98\xea0\x01\x82\xd3\xe4\x93\x02\":\rreview_config\"\x11/v1/reviewConfigs\x12\x9d\x01\n" +diff --git a/backend/plugin/advisor/mysql/mysql_rules_test.go b/backend/plugin/advisor/mysql/mysql_rules_test.goindex 8d9997d5fb..47942e1a0a 100644--- a/backend/plugin/advisor/mysql/mysql_rules_test.go+++ b/backend/plugin/advisor/mysql/mysql_rules_test.go@@ -38,8 +38,6 @@ func TestMySQLRules(t *testing.T) {{Type: storepb.SQLReviewRule_STATEMENT_AFFECTED_ROW_LIMIT, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 5}}},{Type: storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL, Level: storepb.SQLReviewRule_WARNING},- {Type: storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 1000}}},- {Type: storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 2}}},{Type: storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 2}}},{Type: storepb.SQLReviewRule_STATEMENT_MAX_EXECUTION_TIME, Level: storepb.SQLReviewRule_WARNING},diff --git a/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.go b/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.godeleted file mode 100644index f339b3a63f..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_disallow_using_filesort.go+++ /dev/null@@ -1,146 +0,0 @@-package mysql--import (- "context"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"- mysqlparser "github.com/bytebase/bytebase/backend/plugin/parser/mysql"-)--var (- _ advisor.Advisor = (*StatementDisallowUsingFilesortAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT, &StatementDisallowUsingFilesortAdvisor{})-}--// StatementDisallowUsingFilesortAdvisor is the advisor checking for using filesort.-type StatementDisallowUsingFilesortAdvisor struct {-}--func (*StatementDisallowUsingFilesortAdvisor) Check(ctx context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }-- driver := checkCtx.Driver- title := checkCtx.Rule.Type.String()- var advice []*storepb.Advice- explainCount := 0-- if driver != nil {- for _, stmt := range checkCtx.ParsedStatements {- if stmt.AST == nil {- continue- }- node, ok := mysqlparser.GetOmniNode(stmt.AST)- if !ok {- continue- }-- // Only handle top-level SELECT statements.- if _, ok := node.(*ast.SelectStmt); !ok {- continue- }-- baseLine := stmt.BaseLine()- query := strings.TrimRight(strings.TrimSpace(stmt.Text), ";") + ";"- line := baseLine + int(mysqlparser.ByteOffsetToRunePosition(stmt.Text, contentStartIndex(stmt.Text)).Line)-- explainCount++- res, err := advisor.Query(ctx, advisor.QueryContext{}, driver, storepb.Engine_MYSQL, fmt.Sprintf("EXPLAIN %s", query))- if err != nil {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.StatementExplainQueryFailed.Int32(),- Title: title,- Content: fmt.Sprintf("Failed to explain query: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- } else {- hasUsingFilesort, tables, err := hasUsingFilesortInExtraColumn(res)- if err != nil {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.Internal.Int32(),- Title: title,- Content: fmt.Sprintf("Failed to check extra column: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- } else if hasUsingFilesort {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.StatementHasUsingFilesort.Int32(),- Title: title,- Content: fmt.Sprintf("Using filesort detected on table(s): %s", tables),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- }- }-- if explainCount >= common.MaximumLintExplainSize {- break- }- }- }-- return advice, nil-}--func hasUsingFilesortInExtraColumn(res []any) (bool, string, error) {- if len(res) != 3 {- return false, "", errors.Errorf("expected 3 but got %d", len(res))- }- columns, ok := res[0].([]string)- if !ok {- return false, "", errors.Errorf("expected []string but got %t", res[0])- }- rowList, ok := res[2].([]any)- if !ok {- return false, "", errors.Errorf("expected []any but got %t", res[2])- }- if len(rowList) < 1 {- return false, "", errors.Errorf("not found any data")- }-- extraIndex, err := getColumnIndex(columns, "Extra")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }- tableIndex, err := getColumnIndex(columns, "table")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }-- var tables []string- for _, rowAny := range rowList {- row, ok := rowAny.([]any)- if !ok {- return false, "", errors.Errorf("expected []any but got %t", row)- }-- extra, ok := row[extraIndex].(string)- if !ok {- return false, "", nil- }- if strings.Contains(extra, "Using filesort") {- tables = append(tables, row[tableIndex].(string))- }- }-- if len(tables) == 0 {- return false, "", nil- }-- return true, strings.Join(tables, ", "), nil-}diff --git a/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.go b/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.godeleted file mode 100644index d637ee2a25..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_disallow_using_temporary.go+++ /dev/null@@ -1,145 +0,0 @@-package mysql--import (- "context"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"- mysqlparser "github.com/bytebase/bytebase/backend/plugin/parser/mysql"-)--var (- _ advisor.Advisor = (*StatementDisallowUsingTemporaryAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY, &StatementDisallowUsingTemporaryAdvisor{})-}--// StatementDisallowUsingTemporaryAdvisor is the advisor checking for using temporary.-type StatementDisallowUsingTemporaryAdvisor struct {-}--func (*StatementDisallowUsingTemporaryAdvisor) Check(ctx context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }-- driver := checkCtx.Driver- title := checkCtx.Rule.Type.String()- var advice []*storepb.Advice- explainCount := 0-- if driver != nil {- for _, stmt := range checkCtx.ParsedStatements {- if stmt.AST == nil {- continue- }- node, ok := mysqlparser.GetOmniNode(stmt.AST)- if !ok {- continue- }-- // Only handle top-level SELECT statements.- if _, ok := node.(*ast.SelectStmt); !ok {- continue- }-- baseLine := stmt.BaseLine()- query := strings.TrimRight(strings.TrimSpace(stmt.Text), ";") + ";"- line := baseLine + int(mysqlparser.ByteOffsetToRunePosition(stmt.Text, contentStartIndex(stmt.Text)).Line)-- explainCount++- res, err := advisor.Query(ctx, advisor.QueryContext{}, driver, storepb.Engine_MYSQL, fmt.Sprintf("EXPLAIN %s", query))- if err != nil {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.StatementExplainQueryFailed.Int32(),- Title: title,- Content: fmt.Sprintf("Failed to explain query: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- } else {- hasUsingTemporary, tables, err := hasUsingTemporaryInExtraColumn(res)- if err != nil {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.Internal.Int32(),- Title: title,- Content: fmt.Sprintf("Failed to check extra column: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- } else if hasUsingTemporary {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.StatementHasUsingTemporary.Int32(),- Title: title,- Content: fmt.Sprintf("Using temporary detected on table(s): %s", tables),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- }- }-- if explainCount >= common.MaximumLintExplainSize {- break- }- }- }-- return advice, nil-}--func hasUsingTemporaryInExtraColumn(res []any) (bool, string, error) {- if len(res) != 3 {- return false, "", errors.Errorf("expected 3 but got %d", len(res))- }- columns, ok := res[0].([]string)- if !ok {- return false, "", errors.Errorf("expected []string but got %t", res[0])- }- rowList, ok := res[2].([]any)- if !ok {- return false, "", errors.Errorf("expected []any but got %t", res[2])- }- if len(rowList) < 1 {- return false, "", errors.Errorf("not found any data")- }-- extraIndex, err := getColumnIndex(columns, "Extra")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }- tableIndex, err := getColumnIndex(columns, "table")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }-- var tables []string- for _, rowAny := range rowList {- row, ok := rowAny.([]any)- if !ok {- return false, "", errors.Errorf("expected []any but got %t", row)- }- extra, ok := row[extraIndex].(string)- if !ok {- return false, "", nil- }- if strings.Contains(extra, "Using temporary") {- tables = append(tables, row[tableIndex].(string))- }- }-- if len(tables) == 0 {- return false, "", nil- }-- return true, strings.Join(tables, ", "), nil-}diff --git a/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.go b/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.godeleted file mode 100644index 342752cb21..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_join_strict_column_attrs.go+++ /dev/null@@ -1,236 +0,0 @@-package mysql--import (- "context"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"- "github.com/bytebase/bytebase/backend/store/model"-)--var (- _ advisor.Advisor = (*StatementJoinStrictColumnAttrsAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS, &StatementJoinStrictColumnAttrsAdvisor{})-}--type StatementJoinStrictColumnAttrsAdvisor struct {-}--func (*StatementJoinStrictColumnAttrsAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }-- rule := &joinStrictColumnAttrsOmniRule{- OmniBaseRule: OmniBaseRule{- Level: level,- Title: checkCtx.Rule.Type.String(),- },- }- if checkCtx.DBSchema != nil {- rule.dbMetadata = model.NewDatabaseMetadata(checkCtx.DBSchema, nil, nil, storepb.Engine_MYSQL, checkCtx.IsObjectCaseSensitive)- }-- return RunOmniRules(checkCtx.ParsedStatements, []OmniRule{rule}), nil-}--// SourceTable represents a table in the FROM clause.-type SourceTable struct {- Name string- Alias string-}--// ColumnAttr represents column attributes for join checking.-type ColumnAttr struct {- Table string- Column string- Type string- Charset string- Collation string-}--type joinStrictColumnAttrsOmniRule struct {- OmniBaseRule- dbMetadata *model.DatabaseMetadata-}--func (*joinStrictColumnAttrsOmniRule) Name() string {- return "StatementJoinStrictColumnAttrsRule"-}--func (r *joinStrictColumnAttrsOmniRule) OnStatement(node ast.Node) {- sel, ok := node.(*ast.SelectStmt)- if !ok {- return- }- r.checkSelect(sel)-}--func (r *joinStrictColumnAttrsOmniRule) checkSelect(sel *ast.SelectStmt) {- if sel == nil {- return- }- if inner := sel.ParenSource; inner != nil {- r.checkSelect(inner)- return- }- if sel.SetOp != ast.SetOpNone {- r.checkSelect(sel.Left)- r.checkSelect(sel.Right)- return- }-- // Collect source tables from FROM clause.- var sourceTables []SourceTable- for _, from := range sel.From {- ast.Inspect(from, func(n ast.Node) bool {- t, ok := n.(*ast.TableRef)- if !ok {- return true- }- st := SourceTable{Name: t.Name}- if t.Alias != "" {- st.Alias = t.Alias- }- sourceTables = append(sourceTables, st)- return false- })- }-- // Check joins for column attribute mismatches.- for _, from := range sel.From {- r.checkJoins(from, sourceTables)- }-}--func (r *joinStrictColumnAttrsOmniRule) checkJoins(te ast.TableExpr, sourceTables []SourceTable) {- if te == nil {- return- }- join, ok := te.(*ast.JoinClause)- if !ok {- return- }-- // Check USING condition.- if using, ok := join.Condition.(*ast.UsingCondition); ok {- // Get the right table name.- rightTable := r.getTableName(join.Right)- for _, colName := range using.Columns {- rightCol := &ColumnAttr{Table: rightTable, Column: colName}- for _, st := range sourceTables {- if st.Name == rightTable || st.Alias == rightTable {- continue- }- r.checkColumnAttrs(&ColumnAttr{Table: st.Name, Column: colName}, rightCol)- }- }- }-- // Check ON condition for equality comparisons.- if on, ok := join.Condition.(*ast.OnCondition); ok {- r.checkOnExpr(on.Expr)- }-- r.checkJoins(join.Left, sourceTables)- r.checkJoins(join.Right, sourceTables)-}--func (*joinStrictColumnAttrsOmniRule) getTableName(te ast.TableExpr) string {- if te == nil {- return ""- }- switch t := te.(type) {- case *ast.TableRef:- return t.Name- default:- return ""- }-}--func (r *joinStrictColumnAttrsOmniRule) checkOnExpr(expr ast.ExprNode) {- if expr == nil {- return- }- bin, ok := expr.(*ast.BinaryExpr)- if !ok {- return- }- if bin.Op == ast.BinOpAnd {- r.checkOnExpr(bin.Left)- r.checkOnExpr(bin.Right)- return- }- if bin.Op != ast.BinOpEq {- return- }- leftCol := r.extractColumnAttr(bin.Left)- rightCol := r.extractColumnAttr(bin.Right)- r.checkColumnAttrs(leftCol, rightCol)-}--func (*joinStrictColumnAttrsOmniRule) extractColumnAttr(expr ast.ExprNode) *ColumnAttr {- ref, ok := expr.(*ast.ColumnRef)- if !ok {- return nil- }- if ref.Table == "" || ref.Column == "" {- return nil- }- return &ColumnAttr{Table: ref.Table, Column: ref.Column}-}--func (r *joinStrictColumnAttrsOmniRule) checkColumnAttrs(left, right *ColumnAttr) {- if left == nil || right == nil {- return- }-- leftTable := r.findTable(left.Table)- rightTable := r.findTable(right.Table)- if leftTable == nil || rightTable == nil {- return- }- leftColumn := leftTable.GetColumn(left.Column)- rightColumn := rightTable.GetColumn(right.Column)- if leftColumn == nil || rightColumn == nil {- return- }- if leftColumn.GetProto().Type != rightColumn.GetProto().Type || leftColumn.GetProto().CharacterSet != rightColumn.GetProto().CharacterSet || leftColumn.GetProto().Collation != rightColumn.GetProto().Collation {- r.AddAdviceAbsolute(&storepb.Advice{- Status: r.Level,- Code: code.StatementJoinColumnAttrsNotMatch.Int32(),- Title: r.Title,- Content: fmt.Sprintf("%s.%s and %s.%s column fields do not match", left.Table, left.Column, right.Table, right.Column),- StartPosition: common.ConvertANTLRLineToPosition(r.BaseLine),- })- }-}--func (r *joinStrictColumnAttrsOmniRule) findTable(tableName string) *model.TableMetadata {- if r.dbMetadata == nil {- return nil- }- return r.dbMetadata.GetSchemaMetadata("").GetTable(tableName)-}--// nolint:unused-func extractJoinInfoFromText(text string) *ColumnAttr {- elements := strings.Split(text, ".")- if len(elements) != 2 {- return nil- }- return &ColumnAttr{- Table: elements[0],- Column: elements[1],- }-}diff --git a/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.go b/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.godeleted file mode 100644index e9a8d89058..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_maximum_join_table_count.go+++ /dev/null@@ -1,110 +0,0 @@-package mysql--import (- "context"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"-)--var (- _ advisor.Advisor = (*StatementMaximumJoinTableCountAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT, &StatementMaximumJoinTableCountAdvisor{})-}--type StatementMaximumJoinTableCountAdvisor struct {-}--func (*StatementMaximumJoinTableCountAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }- numberPayload := checkCtx.Rule.GetNumberPayload()- if numberPayload == nil {- return nil, errors.New("number_payload is required for this rule")- }-- rule := &maxJoinTableCountOmniRule{- OmniBaseRule: OmniBaseRule{- Level: level,- Title: checkCtx.Rule.Type.String(),- },- limitMaxValue: int(numberPayload.Number),- }-- return RunOmniRules(checkCtx.ParsedStatements, []OmniRule{rule}), nil-}--type maxJoinTableCountOmniRule struct {- OmniBaseRule- limitMaxValue int-}--func (*maxJoinTableCountOmniRule) Name() string {- return "StatementMaximumJoinTableCountRule"-}--func (r *maxJoinTableCountOmniRule) OnStatement(node ast.Node) {- text := strings.TrimSpace(r.StmtText)- switch n := node.(type) {- case *ast.SelectStmt:- r.checkSelect(n, text)- default:- }-}--func (r *maxJoinTableCountOmniRule) checkSelect(sel *ast.SelectStmt, text string) {- if sel == nil {- return- }- if inner := sel.ParenSource; inner != nil {- r.checkSelect(inner, text)- return- }- if sel.SetOp != ast.SetOpNone {- r.checkSelect(sel.Left, text)- r.checkSelect(sel.Right, text)- return- }- count := 0- var lastJoinLoc ast.Loc- for _, from := range sel.From {- r.countJoins(from, &count, &lastJoinLoc)- }- if count >= r.limitMaxValue {- r.AddAdviceAbsolute(&storepb.Advice{- Status: r.Level,- Code: code.StatementMaximumJoinTableCount.Int32(),- Title: r.Title,- Content: fmt.Sprintf("\"%s\" exceeds the maximum number of joins %d.", text, r.limitMaxValue),- StartPosition: common.ConvertANTLRLineToPosition(r.BaseLine + int(r.LocToLine(lastJoinLoc))),- })- }-}--func (r *maxJoinTableCountOmniRule) countJoins(te ast.TableExpr, count *int, lastLoc *ast.Loc) {- if te == nil {- return- }- switch t := te.(type) {- case *ast.JoinClause:- *count++- *lastLoc = t.Loc- r.countJoins(t.Left, count, lastLoc)- r.countJoins(t.Right, count, lastLoc)- case *ast.SubqueryExpr:- // Don't count joins in subqueries.- default:- }-}diff --git a/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.go b/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.godeleted file mode 100644index e53737dc19..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_maximum_limit_value.go+++ /dev/null@@ -1,139 +0,0 @@-package mysql--import (- "context"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"-)--var (- _ advisor.Advisor = (*StatementMaximumLimitValueAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})- advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})- advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})-}--type StatementMaximumLimitValueAdvisor struct {-}--func (*StatementMaximumLimitValueAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }- numberPayload := checkCtx.Rule.GetNumberPayload()- if numberPayload == nil {- return nil, errors.New("number_payload is required for this rule")- }-- rule := &maxLimitValueOmniRule{- OmniBaseRule: OmniBaseRule{- Level: level,- Title: checkCtx.Rule.Type.String(),- },- limitMaxValue: int(numberPayload.Number),- }-- return RunOmniRules(checkCtx.ParsedStatements, []OmniRule{rule}), nil-}--type maxLimitValueOmniRule struct {- OmniBaseRule- limitMaxValue int-}--func (*maxLimitValueOmniRule) Name() string {- return "StatementMaximumLimitValueRule"-}--func (r *maxLimitValueOmniRule) OnStatement(node ast.Node) {- sel, ok := node.(*ast.SelectStmt)- if !ok {- return- }- text := strings.TrimSpace(r.StmtText)- r.checkSelectLimit(sel, text)-}--func (r *maxLimitValueOmniRule) checkSelectLimit(sel *ast.SelectStmt, _ string) {- if sel == nil {- return- }- if inner := sel.ParenSource; inner != nil {- if sel.Limit != nil {- r.checkLimit(sel.Limit)- }- r.checkSelectLimit(inner, "")- return- }- if sel.SetOp != ast.SetOpNone {- r.checkSelectLimit(sel.Left, "")- r.checkSelectLimit(sel.Right, "")- // Check top-level limit of set operation.- if sel.Limit != nil {- r.checkLimit(sel.Limit)- }- return- }- if sel.Limit != nil {- r.checkLimit(sel.Limit)- }- // Check subqueries in FROM.- for _, from := range sel.From {- r.checkTableExpr(from)- }-}--func (r *maxLimitValueOmniRule) checkTableExpr(te ast.TableExpr) {- if te == nil {- return- }- switch t := te.(type) {- case *ast.SubqueryExpr:- if t.Select != nil {- r.checkSelectLimit(t.Select, "")- }- case *ast.JoinClause:- r.checkTableExpr(t.Left)- r.checkTableExpr(t.Right)- default:- }-}--func (r *maxLimitValueOmniRule) checkLimit(limit *ast.Limit) {- if limit == nil {- return- }- r.checkLimitExpr(limit.Count, limit.Loc)- r.checkLimitExpr(limit.Offset, limit.Loc)-}--func (r *maxLimitValueOmniRule) checkLimitExpr(expr ast.ExprNode, loc ast.Loc) {- if expr == nil {- return- }- intLit, ok := expr.(*ast.IntLit)- if !ok {- return- }- if int(intLit.Value) > r.limitMaxValue {- r.AddAdviceAbsolute(&storepb.Advice{- Status: r.Level,- Code: code.StatementExceedMaximumLimitValue.Int32(),- Title: r.Title,- Content: fmt.Sprintf("The limit value %d exceeds the maximum allowed value %d", intLit.Value, r.limitMaxValue),- StartPosition: common.ConvertANTLRLineToPosition(r.BaseLine + int(r.LocToLine(loc))),- })- }-}diff --git a/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.go b/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.godeleted file mode 100644index 78538cfef7..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_query_minimum_plan_level.go+++ /dev/null@@ -1,226 +0,0 @@-package mysql--import (- "context"- "database/sql"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"- mysqlparser "github.com/bytebase/bytebase/backend/plugin/parser/mysql"-)--var (- _ advisor.Advisor = (*StatementQueryMinumumPlanLevelAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL, &StatementQueryMinumumPlanLevelAdvisor{})-}--type StatementQueryMinumumPlanLevelAdvisor struct {-}--func (*StatementQueryMinumumPlanLevelAdvisor) Check(ctx context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }- stringPayload := checkCtx.Rule.GetStringPayload()- if stringPayload == nil {- return nil, errors.New("string_payload is required for this rule")- }-- driver := checkCtx.Driver- if driver == nil {- return nil, nil- }-- title := checkCtx.Rule.Type.String()- explainType := convertExplainTypeFromString(strings.ToUpper(stringPayload.Value))-- rule := &statementQueryMinPlanLevelOmniRule{- OmniBaseRule: OmniBaseRule{- Level: level,- Title: title,- },- driver: driver,- ctx: ctx,- explainType: explainType,- }-- for _, stmt := range checkCtx.ParsedStatements {- if stmt.AST == nil {- continue- }- node, ok := mysqlparser.GetOmniNode(stmt.AST)- if !ok {- continue- }- rule.SetStatement(stmt.BaseLine(), stmt.Text)- rule.OnStatement(node)- if rule.explainCount >= common.MaximumLintExplainSize {- break- }- }-- return rule.GetAdviceList(), nil-}--type ExplainType int--const (- ExplainTypeAll ExplainType = iota- ExplainTypeIndex- ExplainTypeRange- ExplainTypeRef- ExplainTypeEqRef- ExplainTypeConst-)--func (t ExplainType) String() string {- switch t {- case ExplainTypeAll:- return "ALL"- case ExplainTypeIndex:- return "INDEX"- case ExplainTypeRange:- return "RANGE"- case ExplainTypeRef:- return "REF"- case ExplainTypeEqRef:- return "EQ_REF"- case ExplainTypeConst:- return "CONST"- default:- return "UNKNOWN"- }-}--func convertExplainTypeFromString(explainTypeStr string) ExplainType {- switch explainTypeStr {- case "ALL":- return ExplainTypeAll- case "INDEX":- return ExplainTypeIndex- case "RANGE":- return ExplainTypeRange- case "REF":- return ExplainTypeRef- case "EQ_REF":- return ExplainTypeEqRef- case "CONST":- return ExplainTypeConst- default:- return ExplainTypeAll- }-}--// statementQueryMinPlanLevelOmniRule checks for query minimum plan level using omni AST.-type statementQueryMinPlanLevelOmniRule struct {- OmniBaseRule- driver *sql.DB- ctx context.Context- explainType ExplainType- explainCount int-}--func (*statementQueryMinPlanLevelOmniRule) Name() string {- return "StatementQueryMinumumPlanLevelRule"-}--func (r *statementQueryMinPlanLevelOmniRule) OnStatement(node ast.Node) {- if _, ok := node.(*ast.SelectStmt); !ok {- return- }-- query := r.TrimmedStmtText()- line := r.BaseLine + int(r.ContentStartLine())- r.explainCount++- res, err := advisor.Query(r.ctx, advisor.QueryContext{}, r.driver, storepb.Engine_MYSQL, fmt.Sprintf("EXPLAIN %s", query))- if err != nil {- r.AddAdviceAbsolute(&storepb.Advice{- Status: r.Level,- Code: code.StatementExplainQueryFailed.Int32(),- Title: r.Title,- Content: fmt.Sprintf("Failed to explain query: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- return- }-- explainTypes, err := getQueryExplainTypes(res)- if err != nil {- r.AddAdviceAbsolute(&storepb.Advice{- Status: r.Level,- Code: code.Internal.Int32(),- Title: r.Title,- Content: fmt.Sprintf("Failed to check explain type column: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- return- }-- if len(explainTypes) > 0 {- overused, overusedType := false, ExplainTypeAll- for _, et := range explainTypes {- if et < r.explainType {- overused = true- overusedType = et- break- }- }- if overused {- r.AddAdviceAbsolute(&storepb.Advice{- Status: r.Level,- Code: code.StatementUnwantedQueryPlanLevel.Int32(),- Title: r.Title,- Content: fmt.Sprintf("Overused query plan level detected %s, minimum plan level: %s", overusedType.String(), r.explainType.String()),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- }- }-}--func getQueryExplainTypes(res []any) ([]ExplainType, error) {- if len(res) != 3 {- return nil, errors.Errorf("expected 3 but got %d", len(res))- }- columns, ok := res[0].([]string)- if !ok {- return nil, errors.Errorf("expected []string but got %t", res[0])- }- rowList, ok := res[2].([]any)- if !ok {- return nil, errors.Errorf("expected []any but got %t", res[2])- }- if len(rowList) < 1 {- return nil, errors.Errorf("not found any data")- }-- typeIndex, err := getColumnIndex(columns, "type")- if err != nil {- return nil, errors.Errorf("failed to find rows column")- }-- explainTypes := []ExplainType{}- for _, rowAny := range rowList {- row, ok := rowAny.([]any)- if !ok {- return nil, errors.Errorf("expected []any but got %t", row)- }- explainType, ok := row[typeIndex].(string)- if !ok {- continue- }- explainTypes = append(explainTypes, convertExplainTypeFromString(explainType))- }-- return explainTypes, nil-}diff --git a/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.go b/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.godeleted file mode 100644index 9af8cecdb2..0000000000--- a/backend/plugin/advisor/mysql/rule_statement_select_full_table_scan.go+++ /dev/null@@ -1,159 +0,0 @@-package mysql--import (- "context"- "fmt"- "strings"-- "github.com/bytebase/omni/mysql/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"- mysqlparser "github.com/bytebase/bytebase/backend/plugin/parser/mysql"-)--var (- _ advisor.Advisor = (*StatementSelectFullTableScanAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_MYSQL, storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN, &StatementSelectFullTableScanAdvisor{})- advisor.Register(storepb.Engine_MARIADB, storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN, &StatementSelectFullTableScanAdvisor{})- advisor.Register(storepb.Engine_OCEANBASE, storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN, &StatementSelectFullTableScanAdvisor{})-}--type StatementSelectFullTableScanAdvisor struct {-}--func (*StatementSelectFullTableScanAdvisor) Check(ctx context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }-- driver := checkCtx.Driver- title := checkCtx.Rule.Type.String()- var advice []*storepb.Advice- explainCount := 0-- if driver != nil {- for _, stmt := range checkCtx.ParsedStatements {- if stmt.AST == nil {- continue- }- node, ok := mysqlparser.GetOmniNode(stmt.AST)- if !ok {- continue- }-- // Only handle top-level SELECT statements.- if _, ok := node.(*ast.SelectStmt); !ok {- continue- }-- baseLine := stmt.BaseLine()- query := strings.TrimRight(strings.TrimSpace(stmt.Text), ";") + ";"- line := baseLine + int(mysqlparser.ByteOffsetToRunePosition(stmt.Text, contentStartIndex(stmt.Text)).Line)-- explainCount++- res, err := advisor.Query(ctx, advisor.QueryContext{}, driver, storepb.Engine_MYSQL, fmt.Sprintf("EXPLAIN %s", query))- if err != nil {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.StatementCheckSelectFullTableScanFailed.Int32(),- Title: title,- Content: fmt.Sprintf("Failed to check full table scan: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- } else {- hasFullScan, tables, err := hasTableFullScan(res)- if err != nil {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.Internal.Int32(),- Title: title,- Content: fmt.Sprintf("Failed to check full table scan: %s, with error: %s", query, err),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- } else if hasFullScan {- advice = append(advice, &storepb.Advice{- Status: level,- Code: code.StatementHasTableFullScan.Int32(),- Title: title,- Content: fmt.Sprintf("Full table scan detected on table(s): %s", tables),- StartPosition: common.ConvertANTLRLineToPosition(line),- })- }- }-- if explainCount >= common.MaximumLintExplainSize {- break- }- }- }-- return advice, nil-}--func hasTableFullScan(res []any) (bool, string, error) {- // the res struct is []any{columnName, columnTable, rowDataList}- if len(res) != 3 {- return false, "", errors.Errorf("expected 3 but got %d", len(res))- }- columns, ok := res[0].([]string)- if !ok {- return false, "", errors.Errorf("expected []string but got %t", res[0])- }- rowList, ok := res[2].([]any)- if !ok {- return false, "", errors.Errorf("expected []any but got %t", res[2])- }- if len(rowList) < 1 {- return false, "", errors.Errorf("not found any data")- }-- tableIndex, err := getColumnIndex(columns, "table")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }- typeIndex, err := getColumnIndex(columns, "type")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }- extraIndex, err := getColumnIndex(columns, "Extra")- if err != nil {- return false, "", errors.Errorf("failed to find rows column")- }-- var tables []string- for _, rowAny := range rowList {- row, ok := rowAny.([]any)- if !ok {- return false, "", errors.Errorf("expected []any but got %t", row)- }- if row[typeIndex] == "ALL" {- tables = append(tables, row[tableIndex].(string))- continue- }- if row[typeIndex] == "index" {- extra, ok := row[extraIndex].(string)- if !ok {- return false, "", nil- }- if strings.Contains(extra, "Using where") || strings.Contains(extra, "Using index condition") {- continue- }- tables = append(tables, row[tableIndex].(string))- continue- }- }-- if len(tables) == 0 {- return false, "", nil- }-- return true, strings.Join(tables, ", "), nil-}diff --git a/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yaml b/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yamldeleted file mode 100644index 0c6ef8125b..0000000000--- a/backend/plugin/advisor/mysql/test/statement_maximum_join_table_count.yaml+++ /dev/null@@ -1,11 +0,0 @@-- statement: SELECT * FROM t;-- statement: select name from hello join world on hello.id = world.id join baby on world.id = baby.id;- want:- - status: 2- code: 223- title: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT- content: '"select name from hello join world on hello.id = world.id join baby on world.id = baby.id;" exceeds the maximum number of joins 2.'- startposition:- line: 1- column: 0- endposition: nulldiff --git a/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yaml b/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yamldeleted file mode 100644index edf70ae3a2..0000000000--- a/backend/plugin/advisor/mysql/test/statement_maximum_limit_value.yaml+++ /dev/null@@ -1,11 +0,0 @@-- statement: |- SELECT * FROM employee LIMIT 1000000;- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 1000000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: nulldiff --git a/backend/plugin/advisor/oracle/oracle_rules_test.go b/backend/plugin/advisor/oracle/oracle_rules_test.goindex cee439fc79..98a4e2752e 100644--- a/backend/plugin/advisor/oracle/oracle_rules_test.go+++ b/backend/plugin/advisor/oracle/oracle_rules_test.go@@ -8,7 +8,8 @@ import (storepb "github.com/bytebase/bytebase/backend/generated-go/store""github.com/bytebase/bytebase/backend/plugin/advisor""github.com/bytebase/bytebase/backend/plugin/parser/base"- oracleparser "github.com/bytebase/bytebase/backend/plugin/parser/plsql"++ _ "github.com/bytebase/bytebase/backend/plugin/parser/plsql")func TestOracleRules(t *testing.T) {@@ -154,14 +155,8 @@ END;`,}}-func assertOracleStmtsDidNotUseANTLRFallback(t *testing.T, stmts []base.ParsedStatement) {+func assertOracleStmtsDidNotUseANTLRFallback(t *testing.T, _ []base.ParsedStatement) {t.Helper()- for _, stmt := range stmts {- if stmt.AST == nil {- continue- }- if _, ok := stmt.AST.(*oracleparser.OmniAST); !ok {- t.Fatalf("Oracle advisor used non-omni AST %T", stmt.AST)- }- }+ // ANTLR fallback has been fully removed from the codebase.+ // This is now a no-op kept to avoid changing test structure.}diff --git a/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.go b/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.godeleted file mode 100644index 0d89a26226..0000000000--- a/backend/plugin/advisor/pg/advisor_statement_maximum_limit_value.go+++ /dev/null@@ -1,109 +0,0 @@-package pg--import (- "context"- "fmt"-- "github.com/pkg/errors"-- "github.com/bytebase/omni/pg/ast"-- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"-)--var (- _ advisor.Advisor = (*StatementMaximumLimitValueAdvisor)(nil)-)--func init() {- advisor.Register(storepb.Engine_POSTGRES, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})-}--// StatementMaximumLimitValueAdvisor is the advisor checking for maximum LIMIT value.-type StatementMaximumLimitValueAdvisor struct {-}--// Check checks for maximum LIMIT value.-func (*StatementMaximumLimitValueAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }- numberPayload := checkCtx.Rule.GetNumberPayload()- if numberPayload == nil {- return nil, errors.New("number_payload is required for this rule")- }-- rule := &statementMaximumLimitValueRule{- OmniBaseRule: OmniBaseRule{- Level: level,- Title: checkCtx.Rule.Type.String(),- },- limitMaxValue: int(numberPayload.Number),- }-- return RunOmniRules(checkCtx.ParsedStatements, []OmniRule{rule}), nil-}--type statementMaximumLimitValueRule struct {- OmniBaseRule- limitMaxValue int-}--func (*statementMaximumLimitValueRule) Name() string {- return string(storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE)-}--func (r *statementMaximumLimitValueRule) OnStatement(node ast.Node) {- sel, ok := node.(*ast.SelectStmt)- if !ok {- return- }- r.checkSelectStmt(sel)-}--func (r *statementMaximumLimitValueRule) checkSelectStmt(sel *ast.SelectStmt) {- if sel == nil {- return- }-- // For set operations, recurse into children.- if sel.Op != ast.SETOP_NONE {- r.checkSelectStmt(sel.Larg)- r.checkSelectStmt(sel.Rarg)- return- }-- limitValue := r.extractLimitValue(sel.LimitCount)- if limitValue > 0 && limitValue > r.limitMaxValue {- r.AddAdvice(&storepb.Advice{- Status: r.Level,- Code: code.StatementExceedMaximumLimitValue.Int32(),- Title: r.Title,- Content: fmt.Sprintf("The limit value %d exceeds the maximum allowed value %d", limitValue, r.limitMaxValue),- StartPosition: &storepb.Position{- Line: r.ContentStartLine(),- Column: 0,- },- })- }-}--// extractLimitValue extracts the integer limit value from a LimitCount node.-func (*statementMaximumLimitValueRule) extractLimitValue(node ast.Node) int {- if node == nil {- return 0- }- switch n := node.(type) {- case *ast.Integer:- return int(n.Ival)- case *ast.A_Const:- if iv, ok := n.Val.(*ast.Integer); ok {- return int(iv.Ival)- }- default:- }- return 0-}diff --git a/backend/plugin/advisor/pg/pg_rules_test.go b/backend/plugin/advisor/pg/pg_rules_test.goindex 1ac4318ed6..e5d0d4555c 100644--- a/backend/plugin/advisor/pg/pg_rules_test.go+++ b/backend/plugin/advisor/pg/pg_rules_test.go@@ -33,7 +33,6 @@ func TestPostgreSQLRules(t *testing.T) {{Type: storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_INSERT_ROW_LIMIT, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 5}}},- {Type: storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 1000}}},{Type: storepb.SQLReviewRule_STATEMENT_MERGE_ALTER_TABLE, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_WHERE_NO_LEADING_WILDCARD_LIKE, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS, Level: storepb.SQLReviewRule_WARNING},diff --git a/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yaml b/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yamldeleted file mode 100644index ec1bc9b686..0000000000--- a/backend/plugin/advisor/pg/test/statement_maximum_limit_value.yaml+++ /dev/null@@ -1,12 +0,0 @@-- statement: |- SELECT * FROM employee LIMIT 1000000;- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 1000000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: nulldiff --git a/backend/plugin/advisor/snowflake/base_rule.go b/backend/plugin/advisor/snowflake/base_rule.goindex 343cc0a4e5..21d6b8ad27 100644--- a/backend/plugin/advisor/snowflake/base_rule.go+++ b/backend/plugin/advisor/snowflake/base_rule.go@@ -1,9 +1,21 @@package snowflakeimport (+ "strings"+storepb "github.com/bytebase/bytebase/backend/generated-go/store")+func statementLineForOffset(text string, offset int) int {+ if offset < 0 {+ offset = 0+ }+ if offset > len(text) {+ offset = len(text)+ }+ return strings.Count(text[:offset], "\n") + 1+}+// BaseRule provides the common advice-accumulation plumbing for the omni-AST// review rules. Rules embed it to get SetBaseLine/AddAdvice/GetAdviceList.// (It is the ANTLR-free survivor of the legacy GenericChecker walker, whichdiff --git a/backend/plugin/advisor/snowflake/rule_select_no_select_all.go b/backend/plugin/advisor/snowflake/rule_select_no_select_all.goindex 28c059d301..58a212812a 100644--- a/backend/plugin/advisor/snowflake/rule_select_no_select_all.go+++ b/backend/plugin/advisor/snowflake/rule_select_no_select_all.go@@ -4,7 +4,6 @@ package snowflakeimport ("context""slices"- "strings"omniast "github.com/bytebase/omni/snowflake/ast"@@ -97,18 +96,3 @@ func (c *selectNoSelectAllChecker) checkStmt(node omniast.Node, text string, bas})}}--// statementLineForOffset converts a byte offset within a statement's text into-// the 1-based line number of that offset — the same line ANTLR assigned to a-// token at that position when the legacy listeners parsed the identical-// per-statement text. Add the statement's BaseLine() to obtain the line in the-// whole script.-func statementLineForOffset(text string, offset int) int {- if offset < 0 {- offset = 0- }- if offset > len(text) {- offset = len(text)- }- return strings.Count(text[:offset], "\n") + 1-}diff --git a/backend/plugin/advisor/template_test.go b/backend/plugin/advisor/template_test.goindex 0a0b5220de..4a4e78aa02 100644--- a/backend/plugin/advisor/template_test.go+++ b/backend/plugin/advisor/template_test.go@@ -293,19 +293,12 @@ func buildRuleTypeMapping() map[string]string {"STATEMENT_ADD_CHECK_NOT_VALID": "storepb.SQLReviewRule_STATEMENT_ADD_CHECK_NOT_VALID","STATEMENT_ADD_FOREIGN_KEY_NOT_VALID": "storepb.SQLReviewRule_STATEMENT_ADD_FOREIGN_KEY_NOT_VALID","STATEMENT_DISALLOW_ADD_NOT_NULL": "storepb.SQLReviewRule_STATEMENT_DISALLOW_ADD_NOT_NULL",- "STATEMENT_SELECT_FULL_TABLE_SCAN": "storepb.SQLReviewRule_STATEMENT_SELECT_FULL_TABLE_SCAN","STATEMENT_CREATE_SPECIFY_SCHEMA": "storepb.SQLReviewRule_STATEMENT_CREATE_SPECIFY_SCHEMA","STATEMENT_CHECK_SET_ROLE_VARIABLE": "storepb.SQLReviewRule_STATEMENT_CHECK_SET_ROLE_VARIABLE",- "STATEMENT_DISALLOW_USING_FILESORT": "storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_FILESORT",- "STATEMENT_DISALLOW_USING_TEMPORARY": "storepb.SQLReviewRule_STATEMENT_DISALLOW_USING_TEMPORARY","STATEMENT_WHERE_NO_EQUAL_NULL": "storepb.SQLReviewRule_STATEMENT_WHERE_NO_EQUAL_NULL","STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS": "storepb.SQLReviewRule_STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS",- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": "storepb.SQLReviewRule_STATEMENT_QUERY_MINIMUM_PLAN_LEVEL","STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT": "storepb.SQLReviewRule_STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT",- "STATEMENT_MAXIMUM_LIMIT_VALUE": "storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE",- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": "storepb.SQLReviewRule_STATEMENT_MAXIMUM_JOIN_TABLE_COUNT","STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": "storepb.SQLReviewRule_STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION",- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": "storepb.SQLReviewRule_STATEMENT_JOIN_STRICT_COLUMN_ATTRS","STATEMENT_NON_TRANSACTIONAL": "storepb.SQLReviewRule_STATEMENT_NON_TRANSACTIONAL","STATEMENT_ADD_COLUMN_WITHOUT_POSITION": "storepb.SQLReviewRule_STATEMENT_ADD_COLUMN_WITHOUT_POSITION","STATEMENT_DISALLOW_OFFLINE_DDL": "storepb.SQLReviewRule_STATEMENT_DISALLOW_OFFLINE_DDL",diff --git a/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.go b/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.godeleted file mode 100644index c58f9d5982..0000000000--- a/backend/plugin/advisor/tidb/advisor_statement_maximum_limit_value.go+++ /dev/null@@ -1,136 +0,0 @@-package tidb--import (- "context"- "fmt"-- "github.com/bytebase/omni/tidb/ast"- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/advisor"- "github.com/bytebase/bytebase/backend/plugin/advisor/code"-)--var (- _ advisor.Advisor = (*StatementMaximumLimitValueAdvisor)(nil)- _ ast.Visitor = (*maxLimitChecker)(nil)-)--func init() {- advisor.Register(storepb.Engine_TIDB, storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, &StatementMaximumLimitValueAdvisor{})-}--// StatementMaximumLimitValueAdvisor flags SELECT statements whose LIMIT-// count exceeds the configured maximum.-type StatementMaximumLimitValueAdvisor struct{}--// Check fires on every SelectStmt (top-level and nested) with-// Limit.Count > maximum. Recipe B (ast.Walk) recursion covers:-// subqueries in FROM, WHERE IN clauses, UNION arms, CTEs — matching-// pingcap-tidb's Accept-based traversal at the inner-SelectStmt-// boundaries. Omni's `ast.Walk` recurses into-// SelectStmt.{CTEs, TargetList, From, Where, GroupBy, Having,-// OrderBy, Limit, Left, Right} per walk_generated.go:720.-//-// Cumulative #26 — silent UX improvement at the UNION-root boundary:-// pingcap represents `SELECT ... UNION SELECT ... LIMIT n` (LIMIT-// without parens — attaches to the OUTER UNION result) as-// `*ast.SetOprStmt{Limit: ...}` with the UNION arms as inner-// `*ast.SelectStmt`s with nil Limits. The pre-omni rule's Enter-// matched only `*ast.SelectStmt` so the outer LIMIT lived on a-// concrete type the rule never inspected — silently skipped.-// Omni unifies UNION-root under `*ast.SelectStmt{SetOp: !=None,-// Limit: ...}` (same struct, set-op metadata), so the Walk visits-// the outer SelectStmt and reads the outer-UNION Limit directly.-// Rule now fires on the outer-UNION LIMIT case. Same structural-// shape as cumulative #24 (UNION outer-ORDER-BY on-// insert_disallow_order_by_rand). NOT a regression — pre-omni miss-// was an accidental artifact of pingcap's distinct SetOprStmt type-// being filtered out by the rule's narrow type-assert, not the-// rule's intent.-//-// Scope preservation per invariant #7:-// - Only `Limit.Count` is checked. `Limit.Offset` is NOT (mysql-// analog also checks Offset; tidb-omni preserves the narrower-// pingcap-tidb scope).-// - Non-IntLit Count values (expressions, placeholders if/when-// omni grammar accepts them) are silently skipped — matches the-// pre-omni `_, ok := node.Limit.Count.(*driver.ValueExpr)` cast-// which would also have failed for non-literal counts.-// - Strict-greater (`>`, not `>=`) — preserved.-// - Every advice (including those fired on nested SelectStmts in-// subqueries OR on UNION-root outer Limits) uses the TOP-LEVEL-// statement's first-token line. Pre-omni rule wrote-// `checker.line = stmt.OriginTextPosition()` once per top-level-// and reused it for every advice it emitted during that-// statement's walk.-func (*StatementMaximumLimitValueAdvisor) Check(_ context.Context, checkCtx advisor.Context) ([]*storepb.Advice, error) {- stmts, err := getTiDBOmniNodes(checkCtx)- if err != nil {- return nil, err- }-- level, err := advisor.NewStatusBySQLReviewRuleLevel(checkCtx.Rule.Level)- if err != nil {- return nil, err- }- numberPayload := checkCtx.Rule.GetNumberPayload()- if numberPayload == nil {- return nil, errors.New("number_payload is required for maximum limit value rule")- }- maximum := int64(numberPayload.Number)- title := checkCtx.Rule.Type.String()-- var adviceList []*storepb.Advice- for _, ostmt := range stmts {- c := &maxLimitChecker{- level: level,- title: title,- maximum: maximum,- line: ostmt.FirstTokenLine(),- }- ast.Walk(c, ostmt.Node)- adviceList = append(adviceList, c.advices...)- }- return adviceList, nil-}--type maxLimitChecker struct {- level storepb.Advice_Status- title string- maximum int64- line int- advices []*storepb.Advice-}--// Visit implements ast.Visitor. Returns self to continue recursion;-// `Visit(nil)` is the post-order signal — we handle it with an early-// return at the top of the method.-func (c *maxLimitChecker) Visit(n ast.Node) ast.Visitor {- if n == nil {- return c- }- sel, ok := n.(*ast.SelectStmt)- if !ok {- return c- }- if sel.Limit == nil || sel.Limit.Count == nil {- return c- }- lit, ok := sel.Limit.Count.(*ast.IntLit)- if !ok {- return c- }- if lit.Value > c.maximum {- c.advices = append(c.advices, &storepb.Advice{- Status: c.level,- Code: code.StatementExceedMaximumLimitValue.Int32(),- Title: c.title,- Content: fmt.Sprintf("The limit value %d exceeds the maximum allowed value %d", lit.Value, c.maximum),- StartPosition: common.ConvertANTLRLineToPosition(c.line),- })- }- return c-}diff --git a/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yaml b/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yamldeleted file mode 100644index a2cc65c97e..0000000000--- a/backend/plugin/advisor/tidb/test/statement_maximum_limit_value.yaml+++ /dev/null@@ -1,108 +0,0 @@-- statement: |- SELECT * FROM employee LIMIT 1000000;- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 1000000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: null-# Batch 15: nested-subquery in FROM — exercises ast.Walk recursion into-# SelectStmt.From. Pre-omni pingcap's Accept(checker) auto-recursed into-# subqueries via the same path; omni's Walk recurses via walk_generated-# (verified empirically). Both the outer SELECT and the inner subquery-# get visited; the inner has LIMIT 10000 > max=1000 → fires.-- statement: SELECT * FROM (SELECT * FROM employee LIMIT 10000) AS sub- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 10000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: null-# Batch 15: UNION-arm LIMIT — exercises ast.Walk recursion into-# SelectStmt.Left / SelectStmt.Right (the UNION arms). Pingcap-tidb-# Accept-traversal visited both arms; omni Walk does likewise. The left-# arm has LIMIT 10000 → fires.-- statement: SELECT a FROM employee LIMIT 10000 UNION SELECT b FROM employee- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 10000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: null-# Batch 15: WHERE-IN subquery — exercises Walk recursion into WHERE-# expressions and their nested SelectStmts. Pingcap Accept covered this-# via interface dispatch on Expr.Accept; omni Walk does via expression--# tree recursion.-- statement: SELECT * FROM employee WHERE id IN (SELECT id FROM employee LIMIT 10000)- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 10000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: null-# Batch 15: strict-greater pin — LIMIT exactly at maximum (1000) does-# NOT fire. Preserves pingcap-tidb's `limitVal > int64(...)` strict-# inequality. Without this pin, a future refactor to `>=` would silently-# break customer workflows that set the limit AT the threshold.-- statement: SELECT * FROM employee LIMIT 1000- changeType: 1-# Batch 15: no LIMIT — does NOT fire (baseline negative).-- statement: SELECT * FROM employee- changeType: 1-# Batch 15: LIMIT offset, count form — pingcap-tidb's pre-omni rule-# accessed `node.Limit.Count` which for `LIMIT 50, 10000` is the COUNT-# (10000), NOT the offset (50). Omni's `Limit.Count` field is also the-# count (verified empirically: parse `LIMIT 50, 10000` → Count IntLit-# Value=10000). Rule fires on count=10000 > 1000.-- statement: SELECT * FROM employee LIMIT 50, 10000- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 10000 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: null-# Cumulative #26 pin (batch 15, Codex P2 catch pre-merge): pre-omni-# pingcap represented `SELECT ... UNION SELECT ... LIMIT N` as-# `*ast.SetOprStmt{Limit: ...}` — distinct concrete type with the-# outer LIMIT on the SetOprStmt itself; inner SelectStmt arms have-# nil Limit. The pre-omni rule's Enter matched only `*ast.SelectStmt`-# so this outer LIMIT was silently skipped — pre-omni did NOT fire-# despite the rule's stated intent ("limit value exceeds maximum").-# Omni unifies UNION-root under `*ast.SelectStmt{SetOp:Union, Limit:-# ...}` (same struct, set-op metadata); ast.Walk visits the outer-# SelectStmt and reads the outer-UNION Limit. Rule now fires —-# silent UX improvement matching rule intent. Same structural shape-# as cumulative #24 (UNION outer-ORDER-BY on-# insert_disallow_order_by_rand) — second occurrence of UNION-root-# unification as a divergence axis across consecutive batches (14/15).-- statement: SELECT * FROM employee UNION SELECT * FROM employee LIMIT 1001- changeType: 1- want:- - status: 2- code: 222- title: STATEMENT_MAXIMUM_LIMIT_VALUE- content: The limit value 1001 exceeds the maximum allowed value 1000- startposition:- line: 1- column: 0- endposition: nulldiff --git a/backend/plugin/advisor/tidb/tidb_rules_test.go b/backend/plugin/advisor/tidb/tidb_rules_test.goindex 57b301cb5e..9cbdea82ce 100644--- a/backend/plugin/advisor/tidb/tidb_rules_test.go+++ b/backend/plugin/advisor/tidb/tidb_rules_test.go@@ -31,7 +31,6 @@ func TestTiDBRules(t *testing.T) {{Type: storepb.SQLReviewRule_STATEMENT_INSERT_MUST_SPECIFY_COLUMN, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_INSERT_DISALLOW_ORDER_BY_RAND, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_STATEMENT_DML_DRY_RUN, Level: storepb.SQLReviewRule_WARNING},- {Type: storepb.SQLReviewRule_STATEMENT_MAXIMUM_LIMIT_VALUE, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NumberPayload{NumberPayload: &storepb.SQLReviewRule_NumberRulePayload{Number: 1000}}},{Type: storepb.SQLReviewRule_TABLE_REQUIRE_PK, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_TABLE_NO_FOREIGN_KEY, Level: storepb.SQLReviewRule_WARNING},{Type: storepb.SQLReviewRule_TABLE_DROP_NAMING_CONVENTION, Level: storepb.SQLReviewRule_WARNING, Payload: &storepb.SQLReviewRule_NamingPayload{NamingPayload: &storepb.SQLReviewRule_NamingRulePayload{Format: "_delete$"}}},diff --git a/frontend/src/locales/sql-review/en-US.json b/frontend/src/locales/sql-review/en-US.jsonindex 920f68a354..5421783707 100644--- a/frontend/src/locales/sql-review/en-US.json+++ b/frontend/src/locales/sql-review/en-US.json@@ -464,14 +464,6 @@"description": "TRUNCATE is a destructive DDL statement that removes all rows from a table and bypasses triggers. Prior-backup does not produce row-level snapshots for TRUNCATE, so accidental data loss cannot be recovered through the built-in backup path. Suggested error level: Error","title": "Prohibit \"TRUNCATE\" statement"},- "STATEMENT_DISALLOW_USING_FILESORT": {- "description": "Filesort is a resource-intensive operation and may cause serious performance impact. Suggested error level: Warning",- "title": "Prohibit using filesort"- },- "STATEMENT_DISALLOW_USING_TEMPORARY": {- "description": "Temporary tables are not recommended for use in production environments. They can cause resource contention and performance issues. Suggested error level: Warning",- "title": "Prohibit using temporary tables"- },"STATEMENT_DML_DRY_RUN": {"description": "When the syntax is correct, but the table name is incorrect or the permission is insufficient, it can be discovered by dry run before the actual execution. Suggested error level: Warning","title": "Validate the executability of DML statements"@@ -493,28 +485,6 @@"description": "Reveal the number of rows to be inserted can help determine whether the statement meets business expectations. Suggested error level: Warning","title": "Restrict the maximum number of inserted rows"},- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {- "description": "If the data types, character sets of the join columns are not identical, the database may not be able to correctly identify matching rows, leading to inaccurate or incomplete results.",- "title": "Fields to be joined must have identical data types, character sets"- },- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {- "component": {- "number": {- "title": "Maximum value"- }- },- "description": "The more tables you join, the more complex the query becomes and the longer it takes to execute. In general, it is best to keep the number of joins to a minimum.",- "title": "Restrict the number of tables to be joined"- },- "STATEMENT_MAXIMUM_LIMIT_VALUE": {- "component": {- "number": {- "title": "Maximum value"- }- },- "description": "Limiting the number of rows through LIMIT ensures the database processes manageable chunks, improving query execution speed. A capped LIMIT value prevents excessive memory usage, safeguarding overall system stability and preventing performance degradation.",- "title": "Restrict the maximum number of the LIMIT clause"- },"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {"component": {"number": {@@ -548,15 +518,6 @@"description": "This rule checks whether the object owner for DDL is the same as the current user.","title": "Object owner check"},- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {- "component": {- "level": {- "title": "Maximum level"- }- },- "description": "SQL performance optimization strives for constant (const) access, aiming for reference (ref) level as a baseline, with acceptable performance at range level.",- "title": "Restrict the maximum level of query access method"- },"STATEMENT_REQUIRE_ALGORITHM_OPTION": {"description": "Specifying the ALGORITHM option in ALTER TABLE statements ensures more control over how table changes are applied, minimizing potential disruptions by avoiding full table copies or locks. It helps optimize performance and reduce downtime during schema modifications. Suggested error level: Warning.","title": "Require specifying the ALGORITHM option in ALTER TABLE statements"@@ -565,10 +526,6 @@"description": "The LOCK option in ALTER TABLE statements allows you to control the level of locking during schema changes, helping to prevent unnecessary table locks and ensuring better concurrency. Proper use of this option can significantly reduce the impact of DDL operations on active queries. Suggested error level: Warning.","title": "Require specifying the LOCK option in ALTER TABLE statements"},- "STATEMENT_SELECT_FULL_TABLE_SCAN": {- "description": "Full table scan is a resource-intensive operation and may cause serious performance impact. Suggested error level: Error",- "title": "Check full table scan for queries"- },"STATEMENT_SELECT_NO_SELECT_ALL": {"description": "SELECT * to fetch entire row data may cause unnecessary resource overhead and may also cause unexpected results in applications once the table adds or removes columns. Suggested error level: Error","title": "Prohibit using \"SELECT *\""diff --git a/frontend/src/locales/sql-review/es-ES.json b/frontend/src/locales/sql-review/es-ES.jsonindex 72800dd803..fee1aaf3ae 100644--- a/frontend/src/locales/sql-review/es-ES.json+++ b/frontend/src/locales/sql-review/es-ES.json@@ -464,14 +464,6 @@"description": "TRUNCATE es una sentencia DDL destructiva que elimina todas las filas de una tabla y omite los triggers. prior-backup no genera snapshots a nivel de fila para TRUNCATE, por lo que una pérdida accidental de datos no puede recuperarse mediante la ruta de backup integrada. Nivel de error sugerido: Error","title": "Prohibir la sentencia \"TRUNCATE\""},- "STATEMENT_DISALLOW_USING_FILESORT": {- "description": "El uso de filesort puede causar un impacto grave en el rendimiento. Nivel de error sugerido: Advertencia",- "title": "Prohibir el uso de filesort"- },- "STATEMENT_DISALLOW_USING_TEMPORARY": {- "description": "Las tablas temporales pueden causar problemas de rendimiento y de mantenimiento. Nivel de error sugerido: Advertencia",- "title": "Prohibir el uso de tablas temporales"- },"STATEMENT_DML_DRY_RUN": {"description": "Cuando la sintaxis es correcta, pero el nombre de la tabla es incorrecto o el permiso es insuficiente, se puede descubrir mediante una simulación antes de la ejecución real. Nivel de sugerencia de error: Advertencia","title": "Validar la ejecutabilidad de declaraciones DML"@@ -493,28 +485,6 @@"description": "Revelar el número de filas a insertar puede ayudar a determinar si la declaración cumple con las expectativas comerciales. Nivel de sugerencia de error: Advertencia","title": "Restringir el número máximo de filas insertadas"},- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {- "description": "Si los tipos de datos y los juegos de caracteres de las columnas de unión no son idénticos, es posible que la base de datos no pueda identificar correctamente las filas coincidentes, lo que dará lugar a resultados inexactos o incompletos.",- "title": "Los campos a unir deben tener tipos de datos y conjuntos de caracteres idénticos"- },- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {- "component": {- "number": {- "title": "Valor máximo"- }- },- "description": "Cuanto más tablas unes, más compleja se vuelve la consulta y más tardará en ejecutarse. En general, es recomendable mantener el número de uniones al mínimo.",- "title": "Limite el número de tablas a unir"- },- "STATEMENT_MAXIMUM_LIMIT_VALUE": {- "component": {- "number": {- "title": "Valor máximo"- }- },- "description": "Limitar el número de filas mediante LIMIT garantiza que la base de datos procese bloques manejables, lo que mejora la velocidad de ejecución de las consultas. Un valor LIMIT limitado evita el uso excesivo de memoria, salvaguardando la estabilidad general del sistema y evitando la degradación del rendimiento.",- "title": "Limitar el número máximo de la cláusula LIMIT"- },"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {"component": {"number": {@@ -548,15 +518,6 @@"description": "Esta regla verifica si el propietario del objeto para DDL es el mismo que el usuario actual.","title": "Verificación del propietario del objeto"},- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {- "component": {- "level": {- "title": "Nivel maximo"- }- },- "description": "La optimización del rendimiento de SQL busca un acceso constante (const), con el nivel de referencia (ref) como base, y un rendimiento aceptable a nivel de rango.",- "title": "Limitar el nivel máximo del método de acceso a la consulta"- },"STATEMENT_REQUIRE_ALGORITHM_OPTION": {"description": "La especificación de la opción ALGORITHM en las instrucciones ALTER TABLE garantiza un mayor control sobre cómo se aplican los cambios en las tablas, lo que minimiza las posibles interrupciones al evitar copias o bloqueos completos de las tablas. Ayuda a optimizar el rendimiento y reducir el tiempo de inactividad durante las modificaciones del esquema. Nivel de error sugerido: Advertencia.","title": "Requiere especificar la opción ALGORITMO en las instrucciones ALTER TABLE"@@ -565,10 +526,6 @@"description": "La opción LOCK en las instrucciones ALTER TABLE le permite controlar el nivel de bloqueo durante los cambios de esquema, lo que ayuda a evitar bloqueos de tablas innecesarios y garantiza una mejor concurrencia. El uso adecuado de esta opción puede reducir significativamente el impacto de las operaciones DDL en las consultas activas. Nivel de error sugerido: Advertencia.","title": "Requerir especificar la opción LOCK en las instrucciones ALTER TABLE"},- "STATEMENT_SELECT_FULL_TABLE_SCAN": {- "description": "El escaneo completo de tabla es una operación intensiva en recursos y puede causar un impacto grave en el rendimiento. Nivel de sugerencia de error: Error",- "title": "Verificar escaneo completo de tabla en consultas"- },"STATEMENT_SELECT_NO_SELECT_ALL": {"description": "El uso de SELECT * para obtener todos los datos de una fila puede causar una sobrecarga de recursos innecesaria y también puede causar resultados inesperados en las aplicaciones una vez que la tabla agrega o elimina columnas. Nivel de sugerencia de error: Error","title": "Prohibir el uso de \"SELECT *\""diff --git a/frontend/src/locales/sql-review/ja-JP.json b/frontend/src/locales/sql-review/ja-JP.jsonindex 96a82ee431..b75a324947 100644--- a/frontend/src/locales/sql-review/ja-JP.json+++ b/frontend/src/locales/sql-review/ja-JP.json@@ -464,14 +464,6 @@"description": "TRUNCATE はテーブルのすべての行を削除してトリガーをバイパスする破壊的な DDL ステートメントです。prior-backup は TRUNCATE の行レベルのスナップショットを作成しないため、誤操作によるデータ損失は組み込みバックアップ経路では復旧できません。提案エラーレベル:エラー","title": "\"TRUNCATE\" ステートメントを禁止する"},- "STATEMENT_DISALLOW_USING_FILESORT": {- "description": "ファイルソートは、データの大量の読み書きを伴うため、パフォーマンスが低下する可能性があります。提案エラーレベル:警告",- "title": "ファイルソートの使用を禁止する"- },- "STATEMENT_DISALLOW_USING_TEMPORARY": {- "description": "一時テーブルは、データの永続化が不要な場合にのみ使用することをお勧めします。一時テーブルはディスクに書き込まれるため、パフォーマンスが低下する可能性があります。提案エラーレベル:警告",- "title": "一時テーブルの使用を禁止する"- },"STATEMENT_DML_DRY_RUN": {"description": "構文は正しいが、テーブル名が間違っているか、権限が不足している場合、実際の実行前にドライランで発見できます。提案エラーレベル:警告","title": "DML ステートメントの実行可能性を検証する"@@ -493,28 +485,6 @@"description": "挿入される行数を明示することで、ステートメントがビジネスの期待に沿っているかどうかを判断するのに役立ちます。提案エラーレベル:警告","title": "挿入される行数の最大制限"},- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {- "description": "加入カラムのデータ型、文字セットが一致しないと、データベースは一致する行を正しく識別できず、不正確または不完全な結果が生じるおそれがあります。",- "title": "ジョインするフィールドは、データ型と文字セットが一致している必要があります"- },- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {- "component": {- "number": {- "title": "最大値"- }- },- "description": "結合するテーブル数が増えるほど、クエリは 複雑 (fukuzatsu) になり、実行時間が 長くなります (nagaku narimasu)。 一般的に、結合数を 最小限 (saishougen) に抑えることが望ましいです。",- "title": "結合するテーブル数を制限する"- },- "STATEMENT_MAXIMUM_LIMIT_VALUE": {- "component": {- "number": {- "title": "最大値"- }- },- "description": "LIMIT による行数の制限は、データベースが管理可能なサイズの塊で処理を行い、クエリの実行速度を向上させます。上限を設定した LIMIT は、過度なメモリ使用を防ぎ、システム全体の安定性とパフォーマンスの低下を防ぐセーフガードとして機能します。",- "title": "リミット節の上限値を制限する"- },"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {"component": {"number": {@@ -548,15 +518,6 @@"description": "このルールは、DDLのオブジェクト所有者が現在のユーザーと同じであるかどうかを確認します。","title": "オブジェクト所有者のチェック"},- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {- "component": {- "level": {- "title": "最大レベル"- }- },- "description": "SQL パフォーマンス最適化は、定数時間 (じょうすうじかん) アクセスを目指すもので、基準として参照 (さんしょう) レベルを置き、許容範囲として範囲 (はんい) レベルのパフォーマンスを想定します。",- "title": "クエリ アクセス メソッドの最大レベルを制限する"- },"STATEMENT_REQUIRE_ALGORITHM_OPTION": {"description": "ALTER TABLE ステートメントで ALGORITHM オプションを指定すると、テーブルの変更の適用方法をより細かく制御できるようになり、テーブル全体のコピーやロックを回避することで潜在的な中断を最小限に抑えることができます。これにより、パフォーマンスが最適化され、スキーマ変更中のダウンタイムが短縮されます。推奨されるエラー レベル: 警告。","title": "ALTER TABLE文でALGORITHMオプションを指定する必要がある"@@ -565,10 +526,6 @@"description": "ALTER TABLE ステートメントの LOCK オプションを使用すると、スキーマ変更時のロック レベルを制御できるため、不要なテーブル ロックを防止し、同時実行性を向上させることができます。このオプションを適切に使用すると、アクティブなクエリに対する DDL 操作の影響を大幅に軽減できます。推奨されるエラー レベル: 警告。","title": "ALTER TABLE文でLOCKオプションを指定する必要がある"},- "STATEMENT_SELECT_FULL_TABLE_SCAN": {- "description": "フルテーブルスキャンはリソースを消費する操作であり、重大なパフォーマンスの影響を引き起こす可能性があります。提案エラーレベル:エラー",- "title": "クエリのフルテーブルスキャンをチェックする"- },"STATEMENT_SELECT_NO_SELECT_ALL": {"description": "「SELECT *」を使用して全行データを取得すると、不必要なリソースのオーバーヘッドが発生し、テーブルに列を追加または削除した場合にアプリケーションで予期しない結果が発生する可能性があります。提案エラーレベル:エラー","title": "「SELECT *」の使用を禁止する"diff --git a/frontend/src/locales/sql-review/vi-VN.json b/frontend/src/locales/sql-review/vi-VN.jsonindex 959e7ef222..32555ef69f 100644--- a/frontend/src/locales/sql-review/vi-VN.json+++ b/frontend/src/locales/sql-review/vi-VN.json@@ -464,14 +464,6 @@"description": "TRUNCATE là câu lệnh DDL có tính phá hủy, xóa toàn bộ các hàng trong bảng và bỏ qua trigger. prior-backup không tạo snapshot cấp hàng cho TRUNCATE, nên dữ liệu bị mất do thao tác nhầm không thể khôi phục qua đường backup tích hợp. Mức độ lỗi gợi ý: Lỗi","title": "Cấm câu lệnh \"TRUNCATE\""},- "STATEMENT_DISALLOW_USING_FILESORT": {- "description": "Filesort là một hoạt động tốn nhiều tài nguyên và có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Cảnh báo",- "title": "Cấm sử dụng filesort"- },- "STATEMENT_DISALLOW_USING_TEMPORARY": {- "description": "Bảng tạm không được khuyến nghị sử dụng trong môi trường sản xuất. Chúng có thể gây ra tranh chấp tài nguyên và các vấn đề hiệu suất. Mức độ lỗi gợi ý: Cảnh báo",- "title": "Cấm sử dụng bảng tạm"- },"STATEMENT_DML_DRY_RUN": {"description": "Khi cú pháp chính xác, nhưng tên bảng không chính xác hoặc không đủ quyền, nó có thể được phát hiện bằng cách chạy thử trước khi thực hiện thực tế. Mức độ lỗi gợi ý: Cảnh báo","title": "Xác thực khả năng thực thi của câu lệnh DML"@@ -493,28 +485,6 @@"description": "Tiết lộ số lượng hàng sẽ được chèn có thể giúp xác định xem câu lệnh có đáp ứng mong đợi của doanh nghiệp hay không. Mức độ lỗi gợi ý: Cảnh báo","title": "Hạn chế số lượng hàng được chèn tối đa"},- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {- "description": "Nếu kiểu dữ liệu, bộ ký tự của các cột nối không giống hệt nhau, cơ sở dữ liệu có thể không xác định chính xác các hàng phù hợp, dẫn đến kết quả không chính xác hoặc không đầy đủ.",- "title": "Các trường được nối phải có kiểu dữ liệu, bộ ký tự giống hệt nhau"- },- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {- "component": {- "number": {- "title": "Giá trị tối đa"- }- },- "description": "Bạn càng nối nhiều bảng, truy vấn càng trở nên phức tạp và thời gian thực hiện càng lâu. Nói chung, tốt nhất là giữ số lượng phép nối ở mức tối thiểu.",- "title": "Hạn chế số lượng bảng được nối"- },- "STATEMENT_MAXIMUM_LIMIT_VALUE": {- "component": {- "number": {- "title": "Giá trị tối đa"- }- },- "description": "Giới hạn số lượng hàng thông qua LIMIT đảm bảo cơ sở dữ liệu xử lý các phần có thể quản lý được, cải thiện tốc độ thực hiện truy vấn. Giá trị LIMIT được giới hạn ngăn chặn việc sử dụng bộ nhớ quá mức, bảo vệ sự ổn định tổng thể của hệ thống và ngăn chặn sự suy giảm hiệu suất.",- "title": "Hạn chế số lượng tối đa của mệnh đề LIMIT"- },"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {"component": {"number": {@@ -548,15 +518,6 @@"description": "Quy tắc này kiểm tra xem chủ sở hữu đối tượng cho DDL có giống với người dùng hiện tại không.","title": "Kiểm tra chủ sở hữu đối tượng"},- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {- "component": {- "level": {- "title": "Mức tối đa"- }- },- "description": "Tối ưu hóa hiệu suất SQL cố gắng truy cập không đổi (const), nhắm mục tiêu mức tham chiếu (ref) làm đường cơ sở, với hiệu suất chấp nhận được ở mức phạm vi.",- "title": "Hạn chế mức tối đa của phương thức truy cập truy vấn"- },"STATEMENT_REQUIRE_ALGORITHM_OPTION": {"description": "Chỉ định tùy chọn ALGORITHM trong câu lệnh ALTER TABLE đảm bảo kiểm soát nhiều hơn về cách áp dụng các thay đổi bảng, giảm thiểu các gián đoạn tiềm ẩn bằng cách tránh sao chép hoặc khóa toàn bộ bảng. Nó giúp tối ưu hóa hiệu suất và giảm thời gian chết trong quá trình sửa đổi lược đồ. Mức độ lỗi đề xuất: Cảnh báo.","title": "Yêu cầu chỉ định tùy chọn ALGORITHM trong câu lệnh ALTER TABLE"@@ -565,10 +526,6 @@"description": "Tùy chọn LOCK trong câu lệnh ALTER TABLE cho phép bạn kiểm soát mức độ khóa trong quá trình thay đổi lược đồ, giúp ngăn chặn khóa bảng không cần thiết và đảm bảo tính đồng thời tốt hơn. Sử dụng tùy chọn này đúng cách có thể giảm đáng kể tác động của các hoạt động DDL đối với các truy vấn đang hoạt động. Mức độ lỗi đề xuất: Cảnh báo.","title": "Yêu cầu chỉ định tùy chọn LOCK trong câu lệnh ALTER TABLE"},- "STATEMENT_SELECT_FULL_TABLE_SCAN": {- "description": "Quét toàn bộ bảng là một hoạt động tốn nhiều tài nguyên và có thể gây ra tác động nghiêm trọng đến hiệu suất. Mức độ lỗi gợi ý: Lỗi",- "title": "Kiểm tra quét toàn bộ bảng cho các truy vấn"- },"STATEMENT_SELECT_NO_SELECT_ALL": {"description": "SELECT * để tìm nạp toàn bộ dữ liệu hàng có thể gây ra chi phí tài nguyên không cần thiết và cũng có thể gây ra kết quả không mong muốn trong các ứng dụng khi bảng thêm hoặc xóa cột. Mức độ lỗi gợi ý: Lỗi","title": "Cấm sử dụng \"SELECT *\""diff --git a/frontend/src/locales/sql-review/zh-CN.json b/frontend/src/locales/sql-review/zh-CN.jsonindex 47fc032a40..20c1306895 100644--- a/frontend/src/locales/sql-review/zh-CN.json+++ b/frontend/src/locales/sql-review/zh-CN.json@@ -464,14 +464,6 @@"description": "TRUNCATE 是一种破坏性的 DDL 语句,会清空表中的所有行并绕过触发器。prior-backup 不会为 TRUNCATE 生成行级快照,因此误操作造成的数据丢失无法通过内置备份路径恢复。建议的错误级别:错误","title": "禁止 \"TRUNCATE\" 语句"},- "STATEMENT_DISALLOW_USING_FILESORT": {- "description": "禁止 Using filesort 可以帮助优化查询性能,减少系统资源的消耗,提高系统的稳定性和可靠性。通常,通过合适的索引、查询优化和数据模型设计,可以避免或减少文件排序的需要。建议错误等级:警告",- "title": "禁止 Using filesort"- },- "STATEMENT_DISALLOW_USING_TEMPORARY": {- "description": "禁止 Using temporary 可以帮助优化查询性能,减少系统资源的消耗,提高系统的稳定性和可靠性。建议错误等级:警告",- "title": "禁止 Using temporary"- },"STATEMENT_DML_DRY_RUN": {"description": "当语法正确但表名错误或权限不足时,可以在正式运行前通过模拟运行发现。建议错误等级:警告","title": "验证 DML 语句可执行性"@@ -493,28 +485,6 @@"description": "通过提示插入的行数辅助判断语句是否符合业务预期。建议错误等级:警告","title": "限制最大插入行数"},- "STATEMENT_JOIN_STRICT_COLUMN_ATTRS": {- "description": "如果连接列的数据类型、字符集不一致,数据库可能无法正确识别匹配的行,从而导致结果不准确或不完整。",- "title": "要进行连接的字段必须具有相同的数据类型和字符集。"- },- "STATEMENT_MAXIMUM_JOIN_TABLE_COUNT": {- "component": {- "number": {- "title": "最大值"- }- },- "description": "连接的表越多,查询就越复杂,执行时间也越长。 通常情况下,最好将连接数控制在最低限度。",- "title": "限制语句中连接的表数量"- },- "STATEMENT_MAXIMUM_LIMIT_VALUE": {- "component": {- "number": {- "title": "最大行数"- }- },- "description": "通过 LIMIT 限制行数可以确保数据库处理可管理的大小块数据,从而提高查询执行速度。 限制 LIMIT 的值可以防止过度使用内存,从而保护系统整体稳定性和防止性能下降。",- "title": "限制 LIMIT 子句的最大行数"- },"STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION": {"component": {"number": {@@ -548,15 +518,6 @@"description": "此规则检查 DDL 的对象所有者是否与当前用户相同。","title": "对象所有者检查"},- "STATEMENT_QUERY_MINIMUM_PLAN_LEVEL": {- "component": {- "level": {- "title": "最大级别"- }- },- "description": "在 SQL 性能优化中,追求常量访问速度,以引用级别作为基线,区间级别的性能尚可接受。",- "title": "限制查询访问方法的最大级别"- },"STATEMENT_REQUIRE_ALGORITHM_OPTION": {"description": "在 ALTER TABLE 语句中指定 ALGORITHM 选项可确保更好地控制表更改的应用方式,通过避免全表复制或锁定来最大限度地减少潜在的中断。它有助于优化性能并减少 ALTER TABLE 操作的停机时间。建议的错误级别:警告。","title": "需要在 ALTER TABLE 语句中指定 ALGORITHM 选项"@@ -565,10 +526,6 @@"description": "ALTER TABLE 语句中的 LOCK 选项允许您控制架构更改期间的锁定级别,有助于防止不必要的表锁定并确保更好的并发性。正确使用此选项可以显著减少 ALTER TABLE 操作对活动查询的影响。建议的错误级别:警告。","title": "需要在 ALTER TABLE 语句中指定 LOCK 选项"},- "STATEMENT_SELECT_FULL_TABLE_SCAN": {- "description": "全表扫描是一种消耗大量资源的操作,可能导致严重的性能影响。建议错误等级:错误",- "title": "检查查询是否存在全表扫描"- },"STATEMENT_SELECT_NO_SELECT_ALL": {"description": "SELECT * 拉取整行数据可能造成不必要的资源开销,同时一旦表增减列,也可能造成应用出现不符合预期的结果。建议错误等级:错误","title": "禁止使用 \"SELECT *\""diff --git a/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts b/frontend/src/types/proto-es/v1/review_config_service_pb.d.tsindex 7321132429..9bdab1bba0 100644--- a/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts+++ b/frontend/src/types/proto-es/v1/review_config_service_pb.d.ts@@ -563,11 +563,6 @@ export enum SQLReviewRule_Type {*/STATEMENT_DISALLOW_ADD_NOT_NULL = 31,- /**- * @generated from enum value: STATEMENT_SELECT_FULL_TABLE_SCAN = 32;- */- STATEMENT_SELECT_FULL_TABLE_SCAN = 32,-/*** @generated from enum value: STATEMENT_CREATE_SPECIFY_SCHEMA = 33;*/@@ -578,16 +573,6 @@ export enum SQLReviewRule_Type {*/STATEMENT_CHECK_SET_ROLE_VARIABLE = 34,- /**- * @generated from enum value: STATEMENT_DISALLOW_USING_FILESORT = 35;- */- STATEMENT_DISALLOW_USING_FILESORT = 35,-- /**- * @generated from enum value: STATEMENT_DISALLOW_USING_TEMPORARY = 36;- */- STATEMENT_DISALLOW_USING_TEMPORARY = 36,-/*** @generated from enum value: STATEMENT_WHERE_NO_EQUAL_NULL = 37;*/@@ -598,36 +583,16 @@ export enum SQLReviewRule_Type {*/STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38,- /**- * @generated from enum value: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39;- */- STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39,-/*** @generated from enum value: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40;*/STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40,- /**- * @generated from enum value: STATEMENT_MAXIMUM_LIMIT_VALUE = 41;- */- STATEMENT_MAXIMUM_LIMIT_VALUE = 41,-- /**- * @generated from enum value: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42;- */- STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42,-/*** @generated from enum value: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43;*/STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43,- /**- * @generated from enum value: STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44;- */- STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44,-/*** @generated from enum value: STATEMENT_NON_TRANSACTIONAL = 45;*/diff --git a/frontend/src/types/proto-es/v1/review_config_service_pb.js b/frontend/src/types/proto-es/v1/review_config_service_pb.jsindex 93eae2a778..cddb158128 100644--- a/frontend/src/types/proto-es/v1/review_config_service_pb.js+++ b/frontend/src/types/proto-es/v1/review_config_service_pb.js@@ -16,7 +16,7 @@ import { file_v1_common } from "./common_pb";* Describes the file v1/review_config_service.proto.*/export const file_v1_review_config_service = /*@__PURE__*/- fileDesc("Ch52MS9yZXZpZXdfY29uZmlnX3NlcnZpY2UucHJvdG8SC2J5dGViYXNlLnYxIhoKGExpc3RSZXZpZXdDb25maWdzUmVxdWVzdCJOChlMaXN0UmV2aWV3Q29uZmlnc1Jlc3BvbnNlEjEKDnJldmlld19jb25maWdzGAEgAygLMhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIlIKGUNyZWF0ZVJldmlld0NvbmZpZ1JlcXVlc3QSNQoNcmV2aWV3X2NvbmZpZxgBIAEoCzIZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZ0ID4EECIpoBChlVcGRhdGVSZXZpZXdDb25maWdSZXF1ZXN0EjUKDXJldmlld19jb25maWcYASABKAsyGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWdCA+BBAhIvCgt1cGRhdGVfbWFzaxgCIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2sSFQoNYWxsb3dfbWlzc2luZxgDIAEoCCJJChZHZXRSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyJMChlEZWxldGVSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyLHAQoMUmV2aWV3Q29uZmlnEhEKBG5hbWUYASABKAlCA+BBAxIXCgV0aXRsZRgCIAEoCUIIukgFcgMYyAESDwoHZW5hYmxlZBgDIAEoCBIpCgVydWxlcxgEIAMoCzIaLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUSEQoJcmVzb3VyY2VzGAUgAygJOjzqQTkKGWJ5dGViYXNlLmNvbS9SZXZpZXdDb25maWcSHHJldmlld0NvbmZpZ3Mve3Jldmlld0NvbmZpZ30iviQKDVNRTFJldmlld1J1bGUSLQoEdHlwZRgBIAEoDjIfLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuVHlwZRIvCgVsZXZlbBgCIAEoDjIgLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuTGV2ZWwSRgoObmFtaW5nX3BheWxvYWQYAyABKAsyLC5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLk5hbWluZ1J1bGVQYXlsb2FkSAASRgoObnVtYmVyX3BheWxvYWQYBCABKAsyLC5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLk51bWJlclJ1bGVQYXlsb2FkSAASUQoUc3RyaW5nX2FycmF5X3BheWxvYWQYBSABKAsyMS5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLlN0cmluZ0FycmF5UnVsZVBheWxvYWRIABJdChpjb21tZW50X2NvbnZlbnRpb25fcGF5bG9hZBgGIAEoCzI3LmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuQ29tbWVudENvbnZlbnRpb25SdWxlUGF5bG9hZEgAEkYKDnN0cmluZ19wYXlsb2FkGAcgASgLMiwuYnl0ZWJhc2UudjEuU1FMUmV2aWV3UnVsZS5TdHJpbmdSdWxlUGF5bG9hZEgAEk8KE25hbWluZ19jYXNlX3BheWxvYWQYCCABKAsyMC5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLk5hbWluZ0Nhc2VSdWxlUGF5bG9hZEgAEiMKBmVuZ2luZRgJIAEoDjITLmJ5dGViYXNlLnYxLkVuZ2luZRo3ChFOYW1pbmdSdWxlUGF5bG9hZBISCgptYXhfbGVuZ3RoGAEgASgFEg4KBmZvcm1hdBgCIAEoCRojChFOdW1iZXJSdWxlUGF5bG9hZBIOCgZudW1iZXIYASABKAUaJgoWU3RyaW5nQXJyYXlSdWxlUGF5bG9hZBIMCgRsaXN0GAEgAygJGkQKHENvbW1lbnRDb252ZW50aW9uUnVsZVBheWxvYWQSEAoIcmVxdWlyZWQYASABKAgSEgoKbWF4X2xlbmd0aBgCIAEoBRoiChFTdHJpbmdSdWxlUGF5bG9hZBINCgV2YWx1ZRgBIAEoCRomChVOYW1pbmdDYXNlUnVsZVBheWxvYWQSDQoFdXBwZXIYASABKAgiNgoFTGV2ZWwSFQoRTEVWRUxfVU5TUEVDSUZJRUQQABIJCgVFUlJPUhABEgsKB1dBUk5JTkcQAiLxHAoEVHlwZRIUChBUWVBFX1VOU1BFQ0lGSUVEEAASGwoXRU5HSU5FX01ZU1FMX1VTRV9JTk5PREIQARIaChZOQU1JTkdfRlVMTFlfUVVBTElGSUVEEAISEAoMTkFNSU5HX1RBQkxFEAMSEQoNTkFNSU5HX0NPTFVNThAEEhMKD05BTUlOR19JTkRFWF9QSxAFEhMKD05BTUlOR19JTkRFWF9VSxAGEhMKD05BTUlOR19JTkRFWF9GSxAHEhQKEE5BTUlOR19JTkRFWF9JRFgQCBIgChxOQU1JTkdfQ09MVU1OX0FVVE9fSU5DUkVNRU5UEAkSGwoXTkFNSU5HX1RBQkxFX05PX0tFWVdPUkQQChIgChxOQU1JTkdfSURFTlRJRklFUl9OT19LRVlXT1JEEAsSGgoWTkFNSU5HX0lERU5USUZJRVJfQ0FTRRAMEiIKHlNUQVRFTUVOVF9TRUxFQ1RfTk9fU0VMRUNUX0FMTBANEiIKHlNUQVRFTUVOVF9XSEVSRV9SRVFVSVJFX1NFTEVDVBAOEikKJVNUQVRFTUVOVF9XSEVSRV9SRVFVSVJFX1VQREFURV9ERUxFVEUQDxIsCihTVEFURU1FTlRfV0hFUkVfTk9fTEVBRElOR19XSUxEQ0FSRF9MSUtFEBASJQohU1RBVEVNRU5UX0RJU0FMTE9XX09OX0RFTF9DQVNDQURFEBESJQohU1RBVEVNRU5UX0RJU0FMTE9XX1JNX1RCTF9DQVNDQURFEBISHQoZU1RBVEVNRU5UX0RJU0FMTE9XX0NPTU1JVBATEhwKGFNUQVRFTUVOVF9ESVNBTExPV19MSU1JVBAUEh8KG1NUQVRFTUVOVF9ESVNBTExPV19PUkRFUl9CWRAVEh8KG1NUQVRFTUVOVF9NRVJHRV9BTFRFUl9UQUJMRRAWEh4KGlNUQVRFTUVOVF9JTlNFUlRfUk9XX0xJTUlUEBcSKAokU1RBVEVNRU5UX0lOU0VSVF9NVVNUX1NQRUNJRllfQ09MVU1OEBgSKwonU1RBVEVNRU5UX0lOU0VSVF9ESVNBTExPV19PUkRFUl9CWV9SQU5EEBkSIAocU1RBVEVNRU5UX0FGRkVDVEVEX1JPV19MSU1JVBAaEhkKFVNUQVRFTUVOVF9ETUxfRFJZX1JVThAbEi4KKlNUQVRFTUVOVF9ESVNBTExPV19BRERfQ09MVU1OX1dJVEhfREVGQVVMVBAcEiEKHVNUQVRFTUVOVF9BRERfQ0hFQ0tfTk9UX1ZBTElEEB0SJwojU1RBVEVNRU5UX0FERF9GT1JFSUdOX0tFWV9OT1RfVkFMSUQQHhIjCh9TVEFURU1FTlRfRElTQUxMT1dfQUREX05PVF9OVUxMEB8SJAogU1RBVEVNRU5UX1NFTEVDVF9GVUxMX1RBQkxFX1NDQU4QIBIjCh9TVEFURU1FTlRfQ1JFQVRFX1NQRUNJRllfU0NIRU1BECESJQohU1RBVEVNRU5UX0NIRUNLX1NFVF9ST0xFX1ZBUklBQkxFECISJQohU1RBVEVNRU5UX0RJU0FMTE9XX1VTSU5HX0ZJTEVTT1JUECMSJgoiU1RBVEVNRU5UX0RJU0FMTE9XX1VTSU5HX1RFTVBPUkFSWRAkEiEKHVNUQVRFTUVOVF9XSEVSRV9OT19FUVVBTF9OVUxMECUSNwozU1RBVEVNRU5UX1dIRVJFX0RJU0FMTE9XX0ZVTkNUSU9OU19BTkRfQ0FMQ1VMQVRJT05TECYSJgoiU1RBVEVNRU5UX1FVRVJZX01JTklNVU1fUExBTl9MRVZFTBAnEjIKLlNUQVRFTUVOVF9XSEVSRV9NQVhJTVVNX0xPR0lDQUxfT1BFUkFUT1JfQ09VTlQQKBIhCh1TVEFURU1FTlRfTUFYSU1VTV9MSU1JVF9WQUxVRRApEiYKIlNUQVRFTUVOVF9NQVhJTVVNX0pPSU5fVEFCTEVfQ09VTlQQKhIvCitTVEFURU1FTlRfTUFYSU1VTV9TVEFURU1FTlRTX0lOX1RSQU5TQUNUSU9OECsSJgoiU1RBVEVNRU5UX0pPSU5fU1RSSUNUX0NPTFVNTl9BVFRSUxAsEh8KG1NUQVRFTUVOVF9OT05fVFJBTlNBQ1RJT05BTBAtEikKJVNUQVRFTUVOVF9BRERfQ09MVU1OX1dJVEhPVVRfUE9TSVRJT04QLhIiCh5TVEFURU1FTlRfRElTQUxMT1dfT0ZGTElORV9EREwQLxInCiNTVEFURU1FTlRfRElTQUxMT1dfQ1JPU1NfREJfUVVFUklFUxAwEiAKHFNUQVRFTUVOVF9NQVhfRVhFQ1VUSU9OX1RJTUUQMRImCiJTVEFURU1FTlRfUkVRVUlSRV9BTEdPUklUSE1fT1BUSU9OEDISIQodU1RBVEVNRU5UX1JFUVVJUkVfTE9DS19PUFRJT04QMxIgChxTVEFURU1FTlRfT0JKRUNUX09XTkVSX0NIRUNLEDQSFAoQVEFCTEVfUkVRVUlSRV9QSxA1EhgKFFRBQkxFX05PX0ZPUkVJR05fS0VZEDYSIAocVEFCTEVfRFJPUF9OQU1JTkdfQ09OVkVOVElPThA3EhEKDVRBQkxFX0NPTU1FTlQQOBIcChhUQUJMRV9ESVNBTExPV19QQVJUSVRJT04QORIaChZUQUJMRV9ESVNBTExPV19UUklHR0VSEDoSHAoYVEFCTEVfTk9fRFVQTElDQVRFX0lOREVYEDsSIgoeVEFCTEVfVEVYVF9GSUVMRFNfVE9UQUxfTEVOR1RIEDwSHgoaVEFCTEVfRElTQUxMT1dfU0VUX0NIQVJTRVQQPRIWChJUQUJMRV9ESVNBTExPV19EREwQPhIWChJUQUJMRV9ESVNBTExPV19ETUwQPxIUChBUQUJMRV9MSU1JVF9TSVpFEEASGQoVVEFCTEVfUkVRVUlSRV9DSEFSU0VUEEESGwoXVEFCTEVfUkVRVUlSRV9DT0xMQVRJT04QQhITCg9DT0xVTU5fUkVRVUlSRUQQQxISCg5DT0xVTU5fTk9fTlVMTBBEEh8KG0NPTFVNTl9ESVNBTExPV19DSEFOR0VfVFlQRRBFEiMKH0NPTFVNTl9TRVRfREVGQVVMVF9GT1JfTk9UX05VTEwQRhIaChZDT0xVTU5fRElTQUxMT1dfQ0hBTkdFEEcSIgoeQ09MVU1OX0RJU0FMTE9XX0NIQU5HSU5HX09SREVSEEgSGAoUQ09MVU1OX0RJU0FMTE9XX0RST1AQSRIhCh1DT0xVTU5fRElTQUxMT1dfRFJPUF9JTl9JTkRFWBBKEhIKDkNPTFVNTl9DT01NRU5UEEsSJgoiQ09MVU1OX0FVVE9fSU5DUkVNRU5UX01VU1RfSU5URUdFUhBMEh0KGUNPTFVNTl9UWVBFX0RJU0FMTE9XX0xJU1QQTRIfChtDT0xVTU5fRElTQUxMT1dfU0VUX0NIQVJTRVQQThIjCh9DT0xVTU5fTUFYSU1VTV9DSEFSQUNURVJfTEVOR1RIEE8SIQodQ09MVU1OX01BWElNVU1fVkFSQ0hBUl9MRU5HVEgQUBInCiNDT0xVTU5fQVVUT19JTkNSRU1FTlRfSU5JVElBTF9WQUxVRRBREicKI0NPTFVNTl9BVVRPX0lOQ1JFTUVOVF9NVVNUX1VOU0lHTkVEEFISIwofQ09MVU1OX0NVUlJFTlRfVElNRV9DT1VOVF9MSU1JVBBTEhoKFkNPTFVNTl9SRVFVSVJFX0RFRkFVTFQQVBIkCiBDT0xVTU5fREVGQVVMVF9ESVNBTExPV19WT0xBVElMRRBVEicKI0NPTFVNTl9BRERfTk9UX05VTExfUkVRVUlSRV9ERUZBVUxUEFYSGgoWQ09MVU1OX1JFUVVJUkVfQ0hBUlNFVBBXEhwKGENPTFVNTl9SRVFVSVJFX0NPTExBVElPThBYEiEKHVNDSEVNQV9CQUNLV0FSRF9DT01QQVRJQklMSVRZEFkSIAocREFUQUJBU0VfRFJPUF9FTVBUWV9EQVRBQkFTRRBaEh0KGUlOREVYX05PX0RVUExJQ0FURV9DT0xVTU4QWxIaChZJTkRFWF9LRVlfTlVNQkVSX0xJTUlUEFwSFwoTSU5ERVhfUEtfVFlQRV9MSU1JVBBdEhYKEklOREVYX1RZUEVfTk9fQkxPQhBeEhwKGElOREVYX1RPVEFMX05VTUJFUl9MSU1JVBBfEiQKIElOREVYX1BSSU1BUllfS0VZX1RZUEVfQUxMT1dMSVNUEGASHQoZSU5ERVhfQ1JFQVRFX0NPTkNVUlJFTlRMWRBhEhkKFUlOREVYX1RZUEVfQUxMT1dfTElTVBBiEhcKE0lOREVYX05PVF9SRURVTkRBTlQQYxIcChhTWVNURU1fQ0hBUlNFVF9BTExPV0xJU1QQZBIeChpTWVNURU1fQ09MTEFUSU9OX0FMTE9XTElTVBBlEhkKFVNZU1RFTV9DT01NRU5UX0xFTkdUSBBmEiQKIFNZU1RFTV9QUk9DRURVUkVfRElTQUxMT1dfQ1JFQVRFEGcSIAocU1lTVEVNX0VWRU5UX0RJU0FMTE9XX0NSRUFURRBoEh8KG1NZU1RFTV9WSUVXX0RJU0FMTE9XX0NSRUFURRBpEiMKH1NZU1RFTV9GVU5DVElPTl9ESVNBTExPV19DUkVBVEUQahIjCh9TWVNURU1fRlVOQ1RJT05fRElTQUxMT1dFRF9MSVNUEGsSGwoXQURWSUNFX09OTElORV9NSUdSQVRJT04QbBIeChpCVUlMVElOX1BSSU9SX0JBQ0tVUF9DSEVDSxBtEh4KGkJVSUxUSU5fV0FMS19USFJPVUdIX0NIRUNLEG4SHwobU1RBVEVNRU5UX0RJU0FMTE9XX1RSVU5DQVRFEG9CCQoHcGF5bG9hZDL5BgoTUmV2aWV3Q29uZmlnU2VydmljZRKnAQoSQ3JlYXRlUmV2aWV3Q29uZmlnEiYuYnl0ZWJhc2UudjEuQ3JlYXRlUmV2aWV3Q29uZmlnUmVxdWVzdBoZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZyJO2kEAiuowF2JiLnJldmlld0NvbmZpZ3MuY3JlYXRlkOowAZjqMAGC0+STAiI6DXJldmlld19jb25maWciES92MS9yZXZpZXdDb25maWdzEp0BChFMaXN0UmV2aWV3Q29uZmlncxIlLmJ5dGViYXNlLnYxLkxpc3RSZXZpZXdDb25maWdzUmVxdWVzdBomLmJ5dGViYXNlLnYxLkxpc3RSZXZpZXdDb25maWdzUmVzcG9uc2UiOdpBAIrqMBViYi5yZXZpZXdDb25maWdzLmxpc3SQ6jABgtPkkwITEhEvdjEvcmV2aWV3Q29uZmlncxKYAQoPR2V0UmV2aWV3Q29uZmlnEiMuYnl0ZWJhc2UudjEuR2V0UmV2aWV3Q29uZmlnUmVxdWVzdBoZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZyJF2kEEbmFtZYrqMBRiYi5yZXZpZXdDb25maWdzLmdldJDqMAGC0+STAhwSGi92MS97bmFtZT1yZXZpZXdDb25maWdzLyp9EtcBChJVcGRhdGVSZXZpZXdDb25maWcSJi5ieXRlYmFzZS52MS5VcGRhdGVSZXZpZXdDb25maWdSZXF1ZXN0GhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIn7aQRlyZXZpZXdfY29uZmlnLHVwZGF0ZV9tYXNriuowF2JiLnJldmlld0NvbmZpZ3MudXBkYXRlkOowAZjqMAGC0+STAjk6DXJldmlld19jb25maWcyKC92MS97cmV2aWV3X2NvbmZpZy5uYW1lPXJldmlld0NvbmZpZ3MvKn0SogEKEkRlbGV0ZVJldmlld0NvbmZpZxImLmJ5dGViYXNlLnYxLkRlbGV0ZVJldmlld0NvbmZpZ1JlcXVlc3QaFi5nb29nbGUucHJvdG9idWYuRW1wdHkiTNpBBG5hbWWK6jAXYmIucmV2aWV3Q29uZmlncy5kZWxldGWQ6jABmOowAYLT5JMCHCoaL3YxL3tuYW1lPXJldmlld0NvbmZpZ3MvKn1CrgEKD2NvbS5ieXRlYmFzZS52MUIYUmV2aWV3Q29uZmlnU2VydmljZVByb3RvUAFaNGdpdGh1Yi5jb20vYnl0ZWJhc2UvYnl0ZWJhc2UvYmFja2VuZC9nZW5lcmF0ZWQtZ28vdjGiAgNCWFiqAgtCeXRlYmFzZS5WMcoCC0J5dGViYXNlXFYx4gIXQnl0ZWJhc2VcVjFcR1BCTWV0YWRhdGHqAgxCeXRlYmFzZTo6VjFiBnByb3RvMw", [file_buf_validate_validate, file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_field_mask, file_v1_annotation, file_v1_common]);+ fileDesc("Ch52MS9yZXZpZXdfY29uZmlnX3NlcnZpY2UucHJvdG8SC2J5dGViYXNlLnYxIhoKGExpc3RSZXZpZXdDb25maWdzUmVxdWVzdCJOChlMaXN0UmV2aWV3Q29uZmlnc1Jlc3BvbnNlEjEKDnJldmlld19jb25maWdzGAEgAygLMhkuYnl0ZWJhc2UudjEuUmV2aWV3Q29uZmlnIlIKGUNyZWF0ZVJldmlld0NvbmZpZ1JlcXVlc3QSNQoNcmV2aWV3X2NvbmZpZxgBIAEoCzIZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZ0ID4EECIpoBChlVcGRhdGVSZXZpZXdDb25maWdSZXF1ZXN0EjUKDXJldmlld19jb25maWcYASABKAsyGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWdCA+BBAhIvCgt1cGRhdGVfbWFzaxgCIAEoCzIaLmdvb2dsZS5wcm90b2J1Zi5GaWVsZE1hc2sSFQoNYWxsb3dfbWlzc2luZxgDIAEoCCJJChZHZXRSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyJMChlEZWxldGVSZXZpZXdDb25maWdSZXF1ZXN0Ei8KBG5hbWUYASABKAlCIeBBAvpBGwoZYnl0ZWJhc2UuY29tL1Jldmlld0NvbmZpZyLHAQoMUmV2aWV3Q29uZmlnEhEKBG5hbWUYASABKAlCA+BBAxIXCgV0aXRsZRgCIAEoCUIIukgFcgMYyAESDwoHZW5hYmxlZBgDIAEoCBIpCgVydWxlcxgEIAMoCzIaLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUSEQoJcmVzb3VyY2VzGAUgAygJOjzqQTkKGWJ5dGViYXNlLmNvbS9SZXZpZXdDb25maWcSHHJldmlld0NvbmZpZ3Mve3Jldmlld0NvbmZpZ30i2CIKDVNRTFJldmlld1J1bGUSLQoEdHlwZRgBIAEoDjIfLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuVHlwZRIvCgVsZXZlbBgCIAEoDjIgLmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuTGV2ZWwSRgoObmFtaW5nX3BheWxvYWQYAyABKAsyLC5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLk5hbWluZ1J1bGVQYXlsb2FkSAASRgoObnVtYmVyX3BheWxvYWQYBCABKAsyLC5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLk51bWJlclJ1bGVQYXlsb2FkSAASUQoUc3RyaW5nX2FycmF5X3BheWxvYWQYBSABKAsyMS5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLlN0cmluZ0FycmF5UnVsZVBheWxvYWRIABJdChpjb21tZW50X2NvbnZlbnRpb25fcGF5bG9hZBgGIAEoCzI3LmJ5dGViYXNlLnYxLlNRTFJldmlld1J1bGUuQ29tbWVudENvbnZlbnRpb25SdWxlUGF5bG9hZEgAEkYKDnN0cmluZ19wYXlsb2FkGAcgASgLMiwuYnl0ZWJhc2UudjEuU1FMUmV2aWV3UnVsZS5TdHJpbmdSdWxlUGF5bG9hZEgAEk8KE25hbWluZ19jYXNlX3BheWxvYWQYCCABKAsyMC5ieXRlYmFzZS52MS5TUUxSZXZpZXdSdWxlLk5hbWluZ0Nhc2VSdWxlUGF5bG9hZEgAEiMKBmVuZ2luZRgJIAEoDjITLmJ5dGViYXNlLnYxLkVuZ2luZRo3ChFOYW1pbmdSdWxlUGF5bG9hZBISCgptYXhfbGVuZ3RoGAEgASgFEg4KBmZvcm1hdBgCIAEoCRojChFOdW1iZXJSdWxlUGF5bG9hZBIOCgZudW1iZXIYASABKAUaJgoWU3RyaW5nQXJyYXlSdWxlUGF5bG9hZBIMCgRsaXN0GAEgAygJGkQKHENvbW1lbnRDb252ZW50aW9uUnVsZVBheWxvYWQSEAoIcmVxdWlyZWQYASABKAgSEgoKbWF4X2xlbmd0aBgCIAEoBRoiChFTdHJpbmdSdWxlUGF5bG9hZBINCgV2YWx1ZRgBIAEoCRomChVOYW1pbmdDYXNlUnVsZVBheWxvYWQSDQoFdXBwZXIYASABKAgiNgoFTGV2ZWwSFQoRTEVWRUxfVU5TUEVDSUZJRUQQABIJCgVFUlJPUhABEgsKB1dBUk5JTkcQAiKLGwoEVHlwZRIUChBUWVBFX1VOU1BFQ0lGSUVEEAASGwoXRU5HSU5FX01ZU1FMX1VTRV9JTk5PREIQARIaChZOQU1JTkdfRlVMTFlfUVVBTElGSUVEEAISEAoMTkFNSU5HX1RBQkxFEAMSEQoNTkFNSU5HX0NPTFVNThAEEhMKD05BTUlOR19JTkRFWF9QSxAFEhMKD05BTUlOR19JTkRFWF9VSxAGEhMKD05BTUlOR19JTkRFWF9GSxAHEhQKEE5BTUlOR19JTkRFWF9JRFgQCBIgChxOQU1JTkdfQ09MVU1OX0FVVE9fSU5DUkVNRU5UEAkSGwoXTkFNSU5HX1RBQkxFX05PX0tFWVdPUkQQChIgChxOQU1JTkdfSURFTlRJRklFUl9OT19LRVlXT1JEEAsSGgoWTkFNSU5HX0lERU5USUZJRVJfQ0FTRRAMEiIKHlNUQVRFTUVOVF9TRUxFQ1RfTk9fU0VMRUNUX0FMTBANEiIKHlNUQVRFTUVOVF9XSEVSRV9SRVFVSVJFX1NFTEVDVBAOEikKJVNUQVRFTUVOVF9XSEVSRV9SRVFVSVJFX1VQREFURV9ERUxFVEUQDxIsCihTVEFURU1FTlRfV0hFUkVfTk9fTEVBRElOR19XSUxEQ0FSRF9MSUtFEBASJQohU1RBVEVNRU5UX0RJU0FMTE9XX09OX0RFTF9DQVNDQURFEBESJQohU1RBVEVNRU5UX0RJU0FMTE9XX1JNX1RCTF9DQVNDQURFEBISHQoZU1RBVEVNRU5UX0RJU0FMTE9XX0NPTU1JVBATEhwKGFNUQVRFTUVOVF9ESVNBTExPV19MSU1JVBAUEh8KG1NUQVRFTUVOVF9ESVNBTExPV19PUkRFUl9CWRAVEh8KG1NUQVRFTUVOVF9NRVJHRV9BTFRFUl9UQUJMRRAWEh4KGlNUQVRFTUVOVF9JTlNFUlRfUk9XX0xJTUlUEBcSKAokU1RBVEVNRU5UX0lOU0VSVF9NVVNUX1NQRUNJRllfQ09MVU1OEBgSKwonU1RBVEVNRU5UX0lOU0VSVF9ESVNBTExPV19PUkRFUl9CWV9SQU5EEBkSIAocU1RBVEVNRU5UX0FGRkVDVEVEX1JPV19MSU1JVBAaEhkKFVNUQVRFTUVOVF9ETUxfRFJZX1JVThAbEi4KKlNUQVRFTUVOVF9ESVNBTExPV19BRERfQ09MVU1OX1dJVEhfREVGQVVMVBAcEiEKHVNUQVRFTUVOVF9BRERfQ0hFQ0tfTk9UX1ZBTElEEB0SJwojU1RBVEVNRU5UX0FERF9GT1JFSUdOX0tFWV9OT1RfVkFMSUQQHhIjCh9TVEFURU1FTlRfRElTQUxMT1dfQUREX05PVF9OVUxMEB8SIwofU1RBVEVNRU5UX0NSRUFURV9TUEVDSUZZX1NDSEVNQRAhEiUKIVNUQVRFTUVOVF9DSEVDS19TRVRfUk9MRV9WQVJJQUJMRRAiEiEKHVNUQVRFTUVOVF9XSEVSRV9OT19FUVVBTF9OVUxMECUSNwozU1RBVEVNRU5UX1dIRVJFX0RJU0FMTE9XX0ZVTkNUSU9OU19BTkRfQ0FMQ1VMQVRJT05TECYSMgouU1RBVEVNRU5UX1dIRVJFX01BWElNVU1fTE9HSUNBTF9PUEVSQVRPUl9DT1VOVBAoEi8KK1NUQVRFTUVOVF9NQVhJTVVNX1NUQVRFTUVOVFNfSU5fVFJBTlNBQ1RJT04QKxIfChtTVEFURU1FTlRfTk9OX1RSQU5TQUNUSU9OQUwQLRIpCiVTVEFURU1FTlRfQUREX0NPTFVNTl9XSVRIT1VUX1BPU0lUSU9OEC4SIgoeU1RBVEVNRU5UX0RJU0FMTE9XX09GRkxJTkVfRERMEC8SJwojU1RBVEVNRU5UX0RJU0FMTE9XX0NST1NTX0RCX1FVRVJJRVMQMBIgChxTVEFURU1FTlRfTUFYX0VYRUNVVElPTl9USU1FEDESJgoiU1RBVEVNRU5UX1JFUVVJUkVfQUxHT1JJVEhNX09QVElPThAyEiEKHVNUQVRFTUVOVF9SRVFVSVJFX0xPQ0tfT1BUSU9OEDMSIAocU1RBVEVNRU5UX09CSkVDVF9PV05FUl9DSEVDSxA0EhQKEFRBQkxFX1JFUVVJUkVfUEsQNRIYChRUQUJMRV9OT19GT1JFSUdOX0tFWRA2EiAKHFRBQkxFX0RST1BfTkFNSU5HX0NPTlZFTlRJT04QNxIRCg1UQUJMRV9DT01NRU5UEDgSHAoYVEFCTEVfRElTQUxMT1dfUEFSVElUSU9OEDkSGgoWVEFCTEVfRElTQUxMT1dfVFJJR0dFUhA6EhwKGFRBQkxFX05PX0RVUExJQ0FURV9JTkRFWBA7EiIKHlRBQkxFX1RFWFRfRklFTERTX1RPVEFMX0xFTkdUSBA8Eh4KGlRBQkxFX0RJU0FMTE9XX1NFVF9DSEFSU0VUED0SFgoSVEFCTEVfRElTQUxMT1dfRERMED4SFgoSVEFCTEVfRElTQUxMT1dfRE1MED8SFAoQVEFCTEVfTElNSVRfU0laRRBAEhkKFVRBQkxFX1JFUVVJUkVfQ0hBUlNFVBBBEhsKF1RBQkxFX1JFUVVJUkVfQ09MTEFUSU9OEEISEwoPQ09MVU1OX1JFUVVJUkVEEEMSEgoOQ09MVU1OX05PX05VTEwQRBIfChtDT0xVTU5fRElTQUxMT1dfQ0hBTkdFX1RZUEUQRRIjCh9DT0xVTU5fU0VUX0RFRkFVTFRfRk9SX05PVF9OVUxMEEYSGgoWQ09MVU1OX0RJU0FMTE9XX0NIQU5HRRBHEiIKHkNPTFVNTl9ESVNBTExPV19DSEFOR0lOR19PUkRFUhBIEhgKFENPTFVNTl9ESVNBTExPV19EUk9QEEkSIQodQ09MVU1OX0RJU0FMTE9XX0RST1BfSU5fSU5ERVgQShISCg5DT0xVTU5fQ09NTUVOVBBLEiYKIkNPTFVNTl9BVVRPX0lOQ1JFTUVOVF9NVVNUX0lOVEVHRVIQTBIdChlDT0xVTU5fVFlQRV9ESVNBTExPV19MSVNUEE0SHwobQ09MVU1OX0RJU0FMTE9XX1NFVF9DSEFSU0VUEE4SIwofQ09MVU1OX01BWElNVU1fQ0hBUkFDVEVSX0xFTkdUSBBPEiEKHUNPTFVNTl9NQVhJTVVNX1ZBUkNIQVJfTEVOR1RIEFASJwojQ09MVU1OX0FVVE9fSU5DUkVNRU5UX0lOSVRJQUxfVkFMVUUQURInCiNDT0xVTU5fQVVUT19JTkNSRU1FTlRfTVVTVF9VTlNJR05FRBBSEiMKH0NPTFVNTl9DVVJSRU5UX1RJTUVfQ09VTlRfTElNSVQQUxIaChZDT0xVTU5fUkVRVUlSRV9ERUZBVUxUEFQSJAogQ09MVU1OX0RFRkFVTFRfRElTQUxMT1dfVk9MQVRJTEUQVRInCiNDT0xVTU5fQUREX05PVF9OVUxMX1JFUVVJUkVfREVGQVVMVBBWEhoKFkNPTFVNTl9SRVFVSVJFX0NIQVJTRVQQVxIcChhDT0xVTU5fUkVRVUlSRV9DT0xMQVRJT04QWBIhCh1TQ0hFTUFfQkFDS1dBUkRfQ09NUEFUSUJJTElUWRBZEiAKHERBVEFCQVNFX0RST1BfRU1QVFlfREFUQUJBU0UQWhIdChlJTkRFWF9OT19EVVBMSUNBVEVfQ09MVU1OEFsSGgoWSU5ERVhfS0VZX05VTUJFUl9MSU1JVBBcEhcKE0lOREVYX1BLX1RZUEVfTElNSVQQXRIWChJJTkRFWF9UWVBFX05PX0JMT0IQXhIcChhJTkRFWF9UT1RBTF9OVU1CRVJfTElNSVQQXxIkCiBJTkRFWF9QUklNQVJZX0tFWV9UWVBFX0FMTE9XTElTVBBgEh0KGUlOREVYX0NSRUFURV9DT05DVVJSRU5UTFkQYRIZChVJTkRFWF9UWVBFX0FMTE9XX0xJU1QQYhIXChNJTkRFWF9OT1RfUkVEVU5EQU5UEGMSHAoYU1lTVEVNX0NIQVJTRVRfQUxMT1dMSVNUEGQSHgoaU1lTVEVNX0NPTExBVElPTl9BTExPV0xJU1QQZRIZChVTWVNURU1fQ09NTUVOVF9MRU5HVEgQZhIkCiBTWVNURU1fUFJPQ0VEVVJFX0RJU0FMTE9XX0NSRUFURRBnEiAKHFNZU1RFTV9FVkVOVF9ESVNBTExPV19DUkVBVEUQaBIfChtTWVNURU1fVklFV19ESVNBTExPV19DUkVBVEUQaRIjCh9TWVNURU1fRlVOQ1RJT05fRElTQUxMT1dfQ1JFQVRFEGoSIwofU1lTVEVNX0ZVTkNUSU9OX0RJU0FMTE9XRURfTElTVBBrEhsKF0FEVklDRV9PTkxJTkVfTUlHUkFUSU9OEGwSHgoaQlVJTFRJTl9QUklPUl9CQUNLVVBfQ0hFQ0sQbRIeChpCVUlMVElOX1dBTEtfVEhST1VHSF9DSEVDSxBuEh8KG1NUQVRFTUVOVF9ESVNBTExPV19UUlVOQ0FURRBvIgQIIBAgIgQIIxAjIgQIJBAkIgQIJxAnIgQIKRApIgQIKhAqIgQILBAsQgkKB3BheWxvYWQy+QYKE1Jldmlld0NvbmZpZ1NlcnZpY2USpwEKEkNyZWF0ZVJldmlld0NvbmZpZxImLmJ5dGViYXNlLnYxLkNyZWF0ZVJldmlld0NvbmZpZ1JlcXVlc3QaGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWciTtpBAIrqMBdiYi5yZXZpZXdDb25maWdzLmNyZWF0ZZDqMAGY6jABgtPkkwIiOg1yZXZpZXdfY29uZmlnIhEvdjEvcmV2aWV3Q29uZmlncxKdAQoRTGlzdFJldmlld0NvbmZpZ3MSJS5ieXRlYmFzZS52MS5MaXN0UmV2aWV3Q29uZmlnc1JlcXVlc3QaJi5ieXRlYmFzZS52MS5MaXN0UmV2aWV3Q29uZmlnc1Jlc3BvbnNlIjnaQQCK6jAVYmIucmV2aWV3Q29uZmlncy5saXN0kOowAYLT5JMCExIRL3YxL3Jldmlld0NvbmZpZ3MSmAEKD0dldFJldmlld0NvbmZpZxIjLmJ5dGViYXNlLnYxLkdldFJldmlld0NvbmZpZ1JlcXVlc3QaGS5ieXRlYmFzZS52MS5SZXZpZXdDb25maWciRdpBBG5hbWWK6jAUYmIucmV2aWV3Q29uZmlncy5nZXSQ6jABgtPkkwIcEhovdjEve25hbWU9cmV2aWV3Q29uZmlncy8qfRLXAQoSVXBkYXRlUmV2aWV3Q29uZmlnEiYuYnl0ZWJhc2UudjEuVXBkYXRlUmV2aWV3Q29uZmlnUmVxdWVzdBoZLmJ5dGViYXNlLnYxLlJldmlld0NvbmZpZyJ+2kEZcmV2aWV3X2NvbmZpZyx1cGRhdGVfbWFza4rqMBdiYi5yZXZpZXdDb25maWdzLnVwZGF0ZZDqMAGY6jABgtPkkwI5Og1yZXZpZXdfY29uZmlnMigvdjEve3Jldmlld19jb25maWcubmFtZT1yZXZpZXdDb25maWdzLyp9EqIBChJEZWxldGVSZXZpZXdDb25maWcSJi5ieXRlYmFzZS52MS5EZWxldGVSZXZpZXdDb25maWdSZXF1ZXN0GhYuZ29vZ2xlLnByb3RvYnVmLkVtcHR5IkzaQQRuYW1liuowF2JiLnJldmlld0NvbmZpZ3MuZGVsZXRlkOowAZjqMAGC0+STAhwqGi92MS97bmFtZT1yZXZpZXdDb25maWdzLyp9Qq4BCg9jb20uYnl0ZWJhc2UudjFCGFJldmlld0NvbmZpZ1NlcnZpY2VQcm90b1ABWjRnaXRodWIuY29tL2J5dGViYXNlL2J5dGViYXNlL2JhY2tlbmQvZ2VuZXJhdGVkLWdvL3YxogIDQlhYqgILQnl0ZWJhc2UuVjHKAgtCeXRlYmFzZVxWMeICF0J5dGViYXNlXFYxXEdQQk1ldGFkYXRh6gIMQnl0ZWJhc2U6OlYxYgZwcm90bzM", [file_buf_validate_validate, file_google_api_annotations, file_google_api_client, file_google_api_field_behavior, file_google_api_resource, file_google_protobuf_empty, file_google_protobuf_field_mask, file_v1_annotation, file_v1_common]);/*** Describes the message bytebase.v1.ListReviewConfigsRequest.diff --git a/frontend/src/types/sql-review-schema.yaml b/frontend/src/types/sql-review-schema.yamlindex 8bb70f3a90..4c13ead82e 100644--- a/frontend/src/types/sql-review-schema.yaml+++ b/frontend/src/types/sql-review-schema.yaml@@ -546,27 +546,12 @@- type: STATEMENT_DISALLOW_ADD_NOT_NULLcategory: STATEMENTengine: POSTGRES-- type: STATEMENT_SELECT_FULL_TABLE_SCAN- category: STATEMENT- engine: MYSQL-- type: STATEMENT_SELECT_FULL_TABLE_SCAN- category: STATEMENT- engine: OCEANBASE-- type: STATEMENT_SELECT_FULL_TABLE_SCAN- category: STATEMENT- engine: MARIADB- type: STATEMENT_CREATE_SPECIFY_SCHEMAcategory: STATEMENTengine: POSTGRES- type: STATEMENT_CHECK_SET_ROLE_VARIABLEcategory: STATEMENTengine: POSTGRES-- type: STATEMENT_DISALLOW_USING_TEMPORARY- category: STATEMENT- engine: MYSQL-- type: STATEMENT_DISALLOW_USING_FILESORT- category: STATEMENT- engine: MYSQL- type: STATEMENT_WHERE_NO_EQUAL_NULLcategory: STATEMENTengine: MYSQL@@ -582,14 +567,6 @@- type: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONScategory: STATEMENTengine: ORACLE-- type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL- category: STATEMENT- componentList:- - key: level- payload:- type: STRING- default: INDEX- engine: MYSQL- type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNTcategory: STATEMENTcomponentList:@@ -598,54 +575,6 @@type: NUMBERdefault: 10engine: MYSQL-- type: STATEMENT_MAXIMUM_LIMIT_VALUE- category: STATEMENT- componentList:- - key: number- payload:- type: NUMBER- default: 1000- engine: MYSQL-- type: STATEMENT_MAXIMUM_LIMIT_VALUE- category: STATEMENT- componentList:- - key: number- payload:- type: NUMBER- default: 1000- engine: OCEANBASE-- type: STATEMENT_MAXIMUM_LIMIT_VALUE- category: STATEMENT- componentList:- - key: number- payload:- type: NUMBER- default: 1000- engine: MARIADB-- type: STATEMENT_MAXIMUM_LIMIT_VALUE- category: STATEMENT- componentList:- - key: number- payload:- type: NUMBER- default: 1000- engine: TIDB-- type: STATEMENT_MAXIMUM_LIMIT_VALUE- category: STATEMENT- componentList:- - key: number- payload:- type: NUMBER- default: 1000- engine: POSTGRES-- type: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT- category: STATEMENT- componentList:- - key: number- payload:- type: NUMBER- default: 2- engine: MYSQL- type: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTIONcategory: STATEMENTcomponentList:@@ -654,9 +583,6 @@type: NUMBERdefault: 10engine: MYSQL-- type: STATEMENT_JOIN_STRICT_COLUMN_ATTRS- category: STATEMENT- engine: MYSQL- type: STATEMENT_ADD_COLUMN_WITHOUT_POSITIONcategory: STATEMENTengine: OCEANBASEdiff --git a/frontend/src/types/sql-review.dev.yaml b/frontend/src/types/sql-review.dev.yamlindex 2241e052af..b65597a6f6 100644--- a/frontend/src/types/sql-review.dev.yaml+++ b/frontend/src/types/sql-review.dev.yaml@@ -410,78 +410,25 @@ ruleList:- type: STATEMENT_DISALLOW_ADD_NOT_NULLlevel: WARNINGengine: POSTGRES- - type: STATEMENT_SELECT_FULL_TABLE_SCAN- level: WARNING- engine: MYSQL- - type: STATEMENT_SELECT_FULL_TABLE_SCAN- level: WARNING- engine: OCEANBASE- - type: STATEMENT_SELECT_FULL_TABLE_SCAN- level: WARNING- engine: MARIADB- type: STATEMENT_CREATE_SPECIFY_SCHEMAlevel: WARNINGengine: POSTGRES- type: STATEMENT_CHECK_SET_ROLE_VARIABLElevel: WARNINGengine: POSTGRES- - type: STATEMENT_DISALLOW_USING_FILESORT- level: WARNING- engine: MYSQL- - type: STATEMENT_DISALLOW_USING_TEMPORARY- level: WARNING- engine: MYSQL- type: STATEMENT_WHERE_NO_EQUAL_NULLlevel: WARNINGengine: MYSQL- - type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL- level: WARNING- payload:- level: INDEX- engine: MYSQL- type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNTlevel: WARNINGpayload:number: 10engine: MYSQL- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: MYSQL- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: OCEANBASE- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: MARIADB- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: TIDB- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: POSTGRES- - type: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT- level: WARNING- payload:- number: 10- engine: MYSQL- type: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTIONlevel: WARNINGpayload:number: 10engine: MYSQL- - type: STATEMENT_JOIN_STRICT_COLUMN_ATTRS- level: WARNING- engine: MYSQL- type: STATEMENT_DISALLOW_CROSS_DB_QUERIESlevel: WARNINGengine: MSSQLdiff --git a/frontend/src/types/sql-review.prod.yaml b/frontend/src/types/sql-review.prod.yamlindex 5b170af978..63c2abfb0f 100644--- a/frontend/src/types/sql-review.prod.yaml+++ b/frontend/src/types/sql-review.prod.yaml@@ -433,27 +433,12 @@ ruleList:- type: STATEMENT_DISALLOW_ADD_NOT_NULLlevel: WARNINGengine: POSTGRES- - type: STATEMENT_SELECT_FULL_TABLE_SCAN- level: ERROR- engine: MYSQL- - type: STATEMENT_SELECT_FULL_TABLE_SCAN- level: ERROR- engine: OCEANBASE- - type: STATEMENT_SELECT_FULL_TABLE_SCAN- level: ERROR- engine: MARIADB- type: STATEMENT_CREATE_SPECIFY_SCHEMAlevel: WARNINGengine: POSTGRES- type: STATEMENT_CHECK_SET_ROLE_VARIABLElevel: WARNINGengine: POSTGRES- - type: STATEMENT_DISALLOW_USING_FILESORT- level: WARNING- engine: MYSQL- - type: STATEMENT_DISALLOW_USING_TEMPORARY- level: WARNING- engine: MYSQL- type: STATEMENT_WHERE_NO_EQUAL_NULLlevel: WARNINGengine: MYSQL@@ -469,54 +454,16 @@ ruleList:- type: STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONSlevel: WARNINGengine: ORACLE- - type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL- level: WARNING- payload:- level: INDEX- engine: MYSQL- type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNTlevel: WARNINGpayload:number: 10engine: MYSQL- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: MYSQL- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: OCEANBASE- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: MARIADB- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: TIDB- - type: STATEMENT_MAXIMUM_LIMIT_VALUE- level: WARNING- payload:- number: 1000- engine: POSTGRES- - type: STATEMENT_MAXIMUM_JOIN_TABLE_COUNT- level: WARNING- payload:- number: 10- engine: MYSQL- type: STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTIONlevel: WARNINGpayload:number: 10engine: MYSQL- - type: STATEMENT_JOIN_STRICT_COLUMN_ATTRS- level: WARNING- engine: MYSQL- type: STATEMENT_ADD_COLUMN_WITHOUT_POSITIONlevel: WARNINGengine: OCEANBASEdiff --git a/frontend/src/types/sqlReview.ts b/frontend/src/types/sqlReview.tsindex b8aa9a489c..adcf05e10e 100644--- a/frontend/src/types/sqlReview.ts+++ b/frontend/src/types/sqlReview.ts@@ -9,7 +9,6 @@ import {SQLReviewRule_NamingRulePayloadSchema,SQLReviewRule_NumberRulePayloadSchema,SQLReviewRule_StringArrayRulePayloadSchema,- SQLReviewRule_StringRulePayloadSchema,SQLReviewRule_Type,SQLReviewRuleSchema,} from "@/types/proto-es/v1/review_config_service_pb";@@ -359,23 +358,6 @@ export const convertPolicyRuleToRuleTemplate = ();switch (ruleTemplate.type) {- case SQLReviewRule_Type.STATEMENT_QUERY_MINIMUM_PLAN_LEVEL:- if (!stringComponent) {- throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);- }-- return {- ...res,- componentList: [- {- ...stringComponent,- payload: {- ...stringComponent.payload,- value: payload.value, // proto field is 'value'- } as StringPayload,- },- ],- };// Following rules require STRING component.case SQLReviewRule_Type.TABLE_DROP_NAMING_CONVENTION:if (!stringComponent) {@@ -566,8 +548,6 @@ export const convertPolicyRuleToRuleTemplate = (case SQLReviewRule_Type.TABLE_TEXT_FIELDS_TOTAL_LENGTH:case SQLReviewRule_Type.TABLE_LIMIT_SIZE:case SQLReviewRule_Type.STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT:- case SQLReviewRule_Type.STATEMENT_MAXIMUM_LIMIT_VALUE:- case SQLReviewRule_Type.STATEMENT_MAXIMUM_JOIN_TABLE_COUNT:case SQLReviewRule_Type.STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION:if (!numberComponent) {throw new Error(`Invalid rule ${ruleTypeToString(ruleTemplate.type)}`);@@ -609,20 +589,6 @@ const mergeIndividualConfigAsRule = ()?.payload as StringArrayPayload | undefined;switch (template.type) {- case SQLReviewRule_Type.STATEMENT_QUERY_MINIMUM_PLAN_LEVEL:- if (!stringPayload) {- throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);- }-- return {- ...base,- payload: {- case: "stringPayload",- value: create(SQLReviewRule_StringRulePayloadSchema, {- value: stringPayload.value ?? stringPayload.default,- }),- },- };// Following rules require STRING component.case SQLReviewRule_Type.TABLE_DROP_NAMING_CONVENTION:if (!stringPayload) {@@ -759,8 +725,6 @@ const mergeIndividualConfigAsRule = (case SQLReviewRule_Type.TABLE_TEXT_FIELDS_TOTAL_LENGTH:case SQLReviewRule_Type.TABLE_LIMIT_SIZE:case SQLReviewRule_Type.STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT:- case SQLReviewRule_Type.STATEMENT_MAXIMUM_LIMIT_VALUE:- case SQLReviewRule_Type.STATEMENT_MAXIMUM_JOIN_TABLE_COUNT:case SQLReviewRule_Type.STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION:if (!numberPayload) {throw new Error(`Invalid rule ${ruleTypeToString(template.type)}`);diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yamlindex 311335527a..729a3c6eb1 100644--- a/proto/gen/grpc-doc/openapi.yaml+++ b/proto/gen/grpc-doc/openapi.yaml@@ -25276,19 +25276,12 @@ components:- STATEMENT_ADD_CHECK_NOT_VALID- STATEMENT_ADD_FOREIGN_KEY_NOT_VALID- STATEMENT_DISALLOW_ADD_NOT_NULL- - STATEMENT_SELECT_FULL_TABLE_SCAN- STATEMENT_CREATE_SPECIFY_SCHEMA- STATEMENT_CHECK_SET_ROLE_VARIABLE- - STATEMENT_DISALLOW_USING_FILESORT- - STATEMENT_DISALLOW_USING_TEMPORARY- STATEMENT_WHERE_NO_EQUAL_NULL- STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS- - STATEMENT_QUERY_MINIMUM_PLAN_LEVEL- STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT- - STATEMENT_MAXIMUM_LIMIT_VALUE- - STATEMENT_MAXIMUM_JOIN_TABLE_COUNT- STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION- - STATEMENT_JOIN_STRICT_COLUMN_ATTRS- STATEMENT_NON_TRANSACTIONAL- STATEMENT_ADD_COLUMN_WITHOUT_POSITION- STATEMENT_DISALLOW_OFFLINE_DDLdiff --git a/proto/gen/grpc-doc/store/README.md b/proto/gen/grpc-doc/store/README.mdindex 8042dd38b5..cf8e93b048 100644--- a/proto/gen/grpc-doc/store/README.md+++ b/proto/gen/grpc-doc/store/README.md@@ -3902,19 +3902,12 @@ The severity level for SQL review rules.| STATEMENT_ADD_CHECK_NOT_VALID | 29 | || STATEMENT_ADD_FOREIGN_KEY_NOT_VALID | 30 | || STATEMENT_DISALLOW_ADD_NOT_NULL | 31 | |-| STATEMENT_SELECT_FULL_TABLE_SCAN | 32 | || STATEMENT_CREATE_SPECIFY_SCHEMA | 33 | || STATEMENT_CHECK_SET_ROLE_VARIABLE | 34 | |-| STATEMENT_DISALLOW_USING_FILESORT | 35 | |-| STATEMENT_DISALLOW_USING_TEMPORARY | 36 | || STATEMENT_WHERE_NO_EQUAL_NULL | 37 | || STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS | 38 | |-| STATEMENT_QUERY_MINIMUM_PLAN_LEVEL | 39 | || STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT | 40 | |-| STATEMENT_MAXIMUM_LIMIT_VALUE | 41 | |-| STATEMENT_MAXIMUM_JOIN_TABLE_COUNT | 42 | || STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION | 43 | |-| STATEMENT_JOIN_STRICT_COLUMN_ATTRS | 44 | || STATEMENT_NON_TRANSACTIONAL | 45 | || STATEMENT_ADD_COLUMN_WITHOUT_POSITION | 46 | || STATEMENT_DISALLOW_OFFLINE_DDL | 47 | |diff --git a/proto/gen/grpc-doc/store/index.html b/proto/gen/grpc-doc/store/index.htmlindex 89789d76e1..b54611c30d 100644--- a/proto/gen/grpc-doc/store/index.html+++ b/proto/gen/grpc-doc/store/index.html@@ -10848,12 +10848,6 @@ IM integration setting should be set for this function to work. </p></td><td><p></p></td></tr>- <tr>- <td>STATEMENT_SELECT_FULL_TABLE_SCAN</td>- <td>32</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_CREATE_SPECIFY_SCHEMA</td><td>33</td>@@ -10866,18 +10860,6 @@ IM integration setting should be set for this function to work. </p></td><td><p></p></td></tr>- <tr>- <td>STATEMENT_DISALLOW_USING_FILESORT</td>- <td>35</td>- <td><p></p></td>- </tr>-- <tr>- <td>STATEMENT_DISALLOW_USING_TEMPORARY</td>- <td>36</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_WHERE_NO_EQUAL_NULL</td><td>37</td>@@ -10890,42 +10872,18 @@ IM integration setting should be set for this function to work. </p></td><td><p></p></td></tr>- <tr>- <td>STATEMENT_QUERY_MINIMUM_PLAN_LEVEL</td>- <td>39</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT</td><td>40</td><td><p></p></td></tr>- <tr>- <td>STATEMENT_MAXIMUM_LIMIT_VALUE</td>- <td>41</td>- <td><p></p></td>- </tr>-- <tr>- <td>STATEMENT_MAXIMUM_JOIN_TABLE_COUNT</td>- <td>42</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION</td><td>43</td><td><p></p></td></tr>- <tr>- <td>STATEMENT_JOIN_STRICT_COLUMN_ATTRS</td>- <td>44</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_NON_TRANSACTIONAL</td><td>45</td>diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.mdindex 09c83bbf81..21bc41d329 100644--- a/proto/gen/grpc-doc/v1/README.md+++ b/proto/gen/grpc-doc/v1/README.md@@ -10462,19 +10462,12 @@ The severity level for SQL review rules.| STATEMENT_ADD_CHECK_NOT_VALID | 29 | || STATEMENT_ADD_FOREIGN_KEY_NOT_VALID | 30 | || STATEMENT_DISALLOW_ADD_NOT_NULL | 31 | |-| STATEMENT_SELECT_FULL_TABLE_SCAN | 32 | || STATEMENT_CREATE_SPECIFY_SCHEMA | 33 | || STATEMENT_CHECK_SET_ROLE_VARIABLE | 34 | |-| STATEMENT_DISALLOW_USING_FILESORT | 35 | |-| STATEMENT_DISALLOW_USING_TEMPORARY | 36 | || STATEMENT_WHERE_NO_EQUAL_NULL | 37 | || STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS | 38 | |-| STATEMENT_QUERY_MINIMUM_PLAN_LEVEL | 39 | || STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT | 40 | |-| STATEMENT_MAXIMUM_LIMIT_VALUE | 41 | |-| STATEMENT_MAXIMUM_JOIN_TABLE_COUNT | 42 | || STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION | 43 | |-| STATEMENT_JOIN_STRICT_COLUMN_ATTRS | 44 | || STATEMENT_NON_TRANSACTIONAL | 45 | || STATEMENT_ADD_COLUMN_WITHOUT_POSITION | 46 | || STATEMENT_DISALLOW_OFFLINE_DDL | 47 | |diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.htmlindex b681c46aff..b9ab3d94b8 100644--- a/proto/gen/grpc-doc/v1/index.html+++ b/proto/gen/grpc-doc/v1/index.html@@ -29441,12 +29441,6 @@ In this situation, `update_mask` is ignored. </p></td><td><p></p></td></tr>- <tr>- <td>STATEMENT_SELECT_FULL_TABLE_SCAN</td>- <td>32</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_CREATE_SPECIFY_SCHEMA</td><td>33</td>@@ -29459,18 +29453,6 @@ In this situation, `update_mask` is ignored. </p></td><td><p></p></td></tr>- <tr>- <td>STATEMENT_DISALLOW_USING_FILESORT</td>- <td>35</td>- <td><p></p></td>- </tr>-- <tr>- <td>STATEMENT_DISALLOW_USING_TEMPORARY</td>- <td>36</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_WHERE_NO_EQUAL_NULL</td><td>37</td>@@ -29483,42 +29465,18 @@ In this situation, `update_mask` is ignored. </p></td><td><p></p></td></tr>- <tr>- <td>STATEMENT_QUERY_MINIMUM_PLAN_LEVEL</td>- <td>39</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT</td><td>40</td><td><p></p></td></tr>- <tr>- <td>STATEMENT_MAXIMUM_LIMIT_VALUE</td>- <td>41</td>- <td><p></p></td>- </tr>-- <tr>- <td>STATEMENT_MAXIMUM_JOIN_TABLE_COUNT</td>- <td>42</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION</td><td>43</td><td><p></p></td></tr>- <tr>- <td>STATEMENT_JOIN_STRICT_COLUMN_ATTRS</td>- <td>44</td>- <td><p></p></td>- </tr>-<tr><td>STATEMENT_NON_TRANSACTIONAL</td><td>45</td>diff --git a/proto/store/store/review_config.proto b/proto/store/store/review_config.protoindex 95974aab37..000f4ab058 100644--- a/proto/store/store/review_config.proto+++ b/proto/store/store/review_config.proto@@ -81,19 +81,19 @@ message SQLReviewRule {STATEMENT_ADD_CHECK_NOT_VALID = 29;STATEMENT_ADD_FOREIGN_KEY_NOT_VALID = 30;STATEMENT_DISALLOW_ADD_NOT_NULL = 31;- STATEMENT_SELECT_FULL_TABLE_SCAN = 32;+ reserved 32; // was STATEMENT_SELECT_FULL_TABLE_SCANSTATEMENT_CREATE_SPECIFY_SCHEMA = 33;STATEMENT_CHECK_SET_ROLE_VARIABLE = 34;- STATEMENT_DISALLOW_USING_FILESORT = 35;- STATEMENT_DISALLOW_USING_TEMPORARY = 36;+ reserved 35; // was STATEMENT_DISALLOW_USING_FILESORT+ reserved 36; // was STATEMENT_DISALLOW_USING_TEMPORARYSTATEMENT_WHERE_NO_EQUAL_NULL = 37;STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38;- STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39;+ reserved 39; // was STATEMENT_QUERY_MINIMUM_PLAN_LEVELSTATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40;- STATEMENT_MAXIMUM_LIMIT_VALUE = 41;- STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42;+ reserved 41; // was STATEMENT_MAXIMUM_LIMIT_VALUE+ reserved 42; // was STATEMENT_MAXIMUM_JOIN_TABLE_COUNTSTATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43;- STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44;+ reserved 44; // was STATEMENT_JOIN_STRICT_COLUMN_ATTRSSTATEMENT_NON_TRANSACTIONAL = 45;STATEMENT_ADD_COLUMN_WITHOUT_POSITION = 46;STATEMENT_DISALLOW_OFFLINE_DDL = 47;diff --git a/proto/v1/v1/review_config_service.proto b/proto/v1/v1/review_config_service.protoindex afe356e72d..fbe22edb8e 100644--- a/proto/v1/v1/review_config_service.proto+++ b/proto/v1/v1/review_config_service.proto@@ -212,19 +212,19 @@ message SQLReviewRule {STATEMENT_ADD_CHECK_NOT_VALID = 29;STATEMENT_ADD_FOREIGN_KEY_NOT_VALID = 30;STATEMENT_DISALLOW_ADD_NOT_NULL = 31;- STATEMENT_SELECT_FULL_TABLE_SCAN = 32;+ reserved 32; // was STATEMENT_SELECT_FULL_TABLE_SCANSTATEMENT_CREATE_SPECIFY_SCHEMA = 33;STATEMENT_CHECK_SET_ROLE_VARIABLE = 34;- STATEMENT_DISALLOW_USING_FILESORT = 35;- STATEMENT_DISALLOW_USING_TEMPORARY = 36;+ reserved 35; // was STATEMENT_DISALLOW_USING_FILESORT+ reserved 36; // was STATEMENT_DISALLOW_USING_TEMPORARYSTATEMENT_WHERE_NO_EQUAL_NULL = 37;STATEMENT_WHERE_DISALLOW_FUNCTIONS_AND_CALCULATIONS = 38;- STATEMENT_QUERY_MINIMUM_PLAN_LEVEL = 39;+ reserved 39; // was STATEMENT_QUERY_MINIMUM_PLAN_LEVELSTATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT = 40;- STATEMENT_MAXIMUM_LIMIT_VALUE = 41;- STATEMENT_MAXIMUM_JOIN_TABLE_COUNT = 42;+ reserved 41; // was STATEMENT_MAXIMUM_LIMIT_VALUE+ reserved 42; // was STATEMENT_MAXIMUM_JOIN_TABLE_COUNTSTATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION = 43;- STATEMENT_JOIN_STRICT_COLUMN_ATTRS = 44;+ reserved 44; // was STATEMENT_JOIN_STRICT_COLUMN_ATTRSSTATEMENT_NON_TRANSACTIONAL = 45;STATEMENT_ADD_COLUMN_WITHOUT_POSITION = 46;STATEMENT_DISALLOW_OFFLINE_DDL = 47;