Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: correct SQL review payload migration for STATEMENT_QUERY_MINIMUM_PLAN_LEVEL and COLUMN_CURRENT_TIME_COUNT_LIMIT (#18431)

Danny Xu48ec206b87cf
diff --git a/backend/migrator/migration/3.13/0018##migrate_review_config_payload_to_proto.sql b/backend/migrator/migration/3.13/0018##migrate_review_config_payload_to_proto.sql
index 8eef71b2d0..4ce4734f22 100644
--- a/backend/migrator/migration/3.13/0018##migrate_review_config_payload_to_proto.sql
+++ b/backend/migrator/migration/3.13/0018##migrate_review_config_payload_to_proto.sql
@@ -30,9 +30,8 @@ BEGIN
'STATEMENT_INSERT_ROW_LIMIT', 'STATEMENT_AFFECTED_ROW_LIMIT',
'STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT', 'STATEMENT_MAXIMUM_LIMIT_VALUE',
'STATEMENT_MAXIMUM_JOIN_TABLE_COUNT', 'STATEMENT_MAXIMUM_STATEMENTS_IN_TRANSACTION',
- 'STATEMENT_MAX_EXECUTION_TIME', 'STATEMENT_QUERY_MINIMUM_PLAN_LEVEL',
'COLUMN_MAXIMUM_CHARACTER_LENGTH', 'COLUMN_MAXIMUM_VARCHAR_LENGTH',
- 'COLUMN_AUTO_INCREMENT_INITIAL_VALUE', 'COLUMN_CURRENT_TIME_COUNT_LIMIT',
+ 'COLUMN_AUTO_INCREMENT_INITIAL_VALUE',
'INDEX_KEY_NUMBER_LIMIT', 'INDEX_TOTAL_NUMBER_LIMIT',
'TABLE_TEXT_FIELDS_TOTAL_LENGTH', 'TABLE_LIMIT_SIZE', 'SYSTEM_COMMENT_LENGTH'
) AND rule->>'payload' IS NOT NULL AND rule->>'payload' != '' AND rule->>'payload' != 'null' AND rule->>'payload' != '{}'
@@ -57,16 +56,17 @@ BEGIN
AND rule->>'payload' IS NOT NULL AND rule->>'payload' != '' AND rule->>'payload' != 'null' AND rule->>'payload' != '{}'
THEN jsonb_set(rule, '{namingCasePayload}', (rule->>'payload')::jsonb) - 'payload'
- -- String rule: parse JSON string, rename field from "string" to "value", and wrap in stringPayload
- WHEN (rule->>'type') = 'NAMING_FULLY_QUALIFIED'
+ -- String rule: parse JSON string, extract "level" field (or default to INDEX), and wrap in stringPayload
+ WHEN (rule->>'type') = 'STATEMENT_QUERY_MINIMUM_PLAN_LEVEL'
AND rule->>'payload' IS NOT NULL AND rule->>'payload' != '' AND rule->>'payload' != 'null' AND rule->>'payload' != '{}'
THEN jsonb_set(
rule,
'{stringPayload}',
- jsonb_build_object('value', (rule->>'payload')::jsonb->>'string')
+ jsonb_build_object('value', COALESCE((rule->>'payload')::jsonb->>'level', 'INDEX'))
) - 'payload'
- -- Rules with empty/null payload or already migrated - remove payload field
+ -- Rules with empty/null payload or no payload (like NAMING_FULLY_QUALIFIED,
+ -- STATEMENT_MAX_EXECUTION_TIME, COLUMN_CURRENT_TIME_COUNT_LIMIT) - just remove payload field
ELSE rule - 'payload'
END
)
diff --git a/frontend/src/types/sql-review.dev.yaml b/frontend/src/types/sql-review.dev.yaml
index 205c620f4e..5781409c10 100644
--- a/frontend/src/types/sql-review.dev.yaml
+++ b/frontend/src/types/sql-review.dev.yaml
@@ -419,8 +419,7 @@ ruleList:
- type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL
level: WARNING
payload:
- required: true
- maxLength: 64
+ level: INDEX
engine: MYSQL
- type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
level: WARNING
@@ -1063,23 +1062,15 @@ ruleList:
engine: MARIADB
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: MYSQL
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: TIDB
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: OCEANBASE
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: MARIADB
- type: COLUMN_REQUIRE_DEFAULT
level: WARNING
diff --git a/frontend/src/types/sql-review.prod.yaml b/frontend/src/types/sql-review.prod.yaml
index 07b2ba8fd9..32eda8365c 100644
--- a/frontend/src/types/sql-review.prod.yaml
+++ b/frontend/src/types/sql-review.prod.yaml
@@ -460,8 +460,7 @@ ruleList:
- type: STATEMENT_QUERY_MINIMUM_PLAN_LEVEL
level: WARNING
payload:
- required: true
- maxLength: 64
+ level: INDEX
engine: MYSQL
- type: STATEMENT_WHERE_MAXIMUM_LOGICAL_OPERATOR_COUNT
level: WARNING
@@ -1143,23 +1142,15 @@ ruleList:
engine: MARIADB
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: MYSQL
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: TIDB
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: OCEANBASE
- type: COLUMN_CURRENT_TIME_COUNT_LIMIT
level: WARNING
- payload:
- number: 1000
engine: MARIADB
- type: COLUMN_REQUIRE_DEFAULT
level: WARNING