Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: iam check should consider the expire time (#19411)
ecmadao4a555fbd214b
diff --git a/backend/component/iam/manager.go b/backend/component/iam/manager.goindex ab34918d52..4c1fa198ba 100644--- a/backend/component/iam/manager.go+++ b/backend/component/iam/manager.go@@ -12,6 +12,7 @@ import ("github.com/bytebase/bytebase/backend/enterprise"storepb "github.com/bytebase/bytebase/backend/generated-go/store""github.com/bytebase/bytebase/backend/store"+ "github.com/bytebase/bytebase/backend/utils")type Manager struct {@@ -102,6 +103,9 @@ func check(user *store.UserMessage, p permission.Permission, policy *storepb.IamuserName := formatUserNameByType(user)for _, binding := range policy.GetBindings() {+ if !utils.ValidateIAMBinding(binding) {+ continue+ }permissions := getPermissions(binding.GetRole())if permissions == nil {continuediff --git a/backend/utils/member.go b/backend/utils/member.goindex 851292372c..b81e7b8a46 100644--- a/backend/utils/member.go+++ b/backend/utils/member.go@@ -15,7 +15,8 @@ import ("github.com/bytebase/bytebase/backend/store")-func validateIAMBinding(binding *storepb.Binding) bool {+// ValidateIAMBinding checks if the binding's condition expression is still valid (e.g., not expired).+func ValidateIAMBinding(binding *storepb.Binding) bool {ok, err := common.EvalBindingCondition(binding.Condition.GetExpression(), time.Now())if err != nil {slog.Error("failed to eval binding condition", slog.String("expression", binding.Condition.GetExpression()), log.BBError(err))@@ -47,7 +48,7 @@ func GetUsersByRoleInIAMPolicy(ctx context.Context, stores *store.Store, role stcontinue}- if !validateIAMBinding(binding) {+ if !ValidateIAMBinding(binding) {continue}@@ -188,7 +189,7 @@ func GetUserIAMPolicyBindings(ctx context.Context, stores *store.Store, user *stfor _, policy := range policies {for _, binding := range policy.Bindings {- if !validateIAMBinding(binding) {+ if !ValidateIAMBinding(binding) {continue}