Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(parser): fix data masking bypass via table.* in JOIN queries (#19156)

Vincent Huang512222d0e611
diff --git a/backend/plugin/parser/pg/query_span_extractor.go b/backend/plugin/parser/pg/query_span_extractor.go
index 26749a0e3d..b45d153a6f 100644
--- a/backend/plugin/parser/pg/query_span_extractor.go
+++ b/backend/plugin/parser/pg/query_span_extractor.go
@@ -2814,15 +2814,15 @@ func (q *querySpanExtractor) getColumnsFromColumnRef(ctx postgresql.IColumnrefCo
// Return empty set as this should be handled by star expansion logic
switch len(parts) {
case 1:
- // table.* case
- columnName = ""
+ // table.* case - columnName contains the table name from Colid()
tableName = columnName
+ columnName = ""
schemaName = ""
case 2:
- // schema.table.* case
- columnName = ""
+ // schema.table.* case - columnName contains the schema name from Colid()
schemaName = columnName
tableName = parts[0]
+ columnName = ""
default:
// More complex indirection with star, ignore
return []base.QuerySpanResult{}, nil
diff --git a/backend/plugin/parser/pg/test-data/query_span.yaml b/backend/plugin/parser/pg/test-data/query_span.yaml
index ca1ba356df..2b19ddc978 100644
--- a/backend/plugin/parser/pg/test-data/query_span.yaml
+++ b/backend/plugin/parser/pg/test-data/query_span.yaml
@@ -2805,3 +2805,108 @@
results: []
sourcecolumns: []
predicatecolumns: []
+- description: Test table.* with JOIN on different tables for masking
+ statement: SELECT users.*, payments.* FROM users JOIN payments ON users.id = payments.user_id;
+ defaultDatabase: db
+ metadata: |-
+ {
+ "name": "db",
+ "schemas": [
+ {
+ "name": "public",
+ "tables": [
+ {
+ "name": "users",
+ "columns": [
+ {"name": "id"},
+ {"name": "name"},
+ {"name": "email"}
+ ]
+ },
+ {
+ "name": "payments",
+ "columns": [
+ {"name": "id"},
+ {"name": "user_id"},
+ {"name": "amount"}
+ ]
+ }
+ ]
+ }
+ ]
+ }
+ querySpan:
+ type: 1
+ results:
+ - name: id
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: users
+ column: id
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: name
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: users
+ column: name
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: email
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: users
+ column: email
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: id
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: payments
+ column: id
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: user_id
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: payments
+ column: user_id
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ - name: amount
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: payments
+ column: amount
+ isplainfield: true
+ sourcefieldpaths: []
+ selectasterisk: false
+ sourcecolumns:
+ - server: ""
+ database: db
+ schema: public
+ table: payments
+ column: ""
+ - server: ""
+ database: db
+ schema: public
+ table: users
+ column: ""
+ predicatecolumns: []
diff --git a/backend/plugin/parser/redshift/query_span_extractor.go b/backend/plugin/parser/redshift/query_span_extractor.go
index 3f0e0ffd10..316aeb28a0 100644
--- a/backend/plugin/parser/redshift/query_span_extractor.go
+++ b/backend/plugin/parser/redshift/query_span_extractor.go
@@ -2760,15 +2760,15 @@ func (q *querySpanExtractor) getColumnsFromColumnRef(ctx parser.IColumnrefContex
// Return empty set as this should be handled by star expansion logic
switch len(parts) {
case 1:
- // table.* case
- columnName = ""
+ // table.* case - columnName contains the table name from Colid()
tableName = columnName
+ columnName = ""
schemaName = ""
case 2:
- // schema.table.* case
- columnName = ""
+ // schema.table.* case - columnName contains the schema name from Colid()
schemaName = columnName
tableName = parts[0]
+ columnName = ""
default:
// More complex indirection with star, ignore
return []base.QuerySpanResult{}, nil