Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: remove approval flow edit button from Rules tab (#17758)

Danny Xu515fdb5ea769
diff --git a/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesPanel.vue b/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesPanel.vue
index 64131cd748..7b0c0c11ab 100644
--- a/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesPanel.vue
+++ b/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesPanel.vue
@@ -1,32 +1,16 @@
<template>
- <div class="w-full">
- <RiskFilter :hide-search="true" />
-
- <div class="space-y-4 my-4">
- <RulesSection
- v-for="source in selectedSourceList"
- :key="source"
- :source="source"
- />
- </div>
+ <div class="w-full space-y-4">
+ <RulesSection
+ v-for="source in supportedSourceList"
+ :key="source"
+ :source="source"
+ />
</div>
</template>
<script lang="ts" setup>
-import { computed } from "vue";
import { useSupportedSourceList } from "@/types";
-import { Risk_Source } from "@/types/proto-es/v1/risk_service_pb";
-import { RiskFilter, useRiskFilter } from "../../common";
import RulesSection from "./RulesSection.vue";
-const filter = useRiskFilter();
const supportedSourceList = useSupportedSourceList();
-
-const selectedSourceList = computed(() => {
- if (filter.source.value === Risk_Source.SOURCE_UNSPECIFIED) {
- // "ALL"
- return supportedSourceList.value;
- }
- return [filter.source.value];
-});
</script>
diff --git a/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue b/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue
index 7f0c9a06ed..14e98c85a7 100644
--- a/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue
+++ b/frontend/src/components/CustomApproval/Settings/components/CustomApproval/RulesPanel/RulesSection.vue
@@ -61,7 +61,6 @@ const columns = computed((): DataTableColumn<Row>[] => {
<RuleSelect
class="flex-1 max-w-md min-w-[10rem]"
value={row.rule}
- link={true}
onUpdate={(rule: string | undefined) => updateRow(row, rule)}
/>
<RiskTips level={row.level} source={props.source} rule={row.rule} />