Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix: satisfy Cloud SQL sample password complexity (#21380)

p0ny5260538311fd
diff --git a/backend/component/sample/saas/manager.go b/backend/component/sample/saas/manager.go
index 6e19ac6bcf..c135bc1b8f 100644
--- a/backend/component/sample/saas/manager.go
+++ b/backend/component/sample/saas/manager.go
@@ -538,7 +538,8 @@ func randomPassword(reader io.Reader) (string, error) {
if _, err := io.ReadFull(reader, value); err != nil {
return "", err
}
- return base64.RawURLEncoding.EncodeToString(value), nil
+ // Satisfy Cloud SQL password complexity without reducing the random entropy.
+ return "Aa0!" + base64.RawURLEncoding.EncodeToString(value), nil
}
func randomInstanceID(reader io.Reader) (string, error) {
diff --git a/backend/component/sample/saas/manager_test.go b/backend/component/sample/saas/manager_test.go
index 3cf94c8cce..ddbf13b945 100644
--- a/backend/component/sample/saas/manager_test.go
+++ b/backend/component/sample/saas/manager_test.go
@@ -1,14 +1,39 @@
package saas
import (
+ "bytes"
"context"
+ "io"
"testing"
+ "unicode"
"github.com/stretchr/testify/require"
"github.com/bytebase/bytebase/backend/component/sample"
)
+func TestRandomPasswordMeetsCloudSQLComplexity(t *testing.T) {
+ for _, value := range []byte{0, 0xff, 'x'} {
+ password, err := randomPassword(bytes.NewReader(bytes.Repeat([]byte{value}, 32)))
+ require.NoError(t, err)
+ var lower, upper, digit, symbol bool
+ for _, char := range password {
+ lower = lower || unicode.IsLower(char)
+ upper = upper || unicode.IsUpper(char)
+ digit = digit || unicode.IsDigit(char)
+ symbol = symbol || (!unicode.IsLetter(char) && !unicode.IsDigit(char))
+ }
+ require.True(t, lower && upper && digit && symbol, "password must satisfy Cloud SQL complexity for input byte %d", value)
+ require.GreaterOrEqual(t, len(password), 43)
+ }
+}
+
+func TestRandomPasswordRequiresFullEntropy(t *testing.T) {
+ password, err := randomPassword(bytes.NewReader(make([]byte, 31)))
+ require.ErrorIs(t, err, io.ErrUnexpectedEOF)
+ require.Empty(t, password)
+}
+
func TestCheckAvailableRejectsUnconfiguredManager(t *testing.T) {
var manager *Manager
err := manager.CheckAvailable(context.Background())