Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(tidb): honor IF [NOT] EXISTS in walk-through DDL simulation (#20169)
h3n4l558c962c922c
diff --git a/backend/plugin/schema/tidb/testdata/walk_through.yaml b/backend/plugin/schema/tidb/testdata/walk_through.yamlindex 378f5c844f..8e2c3348e7 100644--- a/backend/plugin/schema/tidb/testdata/walk_through.yaml+++ b/backend/plugin/schema/tidb/testdata/walk_through.yaml@@ -465,3 +465,180 @@\ \"visible\": true\n }\n ]\n }\n ]\n }\n\\ ]\n}"advice: null+- statement: |+ CREATE TABLE t(a int);+ ALTER TABLE t ADD COLUMN IF NOT EXISTS a int;+ ignore_case_sensitive: false+ want: |-+ {+ "name": "test",+ "schemas": [+ {+ "tables": [+ {+ "name": "t",+ "columns": [+ {+ "name": "a",+ "position": 1,+ "nullable": true,+ "type": "int(11)"+ }+ ]+ }+ ]+ }+ ]+ }+ advice: null+- statement: |+ CREATE TABLE t(a int);+ ALTER TABLE t ADD COLUMN a int;+ ignore_case_sensitive: false+ want: ''+ advice:+ status: 1+ code: 412+ title: Column `a` already exists in table `t`+ content: Column `a` already exists in table `t`+ startPosition:+ line: 0+- statement: |+ CREATE TABLE t(a int);+ ALTER TABLE t DROP COLUMN IF EXISTS b;+ ignore_case_sensitive: false+ want: |-+ {+ "name": "test",+ "schemas": [+ {+ "tables": [+ {+ "name": "t",+ "columns": [+ {+ "name": "a",+ "position": 1,+ "nullable": true,+ "type": "int(11)"+ }+ ]+ }+ ]+ }+ ]+ }+ advice: null+- statement: |+ CREATE TABLE t(a int);+ ALTER TABLE t DROP INDEX IF EXISTS idx_nonexistent;+ ignore_case_sensitive: false+ want: |-+ {+ "name": "test",+ "schemas": [+ {+ "tables": [+ {+ "name": "t",+ "columns": [+ {+ "name": "a",+ "position": 1,+ "nullable": true,+ "type": "int(11)"+ }+ ]+ }+ ]+ }+ ]+ }+ advice: null+- statement: |+ CREATE TABLE t(a int);+ CREATE INDEX idx_a ON t(a);+ CREATE INDEX IF NOT EXISTS idx_a ON t(a);+ ignore_case_sensitive: false+ want: |-+ {+ "name": "test",+ "schemas": [+ {+ "tables": [+ {+ "name": "t",+ "columns": [+ {+ "name": "a",+ "position": 1,+ "nullable": true,+ "type": "int(11)"+ }+ ],+ "indexes": [+ {+ "name": "idx_a",+ "expressions": [+ "a"+ ],+ "type": "BTREE",+ "visible": true+ }+ ]+ }+ ]+ }+ ]+ }+ advice: null+- statement: |+ CREATE TABLE t(a int);+ CREATE INDEX idx_a ON t(a);+ CREATE INDEX idx_a ON t(a);+ ignore_case_sensitive: false+ want: ''+ advice:+ status: 1+ code: 805+ title: Index `idx_a` already exists in table `t`+ content: Index `idx_a` already exists in table `t`+ startPosition:+ line: 0+- statement: |+ CREATE TABLE t(a int);+ CREATE INDEX idx_a ON t(a);+ ALTER TABLE t ADD INDEX IF NOT EXISTS idx_a (a);+ ignore_case_sensitive: false+ want: |-+ {+ "name": "test",+ "schemas": [+ {+ "tables": [+ {+ "name": "t",+ "columns": [+ {+ "name": "a",+ "position": 1,+ "nullable": true,+ "type": "int(11)"+ }+ ],+ "indexes": [+ {+ "name": "idx_a",+ "expressions": [+ "a"+ ],+ "type": "BTREE",+ "visible": true+ }+ ]+ }+ ]+ }+ ]+ }+ advice: nulldiff --git a/backend/plugin/schema/tidb/walk_through.go b/backend/plugin/schema/tidb/walk_through.goindex e11d0ba83f..da1eac0728 100644--- a/backend/plugin/schema/tidb/walk_through.go+++ b/backend/plugin/schema/tidb/walk_through.go@@ -319,6 +319,10 @@ func tidbHandleCreateIndex(d *model.DatabaseMetadata, node *tidbast.CreateIndexSreturn err}+ if node.IfNotExists && node.IndexName != "" && table.GetIndex(node.IndexName) != nil {+ return nil+ }+unique := falsetp := tidbast.IndexTypeBtree.String()isSpatial := false@@ -367,6 +371,9 @@ func tidbAlterTable(d *model.DatabaseMetadata, node *tidbast.AlterTableStmt) *st}case tidbast.AlterTableAddColumns:for _, column := range spec.NewColumns {+ if spec.IfNotExists && table.GetColumn(column.Name.Name.L) != nil {+ continue+ }var pos *tidbast.ColumnPositionif len(spec.NewColumns) == 1 {pos = spec.Position@@ -396,6 +403,9 @@ func tidbAlterTable(d *model.DatabaseMetadata, node *tidbast.AlterTableStmt) *stcol.Position = int32(i + 1)}case tidbast.AlterTableAddConstraint:+ if spec.Constraint != nil && spec.Constraint.IfNotExists && spec.Constraint.Name != "" && table.GetIndex(spec.Constraint.Name) != nil {+ continue+ }if err := tidbCreateConstraint(table, spec.Constraint); err != nil {return err}@@ -403,6 +413,9 @@ func tidbAlterTable(d *model.DatabaseMetadata, node *tidbast.AlterTableStmt) *stcolumnName := spec.OldColumnName.Name.O// Validate column existsif table.GetColumn(columnName) == nil {+ if spec.IfExists {+ continue+ }content := fmt.Sprintf("Column `%s` does not exist in table `%s`", columnName, table.GetProto().Name)return &storepb.Advice{Status: storepb.Advice_ERROR,@@ -433,6 +446,9 @@ func tidbAlterTable(d *model.DatabaseMetadata, node *tidbast.AlterTableStmt) *st}}case tidbast.AlterTableDropIndex:+ if spec.IfExists && table.GetIndex(spec.Name) == nil {+ continue+ }if err := table.DropIndex(spec.Name); err != nil {return &storepb.Advice{Status: storepb.Advice_ERROR,diff --git a/backend/plugin/schema/tidb/walk_through_test.go b/backend/plugin/schema/tidb/walk_through_test.goindex de779eb9ff..4ef01803e2 100644--- a/backend/plugin/schema/tidb/walk_through_test.go+++ b/backend/plugin/schema/tidb/walk_through_test.go@@ -56,9 +56,9 @@ func TestWalkThrough(t *testing.T) {asts := base.ExtractASTs(stmts)advice := WalkThrough(state, asts)if advice != nil {- // Compare the advice fields- require.Equal(t, test.Advice.Code, advice.Code)- require.Equal(t, test.Advice.Content, advice.Content)+ require.NotNil(t, test.Advice, "unexpected advice for statement %q: %+v", test.Statement, advice)+ require.Equal(t, test.Advice.Code, advice.Code, "statement %q", test.Statement)+ require.Equal(t, test.Advice.Content, advice.Content, "statement %q", test.Statement)continue}