Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix(frontend): differentiate tags and actions between plan and issue pages (#18709)
boojack5eab02d7f34c
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.tsindex 8564a4fc53..06b5c0c305 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts@@ -1,4 +1,5 @@import { t } from "@/plugins/i18n";+import { IssueStatus } from "@/types/proto-es/v1/issue_service_pb";import type { ActionDefinition } from "../types";export const ROLLOUT_CREATE: ActionDefinition = {@@ -14,6 +15,8 @@ export const ROLLOUT_CREATE: ActionDefinition = {if (ctx.isIssueOnly) return false;if (ctx.plan.hasRollout) return false;if (!ctx.issue) return false;+ // Don't show create rollout when issue is closed+ if (ctx.issueStatus === IssueStatus.CANCELED) return false;if (!ctx.permissions.createRollout) return false;// Project setting validations are handled in RolloutCreatePaneldiff --git a/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue b/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vueindex 95cb94cb23..720f39f337 100644--- a/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue+++ b/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue@@ -1,17 +1,17 @@<template><div class="py-2 px-2 sm:px-4"><div class="flex flex-row items-center justify-between gap-2">- <NTag v-if="showDraftTag" round>+ <NTag v-if="showClosedTag" round type="default"><template #icon>- <CircleDotDashedIcon class="w-4 h-4" />+ <BanIcon class="w-4 h-4" /></template>- {{ $t("common.draft") }}+ {{ $t("common.closed") }}</NTag>- <NTag v-else-if="showClosedTag" round type="default">+ <NTag v-else-if="showDraftTag" round><template #icon>- <BanIcon class="w-4 h-4" />+ <CircleDotDashedIcon class="w-4 h-4" /></template>- {{ $t("common.closed") }}+ {{ $t("common.draft") }}</NTag><NTag v-else-if="showDoneTag" round type="success"><template #icon>@@ -48,7 +48,11 @@ import {import { NButton, NTag } from "naive-ui";import { computed } from "vue";import { useRoute } from "vue-router";-import { PROJECT_V1_ROUTE_ISSUE_DETAIL_V1 } from "@/router/dashboard/projectV1";+import {+ PROJECT_V1_ROUTE_ISSUE_DETAIL_V1,+ PROJECT_V1_ROUTE_PLAN_DETAIL_SPEC_DETAIL,+ PROJECT_V1_ROUTE_PLAN_DETAIL_SPECS,+} from "@/router/dashboard/projectV1";import { State } from "@/types/proto-es/v1/common_pb";import { IssueStatus } from "@/types/proto-es/v1/issue_service_pb";import { isValidPlanName } from "@/utils";@@ -61,14 +65,23 @@ import TitleInput from "./TitleInput.vue";const route = useRoute();const { isCreating, plan, issue } = usePlanContext();+const isPlanDetailPage = computed(() => {+ return (+ route.name === PROJECT_V1_ROUTE_PLAN_DETAIL_SPECS ||+ route.name === PROJECT_V1_ROUTE_PLAN_DETAIL_SPEC_DETAIL+ );+});++const isIssueDetailPage = computed(() => {+ return route.name === PROJECT_V1_ROUTE_ISSUE_DETAIL_V1;+});+const hasSidebar = computed(() => {// Check if we're in a layout with sidebar (Issue overview tab only)// The sidebar only exists when there's an issue AND we're on the overview tabif (!plan.value.issue) return false;- // Check current route to see if we're on the overview tab- // This would be the ISSUE_DETAIL_V1 route, not the PLAN_DETAIL or ROLLOUT routes- return route.name === PROJECT_V1_ROUTE_ISSUE_DETAIL_V1;+ return isIssueDetailPage.value;});const { mode: sidebarMode, mobileSidebarOpen } = useSidebarContext();@@ -78,6 +91,8 @@ const handleMobileSidebarOpen = () => {};const showDraftTag = computed(() => {+ // Only show draft tag on plan detail page+ if (!isPlanDetailPage.value) return false;return (!isCreating.value &&isValidPlanName(plan.value.name) &&@@ -87,13 +102,20 @@ const showDraftTag = computed(() => {});const showClosedTag = computed(() => {- return (- plan.value.state === State.DELETED ||- issue.value?.status === IssueStatus.CANCELED- );+ // On plan detail page: show when plan is deleted+ if (isPlanDetailPage.value) {+ return plan.value.state === State.DELETED;+ }+ // On issue detail page: show when issue is canceled+ if (isIssueDetailPage.value) {+ return issue.value?.status === IssueStatus.CANCELED;+ }+ return false;});const showDoneTag = computed(() => {+ // Only show done tag on issue detail page+ if (!isIssueDetailPage.value) return false;return issue.value?.status === IssueStatus.DONE;});diff --git a/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/SpecTabs.vue b/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/SpecTabs.vueindex 2232bbbf81..1ff856433b 100644--- a/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/SpecTabs.vue+++ b/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/SpecTabs.vue@@ -71,6 +71,7 @@ import {useCurrentProjectV1,useSheetV1Store,} from "@/store";+import { IssueStatus } from "@/types/proto-es/v1/issue_service_pb";import type { Plan_Spec } from "@/types/proto-es/v1/plan_service_pb";import { UpdatePlanRequestSchema } from "@/types/proto-es/v1/plan_service_pb";import { extractSheetUID } from "@/utils";@@ -84,7 +85,7 @@ const emit = defineEmits<{ "update:selectedSpecId": [specId: string] }>();const dialog = useDialog();const { t } = useI18n();-const { plan, isCreating } = usePlanContext();+const { plan, issue, isCreating } = usePlanContext();const sheetStore = useSheetV1Store();const { project } = useCurrentProjectV1();@@ -92,7 +93,10 @@ const specs = computed(() => plan.value.specs);const { isSpecEmpty } = useSpecsValidation(specs);const showAddSpecDrawer = ref(false);const canModifySpecs = computed(- () => isCreating.value || !plan.value.hasRollout+ () =>+ (isCreating.value || !plan.value.hasRollout) &&+ issue.value?.status !== IssueStatus.CANCELED &&+ issue.value?.status !== IssueStatus.DONE);const getDropdownOptions = (): DropdownOption[] =>