Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

feat(frontend): unify rollout creation warning behavior (#18647)

boojack5efd052bf86e
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/ACTIONS.md b/frontend/src/components/Plan/components/HeaderSection/Actions/ACTIONS.md
index 67c5a58a66..f308869f11 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/ACTIONS.md
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/ACTIONS.md
@@ -41,7 +41,7 @@ interface ActionDefinition {
id: UnifiedActionType;
label: (ctx: ActionContext) => string;
buttonType: "primary" | "success" | "default";
- category: "primary" | "secondary";
+ category: ActionCategory | ((ctx: ActionContext) => ActionCategory); // Can be dynamic
priority: number; // Lower = higher priority
isVisible: (ctx: ActionContext) => boolean;
isDisabled: (ctx: ActionContext) => boolean;
@@ -154,16 +154,28 @@ interface ActionDefinition {
### Rollout Actions
-#### `ROLLOUT_CREATE` (Primary, Priority: 55)
+#### `ROLLOUT_CREATE` (Primary/Secondary, Priority: 55)
**Label**: "Create Rollout"
-**Description**: Creates a rollout from the approved issue.
+**Description**: Creates a rollout from the issue. Shows as primary action when ready, moves to dropdown when conditions aren't met.
**Visibility**:
- Plan has no rollout attached
- Issue exists
- User has `bb.rollouts.create` permission
-- Rollout preconditions met (approval status, plan checks)
+- If `requireIssueApproval=true` AND issue not APPROVED/SKIPPED → hidden
+- If `requirePlanCheckNoError=true` AND plan checks failed → hidden
+
+**Category Logic**:
+- **Primary** (main button): When all conditions are met (no warnings)
+- **Secondary** (dropdown): When warnings exist (require_*=false but conditions not met)
+
+**Warning Panel** (shown when clicking from dropdown):
+- `requireIssueApproval=false` AND approval not APPROVED/SKIPPED → shows approval flow section
+- Plan checks are running → shows running message
+- `requirePlanCheckNoError=false` AND plan checks failed → shows plan check status
+
+When warnings exist, user must check "Bypass stage requirements" checkbox to proceed.
---
@@ -208,6 +220,27 @@ interface ActionDefinition {
---
+## Warning Behavior
+
+### Rollout Creation Category and Warnings
+
+The ROLLOUT_CREATE button visibility and category depend on project settings and current state:
+
+| Condition | Result |
+|-----------|--------|
+| `requireIssueApproval=true` + not approved | **Hidden** |
+| `requirePlanCheckNoError=true` + checks failed | **Hidden** |
+| `requireIssueApproval=false` + not approved | Secondary (dropdown) with warning |
+| `requirePlanCheckNoError=false` + checks failed | Secondary (dropdown) with warning |
+| Plan checks running | Secondary (dropdown) with warning |
+| All conditions met | Primary (main button) |
+
+### Task Execution Warnings
+
+Task execution (RUN/SKIP/CANCEL) always shows **warnings** for approval and plan check issues, never errors. Users can bypass these warnings to proceed.
+
+---
+
## Global Disabled States
All actions are disabled when:
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue
index 48a72dc152..bd8ef6c985 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue
@@ -52,6 +52,14 @@
@confirm="handleRolloutActionConfirm"
/>
</template>
+
+ <!-- Rollout Create Panel -->
+ <RolloutCreatePanel
+ :show="showRolloutCreatePanel"
+ :context="context"
+ @close="showRolloutCreatePanel = false"
+ @confirm="showRolloutCreatePanel = false"
+ />
</div>
</template>
@@ -81,7 +89,7 @@ import {
Task_Type,
} from "@/types/proto-es/v1/rollout_service_pb";
import { extractProjectResourceName, extractRolloutUID } from "@/utils";
-import { CreateButton, CreateIssueButton } from "./create";
+import { CreateButton, CreateIssueButton, RolloutCreatePanel } from "./create";
import { ExportArchiveDownloadAction } from "./export";
import RolloutReadyLink from "./RolloutReadyLink.vue";
import { ActionButton, ActionDropdown, useActionRegistry } from "./registry";
@@ -124,6 +132,12 @@ const globalDisabledReason = computed(() => {
// Panel visibility state
const pendingRolloutAction = ref<RolloutAction | undefined>(undefined);
+const showRolloutCreatePanel = ref(false);
+
+// Helper to check if rollout creation has warnings
+const hasRolloutCreationWarnings = computed(
+ () => context.value.rolloutCreationWarnings.hasAny
+);
// Get the stage that contains database creation or export tasks
const rolloutStage = computed(() => {
@@ -151,7 +165,12 @@ const handlePerformAction = async (action: UnifiedAction) => {
await handlePlanStateChange("PLAN_REOPEN");
break;
case "ROLLOUT_CREATE":
- await handleCreateRollout();
+ // Show panel if there are warnings; otherwise create immediately
+ if (hasRolloutCreationWarnings.value) {
+ showRolloutCreatePanel.value = true;
+ } else {
+ await handleCreateRollout();
+ }
break;
case "ROLLOUT_START":
case "ROLLOUT_CANCEL":
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue
new file mode 100644
index 0000000000..3bb213a24f
--- /dev/null
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue
@@ -0,0 +1,184 @@
+<template>
+ <CommonDrawer
+ :show="show"
+ :title="$t('issue.create-rollout')"
+ :loading="loading"
+ @show="resetState"
+ @close="$emit('close')"
+ >
+ <template #default>
+ <div class="flex flex-col gap-y-4 h-full px-1">
+ <!-- Warning alert with messages -->
+ <NAlert
+ v-if="warningMessages.length > 0"
+ type="warning"
+ :title="$t('common.notices')"
+ >
+ <ul class="list-disc list-inside flex flex-col gap-y-1">
+ <li
+ v-for="(warning, index) in warningMessages"
+ :key="index"
+ class="text-sm"
+ >
+ {{ warning }}
+ </li>
+ </ul>
+ </NAlert>
+
+ <!-- Approval Flow Section -->
+ <ApprovalFlowSection v-if="issue" :issue="issue" />
+
+ <!-- Plan Check Status -->
+ <div class="w-full flex flex-col gap-2">
+ <span class="font-medium text-control shrink-0">{{
+ $t("plan.navigator.checks")
+ }}</span>
+ <PlanCheckStatusCount :plan="plan" />
+ </div>
+ </div>
+ </template>
+ <template #footer>
+ <div class="w-full flex flex-row justify-between items-center gap-x-2">
+ <!-- Bypass checkbox -->
+ <div v-if="hasWarnings" class="flex items-center">
+ <NCheckbox v-model:checked="bypassWarnings" :disabled="loading">
+ {{ $t("rollout.bypass-stage-requirements") }}
+ </NCheckbox>
+ </div>
+ <div v-else />
+
+ <div class="flex justify-end gap-x-2">
+ <NButton quaternary @click="$emit('close')">
+ {{ $t("common.close") }}
+ </NButton>
+
+ <NButton
+ :disabled="hasWarnings && !bypassWarnings"
+ type="primary"
+ :loading="loading"
+ @click="handleConfirm"
+ >
+ {{ $t("issue.create-rollout") }}
+ </NButton>
+ </div>
+ </div>
+ </template>
+ </CommonDrawer>
+</template>
+
+<script setup lang="ts">
+import { create } from "@bufbuild/protobuf";
+import { NAlert, NButton, NCheckbox } from "naive-ui";
+import { computed, ref } from "vue";
+import { useI18n } from "vue-i18n";
+import { useRouter } from "vue-router";
+import CommonDrawer from "@/components/IssueV1/components/Panel/CommonDrawer.vue";
+import { ApprovalFlowSection } from "@/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection";
+import PlanCheckStatusCount from "@/components/Plan/components/PlanCheckStatusCount.vue";
+import { usePlanContext } from "@/components/Plan/logic";
+import { rolloutServiceClientConnect } from "@/grpcweb";
+import { PROJECT_V1_ROUTE_ROLLOUT_DETAIL } from "@/router/dashboard/projectV1";
+import { pushNotification } from "@/store";
+import { CreateRolloutRequestSchema } from "@/types/proto-es/v1/rollout_service_pb";
+import { extractProjectResourceName, extractRolloutUID } from "@/utils";
+import type { ActionContext } from "../registry/types";
+
+const props = defineProps<{
+ show: boolean;
+ context: ActionContext;
+}>();
+
+const emit = defineEmits<{
+ (event: "close"): void;
+ (event: "confirm"): void;
+}>();
+
+const { t } = useI18n();
+const router = useRouter();
+const { events } = usePlanContext();
+
+// Use context from props for consistency
+const plan = computed(() => props.context.plan);
+const issue = computed(() => props.context.issue);
+const project = computed(() => props.context.project);
+const warnings = computed(() => props.context.rolloutCreationWarnings);
+
+const loading = ref(false);
+const bypassWarnings = ref(false);
+
+// Build warning messages based on current state
+const warningMessages = computed(() => {
+ const messages: string[] = [];
+
+ if (warnings.value.approvalNotReady) {
+ messages.push(
+ t("project.settings.issue-related.require-issue-approval.description")
+ );
+ }
+
+ if (warnings.value.planChecksRunning) {
+ messages.push(
+ t(
+ "custom-approval.issue-review.disallow-approve-reason.some-task-checks-are-still-running"
+ )
+ );
+ } else if (warnings.value.planChecksFailed) {
+ messages.push(
+ t(
+ "project.settings.issue-related.require-plan-check-no-error.description"
+ )
+ );
+ }
+
+ return messages;
+});
+
+const hasWarnings = computed(() => warnings.value.hasAny);
+
+const resetState = () => {
+ bypassWarnings.value = false;
+};
+
+const handleConfirm = async () => {
+ if (loading.value) return;
+
+ loading.value = true;
+ try {
+ const request = create(CreateRolloutRequestSchema, {
+ parent: project.value.name,
+ rollout: {
+ plan: plan.value.name,
+ },
+ });
+ const createdRollout =
+ await rolloutServiceClientConnect.createRollout(request);
+
+ pushNotification({
+ module: "bytebase",
+ style: "SUCCESS",
+ title: t("common.created"),
+ });
+
+ events.emit("status-changed", { eager: true });
+ emit("confirm");
+
+ router.push({
+ name: PROJECT_V1_ROUTE_ROLLOUT_DETAIL,
+ params: {
+ projectId: extractProjectResourceName(project.value.name),
+ rolloutId: extractRolloutUID(createdRollout.name),
+ },
+ });
+ } catch (error) {
+ pushNotification({
+ module: "bytebase",
+ style: "CRITICAL",
+ title: t("common.failed"),
+ description: String(error),
+ });
+ } finally {
+ loading.value = false;
+ emit("close");
+ }
+};
+</script>
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts
index 14255371a7..c67422f25f 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/index.ts
@@ -1,4 +1,5 @@
import CreateButton from "./CreateButton.vue";
import CreateIssueButton from "./CreateIssueButton.vue";
+import RolloutCreatePanel from "./RolloutCreatePanel.vue";
-export { CreateButton, CreateIssueButton };
+export { CreateButton, CreateIssueButton, RolloutCreatePanel };
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts
index 4dc63d7ca3..f0db932188 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/rollout.ts
@@ -1,20 +1,28 @@
import { t } from "@/plugins/i18n";
-import { Issue_ApprovalStatus } from "@/types/proto-es/v1/issue_service_pb";
import type { ActionDefinition } from "../types";
export const ROLLOUT_CREATE: ActionDefinition = {
id: "ROLLOUT_CREATE",
label: () => t("issue.create-rollout"),
buttonType: "default",
- category: "primary",
+ // Primary when ready, secondary (dropdown) when warnings exist
+ category: (ctx) =>
+ ctx.rolloutCreationWarnings.hasAny ? "secondary" : "primary",
priority: 55,
- isVisible: (ctx) =>
- !ctx.isIssueOnly &&
- !ctx.plan.hasRollout &&
- ctx.issue !== undefined &&
- ctx.permissions.createRollout &&
- ctx.rolloutPreconditionsMet,
+ isVisible: (ctx) => {
+ if (ctx.isIssueOnly) return false;
+ if (ctx.plan.hasRollout) return false;
+ if (!ctx.issue) return false;
+ if (!ctx.permissions.createRollout) return false;
+
+ // Hide when require_*=true and condition not met
+ if (!ctx.issueApproved && ctx.project.requireIssueApproval) return false;
+ if (ctx.validation.planChecksFailed && ctx.project.requirePlanCheckNoError)
+ return false;
+
+ return true;
+ },
isDisabled: () => false,
disabledReason: () => undefined,
@@ -31,15 +39,9 @@ export const ROLLOUT_START: ActionDefinition = {
isVisible: (ctx) => {
if (!ctx.rollout) return false;
- if (
- ctx.approvalStatus !== Issue_ApprovalStatus.APPROVED &&
- ctx.approvalStatus !== Issue_ApprovalStatus.SKIPPED
- ) {
- return false;
- }
+ if (!ctx.issueApproved) return false;
if (!ctx.hasDatabaseCreateOrExportTasks) return false;
if (!ctx.hasStartableTasks) return false;
-
return ctx.permissions.runTasks;
},
@@ -58,14 +60,8 @@ export const ROLLOUT_CANCEL: ActionDefinition = {
isVisible: (ctx) => {
if (!ctx.rollout) return false;
- if (
- ctx.approvalStatus !== Issue_ApprovalStatus.APPROVED &&
- ctx.approvalStatus !== Issue_ApprovalStatus.SKIPPED
- ) {
- return false;
- }
+ if (!ctx.issueApproved) return false;
if (!ctx.hasRunningTasks) return false;
-
return ctx.permissions.runTasks;
},
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts
index c6661c2ebc..539b809b18 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts
@@ -210,17 +210,26 @@ export function buildActionContext(input: ContextBuilderInput): ActionContext {
[Task_Status.PENDING, Task_Status.RUNNING].includes(task.status)
);
- // Compute rollout preconditions
+ // Compute approval status
const issueApproved =
issue?.approvalStatus === Issue_ApprovalStatus.APPROVED ||
issue?.approvalStatus === Issue_ApprovalStatus.SKIPPED;
- const { requireIssueApproval, requirePlanCheckNoError } = project;
- const issueReady = !requireIssueApproval || issueApproved;
- const planCheckReady =
- !requirePlanCheckNoError ||
- (!hasRunningPlanChecks && planCheckStatus !== Advice_Level.ERROR);
- const rolloutPreconditionsMet = issueReady && planCheckReady;
+ // Compute rollout creation warnings
+ // These flags indicate when ROLLOUT_CREATE should show in dropdown with warnings
+ // Warnings only apply when require_*=false; when require_*=true, button is hidden instead
+ const warnApprovalNotReady = !project.requireIssueApproval && !issueApproved;
+ const warnPlanChecksRunning = hasRunningPlanChecks;
+ const warnPlanChecksFailed =
+ !project.requirePlanCheckNoError && planCheckStatus === Advice_Level.ERROR;
+
+ const rolloutCreationWarnings = {
+ approvalNotReady: warnApprovalNotReady,
+ planChecksRunning: warnPlanChecksRunning,
+ planChecksFailed: warnPlanChecksFailed,
+ hasAny:
+ warnApprovalNotReady || warnPlanChecksRunning || warnPlanChecksFailed,
+ };
return {
plan,
@@ -236,6 +245,7 @@ export function buildActionContext(input: ContextBuilderInput): ActionContext {
isIssueOnly,
isExportPlan,
isCreator,
+ issueApproved,
exportArchiveReady: computeExportArchiveReady(
rollout,
taskRuns,
@@ -246,7 +256,7 @@ export function buildActionContext(input: ContextBuilderInput): ActionContext {
hasDatabaseCreateOrExportTasks,
hasStartableTasks,
hasRunningTasks,
- rolloutPreconditionsMet,
+ rolloutCreationWarnings,
permissions,
validation,
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts
index 6c9c4f73a6..7c7a7cb7c4 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts
@@ -63,23 +63,34 @@ export interface ActionContext {
isIssueOnly: boolean;
isExportPlan: boolean;
isCreator: boolean;
+ issueApproved: boolean; // approval is APPROVED or SKIPPED
exportArchiveReady: boolean;
allTasksFinished: boolean;
hasDatabaseCreateOrExportTasks: boolean;
hasStartableTasks: boolean;
hasRunningTasks: boolean;
- rolloutPreconditionsMet: boolean;
+
+ // Warning flags for rollout creation (button moves to dropdown when hasAny=true)
+ // Note: When require_*=true and condition not met, button is HIDDEN (not a warning)
+ rolloutCreationWarnings: {
+ approvalNotReady: boolean; // require_issue_approval=false AND not approved
+ planChecksRunning: boolean; // plan checks currently running
+ planChecksFailed: boolean; // require_plan_check_no_error=false AND checks failed
+ hasAny: boolean; // convenience: true if any warning is active
+ };
// Grouped
permissions: ActionPermissions;
validation: ActionValidation;
}
+export type ActionCategory = "primary" | "secondary";
+
export interface ActionDefinition {
id: UnifiedAction;
label: (ctx: ActionContext) => string;
buttonType: "primary" | "success" | "default";
- category: "primary" | "secondary";
+ category: ActionCategory | ((ctx: ActionContext) => ActionCategory);
priority: number;
isVisible: (ctx: ActionContext) => boolean;
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/useActionRegistry.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/useActionRegistry.ts
index 4489fd5c55..2bb32540d2 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/useActionRegistry.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/useActionRegistry.ts
@@ -44,6 +44,12 @@ export function useActionRegistry(): ActionRegistryReturn {
: undefined
);
+ // Helper to resolve category (static or dynamic)
+ const getCategory = (action: ActionDefinition) =>
+ typeof action.category === "function"
+ ? action.category(context.value)
+ : action.category;
+
// Filter visible actions (no actions during plan creation)
const visibleActions = computed(() => {
if (isCreating.value) return [];
@@ -52,15 +58,15 @@ export function useActionRegistry(): ActionRegistryReturn {
// Primary action (first visible by priority, category=primary)
const primaryAction = computed(() =>
- visibleActions.value.find((a) => a.category === "primary")
+ visibleActions.value.find((a) => getCategory(a) === "primary")
);
// Secondary actions: all secondary-category actions + remaining primary actions (excluding the chosen primary)
const secondaryActions = computed(() =>
visibleActions.value.filter(
(a) =>
- a.category === "secondary" ||
- (a.category === "primary" && a.id !== primaryAction.value?.id)
+ getCategory(a) === "secondary" ||
+ (getCategory(a) === "primary" && a.id !== primaryAction.value?.id)
)
);
diff --git a/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue b/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue
index 489facc19b..a0ea8df2fc 100644
--- a/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue
+++ b/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue
@@ -329,7 +329,6 @@ const comment = ref("");
const runTimeInMS = ref<number | undefined>(undefined);
const bypassPolicyChecks = ref(false);
const { statusSummary: planCheckStatus } = usePlanCheckStatus(plan);
-const project = computed(() => projectOfPlan(plan.value));
// Check issue approval status using the review context
const issueApprovalStatus = computed(() => {
@@ -373,24 +372,19 @@ const shouldShowComment = computed(
() => props.action === "SKIP" && !isNullOrUndefined(issue?.value)
);
-// Plan check error validation based on project settings
-const planCheckError = computed(() => {
- if (props.action !== "RUN") {
- return undefined;
- }
-
- // If no enforcement is specified, default to no validation
- if (!project.value || !project.value.requirePlanCheckNoError) {
+// Plan check warning validation - always show as warning (never error)
+const planCheckWarning = computed(() => {
+ if (props.action !== "RUN" || planCheckStatus.value.total === 0) {
return undefined;
}
+ // Always show plan check issues as warnings (regardless of require_* setting)
if (planCheckStatus.value.running > 0) {
return t(
"custom-approval.issue-review.disallow-approve-reason.some-task-checks-are-still-running"
);
}
-
- if (planCheckStatus.value.error > 0) {
+ if (planCheckStatus.value.error > 0 || planCheckStatus.value.warning > 0) {
return t(
"custom-approval.issue-review.disallow-approve-reason.some-task-checks-didnt-pass"
);
@@ -399,29 +393,6 @@ const planCheckError = computed(() => {
return undefined;
});
-// Plan check warning validation for non-blocking plan check results
-const planCheckWarning = computed(() => {
- if (props.action !== "RUN" || planCheckStatus.value.total === 0) {
- return undefined;
- }
-
- // If enforcement is disabled, show any plan check issues as warnings
- if (!project.value || !project.value.requirePlanCheckNoError) {
- if (planCheckStatus.value.running > 0) {
- return t(
- "custom-approval.issue-review.disallow-approve-reason.some-task-checks-are-still-running"
- );
- }
- if (planCheckStatus.value.error > 0 || planCheckStatus.value.warning > 0) {
- return t(
- "custom-approval.issue-review.disallow-approve-reason.some-task-checks-didnt-pass"
- );
- }
- }
-
- return undefined;
-});
-
// Collect blocking validation errors
const validationErrors = computed(() => {
const errors: string[] = [];
@@ -466,28 +437,6 @@ const validationErrors = computed(() => {
) {
errors.push(t("rollout.no-runnable-task"));
}
-
- // Issue approval errors (only if policy requires it) - HARD BLOCK
- const requiresIssueApproval =
- project.value && project.value.requireIssueApproval;
-
- if (
- requiresIssueApproval &&
- issueApprovalStatus.value.hasIssue &&
- !issueApprovalStatus.value.rolloutReady
- ) {
- const isRejected = issueApprovalStatus.value.status === "rejected";
- errors.push(
- isRejected
- ? t("issue.approval.rejected-error")
- : t("issue.approval.pending-error")
- );
- }
-
- // Plan check errors (based on rollout policy) - HARD BLOCK
- if (planCheckError.value) {
- errors.push(planCheckError.value);
- }
}
return errors;
@@ -508,17 +457,13 @@ const validationWarnings = computed(() => {
warnings.push(t("task.error.scheduled-time-must-be-in-the-future"));
}
- // Plan check warnings (non-blocking plan check results)
+ // Plan check warnings - always show when checks have issues
if (planCheckWarning.value) {
warnings.push(planCheckWarning.value);
}
- // Issue approval warnings (when not required by policy but issue is not approved)
- const requiresIssueApproval =
- project.value && project.value.requireIssueApproval;
-
+ // Issue approval warnings - always show when not approved (regardless of require_* setting)
if (
- !requiresIssueApproval &&
issueApprovalStatus.value.hasIssue &&
!issueApprovalStatus.value.rolloutReady
) {
diff --git a/frontend/src/locales/en-US.json b/frontend/src/locales/en-US.json
index a1e419ab40..7ea8ede89a 100644
--- a/frontend/src/locales/en-US.json
+++ b/frontend/src/locales/en-US.json
@@ -139,6 +139,7 @@
"search": "Search",
"search-for-more": "Search for more",
"warning": "Warning",
+ "notices": "Notices",
"edited": "edited",
"preview": "Preview",
"file-selector": {
diff --git a/frontend/src/locales/es-ES.json b/frontend/src/locales/es-ES.json
index dec26d0eab..9a8f07310b 100644
--- a/frontend/src/locales/es-ES.json
+++ b/frontend/src/locales/es-ES.json
@@ -139,6 +139,7 @@
"search": "Buscar",
"search-for-more": "Buscar más",
"warning": "Advertencia",
+ "notices": "Avisos",
"edited": "editado",
"preview": "Previsualización",
"file-selector": {
diff --git a/frontend/src/locales/ja-JP.json b/frontend/src/locales/ja-JP.json
index 80b0123f84..4fc72569fe 100644
--- a/frontend/src/locales/ja-JP.json
+++ b/frontend/src/locales/ja-JP.json
@@ -139,6 +139,7 @@
"search": "検索",
"search-for-more": "さらに検索",
"warning": "警告する",
+ "notices": "注意事項",
"edited": "編集日時",
"preview": "プレビュー",
"file-selector": {
diff --git a/frontend/src/locales/vi-VN.json b/frontend/src/locales/vi-VN.json
index 6f8151d9ee..7d4b04061f 100644
--- a/frontend/src/locales/vi-VN.json
+++ b/frontend/src/locales/vi-VN.json
@@ -139,6 +139,7 @@
"search": "Tìm kiếm",
"search-for-more": "Tìm kiếm thêm",
"warning": "Cảnh báo",
+ "notices": "Thông báo",
"edited": "đã chỉnh sửa",
"preview": "Xem trước",
"file-selector": {
diff --git a/frontend/src/locales/zh-CN.json b/frontend/src/locales/zh-CN.json
index b51848f444..db50945688 100644
--- a/frontend/src/locales/zh-CN.json
+++ b/frontend/src/locales/zh-CN.json
@@ -139,6 +139,7 @@
"search": "搜索",
"search-for-more": "搜索更多",
"warning": "警告",
+ "notices": "注意事项",
"edited": "编辑于",
"preview": "预览",
"file-selector": {