Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

refactor(frontend): move task run components from IssueV1 to RolloutV1 (#18792)

boojack5f8896350635
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunTable.vue b/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunTable.vue
index 24e60bcf25..bf8626b50f 100644
--- a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunTable.vue
+++ b/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunTable.vue
@@ -28,6 +28,8 @@ import { type DataTableColumn, NButton, NDataTable } from "naive-ui";
import { computed, ref } from "vue";
import { useI18n } from "vue-i18n";
import HumanizeDate from "@/components/misc/HumanizeDate.vue";
+import TaskRunDetail from "@/components/RolloutV1/components/TaskRunDetail.vue";
+import TaskRunStatusIcon from "@/components/RolloutV1/components/TaskRunStatusIcon.vue";
import { Drawer, DrawerContent } from "@/components/v2";
import { useCurrentProjectV1 } from "@/store";
import {
@@ -41,8 +43,6 @@ import {
import { databaseForTask, humanizeDurationV1 } from "@/utils";
import { useIssueContext } from "../../logic";
import TaskRunComment from "./TaskRunComment.vue";
-import TaskRunDetail from "./TaskRunDetail.vue";
-import TaskRunStatusIcon from "./TaskRunStatusIcon.vue";
defineOptions({
inheritAttrs: false,
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue
index d4cb9ed6a7..629f3ab696 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/create/RolloutCreatePanel.vue
@@ -74,10 +74,10 @@ import { NAlert, NButton, NCheckbox } from "naive-ui";
import { computed, ref } from "vue";
import { useI18n } from "vue-i18n";
import { useRouter } from "vue-router";
-import CommonDrawer from "@/components/IssueV1/components/Panel/CommonDrawer.vue";
import { ApprovalFlowSection } from "@/components/Plan/components/IssueReviewView/Sidebar/ApprovalFlowSection";
import PlanCheckStatusCount from "@/components/Plan/components/PlanCheckStatusCount.vue";
import { usePlanCheckStatus, usePlanContext } from "@/components/Plan/logic";
+import CommonDrawer from "@/components/RolloutV1/components/CommonDrawer.vue";
import {
issueServiceClientConnect,
rolloutServiceClientConnect,
diff --git a/frontend/src/components/Plan/components/SpecDetailView/FailedTaskRunsSection.vue b/frontend/src/components/Plan/components/SpecDetailView/FailedTaskRunsSection.vue
index 83119c3ad6..10808f4a6e 100644
--- a/frontend/src/components/Plan/components/SpecDetailView/FailedTaskRunsSection.vue
+++ b/frontend/src/components/Plan/components/SpecDetailView/FailedTaskRunsSection.vue
@@ -55,10 +55,10 @@ import { type DataTableColumn, NButton, NDataTable } from "naive-ui";
import { computed, reactive, ref, watchEffect } from "vue";
import { useI18n } from "vue-i18n";
import { useRouter } from "vue-router";
-import TaskRunDetail from "@/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue";
-import TaskRunStatusIcon from "@/components/IssueV1/components/TaskRunSection/TaskRunStatusIcon.vue";
import HumanizeDate from "@/components/misc/HumanizeDate.vue";
import TaskRunComment from "@/components/RolloutV1/components/TaskRunComment.vue";
+import TaskRunDetail from "@/components/RolloutV1/components/TaskRunDetail.vue";
+import TaskRunStatusIcon from "@/components/RolloutV1/components/TaskRunStatusIcon.vue";
import { Drawer, DrawerContent } from "@/components/v2";
import { PROJECT_V1_ROUTE_PLAN_ROLLOUT_TASK } from "@/router/dashboard/projectV1";
import { useCurrentProjectV1, useDatabaseV1Store } from "@/store";
diff --git a/frontend/src/components/RolloutV1/components/CommonDrawer.vue b/frontend/src/components/RolloutV1/components/CommonDrawer.vue
new file mode 100644
index 0000000000..8eb50b21c1
--- /dev/null
+++ b/frontend/src/components/RolloutV1/components/CommonDrawer.vue
@@ -0,0 +1,51 @@
+<template>
+ <Drawer :show="show" :mask-closable="true" @close="$emit('close')">
+ <DrawerContent
+ :title="title"
+ class="relative overflow-hidden w-128 max-w-[100vw]"
+ >
+ <template #default>
+ <slot />
+
+ <div
+ v-if="loading"
+ v-zindexable="{ enabled: true }"
+ class="absolute inset-0 flex items-center justify-center bg-white/50"
+ >
+ <BBSpin />
+ </div>
+ </template>
+
+ <template v-if="$slots.footer" #footer>
+ <slot name="footer" />
+ </template>
+ </DrawerContent>
+ </Drawer>
+</template>
+
+<script setup lang="ts">
+import { zindexable as vZindexable } from "vdirs";
+import { watch } from "vue";
+import { BBSpin } from "@/bbkit";
+import { Drawer, DrawerContent } from "@/components/v2";
+
+const props = defineProps<{
+ title: string;
+ show: boolean;
+ loading: boolean;
+}>();
+
+const emit = defineEmits<{
+ (event: "show"): void;
+ (event: "close"): void;
+}>();
+
+watch(
+ () => props.show,
+ (newShow, oldShow) => {
+ if (newShow && !oldShow) {
+ emit("show");
+ }
+ }
+);
+</script>
diff --git a/frontend/src/components/RolloutV1/components/ErrorList.vue b/frontend/src/components/RolloutV1/components/ErrorList.vue
new file mode 100644
index 0000000000..da82a653fe
--- /dev/null
+++ b/frontend/src/components/RolloutV1/components/ErrorList.vue
@@ -0,0 +1,23 @@
+<template>
+ <ul
+ class="flex flex-col whitespace-nowrap"
+ :class="[errors.length > 1 && bullets && 'list-disc pl-4']"
+ >
+ <li v-for="(error, i) in errors" :key="i">
+ <slot name="prefix" />
+ {{ error }}
+ </li>
+ </ul>
+</template>
+
+<script setup lang="ts">
+withDefaults(
+ defineProps<{
+ errors: string[];
+ bullets?: boolean;
+ }>(),
+ {
+ bullets: true,
+ }
+);
+</script>
diff --git a/frontend/src/components/RolloutV1/components/StageTimeline.vue b/frontend/src/components/RolloutV1/components/StageTimeline.vue
index f6eca30465..745d3b1eb0 100644
--- a/frontend/src/components/RolloutV1/components/StageTimeline.vue
+++ b/frontend/src/components/RolloutV1/components/StageTimeline.vue
@@ -133,7 +133,6 @@ import { SquareChartGanttIcon } from "lucide-vue-next";
import { NTimeline, NTimelineItem, NTooltip } from "naive-ui";
import { computed, onUnmounted, ref, watch } from "vue";
import BBSpin from "@/bbkit/BBSpin.vue";
-import TaskRunDetail from "@/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue";
import TimestampDisplay from "@/components/misc/Timestamp.vue";
import { useResourcePoller } from "@/components/Plan/logic/poller";
import TaskStatus from "@/components/Rollout/kits/TaskStatus.vue";
@@ -154,6 +153,7 @@ import {
mapTaskRunStatusToTaskStatus,
} from "./composables/useTaskRunUtils";
import ScheduledTimeIndicator from "./ScheduledTimeIndicator.vue";
+import TaskRunDetail from "./TaskRunDetail.vue";
const props = withDefaults(
defineProps<{
diff --git a/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue b/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue
index 48447b0485..504e0a14f0 100644
--- a/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue
+++ b/frontend/src/components/RolloutV1/components/TaskRolloutActionPanel.vue
@@ -259,8 +259,6 @@ import {
} from "naive-ui";
import { computed, ref, watch, watchEffect } from "vue";
import { useI18n } from "vue-i18n";
-import { ErrorList } from "@/components/IssueV1/components/common";
-import CommonDrawer from "@/components/IssueV1/components/Panel/CommonDrawer.vue";
import PlanCheckStatusCount from "@/components/Plan/components/PlanCheckStatusCount.vue";
import {
usePlanCheckStatus,
@@ -305,6 +303,8 @@ import {
TaskRun_Status,
} from "@/types/proto-es/v1/rollout_service_pb";
import { extractStageUID, isNullOrUndefined } from "@/utils";
+import CommonDrawer from "./CommonDrawer.vue";
+import ErrorList from "./ErrorList.vue";
import TaskDatabaseName from "./TaskDatabaseName.vue";
import { canRolloutTasks } from "./taskPermissions";
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue b/frontend/src/components/RolloutV1/components/TaskRunDetail.vue
similarity index 97%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue
rename to frontend/src/components/RolloutV1/components/TaskRunDetail.vue
index d94b4acb9b..8cdafe82c3 100644
--- a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue
+++ b/frontend/src/components/RolloutV1/components/TaskRunDetail.vue
@@ -37,7 +37,6 @@ import { uniqueId } from "lodash-es";
import { RefreshCcwIcon } from "lucide-vue-next";
import { NButton, NTabPane, NTabs } from "naive-ui";
import { computed, reactive, ref } from "vue";
-import { TaskRunLogViewer } from "@/components/RolloutV1/components/TaskRunLogViewer";
import { rolloutServiceClientConnect } from "@/connect";
import { Engine } from "@/types/proto-es/v1/common_pb";
import type { Database } from "@/types/proto-es/v1/database_service_pb";
@@ -47,6 +46,7 @@ import {
TaskRun_Status,
} from "@/types/proto-es/v1/rollout_service_pb";
import type { Sheet } from "@/types/proto-es/v1/sheet_service_pb";
+import { TaskRunLogViewer } from "./TaskRunLogViewer";
import TaskRunSession from "./TaskRunSession";
const TASK_RUN_SESSION_SUPPORTED_ENGINES = [Engine.POSTGRES];
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/Cells/StatementCell.vue b/frontend/src/components/RolloutV1/components/TaskRunSession/Cells/StatementCell.vue
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/Cells/StatementCell.vue
rename to frontend/src/components/RolloutV1/components/TaskRunSession/Cells/StatementCell.vue
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/Cells/TimeCell.vue b/frontend/src/components/RolloutV1/components/TaskRunSession/Cells/TimeCell.vue
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/Cells/TimeCell.vue
rename to frontend/src/components/RolloutV1/components/TaskRunSession/Cells/TimeCell.vue
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/Cells/index.ts b/frontend/src/components/RolloutV1/components/TaskRunSession/Cells/index.ts
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/Cells/index.ts
rename to frontend/src/components/RolloutV1/components/TaskRunSession/Cells/index.ts
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/PostgresSessionTable.vue b/frontend/src/components/RolloutV1/components/TaskRunSession/PostgresSessionTable.vue
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/PostgresSessionTable.vue
rename to frontend/src/components/RolloutV1/components/TaskRunSession/PostgresSessionTable.vue
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/TaskRunSession.vue b/frontend/src/components/RolloutV1/components/TaskRunSession/TaskRunSession.vue
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/TaskRunSession.vue
rename to frontend/src/components/RolloutV1/components/TaskRunSession/TaskRunSession.vue
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/index.ts b/frontend/src/components/RolloutV1/components/TaskRunSession/index.ts
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunSession/index.ts
rename to frontend/src/components/RolloutV1/components/TaskRunSession/index.ts
diff --git a/frontend/src/components/IssueV1/components/TaskRunSection/TaskRunStatusIcon.vue b/frontend/src/components/RolloutV1/components/TaskRunStatusIcon.vue
similarity index 100%
rename from frontend/src/components/IssueV1/components/TaskRunSection/TaskRunStatusIcon.vue
rename to frontend/src/components/RolloutV1/components/TaskRunStatusIcon.vue
diff --git a/frontend/src/components/RolloutV1/components/TaskRunTable.vue b/frontend/src/components/RolloutV1/components/TaskRunTable.vue
index 17d44b38c8..a51f5fb784 100644
--- a/frontend/src/components/RolloutV1/components/TaskRunTable.vue
+++ b/frontend/src/components/RolloutV1/components/TaskRunTable.vue
@@ -31,8 +31,6 @@ import type { DataTableColumn } from "naive-ui";
import { NButton, NDataTable } from "naive-ui";
import { computed, ref } from "vue";
import { useI18n } from "vue-i18n";
-import TaskRunDetail from "@/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue";
-import TaskRunStatusIcon from "@/components/IssueV1/components/TaskRunSection/TaskRunStatusIcon.vue";
import HumanizeDate from "@/components/misc/HumanizeDate.vue";
import DatabaseDisplay from "@/components/Plan/components/common/DatabaseDisplay.vue";
import { usePlanContextWithRollout } from "@/components/Plan/logic";
@@ -46,6 +44,8 @@ import type { Task, TaskRun } from "@/types/proto-es/v1/rollout_service_pb";
import { TaskRun_Status } from "@/types/proto-es/v1/rollout_service_pb";
import { databaseForTask, extractTaskUID, humanizeDurationV1 } from "@/utils";
import TaskRunComment from "./TaskRunComment.vue";
+import TaskRunDetail from "./TaskRunDetail.vue";
+import TaskRunStatusIcon from "./TaskRunStatusIcon.vue";
const props = defineProps<{
taskRuns: TaskRun[];
diff --git a/frontend/src/components/RolloutV1/components/TaskTable.vue b/frontend/src/components/RolloutV1/components/TaskTable.vue
index 9aa965c738..4d8489abdd 100644
--- a/frontend/src/components/RolloutV1/components/TaskTable.vue
+++ b/frontend/src/components/RolloutV1/components/TaskTable.vue
@@ -25,7 +25,6 @@ import { NDataTable, NTag, NTooltip } from "naive-ui";
import { computed, watch } from "vue";
import { useI18n } from "vue-i18n";
import { useRouter } from "vue-router";
-import { semanticTaskType } from "@/components/IssueV1";
import Timestamp from "@/components/misc/Timestamp.vue";
import DatabaseDisplay from "@/components/Plan/components/common/DatabaseDisplay.vue";
import { usePlanContextWithRollout } from "@/components/Plan/logic";
@@ -41,6 +40,7 @@ import {
extractStageNameFromTaskName,
humanizeTs,
} from "@/utils";
+import { semanticTaskType } from "../logic";
const props = withDefaults(
defineProps<{
diff --git a/frontend/src/components/RolloutV1/components/TaskView.vue b/frontend/src/components/RolloutV1/components/TaskView.vue
index 821f170100..501f810397 100644
--- a/frontend/src/components/RolloutV1/components/TaskView.vue
+++ b/frontend/src/components/RolloutV1/components/TaskView.vue
@@ -136,7 +136,6 @@ import { CalendarClockIcon, LinkIcon } from "lucide-vue-next";
import { NButton, NTag, NTooltip } from "naive-ui";
import { computed, watchEffect } from "vue";
import { RouterLink } from "vue-router";
-import TaskRunDetail from "@/components/IssueV1/components/TaskRunSection/TaskRunDetail.vue";
import { MonacoEditor } from "@/components/MonacoEditor";
import DatabaseDisplay from "@/components/Plan/components/common/DatabaseDisplay.vue";
import {
@@ -167,6 +166,7 @@ import {
} from "@/utils";
import ReleaseInfoCard from "./ReleaseInfoCard.vue";
import TaskRollbackButton from "./TaskRollbackButton.vue";
+import TaskRunDetail from "./TaskRunDetail.vue";
import TaskRunTable from "./TaskRunTable.vue";
import TaskStatusActions from "./TaskStatusActions.vue";
diff --git a/frontend/src/components/RolloutV1/logic/index.ts b/frontend/src/components/RolloutV1/logic/index.ts
index 5234f1db83..2b6c9fd4a7 100644
--- a/frontend/src/components/RolloutV1/logic/index.ts
+++ b/frontend/src/components/RolloutV1/logic/index.ts
@@ -1 +1,2 @@
+export * from "./task";
export * from "./useRolloutPreview";
diff --git a/frontend/src/components/RolloutV1/logic/task.ts b/frontend/src/components/RolloutV1/logic/task.ts
new file mode 100644
index 0000000000..38aa89d723
--- /dev/null
+++ b/frontend/src/components/RolloutV1/logic/task.ts
@@ -0,0 +1,17 @@
+import { t } from "@/plugins/i18n";
+import { Task_Type } from "@/types/proto-es/v1/rollout_service_pb";
+
+export const semanticTaskType = (type: Task_Type) => {
+ switch (type) {
+ case Task_Type.DATABASE_CREATE:
+ return t("task.type.database-create");
+ case Task_Type.DATABASE_MIGRATE:
+ return t("task.type.migrate");
+ case Task_Type.DATABASE_EXPORT:
+ return t("task.type.database-export");
+ case Task_Type.GENERAL:
+ return t("task.type.general");
+ default:
+ return "";
+ }
+};