Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(frontend): provide NConfigProvider to Vue bridge components and fix use effect dependencies (#19931)

Danny Xu628d08cef009
diff --git a/frontend/src/react/pages/project/database-detail/overview/TableDetailDialog.tsx b/frontend/src/react/pages/project/database-detail/overview/TableDetailDialog.tsx
index 590cbaf5a6..a0f71aa647 100644
--- a/frontend/src/react/pages/project/database-detail/overview/TableDetailDialog.tsx
+++ b/frontend/src/react/pages/project/database-detail/overview/TableDetailDialog.tsx
@@ -1,5 +1,7 @@
+import { NConfigProvider } from "naive-ui";
import { useEffect, useRef } from "react";
import { createApp, h, reactive } from "vue";
+import { themeOverrides } from "@/../naive-ui.config";
import { updateTableCatalog } from "@/components/ColumnDataTable/utils";
import OverlayStackManager from "@/components/misc/OverlayStackManager.vue";
import TableDetailDrawer from "@/components/TableDetailDrawer.vue";
@@ -64,25 +66,32 @@ export function VueTableDetailDrawerMount({
const app = createApp({
render() {
- return h(OverlayStackManager as never, null, {
- default: () =>
- h(TableDetailDrawer as never, {
- show: bridgeState.show,
- databaseName: bridgeState.databaseName,
- schemaName: bridgeState.schemaName,
- tableName: bridgeState.tableName,
- classificationConfig: bridgeState.classificationConfig,
- onDismiss: bridgeState.onDismiss,
- onApplyClassification: (table: string, id: string) => {
- void updateTableCatalog({
- database: bridgeState.databaseName,
- schema: bridgeState.schemaName,
- table,
- tableCatalog: { classification: id },
- });
- },
- }),
- });
+ return h(
+ NConfigProvider as never,
+ { themeOverrides: themeOverrides.value },
+ {
+ default: () =>
+ h(OverlayStackManager as never, null, {
+ default: () =>
+ h(TableDetailDrawer as never, {
+ show: bridgeState.show,
+ databaseName: bridgeState.databaseName,
+ schemaName: bridgeState.schemaName,
+ tableName: bridgeState.tableName,
+ classificationConfig: bridgeState.classificationConfig,
+ onDismiss: bridgeState.onDismiss,
+ onApplyClassification: (table: string, id: string) => {
+ void updateTableCatalog({
+ database: bridgeState.databaseName,
+ schema: bridgeState.schemaName,
+ table,
+ tableCatalog: { classification: id },
+ });
+ },
+ }),
+ }),
+ }
+ );
},
});
app.use(router).use(pinia).use(i18n).use(NaiveUI);
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseCatalogPanel.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseCatalogPanel.tsx
index 51aaf119d9..dfd8a08ec8 100644
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseCatalogPanel.tsx
+++ b/frontend/src/react/pages/project/database-detail/panels/DatabaseCatalogPanel.tsx
@@ -1,5 +1,7 @@
+import { NConfigProvider } from "naive-ui";
import { useEffect, useRef } from "react";
import { createApp, h } from "vue";
+import { themeOverrides } from "@/../naive-ui.config";
import DatabaseSensitiveDataPanel from "@/components/Database/DatabaseSensitiveDataPanel.vue";
import OverlayStackManager from "@/components/misc/OverlayStackManager.vue";
import i18n from "@/plugins/i18n";
@@ -18,12 +20,19 @@ export function DatabaseCatalogPanel({ database }: { database: Database }) {
const app = createApp({
render() {
- return h(OverlayStackManager as never, null, {
- default: () =>
- h(DatabaseSensitiveDataPanel as never, {
- database,
- }),
- });
+ return h(
+ NConfigProvider as never,
+ { themeOverrides: themeOverrides.value },
+ {
+ default: () =>
+ h(OverlayStackManager as never, null, {
+ default: () =>
+ h(DatabaseSensitiveDataPanel as never, {
+ database,
+ }),
+ }),
+ }
+ );
},
});
app.use(router).use(pinia).use(i18n).use(NaiveUI);
@@ -32,7 +41,7 @@ export function DatabaseCatalogPanel({ database }: { database: Database }) {
return () => {
app.unmount();
};
- }, [database.name]);
+ }, [database.name, database.project, database.environment]);
return <div ref={containerRef} />;
}
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx
index dd8ff3443a..59d837a766 100644
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx
+++ b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx
@@ -37,10 +37,20 @@ const mocks = vi.hoisted(() => ({
}
>,
createApp: vi.fn(),
- h: vi.fn((component: unknown, props: Record<string, unknown>) => ({
- component,
- props,
- })),
+ h: vi.fn(
+ (
+ component: unknown,
+ props: Record<string, unknown> | null,
+ slots?: { default?: () => unknown }
+ ) => {
+ // If called with slots (wrapper components like NConfigProvider),
+ // return the slot content to unwrap the wrapper.
+ if (slots?.default) {
+ return slots.default();
+ }
+ return { component, props };
+ }
+ ),
}));
let DatabaseRevisionPanel: typeof import("./DatabaseRevisionPanel").DatabaseRevisionPanel;
@@ -75,6 +85,18 @@ vi.mock("@/plugins/i18n", () => ({
},
}));
+vi.mock("naive-ui", async (importOriginal) => {
+ const actual = await importOriginal<typeof import("naive-ui")>();
+ return {
+ ...actual,
+ NConfigProvider: Symbol("NConfigProvider"),
+ };
+});
+
+vi.mock("@/../naive-ui.config", () => ({
+ themeOverrides: { value: {} },
+}));
+
vi.mock("@/plugins/naive-ui", () => ({
default: {
install: vi.fn(),
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx
index b3b23df56e..4c563fcaad 100644
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx
+++ b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx
@@ -1,7 +1,9 @@
import { create } from "@bufbuild/protobuf";
+import { NConfigProvider } from "naive-ui";
import { useCallback, useEffect, useRef, useState } from "react";
import { useTranslation } from "react-i18next";
import { createApp, h, reactive } from "vue";
+import { themeOverrides } from "@/../naive-ui.config";
import CreateRevisionDrawer from "@/components/Revision/CreateRevisionDrawer.vue";
import { revisionServiceClientConnect } from "@/connect";
import i18n from "@/plugins/i18n";
@@ -53,12 +55,19 @@ function VueCreateRevisionDrawerMount({
const app = createApp({
render() {
- return h(CreateRevisionDrawer as never, {
- database: bridgeState.databaseName,
- show: bridgeState.open,
- "onUpdate:show": bridgeState.onOpenChange,
- onCreated: bridgeState.onCreated,
- });
+ return h(
+ NConfigProvider as never,
+ { themeOverrides: themeOverrides.value },
+ {
+ default: () =>
+ h(CreateRevisionDrawer as never, {
+ database: bridgeState.databaseName,
+ show: bridgeState.open,
+ "onUpdate:show": bridgeState.onOpenChange,
+ onCreated: bridgeState.onCreated,
+ }),
+ }
+ );
},
});
app.use(router).use(pinia).use(i18n).use(NaiveUI);