Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
fix: bring issue label limit back (#18582)
ecmadao65590955c8e2
diff --git a/backend/api/v1/issue_service.go b/backend/api/v1/issue_service.goindex 71a5ba1c99..25c880b206 100644--- a/backend/api/v1/issue_service.go+++ b/backend/api/v1/issue_service.go@@ -395,39 +395,43 @@ func (s *IssueService) getUserByIdentifier(ctx context.Context, identifier strin// CreateIssue creates a issue.func (s *IssueService) CreateIssue(ctx context.Context, req *connect.Request[v1pb.CreateIssueRequest]) (*connect.Response[v1pb.Issue], error) {+ projectID, err := common.GetProjectID(req.Msg.Parent)+ if err != nil {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("%v", err.Error()))+ }+ project, err := s.store.GetProject(ctx, &store.FindProjectMessage{+ ResourceID: &projectID,+ })+ if err != nil {+ return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))+ }+ if project == nil {+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))+ }+ if project.Setting.ForceIssueLabels && len(req.Msg.Issue.Labels) == 0 {+ return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("require issue labels"))+ }+switch req.Msg.Issue.Type {case v1pb.Issue_GRANT_REQUEST:if req.Msg.Issue.Title == "" {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("issue title is required"))}- return s.createIssueGrantRequest(ctx, req.Msg)+ return s.createIssueGrantRequest(ctx, project, req.Msg)case v1pb.Issue_DATABASE_CHANGE:- return s.createIssueDatabaseChange(ctx, req.Msg)+ return s.createIssueDatabaseChange(ctx, project, req.Msg)case v1pb.Issue_DATABASE_EXPORT:- return s.createIssueDatabaseDataExport(ctx, req.Msg)+ return s.createIssueDatabaseDataExport(ctx, project, req.Msg)default:return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("unknown issue type %q", req.Msg.Issue.Type))}}-func (s *IssueService) createIssueDatabaseChange(ctx context.Context, request *v1pb.CreateIssueRequest) (*connect.Response[v1pb.Issue], error) {+func (s *IssueService) createIssueDatabaseChange(ctx context.Context, project *store.ProjectMessage, request *v1pb.CreateIssueRequest) (*connect.Response[v1pb.Issue], error) {user, ok := GetUserFromContext(ctx)if !ok {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))}- projectID, err := common.GetProjectID(request.Parent)- if err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("%v", err.Error()))- }- project, err := s.store.GetProject(ctx, &store.FindProjectMessage{- ResourceID: &projectID,- })- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))- }- if project == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))- }if request.Issue.Plan == "" {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("plan is required"))@@ -438,12 +442,12 @@ func (s *IssueService) createIssueDatabaseChange(ctx context.Context, request *vif err != nil {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("%v", err.Error()))}- plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &projectID})+ plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &project.ResourceID})if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))}if plan == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, projectID))+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, project.ResourceID))}planUID = &plan.UIDvar rolloutUID *int@@ -454,13 +458,13 @@ func (s *IssueService) createIssueDatabaseChange(ctx context.Context, request *v}pipeline, err := s.store.GetPipeline(ctx, &store.PipelineFind{ID: &rolloutID,- ProjectID: &projectID,+ ProjectID: &project.ResourceID,})if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get rollout, error: %v", err))}if pipeline == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", rolloutID, projectID))+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", rolloutID, project.ResourceID))}rolloutUID = &pipeline.ID}@@ -506,7 +510,7 @@ func (s *IssueService) createIssueDatabaseChange(ctx context.Context, request *vreturn connect.NewResponse(converted), nil}-func (s *IssueService) createIssueGrantRequest(ctx context.Context, request *v1pb.CreateIssueRequest) (*connect.Response[v1pb.Issue], error) {+func (s *IssueService) createIssueGrantRequest(ctx context.Context, project *store.ProjectMessage, request *v1pb.CreateIssueRequest) (*connect.Response[v1pb.Issue], error) {// Check if grant request feature is enabled.// Grant requests are only available in Enterprise plan.if err := s.licenseService.IsFeatureEnabled(v1pb.PlanFeature_FEATURE_REQUEST_ROLE_WORKFLOW); err != nil {@@ -518,19 +522,6 @@ func (s *IssueService) createIssueGrantRequest(ctx context.Context, request *v1pif !ok {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))}- projectID, err := common.GetProjectID(request.Parent)- if err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("%v", err.Error()))- }- project, err := s.store.GetProject(ctx, &store.FindProjectMessage{- ResourceID: &projectID,- })- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))- }- if project == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))- }if request.Issue.GrantRequest.GetRole() == "" {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("expect grant request role"))@@ -596,24 +587,11 @@ func (s *IssueService) createIssueGrantRequest(ctx context.Context, request *v1preturn connect.NewResponse(converted), nil}-func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, request *v1pb.CreateIssueRequest) (*connect.Response[v1pb.Issue], error) {+func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, project *store.ProjectMessage, request *v1pb.CreateIssueRequest) (*connect.Response[v1pb.Issue], error) {user, ok := GetUserFromContext(ctx)if !ok {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("user not found"))}- projectID, err := common.GetProjectID(request.Parent)- if err != nil {- return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("%v", err.Error()))- }- project, err := s.store.GetProject(ctx, &store.FindProjectMessage{- ResourceID: &projectID,- })- if err != nil {- return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get project, error: %v", err))- }- if project == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("project not found for id: %v", projectID))- }if request.Issue.Plan == "" {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("plan is required"))@@ -624,12 +602,12 @@ func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, requesif err != nil {return nil, connect.NewError(connect.CodeInvalidArgument, errors.Errorf("%v", err.Error()))}- plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &projectID})+ plan, err := s.store.GetPlan(ctx, &store.FindPlanMessage{UID: &planID, ProjectID: &project.ResourceID})if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get plan, error: %v", err))}if plan == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, projectID))+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("plan %d not found in project %s", planID, project.ResourceID))}planUID = &plan.UIDvar rolloutUID *int@@ -640,13 +618,13 @@ func (s *IssueService) createIssueDatabaseDataExport(ctx context.Context, reques}pipeline, err := s.store.GetPipeline(ctx, &store.PipelineFind{ID: &rolloutID,- ProjectID: &projectID,+ ProjectID: &project.ResourceID,})if err != nil {return nil, connect.NewError(connect.CodeInternal, errors.Errorf("failed to get rollout, error: %v", err))}if pipeline == nil {- return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", rolloutID, projectID))+ return nil, connect.NewError(connect.CodeNotFound, errors.Errorf("rollout %d not found in project %s", rolloutID, project.ResourceID))}rolloutUID = &pipeline.ID}diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vueindex d037912c3a..5110ca24a6 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/Actions.vue@@ -57,8 +57,6 @@ import {} from "@/grpcweb";import { PROJECT_V1_ROUTE_ISSUE_DETAIL_V1 } from "@/router/dashboard/projectV1";import {- candidatesOfApprovalStepV1,- extractUserId,pushNotification,useCurrentProjectV1,useCurrentUserV1,@@ -67,8 +65,6 @@ import { usePlanStore } from "@/store/modules/v1/plan";import { State } from "@/types/proto-es/v1/common_pb";import {CreateIssueRequestSchema,- Issue_ApprovalStatus,- Issue_Approver_Status,Issue_Type,IssueSchema,IssueStatus,@@ -76,15 +72,12 @@ import {import type { Plan, Plan_Spec } from "@/types/proto-es/v1/plan_service_pb";import {CreateRolloutRequestSchema,- Task_Status,Task_Type,} from "@/types/proto-es/v1/rollout_service_pb";import { Advice_Level } from "@/types/proto-es/v1/sql_service_pb";import {extractIssueUID,extractProjectResourceName,- hasProjectPermissionV2,- isUserIncludedInList,isValidIssueName,isValidPlanName,} from "@/utils";@@ -100,16 +93,19 @@ import {type UnifiedAction,UnifiedActionGroup,} from "./unified";+import { usePlanAction } from "./unified/action";const { t } = useI18n();const router = useRouter();const dialog = useDialog();const resourcePoller = useResourcePoller();-const { isCreating, plan, issue, rollout, events } = usePlanContext();+const { isCreating, plan, issueLabels, issue, rollout, events } =+ usePlanContext();const currentUser = useCurrentUserV1();const { project } = useCurrentProjectV1();const planStore = usePlanStore();const editorState = useEditorState();+const { availableActions } = usePlanAction();// Use the validation hook for all specsconst { isSpecEmpty } = useSpecsValidation(computed(() => plan.value.specs));@@ -157,207 +153,6 @@ const rolloutStage = computed(() => {);});-/**- * Compute available actions based on issue state and user permissions.- *- * Action priority order:- * 1. Plan-level actions (for draft plans): PLAN_REOPEN, PLAN_CLOSE, ISSUE_CREATE- * 2. Issue review actions: ISSUE_REVIEW_APPROVE, ISSUE_REVIEW_REJECT, ISSUE_REVIEW_RE_REQUEST- * 3. Issue status actions: ISSUE_STATUS_RESOLVE, ISSUE_STATUS_CLOSE, ISSUE_STATUS_REOPEN- * 4. Rollout actions: ROLLOUT_START, ROLLOUT_CANCEL- *- * Special cases:- * - Grant requests: Issue-only (no plan), only show issue-related actions- * - Draft plans: Plans without issues, show plan management + issue creation- * - Deleted plans: Only show PLAN_REOPEN- * - Cancelled/Done issues: Only show ISSUE_STATUS_REOPEN- */-const availableActions = computed(() => {- const actions: UnifiedAction[] = [];-- if (isCreating.value) return actions;-- const currentUserEmail = currentUser.value.email;- const isIssueOnly =- !isValidPlanName(plan.value.name) && isValidIssueName(issue.value?.name);-- // For issue-only cases (grant requests, etc.), skip plan-specific actions- // and go directly to issue-related actions- if (isIssueOnly) {- // Issue-only cases should not show plan actions- // Continue to issue-related actions below- }- // If no issue exists, show create issue action or close plan action.- else if (plan.value.issue === "") {- // If rollout exists, no actions are available.- if (plan.value.rollout !== "") {- return actions;- }-- const canUpdatePlan =- currentUserEmail === extractUserId(plan.value.creator || "") ||- hasProjectPermissionV2(project.value, "bb.plans.update");-- // Check if user can reopen the plan- if (plan.value.state === State.DELETED) {- if (canUpdatePlan) {- actions.push("PLAN_REOPEN");- }- return actions; // For deleted plans, only show reopen action- }-- // Check if user can close the plan- if (canUpdatePlan) {- actions.push("PLAN_CLOSE");- }-- // Check if user can create an issue- if (hasProjectPermissionV2(project.value, "bb.issues.create")) {- actions.push("ISSUE_CREATE");- }-- return actions;- }-- const issueValue = issue?.value;- // Should not reach here.- if (!issueValue) return actions;- const issueCreator = extractUserId(issueValue.creator);- const isCanceled = issueValue.status === IssueStatus.CANCELED;- const isDone = issueValue.status === IssueStatus.DONE;- const canUpdateIssue = hasProjectPermissionV2(- project.value,- "bb.issues.update"- );-- // If issue is canceled, check for re-open action- if (isCanceled) {- if (canUpdateIssue) {- actions.push("ISSUE_STATUS_REOPEN");- }- return actions;- }-- // If issue is done, check for reopen action- if (isDone) {- if (canUpdateIssue) {- actions.push("ISSUE_STATUS_REOPEN");- }- return actions;- }-- // Check for review actions- const issueApproved =- issueValue.approvalStatus === Issue_ApprovalStatus.APPROVED ||- issueValue.approvalStatus === Issue_ApprovalStatus.SKIPPED;- if (!issueApproved) {- const { approvers, approvalTemplate } = issueValue;-- // Check if issue has been rejected- const hasRejection = approvers.some(- (app) => app.status === Issue_Approver_Status.REJECTED- );-- // RE_REQUEST is only available to the issue creator when rejected- if (hasRejection && currentUserEmail === issueCreator) {- actions.push("ISSUE_REVIEW_RE_REQUEST");- } else {- // Check if user can approve/reject- const roles = approvalTemplate?.flow?.roles ?? [];- if (roles.length > 0) {- const rejectedIndex = approvers.findIndex(- (ap) => ap.status === Issue_Approver_Status.REJECTED- );- const currentRoleIndex =- rejectedIndex >= 0 ? rejectedIndex : approvers.length;- const currentRole = roles[currentRoleIndex];-- if (currentRole) {- const candidates = candidatesOfApprovalStepV1(- issueValue,- currentRole- );- if (isUserIncludedInList(currentUserEmail, candidates)) {- actions.push("ISSUE_REVIEW_APPROVE");-- // Only show REJECT if no one has rejected yet.- if (!hasRejection) {- actions.push("ISSUE_REVIEW_REJECT");- }- }- }- }- }- }-- if (canUpdateIssue) {- // Check if issue can be resolved (all tasks must be finished)- if (rollout.value) {- const allTasksFinished = rollout.value.stages- .flatMap((stage) => stage.tasks)- .every((task) =>- [Task_Status.DONE, Task_Status.SKIPPED].includes(task.status)- );- if (allTasksFinished && issueApproved) {- actions.push("ISSUE_STATUS_RESOLVE");- }- }-- actions.push("ISSUE_STATUS_CLOSE");- }-- // Check for rollout actions when rollout has database creation/export tasks- // Only allow rollout actions when approval is ready (APPROVED or SKIPPED)- // For database change tasks, we'll handle in other places- if (rollout.value && issueApproved) {- // Check if there are any database creation or export tasks- const hasDatabaseCreateOrExportTasks = rollout.value.stages.some((stage) =>- stage.tasks.some(- (task) =>- task.type === Task_Type.DATABASE_CREATE ||- task.type === Task_Type.DATABASE_EXPORT- )- );- // Different permission checks based on issue type- // For export data issues: only the creator can run tasks- // For other issues: need bb.taskRuns.create permission- const canRunTasks =- issueValue.type === Issue_Type.DATABASE_EXPORT- ? currentUserEmail === extractUserId(issueValue.creator)- : hasProjectPermissionV2(project.value, "bb.taskRuns.create");-- if (hasDatabaseCreateOrExportTasks && canRunTasks) {- // Show ROLLOUT_START if there are actionable database creation/export tasks- // This includes both normal rollout and force rollout scenarios- const hasStartableTasks = rollout.value.stages- .flatMap((stage) => stage.tasks)- .some((task) =>- [- Task_Status.NOT_STARTED,- Task_Status.FAILED,- Task_Status.CANCELED,- ].includes(task.status)- );- if (hasStartableTasks) {- actions.push("ROLLOUT_START");- }-- // Check for cancel action on running/pending tasks- const runningTask = rollout.value.stages- .flatMap((stage) => stage.tasks)- .find((task) =>- [Task_Status.PENDING, Task_Status.RUNNING].includes(task.status)- );-- if (runningTask) {- actions.push("ROLLOUT_CANCEL");- }- }- }-- return actions;-});-const primaryAction = computed((): ActionConfig | undefined => {const actions = availableActions.value;const isIssueOnly =@@ -393,6 +188,9 @@ const primaryAction = computed((): ActionConfig | undefined => {));}+ if (project.value.forceIssueLabels && issueLabels.value.length === 0) {+ errors.push("Missing issue labels");+ }return {action: "ISSUE_CREATE",diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionButton.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionButton.vueindex 79c6a55008..2571f3bc5c 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionButton.vue+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionButton.vue@@ -19,9 +19,7 @@<script setup lang="ts">import { NButton, NTooltip } from "naive-ui";-import { computed } from "vue";-import { useI18n } from "vue-i18n";-import { usePlanContext } from "../../../../logic";+import { usePlanAction } from "./action";import type { UnifiedAction } from "./types";defineProps<{@@ -34,42 +32,7 @@ defineEmits<{(event: "perform-action", action: UnifiedAction): void;}>();-const { t } = useI18n();-const { plan } = usePlanContext();--// Check if this is a database export plan-const isExportPlan = computed(() => {- return plan.value.specs.some(- (spec) => spec.config?.case === "exportDataConfig"- );-});--const actionDisplayName = (action: UnifiedAction): string => {- switch (action) {- case "ISSUE_REVIEW_APPROVE":- return t("common.approve");- case "ISSUE_REVIEW_REJECT":- return t("custom-approval.issue-review.send-back");- case "ISSUE_REVIEW_RE_REQUEST":- return t("custom-approval.issue-review.re-request-review");- case "ISSUE_STATUS_CLOSE":- return t("issue.batch-transition.close");- case "ISSUE_STATUS_REOPEN":- return t("issue.batch-transition.reopen");- case "ISSUE_STATUS_RESOLVE":- return t("issue.batch-transition.resolve");- case "ISSUE_CREATE":- return t("plan.ready-for-review");- case "PLAN_CLOSE":- return t("common.close");- case "PLAN_REOPEN":- return t("common.reopen");- case "ROLLOUT_START":- return isExportPlan.value ? t("common.export") : t("common.rollout");- case "ROLLOUT_CANCEL":- return t("common.cancel");- }-};+const { actionDisplayName } = usePlanAction();const actionButtonProps = (action: UnifiedAction) => {switch (action) {diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionGroup.vue b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionGroup.vueindex 19cd5a38c7..303d26cdf5 100644--- a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionGroup.vue+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/UnifiedActionGroup.vue@@ -59,6 +59,7 @@ import { extractTaskRunUID, extractTaskUID } from "@/utils";import { usePlanContext, useRolloutReadyLink } from "../../../../logic";import { ExportArchiveDownloadAction } from "../export";import RolloutReadyLink from "../RolloutReadyLink.vue";+import { usePlanAction } from "./action";import type { ActionConfig, UnifiedAction } from "./types";import UnifiedActionButton from "./UnifiedActionButton.vue";@@ -80,16 +81,10 @@ const emit = defineEmits<{}>();const { t } = useI18n();-const { plan, issue, rollout, taskRuns } = usePlanContext();+const { issue, rollout, taskRuns } = usePlanContext();const currentUser = useCurrentUserV1();const { shouldShow: shouldShowRolloutReadyLink } = useRolloutReadyLink();--// Check if this is a database export plan-const isExportPlan = computed(() => {- return plan.value.specs.every(- (spec) => spec.config.case === "exportDataConfig"- );-});+const { actionDisplayName } = usePlanAction();const shouldShowExportDownload = computed(() => {// Must have an issue@@ -156,33 +151,6 @@ const shouldShowExportDownload = computed(() => {return true;});-const actionDisplayName = (action: UnifiedAction): string => {- switch (action) {- case "ISSUE_REVIEW_APPROVE":- return t("common.approve");- case "ISSUE_REVIEW_REJECT":- return t("custom-approval.issue-review.send-back");- case "ISSUE_REVIEW_RE_REQUEST":- return t("custom-approval.issue-review.re-request-review");- case "ISSUE_STATUS_CLOSE":- return t("issue.batch-transition.close");- case "ISSUE_STATUS_REOPEN":- return t("issue.batch-transition.reopen");- case "ISSUE_STATUS_RESOLVE":- return t("issue.batch-transition.resolve");- case "ISSUE_CREATE":- return t("plan.ready-for-review");- case "PLAN_CLOSE":- return t("common.close");- case "PLAN_REOPEN":- return t("common.reopen");- case "ROLLOUT_START":- return isExportPlan.value ? t("common.export") : t("common.rollout");- case "ROLLOUT_CANCEL":- return t("common.cancel");- }-};-const dropdownOptions = computed((): DropdownActionOption[] => {return props.secondaryActions.map((config) => ({key: config.action,diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/unified/action.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/action.tsnew file mode 100644index 0000000000..ce4f16e3f0--- /dev/null+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/unified/action.ts@@ -0,0 +1,271 @@+import { computed } from "vue";+import { usePlanContext } from "@/components/Plan/logic";+import { t } from "@/plugins/i18n";+import {+ candidatesOfApprovalStepV1,+ extractUserId,+ useCurrentProjectV1,+ useCurrentUserV1,+} from "@/store";+import { State } from "@/types/proto-es/v1/common_pb";+import {+ Issue_ApprovalStatus,+ Issue_Approver_Status,+ Issue_Type,+ IssueStatus,+} from "@/types/proto-es/v1/issue_service_pb";+import { Task_Status, Task_Type } from "@/types/proto-es/v1/rollout_service_pb";+import {+ hasProjectPermissionV2,+ isUserIncludedInList,+ isValidIssueName,+ isValidPlanName,+} from "@/utils";+import { type UnifiedAction } from "./types";++export const usePlanAction = () => {+ const currentUser = useCurrentUserV1();+ const { project } = useCurrentProjectV1();++ const { isCreating, plan, issue, rollout } = usePlanContext();++ /**+ * Compute available actions based on issue state and user permissions.+ *+ * Action priority order:+ * 1. Plan-level actions (for draft plans): PLAN_REOPEN, PLAN_CLOSE, ISSUE_CREATE+ * 2. Issue review actions: ISSUE_REVIEW_APPROVE, ISSUE_REVIEW_REJECT, ISSUE_REVIEW_RE_REQUEST+ * 3. Issue status actions: ISSUE_STATUS_RESOLVE, ISSUE_STATUS_CLOSE, ISSUE_STATUS_REOPEN+ * 4. Rollout actions: ROLLOUT_START, ROLLOUT_CANCEL+ *+ * Special cases:+ * - Grant requests: Issue-only (no plan), only show issue-related actions+ * - Draft plans: Plans without issues, show plan management + issue creation+ * - Deleted plans: Only show PLAN_REOPEN+ * - Cancelled/Done issues: Only show ISSUE_STATUS_REOPEN+ */+ const availableActions = computed(() => {+ const actions: UnifiedAction[] = [];++ if (isCreating.value) return actions;++ const currentUserEmail = currentUser.value.email;+ const isIssueOnly =+ !isValidPlanName(plan.value.name) && isValidIssueName(issue.value?.name);++ // For issue-only cases (grant requests, etc.), skip plan-specific actions+ // and go directly to issue-related actions+ if (isIssueOnly) {+ // Issue-only cases should not show plan actions+ // Continue to issue-related actions below+ }+ // If no issue exists, show create issue action or close plan action.+ else if (plan.value.issue === "") {+ // If rollout exists, no actions are available.+ if (plan.value.rollout !== "") {+ return actions;+ }++ const canUpdatePlan =+ currentUserEmail === extractUserId(plan.value.creator || "") ||+ hasProjectPermissionV2(project.value, "bb.plans.update");++ // Check if user can reopen the plan+ if (plan.value.state === State.DELETED) {+ if (canUpdatePlan) {+ actions.push("PLAN_REOPEN");+ }+ return actions; // For deleted plans, only show reopen action+ }++ // Check if user can close the plan+ if (canUpdatePlan) {+ actions.push("PLAN_CLOSE");+ }++ // Check if user can create an issue+ if (hasProjectPermissionV2(project.value, "bb.issues.create")) {+ actions.push("ISSUE_CREATE");+ }++ return actions;+ }++ const issueValue = issue?.value;+ // Should not reach here.+ if (!issueValue) return actions;+ const issueCreator = extractUserId(issueValue.creator);+ const isCanceled = issueValue.status === IssueStatus.CANCELED;+ const isDone = issueValue.status === IssueStatus.DONE;+ const canUpdateIssue = hasProjectPermissionV2(+ project.value,+ "bb.issues.update"+ );++ // If issue is canceled, check for re-open action+ if (isCanceled) {+ if (canUpdateIssue) {+ actions.push("ISSUE_STATUS_REOPEN");+ }+ return actions;+ }++ // If issue is done, check for reopen action+ if (isDone) {+ if (canUpdateIssue) {+ actions.push("ISSUE_STATUS_REOPEN");+ }+ return actions;+ }++ // Check for review actions+ const issueApproved =+ issueValue.approvalStatus === Issue_ApprovalStatus.APPROVED ||+ issueValue.approvalStatus === Issue_ApprovalStatus.SKIPPED;+ if (!issueApproved) {+ const { approvers, approvalTemplate } = issueValue;++ // Check if issue has been rejected+ const hasRejection = approvers.some(+ (app) => app.status === Issue_Approver_Status.REJECTED+ );++ // RE_REQUEST is only available to the issue creator when rejected+ if (hasRejection && currentUserEmail === issueCreator) {+ actions.push("ISSUE_REVIEW_RE_REQUEST");+ } else {+ // Check if user can approve/reject+ const roles = approvalTemplate?.flow?.roles ?? [];+ if (roles.length > 0) {+ const rejectedIndex = approvers.findIndex(+ (ap) => ap.status === Issue_Approver_Status.REJECTED+ );+ const currentRoleIndex =+ rejectedIndex >= 0 ? rejectedIndex : approvers.length;+ const currentRole = roles[currentRoleIndex];++ if (currentRole) {+ const candidates = candidatesOfApprovalStepV1(+ issueValue,+ currentRole+ );+ if (isUserIncludedInList(currentUserEmail, candidates)) {+ actions.push("ISSUE_REVIEW_APPROVE");++ // Only show REJECT if no one has rejected yet.+ if (!hasRejection) {+ actions.push("ISSUE_REVIEW_REJECT");+ }+ }+ }+ }+ }+ }++ if (canUpdateIssue) {+ // Check if issue can be resolved (all tasks must be finished)+ if (rollout.value) {+ const allTasksFinished = rollout.value.stages+ .flatMap((stage) => stage.tasks)+ .every((task) =>+ [Task_Status.DONE, Task_Status.SKIPPED].includes(task.status)+ );+ if (allTasksFinished && issueApproved) {+ actions.push("ISSUE_STATUS_RESOLVE");+ }+ }++ actions.push("ISSUE_STATUS_CLOSE");+ }++ // Check for rollout actions when rollout has database creation/export tasks+ // Only allow rollout actions when approval is ready (APPROVED or SKIPPED)+ // For database change tasks, we'll handle in other places+ if (rollout.value && issueApproved) {+ // Check if there are any database creation or export tasks+ const hasDatabaseCreateOrExportTasks = rollout.value.stages.some(+ (stage) =>+ stage.tasks.some(+ (task) =>+ task.type === Task_Type.DATABASE_CREATE ||+ task.type === Task_Type.DATABASE_EXPORT+ )+ );+ // Different permission checks based on issue type+ // For export data issues: only the creator can run tasks+ // For other issues: need bb.taskRuns.create permission+ const canRunTasks =+ issueValue.type === Issue_Type.DATABASE_EXPORT+ ? currentUserEmail === extractUserId(issueValue.creator)+ : hasProjectPermissionV2(project.value, "bb.taskRuns.create");++ if (hasDatabaseCreateOrExportTasks && canRunTasks) {+ // Show ROLLOUT_START if there are actionable database creation/export tasks+ // This includes both normal rollout and force rollout scenarios+ const hasStartableTasks = rollout.value.stages+ .flatMap((stage) => stage.tasks)+ .some((task) =>+ [+ Task_Status.NOT_STARTED,+ Task_Status.FAILED,+ Task_Status.CANCELED,+ ].includes(task.status)+ );+ if (hasStartableTasks) {+ actions.push("ROLLOUT_START");+ }++ // Check for cancel action on running/pending tasks+ const runningTask = rollout.value.stages+ .flatMap((stage) => stage.tasks)+ .find((task) =>+ [Task_Status.PENDING, Task_Status.RUNNING].includes(task.status)+ );++ if (runningTask) {+ actions.push("ROLLOUT_CANCEL");+ }+ }+ }++ return actions;+ });++ const isExportPlan = computed(() => {+ return plan.value.specs.some(+ (spec) => spec.config?.case === "exportDataConfig"+ );+ });++ const actionDisplayName = (action: UnifiedAction): string => {+ switch (action) {+ case "ISSUE_REVIEW_APPROVE":+ return t("common.approve");+ case "ISSUE_REVIEW_REJECT":+ return t("custom-approval.issue-review.send-back");+ case "ISSUE_REVIEW_RE_REQUEST":+ return t("custom-approval.issue-review.re-request-review");+ case "ISSUE_STATUS_CLOSE":+ return t("issue.batch-transition.close");+ case "ISSUE_STATUS_REOPEN":+ return t("issue.batch-transition.reopen");+ case "ISSUE_STATUS_RESOLVE":+ return t("issue.batch-transition.resolve");+ case "ISSUE_CREATE":+ return t("plan.ready-for-review");+ case "PLAN_CLOSE":+ return t("common.close");+ case "PLAN_REOPEN":+ return t("common.reopen");+ case "ROLLOUT_START":+ return isExportPlan.value ? t("common.export") : t("common.rollout");+ case "ROLLOUT_CANCEL":+ return t("common.cancel");+ }+ };++ return {+ availableActions,+ actionDisplayName,+ };+};diff --git a/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue b/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vueindex b4c914b396..2dda4902d0 100644--- a/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue+++ b/frontend/src/components/Plan/components/HeaderSection/HeaderSection.vue@@ -23,6 +23,13 @@</div></div><DescriptionSection v-if="showDescriptionSection" />+ <div class=" max-w-120 my-4">+ <IssueLabels+ v-if="availableActions.includes('ISSUE_CREATE')"+ :project="project"+ v-model:value="issueLabels"+ />+ </div></div></template>@@ -31,16 +38,21 @@ import { CircleDotDashedIcon, MenuIcon } from "lucide-vue-next";import { NButton, NTag } from "naive-ui";import { computed } from "vue";import { useRoute } from "vue-router";+import IssueLabels from "@/components/IssueV1/components/Sidebar/IssueLabels.vue";import { PROJECT_V1_ROUTE_ISSUE_DETAIL_V1 } from "@/router/dashboard/projectV1";+import { useCurrentProjectV1 } from "@/store";import { isValidPlanName } from "@/utils";import { usePlanContext } from "../../logic";import { useSidebarContext } from "../../logic/sidebar";import Actions from "./Actions";+import { usePlanAction } from "./Actions/unified/action";import DescriptionSection from "./DescriptionSection.vue";import TitleInput from "./TitleInput.vue";const route = useRoute();-const { isCreating, plan } = usePlanContext();+const { isCreating, plan, issueLabels } = usePlanContext();+const { project } = useCurrentProjectV1();+const { availableActions } = usePlanAction();const hasSidebar = computed(() => {// Check if we're in a layout with sidebar (Issue overview tab only)diff --git a/frontend/src/components/Plan/logic/context.ts b/frontend/src/components/Plan/logic/context.tsindex 14bb182200..5aaa349df1 100644--- a/frontend/src/components/Plan/logic/context.ts+++ b/frontend/src/components/Plan/logic/context.ts@@ -30,6 +30,7 @@ export type PlanContext = {issue: Ref<Issue | undefined>;rollout: Ref<Rollout | undefined>;taskRuns: Ref<TaskRun[]>;+ issueLabels: Ref<string[]>;readonly: ComputedRef<boolean>;diff --git a/frontend/src/views/project/CICDLayout.vue b/frontend/src/views/project/CICDLayout.vueindex e6d16821be..ed91ac9c35 100644--- a/frontend/src/views/project/CICDLayout.vue+++ b/frontend/src/views/project/CICDLayout.vue@@ -131,6 +131,7 @@ providePlanContext({issue,rollout,taskRuns,+ issueLabels: ref<string[]>(issue.value?.labels ?? []),...planBaseContext,});