Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
feat: remove SQLite support (#20977)
Danny Xu65f725f3b4df
diff --git a/backend/api/mcp/gen/openapi.yaml b/backend/api/mcp/gen/openapi.yamlindex e90f0627eb..e45fae06fd 100644--- a/backend/api/mcp/gen/openapi.yaml+++ b/backend/api/mcp/gen/openapi.yaml@@ -11295,7 +11295,6 @@ components:- MYSQL- POSTGRES- SNOWFLAKE- - SQLITE- TIDB- MONGODB- REDISdiff --git a/backend/api/mcp/tool_schema_test.go b/backend/api/mcp/tool_schema_test.goindex 068d1ed68c..45e94a386e 100644--- a/backend/api/mcp/tool_schema_test.go+++ b/backend/api/mcp/tool_schema_test.go@@ -503,7 +503,7 @@ func TestGetSchema_SchemaFilter_PassedThroughOnMultiSchemaEngines(t *testing.T)func TestGetSchema_SchemaFilter_DroppedOnSingleSchemaEngines(t *testing.T) {// Spot-check a few known single-schema engines.- for _, engine := range []string{"MYSQL", "TIDB", "MARIADB", "CLICKHOUSE", "SQLITE"} {+ for _, engine := range []string{"MYSQL", "TIDB", "MARIADB", "CLICKHOUSE", "STARROCKS"} {t.Run(engine, func(t *testing.T) {databases := []map[string]any{makeDatabase("instances/prod/databases/employee_db", "instances/prod", "projects/hr-system", engine, "ds-1"),diff --git a/backend/api/v1/common.go b/backend/api/v1/common.goindex 7b814d5e71..c4a613a975 100644--- a/backend/api/v1/common.go+++ b/backend/api/v1/common.go@@ -218,8 +218,6 @@ func convertToEngine(engine storepb.Engine) v1pb.Engine {return v1pb.Engine_POSTGREScase storepb.Engine_SNOWFLAKE:return v1pb.Engine_SNOWFLAKE- case storepb.Engine_SQLITE:- return v1pb.Engine_SQLITEcase storepb.Engine_TIDB:return v1pb.Engine_TIDBcase storepb.Engine_MONGODB:@@ -275,8 +273,6 @@ func convertEngine(engine v1pb.Engine) storepb.Engine {return storepb.Engine_POSTGREScase v1pb.Engine_SNOWFLAKE:return storepb.Engine_SNOWFLAKE- case v1pb.Engine_SQLITE:- return storepb.Engine_SQLITEcase v1pb.Engine_TIDB:return storepb.Engine_TIDBcase v1pb.Engine_MONGODB:diff --git a/backend/api/v1/rollout_service_task.go b/backend/api/v1/rollout_service_task.goindex 1862f149bb..a50e353f45 100644--- a/backend/api/v1/rollout_service_task.go+++ b/backend/api/v1/rollout_service_task.go@@ -370,7 +370,7 @@ func checkCharacterSetCollationOwner(dbType storepb.Engine, characterSet, collatif owner == "" {return errors.Errorf("database owner is required for CockroachDB")}- case storepb.Engine_SQLITE, storepb.Engine_MONGODB, storepb.Engine_MSSQL, storepb.Engine_DORIS, storepb.Engine_STARROCKS:+ case storepb.Engine_MONGODB, storepb.Engine_MSSQL, storepb.Engine_DORIS, storepb.Engine_STARROCKS:// no-op.default:if characterSet == "" {@@ -414,9 +414,6 @@ func getCreateDatabaseStatement(dbType storepb.Engine, c *storepb.PlanConfig_Crereturn fmt.Sprintf("CREATE DATABASE `%s`%s;", databaseName, clusterPart), nilcase storepb.Engine_SNOWFLAKE:return fmt.Sprintf("CREATE DATABASE %s;", databaseName), nil- case storepb.Engine_SQLITE:- // This is a fake CREATE DATABASE and USE statement since a single SQLite file represents a database. Engine driver will recognize it and establish a connection to create the sqlite file representing the database.- return fmt.Sprintf("CREATE DATABASE '%s';", databaseName), nilcase storepb.Engine_MONGODB:// MongoDB has no top-level CREATE DATABASE — a database is implicitly created// when its first collection is. We pass the database name to the engine driverdiff --git a/backend/common/engine.go b/backend/common/engine.goindex ceabef83cc..7ade4471cb 100644--- a/backend/common/engine.go+++ b/backend/common/engine.go@@ -25,7 +25,6 @@ func EngineSupportSQLReview(engine storepb.Engine) bool {casestorepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -62,7 +61,6 @@ func EngineSupportSDLExport(engine storepb.Engine) bool {casestorepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -107,7 +105,6 @@ func EngineSupportQueryNewACL(engine storepb.Engine) bool {casestorepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,storepb.Engine_OCEANBASE,@@ -146,7 +143,6 @@ func EngineSupportMasking(e storepb.Engine) bool {return truecasestorepb.Engine_ENGINE_UNSPECIFIED,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -189,7 +185,6 @@ func EngineSupportAutoComplete(e storepb.Engine) bool {casestorepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_REDIS,storepb.Engine_SPANNER,storepb.Engine_BIGQUERY,@@ -222,7 +217,6 @@ func EngineSupportStatementAdvise(e storepb.Engine) bool {casestorepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -258,7 +252,6 @@ func EngineSupportStatementReport(e storepb.Engine) bool {storepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_SNOWFLAKE,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -294,7 +287,6 @@ func EngineSupportPriorBackup(e storepb.Engine) bool {storepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_SNOWFLAKE,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -321,7 +313,6 @@ func EngineSupportCreateDatabase(e storepb.Engine) bool {//exhaustive:enforceswitch e {case- storepb.Engine_SQLITE,storepb.Engine_MYSQL,storepb.Engine_POSTGRES,storepb.Engine_MSSQL,@@ -375,7 +366,6 @@ func EngineSupportQuerySpanPlainField(e storepb.Engine) bool {storepb.Engine_DATABRICKS,storepb.Engine_COSMOSDB,storepb.Engine_TRINO,- storepb.Engine_SQLITE,storepb.Engine_POSTGRES,storepb.Engine_MSSQL,storepb.Engine_SNOWFLAKE,@@ -412,7 +402,6 @@ func EngineSupportSyntaxCheck(e storepb.Engine) bool {casestorepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,@@ -448,7 +437,6 @@ func BackupDatabaseNameOfEngine(e storepb.Engine) string {storepb.Engine_ENGINE_UNSPECIFIED,storepb.Engine_SNOWFLAKE,storepb.Engine_CASSANDRA,- storepb.Engine_SQLITE,storepb.Engine_MONGODB,storepb.Engine_REDIS,storepb.Engine_CLICKHOUSE,diff --git a/backend/component/export/sql.go b/backend/component/export/sql.goindex 5ce02d4eea..2a045fb8d4 100644--- a/backend/component/export/sql.go+++ b/backend/component/export/sql.go@@ -57,7 +57,7 @@ func SQLStatementPrefix(engine storepb.Engine, resourceList []base.SchemaResourcswitch engine {case storepb.Engine_MYSQL, storepb.Engine_MARIADB, storepb.Engine_TIDB, storepb.Engine_OCEANBASE, storepb.Engine_SPANNER:escapeQuote = "`"- case storepb.Engine_CLICKHOUSE, storepb.Engine_MSSQL, storepb.Engine_ORACLE, storepb.Engine_POSTGRES, storepb.Engine_REDSHIFT, storepb.Engine_SQLITE, storepb.Engine_SNOWFLAKE:+ case storepb.Engine_CLICKHOUSE, storepb.Engine_MSSQL, storepb.Engine_ORACLE, storepb.Engine_POSTGRES, storepb.Engine_REDSHIFT, storepb.Engine_SNOWFLAKE:escapeQuote = "\""default:return "", errors.Errorf("unsupported engine %v for exporting as SQL", engine)diff --git a/backend/generated-go/store/common.pb.go b/backend/generated-go/store/common.pb.goindex 5f6193bf9d..f7092ab803 100644--- a/backend/generated-go/store/common.pb.go+++ b/backend/generated-go/store/common.pb.go@@ -30,7 +30,6 @@ const (Engine_MYSQL Engine = 2Engine_POSTGRES Engine = 3Engine_SNOWFLAKE Engine = 4- Engine_SQLITE Engine = 5Engine_TIDB Engine = 6Engine_MONGODB Engine = 7Engine_REDIS Engine = 8@@ -61,7 +60,6 @@ var (2: "MYSQL",3: "POSTGRES",4: "SNOWFLAKE",- 5: "SQLITE",6: "TIDB",7: "MONGODB",8: "REDIS",@@ -89,7 +87,6 @@ var ("MYSQL": 2,"POSTGRES": 3,"SNOWFLAKE": 4,- "SQLITE": 5,"TIDB": 6,"MONGODB": 7,"REDIS": 8,@@ -804,16 +801,14 @@ const file_store_common_proto_rawDesc = "" +"\x06column\x18\x02 \x01(\x05R\x06column\"/\n" +"\x05Range\x12\x14\n" +"\x05start\x18\x01 \x01(\x05R\x05start\x12\x10\n" +- "\x03end\x18\x02 \x01(\x05R\x03end*\xf0\x02\n" ++ "\x03end\x18\x02 \x01(\x05R\x03end*\xe4\x02\n" +"\x06Engine\x12\x16\n" +"\x12ENGINE_UNSPECIFIED\x10\x00\x12\x0e\n" +"\n" +"CLICKHOUSE\x10\x01\x12\t\n" +"\x05MYSQL\x10\x02\x12\f\n" +"\bPOSTGRES\x10\x03\x12\r\n" +- "\tSNOWFLAKE\x10\x04\x12\n" +- "\n" +- "\x06SQLITE\x10\x05\x12\b\n" ++ "\tSNOWFLAKE\x10\x04\x12\b\n" +"\x04TIDB\x10\x06\x12\v\n" +"\aMONGODB\x10\a\x12\t\n" +"\x05REDIS\x10\b\x12\n" +diff --git a/backend/generated-go/v1/common.pb.go b/backend/generated-go/v1/common.pb.goindex 29738774c4..8b136d0dc5 100644--- a/backend/generated-go/v1/common.pb.go+++ b/backend/generated-go/v1/common.pb.go@@ -87,8 +87,6 @@ const (Engine_POSTGRES Engine = 3// Snowflake cloud data warehouse.Engine_SNOWFLAKE Engine = 4- // SQLite embedded database.- Engine_SQLITE Engine = 5// TiDB distributed SQL database.Engine_TIDB Engine = 6// MongoDB document database.@@ -139,7 +137,6 @@ var (2: "MYSQL",3: "POSTGRES",4: "SNOWFLAKE",- 5: "SQLITE",6: "TIDB",7: "MONGODB",8: "REDIS",@@ -167,7 +164,6 @@ var ("MYSQL": 2,"POSTGRES": 3,"SNOWFLAKE": 4,- "SQLITE": 5,"TIDB": 6,"MONGODB": 7,"REDIS": 8,@@ -928,16 +924,14 @@ const file_v1_common_proto_rawDesc = "" +"\x11STATE_UNSPECIFIED\x10\x00\x12\n" +"\n" +"\x06ACTIVE\x10\x01\x12\v\n" +- "\aDELETED\x10\x02*\xf0\x02\n" ++ "\aDELETED\x10\x02*\xe4\x02\n" +"\x06Engine\x12\x16\n" +"\x12ENGINE_UNSPECIFIED\x10\x00\x12\x0e\n" +"\n" +"CLICKHOUSE\x10\x01\x12\t\n" +"\x05MYSQL\x10\x02\x12\f\n" +"\bPOSTGRES\x10\x03\x12\r\n" +- "\tSNOWFLAKE\x10\x04\x12\n" +- "\n" +- "\x06SQLITE\x10\x05\x12\b\n" ++ "\tSNOWFLAKE\x10\x04\x12\b\n" +"\x04TIDB\x10\x06\x12\v\n" +"\aMONGODB\x10\a\x12\t\n" +"\x05REDIS\x10\b\x12\n" +diff --git a/backend/plugin/db/sqlite/dump.go b/backend/plugin/db/sqlite/dump.godeleted file mode 100644index d82464875f..0000000000--- a/backend/plugin/db/sqlite/dump.go+++ /dev/null@@ -1,92 +0,0 @@-package sqlite--import (- "context"- "database/sql"- "fmt"- "io"-- "github.com/pkg/errors"-- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/db/util"-)--// Dump dumps the database.-func (d *Driver) Dump(ctx context.Context, out io.Writer, _ *storepb.DatabaseSchemaMetadata) error {- if d.databaseName == "" {- return errors.Errorf("SQLite can dump one database only at a time")- }-- // Find all dumpable databases and make sure the existence of the database to be dumped.- databases, err := d.getDatabases()- if err != nil {- return errors.Wrap(err, "failed to get databases")- }- exist := false- for _, n := range databases {- if n == d.databaseName {- exist = true- break- }- }- if !exist {- return errors.Errorf("database %s not found", d.databaseName)- }-- return d.dumpOneDatabase(ctx, out)-}--type sqliteSchema struct {- schemaType string- name string- statement string-}--func (d *Driver) dumpOneDatabase(ctx context.Context, out io.Writer) error {- txn, err := d.db.BeginTx(ctx, &sql.TxOptions{ReadOnly: true})- if err != nil {- return err- }- defer txn.Rollback()-- // Get all schemas.- query := "SELECT type, name, sql FROM sqlite_schema;"- rows, err := txn.QueryContext(ctx, query)- if err != nil {- return util.FormatErrorWithQuery(err, query)- }- defer rows.Close()-- var sqliteSchemas []sqliteSchema- for rows.Next() {- var s sqliteSchema- var sql sql.NullString- if err := rows.Scan(- &s.schemaType,- &s.name,- &sql,- ); err != nil {- return err- }- if sql.Valid {- s.statement = sql.String- }- sqliteSchemas = append(sqliteSchemas, s)- }- if err := rows.Err(); err != nil {- return err- }-- for _, s := range sqliteSchemas {- // We should skip sqlite sequence table.- if s.name == "sqlite_sequence" {- continue- }- if _, err := io.WriteString(out, fmt.Sprintf("%s;\n", s.statement)); err != nil {- return err- }- }-- return txn.Commit()-}diff --git a/backend/plugin/db/sqlite/sqlite.go b/backend/plugin/db/sqlite/sqlite.godeleted file mode 100644index 230dde1ade..0000000000--- a/backend/plugin/db/sqlite/sqlite.go+++ /dev/null@@ -1,176 +0,0 @@-// Package sqlite is the plugin for SQLite driver.-package sqlite--import (- "context"- "database/sql"- "fmt"- "log/slog"- "os"- "path"- "strings"- "time"-- // Import sqlite3 driver.- _ "github.com/mattn/go-sqlite3"- "github.com/pkg/errors"- "google.golang.org/protobuf/types/known/durationpb"-- "github.com/bytebase/bytebase/backend/common/log"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- v1pb "github.com/bytebase/bytebase/backend/generated-go/v1"- "github.com/bytebase/bytebase/backend/plugin/db"- "github.com/bytebase/bytebase/backend/plugin/db/util"-)--var (- _ db.Driver = (*Driver)(nil)-)--func init() {- db.Register(storepb.Engine_SQLITE, newDriver)-}--// Driver is the SQLite driver.-type Driver struct {- dir string- db *sql.DB- connectionCtx db.ConnectionContext- databaseName string-}--func newDriver() db.Driver {- return &Driver{}-}--// Open opens a SQLite driver.-func (d *Driver) Open(_ context.Context, _ storepb.Engine, config db.ConnectionConfig) (db.Driver, error) {- // Host is the directory (instance) containing all SQLite databases.- d.dir = config.DataSource.Host-- // If config.Database is empty, we will get a connection to in-memory database.- db, err := createDBConnection(d.dir, config.ConnectionContext.DatabaseName)- if err != nil {- return nil, err- }- d.db = db- d.connectionCtx = config.ConnectionContext- d.databaseName = config.ConnectionContext.DatabaseName- return d, nil-}--// Close closes the driver.-func (d *Driver) Close(context.Context) error {- if d.db != nil {- return d.db.Close()- }- return nil-}--// Ping pings the database.-func (d *Driver) Ping(ctx context.Context) error {- return d.db.PingContext(ctx)-}--// GetDB gets the database.-func (d *Driver) GetDB() *sql.DB {- return d.db-}--// createDBConnection gets a database connection.-// If database is empty, we will get a connect to in-memory database.-func createDBConnection(dir, database string) (*sql.DB, error) {- dns := path.Join(dir, fmt.Sprintf("%s.db", database))- if database == "" {- dns = ":memory:"- }- db, err := sql.Open("sqlite3", dns)- if err != nil {- return nil, err- }- return db, nil-}--func (d *Driver) getDatabases() ([]string, error) {- files, err := os.ReadDir(d.dir)- if err != nil {- return nil, errors.Wrapf(err, "failed to read directory %q", d.dir)- }- var databases []string- for _, file := range files {- if file.IsDir() || !strings.HasSuffix(file.Name(), ".db") {- continue- }- databases = append(databases, strings.TrimSuffix(file.Name(), ".db"))- }- return databases, nil-}--// Execute executes a SQL statement.-func (d *Driver) Execute(ctx context.Context, statement string, opts db.ExecuteOptions) (int64, error) {- if opts.CreateDatabase {- parts := strings.Split(statement, `'`)- if len(parts) != 3 {- return 0, errors.Errorf("invalid statement %q", statement)- }- db, err := createDBConnection(d.dir, parts[1])- if err != nil {- return 0, err- }- defer db.Close()- // We need to query to persist the database file.- if _, err := db.ExecContext(ctx, "SELECT 1;"); err != nil {- return 0, err- }- return 0, nil- }-- tx, err := d.db.BeginTx(ctx, nil)- if err != nil {- return 0, err- }- defer tx.Rollback()-- sqlResult, err := tx.ExecContext(ctx, statement)- if err != nil {- return 0, err- }- if err := tx.Commit(); err != nil {- return 0, err- }- rowsAffected, err := sqlResult.RowsAffected()- if err != nil {- // Since we cannot differentiate DDL and DML yet, we have to ignore the error.- slog.Debug("rowsAffected returns error", log.BBError(err))- return 0, nil- }-- return rowsAffected, nil-}--// QueryConn queries a SQL statement in a given connection.-func (*Driver) QueryConn(ctx context.Context, conn *sql.Conn, statement string, queryContext db.QueryContext) ([]*v1pb.QueryResult, error) {- startTime := time.Now()- rows, err := conn.QueryContext(ctx, statement)- if err != nil {- return nil, err- }- defer rows.Close()-- result, err := util.RowsToQueryResult(rows, util.MakeCommonValueByTypeName, util.ConvertCommonValue, queryContext.MaximumSQLResultSize)- if err != nil {- // nolint- return []*v1pb.QueryResult{- {- Error: err.Error(),- },- }, nil- }- if err := rows.Err(); err != nil {- return nil, err- }- result.Latency = durationpb.New(time.Since(startTime))- result.Statement = statement- result.RowsCount = int64(len(result.Rows))- return []*v1pb.QueryResult{result}, nil-}diff --git a/backend/plugin/db/sqlite/sync.go b/backend/plugin/db/sqlite/sync.godeleted file mode 100644index a98f1da393..0000000000--- a/backend/plugin/db/sqlite/sync.go+++ /dev/null@@ -1,252 +0,0 @@-package sqlite--import (- "context"- "database/sql"- "fmt"- "strings"-- "github.com/pkg/errors"-- "github.com/bytebase/bytebase/backend/common"- storepb "github.com/bytebase/bytebase/backend/generated-go/store"- "github.com/bytebase/bytebase/backend/plugin/db"- "github.com/bytebase/bytebase/backend/plugin/db/util"-)--// SyncInstance syncs the instance.-func (d *Driver) SyncInstance(ctx context.Context) (*db.InstanceMetadata, error) {- version, err := d.getVersion(ctx)- if err != nil {- return nil, err- }-- databaseNames, err := d.getDatabases()- if err != nil {- return nil, err- }-- var databases []*storepb.DatabaseSchemaMetadata- for _, databaseName := range databaseNames {- databases = append(databases, &storepb.DatabaseSchemaMetadata{Name: databaseName})- }-- return &db.InstanceMetadata{- Version: version,- Databases: databases,- }, nil-}--// getVersion gets the version.-func (d *Driver) getVersion(ctx context.Context) (string, error) {- var version string- if err := d.db.QueryRowContext(ctx, "SELECT sqlite_version();").Scan(&version); err != nil {- return "", err- }- return version, nil-}--// SyncDBSchema syncs a single database schema.-func (d *Driver) SyncDBSchema(ctx context.Context) (*storepb.DatabaseSchemaMetadata, error) {- databases, err := d.getDatabases()- if err != nil {- return nil, err- }-- schemaMetadata := &storepb.SchemaMetadata{- Name: "",- }- databaseMetadata := &storepb.DatabaseSchemaMetadata{- Name: d.databaseName,- Schemas: []*storepb.SchemaMetadata{schemaMetadata},- }- found := false- for _, database := range databases {- if database == d.databaseName {- found = true- break- }- }- if !found {- return nil, common.Errorf(common.NotFound, "database %q not found", d.databaseName)- }-- txn, err := d.db.BeginTx(ctx, &sql.TxOptions{ReadOnly: true})- if err != nil {- return nil, err- }- defer txn.Rollback()-- tables, err := getTables(txn)- if err != nil {- return nil, err- }- schemaMetadata.Tables = tables-- views, err := getViews(txn)- if err != nil {- return nil, err- }- schemaMetadata.Views = views-- if err := txn.Commit(); err != nil {- return nil, err- }-- return databaseMetadata, nil-}--// getTables gets all tables of a database.-func getTables(txn *sql.Tx) ([]*storepb.TableMetadata, error) {- indexMap, err := getIndices(txn)- if err != nil {- return nil, errors.Wrapf(err, "failed to get indices")- }-- var tableNames []string- query := `- SELECT- name- FROM sqlite_schema- WHERE type ='table' AND name NOT LIKE 'sqlite_%'- ORDER BY name;`- rows, err := txn.Query(query)- if err != nil {- return nil, err- }- defer rows.Close()- for rows.Next() {- var name string- if err := rows.Scan(&name); err != nil {- return nil, err- }- tableNames = append(tableNames, name)- }- if err := rows.Err(); err != nil {- return nil, util.FormatErrorWithQuery(err, query)- }-- var tables []*storepb.TableMetadata- for _, name := range tableNames {- table := &storepb.TableMetadata{- Name: name,- }- if err := func() error {- // Get columns: cid, name, type, notnull, dflt_value, pk.- query := fmt.Sprintf("pragma table_info(%s);", name)- rows, err := txn.Query(query)- if err != nil {- return err- }- defer rows.Close()- for rows.Next() {- column := &storepb.ColumnMetadata{}- var notNull, unusedPk bool- var defaultStr sql.NullString- if err := rows.Scan(&column.Position, &column.Name, &column.Type, ¬Null, &defaultStr, &unusedPk); err != nil {- return err- }- column.Nullable = !notNull- if defaultStr.Valid {- // TODO: use correct default type- column.Default = defaultStr.String- }-- table.Columns = append(table.Columns, column)- table.Indexes = indexMap[table.Name]- }- return rows.Err()- }(); err != nil {- return nil, err- }-- tables = append(tables, table)- }- return tables, nil-}--// getIndices gets all indices of a database.-func getIndices(txn *sql.Tx) (map[string][]*storepb.IndexMetadata, error) {- indexMap := make(map[string][]*storepb.IndexMetadata)- query := `- SELECT- tbl_name, name, sql- FROM sqlite_schema- WHERE type ='index' AND name NOT LIKE 'sqlite_%'- ORDER BY tbl_name, name;`- rows, err := txn.Query(query)- if err != nil {- return nil, err- }- defer rows.Close()-- for rows.Next() {- var tableName, statement string- index := &storepb.IndexMetadata{}- if err := rows.Scan(&tableName, &index.Name, &statement); err != nil {- return nil, err- }- index.Unique = strings.Contains(statement, " UNIQUE INDEX ")- indexMap[tableName] = append(indexMap[tableName], index)- }- if err := rows.Err(); err != nil {- return nil, util.FormatErrorWithQuery(err, query)- }-- for _, indexes := range indexMap {- for _, index := range indexes {- if err := func() error {- query := fmt.Sprintf("pragma index_info(%s);", index.Name)- rows, err := txn.Query(query)- if err != nil {- return err- }- defer rows.Close()- for rows.Next() {- var unusedPosition int- var unusedCid, expression string- if err := rows.Scan(&unusedPosition, &unusedCid, &expression); err != nil {- return err- }- index.Expressions = append(index.Expressions, expression)- }- if err := rows.Err(); err != nil {- return util.FormatErrorWithQuery(err, query)- }- return nil- }(); err != nil {- return nil, err- }- }- }-- return indexMap, nil-}--func getViews(txn *sql.Tx) ([]*storepb.ViewMetadata, error) {- var views []*storepb.ViewMetadata-- query := `- SELECT- name, sql- FROM sqlite_schema- WHERE type ='view' AND name NOT LIKE 'sqlite_%'- ORDER BY name;`- rows, err := txn.Query(query)- if err != nil {- return nil, err- }- defer rows.Close()- for rows.Next() {- view := &storepb.ViewMetadata{}- if err := rows.Scan(&view.Name, &view.Definition); err != nil {- return nil, err- }- views = append(views, view)- }- if err := rows.Err(); err != nil {- return nil, util.FormatErrorWithQuery(err, query)- }-- return views, nil-}diff --git a/backend/plugin/parser/standard/query.go b/backend/plugin/parser/standard/query.goindex 753c0ee5cf..27e3350361 100644--- a/backend/plugin/parser/standard/query.go+++ b/backend/plugin/parser/standard/query.go@@ -13,7 +13,6 @@ import (func init() {base.RegisterQueryValidator(storepb.Engine_CLICKHOUSE, ValidateSQLForEditor)- base.RegisterQueryValidator(storepb.Engine_SQLITE, ValidateSQLForEditor)base.RegisterQueryValidator(storepb.Engine_SPANNER, ValidateSQLForEditor)base.RegisterQueryValidator(storepb.Engine_HIVE, ValidateSQLForEditor)base.RegisterQueryValidator(storepb.Engine_BIGQUERY, ValidateSQLForEditor)diff --git a/backend/plugin/parser/standard/split.go b/backend/plugin/parser/standard/split.goindex 83f152af6e..47d1b76401 100644--- a/backend/plugin/parser/standard/split.go+++ b/backend/plugin/parser/standard/split.go@@ -14,7 +14,6 @@ import (func init() {base.RegisterSplitterFunc(storepb.Engine_CLICKHOUSE, SplitSQL)- base.RegisterSplitterFunc(storepb.Engine_SQLITE, SplitSQL)base.RegisterSplitterFunc(storepb.Engine_HIVE, SplitSQL)base.RegisterSplitterFunc(storepb.Engine_DATABRICKS, SplitSQL)}diff --git a/backend/plugin/schema/index_comparer.go b/backend/plugin/schema/index_comparer.goindex fee6b3355d..12065f2652 100644--- a/backend/plugin/schema/index_comparer.go+++ b/backend/plugin/schema/index_comparer.go@@ -83,7 +83,6 @@ func init() {RegisterIndexComparer(storepb.Engine_TIDB, defaultComparer)RegisterIndexComparer(storepb.Engine_ORACLE, defaultComparer)RegisterIndexComparer(storepb.Engine_MSSQL, defaultComparer)- RegisterIndexComparer(storepb.Engine_SQLITE, defaultComparer)RegisterIndexComparer(storepb.Engine_MONGODB, defaultComparer)RegisterIndexComparer(storepb.Engine_REDIS, defaultComparer)RegisterIndexComparer(storepb.Engine_SNOWFLAKE, defaultComparer)diff --git a/backend/server/ultimate.go b/backend/server/ultimate.goindex f050a2ab42..d34a113152 100644--- a/backend/server/ultimate.go+++ b/backend/server/ultimate.go@@ -20,7 +20,6 @@ import (_ "github.com/bytebase/bytebase/backend/plugin/db/redshift"_ "github.com/bytebase/bytebase/backend/plugin/db/snowflake"_ "github.com/bytebase/bytebase/backend/plugin/db/spanner"- _ "github.com/bytebase/bytebase/backend/plugin/db/sqlite"_ "github.com/bytebase/bytebase/backend/plugin/db/starrocks"_ "github.com/bytebase/bytebase/backend/plugin/db/tidb"_ "github.com/bytebase/bytebase/backend/plugin/db/trino"diff --git a/backend/tests/action_test.go b/backend/tests/action_test.goindex 39697f31b9..9e8162bc19 100644--- a/backend/tests/action_test.go+++ b/backend/tests/action_test.go@@ -42,7 +42,7 @@ func TestActionCheckCommand(t *testing.T) {// Create a valid migration filemigrationContent := `CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`@@ -72,7 +72,7 @@ func TestActionCheckCommand(t *testing.T) {Name: database.Name + "/metadata",}))a.NoError(err)- // Verify no user tables exist (only SQLite system tables)+ // Verify no user tables existfor _, schema := range metadata.Msg.Schemas {for _, table := range schema.Tables {a.NotEqual("users", table.Name, "Check command should not create tables")@@ -114,7 +114,7 @@ func TestActionCheckCommand(t *testing.T) {// Create a valid migration filemigrationContent := `CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`@@ -144,7 +144,7 @@ func TestActionCheckCommand(t *testing.T) {Name: database.Name + "/metadata",}))a.NoError(err)- // Verify no user tables exist (only SQLite system tables)+ // Verify no user tables existfor _, schema := range metadata.Msg.Schemas {for _, table := range schema.Tables {a.NotEqual("users", table.Name, "Check command should not create tables")@@ -183,7 +183,7 @@ func TestActionCheckCommand(t *testing.T) {a.NoError(err)// Execute check with file that has syntax errors- result, err := executeActionCommand(ctx,+ _, err = executeActionCommand(ctx,"check","--url", ctl.rootURL,"--service-account", "[email protected]",@@ -193,17 +193,11 @@ func TestActionCheckCommand(t *testing.T) {"--file-pattern", filepath.Join(testDataDir, "00001_syntax_error.sql"),"--check-release", "FAIL_ON_ERROR",)- a.NoError(err)-- // The command may or may not fail depending on how syntax errors are handled- // The key verification is that syntax issues are detected and reported- // E2E Verification for check command with syntax errors:- // The check should detect syntax errors without modifying databases-- // The command should complete successfully regardless of syntax issues in the SQL- // The check API validates the request but may not deeply parse SQL syntax- a.NoError(result.Error, "Command should complete successfully")+ // Postgres parses the statement, so the release check reports the syntax+ // error and FAIL_ON_ERROR makes the command exit with an error.+ a.Error(err)+ a.Contains(err.Error(), "error(s) in release check")// Verify NO database changes occurredmetadata, err := ctl.databaseServiceClient.GetDatabaseMetadata(ctx, connect.NewRequest(&v1pb.GetDatabaseMetadataRequest{@@ -533,24 +527,21 @@ func executeActionCommand(ctx context.Context, args ...string) (*ActionResult, e}, err}-// createTestDatabase creates a test SQLite database instance and database+// createTestDatabase creates a test Postgres database instance and databasefunc (ctl *controller) createTestDatabase(ctx context.Context, t *testing.T) *v1pb.Database {a := require.New(t)- // Create SQLite instance- instanceDir := t.TempDir()+ // Create Postgres instance+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst")[:8],Instance: &v1pb.Instance{Title: "Test Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -672,7 +663,7 @@ func TestActionRolloutCommand(t *testing.T) {// Create test data directory and migration filetestDataDir := t.TempDir()migrationContent := `CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`@@ -808,7 +799,7 @@ func TestActionRolloutCommand(t *testing.T) {// Create 00001_create_users.sqlmigrationContent1 := `CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`@@ -1675,7 +1666,7 @@ func TestActionErrorScenarios(t *testing.T) {// Create test data directory and migration filetestDataDir := t.TempDir()migrationContent := `CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`@@ -1710,7 +1701,7 @@ func TestActionErrorScenarios(t *testing.T) {// Create test data directory and migration filetestDataDir := t.TempDir()migrationContent := `CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`diff --git a/backend/tests/approval_test.go b/backend/tests/approval_test.goindex 2662c8c70a..8f74ebcce5 100644--- a/backend/tests/approval_test.go+++ b/backend/tests/approval_test.go@@ -34,19 +34,16 @@ func TestDirectApprovalRuleMatching(t *testing.T) {defer ctl.Close(ctx)// Create instance in prod environment- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Prod Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -69,7 +66,7 @@ func TestDirectApprovalRuleMatching(t *testing.T) {{Source: v1pb.WorkspaceApprovalSetting_Rule_CHANGE_DATABASE,Condition: &expr.Expr{- Expression: `resource.db_engine == "SQLITE"`, // Use db_engine to test CEL with variables+ Expression: `resource.db_engine == "POSTGRES"`, // Use db_engine to test CEL with variables},Template: &v1pb.ApprovalTemplate{Title: "Prod Change Database Approval",@@ -165,19 +162,16 @@ func TestApprovalFindingRerunsPlanCheckForStaleApprovalInputVersion(t *testing.Ta.NoError(err)t.Cleanup(func() { _ = ctl.Close(ctx) })- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Approval Input Version Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -201,7 +195,7 @@ func TestApprovalFindingRerunsPlanCheckForStaleApprovalInputVersion(t *testing.TExpression: `statement.text.contains("stale_approval_b")`,},Template: &v1pb.ApprovalTemplate{- Title: "SQLite change approval B",+ Title: "Postgres change approval B",Flow: &v1pb.ApprovalFlow{Roles: []string{"roles/workspaceOwner"},},@@ -213,7 +207,7 @@ func TestApprovalFindingRerunsPlanCheckForStaleApprovalInputVersion(t *testing.TExpression: `statement.text.contains("stale_approval_a")`,},Template: &v1pb.ApprovalTemplate{- Title: "SQLite change approval A",+ Title: "Postgres change approval A",Flow: &v1pb.ApprovalFlow{Roles: []string{"roles/workspaceOwner"},},@@ -276,7 +270,7 @@ func TestApprovalFindingRerunsPlanCheckForStaleApprovalInputVersion(t *testing.TgotIssueResp, err := ctl.issueServiceClient.GetIssue(ctx, connect.NewRequest(&v1pb.GetIssueRequest{Name: issueResp.Msg.Name}))a.NoError(err)a.NotEqual(v1pb.ApprovalStatus_CHECKING, gotIssueResp.Msg.ApprovalStatus)- a.Equal("SQLite change approval A", gotIssueResp.Msg.GetApprovalTemplate().GetTitle())+ a.Equal("Postgres change approval A", gotIssueResp.Msg.GetApprovalTemplate().GetTitle())updatedPlanResp, err := ctl.planServiceClient.UpdatePlan(ctx, connect.NewRequest(&v1pb.UpdatePlanRequest{Plan: &v1pb.Plan{@@ -300,7 +294,7 @@ func TestApprovalFindingRerunsPlanCheckForStaleApprovalInputVersion(t *testing.TgotIssueResp, err = ctl.issueServiceClient.GetIssue(ctx, connect.NewRequest(&v1pb.GetIssueRequest{Name: issueResp.Msg.Name}))a.NoError(err)a.NotEqual(v1pb.ApprovalStatus_CHECKING, gotIssueResp.Msg.ApprovalStatus)- a.Equal("SQLite change approval B", gotIssueResp.Msg.GetApprovalTemplate().GetTitle())+ a.Equal("Postgres change approval B", gotIssueResp.Msg.GetApprovalTemplate().GetTitle())checkResp, err := ctl.planServiceClient.GetPlanCheckRun(ctx, connect.NewRequest(&v1pb.GetPlanCheckRunRequest{Name: fmt.Sprintf("%s/planCheckRun", updatedPlanResp.Msg.Name),@@ -381,19 +375,16 @@ func createStaleApprovalInputVersionIssue(ctx context.Context, t *testing.T, ctlt.Helper()project := ctl.createTestProject(ctx, t, suffix)- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ require.NoError(t, err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Stale Approval Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))require.NoError(t, err)@@ -509,19 +500,16 @@ func TestApprovalRuleFirstMatchWins(t *testing.T) {defer ctl.Close(ctx)// Create instance in prod environment- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Prod Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -654,19 +642,16 @@ func TestApprovalRuleNoMatch(t *testing.T) {defer ctl.Close(ctx)// Create instance in test environment (not prod)- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Test Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/test"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -855,19 +840,16 @@ func TestFallbackRuleMatchesWhenSourceSpecificDoesNot(t *testing.T) {defer ctl.Close(ctx)// Create instance in TEST environment (not prod)- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Test Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/test"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -994,19 +976,16 @@ func TestSourceSpecificRuleTakesPriorityOverFallback(t *testing.T) {defer ctl.Close(ctx)// Create instance in prod environment- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Prod Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -1145,19 +1124,16 @@ func TestSelfApprovalBlocked(t *testing.T) {project := projectResp.Msg// Create instance- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Prod Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/collision_helper_test.go b/backend/tests/collision_helper_test.goindex 42f1ba9aae..0f4412101f 100644--- a/backend/tests/collision_helper_test.go+++ b/backend/tests/collision_helper_test.go@@ -50,7 +50,7 @@ type collisionFixture struct {// setupCollidingProjects creates two projects with naturally colliding ids.//// Both projects get a plan → issue → rollout with a DML task targeting-// separate databases on the same SQLite instance. Because nextProjectID+// separate databases on the same Postgres instance. Because nextProjectID// allocates per-project, the first plan/task/task_run/plan_check_run in// each project receives the same numeric id.//@@ -76,18 +76,17 @@ func setupCollidingProjects(}))a.NoError(err)- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "collision-instance")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("col-inst"),Instance: &v1pb.Instance{Title: "collision-instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -208,7 +207,7 @@ func setupCollidingProjects(}// setupCollidingProjectsSeparateInstances is a variant of setupCollidingProjects-// that places each project on its own SQLite instance. Useful for tests that+// that places each project on its own Postgres instance. Useful for tests that// need to distinguish correct per-instance cascade from a buggy cross-project// DELETE USING predicate. Project A's rollout is driven to DONE; project B's// rollout is left for the caller to trigger.@@ -232,8 +231,8 @@ func setupCollidingProjectsSeparateInstances(}))a.NoError(err)- instA := createSQLiteInstance(ctx, t, ctl, "col-inst-a")- instB := createSQLiteInstance(ctx, t, ctl, "col-inst-b")+ instA := createPgInstance(ctx, t, ctl, "col-inst-a")+ instB := createPgInstance(ctx, t, ctl, "col-inst-b")const dbNameA = "collision_db_a"a.NoError(ctl.createDatabase(ctx, projectA.Msg, instA, nil, dbNameA, ""))@@ -454,20 +453,21 @@ func listTaskRunAndTaskUIDs(ctx context.Context, t *testing.T, ctl *controller,return taskRunUIDs, taskUIDs}-// createSQLiteInstance provisions and registers a SQLite instance for test use.-func createSQLiteInstance(ctx context.Context, t *testing.T, ctl *controller, titlePrefix string) *v1pb.Instance {+// createPgInstance provisions a dedicated Postgres container and registers it+// as an instance for test use.+func createPgInstance(ctx context.Context, t *testing.T, ctl *controller, titlePrefix string) *v1pb.Instance {t.Helper()a := require.New(t)- instanceDir, err := ctl.provisionSQLiteInstance(t.TempDir(), titlePrefix)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)resp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString(titlePrefix),Instance: &v1pb.Instance{Title: titlePrefix,- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/data_source_test.go b/backend/tests/data_source_test.goindex 2ed615bf4f..4bf9c143b6 100644--- a/backend/tests/data_source_test.go+++ b/backend/tests/data_source_test.go@@ -19,19 +19,17 @@ func TestDataSource(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceName := "testInstance1"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Id: "admin-ds", Host: instanceDir}},+ DataSources: []*v1pb.DataSource{pgContainer.dataSource(v1pb.DataSourceType_ADMIN, "admin-ds")},},}))instance := instanceResp.Msg@@ -40,12 +38,8 @@ func TestDataSource(t *testing.T) {err = ctl.removeLicense(ctx)a.NoError(err)_, err = ctl.instanceServiceClient.AddDataSource(ctx, connect.NewRequest(&v1pb.AddDataSourceRequest{- Name: instance.Name,- DataSource: &v1pb.DataSource{- Id: "readonly-validate-only",- Type: v1pb.DataSourceType_READ_ONLY,- Host: instanceDir,- },+ Name: instance.Name,+ DataSource: pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly-validate-only"),ValidateOnly: true,}))a.ErrorContains(err, "TEAM feature, please upgrade to access it")@@ -133,13 +127,13 @@ func TestDataSource(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "invalid",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,DataSources: []*v1pb.DataSource{- {Type: v1pb.DataSourceType_ADMIN, Id: "admin", Host: instanceDir},- {Type: v1pb.DataSourceType_READ_ONLY, Id: "readonly-1", Host: instanceDir},- {Type: v1pb.DataSourceType_READ_ONLY, Id: "readonly-2", Host: instanceDir},+ pgContainer.adminDataSource(),+ pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly-1"),+ pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly-2"),},},}))@@ -149,9 +143,9 @@ func TestDataSource(t *testing.T) {Instance: &v1pb.Instance{Name: instance.Name,DataSources: []*v1pb.DataSource{- {Type: v1pb.DataSourceType_ADMIN, Id: "admin-ds", Host: instanceDir},+ pgContainer.dataSource(v1pb.DataSourceType_ADMIN, "admin-ds"),{Type: v1pb.DataSourceType_READ_ONLY, Id: "readonly", Username: "ro_ds", Host: "127.0.0.1", Port: "8000"},- {Type: v1pb.DataSourceType_READ_ONLY, Id: "readonly-2", Host: instanceDir},+ pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly-2"),},},UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"data_sources"}},@@ -173,19 +167,17 @@ func TestDataSourceValidateOnly(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceName := "testInstanceValidateOnly"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Id: "admin-ds", Host: instanceDir}},+ DataSources: []*v1pb.DataSource{pgContainer.dataSource(v1pb.DataSourceType_ADMIN, "admin-ds")},},}))a.NoError(err)@@ -195,12 +187,8 @@ func TestDataSourceValidateOnly(t *testing.T) {a.NoError(err)addResp, err := ctl.instanceServiceClient.AddDataSource(ctx, connect.NewRequest(&v1pb.AddDataSourceRequest{- Name: instance.Name,- DataSource: &v1pb.DataSource{- Id: "readonly-validate-only",- Type: v1pb.DataSourceType_READ_ONLY,- Host: instanceDir,- },+ Name: instance.Name,+ DataSource: pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly-validate-only"),ValidateOnly: true,}))a.NoError(err)@@ -213,12 +201,8 @@ func TestDataSourceValidateOnly(t *testing.T) {a.Nil(findDataSource(instanceResp.Msg.DataSources, "readonly-validate-only"))updateResp, err := ctl.instanceServiceClient.UpdateDataSource(ctx, connect.NewRequest(&v1pb.UpdateDataSourceRequest{- Name: instance.Name,- DataSource: &v1pb.DataSource{- Id: "readonly-allow-missing",- Type: v1pb.DataSourceType_READ_ONLY,- Host: instanceDir,- },+ Name: instance.Name,+ DataSource: pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly-allow-missing"),UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"host"}},ValidateOnly: true,AllowMissing: true,@@ -233,15 +217,15 @@ func TestDataSourceValidateOnly(t *testing.T) {a.Nil(findDataSource(instanceResp.Msg.DataSources, "readonly-allow-missing"))_, err = ctl.instanceServiceClient.AddDataSource(ctx, connect.NewRequest(&v1pb.AddDataSourceRequest{- Name: instance.Name,- DataSource: &v1pb.DataSource{- Id: "readonly",- Type: v1pb.DataSourceType_READ_ONLY,- Host: instanceDir,- },+ Name: instance.Name,+ DataSource: pgContainer.dataSource(v1pb.DataSourceType_READ_ONLY, "readonly"),}))a.NoError(err)+ // Create the role so the validate-only connection test with the updated username succeeds.+ _, err = pgContainer.db.Exec(`CREATE ROLE "updated-user" LOGIN PASSWORD 'root-password'`)+ a.NoError(err)+updateResp, err = ctl.instanceServiceClient.UpdateDataSource(ctx, connect.NewRequest(&v1pb.UpdateDataSourceRequest{Name: instance.Name,DataSource: &v1pb.DataSource{@@ -260,7 +244,7 @@ func TestDataSourceValidateOnly(t *testing.T) {a.NoError(err)persisted := findDataSource(instanceResp.Msg.DataSources, "readonly")a.NotNil(persisted)- a.Equal("", persisted.Username)+ a.Equal("postgres", persisted.Username)}func findDataSource(dataSources []*v1pb.DataSource, id string) *v1pb.DataSource {diff --git a/backend/tests/database.go b/backend/tests/database.goindex b1f6325d4f..6a0ac3eb5a 100644--- a/backend/tests/database.go+++ b/backend/tests/database.go@@ -15,6 +15,9 @@ func (ctl *controller) createDatabase(ctx context.Context, project *v1pb.Projectif instance.Engine == v1pb.Engine_POSTGRES {characterSet = "UTF8"collation = "en_US.UTF-8"+ if owner == "" {+ owner = "postgres"+ }}environmentName := ""if environment != nil {diff --git a/backend/tests/environment_test.go b/backend/tests/environment_test.goindex 23f92231b3..96d5cd2618 100644--- a/backend/tests/environment_test.go+++ b/backend/tests/environment_test.go@@ -20,9 +20,7 @@ func TestDatabaseEnvironment(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceName := "testInstance1"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)prodEnvironment, err := ctl.getEnvironment(ctx, "prod")@@ -34,10 +32,10 @@ func TestDatabaseEnvironment(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new(prodEnvironment.Name),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Id: "admin-ds", Host: instanceDir}},+ DataSources: []*v1pb.DataSource{pgContainer.dataSource(v1pb.DataSourceType_ADMIN, "admin-ds")},},}))a.NoError(err)diff --git a/backend/tests/gitops_test.go b/backend/tests/gitops_test.goindex 232af4ea90..91e7f135cf 100644--- a/backend/tests/gitops_test.go+++ b/backend/tests/gitops_test.go@@ -43,12 +43,10 @@ func TestGitOpsCheck(t *testing.T) {project := projectResp.Msg// Provision test and prod instances.- instanceRootDir := t.TempDir()-- testInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "gitops-check-test")+ testPgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)- prodInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "gitops-check-prod")+ prodPgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)// Add the provisioned instances.@@ -56,10 +54,10 @@ func TestGitOpsCheck(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "gitops-check-test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/test"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: testInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{testPgContainer.adminDataSource()},},}))a.NoError(err)@@ -69,10 +67,10 @@ func TestGitOpsCheck(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "gitops-check-prod",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: prodInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{prodPgContainer.adminDataSource()},},}))a.NoError(err)@@ -93,10 +91,10 @@ func TestGitOpsCheck(t *testing.T) {Path: "migrations/001__create_users_table.sql",Version: "001",Statement: []byte(`CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL UNIQUE,email TEXT NOT NULL,- created_at DATETIME DEFAULT CURRENT_TIMESTAMP+ created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`),},{@@ -601,7 +599,7 @@ func createGitOpsVCSUserTestProject(ctx context.Context, t *testing.T, ctl *contfunc createGitOpsVCSUserTestTarget(ctx context.Context, t *testing.T, ctl *controller, project *v1pb.Project) string {t.Helper()- instance := createSQLiteInstance(ctx, t, ctl, "gitops-vcs-user")+ instance := createPgInstance(ctx, t, ctl, "gitops-vcs-user")databaseName := generateRandomString("gitops_vcs_user")require.NoError(t, ctl.createDatabase(ctx, project, instance, nil, databaseName, ""))return fmt.Sprintf("%s/databases/%s", instance.Name, databaseName)@@ -643,9 +641,7 @@ func TestGitOpsRollout(t *testing.T) {project := projectResp.Msg// Provision test instance.- instanceRootDir := t.TempDir()-- testInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "gitops-rollout-test")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)// Add the provisioned instance.@@ -653,10 +649,10 @@ func TestGitOpsRollout(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "gitops-rollout-test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/test"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: testInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -677,11 +673,11 @@ func TestGitOpsRollout(t *testing.T) {Path: "migrations/001__create_products_table.sql",Version: "001",Statement: []byte(`CREATE TABLE products (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,name TEXT NOT NULL,price DECIMAL(10,2) NOT NULL,description TEXT,- created_at DATETIME DEFAULT CURRENT_TIMESTAMP+ created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`),},},@@ -753,8 +749,8 @@ func TestGitOpsRollout(t *testing.T) {a.NoError(err)testDBSchema := testDBSchemaResp.Msga.Contains(testDBSchema.Schema, "products")- a.Contains(testDBSchema.Schema, "id INTEGER PRIMARY KEY AUTOINCREMENT")- a.Contains(testDBSchema.Schema, "name TEXT NOT NULL")+ a.Contains(testDBSchema.Schema, "\"id\" integer DEFAULT nextval")+ a.Contains(testDBSchema.Schema, "\"name\" text NOT NULL")// Verify database revision after migration using RevisionService.revisionsResp, err := ctl.revisionServiceClient.ListRevisions(ctx, connect.NewRequest(&v1pb.ListRevisionsRequest{@@ -947,12 +943,10 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {project := projectResp.Msg// Provision test and prod instances.- instanceRootDir := t.TempDir()-- testInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "gitops-multi-test")+ testPgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)- prodInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "gitops-multi-prod")+ prodPgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)// Add the provisioned instances.@@ -960,10 +954,10 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "gitops-multi-test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/test"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: testInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{testPgContainer.adminDataSource()},},}))a.NoError(err)@@ -973,10 +967,10 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "gitops-multi-prod",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: prodInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{prodPgContainer.adminDataSource()},},}))a.NoError(err)@@ -999,7 +993,7 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {Path: "migrations/1.0.0__create_table_one.sql",Version: "1.0.0",Statement: []byte(`CREATE TABLE table_one (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,name TEXT NOT NULL);`),},@@ -1007,7 +1001,7 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {Path: "migrations/1.0.1__create_table_two.sql",Version: "1.0.1",Statement: []byte(`CREATE TABLE table_two (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,value TEXT NOT NULL);`),},@@ -1015,7 +1009,7 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {Path: "migrations/1.0.2__create_table_three.sql",Version: "1.0.2",Statement: []byte(`CREATE TABLE table_three (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,data TEXT NULL);`),},@@ -1094,9 +1088,9 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {a.Contains(testDBSchema.Schema, "table_one")a.Contains(testDBSchema.Schema, "table_two")a.Contains(testDBSchema.Schema, "table_three")- a.Contains(testDBSchema.Schema, "name TEXT NOT NULL")- a.Contains(testDBSchema.Schema, "value TEXT NOT NULL")- a.Contains(testDBSchema.Schema, "data TEXT")+ a.Contains(testDBSchema.Schema, "\"name\" text NOT NULL")+ a.Contains(testDBSchema.Schema, "\"value\" text NOT NULL")+ a.Contains(testDBSchema.Schema, "\"data\" text")// Verify schema changes were applied to prod database.prodDBSchemaResp, err := ctl.databaseServiceClient.GetDatabaseSchema(ctx, connect.NewRequest(&v1pb.GetDatabaseSchemaRequest{@@ -1109,9 +1103,9 @@ func TestGitOpsRolloutMultiTarget(t *testing.T) {a.Contains(prodDBSchema.Schema, "table_one")a.Contains(prodDBSchema.Schema, "table_two")a.Contains(prodDBSchema.Schema, "table_three")- a.Contains(prodDBSchema.Schema, "name TEXT NOT NULL")- a.Contains(prodDBSchema.Schema, "value TEXT NOT NULL")- a.Contains(prodDBSchema.Schema, "data TEXT")+ a.Contains(prodDBSchema.Schema, "\"name\" text NOT NULL")+ a.Contains(prodDBSchema.Schema, "\"value\" text NOT NULL")+ a.Contains(prodDBSchema.Schema, "\"data\" text")// Additional verification: Ensure both databases have identical schemas.a.Equal(testDBSchema.Schema, prodDBSchema.Schema, "Test and prod databases should have identical schemas after deployment")@@ -1195,8 +1189,7 @@ func TestGitOpsCheckAppliedButChanged(t *testing.T) {project := projectResp.Msg// Provision test instance.- instanceRootDir := t.TempDir()- testInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "gitops-changed-test")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)// Add the provisioned instance.@@ -1204,10 +1197,10 @@ func TestGitOpsCheckAppliedButChanged(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "gitops-changed-test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/test"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: testInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -1226,7 +1219,7 @@ func TestGitOpsCheckAppliedButChanged(t *testing.T) {Path: "migrations/1.0.0__create_users_table.sql",Version: "1.0.0",Statement: []byte(`CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL,email TEXT NOT NULL);`),@@ -1292,11 +1285,11 @@ func TestGitOpsCheckAppliedButChanged(t *testing.T) {Path: "migrations/1.0.0__create_users_table.sql",Version: "1.0.0",Statement: []byte(`CREATE TABLE users (- id INTEGER PRIMARY KEY AUTOINCREMENT,+ id SERIAL PRIMARY KEY,username TEXT NOT NULL,email TEXT NOT NULL,phone TEXT,- created_at DATETIME DEFAULT CURRENT_TIMESTAMP+ created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP);`),},},diff --git a/backend/tests/grouping_change_test.go b/backend/tests/grouping_change_test.goindex f6c4855f51..f27f3236c2 100644--- a/backend/tests/grouping_change_test.go+++ b/backend/tests/grouping_change_test.go@@ -15,7 +15,7 @@ import (// TestCreateDatabaseGroup tests creating database and verify the grouping result.// For each test case:-// 1. The test provides a number of sqlite instances equal to the number of prepareInstances and creates the specified matchDatabase and unmatchedDatabase in the corresponding instances.+// 1. The test provides a number of Postgres instances equal to the number of prepareInstances and creates the specified matchDatabase and unmatchedDatabase in the corresponding instances.// 2. The database group is then created with the specified expr.// 3. The results obtained are compared with the results given in prepareInstance and they should be consistent.func TestCreateDatabaseGroup(t *testing.T) {@@ -120,16 +120,16 @@ func TestCreateDatabaseGroup(t *testing.T) {instanceResourceID2InstanceTitle := make(map[string]string)for _, prepareInstance := range tc.prepareInstances {- instanceDir, err := ctl.provisionSQLiteInstance(t.TempDir(), t.Name())+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResourceID := generateRandomString("instance")instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: instanceResourceID,Instance: &v1pb.Instance{Title: prepareInstance.instanceTitle,- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},Activation: true,},}))diff --git a/backend/tests/instance_create_project_test.go b/backend/tests/instance_create_project_test.goindex 470156119c..b176e0ba1e 100644--- a/backend/tests/instance_create_project_test.go+++ b/backend/tests/instance_create_project_test.go@@ -2,14 +2,11 @@ package testsimport ("context"- "database/sql""fmt"- "path/filepath""strings""testing""connectrpc.com/connect"- _ "github.com/mattn/go-sqlite3""github.com/stretchr/testify/require"v1pb "github.com/bytebase/bytebase/backend/generated-go/v1"@@ -24,21 +21,20 @@ func TestCreateInstanceAssignsSyncedDatabasesToProject(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "project-aware-sync")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)databaseName := "project_assignment"- createSQLiteDatabase(t, instanceDir, databaseName)+ createPgDatabase(t, pgContainer, databaseName)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),InitialDatabaseProject: ctl.project.Name,Instance: &v1pb.Instance{Title: "project-aware-sync",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -60,20 +56,19 @@ func TestCreateInstanceWithoutProjectKeepsDefaultProject(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "default-project-sync")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)databaseName := "default_project_assignment"- createSQLiteDatabase(t, instanceDir, databaseName)+ createPgDatabase(t, pgContainer, databaseName)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "default-project-sync",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -96,20 +91,19 @@ func TestCreateInstanceWithEmptySyncDatabasesSkipsInitialDatabaseSync(t *testinga.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "skip-initial-database-sync")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)databaseName := "unsynced_database"- createSQLiteDatabase(t, instanceDir, databaseName)+ createPgDatabase(t, pgContainer, databaseName)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "skip-initial-database-sync",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},SyncDatabases: &v1pb.SyncDatabases{},},}))@@ -135,33 +129,28 @@ func TestListInstanceDatabaseBeforeCreate(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "preview-databases")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)databaseName := "preview_database"- createSQLiteDatabase(t, instanceDir, databaseName)+ createPgDatabase(t, pgContainer, databaseName)resp, err := ctl.instanceServiceClient.ListInstanceDatabase(ctx, connect.NewRequest(&v1pb.ListInstanceDatabaseRequest{Name: fmt.Sprintf("instances/%s", generateRandomString("instance")),Instance: &v1pb.Instance{Title: "preview-databases",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)a.Contains(resp.Msg.Databases, databaseName)}-func createSQLiteDatabase(t *testing.T, dir, databaseName string) {+func createPgDatabase(t *testing.T, pgContainer *Container, databaseName string) {t.Helper()- db, err := sql.Open("sqlite3", filepath.Join(dir, fmt.Sprintf("%s.db", databaseName)))- require.NoError(t, err)- defer db.Close()-- _, err = db.Exec("CREATE TABLE t(id INTEGER PRIMARY KEY)")+ _, err := pgContainer.db.Exec(fmt.Sprintf("CREATE DATABASE %s", databaseName))require.NoError(t, err)}diff --git a/backend/tests/maximum_request_expiration_test.go b/backend/tests/maximum_request_expiration_test.goindex e3856c63b3..22ebaf6186 100644--- a/backend/tests/maximum_request_expiration_test.go+++ b/backend/tests/maximum_request_expiration_test.go@@ -189,19 +189,16 @@ func TestAccessGrantMaximumExpiration(t *testing.T) {defer ctl.Close(ctx)// Create an instance and database to target.- instanceDir := t.TempDir()+ pgContainer, err := provisionPgInstance(ctx, t)+ a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("inst"),Instance: &v1pb.Instance{Title: "Test Instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{- Type: v1pb.DataSourceType_ADMIN,- Host: instanceDir,- Id: "admin",- }},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/plan_update_test.go b/backend/tests/plan_update_test.goindex f3309c86ff..baa44a667a 100644--- a/backend/tests/plan_update_test.go+++ b/backend/tests/plan_update_test.go@@ -13,7 +13,7 @@ import (v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")-// planUpdateFixture holds a project + sqlite instance + database + two sheets+// planUpdateFixture holds a project + Postgres instance + database + two sheets// + plan + linked issue, ready for tests that mutate the plan and inspect// the resulting issue_comment audit rows.type planUpdateFixture struct {@@ -38,18 +38,17 @@ func setupPlanUpdateFixture(t *testing.T, withIssue bool) *planUpdateFixture {a.NoError(err)t.Cleanup(func() { _ = ctl.Close(ctx) })- instanceRootDir := t.TempDir()instanceName := "planUpdateInstance_" + generateRandomString("inst")- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: instanceName,- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/project_test.go b/backend/tests/project_test.goindex b6afa31bb1..97154eca51 100644--- a/backend/tests/project_test.go+++ b/backend/tests/project_test.go@@ -19,9 +19,7 @@ func TestArchiveProject(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceName := "testInstance1"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)// Add an instance.@@ -29,10 +27,10 @@ func TestArchiveProject(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "test",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/schema_update_test.go b/backend/tests/schema_update_test.goindex afd5883bd1..b1a7cd9b28 100644--- a/backend/tests/schema_update_test.go+++ b/backend/tests/schema_update_test.go@@ -26,19 +26,18 @@ func TestSchemaAndDataUpdate(t *testing.T) {defer ctl.Close(ctx)// Provision an instance.- instanceRootDir := t.TempDir()instanceName := "testInstance1"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: instanceName,- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -95,9 +94,10 @@ func TestSchemaAndDataUpdate(t *testing.T) {changelogs := resp.Msg.Changelogs// Expect 3 changelogs: 2 migrations + baseline (auto-created on first migration)a.Equal(3, len(changelogs))- // First changelog should be the data update migration (most recent)+ // First changelog should be the data update migration (most recent).+ // DML-only migrations skip the schema dump, so it carries no schema.a.Equal(v1pb.Changelog_DONE, changelogs[0].Status)- a.Equal(dumpedSchema, changelogs[0].Schema)+ a.Empty(changelogs[0].Schema)// Second changelog should be the schema migrationa.Equal(v1pb.Changelog_DONE, changelogs[1].Status)a.Equal(dumpedSchema, changelogs[1].Schema)@@ -330,9 +330,8 @@ func TestMarkTaskAsDone(t *testing.T) {defer ctl.Close(ctx)// Provision an instance.- instanceRootDir := t.TempDir()instanceName := "testInstance1"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)// Add an instance.@@ -340,10 +339,10 @@ func TestMarkTaskAsDone(t *testing.T) {InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: instanceName,- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -422,5 +421,6 @@ func TestMarkTaskAsDone(t *testing.T) {dbMetadataResp, err := ctl.databaseServiceClient.GetDatabaseSchema(ctx, connect.NewRequest(&v1pb.GetDatabaseSchemaRequest{Name: fmt.Sprintf("%s/schema", database.Name)}))a.NoError(err)dbMetadata := dbMetadataResp.Msg- a.Equal("", dbMetadata.Schema)+ // The only migration was skipped, so the schema must not contain the book table.+ a.NotContains(dbMetadata.Schema, "book")}diff --git a/backend/tests/sql_service_audit_test.go b/backend/tests/sql_service_audit_test.goindex 86c26577f2..5b654ddca4 100644--- a/backend/tests/sql_service_audit_test.go+++ b/backend/tests/sql_service_audit_test.go@@ -18,16 +18,16 @@ func TestAdminExecuteAuditLog(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceDir, err := ctl.provisionSQLiteInstance(t.TempDir(), "admin-execute-audit")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "admin execute audit",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/task_run_idempotent_test.go b/backend/tests/task_run_idempotent_test.goindex fd89910e35..945f95ae27 100644--- a/backend/tests/task_run_idempotent_test.go+++ b/backend/tests/task_run_idempotent_test.go@@ -26,19 +26,18 @@ func TestBatchRunTasks_Idempotent(t *testing.T) {defer ctl.Close(ctx)// Provision an instance- instanceRootDir := t.TempDir()instanceName := "testInstanceIdempotent"- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, instanceName)+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: instanceName,- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -171,16 +170,16 @@ func TestBatchRunTasks_ConcurrentSkipCannotBothWin(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceDir, err := ctl.provisionSQLiteInstance(t.TempDir(), "testInstanceConcurrentRunSkip")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "testInstanceConcurrentRunSkip",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -325,18 +324,17 @@ func TestBatchRunTasks_RejectsSkippedTasks(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "testInstanceSkippedTask")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "testInstanceSkippedTask",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/tenant_test.go b/backend/tests/tenant_test.goindex 86459afa16..646a26fab3 100644--- a/backend/tests/tenant_test.go+++ b/backend/tests/tenant_test.go@@ -54,18 +54,17 @@ func TestTenantBackfill(t *testing.T) {}))a.NoError(err)- instanceRootDir := t.TempDir()- prodInstanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "prod-instance")+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)prodInstance, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "prod-instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: prodInstanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)@@ -313,16 +312,16 @@ func TestCreatePlanWithRepeatedDatabaseGroupTarget(t *testing.T) {a.NoError(err)defer ctl.Close(ctx)- instanceDir, err := ctl.provisionSQLiteInstance(t.TempDir(), t.Name())+ pgContainer, err := provisionPgInstance(ctx, t)a.NoError(err)instance, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "prod-instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))a.NoError(err)diff --git a/backend/tests/test-data/book_schema.result b/backend/tests/test-data/book_schema.resultindex ee567d9d97..109a3cc414 100644--- a/backend/tests/test-data/book_schema.result+++ b/backend/tests/test-data/book_schema.result@@ -1,4 +1,31 @@-CREATE TABLE book (- id INTEGER PRIMARY KEY AUTOINCREMENT,- name TEXT NULL- );++SET statement_timeout = 0;+SET lock_timeout = 0;+SET idle_in_transaction_session_timeout = 0;+SET client_encoding = 'UTF8';+SET standard_conforming_strings = on;+SELECT pg_catalog.set_config('search_path', '', false);+SET check_function_bodies = false;+SET xmloption = content;+SET client_min_messages = warning;+SET row_security = off;++CREATE SEQUENCE "public"."book_id_seq"+ AS integer+ START WITH 1+ INCREMENT BY 1+ MINVALUE 1+ MAXVALUE 2147483647+ NO CYCLE;++SET default_tablespace = '';++CREATE TABLE "public"."book" (+ "id" integer DEFAULT nextval('public.book_id_seq'::regclass) NOT NULL,+ "name" text+);++ALTER SEQUENCE "public"."book_id_seq" OWNED BY "public"."book"."id";++ALTER TABLE ONLY "public"."book" ADD CONSTRAINT "book_pkey" PRIMARY KEY (id);+diff --git a/backend/tests/testcontainer.go b/backend/tests/testcontainer.goindex d0ae1a92fa..328011cd8a 100644--- a/backend/tests/testcontainer.go+++ b/backend/tests/testcontainer.go@@ -3,8 +3,10 @@ package testsimport ("context""database/sql"+ "testing""github.com/bytebase/bytebase/backend/common/testcontainer"+ v1pb "github.com/bytebase/bytebase/backend/generated-go/v1")// Container wraps testcontainer.Container and exposes fields for backward compatibility@@ -29,6 +31,34 @@ func getPgContainer(ctx context.Context) (*Container, error) {}, nil}+// provisionPgInstance starts a dedicated Postgres container that backs a test+// database instance. The container is closed when the test finishes.+func provisionPgInstance(ctx context.Context, t *testing.T) (*Container, error) {+ c, err := getPgContainer(ctx)+ if err != nil {+ return nil, err+ }+ t.Cleanup(func() { c.Close(ctx) })+ return c, nil+}++// dataSource returns a data source of the given type and ID pointing at the container.+func (c *Container) dataSource(dsType v1pb.DataSourceType, id string) *v1pb.DataSource {+ return &v1pb.DataSource{+ Type: dsType,+ Id: id,+ Host: c.host,+ Port: c.port,+ Username: "postgres",+ Password: "root-password",+ }+}++// adminDataSource returns an ADMIN data source pointing at the container.+func (c *Container) adminDataSource() *v1pb.DataSource {+ return c.dataSource(v1pb.DataSourceType_ADMIN, "admin")+}+// getMySQLContainer creates a MySQL container for testingfunc getMySQLContainer(ctx context.Context) (*Container, error) {tc, err := testcontainer.GetTestMySQLContainer(ctx)diff --git a/backend/tests/tests.go b/backend/tests/tests.goindex 016a061f95..74f719f1f9 100644--- a/backend/tests/tests.go+++ b/backend/tests/tests.go@@ -9,8 +9,6 @@ import ("fmt""net""net/http"- "os"- "path""strings""sync""time"@@ -68,8 +66,8 @@ func (*authInterceptor) WrapStreamingHandler(next connect.StreamingHandlerFunc)var (migrationStatement1 = `CREATE TABLE book (- id INTEGER PRIMARY KEY AUTOINCREMENT,- name TEXT NULL+ id SERIAL PRIMARY KEY,+ name TEXT);`//go:embed test-data/book_schema.result@@ -77,14 +75,10 @@ var (dataUpdateStatement = `INSERT INTO book(name) VALUES- ("byte"),+ ('byte'),(NULL);`- dumpedSchema = `CREATE TABLE book (- id INTEGER PRIMARY KEY AUTOINCREMENT,- name TEXT NULL- );-`+ dumpedSchema = wantBookSchema)type controller struct {@@ -356,16 +350,6 @@ func (ctl *controller) Close(ctx context.Context) error {return e}-// provisionSQLiteInstance provisions a SQLite instance (a directory).-func (*controller) provisionSQLiteInstance(rootDir, name string) (string, error) {- p := path.Join(rootDir, name)- if err := os.MkdirAll(p, os.ModePerm); err != nil {- return "", errors.Wrapf(err, "failed to make directory %q", p)- }-- return p, nil-}-// signupAndLogin will signup and login as user [email protected].// addMemberToWorkspaceIAM adds a member as workspace role to the current workspace.func (ctl *controller) addMemberToWorkspaceIAM(ctx context.Context, workspace, member, role string) (*v1pb.IamPolicy, error) {diff --git a/backend/tests/webhook_helpers_test.go b/backend/tests/webhook_helpers_test.goindex 3f6f6310a5..bb9fcdab51 100644--- a/backend/tests/webhook_helpers_test.go+++ b/backend/tests/webhook_helpers_test.go@@ -6,7 +6,6 @@ import ("encoding/json""fmt""path"- "path/filepath""strings""testing""time"@@ -167,17 +166,16 @@ func seedFailingSheet(ctx context.Context, t *testing.T, ctl *controller, projecreturn resp.Msg.Name}-// unblockFailingTask creates the missing table inside the SQLite database file-// so subsequent runs of seedFailingSheet's SQL succeed. db.Close() flushes-// WAL/journal so the file is consistent before the retry is enqueued.-func unblockFailingTask(t *testing.T, instanceDir, dbName string) {+// unblockFailingTask creates the missing table inside the test database on the+// instance's Postgres container so subsequent runs of seedFailingSheet's SQL+// succeed.+func unblockFailingTask(t *testing.T, pgContainer *Container, dbName string) {t.Helper()- dbPath := filepath.Join(instanceDir, dbName+".db")- db, err := sql.Open("sqlite3", dbPath)+ db, err := sql.Open("pgx", fmt.Sprintf("host=%s port=%s user=postgres password=root-password database=%s", pgContainer.host, pgContainer.port, dbName))require.NoError(t, err)defer func() {if cerr := db.Close(); cerr != nil {- t.Errorf("close sqlite handle for %s: %v", dbPath, cerr)+ t.Errorf("close postgres handle for %s: %v", dbName, cerr)}}()_, err = db.Exec("CREATE TABLE IF NOT EXISTS __force_fail_target(id INT);")diff --git a/backend/tests/webhook_test.go b/backend/tests/webhook_test.goindex 542d3eeeda..95fd12f740 100644--- a/backend/tests/webhook_test.go+++ b/backend/tests/webhook_test.go@@ -168,18 +168,17 @@ func TestWebhookIntegration(t *testing.T) {defer webhookServer.Close()// Create a single instance for all tests- instanceRootDir := t.TempDir()- instanceDir, err := ctl.provisionSQLiteInstance(instanceRootDir, "testInstance")+ pgContainer, err := provisionPgInstance(ctx, t)require.NoError(t, err)instanceResp, err := ctl.instanceServiceClient.CreateInstance(ctx, connect.NewRequest(&v1pb.CreateInstanceRequest{InstanceId: generateRandomString("instance"),Instance: &v1pb.Instance{Title: "test instance",- Engine: v1pb.Engine_SQLITE,+ Engine: v1pb.Engine_POSTGRES,Environment: new("environments/prod"),Activation: true,- DataSources: []*v1pb.DataSource{{Type: v1pb.DataSourceType_ADMIN, Host: instanceDir, Id: "admin"}},+ DataSources: []*v1pb.DataSource{pgContainer.adminDataSource()},},}))require.NoError(t, err)@@ -372,7 +371,7 @@ func TestWebhookIntegration(t *testing.T) {waitForAllTasksTerminal(ctx, t, ctl, rollout, 30*time.Second)requireWebhookCount(t, collector, project.Name, "Rollout completed", 0)- unblockFailingTask(t, instanceDir, "byt9398_c3_fail")+ unblockFailingTask(t, pgContainer, "byt9398_c3_fail")retryFailedTasks(ctx, t, ctl, rollout)waitForWebhookCount(t, collector, project.Name, "Rollout completed", 1)@@ -432,8 +431,8 @@ func TestWebhookIntegration(t *testing.T) {requireWebhookCount(t, collector, project.Name, "Rollout completed", 0)// Unblock dbRetry only — dbSkipFailed's __force_fail_target table remains- // absent in its own .db file, so its retry would still fail.- unblockFailingTask(t, instanceDir, "byt9398_c7_retry")+ // absent in its own database, so its retry would still fail.+ unblockFailingTask(t, pgContainer, "byt9398_c7_retry")runTaskByDB(ctx, t, ctl, rollout, dbTargetName(instance, "byt9398_c7_retry"))waitForTaskStatus(ctx, t, ctl, rollout, dbTargetName(instance, "byt9398_c7_retry"), v1pb.Task_DONE, 30*time.Second)skipTaskByDB(ctx, t, ctl, rollout, dbTargetName(instance, "byt9398_c7_skipfailed"))diff --git a/frontend/src/components/instance/constants.ts b/frontend/src/components/instance/constants.tsindex f1698e9817..03153c4bbf 100644--- a/frontend/src/components/instance/constants.ts+++ b/frontend/src/components/instance/constants.ts@@ -11,8 +11,6 @@ export const defaultPortForEngine = (engine: Engine) => {return "5432";case Engine.SNOWFLAKE:return "";- case Engine.SQLITE:- return "";case Engine.TIDB:return "4000";case Engine.MONGODB:diff --git a/frontend/src/types/proto-es/v1/common_pb.d.ts b/frontend/src/types/proto-es/v1/common_pb.d.tsindex bd21627af1..ffabd08b16 100644--- a/frontend/src/types/proto-es/v1/common_pb.d.ts+++ b/frontend/src/types/proto-es/v1/common_pb.d.ts@@ -195,13 +195,6 @@ export enum Engine {*/SNOWFLAKE = 4,- /**- * SQLite embedded database.- *- * @generated from enum value: SQLITE = 5;- */- SQLITE = 5,-/*** TiDB distributed SQL database.*diff --git a/frontend/src/types/proto-es/v1/common_pb.js b/frontend/src/types/proto-es/v1/common_pb.jsindex b28ac1e94d..62fbb193b8 100644--- a/frontend/src/types/proto-es/v1/common_pb.js+++ b/frontend/src/types/proto-es/v1/common_pb.js@@ -8,7 +8,7 @@ import { enumDesc, fileDesc, messageDesc, tsEnum } from "@bufbuild/protobuf/code* Describes the file v1/common.proto.*/export const file_v1_common = /*@__PURE__*/- fileDesc("Cg92MS9jb21tb24ucHJvdG8SC2J5dGViYXNlLnYxIigKCFBvc2l0aW9uEgwKBGxpbmUYASABKAUSDgoGY29sdW1uGAIgASgFIiMKBVJhbmdlEg0KBXN0YXJ0GAEgASgFEgsKA2VuZBgCIAEoBSJZChZQZXJtaXNzaW9uRGVuaWVkRGV0YWlsEg4KBm1ldGhvZBgBIAEoCRIcChRyZXF1aXJlZF9wZXJtaXNzaW9ucxgCIAMoCRIRCglyZXNvdXJjZXMYAyADKAkqNwoFU3RhdGUSFQoRU1RBVEVfVU5TUEVDSUZJRUQQABIKCgZBQ1RJVkUQARILCgdERUxFVEVEEAIq8AIKBkVuZ2luZRIWChJFTkdJTkVfVU5TUEVDSUZJRUQQABIOCgpDTElDS0hPVVNFEAESCQoFTVlTUUwQAhIMCghQT1NUR1JFUxADEg0KCVNOT1dGTEFLRRAEEgoKBlNRTElURRAFEggKBFRJREIQBhILCgdNT05HT0RCEAcSCQoFUkVESVMQCBIKCgZPUkFDTEUQCRILCgdTUEFOTkVSEAoSCQoFTVNTUUwQCxIMCghSRURTSElGVBAMEgsKB01BUklBREIQDRINCglPQ0VBTkJBU0UQDhINCglTVEFSUk9DS1MQDxIJCgVET1JJUxAQEggKBEhJVkUQERIRCg1FTEFTVElDU0VBUkNIEBISDAoIQklHUVVFUlkQExIMCghEWU5BTU9EQhAUEg4KCkRBVEFCUklDS1MQFRIPCgtDT0NLUk9BQ0hEQhAWEgwKCENPU01PU0RCEBcSCQoFVFJJTk8QGBINCglDQVNTQU5EUkEQGSpcCgdWQ1NUeXBlEhgKFFZDU19UWVBFX1VOU1BFQ0lGSUVEEAASCgoGR0lUSFVCEAESCgoGR0lUTEFCEAISDQoJQklUQlVDS0VUEAMSEAoMQVpVUkVfREVWT1BTEAQqTAoMRXhwb3J0Rm9ybWF0EhYKEkZPUk1BVF9VTlNQRUNJRklFRBAAEgcKA0NTVhABEggKBEpTT04QAhIHCgNTUUwQAxIICgRYTFNYEAQqdQoOQXBwcm92YWxTdGF0dXMSHwobQVBQUk9WQUxfU1RBVFVTX1VOU1BFQ0lGSUVEEAASDAoIQ0hFQ0tJTkcQARILCgdQRU5ESU5HEAISDAoIQVBQUk9WRUQQAxIMCghSRUpFQ1RFRBAEEgsKB1NLSVBQRUQQBSpICglSaXNrTGV2ZWwSGgoWUklTS19MRVZFTF9VTlNQRUNJRklFRBAAEgcKA0xPVxABEgwKCE1PREVSQVRFEAISCAoESElHSBADKo4BCgtXZWJob29rVHlwZRIcChhXRUJIT09LX1RZUEVfVU5TUEVDSUZJRUQQABIJCgVTTEFDSxABEgsKB0RJU0NPUkQQAhIJCgVURUFNUxADEgwKCERJTkdUQUxLEAQSCgoGRkVJU0hVEAUSCQoFV0VDT00QBhIICgRMQVJLEAcSDwoLR09PR0xFX0NIQVQQCCrrBQoNU3RhdGVtZW50VHlwZRIeChpTVEFURU1FTlRfVFlQRV9VTlNQRUNJRklFRBAAEhMKD0NSRUFURV9EQVRBQkFTRRABEhAKDENSRUFURV9UQUJMRRACEg8KC0NSRUFURV9WSUVXEAMSEAoMQ1JFQVRFX0lOREVYEAQSEwoPQ1JFQVRFX1NFUVVFTkNFEAUSEQoNQ1JFQVRFX1NDSEVNQRAGEhMKD0NSRUFURV9GVU5DVElPThAHEhIKDkNSRUFURV9UUklHR0VSEAgSFAoQQ1JFQVRFX1BST0NFRFVSRRAJEhAKDENSRUFURV9FVkVOVBAKEhQKEENSRUFURV9FWFRFTlNJT04QCxIPCgtDUkVBVEVfVFlQRRAMEhEKDURST1BfREFUQUJBU0UQFBIOCgpEUk9QX1RBQkxFEBUSDQoJRFJPUF9WSUVXEBYSDgoKRFJPUF9JTkRFWBAXEhEKDURST1BfU0VRVUVOQ0UQGBIPCgtEUk9QX1NDSEVNQRAZEhEKDURST1BfRlVOQ1RJT04QGhIQCgxEUk9QX1RSSUdHRVIQGxISCg5EUk9QX1BST0NFRFVSRRAcEg4KCkRST1BfRVZFTlQQHRISCg5EUk9QX0VYVEVOU0lPThAeEg0KCURST1BfVFlQRRAfEhIKDkFMVEVSX0RBVEFCQVNFECgSDwoLQUxURVJfVEFCTEUQKRIOCgpBTFRFUl9WSUVXECoSEgoOQUxURVJfU0VRVUVOQ0UQKxIPCgtBTFRFUl9FVkVOVBAsEg4KCkFMVEVSX1RZUEUQLRIPCgtBTFRFUl9JTkRFWBAuEgwKCFRSVU5DQVRFEDISCgoGUkVOQU1FEDMSEAoMUkVOQU1FX0lOREVYEDQSEQoNUkVOQU1FX1NDSEVNQRA1EhMKD1JFTkFNRV9TRVFVRU5DRRA2EgsKB0NPTU1FTlQQNxIKCgZJTlNFUlQQPBIKCgZVUERBVEUQPRIKCgZERUxFVEUQPkKhAQoPY29tLmJ5dGViYXNlLnYxQgtDb21tb25Qcm90b1ABWjRnaXRodWIuY29tL2J5dGViYXNlL2J5dGViYXNlL2JhY2tlbmQvZ2VuZXJhdGVkLWdvL3YxogIDQlhYqgILQnl0ZWJhc2UuVjHKAgtCeXRlYmFzZVxWMeICF0J5dGViYXNlXFYxXEdQQk1ldGFkYXRh6gIMQnl0ZWJhc2U6OlYxYgZwcm90bzM");+ fileDesc("Cg92MS9jb21tb24ucHJvdG8SC2J5dGViYXNlLnYxIigKCFBvc2l0aW9uEgwKBGxpbmUYASABKAUSDgoGY29sdW1uGAIgASgFIiMKBVJhbmdlEg0KBXN0YXJ0GAEgASgFEgsKA2VuZBgCIAEoBSJZChZQZXJtaXNzaW9uRGVuaWVkRGV0YWlsEg4KBm1ldGhvZBgBIAEoCRIcChRyZXF1aXJlZF9wZXJtaXNzaW9ucxgCIAMoCRIRCglyZXNvdXJjZXMYAyADKAkqNwoFU3RhdGUSFQoRU1RBVEVfVU5TUEVDSUZJRUQQABIKCgZBQ1RJVkUQARILCgdERUxFVEVEEAIq5AIKBkVuZ2luZRIWChJFTkdJTkVfVU5TUEVDSUZJRUQQABIOCgpDTElDS0hPVVNFEAESCQoFTVlTUUwQAhIMCghQT1NUR1JFUxADEg0KCVNOT1dGTEFLRRAEEggKBFRJREIQBhILCgdNT05HT0RCEAcSCQoFUkVESVMQCBIKCgZPUkFDTEUQCRILCgdTUEFOTkVSEAoSCQoFTVNTUUwQCxIMCghSRURTSElGVBAMEgsKB01BUklBREIQDRINCglPQ0VBTkJBU0UQDhINCglTVEFSUk9DS1MQDxIJCgVET1JJUxAQEggKBEhJVkUQERIRCg1FTEFTVElDU0VBUkNIEBISDAoIQklHUVVFUlkQExIMCghEWU5BTU9EQhAUEg4KCkRBVEFCUklDS1MQFRIPCgtDT0NLUk9BQ0hEQhAWEgwKCENPU01PU0RCEBcSCQoFVFJJTk8QGBINCglDQVNTQU5EUkEQGSpcCgdWQ1NUeXBlEhgKFFZDU19UWVBFX1VOU1BFQ0lGSUVEEAASCgoGR0lUSFVCEAESCgoGR0lUTEFCEAISDQoJQklUQlVDS0VUEAMSEAoMQVpVUkVfREVWT1BTEAQqTAoMRXhwb3J0Rm9ybWF0EhYKEkZPUk1BVF9VTlNQRUNJRklFRBAAEgcKA0NTVhABEggKBEpTT04QAhIHCgNTUUwQAxIICgRYTFNYEAQqdQoOQXBwcm92YWxTdGF0dXMSHwobQVBQUk9WQUxfU1RBVFVTX1VOU1BFQ0lGSUVEEAASDAoIQ0hFQ0tJTkcQARILCgdQRU5ESU5HEAISDAoIQVBQUk9WRUQQAxIMCghSRUpFQ1RFRBAEEgsKB1NLSVBQRUQQBSpICglSaXNrTGV2ZWwSGgoWUklTS19MRVZFTF9VTlNQRUNJRklFRBAAEgcKA0xPVxABEgwKCE1PREVSQVRFEAISCAoESElHSBADKo4BCgtXZWJob29rVHlwZRIcChhXRUJIT09LX1RZUEVfVU5TUEVDSUZJRUQQABIJCgVTTEFDSxABEgsKB0RJU0NPUkQQAhIJCgVURUFNUxADEgwKCERJTkdUQUxLEAQSCgoGRkVJU0hVEAUSCQoFV0VDT00QBhIICgRMQVJLEAcSDwoLR09PR0xFX0NIQVQQCCrrBQoNU3RhdGVtZW50VHlwZRIeChpTVEFURU1FTlRfVFlQRV9VTlNQRUNJRklFRBAAEhMKD0NSRUFURV9EQVRBQkFTRRABEhAKDENSRUFURV9UQUJMRRACEg8KC0NSRUFURV9WSUVXEAMSEAoMQ1JFQVRFX0lOREVYEAQSEwoPQ1JFQVRFX1NFUVVFTkNFEAUSEQoNQ1JFQVRFX1NDSEVNQRAGEhMKD0NSRUFURV9GVU5DVElPThAHEhIKDkNSRUFURV9UUklHR0VSEAgSFAoQQ1JFQVRFX1BST0NFRFVSRRAJEhAKDENSRUFURV9FVkVOVBAKEhQKEENSRUFURV9FWFRFTlNJT04QCxIPCgtDUkVBVEVfVFlQRRAMEhEKDURST1BfREFUQUJBU0UQFBIOCgpEUk9QX1RBQkxFEBUSDQoJRFJPUF9WSUVXEBYSDgoKRFJPUF9JTkRFWBAXEhEKDURST1BfU0VRVUVOQ0UQGBIPCgtEUk9QX1NDSEVNQRAZEhEKDURST1BfRlVOQ1RJT04QGhIQCgxEUk9QX1RSSUdHRVIQGxISCg5EUk9QX1BST0NFRFVSRRAcEg4KCkRST1BfRVZFTlQQHRISCg5EUk9QX0VYVEVOU0lPThAeEg0KCURST1BfVFlQRRAfEhIKDkFMVEVSX0RBVEFCQVNFECgSDwoLQUxURVJfVEFCTEUQKRIOCgpBTFRFUl9WSUVXECoSEgoOQUxURVJfU0VRVUVOQ0UQKxIPCgtBTFRFUl9FVkVOVBAsEg4KCkFMVEVSX1RZUEUQLRIPCgtBTFRFUl9JTkRFWBAuEgwKCFRSVU5DQVRFEDISCgoGUkVOQU1FEDMSEAoMUkVOQU1FX0lOREVYEDQSEQoNUkVOQU1FX1NDSEVNQRA1EhMKD1JFTkFNRV9TRVFVRU5DRRA2EgsKB0NPTU1FTlQQNxIKCgZJTlNFUlQQPBIKCgZVUERBVEUQPRIKCgZERUxFVEUQPkKhAQoPY29tLmJ5dGViYXNlLnYxQgtDb21tb25Qcm90b1ABWjRnaXRodWIuY29tL2J5dGViYXNlL2J5dGViYXNlL2JhY2tlbmQvZ2VuZXJhdGVkLWdvL3YxogIDQlhYqgILQnl0ZWJhc2UuVjHKAgtCeXRlYmFzZVxWMeICF0J5dGViYXNlXFYxXEdQQk1ldGFkYXRh6gIMQnl0ZWJhc2U6OlYxYgZwcm90bzM");/*** Describes the message bytebase.v1.Position.diff --git a/frontend/src/utils/v1/sql.ts b/frontend/src/utils/v1/sql.tsindex 8a05deab6d..90772cf4d0 100644--- a/frontend/src/utils/v1/sql.ts+++ b/frontend/src/utils/v1/sql.ts@@ -154,7 +154,6 @@ const wrapSQLIdentifier = (id: string, engine: Engine) => {if ([Engine.POSTGRES,- Engine.SQLITE,Engine.SNOWFLAKE,Engine.ORACLE,Engine.REDSHIFT,diff --git a/go.mod b/go.modindex b73951435c..d70bc2d0d0 100644--- a/go.mod+++ b/go.mod@@ -64,7 +64,6 @@ require (github.com/labstack/echo-contrib/v5 v5.0.1github.com/lib/pq v1.12.3github.com/lor00x/goldap v0.0.0-20240304151906-8d785c64d1c8- github.com/mattn/go-sqlite3 v1.14.48github.com/microsoft/go-mssqldb v1.10.0github.com/moby/moby/api v1.55.0github.com/modelcontextprotocol/go-sdk v1.6.1diff --git a/go.sum b/go.sumindex be302bc0dc..a58730f952 100644--- a/go.sum+++ b/go.sum@@ -713,8 +713,6 @@ github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEgithub.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=github.com/mattn/go-runewidth v0.0.16 h1:E5ScNMtiwvlvB5paMFdw9p4kSQzbXFikJ5SQO6TULQc=github.com/mattn/go-runewidth v0.0.16/go.mod h1:Jdepj2loyihRzMpdS35Xk/zdY8IAYHsh153qUoGf23w=-github.com/mattn/go-sqlite3 v1.14.48 h1:7XHIgl0a8HwOaiK4E47ozLkST78rR9+OtNGx27D/TFs=-github.com/mattn/go-sqlite3 v1.14.48/go.mod h1:6JTjA44L93a0QCyJef5YvlPoKXntQPjzWv5gtm9sB6w=github.com/minio/asm2plan9s v0.0.0-20200509001527-cdd76441f9d8 h1:AMFGa4R4MiIpspGNG7Z948v4n35fFGB3RR3G/ry4FWs=github.com/minio/asm2plan9s v0.0.0-20200509001527-cdd76441f9d8/go.mod h1:mC1jAcsrzbxHt8iiaC+zU4b1ylILSosueou12R++wfY=github.com/minio/c2goasm v0.0.0-20190812172519-36a3d3bbc4f3 h1:+n/aFZefKZp7spd8DFdX7uMikMLXX4oubIzJF4kv/wI=diff --git a/proto/gen/grpc-doc/openapi.yaml b/proto/gen/grpc-doc/openapi.yamlindex 8d34e07426..2d5112122f 100644--- a/proto/gen/grpc-doc/openapi.yaml+++ b/proto/gen/grpc-doc/openapi.yaml@@ -19387,7 +19387,6 @@ components:- MYSQL- POSTGRES- SNOWFLAKE- - SQLITE- TIDB- MONGODB- REDISdiff --git a/proto/gen/grpc-doc/store/README.md b/proto/gen/grpc-doc/store/README.mdindex 6c931adb77..2c8d7daf2c 100644--- a/proto/gen/grpc-doc/store/README.md+++ b/proto/gen/grpc-doc/store/README.md@@ -512,7 +512,6 @@ Engine represents the type of database system.| MYSQL | 2 | || POSTGRES | 3 | || SNOWFLAKE | 4 | |-| SQLITE | 5 | || TIDB | 6 | || MONGODB | 7 | || REDIS | 8 | |diff --git a/proto/gen/grpc-doc/store/index.html b/proto/gen/grpc-doc/store/index.htmlindex c0bb05b7ed..0b12270573 100644--- a/proto/gen/grpc-doc/store/index.html+++ b/proto/gen/grpc-doc/store/index.html@@ -734,7 +734,7 @@<li><a href="#bytebase.store.SyncDatabases"><span class="badge">M</span>SyncDatabases</a></li>-+<li><a href="#bytebase.store.DataSource.AuthenticationType"><span class="badge">E</span>DataSource.AuthenticationType</a>@@ -1913,12 +1913,6 @@ Examples:<td><p></p></td></tr>- <tr>- <td>SQLITE</td>- <td>5</td>- <td><p></p></td>- </tr>-<tr><td>TIDB</td><td>6</td>@@ -8184,27 +8178,27 @@ For MySQL, it is the global privileges as GRANT statements, which means it only<h3 id="bytebase.store.SyncDatabases">SyncDatabases</h3><p></p>-+<table class="field-table"><thead><tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr></thead><tbody>-+<tr><td>databases</td><td><a href="#string">string</a></td><td>repeated</td><td><p> </p></td></tr>-+</tbody></table>+---++<h3 id="bytebase.store.DataSource.AuthenticationType">DataSource.AuthenticationType</h3>@@ -15408,3 +15402,4 @@ For example, if the folders is [A, B, C], means the worksheet is in the A/B/C su</table></body></html>+diff --git a/proto/gen/grpc-doc/v1/README.md b/proto/gen/grpc-doc/v1/README.mdindex dd51cfc40b..6337398b74 100644--- a/proto/gen/grpc-doc/v1/README.md+++ b/proto/gen/grpc-doc/v1/README.md@@ -1119,7 +1119,6 @@ Database engine type.| MYSQL | 2 | MySQL relational database. || POSTGRES | 3 | PostgreSQL relational database. || SNOWFLAKE | 4 | Snowflake cloud data warehouse. |-| SQLITE | 5 | SQLite embedded database. || TIDB | 6 | TiDB distributed SQL database. || MONGODB | 7 | MongoDB document database. || REDIS | 8 | Redis key-value store. |diff --git a/proto/gen/grpc-doc/v1/index.html b/proto/gen/grpc-doc/v1/index.htmlindex 8797cb4596..34018db0d4 100644--- a/proto/gen/grpc-doc/v1/index.html+++ b/proto/gen/grpc-doc/v1/index.html@@ -668,7 +668,7 @@<li><a href="#bytebase.v1.SyncDatabases"><span class="badge">M</span>SyncDatabases</a></li>-+<li><a href="#bytebase.v1.SyncInstanceRequest"><span class="badge">M</span>SyncInstanceRequest</a></li>@@ -3993,12 +3993,6 @@ Examples:<td><p>Snowflake cloud data warehouse.</p></td></tr>- <tr>- <td>SQLITE</td>- <td>5</td>- <td><p>SQLite embedded database.</p></td>- </tr>-<tr><td>TIDB</td><td>6</td>@@ -8548,27 +8542,27 @@ Only READ_ONLY data source can be removed. </p></td><h3 id="bytebase.v1.SyncDatabases">SyncDatabases</h3><p></p>-+<table class="field-table"><thead><tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr></thead><tbody>-+<tr><td>databases</td><td><a href="#string">string</a></td><td>repeated</td><td><p> </p></td></tr>-+</tbody></table>+---++<h3 id="bytebase.v1.SyncInstanceRequest">SyncInstanceRequest</h3><p></p>@@ -35113,3 +35107,4 @@ Permissions required: bb.workspaces.setIamPolicy</p></td></table></body></html>+diff --git a/proto/store/store/common.proto b/proto/store/store/common.protoindex 86bcfb51ab..03654b1484 100644--- a/proto/store/store/common.proto+++ b/proto/store/store/common.proto@@ -19,7 +19,6 @@ enum Engine {MYSQL = 2;POSTGRES = 3;SNOWFLAKE = 4;- SQLITE = 5;TIDB = 6;MONGODB = 7;REDIS = 8;diff --git a/proto/v1/v1/common.proto b/proto/v1/v1/common.protoindex 30dd31c4d8..d16a63082d 100644--- a/proto/v1/v1/common.proto+++ b/proto/v1/v1/common.proto@@ -25,8 +25,6 @@ enum Engine {POSTGRES = 3;// Snowflake cloud data warehouse.SNOWFLAKE = 4;- // SQLite embedded database.- SQLITE = 5;// TiDB distributed SQL database.TIDB = 6;// MongoDB document database.