Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

chore: error handling for tab migration (#18407)

ecmadao6e9afa7d2e20
diff --git a/frontend/src/store/modules/sqlEditor/legacy/migration.ts b/frontend/src/store/modules/sqlEditor/legacy/migration.ts
index 9f63ab1dd4..f04ed8a0c8 100644
--- a/frontend/src/store/modules/sqlEditor/legacy/migration.ts
+++ b/frontend/src/store/modules/sqlEditor/legacy/migration.ts
@@ -1,5 +1,5 @@
import { create } from "@bufbuild/protobuf";
-import { omit } from "lodash-es";
+import { isUndefined, omit, omitBy } from "lodash-es";
import { computed, reactive } from "vue";
import type { EditorPanelViewState, SQLEditorTab } from "@/types";
import { DEFAULT_SQL_EDITOR_TAB_MODE } from "@/types";
@@ -9,6 +9,7 @@ import {
} from "@/types/proto-es/v1/worksheet_service_pb";
import {
defaultSQLEditorTab,
+ extractWorksheetConnection,
useDynamicLocalStorage,
WebStorageHelper,
} from "@/utils";
@@ -135,18 +136,27 @@ export const migrateDraftsFromCache = async (project: string) => {
const drafts = [...draftTabList.value];
for (const draft of drafts) {
- const viewState = viewStateByTab.value.get(draft.id);
- if ((!viewState || viewState.view === "CODE") && draft.statement) {
+ const tab = {
+ ...defaultSQLEditorTab(),
+ ...omitBy(draft, isUndefined),
+ };
+ const viewState = viewStateByTab.value.get(tab.id);
+ if ((!viewState || viewState.view === "CODE") && tab.statement) {
// only store the draft with content
- await worksheetStore.createWorksheet(
- create(WorksheetSchema, {
- title: draft.title,
- database: draft.connection.database,
- content: new TextEncoder().encode(draft.statement),
- project: project,
- visibility: Worksheet_Visibility.PRIVATE,
- })
- );
+ try {
+ const connection = await extractWorksheetConnection({
+ database: tab.connection.database,
+ });
+ await worksheetStore.createWorksheet(
+ create(WorksheetSchema, {
+ title: tab.title,
+ database: connection.database,
+ content: new TextEncoder().encode(tab.statement),
+ project,
+ visibility: Worksheet_Visibility.PRIVATE,
+ })
+ );
+ } catch {}
}
const index = draftTabList.value.findIndex((d) => d.id === draft.id);
if (index >= 0) {
diff --git a/frontend/src/utils/v1/worksheet.ts b/frontend/src/utils/v1/worksheet.ts
index e2296389d5..a7b4138a5d 100644
--- a/frontend/src/utils/v1/worksheet.ts
+++ b/frontend/src/utils/v1/worksheet.ts
@@ -110,7 +110,9 @@ export const setDefaultDataSourceForConn = (
}
};
-export const extractWorksheetConnection = async (worksheet: Worksheet) => {
+export const extractWorksheetConnection = async (worksheet: {
+ database: string;
+}) => {
const connection = emptySQLEditorConnection();
if (worksheet.database) {
try {