Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(frontend): provide overlay stack to revision drawer and remove redundant tests (#19932)

Danny Xu7189d5fdaaca
diff --git a/frontend/src/components/Revision/CreateRevisionDrawer.vue b/frontend/src/components/Revision/CreateRevisionDrawer.vue
index 67561aa21c..30864b9cd3 100644
--- a/frontend/src/components/Revision/CreateRevisionDrawer.vue
+++ b/frontend/src/components/Revision/CreateRevisionDrawer.vue
@@ -37,7 +37,7 @@
class="flex flex-col gap-y-4 w-full"
>
<div
- class="border border-gray-200 rounded-lg p-4 hover:border-gray-300 transition-colors"
+ class="border border-gray-200 rounded-lg p-4 hover:border-gray-300 transition-colors mb-4"
:class="{
'border-blue-500 bg-blue-50': selectedSource === 'release',
}"
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseChangelogPanel.test.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseChangelogPanel.test.tsx
deleted file mode 100644
index 491aae75bf..0000000000
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseChangelogPanel.test.tsx
+++ /dev/null
@@ -1,183 +0,0 @@
-import { act, createElement } from "react";
-import { createRoot } from "react-dom/client";
-import { beforeEach, describe, expect, test, vi } from "vitest";
-import type {
- Changelog,
- Database,
-} from "@/types/proto-es/v1/database_service_pb";
-
-(
- globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
-).IS_REACT_ACT_ENVIRONMENT = true;
-
-const mocks = vi.hoisted(() => ({
- localStorage: {
- clear: vi.fn(),
- getItem: vi.fn(() => null),
- removeItem: vi.fn(),
- setItem: vi.fn(),
- },
- useTranslation: vi.fn(() => ({
- t: (key: string) => key,
- })),
- fetchChangelogList: vi.fn(),
- currentUser: {
- value: {
- email: "[email protected]",
- },
- },
- createApp: vi.fn(),
- h: vi.fn((component: unknown, props: Record<string, unknown>) => ({
- component,
- props,
- })),
-}));
-
-let DatabaseChangelogPanel: typeof import("./DatabaseChangelogPanel").DatabaseChangelogPanel;
-
-vi.stubGlobal("localStorage", mocks.localStorage);
-
-vi.mock("react-i18next", () => ({
- useTranslation: mocks.useTranslation,
-}));
-
-vi.mock("vue", async (importOriginal) => {
- const actual = await importOriginal<typeof import("vue")>();
- return {
- ...actual,
- createApp: mocks.createApp,
- h: mocks.h,
- };
-});
-
-vi.mock("@/components/Changelog", () => ({
- ChangelogDataTable: Symbol("ChangelogDataTable"),
-}));
-
-vi.mock("@/plugins/i18n", () => ({
- default: {
- install: vi.fn(),
- },
-}));
-
-vi.mock("@/plugins/naive-ui", () => ({
- default: {
- install: vi.fn(),
- },
-}));
-
-vi.mock("@/router", () => ({
- router: {
- push: vi.fn(),
- install: vi.fn(),
- },
-}));
-
-vi.mock("@/react/components/ui/button", () => ({
- Button: (props: React.ButtonHTMLAttributes<HTMLButtonElement>) => (
- <button {...props} />
- ),
-}));
-
-vi.mock("@/store", () => ({
- pinia: {
- install: vi.fn(),
- },
- useCurrentUserV1: () => mocks.currentUser,
- useChangelogStore: () => ({
- fetchChangelogList: mocks.fetchChangelogList,
- }),
-}));
-
-vi.mock("@/utils/v1/changelog", () => ({
- changelogLink: (changelog: { name: string }) =>
- `/changelogs/${changelog.name}`,
-}));
-
-const renderIntoContainer = (element: ReturnType<typeof createElement>) => {
- const container = document.createElement("div");
- const root = createRoot(container);
-
- return {
- container,
- render: (nextElement = element) => {
- act(() => {
- root.render(nextElement);
- });
- },
- unmount: () =>
- act(() => {
- root.unmount();
- }),
- };
-};
-
-const flush = async () => {
- await act(async () => {
- await Promise.resolve();
- await Promise.resolve();
- });
-};
-
-const makeDatabase = (): Database =>
- ({
- name: "instances/inst1/databases/db1",
- project: "projects/proj1",
- }) as Database;
-
-beforeEach(async () => {
- mocks.useTranslation.mockReset();
- mocks.useTranslation.mockReturnValue({
- t: (key: string) => key,
- });
- mocks.localStorage.clear.mockReset();
- mocks.localStorage.getItem.mockReset();
- mocks.localStorage.getItem.mockReturnValue(null);
- mocks.localStorage.removeItem.mockReset();
- mocks.localStorage.setItem.mockReset();
- mocks.fetchChangelogList.mockReset();
- mocks.fetchChangelogList.mockResolvedValue({
- nextPageToken: "",
- changelogs: [
- {
- name: "instances/inst1/databases/db1/changelogs/1",
- planTitle: "Release 1",
- } as Changelog,
- ],
- });
- mocks.createApp.mockReset();
- mocks.createApp.mockImplementation(() => ({
- use() {
- return this;
- },
- mount() {},
- unmount: vi.fn(),
- }));
-
- vi.resetModules();
- ({ DatabaseChangelogPanel } = await import("./DatabaseChangelogPanel"));
-});
-
-describe("DatabaseChangelogPanel", () => {
- test("renders changelog rows in a React table", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseChangelogPanel, {
- database: makeDatabase(),
- })
- );
-
- render();
- await flush();
-
- expect(mocks.fetchChangelogList).toHaveBeenCalledWith({
- parent: "instances/inst1/databases/db1",
- pageSize: expect.any(Number),
- pageToken: "",
- });
- expect(container.querySelector("table")).not.toBeNull();
- // The table shows plan title and created-at, not the raw resource name
- expect(container.textContent).toContain("Release 1");
-
- unmount();
- });
-});
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx
deleted file mode 100644
index 59d837a766..0000000000
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.test.tsx
+++ /dev/null
@@ -1,324 +0,0 @@
-import { act, createElement } from "react";
-import { createRoot } from "react-dom/client";
-import { beforeEach, describe, expect, test, vi } from "vitest";
-import type { Database } from "@/types/proto-es/v1/database_service_pb";
-import {
- type Revision,
- Revision_Type,
-} from "@/types/proto-es/v1/revision_service_pb";
-
-(
- globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
-).IS_REACT_ACT_ENVIRONMENT = true;
-
-const mocks = vi.hoisted(() => ({
- confirm: vi.fn(() => true),
- localStorage: {
- clear: vi.fn(),
- getItem: vi.fn(() => null),
- removeItem: vi.fn(),
- setItem: vi.fn(),
- },
- useTranslation: vi.fn(() => ({
- t: (key: string) => key,
- })),
- CreateRevisionDrawer: Symbol("CreateRevisionDrawer"),
- listRevisions: vi.fn(),
- deleteRevision: vi.fn(),
- currentUser: {
- value: {
- email: "[email protected]",
- },
- },
- appRenderers: [] as Array<
- () => {
- component: unknown;
- props: Record<string, unknown>;
- }
- >,
- createApp: vi.fn(),
- h: vi.fn(
- (
- component: unknown,
- props: Record<string, unknown> | null,
- slots?: { default?: () => unknown }
- ) => {
- // If called with slots (wrapper components like NConfigProvider),
- // return the slot content to unwrap the wrapper.
- if (slots?.default) {
- return slots.default();
- }
- return { component, props };
- }
- ),
-}));
-
-let DatabaseRevisionPanel: typeof import("./DatabaseRevisionPanel").DatabaseRevisionPanel;
-
-vi.stubGlobal("localStorage", mocks.localStorage);
-vi.stubGlobal("confirm", mocks.confirm);
-
-vi.mock("react-i18next", () => ({
- useTranslation: mocks.useTranslation,
-}));
-
-vi.mock("vue", async (importOriginal) => {
- const actual = await importOriginal<typeof import("vue")>();
- return {
- ...actual,
- createApp: mocks.createApp,
- h: mocks.h,
- };
-});
-
-vi.mock("@/components/Revision", () => ({
- RevisionDataTable: Symbol("RevisionDataTable"),
-}));
-
-vi.mock("@/components/Revision/CreateRevisionDrawer.vue", () => ({
- default: mocks.CreateRevisionDrawer,
-}));
-
-vi.mock("@/plugins/i18n", () => ({
- default: {
- install: vi.fn(),
- },
-}));
-
-vi.mock("naive-ui", async (importOriginal) => {
- const actual = await importOriginal<typeof import("naive-ui")>();
- return {
- ...actual,
- NConfigProvider: Symbol("NConfigProvider"),
- };
-});
-
-vi.mock("@/../naive-ui.config", () => ({
- themeOverrides: { value: {} },
-}));
-
-vi.mock("@/plugins/naive-ui", () => ({
- default: {
- install: vi.fn(),
- },
-}));
-
-vi.mock("@/react/components/ui/button", () => ({
- Button: (props: React.ButtonHTMLAttributes<HTMLButtonElement>) => (
- <button {...props} />
- ),
-}));
-
-vi.mock("@/router", () => ({
- router: {
- install: vi.fn(),
- push: vi.fn(),
- },
-}));
-
-vi.mock("@/react/components/ui/dialog", () => ({
- Dialog: ({ open, children }: { open: boolean; children: React.ReactNode }) =>
- open ? <div data-testid="dialog-root">{children}</div> : null,
- DialogContent: ({ children }: { children: React.ReactNode }) => (
- <div>{children}</div>
- ),
- DialogTitle: ({ children }: { children: React.ReactNode }) => (
- <h1>{children}</h1>
- ),
-}));
-
-vi.mock("@/connect", () => ({
- revisionServiceClientConnect: {
- listRevisions: mocks.listRevisions,
- },
-}));
-
-vi.mock("@/store", () => ({
- pinia: {
- install: vi.fn(),
- },
- useCurrentUserV1: () => mocks.currentUser,
- useRevisionStore: () => ({
- deleteRevision: mocks.deleteRevision,
- }),
-}));
-
-vi.mock("@/utils/v1/revision", () => ({
- getRevisionType: (type: number) => `type-${type}`,
- revisionLink: (revision: { name: string }) => `/revisions/${revision.name}`,
-}));
-
-const renderIntoContainer = (element: ReturnType<typeof createElement>) => {
- const container = document.createElement("div");
- const root = createRoot(container);
-
- return {
- container,
- render: (nextElement = element) => {
- act(() => {
- root.render(nextElement);
- });
- },
- unmount: () =>
- act(() => {
- root.unmount();
- }),
- };
-};
-
-const flush = async () => {
- await act(async () => {
- await Promise.resolve();
- await Promise.resolve();
- });
-};
-
-const click = (element: HTMLElement) => {
- act(() => {
- element.dispatchEvent(
- new MouseEvent("click", { bubbles: true, cancelable: true })
- );
- });
-};
-
-const makeDatabase = (): Database =>
- ({
- name: "instances/inst1/databases/db1",
- project: "projects/proj1",
- }) as Database;
-
-beforeEach(async () => {
- mocks.useTranslation.mockReset();
- mocks.useTranslation.mockReturnValue({
- t: (key: string) => key,
- });
- mocks.confirm.mockReset();
- mocks.confirm.mockReturnValue(true);
- mocks.localStorage.clear.mockReset();
- mocks.localStorage.getItem.mockReset();
- mocks.localStorage.getItem.mockReturnValue(null);
- mocks.localStorage.removeItem.mockReset();
- mocks.localStorage.setItem.mockReset();
- mocks.listRevisions.mockReset();
- mocks.listRevisions.mockResolvedValue({
- nextPageToken: "",
- revisions: [
- {
- name: "instances/inst1/databases/db1/revisions/1",
- version: "1.0.0",
- type: Revision_Type.VERSIONED,
- } as Revision,
- ],
- });
- mocks.deleteRevision.mockReset();
- mocks.deleteRevision.mockResolvedValue(undefined);
- mocks.appRenderers.length = 0;
- mocks.createApp.mockReset();
- mocks.createApp.mockImplementation(
- (appDefinition: { render: () => unknown }) => {
- return {
- use() {
- return this;
- },
- mount() {
- mocks.appRenderers.push(
- appDefinition.render as () => {
- component: unknown;
- props: Record<string, unknown>;
- }
- );
- },
- unmount: vi.fn(),
- };
- }
- );
-
- vi.resetModules();
- ({ DatabaseRevisionPanel } = await import("./DatabaseRevisionPanel"));
-});
-
-describe("DatabaseRevisionPanel", () => {
- test("opens the legacy revision drawer and refreshes after create", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseRevisionPanel, {
- database: makeDatabase(),
- })
- );
-
- render();
- await flush();
-
- // Vue mount is lazy — not created until the drawer first opens
- expect(mocks.createApp).toHaveBeenCalledTimes(0);
-
- const importButton = Array.from(container.querySelectorAll("button")).find(
- (button) => button.textContent === "common.import"
- ) as HTMLButtonElement | undefined;
- expect(importButton).toBeDefined();
-
- click(importButton as HTMLButtonElement);
- await flush();
-
- // After clicking Import, the Vue drawer mount is created
- expect(mocks.createApp).toHaveBeenCalledTimes(1);
-
- const latestDrawerVNode = mocks.appRenderers.at(-1)?.();
- expect(latestDrawerVNode).toMatchObject({
- component: mocks.CreateRevisionDrawer,
- props: expect.objectContaining({
- database: "instances/inst1/databases/db1",
- show: true,
- }),
- });
-
- act(() => {
- (latestDrawerVNode?.props["onCreated"] as (() => void) | undefined)?.();
- });
- await flush();
-
- expect(mocks.listRevisions).toHaveBeenCalledTimes(2);
- // Vue mount stays alive after closing (lazy-mounted, never unmounted)
- expect(mocks.createApp).toHaveBeenCalledTimes(1);
- expect(mocks.appRenderers.at(-1)?.()).toMatchObject({
- component: mocks.CreateRevisionDrawer,
- props: expect.objectContaining({
- show: false,
- }),
- });
-
- unmount();
- });
-
- test("refreshes the revision list after delete", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseRevisionPanel, {
- database: makeDatabase(),
- })
- );
-
- render();
- await flush();
-
- expect(container.querySelector("table")).not.toBeNull();
- expect(container.textContent).toContain("1.0.0");
-
- const deleteButton = Array.from(container.querySelectorAll("button")).find(
- (button) =>
- button.dataset.name === "instances/inst1/databases/db1/revisions/1"
- ) as HTMLButtonElement | undefined;
- expect(deleteButton).toBeDefined();
-
- click(deleteButton as HTMLButtonElement);
- await flush();
-
- expect(mocks.confirm).toHaveBeenCalledWith(
- "database.revision.delete-confirm-dialog"
- );
- expect(mocks.deleteRevision).toHaveBeenCalledWith(
- "instances/inst1/databases/db1/revisions/1"
- );
- expect(mocks.listRevisions).toHaveBeenCalledTimes(2);
-
- unmount();
- });
-});
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx
index 4c563fcaad..aaaad915e2 100644
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx
+++ b/frontend/src/react/pages/project/database-detail/panels/DatabaseRevisionPanel.tsx
@@ -4,6 +4,7 @@ import { useCallback, useEffect, useRef, useState } from "react";
import { useTranslation } from "react-i18next";
import { createApp, h, reactive } from "vue";
import { themeOverrides } from "@/../naive-ui.config";
+import BBOverlayStack from "@/components/misc/OverlayStackManager.vue";
import CreateRevisionDrawer from "@/components/Revision/CreateRevisionDrawer.vue";
import { revisionServiceClientConnect } from "@/connect";
import i18n from "@/plugins/i18n";
@@ -60,12 +61,19 @@ function VueCreateRevisionDrawerMount({
{ themeOverrides: themeOverrides.value },
{
default: () =>
- h(CreateRevisionDrawer as never, {
- database: bridgeState.databaseName,
- show: bridgeState.open,
- "onUpdate:show": bridgeState.onOpenChange,
- onCreated: bridgeState.onCreated,
- }),
+ h(
+ BBOverlayStack as never,
+ {},
+ {
+ default: () =>
+ h(CreateRevisionDrawer as never, {
+ database: bridgeState.databaseName,
+ show: bridgeState.open,
+ "onUpdate:show": bridgeState.onOpenChange,
+ onCreated: bridgeState.onCreated,
+ }),
+ }
+ ),
}
);
},
diff --git a/frontend/src/react/pages/project/database-detail/panels/DatabaseSettingsPanel.test.tsx b/frontend/src/react/pages/project/database-detail/panels/DatabaseSettingsPanel.test.tsx
deleted file mode 100644
index d7ecbb18fe..0000000000
--- a/frontend/src/react/pages/project/database-detail/panels/DatabaseSettingsPanel.test.tsx
+++ /dev/null
@@ -1,420 +0,0 @@
-import { act, createElement } from "react";
-import { createRoot } from "react-dom/client";
-import { beforeEach, describe, expect, test, vi } from "vitest";
-import type { Database } from "@/types/proto-es/v1/database_service_pb";
-
-(
- globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
-).IS_REACT_ACT_ENVIRONMENT = true;
-
-const mocks = vi.hoisted(() => ({
- useTranslation: vi.fn(() => ({
- t: (key: string) => key,
- })),
- updateDatabase: vi.fn(),
- pushNotification: vi.fn(),
- hasProjectPermissionV2: vi.fn(() => true),
- getDatabaseProject: vi.fn((database: { project: string }) => ({
- name: database.project,
- })),
- getInstanceResource: vi.fn(
- (database: { instanceResource?: { environment?: string } }) =>
- database.instanceResource ?? { environment: "" }
- ),
- EnvironmentSelect: vi.fn(
- ({
- value,
- onChange,
- disabled,
- className,
- clearable,
- renderSuffix,
- }: {
- value: string;
- onChange: (value: string) => void;
- disabled?: boolean;
- className?: string;
- clearable?: boolean;
- renderSuffix?: (environment: { name: string }) => React.ReactNode;
- }) => (
- <div data-testid="environment-select-wrapper" className={className}>
- <select
- data-testid="environment-select"
- value={value}
- disabled={disabled}
- onChange={(event) => onChange(event.target.value)}
- >
- <option value="">none</option>
- <option value="environments/dev">Dev</option>
- <option value="environments/test">Test</option>
- </select>
- <div data-testid="environment-option-environments/dev">
- Dev {renderSuffix?.({ name: "environments/dev" })}
- </div>
- <div data-testid="environment-option-environments/test">
- Test {renderSuffix?.({ name: "environments/test" })}
- </div>
- {clearable && (
- <button
- type="button"
- data-testid="environment-clear"
- onClick={() => onChange("")}
- >
- clear
- </button>
- )}
- </div>
- )
- ),
-}));
-
-let DatabaseSettingsPanel: typeof import("./DatabaseSettingsPanel").DatabaseSettingsPanel;
-
-vi.mock("react-i18next", () => ({
- useTranslation: mocks.useTranslation,
-}));
-
-vi.mock("@/react/components/EnvironmentSelect", () => ({
- EnvironmentSelect: mocks.EnvironmentSelect,
-}));
-
-vi.mock("@/react/components/ui/button", () => ({
- Button: (props: React.ButtonHTMLAttributes<HTMLButtonElement>) => (
- <button {...props} />
- ),
-}));
-
-vi.mock("@/react/components/ui/input", () => ({
- Input: (props: React.InputHTMLAttributes<HTMLInputElement>) => (
- <input {...props} />
- ),
-}));
-
-vi.mock("@/store", () => ({
- pushNotification: mocks.pushNotification,
- useDatabaseV1Store: () => ({
- updateDatabase: mocks.updateDatabase,
- }),
-}));
-
-vi.mock("@/utils", () => ({
- convertLabelsToKVList: (labels: Record<string, string>, sort = true) => {
- const list = Object.keys(labels).map((key) => ({
- key,
- value: labels[key],
- }));
- return sort ? list.sort((a, b) => a.key.localeCompare(b.key)) : list;
- },
- convertKVListToLabels: (
- list: { key: string; value: string }[],
- omitEmpty = true
- ) => {
- return list.reduce<Record<string, string>>((labels, kv) => {
- if (!kv.value && omitEmpty) {
- return labels;
- }
- labels[kv.key] = kv.value;
- return labels;
- }, {});
- },
- MAX_LABEL_VALUE_LENGTH: 63,
- getDatabaseProject: mocks.getDatabaseProject,
- getInstanceResource: mocks.getInstanceResource,
- hasProjectPermissionV2: mocks.hasProjectPermissionV2,
-}));
-
-const renderIntoContainer = (element: ReturnType<typeof createElement>) => {
- const container = document.createElement("div");
- const root = createRoot(container);
-
- return {
- container,
- render: (nextElement = element) => {
- act(() => {
- root.render(nextElement);
- });
- },
- unmount: () =>
- act(() => {
- root.unmount();
- }),
- };
-};
-
-const flush = async () => {
- await act(async () => {
- await Promise.resolve();
- await Promise.resolve();
- });
-};
-
-const setInputValue = (input: HTMLInputElement, value: string) => {
- act(() => {
- const descriptor = Object.getOwnPropertyDescriptor(
- HTMLInputElement.prototype,
- "value"
- );
- descriptor?.set?.call(input, value);
- input.dispatchEvent(new Event("input", { bubbles: true }));
- input.dispatchEvent(new Event("change", { bubbles: true }));
- });
-};
-
-const changeSelectValue = (select: HTMLSelectElement, value: string) => {
- act(() => {
- const descriptor = Object.getOwnPropertyDescriptor(
- HTMLSelectElement.prototype,
- "value"
- );
- descriptor?.set?.call(select, value);
- select.dispatchEvent(new Event("change", { bubbles: true }));
- });
-};
-
-const click = (element: HTMLElement) => {
- act(() => {
- element.dispatchEvent(
- new MouseEvent("click", { bubbles: true, cancelable: true })
- );
- });
-};
-
-const makeDatabase = (
- overrides: Partial<{
- name: string;
- project: string;
- environment: string;
- effectiveEnvironment: string;
- labels: Record<string, string>;
- instanceResource: {
- environment?: string;
- };
- }> = {}
-) =>
- ({
- name: "instances/inst1/databases/db1",
- project: "projects/proj1",
- environment: "",
- effectiveEnvironment: "environments/dev",
- labels: {},
- instanceResource: {
- environment: "",
- },
- ...overrides,
- }) as Database;
-
-beforeEach(async () => {
- mocks.useTranslation.mockReset();
- mocks.useTranslation.mockReturnValue({
- t: (key: string) => key,
- });
- mocks.updateDatabase.mockReset();
- mocks.updateDatabase.mockResolvedValue(undefined);
- mocks.pushNotification.mockReset();
- mocks.hasProjectPermissionV2.mockReset();
- mocks.hasProjectPermissionV2.mockReturnValue(true);
- mocks.getDatabaseProject.mockReset();
- mocks.getDatabaseProject.mockImplementation(
- (database: { project: string }) => ({
- name: database.project,
- })
- );
- mocks.getInstanceResource.mockReset();
- mocks.getInstanceResource.mockImplementation(
- (database: { instanceResource?: { environment?: string } }) =>
- database.instanceResource ?? { environment: "" }
- );
- mocks.EnvironmentSelect.mockClear();
-
- vi.resetModules();
- ({ DatabaseSettingsPanel } = await import("./DatabaseSettingsPanel"));
-});
-
-describe("DatabaseSettingsPanel", () => {
- test("updates the database environment", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseSettingsPanel, {
- database: makeDatabase(),
- })
- );
-
- render();
-
- const select = container.querySelector(
- '[data-testid="environment-select"]'
- ) as HTMLSelectElement | null;
- expect(select).not.toBeNull();
-
- changeSelectValue(select as HTMLSelectElement, "environments/test");
- await flush();
-
- expect(mocks.updateDatabase).toHaveBeenCalledWith(
- expect.objectContaining({
- database: expect.objectContaining({
- environment: "environments/test",
- }),
- updateMask: expect.objectContaining({
- paths: ["environment"],
- }),
- })
- );
- expect(mocks.pushNotification).toHaveBeenCalledWith(
- expect.objectContaining({
- style: "SUCCESS",
- title: "common.updated",
- })
- );
-
- unmount();
- });
-
- test("saves edited labels through the shared React label editor", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseSettingsPanel, {
- database: makeDatabase({
- labels: { team: "dba" },
- }),
- })
- );
-
- render();
-
- const valueInput = Array.from(container.querySelectorAll("input")).find(
- (input) => (input as HTMLInputElement).value === "dba"
- ) as HTMLInputElement | undefined;
- expect(valueInput).toBeDefined();
-
- setInputValue(valueInput as HTMLInputElement, "platform");
- await flush();
-
- const saveButton = Array.from(container.querySelectorAll("button")).find(
- (button) => button.textContent === "common.save"
- ) as HTMLButtonElement | undefined;
- expect(saveButton).toBeDefined();
-
- click(saveButton as HTMLButtonElement);
- await flush();
-
- expect(mocks.updateDatabase).toHaveBeenCalledWith(
- expect.objectContaining({
- database: expect.objectContaining({
- labels: { team: "platform" },
- }),
- updateMask: expect.objectContaining({
- paths: ["labels"],
- }),
- })
- );
- expect(mocks.pushNotification).toHaveBeenCalledWith(
- expect.objectContaining({
- style: "SUCCESS",
- title: "common.updated",
- })
- );
-
- unmount();
- });
-
- test("blocks label save when the value exceeds the shared max length", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseSettingsPanel, {
- database: makeDatabase({
- labels: { team: "dba" },
- }),
- })
- );
-
- render();
-
- const valueInput = Array.from(container.querySelectorAll("input")).find(
- (input) => (input as HTMLInputElement).value === "dba"
- ) as HTMLInputElement | undefined;
- expect(valueInput).toBeDefined();
-
- setInputValue(valueInput as HTMLInputElement, "x".repeat(64));
- await flush();
-
- const saveButton = Array.from(container.querySelectorAll("button")).find(
- (button) => button.textContent === "common.save"
- ) as HTMLButtonElement | undefined;
- expect(saveButton).toBeDefined();
- expect((saveButton as HTMLButtonElement).disabled).toBe(true);
- expect(container.textContent).toContain(
- "label.error.max-value-length-exceeded"
- );
-
- click(saveButton as HTMLButtonElement);
- await flush();
-
- expect(mocks.updateDatabase).not.toHaveBeenCalled();
-
- unmount();
- });
-
- test("clears the environment to an empty string when the instance has no default environment", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseSettingsPanel, {
- database: makeDatabase({
- effectiveEnvironment: "environments/dev",
- environment: "environments/dev",
- instanceResource: {
- environment: "",
- },
- }),
- })
- );
-
- render();
-
- const clearButton = container.querySelector(
- '[data-testid="environment-clear"]'
- ) as HTMLButtonElement | null;
- expect(clearButton).not.toBeNull();
-
- click(clearButton as HTMLButtonElement);
- await flush();
-
- expect(mocks.updateDatabase).toHaveBeenCalledWith(
- expect.objectContaining({
- database: expect.objectContaining({
- environment: "",
- }),
- updateMask: expect.objectContaining({
- paths: ["environment"],
- }),
- })
- );
-
- unmount();
- });
-
- test("marks the instance default environment inside the selector and disables clearing when inherited", async () => {
- const { container, render, unmount } = renderIntoContainer(
- createElement(DatabaseSettingsPanel, {
- database: makeDatabase({
- effectiveEnvironment: "environments/test",
- environment: "environments/test",
- instanceResource: {
- environment: "environments/dev",
- },
- }),
- })
- );
-
- render();
-
- expect(container.textContent).toContain("common.default");
- expect(mocks.EnvironmentSelect).toHaveBeenCalledWith(
- expect.objectContaining({
- clearable: false,
- renderSuffix: expect.any(Function),
- }),
- undefined
- );
- expect(
- container.querySelector('[data-testid="environment-clear"]')
- ).toBeNull();
-
- unmount();
- });
-});