Skip to content

Database governance built for humans and agents — controlling changes and access across every major database.

fix(plan): handle release plan detail correctly (#19936)

boojack724678bc9a4d
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/issue.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/issue.ts
index c357bd7382..ea58106a55 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/issue.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/actions/issue.ts
@@ -15,6 +15,7 @@ export const ISSUE_CREATE: ActionDefinition = {
isVisible: (ctx) =>
!ctx.isIssueOnly &&
+ !ctx.isReleasePlan &&
ctx.plan.issue === "" &&
!ctx.plan.hasRollout &&
ctx.planState === State.ACTIVE,
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts
index 154c99607f..10bd0c0001 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/context.ts
@@ -174,6 +174,11 @@ export function buildActionContext(input: ContextBuilderInput): ActionContext {
const isExportPlan = plan.specs.some(
(spec) => spec.config?.case === "exportDataConfig"
);
+ const isReleasePlan = plan.specs.some(
+ (spec) =>
+ spec.config?.case === "changeDatabaseConfig" &&
+ !!spec.config.value.release
+ );
// Plans where rollout is created on-demand when user clicks action button
const hasDeferredRollout = plan.specs.some(
(spec) =>
@@ -254,6 +259,7 @@ export function buildActionContext(input: ContextBuilderInput): ActionContext {
isCreating,
isIssueOnly,
isExportPlan,
+ isReleasePlan,
hasDeferredRollout,
isCreator,
issueApproved,
diff --git a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts
index fbdb039c8e..6617ada71d 100644
--- a/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts
+++ b/frontend/src/components/Plan/components/HeaderSection/Actions/registry/types.ts
@@ -70,6 +70,7 @@ export interface ActionContext {
isCreating: boolean;
isIssueOnly: boolean;
isExportPlan: boolean;
+ isReleasePlan: boolean;
// Plans where rollout is created on-demand (export, create database)
hasDeferredRollout: boolean;
isCreator: boolean;
diff --git a/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue b/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue
index a86d68dba1..4c019747ab 100644
--- a/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue
+++ b/frontend/src/components/Plan/components/IssueReviewView/DatabaseChangeView/DatabaseChangeView.vue
@@ -4,7 +4,7 @@
<SpecTabs v-model:selected-spec-id="selectedSpecId">
<div v-if="selectedSpec" class="flex flex-col gap-2">
<TargetListSection />
- <div class="h-72 flex flex-col">
+ <div class="flex flex-col" :class="isReleaseView ? '' : 'h-72'">
<StatementSection header-variant="section" />
</div>
<OptionsSection />
@@ -38,6 +38,13 @@ const selectedSpec = computed(() => {
return plan.value.specs.find((spec) => spec.id === selectedSpecId.value);
});
+const isReleaseView = computed(() => {
+ return (
+ selectedSpec.value?.config?.case === "changeDatabaseConfig" &&
+ !!selectedSpec.value.config.value.release
+ );
+});
+
provideSelectedSpec(
computed(() => {
const spec = selectedSpec.value;