Database governance built for humans and agents — controlling changes and access across every major database.
Go cicddata-governancedata-maskingdata-securitydatabase-accessdatabase-governancedevopsdevsecopsflywaygitopsliquibasemongodbmysqloraclepostgresqlschema-migrationssecuritysql-clientsqlservertidb
chore(migrator): remove 7 SELECT-only rules from review_config payload (BYT-9784) (#20697)
rebelice7833baca485e
diff --git a/backend/migrator/migration/3.20/0002##remove_select_only_sql_review_rules.sql b/backend/migrator/migration/3.20/0002##remove_select_only_sql_review_rules.sqlnew file mode 100644index 0000000000..9fcd054cf8--- /dev/null+++ b/backend/migrator/migration/3.20/0002##remove_select_only_sql_review_rules.sql@@ -0,0 +1,51 @@+-- Remove 7 SELECT-only SQL review rules from review configurations.+--+-- Context: These rules only triggered on SELECT statements and served no purpose+-- in the DDL/DML change review workflow. Their proto enum values have been reserved+-- in PR #20685 (BYT-9784), so existing payloads referencing these type names must+-- be cleaned up to avoid protojson unmarshal failures.+--+-- Removed rules:+-- STATEMENT_SELECT_FULL_TABLE_SCAN+-- STATEMENT_QUERY_MINIMUM_PLAN_LEVEL+-- STATEMENT_DISALLOW_USING_FILESORT+-- STATEMENT_DISALLOW_USING_TEMPORARY+-- STATEMENT_MAXIMUM_JOIN_TABLE_COUNT+-- STATEMENT_JOIN_STRICT_COLUMN_ATTRS+-- STATEMENT_MAXIMUM_LIMIT_VALUE++UPDATE review_config+SET payload = jsonb_set(+ payload,+ '{sqlReviewRules}',+ COALESCE(+ (+ SELECT jsonb_agg(rule)+ FROM jsonb_array_elements(payload->'sqlReviewRules') AS rule+ WHERE (rule->>'type') NOT IN (+ 'STATEMENT_SELECT_FULL_TABLE_SCAN',+ 'STATEMENT_QUERY_MINIMUM_PLAN_LEVEL',+ 'STATEMENT_DISALLOW_USING_FILESORT',+ 'STATEMENT_DISALLOW_USING_TEMPORARY',+ 'STATEMENT_MAXIMUM_JOIN_TABLE_COUNT',+ 'STATEMENT_JOIN_STRICT_COLUMN_ATTRS',+ 'STATEMENT_MAXIMUM_LIMIT_VALUE'+ )+ ),+ '[]'::jsonb+ )+)+WHERE payload ? 'sqlReviewRules'+ AND EXISTS (+ SELECT 1+ FROM jsonb_array_elements(payload->'sqlReviewRules') AS rule+ WHERE (rule->>'type') IN (+ 'STATEMENT_SELECT_FULL_TABLE_SCAN',+ 'STATEMENT_QUERY_MINIMUM_PLAN_LEVEL',+ 'STATEMENT_DISALLOW_USING_FILESORT',+ 'STATEMENT_DISALLOW_USING_TEMPORARY',+ 'STATEMENT_MAXIMUM_JOIN_TABLE_COUNT',+ 'STATEMENT_JOIN_STRICT_COLUMN_ATTRS',+ 'STATEMENT_MAXIMUM_LIMIT_VALUE'+ )+ );diff --git a/backend/migrator/migrator_test.go b/backend/migrator/migrator_test.goindex 2a681ae6f5..f73b09ba41 100644--- a/backend/migrator/migrator_test.go+++ b/backend/migrator/migrator_test.go@@ -15,8 +15,8 @@ import (func TestLatestVersion(t *testing.T) {files, err := getSortedVersionedFiles()require.NoError(t, err)- require.Equal(t, semver.MustParse("3.20.1"), *files[len(files)-1].version)- require.Equal(t, "migration/3.20/0001##rename_maximum_request_expiration.sql", files[len(files)-1].path)+ require.Equal(t, semver.MustParse("3.20.2"), *files[len(files)-1].version)+ require.Equal(t, "migration/3.20/0002##remove_select_only_sql_review_rules.sql", files[len(files)-1].path)}func TestVersionUnique(t *testing.T) {